Author Topic: Canon EOS M  (Read 1060605 times)

dfort

  • Developer
  • Hero Member
  • *****
  • Posts: 3751
Re: Canon EOS M
« Reply #2225 on: February 17, 2019, 03:35:34 AM »
Those are focus pixels. They can be removed in post. Working on it.


Sent from my iPhone using Tapatalk
5D3.* 7D.206 700D.115 EOSM.203 EOSM2.103 M50.102

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1637
Re: Canon EOS M
« Reply #2226 on: February 17, 2019, 09:57:03 AM »
Hi Danne, light is back, so I tried out your build now. But it looks not as expected:
-rewire=old: no red line
-rewire=off, -2+2=no red line
-rewire=off, +0-0/-1+1=red line
-rewire=off, +1-1/+2-2=red line + one white line
-rewire=off, +3-3/+4-4=red line + two white lines
-rewire=off, +5-5/+6-6=red line + three white lines
Moiree looks always identical (better than yesterday, but can't compare to Feb15). But I don't find stair effects.
5D3.113 | EOSM.202

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6830
Re: Canon EOS M
« Reply #2227 on: February 17, 2019, 10:07:04 AM »
Try refreshing after enabling "old" by opening canon menu and also maybe ml menu.
Tested this morning and it´s not possible to reproduce any issues. What happens is that aliasing can be produced differently but that has more to do with focus, not with ratio changes.

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1637
Re: Canon EOS M
« Reply #2228 on: February 17, 2019, 10:26:42 AM »
Okay... got it reproduced, but not as expected. Will shorten the files and upload. Best by far is rewire=Off, -2+2. ;)
5D3.113 | EOSM.202

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1637
Re: Canon EOS M
« Reply #2229 on: February 17, 2019, 10:45:51 AM »
The only two settings without bottom line are rewire=old and rewire=off-2+2. But in rewire=old I get stairs, hard focus pixels and more artifacts. So in this build I prefere rewire=Off, reg_skip_top=-2, reg_skip_bottom=+2.

You'll find a png with some marked areas in the frame where I looked at details and my receipt file.
https://www.dropbox.com/s/wddfxe3p7zmdsn1/RewireTestrun.zip?dl=0
5D3.113 | EOSM.202

jacquaviva

  • New to the forum
  • *
  • Posts: 17
Re: Canon EOS M
« Reply #2230 on: February 17, 2019, 11:29:08 AM »
Thank you Dfort. I can get rid of focus pixels by using the debayer amaze in MLVapp, but can't use it by exporting to dng sequence. How to ?

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6830
Re: Canon EOS M
« Reply #2231 on: February 17, 2019, 11:32:51 AM »
Set chroma smooth to 3x3.

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6830
Re: Canon EOS M
« Reply #2232 on: February 17, 2019, 11:50:46 AM »
@masc
Settings right now if test_rewire is set to off:
Code: [Select]
        skip_top = 84;
        skip_right = 60;
    skip_bottom = 0;

Let´s apply your optimised setting "So in this build I prefere rewire=Off, reg_skip_top=-2, reg_skip_bottom=+2.":
Code: [Select]
        skip_top = 82;
        skip_right = 60;
    skip_bottom = 2;

Only one problem. The first commit after noticing the thin red line was exactly the setting above:
https://bitbucket.org/Dannephoto/magic-lantern/commits/5cb143d56c2dcb9a16f27c5094e4f8f1ee8fb52b

Your comment to that commit:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg212152#msg212152

So, I revert back to the first commit as long as we all agree this problem is not as easy as we first thought? Any other thoughts?

Also note that when test_rewire is set to old it´s the exact lines as with the build before any thin redline fixes were applied(same as february 15th).

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1637
Re: Canon EOS M
« Reply #2233 on: February 17, 2019, 12:05:46 PM »
Very strange. Do we have a kind of sign error somewhere? Don't understand all this at all.
5D3.113 | EOSM.202

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6830
Re: Canon EOS M
« Reply #2234 on: February 17, 2019, 12:40:42 PM »
Placebo?
Anyway. Here´s a build with your proposed settings working best:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg208959#msg208959

Here is the feb 15th build compiled exactly before the thin red line fix in commit tree(compiled today and renamed):
https://bitbucket.org/Dannephoto/magic-lantern/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Feb15.EOSM202.zip

jacquaviva

  • New to the forum
  • *
  • Posts: 17
Re: Canon EOS M
« Reply #2235 on: February 17, 2019, 12:42:49 PM »
Thank you, chroma smoothing works with dng out.
Danne, is there a way to save crop mode activated when booting the camera. I always have to switch it on again. Thanks

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6830
Re: Canon EOS M
« Reply #2236 on: February 17, 2019, 12:50:05 PM »
Yes, you can enable it but I havn´t found a way to disable it when changing presets in crop rec once it´s enabled. In crop_rec.c put in this at the top:
Code: [Select]
#include "crop-mode-hack.h"
Then inside static int crop_rec_needs_lv_refresh(): in crop_rec.c put in following:
Code: [Select]
if (crop_preset == CROP_PRESET_mcm_mv1080_EOSM)
{
        movie_crop_hack_enable();
}

Compile.

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1637
Re: Canon EOS M
« Reply #2237 on: February 17, 2019, 01:07:26 PM »
Placebo?
Anyway. Here´s a build with your proposed settings working best:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg208959#msg208959

Here is the feb 15th build compiled exactly before the thin red line fix in commit tree(compiled today and renamed):
https://bitbucket.org/Dannephoto/magic-lantern/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Feb15.EOSM202.zip

No, don't think so. The "stairs" are very easy to identify at 45° edges, same for the red line. But what happened for your "rewire=old" preset? Why activates it the stairs, and -2+2 doesn't. And all this does not fit to yesterdays build. Something must be wrong.

Will test again the posted builds.
5D3.113 | EOSM.202

jacquaviva

  • New to the forum
  • *
  • Posts: 17
Re: Canon EOS M
« Reply #2238 on: February 17, 2019, 01:15:20 PM »
Thanks Danne, I don't know to compile but I'll figure it out.
Thanks you again for this work !

One question about MLVapp, is there a way to set by default 3x3 chroma smoothing, I have to set it for each MLV file.

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1637
Re: Canon EOS M
« Reply #2239 on: February 17, 2019, 01:27:21 PM »
@Danne:
I expect indeed a sign error somewhere. I again tested the first build after the red line (the one with the stairs). Reproduced all I saw yesterday. BUT: reg_skip_top=-4 and reg_skip_bottom=+4 looks perfect ;)
What happens for:
Code: [Select]
        skip_top = 86;
        skip_right = 60;
    skip_bottom = -2;

@jacquaviva
Activate it once for one clip, Ctrl+C (maybe activate in mask chroma smoothing only), Ctrl+A, Ctrl+V.
5D3.113 | EOSM.202

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6830
Re: Canon EOS M
« Reply #2240 on: February 17, 2019, 01:39:10 PM »
-4, +4, link or name of build used?
What's a "sign error"?

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1637
Re: Canon EOS M
« Reply #2241 on: February 17, 2019, 01:45:10 PM »
Build used is: crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Feb17.EOSM202
-4+4 looks perfect. Registers have 82 and 2 by default, you wrote

Build before:
-2+2 looked perfect. Registers were 84 and 0 by default.

So I think the math behind is not default+offset, it is default-offset. The algebraic sign (+ instead of -) should be wrong - or I am... confusing...  :P

So I would try 86 and -2 next.
5D3.113 | EOSM.202

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6830
Re: Canon EOS M
« Reply #2242 on: February 17, 2019, 02:33:33 PM »
Build used is: crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Feb17.EOSM202
-4+4 looks perfect. Registers have 82 and 2 by default, you wrote
-4+4 equals:
Code: [Select]
        skip_top = 78;
        skip_right = 60;
    skip_bottom = 6;

86 and -2 as suggested would become
Code: [Select]
        skip_top = 86;
        skip_right = 60;
    skip_bottom = -2;
And then we have a fat white border at the bottom.

We need to shave at minimum 2 at the bottom to get rid of the bottom pixels:
Code: [Select]
    skip_bottom = 2;Since default skip_top is 72 we can safely add back what´s shaved at the bottom since we here start at:
Code: [Select]
    skip_top = 84; so decreasing to 82 will keep us at 1736x976(16:9):
Code: [Select]
        skip_top = 82;
        skip_right = 60;
    skip_bottom = 2;

I cannot reproduce the issue described so I really suggest you download my branch and get right into crop_rec.c and compile crop_rec.mo with any optimised settings you come up with. It´s easy with Compiler.app. Just get into the modules area and find this menu:

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1637
Re: Canon EOS M
« Reply #2243 on: February 17, 2019, 02:47:15 PM »
-4+4 equals:
Code: [Select]
        skip_top = 78;
        skip_right = 60;
    skip_bottom = 6;
...if the register screen does what we think it does...
86 and -2 as suggested would become
Code: [Select]
        skip_top = 86;
        skip_right = 60;
    skip_bottom = -2;
And then we have a fat white border at the bottom.
Have you tried out? Oh man... I really don't understand what happens here.
I cannot reproduce the issue described so I really suggest you download my branch and get right into crop_rec.c and compile crop_rec.mo with any optimised settings you come up with. It´s easy with Compiler.app.
What a shame it seems I am the only one getting this. Unfortunately I am here with OSX 10.9, which is not supported by your compiler app (or by brew).
5D3.113 | EOSM.202

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6830
Re: Canon EOS M
« Reply #2244 on: February 17, 2019, 02:57:00 PM »
Yes, tested.
It is not evident what to look for to me. But general tests on static scenes I cannot see anything significant and judging from that we can get different results from same builds and commits it suggests it´s a problem somewhere else.

Why isn´t compiler.app working? Can you try double clicking the main.command inside Compiler.app/Contents/?

You might wanna give the command admin rights:
Code: [Select]
chmod u=rwx main.command

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1637
Re: Canon EOS M
« Reply #2245 on: February 17, 2019, 03:08:56 PM »
Brew isn't supported on OSX 10.9 (or the packages needed). So no chance for your app. It won't install anything.
5D3.113 | EOSM.202

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6830
Re: Canon EOS M
« Reply #2246 on: February 17, 2019, 03:12:17 PM »
Ok, reproduced. Wtf! Some alignment issue:


82, 0


-4, +4



82, 0


-4, +4



Brew for 10.9?
https://coolestguidesontheplanet.com/setting-up-os-x-mavericks-and-homebrew/


EDIT:
Tested again and cannot reproduce it now. Crazy. Can´t make sense of it.

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1637
Re: Canon EOS M
« Reply #2247 on: February 17, 2019, 03:44:59 PM »
Yes, that looks like what I see here. Best use a wideangle lens where a lot is in focus. Then search trees and hard contrast edges at 45°. Very easy to reproduce this way.
5D3.113 | EOSM.202

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6830
Re: Canon EOS M
« Reply #2248 on: February 17, 2019, 04:37:35 PM »
I did a slight change and it seemed to be enough. Is this version working for your wide angle lens?
https://bitbucket.org/Dannephoto/magic-lantern/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Feb17.EOSM202.zip

Code: [Select]
        skip_top = 81;
        skip_right = 60;
    skip_bottom = 3;

DeafEyeJedi

  • Hero Member
  • *****
  • Posts: 3397
  • 5D3 | M1 | 7D | 70D | SL1 | M2 | 50D
Re: Canon EOS M
« Reply #2249 on: February 17, 2019, 05:30:53 PM »
Tying to reproduce this w both 10mm 2.8 & 11-20mm 2.8 lenses to no avail. I don’t blame you guys for this strangeness though. I’m pointing at a white wall w a fan (to show /aliasing/moire effects) and will try again w the latest build from 50 mins ago.
5D3.113 | 5D3.123 | EOSM.203 | 7D.203 | 70D.112 | 100D.101 | EOSM2.* | 50D.109