Author Topic: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)  (Read 135904 times)

hyalinejim

  • Member
  • ***
  • Posts: 127
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #175 on: November 14, 2016, 10:25:17 AM »
You are the man, a1ex! This is a great aid for getting precise rectilinear compositions at higher resolutions. Prior to this it was like trying to use a shift lens in the horizontally offset position. It's also a boon for those wishing to use anamorphics without one side being heavily vignetted.

a1ex

  • Administrator
  • Hero Member
  • *****
  • Posts: 12322
  • Emergencies only
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #176 on: November 14, 2016, 10:51:07 AM »
Ouch, not exactly the easiest workaround.

2nd thing i "noticed" is that 1:1 mode is extremely overexposed compared to 3x3

I've just found an overexposure bug when using FPS override (actual exposure time is incorrect, usually higher than expected). Were you using it when you had the issue?

Quentin

  • Member
  • ***
  • Posts: 131
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #177 on: November 14, 2016, 11:04:41 AM »
Thanks to all people that contribute.
Any recent build with the new crop developments ?
Thank you

a1ex

  • Administrator
  • Hero Member
  • *****
  • Posts: 12322
  • Emergencies only
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #178 on: November 14, 2016, 09:12:42 PM »
Just committed the centered 5x zoom, the overexposure fix, and some refactors to ease porting to other camera models. EOS M support is included too (thanks rbrune).

Test build coming after feedback from those who understand the code :)

budafilms

  • Hero Member
  • *****
  • Posts: 711
  • 5D Mark a1ex
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #179 on: November 15, 2016, 09:13:16 PM »
Great work my King!  ;D

nikfreak

  • Developer
  • Hero Member
  • *****
  • Posts: 1139
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #180 on: November 28, 2016, 05:17:25 PM »
just discovered that you are reading out old hardcoded values for edmac_raw_slurp now automagically via the registers. Probably you will be using this technique and adding the skip values for centering x5-zoom on all cameras later, right?
70D.112 & 100D.101

DeafEyeJedi

  • Hero Member
  • *****
  • Posts: 3348
  • 5D3 | M1 | 7D | 70D | SL1 | M2 | 50D
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #181 on: November 28, 2016, 05:31:27 PM »
just discovered that you are reading out old hardcoded values for edmac_raw_slurp now automagically via the registers. Probably you will be using this technique and adding the skip values for centering x5-zoom on all cameras later, right?

+1
5D3.113 | 5D3.123 | EOSM.203 | 7D.203 | 70D.112 | 100D.101 | EOSM2.* | 50D.109

a1ex

  • Administrator
  • Hero Member
  • *****
  • Posts: 12322
  • Emergencies only
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #182 on: November 28, 2016, 05:36:19 PM »
Right, this covers all video modes without having to hardcode them.

Still need one camera-specific constant: the multiplier for horizontal resolution (I guess it's number of columns read out in parallel, and I believe it's the same for all video modes). Known range: from 1 (500D) to 8 (5D3). Also, older cameras use 0xC0F0608[04] instead of 0xC0F0680[04].

nikfreak

  • Developer
  • Hero Member
  • *****
  • Posts: 1139
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #183 on: November 28, 2016, 09:13:37 PM »
Quote
static unsigned int crop_rec_init()
{
    if (is_camera("5D3",  "1.1.3") || is_camera("5D3", "1.2.3"))
    {
        /* same addresses on both 1.1.3 and 1.2.3 */
        CMOS_WRITE = 0x119CC;
        MEM_CMOS_WRITE = 0xE92D47F0;
       
        ADTG_WRITE = 0x11640;
        MEM_ADTG_WRITE = 0xE92D47F0;

typo or unique 5D3 thingie?
70D.112 & 100D.101

a1ex

  • Administrator
  • Hero Member
  • *****
  • Posts: 12322
  • Emergencies only
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #184 on: November 28, 2016, 09:16:49 PM »
Both functions happen to start with the same instruction. Didn't check other cameras.

DeafEyeJedi

  • Hero Member
  • *****
  • Posts: 3348
  • 5D3 | M1 | 7D | 70D | SL1 | M2 | 50D
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #185 on: December 01, 2016, 11:53:53 AM »
Felt this was worth sharing.
5D3.113 | 5D3.123 | EOSM.203 | 7D.203 | 70D.112 | 100D.101 | EOSM2.* | 50D.109

Quentin

  • Member
  • ***
  • Posts: 131
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #186 on: December 18, 2016, 05:39:59 PM »
Does the latest NightBuild 18 Dec 2016, includes the new Crop mode ?

Walter Schulz

  • Contributor
  • Hero Member
  • *****
  • Posts: 6902
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #187 on: December 18, 2016, 05:46:46 PM »
?
Latest Build date is 2016Dec03.
Photogs and videographers: Assist in proof reading upcoming in-camera help!. Your input is wanted and needed!

Quentin

  • Member
  • ***
  • Posts: 131
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #188 on: December 18, 2016, 06:04:06 PM »
Dunno, maybe was withdrawn. I downloaded it but didnt test it.

Walter Schulz

  • Contributor
  • Hero Member
  • *****
  • Posts: 6902
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #189 on: December 18, 2016, 06:22:27 PM »
I doubt you downloaded something from the main branch. You should be able to determine the download link.
Something like
https://builds.magiclantern.fm/jenkins/job/<camera type>.<firmware version>/<build number>/artifact/platform/<camera type>.<firmware version>/magiclantern-Nightly.2016Dec18.<camera type><firmware version>.zip
Photogs and videographers: Assist in proof reading upcoming in-camera help!. Your input is wanted and needed!

Quentin

  • Member
  • ***
  • Posts: 131
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #190 on: December 18, 2016, 09:53:06 PM »
I have it handy.
If someone wants the today version, I dont mind sending it to him

Walter Schulz

  • Contributor
  • Hero Member
  • *****
  • Posts: 6902
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #191 on: December 18, 2016, 10:01:31 PM »
I hope it was build after g3gg0 re-edited his changes ...
Photogs and videographers: Assist in proof reading upcoming in-camera help!. Your input is wanted and needed!

Julien

  • Just arrived
  • *
  • Posts: 1
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #192 on: December 21, 2016, 02:34:50 AM »
First, Big up to all developers and all ML community including @Hans_Punk, @Danne, @a1ex, and the rest.

Second point, sorry for my level in english. It's not as well as I want.

Third, I try 3x crop mode on my 700D/T5i Rebel and it works good.
My question or better my wish, is to know if it's possible to have a variable/graduate crop mode module with ML or may be to develop this kind of possibilities?

What I mean when I talk about graduate crop mode?
With ML, 3x crop mode transform a 5O mm F1.4 lens in 150 mm for the same aperture.
I need a smaller extensions/crops like 1.4x crop or 1.6x crop or 2x crop which become 70 mm , 80 mm or 100 mm with the same 1.4 aperture.
It's like extension tubes or extender teleconverter, but numericaly with less or without loss of light in high magnification and disfraction of lights.
In fact,
 - 50mm lens + 20mm extension tubes or 1.4 extender = 70mm
   70 x f/1.4 = 98 divided by 50mm = f/1.96

What kind of utilities can we have with a graduate crop mode (x1.4/x1.6/x2)?
For instance, I use B4 2/3'' Angénieux and Fujinon lens.
Both have analogic extender (x2). The M4/3's digital camera sensor is full covered. No problem with a  Panasonic GH4 for instance.
If I use this kind of lens with my Canon T5i/700D, the APS-C sensor is not ful covered. There are small vignetting.
I think the sensor could be all covered with x1.4 or x1.2 crop.

That's why I ask this kind of new features in the developement of Magic Lantern crop mod.
Do you think it coulb be possible?

Thanks for reading

vstrglv

  • Member
  • ***
  • Posts: 185
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #193 on: December 21, 2016, 10:14:30 AM »
I have tried to merge Unified into crop_rec branch but failed. There are many conflicts. It is very useful if somebody post a tutorial how to  merge Unified into crop_rec branch, because crop_rec.mo is very, very useful.
Canon 5D3,1.1.3 CF-SanDisk Extreme PRO,160MB/s, 256GB, SD-SanDisk Extreme, 90MB/s, 64GB.

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6023
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #194 on: December 21, 2016, 10:55:05 AM »
How are you merging? Source tree? Usually I create a branch of unified then I merge crop_rec into my branch through source tree.
If you,re on mac you could post your workflow descriptions, questions and findings here.
http://www.magiclantern.fm/forum/index.php?topic=16012.msg155422#msg155422

dfort

  • Developer
  • Hero Member
  • *****
  • Posts: 3740
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #195 on: December 22, 2016, 06:18:21 PM »
Looks like this worked for @vstrglv

Code: [Select]
hg update unified
hg pull
hg branch unified_crop_rec
hg merge crop_rec
5D3.* 7D.206 700D.115 EOSM.203 EOSM2.103 M50.102

vstrglv

  • Member
  • ***
  • Posts: 185
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #196 on: December 22, 2016, 09:36:57 PM »
Yes it works! Thanks to dfort. Tested on 5D3.113, OK until now.
Canon 5D3,1.1.3 CF-SanDisk Extreme PRO,160MB/s, 256GB, SD-SanDisk Extreme, 90MB/s, 64GB.

clement2

  • New to the forum
  • *
  • Posts: 4
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #197 on: December 22, 2016, 11:27:27 PM »
Is there any chance I can get the latest build version with the last update crop mode module? I am idiot on programming. I am 5d3.113. thx.

RenatoPhoto

  • Moderators
  • Hero Member
  • *****
  • Posts: 1509
  • 5DM3 / 7D
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #198 on: December 23, 2016, 08:23:52 PM »
@ A1lex and Greg
Fantastic module!  I use it 99% of the time..  and thanks for providing it for 5D3-1.23 firmware.
Thanks for dedication and hard work.
http://www.pululahuahostal.com  |  EF 300 f/4, EF 100-400 L, EF 180 L, EF-S 10-22, Samyang 14mm, Sigma 28mm EX DG, Sigma 8mm 1:3.5 EX DG, EF 50mm 1:1.8 II, EF 1.4X II, Kenko C-AF 2X

aschille84

  • Freshman
  • **
  • Posts: 72
Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
« Reply #199 on: December 24, 2016, 12:39:04 AM »
Yes it works! Thanks to dfort. Tested on 5D3.113, OK until now.
@vstrglv Care to share a test build? Still working with crop_rec and 10/12-bit?


Sent from my iPhone using Tapatalk