Magic Lantern Forum

Developing Magic Lantern => Modules Development => Topic started by: a1ex on April 01, 2016, 08:37:14 AM

Title: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 01, 2016, 08:37:14 AM
During the last few weeks I have finally managed to sit down and implement the 3x crop mode discovered by Greg a while ago (http://www.magiclantern.fm/forum/index.php?topic=10111.msg125505#msg125505), and summarized here (http://www.magiclantern.fm/forum/index.php?topic=10111.msg145036#msg145036). This feature could be very useful for wild life, astro, or just for bragging on the forums about how cool your camera is :)

How it works?

It modifies Canon's 1080p and 720p video modes by altering the sensor area that is going to be captured. Resolution and nearly all other parameters are left unchanged.

That means:
- it works with both H.264 and RAW
- works at all usual frame rates: 24/25/30/50/60 fps (with some quirks at high FPS)
- preview, sound, overlays, HDMI out... most of the stuff should just work as expected.

Samples?

update: here's one from kgv5


Not yet, but I have a feeling DeafEyeJedi is already on it :) scroll down :)

Quirks

On 5D3 (other cameras may be different, we'll see):

- framing almost centered (only roughly checked by zooming on a test subject on the camera screen)
- 720p aspect ratio:
   - at 720p (50/60fps), we are sampling the sensor at 1:1 crop, but Canon uses a 5x3 pixel binning (http://www.magiclantern.fm/forum/index.php?topic=16516)
   - that means, H.264 video will be squashed - resize the video in post at 1280x432 or 1920x648
   - however, raw video will have 1:1 pixel ratio (not squashed, just very wide - up to 1920x632)
- there is a small black border at the top of the frame, if you record at max resolution in RAW
- it may have side effects such as sensor overheating (https://www.youtube.com/watch?v=vkHLbqhwthU), camera exploding (https://www.youtube.com/watch?v=keTDS5nbWKI) or displaying BSODs.

As usual - if it breaks, you get to keep both pieces.

Compatibility

Current implementation only works on 5D3, and I've tested it only on 1.1.3. The module is not yet compatible with current nightlies, so you need a full package (not just the module).

As you can see if you scroll down, it is possible to port this on many other cameras. It's just not very straightforward. But, on the bright side, Maqs is already eager to port it to 6D, and I'm sure others will follow.

Note that 600D and 70D already have this feature from Canon, and 650D, 700D and EOS M already have it in ML with a little hack. All other cameras could already use the crop mode when recording RAW from the 5x zoom view, but with some quirks (mainly bad preview and off-center image). So, this is nothing really new - maybe just a little more usable.

Why a separate build is needed? It's because this module uses an experimental patching library, which seemed to work fine while I wrote the code, but as soon as I took it outside (about one month ago), it crashed almost every time I used ETTR + Dual ISO. I've fixed the bug (https://bitbucket.org/hudson/magic-lantern/commits/7f147374c96bfb8a57836a4f5988a862b1bea857?at=unified) since then, but you can imagine you don't want this level of "stability" in the nightly builds.

However, this library paves the way to implementing the long-awaited ISO tweaks (http://www.magiclantern.fm/forum/index.php?topic=10111) (with real ISOs lower than 100, including a small dynamic range boost). I've also used this library as a backend for low-level tweaks such as choosing FAT32 or exFAT when formatting a card from the camera (http://www.magiclantern.fm/forum/index.php?topic=13983.0). So, let's test it and iron out all the quirks!

Downloads

- source code (https://bitbucket.org/hudson/magic-lantern/src/crop_rec/modules/crop_rec/)
- 5D3 1.1.3: magiclantern-crop3x.2016Apr01.5D3113.zip (https://builds.magiclantern.fm/jenkins/job/5D3.113-crop3x-april-1st-edition/3/artifact/platform/5D3.113/magiclantern-crop3x.2016Apr01.5D3113.zip) (build log (https://builds.magiclantern.fm/jenkins/job/5D3.113-crop3x-april-1st-edition/3/console))
- 5D3 1.2.3: magiclantern-crop3x.2016Apr01.5D3123.zip (https://builds.magiclantern.fm/jenkins/job/5D3.123-crop3x-april-1st-edition/3/artifact/platform/5D3.123/magiclantern-crop3x.2016Apr01.5D3123.zip) (build log (https://builds.magiclantern.fm/jenkins/job/5D3.123-crop3x-april-1st-edition/3/console)) (confirmed by Hans_Punk)
- other cameras: hopefully coming soon

TODO

- port it to other cameras
- merge into nightly builds

Hacking

- grab adtg_gui.mo and raw_diag.mo from the ISO research thread (http://www.magiclantern.fm/forum/index.php?topic=10111), then:
- try to understand what those registers do, and which ones need to be changed to achieve various effects
- check black bars with raw_diag, option OB zones (trigger with long half-shutter press in LV)
- optional: check DR, SNR curve, full well and read noise with raw_diag, option "SNR curve (2 shots)", trigger with "Dummy Bracket"
- take your time to read and experiment; it's very time-consuming, but once you get the hang of it, be careful - it's addictive.

Porting checklist

- clean image (without weird artifacts)
- clean turning on and off, in all the supported video modes
- clean switch to/from other modes (5x/10x zoom, other video modes, photo mode - these should not be affected)
- black bars should be larger than or equal to the values assumed in raw.c (check with raw_diag OB zones)
- centered image: put the focus box in the centered image and zoom in; the subject should not move
- menu: if there is any mode where the patch is not working, it should print a warning

Credits

Greg - original findings on 500D (http://www.magiclantern.fm/forum/index.php?topic=10111.msg125581#msg125581)
Levas - for finding the equivalent registers for 6D (http://www.magiclantern.fm/forum/index.php?topic=10111.msg125590#msg125590)
mothaibaphoto - for finding the 5D3 register values for 30/50/60 fps (http://www.magiclantern.fm/forum/index.php?topic=10111.msg162707#msg162707)
Maqs - for the lightweight code hooks (https://bitbucket.org/hudson/magic-lantern/commits/03f8872d793a137dfa8e84f14056c969d299eeda) used in the backend
g3gg0 - for laying out the foundation about ADTG registers (http://magiclantern.wikia.com/wiki/ADTG), ENGIO registers (http://magiclantern.wikia.com/wiki/Register_Map) and other low-level stuff that tends to be forgotten once it's up and running.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Hans_Punk on April 01, 2016, 10:25:05 AM
Thank you!

Works great, and can confirm crop mode works with external monitor (smallhd 501) on build 1.2.3 perfectly.
If sensor area remapping has been 'cracked' - could we ever see a APSC sub-mode crop option?

Having ability to use 'APSC only' or super 35 cine lenses without vignette on full frame without significant loss of quality would be truly outstanding.

p.s - I also noticed the April 1st screen flicker gag again  :D
Title: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on April 01, 2016, 11:04:13 AM
Not yet, but I have a feeling DeafEyeJedi is already on it :)

Just tested this on 5D3.123 (w Lexus 32GB 1000x) and confirmed all to be working. Quick video below. It's literally 2 am in here.


More in depth testing to come (w KB 128GB 1066x) and will probably post results along with some more screen flow as well!

As to be expected, I can also confirm the infamous April Fool's flicker gag once again ... There's an temporary easy-workaround to it.  ;)

Happy April, Everyone!

*edit*

Here's one shot entirely in 30p H.264 (Faithful 0,1,2,0) while shooting in crop_rec.mo w 5D3, 7D and mixed in w a rented C100II for slo-mo (Standard EOS) as well for this event:

https://vimeo.com/167454180 (Sorry fellas the couple decided to make their wedding video private)

5D3 Non Crop-Mode 35L @ ISO 3200
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm8.staticflickr.com%2F7720%2F26498249973_239b128f6d.jpg&hash=018217929b9bdf8f7580bb739c0131ff) (https://flic.kr/p/GnyswR)

5D3 Crop-Mode (1:1) 35L @ ISO 3200
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm8.staticflickr.com%2F7788%2F26498249173_45002836b1.jpg&hash=ef6b092c97c0e4c98fd9323a6b6a373e) (https://flic.kr/p/Gnysi4)

Where's DeafEyeJedi at? 7D + 6.5mm @ ISO 6400
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm8.staticflickr.com%2F7695%2F26828083700_0e8e41fa24.jpg&hash=9d125c7c06b1fea124a2c6c6d57eba12) (https://flic.kr/p/GSGWBf)

From where I was standing and just to be able to push a few buttons (preferably one) in order to get into crop-mode is priceless.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 01, 2016, 12:06:06 PM
If sensor area remapping has been 'cracked' - could we ever see a APSC sub-mode crop option?

If one figures out how to do a 2x2 pixel binning...

I remember ADTG[0x800C], on 60D and 600D IIRC, does this (see adtg_gui source, where they are documented):
Code: [Select]
    {DST_ADTG, 0x800C, 0, "Line skipping factor (2 = 1080p, 4 = 720p, 0 = zoom)"},

Let's say you adjust this line skipping register to 1 (that is, read every two lines). Now you have a little problem: you only captured two Bayer colors (either red/green or green/blue). Something like this:

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs3.postimg.cc%2Fhel956xeb%2FVRAM1.png&hash=b344a369ac5b296f9f5f41194a659840)(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs3.postimg.cc%2F5y9sa1cwj%2FVRAM0.png&hash=ba9ab517ff93bb8d7b8bba8d5756a02c)(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs3.postimg.cc%2Ffk3cqc42b%2FVRAM2.png&hash=886994fff9760f86fae1995aeed69739)
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs3.postimg.cc%2F6qcg98h3n%2FVRAM3.png&hash=80d4394056d7ffe9537ef2a64c04a9e5)(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs3.postimg.cc%2Fql3jsh2mr%2FVRAM4.png&hash=11be0f427d67fc24bad422e0950e3622)

You would need a smarter binning/skipping algorithm for 2x2 - that is, read two lines, skip two lines. Or, readout at 1:1 (good luck doing that at 24 fps) and resize in hardware (same).

And I'm afraid the binning patterns might be hardcoded in the sensor chip.

Of course, nothing stops you from fiddling with these registers, just be sure to take the battery out as soon as you suspect a burning smell coming from the sensor ;)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: squig on April 01, 2016, 12:27:40 PM
Cool. Thx a1ex.

 >:( That flicker's been driving me nuts all day. I was ready to fix it with a sledgehammer.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: GutterPump on April 01, 2016, 02:58:34 PM
Amazing feature ! Thanks to all developers :)

I expected this news for a while..

I will ask my troll question but for future builds, will we be able to go beyond 1080?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 02, 2016, 09:17:58 AM
After tinkering a bit with the registers, I've got a 3x3 binning in 720p (50/60 fps) on 5D3. This one is very easy to apply with adtg_gui.
Code: [Select]
CMOS[1] = 0x748         
ADTG*[0x800C] = 2

This gives square pixels in RAW without any crop (just 3x3 binning), so for slow motion, you would have 1920x664 RAW that does not require any de-squeezing. It would look just like 1080p RAW, with vertical crop to 664 instead of 1280.

It should be also be possible to have 1x3 or 3x1 binning (with really squashed image), probably interesting for anamorphic lens users.

Anyone interested in any of those presets?
Title: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on April 02, 2016, 09:25:36 AM
Absolutely, @a1ex and I am all for this.

Just about to get home from work and ready to start the weekend with your latest gems.

Speaking of I was able to take the 5D3 to work earlier and shot some in H264 and MLV.

Curious to see how it looks when de-stretching these ugly looking squashed footage ... However I'm looking forward to this next step with you all!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on April 02, 2016, 10:07:39 AM
If there were not some links, I would have thought that was April's fools lie.
What an incredible tool.
I tried it on my 5dm3 1.1.3
I managed to record 60FPS up to 9 seconds and then it stopped.
50FPS was possible without interruption.
I also noticed the vertical shorter size and the black bar at the top.

Considering that we are on early stage, I am confident that ML developers will find the magic spell :D
Thank you very much for making our camera so powerful.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 02, 2016, 11:59:11 AM
Updated source code with 3 new presets:

- 3x3 binning in 720p (unsquashed slow motion at 1920x664 in RAW, image cropped only vertically; preview and H.264 are squashed)
- 1x3 binning: read all lines, bin every 3 columns (extremely squashed image)
- 3x1 binning: bin every 3 lines, read all columns (doesn't work well, image has artifacts)

The last preset could be useful for anamorphic lenses, but unfortunately I couldn't get it work without image artifacts. It might be possible to fix it by postprocessing, or it might be possible to find some register values that fixes it, I don't know. If you want to try, edit the source and put .max = 4 in the menu description. If you want to edit registers manually, use this configuration in adtg_gui:
Code: [Select]
CMOS[2] = 0x10E               ; read every column, centered crop
ADTG*[0x800C] = 2             ; vertical binning factor = 3
ADTG2[0x8806] = 0x6088        ; artifacts worse without it

then switch video mode to 720p and back to 1080p to apply all the changes.

So, my best guess for solving these artifacts would be by tweaking ADTG2[0x8806] and maybe also ADTG4[0x8806]. I wasn't able to find a suitable value, so if you have lots of time in your hands, you are welcome to try. Here's a tip: enable the full-screen magic zoom to see the artifacts.

Build coming later (I hope to fix the black bar issue as well); meanwhile, you can compile the sources.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Levas on April 02, 2016, 02:33:15 PM
Wow, do you guys say that there is finally a way to get 50 or 60 fps raw MLV without squashed image  :D
3 x crop mode at 50 fps and square pixels, nice!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: andy kh on April 02, 2016, 07:01:21 PM
very intersting. waiting for other cameras
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 03, 2016, 12:12:17 AM
Wow, do you guys say that there is finally a way to get 50 or 60 fps raw MLV without squashed image  :D
3 x crop mode at 50 fps and square pixels, nice!

That's right - 3x and also 1x with the latest update.

New builds:
- 5D3 1.1.3: magiclantern-crop3x.2016Apr02.5D3113.zip (https://builds.magiclantern.fm/jenkins/job/5D3.113-crop3x-april-1st-edition/7/artifact/platform/5D3.113/magiclantern-crop3x.2016Apr02.5D3113.zip) (build log (https://builds.magiclantern.fm/jenkins/job/5D3.113-crop3x-april-1st-edition/7/console))
- 5D3 1.2.3: magiclantern-crop3x.2016Apr02.5D3123.zip (https://builds.magiclantern.fm/jenkins/job/5D3.123-crop3x-april-1st-edition/6/artifact/platform/5D3.123/magiclantern-crop3x.2016Apr02.5D3123.zip) (build log (https://builds.magiclantern.fm/jenkins/job/5D3.123-crop3x-april-1st-edition/6/console))

Presets:
- 1:1 (3x) for 1080p and 720p (same as first post)
- 3x3 binning in 720p (square pixels in RAW 50/60 FPS, full sensor width, vertical crop)
- 1x3 binning: read all lines, bin every 3 columns (extremely squashed image)
- 3x1 binning, image has artifacts, setting hidden (you can edit crop_rec.cfg if you really want to try it without recompiling)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: squig on April 03, 2016, 04:44:23 AM
 :)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: kgv5 on April 03, 2016, 05:56:27 AM
Its unbelievable, wow. Thank you for that, soooo useful now, this is huge!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on April 03, 2016, 10:29:02 AM
This is great. Thanks for putting this in my cam. Awesome stuff.

I did a some short test footage comparisons exported with ffmpeg prores4444 out of MLP. Looking at the last dual iso clip, the one called 1:1 3xcrop 50fps 720p(mode) DUALISO I noticed the dual iso artifacts are a lot less noticeable than with the clip before called 1:1 3xcrop 25fps 1080p(mode) DUALISO.Not valid test, not equal settings on camera.

dualiso dng files for comparison.(white balance might be a little off)
1:1 3xcrop 50fps 720p(mode) DUALISO
https://drive.google.com/file/d/0B4tCJMlOYfirXzFFODVCb3UtM2M/view?usp=sharing
1:1 3xcrop 25fps 1080p(mode) DUALISO
https://drive.google.com/file/d/0B4tCJMlOYfiraEtUdkRLXy1HdVE/view?usp=sharing


Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: bouncyball on April 03, 2016, 11:36:25 AM
@Danne: Yep, looks like aliasing of the window frame is almost gone
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: beauchampy on April 03, 2016, 01:20:19 PM
Unfortunately I'm still getting corrupt frames on this build using 1.2.3 +MLV on 5d3. There's already a thread on this, so if you want to help solve this, we're on it here:
http://www.magiclantern.fm/forum/index.php?topic=5473.msg165242#msg165242
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 03, 2016, 01:35:12 PM
Looking at the last dual iso clip, the one called 1:1 3xcrop 50fps 720p(mode) DUALISO I noticed the dual iso artifacts are a lot less noticeable than with the clip before called 1:1 3xcrop 25fps 1080p(mode) DUALISO.

Apples with oranges. Repeat with a static scene, with identical focus in both frames ;)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on April 03, 2016, 03:48:32 PM
hehe, ok, thanks for fighting the placebo.

original DNG files
https://drive.google.com/file/d/0B4tCJMlOYfirRHBCeUh0X19CZGs/view?usp=sharing
https://drive.google.com/file/d/0B4tCJMlOYfirUmxWSnhoSGc1aDg/view?usp=sharing

Quick comparison. Couldn,t get super exact match. Not sure if subtle variations is due to cr2hdr or if I missed out on shutter. Think I nailed it. Anyhow. Can,t check more right now but any variations can be anything. Now it seems 25fps is a little less aliased in the blinds but could be coincidence.

1:1 3x crop 25fps 1080p setting
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2Ft2zcv2ecx%2FScreen_Shot_2016_04_03_at_15_24_19.png&hash=c1cd1e3451cb273ac8c1969d5c1f521f)

1:1 3x crop 50fps 720p setting
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2Fa98ykbqr5%2FScreen_Shot_2016_04_03_at_15_24_26.png&hash=56849cc7433b44fba46f0440da20ea91)

1:1 3x crop 25fps 1080p setting(cropped 400%)
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2Fyfo79729d%2F25fps1080.png&hash=9420e36a13d280a89d05559700901d84)

1:1 3x crop 50fps 720p setting(cropped 400%)
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs30.postimg.org%2F714h7a4hd%2F50fps720.png&hash=04a7f8ff8572afbc8975bb4f3e5bd63c)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: axelcine on April 03, 2016, 10:49:45 PM
@a1ex & Co - I had it on my good ol' 700d and I loved it. And now... same wonderful functionality on my new babies. You're just awesome. Thank you once again for ML; what you're doing is very much appreciated. Yesterday we had a wonderful sunset. I was filming near a lake with some exciting bird life with a long lens, and all the time I said to myself: should have brought the ol' trusted 700d - 1.6 factor + crop mode - o, I wish I could do this with my 5d's.
And today I wake up - and it's there. Magic. Pure m a g i c  l a n t e r n.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on April 04, 2016, 04:20:45 AM
@a1ex

Dear a1ex, which is the settings to test this module: should I put in Canon Menu 1280x720 50? Anything else? Thanks.


Sorry, I saw de @DeafEyeJedi video! thanks.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Hans_Punk on April 04, 2016, 05:50:02 PM
@A1ex

Quote
- 3x3 binning in 720p (unsquashed slow motion at 1920x664 in RAW, image cropped only vertically; preview and H.264 are squashed)
- 1x3 binning: read all lines, bin every 3 columns (extremely squashed image)
- 3x1 binning: bin every 3 lines, read all columns (doesn't work well, image has artifacts)

The last preset could be useful for anamorphic lenses, but unfortunately I couldn't get it work without image artifacts. It might be possible to fix it by postprocessing, or it might be possible to find some register values that fixes it, I don't know.

This is incredible, having a fix for 3x1 would be outstanding for those (like me and many others) who shoot anamorphic.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dmilligan on April 04, 2016, 06:17:37 PM
It's probably going to be important to have metadata about the crop mode stored in the MLV file (and also in sidecars for H.264 for people who might want to write auto-desqueeze scripts). Up until now, you could guess the crop mode based on the raw_info dimensions, but with this module, I assume that will no longer be possible.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on April 04, 2016, 06:44:10 PM
+10
Quote
It's probably going to be important to have metadata about the crop mode stored in the MLV file...
Title: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on April 04, 2016, 07:00:49 PM
+10

Excellent catch, @dmilligan!

Perhaps could this coincidence be related to this (http://www.magiclantern.fm/forum/index.php?topic=13152.msg165315#msg165315this)?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: markodarko on April 06, 2016, 03:19:12 AM
<I'm re-doing this post after more tests... Will update soon>
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: markodarko on April 06, 2016, 06:08:53 AM
Thank you to @dmilligan for pointing me to this thread from my own in-camera anamorphic request. I immediately downloaded the build to try it out!  :D

After doing some tests using with the 1x3 Binning mode, and whilst excellent(!), I think that the 3:1 compression (not sure if compression is the right word to use here. I mean the height:width ratio.) is perhaps a little too severe for critical shots but great for shots with less detail. Here are two stills to illustrate:

Here's a still from a video taken with the new 1:1 (3x) crop mode @ 1920x1080 (so great being able to see the framing properly in colour! Thank you!):

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fi1032.photobucket.com%2Falbums%2Fa404%2Fmarkodarkophoto%2FScreen%2520Shot%25202016-04-06%2520at%252004.11.18_zpsbxmjfbfv.png&hash=962527d2e97af9bc52a2a1d13ffb00f6)

And here's a still taken from a video shot @ 1024x1290 in 1x3 Binning mode with the width resized to 3072 and the height cropped by 40 pixels to remove the top black line:

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fi1032.photobucket.com%2Falbums%2Fa404%2Fmarkodarkophoto%2FScreen%2520Shot%25202016-04-06%2520at%252004.11.43_zpsgzk7zdis.png&hash=1b9d3cb10583efd4c2ae1c3e393316f3)

As you can see, the binned image is perfectly useable for non-detail shots and in those circumstances it would be fine (especially considering the lower data rate requirement of shooting at 1024x1290!), but as to be expected with a compression of 3:1 the image is noticeably softer than the native 1:1 image and no longer "looks" like RAW. More like H.264.

Because of this I'm wondering if it's possible to create a binning mode of 1x2 or even a binning mode of 1x1.5 or 1x1.33?

If that is technically possible I think that would greatly add to the functionality you've included here as for example we'd be able to record 1804x1152 @ 1x1.5 to give an aspect ratio of 2.35:1 @ 2707x1152 when stretched. I'd imagine that the image would not suffer too much with such a small squeeze.

Thanks again for your hard work.

Cheers,

Mark.

p.s.
- 1x3 binning: read all lines, bin every 3 columns (extremely squashed image)

Just as a matter of interest, is this correct with regards to the pixels that are thrown away or kept?

Code: [Select]
Column 1 - discard
Column 2 - discard
Column 3 - discard
Column 4 - keep
[repeat]
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 06, 2016, 07:07:46 AM
The binning patterns are described here: http://www.magiclantern.fm/forum/index.php?topic=16516

and (although I didn't test it), I think they are used in these modified video modes as well.

Therefore, a single line from 1x3 binning would average (x-2,y), (x,y), (x+2,y) to create pixel at (x/3,y), assuming centered coordinates.

Something like this, but without the skipped lines:

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fa1ex.magiclantern.fm%2Fbleeding-edge%2Flv-binning%2F5d2-lv-binning-cell.png&hash=2a879ac3e5dcaade20aaf307142bc79b)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: markodarko on April 06, 2016, 06:07:51 PM
The binning patterns are described here: http://www.magiclantern.fm/forum/index.php?topic=16516

Ah. Makes sense now as we're not dealing with debayered pixels but the RGB "blobs" that make up the pixels, of course. Thanks, A1ex. I take it from the photo you attached that the non binned bits are the ones with the green rectangles around them?

Can I take it from the binning pattern post that one must have a pattern in 3s so that equal amounts of red and blue are removed?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 06, 2016, 06:30:14 PM
In that figure, the green rectangle surrounds 3 other green pixels - meaning, those 3 are averaged to create one binned pixel. Same for red and blue.

Indeed, the binning factor has to be 1 or 3 (on vertical direction, 5 also works, since Canon's 720p uses 5x3 binning on 5D3). Check the previous page (http://www.magiclantern.fm/forum/index.php?topic=17021.msg165204#msg165204) to see why.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: ItsMeLenny on April 07, 2016, 07:16:33 AM
Does this mean that (say on a camera like 550D) when recording in 1920x1080 it can record a a 1920x1080 image cropped to the middle of the sensor, or will it still be a 1728x1156 image (cropped to the middle of the sensor) upscaled to 1920x1080 (like regular)?

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: markodarko on April 07, 2016, 10:00:02 AM
Thanks for the clarification and information, A1ex.

Cheers,

Mark.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Frank7D on April 07, 2016, 06:25:59 PM
ItsMeLenny, I'm no expert, but 1:1 sounds like no upscaling.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 07, 2016, 06:56:13 PM
Does this mean that (say on a camera like 550D) when recording in 1920x1080 it can record a a 1920x1080 image cropped to the middle of the sensor, or will it still be a 1728x1156 image (cropped to the middle of the sensor) upscaled to 1920x1080 (like regular)?

Resolution is not changed, so... 1728 or whatever your camera already records. The image sampled from the sensor is 1:1 crop, but whatever Canon does to process this data (for display, H.264, HDMI out and so on), is left unchanged.

Tip: adtg_gui.mo from the ISO thread works on this codebase without requiring recompilation, so you can already try to figure out which registers have to be changed ;)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: ItsMeLenny on April 08, 2016, 10:49:44 AM
Tip: adtg_gui.mo from the ISO thread works on this codebase without requiring recompilation, so you can already try to figure out which registers have to be changed ;)
I can't find that adtg_gui.mo, searched through a few posts and tried a few search queries and couldn't find it.
I haven't compiled ML in a while so I'll have to re-remember how to do that :P
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Walter Schulz on April 08, 2016, 11:01:19 AM
http://www.magiclantern.fm/forum/index.php?topic=10111.0
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: ItsMeLenny on April 08, 2016, 01:36:41 PM
http://www.magiclantern.fm/forum/index.php?topic=10111.0
ahh thanks! I was in the modules sub >_<
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: ItsMeLenny on April 10, 2016, 09:59:23 AM
Looks like I need a "a custom ML build from the iso-research branch" anyway, so when I get round to it I'll compile ML and the module.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: markodarko on April 10, 2016, 11:37:14 AM
The binning patterns are described here: http://www.magiclantern.fm/forum/index.php?topic=16516

Just a quick question if I may, A1ex... If I understand it correctly, does that mean that the "normal" (non-crop mode) recording in ML uses pixel binning but crop-mode recording does not as it's a 1:1 crop of the sensor? If that is indeed the case does that mean that the image quality is potentially better in crop mode?

Please feel free to slap me with a wet fish if I've misunderstood.

Thanks,

Mark.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 10, 2016, 11:57:46 AM
The image quality will differ in two ways:

Noise:
- 1:1 crop is more noisy (3x3 binning captures 9x as many photons)
- DR is similar because, on Canons, the averaging is done in hardware, before the read noise gets introduced; so the main difference will be in highlights.
- side note: a software 3x3 binning (after capturing a full-res image) would actually improve DR by about 1.5  stops.

Example from the above link (ISO 100, 1080p vs 5x crop):
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fa1ex.magiclantern.fm%2Fbleeding-edge%2Flv-binning%2F5D3-1080p-ISO-100.png&hash=2fa5d9fbd70a55cfe91cfe53aa48fd62) (https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fa1ex.magiclantern.fm%2Fbleeding-edge%2Flv-binning%2F5D3-Crop_mode-ISO-100.png&hash=6678723ec92a9f9c5544b9d42e74b5be)

ISO 1600:
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fa1ex.magiclantern.fm%2Fbleeding-edge%2Flv-binning%2F5D3-1080p-ISO-1600.png&hash=f121719951c3309887f7fe387e1ada4a) (https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fa1ex.magiclantern.fm%2Fbleeding-edge%2Flv-binning%2F5D3-Crop_mode-ISO-1600.png&hash=aa607d9dffaa3cdefab60141fd82cc44)

On these graphs, X is log2(raw-black) and Y is log2(noise stdev).

Resolution:
- for 3x3 binning, the impulse response is a little different (because of averaging), compared to 1:1 crop
- for 1x3 binning and 3x1 skipping (on cameras other than 5D3), the response is a significantly more different

The 1:1 crop matches the assumptions used in current debayer algorithms (it's what you would get from a still photo raw). The pixel binning modes are close, but not identical. One can exploit this property to create (or modify existing) debayer algorithms optimized for pixel-binned raw images, but I'm not aware of anyone who attempted to do so. Didn't try to search too hard, though.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Licaon_Kter on April 10, 2016, 09:24:18 PM
Nice work. Waiting for EOSM test code :)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: markodarko on April 11, 2016, 12:13:12 AM
Noise:
- 1:1 crop is more noisy (3x3 binning captures 9x as many photons)
- DR is similar because, on Canons, the averaging is done in hardware, before the read noise gets introduced;

Thanks A1ex. Did a quick and dirty noise test here (http://www.magiclantern.fm/forum/index.php?topic=17064.new#new) if you're interested. Those photos you attached don't seem to show up on my computer though.

So, if the 3x3 binning mode captures 9x as many photons, does that mean that for equal ISOs the 3x3 binning mode will have potentially 9x less noise than in 1:1 crop mode or is that being simplistic?

Cheers,

Mark.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on April 11, 2016, 08:12:40 AM
I was testing the new development with my new Rokinon 24mm f/1.4 that reached me lately I tried to justify the noisy results.
I trust ML wizards  :-*
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 11, 2016, 08:26:07 AM
So, if the 3x3 binning mode captures 9x as many photons, does that mean that for equal ISOs the 3x3 binning mode will have potentially 9x less noise than in 1:1 crop mode or is that being simplistic?

Are you able to see the graphs from my post? I'm not sure I linked them properly from dropbox. They show exactly how much noise you have and how it changes with signal level.

For example, at ISO 1600:
- in highlights (13 EV, or about 0.7 EV below white) you have noise stdev about 2^5.7 units in 3x3 and 2^7.2 in 1:1, so about 3 times less noise in 3x3.
- in midtones (9 EV, or about 4.7 EV below white) you have noise about 2^3.9 in 3x3 and 2^5.2 in 1:1, so about 2.5 times less noise in 3x3.
- in shadows (3 EV, where signal gets close to noise, or SNR close to 1) you have 2^3 in 3x3 and 2^3.5 in 1:1, so about 1.4 times less noise in 3x3 binning mode, compared to 1:1 crop.

If the 3x3 binning would be done in software, from a full-resolution image (with no extra noise added afterwards), the noise would be 3 times less in the 3x3 binning mode, regardless of signal level.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: markodarko on April 12, 2016, 12:44:28 AM
Are you able to see the graphs from my post?

I'm afraid not. :( They're just dead-image placeholders on my computer. Your textual explanation was enough though. Thank you again, A1ex.

Having thought long and hard about things I think I'm going to stick to recording 1920x803 in 3x3 binning mode instead of worrying about recording 2.5K in 1:1 crop mode like some idiotic megapixel junkie as from my non-scientific tests it seems that the quality of each pixel seems better in the 3x3 binning mode over the 1:1 crop mode - the result of which (now that you are educating me a little) I'm sure is more than likely down to the lower noise per pixel, but of course I could be completely wrong.

Cheers,

Mark.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 12, 2016, 12:54:02 AM
I've copied the files locally, to my dropbox, and linked them again - should be OK now.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: hjfilmspeed on April 12, 2016, 01:24:12 AM
Wow this looks Sick!!! Something tells me this will hit the nightlys soon!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: hjfilmspeed on April 14, 2016, 06:55:18 PM
What other testing needs to be done with this? Are there specific tests? Things we should try?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 14, 2016, 07:04:26 PM
Try crashing it. I already found a way to screw up the image, maybe you can find more.

http://www.magiclantern.fm/forum/index.php?topic=8900.msg91362#msg91362
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: hjfilmspeed on April 14, 2016, 09:23:58 PM
Im sure I can mess something up ha ha. I'm good at crashing. But I need to do more research on tragic lantern. I've never messed with TL. I've been on Nightlys since RAW vid was announced.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 16, 2016, 02:40:05 PM
I've linked to one particular message that tells you how to test things, not to the entire topic ;)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: domasa on April 16, 2016, 04:48:10 PM
Greate feature!
Please add "3x" next to focal distance. Now you can not recognize the current mode. Thx.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 16, 2016, 05:56:56 PM
Done.

Funny thing - while attempting to fix the interference with still photos, I've got upside-down images. They looked pretty normal otherwise; they had OB pixels both at top and bottom though.

I also found the feature useful in photo mode (for example, as a mild zoom), so I've enabled it there as well.

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: domasa on April 16, 2016, 08:54:21 PM
Quote
Let's say you adjust this line skipping register to 1 (that is, read every two lines). Now you have a little problem: you only captured two Bayer colors
Is RAW file smaller when I record only two colors? It will be good for black and white recording..
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dmilligan on April 16, 2016, 09:23:19 PM
Nope. Each raw pixel is 14 bits and only one color.

https://en.wikipedia.org/wiki/Color_filter_array

Though, a 1:2 line skipping would probably work if you only wanted black and white. Though you would probably need some custom debayer algorithm, or only use the green channel (which you would loose resolution). Or you could go hardcore and scrape the CFA off of your sensor (I've been wanting to do this to my 1100D, but the probability I would destroy the sensor is quite high).
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: hjfilmspeed on April 17, 2016, 07:29:43 AM
@
I've linked to one particular message that tells you how to test things, not to the entire topic ;)
Got it!!! Thank you! Test for the sake of testing! That's very important.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: beauchampy on April 20, 2016, 09:41:41 PM
A1ex, is it possible to use this feature to record an area of the sensor that is 1440x1080?

Could be a useful way to implement 4:3 recording for anamorphic lenses.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 20, 2016, 09:44:42 PM
If I'm not mistaken, you can just select that resolution in the raw recorder. Are you asking something different?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: axelcine on April 20, 2016, 10:12:43 PM
Do anybody know where I can find the latest ML/crop3x? I am using the April 2 version (with great satisfaction) but I think, the crop module and a few other items have "developed" somewhat. I'm looking forward to try it out - and of course to see it come out in the nigthlies when you think it's ready, being one of the more important improvements - thanks again, A1ex.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: The Director on April 22, 2016, 08:20:47 PM
if this crop mode could shot down more than 1080 - it's would be f*cking amazing...
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: pyjamaproductions on April 25, 2016, 11:31:45 PM
I'm on the current nightly build for 5DIII.113 but when i but the crop_rec module from april 2nd into my modules folder on my sd card i can't boot ml anymore. once i delete it everything boots up normal again. What am i doing wrong here?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: axelcine on April 26, 2016, 02:49:03 PM
Quote
From A1ex, April 1 (first post in this thread): Current implementation only works on 5D3, and I've tested it only on 1.1.3. The module is not yet compatible with current nightlies, so you need a full package (not just the module).

The latest ML/Crop3X may be found here: http://www.magiclantern.fm/forum/index.php?topic=17021.msg165282#msg165282
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Walter Schulz on April 26, 2016, 03:09:57 PM
What am i doing wrong here?

Not reading first post comes to mind ...
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on April 26, 2016, 03:52:55 PM
Quote
Not reading first post comes to mind ...
:-* +1
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Hans_Punk on April 28, 2016, 04:54:48 PM
Did a shoot yesterday on the awesome 5D3 build 1.2.3 crop mode update from A1ex . h264 was requested by client (they needed 'easy' footage to edit)  - For some shots I utilised the 1:1 crop mode from the most recent update and noticed vertical stripes in the footage. Camera was iso 400-800 1/50 shutter and only noticed stripes after downloading footage from card. I've not encountered this issue when shooting raw with the same settings and crop mode - I wondered if anyone else had this issue?

Is there such a thing as post vertical stripe correction for .h264 files that does not require a programmers brain to implement?

Here is am example of the vertical stripes I've encountered on .h264 footage, when using the crop mode:
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fs32.postimg.org%2Flpdptjo44%2FML_SAMPLE.jpg&hash=ca9dc72071b37403d97132360b146ffe)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: aschille84 on April 29, 2016, 08:25:10 AM
Had the same problem to when using 5D3 1.1.3 build in h264 crop mode. Vertical stripes just like in some raw footage, only much harder too remove I guess..
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 29, 2016, 09:06:48 AM
Do these appear every time you record H.264 in crop mode?

Is this a full-sized image? In raw, the same pattern repeats every 8 columns and it's caused by nonuniform amplifier gains. Basically, divide the image in 8 sub-images (columns 1:8:end, 2:8:end and so on) and match their histograms. Looks like avisynth might be useful here:

http://avisynth.nl/index.php/SeparateFields
http://avisynth.nl/index.php/Select#SelectEvery
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: aschille84 on April 29, 2016, 10:57:35 AM
I've only tried indoor shoots, but it seems to be present most of the time. It is full-sized as in 1080p 3x3 crop mode. Can upload som sample footage later.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 29, 2016, 11:07:38 AM
A few frames extracted with ffmpeg -vcodec copy would be best.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Hans_Punk on April 29, 2016, 01:05:39 PM
Do these appear every time you record H.264 in crop mode?

Is this a full-sized image? In raw, the same pattern repeats every 8 columns and it's caused by nonuniform amplifier gains. Basically, divide the image in 8 sub-images (columns 1:8:end, 2:8:end and so on) and match their histograms. Looks like avisynth might be useful here:

http://avisynth.nl/index.php/SeparateFields
http://avisynth.nl/index.php/Select#SelectEvery


Yes - to both questions.

I'll look into avisynth and extracting frames with ffmpeg - vcodec, but I'm a total idiot when it comes to what I'm doing, and how to correct with code.
Many thanks for reply A1ex :)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on April 29, 2016, 01:23:03 PM
You could do something like this

open terminal
Code: [Select]
ffmpeg -i drag your file here -t 1 -vcodec copy -acodec copy outputfile.movEven shorter clip do
Code: [Select]
ffmpeg -i drag your file here -t 0.2 -vcodec copy -acodec copy outputfile.mov
vcodec=video(no compression)
acodec=audio(no compression)
-t 1(1 second)
outputfile=name your outputfile with correct extension. Will probably export to your home folder.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 29, 2016, 01:41:34 PM
Ah, it's a 720p image? In this case, the pattern repeats every 5.33 pixels, or 15 pixels.

Can you do the pixel peeping part for me to confirm these numbers?

edit: FFT says it repeats every 5.3782 pixels; maybe Canon doesn't resize the 1280 image from 1920, but from 1904.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: beauchampy on April 29, 2016, 02:01:56 PM
Here's a thought.. How about incremental stepping crop?

Could you map it so we can choose 1.1x, 1.2x, 1.3x, 1.4x......... 2x.... 3x....

Effectively we could just bang on a wide-ish lens and have a multitude of different focal lengths to choose from?

This would be amazing, I'm shopping for Leica glass at the moment and effectively turning the 35mm into a 50mm too would save me a lot of ££
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Hans_Punk on April 29, 2016, 02:05:15 PM
@Danne Many thanks...first time I've ever used ffmpeg (errr...or typed any command line!)  :o
Even I understood that - thank you for helping.

Here are two short clip extracts, first in context of footage...second clip is start of take (against warm white background of studio)

https://www.dropbox.com/s/60jxn7e9ehwejtc/1080p%20Stripes%201.mov?dl=0

https://www.dropbox.com/s/a9zz2y4gihm9vfo/1080p%20Stripes%202.mov?dl=0


@A1ex, sorry - my fault I added confusion with my previous low res jpg uploaded grab.
All footage is 1080p, 25fps. iso between 400-800, 1/50th shutter throughout.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 29, 2016, 02:16:09 PM
Link doesn't work, see https://www.dropbox.com/en/help/167

@beauchampy: already answered.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Hans_Punk on April 29, 2016, 02:46:31 PM
My apologies, try this...

https://www.dropbox.com/s/60jxn7e9ehwejtc/1080p%20Stripes%201.mov?dl=0

https://www.dropbox.com/s/a9zz2y4gihm9vfo/1080p%20Stripes%202.mov?dl=0
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 29, 2016, 03:58:40 PM
Is this good enough, or should I keep trying?

http://a1ex.magiclantern.fm/bleeding-edge/stripefix/fix.jpg

(will publish the script later, afk)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on April 29, 2016, 04:01:30 PM
Wow.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Hans_Punk on April 29, 2016, 04:11:16 PM
@A1ex....huge improvement already, many thanks!

Hard to judge if it is still distracting when footage in motion, rather than in a still....but to me it looks almost 100% clean.
Don't want to steal your time too much - but if you have any joy pushing it further, that would be totally amazing and much appreciated.

RE: script, please be gentle with me in explaining how to implement...scripts and line commands are still confusing for my tiny brain, still trying to grasp basics.  ::)



Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 29, 2016, 10:05:39 PM
Here you go - the vertical stripe fix for H.264:

stripe-fix-h264.html (http://a1ex.magiclantern.fm/bleeding-edge/stripefix/stripe-fix-h264.html)

stripe-fix-h264.ipynb (http://a1ex.magiclantern.fm/bleeding-edge/stripefix/stripe-fix-h264.ipynb)

fix2.jpg (http://a1ex.magiclantern.fm/bleeding-edge/stripefix/fix2.jpg) (slightly better results after cleaning up the code)



Regarding script:

For tasks like this, I find it much easier to write a script, than to write a C program that can be compiled as executable. Also, I hope my approach will not just solve your particular problem, but it will let the ML community benefit in other ways from this script, such as:

- understanding how this method works (I've included sample images at every step)
- getting started with octave and IPython Notebook (even if this is your first contact with these tools, I don't think it's a bad idea to take a look at my experiment, then check the documentation of these tools where my description is not fully clear)
- having a working code that you can just copy/paste and integrate in your workflow

Of course, octave is a little slow, but I think I gave enough details for anyone with average programming skills to implement the same method in a language that can give better execution times, and/or a nicer user interface.

If you still have trouble running the script, I'm sure other members will be able to help you.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Hans_Punk on April 29, 2016, 10:52:32 PM
I owe you not a beer...but a brewery!

Many thanks again a1ex, truly outstanding work as always.
I really appriciate the time and effort you and others put in to help this community.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 30, 2016, 12:57:26 AM
Looks like the remaining artifacts can be masked out if you add a tiny bit of noise.

fix2n.jpg (http://a1ex.magiclantern.fm/bleeding-edge/stripefix/fix2n.jpg) - compare to fix2.jpg (http://a1ex.magiclantern.fm/bleeding-edge/stripefix/fix2.jpg)

Updated the notebook to show the effects of adding noise, and saved both samples with better jpeg quality.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: hjfilmspeed on April 30, 2016, 06:35:53 AM
Wow this is brilliant. Just red the article..... I just can't even understand this simple fix. Its over my head. Amazing work
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on April 30, 2016, 07:16:46 AM
Great documentation. Even "repairing" the h.264 blocky artifacts. I,ll try to make this work in MLP.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on May 06, 2016, 06:03:32 AM
First of all, Excellent contributions by all of you guys including @Hans_Punk, @Danne, @a1ex, @beauchampy and the rest.

Secondly, I am even more impressed with the progress of having the possiblitilies with a script to help fix those vertical stripes horror of H264.

However, with that being said I can't fathom myself on trying to produce those stripes during crop_rec.mo shooting unless I'm doing something wrong? Does it only appear in highlights area or vice versa?

Shooting a Wedding this weekend and unfortunately the couple refused to have me shoot in RAW because they want the footage at the end of the night ... so I'll be shooting everything in H264 and I've been keen on myself (more like forcing) to not use this module during this event but at the same time I am feeling confident that I can get away with a lot afaik unless I'm literally color blind from those so called blocky artifacts.

Also is there a reason why I refuse to shoot this in 60p and only in 30p? Maybe because I fear that I won't be able to fix the squeeze effect on the H264 footage if I were to shoot in 60p (they ask for some slo-mo's) which I will secretly use my SL1 and EOSM with their crop_mode video hack ( 30p in Canon Menu w FPS override set to 45fps @ 1080p  :P ) w a 6.5mm Opteka Lens which has done its job respectively in the past.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on May 06, 2016, 10:07:47 AM
Most of the questions and the answers to them could probably be tested out before you go out and shoot the wedding. In fact a thourough pretest and then the wedding shoot with a thourough follow up addressing bugs etc would be great for progress here.
http://www.magiclantern.fm/forum/index.php?topic=8900.msg91362#msg91362
http://www.magiclantern.fm/forum/index.php?topic=17021.msg165749#msg165749
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: axelcine on May 06, 2016, 10:54:07 AM
@DeafEyeJedi - I happen to see you as a totally competent cinematographer, and the way I read your post, you "drop the crop" for the time being, since you don't really know how much work you'll have to do in post, just like the clients want some footage tonight, and you won't have time for conversion from raw.
I'd say to you, as an old journalist to another old and wellproven veteran: Go ahead with SL1 and the M, if you feel they'll do the job with slomo and crop. Do it discretely but not secretly - you are the expert, and the clients should not interfere with your choice of cameras. Like when they go away from church in a limousine and want to dictate the brand of gasoline...!
So you're in for many hectic hours behind the cams and in post. Good luck - I know that the married couple are going to love their movie and be proud to show it to their kids and grandkids in the years to come.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: sterid on May 09, 2016, 04:25:33 AM
Hi, did anybody fork it to 6D?

I found this link http://www.magiclantern.fm/forum/index.php?topic=10111.msg125590#msg125590
But I cant understand how to change.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dmilligan on May 19, 2016, 01:41:10 PM
Up until now, in post tools we were identifying the video mode based on the raw buffer size in raw_info. This is important information for things like automatic focus pixel removal and automatic "de-squeezing", and it's probably also just nice metadata to have for users (should I worry about aliasing in this shot? computing effective focal length, etc.). With this module, that is no longer possible, different cropping modes can have the same raw buffer size.

So I propose that part of the change for this new feature should be to add new metadata to the MLV format for horizontal and vertical pixel skipping/binning amount.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on May 19, 2016, 03:57:28 PM
Agree, detailed proposals welcome.
Title: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on May 21, 2016, 09:24:41 PM
Hello everyone-

After weeks of debating on whether or not I should use this special build by @a1ex while shooting a Wedding few weekends ago. Lord behold and I was actually fortunate enough to bite this bullet. Why? Because I believe things happen for reasons and here's what I was able to get away with.

First of all, My goal was to try and keep things simple as possible because the groom (my client) had asked me to NOT shoot anything in MLV RAW and also for me to use a decent color profile while shooting in H.264 which smelled trouble at least for me since I haven't used anything other than MLV RAW over the years.

So I decided to go with Faithful (Sharpness @ 0, Contrast @ 1, Saturation @ 2 & Color Tone @ 0) and only because @markodarko has proven that this color profile can literally hold up pretty well without any required post work as this client repeatedly told me that he wasn't comfortable with the color grading process and he's only into Editing. Thanks to @markodarko for this otherwise I'd be using CineStyle and force the client to apply LUT's on top of it but he firmly instincts not to and frankly he's the one that paid me so here we go.

Cameras used on set: 5D3, 7D & C100II (a nephew used an Osmo that was owned by the groom).

Glass: 35L, 16-35L, 24-105L, 70-200 F4 & Opteka 6.5mm (I didn't want to bring my whole set of glass as I try to pack light).

Audio: Groom's Lapel on Channel L & AUX Output from a PA system into Channel R which was recorded onto Sound Device (rented).

Secondly, earlier I mentioned that things happen for reasons and what I meant by this was the fact that halfway through the Ceremony as I was running to the other side of the aisle to make sure the 7D + 70-200 was wide enough for the couple to walk out at the end and bam just before I got there ... Dropped the good ole' 24-105L onto the ground as it was in my Hip Pack. Cracked the UV Filter and it was pretty hard to try and take off the Filter which I then decided to not waste time trying to fix this while the event was taking place.

Look up it's not a Plane, it's not a Bird & no it's not Superman. It was @a1ex's build who came to the rescue by using his crop_rec.mo while shooting in H.264 (yes, that's right I said H.264) with a 35L for the rest of the event on the 5D3. I knew in my head that with this deadly combo of 35/105 focal length would deliver magic (according to my pretests in MLV RAW and barely any tests on H.264) as I thrive on taking risks. No IS. Not sure why I've been like this my whole life. Living on the bleeding edges can actually help you with building up confidence, BIG time.

Per the Groom's request everything was shot in 30p (5D3, 7D, Osmo) while I only used C100II for slo-mo (60p) all @ 1080p. I also had to force myself to set the Color Profile to 'EOS Standard' instead of the lovely 'Wide DR' on the C100II to better match with the 'Faithful Profile' from the 5D3, 7D.

https://vimeo.com/167454180 (Sorry fellas the couple decided to make their video private)

Non Crop-Mode 35L @ ISO 3200
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm8.staticflickr.com%2F7720%2F26498249973_239b128f6d.jpg&hash=018217929b9bdf8f7580bb739c0131ff) (https://flic.kr/p/GnyswR)

Crop-Mode (1:1) 35L @ ISO 3200
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm8.staticflickr.com%2F7788%2F26498249173_45002836b1.jpg&hash=ef6b092c97c0e4c98fd9323a6b6a373e) (https://flic.kr/p/Gnysi4)

Where's DeafEyeJedi at? 7D + 6.5mm @ ISO 6400
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm8.staticflickr.com%2F7695%2F26828083700_0e8e41fa24.jpg&hash=9d125c7c06b1fea124a2c6c6d57eba12) (https://flic.kr/p/GSGWBf)

From where I was standing and just to be able to push a few buttons (preferably one) in order to get into crop-mode is priceless.

Now imagine if I had shot this whole thing in MLV RAW instead but no shame on myself and hey I think overall it came out not too shabby at all.  :P

Special Credits goes to @a1ex for this build and none of this would have been possible without your eagerness so I THANK YOU from the bottom of my heart and also to everyone else on board that has contributed all along. Thank You!

Incidentally my question now brings to this thought ... How & When do we know that this build is ready for to be merged into the Nightlies?

I know we still have quirks to iron out for slo-mo's squeezed images and whatnot but as for 24p & 30p which seems legit according to my eyes for both H.264 and MLV RAW.

Anything that we can help with to speed up this Project of yours, @a1ex?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: markodarko on May 21, 2016, 09:51:05 PM
Thanks to @markodarko for this otherwise I'd be using CineStyle and force the client to apply LUT's on top of it but he firmly instincts not to and frankly he's the one that paid me so here we go.

<snip>

I knew in my head that with this deadly combo of 35/105 focal length would deliver magic

You are most welcome. Looks great! :-)

Funny you should mention the 35/105 combo too as I posted the very same thing about it here (http://www.magiclantern.fm/forum/index.php?topic=17299) earlier. :-D

The crop mode recording is, as you say, fantastic. So versatile for a one lens setup.

I shot with my 70-200 f/4 IS the other day and essentially had every focal length between 70-600 at my fingertips!

I too would be interested if and when it'll be in the nightlies as I'm still currently rocking @a1ex's original build he posted up. Not that I've any problems with it though.

Anyway, I'm glad the shoot went well. Oh, and how's your poor 24-105L doing now?

Cheers,

Mark.

P.s. Have a look at the Canon 35mm f/2.0 IS, @DeafEyeJedi. The IS is great for hand held video work and from f/4 it's absolutely pin sharp. I use my Sigma 35mm f/1.4 Art when on a tripod or for the extra light, but the Canon is a cracking little lens and cheap (relatively) too!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: axelcine on May 22, 2016, 04:43:06 PM
@DeafEyeYedi: Excellent, beautiful wedding footage, and the crop is a godsent, especially in low light. Maybe we could hope for a new interim crop-ML/5d.113 based on the most recent nightly - there have been some very important improvements to ML since April 3. Then again - one just has to read the posts here to acknowledge the amount of work, A1ex (a.o.) is putting into the ML. Does that man ever get to sleep?
@markodarko: Yes, with a variety of glass the crop would be a real game-changer. I'm using crop/5d.123 with my nifty-fifty. It's a gem.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Licaon_Kter on May 22, 2016, 05:50:01 PM
...
I will secretly use my SL1 and EOSM with their crop_mode video hack ( 30p in Canon Menu w FPS override set to 45fps @ 1080p  :P ) w a 6.5mm Opteka Lens which has done its job respectively in the past.
Umm, on my EOSM crop_mode does not actually do anything, it works for you?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: axelcine on May 22, 2016, 06:02:22 PM
The crop-version ML we're discussing is a tailored ML/5DIII that A1ex produced back in the start of April. It is being tested in various modes and configurations before going into the nightlies. EOS-M has its own crop mode hack - https://builds.magiclantern.fm/#/features.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Licaon_Kter on May 22, 2016, 07:00:13 PM
I know it has the 600D mode, though this was a different implementation.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on May 22, 2016, 11:16:17 PM
Thanks for sharing deafeyejedi. Truly remarkable module I say.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: bouncyball on May 23, 2016, 09:13:52 AM
Thanks for sharing DeafEyeJedi. Nice work.
Title: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on May 23, 2016, 08:02:44 PM
@markodarko - Thanks for your kind words. Yea I saw that post of yours too and thought it was funny and quite a coincidence, right? Yes, I also agree that the 35 f2 IS is a nice workhorse but needed the extra light as I knew I was getting myself into some serious night scenes towards the end of this event.

I could have gotten away with it more nicely in crop-mode if I hadn't dropped the 24-105L which would obviously help but knew that with a Monopod and try to keep it on its feet (rather than handheld) would be good enough with a 35L. It's a tough job to try and pull the monopod leg down more to set the feet properly while recording for certain angles. Schmucks!

Admittedly, it's not perfect but how else can we train our eye/hand coordinations in order to continue and improve our skills? The more I try to stay away from IS the better I become as a whole (even when I do use IS for certain situations later on) which still produce nice results as I've been itching to sell my 16-35L II for a 16-35L f4 IS but damn it ain't so easy to give up that extra light for IS even tho I can tell that both glasses are still sharp as F. Right, @beauchampy? Ha.

@axelcine - Thanks, Mate! I too think this is a great Module and just to be able to use this 50/150 focal length combo is incredible especially wide open. Bokeh's dreamy as it can be.

@Licaon_Kter - I ended up NOT using the M or SLR during this wedding event because I had decided to rent a C100II as the client demanded everything to be in 1080p and preferred 60p over 45p. Yes,  I agree with you that the M's '600D-crop' isn't quite the same as this but one of the main reasons why @a1ex came up with this build was because I believe many of us 5D3 users were, for years, howling at the moon out loud for a similar module that a lot of the APS-C's cameras running ML already have.

In other words, I'm afraid it's pretty much the same for 24p/30p except for when it comes to slo-mo (48p,50p,60p) which hasn't been implemented yet but am feeling confident that other cameras will eventually have this build sooner rather than later, hopefully!

@Danne & @bouncyball - Thanks for the compliments and much appreciated! Even though would I do this again with H.264? I'm not sure as I am completely addicted to the workflow of MLV RAW and the Dynamic Range that comes along with the color grading process. It delivers at a level that's incomparable with what H.264 delivers, IMO. However, to my surprise the end result from this event was probably better than I expected especially for shooting in a codec that I cannot fathom to use. Thanks again to @markodarko for the generous tip w a certain Color-Profile on our Canon DSLR's.

At the end of the day... Once you go RAW, there's no going Back. I try to keep that motto and stick with it in my head. Because as for me it was actually quite a nightmare in preparing myself to shoot H.264 after years of shooting in MLV RAW.

@Everyone - Last week I personally took the 24-105L to a Canon repair facility down in Irvine, CA and was pleased with their service as they were able to take it into the lab to take the filter off as well as doing the 11-point check for free of charge. Took them 20 minutes.
 
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Ffarm8.staticflickr.com%2F7005%2F26592782874_7244475e83_n.jpg&hash=06c6f2d6724a7a512775cd69a52becd0) (https://flic.kr/p/GvUXSs)

All good in despite. Whew!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: _OLLE_ on May 28, 2016, 03:49:42 PM
Anything similar for the 7D yet??
Title: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on May 28, 2016, 06:48:45 PM
Not yet AFAIK. I'm waiting for this one to be implemented as well. However, you can still use "crop-mode" in 24p/30p by pressing the magnified glass button once which will give you at least a proper framing while using a Greyed out liveview LCD (not pretty) but the final result from RAW is still priceless. Maybe you have tried it already but not doable for our kind of work, right?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: _OLLE_ on May 28, 2016, 09:29:11 PM
Yes, I have tried it! If it will work for 7d some day, how many sec do you think it will be possible to record @60fps 2,5k with 7D? Not very long i guess hehe!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on June 08, 2016, 10:30:48 AM
Since 2/4/2016 I use the crop version of ML for 5dmk3 1.1.3

I was shooting lately and because my prime lens wasnt close enough, I used the traditional crop recording.
I noticed that it recorded 30FPS rather than 25FPS.
Is it a bug ?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: beauchampy on June 08, 2016, 11:51:05 AM
Since 2/4/2016 I use the crop version of ML for 5dmk3 1.1.3

I was shooting lately and because my prime lens wasnt close enough, I used the traditional crop recording.
I noticed that it recorded 30FPS rather than 25FPS.
Is it a bug ?

It does that for me too.. I have to use FPS override to correct.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: GutterPump on June 08, 2016, 12:09:03 PM
Do you know if the new 3X crop mod will officialy be implemented in new builds ?

I check everyday if the a new build is ready with this new mod  :) i can't record without now.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Levas on June 09, 2016, 12:02:29 AM
About the 30fps in crop mode:

The moment you use the magnify button and have a zoomed liveview, the fps goes to 30 fps, even if you're in PAL or 24fps mode.
It's how canon reads out the sensor at default, you need fps override to correct to 24 or 25, even in PAL mode.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Lars Steenhoff on June 09, 2016, 01:27:40 AM
Does the crop build include the fix for pink frames?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: GutterPump on June 09, 2016, 10:05:26 AM
To avoid pink frame, it's advisable not to use some options in "global draw" like "focus peaking", and be carefull with FPS override.

But i never get pink frame's problem with this special crop build. It work like a charm.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on June 09, 2016, 05:35:11 PM
About the 30FPS

I assume that some things are beyond control, guessing, trial and error.
Its a bitch to remember to disable/enable something when entering a mode.
Most of the times I shoot solo, doing things for 5-6 people. Its very tiring and very slow moving.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: peterjohnjoseph on June 17, 2016, 09:02:39 AM
Sorry if this is an awful question, but what is the difference between shooting with the 3x Crop Mode in this build (when using the 1x1 binning mode), and the regular Crop Mode using the 5x button, which, for me, would achieve a 3x zoom in playback?  I'm using a 5d Mark III with the April 02 build in this post.

To my understanding when using the standard "Crop Mode", it also creates a 3x zoom when clicking the 5x zoom button, allows you to shoot in resolutions above 1920x1080, but also has the caveat of a slow, grayed screen, or being forced to record with incorrect composition that stays at 5x while recording.

Am I correct in saying that this is more or less the main tradeoff? The ability to shoot in higher resolutions vs. the ability to get full color correct compositions?

To make sure I'm on the same page, when using this build, turning on the 3x Crop Mode at 1x1 binning, and shooting at 1920x1080 I get accurate composition in full color, and the same size recorded image as if I were using the standard Crop Mode with the 5x zoom button instead. When using the 5x zoom crop mode, it allows me to use resolutions higher than 1920x1080, however doing it this way also means a slow and grayed screen, even at 1920x1080, or a poorly composed image if I were to use the Canon previews that stays incorrectly zoomed to 5x while recording. So would I be correct in saying this is the main difference?

My other questions would be-
-Is there a way to achieve resolutions above 1920x1080 with this build using the 3x Crop Mode with 1x1 binning?
-Am I missing a way when using the standard Crop Mode with the 5x zoom button to a achieve color previews with correct composition?
-Is there anything else that I seem to be misunderstanding, such as the difference between using these two methods?

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on June 26, 2016, 08:35:03 PM
Nightly ready 5DIII ?

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: axelcine on July 27, 2016, 03:08:32 PM
I wonder if crop mode for5d3 is progressing. We've been very happy with the April miracle from a1ex, but I'm wondering if we could persuade him to add the crop wonder to a more recent build of ML,since ML has been improved on a great many areas since April. I feel, that the crop mode for 5d3 was added at a price - some existing functionality being scuttled in order to make the crop mode work. It might be interesting to know a little more about this. The cropping facility is highly appreciated in our 650's and 700's and would be a marvel for 5d and others as well. Hopefully I'm not "throlling..."
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: GutterPump on July 27, 2016, 03:17:31 PM
I asked myself the same question, but I think Alex is waiting to learn more with tests to be able to implement it in a stable release.

I personally use continually this mod without any problems.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: axelcine on July 27, 2016, 05:15:31 PM
@GutterPump - I'm happy with the April miracle as well - no doubt about that - but I felt, that the problem implementing the crop mode was more than a little trivial, so... But just like you  I'm sure we'll get a status report as soon as there is something to tell.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dmilligan on July 27, 2016, 05:16:02 PM
It might be interesting to know a little more about this.

The crop mode feature works by changing CMOS registers (a register is simply a memory address that we can set to some value and that value will control some aspect of some external piece of hardware, for example an LED). Normally this is a very simple thing to do in an embedded system. Just set the memory address to the value you want (1 line of C code, or a simple command or two in assembly). However, in our situation, we (ML code) are fighting with Canon firmware. Canon firmware is constantly re-configuring and overwriting all kinds of registers. Therefore, to get the value we want into the register (and get it to stay there and not be overwritten), we have to modify the behavior of Canon firmware. We refer to this behavior modification as 'patching'.  It can be very tricky to get right, because we don't want to actually permanently modify the Canon firmware in ROM (that would be very dangerous). So instead, we exploit some hardware known as a "cache" and use it in a way it was not really intended to be used, that is, to fake the CPU into thinking it's reading from Canon firmware ROM, when in reality it's reading from some value we control.

For a long time even before this particular feature was implemented, a1ex had been working on a nice new "backend" for applying and managing our patches that would be easier to use and monitor, and it would be "safer" and more efficient. (There may be situations where we only need to patch something that is in RAM not ROM, e.g. dual ISO, which is much easier b/c we can do it directly without worrying about permanently overwriting anything, but the new backend will handle both for us nicely in a unified way). Like the memory backend, or raw backend, this is one of those "under the hood" features that most users aren't aware of exists, but consumes probably a majority of development effort, and on which many important "user-facing" features actually depend on. These "backends" basically encapsulate the knowledge we learn from reverse engineering and how to get Canon firmware to do what we want, and present an nice, easy to use API to the developer. They are the foundation on which the rest of ML is built.

Since the crop mode feature needs to be able to override registers (and do so very fast and efficiently), it was built upon the new patch manager backend. However, the patch manager itself isn't quite ready for prime time (at least not on all cameras, for example on 60D it doesn't work at all). There are many other things that ML does that require patching Canon firmware, even the extremely complicated process of booting up.

TLDR:
This is a relatively small and simple feature by itself, but it depends on a large change to the foundation of ML. It's the foundation change that is holding it back.

Once the new patch manager is completed and confirmed to be working well (which is very important in this case, since it's at such a low level, and has the potential to effect so many things) it will be merged, and features like this one, and other similar ones in the pipe, will be trivial to complete and merge.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: axelcine on July 27, 2016, 05:33:13 PM
Thanks, dmilligan, an excellent and very deep explanation, that only widens the respect and admiration we have for you guys - I  K N E W  there had to be some very intriguing stuff going on when a1ex released the April Miracles. At the same time I understand, that once the Canon firmware is respectfully tamed, crop mode will be one of a whole new range of possibilities. Wow.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: PabloW on July 27, 2016, 11:50:29 PM
Would this allow you to use EF-S lenses on a full frame sensor like the 5D's?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on July 28, 2016, 12:08:55 AM
How will you mount an EFs lens to a 5D?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: PabloW on July 28, 2016, 12:21:02 AM
It would have to be with an adapter. But I was asking if it could be done in theory. Sorry for not being clear.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on July 28, 2016, 12:27:52 AM
http://photography-on-the.net/forum/showthread.php?t=1388461&page=1
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: tecgen on July 28, 2016, 01:01:03 PM
Quote
How will you mount an EFs lens to a 5D?
I did this with my old kit lens. ;)
http://www.instructables.com/id/Canon-EF-S-18-55mm-To-EF-mount/
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on August 23, 2016, 10:42:22 PM
New builds:
- 5D3 1.1.3: magiclantern-crop3x.2016Aug23.5D3113.zip (https://builds.magiclantern.fm/jenkins/job/5D3.113-crop3x-april-1st-edition/9/artifact/platform/5D3.113/magiclantern-crop3x.2016Aug23.5D3113.zip) (build log (https://builds.magiclantern.fm/jenkins/job/5D3.113-crop3x-april-1st-edition/9/console))
- 5D3 1.2.3: magiclantern-crop3x.2016Aug23.5D3123.zip (https://builds.magiclantern.fm/jenkins/job/5D3.123-crop3x-april-1st-edition/7/artifact/platform/5D3.123/magiclantern-crop3x.2016Aug23.5D3123.zip) (build log (https://builds.magiclantern.fm/jenkins/job/5D3.123-crop3x-april-1st-edition/7/console)) (build fails...)

Changes:
- synced to main builds
- fix for the famous bug (http://www.magiclantern.fm/forum/index.php?topic=17021.msg165749#msg165749) that nobody managed to find so far (yet, extremely easy to trigger)
- status icon
- also works in photo mode (either as mild zoom, or for silent pictures)
- experimental fix for vertical stripes (https://bitbucket.org/hudson/magic-lantern/pull-requests/732/5d3-attempt-to-fix-vertical-stripes-so-it), to be tested in both crop and regular raw video modes (no effect on H.264)

Please note the builds are pretty much untested, so you should probably wait for feedback from early testers before upgrading.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on August 23, 2016, 10:46:53 PM
Thank you for greatness.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: GutterPump on August 23, 2016, 10:55:42 PM
Thanks you A1ex,  im impatient to test it tommorow !
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Lars Steenhoff on August 24, 2016, 10:50:19 AM
nice update alex!

will try it out soon, any ideas why the 1.2.3 failed?

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on August 31, 2016, 08:50:23 PM
Discussion regarding vertical stripes moved here (http://www.magiclantern.fm/forum/index.php?topic=17795.0).

Original reply (August 24):
Quote from: a1ex
Yes, a minor merge conflict that mercurial doesn't handle automatically. The easiest fix (for me) would be to include the vertical stripe fix in the main 1.2.3 builds (otherwise I'll need to commit an extra branch just for this). I can compile it locally, but uploading the zip would take ages from my current location.

I'd say let's review the vertical stripe fix on 1.1.3, and if it's everything alright, I'll include it in the main builds (and fix the 1.2.3 crop build) soon.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Brawl on September 04, 2016, 06:20:37 PM
Hope for the 7D version too please!

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Kharak on September 05, 2016, 11:06:19 AM
I am on holidays these days and brought this build with me for the ride. Two things i noticed is that i got black dots in 1:1 and 3x3 mode. Not sure if this is a known problem or not, i thought the black dots were only in 1:1 mode.

2nd thing i "noticed" is that 1:1 mode is extremely overexposed compared to 3x3, which to my understanding, 1:1 mode should be less sensitive to light. I had ISO 100 and manually set ettr and then I switched to 1:1 mode and everything was overexposed by around 2EV or so. It seemed like ISO 400 even though it was ISO 100. I also tried setting the ISO to 200 and back to 100 thinking, maybe its stuck at some higher iso, but same result. Now, I forgot to pack my ND filter.. So I've bern using the shutter to expose my images, i suppose the shutter might be much lower in 1:1 mode then disayed in the overlay. I think i had shutter 400 something when going in to 1:1 mode and had to put it up to almost 1000 or so to get back to my initial ettr.

Or maybe 1:1 mode is a secret low light beast, haven't tested that yet :) i reverted from the 1:1 for this vacation as i don't wanna deal with black dots in 3x3 mode aswell.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on September 05, 2016, 11:49:02 AM
Hope for the 7D version too please!

7D is unfortunately the hardest model, as it has trouble with many other features that fine-tune image parameters (even the good old FPS override and HDR video). I think it's easier to port it to a model from the same generation (550D is probably the best match), then figure out the dual digic issues.

The first step in porting this is to grab adtg_gui (see first post) and compare the 1080p and 5x video modes. There will be a lot of registers that change their values, but you only need a small subset to configure the crop mode. You need to find it by trial and error; it's very time consuming, but there's nothing to compile, just time to sit down, play with the registers, and write down your findings.

BTW, a while ago I've tried to reproduce Greg's full width LiveView (http://www.magiclantern.fm/forum/index.php?topic=10111.msg123909;topicseen#msg123909) on 5D3 with partial success. There is a 3K video mode preset in adtg_gui, with broken preview. You can, however, use the grayscale preview from the raw recording module. I'm publishing it in this state, maybe some of you can figure out the missing bits.

i got black dots in 1:1 and 3x3 mode.

This was a side effect of the vertical stripe fix. I'll undo that change, because it didn't really fix the vertical stripes (it only made them a little less noticeable, but you still have to fix them in postprocessing).

2nd thing i "noticed" is that 1:1 mode is extremely overexposed compared to 3x3

Probably the other side effect discussed in the vertical stripe thread (linked above). Will double-check, just in case.

I'll prepare new build with the vertical stripe fix removed (back to the good old method).

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on September 05, 2016, 10:10:49 PM
New builds:
- 5D3 1.1.3: magiclantern-crop3x.2016Sep05.5D3113.zip (https://builds.magiclantern.fm/jenkins/job/5D3.113-crop3x-april-1st-edition/12/artifact/platform/5D3.113/magiclantern-crop3x.2016Sep05.5D3113.zip) (build log (https://builds.magiclantern.fm/jenkins/job/5D3.113-crop3x-april-1st-edition/12/console))
- 5D3 1.2.3: magiclantern-crop3x.2016Sep05.5D3123.zip (https://builds.magiclantern.fm/jenkins/job/5D3.123-crop3x-april-1st-edition/11/artifact/platform/5D3.123/magiclantern-crop3x.2016Sep05.5D3123.zip) (build log (https://builds.magiclantern.fm/jenkins/job/5D3.123-crop3x-april-1st-edition/11/console))

Changes:
- synced to main builds
- vertical stripe fix removed (https://bitbucket.org/hudson/magic-lantern/pull-requests/732/5d3-attempt-to-fix-vertical-stripes-so-it/diff#comment-23278056) (no more bad pixels and digital ISO issues)
- minor status icon fix
- backend updates (patchmgr branch)

Indeed, the crop mode appears to clip highlights a bit earlier, but certainly not by 2 stops. The raw histogram shows a difference of about 0.2 ... 0.3 EV on a blank wall.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Lars Steenhoff on September 05, 2016, 11:38:07 PM
thanks alex I will install on the 5d3 to test it out,
the one i used before gave some strange pixels indeed, glad to see that is fixed.

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on September 06, 2016, 01:35:39 AM
Yikes. A lot has happened while I was out on Vacation in the past few weeks. So happy to see you all contributing towards into this Project. Took the 2016Aug23 build for 5D3.113 with me and tested the shit out of it especially while on the plane flying into Chicago.

A few notes that I should point out (which have been confirmed by @Kharak) in regards to the black dots as well as the slightly overexposed while in 1:1 crop mode.

At first I thought it was me or the lens but after double checking and indeed it is slightly OE by .2 or .3 of a stop. Definitely don't think it's OE by 2.0 otherwise it would have been more noticeable.

However, still going through the test files along with the actual footage that I shot while around town (both in H.264 & MLV) and am I insane for thinking that I cannot find any vertical stripes in any of the footage shot in MLV?

I read it that @a1ex's 5D3 isn't showing anything in similar but few others have been affected? Does it mean it may come down to when was the body produced by Canon's factory (newer models versus old?) or what could be the culprit in here?

Ideally I would like to produce it on my end so that way I can test this with the new mlv_dump and whatnot. Also will share my findings/results when I complete this footage together.

Thanks again @a1ex as well as everyone else on board for pushing this particular project forward.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Kharak on September 06, 2016, 09:45:53 AM
Maybe 2 ev was a bit extreme ;) but i was exposing for the sky and a mountain, and more or less everything blew out.

Look forward to try out the new build, when i get access to a computer and sd card reader.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: GutterPump on September 06, 2016, 10:46:26 AM
New builds:
- 5D3 1.1.3: magiclantern-crop3x.2016Sep05.5D3113.zip (https://builds.magiclantern.fm/jenkins/job/5D3.113-crop3x-april-1st-edition/12/artifact/platform/5D3.113/magiclantern-crop3x.2016Sep05.5D3113.zip) (build log (https://builds.magiclantern.fm/jenkins/job/5D3.113-crop3x-april-1st-edition/12/console))
- 5D3 1.2.3: magiclantern-crop3x.2016Sep05.5D3123.zip (https://builds.magiclantern.fm/jenkins/job/5D3.123-crop3x-april-1st-edition/11/artifact/platform/5D3.123/magiclantern-crop3x.2016Sep05.5D3123.zip) (build log (https://builds.magiclantern.fm/jenkins/job/5D3.123-crop3x-april-1st-edition/11/console))

Changes:
- synced to main builds
- vertical stripe fix removed (https://bitbucket.org/hudson/magic-lantern/pull-requests/732/5d3-attempt-to-fix-vertical-stripes-so-it/diff#comment-23278056) (no more bad pixels and digital ISO issues)
- minor status icon fix
- backend updates (patchmgr branch)

Indeed, the crop mode appears to clip highlights a bit earlier, but certainly not by 2 stops. The raw histogram shows a difference of about 0.2 ... 0.3 EV on a blank wall.

This new build + new version of mlv_dump is the perfect combinaison, i just did some tests.

Thanks you Alex for your work.  :)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on September 07, 2016, 05:52:20 PM
More and more stable. Thank you
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: axelcine on September 07, 2016, 07:03:15 PM
Running around with only a few lenses - crop mode does the rest. And when it's time to take out the long lens - WOW! What a tool to have beside the other very important improvements, ML makes to a camera, that is in itself top-o'-the-class. I would SO like for the Canon engineers to appreciate, that we're not cannibalizing the 1-series, but are taking the excellent 5DIII to perform and show all the potential, Canon built into it. If I knew of ML-users in central Jutland in Denmark (Aarhus-area) we'd be drinking champagne and toasting A1ex - again!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on September 07, 2016, 07:15:00 PM
Fully agree. I have filmed some of my finest moments in nature with crop mode. Sharpness and quality when working with high quality glass is top notch.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on September 15, 2016, 05:38:39 PM
I use latest Crop Build. The Auto ETTR although it works, it appears in "ghost mode". The menu item is not highlighted as before.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on September 15, 2016, 06:11:34 PM
What error message do you get at the bottom of the screen?

(when a menu is grayed out, it always prints the reason on the help area)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on September 15, 2016, 07:24:35 PM
You are right. ISO was set in AUTO. Apologies.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Kharak on September 17, 2016, 02:57:14 PM
The highlight clipping in Crop Mode, is this something that will persist or are you working on a fix, Alex?

And do you know why? Is it digital or analog boost?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on September 17, 2016, 03:23:28 PM
I expect this to be solved once I'll finish the CMOS ISO tweaks. I want to do that before the 5D4 port, and already made some progress (check the iso-research commits).
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Kharak on September 17, 2016, 04:05:53 PM
I'll do that
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: JADURCA on September 17, 2016, 11:29:55 PM
I expect this to be solved once I'll finish the CMOS ISO tweaks. I want to do that before the 5D4 port, and already made some progress (check the iso-research commits).

Did I just read, "...before the 5D4 port..."?  :o
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on September 17, 2016, 11:34:43 PM
Check the relevant thread.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: yanki on October 03, 2016, 12:37:35 PM
is it possible to use 3x crop without raw video? (3x crop in h264?)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on October 03, 2016, 12:51:51 PM
http://magiclantern.fm/forum/index.php?topic=17021.msg171821#msg171821

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Lars Steenhoff on October 10, 2016, 02:46:42 PM
I have tested the crop mode on the canon 5d mark 3 and i'm really happy with it.

The only thing I would like to change is the button to activate it.

Now I have to go in the menu and press play two times, and it activated my mlv playback in the camera at the same time.

Then I have to go out of playback mode again.

For example the depth of field preview button could work for me. Or the * button

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: mothaibaphoto on October 10, 2016, 04:10:47 PM
MENU works, as well, without side effects :)
I've made this mod for activation/deactivation with button: https://bitbucket.org/mothaibaphoto/magic_lantern_vold_fork/commits/df0dc87627200d0da52d7952e7ace91e7d2f0184
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on October 10, 2016, 05:47:57 PM
@Lars Steenhoff -- I've thought about that but then I decided to not activate the MLV Playback module in order to bypass this when double pressing play button for crop-mode. Depth of field preview or * buttons would be ideal.

@mothaibaphoto -- excellent mod to use the Menu button instead but then how can one enter the Canon menu when desired?

Just have to be at least out of the ML menu first in prior, correct?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: hyalinejim on October 10, 2016, 08:28:54 PM
An absolute dream come true would be to have a one click on/off button for crop mode. I don't know if this is possible but it would save valuable seconds going in and out of ML menu.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on October 10, 2016, 11:39:04 PM
@a1ex if this module modifies Canon's video modes by altering the sensor area , it's possible modify the area  to get more than 1920x1080 in h264?
THanks   ;)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: mothaibaphoto on October 11, 2016, 08:02:20 AM
@DeafEyeJedi It's not my mod that MENU works. It works on its own the same way as PLAY, just without unessesary playback activation. My mod is to press RATE instead entering menu.
You can download it here - https://bitbucket.org/mothaibaphoto/magic_lantern_vold_fork/downloads

Be careful with that and check commit messages as it contains some more modifications.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Lars Steenhoff on October 11, 2016, 03:26:27 PM
@mothaibaphoto
Thanks for the tip about using the Menu button to activate!
It already saves a bit of time

Now I already use the rate button to get my white balance reading, would it be possible to change your code to make the switch the the depth of preview button?

 
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on October 11, 2016, 03:46:52 PM
Can you set ml white balance reading to the rate button? How? (Not my camera with me)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: mothaibaphoto on October 11, 2016, 04:47:18 PM
@Lars Steenhoff: I don't know, if it possible. I'm newbie in ML and it could takes a lot of time for me to find that button in code and how it works. For now I just don't have time for this. And why do you care about WB? You don't shoot RAW?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Lars Steenhoff on October 11, 2016, 06:19:35 PM
@Danne

In the menu you can set the short cut to the push the set button after pressing rate to measure a white balance reading. ( in live view mode )

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fwww.larssteenhoff.com%2Fforum_pics%2FIMG_9461.JPG&hash=1daa3ef792d179b766a757d2dc7c426b)
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fwww.larssteenhoff.com%2Fforum_pics%2FIMG_9462.JPG&hash=7fa128af6cf62531060eeff66d252647)

@mothaibaphoto

Yes I shoot RAW, this does not mean that i don't want an accurate white balance reading as a starting point for my color correction.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on October 11, 2016, 06:35:37 PM
Gotta check that shortcut button. Thanks for tip.
I agree on seeking correct wb already in cam. Mlv files even sets the different matrix(magenta,green etc). Caveat. Noone knows how to calculate those in post  :P
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: vstrglv on October 11, 2016, 06:44:29 PM
@mothaibaphoto
Thank you very much! Very convenient.
What Nightly Builds do you use? Would you please compile for  magiclantern-crop3x.2016Sep05.5D3113.zip?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on October 11, 2016, 07:43:49 PM
@DeafEyeJedi It's not my mod that MENU works. It works on its own the same way as PLAY, just without unessesary playback activation. My mod is to press RATE instead entering menu.
You can download it here - https://bitbucket.org/mothaibaphoto/magic_lantern_vold_fork/downloads

Be careful with that and check commit messages as it contains some more modifications.

Thanks for this @mothaibaphoto -- I'll take a look at it and test when I can then will share my results. We wouldn't want to sacrifice the RATE button because I find it useful to have the options to choose color profiles for certain situations, right?

Gotta check that shortcut button. Thanks for tip.
I agree on seeking correct wb already in cam. Mlv files even sets the different matrix(magenta,green etc). Caveat. Noone knows how to calculate those in post  :P

Tried that shortcut SET button for Auto WB adjustments which at first seemed like an awesome feature when I first heard about it years ago. It actually does the WB for you under any scenarios as long as you can manage to find a white object. Can be useful for some. But not always. I would say it gets the job done accurately 80-90% of the time more or less.

However, I've learned the hard way that by doing this it will also adjust the WB Shift/Bkt (0,0/+-0) to anything like A5,M4/+-0 or B1, M5/+-0, etc depending on scene which then often times I would forget to go back and set it to default (0,0/+-0) after I prefer to set my own Kelvin's otherwise I end up with a bunch of a strange WB inconsistencies which was a nightmare to fix in the long run.

It's always a good practice to nail down WB at first regardless of which format we shoot in -- even for me.

Unless I'm shooting the whole thing in MLV RAW then none of this matters, right?  :)

 
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on October 12, 2016, 07:33:35 AM
I tried this version. Works very nice.
I get a diference in the bit rate:

- At full HD, with out activate crop 3x, I get 26 Mb/s
- With crop activated, I get 31,19 Mb/s

is the bit rate modified?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Walter Schulz on October 12, 2016, 07:54:56 AM
Check frame rate ...
29.97/25 = 31.19/26
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on October 12, 2016, 08:18:52 AM
25 Fps in both.
Same setting.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Lars Steenhoff on October 12, 2016, 01:46:24 PM
Perhaps because crop mode has slightly more noise and it is therfore harder to compress?
thus resulting in a higher bitrate in h264.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on October 28, 2016, 04:36:58 PM
@rbrune added EOSM to the crop_rec module. Here's the announcement (http://www.magiclantern.fm/forum/index.php?topic=16608.msg173854#msg173854) and pull request (https://bitbucket.org/hudson/magic-lantern/pull-requests/762/crop_rec-add-limited-eosm-support-to/diff). It would be great if a build can be posted on the first post of this thread for EOSM users wanting to try it out and developers interested in tinkering with it.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on October 29, 2016, 11:26:55 AM
Very nice.

Also committed a small usability tweak: you no longer need to exit and re-enter LiveView manually; the video mode is now refreshed shortly after closing ML menu.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Lars Steenhoff on October 29, 2016, 12:15:29 PM
Nice addition Alex!

now I have to learn how to make builds on my mac :)

You mentioned before about a pre record buffer, did you find out any more about this?

I'm really curious how this would work.  like pressing record and having two seconds before I pressed record would be a great feature to use.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on October 29, 2016, 12:18:44 PM
Up until now, in post tools we were identifying the video mode based on the raw buffer size in raw_info. This is important information for things like automatic focus pixel removal and automatic "de-squeezing", and it's probably also just nice metadata to have for users (should I worry about aliasing in this shot? computing effective focal length, etc.). With this module, that is no longer possible, different cropping modes can have the same raw buffer size.

So I propose that part of the change for this new feature should be to add new metadata to the MLV format for horizontal and vertical pixel skipping/binning amount.

Proposal for making crop info available to other modules (please review):

Code: [Select]
struct raw_crop_info {
    /* subsampling factor: (binning_x+skipping_x) x (binning_y+skipping_y) */
    uint8_t binning_x;      /* 3 (1080p and 720p); 1 (crop, zoom) */
    uint8_t skipping_x;     /* so far, 0 everywhere */
    uint8_t binning_y;      /* 1 (most cameras in 1080/720p; also all crop modes); 3 (5D3 1080p); 5 (5D3 720p) */
    uint8_t skipping_y;     /* 2 (most cameras in 1080p); 4 (most cameras in 720p); 0 (5D3) */
    uint16_t offset_x;      /* crop offset (top-left corner) */
    uint16_t offset_y;      /* relative to a full-res silent picture (usually slightly larger than a CR2) */
   
    /* The captured area (described by raw_info) will be:
     *   left  : offset_x
     *   top   : offset_y
     *   right : offset_x + raw_info.width  * (binning_x+skipping_x)
     *   bottom: offset_y + raw_info.height * (binning_y+skipping_y)
     */
};

This would be visible to all ML modules (just like raw_info). For MLV files, we could add a new block (CROP) with exactly the same structure.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on October 29, 2016, 12:30:24 PM
...This would be visible to all ML modules (just like raw_info). For MLV files, we could add a new block (CROP) with exactly the same structure.
Indeed this would be a really nice proposal @a1ex!  8)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on October 29, 2016, 12:42:41 PM
now I have to learn how to make builds on my mac :)

http://www.magiclantern.fm/forum/index.php?topic=16012.0

Comment on that topic or PM me with any issues and I'll try to walk you through it.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on October 29, 2016, 07:13:03 PM
Some quick and dirty test with crop_rec.mo from the EOSM (http://www.magiclantern.fm/forum/index.php?topic=16608.msg173854#msg173854EOSM) (Thanks @rbrune) at ISO 3200 in 29.97p (1600x692p) with a 50L in MLV last night.


Where'd the Focus Pixels (http://www.magiclantern.fm/forum/index.php?topic=16054.0Focus Pixels) go? I think I can still seem them but they are literally minimal to the extreme.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on October 29, 2016, 07:20:29 PM
That is great footage. And no focus pixels!? Can,t say I miss them :P.
Thanks for sharing. Glad to own an eos m. Looks bad ass.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: daniel@danielchamorro.com on October 30, 2016, 02:31:21 AM
Sorry because my english is not very good and I really cant find anything about that. too many forums and topics.

1 - Can anybody tell me please if in the last nighlty build for 5d MARK 2 can we shoot RAW in FULL HD? or at least in 1920x any panoramic 2,35 or 2,39 panoramic? Or maybe for that we still need crop mode?

2 - In this case we need crop mode in 5d M2, can now do a proper live view framing without this horrible black and white with 3 frames per second that we had before?

3 - in this last nigtly view can we proper test in play any clip in RAW or is also jumping and difficult to check?

Thanks and congratulations for the hard work!

DANI
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on November 14, 2016, 12:05:07 AM
Found a way to center the raw buffer and Canon's preview window in the "classic" crop mode - the one triggered by x5 zoom. Advantage: higher resolution.

5D3 registers:

For centering the raw buffer:
Code: [Select]
    cmos_new[1] = PACK12(9+2, 42+2);    /* vertical (first|last) */
    cmos_new[2] = 0x09E;                /* horizontal offset (mask 0xFF0) */

For centering Canon preview:
Code: [Select]
    {0xc0f3,   0x83d4, 0, "Preview area (y1 | x1/4)"},  /* similar to raw_info.active_area */
    {0xc0f3,   0x83dc, 0, "Preview area (y2 | x2/4)"},

Resizing Canon preview doesn't seem to work, so for the 5x zoom mode, the preview will be centered, but the coverage will not be exact. At least until somebody figures out how to resize the YUV buffer.

There are hints that raw buffer size might be adjustable (http://www.magiclantern.fm/forum/index.php?topic=10111.msg123909#msg123909) in the 5x zoom mode.

(side note: actual crop factor in 5x zoom mode is not 5x - it depends on the raw recording resolution)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: hyalinejim on November 14, 2016, 10:25:17 AM
You are the man, a1ex! This is a great aid for getting precise rectilinear compositions at higher resolutions. Prior to this it was like trying to use a shift lens in the horizontally offset position. It's also a boon for those wishing to use anamorphics without one side being heavily vignetted.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on November 14, 2016, 10:51:07 AM
Ouch, not exactly the easiest workaround.

2nd thing i "noticed" is that 1:1 mode is extremely overexposed compared to 3x3

I've just found an overexposure bug when using FPS override (actual exposure time is incorrect, usually higher than expected). Were you using it when you had the issue?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on November 14, 2016, 11:04:41 AM
Thanks to all people that contribute.
Any recent build with the new crop developments ?
Thank you
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on November 14, 2016, 09:12:42 PM
Just committed the centered 5x zoom, the overexposure fix, and some refactors to ease porting to other camera models. EOS M support is included too (thanks rbrune).

Test build coming after feedback from those who understand the code :)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on November 15, 2016, 09:13:16 PM
Great work my King!  ;D
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: nikfreak on November 28, 2016, 05:17:25 PM
just discovered that you are reading out old hardcoded values for edmac_raw_slurp now automagically via the registers. Probably you will be using this technique and adding the skip values for centering x5-zoom on all cameras later, right?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on November 28, 2016, 05:31:27 PM
just discovered that you are reading out old hardcoded values for edmac_raw_slurp now automagically via the registers. Probably you will be using this technique and adding the skip values for centering x5-zoom on all cameras later, right?

+1
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on November 28, 2016, 05:36:19 PM
Right, this covers all video modes without having to hardcode them.

Still need one camera-specific constant: the multiplier for horizontal resolution (I guess it's number of columns read out in parallel, and I believe it's the same for all video modes). Known range: from 1 (500D) to 8 (5D3). Also, older cameras use 0xC0F0608[04] instead of 0xC0F0680[04].
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: nikfreak on November 28, 2016, 09:13:37 PM
Quote
static unsigned int crop_rec_init()
{
    if (is_camera("5D3",  "1.1.3") || is_camera("5D3", "1.2.3"))
    {
        /* same addresses on both 1.1.3 and 1.2.3 */
        CMOS_WRITE = 0x119CC;
        MEM_CMOS_WRITE = 0xE92D47F0;
       
        ADTG_WRITE = 0x11640;
        MEM_ADTG_WRITE = 0xE92D47F0;

typo or unique 5D3 thingie?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on November 28, 2016, 09:16:49 PM
Both functions happen to start with the same instruction. Didn't check other cameras.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on December 01, 2016, 11:53:53 AM
Felt this (http://www.magiclantern.fm/forum/index.php?topic=13163.msg175776#msg175776this) was worth sharing.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on December 18, 2016, 05:39:59 PM
Does the latest NightBuild 18 Dec 2016, includes the new Crop mode ?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Walter Schulz on December 18, 2016, 05:46:46 PM
?
Latest Build date is 2016Dec03.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on December 18, 2016, 06:04:06 PM
Dunno, maybe was withdrawn. I downloaded it but didnt test it.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Walter Schulz on December 18, 2016, 06:22:27 PM
I doubt you downloaded something from the main branch. You should be able to determine the download link.
Something like
https://builds.magiclantern.fm/jenkins/job/<camera type>.<firmware version>/<build number>/artifact/platform/<camera type>.<firmware version>/magiclantern-Nightly.2016Dec18.<camera type><firmware version>.zip
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on December 18, 2016, 09:53:06 PM
I have it handy.
If someone wants the today version, I dont mind sending it to him
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Walter Schulz on December 18, 2016, 10:01:31 PM
I hope it was build after g3gg0 re-edited his changes ...
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Julien on December 21, 2016, 02:34:50 AM
First, Big up to all developers and all ML community including @Hans_Punk, @Danne, @a1ex, and the rest.

Second point, sorry for my level in english. It's not as well as I want.

Third, I try 3x crop mode on my 700D/T5i Rebel and it works good.
My question or better my wish, is to know if it's possible to have a variable/graduate crop mode module with ML or may be to develop this kind of possibilities?

What I mean when I talk about graduate crop mode?
With ML, 3x crop mode transform a 5O mm F1.4 lens in 150 mm for the same aperture.
I need a smaller extensions/crops like 1.4x crop or 1.6x crop or 2x crop which become 70 mm , 80 mm or 100 mm with the same 1.4 aperture.
It's like extension tubes or extender teleconverter, but numericaly with less or without loss of light in high magnification and disfraction of lights.
In fact,
 - 50mm lens + 20mm extension tubes or 1.4 extender = 70mm
   70 x f/1.4 = 98 divided by 50mm = f/1.96

What kind of utilities can we have with a graduate crop mode (x1.4/x1.6/x2)?
For instance, I use B4 2/3'' Angénieux and Fujinon lens.
Both have analogic extender (x2). The M4/3's digital camera sensor is full covered. No problem with a  Panasonic GH4 for instance.
If I use this kind of lens with my Canon T5i/700D, the APS-C sensor is not ful covered. There are small vignetting.
I think the sensor could be all covered with x1.4 or x1.2 crop.

That's why I ask this kind of new features in the developement of Magic Lantern crop mod.
Do you think it coulb be possible?

Thanks for reading
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: vstrglv on December 21, 2016, 10:14:30 AM
I have tried to merge Unified into crop_rec branch but failed. There are many conflicts. It is very useful if somebody post a tutorial how to  merge Unified into crop_rec branch, because crop_rec.mo is very, very useful.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on December 21, 2016, 10:55:05 AM
How are you merging? Source tree? Usually I create a branch of unified then I merge crop_rec into my branch through source tree.
If you,re on mac you could post your workflow descriptions, questions and findings here.
http://www.magiclantern.fm/forum/index.php?topic=16012.msg155422#msg155422
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on December 22, 2016, 06:18:21 PM
Looks like this worked for @vstrglv

Code: [Select]
hg update unified
hg pull
hg branch unified_crop_rec
hg merge crop_rec
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: vstrglv on December 22, 2016, 09:36:57 PM
Yes it works! Thanks to dfort. Tested on 5D3.113, OK until now.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: clement2 on December 22, 2016, 11:27:27 PM
Is there any chance I can get the latest build version with the last update crop mode module? I am idiot on programming. I am 5d3.113. thx.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on December 23, 2016, 08:23:52 PM
@ A1lex and Greg
Fantastic module!  I use it 99% of the time..  and thanks for providing it for 5D3-1.23 firmware.
Thanks for dedication and hard work.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: aschille84 on December 24, 2016, 12:39:04 AM
Yes it works! Thanks to dfort. Tested on 5D3.113, OK until now.
@vstrglv Care to share a test build? Still working with crop_rec and 10/12-bit?


Sent from my iPhone using Tapatalk
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on December 24, 2016, 04:46:20 AM
https://bitbucket.org/daniel_fort/magic-lantern/downloads
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Surin Dmitriy on December 24, 2016, 11:40:43 AM
https://bitbucket.org/daniel_fort/magic-lantern/downloads

Is it possible to add crop_rec module to 1.1.3 also? I find it only for 1.2.3 inside.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: GutterPump on December 24, 2016, 01:06:57 PM
Is it possible to add crop_rec module to 1.1.3 also? I find it only for 1.2.3 inside.

Very interested in this possibility also.

crop_rec + 10 - 12bits RAW will be a great combo.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on December 24, 2016, 07:27:51 PM
Ok--here you go:

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-raw_video_10bit_12bit_crop_rec.2016Dec24.5D3113.zip

Please report your findings.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: GutterPump on December 24, 2016, 08:14:05 PM
Ok--here you go:

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-raw_video_10bit_12bit_crop_rec.2016Dec24.5D3113.zip

Please report your findings.

Thanks a lot, i will make some tests tommorow. Even if it's Christmas i don't care, ML is the priority  8)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: vstrglv on December 24, 2016, 08:58:40 PM
Ok--here you go:

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-raw_video_10bit_12bit_crop_rec.2016Dec24.5D3113.zip

Please report your findings.
Thank you very much!
Quick test - frame issue:
10bit,12bit, crop1:1 and not crop mode - preview framing during recording  is not correct. All screen is filled.
Sometimes this issue takes place in 14bit mode too. I could not find a regularity.   
This issue takes place sometimes on my merged crop_rec in Unified on Dec22.2016 too.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on December 25, 2016, 05:18:23 PM
FYI,
crop.rec module does not load on 5D3.123  It gives module error.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: rrrmusic on December 28, 2016, 10:35:52 PM
I have the same problem that RenatoPhoto reports on magiclantern-raw_video_10bit_12bit.2016Dec20.5D3123

crop.rec module does not load on. It gives module error.

when i do the start/stop of recording with mlv_rec module I get this message:
Hack error at 0:
excpectede3a00032, got e1a00000
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on December 29, 2016, 08:36:09 AM
Looks like that 10bit/12bit combined with crop_rec for the 5D3.123 I compiled had a problem. crop_rec should work with the 5D3.123 so let's try a build without the 10bit/12bit.

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-crop_rec.2016Dec28.5D3123.zip

If this works then we can take the next step and merge in 10bit/12bit.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on December 29, 2016, 01:14:42 PM
@dfort

Yep magiclantern-crop_rec.2016Dec28.5D3123.zip works very well..  ;D
Looking forward to the new version.. great work!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on December 29, 2016, 05:08:34 PM
Yep magiclantern-crop_rec.2016Dec28.5D3123.zip works very well..  ;D

Alright, let's take the next step. I might have resolved the merge conflicts improperly last time. Hope it works this time:

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-5D3-123_crop_rec_10bit_12bit.2016Dec29.5D3123.zip
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on December 29, 2016, 06:17:06 PM
No success!
The modules load but mlv_rec or raw_rec recording do not work and put the camera in some error.
Crash log 1:
ASSERT: hLvJob->hJpegMemSuite
at ./Epp/Vram/VramStage.c:891, task Epp
lv:1 mode:3

Magic Lantern version : Nightly.2016Dec29.5D3123
Mercurial changeset   : 48d29e058105+fcadac0113e1+ (5D3-123_crop_rec_10bit_12bit) tip
Built on 2016-12-29 16:01:57 UTC by rosiefort@RosieFoComputer.
Free Memory  : 158K + 3755K

Crash log2:
ASSERT: IsSuiteSignature( hSuite )
at ./PackMemory/PackMem.c:599, task Epp
lv:0 mode:3

Magic Lantern version : Nightly.2016Dec29.5D3123
Mercurial changeset   : 48d29e058105+fcadac0113e1+ (5D3-123_crop_rec_10bit_12bit) tip
Built on 2016-12-29 16:01:57 UTC by rosiefort@RosieFoComputer.
Free Memory  : 158K + 3764K
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: rrrmusic on December 29, 2016, 06:20:08 PM
All modules loaded with magiclantern-5D3-123_crop_rec_10bit_12bit.2016Dec29.5D3123.zip but i experimented a lot of crashes.

Link with the Logs
https://drive.google.com/open?id=0BzDsfba1S_rgbTI5NEFzMHdIOUk
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on December 30, 2016, 02:09:48 AM
Put up a new build for 5D3.123

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-5D3-123_crop_rec_10bit_12bit.2016Dec29.5D3123.zip

If you're interested in seeing what's being changed on the test build, follow this:

https://bitbucket.org/daniel_fort/magic-lantern/commits/branch/5D3-123_crop_rec_10bit_12bit
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on December 30, 2016, 02:47:01 AM
@dfort

Negative.. Modules loaded but I have problems accessing ML menu after I flipped the video switch.  Also on the first video switch it took a little long for the video to show up..
Had to reboot no Crash log.

I will be back to check in a week... going on a birding trip..  :D :D  Was hoping to test new crop_rec with 10/12 bit  :(
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: rrrmusic on December 30, 2016, 03:05:37 AM
@dfort errors continues

CRASH00.LOG
ASSERT: hLvJob->hJpegMemSuite
at ./Epp/Vram/VramStage.c:891, task Epp
lv:1 mode:3


Magic Lantern version : Nightly.2016Dec29.5D3123
Mercurial changeset   : d33ea8074da3+ (5D3-123_crop_rec_10bit_12bit)
Built on 2016-12-30 01:00:40 UTC by rosiefort@RosieFoComputer.
Free Memory  : 147K + 3557K


CRASH01.LOG
ASSERT: IsSuiteSignature( hSuite )
at ./PackMemory/PackMem.c:599, task Epp
lv:0 mode:3


Magic Lantern version : Nightly.2016Dec29.5D3123
Mercurial changeset   : d33ea8074da3+ (5D3-123_crop_rec_10bit_12bit)
Built on 2016-12-30 01:00:40 UTC by rosiefort@RosieFoComputer.
Free Memory  : 147K + 3565K


CRASH02.LOG
ASSERT: IsSuiteSignature( hSuite )
at ./PackMemory/PackMem.c:983, task RscMgr
lv:0 mode:3


Magic Lantern version : Nightly.2016Dec29.5D3123
Mercurial changeset   : d33ea8074da3+ (5D3-123_crop_rec_10bit_12bit)
Built on 2016-12-30 01:00:40 UTC by rosiefort@RosieFoComputer.
Free Memory  : 147K + 3567K


CRASH03.LOG
ASSERT: fInitialize == TRUE
at ./System/PostPostman/PostPostman.c:243, task Epp
lv:0 mode:3


Magic Lantern version : Nightly.2016Dec29.5D3123
Mercurial changeset   : d33ea8074da3+ (5D3-123_crop_rec_10bit_12bit)
Built on 2016-12-30 01:00:40 UTC by rosiefort@RosieFoComputer.
Free Memory  : 147K + 3567K
 
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on December 30, 2016, 04:14:32 AM
I took down the non-working build.

This previous build also has the crop_rec module and over 100 downloads. Please verify that crop_rec isn't working with 10bit/12bit:

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-raw_video_10bit_12bit.2016Dec20.5D3123.zip

crop_rec is a module and you should be able to add it from any other build so if it isn't working there may be some back end modifications that need to be done specific to the 1.2.3 firmware. There's a working version on the first post but looking at the date I wonder if it is an April Fools joke:

https://builds.magiclantern.fm/jenkins/job/5D3.123-crop3x-april-1st-edition/3/artifact/platform/5D3.123/magiclantern-crop3x.2016Apr01.5D3123.zip

In any case I'm going to back away and see if someone with a 5D3 running 123 firmware can attempt to merge raw_video_10bit_12bit with crop_rec.



Title: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: rrrmusic on December 30, 2016, 07:38:04 AM
I tried this build before and reported in reply #207.

Will be great to have a working build with crop_rec And 10/12 bit raw with 5d3 123.
I used external monitor And recorder so i need clean hdmi.
Please Do not give up [emoji57]
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on December 31, 2016, 04:23:02 AM
Not giving up yet. Found a really basic mistake--I still had the DEFAULT_RAW_BUFFER for the 5D3.113. Let's give this another shot.

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-5D3-123_crop_rec_10bit_12bit.2016Dec30.5D3123.zip
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: rrrmusic on December 31, 2016, 05:45:29 AM

@dfort
Things are better but need more work  :)
My first reports using magiclantern-5D3-123_crop_rec_10bit_12bit.2016Dec30.5D3123

10/12 bit works with raw_rec full frame but with crop mode the camera crash.
ASSERT: hLvJob->hJpegMemSuite
at ./Epp/Vram/VramStage.c:891, task Epp
lv:1 mode:3

ASSERT: IsSuiteSignature( hSuite )
at ./PackMemory/PackMem.c:599, task Epp
lv:0 mode:3

ASSERT: IsSuiteSignature( hSuite )
at ./PackMemory/PackMem.c:983, task RscMgr
lv:0 mode:3

Crop Mode works well with H.264
Mlvrec gives a hack error when start to record in full frame and crop mode
Hack error at 0:
expected e3a00032, got e1a00000


Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on December 31, 2016, 07:41:40 PM
@rrrmusic

Do you get those crashes with 14 bit recording or just with 10/12 bit? How is it working when you aren't using the crop_rec module?

Looks like there were also issues with the 5D3.113 when crop_rec and raw_video_10bit_12bit were merged so this might be a problem that needs someone with a deeper understanding of what's going on.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: rrrmusic on December 31, 2016, 09:21:01 PM
@dfort
Hi i did more tests today

raw_rec 10bit and 14bit both works well at the moment no crashes in full frame and crop   :o
Turn it off the camera

Same test with mlv_rec
Hack error at 0:
expected e3a00032, got e1a00000
gaves this error but continue to records the movie. Sometimes the movie is fine and others with a complete black and green movie.

The only difference before yesterday tests is when i use raw_rec 10/12bit i disabled mlv_rec module.

Maybe the crashes before was the mlv_rec.
I will continue to do more tests and if you want to do a specific test let me know.
Happy New Year  :)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on December 31, 2016, 10:35:31 PM
So the problems is only with mlv_rec? raw_rec (which is MLV Lite in this build) is fine?

Try it the way we know it should work--no crop_rec and 14 bit. Then try 10bit/12bit without crop_rec. Finally, run that test again with crop_rec.

There were some merge conflicts with mlv_rec and maybe I made the wrong assumptions when resolving them. Also, g3ggo made some fixes on mlv_rec that should have made it into this build but I should double check it.

In any case, we need to verify that raw_rec is playing nicely with crop_rec so we can narrow down the problem.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on January 01, 2017, 12:24:08 AM
@rrrmusic -- just double checking you didn't load both mlv_rec.mo and raw_rec.mo at the same time, correct?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on January 01, 2017, 12:40:01 AM
@DeafEyeJedi -- just noticed from your signature that you're using 123 on your 5D3, is that right? This is the build we're testing:

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-5D3-123_crop_rec_10bit_12bit.2016Dec30.5D3123.zip

You can get it from my repository too:

https://bitbucket.org/daniel_fort/magic-lantern/commits/branch/5D3-123_crop_rec_10bit_12bit
Title: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on January 01, 2017, 12:47:26 AM
It may not be. Usually I go back and forth for testing purpose or depending on certain gig's requirements but at the moment it's still on 113. If so, then I can upgrade easily in camera.

The 5D3 is at home and am currently on the road driving back from visiting the grandparents. Will do this tonight and report back my findings!
Title: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: rrrmusic on January 01, 2017, 02:01:37 AM
@rrrmusic -- just double checking you didn't load both mlv_rec.mo and raw_rec.mo at the same time, correct?
At the same time off course not and one of the test that i did with the mlvrec module completely disabled
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 06, 2017, 04:39:22 PM
@Alex:  This is the best module and have been using for my bird videos.
The build you provided : magiclantern-crop3x.2016Apr01.5D3123.zip  is very good and stable.  I have been using exclusively without any problems.
Best regards and much appreciation for your work.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: NoCp_Albert on January 07, 2017, 09:12:27 AM
@Alex and RenatoPhoto

even for the same use on bird and nature video I use the last version from Alex - 5D3 1.2.3: magiclantern-crop3x.2016Sep05.5D3123.zip (build log). I used it since September without any problems.
Thanks very much for your work.

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: ewinemiller on January 07, 2017, 07:07:23 PM
I'm using dfort's 5d3 1.13 build from 12/24. The new 5x centered crop mode, 10 bit RAW, and 2880x1320 with the SLR Magic anamorphot adapter on the front might become my new favorite way to shoot. Continuous recording works fine and the results look really good.


Right now about every 4th or 5th shot results in the black levels being trashed and the fix black level in mlv dump doesn't seem to help. There are other corruptions of the video when that happens so I think it's more than just the black level.

Having said that, 4kish RAW video from a 4.5 year old camera is freaking awesome.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on January 07, 2017, 07:36:05 PM
Recorded with or without greyscale preview on? Have you tested with previous builds? Better results?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: ewinemiller on January 08, 2017, 01:02:48 PM
Recorded with or without greyscale preview on? Have you tested with previous builds? Better results?

I did not use greyscale preview. Looks broken in that build with that combination of settings.

This was the first build I found that combined crop mode and 10 bit recording so I didn't try this before. I couldn't have got continuous recording on 14bit.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on January 08, 2017, 06:09:14 PM
Iso values are not changing with wheel, or joystick, or whatever you use... even in Iso button on camera top, or ML menu.

5D mark III, 1.1.3 Build 2016-09-05 19:59

Edit: I put out ML Card, reset factory settings. Battery out. Check the wheel without ML and camera works fine. I am using other ML build.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on January 09, 2017, 09:47:00 AM
This is one great module.
I tried with a late compile yesterday and iso was changed while recording over here while recording in crop mode. Anybody else maybe can test this as well?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 09, 2017, 06:31:37 PM
@A1lex:
I think 5D-123 should be listed on the crop module experiments:
https://builds.magiclantern.fm/experiments.html

I have used it for a while and it is GREAT!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: NoCp_Albert on January 09, 2017, 08:14:03 PM
Today I try also the 5D3-113 Module from dfort - magiclantern-raw_video_10bit_12bit_crop_rec.2016Dec24.5D3113. I try the crop Mode with the 5x centered crop and after a few changes in my settings it was working very god without corrupted Files. I made perfect clips with 2880x1320-10 bit, 15sec, 25fps and with 2400x1320, 10bit, 25fps it works continual. I prepare at the moment a video with some sequences and the ML settings.
I believe there was also a version for the 5D3-123 from dfort, but I don’t save it to try it out. Maybe someone get id for download again.

The charm one this 10bit-crop-record version against the Standard Crop mode Module from September 2016 what I normaly use is to use also the 10bit Version with higher resolution. What I see today is one of the best results and simular to the Crop-Mode, also the colors and resolution don’t need big corrections in ACR Lightroom, everything looks perfect for me.

Sorry for my bad english
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on January 09, 2017, 10:24:19 PM
Can we add the module crop mode usefull for h264/RAW, to the build RAW 10/12 bits?

5D Mark 3 Firmware 1.1.3
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on January 10, 2017, 01:01:40 AM
I have made special builds that combined crop_rec with 10/12bit for the 5D3.113 and 5D3.123 but have had limited success. There are some 5D3 users who now have development systems running and have expressed an interest in taking over these special builds. Great news because they can test them before posting.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on January 10, 2017, 01:07:35 AM
compiled this for 5D mark III (1.1.3) yesterday.(crop_rec 10bit/12bit)
https://bitbucket.org/Dannephoto/magic-lantern/downloads/magiclantern-Nightly.2017Jan08.5D3113.zip
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on January 10, 2017, 04:59:06 AM
@Dfort

thank you for the explanation.

I can make test if you need and report back. I don't have skills to programming, but for film is my everyday job.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on January 10, 2017, 08:41:01 AM
@A1lex:
I think 5D-123 should be listed on the crop module experiments:
https://builds.magiclantern.fm/experiments.html

I have used it for a while and it is GREAT!

Looks like he heard you. Check it out.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: NoCp_Albert on January 10, 2017, 08:59:51 AM
@dfort

my help can only be testing and report back to, I am an old photographer but following Magic Lantern for Video especially with crop mode over 4 years now. I work on WIN 10 and Adobe Cloud with Lightroom, PS, AE and Premiere Pro, but programming isn’t my Job. I use the Canon Firmware 113 and 123, change the Firmware is every time possible. So if you need testing something special an the 5d3 let me know. About the test I made yesterday here is a small video shows you my settings and a few clips with the result.
From MLV to DNG I use MLV Mystic, raw2cdng 17.9 and MLV Producer. Best results I get with MLV Mystic and ACR / Lightroom. Because I am a Nature and Bird photographer not so interested in LUT´s and Movie optic.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on January 11, 2017, 08:17:20 AM
@NoCp_Albert

If you check my profile you'll see that I'm also an old photographer. First of all, wow--you've got a lot of modules loaded. You aren't experiencing any issues with that? I also noticed that you are running one of the crop_rec/10bit-12bit builds that reportedly wasn't working though it seems to work for you. Are the tests you posted using the 113 or 123 firmware?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: NoCp_Albert on January 11, 2017, 07:03:23 PM
@dfort
Hi Daniel, in one of your Treads in the last Days you write about a "April joke" meaning some different reports from Testers. I don’t understand all the Programming Details in many Treads and I believe many others ML Interessted User got the same Problem. But I cut feel that you was not satisfied about the different reports about the Testing Modules you offer to bring the Crop mode and 10,12-14 Bit Mode together.

Let me say since 4 Years I use more or less ML Modules anthill I found with the 3xCrop Mode exactly what I need and looking for, especially for the 5D3-123 Firmware, because I use a Field monitor for manual focusing the small Birds on bigger distances. With my 65 years old Eyes the Monitor is a big help. I use Lenses from 12 to 100-400mm and 600mm or 840mm with T-Converter and the 3xcrop Mode works perfect for my Bird documentaries.

I read your Reaction and ask myself what I can do to help by testing especially for the 5D3 with 123 Firmware. So I change the Firmware from 123 to 113 and test the last December Modules where 5xcentered Crop and 10, 12 and14 bit is together. Id needs a bit to understand the workflow, but now I got it. Today I was out in the Fields around Paphos – Cyprus and test it in the real World. I used MLV with Sound and Auto ETTR, the Module works without Problem in the way I used. The Colors and Withe balance are nearly ok when I open the MLV in Lightroom, only small corrections in the Highlights.

So if you need Testing and reports back let me know, it will be a pleasure for me to help for ML.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on January 11, 2017, 08:27:18 PM
If you go to the build log (https://builds.magiclantern.fm/jenkins/job/5D3.113-crop3x-april-1st-edition/12/consoleText) for the crop_rec experimental builds you'll see that the build is from a branch called, "5D3.113-crop3x-april-1st-edition" which isn't in the main repository as far as I can tell.

There is an April 1st easter egg in the code but it has nothing to do with this topic--except maybe if it is April 1st.

You're using an 840mm with a tele converter in 3x crop mode? Whoa!

There are lots of reasons to use the 1.2.3 firmware, this is what Canon says about the update from 1.1.3 to 1.2.3:

Quote
Changes in Version 1.2.3:
1. Fixes a phenomenon in which the flash may not fire depending on the timing of when the shutter button is pressed.
2. Fixes a phenomenon in which the AF microadjustment value may change.
3. Fixes a phenomenon in which the LCD monitor may show a line of false color along boundaries of high contrast.
4. Fixes a phenomenon in which the histogram of a LiveView image is incorrectly displayed when an HDMI cable is connected.
5. Enables the brightness of the camera's LCD monitor to be adjusted even when an HDMI cable is connected.

Changes in Version 1.2.1:
1. Uncompressed HDMI output is now enabled.
2. Enables the center AF point to autofocus when the camera is used with Canon EF lens/extender combinations whose combined maximum aperture is f/8.
3. Improves the speed of the camera's acquisition of focus when using a Canon Speedlite's AF-assist beam.
4. Fixes a phenomenon in which the LCD monitor may freeze and display Err 70 or Err 80 when a still photo is taken during Live View or in movie shooting mode.
5. Fixes a phenomenon that may occur when the continuous shooting priority setting is enabled for multiple exposures, such that, after the sixth image is taken, there is a slight pause before the remainder of the sequence is completed.
6. Fixes a phenomenon in which the viewfinder display shows incorrect information during AEB shooting.
7. Communication with the WFT-E7 Wireless File Transmitter has been improved.
8. When images have been successfully transferred with the WFT-E7 Wireless File Transmitter through the FTP protocol, an "O" will be displayed. When images have not been successfully transferred with the WFT-E7 Wireless File Transmitter through the FTP protocol, an "X" will be displayed.
9. Fixes a phenomenon in which the camera may not function properly when an Eye-Fi card is used.
10. Fixes a phenomenon in which the focal length value listed in the Exif information is not displayed correctly for images shot with the EF 24-70mm f/4L IS USM lens.
11. Fixes a phenomenon in which the lens firmware cannot be updated properly.
12. Corrects errors in the Arabic language menu.
13. Fixes a phenomenon in which the camera changes the AF microadjustment value to -8.
14. Fixes a phenomenon in which the on-screen guidance cannot be fully displayed when setting the maximum limit value for the "Setting the ISO Speed Range for Auto ISO" option.

The part about tele extenders and lenses with maximum apertures of f/8 might be affecting you.

If you do find an issue in 1.2.3 it would be a good test to see if you can reproduce it in 1.1.3.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on January 12, 2017, 04:59:12 AM
@NoCp_Albert

Share something for watch!!!! Very interesting!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on January 12, 2017, 06:49:46 AM
He did, back on Reply #240 (http://www.magiclantern.fm/forum/index.php?topic=17021.msg178010#msg178010):


Looks pretty solid to me.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: NoCp_Albert on January 12, 2017, 10:58:57 AM
@A1lex and dfort

I like to test this Module magiclantern-raw_video_10bit_12bit_crop_rec.2016Dec24.5D3113 also on the 5D3-123 Firmware, where can I find this Test module. In the new https://builds.magiclantern.fm/experiments.html is only the crop module from September 2016 which I use normally because it works perfect. I found one modified Crop Module from dfort - magiclantern-crop_rec.2016Dec28.5D3123.zip which includes the 5x centered Crop from @A1lex but without the possibility to go down with the Bit rate it is useless. The 3xcrop mode works exactly like the crop modules from September 2016. I understand, that most Modules are made for normally Videos and not for Nature documentaries, but maybe I can get the last mixed Crop with 10, 12,14 Bit for Testing on the Canon 5D3-123 Firmware as well to test it.

@A1lex:
If possible I like to find on the Experimental raw video recording site also a testing file for 10, 12, 14 Bid recording with 5D3 – 123 Firmware.

@dfort: at the moment I test your magiclantern-raw_video_10bit_12bit.2017Jan05.5D3123, my biggest Problem is the 5x centered Crop, because it is not centered. When I switch from normal to 5x centered Crop the AF point is moved like in the old Modules and not useable at all, If I an hurry during recording and get different AF points I lousing the trust in my one work and later the footage is not useable at all. In your Crop Module from 28 December with the included 5x centered Crop the AF works centered in all Crop modes.

And hier some more Video proposual how shows how importand the Crop mode for some Useres is.

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on January 12, 2017, 02:29:46 PM
Added builds for 5D3 1.1.3, 1.2.3 and EOS M 2.0.2, including 10/12-bit raw video support, to the Experiments (http://builds.magiclantern.fm/experiments.html) page.

Unfortunately they are 100% untested => please report.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 12, 2017, 03:47:28 PM
 ;D ;D ;D ;D ;D ;D ;D  Thank you A1lex!  You are the man!

Testing: magiclantern-crop3x.2017Jan12.5D3123
mlv_rec and mlv_sound modules missing.. not done yet I suspect!

Working beautifully.. here are underexposed samples.  Post process at +4EV
Note that BlackFix 2048 give skin tones and eye color similar to 14 bit

14 bit:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fs20.postimg.org%2Fr24q90ip9%2F14_BIT.jpg&hash=92bad59ebb9478d3258444e3be69f42c)

12 bit:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fs20.postimg.org%2Fojj18bwz1%2F12_BIT.jpg&hash=64d987025a721cd752a83cb8e35f35c9)

10 bit:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fs20.postimg.org%2Fhp454wey5%2F10_BIT.jpg&hash=bd58a7b3d5f6c3d8b6ada96c9f9e0b61)

10bit BlackFix 2040:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fs20.postimg.org%2Fgbh3nc52l%2F10_BIT_BLACKFIX2040.jpg&hash=2769e4753c084d91990687a59ef01632)

10 bit BlackFix2048:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fs20.postimg.org%2Frcc8scxbh%2F10_BIT_Black_Fix2048.jpg&hash=9a3a1d73bd6293ef0379c5cc674410f5)

Final Comparison 10 vs 14 bit and BlackFix:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fs20.postimg.org%2F66ifxrmi5%2F14bit_vs_10bit_Blackfix.jpg&hash=441efb35949e6f04b060e41cef89ef6e)

I am Preparing a video of my garden at 10 bits...
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: NoCp_Albert on January 12, 2017, 04:20:29 PM
@A1lex, thank you for the new test crop modul 12.01.2017.

Just make a quick test, got some coruptet files and flickering during 5xcroped recording.

Will make a short video with al settings for you.

About Renatophoto record, maybe it is possible to make the correction of Black level directly in this module
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on January 12, 2017, 04:29:38 PM
 - In Preview Option, in Raw menu, I set Canon instead Auto or ML Grayscale. Except the bars overlay, the image its solid and centered for shoots.

- if you load rawRec.mo and Mlvsound, you get errors in all modules. I am using mlvrec.mo

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on January 12, 2017, 04:36:58 PM
You can,t run raw_rec and mlv sound at the same time.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 12, 2017, 05:04:20 PM
Problem found: With zebras enabled the Auto ETTR changes exposure during recording..  in the first few frames.. sometimes it settles with over exposure.

Otherwise crop rec module working very well.  Video recorded with:
AETTR (Always ON)
Zebras Off
Crop module  (3X 1080/720p)
1920x1080 at 30 fps

Post with ACR and Vegas pro 13

Unfotunately Youtube does lower the quality.. and I exceeded my Vimeo account.  Looks better on computer.

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: GutterPump on January 12, 2017, 05:15:37 PM
Even with YT compression, the footage is very clean ! Well done !
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 12, 2017, 05:48:38 PM
The exposure flickering happens with or without zebras... It seems to happen when the recording button is pressed before Auto ETTR has finished settling its exposure.
Was able to catch it in this video and later reproduced if start button was pressed while AETTR is still changing.
Also minor problems:
1. Notice the exposure flickering after stop button is pressed.
2. Notice how the Raw Histogram changes during recording to wrong settings.


Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on January 12, 2017, 09:53:03 PM
BUILD3x_JAN12 5d Mark3 1.1.3

- TEST Crop Rec h264.

- 1:1 3x 180/720 works. No works Auto focus with Half shutter with a Canon Lenses during recording.
- 1:1 x5 zoom. When recording appear a kind of psicodelic color very funny, but not usefull.
- 3x3 720 1x Wide - I don's see any change as normal h264. Maybe I am missing sth.

- Test Raw. Preview Canon. No Spanning. Computerbay 1066x

- Raw 1920x1080 25p Crop/no Crop continous 10/12/14 bits
- Raw 2544x1320 25p Crop Continous 10 bits
- Raw 2560 x 1320 25p Crop Continous 10 bits
- Raw 2576 x 1320 25p Crop Continous 10 bits
- Raw 2592 x 1320 25p Crop Continuous 10 bits
- Raw 2608 x 1320 25p Crop Continuous 10 bits.
- Raw 2800 x 1320 25p Crop 30 Seg. Stop. 10 bits.
-
- Raw 3584 x 1320 30p FPS 90 frames.
- Raw 3584 x 1320 30p FPS 120 Frames.
- Raw 3584 x 1320 25p FPS 180 frames

Soft MFLVS and Resolve 12,5.

Here in Argentina it's summer and hot. 35 degrees Celsius. I don't know if its an influence in recording. Camera works hot at 49/50 degrees Celsius. But not problems  ;D
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: D_Odell on January 12, 2017, 10:19:46 PM
What stops 3x to have higher resolution in this module?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 13, 2017, 12:37:52 PM
Oh my, new Experimental build for crop_rec with 10 Bit and 5D3-123 :o Thanks A1lex!  ;)
Get them here: https://builds.magiclantern.fm/experiments.html

I will have to test all the new updates but have not time now!

This is the new stuff for testing here:

a1c01bb: Raw backend: fix black borders on raw previews

4081e14: Merged raw_video_10bit_12bit into crop_rec

f849355: mlv_rec: fix bad merge (to be tested)

12f156f: Moved bit depth setup from raw_rec/mlv_rec to raw backend; raw overlays should now refuse to run at bit depths other than 14

a31228c: raw_rec, mlv_rec: minimize roundoff error when scaling black and white levels
(using --black-fix in mlv_dump should be no longer needed)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: NoCp_Albert on January 13, 2017, 02:51:58 PM
During my test for the magiclantern-crop3x.2017Jan12.5D3123 without MLV_rec and MLV_sound I found this Morning the new Test Module magiclantern-crop3x.2017Jan13.5D3123.

I test the new Crop Module with MLV_rec and MLV_sound, A-ETTR "always on", RAW_rec and raw_twk.mod not loaded.

Let me say, really a pleaser to use this Modul now, Thank you

1.1 Normal 1920x1080, 14 bit, ok.
1.2 Normal 1920x1080, 12 bit, Message RAW error, but the recorded footage without problem in MLW-view and in Lightroom, resolution can not be changed
1.3 Normal 1920x1080, 10 bit, Message RAW error, but the recorded footage without problem in MLW-view and in Lightroom, resolution can not be changed

2.1 3xcrop 1080/720, 14 bit, ok.
2.2 3xcrop 1080/720, 12 bit, ok.
2.3 3xcrop 1080/720, 10 bit, ok.

3.1 5x centered crop, 14 bit ok
3.2 5x centered crop, 12 bit ok
3.3 5x centered crop, 1920x1080, 14 bit ok
3.4 5x centered crop, 2208x1242, 14 bit ok
3.5 5x centered crop, 2400x1320, 10 bit ok - continual
3.6 5x centered crop, 3008x1320, 10 bit ok - 12 sec
3.7 5x centered crop, 3520x1320, 10 bit ok - 4 sec

All DNG files with ML-Mystic converted to DNG for Lightroom ACR without any correction looks nearly perfect, will prepare a video with short clips for you.

   
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on January 13, 2017, 03:36:40 PM
1.2 Normal 1920x1080, 12 bit, Message RAW error, but the recorded footage without problem in MLW-view and in Lightroom, resolution can not be changed

The RAW error is from ETTR - it doesn't know how to handle 12-bit data. It's a race condition - if it decides to meter the exposure when recording is starting, you may get this as a side effect. Or, if the metering starts right before you press REC, and the process continues in the first few frames, the exposure can be screwed up completely (because 10/12-bit data interpreted as 14-bit looks like noise).

Not sure what's the best way to fix it: lock the GUI during adjustment (could make sense when using SET as a trigger, but not in always on mode), continuously check for recording during the metering process (and give up), or delay the recording somehow until the metering finishes.

What exactly do you mean by "resolution can not be changed" ?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: NoCp_Albert on January 13, 2017, 07:58:41 PM
@A1ex

First of all, I was really impressed today about the completely Module, for me nearly on the way to include the perfect working 3xcrop 1080/720 Module together with the 5x centered Crop and….the 10bit, 12 bit and 14bit recording. All I testing today with the 5D3 – 123 Firmware was perfect, tomorrow I get out in the real world. I don’t expecting to work in the Standard Module 1920x1080 14 bit also with 10 bit and 12 bit as you make it possible now. Forget all the Issue’s I found in the previous Test Zip from 12.January, I do not found any Problem today, no corrupted Files, no flickering, also without Gray scale during the records.

Thanks for the Info about RAW error, I understand your Info because I was trying out first time Auto-ETTR “always on” The RAW error message stays for 2-3 seconds, get off and came back during my 10 sec. recording. Tomorrow I try with ETTR by" Press Set".

What I mean with Resolution cannot be changed, maybe is a problem of the old German with his bad English. I just was wondering because the 12 bit and 10 bit was working in the Standard Size 1920-1080, so I try to get with 12 and 10 bit bigger Frame size, similar to the crop mode version maybe 2400x 1320 in 10 bit recording same like the 5x centered Crop mode or otherwise an higher FPS rate up to 50.

I am just dreaming sometimes. Magic Lantern is a Dream, thanks for a great work to the ML Team

Here some testing footage 
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 14, 2017, 12:44:19 AM
Testing Latest : magiclantern-crop3x.2017Jan13.5D3123

a1c01bb: Raw backend: fix black borders on raw previews

Yep, this is working on raw previews for 14 bit.  On 12 and 10 bit the Gray Preview is frozen when recording starts.  If 10bit and 12bit preview during recording is not available could it swing back to Canon preview?  In this way at least we have the proper framing with the Gray Preview and then we can get some idea of the scene by looking at the Canon preview.  For now I click on the zoom button and get to the 10X zoom just before I start recording.

4081e14: Merged raw_video_10bit_12bit into crop_rec

Working great!  Crop rec module is doing its thing. 

f849355: mlv_rec: fix bad merge (to be tested)

mlv_rec is working very well with 10/12/14 bit video.  Tested sound, card spanning, resolution, and found no problems.

12f156f: Moved bit depth setup from raw_rec/mlv_rec to raw backend; raw overlays should now refuse to run at bit depths other than 14

Yep unfortunately the frozen gray preview is of no help..  as I mentioned before maybe if possible the canon preview should be put in place only during recording.

a31228c: raw_rec, mlv_rec: minimize roundoff error when scaling black and white levels
(using --black-fix in mlv_dump should be no longer needed)


Well done, 10bit footage looks very well.

OTHER PROBLEMS:

Using crop_rec with 5X setting:
I recorded some videos with zoom and some without.  Always previewed them using the play button and then sometimes the playback got corrupted.  The video was recorded ok but the playback looked like this (caught it with screen shot):
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fs20.postimg.org%2F4lccxfr1p%2FVRAM0.jpg&hash=92a6ac5a8ddacfdc0a729b4072daa112)

If the camera is turned off and on then the video playback looks proper.

-----------------------

More Video Playback problems:

When erasing or playing videos with mlv_play
after pressing the erase the previous video shows up..  this only works for two or three videos and then just get a black screen
During playback the same issue happens.. only can review three videos and then a black screen without the video.
To erase more videos have to get out of LV and back in.. then the other videos appear.

This is great stuff guys!  I really appreciate all of the many hours of work that you have put into this great project. :)  :-*
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: NoCp_Albert on January 14, 2017, 10:55:55 AM
@A1ex, Renatophoto

All 14bit records are showed in mlv_play, but mostly maximum 3 and then comes the black screen. The Info bar is running for maximum 8 records if you go back with the wheel, than it’s completely black. Sometimes get the also10+12bit video showed, not everytime, not when I get the "RAW error" message during recording. Maximum I get 8 records in mlv_play, but the records all ok.
 
I try today ETTR with push Set" and also Snapshot mode, the RAW error messaged is there also, recorded footage is ok.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: axelcine on January 14, 2017, 01:25:35 PM
What a Christmas present - thanks A1ex and all you other excellent Canon Magicians. I know that all of you - of course - know exactly how happy we all are with your work. But it can't be said enough: You guys take terrific cameras and turn them into super machines. Our daily work with the cameras benefit tremendously from your work. Many very difficult tasks are a lot easier now, and the overall quality of our work is vastly improved, thanks to you guys. My town, Aarhus in Denmark, is the European Culture Capitol this year, with lots and lots of photogenic events, so ML will certainly prove its worth again and again. Should you happen to be in the vicinity, I'll pop the bubbly.

You might want to look it up. Google Aarhus Denmark - lots of info is in English as well as Danish...
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: NoCp_Albert on January 14, 2017, 06:26:22 PM
@axelcine

Axel, as you say My town, Aarhus in Denmark and my Home City Paphos in Cyprus, is the European Culture Capitol this year, with lots and lots of photogenic events, so ML will certainly prove its worth again and again. Should you happen to be in the vicinity, I'll pop the bubbly.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: GutterPump on January 14, 2017, 08:08:09 PM
I wonder if one day we will be able to use the crop mod with a preview like the 3x crop mod but with a resolution that we can choose, higher than 1080, like the 5x centered crop. With the new 10/12 bit functionality, it will be wonderful.

If A1ex or others devs can point the finger at this possibility, Magic Lantern will reach its peak, If this is not already the case.

I know it sounds insolent, knowing the enormous work and discovery that the developers are doing now. But when I see the evolutions that are getting faster and faster, I'm hoping.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: goldenchild9to5 on January 15, 2017, 05:20:42 AM
Pre Video Shoot Test.. Let me know what you guy's think of this look. If anyone is from the NY, CT area and would like to be part of this project and help out let me know.  By the way thank you Team Magic Lantern for this wonderful Upgrade :)

5D Mark III using Magic Lantern RAW (720p Mode in 3X3 Crop Mode, was the older built) 
Lens Nikon 50mm f1.8
Color Graded using Davinci Resolve 12.5.3
 

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: GutterPump on January 15, 2017, 02:13:45 PM
Did i try too.


5D mark III -  firm v.113

Resolution : 3104 x 1320 @ 24p - Upscale to 3840 x 1632
Bitdepth : 10bits

Not continuous but allow to record arround 800 frames with card spanning.

DNG was extracted with the last MLV_DUMP, i not met any issue or corrupted files.

To get an idea : 7 mb by DNG -  340 frames = 2,3 gb

Was a pleasure to  color grade with these 10bits footage.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: child01 on January 15, 2017, 02:15:27 PM
Sorry, may be I missed something, but why I don't see crop_rec module in the Jan13 nightly build?
I've tried to copie-paste it from Apr02 nightly build but it didn't work((
So why there's no crop_rec in Jan13?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 15, 2017, 02:56:32 PM
Ok ok... here is my test recorded at 60 fps rendered at 29.9 fps with crop module: 1:1 3X giving resolution of 1920x648
TESTED: magiclantern-crop3x.2017Jan13.5D3123
Get it here: https://builds.magiclantern.fm/experiments.html

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 15, 2017, 04:02:26 PM
I am experiencing problems with 1:1 (centered x5 zoom) settings when the resolution is above 3008x1320, at 3008 I have no problems but at 3040 I do!
magiclantern-crop3x.2017Jan13.5D3123
Using mlv_rec module.
The problem begins when the camera stops due to skipped frame or stopped by button press.
After the camera stops I have to pull the battery out since camera stops responding.
The video file gets recorded and have no problems.
After rebooting the camera cannot play back the file it gets a black screen.

If I flick the video lever a couple of time I get camera Err 80.

Also confirm the problems is with mlv_rec..  Using raw_rec does not give me any problems and I can record to max resolution  3574x1320
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: NoCp_Albert on January 15, 2017, 06:30:13 PM
@RenatoPhoto

I test your report and confirm the same problem, with MLV-rec at 3040x1320 10,12 and 14 bit. By 10 bit I get record toime about 8 seconds, then "Automatic stop" and "Bussy", after a few seconds I switch the Camera of and start again, press Lupe for 5x crop and then record working again 8 seconds. With 3008x 1320 10 bit Camera stop after 8 Seconds recording but after 3-4 seconds comes back automaticle in Record Mode.

As you say, with RAW_rec this problem is not happen.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 16, 2017, 08:26:17 PM
5D3.123  using crop_mo 3X at 60 fps
magiclantern-crop3x.2017Jan13.5D3123

There is a aprox 28 pixel black border on the top of the frame.

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fs20.postimg.org%2Fp8ohyuab1%2F1920x648_black_border.jpg&hash=13212c6d0f2d653fbcfdf2794b4b9ad6)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on January 17, 2017, 03:37:21 AM

...Also confirm the problems is with mlv_rec..  Using raw_rec does not give me any problems and I can record to max resolution  3574x1320..

Confirmed this on my end with 5D3.123 as well.


There is a aprox 28 pixel black border on the top of the frame.

Unfortunately atm this is to be expected afaik (https://www.magiclantern.fm/forum/index.php?topic=17021.msg165196#msg165196afaik).
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: NoCp_Albert on January 17, 2017, 11:51:28 AM
Test this also now and confirme this Problem also for  5D3-123 on PAL and 50 FPS with MLV and RAW_rec.
With MLV_rec and AutoETTR I get corupted Files with this settings in MLV_view and in the Clips also.
RAW_Rec works fine
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: anto on January 22, 2017, 09:50:21 PM
what is the best resolutionfor to scaling image to 1080p?

shooting in 2,88k (as the Alexa do) we can have a 1080p from a compession of 2 every 3 pixels (2880/1920=1,5=3/2)
in 2,304k we have 1,2 compression ratio.

it's better to choose a resolution that give us a compression ratio more precise (like 1,5) or this isn't a problem shooting in raw? so, more resolution more detail?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: hyalinejim on January 22, 2017, 09:52:20 PM
Well, why not test it and post the results?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: anto on January 22, 2017, 10:05:00 PM
unfortunately currently I have only a 50mm f1.8 canon (50€ lens).  i think  could be a more accurate test with good zoom lens, because changing the resolution change the crop.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Lars Steenhoff on January 22, 2017, 11:35:23 PM
the 50 mm is fine, just stop it down a bit and you will have trouble finding a significantly sharper lens no matter what the price is.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: panth3r on January 23, 2017, 09:48:48 AM
did some 50fps testing @ 1920*672 (i am able to record 23 sec with this quality)
@5d MkIII 1.13


additionally a comparison between crop mode raw (right) and no crop mode raw (left) ( both "slomo" mode = 50/60 fps)
with 5dmkIII sigma 105mm. like it! heavy letterboxing though


(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fpicload.org%2Fimage%2Frodplwpw%2Fcroprawcomp3.jpg&hash=8a94d4bf9705eb3699410f43a5b93f3b)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 26, 2017, 04:42:35 PM
Testing of 3x3 crop module recording at 60 fps with 5D3-123
Test to evaluate the lower noise and higher definition of 3x3 bining recording.
Build: magiclantern-crop3x.2017Jan13.5D3123

For comparison below are three frames from recordings at standard (stretch) 60 fps recording, 3x3 bining, and 1:1 recording.

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fs20.postimg.org%2Fg9x268i99%2FStretch_3x3_1x1_images.jpg&hash=afa3dc727b71bb1ab5ebc5b6ab7e14b5)

First thing to notice is that 3x3 bining produces an image that is not zoomed like 1:1 and that it has a reduced height (1920x648).

Now the corresponding crops to see more details of each:

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fs20.postimg.org%2Fd1skt6vzh%2FNoise_and_Color_Stretch_vs_3x3_vs_1x1.jpg&hash=7365f7f9385e1d180d6c373c12611c9f)

The 3x3 recording shows better definition than the stretched images but not as high as 1:1.
The 3x3 recording shows a little less color saturation.
The 3x3 recording shows less noise.

This 3x3 recording module gives a higher image quality for the situations in which the zoom (3x) cannot be used.  The restricted resolution of 1920x648 can be maxed out to 1920x672 by changing the aspect ratio to almost 5:3.  This gives a usable video of 1920x665.

Here are some sample videos recorded with stretch mode, at 3X3, and 1:1 mode.  The videos where slowed down to 25% speed by twixtor and slightly sharpened.

Stretch

3x3 bining

1:1 Recording
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 29, 2017, 03:34:04 PM
@A1lex:
Do you think it is still possible to find new settings for  CMOS/ADTG/Digic that could lead to larger height on the 3x3 bining settings.  Right now it is limited to 672 px height. 
Have you reached then end of possibilities to improve this recording method?
I ask because this seems like a very useful finding and maybe others can explore further if you think there is still room for improvement.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on January 29, 2017, 04:00:47 PM
Yes, there is still a lot of room for improvement, and probably lots of hidden surprises. For example, clicking on g3gg0's signature gives you this (http://www.magiclantern.fm/forum/index.php?topic=14656.0). The first post also has some useful hints about where to start, and the big ISO research thread has a lot of information that may be relevant here as well. The mv1080 thread for EOS M (http://www.magiclantern.fm/forum/index.php?topic=16608) is another gold mine, in particular if you want to port this module on other camera models, and may be a little easier to grasp by those with less reverse engineering experience.

BTW, just noticed the latest adtg_gui no longer loads on vanilla crop_rec builds. I can fix it if there is interest in experimenting with this module (though it's highly recommended that one knows what to do if things go wrong, and being able to compile from source is probably a good indicator of such knowledge).
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 29, 2017, 11:04:16 PM
Well certainly it would help if adtg_gui  is required to to try some register modifications.  I would do it if I knew what registers and what range to try.
Currently I have loaded Iso_regs and will probably try some of the iso changes..
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on January 29, 2017, 11:13:43 PM
The known ADTG/CMOS registers are documented in the source code:

https://bitbucket.org/hudson/magic-lantern/src/iso-research/modules/adtg_gui/adtg_gui.c

Searching for adtg_gui on the forum will give additional tips, and trying to reproduce the existing findings is probably the best way to get started.

Porting to 6D and 500D should be straightforward, see the links from first post. Other cameras may be similar.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 29, 2017, 11:58:56 PM
This is the most straight forward summary of the registers posted by you for 5d3 here (The code on adtg_gui.c just shows how extensive is the information so far obtained.  :o):

http://www.magiclantern.fm/forum/index.php?topic=10111.msg145036#msg145036 (http://www.magiclantern.fm/forum/index.php?topic=10111.msg145036#msg145036)      
April 14 2015   

For 5D3, a configuration that appears to work is:
      
Code: [Select]      
CMOS[1]                 0xB8B           vertical position and size      
CMOS[2]                 0x10E           horizontal position and downsizing factor      
CMOS[6]                 0x170           ISO related? pink highlights without it      
ADTG2[0x8000]           0x5             it's 5 in zoom mode and 6 in 1080p      
ADTG4[0x8000]           0x5             same      
ADTG2[0x8806]           0x6088          without this, you get some weird artifacts      
                                        note: ADTG4[0x8806] should not be changed (default 0x6048)   

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on January 30, 2017, 01:14:49 AM
Also I found this on on Crop_rec code specific to 3x3:

           
Code: [Select]
/* 3x3 binning in 720p (in 1080p it's already 3x3) */
            case CROP_PRESET_3x3_1X:
                /* ADTG2/4[0x800C] = 2: vertical binning factor = 3 */
                adtg_new[0] = (struct adtg_new) {6, 0x800C, 2};
                break;


and this:

           
Code: [Select]
/* 3x3 binning in 720p */
            /* 1080p it's already 3x3, don't change it */
            case CROP_PRESET_3x3_1X:
                if (is_720p())
                {
                    /* start/stop scanning line, very large increments */
                    cmos_new[1] = PACK12(8,29);
                }
                break;


and this on adtg_gui.c:

Code: [Select]
static int crop_mode_reg(int reg)
{
    if (regs[reg].dst == DST_CMOS)
    {
        switch (regs[reg].reg)
        {
            case 1:                     /* CMOS[1]: vertical position and size */
                return (video_mode_resolution)
                    ? PACK12(14,10)     /* 720p,  almost centered */
                    : PACK12(11,11);    /* 1080p, almost centered */

            case 2: return 0x10E;       /* CMOS[2]: horizontal position and downsizing factor */
            case 6: return 0x170;       /* CMOS[6]: ISO related? */
        }
    }
    else if (regs[reg].dst == 2)        /* ADTG 2 */
    {
        switch (regs[reg].reg)
        {
            case 0x8000: return 5;      /* it's 5 in zoom mode and 6 in 1080p; this also overrides ADTG4 */
            case 0x8806: return 0x6088; /* without this, you get some weird artifacts; this should only go to ADTG2, not 4 */
        }
    }

    return 0;
      


So then I realize that I dont know which registers should be changed to try to increase the vertical resolution of the resulting video in 3x3 bining.

I am not a coder so I will leave this to those who have a better understanding of what is going on.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dfort on January 31, 2017, 05:26:43 PM
Got the crop_rec module working on the 700D and it was pretty easy to do--or let's just way it was mostly stupid luck. It is working just like on the EOSM, including the vertically stretched 3x3 preview that @rburne noted as needing fixing. In a way it works better than the EOSM because it can do 50p/60p "slow motion" in H.264 and even raw video, though of course it is limited by the SD card write speed but switching to 10bit helps with that.
[EDIT - Just test H.264 and uh, never mind. frame size is 1280x720 and the image is stretched vertically.]

I followed the rbrune pull request for the EOSM (https://bitbucket.org/hudson/magic-lantern/pull-requests/762/crop_rec-add-limited-eosm-support-to/diff) which means that it has the same limited options as the EOSM. I'll be doing some tinkering on a 5D3 soon so I'll finally get to see what 1:1, 1x3 and 3x1 does and if it is applicable to the 700D. Anyone have any thoughts on this?

I added new sections for the 700D so it won't break 5D3/EOSM functionality but it looks like several sections can be combined. I'd like to look into these things before making a pull request but if anyone wants to see my work in progress:

https://bitbucket.org/daniel_fort/magic-lantern/branch/crop_rec-700D_experiments

Here are details of how I did it. First of all, this is the important stuff:

Code: [Select]
    else if (is_camera("700D", "1.1.4"))
    {
        CMOS_WRITE = 0x17A1C;
        MEM_CMOS_WRITE = 0xE92D41F0;
       
        ADTG_WRITE = 0x178FC;
        MEM_ADTG_WRITE = 0xE92D43F8;

So where did I find these numbers? I looked at the EOSM numbers:

Code: [Select]
    else if (is_camera("EOSM", "2.0.2"))
    {
        CMOS_WRITE = 0x2998C;
        MEM_CMOS_WRITE = 0xE92D41F0;
       
        ADTG_WRITE = 0x2986C;
        MEM_ADTG_WRITE = 0xE92D43F8;

Ok--where to find CMOS_WRITE. I compiled a version of the iso_research branch to get the adtg_gui module for both the EOSM and 700D so I can see the registers side-by-side, started hunting and got totally lost. Then I remembered dmilligan's advice, look at the code.

adtg_gui.c
Code: [Select]
    else if (is_camera("EOSM", "2.0.2")) // from 1%
    {
        ADTG_WRITE_FUNC = 0x2986C;
        CMOS_WRITE_FUNC = 0x2998C;
    }
...
    else if (is_camera("650D", "1.0.4"))
    {
        ADTG_WRITE_FUNC = 0x178FC; //"[REG] @@@@@@@@@@@@ Start ADTG[CS:%lx]"
        CMOS_WRITE_FUNC = 0x17A1C; //"[REG] ############ Start CMOS"
    }
    else if (is_camera("700D", "1.1.4"))
    {
        ADTG_WRITE_FUNC = 0x178FC; //"[REG] @@@@@@@@@@@@ Start ADTG[CS:%lx]"
        CMOS_WRITE_FUNC = 0x17A1C; //"[REG] ############ Start CMOS"
    }   

Two down two to go. Gee almost too easy. I kept the 650D code in that code snippet because this might get interesting. See how the values are exactly the same as the 700D?

Next, how to find the MEM_CMOS_WRITE and MEM_ADTG_WRITE? Lost again. So I looked up those addresses on the EOSM disassembly. I got 6,146 hits for 0xE92D41F0 but comparing the two disassembly files side-by-side, they were all in the same places on both cameras so I went with the EOSM numbers and it worked. Totally lucked out. Now I know this is not the right way to find these addresses but in the end the only thing that really matters is that it works. Still, it would be nice to learn the right way to do this in order help get other cameras working with crop_rec.

How about the 650D? I got a ROM1.BIN from that camera so I disassembled it. The code is very similar to the 700D but the MEM_CMOS_WRITE and MEM_ADTG_WRITE address seems to be different and it will take some searching to figure it out but it looks doable.

The crop_rec module is one of those Magic Lantern features that you didn't know you needed until you try it out. It also evolved into something that doesn't resemble its name any more. A few days ago a1ex asked if it is time for a rename (http://www.magiclantern.fm/forum/index.php?topic=16608.msg179158#msg179158) so if there are any non-coders who know about marketing, here's your chance to contribute to ML development. Just remember there is an 8-character limit on the module's name.
Title: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: aschille84 on January 31, 2017, 06:52:11 PM
Wow, great progress!
Quote
..so if there are any non-coders who know about marketing, here's your chance to contribute to ML development.
I think a similar function is called center scan mode on Sony cameras
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on January 31, 2017, 09:20:20 PM
Great find dfort!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on January 31, 2017, 10:04:40 PM
Indeed another great performance done by the legendary @dfort!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on February 01, 2017, 02:03:47 AM
@dfort I am sure many users will be very happy of your findings.  Thanks for your great help.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: RenatoPhoto on February 01, 2017, 02:10:38 AM
I like crop mode recording but could see it as magic crop module  :D
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: andy kh on February 01, 2017, 06:35:22 AM
Well done @dfort
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Lars Steenhoff on February 10, 2017, 07:15:33 PM
Are there any builds with latest unified + crop?  :)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Roberto Mena on February 10, 2017, 10:57:08 PM
Im sorry crop mode has been around for ML for a while now, right? So what's the big deal with this new update?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Walter Schulz on February 10, 2017, 11:03:55 PM
H.264 crop mode ...
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Roberto Mena on February 11, 2017, 12:50:01 AM
Ooooh. Thanks. By the way, how do you guys shoot in crop mode if your moving the camera around its gotta be super hard to frame your subject with so little of the actual image is seen in the camera's LCD screen? Is there a way to shoot in crop mode in camera but the video output to an external monitor would look regular, i.e. non-cropped?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: anto on February 11, 2017, 06:51:52 PM
same problem (stesso problema?  ::)  :D) )
I think the better solution is ML greyscale on the 5D and clean out on the external lcd. with 1.2.3 course
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: D_Odell on February 11, 2017, 07:08:33 PM
Ooooh. Thanks. By the way, how do you guys shoot in crop mode if your moving the camera around its gotta be super hard to frame your subject with so little of the actual image is seen in the camera's LCD screen? Is there a way to shoot in crop mode in camera but the video output to an external monitor would look regular, i.e. non-cropped?
For serious work, it only works with static shots, since there is right now no way to see 1:1 over 1080p in 3x3 crop mode. The super news and high fives would be when 3x3 crop works with higher resolutions like 24xx horizontal. Until the future, use a tripod if shooting crop, or zoom view.

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: anto on February 11, 2017, 08:41:58 PM


The super news and high fives would be when 3x3 crop works with higher resolutions like 24xx horizontal. Until the future, use a tripod if shooting crop, or zoom view.

It'll possible?
With somethings like 3x2 Bunning I think...


Inviato dal mio HTC One utilizzando Tapatalk

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: NikeFreak on February 17, 2017, 11:44:42 AM
for 6d and 650d has such a module?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on March 06, 2017, 08:40:07 PM
Today I shot several takes of 1920x490, 60FPS, 2.35 Aspect Ratio.
Ordinary shots were fine.
Some shots I used 3x Crop, the Aspect Ratio was different. A circle looks like an egg
I could see in the monitor the problem and I didnt examine what was recorded.
If I knew, I would swap a lens in order to zoom.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on March 07, 2017, 04:52:00 PM
Yes, Canon preview in 50/60fps modes that record square pixels (including the 3x crop mode) is squashed, as mentioned in the first post. The video recorded in raw should be fine (check with e.g. mlv_play).
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on March 07, 2017, 05:53:59 PM
Unfortunately the video recorded was not right.
BTW, I used 10 bit recording mode.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on March 07, 2017, 06:15:14 PM
Sample clip and steps to reproduce?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on March 08, 2017, 05:43:26 AM
I use magiclantern-crop3x.2017Jan13.5D3113.zip
I set my Camera to NTSC Video System, 1280x720, 60FPS
I set the recording mode to RAW 1920x490 and Aspect Ratio to 2.35:1
in order to get continuous 60FPS. (I know that I need to stretch the result vertically by 1.67 in order to get 2.35:1)
I set 10bits mode.

Recoding like this is normal. The monitoring and the recording is as expected. Stretching it by 1.67 vertically makes it as expected.
When I set the Crop Mode to 3x, the preview Aspect Ratio is stretched.
Stretching the Recording result by 1.67 makes it unusable.

I erased the MLV files.
I only have DNGs.
Here is the first frame if this helps
https://drive.google.com/open?id=0B-d8ARtc7xwWU3JCQTRRTHFFV1E
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on March 08, 2017, 07:25:18 AM
The DNG looks OK to me. The slight "distortion" in the circles' aspect ratio is because of camera position.

(I know that I need to stretch the result vertically by 1.67 in order to get 2.35:1)

There's your problem.

You need to stretch in regular 720p raw mode (with crop_rec turned off), but you do not need to stretch in 3x crop or in 3x3 1x.

Refer to this post for a visual explanation: http://www.magiclantern.fm/forum/index.php?topic=17021.msg179168#msg179168
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on March 08, 2017, 08:26:35 AM
Apologies for the confusion.
My intention was constructive
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on March 21, 2017, 01:34:04 AM
Proposal for making crop info available to other modules (please review):
[...]

Done, please review. Experimental builds + updated mlv_dump available.

Relevant commits: structure (https://bitbucket.org/hudson/magic-lantern/commits/043d0b79aee8568c1db599437d306e273263d2e8#chg-src/raw.h), mlv.h entry (https://bitbucket.org/hudson/magic-lantern/commits/1a842f9508b9f4ca449894a9a9c6dc76422a1ed5), mlv_dump info display (https://bitbucket.org/hudson/magic-lantern/commits/7c04f886816a5994021aae75cecb55e2865c14ee).

Metadata examples:
Code: [Select]
Block: RAWC
  Offset: 0x000000e8
    Size: 32
    Time: 0.769000 ms
    raw_capture_info:
      sensor res      5760x3840
      sensor crop     1.00
      sampling        5x3 (bin 5 lines, bin 3 columns)
Code: [Select]
      sampling        1x1 (read every line, read every column)
      sampling        1x3 (read every line, bin 3 columns)
      sampling        3x3 (bin 3 lines, bin 3 columns)
      sampling        5x3 (bin 5 lines, bin 3 columns)
      sampling        3x3 (read 1 line, skip 2, bin 3 columns)
      sampling        5x3 (read 1 line, skip 4, bin 3 columns)

Why I'm recording detailed info about binning/skipping modes? Maybe, at some point, somebody may come up with a custom debayering or super-resolution or whatever algorithm fine-tuned for Canon's pixel binning patterns. Knowing the exact binning pattern would definitely help in this case.

This info is recorded even if you don't use the crop_rec module (so it should probably be ported to regular nightlies as well).
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: DeafEyeJedi on March 21, 2017, 01:44:04 AM
This is excellent news and thanks for a great proposal!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Kharak on March 21, 2017, 01:52:35 AM
So I was just dreaming about this a couple days ago..

If this is what I think it is e.g. artificially imposing resolution on to the Pixel Binned image by guessing or processing with an accurate algorithm the "missing pixels" in the 3x3 image?

Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: bouncyball on March 21, 2017, 08:56:04 AM
At last!!! :D

Great news! Thanks a1ex!

BR
bb
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on March 22, 2017, 07:43:17 PM
:). Lovely metadata. It,s been missed.
Here is mlv_dump compiled for mac
https://bitbucket.org/Dannephoto/magic-lantern/downloads/mlv_dump_RAWC.zip

Tested crop_rec on eosm.
Eyecandy.
Code: [Select]
Block: RAWC
  Offset: 0x000000e8
    Size: 32
    Time: 0.808000 ms
    raw_capture_info:
      sensor res      5184x3456
      sensor crop     1.62
      sampling        3x3 (read 1 line, skip 2, bin 3 columns)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Quentin on April 03, 2017, 05:46:44 AM
R E S P E C T !!!
Currently I have a project to shoot and I cannot risk installing the experimental features.
I am anxious to ...
Thanks
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: mk11174 on April 03, 2017, 07:07:46 PM
I am working on 700D with adtg.gui tool and found after adjusting
ADTG[8000c] to 0x0 gives the tall x3 preview
Then adjusting
CMOS 5 to 0x10 from 0x20 fixes tall stretch to normal 3x preview
CMOS 7 from 0x800 to 0x809 fixes vertical adjust
ADTG2[8000] needs to be set to 0x5 while in this mode or you get weird artifacts.
Cant find a way to adjust horizontal though.

One thing I noticed, is while in this mode, its offset so much, that the pixel dots are only an issue on the far lower right side.

3x mode 1080P Canon
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fs2.postimg.org%2Fx8v6sg4mh%2Fx3zoom.jpg&hash=e431f6c393c11ec57b77e0246ae87ae1)

Normal mode 1080P Canon
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fs9.postimg.org%2Fk13oye8vz%2F1080p.jpg&hash=071ef227dccde2f7d6303e416ea4c858)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on April 03, 2017, 07:43:57 PM
CMOS 5 to 0x10 from 0x20 fixes tall stretch to normal 3x preview
Cant find a way to adjust horizontal though.

On 5D3, the same register adjusts both.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: mk11174 on April 03, 2017, 08:10:47 PM
Right, just had to keep going, just found it at 0x390 on CMOS 5, now looks great!

Update to values for 3x 1080p/720 mode
CMOS 5 0x20 to 0x390 changes width so not tall stretched and horizontal
works on crop_rec module just fine
Code: [Select]
    if (is_700D)
    {
        switch (crop_preset)
        {
            /* 1:1 (3x) */
            case CROP_PRESET_3X:
                /* start/stop scanning line, very large increments */
                /* note: these are two values, 6 bit each, trial and error */
                cmos_new[7] = (is_720p())
                ? PACK12(12,9)
                : PACK12(10,10);
                cmos_new[5] = 0x390;    /* read every column, centered crop */
                break;
            case CROP_PRESET_3x3_1X:
                /* start/stop scanning line, very large increments */
                cmos_new[7] = (is_720p())
                ? PACK12(6,60)
                : PACK12(0,0);
                break;
        }
    }
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Davipe on April 21, 2017, 06:48:32 PM
I was searching but do not found nothing about:

I need to rec with 3x crop on a 5D2 in h.264, is possible?

thanks!!!
Title: Crop mode recording. Frame and block size mismatch, Memory patch error
Post by: MarcusD on June 08, 2017, 10:28:31 AM
Somehow the footage shot in crop mode is not working for me. Everything is working correctly with the Canon Firmware Version: 1.2.3 Latest Build: 2017-06-04 version. But the magiclantern-crop_rec_4k.2017Jun03.5D3 version shows green noise when imported.

* If I try to play the footage inside 5D Mark III cam I get a message frame and block size mismatch 0x684C00 0x20 0x357A00

* The debug mode show a third red dot (first 2 are green). Code FF290F98, EA395076 crop_rec
additional information in screen below: crop_rec: video timers hook

* When exported to computer and opened withe MLrawviewer, the program crashes
* When exported to computer and opened with Raw2DNG, I see a noisy green pattern instead of the video

**I've have tried with 113 and 123 versions. Both have the same problem.
*** different CF cards
*** with and without CROP mode active
**** set to 12 and 14bit lossless compression

WHEN SET TO PLAIN 14 BIT (NOT LOSSLESS) IT WORKS. But sadly the bitrate is to high for recording 3K continously with this setting.

Settings in camera are correct as far as I know.
- RAW video active, set to 3072 and aspect ratio 2:35:1
- Compression 12-bit lossless (14bit same problem)
- Crop mode n3.5K 1:1 centered x5
- Canon menu is set to PAL, 24fps 1920 ALL-I  (tried with IPB, same problem)

So hopefully anybody knows how to fix this, or knows what I'm doing wrong here;)

Cheers,
Marcus


(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fthumb.ibb.co%2Fm0uBsa%2Fraw2dng.jpg&hash=40be77a755bb96c768f7f2686c6e742f) (http://ibb.co/m0uBsa)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: dmilligan on June 08, 2017, 08:59:48 PM
Problem is you need to use an MLV converter that supports the new lossless compression.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: MarcusD on June 09, 2017, 05:49:46 PM
Hi dmilligan.

I just figured that out today. Everything is working fine now. Can record 3K continious in 14bit lossless. Somehow I must have missed the part of converting with MLV dump and Rawflow.

RAW2DNG and MLrawviewer will not work with these new compression MLV files.

Thanks!

(Should I delete my post?)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: etienne on July 20, 2017, 04:24:43 PM
Hi all,

Is there a way to get 14bits losseless in one of the branches that support crop mode x3 & MLV sound in HD no need for higher resolution.

It seems that only the 4k Branch gets the lossless choices but this one as no MLV sound available... Am i wrong? Any other way?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on July 25, 2017, 08:02:40 AM
Please, ML Team, add NO SOUND to the screen, to modules nightly or experimental, when the sound is not recording.
Lot of problems here, and headphones works even without MLV SOUND.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on July 25, 2017, 08:14:34 AM
Last time I've checked (read: 1-2 years ago), the audio meters should disappear when there's no sound recorded (be it in H.264 or mlv_snd). Is this no longer the case?

Headphone output is not currently under ML control.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on July 25, 2017, 08:22:45 AM
Yes, its what you say.

But lot of variables, settings, values - people - when filming and it's very common forget activate sound.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Walter Schulz on July 25, 2017, 08:42:40 AM
There are 2 ways to avoid such troubles:
- A foolproof technical solution
- A checklist either in old-fashioned print with pen or (modern style) using smartphone...

I recommend second approach.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Danne on July 25, 2017, 08:45:20 AM
You mean you want NO SOUND burnt into the ML screen while recording? Thought no meters showing would do that trick but maybe not enough.
One thing could be to enable sound to default ON when mlv_snd is set?
Speaking of sound. How is mlv_lite and mlv_snd going? I see there's a branch started and I compiled it a while ago but briefly tests showed errors. Had no time then to dig further. Is there any specific tests I can do? What is working or not with mlv_lite and sound atm?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on July 25, 2017, 09:21:49 AM
When MLV is ON, no problem. Bars show the level.
When is OFF, I think is better the legend: NO SOUND.

I don't want to prolong a common sense proposal, and a check list sorry but is not enough today. Excepto if you shoot mountines and cats on the grass.
ML from two years at today was adding lot of menus, and beautifull tools.
People like me - and maybe you -  who today shoot with ML know the dozens of variables in every shoot, bits, pixels size, crop factors, iso, lens, people asking, restarts, cards, backups, freezes... and people like me don't use - we can't afford - have a guy to check the sound, other with focus.

We need the best solution, even, when you know that you can forget one of 77 variables.

Except if you are Karpov o Kasparov ;)

Thank you.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: ItsMeLenny on August 01, 2017, 07:20:48 AM
And 4K trolls used to be the problem :P
Now we (not me, but some people) have 4K and text saying "no sound" is the feature request.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: budafilms on August 02, 2017, 11:12:57 AM
@ItsMeLenny

Make a good video, baby.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: clemento on September 13, 2017, 02:23:48 PM
Hi Magic Lantern users,
I haven't been updating my ml build for 2 years now..
is there already a way to see the proper and right frame when recording in crop mode?
It sucks that we see the 5x magnification, but actualy its recording in 3x magnification.
Any workaround?

Thanks so much
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Kharak on September 13, 2017, 04:07:34 PM
Yes, its what you say.

But lot of variables, settings, values - people - when filming and it's very common forget activate sound.

I would like this too. I deactivate sound for increased speeds on 1x3 mode (vanilla) and have forgotten too many times to reactivate. When on a shoot, there are so many things to consider and would be nice with a clear "No Sound/Audio" in the legend
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Kharak on December 31, 2017, 10:28:28 AM
Under Memory Patches I have Red dot for code FF290F98 - EA3569C0. The description bar at the bottom says "crop_rec: video timers hook" and right under that "0xFF290F98: 0xE51FC15C -> 0xEA3569C0"

What does this mean? Should I be worried. I have to say, everything seems to work really well with this build (Oct 28th fir 123). Been playing around with 3.5k center mode a lot these last two weeks and it has worked so well compared to the beginning of the crop_rec release.

I havent gotten around to update my build to latest. Would that fix this?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: drkim on January 02, 2018, 10:22:09 AM
Hi, new to crop.

I would like to shoot a cropped image not in RAW, not zoomed in, just regular video at 1920 width. But I want cinemascope aspect ratio with a 1920 width: 1920 x 817

Using some crop settings, can I just capture 1920 x 817?
(I know about crop marks - I'm just wondering if I can actually capture smaller files.)

I'm on a Canon EOS-M

Thank you in advance!
Kim
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: a1ex on January 02, 2018, 10:33:57 AM
No - the best we might be able to do, with the current knowledge, would be to blacken the top and bottom bars (or turn them into any other solid color), hopefully reducing file size as well.

Even that is not trivial to implement (one has to find when to overwrite what we call HD buffer, somewhere between image capture and H.264 encoding) and it's likely to have model-specific quirks. Not sure if it's worth the trouble.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: drkim on January 05, 2018, 04:41:35 AM
No - the best we might be able to do, with the current knowledge, would be to blacken the top and bottom bars (or turn them into any other solid color), hopefully reducing file size as well...
Thank you a1ex.
I'm just working off crop marks right now, I didn't know if 'crop recording' provided for actually excluding part of the image. Not critical since non-RAW files aren't that big.
Cheers!
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: domasa on January 23, 2018, 12:01:56 AM
It would be possible add some shortcut key for crop mode?

(Button INFO is enough if it does not work otherwise.)
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: leandroprz on November 24, 2018, 07:40:18 PM
I tested the latest crop module last night on my 6D and I'm getting 2/3 of the image with a magenta color:

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.imgur.com%2Fgsb3huf.jpg&hash=1de561ace9b2d252816b79b8d25cfa15)

I used mlv_lite and mlv_rec both with default settings. Both give the same results.

Any idea what could be happening?
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: khaja84 on January 02, 2020, 03:27:21 PM
Its already implemented by Canon in 600D?
Is that 3x and 10x zoom available in Video?
If so, does that mean I will get a crop video in 3x and 10x zoom mode without pixel binning?

Waiting for confirmation, thanks.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Walter Schulz on January 02, 2020, 04:46:23 PM
Crop_rec.mo is not available for your cam. Crop mode is. Just press loupe button for cropped MLV recording.
600D hosts Digic 4 and is limited to about 20 MByte/s transfer rate for continuous recording.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: khaja84 on January 02, 2020, 08:07:43 PM
But in this post, it's mentioned that: Note that 600D and 70D already have this feature from Canon....
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: Walter Schulz on January 02, 2020, 09:30:02 PM
Which post? It may refer to Canon's "crop" mode for  H.264 recording which was introduced with 600D.
Title: Re: Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)
Post by: khaja84 on January 02, 2020, 10:03:33 PM
Which post? It may refer to Canon's "crop" mode for  H.264 recording which was introduced with 600D.

I'm referring to this post: https://www.magiclantern.fm/forum/index.php?topic=17021.0

Yes, I just want to know whether Canon's "crop" mode for  H.264 recording in 600D record H264 video without pixel-binning like Crop_rec.mo is doing with RAW Video?