Author Topic: [experiment] [5D3, others?] massive mlv_play speedup  (Read 46973 times)

ilia3101

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1002
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #50 on: November 16, 2016, 10:26:26 PM »
Sorry Danne, I had that idea stuck in my head from a few days of SD-CF adapter usage, but testing it right now on a 1066x card it is almost perfect, but at least for me on the 5D mark II, theres still a slight difference between 'all' and 'exact' in black and white, so not 100% real time. Yeah sorry about the black and white nonsense, I probably assumed that conclusion. But yes there is a massive difference in colour playback when enabling/disabling the module.

vstrglv

  • Senior
  • ****
  • Posts: 252
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #51 on: November 23, 2016, 09:16:19 PM »
Error message for loading raw_twk.mo "tcc: error: underfined simbol 'engio_write'" for
magiclantern-crop3x.2016Sep05.5D3113 build.
Canon 5D3,1.1.3; Canon EOS M,202,  CF-SanDisk Extreme PRO,160MB/s, 256GB, SD-SanDisk Extreme Pro, 170MB/s, 128GB.

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3190
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #52 on: November 23, 2016, 10:02:33 PM »
You'll be able to use it in next nightly.
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

vstrglv

  • Senior
  • ****
  • Posts: 252
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #53 on: November 24, 2016, 08:05:22 AM »
Unfortunately crop.mo will be not there, i guess.
Canon 5D3,1.1.3; Canon EOS M,202,  CF-SanDisk Extreme PRO,160MB/s, 256GB, SD-SanDisk Extreme Pro, 170MB/s, 128GB.

DeafEyeJedi

  • Hero Member
  • *****
  • Posts: 3413
  • 5D3 | M1 | 7D | 70D | SL1 | M2 | 50D
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #54 on: December 01, 2016, 09:51:03 AM »
@g3gg0 -- This is probably a known issue or has been reported in the past but felt this was worth mentioning at the least.

While playing back 10/12-bit files in mlv_play (with raw_twk.mo enabled) which looks really nice and efficient.

However, on the 5D3 while going into 5x/10x zoom mode (not crop_rec.mo) for us to shoot larger resolutions such as 2.8k or 3.2k -- with the raw_twk.mo enabled the camera freezes up and gets stuck in 5x/10x mode forcing me to pop the battery out for a reboot.

Current workaround is to shoot and do your thing while having the raw_twk.mo DISABLED temporarily (unless you don't intend to shoot higher res) and then once all is done in which we can go ahead and ENABLE raw_twk.mo back on for a decent mlv_play previewing with 10/12-bit files. Is this a bug?
5D3.113 | 5D3.123 | EOSM.203 | 7D.203 | 70D.112 | 100D.101 | EOSM2.* | 50D.109

Danne

  • Developer
  • Hero Member
  • *****
  • Posts: 7702
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #55 on: December 01, 2016, 10:21:05 AM »
This needs more testing. Is centred 5x zoom mode from the crop_rec module in conjunction with raw_twk to blame or not? I tested a while ago and I had a freeze when previewing but after reboot all went to normal even with the raw_twk module included. I tried to reproduce but I couldn,t. However maybe better to put the centred 5x crop module to it,s paces over at the crop_rec thread and also test it cleanly without any other bleeding edge modules.
http://www.magiclantern.fm/forum/index.php?topic=17021.msg174918#msg174918

Danne

  • Developer
  • Hero Member
  • *****
  • Posts: 7702
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #56 on: December 01, 2016, 02:56:57 PM »
Seems the crashing with 5x zoom is related to raw_twk after all.
http://www.magiclantern.fm/forum/index.php?topic=5601.msg175803#msg175803

Also. Any chance to get the overlay buttons working(play,next, pause) on the canon eos m with raw_twk?

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3190
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #57 on: December 01, 2016, 10:03:47 PM »
thanks, will think about how to do that properly
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

RenatoPhoto

  • Moderators
  • Hero Member
  • *****
  • Posts: 1509
  • 5DM3 / 7D
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #58 on: December 24, 2016, 05:10:02 PM »
@g3gg0
Thanks for the raw_twk module.  It works well on 10/12/14 bit files with the current build for 5D3-123 provided by dfort.
I love the ability to zoom while playing the video.
Great work!
http://www.pululahuahostal.com  |  EF 300 f/4, EF 100-400 L, EF 180 L, EF-S 10-22, Samyang 14mm, Sigma 28mm EX DG, Sigma 8mm 1:3.5 EX DG, EF 50mm 1:1.8 II, EF 1.4X II, Kenko C-AF 2X

Licaon_Kter

  • Hero Member
  • *****
  • Posts: 519
  • M
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #59 on: January 04, 2017, 04:31:49 AM »
On EOS M the mlv_play speed up looks like it's working.

Too bad the camera will crash ( "Threads failed to start"; needs battery pull ) when having the module loaded and trying to record RAW (mlv_rec): https://bitbucket.org/snippets/Licaon_Kter/EqkKy

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3190
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #60 on: January 04, 2017, 12:20:48 PM »
its due to the EOS M having not enough free thread ids available.
would need some serious rework of code to save threads.
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

Licaon_Kter

  • Hero Member
  • *****
  • Posts: 519
  • M
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #61 on: January 04, 2017, 01:34:19 PM »
its due to the EOS M having not enough free thread ids available.
would need some serious rework of code to save threads.
NO idea what you are talking about.
That being said, those need to be hooked (reserved, whatever) all the time even if not mlv_playing anything? (don't mind me, this is way over my head)

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3190
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #62 on: January 04, 2017, 03:05:12 PM »
mlv_play doesn't use any threads when it is not started.
however when starting playback it needs 3 threads (or tasks to name it like it is named in the OS).

so maybe some other module starts threads when not invoked - which ones do you have active?
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

Licaon_Kter

  • Hero Member
  • *****
  • Posts: 519
  • M
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #63 on: January 04, 2017, 05:07:43 PM »
so maybe some other module starts threads when not invoked - which ones do you have active?
so: dual_iso, ettr, fileman, mlv_play, mlv_rec, mlv_snd, pic_view and silent

/LE: Ok got it, tracked it down to mlv_snd, and it happens only if sound is actually recorded, yep this makes sense.

RenatoPhoto

  • Moderators
  • Hero Member
  • *****
  • Posts: 1509
  • 5DM3 / 7D
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #64 on: January 18, 2017, 05:46:51 PM »
Just a suggestion:  Is it possible for raw_twk to zoom to center of the image as default?  Thanks for this great tweak!
http://www.pululahuahostal.com  |  EF 300 f/4, EF 100-400 L, EF 180 L, EF-S 10-22, Samyang 14mm, Sigma 28mm EX DG, Sigma 8mm 1:3.5 EX DG, EF 50mm 1:1.8 II, EF 1.4X II, Kenko C-AF 2X

RenatoPhoto

  • Moderators
  • Hero Member
  • *****
  • Posts: 1509
  • 5DM3 / 7D
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #65 on: February 07, 2017, 02:56:44 PM »
Also note that the video playback  limit is 3 files as reported here:

http://www.magiclantern.fm/forum/index.php?topic=5601.msg179644#msg179644
http://www.pululahuahostal.com  |  EF 300 f/4, EF 100-400 L, EF 180 L, EF-S 10-22, Samyang 14mm, Sigma 28mm EX DG, Sigma 8mm 1:3.5 EX DG, EF 50mm 1:1.8 II, EF 1.4X II, Kenko C-AF 2X