Crop mode recording (crop_rec.mo) (1:1, RAW/H.264, 25/30/50/60 fps)

[DeafEyeJedi]

https://bitbucket.org/daniel_fort/magic-lantern/downloads

[Surin Dmitriy]

https://bitbucket.org/daniel_fort/magic-lantern/downloads

Is it possible to add crop_rec module to 1.1.3 also? I find it only for 1.2.3 inside.

[GutterPump]

Is it possible to add crop_rec module to 1.1.3 also? I find it only for 1.2.3 inside.

Very interested in this possibility also.

crop_rec + 10 - 12bits RAW will be a great combo.

[dfort]

Ok--here you go:

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-raw_video_10bit_12bit_crop_rec.2016Dec24.5D3113.zip

Please report your findings.

[GutterPump]

Ok--here you go:

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-raw_video_10bit_12bit_crop_rec.2016Dec24.5D3113.zip

Please report your findings.

Thanks a lot, i will make some tests tommorow. Even if it's Christmas i don't care, ML is the priority 

[vstrglv]

Ok--here you go:

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-raw_video_10bit_12bit_crop_rec.2016Dec24.5D3113.zip

Please report your findings.

Thank you very much!
Quick test - frame issue:
10bit,12bit, crop1:1 and not crop mode - preview framing during recording  is not correct. All screen is filled.
Sometimes this issue takes place in 14bit mode too. I could not find a regularity.   
This issue takes place sometimes on my merged crop_rec in Unified on Dec22.2016 too.

[RenatoPhoto]

FYI,
crop.rec module does not load on 5D3.123  It gives module error.

[rrrmusic]

I have the same problem that RenatoPhoto reports on magiclantern-raw_video_10bit_12bit.2016Dec20.5D3123

crop.rec module does not load on. It gives module error.

when i do the start/stop of recording with mlv_rec module I get this message:
Hack error at 0:
excpectede3a00032, got e1a00000

[dfort]

Looks like that 10bit/12bit combined with crop_rec for the 5D3.123 I compiled had a problem. crop_rec should work with the 5D3.123 so let's try a build without the 10bit/12bit.

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-crop_rec.2016Dec28.5D3123.zip

If this works then we can take the next step and merge in 10bit/12bit.

[RenatoPhoto]

@dfort

Yep magiclantern-crop_rec.2016Dec28.5D3123.zip works very well.. 
Looking forward to the new version.. great work!

[dfort]

Yep magiclantern-crop_rec.2016Dec28.5D3123.zip works very well.. 

Alright, let's take the next step. I might have resolved the merge conflicts improperly last time. Hope it works this time:

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-5D3-123_crop_rec_10bit_12bit.2016Dec29.5D3123.zip

[RenatoPhoto]

No success!
The modules load but mlv_rec or raw_rec recording do not work and put the camera in some error.
Crash log 1:
ASSERT: hLvJob->hJpegMemSuite
at ./Epp/Vram/VramStage.c:891, task Epp
lv:1 mode:3

Magic Lantern version : Nightly.2016Dec29.5D3123
Mercurial changeset   : 48d29e058105+fcadac0113e1+ (5D3-123_crop_rec_10bit_12bit) tip
Built on 2016-12-29 16:01:57 UTC by rosiefort@RosieFoComputer.
Free Memory  : 158K + 3755K

Crash log2:
ASSERT: IsSuiteSignature( hSuite )
at ./PackMemory/PackMem.c:599, task Epp
lv:0 mode:3

Magic Lantern version : Nightly.2016Dec29.5D3123
Mercurial changeset   : 48d29e058105+fcadac0113e1+ (5D3-123_crop_rec_10bit_12bit) tip
Built on 2016-12-29 16:01:57 UTC by rosiefort@RosieFoComputer.
Free Memory  : 158K + 3764K

[rrrmusic]

All modules loaded with magiclantern-5D3-123_crop_rec_10bit_12bit.2016Dec29.5D3123.zip but i experimented a lot of crashes.

Link with the Logs
https://drive.google.com/open?id=0BzDsfba1S_rgbTI5NEFzMHdIOUk

[dfort]

Put up a new build for 5D3.123

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-5D3-123_crop_rec_10bit_12bit.2016Dec29.5D3123.zip

If you're interested in seeing what's being changed on the test build, follow this:

https://bitbucket.org/daniel_fort/magic-lantern/commits/branch/5D3-123_crop_rec_10bit_12bit

[RenatoPhoto]

@dfort

Negative.. Modules loaded but I have problems accessing ML menu after I flipped the video switch.  Also on the first video switch it took a little long for the video to show up..
Had to reboot no Crash log.

I will be back to check in a week... going on a birding trip..    Was hoping to test new crop_rec with 10/12 bit 

[rrrmusic]

@dfort errors continues

CRASH00.LOG
ASSERT: hLvJob->hJpegMemSuite
at ./Epp/Vram/VramStage.c:891, task Epp
lv:1 mode:3


Magic Lantern version : Nightly.2016Dec29.5D3123
Mercurial changeset   : d33ea8074da3+ (5D3-123_crop_rec_10bit_12bit)
Built on 2016-12-30 01:00:40 UTC by rosiefort@RosieFoComputer.
Free Memory  : 147K + 3557K


CRASH01.LOG
ASSERT: IsSuiteSignature( hSuite )
at ./PackMemory/PackMem.c:599, task Epp
lv:0 mode:3


Magic Lantern version : Nightly.2016Dec29.5D3123
Mercurial changeset   : d33ea8074da3+ (5D3-123_crop_rec_10bit_12bit)
Built on 2016-12-30 01:00:40 UTC by rosiefort@RosieFoComputer.
Free Memory  : 147K + 3565K


CRASH02.LOG
ASSERT: IsSuiteSignature( hSuite )
at ./PackMemory/PackMem.c:983, task RscMgr
lv:0 mode:3


Magic Lantern version : Nightly.2016Dec29.5D3123
Mercurial changeset   : d33ea8074da3+ (5D3-123_crop_rec_10bit_12bit)
Built on 2016-12-30 01:00:40 UTC by rosiefort@RosieFoComputer.
Free Memory  : 147K + 3567K


CRASH03.LOG
ASSERT: fInitialize == TRUE
at ./System/PostPostman/PostPostman.c:243, task Epp
lv:0 mode:3


Magic Lantern version : Nightly.2016Dec29.5D3123
Mercurial changeset   : d33ea8074da3+ (5D3-123_crop_rec_10bit_12bit)
Built on 2016-12-30 01:00:40 UTC by rosiefort@RosieFoComputer.
Free Memory  : 147K + 3567K
 

[dfort]

I took down the non-working build.

This previous build also has the crop_rec module and over 100 downloads. Please verify that crop_rec isn't working with 10bit/12bit:

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-raw_video_10bit_12bit.2016Dec20.5D3123.zip

crop_rec is a module and you should be able to add it from any other build so if it isn't working there may be some back end modifications that need to be done specific to the 1.2.3 firmware. There's a working version on the first post but looking at the date I wonder if it is an April Fools joke:

https://builds.magiclantern.fm/jenkins/job/5D3.123-crop3x-april-1st-edition/3/artifact/platform/5D3.123/magiclantern-crop3x.2016Apr01.5D3123.zip

In any case I'm going to back away and see if someone with a 5D3 running 123 firmware can attempt to merge raw_video_10bit_12bit with crop_rec.

[rrrmusic]

I tried this build before and reported in reply #207.

Will be great to have a working build with crop_rec And 10/12 bit raw with 5d3 123.
I used external monitor And recorder so i need clean hdmi.
Please Do not give up [emoji57]

[dfort]

Not giving up yet. Found a really basic mistake--I still had the DEFAULT_RAW_BUFFER for the 5D3.113. Let's give this another shot.

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-5D3-123_crop_rec_10bit_12bit.2016Dec30.5D3123.zip

[rrrmusic]

@dfort
Things are better but need more work 
My first reports using magiclantern-5D3-123_crop_rec_10bit_12bit.2016Dec30.5D3123

10/12 bit works with raw_rec full frame but with crop mode the camera crash.
ASSERT: hLvJob->hJpegMemSuite
at ./Epp/Vram/VramStage.c:891, task Epp
lv:1 mode:3

ASSERT: IsSuiteSignature( hSuite )
at ./PackMemory/PackMem.c:599, task Epp
lv:0 mode:3

ASSERT: IsSuiteSignature( hSuite )
at ./PackMemory/PackMem.c:983, task RscMgr
lv:0 mode:3

Crop Mode works well with H.264
Mlvrec gives a hack error when start to record in full frame and crop mode
Hack error at 0:
expected e3a00032, got e1a00000

[dfort]

@rrrmusic

Do you get those crashes with 14 bit recording or just with 10/12 bit? How is it working when you aren't using the crop_rec module?

Looks like there were also issues with the 5D3.113 when crop_rec and raw_video_10bit_12bit were merged so this might be a problem that needs someone with a deeper understanding of what's going on.

[rrrmusic]

@dfort
Hi i did more tests today

raw_rec 10bit and 14bit both works well at the moment no crashes in full frame and crop   
Turn it off the camera

Same test with mlv_rec
Hack error at 0:
expected e3a00032, got e1a00000
gaves this error but continue to records the movie. Sometimes the movie is fine and others with a complete black and green movie.

The only difference before yesterday tests is when i use raw_rec 10/12bit i disabled mlv_rec module.

Maybe the crashes before was the mlv_rec.
I will continue to do more tests and if you want to do a specific test let me know.
Happy New Year 

[dfort]

So the problems is only with mlv_rec? raw_rec (which is MLV Lite in this build) is fine?

Try it the way we know it should work--no crop_rec and 14 bit. Then try 10bit/12bit without crop_rec. Finally, run that test again with crop_rec.

There were some merge conflicts with mlv_rec and maybe I made the wrong assumptions when resolving them. Also, g3ggo made some fixes on mlv_rec that should have made it into this build but I should double check it.

In any case, we need to verify that raw_rec is playing nicely with crop_rec so we can narrow down the problem.

[DeafEyeJedi]

@rrrmusic -- just double checking you didn't load both mlv_rec.mo and raw_rec.mo at the same time, correct?

[dfort]

@DeafEyeJedi -- just noticed from your signature that you're using 123 on your 5D3, is that right? This is the build we're testing:

https://bitbucket.org/daniel_fort/magic-lantern/downloads/magiclantern-5D3-123_crop_rec_10bit_12bit.2016Dec30.5D3123.zip

You can get it from my repository too:

https://bitbucket.org/daniel_fort/magic-lantern/commits/branch/5D3-123_crop_rec_10bit_12bit