Ah i see now, its 17 frames in fullres and brightness is correct, so i probably did not switch off frame burst previously.
-----------
Im starting to center 2.5k mode, i know what the issue is with correcting all crop modes and framing being offcenter in 16:9 and cinemascope etc.
Its because when you skip left right up down then youre skipping more from one side, so what i did is change that, now it doesnt skip left 40 and right 0, it skips left 20 and right 20, so when you change aspect ratio, it all stays perfectly centered.
Why ? BEcause then you can use the same CMOS addresses for 2.5k and don thave to change them again if you want centering working in different aspect ratios
So far my values for 2.5k are:
case CROP_PRESET_2K_EOSM:
cmos_new[5] = 0x2c0; /* vertical (first|last) */
cmos_new[7] = 0x6ca; /* pink highlights without this */
break;i basically made skipping to be the same from both sides( while respecting actual aspect ratios like You did) , so there is no issue with centering when changing aspect ratios:
case CROP_PRESET_2K_EOSM:
/* set ratio preset */
if (ratios == 0x1)
{
skip_left = 36;
skip_right = 36;
skip_top = 23;
skip_bottom = 23;
}
if (ratios == 0x2)
{
skip_left = 36;
skip_right = 36;
skip_top = 14;
skip_bottom = 14;
}
if (ratios == 0x3)
{
skip_left = 197;
skip_right = 197;
skip_top = 106;
skip_bottom = 106;
}
break;
This works, i can see in camera that it helps a lot.
I would of do that for all skipping in croprec by default and in rare cases i would not if something would be off in liveview.
At first i would get skipping from all sides, sometimes i see left skipping or down skipping is ommited which i would not do, i would take half of it and add new line to skip that half from opposite side, and avoid skipping just one side.
This would help getting correct CMOS addresses for different modes because skipping will be uniform from opposites sides ,thre is less variables to take care of.
I suspect You skip sides in 2.5k mode when doing cinemascope so it records mode time ? Isnt it better to leave full 2520 ? So its not overkill for card reader.
CAuse there is 2520x1480 which is already highes 2.5k preset and its 16:9 but you can also choose 16:9 from other place in menu which crops it to lower 2192x1234
--
Now i see that i i think i know whats up, its stays at 950, so you have to skip sides to get to that 2.39:1
Well... maybe not, its working strange maybe its being changed in other places, also im using aspect ratio calculator and ML gives me different resolutions for 2.39:1 than this calculator
https://www.digitalrebellion.com/webapps/aspectcalc1920x804 and 2520x1054 is 2.39:1 1920:816 and 2520x1072 is 2.35:1 and i wanted that but i see that i can get 2592 pixels width if i turn off skipping sides on 2.39:1 ratio ( i had 2592x950 maximum recorded wgich is 2.7:1) so i wanted 2592x1084 for 2.39:1 or 2592x1104 for 2.35:1 but i dont know if thats possible.
Ah.. that one aspect ratio in menu (above ratio ) gave me 2592 when i skipped 0 on all sides..
Does this mode wirks ?
case 0xC0F06804: return 0x5b90319 + reg_6804_width + (reg_6804_height << 16); // 3000x1432 24fps x5 Mode;With my own CMOS value for 2.5k that aspect ratio in raw video menu with resolution changing above it, with Your value it crops uniformly like it should, maybe because i added CMOS5 as well not just CMOS 7 it has centering all over the place when i adjust aspect ratio and resolution, where i can look it up so its not so unpredictable and center whatever i can ? I set aspect to 4:3 and resolution much lowe so i should not vignette but i do, because it shifts the frame whenever i adjust aspect and resolution, its not trying to skip from both sides at the same time but from one side more than from other.
It is hard at the moment figuring out CMOS values to center crop modes, when i press menu then everything gets shifted anyway, so there are multiple places where framing gets changed.
--
In Your build ISO climb doesnt work in 2.5k mode, 45/50/48fps mode crop and noncrop, works fine in other modes .
