Author Topic: Switch for macOS Catalina/Linux (former cr2hdr.app)  (Read 117548 times)

festr

  • New to the forum
  • *
  • Posts: 31
Re: cr2hdr for macOS Sierra
« Reply #125 on: April 26, 2017, 11:39:02 PM »
Hi, I'm trying to process dual_iso with lossless compressino enabled (lj92) - first few frames are normal but then a lot of greenish frames until the end. Is this known issue?

(even if I disable lossless compression after few frames the rest are greenish)

motionSOUL

  • Freshman
  • **
  • Posts: 59
Re: cr2hdr for macOS Sierra
« Reply #126 on: April 26, 2017, 11:41:20 PM »
I have tried to open it in Automator and step by step execute the tasks, all is going well until the last script which is understood but the cr2hdr window doesn't open.

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6969
Re: cr2hdr for macOS Sierra
« Reply #127 on: April 26, 2017, 11:48:17 PM »
Sorry, cannot help you here. If you get all scripts to work from inside automator it should probably work. MAybe if you copy all scripts and files into a vanilla build of an automator app it might work but there are other thkngs which might be troublesome here. HArd to say.

festr. Are regular dual iso files also problematic? Not compressed ones? Could you upload a short sample?

festr

  • New to the forum
  • *
  • Posts: 31
Re: cr2hdr for macOS Sierra
« Reply #128 on: April 27, 2017, 12:01:37 AM »
Edit: I have tried to turn off ls92 compression in MLV menu (the same result) so its not compression issue


This is first frame:




this is second frame (bad) and all others are bad

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6969
Re: cr2hdr for macOS Sierra
« Reply #129 on: April 27, 2017, 12:14:50 AM »
Upload a short file that exhibits the issue. I can take look.

festr

  • New to the forum
  • *
  • Posts: 31
Re: cr2hdr for macOS Sierra
« Reply #130 on: April 27, 2017, 12:18:57 AM »
Here it is: https://drive.google.com/open?id=0B650ZX3ln336QzlvVWhTanRiY2M

let me know how it decodes on yours machine

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6969
Re: cr2hdr for macOS Sierra
« Reply #131 on: April 27, 2017, 01:02:54 AM »
Thanks for the clip. It´s my version of mlv_dump. It seems to go bananas with your file. You can still use regular cr2hd.app and it will work.

togg

  • Senior
  • ****
  • Posts: 419
Re: cr2hdr for macOS Sierra
« Reply #132 on: April 27, 2017, 01:12:54 AM »
Small suggestions, option 05 and 07 are a little bit strange to read. Are they active when selected or not? Could be improved to be less confusing.





Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6969
Re: cr2hdr for macOS Sierra
« Reply #133 on: April 27, 2017, 01:21:46 AM »
It´s from the mlv_dump menu. But yes, things can always be clearer :)

festr

  • New to the forum
  • *
  • Posts: 31
Re: cr2hdr for macOS Sierra
« Reply #134 on: April 27, 2017, 01:27:33 AM »
cr2hd.app - but will it work with the compressed lj92 feature?

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6969
Re: cr2hdr for macOS Sierra
« Reply #135 on: April 27, 2017, 08:43:31 AM »
The issue is related to vertical stripes correction. Since I divide mlv_dump processing into 4 chunks working in parallell it seems only the first chunk using vertical stripes correction is producing nice output. This bug appears on latest lj92 version crop4k branch as well.
If I run processing in one chunk all looks ok but it seems to change vertical stripes algorithm for every new chunk when processing in parallell.
The fix is to disable vertical stripes correction with dualiso files. Can be done in mlv_dump menu (m)

Code: [Select]
Vertical stripes correction:
  1.00000  1.00084  1.00200  0.98271  0.99992  1.00200  1.00189  1.01596

Frame0 : cold pixels found: 0                             


Vertical stripes correction:
  1.00000  1.99995  1.00266  1.99995  0.99980  1.99995  1.00221  1.99995

Frame0 : cold pixels found: 0                             


Vertical stripes correction:
  1.00000  1.99995  1.00204  1.99995  1.00047  1.99995  1.00127  1.99995

Frame0 : cold pixels found: 0                             


Vertical stripes correction:
  1.00000  1.99995  1.00270  1.99995  1.00055  1.99995  1.00276  1.99995

festr

  • New to the forum
  • *
  • Posts: 31
Re: cr2hdr for macOS Sierra
« Reply #136 on: April 27, 2017, 09:42:27 AM »
Hi Dane, yes without stripes correction there is no problem - but there are vertical stripes now which I need to correct. Do you know how to fix it?

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6969
Re: cr2hdr for macOS Sierra
« Reply #137 on: April 27, 2017, 09:45:57 AM »
Could you upload a dng with stripes?
On a sidenote this issue could be of something related to mlv_dump function -f which works with frame exports. Since files ranging from 0 and forward seems play nicely a -f 100-200 does not. Question is how non dualiso files are affected or not.

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6969
Re: cr2hdr for macOS Sierra
« Reply #138 on: April 27, 2017, 12:20:20 PM »
Uploaded a new cr2hdr_lj92.dmg version. Download in first post.

Reason is I think I found the bug with vertical stripes correction when using the -f function in mlv_dump. This one only occurs when exporting let´s say mlv_dump -f 10-20 --dng. If outputting frames somewhere in the middle of the mlv file vertical stripes correction numbers seems way off as opposed to processing mlv_dump --dng or mlv_dump -f 0-100 --dng.

After the fix I got much more coherent numbers. Please check older numbers a few posts before.
Code: [Select]
Vertical stripes correction:
  1.00000  1.25429  1.12299  1.33395  1.12294  1.14198  1.08633  1.20380

Frame0 : cold pixels found: 0                             


Vertical stripes correction:
  1.00000  1.25465  1.13469  1.31161  1.11452  1.17938  1.09082  1.12737

Frame0 : cold pixels found: 0                             


Vertical stripes correction:
  1.00000  1.25990  1.13376  1.31618  1.12531  1.18373  1.07240  1.12363

Frame0 : cold pixels found: 0                             


Vertical stripes correction:
  1.00000  1.25998  1.12959  1.31648  1.12939  1.18280  1.10335  1.12971
Reached end of chunk 1/1 after 232 blocks
Processed 223 video frames
Done

Commit here.(Needs to be tested)
https://bitbucket.org/Dannephoto/magic-lantern/commits/be8d3a22ce28ec8c18bc07b43c1045204dc03d83

In short vertical stripes correction is called after  /* finally save the DNG */ as opposed to before.

 
Code: [Select]
                           /* finally save the DNG */

                            if(!dng_save(frame_filename, frame_buffer, &dng_info))
                            {
                                print_msg(MSG_ERROR, "VIDF: Failed writing into .DNG file\n");
                                goto abort;
                            }

                            /* call raw2dng code, moved here because otherwise numbers are off for compressed raw */
                            if (fix_vert_stripes)
                            {
                                fix_vertical_stripes();
                            }


festr

  • New to the forum
  • *
  • Posts: 31
Re: cr2hdr for macOS Sierra
« Reply #139 on: April 27, 2017, 01:03:19 PM »
I have tried the latest cr2hrd_lj92.dmg but it does not remove vertical strips now (I have checked that I did not disabled it)

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6969
Re: cr2hdr for macOS Sierra
« Reply #140 on: April 27, 2017, 01:10:26 PM »
Well, you need to upload example dng files. Dual iso files in general doesn´t work as regular footage. Not even sure that dual iso files are supposed to apply vertical correction to them. Upload dng samples that shows your problem.

festr

  • New to the forum
  • *
  • Posts: 31
Re: cr2hdr for macOS Sierra
« Reply #141 on: April 27, 2017, 01:16:55 PM »
It is the same MLV file I have uploaded to dropbox. Here is the new DNG which exhibits vertical stripes:



and here is for comparison previous version which removed vertical stripes (but it broken all other images)




Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6969
Re: cr2hdr for macOS Sierra
« Reply #142 on: April 27, 2017, 01:18:13 PM »
I want the dng files.

festr

  • New to the forum
  • *
  • Posts: 31
Re: cr2hdr for macOS Sierra
« Reply #143 on: April 27, 2017, 01:19:45 PM »
I have uploaded few DNGs here https://drive.google.com/open?id=0B650ZX3ln336MWJ1VDZISGNxTkk

the postimg.org changed resolution, here is the same picture where stripes are clearly visible:




Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6969
Re: cr2hdr for macOS Sierra
« Reply #144 on: April 27, 2017, 01:22:44 PM »
Specify two dng files. One with stripes, the other one without stripes. For comparisons.

festr

  • New to the forum
  • *
  • Posts: 31
Re: cr2hdr for macOS Sierra
« Reply #145 on: April 27, 2017, 01:28:06 PM »
I have reverted to previous cr2hdr which has the green problem - first of two images are without vertical stripes - I have uploaded it to the same link under directory WithoutStripes
(please note that I'm using still the same .MLV which is also uploaded there

https://drive.google.com/open?id=0B650ZX3ln336MWJ1VDZISGNxTkk

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6969
Re: cr2hdr for macOS Sierra
« Reply #146 on: April 27, 2017, 01:36:17 PM »
Compared with g3gg0 latest code and there is a problem with my so called fix. Will have to tinker some more...
Thanks for sharing information on this. It´s only related to -f function, otherwise it works.
By the way. Is it happening on all your dualiso files or only this one?

festr

  • New to the forum
  • *
  • Posts: 31
Re: cr2hdr for macOS Sierra
« Reply #147 on: April 27, 2017, 01:44:03 PM »
I can try more footage but I'm convinced it will do for all. I was actually not using dualiso because of very long postprocess but this application with parallelisation and automation rocks so I wanted to use it :)

what is exactly -f and how I can remove it as a workaround? 


Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 6969
Re: cr2hdr for macOS Sierra
« Reply #148 on: April 27, 2017, 01:54:09 PM »
Try a few more files. It seems to work for non dualiso files. I suspect it could be the file. If not I upload a version which skips processing in parallell. I uploaded the old version again.

festr

  • New to the forum
  • *
  • Posts: 31
Re: cr2hdr for macOS Sierra
« Reply #149 on: April 27, 2017, 02:04:56 PM »
this latest version converted first 56 frames OK (including vertical stripes removing) but the rest of 56-222 frames are green again