Uploaded a new
cr2hdr_lj92.dmg version. Download in first post.
Reason is I think I found the bug with vertical stripes correction when using the
-f function in mlv_dump. This one only occurs when exporting let´s say
mlv_dump -f 10-20 --dng. If outputting frames somewhere in the middle of the mlv file vertical stripes correction numbers seems way off as opposed to processing
mlv_dump --dng or
mlv_dump -f 0-100 --dng.
After the fix I got much more coherent numbers. Please check older numbers a few posts before.
Vertical stripes correction:
1.00000 1.25429 1.12299 1.33395 1.12294 1.14198 1.08633 1.20380
Frame0 : cold pixels found: 0
Vertical stripes correction:
1.00000 1.25465 1.13469 1.31161 1.11452 1.17938 1.09082 1.12737
Frame0 : cold pixels found: 0
Vertical stripes correction:
1.00000 1.25990 1.13376 1.31618 1.12531 1.18373 1.07240 1.12363
Frame0 : cold pixels found: 0
Vertical stripes correction:
1.00000 1.25998 1.12959 1.31648 1.12939 1.18280 1.10335 1.12971
Reached end of chunk 1/1 after 232 blocks
Processed 223 video frames
Done
Commit here.(Needs to be tested)
https://bitbucket.org/Dannephoto/magic-lantern/commits/be8d3a22ce28ec8c18bc07b43c1045204dc03d83In short vertical stripes correction is called after /* finally save the DNG */ as opposed to before.
/* finally save the DNG */
if(!dng_save(frame_filename, frame_buffer, &dng_info))
{
print_msg(MSG_ERROR, "VIDF: Failed writing into .DNG file\n");
goto abort;
}
/* call raw2dng code, moved here because otherwise numbers are off for compressed raw */
if (fix_vert_stripes)
{
fix_vertical_stripes();
}