Author Topic: [experiment] [5D3, others?] massive mlv_play speedup  (Read 31171 times)

a1ex

  • Administrator
  • Hero Member
  • *****
  • Posts: 12290
  • Emergencies only
Re: [experiment] [5D3] mlv_play speedup
« Reply #25 on: September 21, 2014, 09:18:19 PM »
What else can it do?

I hope for raw addition (FA_SubtractTestImage, EekoAddRaw), and I bet a lot of people hope for 12-bit.

mk11174

  • Contributor
  • Hero Member
  • *****
  • Posts: 809
Re: [experiment] [5D3] mlv_play speedup
« Reply #26 on: September 21, 2014, 10:19:04 PM »
On 700D
1280x720@24fps color all
266 frames with = 34sec
266 frames without = 54sec
500D/T1i  550D/T2i  600D/T3i  700D/T5i

1%

  • Developer
  • Hero Member
  • *****
  • Posts: 5936
  • 600D/6D/50D/EOSM/7D
Re: [experiment] [5D3] mlv_play speedup
« Reply #27 on: September 21, 2014, 11:40:13 PM »
I guess next thing to try is to feed it hard coded YUV422_LV_BUFFER_DISPLAY_ADDR and see if does the preview.

Nope, no method lets it work in real time :(

Best I get is a single frozen frame. At least on 6D. I can try on 7D too but I suspect results will be the same.

N/A

  • Hero Member
  • *****
  • Posts: 576
  • Dreaming in 14 bit
Re: [experiment] [5D3] mlv_play speedup
« Reply #28 on: September 22, 2014, 10:16:20 AM »
7D module loaded, 5x ok, 10x ok, recording ok. Playback a bit faster.
So there's potential, cool.
7D. 600D. Rokinon 35 cine. Sigma 30 1.4
Audio and video recording/production, Random Photography
Want to help with the latest development but don't know how to compile?

nikfreak

  • Developer
  • Hero Member
  • *****
  • Posts: 1139
Re: [experiment] [5D3] mlv_play speedup
« Reply #29 on: September 22, 2014, 10:45:06 AM »
I hope for raw addition (FA_SubtractTestImage, EekoAddRaw), and I bet a lot of people hope for 12-bit.

Sounds like you are doing some experiments  :P 12-bit raw would be so awesome.
70D.112 & 100D.101

1%

  • Developer
  • Hero Member
  • *****
  • Posts: 5936
  • 600D/6D/50D/EOSM/7D
Re: [experiment] [5D3] mlv_play speedup
« Reply #30 on: September 23, 2014, 06:21:39 PM »
Looks like its relatively easy to do in camera dark frame subtraction... at least on silent pics.

FA_SubtractTestImage pSrc=%#lx, pDark=%#lx, pDest=%#lx",0

Doubt it for mlv/raw, esp since the live preview doesn't want to work with Furikake.

Remove hot pixels with the defect correction engine?

FA_DefectsTestImage pSrc=%#lx, pDest=%#lx",0

wonder how fast this one is.

a1ex

  • Administrator
  • Hero Member
  • *****
  • Posts: 12290
  • Emergencies only
Re: [experiment] [5D3] mlv_play speedup
« Reply #31 on: September 23, 2014, 06:27:59 PM »
Right, but I'm interested in adding (and averaging) two or more pictures.

1%

  • Developer
  • Hero Member
  • *****
  • Posts: 5936
  • 600D/6D/50D/EOSM/7D
Re: [experiment] [5D3] mlv_play speedup
« Reply #32 on: September 23, 2014, 06:34:57 PM »
FA_DefectsMergeTestImage  but no info on parameters or debug message.

nikfreak

  • Developer
  • Hero Member
  • *****
  • Posts: 1139
Re: [experiment] [5D3] mlv_play speedup
« Reply #33 on: September 23, 2014, 09:42:39 PM »
could this be useful for dualiso preview / processing ?  8)
70D.112 & 100D.101

1%

  • Developer
  • Hero Member
  • *****
  • Posts: 5936
  • 600D/6D/50D/EOSM/7D
Re: [experiment] [5D3] mlv_play speedup
« Reply #34 on: September 23, 2014, 11:01:58 PM »
We already had the preview but parts of them would get burnt into the cr2.

Audionut

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3565
  • Blunt and to the point
Re: [experiment] [5D3] mlv_play speedup
« Reply #35 on: September 24, 2014, 01:42:34 AM »
a1ex has some other dual ISO preview code that didn't suffer from that problem.

http://www.magiclantern.fm/forum/index.php?topic=3904.msg127999#msg127999

kyrobb

  • Member
  • ***
  • Posts: 131
Re: [experiment] [5D3] mlv_play speedup
« Reply #36 on: September 24, 2014, 03:04:42 AM »
Wow. More fantastic news! You guys are incredible!

Kharak

  • Hero Member
  • *****
  • Posts: 902
Re: [experiment] [5D3] mlv_play speedup
« Reply #37 on: September 25, 2014, 12:46:19 AM »
raw_twk is awesome! Such a great enhancement on the play side.

But it is very unstable! In the beginning when I tested it, I wrote that I didn't have problems with going in to crop mode while raw_twk was activated, but now it just seems more and more random on how it works.

In the beginning when I tested this. It was only when ML grayscale was ON together with raw_twk and I go in to 5x mode that I would get black and white stripes all over the screen.

But now it seems going in to 5x with canon preview does so too at random times.. And seems if I press zoom in too quickly so that the overlay is not properly loaded, it will crash the camera and I need to do battery pull.

Also MLV play is not working too well. Sometimes it starts playing but the screen is black and I have to restart the camera and then it plays the file normally.  And same with clicking too quickly, like entering play mode and exiting immediately will crash the camera and I need to do battery pull.


Raw twk has such a good performance that it's hard for me not having it activated, even though it makes the camera crash now and then.

Hope you make a more stable release of this G3ggo!

Sep 1st. Nightly.

113
once you go raw you never go back

1%

  • Developer
  • Hero Member
  • *****
  • Posts: 5936
  • 600D/6D/50D/EOSM/7D
Re: [experiment] [5D3] mlv_play speedup
« Reply #38 on: September 25, 2014, 03:31:46 AM »
It doesn't play nice with live view on digic V. Digic IV was better. I don't think its the module, just the canon engine if its used for defect correction, probably why it didn't work for live preview.

ChadMuffin

  • Member
  • ***
  • Posts: 127
  • RAWsome - 5D3
Re: [experiment] [5D3] mlv_play speedup
« Reply #39 on: September 28, 2014, 04:33:27 PM »
Was a noticeable speed difference for me. Great work! I can also report the black and white lines when trying to use crop mode. Also, if I am in photo mode with Live View off on my 5D3 and try to play a MLV video, it is just a black screen with all of the on screen displays working just as if it was playing but there is no picture.

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3154
Re: [experiment] [5D3] mlv_play speedup
« Reply #40 on: October 03, 2014, 11:31:21 PM »
yeah thanks for the feedback.
maybe some day we know how to program all the different hardware modules to get realtime playback ;)
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

Kharak

  • Hero Member
  • *****
  • Posts: 902
Re: [experiment] [5D3] mlv_play speedup
« Reply #41 on: November 02, 2014, 04:38:18 AM »
Anything new here?

This module is really awesome, just a bit unstable! But I find myself having a hard time not using it, even though it can cause crashes now and then.
once you go raw you never go back

DeafEyeJedi

  • Hero Member
  • *****
  • Posts: 3306
  • 5D3 | M1 | 7D | 70D | SL1 | M2 | 50D
Re: [experiment] [5D3] mlv_play speedup
« Reply #42 on: November 02, 2014, 06:16:26 PM »
Just tried the Module under 1.2.3 on 5D3 -- apparently it only works on 1.1.3 since it says 'Module ini't failed'...

am I right about downgrading back to 1.1.3 for this particular module?

Thanks!
5D3.113 | 5D3.123 | EOSM.203 | 7D.203 | 70D.112 | 100D.101 | EOSM2.* | 50D.109

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3154
Re: [experiment] [5D3] mlv_play speedup
« Reply #43 on: November 16, 2016, 01:40:50 AM »
revival of this mlv_play speedup module

thanks to Greg's clean code of what DARK is doing, i implemented the 14->16 conversion directly into raw_twk.
this results in a much cleaner, non-firmware dependent code and might be more portable.

i am just using DARK in passthru mode, not subtracting anything. no need for this :)

works fine on 5D3.113, may work on others, but test on your own risk!
please report in if it works for you


Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5902
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #44 on: November 16, 2016, 09:35:40 AM »
I,d like to try this on a 550D and 7D but I get linking error
tcc: error: undefined symbol 'engio_write'
[E] failed to link to modules.

Will try it out on a 5D mark III when I get my hands on one soon.

andy kh

  • Hero Member
  • *****
  • Posts: 518
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #45 on: November 16, 2016, 09:58:53 AM »
I would also like to try on a 70D
5D Mark III - 70D

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3154
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #46 on: November 16, 2016, 11:34:26 AM »
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

a1ex

  • Administrator
  • Hero Member
  • *****
  • Posts: 12290
  • Emergencies only
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #47 on: November 16, 2016, 02:43:35 PM »
You'll be able to use it in next nightly.

Ilia3101

  • Contributor
  • Hero Member
  • *****
  • Posts: 667
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #48 on: November 16, 2016, 05:43:58 PM »
I can confirm it works on the 5D mark II using raw-bit-depth branch. Black and white playback is not too far from realtime, and colour is much faster too, but both have split jello image thingy going on. Really good improvement!
5D2, MLV App

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5902
Re: [experiment] [5D3, others?] massive mlv_play speedup
« Reply #49 on: November 16, 2016, 06:19:36 PM »
Hm, wasn,t b&w realtime already?