Crop mood - Danne custom tweaks (EOS M)

[Danne]

It does 👀. Interesting.
Maybe also we should put in a short cut to enabling disabling autofocus?

[Danne]

New build uploaded:
- Fixed following presets, height tuning.
1280x2160, 1472x2208, 1600x2400, 3072x1308, 2520x1080, 1920x1280, 1736x1160, HFR: 1736x976, 1736x868, 1736x790, 1736x738.
- Added new pixel maps to Mlv App
- Reworked 3K 1x1 so that it is now 2.39:1 instead of 2.35:1.

Thanks @gabriielangel
If we find anymore pixelated presets please let me know which ones.

[gabriielangel]

New build uploaded:
- Fixed following presets, height tuning.
1280x2160, 1472x2208, 1600x2400, 3072x1308, 2520x1080, 1920x1280, 1736x1160, HFR: 1736x976, 1736x868, 1736x790, 1736x738.
- Added new pixel maps to Mlv App
- Reworked 3K 1x1 so that it is now 2.39:1 instead of 2.35:1.

Thanks @gabriielangel
If we find anymore pixelated presets please let me know which ones.

Since you asked so nicely 

I tested all the presets while I were at it. For some reason GitHub isn't cooperating, so I can't check the focus pixels. But only the following stilll have issues:

1736x976 HFR: Corrupted Frame (But this is the one showing the black preview. I found that HFR 16:9 and 2:1 show ok if you move the focus box Up by 4 units. Other ratios remain black);
1472x2208 Black line at bottom
5208x3478 Black or Red line at bottom, depending on exposure.
1920x1280 Needs Focus Pix
2560x1440 Black line at bottom
3072x1284 Needs Focus Pix
1552x2118 Needs Focus Pix
1600x2400 Needs Focus Pix



I filmed a white card this time to make sure I wouldn't miss anything, but I'll film a real scene on your next release to make sure the image didn't get hurt.

[Danne]

Thanks a lot!

New build:
- Heights tuned according to @gabriielangel and also added new pixel maps


All new maps are downloaded over here @gabriielangel so not sure what is going on. Maybe works now?

regarding this:

1736x976 HFR: Corrupted Frame (But this is the one showing the black preview. I found that HFR 16:9 and 2:1 show ok if you move the focus box Up by 4 units. Other ratios remain black);

I guess it is related to auto focus being on. Could you test to restart your camera after selecting HFR presets the first time? A while ago I added focus box automation so that it moves to correct position after restart.

[iaburn]

This build is getting super polished, thanks Danne! 

I was recording on the new format yesterday and got a couple of shoots "broken". One was green, I just deleted it, and another one got corrupted over time, I never saw that before (example below).
Any idea why did that happened?
https://mega.nz/file/owtlWZpa#v8lLceDaJdDigWqS-BHeN8WuQJt-hGFHgwG9MtZBcus

[Danne]

What preset was used? Not on my computer atm.
I fixed an issue in my older build long ago which is not included in Bilal's build. Might be the issue here too.

[Danne]

New build:

Could you test this build @iaburn?

- Adjusting powersavetiming registry probably causing random image tearing. To be tested.

commit
https://bitbucket.org/Dannephoto/magiclantern_hg_02/commits/2e041f5e51fbcdbd931399b1e31109c1db45ca67

[gabriielangel]

New build:

Could you test this build @iaburn?

- Adjusting powersavetiming registry probably causing random image tearing. To be tested.

commit
https://bitbucket.org/Dannephoto/magiclantern_hg_02/commits/2e041f5e51fbcdbd931399b1e31109c1db45ca67

I just tested again, will post results tomorrow pm as it is still compressing as I am writing this, but the new 1620p preset gives corrupted frames right from the start (I can see it onscreen as it records).
I switched to 2.8k to see, no problem there.
Then back to 1620p and it did it again.
This seems to be recent, as when I recorded last time (Feb 2, Jan 29), it did not happen.

[Danne]

No issues here. Tried restart?

[iaburn]

Could you test this build @iaburn?

I tried a few clips and had no issues with the new build, but it will need more testing, as I only had this problem twice 
Thanks!

[Danne]

It's an old nasty bug and rarely occurs but I think this will fix it.

[gabriielangel]

Tested magiclantern-crop_mood.2024Feb04_Custom.EOSM202.zip

Tested every resolution, no more black / red bars at the bottom of any preset.
No corrupted frames, except for the new preset. This one is strange, because out of 3 recordings, 2 showed glitches on screen while I were recording, but only 1 file had corrupted frames in it.
And 1736x868 48fps gave a corrupted frame even in manual mode.
The image is free of artifacts.

About the 3k preset:
After recording yesterday and last time with the watch scene, I realized that the 3k preset cannot work at 14 bits. The data rate is way too high,
and you need to underexpose 2 stops (Which is equivalent to switching to 12 bits) for it to work.

See the scene I recorded for the tests below. You can see that it is reasonably exposed and not overly bright. Plenty of shadow areas and it still needs 94 MB/s.

If you look at the screenshot, you'll see that 20, 21 and 22fps brings it within reach for the fastest cards.
So, it would be a good idea to take the same approach you took with the Full-Res 1x3 presets, whereas 14bit uses a lower frame rate.
This would make 14bit usable until faster cards are found.

[Danne]

Thanks for your findings.
I consider 12bit as standard for all presets.
Corrupted frames in 1620p. Might be overhead histogram or similar. What was enabled? What SD card is used? Run 12bit and don't add global draw items, manual focus. Still corrupted frames?
Thanks for all your tests. Valuable too many.

[iaburn]

I forgot to mention that I have "kill global draw" enabled, 12 bit and only zebras

[Danne]

We could play around with variable fps. It is possible to lower fps while recording which gets cpu on track again.

[gabriielangel]

Thanks for your findings.
I consider 12bit as standard for all presets.
Corrupted frames in 1620p. Might be overhead histogram or similar. What was enabled? What SD card is used? Run 12bit and don't add global draw items, manual focus. Still corrupted frames?
Thanks for all your tests. Valuable too many.

Sandisk Extreme Pro 128GB R170W/W90 (Freshly Low-Level formatted)
Kill Global Draw On (So Nothing Was On Screen)
Manual Focus (Feb02, Feb04 and Feb05. The tests I did before that were all on AF)
U/D Buttons Off
INFO Button x10 Zoom
SET Button False Colors
TAP Screen Off
(I always use the same setup)

Today, running the Feb05 Build,
Recording at 12bit, I got a corrupted frame using 1376x2322 (See Image)

Although anything is possible, I have gone through the preset thing at least 6 times since Jan 1, so that's 25+ Presets + the 3x3 Presets, times 6.
9 of those presets have a higher Megapixel Count. So I'd lean more towards a recent change.
I am unable to reproduce it on demand though. So a few more tests are required.

I will record some this evening and let you know.

[kadushkin90]

Hello, I will ask a lot of simple questions, because I have not shot with your builds for a long time. Also I don't speak English and I use a translator, so it's not easy for me to learn new settings. In the new build I can't find how to switch the video mode from automatic to manual. Previously it could be done with the info key.

[Danne]

I don´t understand what you mean. Please do a screen recording of your preferred workflow and use the build that works as described. Without this step I cannot provide any relevant answers.

[iaburn]

The Info button is mapped from the start in this build. Go to customize buttons and set it to OFF, that might help

[gabriielangel]

About the Feb05 build additional tests, I tried the following settings at 2160x1620, 10 seconds clips, 5 trials each:

Manual Focus, Kill Global Draw On, 12bit
Manual Focus, Kill Global Draw Off, No Overlays, 12bit
Manual Focus, Kill Global Draw Off, Histogram On Screen, 12bit
Manual Focus, Kill Global Draw On, Histogram On, 12bit
Auto Focus, Kill Global Draw Off, Histogram On Screen, 12bit
Auto Focus, Kill Global Draw Off, Histogram On Screen, 14bit
Auto Focus, Kill Global Draw On, Histogram On, 14bit
Alternating AF/MF, Kill Global Draw On, Histogram On, 14bit for 6 trials

I got 1 corrupted frame on 1 out of 5 trials with Auto Focus, Kill Global Draw Off, Histogram On Screen, 12bit
No corrupted frames in any of the other trials.

Same Sandisk Extreme Pro 128GB R170W/W90 (Freshly Low-Level formatted)
Same button assignments as previously reported.
Files recorded @ 76MB/s (The cand can handle  76.5 in the Green)

I did not change focus, switch presets or used any of the custom buttons.

[Danne]

It's surprising we are not getting more image corruption with that much height in 1x1.

[SammyBEEES]

I was playing around with Dual ISO on the newest version and it seems like focus peaking isn't working correctly, mainly just highlighting the horizontal lines in Dual ISO vs in the original crop mood where it works as intended.

[Danne]

I didn't do anything to dual iso. If you could do tests with exact same setup and test the same scene against both builds you'll see if something is different or not.

[doktorkrek]

Thank you for the 1620p mode! Here are some notes from my experiments with a 4:3 mode, which could perhaps be useful:

• from what I see in the framed preview, setting cmos_new[7] to 0xAC8 gives a better vertical centering
• rolling shutter can be reduced (from 89% to 77%) by setting the timer A to 0x279, timer B to 0x838 (yielding FPS 23.977)
• one can squeeze more of the vertical real time preview with the correct aspect ratio by setting:
  
  YUV_HD_S_H = 0x1050220;
  YUV_HD_S_V = 0x1050240;
  YUV_LV_Buf = 0x1B505A0;
  YUV_LV_S_V = 0x10501B2;
  YUV_LV_S_H = 0x1E0038; // register 0xC0F11A8C
  
  although the preview appears a little messed up
  

[Danne]

Cool. I'll have a look at this soon. Seems a nice contribution.