Author Topic: MLV PLAY (mlv_play.mo)  (Read 86348 times)

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5799
Re: MLV PLAY (mlv_play.mo)
« Reply #150 on: December 19, 2016, 03:12:59 PM »
Risking double posts now but I continue this issue here.

On eos m play, pause, delete, scroll buttons are visible either when pressing set and also a while from start of playing mlv files in cam.
Problem with raw_twk enabled is that all buttons are gone making deleting impossible. Previewing is possible but no possibilities to go to the next video pause it etc won,t work. This seems to be a problem only on the eos m and only when using the raw_twk module. All buttons are visible if raw_twk is disabled and regular mlv_play is running.

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3154
Re: MLV PLAY (mlv_play.mo)
« Reply #151 on: December 19, 2016, 08:46:55 PM »
interesting bug. i dont understand it.
if raw_twk is enabled, no GUI code behaves different.
t.b.h the whole code doesn't care about raw_twk at all.

so this might be an issue with the number of threads we are starting.
raw_twk starts threads, mlv_play does etc. and the EOS M is (iirc) at its limit.
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5799
Re: MLV PLAY (mlv_play.mo)
« Reply #152 on: December 19, 2016, 09:04:45 PM »
That certainly would explain why it,s working on seemingly all other cams. How would it work if done in mlv_play.mo code directly(working with 10/12bit)?

On the eos m with raw_twk enabled

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3154
Re: MLV PLAY (mlv_play.mo)
« Reply #153 on: June 18, 2017, 01:34:26 AM »
fixed the black screen issue when playing back several files.
now scrolling through files should work without trouble.

https://bitbucket.org/hudson/magic-lantern/commits/3f90c436d85aff183af93b9bf6a30224811e5fa2
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5799
Re: MLV PLAY (mlv_play.mo)
« Reply #154 on: June 18, 2017, 06:57:19 AM »
Thanks g3gg0.
Just compiled from crop_rec_4k.
Working
- 10bit/12bit/14bit plays back nicely
- Scrolling back and forth always opens up the expected file
- black screen issue fixed!
- nice to have info on what bits we┬┤re previewing

not working
- lossles compressed 14bit files causes camera freeze and black screen. Restart needed.
once I got one frame showing freezed but tested two more times after restart and  screen went black and freeze. No crash logs to be found.

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3154
Re: MLV PLAY (mlv_play.mo)
« Reply #155 on: June 18, 2017, 09:25:28 AM »
thanks.
on which model you tried it?

oh and disable raw_twk for now.
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5799
Re: MLV PLAY (mlv_play.mo)
« Reply #156 on: June 18, 2017, 09:29:46 AM »
Yes, I will.
Sorry, 5D mark III. 1.1.3.

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3154
Re: MLV PLAY (mlv_play.mo)
« Reply #157 on: June 18, 2017, 09:50:34 AM »
same as me, so i expect it to work if you disable raw_twk.
there seem to be some incompatibilities.
maybe some locking or so.
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5799
Re: MLV PLAY (mlv_play.mo)
« Reply #158 on: June 18, 2017, 10:23:11 AM »
Yes, you're absolutely right. Lossless works when raw_twk is disabled. Thanks for pointing that out.

domasa

  • Freshman
  • **
  • Posts: 88
Re: MLV PLAY (mlv_play.mo)
« Reply #159 on: June 28, 2017, 12:16:07 AM »
Thx for add lossless playback support inside camera.

Do you know some alternative for Windows?

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5799
Re: MLV PLAY (mlv_play.mo)
« Reply #160 on: June 28, 2017, 05:39:34 AM »
Previewing footage in windows can be done in MlRawViewer. Either through MLVFS, check link
http://www.magiclantern.fm/forum/index.php?topic=19300.msg185808#msg185808
Or you can decompress your MLV files with mlv_dump and preview the uncompressed MLV files directly in MLRawViewer.

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3154
Re: MLV PLAY (mlv_play.mo)
« Reply #161 on: July 02, 2017, 02:04:41 AM »
Yes, you're absolutely right. Lossless works when raw_twk is disabled. Thanks for pointing that out.

fixed in latest crop_rec_4k branch.

when we have pure raw frames, raw_twk will still repack them to 16bpp and then render them.
for lossless with raw_twk, mlv_play will use the lossless routines to already pack them to 16bpp and then pass to raw_twk which renders on screen.
for lossless without raw_twk, mlv_play will use lossless routines to create 14bpp data as before and pass them to the core raw backend.
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5799
Re: MLV PLAY (mlv_play.mo)
« Reply #162 on: July 02, 2017, 06:33:20 PM »
Tested briefly today. Seems to swing nicely with all bitdepths and compression mode. Nice, nice. Some porting for this and mlv_rec as well would be nice :).

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3154
Re: MLV PLAY (mlv_play.mo)
« Reply #163 on: July 02, 2017, 07:26:59 PM »
cool, happy to hear that :)
if you want to support, feel free :D

which models do you use?

edit:
mlv_rec will get replaced by mlv_lite step by step.
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5799
Re: MLV PLAY (mlv_play.mo)
« Reply #164 on: July 02, 2017, 08:44:08 PM »
I use 5D mark III and eosm.
Sure, support, how?
Mlv_lite taking over :)

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3154
Re: MLV PLAY (mlv_play.mo)
« Reply #165 on: July 02, 2017, 09:22:32 PM »
mlv_lite is a cleaner rewrite of mlv_rec with all knowledge of it with additional new findings.
so yeah, it will take over and be the raw recording module.
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

Surin Dmitriy

  • New to the forum
  • *
  • Posts: 45
Re: MLV PLAY (mlv_play.mo)
« Reply #166 on: July 03, 2017, 01:37:51 AM »
mlv_lite is a cleaner rewrite of mlv_rec with all knowledge of it with additional new findings.
so yeah, it will take over and be the raw recording module.

Does mlv_lite support sound?
5D3

andy kh

  • Hero Member
  • *****
  • Posts: 513
Re: MLV PLAY (mlv_play.mo)
« Reply #167 on: July 03, 2017, 11:47:57 AM »
mlv_lite is a cleaner rewrite of mlv_rec with all knowledge of it with additional new findings.
so yeah, it will take over and be the raw recording module.

won't be a problem if it's going to support audio recording
5D Mark III - 70D

andy kh

  • Hero Member
  • *****
  • Posts: 513
Re: MLV PLAY (mlv_play.mo)
« Reply #168 on: July 03, 2017, 11:51:37 AM »
5D Mark III - 70D

theBilalFakhouri

  • Contributor
  • Senior
  • *****
  • Posts: 353
Re: MLV PLAY (mlv_play.mo)
« Reply #169 on: July 10, 2019, 03:01:12 PM »
Can we play the sound beside MLV file in camera?
What should we do ? Where to start ?
700D 1.1.5 | no more ISOless LV err 8

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5799
Re: MLV PLAY (mlv_play.mo)
« Reply #170 on: July 10, 2019, 03:14:15 PM »
Check in mlv_play code. g3gg0  has some unused code regarding audio in there. Good start.