Messages

Use EOSCARD to make your card bootable. Afterwards extract this zip onto your card:
https://builds.magiclantern.fm/70D-112.html

Be happy with ML on 70D with firmware V1.1.2

major drawback for 70D are "fps override" and "dual iso" features. These don't work atm. Onthe other side it has dualpixel AF....

Any visual examples?

[100D]

100D
805e -> 41697784
8060 -> 41697ac0
805f -> 41697bc4
8061 -> 41697bc8

what dfort mentioned: 805f and 8061 didn't show up until I switched to 1920/24

Great not far away for Full-Res LiveView with the benefit of higher shutter speed - though ADTG gui still hangs for me in Liveview.

Best way is in crop_rec module. "Is_basic" refers to 100D / 700D / EOSM. You could add a new option or here "case" and name it like you which:

https://bitbucket.org/hudson/magic-lantern/src/d2da32f62e6cd7758171cd964ac80d3a28fd2af7/modules/crop_rec/crop_rec.c?at=crop_rec_4k&fileviewer=file-view-default#crop_rec.c-110

Important places:
https://bitbucket.org/hudson/magic-lantern/src/d2da32f62e6cd7758171cd964ac80d3a28fd2af7/modules/crop_rec/crop_rec.c?at=crop_rec_4k&fileviewer=file-view-default#crop_rec.c-522
https://bitbucket.org/hudson/magic-lantern/src/d2da32f62e6cd7758171cd964ac80d3a28fd2af7/modules/crop_rec/crop_rec.c?at=crop_rec_4k&fileviewer=file-view-default#crop_rec.c-843

Ofc you have to fiddle a lil bit but generally you just can return the values needed like this:
https://bitbucket.org/hudson/magic-lantern/src/d2da32f62e6cd7758171cd964ac80d3a28fd2af7/modules/crop_rec/crop_rec.c?at=crop_rec_4k&fileviewer=file-view-default#crop_rec.c-894

Hope you get what I mean. The code cheks for video modes etc. Maybe hard to understand at first but should be doable.. a1ex uses delta values and some hardcoded ones maybe that could be a way to unify it for apsc cams for e.g. find safe working deltas by comparing original to overriden values on all cameras.

From your screenshots I found out 100D / 700D share almost same values and as you already notice 8-12 bit lossless won't work. Just 14 bit lossless and normal 10,12,14 bit. We can do a preset in crop_rec module by defining some safe deltas for all needed registers but which resolution makes sense in terms of useful recording speed I can't tell atm. Danne maybe can do some tests but 3k width was just a second or so. I am rather interested in this but not yet there

Danne can you try this:

Code Select Expand


static int res3k_reg(int reg)
{
    if (regs[reg].dst == 0xC0F0)
    {
        switch (regs[reg].reg)
        {
            case 0x6800:                /* C0F06804 - raw resolution */
                return 0x40019;
            case 0x6804:                /* C0F06804 - raw resolution */
                return 0x5080301;       /* from 0x528011B -> 3072px in raw_rec */
            case 0x6824:
               return 0x4ca;
            case 0x6828:
               return 0x4ca;
            case 0x682c:
               return 0x4ca;
            case 0x6830:
               return 0x4ca;
            case 0x6008:
               return 0x34b034b;
            case 0x600c:
               return 0x34b034b;
            case 0x6010:
               return 0x34b;
            case 0x6014:
               return 0x60b;
            case 0x7150:
              return 0x428;
            case 0x713c:
               return 0x545;
         
         }
    }
       else if (regs[reg].dst == 2)        /* ADTG 2 */
    {
        switch (regs[reg].reg)
        {
           case 0x8172:
               return 0x437;
            case 0x8178:
               return 0x437;
            case 0x8179:
               return 0x587;
            case 0x82b6:
               return 0x87f;

        }
    }

    return 0;
}

713c has been changed and 82B6 added.

Good news. Battery empty I am pausing BUT I have the full vertical resolution displayed on the LCD. Needs some fine tuning an additional register added. Now there's some pink overlay but that could be CMOS registers. We will see when I pick it up again ;-)

Initial test was definitely 2400 width possible in movie crop mode. Maybe more with the knowledge now.
From 70D I know there's a x3 zoom which I think "movie crop mode" is equal to. But I can't tell if the output is different or x5 zoom has the same FOV / POV. I still "think" it has another POV when viewing on PC but If they are same then it doesn't make sense. Can someone comment on it.

Code Select Expand


case 0x6008:
               return 0x35b035b;
            case 0x600c:
               return 0x35b035b;
            case 0x6010:
               return 0x35b;
            case 0x6014:
               return 0x65b;

Lower it step by step like this. Above seen control fps. Don't forget to open Canon menu after each adjustment. until you reach 24fps and no corrupted frames. I guess you can lower 0x6014 to something like 0x60b or even lower 0x5cb etc.

The first three have not much room to lower. Just try step by step

Update: I initially stated that movie crop mode can be adjusted with same technique. Wouldn't it be even more useful in that mode?
x3 zoom vs x5. Wide angle will be much wider???

Oops updated my code above
713c and 7150 are not adtg2 registers. Please recompile.

Danne like this:

Code Select Expand

static int res3k_reg(int reg)
{
    if (regs[reg].dst == 0xC0F0)
    {
        switch (regs[reg].reg)
        {
            case 0x6804:                /* C0F06804 - raw resolution */
                return 0x4580311;       /* from 0x528011B -> 3072px in raw_rec */
            case 0x6824:
               return 0x4ca;
            case 0x6828:
               return 0x4ca;
            case 0x682c:
               return 0x4ca;
            case 0x6830:
               return 0x4ca;
            case 0x6008:
               return 0x36b036b;
            case 0x600c:
               return 0x36b036b;
            case 0x6010:
               return 0x36b;
            case 0x6014:
               return 0x66b;
            case 0x7150:
              return 0x428;
            case 0x713c:
               return 0x455;
         
         }
    }
       else if (regs[reg].dst == 2)        /* ADTG 2 */
    {
        switch (regs[reg].reg)
        {
           case 0x8172:
               return 0x457;
            case 0x8178:
               return 0x457;
            case 0x8179:
               return 0x587;

        }
    }

    return 0;
}


Notice / Update:
I added C0F06014 for you into the code. Now later with "Overriden regs" option you can modify it for vertical resolution and fps.

btw can you post me that updated adtg_gui module. Me is doing this still manually each time....

It's in cop_rec code. You might want to try these following six adtg2 registers from 5D3 for vertical resolution:

https://bitbucket.org/hudson/magic-lantern/src/0075d0fa70f229ec972d7831aa756c4a9280e625/modules/crop_rec/crop_rec.c?at=crop_rec_4k&fileviewer=file-view-default#crop_rec.c-809

It also seems you have to modify timer a C0F06014 for verticl adjustment

It will work on any build which enables adtg gui module. Check Danne's previous posts he earlier linked some zips which are fine to use if you want to experiment.

I've got 2904x1254 recorded. My slow card can't manage it and also 14bit  lossless set it prints some "slot" error  after recording but the clip looks fine BUT there's a black border at the bottom at the exact size of the height extension

Code Select Expand

ML ASSERT:
slots[slot_index].size < max_frame_size
at mlv_lite.c:3408 (raw_video_rec_task), task raw_rec_task
lv:0 mode:3

raw_rec_task stack: 1edd18 [1eddd8-1ecdd8]
0x0044C94C @ a7a020:1edd48
0x0044C468 @ 44c9ac:1edd18

Magic Lantern version : Nightly.2018Jun11.100D101
Mercurial changeset   : 0075d0fa70f2+ (crop_rec_4k) tip
Built on 2018-06-11 10:38:36 UTC by ml@ml-pc.
Free Memory  : 578K + 1123K


Code Select Expand


ML ASSERT:
0
at mlv_lite.c:2517 (compress_task), task compress_task
lv:0 mode:3

compress_task stack: 1f1d58 [1f1de0-1f0de0]
0x0044C94C @ a751ac:1f1d88
0x0044C468 @ 44c9ac:1f1d58

Magic Lantern version : Nightly.2018Jun11.100D101
Mercurial changeset   : 0075d0fa70f2+ (crop_rec_4k) tip
Built on 2018-06-11 10:38:36 UTC by ml@ml-pc.
Free Memory  : 578K + 1122K


Here the settings to experiment with slightly reduced settings:
https://drive.google.com/file/d/10vPO9U7lrEh-iBbtYovBp8jquFDwmEOR/view?usp=sharing
https://drive.google.com/file/d/1ZVB8hif2B4WGNe0u-hepC3ZFFwrxMDcc/view?usp=sharing

Btw: Can you do some testing (3k width only) how much recording is possible and if there's corrupted frames etc.?

I am already getting better results in terms of height extension.  I wouldn't do more widht adjustments for now. It looks like we can do ~3000x1200 res. Maybe sacrifice some width to get more height. It also looks like whatevr we end up here will be 1:1 usable on 700D 

height can also be done. Just not yet stable enough.

These three help to get some dirty output {bottom and top 1/6 dirty}
ADTG2 8178 / 8179
C0F06014

We always said:
42fps at 1800x1012 in default movie crop mode is ok. We rip off fps but gain resolution. Now how to find the sweet spot for 24fps? Math?

x*y*42fps = 76507200

76507200 / 3000 width / 24fps = ~1060 height? So we should be nearby to the width limit already. if the calc is correct

Yay user TheBilalFakhouri already stated same (10-12bit lossless) not working when overriding resolution on 700D. So we are in the same boat. battery needs another charge 

Great stuff. It's much more fun to team up and I am already doing some maths based on a1ex's instructions. Guess first goal could be 3k width for now. It needs fiddling though I am optimistic we can increase height at a later time too:
https://www.magiclantern.fm/forum/index.php?topic=19300.1435

Ahh using MLV App first time as PC reinstalled freshly I would try it. I notice its getting better - the sluggishness appears to be caused also in playback  from "Dropped frame" option in MLV app? I just can record short clips with slow sdcard. Enabling sd_uhs, adtg_gu and mlv_lite doesn't work quite well for me at least. Getting malloc errors...

Did some more tests. You were ofc right with the broken preview etc. But somehow the recordings have this "sluggishness". So we need to find or correct some registers. Let me know your results

Danne please check my instructions again.
Your code is ok but check the static int before. You are applying 5D3 CMOS values.

Code Select Expand


static int crop_mode_reg(int reg)
{
       return 0;
}

static int res3k_reg(int reg)
{
    if (regs[reg].dst == 0xC0F0)
    {
        switch (regs[reg].reg)
        ....
       .....
      .....

Got it? You just have to return 0 for the dirty hack. rest is ok.
Btw: I am confused atm. I gave up becuase the raw recording also was sluggish. Same as the LCD. I guess it was that way!? Tried too much stuff at the same time  . Once you get it working maybe you can comment again and we can fine tune the values if it is ok.

I generally never do raw recording so I may have missed a bit too much regarding latest achievements.

Set the values as seen i my screenshots. Then open Canon menu and back. Voila!

[How to confirm:]

Danne, can you confirm that the sluggish LCD output (looks like 2 fps) is caused by Global draw and/or mlv_lite.

It does not happen on the crop_rec experiments download as well as "builds" download. My guess is manually defined fps timers in code luckily fix it "somehow".
playing with resolution extention i need to modify fps timers - either via adtg gui or manually in fps-engio.c.
Strange thing happens now when in video mode: Global draw in conjunction with mlv_lite causes it. No sub-options causing it - but main Global Draw ON, all modes. If you disable "RAW video" then it will not be "sluggish". On the other side. If you leave "RAW video" "ON" and disable "Global draw" it will not happen, too. Could be some edmac issue or whatever. We were just in luck nobody noticing it due to manually defined timer values. Now in need to change them the issue appears.

How to confirm:
Compile 100D_merge_fw101 branch and replace 100D timers in fps-engio.c. Code below sets both timers back to its original timers by also uncommenting timer B values.:

Code Select Expand


#elif defined(CONFIG_100D)
    #define TG_FREQ_BASE 32000000
    #define FPS_TIMER_A_MIN (fps_timer_a_orig)
    // no need to cause confusions as recording speed cannot handle such high fps in crop mode
    // (ZOOM || MV1080CROP ? 1288 : 1970)) <-- these are ok while not recording.
    // Hybrid CMOS AF II uses 60fps by default in LV/MV for the camera display
    // to achieve a "snappy" autofocus by doubling the fps
    // MV720 is not LV so we need to extend the definition for the LCD.
    // #define FPS_TIMER_B_MIN (ZOOM || MV1080CROP ? 1288 : MV720 || (lv && lv_dispsize==1 && !is_movie_mode()) ? 990 : 1970)
#elif defined(CONFIG_500D)
....
....

Next enable Global draw as well as RAW video and just press zoom X5 and the LCD output will be sluggish (kind of 2fps). It will also happen after focus confirmation. There's some overlay, too. I see hundreds f focus dots on the LCD. I don't remember acting the cam like this once beginning to port ML and even recently. Could be a commit in the repo in the last 6 months or so. I must admit I didn't use the cam for a long time.

Now go figure how to solve this before continuing with anything else. Any idea what to look at @a1ex? Edmac channels?