Messages

One small issue I noticed with the converter is that some tags, noticeably GPS coordinates, don't get transferred from CR2 to DNG, but adding -all:all to the exiftool command line fixed that for me:

Code Select Expand


diff -r 728e571a1276 modules/dual_iso/cr2hdr.c
--- a/modules/dual_iso/cr2hdr.c Wed Jul 24 16:58:18 2013 +0200
+++ b/modules/dual_iso/cr2hdr.c Fri Jul 26 22:42:56 2013 +0300
@@ -247,7 +247,7 @@
                 raw_info.white_level /= 4;

                 char exif_cmd[100];
-                snprintf(exif_cmd, sizeof(exif_cmd), "exiftool -tagsFromFile \"%s\" \"%s\" -overwrite_original", filename, out_filename);
+                snprintf(exif_cmd, sizeof(exif_cmd), "exiftool -tagsFromFile \"%s\" -all:all \"%s\" -overwrite_original", filename, out_filename);
                 int r = system(exif_cmd);
                 if (r != 0)
                     printf("Exiftool didn't work\n");


For some reason, dcraw was writing a pixel value of 65506 (come on, for 14-bit data, the range is 0-16383...). This also breaks my calculations (even the robust statistics part). The image is read correctly though.

I've converted the shot by hacking the source code a bit, but before providing a fix, I want to understand exactly what's going on.

http://acoutts.com/a1ex/IMGL9830.DNG
http://acoutts.com/a1ex/IMGL9830.jpg

Excellent, thank you!

Using cr2hdr from today (as of https://bitbucket.org/hudson/magic-lantern/commits/00ea74a66945b9626e0fe53807232af831d62269) compiled on OSX, I get a crash on one particular file:

Input file     : IMGL9830.CR2
Full size      : 5920 x 3950
Active area    : 5796 x 3870
Black borders  : 124 left, 80 top
ISO pattern    : BddB RGGB
Interpolation  : mean23-vsmooth3-contrast

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0xaa5e3408
0x00006967 in hdr_interpolate () at cr2hdr.c:1126
1126                   dark_smooth[x + y*w] = ev2raw[(raw2ev[a] + raw2ev[ b] + raw2ev[ b] + raw2ev[c]) / 4];
(gdb) p a
$1 = -30

Other files I've tried so far convert fine so I put the file up at https://www.dropbox.com/s/ruv13bn6ibkzm08/IMGL9830.CR2