Messages

@a1ex: I've been trying to modify handle_zoom_overlay() to show the zoom overlay only while half pressed; unfortunately without success...  It works if I press and then release half shutter (so it shows up and the disappears), but if I take a shot it remains on screen. This is what I've tried in handle_zoom_overlay(...) in zebra.c.

    if(get_zoom_overlay_trigger_by_halfshutter()) {
      //make sure zoom overlay is not shown and show it
      if (!is_zoom_overlay_triggered_by_zoom_btn() && event->param == BGMT_PRESS_HALFSHUTTER)
        zoom_overlay_toggle();
      //make sure it is shown and hide it
      else if(is_zoom_overlay_triggered_by_zoom_btn() && !get_halfshutter_pressed())
      //else if (is_zoom_overlay_triggered_by_zoom_btn() && event->param == BGMT_UNPRESS_HALFSHUTTER)
   zoom_overlay_toggle();     
    }   

What am I doing wrong ?

Btw. EOSM (apparently) falls under the #ifdef CONFIG_ZOOM_BTN_NOT_WORKING_WHILE_RECORDING ... #endif branch so I'm basically trying there to replace

     if (event->param == BGMT_PRESS_HALFSHUTTER && get_zoom_overlay_trigger_by_halfshutter())
        zoom_overlay_toggle();

by the above.

At first, Magic Zoom used the Zoom In button for toggling; that would require one click to enable the zoomed window and another click to disable it. However, on some models, the Zoom In button did not work while recording (the MPU just does not send these events); in this case, half-shutter was used instead, but the overall logic wasn't changed. I assume you want it to be displayed only while holding half-shutter, right?

Yes, this is what I'm after.

The toggling logic is in zebra.c, handle_zoom_overlay.

Ok, I'll have a look and see if I can manage. I'll post here my findings.

Anyways, thanks for your help !

Maybe you have looked at this PR ?

Indeed. Problems with this are: i) freezes the ML bar (no distance update near/far, etc. info), and ii) Canon's bar only partially covers the ML one, so it looks ugly.

Caveat: this tiny issue may turn into a big rabbit hole: we have already tried many workarounds (though none of them attempted to save and restore the bitmap overlay contents). And I don't currently have a way to test this workaround on cameras I don't own (need to update the emulator to handle LiveView, and that's not exactly an easy task).

What would it take to restore image info underneath ? On the other hand, it's not a big issue, as you've already pointed out. Also, I'm fine with my current solution (moved the ML bar slightly upwards so that it's never under the Canon bar, and re-enable real-time updates).

One more thing . I've played with magic zoom. I have it kick in on half-shutter + zoom ring (Default, I think). However, it only works every other time I use the half shutter. So on first half-press, magic zoom pops up as expected. If I depress half-shutter, it's still on screen... Only if I push half-shutter a second time it goes away, then it all repeats. Is this the normal behaviour ? I suppose not. I'd expect, once I release the half-shutter, it goes away and then the whole sequence repeats.

What could I do to attempt fixing this ? Where should I start ?

@a1ex: I'll have to look into the throttling commands. Thanks for pointing me to your commit.

One more little annoyance is the bottom Canon bar overwriting the ML one, when half-shutter pressed. I've came across a commit dealing with this -- forgot exactly which one -- but that would merely freeze the ML bar so that the Canon one takes cleanly over. Not exactly the right way, I'd say....

What I have in mind is a follows: By default, show the ML bottom bar, as is. If half-shutter pressed, restore background (part of image in LV), hide the ML bar from the bottom-most position and have it rendered on top of the (bottom) Canon bar. All additional stuff like DOF (near/far points) can be translated on top of the ML bar AND be updated in 'realtime'. At this instance (half-shutter still pressed), some items from the ML bar can also be hidden, since they are redundant (they appear anyhow in the Canon bar). This in my opinion would be nice... 

For now, I simply moved the ML bar upwards just enough such that the Canon bar never overwrites it. It's quite fine, though what I've tried to describe above would be nicer, I think. Is this doable ? May main question is now -- can we quickly 'erase' the ML bar ? I.e., restore image pixels underneath ?

Other than finding a way to reproduce and inserting printf's in the source code to see where it fails, no idea. Is the entire UI locked up? or just half-shutter? or only some of the actions triggered by half-shutter, such as autofocus?

It's only the autofocus system not reacting to the half shutter. The GUI behaves normally, well sort of... When the issue happens, if I press the half-shutter the Canon bottom bar appears (as usual), but (re)focusing doesn't work (not even the focus window appears). Then, if I depress the shutter and try a second time,  the bottom Canon bar appears but shows that exposure is locked. IF I also press the exposure lock button, and keep shutter pressed half-way, then focus seems to kick in. If I depress the buttons focus becomes inactive and it all repeats... Btw. I can shoot a picture at any time, but it will be out of focus. So, to me this sounds more of a messed-up state, right ?

 

@a1ex: Thanks for the info. I'll start reading the posts in the links you gave me.

But, maybe you haven't noticed my Edit in the initial message, but focus stacking definitely works here . One issue is that sometimes after running the stack the focus gets stuck, i.e., it doesn't respond to half-shutter presses. Any idea how this can be cured ?

Thanks ! 

First of all, thank you all devs. for the hard work you guys put in the ML development.

===

I'm a new user of ML on an EOS M and very much impressed by the features offered by ML on this camera... I also have a feature I miss, that is focus stacking, which according to the feature matrix is not supported on EOS M. I was wondering, what is the missing info that is required to get this feature working ? I was studying the ML code and I already have some prime suspect, but I'd like to ask advice from devs.

Also, what are the main tools for figuring out possible stubs/property cases, etc. ? (Btw., I know a bit about how CHDK works, but I'm new to ML.)

Thanks !   

EDIT: Well, in the meantime I went ahead and recompiled ML sources with enabled FEATURE_FOLLOW_FOCUS, FEATURE_RACK_FOCUS and  FEATURE_FOCUS_STACKING, and (at least) focus stacking seems to work . Am I missing something ?