Author Topic: Canon EOS M  (Read 863408 times)

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5997
Re: Canon EOS M
« Reply #2200 on: February 16, 2019, 12:22:20 PM »
New build:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg208959#msg208959

Great @masc. Thanks for pixelpeeping. Is version above without the bottom red line?

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1403
Re: Canon EOS M
« Reply #2201 on: February 16, 2019, 01:09:12 PM »
Thanks Danne. The red line is away. But did you change more? In my test clip I got so much moiree and "stair effects" at diagonal lines... way more than with yesterdays build (but don't have it anymore to compare). MLVApp 100% zoom ( f/2.8 ):



Edit: compared to the "old" mv1080p mode, no stairs to see there using same settings. So something is strange with new version.
5D2.212 | EOSM.202

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5997
Re: Canon EOS M
« Reply #2202 on: February 16, 2019, 02:22:32 PM »
Funky. Deleted the build. Will check into it this evening.

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5997
Re: Canon EOS M
« Reply #2203 on: February 16, 2019, 02:56:17 PM »
By the way. Could you test and compare like this:
In Crop mode sub menu do:
Skip_top 2
Skip_bottom -2
This is the old settings.

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1403
Re: Canon EOS M
« Reply #2204 on: February 16, 2019, 04:03:29 PM »
Yes, it is better with the change of these two variables. Extreme moiree is gone again. But I don't see the red line... find no green to film for test here.

Edit: yes... red line is back again, moiree is gone with +2, -2. It is not just moiree, there is much more noise and very red focus pixels.
5D2.212 | EOSM.202

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5997
Re: Canon EOS M
« Reply #2205 on: February 16, 2019, 04:15:58 PM »
You could test maybe +1 and -1 too? Will check over here as well.

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5997
Re: Canon EOS M
« Reply #2206 on: February 16, 2019, 04:39:47 PM »
New build:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg208959#msg208959

@masc, please test.
Confirmed getting sharper focus pixels and more moiré before. Why, I have no idea.

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1403
Re: Canon EOS M
« Reply #2207 on: February 16, 2019, 04:43:38 PM »
What's different in this build?
I tested:
+0-0: moiree and no line
+1-1: less moiree and line
+2-2: have to search moiree and line
+3-3: extreme moiree and noise and 2 lines

Maybe -1+1 is better? :D Edit: no.  :P
5D2.212 | EOSM.202

dfort

  • Developer
  • Hero Member
  • *****
  • Posts: 3739
Re: Canon EOS M
« Reply #2208 on: February 16, 2019, 04:53:30 PM »
There are some cases where the edges might show a red line or a green line or just a change in density depending on what app you use (assuming MLV App in your case).

Here's an extreme example that ACR shows but dcraw doesn't:



If you pixel peep the bottom of Danne's cat picture there's also something going on:



Not sure how debayering works but depending on the algorithm it seems that things can get messed up at the very edges. I pointed this out to Dave Coffin, dcraw developer, but never got a reply from him or a clue how this could be fixed. My hunch is that solving this would also help when removing focus pixels from dual iso footage.
5D3.* 7D.206 700D.115 EOSM.203 EOSM2.103 M50.102

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1403
Re: Canon EOS M
« Reply #2209 on: February 16, 2019, 04:59:23 PM »
Tested new build... no red line, but very colorful moiree (I think more then in yesterdays build)

Picture @ f2.8 (full open)
5D2.212 | EOSM.202

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5997
Re: Canon EOS M
« Reply #2210 on: February 16, 2019, 05:02:01 PM »
I have the issue right now I can´t reproduce. @masc. What are your settings? fps, iso.

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1403
Re: Canon EOS M
« Reply #2211 on: February 16, 2019, 05:07:33 PM »

1/97... ups... hahaha
5D2.212 | EOSM.202

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5997
Re: Canon EOS M
« Reply #2212 on: February 16, 2019, 05:18:23 PM »
From the latest upload I tested a static scene and ran:
0, 0
+1, -1
+2, -2
+3, -3
+4, -4
then:
-1, +1
+2, -2

All files were about the same regarding aliasing and focus pixels. Hmm.

Could you do a static scene with exact same settings and produce two examples which clearly shows the difference imagewise?

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1403
Re: Canon EOS M
« Reply #2213 on: February 16, 2019, 05:32:09 PM »
Have to do it tomorrow. It is getting dark and the best view to reproduce was outside with fences and trees. Inside I don't get moiree.
5D2.212 | EOSM.202

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1403
Re: Canon EOS M
« Reply #2214 on: February 16, 2019, 05:52:00 PM »
All I see with indoor tests is:
+5-5; +6-6: white line and a red line at the bottom
+3-3; +4-4: red line at the bottom
+1-1; +2-2; 0 0; -1+1; -2+2: no line at the bottom
5D2.212 | EOSM.202

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5997
Re: Canon EOS M
« Reply #2215 on: February 16, 2019, 06:21:41 PM »
Yeah, the line was easy to get rid of. We need to check what else is going on.
By the way. With this applied in adtg_gui I could correct the black border to the right. Having trouble applying it in crop_rec.c though:
Code: [Select]
case 0xc0f383d4: return 0x4f0010;
case 0xc0f383dc: return 0x42401c6;
Not always sure what regs are applied and which are not going to be accepted in there...

gravitatemediagroup

  • Member
  • ***
  • Posts: 239
Re: Canon EOS M
« Reply #2216 on: February 16, 2019, 06:48:44 PM »
I did a quick 1 clip test of the new 1080 setting and my results were similar to the screen shot a few post up.  ISO was at 800, that's the only specific setting remember, I deleted already assuming it was something I had wrong, but I figured I'd report the issue letting you know it may be something in the build

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5997
Re: Canon EOS M
« Reply #2217 on: February 16, 2019, 07:08:37 PM »
I need mlv files and test comparisons since I can't reproduce the issue. You can reproduce.

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1403
Re: Canon EOS M
« Reply #2218 on: February 16, 2019, 07:09:15 PM »
@Danne: this was filmed this morning when testing yesterdays build (Feb15). I really loved the quality of this version. It was really hard to find some moiree... (one roof had some). Hope we get this back soon without red line, without noise & moiree! :)
5D2.212 | EOSM.202

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5997
Re: Canon EOS M
« Reply #2219 on: February 16, 2019, 09:23:07 PM »
Here is a version which will help testing:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Feb16.EOSM202TEST_rewire.zip

Once all is set and rewired you can enter Crop mode sub menu and set test_rewire to "old" for the settings with the thin red line at the bottom. If set to off you get the latest settings without the thin red line. We need static test scenes for comparisons of moiré and other anomalies.


jacquaviva

  • New to the forum
  • *
  • Posts: 17
Re: Canon EOS M
« Reply #2220 on: February 17, 2019, 02:44:30 AM »
Thank you Danne for your work, correct preview is wonderful.
Nevertheless, I get a strange white cross pattern in the middle of each frame and more in general all over the frame a black pattern.



 

dfort

  • Developer
  • Hero Member
  • *****
  • Posts: 3739
Re: Canon EOS M
« Reply #2221 on: February 17, 2019, 03:35:34 AM »
Those are focus pixels. They can be removed in post. Working on it.


Sent from my iPhone using Tapatalk
5D3.* 7D.206 700D.115 EOSM.203 EOSM2.103 M50.102

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1403
Re: Canon EOS M
« Reply #2222 on: February 17, 2019, 09:57:03 AM »
Hi Danne, light is back, so I tried out your build now. But it looks not as expected:
-rewire=old: no red line
-rewire=off, -2+2=no red line
-rewire=off, +0-0/-1+1=red line
-rewire=off, +1-1/+2-2=red line + one white line
-rewire=off, +3-3/+4-4=red line + two white lines
-rewire=off, +5-5/+6-6=red line + three white lines
Moiree looks always identical (better than yesterday, but can't compare to Feb15). But I don't find stair effects.
5D2.212 | EOSM.202

Danne

  • Contributor
  • Hero Member
  • *****
  • Posts: 5997
Re: Canon EOS M
« Reply #2223 on: February 17, 2019, 10:07:04 AM »
Try refreshing after enabling "old" by opening canon menu and also maybe ml menu.
Tested this morning and it´s not possible to reproduce any issues. What happens is that aliasing can be produced differently but that has more to do with focus, not with ratio changes.

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 1403
Re: Canon EOS M
« Reply #2224 on: February 17, 2019, 10:26:42 AM »
Okay... got it reproduced, but not as expected. Will shorten the files and upload. Best by far is rewire=Off, -2+2. ;)
5D2.212 | EOSM.202