Author Topic: 600D and MLV: hack error  (Read 5037 times)

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 562
600D and MLV: hack error
« on: October 13, 2013, 11:30:14 PM »
I enable extra hacks in the raw-rec-module. If I start a record, I get this message on cameradisplay:

Code: [Select]
hackerror at 0
expected e3a00032, got 0

What´s wrong, what can I do?

(latest mlv-sources from g3gg0-repo)

Edgar
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3155
Re: 600D and MLV: hack error
« Reply #1 on: October 14, 2013, 12:30:27 AM »
does the same happen with the original raw_rec?
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

1%

  • Developer
  • Hero Member
  • *****
  • Posts: 5936
  • 600D/6D/50D/EOSM/7D
Re: 600D and MLV: hack error
« Reply #2 on: October 14, 2013, 02:11:24 AM »
Did you add the 600D timer address?

cam_600d ? 0xFF37AA18

Rewind

  • Senior
  • ****
  • Posts: 356
Re: 600D and MLV: hack error
« Reply #3 on: October 14, 2013, 04:58:18 AM »
The same behaviour with 650D and 550D (original raw_rec from latest nightlies)
What are the timer addresses for these cameras and where should we add them?

Doyle4

  • Hero Member
  • *****
  • Posts: 690
  • Canon 5DRAWii & 600Dual-Iso
Re: 600D and MLV: hack error
« Reply #4 on: October 14, 2013, 02:43:03 PM »
Iv noticed this for awhile now, have posted in Nightly's but didnt hear back, dont know how to code either, sorry :(

Rewind

  • Senior
  • ****
  • Posts: 356
Re: 600D and MLV: hack error
« Reply #5 on: October 14, 2013, 03:11:57 PM »
I think this is the section of raw_rec.c, where we should add the addresses for orther cameras:

Code: [Select]
/* change dialog refresh timer from 50ms to 8192ms */
        uint32_t dialog_refresh_timer_addr = /* in StartDialogRefreshTimer */
            cam_50d ? 0xffa84e00 :
            cam_5d2 ? 0xffaac640 :
            cam_5d3 ? 0xff4acda4 :
            cam_7d  ? 0xFF345788 :
            cam_700d ? 0xFF52B53C :
            /* ... */

But how we should figure these addresses out for 550D, 650D and others?

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 562
Re: 600D and MLV: hack error
« Reply #6 on: October 14, 2013, 04:12:16 PM »
does the same happen with the original raw_rec?

Yes, the same happens on original ML.

I wrote 1% proposal into my clone of original ML (raw_rec.c)and compiled the module new. But no changes. The same error as before.

Edgar
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

1%

  • Developer
  • Hero Member
  • *****
  • Posts: 5936
  • 600D/6D/50D/EOSM/7D
Re: 600D and MLV: hack error
« Reply #7 on: October 14, 2013, 05:42:37 PM »
Did you do it right, because I don't get the error, timers slow down and it still checks the address its patching.

https://bitbucket.org/OtherOnePercent/tragic-lantern-2.0/src/fe768c4e30178ab7625346d8530e6b135c92a11d/modules/raw_rec/raw_rec.c?at=unified

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 562
Re: 600D and MLV: hack error
« Reply #8 on: October 14, 2013, 11:15:12 PM »
Oh, I did forget raw_rec_ini. Now the error has gone. I will do some more tests tomorrow evening.

ThankYou 1%

Edgar
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 562
Re: 600D and MLV: hack error
« Reply #9 on: October 15, 2013, 08:45:02 PM »
Fixed for 600D. Did a pull request to ML. I hope, this will go into MLV too one day.

ThankYou for your help

Edgar
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3155
Re: 600D and MLV: hack error
« Reply #10 on: October 15, 2013, 10:18:35 PM »
merged, can you test?
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 562
Re: 600D and MLV: hack error
« Reply #11 on: October 15, 2013, 10:50:42 PM »
Tested. Runs fine without hack error.  :)

Edgar
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

mk11174

  • Contributor
  • Hero Member
  • *****
  • Posts: 809
Re: 600D and MLV: hack error
« Reply #12 on: October 16, 2013, 09:31:22 AM »
I think this is the section of raw_rec.c, where we should add the addresses for orther cameras:

Code: [Select]
/* change dialog refresh timer from 50ms to 8192ms */
        uint32_t dialog_refresh_timer_addr = /* in StartDialogRefreshTimer */
            cam_50d ? 0xffa84e00 :
            cam_5d2 ? 0xffaac640 :
            cam_5d3 ? 0xff4acda4 :
            cam_7d  ? 0xFF345788 :
            cam_700d ? 0xFF52B53C :
            /* ... */

But how we should figure these addresses out for 550D, 650D and others?
Found it for 550D cam_550d ? 0xFF2FE5E4
500D/T1i  550D/T2i  600D/T3i  700D/T5i

Rewind

  • Senior
  • ****
  • Posts: 356
Re: 600D and MLV: hack error
« Reply #13 on: October 16, 2013, 12:16:36 PM »
Found it for 550D cam_550d ? 0xFF2FE5E4

That's great. Would you mind to describe the process of this finding a little bit in order we can get this address for 650D?

UPD. thanks to mk11174, now we have the right one for 650D: 0xFF527E38

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3155
Re: 600D and MLV: hack error
« Reply #14 on: October 16, 2013, 12:52:00 PM »
can you make a pull request, so i can merge it from here? (not at home at the moment)
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

mk11174

  • Contributor
  • Hero Member
  • *****
  • Posts: 809
Re: 600D and MLV: hack error
« Reply #15 on: October 17, 2013, 02:47:17 AM »
can you make a pull request, so i can merge it from here? (not at home at the moment)
I made the pull request and it was merged  :)
500D/T1i  550D/T2i  600D/T3i  700D/T5i