Author Topic: PinkDotRemover tool 650D  (Read 402984 times)

foorgol

  • Freshman
  • **
  • Posts: 50
Re: PinkDotRemover tool 650D
« Reply #125 on: August 02, 2013, 06:08:27 AM »
it is so awesome fast.  8)

Yes, I had the same impression, although I didn't make any specific performance tests. Since the code for the dot removal itself is identical for both DNGs and RAWs, my assumption is that the opening/closing of many DNGs files consumes time. Even the overall amount of data read and written from/to disk is identical between processing a RAW and its DNGs. So it must be the handling of maaany files....

foorgol

  • Freshman
  • **
  • Posts: 50
Re: PinkDotRemover tool 650D
« Reply #126 on: August 02, 2013, 06:18:30 AM »
May you have a look at this thread http://www.magiclantern.fm/forum/index.php?topic=5645.new#new

I think you can give fatpig better information than me. Because I asked if it is possible to integrate the pinkdotremover into BATCHelor.

Done:

http://www.magiclantern.fm/forum/index.php?topic=5645.msg63402#msg63402

spider

  • Member
  • ***
  • Posts: 243
Re: PinkDotRemover tool 650D
« Reply #127 on: August 02, 2013, 08:47:19 PM »
Thank you.

And I think the same it is faster because there are not so many files operations. The speed improvement should be the biggest on 5800 rpm drives and maybe only a little improvement on SSD.

foorgol

  • Freshman
  • **
  • Posts: 50
Re: PinkDotRemover tool 650D
« Reply #128 on: August 08, 2013, 03:21:39 AM »
Little update:

Exchanged a few messages about the BATCHelor integration with fatpig the last days. Looks as if he could just call the PinkDotRemover from the command line. For this purpose I added a few lines of code to enable camera type selection for the command line mode of the PDR. Up to now, the cam type was immutably set to 650D when using the command line.

In the meantime, mixer2 provided a few goodies for the GUI: he improved the file list, added the ability to delete individual files from the list and introduced support for Drag'n'Drop!

So be prepared for a new release coming out soon! :)

Tongotongo

  • Freshman
  • **
  • Posts: 50
Re: PinkDotRemover tool 650D
« Reply #129 on: August 09, 2013, 07:32:55 AM »
Hola , se agradecería si  incluyes la resolución 1728x526 en el próximo pinkdotremove , en oras resoluciones funciona perfecto. Muchas gracias y sigan así. Saludos . 

Hello, it would be appreciated if you include the resolution 1728x526 in the next pinkdotremove in resolutions pray it works perfect. Thank you very much and keep it up. Greetings.
Canon 650d Tamron 17-50 mm 2.8 canon 50 mm fijo 1.8 magic lantern

spider

  • Member
  • ***
  • Posts: 243
Re: PinkDotRemover tool 650D
« Reply #130 on: August 09, 2013, 12:01:40 PM »
So be prepared for a new release coming out soon! :)
Thank you very much.

demetrisag

  • Freshman
  • **
  • Posts: 79
Re: PinkDotRemover tool 650D
« Reply #131 on: August 09, 2013, 05:45:01 PM »
drag and drop is a dream coming true!

mkay

  • New to the forum
  • *
  • Posts: 6
Re: PinkDotRemover tool 650D
« Reply #132 on: August 10, 2013, 10:09:52 PM »
cool, thanks for your effort :)
and btw. wtfpl is a cool license choice, haha.

TheUnkn0wn

  • Freshman
  • **
  • Posts: 60
Re: PinkDotRemover tool 650D
« Reply #133 on: August 12, 2013, 09:52:05 PM »
Would be cool if you could add the signature for the 700D  :)

http://puu.sh/40nze.png
http://puu.sh/40nwP.png

TheUnkn0wn

  • Freshman
  • **
  • Posts: 60
Re: PinkDotRemover tool 650D
« Reply #134 on: August 17, 2013, 07:58:54 PM »

Walter Schulz

  • Contributor
  • Hero Member
  • *****
  • Posts: 8492
Re: PinkDotRemover tool 650D
« Reply #135 on: August 17, 2013, 09:19:57 PM »
This is good news! I have to be patient for satriani's new build tomorrow ... very patient.

Ciao, Walter

demetrisag

  • Freshman
  • **
  • Posts: 79
Re: PinkDotRemover tool 650D
« Reply #136 on: August 17, 2013, 09:23:15 PM »

spider

  • Member
  • ***
  • Posts: 243
Re: PinkDotRemover tool 650D
« Reply #137 on: August 17, 2013, 09:55:29 PM »
Looks like I figured the problem out, no need for this anymore ;)

https://bitbucket.org/hudson/magic-lantern/pull-request/184/700d-650d-remove-pink-dots-from-raw/diff
:o :D ;D
How does it work? Are these pixels interpolate in the camera?

TheUnkn0wn

  • Freshman
  • **
  • Posts: 60
Re: PinkDotRemover tool 650D
« Reply #138 on: August 17, 2013, 10:18:54 PM »
:o :D ;D
How does it work? Are these pixels interpolate in the camera?

Nope, nothing is interpolated. Which means your not losing any details anymore. I've set the RAW_TYPE to a stream that doesn't contain those anomalies.

nanomad

  • Administrator
  • Hero Member
  • *****
  • Posts: 2918
  • All your websites are belong to us
Re: PinkDotRemover tool 650D
« Reply #139 on: August 17, 2013, 11:07:35 PM »
Raw 99 is full of green dots on the 650D :/
EOS 1100D | EOS 650 (No, I didn't forget the D) | Ye Olde Canon EF Lenses ('87): 50 f/1.8 - 28 f/2.8 - 70-210 f/4 | EF-S 18-55 f/3.5-5.6 | Metz 36 AF-5

satriani

  • Freshman
  • **
  • Posts: 82
Re: PinkDotRemover tool 650D
« Reply #140 on: August 17, 2013, 11:27:27 PM »
The same for me nanomad. How it looks with 700D is the picture clean?
Cameras: Canon EOS 70D, Canon EOS 650D
Lenses: 2x CanonEF-S 18-135 IS STM, Sigma 50mm f1.4 DG HSM Art
Daily builds

TheUnkn0wn

  • Freshman
  • **
  • Posts: 60
Re: PinkDotRemover tool 650D
« Reply #141 on: August 17, 2013, 11:28:07 PM »
Raw 99 is full of green dots on the 650D :/

For me the 700D has a perfect picture with 99. When I was pixel peeping the RAW_TYPE's I found that 78 and 99 were the best.

Try 78? Looks like the 650D and 700D aren't "exactly" the same after all. If that doesn't work then run this

debug.c - based off work from a1ex
Code: [Select]
#include "raw.h"

static void run_test()
{
    char fn[100];
   
    for (int type = 0; type < 100; type++) {
        MEM(0x350B4) = type;
       
        raw_lv_request();
        msleep(50);
       
        raw_lv_release();
        msleep(50);

        raw_update_params();

        snprintf(fn, sizeof(fn), "%s/%04d.DNG", get_dcim_dir(), type);

        bmp_printf(FONT_MED, 0, 60, "Saving raw type %d, %d x %d...", type, raw_info.jpeg.width, raw_info.jpeg.height);
        save_dng(fn);
    }
}

You will have to pixel peep all of the pictures, I used Lightroom to do this.

satriani

  • Freshman
  • **
  • Posts: 82
Re: PinkDotRemover tool 650D
« Reply #142 on: August 17, 2013, 11:35:44 PM »
Cameras: Canon EOS 70D, Canon EOS 650D
Lenses: 2x CanonEF-S 18-135 IS STM, Sigma 50mm f1.4 DG HSM Art
Daily builds


nanomad

  • Administrator
  • Hero Member
  • *****
  • Posts: 2918
  • All your websites are belong to us
Re: PinkDotRemover tool 650D
« Reply #144 on: August 17, 2013, 11:51:10 PM »
Can you upload a DNG with 78 while focusing on text or hard H / V edges?
EOS 1100D | EOS 650 (No, I didn't forget the D) | Ye Olde Canon EF Lenses ('87): 50 f/1.8 - 28 f/2.8 - 70-210 f/4 | EF-S 18-55 f/3.5-5.6 | Metz 36 AF-5

satriani

  • Freshman
  • **
  • Posts: 82
Re: PinkDotRemover tool 650D
« Reply #145 on: August 17, 2013, 11:55:23 PM »
Sorry guys, it was a bit dark in my room. When the light is on, then this looks not good :/





Cameras: Canon EOS 70D, Canon EOS 650D
Lenses: 2x CanonEF-S 18-135 IS STM, Sigma 50mm f1.4 DG HSM Art
Daily builds

TheUnkn0wn

  • Freshman
  • **
  • Posts: 60
Re: PinkDotRemover tool 650D
« Reply #146 on: August 18, 2013, 12:15:19 AM »
Looks like someone with a 650D will have to run this

http://www.magiclantern.fm/forum/index.php?topic=6658.msg67745#msg67745

P.S : After making the changes in debug.c, to run it go to the Debug menu in ML and click on Don't click on this!

nanomad

  • Administrator
  • Hero Member
  • *****
  • Posts: 2918
  • All your websites are belong to us
Re: PinkDotRemover tool 650D
« Reply #147 on: August 18, 2013, 12:37:00 AM »
BTW, the key difference between the 650D and the 700D/100D is the LV cont. AF algorithm.

650D: v1
EOSM with FW upgrade: v1.1 (simply a v1 tweaked for for more speed probably)
700D/100D: v1.5 (LV feed @ 60 FPS according to canon, possibly other tweaks)
70D: v2 (dual pixel sensor)
EOS 1100D | EOS 650 (No, I didn't forget the D) | Ye Olde Canon EF Lenses ('87): 50 f/1.8 - 28 f/2.8 - 70-210 f/4 | EF-S 18-55 f/3.5-5.6 | Metz 36 AF-5

TheUnkn0wn

  • Freshman
  • **
  • Posts: 60
Re: PinkDotRemover tool 650D
« Reply #148 on: August 18, 2013, 02:10:34 AM »
Who wants to do some pixel peeping for the 650D?

Code: [Select]
https://www.dropbox.com/s/8gkifgx2lwwq2rx/650D.104-RAW_TYPES.zip

Download that, replace the files on your 650D SD card. Enter Movie Mode, go to the debug menu and click on "Don't click on this!"

It will start taking 100 frames, might take a while. Make sure you keep your camera on something static so you can pixel peep properly.

Once it has done you should have 0000-0099 DNG's on your SD card. Go through them all (I recommend light room) and find the BEST one out of them all, report your findings REPORT THE FILE NAME of the best one you've found.

Walter Schulz

  • Contributor
  • Hero Member
  • *****
  • Posts: 8492
Re: PinkDotRemover tool 650D
« Reply #149 on: August 18, 2013, 03:21:50 AM »
Error: Cannot be opened as zip ...