PinkDotRemover tool 650D

[foorgol]

it is so awesome fast. 

Yes, I had the same impression, although I didn't make any specific performance tests. Since the code for the dot removal itself is identical for both DNGs and RAWs, my assumption is that the opening/closing of many DNGs files consumes time. Even the overall amount of data read and written from/to disk is identical between processing a RAW and its DNGs. So it must be the handling of maaany files....

[foorgol]

May you have a look at this thread http://www.magiclantern.fm/forum/index.php?topic=5645.new#new

I think you can give fatpig better information than me. Because I asked if it is possible to integrate the pinkdotremover into BATCHelor.

Done:

http://www.magiclantern.fm/forum/index.php?topic=5645.msg63402#msg63402

[spider]

Thank you.

And I think the same it is faster because there are not so many files operations. The speed improvement should be the biggest on 5800 rpm drives and maybe only a little improvement on SSD.

[foorgol]

Little update:

Exchanged a few messages about the BATCHelor integration with fatpig the last days. Looks as if he could just call the PinkDotRemover from the command line. For this purpose I added a few lines of code to enable camera type selection for the command line mode of the PDR. Up to now, the cam type was immutably set to 650D when using the command line.

In the meantime, mixer2 provided a few goodies for the GUI: he improved the file list, added the ability to delete individual files from the list and introduced support for Drag'n'Drop!

So be prepared for a new release coming out soon!

[Tongotongo]

Hola , se agradecería si  incluyes la resolución 1728x526 en el próximo pinkdotremove , en oras resoluciones funciona perfecto. Muchas gracias y sigan así. Saludos . 

Hello, it would be appreciated if you include the resolution 1728x526 in the next pinkdotremove in resolutions pray it works perfect. Thank you very much and keep it up. Greetings.

[spider]

So be prepared for a new release coming out soon!

Thank you very much.

[demetrisag]

drag and drop is a dream coming true!

[mkay]

cool, thanks for your effort
and btw. wtfpl is a cool license choice, haha.

[TheUnkn0wn]

Would be cool if you could add the signature for the 700D 

http://puu.sh/40nze.png
http://puu.sh/40nwP.png

[TheUnkn0wn]

Looks like I figured the problem out, no need for this anymore

https://bitbucket.org/hudson/magic-lantern/pull-request/184/700d-650d-remove-pink-dots-from-raw/diff

[Walter Schulz]

This is good news! I have to be patient for satriani's new build tomorrow ... very patient.

Ciao, Walter

[demetrisag]

Looks like I figured the problem out, no need for this anymore

https://bitbucket.org/hudson/magic-lantern/pull-request/184/700d-650d-remove-pink-dots-from-raw/diff

is this for real?

[spider]

Looks like I figured the problem out, no need for this anymore

https://bitbucket.org/hudson/magic-lantern/pull-request/184/700d-650d-remove-pink-dots-from-raw/diff

How does it work? Are these pixels interpolate in the camera?

[TheUnkn0wn]

How does it work? Are these pixels interpolate in the camera?

Nope, nothing is interpolated. Which means your not losing any details anymore. I've set the RAW_TYPE to a stream that doesn't contain those anomalies.

[nanomad]

Raw 99 is full of green dots on the 650D :/

[satriani]

The same for me nanomad. How it looks with 700D is the picture clean?

[TheUnkn0wn]

Raw 99 is full of green dots on the 650D :/

For me the 700D has a perfect picture with 99. When I was pixel peeping the RAW_TYPE's I found that 78 and 99 were the best.

Try 78? Looks like the 650D and 700D aren't "exactly" the same after all. If that doesn't work then run this

debug.c - based off work from a1ex

Code: [Select]

#include "raw.h"

static void run_test()
{
    char fn[100];
   
    for (int type = 0; type < 100; type++) {
        MEM(0x350B4) = type;
       
        raw_lv_request();
        msleep(50);
       
        raw_lv_release();
        msleep(50);

        raw_update_params();

        snprintf(fn, sizeof(fn), "%s/%04d.DNG", get_dcim_dir(), type);

        bmp_printf(FONT_MED, 0, 60, "Saving raw type %d, %d x %d...", type, raw_info.jpeg.width, raw_info.jpeg.height);
        save_dng(fn);
    }
}

You will have to pixel peep all of the pictures, I used Lightroom to do this.

[satriani]

78 looks fine 

And here third and the last for today build

[TheUnkn0wn]

https://bitbucket.org/hudson/magic-lantern/pull-request/186/700d-650d-found-better-raw_type/diff

[nanomad]

Can you upload a DNG with 78 while focusing on text or hard H / V edges?

[satriani]

Sorry guys, it was a bit dark in my room. When the light is on, then this looks not good :/

[TheUnkn0wn]

Looks like someone with a 650D will have to run this

http://www.magiclantern.fm/forum/index.php?topic=6658.msg67745#msg67745

P.S : After making the changes in debug.c, to run it go to the Debug menu in ML and click on Don't click on this!

[nanomad]

BTW, the key difference between the 650D and the 700D/100D is the LV cont. AF algorithm.

650D: v1
EOSM with FW upgrade: v1.1 (simply a v1 tweaked for for more speed probably)
700D/100D: v1.5 (LV feed @ 60 FPS according to canon, possibly other tweaks)
70D: v2 (dual pixel sensor)

[TheUnkn0wn]

Who wants to do some pixel peeping for the 650D?

Code: [Select]

https://www.dropbox.com/s/8gkifgx2lwwq2rx/650D.104-RAW_TYPES.zip

Download that, replace the files on your 650D SD card. Enter Movie Mode, go to the debug menu and click on "Don't click on this!"

It will start taking 100 frames, might take a while. Make sure you keep your camera on something static so you can pixel peep properly.

Once it has done you should have 0000-0099 DNG's on your SD card. Go through them all (I recommend light room) and find the BEST one out of them all, report your findings REPORT THE FILE NAME of the best one you've found.

[Walter Schulz]

Error: Cannot be opened as zip ...