Author Topic: Warnings for bad settings  (Read 2771 times)

a1ex

  • Administrator
  • Hero Member
  • *****
  • Posts: 12564
Warnings for bad settings
« on: November 05, 2012, 03:56:06 PM »
Idea: http://www.magiclantern.fm/forum/index.php?topic=3487.msg17859#msg17859

(and I've also forgot picture quality to JPEG after clearing the settings)

So, I've added a framework where ML can warn you if you change some settings by mistake. I've started with what I'd use:
- Mode: other than M
- Picture quality: other than RAW

Code: https://bitbucket.org/hudson/magic-lantern/changeset/7c3541430760

What other settings can benefit from such warnings?

nanomad

  • Administrator
  • Hero Member
  • *****
  • Posts: 2918
  • All your websites are belong to us
Re: Warnings for bad settings
« Reply #1 on: November 05, 2012, 04:04:06 PM »
From the top of my head:
For video mode :
 - FPS + Res combo, altough it may be a PITA to code due to different cameras having different settings
 - AGC / Manual sound level (for cameras that have it buried in canon menus)

For stills shooting;
 - Colorspace (altough the default is sane enough)
EOS 1100D | EOS 650 (No, I didn't forget the D) | Ye Olde Canon EF Lenses ('87): 50 f/1.8 - 28 f/2.8 - 70-210 f/4 | EF-S 18-55 f/3.5-5.6 | Metz 36 AF-5

a1ex

  • Administrator
  • Hero Member
  • *****
  • Posts: 12564
Re: Warnings for bad settings
« Reply #2 on: November 05, 2012, 04:17:46 PM »
I've also added ALO, since there was someone who had exposure problems even if he had manual exposure enabled.

Here's how to add a warning for some arbitrary feature: https://bitbucket.org/hudson/magic-lantern/changeset/cce4e41fc6a5

scrax

  • Contributor
  • Hero Member
  • *****
  • Posts: 1543
  • Code monkey
Re: Warnings for bad settings
« Reply #3 on: January 22, 2013, 04:44:14 PM »
what about this?
Code: [Select]
static void warn_step()
 {
     warn_code = 0;
-    if (warn_mode == 1 && shooting_mode != SHOOTMODE_P)
+    if (warn_mode == 1 && shooting_mode != SHOOTMODE_P && !is_movie_mode())
         warn_code |= 1;
 
-    if (warn_mode == 2 && shooting_mode != SHOOTMODE_TV)
+    if (warn_mode == 2 && shooting_mode != SHOOTMODE_TV && !is_movie_mode())
         warn_code |= 1;
 
-    if (warn_mode == 3 && shooting_mode != SHOOTMODE_AV)
+    if (warn_mode == 3 && shooting_mode != SHOOTMODE_AV && !is_movie_mode())
         warn_code |= 1;
 
-    if (warn_mode == 4 && shooting_mode != SHOOTMODE_M)
+    if (warn_mode == 4 && shooting_mode != SHOOTMODE_M && !is_movie_mode())
         warn_code |= 1;

when in movie mode is clear we are not in a photo mode and the warning is annoying, not?
I'm using ML2.3 for photography with:
EOS 600DML | EOS 400Dplus | EOS 5D MLbeta5- EF 100mm f/2.8 USM Macro  - EF-S 17-85mm f4-5.6 IS USM - EF 70-200mm f/4 L USM - 580EXII - OsX, PS, LR, RawTherapee, LightZone -no video experience-

a1ex

  • Administrator
  • Hero Member
  • *****
  • Posts: 12564
Re: Warnings for bad settings
« Reply #4 on: January 22, 2013, 05:14:15 PM »
Correct, I've written this feature with 5D-like cameras in mind (where movie mode is a separate switch, so you can film in M, P, Tv, Av etc).

This would need an ifdef in internals.h to know which cameras have a separate movie mode and which not.