Author Topic: [MERGED]Menu scrolling and vertical scroll bar!!!  (Read 16349 times)

nanomad

  • Administrator
  • Hero Member
  • *****
  • Posts: 2918
  • All your websites are belong to us
Re: [ACCEPTED]Menu scrolling and vertical scroll bar!!!
« Reply #25 on: September 20, 2012, 08:57:03 AM »
That, and I would have loved to have separate pull requests for audio and menus. But a1ex just accepted the full pull request it so....
Thanks miyake :P
EOS 1100D | EOS 650 (No, I didn't forget the D) | Ye Olde Canon EF Lenses ('87): 50 f/1.8 - 28 f/2.8 - 70-210 f/4 | EF-S 18-55 f/3.5-5.6 | Metz 36 AF-5

Marsu42

  • Contributor
  • Hero Member
  • *****
  • Posts: 1557
  • 66d + flashes
Re: [ACCEPTED]Menu scrolling and vertical scroll bar!!!
« Reply #26 on: September 20, 2012, 11:12:35 AM »
That, and I would have loved to have separate pull requests for audio and menus. But a1ex just accepted the full pull request it so....

Doesn't work on 60d (should it? anything else required except replacing autoexec.bin?), ml menu simply refuses to show :-\

a1ex

  • Administrator
  • Hero Member
  • *****
  • Posts: 12461
Re: [MERGED]Menu scrolling and vertical scroll bar!!!
« Reply #27 on: September 20, 2012, 11:14:00 AM »
Works on my 60D, including scroll.

Marsu42

  • Contributor
  • Hero Member
  • *****
  • Posts: 1557
  • 66d + flashes
Re: [MERGED]Menu scrolling and vertical scroll bar!!!
« Reply #28 on: September 20, 2012, 11:20:35 AM »
Works on my 60D, including scroll.

After the last "-O3 fix", it now also works again if compiled w/ Linaro 4.7 :-)

miyake

  • Developer
  • Senior
  • *****
  • Posts: 396
Re: [MERGED]Menu scrolling and vertical scroll bar!!!
« Reply #29 on: September 20, 2012, 11:26:47 AM »
Current menu has no overflow menu items. If you add new menu item and it's will be overflow from display size, You can see vscroll.

miyake

  • Developer
  • Senior
  • *****
  • Posts: 396
Re: [ACCEPTED]Menu scrolling and vertical scroll bar!!!
« Reply #30 on: September 20, 2012, 11:30:17 AM »
That, and I would have loved to have separate pull requests for audio and menus. But a1ex just accepted the full pull request it so....
Thanks miyake :P

I made a separate pull request. First I make a scroll menu pull request and then I confirmed pulled.
After that, I make a audio pull request.

Or Do you think that make a your own patch and push it? It's not good , because commit log will be lost.

nanomad

  • Administrator
  • Hero Member
  • *****
  • Posts: 2918
  • All your websites are belong to us
Re: [MERGED]Menu scrolling and vertical scroll bar!!!
« Reply #31 on: September 20, 2012, 01:22:11 PM »
No, yesterday I was so tired I didn't notice that :(
My bad
EOS 1100D | EOS 650 (No, I didn't forget the D) | Ye Olde Canon EF Lenses ('87): 50 f/1.8 - 28 f/2.8 - 70-210 f/4 | EF-S 18-55 f/3.5-5.6 | Metz 36 AF-5

a1ex

  • Administrator
  • Hero Member
  • *****
  • Posts: 12461
Re: [MERGED]Menu scrolling and vertical scroll bar!!!
« Reply #32 on: September 22, 2012, 09:15:46 PM »
Bug report: in Overlay menu (11 items) and Focus menu (9 items), pressing UP on first menu entry causes it to disappear. No scrolling is needed, no scrollbars appear (that part is OK).

miyake

  • Developer
  • Senior
  • *****
  • Posts: 396
Re: [MERGED]Menu scrolling and vertical scroll bar!!!
« Reply #33 on: September 23, 2012, 06:50:07 AM »
I thought it has no problem to use it. So I didn't add exception for simple implementation.
But you feel uneasy, I will solve it.
Give me a few time for solving it. More consider for beautiful code design. 

jplxpto

  • Developer
  • Hero Member
  • *****
  • Posts: 506
Re: [MERGED]Menu scrolling and vertical scroll bar!!!
« Reply #34 on: September 23, 2012, 06:07:20 PM »
Congratulations, you did a fantastic job. This functionality can be very useful for the project.

miyake

  • Developer
  • Senior
  • *****
  • Posts: 396
Re: [MERGED]Menu scrolling and vertical scroll bar!!!
« Reply #35 on: September 23, 2012, 06:34:47 PM »
All problem was gone, and made a pull request.
Now need to consider that take out from submenu for fast operations.
I'm changed 600D audio gain/boost from submenu. We don't need to open/close submenu when we change 600D audio volumes!!

a1ex

  • Administrator
  • Hero Member
  • *****
  • Posts: 12461
Re: [MERGED]Menu scrolling and vertical scroll bar!!!
« Reply #36 on: September 24, 2012, 03:06:02 PM »
Works great here.

nanomad

  • Administrator
  • Hero Member
  • *****
  • Posts: 2918
  • All your websites are belong to us
Re: [MERGED]Menu scrolling and vertical scroll bar!!!
« Reply #37 on: September 25, 2012, 02:33:21 PM »
Same on the mighty 1100D  ;)
EOS 1100D | EOS 650 (No, I didn't forget the D) | Ye Olde Canon EF Lenses ('87): 50 f/1.8 - 28 f/2.8 - 70-210 f/4 | EF-S 18-55 f/3.5-5.6 | Metz 36 AF-5