Magic Lantern 2025: Midsummer Edition

Started by names_are_hard, June 21, 2025, 12:57:15 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

names_are_hard

Quote from: reddeercityI'm not a fan of the current status of the builds , in the pursuit of making thing better on D5
cams the D4/5D2,50D suffer performance and functions'/features e.g. Dual ISO Video (not dual ISO photos)
that's been a working feature since Aug.2020 & of cousre Crop_rec 4k 3x1, 3x3 48fps (1880x776) 3k crop_rec(my work here)

Are these in branches on old official heptapod?  If so, please let me know which ones, so I can look at the code and see how hard it might be to integrate.  Or if a different location, where is that?  Thanks.

I can see in dual_iso module code that 50D and 5D2 have PHOTO_CMOS_ISO_START but no FRAME_CMOS_ISO_START - is this what you mean?

No attempt was made to make things better on D5 cams.  Almost all effort was making D6, D7, D8 and DX cams practical to add to the existing code.  Obviously this was quite a lot of work.  Now we have one place where code for all cameras can live.  I welcome attempts to improve any cameras.  We want to do this without making any cameras worse.  And I want to keep everything in one branch.  That's healthier in the long term - people can easily find the right build: there's only one build!



reddeercity

Quote from: names_are_hard on June 27, 2025, 05:26:13 PMAre these in branches on old official heptapod?  If so, please let me know which ones, so I can look at the code and see how hard it might be to integrate.  Or if a different location, where is that?  Thanks.

I can see in dual_iso module code that 50D and 5D2 have PHOTO_CMOS_ISO_START but no FRAME_CMOS_ISO_START - is this what you mean?
5D2 Dual Video ISO from @waza57
https://foss.heptapod.net/magic-lantern/magic-lantern/-/commit/9106918516977007f25f0a936a5a30d91d443062

below code is part of video dual iso 5d2 from line 751
  ..........

        is_5d2 = 1;                                                                   /*waza57:* For 5D2 distance = 0 , only one register in which doing changes */
      FRAME_CMOS_ISO_START = 0x404b4590; // CMOS register 0000 - for LiveView, ISO 100 (check in movie mode, not photo!)
        FRAME_CMOS_ISO_COUNT =          5; // from ISO 100 to 1600
        FRAME_CMOS_ISO_SIZE  =          0; // distance between ISO 100 and ISO 200 addresses, in bytes
     

Here you go Code from D4/5D2 dual ISO Video ,also here @waza57 Video-dual iso for 5d2 thread on the forum . I hope this can be merged to the main branch etc. ...

anandkamal

Looong time 5d3 ML user.. Absolutely glad you guys are back :) Thanks a lot so far and henceforth

names_are_hard

Quote from: reddeercityHere you go Code from D4/5D2 dual ISO Video ,also here

Thanks!  I only started working with ML in 2019, so I simply had no idea this code existed.  It doesn't look hard to merge.

Any idea why it didn't get merged before?  Any known difficulties?

elenhil

Will porting Bilal's Crop Mood features to other, more convoluted cameras (DPAF ones, like 70D) be easier now that the code is, I dunno, more unified?

names_are_hard

Nobody knows.  It shouldn't make it much harder or much easier, so the hardest part will still be: finding someone to do the work.

reddeercity

Quote from: names_are_hard on June 29, 2025, 11:14:35 PMAny idea why it didn't get merged before?

I think waza57 didn't know how do a pull request for a merge correctly I believe
 
Quote from: names_are_hard on June 29, 2025, 11:14:35 PMAny known difficulties?
Have to check my notes , but from memory I think if you have the IOS in too big
difference e.g. 100iso - 3200iso it could freeze liveview in a fast pan e.g. back & forth pans quickly
Like a jello pan , as long as you use only analog pure ISO (100,200,400,800,1600)but I wouldn't use 1600iso has the lo-light recovery if using 100iso as the Hi-light recovery the spread is too much could cause a liveview freeze . The optimum setting is 100iso - 400iso or 200iso - 800iso at lest though my test years ago. To keep any issue to a minimum and for better user experience keep iso spread small in my opinion ,

PaulHarwood856