Danne's crop_rec_4k experiments for EOS M

[cedricp]

I made some tweaks in the dualiso code, it fixes my filckering clips without baking and seems to not alter image (expo slope values remain very close to original code without large jumps between images). If you can try it and tell me if it's OK for you too...

[iaburn]

I made some tweaks in the dualiso code, it fixes my filckering clips without baking and seems to not alter image (expo slope values remain very close to original code without large jumps between images). If you can try it and tell me if it's OK for you too...

I have a couple of "flickering" clips from previous posts that seems to flicker still, maybe you can give it a try also:
https://mega.nz/file/JptAECbS#BXImCPVcmdXe6UXIXspeyZzNhy5kJWD1-aK39UyuJvU
https://mega.nz/file/pkkDkIDZ#e9aHgJtdIaYyiESYEbAXgoNifEO9QxIg85tmOgjXL0Y

[cedricp]

I spent some hours to try to find a better solution, but I failed
I removed some omp directive that caused wrong results and added more caching stuff, so that should be slightly faster to export.
The "baked" expo matching remains the best fix for that so far.

[iaburn]

I spent some hours to try to find a better solution, but I failed
I removed some omp directive that caused wrong results and added more caching stuff, so that should be slightly faster to export.
The "baked" expo matching remains the best fix for that so far.

The bake button is a good compromise for now. Can you make a pull request to my fork with your changes? I'll take a look at the omp directives that you had to remove, maybe I we can fix them 

[cedricp]

I found the ML's dual iso pdf doc on the internet that helped me to better understand the code and I finally got better results for the exposure ISO matching function. It should also be slightly faster.
For those interested the doc is here
I pushed the code on my gitub if you wanna try. It's not perfect, but it solves almost all the problematic shots.

[ML700D]

I found the ML's dual iso pdf doc on the internet that helped me to better understand the code and I finally got better results for the exposure ISO matching function. It should also be slightly faster.
For those interested the doc is here
I pushed the code on my gitub if you wanna try. It's not perfect, but it solves almost all the problematic shots.

nice finding.. I don't understand coding
I hope ML dual iso getting better next..

btw, is it for eos M user only?

[Danne]

I found the ML's dual iso pdf doc on the internet that helped me to better understand the code and I finally got better results for the exposure ISO matching function. It should also be slightly faster.
For those interested the doc is here
I pushed the code on my gitub if you wanna try. It's not perfect, but it solves almost all the problematic shots.

Nice work.
Are these the changes? Anything else modified?
https://github.com/cedricp/MLV-App/commit/0028db617a9efb9c5a5933c487e05d8c5547674c

Possible to fix original source code in here?
https://bitbucket.org/Dannephoto/magic-lantern_jip_hop_git/src/master/modules/dual_iso/dual_iso.c

[cedricp]

nice finding.. I don't understand coding
I hope ML dual iso getting better next..

btw, is it for eos M user only?

Thanks, no, it's a fix for dual iso blending, so for all cameras supporting dual ISO.

Nice work.
Are these the changes? Anything else modified?
https://github.com/cedricp/MLV-App/commit/0028db617a9efb9c5a5933c487e05d8c5547674c

Possible to fix original source code in here?
https://bitbucket.org/Dannephoto/magic-lantern_jip_hop_git/src/master/modules/dual_iso/dual_iso.c

Yes changes are there, and the code in the ML firmware is OK so far. The changes are for postprocess only.
It seems that fullres reconstruction works better too.

[Danne]

Yes changes are there, and the code in the ML firmware is OK so far. The changes are for postprocess only.

Yes of course, my mistake. I mean put in the code in here:
https://bitbucket.org/Dannephoto/magic-lantern_jip_hop_git/src/master/modules/dual_iso/cr2hdr.c

[cedricp]

Interestingly, cr2hdr has a different (maybe more robust) ISO matching function, trying it right now
Edit : That method is the best I tested ! No flickering at all and very good dynamic range staging.

[Danne]

Good. The code is the latest I believe, from a1ex. Would be great if this code is reviewed in whole and implemented in Mlv app .

[cedricp]

I did a quick review. I've adapted and updated my MLVapp repo with the updates from cr2hdr command line utility. The only missing feature is noise computation. Indeed a CR2 (digital still) file seems to contain some special rows/columns of black bars to measure noise, it does not exist in a video clip because of the crop I guess.
I'll do a more accurate analysis of the a1ex code to check if all is up2date.

[Danne]

This is so good!