Danne's crop_rec_4k experiments for EOS M

[masc]

@alpicat: thanks... I must have been drunken. The focus pixel option was still enabled - this brought "the wrong focus pixels" into the frames instead of killing them. Corrected my post, my upload and the picture. Only the white dots are visible now.

@Danne, bouncyball and dfort: will it be possible to recognize if we have a standard mv1080p MLV or an mv1080p-rewire MLV? These two formats look identical but need different focus pixels maps.

[alpicat]

@masc brilliant, glad to hear it worked. I thought I was going crazy when I was seeing those extra focus pixels - it didn't make any sense!
To make the focus pixels really show up, I load the png exported from mlvapp into photoshop and adjust saturation and several other settings, and then they become really distinct.

[Danne]

New build:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg208959#msg208959

- Advised to download this version and replace with whatever you use now
- Fix for extreme moiré when recording with mcm rewired preset(forgetting canon menu button for instance)

So no need for menu pushes for the rewired mode. Major finding from Levas:
https://www.magiclantern.fm/forum/index.php?topic=16516.msg212472#msg212472

[masc]

Findings:
- as long as I use MCM rewire normal -> great!
- after switching camera on, it looks like I am in a zoom mode, but I am not (I haven't chosen). Resolution is 1800x1012. 2x canon menu button, all is fine.
- if I use it with x3 option -> need again canon menu enter/leave; resolution is 1624x914, not 1736x976.
- going back to non x3 (normal zoom) again -> needs again canon menu

[Danne]

Thanks for feedback. Needed.
Try running the cinema script as a starting point. I think you´re resolution needs expanded to max, that´s why you get 1624x914. Or if not maybe a menu push is all it takes. The only thing that actually was fixed was the extreme moiré issue. That should not appear anymore. We still need canon menu push for when changing presets in MCM mode.

The resolution are as follows atm:
mv1080p MCM rewire
default 1736x1158 in x3crop 1624x1080
2.35:1 1736x738 in x3crop 1800x766
16:9    1736x976 in x3crop 1800x1012

[masc]

Hu... okay. I had no sub menu option chosen (all off). Resolution in RAW Video menu is at 5xxx option.

[Danne]

Hard to know exactly what to look for. If presets works after a few pushes I think all is as expected. Or else try to explain what to reproduce exactly.

[masc]

I think I know what happens:
- I used in RAW Video 5xxx resolution and 16:9.
-> in x3 crop this makes 1624x914 -> I should set it in RAW Video to 3:2 and set 16:9 from crop menu
- somehow it seems the standard is x3 zoom mode. So it was always hard to come out there to get normal mode...

[Danne]

I should recommend run the cinema lua script as starting point. It sets to 1:2 in RAW menu and you also end up in anamorphic mode. Then I would leave RAW video alone and only use settings in Crop mode sub menu and start build from there. It´s part of the round trip journey.

- somehow it seems the standard is x3 zoom mode. So it was always hard to come out there to get normal mode...

Can´t really follow you. But yes, rewire MC mode is a totally different beast from the other crop_rec presets. Getting back to the other presets is a bit harder than usual.
If I knew more c-code I would put it in either as a menu option in Movie crop mode or have it as default when starting up my eosm and selecting RAW video.

[Jonit]

@masc just to check, when you're exporting the video (or png file) from MLVapp, are you disabling "Fix focus dots"? If you leave that setting on, as it is by default, I find that additional focus pixels which are really difficult to see show up, and they're not there if turned the setting is turned off.

Thanks for pointing that out. Yes, you're right. It was "Fix focus dots" which was causing those pixels.

[dfort]

Maybe this will clear up some of the confusion over what is happening with the focus pixels on these new resolutions:

https://www.magiclantern.fm/forum/index.php?topic=16054.msg212529#msg212529

Then again maybe it just adds to the confusion.

[masc]

Great work @dfort! That works so good also in MLVApp. Now MCM rewire looks really nice for me (and hopefully many others).

[Danne]

Cool. So Mlv app updated for mcm mode now?

[masc]

Not directly. Download 80000331_1872x1190.fpm from dfort's repos and copy it next to executable (.exe on Win, on OSX executable inside app package). MLVApp will recognize this file and use it.

[Jonit]

Outstanding work dfort! I have such a deep appreciation for this community. You guys are doing great job here.

[Danne]

Nice masc. I wonder if we can add one pixel map for both x3zoom and mcm rewired in the same context that would work with both setups.

[masc]

I don't know why, but the focus pixel map from dfort only works for full (uncropped) MCM rewire clips. So 3:2 works, but e.g. 16:9 doesn't. It looks like there is an wrong offset somewhere (when pixel peeping). Until now I thought, if you have the map for maximal resolution of a preset, it works also for cropped clips. (not zoomed)

[Danne]

Is this working with 16:9 and 2.35:1 when it comes to focus pixels in Mlv App?
https://bitbucket.org/Dannephoto/magic-lantern/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Feb25.EOSM202.zip

[Danne]

Just tested my change and it worked when changing reg 6804 to the same as for the 3:2 preset:
0x4a601e4
So if we now the 0x4a601e4 is working then we can work from this one aand calculate any new offset from that when following the rest of the presets? There are also this for x3zoom in my crop_rec.c:
0x45601e4

For 16:9 and 2.35:1 I have this:
0x42401e4 but will change to working 0x4a601e4

0x4a601e4 = 1736x1190
0x45601e4 = 1736x1110


Maybe should have a talk with the "dotman" dfort...

Edit: 0x45601e4 seems to work with x3zoom...

[masc]

Did a quick test without any crop submenu setting and with 16:9. Both was working with the focus pixel map. Yay.

Edit: 2.35:1 at 3x3 working too. At x3 zoom, it is working for 1800x1012 (in two of three clips, must test where the difference is, maybe just forgot the menu buttons), for 1800x766 too, but not for 1624x1080.

[Danne]

...but not for 1624x1080.

I do some trickery to differ this mode to get around some of a1ex black level autodetection code in raw.c. I knew it would bite me sooner or later. I´ll see if I can do something else here(c-noob):

Code Select Expand

          case 0xC0F06804: return 0x45601e5);

    /* needed for autodetecting black level in mlv_lite.c */
        case 0xc0f06800: return 0x10011;


EDIT:
Ok, let´s try this one. Should work better:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Feb25.EOSM202.zip

[masc]

Ok, let´s try this one. Should work better:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Feb25.EOSM202.zip

Hmm... really? This build is able to toggle my LED. Camera not booting. 

[Danne]

Happens to me sometimes. Check an extra round if you extracted all ml files onto your card. Or do a battery pull 

[masc]

All done. Downloaded, installed, battery pulled... all 2x. 

[Danne]

Strange. I just downloaded and ran it on my camera. Hm, older build working? Cam starting without ML on it?