Author Topic: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]  (Read 1339851 times)

Danne

  • Developer
  • Hero Member
  • *****
  • Posts: 7739
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1250 on: May 09, 2018, 09:50:50 AM »

50mm1200s

  • Member
  • ***
  • Posts: 177
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1251 on: May 09, 2018, 10:27:01 AM »
Other temps are quite off.

Any clue on why? What is necessary to bring it to mainline?

Danne

  • Developer
  • Hero Member
  • *****
  • Posts: 7739
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1252 on: May 09, 2018, 11:11:37 AM »
Curious too what parameters manipulates color.
Could dcraw sources be of any help?

Also this:
https://www.magiclantern.fm/forum/index.php?topic=15897.msg154451#msg154451

bouncyball

  • Contributor
  • Hero Member
  • *****
  • Posts: 850
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1253 on: May 09, 2018, 04:18:38 PM »
Any clue on why? What is necessary to bring it to mainline?
If I had any clue, I would fix it :P

It is Ilia's territory ;)

ilia3101

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1004
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1254 on: May 09, 2018, 04:24:10 PM »
The WB branch seems stuck, right? Ilia even commited the Andy600 suggestion, but backed off...
An incorrect interpreatation of what andy said. That's why I "backed off". Then I noticed some other flaws.

All I need for whitebalance branch is a good multiplier generator, maybe that I can take from DCRaw. That is why the temps are "Off".

@Danne a compiler tool would be great if you did that, I get really bored during the procedure with unzipping ffmpeg, configuring project in Qt creator etc...

bouncyball

  • Contributor
  • Hero Member
  • *****
  • Posts: 850
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1255 on: May 09, 2018, 06:15:16 PM »
@Ilia3101

All I need for whitebalance branch is a good multiplier generator, maybe that I can take from DCRaw. That is why the temps are "Off".
Do you remember I've been experimenting with well known and widely used (cr2hdr, mlvfs) ufraw multiplier functions? We could try to adapt it to WhiteBalance branch. Or maybe you already took a look at it and decided that this code is not useful in this situation?

Danne

  • Developer
  • Hero Member
  • *****
  • Posts: 7739
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1256 on: May 09, 2018, 06:23:49 PM »
@Bouncyball
That would be a great achievement.
@Ilia*
Gonna look into a simplifying compiling tool. Might take a while, pretty busy atm...

jpegmasterjesse

  • Member
  • ***
  • Posts: 100
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1257 on: May 09, 2018, 08:30:20 PM »
Code: [Select]
(xenial)jessepeej@localhost:~/MLV-App/MLV-App-master/platform/qt$ qmake
(xenial)jessepeej@localhost:~/MLV-App/MLV-App-master/platform/qt$ make
/usr/lib/x86_64-linux-gnu/qt5/bin/uic MainWindow.ui -o ui_MainWindow.h
/usr/lib/x86_64-linux-gnu/qt5/bin/uic InfoDialog.ui -o ui_InfoDialog.h
/usr/lib/x86_64-linux-gnu/qt5/bin/uic StatusDialog.ui -o ui_StatusDialog.h
/usr/lib/x86_64-linux-gnu/qt5/bin/uic ExportSettingsDialog.ui -o ui_ExportSettingsDialog.h
/usr/lib/x86_64-linux-gnu/qt5/bin/uic EditSliderValueDialog.ui -o ui_EditSliderValueDialog.h
/usr/lib/x86_64-linux-gnu/qt5/bin/uic Updater/updaterUI/cupdaterdialog.ui -o ui_cupdaterdialog.h
g++ -c -m64 -pipe -O2 -Wall -W -D_REENTRANT -fPIC -DQT_DEPRECATED_WARNINGS -DSTDOUT_SILENT -DQT_NO_DEBUG -DQT_MULTIMEDIA_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtMultimedia -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -I. -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -o main.o main.cpp
In file included from Updater/updaterUI/CUpdater.h:11:0,
                 from MainWindow.h:38,
                 from main.cpp:8:
Updater/updaterUI/../cautoupdatergithub.h:52:2: warning: identifier 'nullptr' is a keyword in C++11 [-Wc++0x-compat]
  UpdateStatusListener* _listener = nullptr;
  ^
In file included from Updater/updaterUI/CUpdater.h:11:0,
                 from MainWindow.h:38,
                 from main.cpp:8:
Updater/updaterUI/../cautoupdatergithub.h:33:20: error: 'function' in namespace 'std' does not name a template type
         const std::function<bool (const QString&, const QString&)>& versionStri
                    ^
Updater/updaterUI/../cautoupdatergithub.h:33:28: error: expected ',' or '...' before '<' token
         const std::function<bool (const QString&, const QString&)>& versionStri
                            ^
In file included from Updater/updaterUI/CUpdater.h:11:0,
                 from MainWindow.h:38,
                 from main.cpp:8:
Updater/updaterUI/../cautoupdatergithub.h:35:67: warning: defaulted and deleted functions only available with -std=c++11 or -std=gnu++11
  CAutoUpdaterGithub& operator=(const CAutoUpdaterGithub& other) = delete;
                                                                   ^
Updater/updaterUI/../cautoupdatergithub.h:50:13: error: 'function' in namespace 'std' does not name a template type
  const std::function<bool (const QString&, const QString&)> _lessThanVersionStr
             ^
Updater/updaterUI/../cautoupdatergithub.h:52:36: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
  UpdateStatusListener* _listener = nullptr;
                                    ^
Updater/updaterUI/../cautoupdatergithub.h:52:36: error: 'nullptr' was not declared in this scope
In file included from MainWindow.h:38:0,
                 from main.cpp:8:
Updater/updaterUI/CUpdater.h:28:67: warning: override controls (override/final) only available with -std=c++11 or -std=gnu++11
     void onUpdateAvailable(CAutoUpdaterGithub::ChangeLog changelog) override;
                                                                   ^
Updater/updaterUI/CUpdater.h:29:61: warning: override controls (override/final) only available with -std=c++11 or -std=gnu++11
     void onUpdateDownloadProgress(float percentageDownloaded) override {Q_UNUSE
                                                             ^
Updater/updaterUI/CUpdater.h:30:35: warning: override controls (override/final) only available with -std=c++11 or -std=gnu++11
     void onUpdateDownloadFinished() override {};
                                   ^
Updater/updaterUI/CUpdater.h:31:44: warning: override controls (override/final) only available with -std=c++11 or -std=gnu++11
     void onUpdateError(QString errorMessage) override {Q_UNUSED(errorMessage);}
                                            ^
Makefile:849: recipe for target 'main.o' failed
make: *** [main.o] Error 1


Anyone have a guess what I did wrong?   :o

50mm1200s

  • Member
  • ***
  • Posts: 177
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1258 on: May 09, 2018, 10:05:40 PM »
I think you have to use -std=c++11 on g++ options... at least that's what the error log is saying.

jpegmasterjesse

  • Member
  • ***
  • Posts: 100
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1259 on: May 09, 2018, 10:16:55 PM »
I think you have to use -std=c++11 on g++ options... at least that's what the error log is saying.

Thanks! Way out of my depth here - g++ is a different compiler method than qmake, right? Or should I just add some specifications to the qmake or make commands?


50mm1200s

  • Member
  • ***
  • Posts: 177
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1260 on: May 09, 2018, 11:54:13 PM »
Well, from what I know, g++ is a compiler, qmake is a makefile. The makefile links all the libraries and other code of the project and then sends to the compiler itself. The compiler will then... compile (transform to binary code). Inside the makefile you should add the compiler options, such as optimizations (-Ox in GCC, where "x" is a number from 1 to 3 or "s"), also archtechture specific parametters (x86, ARM, etc), and other stuff I really don't know.
Are you using some linux distro or Mac? Cygwin is very boring to deal with. If you're on Windows I'd suggest you see Chocolatey, a package manager that can install automatically many tools. On Mac, see Homebrew...

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 2125
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1261 on: May 10, 2018, 05:40:46 AM »
@masc
Looks like this is executed every time even if another script is chosen:
In Scripting.cpp
Code: [Select]
    //enabling HDR processing, no questions asked. Yet.
    QProcess process;
    process.startDetached("/bin/bash", QStringList()<< "HDR_MOV.command");
Could "HDR_MOV.command" be turned into a variable?

Regards this issue:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg201009#msg201009
Hi Danne. Sry I did not answer. I am in holiday and woll have a look when I am back.
5D3.113 | EOSM.202

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 2125
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1262 on: May 10, 2018, 05:42:32 AM »
@Danne a compiler tool would be great if you did that, I get really bored during the procedure with unzipping ffmpeg, configuring project in Qt creator etc...
Why do you not use svn? You'll just have to do this once in your life... For OSX svnX works great.
5D3.113 | EOSM.202

Danne

  • Developer
  • Hero Member
  • *****
  • Posts: 7739
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1263 on: May 10, 2018, 08:57:34 AM »
Hi Danne. Sry I did not answer. I am in holiday and woll have a look when I am back.
Cool, have a great vacation :)

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 563
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1264 on: May 10, 2018, 07:12:07 PM »
@jpegmasterjesse

Bouncyball directed you to my guide:
German: https://sternenkarten.com/fotos/ml/
English: https://sternenkarten.com/tutorial-englisch/
I wrote this guide for openSUSE.

I guess, you have ubuntu 16.04?

Since I change my astronomy-laptop from Windows (Ascom-drivers) to Linux (indi-drivers) atm, I just installed kubuntu 18.04. I tried to compile mlvapp with kubuntu for a quick test. I had some quirks, but finally, I succeeded. I will add this ubuntu-stuff to my guide this weekend.

Maybe, this can help you.
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

IDA_ML

  • Hero Member
  • *****
  • Posts: 1014
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1265 on: May 11, 2018, 04:29:08 PM »
Hello Bouncyball,

I was wondering if the following script by Danne:

https://www.magiclantern.fm/forum/index.php?topic=22076.msg201287;topicseen#msg201287

could be implemented in the next Windows version of MLVApp.  This would greatly suppress moire in cameras like the 7D, 6D and all the Rebels recording video at 1728x972 resolution with line skipping.  Now that some of these cameras can record up to 42 fps due to overclocking, this script would be extremely useful for reducing moire and further raising video quality in critical high-contrast situations. 

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 563
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1266 on: May 11, 2018, 08:06:56 PM »
Linux-openSUSE

I played a bit with mlvapp for creating a desktop-file with a nice icon. I found a raw desktop-file in $HOME/MLV-App/MLV-App-master/platform/qt. But this desktop-file needs "*.png *.xpm *.svg *.svgz|Symbol-Dateien" as icons. I only found "MLVAPP.ico", which is not accepted. Not the biggest problem. I opend MLVAPP.ico with GIMP and exported it as png.

The second thing is the path to mlvapp. In the desktop-file, the path is mlvapp. That is fine, but only, if mlvapp is in a directory, which is described in the $PATH env-var. But mlvapp is located in (in my case) $HOME/MLV-App/MLV-App-master/platform/qt. For to run mlvapp by only clicking the desktop-file, the complete path to mlv-app is needed in the desktop-file. I changed this and have now a nice little start-symbol for mlvapp on my desktop:

https://seescho.files.wordpress.com/2018/05/mlvapp-desktop.jpg
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

bouncyball

  • Contributor
  • Hero Member
  • *****
  • Posts: 850
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1267 on: May 12, 2018, 11:44:54 AM »
@IDA_ML
I was wondering if the following script by Danne could be implemented in the next Windows version of MLVApp.
Despite Danne's scripts are written in bash, unfortunately, they are made very specific to mac os, hence they even do not work under Linux out of the box (without a quite rewriting). Not to mention Windows where bash could be kinda installed but with lot's of hoop jumping. Also there is linux for windows susbsystem under win10pro but it also not quite seamlessly integrated into the Windows. In short Danne is the only one who can help you if he has enough time ;)

@escho

In Ubuntu long time ago I just made shortcut of MLV App with just simple mouse drug and drop on to my desktop and also have very nice icon there. However I like running MLV App from command line in console because of some debug messages I need during development.

Danne

  • Developer
  • Hero Member
  • *****
  • Posts: 7739
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1268 on: May 12, 2018, 01:52:59 PM »
For linux new application paths(three I guess) and then mlv_apps paths folder assigned to maybe home folder and then maybe it'll work.
For windows a little more work but a basic single processing for loop should get things going.
Not enough time atm but who knows about the future...

ilia3101

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1004
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1269 on: May 12, 2018, 04:04:41 PM »
I only found "MLVAPP.ico", which is not accepted.

src/icon - there you will find icon.png and icon.blend (it's open source)


Just remembered a thing... was anyone using Cocoa app on April the 1st?

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 2125
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1270 on: May 12, 2018, 05:12:18 PM »
Linux-openSUSE

I played a bit with mlvapp for creating a desktop-file with a nice icon. I found a raw desktop-file in $HOME/MLV-App/MLV-App-master/platform/qt. But this desktop-file needs "*.png *.xpm *.svg *.svgz|Symbol-Dateien" as icons. I only found "MLVAPP.ico", which is not accepted. Not the biggest problem. I opend MLVAPP.ico with GIMP and exported it as png.

The second thing is the path to mlvapp. In the desktop-file, the path is mlvapp. That is fine, but only, if mlvapp is in a directory, which is described in the $PATH env-var. But mlvapp is located in (in my case) $HOME/MLV-App/MLV-App-master/platform/qt. For to run mlvapp by only clicking the desktop-file, the complete path to mlv-app is needed in the desktop-file. I changed this and have now a nice little start-symbol for mlvapp on my desktop:

https://seescho.files.wordpress.com/2018/05/mlvapp-desktop.jpg

Hej escho, see MLV_App/platform/qt/RetinaIMG/MLVAPP.png as icon. Have you seen the thread on github about how to do a appimage? There were a lot of hints from someone, but I can't help much...
https://github.com/ilia3101/MLV-App/issues/17
5D3.113 | EOSM.202

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 2125
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1271 on: May 12, 2018, 05:19:49 PM »
@masc
Looks like this is executed every time even if another script is chosen:
In Scripting.cpp
Code: [Select]
    //enabling HDR processing, no questions asked. Yet.
    QProcess process;
    process.startDetached("/bin/bash", QStringList()<< "HDR_MOV.command");
Could "HDR_MOV.command" be turned into a variable?

Regards this issue:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg201009#msg201009

Danne, could you please have try?! Greats from my holiday! ;)
(I did not test but commit something...)
5D3.113 | EOSM.202

Danne

  • Developer
  • Hero Member
  • *****
  • Posts: 7739
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1272 on: May 12, 2018, 05:26:30 PM »
Cool @masc. Gonna check this asap(couple of hours)

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 563
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1273 on: May 12, 2018, 09:01:43 PM »
@bouncyball


@escho

In Ubuntu long time ago I just made shortcut of MLV App with just simple mouse drug and drop on to my desktop and also have very nice icon there.

Unfortunatly, this doesn´t work in openSUSE and kubuntu 18.04 (atm?). I can start mlvapp from the desktop, but I have no MLVAPP-icon.


@Ilia3101
@masc

src/icon - there you will find icon.png

Hej escho, see MLV_App/platform/qt/RetinaIMG/MLVAPP.png as icon.

Thanks for the paths. Didn´t see them...


@masc

Have you seen the thread on github about how to do a appimage? There were a lot of hints from someone, but I can't help much...
https://github.com/ilia3101/MLV-App/issues/17

I saw it, the part of the Howto. But i didn´t read the part with the appimage.

I´m sorry, but I cannot help with an appimage. That´s beyond my skills. But maybe, I can help a bit with the linux-desktop-file, you know, this one, you wanted to copy to /usr/share/applications. More tomorrrow... :)
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

Danne

  • Developer
  • Hero Member
  • *****
  • Posts: 7739
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #1274 on: May 12, 2018, 10:44:56 PM »
@masc
your fix works perfectly. I can now choose between scripts :). Awesome! Will push a script soon...