Author Topic: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]  (Read 1089032 times)

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 563
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #475 on: October 03, 2017, 05:37:25 PM »
Does this MLV pass through other programs? mlv_dump, mlvfs?
I´m a bit busy at the moment, so sorry for only a short answer:
No problems with mlv_dump. All frames are decoded to dng, no frame is corrupted.
I will do some screenshots later this evening, maybe tomorrow.
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

hjfilmspeed

  • Senior
  • ****
  • Posts: 479
  • 5D III and IV
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #476 on: October 04, 2017, 05:00:26 AM »
Not sure If this has been addressed. Just really excited to use this. I get a crash every time on import of 14bit lossless 1920 x 1080 23.976 clip.  Sorry for the terrible report but this app looks so good. I haven't had enough time to review this part of the forum but I will delete if this has been addressed. I'm on a On a windows 7 x64 Machine here is the windows error report:
Problem signature:
  Problem Event Name:   APPCRASH
  Application Name:   mlvapp.exe
  Application Version:   0.0.0.0
  Application Timestamp:   59c7c736
  Fault Module Name:   mlvapp.exe
  Fault Module Version:   0.0.0.0
  Fault Module Timestamp:   59c7c736
  Exception Code:   c000001d
  Exception Offset:   0000000000017fc6
  OS Version:   6.1.7601.2.1.0.256.1
  Locale ID:   1033
  Additional Information 1:   907b
  Additional Information 2:   907bc937f1d4b6de41bbc9e5a303a085
  Additional Information 3:   a276
  Additional Information 4:   a27670abb9f65021d2cba031d8026e8f

Read our privacy statement online:
  http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0409

If the online privacy statement is not available, please read our privacy statement offline:
  C:\Windows\system32\en-US\erofflps.txt

bouncyball

  • Contributor
  • Hero Member
  • *****
  • Posts: 849
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #477 on: October 04, 2017, 09:46:13 AM »
Well this error dump gives no hint at all to anybody ( as usual, thanks MS ;) ).

DeafEyeJedi

  • Hero Member
  • *****
  • Posts: 3411
  • 5D3 | M1 | 7D | 70D | SL1 | M2 | 50D
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #478 on: October 05, 2017, 07:39:55 PM »
Quick question -- upon compiling and making app is it normal for me to receive all these warnings?

Look on the bottom of this code.

Code: [Select]
Seans-Mini-385:~ DeafEyeJedi$ cd MLV-App/platform/cocoa
Seans-Mini-385:cocoa DeafEyeJedi$ make app
rm "MLV App".app; \
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 generate_info_plist.c -o generate_info_plist; \
./generate_info_plist "MLV App"; \
make main; \
rm -rf "MLV App".app; \
mkdir "MLV App".app; \
mkdir "MLV App".app/Contents; \
mkdir "MLV App".app/Contents/MacOS; \
mkdir "MLV App".app/Contents/Resources; \
cp -i "MLV App" "MLV App".app/Contents/MacOS/; \
cp -i info.plist "MLV App".app/Contents/; \
mkdir "MLV App".app/Contents/Resources/pixelmaps; \
cp -i ../../src/mlv/llrawproc/pixelmaps/*.fpm "MLV App".app/Contents/Resources/pixelmaps; \
unzip ../qt/FFmpeg/ffmpegOSX.zip -d "MLV App".app/Contents/Resources; \
rm -rf "MLV App".app/Contents/Resources/__MACOSX; \
cp ../../src/icon/icon.icns "MLV App".app/Contents/Resources/MLV\ App.icns; \
rm generate_info_plist; \
rm info.plist; \

rm: MLV App.app: No such file or directory
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 compile_time_code.m -o compile_time_code -framework Cocoa; \
./compile_time_code; \
rm main.o; \
make build; \
rm compile_time_code; \
rm app_defines.h
Initial app name: MLV App (Oct  5 2017 10:37:16 @Seans-Mini-385)
rm: main.o: No such file or directory
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c main.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/video_mlv.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -pthread ../../src/debayer/debayer.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/debayer/amaze_demosaic.c
In file included from ../../src/debayer/amaze_demosaic.c:36:
../../src/debayer/sleefsseavx.c:27:9: warning: 'M_PI' macro redefined
      [-Wmacro-redefined]
#define M_PI 3.14159265358979323846
        ^
/usr/include/math.h:703:9: note: previous definition is here
#define M_PI        3.14159265358979323846264338327950288   /* pi             */
        ^
In file included from ../../src/debayer/amaze_demosaic.c:36:
../../src/debayer/sleefsseavx.c:28:9: warning: 'M_1_PI' macro redefined
      [-Wmacro-redefined]
#define M_1_PI 0.31830988618379067154
        ^
/usr/include/math.h:706:9: note: previous definition is here
#define M_1_PI      0.318309886183790671537767526745028724  /* 1/pi           */
        ^
In file included from ../../src/debayer/amaze_demosaic.c:36:
../../src/debayer/sleefsseavx.c:29:9: warning: 'M_2_PI' macro redefined
      [-Wmacro-redefined]
#define M_2_PI 0.63661977236758134308
        ^
/usr/include/math.h:707:9: note: previous definition is here
#define M_2_PI      0.636619772367581343075535053490057448  /* 2/pi           */
        ^
3 warnings generated.
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/processing/raw_processing.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c main_methods.m
main_methods.m:265:63: warning: null passed to a callee that requires a non-null
      argument [-Wnonnull]
  ...[[App->rawBitmap representationUsingType: NSPNGFileType properties: nil...
                      ^                                                  ~~~
1 warning generated.
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c gui_stuff/useful_methods.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c background_thread.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/matrix/matrix.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/camera_matrices.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/frame_caching.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/liblj92/lj92.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c session_methods.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c delegate.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c mlv_view.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/llrawproc.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/pixelproc.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/stripes.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/patternnoise.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/hist.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/dualiso.c
../../src/mlv/llrawproc/dualiso.c:34:9: warning: 'M_PI' macro redefined
      [-Wmacro-redefined]
#define M_PI 3.14159265358979323846 /* pi */
        ^
/usr/include/math.h:703:9: note: previous definition is here
#define M_PI        3.14159265358979323846264338327950288   /* pi             */
        ^
1 warning generated.
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o llrawproc.o pixelproc.o stripes.o patternnoise.o hist.o dualiso.o -o "MLV App" -framework Cocoa;
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg 
Seans-Mini-385:cocoa DeafEyeJedi$

I have a feeling it's because my Mac Mini just became a virgin last week after accidentally typing in incorrectly to try and remove a directory as oppose to the entire drive. So excuse for my stupidity in here.  Forgot that I have to start everything again from scratch on this machine. :P
5D3.113 | 5D3.123 | EOSM.203 | 7D.203 | 70D.112 | 100D.101 | EOSM2.* | 50D.109

bouncyball

  • Contributor
  • Hero Member
  • *****
  • Posts: 849
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #479 on: October 05, 2017, 08:41:36 PM »
When I'm compiling QTApp I got 63 warnings :P (of course someday all these warnings should be addressed, but mostly they are not harmful)
As far as it compiles and runs I guess this is true for cocoa version too.

DeafEyeJedi

  • Hero Member
  • *****
  • Posts: 3411
  • 5D3 | M1 | 7D | 70D | SL1 | M2 | 50D
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #480 on: October 05, 2017, 08:50:08 PM »
When I'm compiling QTApp I got 63 warnings :P (of course someday all these warnings should be addressed, but mostly they are not harmful) I guess this is true for cocoa version too.

HeHe. Just checked the platform. Saw an MLV App build under Cocoa. Opened it. Wont let me batch import. One file works fine. Upon exporting I get error message after it crashed. I also got a prompt message from MLV App saying that 'export completed' but nothing showed up in destination folder.

Here's a log report in case they are any hints or clues...

https://mega.nz/#!7kEzSRQB!7dLqraZ8kOuBoX2AsUWqNDY98aliEWZgHqBak2Nx2cM
5D3.113 | 5D3.123 | EOSM.203 | 7D.203 | 70D.112 | 100D.101 | EOSM2.* | 50D.109

ilia3101

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 990
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #481 on: October 05, 2017, 11:06:16 PM »
Quote from: DeafEyeJedi
Quick question -- upon compiling and making app is it normal for me to receive all these warnings?
Only one used to be there, but the new ones are harmless as far as I can tell.

Quote from: DeafEyeJedi
Wont let me batch import.
Ah yes, batch import isn't done yet in Cocoa app, that's on the way. Though Cocoa app is probably gonna take a little while to catch up with Qt.

And sorry about the crash on ending of export. Also, I find that the non-exporting clip thing happens only in some directories :/

My current thing is getting cache working which I was going to commit yesterday, then today, but nothing got done today(zero), so gonna have to be tommorow.
@bouncyball we'll have to find a way of detecting LLRawProc changes to know when to re-cache, maybe we can add a flag?
Anyway, first I'll commit it to the cache branch then we sort that out.

bouncyball

  • Contributor
  • Hero Member
  • *****
  • Posts: 849
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #482 on: October 06, 2017, 08:11:54 AM »
@bouncyball we'll have to find a way of detecting LLRawProc changes to know when to re-cache, maybe we can add a flag?
Anyway, first I'll commit it to the cache branch then we sort that out.
OK, I think the simplest way will be to introduce some "is_changed" variable in the llrawproc struct which will be set to true when gui widget handlers get called and then reset to false by caching module.

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 563
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #483 on: October 06, 2017, 05:32:07 PM »

Quote
Quote from: escho on October 03, 2017, 10:17:28 AM

    Maybe you know, that I have problems, importing files bigger than 4 Gbyte. The app crashes. These files are way to big for uploading somewhere.

    So I startet QT Creator in debugging mode with a file with 7,6 GByte. With this file, MLV App always crashes in "frame_cashing.c" Is it possible to run MLV App without cashing for a test? What must I do to disable cashing?


That is strange. Caching is deactivated for the Qt App. In which line does it crash?

It crashes in line 61: https://seescho.files.wordpress.com/2017/10/screenshot_20171005_191349.jpg
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

DeafEyeJedi

  • Hero Member
  • *****
  • Posts: 3411
  • 5D3 | M1 | 7D | 70D | SL1 | M2 | 50D
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #484 on: October 06, 2017, 07:11:19 PM »
Any chance I can compile/make the QT version instead of the MLV App for me to try the latest Dual-ISO implementation?
5D3.113 | 5D3.123 | EOSM.203 | 7D.203 | 70D.112 | 100D.101 | EOSM2.* | 50D.109

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 2011
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #485 on: October 06, 2017, 07:34:14 PM »
It crashes in line 61: https://seescho.files.wordpress.com/2017/10/screenshot_20171005_191349.jpg
Thank you! I'll have a look at that! That information really helps!

Any chance I can compile/make  the QT version instead of the MLV App for me to try the latest Dual-ISO implementation?
Sure, if you like, download Qt (free version, I think 5.9.1 is the latest), install, and do what I wrote somewhere above. The most difficult part is to compile and install libpng and zlib on mac (done in terminal, without Qt). The libraries are also in the repos (zip files).

Edit: there are some bugs inside atm, that is (for me) the main reason why I don't like to build a next release for everybody. We are working on it.
5D3.113 | EOSM.202

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 2011
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #486 on: October 06, 2017, 07:52:55 PM »
It crashes in line 61: https://seescho.files.wordpress.com/2017/10/screenshot_20171005_191349.jpg

Hm, okay, this function is called from MainWindow, openMlv(). For a quick test you could comment this function out there. For the future this may not be the solution...

@Ilia: do you need this function still after your big cache update, or will it be changed? Maybe have a look on that...
5D3.113 | EOSM.202

DeafEyeJedi

  • Hero Member
  • *****
  • Posts: 3411
  • 5D3 | M1 | 7D | 70D | SL1 | M2 | 50D
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #487 on: October 06, 2017, 07:55:41 PM »
Edit: there are some bugs inside atm, that is (for me) the main reason why I don't like to build a next release for everybody. We are working on it.

No worries. Was just curious of the current state being. It's definitely getting closer as we all can feel it, right? Thanks! ;)
5D3.113 | 5D3.123 | EOSM.203 | 7D.203 | 70D.112 | 100D.101 | EOSM2.* | 50D.109

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 563
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #488 on: October 06, 2017, 09:27:58 PM »
Hm, okay, this function is called from MainWindow, openMlv(). For a quick test you could comment this function out there. For the future this may not be the solution...

I commented out line 461 in MainWindow.cpp. Now the app crashes in line 468 in MainWindow.cpp:  https://seescho.files.wordpress.com/2017/10/2.jpg

I did another test. I cut the 7,6 G-file using "mlv_dump -fxxxx":

1318frames.MLV run with no problems
1319frames.MLV let the app crash.

Here are the filesizes of the two MLVs:

Code: [Select]
edgar@localhost:~/test/frames> ls -l
insgesamt 8440240
-rw-r--r-- 1 edgar users 4319763492  6. Okt 20:57 1318frames.MLV
-rw-r--r-- 1 edgar users 4323038516  6. Okt 20:58 1319frames.MLV

I cannot locate, where the crash with 1319frames.MLV appears, since QT Creator tells me, it cannot find binary debug informations for this stack frame.
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 2011
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #489 on: October 08, 2017, 12:09:09 PM »
I commented out line 461 in MainWindow.cpp. Now the app crashes in line 468 in MainWindow.cpp:  https://seescho.files.wordpress.com/2017/10/2.jpg

I did another test. I cut the 7,6 G-file using "mlv_dump -fxxxx":

1318frames.MLV run with no problems
1319frames.MLV let the app crash.

Here are the filesizes of the two MLVs:

Code: [Select]
edgar@localhost:~/test/frames> ls -l
insgesamt 8440240
-rw-r--r-- 1 edgar users 4319763492  6. Okt 20:57 1318frames.MLV
-rw-r--r-- 1 edgar users 4323038516  6. Okt 20:58 1319frames.MLV

I cannot locate, where the crash with 1319frames.MLV appears, since QT Creator tells me, it cannot find binary debug informations for this stack frame.

Thx for your work! Unfortunately I can't test or debug that, because I can't create such a big file with my 5D2. But I created an issue on github for that problem and inserted your messages as quote.
5D3.113 | EOSM.202

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 563
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #490 on: October 08, 2017, 03:05:10 PM »
Thx for your work! Unfortunately I can't test or debug that, because I can't create such a big file with my 5D2. But I created an issue on github for that problem and inserted your messages as quote.

Thanks for opening an issue. You can find my answer in github :)
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

bouncyball

  • Contributor
  • Hero Member
  • *****
  • Posts: 849
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #491 on: October 11, 2017, 11:23:48 AM »
@escho

Can you confirm that under Linux audio is not working as expected in the latest github version?
Which distribution do you use?

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 563
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #492 on: October 12, 2017, 08:55:07 AM »
Can you confirm that under Linux audio is not working as expected in the latest github version?
Which distribution do you use?

Since I  use rawvideo only for my astromomical shootings ( https://seescho.wordpress.com/ ), I have no sound in the MLVs. I must wait for the weekend to record some clips with sound and will report.

I´m on openSUSE Leap42.3 or (for some reasons at tho moment) on the "near bleeding edge" openSUSE Thumbleweed.
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 563
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #493 on: October 16, 2017, 11:50:12 AM »
@masc
Importing a MLV. via menue
File - import mlv - irgendetwas.MLV:  leftclick
This imports the MLV immedeately whithout pressing the open button. Is this expected behavior?
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 2011
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #494 on: October 16, 2017, 12:06:03 PM »
@masc
Importing a MLV. via menue
File - import mlv - irgendetwas.MLV:  leftclick
This imports the MLV immedeately whithout pressing the open button. Is this expected behavior?

This should be operating system behaviour. For me, I have to select the file(s), doubleclick one file or press open. Qt can't change the behaviour of the systems open dialog. I must implement a own file dialog in order to change it.
5D3.113 | EOSM.202

escho

  • Contributor
  • Hero Member
  • *****
  • Posts: 563
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #495 on: October 16, 2017, 10:56:49 PM »
Thanks for the hint. I had a big fight in the last few hours with the big files doing funny things. So I will look later, how I can tune my OP.  ;)
https://sternenkarten.com/
600D, 6D, openSUSE Tumbleweed

ilia3101

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 990
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #496 on: October 21, 2017, 11:25:14 PM »
New Cocoa App release (v0.21)



Main news:
  • Bouncyball's RAW correction's (Focus pixel fix, vertical stripes, etc) are now implemented in GUI
  • Experimental xyY processing mode (xyY model separates colour from luma),
    currently enabling it helps remove coloured edges from sharpening,
    in next release chroma blur will also be implemented (to remove noise and moire)
  • Caching rewritten, should be better, and less crashier(eventually)

Working on getting session implemented too like the Qt App - still not there.

Not sure where to go next with this GUI :-\

Download

Note: I still recommend using Qt app for anything relatively serious, this is only for testing.

Danne

  • Developer
  • Hero Member
  • *****
  • Posts: 7395
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #497 on: October 21, 2017, 11:54:46 PM »
Looking good Ilia.
Is vertical stripes set to off as default?
I prefer raw2dng code pixel fix code set to default. Maybe the new workflow works better with mlvfs code nowadays.
I think crop_rec code could be automated since we have RAWC metadata.
How is dualiso working? On the fly prores making?

Lars Steenhoff

  • Senior
  • ****
  • Posts: 473
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #498 on: October 22, 2017, 12:08:52 AM »
It does look good indeed!

What part of your not sure where to go next with the gui?
I think its growing up very fast

masc

  • Contributor
  • Hero Member
  • *****
  • Posts: 2011
Re: Making a New MLV Processing App! [Windows, Mac and Linux]
« Reply #499 on: October 22, 2017, 11:12:05 AM »
And here comes after a very long time a new MLVApp Qt version. We had many problems with old and new features. Some of them are still present... you'll see when trying out.  Download
New features:
- more RAW corrections, focus pixels working
- dual ISO working
- free zoom
- new caching
- sharpening
- pipe ffmpeg export (no more intermediate PNG, much faster)
- new export options for ffmpeg (ProRes 422 way faster with ffmpeg Anatolyi option)
- single 48bit (3x16bit) PNG frame export
- RGB parade
- dark style
- many detail enhancements
- many bugfixes
Problems:
- big audio (sync) problems on Linux, small audio problems on Windows (app may crash when looping very small clips with audio)
- maybe still some instability with caching (has to be tested more)
- ... :P

@bouncyball: could you please again compile and upload the windows versions on github release page?
5D3.113 | EOSM.202