Author Topic: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux] (Read 1342500 times)

masc · « **Reply #3525 on:** October 27, 2019, 05:58:23 PM »

Quote from: 2blackbar on October 27, 2019, 05:47:14 PM

Does it require some different algorithm ?

Yes, this would be a new development.

2blackbar · « **Reply #3526 on:** October 28, 2019, 01:53:27 AM »

Maybe if You would be interested with it in the future, here is virtualdub gradation curves filter sourcecode, it has lab color profile and other ones so its easier to lookup the math behind them:
http://members.chello.at/nagiller/vdub/downloads.html

Luther · « **Reply #3527 on:** October 28, 2019, 05:13:06 AM »

Quote from: koopg on October 27, 2019, 01:32:54 PM

great app first of all.

recently I have bought a spider color checker.
it comes with a software that can export color profile for you cam + lens after taking a raw picture of a color plate.
this could be achieved using a stand alone software or a plug in for lightroom.

is there a possible way to use this color profile under MLV app ?

It creates a DCP file @koopg? Currently there's no way to input DCP files in MLVApp. Are you using this to get correct white balance? Try a simple 18% gray card... MLVApp has a WB picker.

Quote from: masc on October 27, 2019, 05:58:23 PM

Yes, this would be a new development.

I requested this before here and here, but upon some reading of the RT code, the Lab feature requires many core functions. Might be really difficult to adapt it to mlvapp.
@2blackbar The feature CIECAM02 in advanced tab can be a better way to bring correct saturation to shadows. Instead of using a "film-like" curve, try to increase "Brightness + Colorfulness (QM)" in CIECAM first. From my tests, this method of correcting exposure adapts shadow/highlight saturation very well already. Sometimes it's not even necessary to use Lab adjustments...

masc · « **Reply #3528 on:** October 29, 2019, 10:16:11 PM »

I tried to get a RGB2LAB and LAB2RGB conversion running... the results were not satisfying in any way. Maybe the code I found was not good enough. Who knows.
@Luther: in what application do I find this "advanced tab"? RawTherapee?

If anyone is interested and has not seen it yet: I made a tutorial about a possible workflow between MLVApp and FCPX (Resolve and Vegas should work the same way, but I did not try). It is the workflow I always use and which works fine for me, even in bigger (400GB+ of MLVs) projects. Make sure having subtitles enabled.

Luther · « **Reply #3529 on:** October 30, 2019, 12:31:57 AM »

Quote from: masc on October 29, 2019, 10:16:11 PM

@Luther: in what application do I find this "advanced tab"? RawTherapee?

Yes:

masc · « **Reply #3530 on:** November 01, 2019, 02:07:54 PM »

Found some code for a new feature, tested and added it to MLVApp. Then I modded it a bit to make it even more powerful. It is a CA correction, which works with RGB data. It searches at contrast edges for wrong colors and corrects them. The good thing: this also works for color moiree! This means we now can filter most of the ugly color artifacts in 3x3 lineskipping modes! See here:
Original:

Filtered:

Would be cool if you could check out, compile and report your findings!

Danne · « **Reply #3531 on:** November 01, 2019, 02:09:27 PM »

Holy cow

...

DeafEyeJedi · « **Reply #3532 on:** November 01, 2019, 02:35:50 PM »

Holy Moly @masc! Had to jump out of bed and compile...

It's like asking myself... am I still dreaming? That's how good this is!

timbytheriver · « **Reply #3533 on:** November 01, 2019, 03:14:19 PM »

Blimey. Play-time!

I made clean, compiled and ~~got no command-line errors~~ but the final compiled app on 10.14.4 has a white line through it, and I get the message 'You can’t open the application “MLV App” because it may be damaged or incomplete.'

Any ideas?

Errors:

Code: [Select]

Undefined symbols for architecture x86_64:
  "_CACorrection", referenced from:
      _applyProcessingObject in raw_processing.o
ld: symbol(s) not found for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [MLV App.app/Contents/MacOS/MLV App] Error 1

DeafEyeJedi · « **Reply #3534 on:** November 01, 2019, 03:21:45 PM »

Actually I can second this error @timbytheriver as well!

This very system (10.14.6) compiled just fine few days ago...

I've also tried running ‘U’ via MLV_App_Compiler which didn’t help either.

What gives? Apple can be full of surprises...

masc · « **Reply #3535 on:** November 01, 2019, 03:35:57 PM »

So you both can't compile? Hm... strange. Looks like a linker problem. Did you run qmake? I guess you cleaned all before compiling?

timbytheriver · « **Reply #3536 on:** November 01, 2019, 03:37:54 PM »

Is qmake the option (op) in the compile app?

masc · « **Reply #3537 on:** November 01, 2019, 03:40:34 PM »

No idea, I never used the compiler app. QMake is located in the Qt bin folder and has to be run with the file MLVApp/platform/MLVApp.pro. With that Makefile is created / updated. If you have QtCreator, all this works automatically when pressing build button.

DeafEyeJedi · « **Reply #3538 on:** November 01, 2019, 03:41:04 PM »

I usually prefer to run 'op' than 'c' via MLV_App_Compiler just because I feel dandy and more confidence!

Perhaps I should take this issue over to @Danne's MLV_App_Compiler then?

Sorry I had thought this was definitely related to this... who knows? I'll be up either way...

Thanks @Danne for confirming!

Danne · « **Reply #3539 on:** November 01, 2019, 03:41:49 PM »

Confirm compiling broken due to CACorrection update:

Code: [Select]

framework QtCore -framework DiskArbitration -framework IOKit -framework OpenGL -framework AGL   
Undefined symbols for architecture x86_64:
  "_CACorrection", referenced from:
      _applyProcessingObject in raw_processing.o
ld: symbol(s) not found for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [MLV App.app/Contents/MacOS/MLV App] Error 1

masc · « **Reply #3540 on:** November 01, 2019, 03:46:45 PM »

Höööööö... here it compiles fine. All the includes are there and the ColorAberrationCorrection.o object is also created. This one has the reference which your compilers call "undefined". You find it in "MLV_App/platform/build-MLVApp-Desktop_Qt_x_y_z_....._64bit-Release/.obj/". Don't understand this.

masc · « **Reply #3541 on:** November 01, 2019, 03:51:24 PM »

Added a "extern" for the reference. Could you try again? (Don't expect any difference, but maybe we've luck.)

Edit: and another one. Is this the only error, or do you see something more?

whitelight · « **Reply #3542 on:** November 01, 2019, 03:53:21 PM »

Quote from: masc on November 01, 2019, 02:07:54 PM

Found some code for a new feature, tested and added it to MLVApp. Then I modded it a bit to make it even more powerful. It is a CA correction, which works with RGB data. It searches at contrast edges for wrong colors and corrects them. The good thing: this also works for color moiree! This means we now can filter most of the ugly color artifacts in 3x3 lineskipping modes! See here:
Original:

Filtered:

Would be cool if you could check out, compile and report your findings!

AWESOME! I am looking forward to seeing this implemented

timbytheriver · « **Reply #3543 on:** November 01, 2019, 04:00:39 PM »

Same failure:

Code: [Select]

Undefined symbols for architecture x86_64:
  "_CACorrection", referenced from:
      _applyProcessingObject in raw_processing.o
ld: symbol(s) not found for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [MLV App.app/Contents/MacOS/MLV App] Error 1

Quite a lot of 'Warnings' earlier on in the command line also…

Code: [Select]

../../src/processing/rbfilter/rbf.h:148:9: warning: expression result unused [-Wunused-value]
        *--temp_x; *temp_x = 0.5f*((*temp_x) + (*--in_x));

et al.

Danne · « **Reply #3544 on:** November 01, 2019, 04:01:09 PM »

Quote from: masc on November 01, 2019, 03:51:24 PM

Added a "extern" for the reference. Could you try again? (Don't expect any difference, but maybe we've luck.)

Edit: and another one. Is this the only error, or do you see something more?

Only error.
Add extern? Where? In code, compiler?

masc · « **Reply #3545 on:** November 01, 2019, 04:02:08 PM »

I added it. Have you updated your working copy?

timbytheriver · « **Reply #3546 on:** November 01, 2019, 04:05:30 PM »

If I try to make-clean I get:

Code: [Select]

make: make: *** No rule to make target `clean'.  Stop.
rm -rf "MLV App" "MLV App".app main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o llrawproc.o pixelproc.o stripes.o patternnoise.o hist.o dualiso.o avf_lib.o filter.o genann.o blur_threaded.o dng.o darkframe.o camera_id.o audio_mlv.o *.o

masc · « **Reply #3547 on:** November 01, 2019, 04:27:37 PM »

Quote from: timbytheriver on November 01, 2019, 04:05:30 PM

If I try to make-clean I get:

Code: [Select]
make: make: *** No rule to make target `clean'. Stop. rm -rf "MLV App" "MLV App".app main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o llrawproc.o pixelproc.o stripes.o patternnoise.o hist.o dualiso.o avf_lib.o filter.o genann.o blur_threaded.o dng.o darkframe.o camera_id.o audio_mlv.o *.o

Hm, ColorAberrationCorrection.o is missing. But why it is not included in your makefile? QMake would include it (as it does here). Could you check date and time of your Makefile? And if ColorAberrationCorrection.o can be found inside?

timbytheriver · « **Reply #3548 on:** November 01, 2019, 04:32:43 PM »

my Makefile inside MLv_app_master folder is dated today 14.58

can only find ColorAberrationCorrection.h in there – no .o

masc · « **Reply #3549 on:** November 01, 2019, 04:37:33 PM »

Here a part of what my qmake creates:

Code: [Select]

####### Output directory

OBJECTS_DIR   = .obj/

####### Files

SOURCES       = ../qt/main.cpp \
		../qt/MainWindow.cpp \
		../../src/debayer/amaze_demosaic.c \
		../../src/debayer/debayer.c \
...
		../qt/OverwriteListDialog.cpp \
		../qt/PixelMapListDialog.cpp \
		../../src/processing/cafilter/ColorAberrationCorrection.c \
		../cocoa/avf_lib/avf_lib.m .rcc/qrc_ressources.cpp \
		.rcc/qrc_darkstyle.cpp \
		.moc/moc_MainWindow.cpp \
		.moc/moc_InfoDialog.cpp \
...
OBJECTS       = .obj/main.o \
		.obj/MainWindow.o \
		.obj/amaze_demosaic.o \
		.obj/debayer.o \
...
		.obj/OverwriteListDialog.o \
		.obj/PixelMapListDialog.o \
		.obj/ColorAberrationCorrection.o \
		.obj/avf_lib.o \
		.obj/qrc_ressources.o \
		.obj/qrc_darkstyle.o \
...

News:

Author Topic: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux] (Read 1342500 times)