Author Topic: GPL issues with commercial app (again)  (Read 6468 times)

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3054
Re: GPL issues with commercial app (again)
« Reply #25 on: May 11, 2017, 08:31:34 PM »
MLVProcessorProtocol.h is 404
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: [email protected]
ONLY donate for things we have done, not for things you expect!


martinhering

  • Member
  • ***
  • Posts: 100
Re: GPL issues with commercial app (again)
« Reply #27 on: May 14, 2017, 09:27:24 AM »
Yep, thank you for the correction.

@g3gg0
Any comments?
5D Mark III, EOS M, 700D

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3054
Re: GPL issues with commercial app (again)
« Reply #28 on: May 14, 2017, 11:48:56 AM »
i still wanted to check it out and inspect locally, didnt have time for it yet.

but i already stumbled through the source on the web interface and wonder where you used ML code?
the only thing i could find was the GetRawPixel stuff in MLVRawImage.m.
everything else looks like it was totally rewritten from scratch.

did i miss some point?
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: [email protected]
ONLY donate for things we have done, not for things you expect!

martinhering

  • Member
  • ***
  • Posts: 100
Re: GPL issues with commercial app (again)
« Reply #29 on: May 14, 2017, 12:11:49 PM »
Quote
everything else looks like it was totally rewritten from scratch.

This is what I told all along. For the vertical stripes correction however, I used the code of mlvdump as a reference. As @a1ex told me this is derivative work nonetheless and thus falls under the terms of the GPL.

To be honest it is now much easier for me to have all the MLV code under GPL. This way I don't need to care anymore about the licensing issues. I am fine with that. The only question that remains is, if it is possible now to integrate the mlvprocess binary into a commercial project and communicate over inter-process communication mechanisms. I could not find anything about that. All I can find is, that you can't dynamically or statically link a library. But XPC should be the same as starting a command line tool and sending messages over the shell conceptionally, which should be fine. Not?
5D Mark III, EOS M, 700D

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3054
Re: GPL issues with commercial app (again)
« Reply #30 on: May 14, 2017, 05:32:29 PM »
that's the thing with derivative work.

IMHO, if you just transplant parts like stripe correction into your GPLed part, then i wouldn't feel like ML's (GPL) rights were violated.
especially when your tool has a lot more features than just the MLV->image_sequence part and stripe correction is the only thing it does.
this means the indirectly used code parts of mlv_dump and related sources are not the heart of your program.

so i'd say you are on the right track.
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: [email protected]
ONLY donate for things we have done, not for things you expect!