This was never an issue in past, as I can remember.
This issues was potentially
already present but not noticed before (it's related to the issue reported from
JohanJ in this thread but present in all other branches), because probabily none of the chipped Lenses have long name.
I have
previously modified LENS block to safely add termination char as showed in previous links, but then g3gg0 suggested to don't use it as he prefer to not have mandatory "\0" in the string of a MLV block, so stick with this method (you can find it in all the other branches).
In practice: LENS block is without termination character with lens name >= 32 byte (otherwise should be copied from lens_info.lensName when assigning is done but
only with the a1ex's fix linked before applied to source code), while ELNS will have it as safety in mlv.c when building block
due to snprintf().
So what should be the correct name of your lens used? "Samyang 8mm f/3.5 UMC Fish-Eye C" (32 chars) or "Samyang 8mm f/3.5 UMC Fish-Eye " (31 chars)?
It should be none of the above but "Samyang 8mm f/3.5 UMC Fish-Eye CS II", assuming you want to keep info showed in the same way (ie. not replicating some infos in separate textbox).
I would suggest you to retrieve lens name from ELNS block; well... always use it if available
It would contain the complete name or the exact name if less than 32 bytes length (corner case of lens with 31 chars + "/0" added from ML code) compared to the one in LENS.
Thanks for the clip.
Thank you for adding support to MLV App!
