Author Topic: Update mlv_dump  (Read 2750 times)

dfort

  • Developer
  • Hero Member
  • *****
  • Posts: 3751
Update mlv_dump
« on: October 08, 2016, 03:52:05 PM »
mlv_dump is one of the Magic Lantern stalwart apps and is still useful in many situations although many of the functions have been improved in dmilligan's MLVFS. Some of the "features" in MLVFS could be considered bug fixes that should be implimented in mlv_dump.

I opened an enhancement issue on bitbucket, Issue #2609

First baby step is to change the way dng files are named so that it conforms to MLVFS naming. The justification is because there should be some consistency between ML apps.

Pull request: https://bitbucket.org/hudson/magic-lantern/pull-requests/758/simplify-dng-names/diff
5D3.* 7D.206 700D.115 EOSM.203 EOSM2.103 M50.102

g3gg0

  • Developer
  • Hero Member
  • *****
  • Posts: 3157
Re: Update mlv_dump
« Reply #1 on: October 08, 2016, 04:23:40 PM »
its okay to me. that _frame_ is not necessary.
Help us with datasheets - Help us with register dumps
magic lantern: 1Magic9991E1eWbGvrsx186GovYCXFbppY, server expenses: paypal@g3gg0.de
ONLY donate for things we have done, not for things you expect!

dfort

  • Developer
  • Hero Member
  • *****
  • Posts: 3751
Re: Update mlv_dump
« Reply #2 on: October 08, 2016, 04:36:47 PM »
Thanks g3gg0. That was quick and easy. The other stuff I'll need some help.


Sent from my iPad using Tapatalk
5D3.* 7D.206 700D.115 EOSM.203 EOSM2.103 M50.102

dfort

  • Developer
  • Hero Member
  • *****
  • Posts: 3751
Re: Update mlv_dump
« Reply #3 on: October 08, 2016, 07:06:07 PM »
Looks like the white balance issue has already been solved by @bouncyball but there hasn't been a pull request made yet:

http://magiclantern.fm/forum/index.php?topic=17955.msg173064#msg173064
5D3.* 7D.206 700D.115 EOSM.203 EOSM2.103 M50.102

DeafEyeJedi

  • Hero Member
  • *****
  • Posts: 3397
  • 5D3 | M1 | 7D | 70D | SL1 | M2 | 50D
Re: Update mlv_dump
« Reply #4 on: October 08, 2016, 07:24:51 PM »
+1 for starting this thread @dfort!
5D3.113 | 5D3.123 | EOSM.203 | 7D.203 | 70D.112 | 100D.101 | EOSM2.* | 50D.109

dfort

  • Developer
  • Hero Member
  • *****
  • Posts: 3751
Re: Update mlv_dump
« Reply #5 on: October 13, 2016, 01:31:36 AM »
So it turns out that the white balance issues can be resolved by using dmilligan's ml_dng branch. However, I hit a road block when porting over the latest raw2dng to the modular dng code base. The color on the exported dng files are way off. This is also affecting mlv_dump when working with dual iso. What is strange is that the raw2dng that is in bouncyball's ml_dng version plays fine with mlv_dump but once I put in all the latest changes it doesn't--mind you that raw2dng in bouncyball's ml_dng branch is also definitely broken when used by itself.

Here is what the current "unified" version of raw2dng with bouncyball's latest changes looks like:


And this is what my work in progress build--along with all the other versions of raw2dng that use the ml_dng codebase look like:


exiftool also shows some weird numbers for color.

Current raw2dng:
Code: [Select]
DNG Version                     : 1.3.0.0
DNG Backward Version            : 1.3.0.0
Unique Camera Model             : Canikon
Color Matrix 1                  : 0.6602 -0.0841 -0.0939 -0.4472 1.2458 0.2247 -0.0975 0.2039 0.6148
Analog Balance                  : 1 1 1
As Shot Neutral                 : 0.473635 1 0.624
Baseline Exposure               : undef
Baseline Noise                  : 1
Baseline Sharpness              : 1.333333333
Linear Response Limit           : 1
Calibration Illuminant 1        : D65

DNG module version:
Code: [Select]
DNG Version                     : 1.4.0.0
Unique Camera Model             :
Black Level                     : 2047
White Level                     : 15000
Default Scale                   : 1 1
Default Crop Origin             : 0 0
Default Crop Size               : 1280 720
Color Matrix 1                  : 0.7234 -0.1413 -0.06 -0.3631 1.115 0.285 -0.0382 0.1335 0.6437
Color Matrix 2                  : 0.6722 -0.0635 -0.0963 -0.4287 1.246 0.2028 -0.0908 0.2162 0.5668
As Shot Neutral                 : 0.0004656612873 1 0.0004656612873
Baseline Exposure               : 0
Calibration Illuminant 1        : Standard Light A
Calibration Illuminant 2        : D65

Note that the exif tags are very different between the src/chdk-dng and modules/dng versions. Copying the "As Shot Neutral" tag from the current version and plugging it into the dng module version helps but doesn't completely fix it.

Here's the link to my work in progress:
https://bitbucket.org/daniel_fort/magic-lantern/branch/ml_dng-mlv_dump

So now I've got a working mlv_dump and a broken raw2dng in my mlv_dng branch and a broken mlv_dump and working raw2dng in the unified branch but there's no way to mix and match the two codebases.

Is there a way to break the dependency between mlv_dump and raw2dng? That is beyond my coding skills.

Note that I posted some of this information in the MLV Lite topic on this post but felt I was going too far off topic to continue it there.

[EDIT] Also note that there is an issue with the current version of mlv_dump when used with dual_iso. I filed a bug report on bitbucket. Note that the ml_dng version with the latest enhancements is playing fine with dual_iso. Another reason to push this forward.
5D3.* 7D.206 700D.115 EOSM.203 EOSM2.103 M50.102