Video - dual iso for 5D2

Started by waza57, March 13, 2016, 11:32:10 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

reddeercity

waza57 has put some amazing work into my 3K/UHD 5D2 Raw development thread , I guess he has been able to increase resolution without the adtg_gui.mo
https://www.magiclantern.fm/forum/index.php?topic=19336.msg198809#msg198809
He mention that when he has a chance he'll post his code  :)

waza57

Hello , I need your help for that because i'm not sure.
For dual-ISO on 5D2, how to make a pull request and to which branch ?
Thanks.

Danne

Do you have a bitbucket account? If not I think creating one would be an easy way to fork, branch and submit a pull request. What branch did you work from to begin with when starting changing dual iso code?

waza57

Thanks,
yes, I have an account.
I had created a new branch (dual_iso_video_5d2 ) from a fork the 2016-03-13
I  only made changes in dual_ISO.c file.
What next for a pull request ?

dfort

@waza57 - Push your changes to Bitbucket then in your web browser click on "Pull requests" in the left panel and pick the appropriate branch in the hudson repository. You didn't mention which branch you started with, unified? cr2hdr? I see several changes on a crop_rec_4k_5D2 branch in your repository but that doesn't have the dual_iso changes, does it?

Perhaps you should ask a1ex about an appropriate branch for this pull request.

waza57

Thanks,

Changes are in branch: dual_iso_video_5d2 in my repository. (crop_rec_4k_5D2 i s for experiment but not complete)

I made pull request on "unified" but perhaps a mistake, i don't know.

Danne

Great waza57. If you started working from unified there´s where you should send your pull request.
You seem to now what you´re doing. I wanted to ask if you perhaps wants to take a look at this problem?
https://www.magiclantern.fm/forum/index.php?topic=7139.msg200188#msg200188

waza57

Sorry but i don't understand nothing about pink highlight.
it's comes with 5D2 ?

Danne

Nope 100D bit I think it's rekated to 12bits lossless rather than camera.