Author Topic: Video - dual iso for 5D2  (Read 19147 times)

reddeercity

  • Hero Member
  • *****
  • Posts: 1636
Re: Video - dual iso for 5D2
« Reply #50 on: April 16, 2018, 03:33:40 AM »
waza57 has put some amazing work into my 3K/UHD 5D2 Raw development thread , I guess he has been able to increase resolution without the adtg_gui.mo
https://www.magiclantern.fm/forum/index.php?topic=19336.msg198809#msg198809
He mention that when he has a chance he'll post his code  :)

waza57

  • New to the forum
  • *
  • Posts: 21
Re: Video - dual iso for 5D2
« Reply #51 on: April 16, 2018, 08:33:24 PM »
Hello , I need your help for that because i'm not sure.
For dual-ISO on 5D2, how to make a pull request and to which branch ?
Thanks.

Danne

  • Hero Member
  • *****
  • Posts: 4271
Re: Video - dual iso for 5D2
« Reply #52 on: April 16, 2018, 08:56:31 PM »
Do you have a bitbucket account? If not I think creating one would be an easy way to fork, branch and submit a pull request. What branch did you work from to begin with when starting changing dual iso code?

waza57

  • New to the forum
  • *
  • Posts: 21
Re: Video - dual iso for 5D2
« Reply #53 on: April 17, 2018, 12:21:46 AM »
Thanks,
yes, I have an account.
I had created a new branch (dual_iso_video_5d2 ) from a fork the 2016-03-13
I  only made changes in dual_ISO.c file.
What next for a pull request ?

dfort

  • Developer
  • Hero Member
  • *****
  • Posts: 3031
Re: Video - dual iso for 5D2
« Reply #54 on: April 17, 2018, 12:47:51 AM »
@waza57 - Push your changes to Bitbucket then in your web browser click on "Pull requests" in the left panel and pick the appropriate branch in the hudson repository. You didn't mention which branch you started with, unified? cr2hdr? I see several changes on a crop_rec_4k_5D2 branch in your repository but that doesn't have the dual_iso changes, does it?

Perhaps you should ask a1ex about an appropriate branch for this pull request.
5D3.* 7D.206 700D.115 EOSM.203 EOSM2.103 500D.112

waza57

  • New to the forum
  • *
  • Posts: 21
Re: Video - dual iso for 5D2
« Reply #55 on: April 19, 2018, 09:50:39 AM »
Thanks,

Changes are in branch: dual_iso_video_5d2 in my repository. (crop_rec_4k_5D2 i s for experiment but not complete)

I made pull request on "unified" but perhaps a mistake, i don't know.

Danne

  • Hero Member
  • *****
  • Posts: 4271
Re: Video - dual iso for 5D2
« Reply #56 on: April 19, 2018, 09:59:22 AM »
Great waza57. If you started working from unified there´s where you should send your pull request.
You seem to now what you´re doing. I wanted to ask if you perhaps wants to take a look at this problem?
https://www.magiclantern.fm/forum/index.php?topic=7139.msg200188#msg200188

waza57

  • New to the forum
  • *
  • Posts: 21
Re: Video - dual iso for 5D2
« Reply #57 on: April 19, 2018, 10:13:47 AM »
Sorry but i don't understand nothing about pink highlight.
it's comes with 5D2 ?

Danne

  • Hero Member
  • *****
  • Posts: 4271
Re: Video - dual iso for 5D2
« Reply #58 on: April 19, 2018, 10:26:40 AM »
Nope 100D bit I think it's rekated to 12bits lossless rather than camera.