Dealing with Focus Pixels in raw video

Started by dfort, October 22, 2015, 11:09:10 PM

Previous topic - Next topic

0 Members and 2 Guests are viewing this topic.

dragonsfire1981

Canon EOS M and Danne's June build I'm using.

I'll upload a still image shortly illustrating the problem.

So you're saying short h.264 clips sometimes do have the problem? Or did you mean to say "(share a clip) a short H.264 clip (which) has the problem"


>> also a short H.264 clip has the problem

Quote from: theBilalFakhouri on September 23, 2021, 07:11:24 PM
@dragonsfire1981

Which camera, which build? share a image showing the problem, also a short H.264 clip has the problem

theBilalFakhouri

I meant to "share" short H.264 clip has the problem, just to make sure what kind of focus pixels you are having.

Actually I saw multiple EOS M users are reporting same problem with H.264 video with Danne build, most people didn't have the problem, it must be a quirk happening in specific cases, I don't have EOS M so can't test/help you much

This thread is about fixing focus pixels in RAW videos, you maybe want to report the problem in this thread:
https://www.magiclantern.fm/forum/index.php?topic=25781.0

In normal H.264 videos you shouldn't have focus pixels by default.

dragonsfire1981

Okay, that makes sense, and I'll report it to that thread shortly. I did see on another forum, referring to an older build that Zeek thinks it's something to do with the bitrate. Some of my h264 footage has no focus pixel problem whatsoever and I did change the bitrate a couple of times throughout the day so I'll run some tests to see what correlation i can find.

Can you reccommend, apart from the Vanilla nightly, what else is a most stable previous, recent ML build pherhaps where this problem is not known to occur?

Quote from: theBilalFakhouri on September 28, 2021, 12:06:40 PM
I meant to "share" short H.264 clip has the problem, just to make sure what kind of focus pixels you are having.

Actually I saw multiple EOS M users are reporting same problem with H.264 video with Danne build, most people didn't have the problem, it must be a quirk happening in specific cases, I don't have EOS M so can't test/help you much

This thread is about fixing focus pixels in RAW videos, you maybe want to report the problem in this thread:
https://www.magiclantern.fm/forum/index.php?topic=25781.0

In normal H.264 videos you shouldn't have focus pixels by default.

Danne

It's not known exactly what your issue is about so upload a file which clearly shows the issue before asking for other builds.

dragonsfire1981

Hello Danne! Thanks for all the work you've done so far- really enjoyed learning to shoot RAW.

These are 3 stills taken from 3 bits of h264 footage. First two shots from the window of a train, third one the focus pixels a little fainter but can be seen on the pavement, I'll find a site to upload the videos shortly.   

https://ibb.co/kKWSbnB
https://ibb.co/mzkWn6s
https://ibb.co/WDJ9kPK







So far, from what I've gathered when I proactively select the H264 preset, it does not have the focus pixel problem. It's when the preset is not selected, and RAW video is turned off it seems to have that problem ie you can shoot h264 in more than one preset, but not having the h264 turned on seems to cause the problem.


Quote from: Danne on September 28, 2021, 02:15:08 PM
It's not known exactly what your issue is about so upload a file which clearly shows the issue before asking for other builds.

Danne

Ah, yes, now I know your issue. Look. My version originally was thought to only inherit raw video capabilities but after some consideration I decided to be able and use h264 mode. But by turning of raw video still won´t shut off crop rec presets so all those regs are still applied. Including focus pixel issues. The workaround is to enable h264 from within the preset menu here which also shuts off crop rec:

dragonsfire1981

Thank you yes- I thought that was the workaround, I just shot three h264 clips with h264 preset applied and can confirm there are no focus pixels! Something else I was slightly confused by was that there are two levels of presets, level 1 when you press the set button (presets), and level 2 (startoff presets) when you press the play button. H264 isn't listed as a preset on the level 1 presets, so it seems like level 2 settings take precedence then?

Do you think in the next build, there may be a way that applies the h264 and crop shut off automatically when you turn off RAW video? Currently I think it confuses a few people as I saw on MLV Facebook group a few other people were getting this also.

It's a great build otherwise though!

The original h264 video clips for reference.

https://streamable.com/2fpvqm

https://streamable.com/o5ac0l

https://streamable.com/2fpvqm



Quote from: Danne on September 28, 2021, 03:49:38 PM
Ah, yes, now I know your issue. Look. My version originally was thought to only inherit raw video capabilities but after some consideration I decided to be able and use h264 mode. But by turning of raw video still won´t shut off crop rec presets so all those regs are still applied. Including focus pixel issues. The workaround is to enable h264 from within the preset menu here which also shuts off crop rec:


Danne


gabriielangel

Hello, Are there any focus pixel maps for the latest build's resolutions (5k frtp & 2.5k 1:1 crop)? I went to https://github.com/ilia3101/MLV-App/tree/5feaf45d38b82636fbfe12a8b941c9bf25ada1a9/pixel_maps  , but I could not find matching resolutions. Thanks!

clubsoda

Hey Danne! So i have this issue too but in newer builds there is no h264 8bit preset to select. Is there a workaround or am i stuck with focus pixels in 8bit ? I am using Feb 04 build because it's the only build that wont cause glitches to the photos. Thanks :)

Quote from: Danne on September 28, 2021, 03:49:38 PM
Ah, yes, now I know your issue. Look. My version originally was thought to only inherit raw video capabilities but after some consideration I decided to be able and use h264 mode. But by turning of raw video still won´t shut off crop rec presets so all those regs are still applied. Including focus pixel issues. The workaround is to enable h264 from within the preset menu here which also shuts off crop rec:


Danne

Tapping screen gets me to h264 8bit. Not using old builds so better you show what is not working with newer builds and taking photos so we can try and fix that issue.


clubsoda

Thanks so much ! That fixed it! Seems the h264 8bit won't show up on presets under movie tab only. When selected with tap on screen it shows up as preset 13. Works perfect though. The issue with newest builds is that photos have glitched blocks in the frame when in photo mode. I disabled most major tweaks but it didn't help. This affects the raw file and the jpeg.

Danne

Glitched what? Can you upload a file?

clubsoda

yes here you go with some files. jpeg looks same. latest build photo mode. It happens only sometimes not always. I tried to find out if there is a setting interfering but his is not the case as i tried all combinations on off and it happened either way and with a fresh build. checked my camera settings too. Nothing too unusual https://drive.google.com/drive/folders/1-phPVRWegzt-3icpb84Fjheh8gwHUler?usp=sharing

Danne

Maybe the sd card?
Try turning off sd_uhs patching? Not sure if it can be turned off though in this build.

clubsoda

Ok so i tested further! SD is not the issue and the uhs speed hack neither. I disabled it and switched card. Still the same BUT: I found out that it likely happens when the ML Histrogram is enabled and it doesn't happen when it is disabled in the menu.  :o

Danne


pepper_chip

Hi all
Found something interesting with dealing focus pixels, adjusting adtg2{8190} from 0x10 to 0xf almost reduce focus pixels from capture RAW  files, looks like work in blue channel pixels

https://youtu.be/gFNYpiKoQoI

First take with 0x10 second with 0xf
Focus pixels correction mapping is off in MLV app
Please watch in 4k
Its a standart 5x3 mode, because adtg module doesnt work with cropmood , and I'm not a developer :(

whitelight

Quote from: pepper_chip on May 09, 2023, 06:21:35 PM
Hi all
Found something interesting with dealing focus pixels, adjusting adtg2{8190} from 0x10 to 0xf almost reduce focus pixels from capture RAW  files, looks like work in blue channel pixels

First take with 0x10 second with 0xf
Focus pixels correction mapping is off in MLV app
Please watch in 4k
Its a standart 5x3 mode, because adtg module doesnt work with cropmood , and I'm not a developer :(

Definitely improved. Is sharpness affected?

pepper_chip

Don't see any changes with sharpness, BUT I can only check it in 5x3 binning mode, need devs here to look closer

Danne

Could you redo test on a white surface stopped down to around 5.6 or higher? Then upload two short example mlv files or one dng of each take.

pepper_chip

Of course, little bit later, not at home now

iaburn

Quote from: pepper_chip on May 09, 2023, 11:45:04 PM
Of course, little bit later, not at home now

Anyone knows what happened with this "adtg2{8190}" register that helped to fade the focus pixels a bit? Didn't worth investigating? was it reducing the max bit rate?

I was searching how to make focus pixels maps for the 100D and saw this post

pepper_chip

Quote from: Danne on May 09, 2023, 10:40:20 PM
Could you redo test on a white surface stopped down to around 5.6 or higher? Then upload two short example mlv files or one dng of each take.

Here s the stills in dng format





https://drive.google.com/drive/folders/1EgLRLF-O1OoedHhLo1_q8CtXtii9el2G?usp=share_link

iaburn

Quote from: pepper_chip on May 14, 2023, 02:35:26 PM
Here s the stills in dng format





https://drive.google.com/drive/folders/1EgLRLF-O1OoedHhLo1_q8CtXtii9el2G?usp=share_link

Is the adtg2 register available to change on Crop mood builds? I can only find adtg0 and adtg1

Edit: The difference is very noticiable! The red pixels are gone, just some blue ones still present