OK, i figured it out,
I was missing the file video_hacksU.o
and I also had to add:
ML_SRC_EXTRA_OBJS = \
video_hacksU.o \
to my makefile.setup in the platform directory.
So I've got it working now.
If i recall correctly, the reason this is not included in main, is because the settings persist until you restart the camera, not only this, but the camera must be restarted with the same card (with the current implementation) in order to clear the settings, this presents a dangerous situation, as someone who isn't aware of this might remove their magic lantern card, and the GOP/flush settings don't go back to default.
So please give me a hint as to an example of different code that had this problem (of having to reboot to turn off feature) and was fixed. I think it's worthwhile to work on this because control over gop settings allows the EOSM (and probably other digic 5 cameras) to record up to 45fps in 1080p crop mode. I would like to eventually implement a slow-mo module that automatically applies the best settings for overcranking.
Is anyone willing to help me with this? Or should I just keep it to myself? I know this is an advanced use case (expert users only...) but I think we could make it easy to understand and safe for the masses with correct implementation (module?). I know that the perceived benefit of these controls did not show much in the way of video quality improvement when it was being investigated, but no one ever talked about overcranking. I feel this warrants further discussion. If you disagree, and think it's just going to be a support nightmare, let me know, and I'll stop talking about it.
Thanks
~Jon