Lightroom plugin cr2hdr v3.0 DEV (WIP)

Started by kichetof, March 18, 2014, 05:04:33 PM

Previous topic - Next topic

0 Members and 3 Guests are viewing this topic.

DeafEyeJedi

20 MB compress file to 5.3 MB compress-lossy file = HOLY S#!t!

Excellent find @dfort and will def try your suggestion asap.
5D3.113 | 5D3.123 | EOSM.203 | 7D.203 | 70D.112 | 100D.101 | EOSM2.* | 50D.109

snakec

Sorry for my bad English

No exif for me with the Lightroom Plugin's

My version Is "unzip, rename kichetof-lr_cr2hdr-42be6b9232cd to cr2hdr.lrplugin"
whit https://bitbucket.org/kichetof/lr_cr2hdr/downloads/cr2hdr.lrtemplate

CANON 70D - Lightroom 6.01

Walter Schulz

As discussed above:
- OS X: Install Exiftool 9.9.8
- Windows: Replace bin\Exiftool.exe and bin\lib directory in with contents in Exiftool 9.9.8

snakec

On Windows 7

I already replace the " bin \ lib directory in 9.9.8 with content in exiftool " but not the exiftool.exe
And I had exif but the photo was becoming overexposed
I will try tonight.
thank you

dfort

As far as I can tell this is the "official" home of ExifTool:
http://www.sno.phy.queensu.ca/~phil/exiftool/
Note that there are Mac and Windows downloads with detailed instructions on how to install. The Windows installation is a bit confusing--you need to rename exiftool(-k).exe to exiftool.exe but it doesn't say exactly where you need to move the file so that it is available system wide.

Quote from: Walter Schulz on July 16, 2015, 09:54:18 AM
As discussed above:
- OS X: Install Exiftool 9.9.8
- Windows: Replace bin\Exiftool.exe and bin\lib directory in with contents in Exiftool 9.9.8

@Walter Schulz - there is a "bin" directory inside of the plug-in, is that what you are referring to or is this something that is in the root directory of the startup drive?

Walter Schulz

Running plug-in in Windows will use cr2hdr.lrplugin\bin as "working directory". No need to change that.

dfort

@Walter Schulz - Thanks for clearing that up. Just wondering, on Windows can't you just delete the bin\lib directory and everything should work fine as long as you're running exiftool.exe version 9.98?

I'm probably testing your patience but it seems to me that the bin\lib contents isn't necessary on Windows. What's in there are library files for ExifTool and the Windows executable should include those libraries. A few days ago you mentioned a fix that worked on Windows by replacing the bin\lib directory: http://magiclantern.fm/forum/index.php?topic=11056.msg151047#msg151047

Strange, why would the official ExifTool Windows binary distribution not include the library files if they are necessary?

On Linux and Mac exiftool is a perl script but on Windows it apparently doesn't have any dependencies so that means perl is also included in the binary. Of course this makes for a rather bloated 5.4 MB executable file.

What I'm getting at is that there are several files in the plug-in that aren't being used and perhaps should be eliminated to avoid confusion. On my system I deleted exiftool, dcraw and the lib directory from the plug-in and it still works fine. For the Mac only cr2hdr is needed in cr2hdr.lrplugin/bin.

*Update*

By the way, I forgot to mention that there is no Windows executable in https://fossies.org/linux/misc/Image-ExifTool-9.98.tar.gz/ or http://www.sno.phy.queensu.ca/~phil/exiftool/Image-ExifTool-9.98.tar.gz

Walter Schulz

Daniel, IMO you truly don't have to be afraid bothering folks around here. I'm speaking for myself - of course - but you're helping a lot driving this project forward. Thorough testing, bug reports with detailed descriptions, reasonable suggestions (and not that much mixing up facts and conclusions) -> valuable input. Keep 'em coming ...

Back on topic: You nailed it!
Fun thing is:
- If bin\lib is present it will be used by Exiftool.exe. And Exiftool's version doesn't matter at all. It now depends on Exiftool.pm's version.
- If lib directory is absent: Exiftool will work without error and Exif will be transferred just fine to output file.
So just delete/rename "lib" and your good to go with exiftool v9.9.5.

Tested with Windows 8.1. No Perl library installed but using plug-in files and directories only. I'm wondering what will happen if library is installed in search path (roughly equal to placing files into bin in OS X/Unices).


dfort

Great, now how do we get the developer's attention so that these updates get incorporated into the plug-in?

@WalterSchulz - Is that the proper way to use @name for you? I assume it doesn't work with the space. In any case, do you have the radio button on the GUI issue that I described on your Windows system?

Selected an option that uses radio buttons in the plug-in's GUI and all of the radio button selections disappeared except for the one selected.



Closing and relaunching the plug-in GUI restored the radio button selections.


Walter Schulz

Quote from: dfort on July 17, 2015, 07:45:51 PM
Great, now how do we get the developer's attention so that these updates get incorporated into the plug-in?

Piece of cake, sort of: Drop a beer keg with note attached to his front door somewhere in/nearby Lausanne, Swiss.

Quote from: dfort on July 17, 2015, 07:45:51 PM
@WalterSchulz - Is that the proper way to use @name for you?
Default in web/internet forums is informal.

Quote from: dfort on July 17, 2015, 07:45:51 PM
Selected an option that uses radio buttons in the plug-in's GUI and all of the radio button selections disappeared except for the one selected.
Not a problem here.
2 systems tested
- Windows 8.1, LR CC, Intel HD Graphics 5300
- Windows 7, LR CC, NVIDIA GeForce GTX 750 Ti

I suppose this is where Windows and OS X platforms may react in different ways. Found something about troubleshooting GPU errors in LR but in doubt it applies here: https://helpx.adobe.com/lightroom/kb/lightroom-gpu-faq.html
You may try to disable GPU support.

Walter Schulz


dfort

I disabled GPU acceleration (NVIDIA GeForce GT 750N OpenGL Engine) but still have the same issue.

Beer? Here's a few I've got around the house. Maybe a keg of Arrogant Bastard is appropriate?

Shot on a Canon EOS-M with Dual ISO processed (ISO 100/800) in Lightroom with the cr2hdr plug-in.



Amazing to capture all the detail in the darkest to lightest areas. The bottles were indoors and the background is a bright sunny day in Redondo Beach, California.

Walter Schulz

No, you got the wrong impression about kichetof. He doesn't deserve Fucking Hell either.

dfort

Ha ha, good one!

@kichetof -- Yo Hoo! Got a beer for you!

Anyone spotted him? Last seen on June 06, 2015, 04:15:35 PM

Danne

Kichetof is the best.

@dfort
A suggestion.
Assemble the newly updated plugin package removing unnessecary files and also include the new argument string which fixed the " compress-lossy" error and just send Kichetof a pm with the new package.

Another (I think doable) suggestion for Kichetof to check would be that the plugin itself would install dcraw and exiftool on first run from within lightroom if not already installed. Then the files could be included in the plugin pack and only used if necessary. Of course I,m not a luascripter but I can,t see why it wouldn,t work. Hm, might be root privilige issues in /us/bin/ when I think of it. Well. Updates needed somehow.



Walter Schulz

Just an idea for OS X plug-in: Would it be possible for plugin to open terminal, define local PATH=$PATH:<path to cr2hdr, dcraw, exiftool> and call cr2hdr with arguments after?

And for development we can fork kichetof's stuff.

dfort

There are lots of ways to improve the user experience for Mac--make an installer that puts all the dependencies in the right place, define a local path by having the lua script call a system command, modify cr2hdr to accept a path argument when calling exiftool and dcraw, etc. The tricky part is not breaking the plug-in for Windows systems.

All of this is way beyond my coding abilities.

I did a little detective work on the Internet and think I may have found kichetof on Flickr, Linkedin and Facebook. Hopefully I'll be successful at luring him back to this project. Either that or someone is going to think I'm some sort of a creepy Internet stalker trying to lure people with an offer to buy them a beer.

snakec

Bad :(

CR2 Export to JPEG
http://dl.free.fr/tw4ztVsDw

Export with original plugin but no exif
http://dl.free.fr/tjbu7Gpp2

Export with change exiftool and/or lib ( exif OK but no Good )
http://dl.free.fr/thO53IFRk

Walter Schulz

Quote from: snakec on July 21, 2015, 08:03:49 PM
CR2 Export to JPEG
http://dl.free.fr/tw4ztVsDw

? What are you trying to show? That exporting Dual-ISO.CR2 to JPG gives garbage output?
This "workflow" will not work, nobody ever made a statement it should. Quite the opposite: Dual-ISO.CR2 has to be processed by cr2hdr or equivalent tools to merge interlaced lines.

Quote from: snakec on July 21, 2015, 08:03:49 PM
Export with original plugin but no exif
http://dl.free.fr/tjbu7Gpp2

Yes, that's just discussed in posts above. Nothing new here.

Quote from: snakec on July 21, 2015, 08:03:49 PM
Export with change exiftool and/or lib ( exif OK but no Good )
http://dl.free.fr/thO53IFRk

You may upload your Dual-ISO.CR2 so others may try to show better results.

dfort

Quote from: snakec on July 21, 2015, 08:03:49 PM
Bad :(
Yeah, Bad. I'm not getting anything from those links other than a French website with a bunch of advertisement. Were the files removed?

A few days ago I processed some raw dual iso files from users that were having problems but you really need to provide the raw files. We also need more information, like Windows or Mac? Have you updated to the latest version of the plug-in? (Rather convoluted at the moment but doable.)

I'm assuming that one thing you did was to export a dual iso raw file to jpeg without running it through cr2hdr. That's not how it works. This is how it works:

http://acoutts.com/a1ex/dual_iso.pdf

The Lightroom plug-in just makes it easier to do for people that are more familiar with Photoshop/Lightroom than the command line.

snakec

Hi,

I know used the plugin, which works very well with LR5.5.

With LR6,
when I use the version "kichetof lr_cr2hdr-to-42be6b9232cd cr2hdr.lrplugin" with the modified CH2HDR.template, I get an image well exposed but no EXIF.
dualno by Stephane CAIRE, sur Flickr

If I apply the Walter advice by replacing the / LIB / or replacing the exiftool.exe, I find EXIF, but the photo is overexposed.
dualexif by Stephane CAIRE, sur Flickr

I specified that no adjustment is applied to compare the two files

Walter Schulz

Again: Without original file we're unable to help.
Without original file (untreated CR2) we cannot reproduce your findings.

DeafEyeJedi

@snakec:

Seriously just upload the original CR2 file already otherwise you're just basically wasting our time.

We obviously don't mind helping out but you simply just won't let us unless you can provide us original samples.
5D3.113 | 5D3.123 | EOSM.203 | 7D.203 | 70D.112 | 100D.101 | EOSM2.* | 50D.109

dfort

@snakec - I think I understand your issue. You have the plug-in installed in Lightroom 6 and that is working fine and you also have it installed in Lightroom 5.5 and there it is not working properly.

We need some information from you in order to help.

Are both versions of LR running on the same or different computers?

What operating system are you using, Mac or Windows?

For now I'm assuming that you are on Windows because you mentioned exiftool.exe -- that is for Windows only. Remove the lib that is inside the plug-in's bin directory! That is what was causing the problems in the Windows installation.

If you are on Mac, remove everything from the bin directory except for cr2hdr. On the Mac exiftool (along with its associated lib directory) and dcraw should be installed in /usr/bin.

Hope this helps.

snakec

Hi

Put simply,
When I used the plugin with LR 5.5, it worked perfectly
Since the switch to LR6, my pictures have become overexposed,
Since the new version of the plugin released after May 12,
The plugin provides well exposed photos, without EXIF.
I tried the advice of Walter, but if my pictures retrouvre their EXIF she again become overexposed.

I am on windows 7 pro, Canon 70D, Lightroom 6.01

Best Regards

ps: Walter, can share your "ch2hdr.lrplugins" to test it?

Photo example of dual iso treated with the plugin, it's good but no exif