Well, I just completed a shit load of sample images, to find the screenshot function only captured the first image, and then went on strike. Sure enough, the first image was setting up the testing procedure and doesn't contain useful information. Anyway, I can share my thoughts.
Thoughts on the data:
At first it appeared like movie mode was entirely Read noise limited at lower ISOs. I suspect that movie mode
is somewhat rather Read noise limited (compared to photo mode), however, the curve was extending above the top of the graph, so I can't be certain. It needs some automatic fitting of the curve, or at least, different scales on the graph for movie mode and photo mode.
The DR is greater in movie mode then photo mode. Now, we know the ADTG registers don't change, so if we also consider that the the images are more Read noise dominated, then I believe that this shows pixel binning.
If memory serves me correctly, the stdev was similar to photo mode, but the FWC was less. I didn't check the read noise measurement during the capture phase. I know, this doesn't make sense.
Around ISO 800, the curve gets clipped at 0 EV on the vertical scale. From here, it increases back towards -2 EV with increasing ISO. Confirmed in both 1080p and 720p modes. Speaking of which, I assume you meant Canon resolution modes, since cropping with ML resolution changes seems pointless?
In crop mode, somewhat expected, the figures were remarkably similar to photo mode.
ADTG tweaks work! 11.5 EV @ ISO 200 with some quick tweaking. CMOS 5 is 0x501 and CMOS 6 is 0x370 in movie mode. ADTG6[8000] is 0x6.
Swapping in and out of crop mode, adjusting ADTG registers, taking SNR curve measurements, eventually the camera had enough, and displayed really weird images like the ones I shared in the ISO research pull request.
Thoughts on functionality:
It says "sampling data" in the top right section, but at first I thought it wasn't doing anything, I'm pretty sure for whatever reason, the graph wasn't updating on the first try.. Maybe you could change that to, "Sit tight, I'm counting your photons"! Or something else
really obvious to us common folks.
Since the data is sampled in real time, the first image in the two shot sequence is rather redundant, right?
The framing of the image on the LCD screen changes, when the SNR curve is processing. However, the curve still reflects the original framing.
Did I mention the screenshot function only works on the first image

And whatever else I forgot, since having a notepad and pen with me, makes to much sense

Off to bed. I look forward to raw_diag_movie_mode version 2 when I wake up
