Messages

[Advanced]

Also, I made some changes which affect AF accuracy, these changes are included in latest 100D build:

from Advanced menu in crop mood submenu, there is a new option called Brighten LV method:

-AeWb: Brighten LV using a regiser related to AeWb task. Stable, inaccurate AF.
-EVF: Brighten LV using regisers related to EVF task. Less stable (might produce corrupted frames), accurate AF.

This only applies when using crop mood and lower bit-depths (less than 14-bit) in lossless compression.

[Continuous]

Already answered three days ago:

Continuous autofocus doesn't work when using crop mood presets, you can only trigger autofocus by a half-shutter press ...

@Wannabe

AF works fine here on my 100D, I explained how it works with crop mood build in this reply.
If it still doesn't work for you, show us what are you doing your ML settings (record a video).

@Wannabe

Cool, nice to hear that.

Continuous autofocus doesn't work when using crop mood presets, you can only trigger autofocus by a half-shutter press which work while not recording.
If you want to use autofocus while recording, small hacks must be turned off from RAW video submenu, but this way you will sacrifice some write speed.

29.970 is more likely FPS (it changes depending on selected video mode or if you used FPS override).

It would be helpful to attach an image show us what you see (e.g. for the "bottom line") so we can help further.
You host images on https://imgbb.com/ then link it here.

@Wannabe

Try this build: magiclantern-crop_mood.2023Jul13.100D101_MoreDelay.zip

I increased the delay with some minor tweaks then I did some tests on my 100D and it no longer crashes.

Code Select Expand

--- a/modules/crop_rec/crop_rec.c
+++ b/modules/crop_rec/crop_rec.c
@@ -5145,7 +5145,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)
     }

     /* 650D / 700D / EOSM/M2 / 100D preferences */
-    if (is_DIGIC_5)
+    if (is_DIGIC_5 && lv)
     {
         // all of our presets work in x5 mode because of preview, even none-cropped ones
         if (CROP_PRESET_MENU && !RECORDING && is_movie_mode())
@@ -5155,7 +5155,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)
             if (lv_dispsize == 1)
             {
                 gui_uilock(UILOCK_EVERYTHING);
-                msleep(700);
+                msleep(1100);
                 gui_uilock(UILOCK_NONE);
             }

@@ -5197,7 +5197,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)
         }

         /* while idle, check our preview resgisters, force the new values if not set yet */
-        if (!lv_dirty && !crop_rec_needs_lv_refresh() && CROP_PRESET_MENU && !RECORDING && lv_dispsize == 5 && PathDriveMode->zoom == 5 && lv)
+        if (!lv_dirty && !crop_rec_needs_lv_refresh() && CROP_PRESET_MENU && !RECORDING && lv_dispsize == 5 && PathDriveMode->zoom == 5)
         {
             if (Preview_Control && !Preview_Control_Basic) // presets with basic preview don't need it
             {
@@ -5207,7 +5207,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)

         // FIXME: for now, "More" hacks must be on in order to get wokring preview in 3x3 presets while recording
         // see notes in reg_override_3X3
-        if (CROP_PRESET_MENU == CROP_PRESET_3X3 && lv && raw_lv_is_enabled() && !is_more_hacks_selected())
+        if (CROP_PRESET_MENU == CROP_PRESET_3X3 && raw_lv_is_enabled() && !is_more_hacks_selected())
         {
             if (crop_preset_3x3_res_menu != 1) // exclude 1080p mode
             {
@@ -5241,7 +5241,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)
          * let's check picture quality on startup, also when the user change it to other than RAW         
          * let's inform the user to change pic quality back to RAW, and a camera restart would required
          * this extends recording times at high resolutions, also allows to record Full-Res LV @ 3 FPS */
-        if (lv && patch_active && CROP_PRESET_MENU && is_movie_mode())
+        if (patch_active && CROP_PRESET_MENU && is_movie_mode())
         {
             if (pic_quality != 0x4060000)
             {



How do I remove the 9 May build completely? Do I just erase it from the SD card, or do I have to uninstall it somehow from the camera as well?

Format SD card in PC or Camera (press AV button to toggle to "remove ML"), then install the mentioned build.
There are other ways too, but let's use this for our case.

[Does it work with FPS override?]

1,Horizontal lines on "1：1 presets 2.5k 10bit",no issue on 14 bit.

It's normal  (check "vertical lines on screen" part).

2，Frame order error.Won't get this error message everytime,but it pops up randomly.Seems like it will get this error more if  a slower speed sd card was in use.The footage recorded looks OK on MLV APP.

Sometime I get this error too, but it seem it dosen't affect recording and it doesn't produce corrupted frames.
This error isn't something bad, it's more like a warning.

For example on 5D3 and when using card spanning, this error is always presensted, I just made it hidden and things worked fine, also Danne did the same thing on EOS M in his builds.

I am not sure if it a good step to always hide this error, it might be a good warning for a possibility of corrupted frames?

3,Is there anything you can do to make the temperature lower ?

With ML? I don't know, probably not.
BTW and IIRC, on 700D the camera shows overheat icon then shut down at around ~85 C° to ~90 C°, so 60 C° isn't that bad (at least to me).

4，When using FPS override ,chose "optimize for exact fps",the screen will go corrupt.I don't have picture to show this one,but it's easy for you to find this problem.

I am assuming you are using crop mood presets with FPS override, right? This combo doesn't work well togather, same as:

Does it work with FPS override?

Sort of. It's not reliable at this point, so it's best not to try yet.

Any progress for 5D3?

Short answer: for me, no.

Currently I am being barely active on ML, I am trying to organize my life a little and find some balance, I am okay, don't worry.
I didn't do much work on 5D3 since the release of crop mood, I still have a plan to work on 5D3 again and be more active in general.

I will let you know when I have something to share, just like this sneak-peek

Oh, I just made some new tests on my 100D using 9 May build and sometime I did encounter the same issue you described.
Fow now, please try magiclantern-crop_mood.2023Apr19.100D101_hot_fix.zip build, does it have same issue too?

I probably broke something in 9 May build and it affect 100D.

Again the SD card isn't related to this issue (also the internal battery isn't related), it's something related to LiveView and our ENGIO hook (some delay could solve the issue).

@Wannabe You don't need to turn on the camera to photo mode each time, it was a just a test, you can turn on the camera to video mode directly.

I don't have problems with my 100D and crop mood, it works fine here.
I think it's time to format SD card in PC and make a clean install again, does it work?

ISO stuck? Are you using Manual mode in first place?
If the settings are set to auto then ML can't change these settings, you need to set mode dial to "M", also set ISO to specific value from Canon menu.

You can change ISO and aperture from ML menu in Expo tab or use 100D physical buttons (read Canon manual), you can also use "customize buttons" for ISO and Aperture.

If it still crashes, recrod a video shows what are you doing on your 100D from A to Z (from a fresh ML install to camera crash moment).

..because even after hundreds of crashes, the modules that I turned on in the very beginning are still active.

There is a setting in Debug menu to always load modules even after a crash, it could be that.
The modules will not be loaded only for next camera boot after a crash, but after that (after another boot) modules will load normally.

Perhaps Bilal changed the behaviour on purpose.

Not really, didn't touch that.

[My geuss]

Can this be fixed somehow? Any settings that I need to tweak?

If we know the cause we might be able to find a workaround, yes.
I think the problem can be fixed if you replace the internal battery

I am using the 5.2K, 4.8K and 4.4K presets at 2.35:1  aspect ratio. 10 bit color depth.

Yes. They all cause crashes. Or at least the ones that I have tried so far (5.2K, 4.8K and 4.4K)

5.2K 2.35:1 preset doesn't work fine on 100D, I will make some tweaks to this preset on 100D in next release.
But since all of 2.35:1 1x3 (5.2K, 4.8K and 4.4K) presets are crashing, then crashing issues aren't related to a specifc preset.


-My geuss on what's happening (the following bug only affect 100D):

I had random crashing issues when I ported crop_rec.c (i.e crop_mood.mo) to 100D, the camera could crash at starup when crop mood is already active (from Movie tab) if the camera swtich turned from OFF to movie mode directly.
Crashes could also happen randomly when switching presets, this issue was bugging me for months, until I figured out what was happening:

It seems to happen because of changing zoom modes (among x1, x5 and x10) via ML call in crop_rec.c, if zoom mode changed directly after enerting LiveView the camera sometime crash,
or at least if it didn't crash right away, it can crash when swtiching presets or after some time when crop mood is active in LiveView, maybe that's happening because of changing LV zoom mode while LiveView isn't fully configured yet?

Good news that this issue was fixed with these two commits, so why it still happen for you:

Probably because of your 100D is asking to set date/time each time I guess on startup?
At this moment, I am guessing that crop_rec.c is making calls to change zoom mode (outside LV or when LV isn't fully configured yet), the added "msleep(700);" delay isn't enough is this case.

-Test to try:
Swtich camera from OFF to Photo mode first, set date/time (or just press cancel) then switch it to movie mode, try recording in 4.8K with same settings, does it crash?

Also please consider to report any problem related to crop mood build in Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D) thread to keep things more organised.
I might lock my previous threads for my previous 100D / 650D / 700D custom builds, and keep them as archive (I will no longer support them).

The crashes you are having are related to crop mood module because of changing preview configuration or in other words something related to LiveView (that what I can tell from this log).
Please share your ML settings, which preset exactly are you using at which aspect ratio (from crop mood menu)? Do all crop mood presets cause crashes?

The SD card isn't related to camera crashes (lock up) in this case.

Customize buttons only work while crop mood is active and in normal preview.

Personally I don't have plans to work on in camera real-time MLV playback,
but I believe it might be possible if we understand how camera image processing engines work (i.e hardware accelerators), e.g the camera can already process RAW data in real-time in LiveView.

The laggy preview is called "Framing" preview, and what are you having is normal. In Danne build only presets with "frtp" has full real-time preview, other presets have cropped real-time preview and as result, Danne made these presets to prefer "Framing" preview instead of cropped real-time one (iirc you can change that in RAW video submenu).

There is new recent ML build version which is called "crop mood", basically this build bring full real-time preview to mostly all crop mode presets:
Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)

Please share a video which shows the issue you are having.

Thanks for the test, so EOS M with Sandisk Extreme Pro R200/W140 at 240 MHz didn't drop to 21 MB/s in all tests unlike 650D?
If yes, that's because 240 MHz preset configuration on EOS M is different from the one on 650D:

1- Hyprid method was used on EOS M i.e 240 MHz for write and 192 MHz for read while on 650D it's 240 MHz in both write/read
2- 240 MHz preset on EOS M is different from the one on 650D (I mean registers values in this case).

I think it worth adding an option to toggle among "240 MHz" and "240 MHz (H)" presets for 650D / 700D, "240 MHz (H)" could be more stable on some SD cards.

@ouzijoe

Thanks for the log, I need another one but this time:

-Keep "Show" set to "Everything"
-Keep "ENGIO Registers" turned OFF

And the follow other steps in the video and previous post.

Please upload it to another host like Google Drive (or send it through Discord). The file get deleted from "file.io" after one download attempt? and you are sharing the download link in public.

https://file.io/6TQSuJuHzLwU here is the log

I came too late? The file was deleted and I can't download it.

is there or no pixel maps for crop mood resolution??

Currently there is no focus pixels maps for crop mood presets on 100D.

[EOS M]

@Walter

Thanks for the tests, so it does drop to 21 MB/s after some time with SDR104?
Could you try the same test but this time on EOS M instead of 650D using the same SD card? Is it stable there?

[now]

@ouzijoe

Thanks for the clip, related issue.

For now, I want to look into your 100D registers, please follow this guide:

Tests:

1- Let me take a look into your 100D registers:

-Download this adtg_gui.mo, put it in ML/modules folder in SD card
-Unload all modules, and load only adtg_gui.mo, restart camera
-Set video mode to 1080p24 to gain extra speed

-Follow the following video, you can see in the video I am entering Canon menu and toggling between x1/x5/x10 modes, you should do that too to let "ADTG registers" bring the registers into it:
https://www.youtube.com/watch?v=Q-Tdu9YZ4fc

-After you finish, you will find "adtg.log" file in ML/LOGS folder in SD card, upload it somewhere and share it.

One last thing, i got frequent lines on my pictures, i have understood that it may comes for underexposure? is there a way to avoid them?

Hi @ouzijoe, which ML build are you using?
Also, could you share short MLV sample have the problem?