Messages

I think yes , from waza comments there more then just the crop_rec code that was changed .

Here , in "NOTES for developers: " You can find where i change the code other than in crop_rec module:

https://www.magiclantern.fm/forum/index.php?topic=19336.msg205624#msg205624

Sorry, always without more time to help....

Hello Danne,

Hacking the hack. Let's take one of the builds from first post:

It contains a single file: crop_rec.mo. Put it in your magic-lantern/modules directory and run:

Code Select Expand


./module_hginfo_dump.sh crop_rec.mo


Result:

Code Select Expand


Build date  : 2019-04-05 04:19:36 UTC
Build user  : david@reddeercity

diff -r 8bfbb0ca228e modules/crop_rec/crop_rec.c
...
< what follows is the complete source code of crop_rec, displayed as diff from changeset 8bfbb0ca228e >


Changeset 8bfbb0ca228e is public (exactly where reddeercity indicated). The diff embedded in the binary module (crop_rec.mo in our case) contains all changes to that module, since the reference changeset.

Et voilà, you've got the complete source code.

So , it's seem that  reddeercity worked on a clone of my repository. As apparently we can not speak about this subject with him we must do archaeology of code.
And to avoid triggering his anger, I suggest you do not talk to him about it.

I believe but I am not sure that since then, the only changes it makes is found in the crop_rec module.
This implementation of crop_rec for 5D2 is so the last time we have trace of a complete source code.
I do not have enough time to dig through the whole thread but it would be really nice to have a summary of the registry changes to get the progress that reddeercity  found:

2624x1200 @ 23.976 fps with the full vertical heigh
4096x590 (Anamorphic 4096x1770) @ 23.976 fps
....and other things that don't remember.

These only in these conditions I could easily update the source code.

When I coded the crop_rec module for 5D2, I pushed the value of the registers to the maximum.
And I was horrified by the strange final result that the format was 2.66 (2880/1080).
But when I see this beautiful artistic work, I think that 2.66 is not so bad!
Bravo!

@ reddeercity

Great job with fps !

"EOS_S_GIGIL"

Same thing for me...

OK , thanks.
I just use the cf card benchmark and I get between 30-40 Mb/s while the 5d2 is rather 70-80 Mb/s. (value under red icon foe example)
I wonder what's going on?

I noticed that the speed of writing (under the red icon of the top) varies according to the frame rate.
I do not use the card benchmarks speed test yet, but is it normal that the speed of writing depends on the frame rate?

I have not 5D2  ROM disassembly to compare but when i see this :

There's no reference to any mode higher then "cfa4.0" on 5D3.

I think it's a good news.

Could we think that "500" for 5D2 and "496" for 5D3 can be interpret as  parameters passed to function  "Set UDMA( Mode=%d )" ?

For 0xC062850C -> 100 , I have already tested and 5D2 freeze.

Please, What are the problems fixed here?

1 - The size of the preview (before or during the recording)?
2 - The preview is frozen or very slow ((before or during recording)?
3 - Bad previewing with artefacts (before or during recording)?

(On 5D2 the only issue (for me) is that the preview is too slow )

Thanks.

wonderful!

I just tested and, for me, I see 2 big improvements:

1. The preview is much better.
2. 10 and 12 bits works in zoom x1 mode. (until now only worked for me in x5)

I will try to understand how it work and see what it gives in my experimental  crop_rec_4k_5D2 branch.

@A1ex

Can you try 102 or 201?

yes but nothing change.

But with the value of  1000102,  I have get a big improvement of around 30% speed write.
Sadly , this corrupt the card filesystem .  ( i can't read mlv file in card and i must format the card if i try to delete it)


........hey , reddeercity, do you hear this? 

I used DIGIC POKE to simply modify this values I found in  http://magiclantern.wikia.com/wiki/Register_Map#CFDMA :

0xC062850C --> 0x1213 and I obtain UDMA 0 speed (around 15MB/s)
                     --> ...........
                     --> ...........
                     -->0x0202 and I obtain UDMA 6 speed (around 80MB/s) i suppose original value
                     -->0x0101 and sadly I obtain UDMA 6 speed  too

OK, i added all this in my list of more and more things to do.
My version of crop_rec is essentially based on things known for a long time (see here for reminder)
I also think that A1ex seemed to be about to rewrite a crop-rec module that will work for 5D2 and probably more academically than I could do it.
With changes I do not know:

ADTG [100C]                                      -> I still do not see it (I guess good for the size)
C0F07150 and C0F0713C                  -> which does not change in with the code of the current crop_rec (possibly using adtg_gui.  I suppose good for the height)
"raw_lv_setedmac_patch" solution? -> with or without CONFIG_EDMAC_SLURP? (I guess good for the memory)

@Reddeercity

Ok, so,  if I understand ( my English is difficult) correctly:

with crop_rec , you can't change ISO settings and you have a black screen when you connect HDMi object?

question:
Is this the same when we use a 5D3 (with his crop_rec enabled)?

I need to know this for investigation , thanks.

Good Idea , it's noted in TODO list

@Danne
Thanks , I do not know this . I'll try to understand.
This is it is noted in TODO list

@reddeercity
thanks for this detailed feedback!

if you can fix the compiling problem/error in mlv_lite

yes , I'm working on it.

Now next we need compression , that's lossless compressed raw

yes, I saw your work with A1ex but but it's not my speciality yet.

increase the CF card write speed

yes , good idea . but compressed raw wouldn't be good enough  ?

crop factor when down from almost 3 (2.8 ) to 1.95 , which mean it's more usable

yes, so, don't you think that it remains also and above a problem with frame height?

@ kwstas

Thank you for the feedback.
I'm not sure to correctly understand but :

the problem occurs while FPS override is enabled

Yes I have not alerted about this because I think it is the case for all cameras model with crop_rec module . if someone can confirm ?

freezed display while recording

the preview is bad when recording but the recording is good , no ? same thing ,  if someone can confirm wit other cameras model ?

@ a1ex

OK, thanks. I have clone  crop-rec4k branch and work on it with a copy of the adtg_gui folder of iso-research branch.
The things compile and seems to work like this and permitted a minimal  crop_work module to work, but:

adtg[100c] is not present even if i refresh livevew or go to play mode and back or go to x5 an go to play mode and...and.. ...nothing ...nothing.

C0F0713C  and C0F07150  i pray for  it won't lock up but god was not in my build.....

it's why , i would like to know, if it's possible:
 
1 - what is exactly the reference of your commit.
2 - Also, if you are currently using your "raw_lv_setedmac_patch" solution?
3 - if yes , is this solution works only with CONFIG_EDMAC_RAW_SLURP
4- And because I'm a little lost , what this solution does concretely.

@reddeercity

happy birthday anyway!

@kwstas

Do you use the new download link ? what is the problem ? have you apply my recommanded settings ?

....some unnecessary deleted modes at the moment in the crop_rec module :

new link : magiclantern-Nightly.2018Sep02.5D2212.zip

@ a1ex
Do you see a ADTG[100C] with adtg_ gui ? i'don't see it with 5D2.

@reddeercity
i have tried to simply copy the files from the adtg_gui folder of iso-research into the crop_rec_4k branch. it seems to work.

[SETTINGS:]

I have the same problem with C0F07150 and C0F0713C I can't override them correctly in my implementation of a 
crop_rec module for 5D2. Maybe that's why I'm limited in height

A few month ago i posted a dng with a promising size from my experiences in "dm-spy-experiments" branch.
It took a lot of time to implement this method in a module of crop_rec_4k branch.
I've seen that Reddeercity spend a lot of time time here, it's encouraged me to continue
 
for the moment only "CROP_PRESET_3X" and "CROP_PRESET_CENTER_Z".For those who want to test the code is there:

https://bitbucket.org/waza57/magic-lantern/src/crop_rec_4k_5D2/
Download link:
magiclantern-Nightly.2018Sep02.5D2212.zip
 
I hope it will be useful. It works for me but at your own risk (Digic poke is enable don't use it if you do not know what you are doing)

SETTINGS:
   
      Canon menu : NTSC 30
      ML menu    : set resolution to maximum ,  preview grayscal
      Modules to load: crop-rec, mlv play, mlv rec, silent
   
NOTES for developers:

I don't use CONFIG_EDMAC_RAW_SLURP.

I started from this:
https://www.magiclantern.fm/forum/index.php?topic=10111.msg123909#msg123909

https://www.magiclantern.fm/forum/index.php?topic=10111.msg125581#msg125581

And especially this where i decide to try increment height with patching ROM addresses.
https://www.magiclantern.fm/forum/index.php?topic=19336.msg183200#msg183200

Thanks to GREG!

For crop_rec.mo works i need to make change in functions of:

raw.c
          "raw_lv_get_resolution" ->  ...uint32_t top_left  = shamem_read(0xC0F06800)... to retrieve the size like this
          "autodetect_black_level"->  disabled,  otherwise  i got "raw detect error"
          "#define BLACK_LEVEL 1792"  otherwise bad black level
         
edmac-memcpy.c , fio-ml.c
          I need to disable call to function "clean_d_cache()" otherwise i can't patch ROM addresses

lv-img-engio.c
          I need to add this otherwise impossible to compile : "if defined(FEATURE_EXPO_ISO_DIGIC) && defined(CONFIG_EDMAC_RAW_SLURP)"
         
Thanks to a1ex for this project, without him, I would never have discovered the joys of programming in C.

TODO list:

- Increase height frame.
- mlv_lite module compilation.
- Compressed raw activation. ( new idea here too :Danne Idea )
- Shutter speed question ( is this bad?)
- compatibility with Dual_iso module question.
- ISO adjustment activation (https://www.magiclantern.fm/forum/index.php?topic=19336.msg205719#msg205719)
- Faulty HDMI connection
- Bad preview solution

* And all i will notice in your feedback

@xaint

Tried again, still get the ad link, but I downloaded the module.

On my 5D3 I get an error "No info structure found(addr 0x0).



   

You must try:
the name of module all in lowercase
report it in Makefile.modules.default

Code Select Expand

hg add astro.c
then  :

Code Select Expand

hg commit -m "your message info"
After this you can try to compile the module

Sorry but i don't understand nothing about pink highlight.
it's comes with 5D2 ?

Thanks,

Changes are in branch: dual_iso_video_5d2 in my repository. (crop_rec_4k_5D2 i s for experiment but not complete)

I made pull request on "unified" but perhaps a mistake, i don't know.

Thanks,
yes, I have an account.
I had created a new branch (dual_iso_video_5d2 ) from a fork the 2016-03-13
I  only made changes in dual_ISO.c file.
What next for a pull request ?

reddeercity, Thanks for that but it seems timer B don't increase height like with other models.

I tried a lot of things but nothing works.

Perhaps ADTG [8xxx] but unfortunately I don't succeed to see it with adtg-gui module in 5D2.

An example :


how to delete mint account


effective width: 2840
effective height: 1082

http://www.adapteo.fr/images/M17-0638_000000.dng