Messages

Hey guys, I think I have discover what's wrong with my tests !

Before, for build 02apr and 23 aug, i always use the ISO tweak :

ML Digital ISO : -0.3 EV

When it's enabled for previous builds like 02apr, it's work well on Resolve, dont see any bad highlight.

But when I enabled it on the new 23aug it's make wrong pink highlight recovery in Resolve.
Then I disabled it, and i didnt see any pink highlight issue.

I will share shorts MLV to my differents tests

EDIT:

In waiting to upload MLV files, i have seen some bad pixels in my footage, even if fixed by MLV_dump.

e.g: It's visible in top of my previous footage, but in my next footage it will be more revelant.



Is there a solution for a more agressive cold pixels fix with mlv_dump ?

I just tired with MLV_viewer 1.4.3, the CP fix is best, i dont see any bad pixels.

I have tested raw2cdng1.6.5:
magiclantern-crop3x.2016Apr02.5D3113.zip - Crop 1:1 and No crop modes - There are NO Hot pixels.
magiclantern-crop3x.2016Aug23.5D3113.zip - Crop 1:1 and No crop modes - There are  Hot pixels.

You have to use MLVViewer or Mlv_dump (with the commande line "--fixcp")/MLVFS for remove them.

In those tests. I intentionally overexposed scenes. I always use zebra for check HL. But even if i get overexposed footage with previous build i never met this issue before.

I dont think it's generated by hazard or bad exposure.

I will now made news tests and made a new comparison, always with intentional  overexposed footage.

Ok i understand !

Here the short MLV from this post.

https://www.dropbox.com/s/twrai93wv5zdler/M24-1019_23aug_light.MLV?dl=0

[mlv_dump -o new.MLV -f 5 [drag/your/MLV/file/here]]

Ok, so selected BMD and pink highlights are appearing. How can you rule out that it isn,t resolve doing a bad job here?

The pink color in highlight is worse when I use cinelog-C or if i put REC709 in color space (yes usually we don't need to use rec709 for raw, but it's just more revelant for this issue.)

For the last dng file I doubt it has anything to do with the builds. Test working with it in acr and you,ll see both dng files works great.  For the dual iso dng file with white level around 65535 isn,t this caused by raw2cdng? Could you film the same sequence with two different builds?
*For some reason raw2cdng won,t let me overwrite white level in the dng example. 

I will do a second test with 2 differents builds yes, but what about your tests ? You don't met the same issue than me on Resolve with footage in highlight ?

white level around 65535 isn,t this caused by raw2cdng?

I did the test with MLV_dump it's the same problem.

Could you upoad the dual iso MLV file example? You could shorten the actual MLV file with mlv_dump like this.
mlv_dump -o new.MLV -f 5 [drag/your/MLV/file/here] hit enter

See to it that you create a different output name (where I put in the name new.MLV) than the name of the original MLV file or mlv_dump will overwrite your original file.

Here the short MLV :

https://www.dropbox.com/s/jr6viin3g2d6vk0/new.MLV?dl=0

but i don't understand what you mean about "dual iso MLV" ? I don't shot any video in dual iso with the new build. (I never use dual iso)

ps: Sorry if my English is approximative, I try to do my best to answer you.

I'm back with news tests. Today i shot some footage ,as usually, in ETTR / 200 iso / 1/48 shutter speed / WB = sunlight.

I still get weird hightligt recovery in Resolve, with this pink color. I never get this before the 23aug crop build.

With the 02apr crop build, when i get pink color in highlight, i'm able to erase it with changing balance color/ tint options, but not with the 23aug build, it's like "frozen" on this pink color.

I can't really know what option/configuration is the cause of this issue

Here a DNG sample convert with mlv_dump (i removed bad pixels with it too) :


https://www.dropbox.com/s/vwssn3aup1mvojf/M27-1808_000000.dng?dl=0

EDIT : in waiting to find a solution ,  it is possible to use the qualifer option for fix it in Resolve.

You can.

Thanks I did not know there was a windows version !

DNG from mlv_dump here :

https://www.dropbox.com/s/twruf4cc9jbsr9p/M24-1019_23aug_frame_000000.dng?dl=0

Well, you've got a DNG with the white level incorrect. Can you find out what settings trigger the issue?

It will be a long and laborious work for find it

But i will try because i want see this new build working well

I can't use mlv_dump, i don't work on MAC, and MLVFS don't work well with my PC (this is why i use raw2cdng)

But i have upload MLV, if someone has the courage to download 700 mb ..

I will made others test with highligt and see and see how it goes.


EDIT :

I don't expect this issue because I didn't change the register configuration. The problem might be random and appearing on both builds - can you rule out this case?

After have done some new tests i think it was a false alert too, especially if you have not changed the portion of code that might generate this error, but in case I prefer to report if others people encounter this problem.

Yes i always work with DNG files in Resolve.

Here DNG from  02 apr and 23 aug builds

https://www.dropbox.com/s/lc7w0caliwc55s1/M24-1019_23augapr00000.dng?dl=0

https://www.dropbox.com/s/2xwo4w3jtepm9hl/M24-1024_2apr00000.dng?dl=0

MLV :

https://www.dropbox.com/s/h4nbsqkujmil6ue/M24-1019_23augapr.MLV?dl=0

https://www.dropbox.com/s/e6igo1ivfo97b4g/M24-1024_2apr.MLV?dl=0

With level is the same for both : 65535
Extraction was done with raw2cdng 1.7.5

I just discover an issue between the 2 april and 23 aug version.

I can't properly recovery  hightlight with the 23aug version in Resolve, highlight stay pink.

Exemple :


02 april build


23aug build


With the same setting (Balance color, tint etc..)

I love these style of works it's quiet, just contemplative, the sound design is well composing, good color grading. Well done.

It could be more interesting to know your workflow, what software and LUTs did you use etc ..

@chmee

Do you think it's possible for you if you have time to design a new version of raw2cdng with the "bad pixels" fix option ?

I'm asking you this feature request in reference to those links and the new vertical stripes fix :

https://bitbucket.org/hudson/magic-lantern/pull-requests/732/5d3-attempt-to-fix-vertical-stripes-so-it/diff

Since the bad pixels are easier and faster to correct in postprocessing, what about choosing the image with bad pixels, but without stripes?

http://www.magiclantern.fm/forum/index.php?topic=17021.msg171179#msg171179

Your converter software is for me the more practice and fast in personnal and pro use, hope it will possible !

Thanks you !

Do you think it will be possible to design a new version of raw2cdng with the option to correct the bad pixels ?
Unless this is already the case but I did not see the option provided for this purpose ..

Since the vertical stripe fix is in camera, you must not also correct it in post-processing. I thought this was obvious.
For the bad pixels, can you try MLVFS or mlv_dump?

Yes i know, but i did the test with vertical stripes correction ON and OFF with raw2cdng 1.7.5 and MLV file from 23aug build, there is really no difference.


Vertical banding correction : On



Vertical banding correction : Off


MLVFS make my computer crashing, i'm not on my computer's work, it's my laptop for this time, i will try later. But i can already say bad pixels are gone very well with MlRawViewer v1.4.3

crop3x.2016Apr02.5D3113
Extract MLV with raw2cdng v 1.7.5 | Vertical banding correction : On
1920x1080 | 200 ISO




crop3x.2016Aug23.5D3113
Extract MLV with raw2cdng v 1.7.5 | Vertical banding correction : On
1920x1080 | 200 ISO



crop3x.2016Aug23.5D3113
Extract MLV with raw2cdng v 1.7.5 | Vertical banding correction : On
PixelPatcher OFX : On
1920x1080 | 200 ISO
(red arrow are showing PixelPatcher traces issues)



The test was did without crop mode, but i can do the same with it.

What software did you use for raw conversion? I thought most of them already handle bad pixels very well.

What softwares do you have in mind for correct bad pixels ? I always use raw2cdng 1.7.5 but i dont saw any options for correct it.

I just did a test,

You can see the video there : https://vimeo.com/180011454

pass : ML

Of course images are overexposed and underexposed for a best view of the stripes, it's not a final grade.

Hope it will help.

My conclusion is, the vertical stripes fix is working, the strips are softer. But in fact, it is invaded by the evil pixels. Is there a more effective solution than PixelPatcher that leaves no trace after correction ?

Thanks you A1ex,  im impatient to test it tommorow !

Just for show for users who don't know what we mean about this issue, i did screenshot who explain what are vericals stripes.



Of course for this result, i forced the contrast in Resolve for a best view of this issue.

In my opinion, the best fix is this, but since I've got zero feedback on it, it's not included in the main builds. I'll probably make a test build with the crop mode included as well, since this feature caused vertical stripes in H.264, so we need to check that too.

Thanks for your help Alex,

I did not know you had already implemented a fix to solve this problem. But I do not have enough developing knowledge to provide the use or implement.

If you combine this patch/fix in any build you can trust me to try and do tests!

If this solve the problem of verical banding, the 5D Mark III RAW will simply be more than perfect.

Beautiful work and color! I am amazed by the results you get @GutterPump. Very inspiring!

Thanks for your feedback ! Now i'm feel "well" with color grading, even if i have still to learn a lot. The 5D mark III + Magic lantern is for me the best school for learn color grading with RAW footage on Resolve.

Hello !

I made a very short video that represents the beautiful beaches of Soulac-Sur-Mer in France.

Color grade in Resolve with 12.5 Koji Colors luts
Edit in Premiere Pro with Pro FilmConvert.

https://vimeo.com/179799809

ps: I has a question about verical stripe, it's more visible in the sky even if i shot in ETTR (it is not visible at first glance but there's some traces when i force too much on the contrasts in Resolve) . I use neat video for fix it when it's too visible, but you know any best solutions for prevent this issue ?

I use the crop build from 2 april 2016.

Yep. If the buffer limitation isnt the same than the mk III, we can expect best RAW performances even if we cant expect CFast fonction..

Im already in hope to see others Magic Lantern miracles on the 5D mark IV

but has anyone found an easy/quick fix for the pink highlights that occur on occasion?

I use the hightlight recovery into resolve and when i see these pink color in highlight i usually move a bit the white balance with tint for eliminate/reduce it.

I asked myself the same question, but I think Alex is waiting to learn more with tests to be able to implement it in a stable release.

I personally use continually this mod without any problems.

Beautiful shots, well done !