Messages

@kichetof
Edit #2: (also @moocowe ) i've got it working. Just install this package that i found in the original post from a1ex. It probably needs this to preform: https://bitbucket.org/a_d_/magic-lantern/downloads/OSX_cr2hdr.zip Just run the cr2hdr package and than simply open lightroom to use the export cr2hdr from kichetof.

Yeah great!!

I know the problem. You had not dcraw and/or exiftool installed on your mac
I'll add a note for the next release !

Thanks for your investigation and the solution

@hdm @moocowe

Do you buy lightroom from Mac App Store? Maybe this is the problem. Could you check your privacy rules (under Mac settings (I don't remember the exact name) and enable to run program from any developer (not recommended but only for testing) and let me known

Export a dng will display already treated!

I'm going to rewrite the plugin and change the check for already treated!

Stay tuned! I hope this weekend

If the DNG was already processed, it will be tagged with Dual-ISO.

However, telling whether a CR2 or DNG is interlaced is not easy (it's a heuristic, and the one from cr2hdr is not perfect).

Yeah good point ! I can read the label of the file and reimport if not tagged ! Thanks a1ex !

However, the original cr2hdr can process the .dng file too.

Good point !
I'll add to the next release !

I rewrite the plugin, so I think it's for this weekend

------------

Okay, if a dng is sended to cr2hdr, it'll write the output with same name. I need to see how to make it nicely (maybe disable check if dual iso already treated)

With dng support, I can't check if file doesn't have interlaced iso without read text file ... I think I'll not add support for dng file or find an elegant way to check if dng and if interlaced iso found. I add it to the todo list

I just ran exports in several export operations. Tried running 5 exports simultaneously of cr2 to dng and they work in parallell that way. Occassionally I get a pop up window telling me an internal error has occured but it exports anyway so I just ignored and synchronized the folder when finished.

The error code


*It appears the error code does indeed affect some pictures only getting halfway through the process so Running several export operations simultaneously isn,t stable.

Fix it

Update to v1.0.3

[140302-1584-320ASA-Max-Mustermann-00491739900599.CR2]

My filenames HAVE unique numbers, but are rather long (;-) f.i.  140302-1584-320ASA-Max-Mustermann-00491739900599.CR2 '1584' is the unique number.

Your plugin seems to CUT the filename; if it won't cut the filename and only would add '-dual-iso-1[number consecutively
].dng' at the END of the filename everything would be ok...

Solved it ! Download v1.0.2 from first post

Work's fine to me on LR 5.3 (Win8 64bit). Very fast, FYI.

I made a Portuguese (BR) translation: http://textuploader.com/1wvb/raw

Thanks for this translation!

I commit it and I'll update plugin when I find a way to solve fotogemeinschaft_de problem.
You can download Portuguese BR or Portuguese PT and place it into cr2hdr.lrplugin for the moment

After the first export (which was ok) I always get the following error with every other Picture:

'Already treated' - 'The File xy has already converted to dual iso'
(LR 5.2)

In fact the file was NOT converted.

I have found the reason for this behaviour by myself: The plugin doesn't add numbers to the converted files; my filenames are rather long and the plugin therefore produces always the same filenames in the same directory.

After every single conversion I have to rename the converted file manually. A batch-job will therefore not be possible but nevertheless the integration in LR is great..

Ralf

Ok I know what you're this problem. My export template rename the file with "dualiso_xxxx.cr2" but if your originale name doesn't has number, the export plugin can't add to the destination.
I'll try to resolve it !

Note that I copied over new versions of cr2hdr.exe (I used the 20 bit version), exiftool.exe (9.54) and dcraw.exe (9.20) since the included ones appear to be quite old?

Updated !

here the german translation:
http://upload.g3gg0.de/pub_files/cf7f49e55e19749234d19593907c5785/TranslatedStrings_de.txt

Thanks for this translation!

Here is the updated code incorporating the above changes:

Code Select Expand


command = string.format('"start /D "%s\\bin" /B /WAIT /BELOWNORMAL cr2hdr.exe "%s" ^> "%s""', pluginPath, filePath, output)


Yeaaaah !! Big thanks for that !!! (I'm more comfortable with a shell terminal)

I wonder if there is a way to run multiple cr2hdr conversions in parallel? Also since I'm not really interested in having the log files left behind, I've removed that feature from my copy. Maybe there's a way to make it optional. I know additional settings can be added to the Plugin Manager dialog though I haven't looked into how to do that yet.

I don't know how to make it, but I'll read the lightroom SDK to find it

I just ran exports in several export operations. Tried running 5 exports simultaneously of cr2 to dng and they work in parallell that way. Occassionally I get a pop up window telling me an internal error has occured but it exports anyway so I just ignored and synchronized the folder when finished.

The error code


*It appears the error code does indeed affect some pictures only getting halfway through the process so Running several export operations simultaneously isn,t stable.

Thanks for this try ! I'll investigate how to make it possible!

New version 1.0.1, I'll update first post soon !

[thanks]

a big lol from my side when reading that post. why?

tonight i sat in front of the adobe SDK because i wanted to make dual iso files usable straight out of LR.
the intermediate step was just too inconvinient if you gave a graphical workflow.
then i decided, this is not a simple task if you never made a LR plugin. so i stopped since i didnt want to spend a week.
(i thought the right way is to generate a proxy file and using custom extensions)
i hoped that someone would come up with a proper solution.

and three hours after i stopped reading the SDK and example plugins you posted exactly what i was looking for.
wow, this was a perfect timing

thanks for this cool plugin, im gonna try it!

I'm happy to help you! For one time it's me who can help you!

Thank you all for your feedback! I appreciate

I'm glad that this plugin makes your workflow easier!!

So, my workflow is Mac and it's really more simple to write shell command on it!

I spent a lot of hours to find a way to launch the command on windows and I'll find a way to optimise it! (see my post on dev ml forum and Lightroom discussion)
To windows users:

Could you add before LrTasks.execute (where cr2hdr.exe is call): mlLog:debug(command)
And paste result from windbg or anything else debugger

Could you add /B and/or /MIN after /WAIT on windows command var and tell me if it's more user friendly

Normally all path are escaped so I don't understand why you don't have output file!

I'll update dcraw and exiftool (forget to commit new version)

Thank you for deutsch translation! I'll add it tomorrow

If you're a pro with lua and Lightroom sdk feel free to help me to make code more robust

[Lightroom Dual ISO Plugin]

Lightroom Dual ISO Plugin

This plugin allows you to convert Dual ISO picture from Lightroom directly to cr2hdr tools.

Lightroom v4 and more is needed.







How to use:

• Default settings
  
  • Right click on one or multiple selected pictures
    
    • Select : Dual ISO Converter (cr2hdr) (this option uses default settings, see below)
• Custom settings
  
  • Launch the Export Window
    
    • Right click on one or multiple selected pictures
      
      • Export selected photo(s)
    • Shortcuts
      
      • Windows: Ctrl + Shift + E / Mac: Command + Shift + E
  • Change what you want

Default settings:

> Plugin settings:

• Add suffix -dualiso to the output file
  
• Synchronize keywords with original picture
  
• Reject original picture (flag unmarked)
  
• Add converted file to all collections of the original
  
• No subfolder
  
• Show summary message
  
• Keep log file
  
• No keywords added by user (Dual-ISO is added by cr2hdr)
  
• No label defined
  

> cr2hdr settings:

• --amaze
  
• --cs2x2
  
• --no-bad-pix
  
• --fullres
  
• --alias-map
  
• --stripe-fix
  
• --wb=graymax (cr2hdr 20bit)
  

This plugin is translate in english, french, german, portuguese and swedish. (feel free to send me a translated file).



/!\ DEV /!\ Download the lastest version of Lightroom Dual ISO Converter (cr2hdr) plugin (dev version).



How the plugin works:

• Pictures selected to export are listed
  
• Only CR2 and DNG files are supported (if file is not present, skip)
  
• Each picture, one by one is converted with cr2hdr (with defaults or custom args)
  
  • if cr2hdr 20bit and --same-levels are selected, all pictures are converted in the same time
• Picture is moved to subfolder
  
• Picture is renamed with suffix
  
• Picture is imported into Lightroom catalog
  
• Label is added
  
• Keywords are added (and created if needed)
  
• Synchronize keywords with original file
  
• Keyword Dual ISO raw or no Dual ISO is added to original file
  
• Parse log file to fill metadata with cr2hdr results
  
• Add picture to all collections
  
• Keep or remove log file
  
• Set the flag of the original file
  

How to install this plugin:

To install this plugin, extract zip and save folder cr2hdr.lrplugin where you want.
(Don't use hyphen mark "-" in path. This is an Adobe bug.)

On Lightroom, open the Plug-In Manager (shortcut Win: Ctrl + Alt + Shift + , (comma), Mac: Command + Option + Shift + , (comma)) and install it.

You can follow instructions from Adobe.



Follow the projet on Magic Lantern Forum.

Contribute to the code on Bitbucket.

This plugin is distributed under the GNU GPL v2.



Changelogs:

2014-09-30 v3.0 BETA 3

• fix bug with cr2hdr command on windows
  

2014-09-22 v3.0 BETA 2

• fix bug with subfolder
  
• fix bug with same-levels
  

2014-09-13 v3.0 BETA

• Rewrite processing (no unnecessary export)
  
• Update cr2hdr 20bit to 0eabcb0
  
• cr2hdr 20bit --same-levels argument supported
  
• Added keywords Dual ISO raw or no Dual ISO to original file (speedup process and sorting in LR)
  
• Synchronize keywords with original file
  
• Convert tabs with 4 space
  
• fix some bugs
  
• (change editor text: Brackets before Smultron/TextMate)
  
• (change Mercurial CLI to GUI: TortoiseHG for Mac)
  

2014-04-21 - 2014-09-12 v2.2 BETA

• Added cr2hdr args
  
• Added cr2hdr 20bit support
  
• Added metadata with cr2hdr results (big thanks akry)
  
• Added keywords
  
• Added color label
  
• Added flag rejection
  
• Restore default plugin settings
  

2014-03-27 v2.1

• Export to subfolder
  
• redesign ui
  

2014-03-26 v2.0.2

• Correct portuguese translation (thanks Luiz)
  

2014-03-26 v2.0.1

• Remove extern functions
  
• Works on Windows
  

2014-03-25 v2.0

• New export window
  
• DNG file supported
  
• Custom user settings (suffix, label, add to collection, remove logfile)
  
• Mac: check dependencies
  

2014-03-19 v1.0.3

• Fix multiple instance of cr2hdr (thanks Rob Cole from Adobe forums)
  

2014-03-19 v1.0.2

• Add portuguese translation (thanks Luiz Roberto dos Santos)
  
• Change output name (solve fotogemeinschaft_de problem with export name)
  

2014-03-19 v1.0.1

• Add german translation (thanks g3gg0 et Walter)
  
• Update dcraw (9.20) and exiftool (9.54)
  
• Windows command run without CMD visible (thanks chris_overseas)
  

2014-03-18 v1.0

• First release (Mac fully compatible, Windows need some optimisation)
  

Solved it ! Sorry !

---------------------------------------------------------------------------------

thanks dmilligan, I don't think to report it on adobe!

To follow http://forums.adobe.com/message/6217975

Yeah thanks chris & a1ex !!

After a long follow on bitbucket it's here now !!
Great thanks a lot!

Like on bitbucket issues, canon overlay on lv it's always present and dualiso module doesn't change the custom prefix of the file.

I'll investigate to solve these issues

Hi everybody,

I'm learning Lua coding, especially Lightroom Lua.

I've made a command which works on mac, but doesn't work on windows.

Code Select Expand


--pluginPath = path of the plugin like ~/plugin.lrplugin/
-- filePath = path of the image like ~/image.cr2
-- filePath = path of output command like ~/image.txt

local binExe = 'start ' .. pluginPath .. '\\bin\\convert.exe'
if MAC_ENV then
-- exec path for Mac (& force language to english; seem to be unnecessary LANG=C LC_ALL=C LANGUAGE=en)
binExe = 'exec "' .. pluginPath .. '/bin/convert" '
end
command = binExe .. '"' .. filePath .. '" > "' .. output .. '"'

result = LrTasks.execute(command)



Does anyone have the solution for fix that ?

When you or me will solve this problem, be sure you'll happy
Enjoy
Tof

Great works !!

(now I just need a script to dump the ppms to an animated gif...)

http://jupiter.ethz.ch/~pjt/makingMovies.html

Code Select Expand

convert -delay 20 test*ppm movie.gif

It's work fine (ok I'm happy for that).

I see what you said, it's always active. I'll try tomorrow

Thanks a1ex!

I don't think to diff files.

diff:

Code Select Expand


$ diff magic-lantern/src/electronic_level.c magic-lantern-tof/src/electronic_level.c
14c14,15
< #include "asm.h"
---
> #include "asm.h"
> #include "lvinfo.h"
79,80c80,81
<     if (angle10 > 1800) angle10 -= 3600;
<     bmp_printf(FONT_MED, 0, 35, "%s%3d", angle10 < 0 ? "-" : angle10 > 0 ? "+" : " ", ABS(angle10/10));
---
>     //if (angle10 > 1800) angle10 -= 3600;
>     //bmp_printf(FONT_MED, 0, 35, "%s%3d", angle10 < 0 ? "-" : angle10 > 0 ? "+" : " ", ABS(angle10/10));
81a83,110
>
> static LVINFO_UPDATE_FUNC(electronic_level_update)
> {
>     LVINFO_BUFFER(8);
>     int angle10 = (level_data.roll_sensor1 * 256 + level_data.roll_sensor2) / 10;
>     if (angle10 > 1800) angle10 -= 3600;
>     snprintf(buffer, sizeof(buffer), "%s%3d", angle10 < 0 ? "-" : angle10 > 0 ? "+" : " ", ABS(angle10/10));
>     
>     item->color_fg = angle10 == 0 ? COLOR_GREEN1 : COLOR_WHITE;
>     
> }
>
> static struct lvinfo_item info_items[] = {
>     {
>         .name = "Electronic level",
>         .which_bar = LV_TOP_BAR_ONLY,
>         .update = electronic_level_update,
>         .preferred_position = -100,
>         .priority = -1,
>     },
> };
>
> static void electronic_level_init()
> {
>     lvinfo_add_items(info_items, COUNT(info_items));
> }
>
> INIT_FUNC("electronic_level_info", electronic_level_init);


Hi everybody,

I'd like to put electronic level number to Bars facelift.
I've made some modifications to electronic_level.c but I don't want to make a mistake on my dslr.

This is the code, could you please check if it's right ?

Please be cool, it's my first modification on the source and I learn slowly

Code Select Expand




#include "dryos.h"
#include "bmp.h"
#include "tasks.h"
#include "debug.h"
#include "menu.h"
#include "property.h"
#include "config.h"
#include "gui.h"
#include "lens.h"
#include "version.h"
#include "edmac.h"
#include "asm.h"
#include "lvinfo.h" // added lvinfo.h

#ifdef CONFIG_ELECTRONIC_LEVEL

struct rolling_pitching
{
    uint8_t status;
    uint8_t cameraposture;
    uint8_t roll_sensor1;
    uint8_t roll_sensor2;
    uint8_t pitch_sensor1;
    uint8_t pitch_sensor2;
};

static struct rolling_pitching level_data;

PROP_HANDLER(PROP_ROLLING_PITCHING_LEVEL)
{
    memcpy(&level_data, buf, 6);
}

static void draw_electronic_level(int angle, int prev_angle, int force_redraw)
{
    if (!force_redraw && angle == prev_angle) return;

    int x0 = os.x0 + os.x_ex/2;
    int y0 = os.y0 + os.y_ex/2;
    int r = 200;
    draw_angled_line(x0, y0, r, prev_angle, 0);
    draw_angled_line(x0+1, y0+1, r, prev_angle, 0);
    draw_angled_line(x0, y0, r, angle, (angle % 900) ? COLOR_BLACK : COLOR_GREEN1);
    draw_angled_line(x0+1, y0+1, r, angle, (angle % 900) ? COLOR_WHITE : COLOR_GREEN2);
}

void disable_electronic_level()
{
    if (level_data.status == 2)
    {
        GUI_SetRollingPitchingLevelStatus(1);
        msleep(100);
    }
}

void show_electronic_level()
{
    static int prev_angle10 = 0;
    int force_redraw = 0;
    if (level_data.status != 2)
    {
        GUI_SetRollingPitchingLevelStatus(0);
        msleep(100);
        force_redraw = 1;
    }

    static int k = 0;
    k++;
    if (k % 10 == 0) force_redraw = 1;

    int angle100 = level_data.roll_sensor1 * 256 + level_data.roll_sensor2;
    int angle10 = angle100/10;
    draw_electronic_level(angle10, prev_angle10, force_redraw);
    draw_electronic_level(angle10 + 1800, prev_angle10 + 1800, force_redraw);
    //~ draw_line(x0, y0, x0 + r * cos(angle), y0 + r * sin(angle), COLOR_BLUE);
    prev_angle10 = angle10;

    //disable printf on left top corner
    //if (angle10 > 1800) angle10 -= 3600;
    //bmp_printf(FONT_MED, 0, 35, "%s%3d", angle10 < 0 ? "-" : angle10 > 0 ? "+" : " ", ABS(angle10/10));
}

// Next, added some function for bare facelift

static LVINFO_UPDATE_FUNC(electronic_level_update)
{
    LVINFO_BUFFER(8);
    int angle10 = (level_data.roll_sensor1 * 256 + level_data.roll_sensor2) / 10;
    if (angle10 > 1800) angle10 -= 3600;
    snprintf(buffer, sizeof(buffer), "%s%3d", angle10 < 0 ? "-" : angle10 > 0 ? "+" : " ", ABS(angle10/10));
   
    item->color_fg = angle10 == 0 ? COLOR_GREEN1 : COLOR_WHITE;
   
}

static struct lvinfo_item info_items[] = {
    {
        .name = "Electronic level",
        .which_bar = LV_TOP_BAR_ONLY,
        .update = electronic_level_update,
        .preferred_position = -100,
        .priority = -1,
    },
};

static void electronic_level_init()
{
    lvinfo_add_items(info_items, COUNT(info_items));
}

INIT_FUNC("electronic_level_info", electronic_level_init);

#endif


Thank's "Audionut" for the commits, it's exactly what I think.

Thank's A1ex for your informations and the time! I'll trying to understand how to make it

I need to successfuly compile source on my mac (I had some difficulty with TL).

I'll try to find an elegant way to integrate the value of ETTR into the exif to make some generic preset for LR.
I need some time to understand hex and arm... respect guys !

Hi everybody,

First thing, THANK YOU !
I bought a 5dIII 3 weeks ago and 3 days ago, I installed ML on it.

Hum... it was finger in the nose! 5 minutes to install it! Thanks dev!

After a long day of shoot, I compare my new 5dIII with my old but lovely 50d with TL installed.
I noticed these changes between both (I compare only the missing or strangely thing from 5d):

• There're not advertising/warning/option to keep ML when you format card (SD or CF)
• When the image is displayed in playback mode, the "image dot" (or graph/ettr? balaying from top to bottom take a "long time" 1-2s, when ettr it's enabled, there no drawing/dot balaying. (approximatively instantly on 50d, 1% solved it (it's seem to be here), I will trace the source to find the commit)
• I just playing whit MLV Rec but I'm not a filmmaker, so I don't have a great knowledge.

Concretely, I was not lost between the 2 versions and the difference is minor. And I'm very happy! The Q button it's a real plus!

I wanted to give you my experience. I'm not very active on forum, but I follow every posts and commits

Many thanks to you Dev to perform your great work !
Tof

Hello !
This is a timelapse from Zermatt in Switzerland with a Canon 50D with ML (tragic lantern 2).

Most of shots have been taken with AETTR. I played a lot with the different settings of AETTR (Highlight ignore, SNR limits) but it's not so easy to defined the best way! I had a lot of flickering, sometimes with the same settings and the same light, same scene with one shot interval.. strange! Maybe I made a mistake with SNR limits and highlight ignore. Unfortunately, I forgot to write the settings for each shooting, so I don't remember but I was inspired by RenatoPhoto testing

Maybe add some "presets" to define the scene to take (night to day, brightness, night, cloud, ..) to automatically define the rights settings.

Expo Lock is enable to change Av with Iso

They are both off... And I still have the problem. As soon as I change the ISO value, the shutterspeed value changes...

I cant shoot anything because of this problem! Any idea how to fix this?  Really anoying and frustrating issue!!   

Maybe Expo. Lock enable?