Messages

and no cr2hdr binary.

Next stop is a search of the forums again.  Any timesaving feedback would be appreciated.

A bit more success!

I found that the following change prevents compiling cr2hdr on MacOS in my configuration..

Code Select Expand

https://bitbucket.org/hudson/magic-lantern/commits/5b78fb409ac81d2bec6b9fecdd352af26d3b27a5

I commented it completely out (the change is self consistent) and despite a slew of errors I am able to develop a binary.  When I use it to post process my photos it work but not as expected. The colors are "off".

Still this is still a work in progress, but getting closer

Thanks,
Gus

I'm working to compile cr2hdr myself - even though I found a MacOS binary online.

It looks like I worked past the following error, though I still cannot build cr2hdr so this workaround may be not be correct.

truncate: illegal option -- s
Internal error!

the problem appears to be in: magic-lanter/src/Makefile.src
two lines have the following:

Code Select Expand

@truncate -s 284 $@
and:

Code Select Expand

truncate -s 0 $@ ; \

the macports truncate command doesn't support the -s switch.  So I changed the lines to read:

Code Select Expand

@truncate $@ 284
and

Code Select Expand

truncate $@ 0 ; \
respectively.

now building the magic lantern build dies in 7D_master.203

Code Select Expand


_log truncated to save space_
make -C  /Users/foo/tmptmp/magic-lantern/platform/7D_MASTER.203
[ VERSION  ]   ../../platform/7D_MASTER.203/version.bin
[ CPP      ]   magiclantern.lds
[ AS       ]   entry.o
[ CC       ]   master_boot.o
../../platform/7D_MASTER.203/master_boot.c: In function 'master_callback':
../../platform/7D_MASTER.203/master_boot.c:161:13: error: implicit declaration of function 'ptpbuf_add' [-Werror=implicit-function-declaration]
             ptpbuf_add(0x4005, callstack, strlen(callstack));
             ^
../../platform/7D_MASTER.203/master_boot.c:177:27: warning: initialization makes pointer from integer without a cast [enabled by default]
         uint8_t *buffer = bkpt->ctx[0];
                           ^
cc1: some warnings being treated as errors
make[1]: *** [master_boot.o] Error 1
make: *** [7D_MASTER] Error 2

which I'll work on as I get time...
some cameras do get built.  If I try a make in dual_iso i get the above error

'-mno-ms-bitfields'

disabling it causes a new set of errors unfortunately. 

Code Select Expand

make
[ gcc      ]   cr2hdr
cr2hdr.c:344:34: error: use of undeclared identifier '__module_strings_MODULE_NAME'
    module_strpair_t *strings = &__module_strings_MODULE_NAME[0];
                                 ^
cr2hdr.c:1208:51: warning: if statement has empty body [-Wempty-body]
        if(system("octave --persist iso-curve.m"));
                                                  ^
cr2hdr.c:1208:51: note: put the semicolon on a separate line to silence this warning
cr2hdr.c:1587:55: warning: if statement has empty body [-Wempty-body]
        if(system("octave --persist fullres-curve.m"));
                                                      ^
cr2hdr.c:1587:55: note: put the semicolon on a separate line to silence this warning
cr2hdr.c:1919:56: warning: if statement has empty body [-Wempty-body]
            if(system("dcraw -d -r 1 1 1 1 edges.dng"));
                                                       ^
cr2hdr.c:1919:56: note: put the semicolon on a separate line to silence this warning
cr2hdr.c:1933:59: warning: if statement has empty body [-Wempty-body]
            if(system("dcraw -d -r 1 1 1 1 edge-map.dng"));
                                                          ^
cr2hdr.c:1933:59: note: put the semicolon on a separate line to silence this warning
cr2hdr.c:2264:51: warning: if statement has empty body [-Wempty-body]
        if(system("octave --persist mix-curve.m"));
                                                  ^
cr2hdr.c:2264:51: note: put the semicolon on a separate line to silence this warning
5 warnings and 1 error generated.
exiftool-bridge.c:58:9: warning: variable 'mode' is used uninitialized whenever 'if' condition
      is false [-Wsometimes-uninitialized]
    if (exif_file)
        ^~~~~~~~~
exiftool-bridge.c:70:9: note: uninitialized use occurs here
    if (mode != 0)
        ^~~~
exiftool-bridge.c:58:5: note: remove the 'if' if its condition is always true
    if (exif_file)
    ^~~~~~~~~~~~~~
exiftool-bridge.c:51:13: note: initialize the variable 'mode' to silence this warning
    int mode;
            ^
             = 0
1 warning generated.
make: *** [cr2hdr] Error 1

and no cr2hdr binary.

Next stop is a search of the forums again.  Any timesaving feedback would be appreciated.

Thanks,
Gus