Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.


Messages - dfort

Pages: [1] 2 3 ... 93
1
Camera-specific discussion / Re: ML on EOS-M2
« on: Today at 07:39:37 AM »
Took another step forward -- got a SFDATA.BIN dump from the camera. I still can't get to the ML menu so here's how I did it.

In order to load modules on startup simply add an empty file with the name of the module in the ML/SETTINGS directory. For the sf_dump module it has to be named like this:

Code: [Select]
SF_DUMP.EN
Now in order to get the module to auto run without having to start it from the Debug menu I did this hack to sf_dump_init():

Code: [Select]
//    menu_add("Debug", sf_dump_menu, COUNT(sf_dump_menu));
    sf_dump_task();
    return 0;

It also worked in QEMU but since we've been using a 100D SFDATA.BIN all that happened was that it copied the 100D file to the card image. Now I've got a "real" EOSM2 SFDATA.BIN to work with.

2
My main development system is a Mac PowerBook and since much of what I've been running in QEMU is not on the qemu branch I've had to unmount the disk image manually. Doing "make install" would trigger the "Error: please unmount the SD image." even though the disk didn't appear as a mounted volumes. Turns out that the fix was to simply "eject" instead of "unmount" -- this works great with both physical cards and disk images. According to the hdiutil man page:

Quote
NOTE: unmount does NOT detach any disk image associated with the volume.
          Images are attached and detached; volumes are mounted and unmounted.

Pull request submitted on the qemu branch.

3
Great news @martinhering -- you've been missed!

4
Are you referring to the colored area under the knobs?



These aren't focus pixels. You should get similar artifacts on the 7D (camera no focus pixels) as you do on the 100D (camera with focus pixels). That's why some ML users won't shoot without a VAF filter on their camera. Well, except for 5D3 users, note that you can't even get a VAF filter for the 5D3.

5
Camera-specific discussion / Re: ML on EOS-M2
« on: Yesterday at 10:30:33 PM »
Fixed task_dispatch_hook so it matches the changes on the 1300D and 6D. I couldn't follow the comments on the task_dispatch_hook for those cameras but I used my best pattern matching skills and also checked against the 100D and 70D so I'm pretty confident that I've got this right. By the way, the EOSM doesn't fall into the same pattern as the other cameras. Is new-dryos-task-hooks working properly on the EOSM?

In the process I also found a typo on task_trampoline and fixed it.

Code: [Select]
/** Tasks **/
NSTUB(   0x8FBE0,  task_dispatch_hook)                      // changed from 0x8FAB4 - now it doesn't work on the camera.
NSTUB(0xFFD24B44 - RAM_OFFSET,  task_create)
NSTUB(0xFFD2A1D8 - RAM_OFFSET,  task_trampoline)

However, as you can see from my comment it no longer works on the camera. LED turns on and camera won't boot up. So there must be something else that needs fixing. I know there are other things to fix. The lens focal length is displayed as 0 thought the f/stop and shutter speed is fine.

So it is one step forward and two steps back.

Still to do:

...a tiny hack in menu.c to bring menu in QEMU (not needed for camera), and if there are any buttons not recognized, just print their codes.

Big discovery for today is that adding this line to MAGIC.CFG the camera boots up with the console open.

Code: [Select]
module.console = 1



Now how to get the console to show button events? I'll bet the answer is to get the task hooks working properly.

6
Camera-specific discussion / Re: ML on EOS-M2
« on: Yesterday at 04:06:15 AM »
Next steps were covered before: new-dryos-task-hooks (done for 1300D, some stubs apparently wrong on M2)

I tried merging new-dryos-task-hooks again and this time it looks like it worked. At least "Hello World" is running--tested on the camera too.

You can now see DryOS tasks switching if you compile with CONFIG_QEMU=y and you enable DEBUG_TASK_HOOK in boot-hack.c. Without the latter, only new tasks will be displayed.

Did that too. Don't know what exactly to look for but there are a lot more messages flying through the terminal when run in QEMU.

So--one small step.

7
Camera-specific discussion / Re: Canon 100D / SL1
« on: January 20, 2018, 09:56:14 PM »
...high-quality video recording is possible at resolutions up to 2520x1080....

Just realized--how are you getting that resolution? The zoom mode file @canneloni did is 1920x1080. The maximum horizontal resolution I'm seeing is 2520 and the max vertical is 1078 using mlv_lite:

EOSM = 2520x1072, 1920x1078
700D = 2520x1072, 1920x1078

I'm not sure how the update_resolution_params function in mlv_lite works but it seems to me that the 100D should have the same combination of image sizes as the EOSM and 700D.

8
Camera-specific discussion / Re: Canon 100D / SL1
« on: January 20, 2018, 08:36:55 PM »
Hum--I was in the unified branch when I looked up the skip values and it seems that Matthew Kelly's commit for the 700D has already been applied to the other cameras in the crop_rec_4k branch. Edited my previous post.

I couldn't reproduce the "hiccup" issue on the EOSM or 700D.

9
Camera-specific discussion / Re: Canon 100D / SL1
« on: January 20, 2018, 07:05:49 PM »
What were the exact settings you used?

I know that it could get confusing because there are several "crop" modes but you're using zoom mode which is set when the Canon menu is at 1920x1080 and you press the magnifying glass button until you get into 5x magnification. However, to record the largest sized image you need to use one of the reduced bit settings and lossless compression. Is this happening at 14bit lossless or only 8...12bit lossless? Maybe this has something to do with it?

...8...12-bit lossless modes (they use raw type 0x12 DEFCORRE, other modes use 0x10 CCD aka the first step in the pipeline).

Maybe there is a problem using 0x12 DEFCORRE in zoom mode? Maybe experimenting with a different PREFERRED_RAW_TYPE?

src/raw.c
Code: [Select]
#define RAW_DEBUG_TYPE   /* this lets you select the raw type (for PREFERRED_RAW_TYPE) from menu */

There's a "warning FIXME" in the skip values so maybe this needs to be changed?

[EDIT] I was looking at the unified branch, this was fixed in the crop_rec_4k branch but I'll leave what I posted here because maybe this is causing some issues? Though I doubt it.

raw.c
Code: [Select]
        #if defined(CONFIG_650D) || defined(CONFIG_EOSM) || defined(CONFIG_100D)
        #warning FIXME: are these values correct for 720p and crop modes?
        skip_top    = 28;
        skip_left   = 74;
        skip_right  = 0;
        skip_bottom = 6;
        #endif

From the files I've been looking at for the cameras with the focus pixel issue it seems to me that it should be:

Code: [Select]
       skip_top    = 28;
        skip_left   = 72;
        skip_right  = 0;
        skip_bottom = 0;
 

Note that the skip values are different on the 700D. These cameras are very similar so maybe this should also apply to the 100D/650D/EOSOM?

Code: [Select]
        #ifdef CONFIG_700D
        skip_top    = 28;
        skip_left   = 72;
        skip_right  = 0;
        skip_bottom = zoom ? 0 : mv1080crop ? 0 : 4;
        #endif

Could it be that the skip_bottom in zoom mode that might be causing the "hiccup" issue?

10
Camera-specific discussion / Re: Canon EOS M
« on: January 20, 2018, 05:42:41 PM »
Short answer, the shutter-bug isn't persistent.

The shutter-bug only happens on certain cards when ML is loaded and you are using an EF-M zoom lens (don't know if it is the zoom or the IS that is causing this). There are a few workarounds but the easiest is to use a SanDisk Extreme 32GB or smaller SD card. Others might or might not work. It is important that the card not be over 32GB.



11
Camera-specific discussion / Re: Canon 100D / SL1
« on: January 20, 2018, 05:29:42 PM »
Whoa--the Dual ISO lines on the highlights are egregious!

It would also be nice to get rid of the focus pixels that are on the edges of the frame on your shot:



12
Did some testing on the 100D. The 1:1 video modes, mv1080crop and zoom, could also have the focus pixels offset 8-pixels to the right. Discussion on the 100D topic.

Updated the map files for MLVFS, updated the MLVFS pull request and updated the fpm.sh script.

13
Camera-specific discussion / Re: Canon 100D / SL1
« on: January 20, 2018, 03:04:17 AM »
Ok, this is what is going on with the 12bit zoom mode and most likely also on the mv1080crop mode. [EDIT] This also applied to mv1080crop.

It doesn't matter if the current focus pixel map is used or the --no-fixfp in mlv_dump or if I remove all of the map files from MLVFS, the results are the same. Focus pixels pop up near contrasty borders.



These aren't quite as obvious as they are on the mv1080 test but they are there. They are usually green or magenta and fall into a pattern. (Click on the image for a closer look.)



It turns out that on these tests the pattern was shifted 8 pixels to the right. On the 100D the pattern repeats every 12 pixels so you can also say that it was shifted 4 pixels to the left. Is it something that happens all of the time or can it be in the "normal" position on one shot and shifted on another shot using the same settings? Since we've seen this happen before on other lossless compressed footage let's make a second pass shifting the map 8 pixels to the right:



I'll check the mv1080crop shots and run some tests on the files from @canneloni and @IDA_ML submitted for testing and if everything checks out I'll update the focus pixel map files.

By the way, I'm using both mlv_dump (the latest version on steroids) and MLVFS on these tests along with dcraw and ACR so if you notice a color shift, it is probably just me using different apps.

14
You mustn't do that.

Most of what I do I mustn't do.

Ok, so the download link on the www.qt.io website took me to a Russian page but the next link went back to English--that was weird. I opened a QT account in order to run the installer, figured out what I wanted to install (there are lots of options) and when I finally got it working--

Code: [Select]
:-1: error: No rule to make target `FFmpeg/ffmpeg', needed by `MLV App.app/Contents/MacOS/ffmpeg'.  Stop.
Oh yeah--go back and read the MLV App instructions. Ah ha, - unpack ffmpegOSX.zip in `platform/qt/FFmpeg` and - go to tab project, add command line argument -j4 (for quad core)

Yay!

15
Camera-specific discussion / Re: Canon 100D / SL1
« on: January 19, 2018, 12:58:26 AM »
Great test @canneloni !

I need to take a closer look but right away look at the psychedelic display of focus pixels on mv1080:



Compared to mv1080crop -- without fixing the focus pixels:



Thanks for this.

16
It even works with this EOSM crop_rec pre-RAWC shot if you play around with the options:


17
The binaries listed on the first post haven't been updated in a while and I wanted to check out the new focus pixel commits so I decided to compile the qt version on my Mac.

A couple of important steps:

Code: [Select]
brew install qt caskroom/cask/qt-creator
echo 'export PATH="/usr/local/opt/qt/bin:$PATH"' >> ~/.bash_profile

You also have to tweak the preferences:



Yay!



18
Camera-specific discussion / Re: Canon 7D Mark I
« on: January 18, 2018, 09:32:19 PM »
Yeah, 2.0.6 is a rather low priority work in progress. If anyone wants to test or correct my mistakes please to do so!

19
Camera-specific discussion / Re: Canon 100D / SL1
« on: January 18, 2018, 06:53:58 PM »
@theBilalFakhouri detailed how he did it but even if you just put the camera on a tripod and shoot it off your computer screen it should work.

Every video mode at every bit rate and compression setting would be best but right now what I'm most interested in are mv1080crop and 5x zoom -- the 1:1 sampling video modes using 8...11bit, 12bit and 14bit lossless compression.

Don't bother testing Dual ISO with the test pattern. We know there is a problem but it shouldn't affect the focus pixels.

20
Camera-specific discussion / Re: Canon 7D Mark I
« on: January 18, 2018, 05:41:45 PM »
Does IO crypt also work with the new ML?

I have never used that module but if I got the addresses right it should work.

https://bitbucket.org/hudson/magic-lantern/pull-requests/878/update-to-7d206/diff#chg-modules/io_crypt/io_crypt.c

[EDIT] The example shows the addresses for 2.0.3 so I updated the example. The values used in the module didn't change with the firmware update.

21
Camera-specific discussion / Re: Canon 100D / SL1
« on: January 18, 2018, 05:36:22 PM »
Sorry, I meant that all of the shots were underexposed. You're far from clipping the highlights.



This is what the Dual ISO histogram looks like before processing:



I'm not an expert at exposing Dual ISO but this looks underexposed to me.

Focus pixel fixing seems to be working, though maybe the 100D doesn't need the 1-pixel offset pass that the 700D needed. What would really help is shooting that test pattern @theBilalFakhouri used. It is still available on his Google Drive from the link in his post.

The main issue here is that cr2hdr isn't processing your 8...12bit Dual ISO shot.

22
Camera-specific discussion / Re: Canon 100D / SL1
« on: January 18, 2018, 04:42:24 AM »
Quick report.

I can't get the 8...12bit Dual ISO isn't working with MLVFS or mlv_dump/cr2hdr. The normal shots worked fine but are quite underexposed.



Looks like maybe the 2-pass map isn't needed on the 100D mv1080crop 8...12bit? Hard to tell with this test because there are so few focus pixels showing up.



Here's the 14bit lossless Dual ISO after playing around with it. Recovered lots of shadow detail but it is a bit noisy. No focus pixels, though.



Well, almost. There were a few along the edges that persisted.



By the way, earlier I was getting lots of focus pixels. When testing out MLVFS I often pull out the fpm files to see the focus pixels. Guess what? I forgot to put them back.  ::)

All fine now!

23
The latest focus pixel map files are here:

https://bitbucket.org/daniel_fort/ml-focus-pixels/src/8bf385a7e828aa07aa605bc911ea94921b5c3c58/focus_pixel_map_files/?at=default

As you discovered there is a lot of duplication in the map files. Read the focus pixel topic if you’re curious why that is.


Sent from my iPhone using Tapatalk

24
Camera-specific discussion / Re: ML on EOS-M2
« on: January 17, 2018, 07:05:54 AM »
Got it working on Windows Subsystem for Linux (WSL) -- (Scream like a little girl!)



(does this make any more sense now?)

Yes it does. Anytime the ROM is patched the firmware signature changes. Is that the lesson here?

Didn't test on Mac though; I'll try later if it still doesn't work. Without loading ML, is the Canon menu still working?

Yeah, looks like there is a Mac issue, but only with patches.gdb. Running ML with debugmsg.gdb does show the firmware signature and it matches what I'm getting in camera. It was just that the commit you pointed out was on patches.gdb so I thought it was necessary to run it with patches.gdb.

One other observation - on Mac it pauses for user input while on WSL it doesn't:

Code: [Select]
---Type <return> to continue, or q <return> to quit---
I merged in the new-dryos-task-hooks a while back but maybe I screwed it up. I'll try it again and see if I can track down the bogus stubs.

..a tiny hack in menu.c to bring menu in QEMU (not needed for camera), and if there are any buttons not recognized, just print their codes.

A tiny hint on how to print out the button codes?

25
Got a suggestion for the documentation.

After hours of struggling to get QEMU working again on Windows Subsystem for Linux (WSL) after a bunch of Microsoft and Ubuntu updates -- what is really important but not obvious is having to start the X server. BTW, VcXsrv isn't working here after the updates but Xming is and it is just as easy to install and run.

[EDIT] Oh yeah, don't forget this:

Code: [Select]
export DISPLAY=:0

Pages: [1] 2 3 ... 93