Messages

I use DR for many years and never heard of "new debayering algorithm in resolve 17". Yes, somewhere in version 12 they made it really up to competitors, but since than i've seen nothing worth mentioning in this regard. And yes, open source algorithms implemented in MLVApp are top notch. What are you talking about? Where was that announced?

https://www.rawdigger.com/download
You can see absolute pixel values of every channel.
No need to buy/activate for that.

Try to convert CR2 to DNG with Adobe DNG Converter first.
Please, let us know, if that helps

What are you even saying?

I'm saying ""Sea-thru" yilds very little difference(just compare S1 results - simple one button push in Photoshop - to S5) with very high price(need to generate 3D model) under very limited circumstances(the distance between different objects and camera should be significant, comparable to distance to the surface)."
My conclusion is based on the results, demonstrated in the original papers and my previous experience in the subject.
Can you be more specific in contradict?
Show some examples, not formulas.
Moreover, the article you reference is about "... to model the human perception of color. The CIECAM02 model has been shown to be a more plausible model of neural activity in the primary visual cortex, compared to the earlier CIELAB model"
What is in common between "more plausible model of neural activity in the primary visual cortex" and the task to get correct colors in underwater images? Are you sure you understand, what is that all about?
I'm not marine biologist too, but your hypothetical example is very doubtful: when coral gets unhealthy, it's "bleaching" wich is visible by naked eye. And i don't see a crouds of underwater professionals of any kind, excited by a new possibilities.

C'mon, guys. Sorry for disappointing you, but how can you even compare your work to this?
You do pure research, because your work is completely voluntary and you have no obligations of any kind.
That scientists work for salary/grants and maybe even want to commercialise the result.
They need to show something to justify they are not just having fun diving Lembeh strait on someone else's expence.
And they revealed the "Sea-thru", whoa, removing water from images!
After reading that comments on reddit i want to say just one thing - I really like people:
they can easily buy anythig with good branding and couple of clever tricks - "Sea-thru", "Theranos", etc. 
Back on subject. According to original papers, "Sea-thru" is:
1. Some color correction algorithm, what i call "whitebalancing" as it essentually it is in the core.
2. 3D map of the scene.
3. Method of calculating the amount of the color correction depending on the distance to any object according to the 3D map.
So, what exactly are they invented? Color correction algorithm itself? No they don't claim that! They enhance some existent.
New method of generating the 3D map from several images? No. They used commercial software from Agisoft LLC.
What is in the rest? The idea to take the 3D map into account itself? Does it so important in any given situation?
Let see how it's work. First, the light goes from the surface to bottom -  let say, H.
Then, it reflects from any object and goes to camera - D1. Light goes H+D1. Similarly, we have another object and D2. 
For all this idea to work we should have D1-D2 comparable to H.
If I, let say, 10 meters underwater, and all my scene within 1 meter deep - i can totally ignore that difference.
So, "Sea-thru" yilds very little difference(just compare S1 results - simple one button push in Photoshop - to S5) with very high price(need to generate 3D model) under very limited circumstances(the distance between different objects and camera should be significant, comparable to distance to the surface).
Who can utilise that? Photographers? I doubt that - too complicated with too weak advantages. Marine biologists? Do they really in such need that "color-accurate" images at that expence? Actually, they have thousands of methods to get answers to theirs questions or results, if they can't take something to the lab.  This, for example
Or this, great example of real dirty job of marine biologists:)

Guys, there is more to this than reinventing auto white balance or applying auto color corrections:

http://openaccess.thecvf.com/content_CVPR_2019/papers/Akkaynak_Sea-Thru_A_Method_for_Removing_Water_From_Underwater_Images_CVPR_2019_paper.pdf

As far as i understand they reconstructing a 3D scene from the image and applying color corrections dependent on distance?
And " In all cases, the simple contrast stretch S1, which is global, works well when scene distances are more or less uniform".
So yes, this is something more, but can't much inspire someone more or less familiar with the subject.
By the way, the ability to use extreme white balance is crucial to get rich colors underwater(and Canons rock here, as no other cameras allow to use such exreme values):
https://www.dpreview.com/articles/5150953093/canon-1d-x-mark-ii-under-water-review

Good things these scientists weren't thinking like that.

Haven't seen something special in that youtube vid.
That "scientist" seems just reinvent auto white balance.
I've shot a lot of photo/video underwater professionally, so i'm know, what i'm talking about.

Be careful: in 10-14 range the rear lens is in reach of the mirror

@allemyr: 14 bit RAW with 16383 WL and ETTR exposure requires "Apply Soft Clip" and "Highlight Recovery" in Camera RAW settings.

Before anyone will believe it's true, need to say thanks god NO, x5 crop mode has nothing to do with FRSP and it's exposure limitations.
If so, that will be completely unusable for any realtime video, only for timelapses.
x5 mode originally intended to LCD only, so it 30 fps despite your actual settings and exposures are different too.
Need to play with FPS/Exposure override to mutch x5 to non-crop.

I have a 5d3 with ml , but it would be nice to be able to set it, so for photos it uses a sd card, and for recording movies it defaults to the cf card. 

Just select sd in canon menu. ML will record to cf anyway.

Do the editing with the proxy on. Then when you want to color grade...

Sorry, but according to wikipedia:
"Adobe After Effects is a digital visual effects, motion graphics, and compositing application ...
can be used for keying, tracking, compositing and animation."
No words about "editing" or "color grade".

For me the most important feature I wish I have with 4K builds is card spanning.
It's so distracting that we had this feature before.
Because the mind blowing 45/48 FHD mode is only 6-7 sec on my camera!!!
Ironically, this is just a "coding task" no need to investigate something new.
I even tried several times to do this myself, but, despite of vast amount of code analysis background,
this task is overkill for me: not enough of C knowledge and details about underlying hardware and OS functionality.
Mlv_rec and mlv_lite modules are significantly different regarded how data record is implemented
and no possible to just copy code from one to another.
I understand, that for main developers this is just boring job, they spend time discovering something new.
Anyone with decent C skills and MKIII camera???

@c2s07: You just described how Auto Lighting Optimizer works.

@masc: let's change it to off by default.

It would be much better to implement user-defined default settings.

Edit: which OS?

...
Just downloaded 1.5 (win64) and tried black frame subtraction.
...

Hi, guys, thank you for your great app!!!
Just downloaded 1.5 (win64) and tried black frame subtraction.
1. 1.5 version crashes constantly after processing 502-504 frames on any file (longer than 504 frames).
If process without black frame it not crashes.
2. 1.4 processes that files well, but... just only one and than i need to terminate the app with task manager.
If i try to select another file after processing one, or add several files to batch - it warns
"Could not open file (path to black frame MLV)" then it warns
"Could not open file (path to MLV to process)".
The only way to close this window is to terminate the app.
If process without black frame, it is possible to select any number of files to process
or add to batch and process too.

Maybe this will be useful for devs?
https://www.rsaconference.com/events/us19/agenda/sessions/16608-Come-Get-Your-Free-NSA-Reverse-Engineering-Tool
It kinda decompile C code, platform independent... And free, maybe even open-source!!!

Ok, thank you!!!
I had that "Raw error" occasionally from time to time before.
It's not so serious problem due it's rare.
At least, now I know that it could be avoided by DualISO( I'm sure, tried several times).
That incorrect canon's white level with silent was real show stopper, and gladly it fixed.

That debugging kinda works... once, and crashes the camera with ERR70 on top LCD
Nethertheless, here is bad dng and 3 generated crash logs:
https://www.dropbox.com/sh/8h4ssn4l8v1mjjo/AABFZ9T1zwDKMFhSJWakZxAfa?dl=0

Thank you, a1ex, you are very helpful, as always!!!
I updated that code in raw.c: when silent enabled, your old code is running:

Code Select Expand


    if (!lv)
    {
if (is_module_enabled("silent"))
{
/* at ISO 160, 320 etc, the white level is decreased by -1/3 EV */
/* in LiveView, it doesn't change */
int iso = 0;
if (!iso) iso = lens_info.raw_iso;
if (!iso) iso = lens_info.raw_iso_auto;
static int last_iso = 0;
if (!iso) iso = last_iso;
last_iso = iso;
if (!iso) return 0;
int iso_rounded = COERCE((iso + 3) / 8 * 8, 72, 200);
float iso_digital = (iso - iso_rounded) / 8.0f;

if (iso_digital <= 0)
{
raw_info.white_level -= raw_info.black_level;
raw_info.white_level *= powf(2, iso_digital);
raw_info.white_level += raw_info.black_level;
}

raw_info.white_level = autodetect_white_level(raw_info.white_level);
raw_info.dynamic_range = compute_dynamic_range(black_mean, black_stdev_x100, raw_info.white_level);
}
else
{
/* start at Canon's white level, and autodetect from there
* Canon's guess may be up to 0.38 EV below the true value - or maybe more?
* http://www.magiclantern.fm/forum/index.php?topic=20579.msg190437#msg190437
*/
int canon_white = shamem_read(0xC0F12054) >> 16;
raw_info.white_level = autodetect_white_level(canon_white);
raw_info.dynamic_range = compute_dynamic_range(black_mean, black_stdev_x100, raw_info.white_level);
printf("White level: %d -> %d\n", canon_white, raw_info.white_level);
}
    }


That fixes the problem, but... now it occasionally ens up stuck with "Raw error".
Need long(5+ sec) exposures, high ISO(400+) and DualISO disabled.
There are 6 occurences of that message in source, so I made all 6 different and found,
that it is the first one in the auto_ettr_step() procedure in ettr module.
It looks like i leave DualISO enabled even if overcast

If you have attempted to meter long exposures from 1/30" LiveView frames... I'm not sure what I can do.

Yes, it's seems that is the point: ETTR (not me) tries to calculate exposure from that mess.
Finally, it deals with completly white LCD preview, but saves completely black DNG.
And only if DualISO is activated, it calculates exposure from actually taken images.
How can I avoid this? As I mentioned, I shoot timelapse:
Photo mode Live view, silent Full-Res, compressed DNG (tried MLV, the same story).
It used to work all the time this way.
I think it's unnecessary to upload the perfectly black DNG.

ETTR in recent builds is not usable in low light.

I used to shoot a lot of timelapses before 4K video era begins.
I even shared my hard earned settings for getting amazing sunrises:
https://www.magiclantern.fm/forum/index.php?topic=18730.msg178621#msg178621
Recently i tried to shoot timelapse with recent build and failed.
Now i try to sort out whats wrong.  What i found: as long, as i reduce light, the image on LCD gets more pixelated,
histigram shows overexposure, ETTR shortens exposure(!!!), but screen gets only brighter and brighter and, finally complete white.
It saves completely black DNG, of course.
I compared the ettr source of recent build with the old one.
I found suspicious new code:

Code Select Expand

if (overexposed_percentage > 0 && (auto_ettr_midtone_snr_limit || auto_ettr_shadow_snr_limit) && !dual_iso)
I enabled DualISO, to test, whether this is the source of problem - and it disappeared.
Instead of white screen I gets correctly exposed images with several second exposures.
I decided to comment this out and try without DualISO - problem persist.
DualISO fixes the problem somehow, but that code is not the source of it.
So, i stuck on it, have no more ideas, my humble skills don't allow me to find why it used to work but no more

Same s**t:

Code Select Expand

ML ASSERT:
0
at mlv_lite.c:2723 (compress_task), task compress_task
lv:1 mode:3

compress_task stack: 1ae538 [1ae5c0-1ad5c0]
0x0006A030 @ ae1174:1ae568
0x00069868 @ 6a09c:1ae538

Magic Lantern version : Nightly.2018Oct09.5D3113
Mercurial changeset   : 41153b1177ce+ (crop_rec_4k_mlv_snd) tip
Built on 2018-10-09 14:52:06 UTC by VOLD@VOLDMONSTER-II.
Free Memory  : 211K + 2983K

By the way, your code example with error: 1048 instead of 1080 in preset. But your repo code is correct.

I need Delta HEAD3 to be -30 - then only a dozen of first frames are "jumping" left-right, and record continues without artifacts. With any other value(-20, -17, -15, -10) - frames corruption, flickering, console messages about corrupted frames and compression errors.