Messages

I was already running ML 1.2.3 on my 5D3 that I'd compiled from Chris's repo. Followed A1ex's instructions and now I'm running wonderfully here. Tested disabling and reenabling the Bootflag. Also no glitches. Congrats to Chris_overseas, A1ex and every other contributor for this!

Chris,
Tested on 1.2.3. Also working fine. Thanks

Every build from feb 12th onwards has the fix.

It's online in the last nightly build. Enjoy!

Commited and pull request sent. Hopefully soon everyone will have the feature working on their 5D3s

Thanks Audionut! Will do that tonight

Great news guys! Fixed Movie Restart on the 5D3. Activated the feature on movie tweaks and by suggestion and with the help of our friend 1%, I changed the wrong NSTUB for the right one and voila! Tested on my 5D3 and it's working fine.
Can't seem to be able to commit it to the unified though. Cloned from unified/hudson to my mac but don't know how to send the changes in order for everyone to have it. 

It stops and doesn't restart. It restarts only if the command movie_end() was issued. Tested putting 2000 and letting the camera stopping automatically. Didn't restart.
Anyway, it was the way I could do it. Would love to do exactly what g3gg0 suggested but there are too many variables I don't know. Like: what is the codification of the button rec? Which button starts recording and what is its name. What are the commands available for me to use. I couldn't find documentation that explains how everything works. :-(
Anyway, for now this works. Don't know if it will alonside fps override though. Will keep trying to think about g3gg9's solution

Done! Working on my 5D3. Movie restarting after every 29 minutes. May work for all cameras. Doesn't depend on error messages. See what you think.

Code Select Expand

#ifdef FEATURE_MOVIE_RESTART
        static int recording_prev = 0;
        static int first_time = 0;
        static int start_rec_time = 0;
        static int r = 0;
       
        #if defined(CONFIG_5D2) || defined(CONFIG_50D) || defined(CONFIG_7D)
        if(!RECORDING_H264 && recording_prev && !movie_was_stopped_by_set) // see also gui.c
        #else
        if(RECORDING_H264)
        #endif
        {
            if (movie_restart)
            { 
               if(!first_time)
                  {
                 start_rec_time = get_seconds_clock();
                 NotifyBox(2000,"Movie Restart Active", start_rec_time, r > 1 ? "s" : "");
                 first_time = 1;   
                    }
                r =  get_seconds_clock() - start_rec_time;
                     if(r > 1740)
                    {
                movie_end();
                start_rec_time = 0;
                first_time = 0;
                NotifyBox(2000,"Restarting", start_rec_time, r > 1 ? "s" : "");
                movie_start();
                    }
            }
        }
       
        recording_prev = RECORDING_H264;

        if(!RECORDING_H264)
        {
            movie_was_stopped_by_set = 0;
        }
    #endif


So, I tried this code and it didn't work. Any ideas why? As far as I can understand it should work because it wasn't a press of BGMT_REC that stopped the recording.

Code Select Expand

if(!RECORDING_H264 && recording_prev && !BGMT_REC)
        #endif
        {
            if (movie_restart)
            {
                msleep(500);
                movie_start();
            }
        }
        recording_prev = RECORDING_H264;

        if(!RECORDING_H264)
        {
            movie_was_stopped_by_set = 0;
        }
    #endif

Just one last thing: when video stopped on 5D2 it was "stopped by set", right? Now on 5D3 is it the same thing? And if it is, can I use it even when 5D3 doesn't have a gui.c?

Ooooh! Right! Thanks g3gg0

So I'm missing only one information and I can't find it, though I've looked for it: what is the line I should use in the code to tell that the camera stopped the recording because of the time limit?

as described, the user keys have to be monitored.
if user pressed REC and the video stops, well then its likely that this was intended
if nothing was pressed, stopping was not intended by the user.

Yes, I understand that, but what then is the command the canon firmware gives the camera to stop recording? If it isn't an error (because we don't want to use errors anymore, right?), I was under the impression it was a BGMT_REC or something similar to movie_was_stopped_by_set.

It stops at like 1799 frames. Maybe can do a frame count.

But then it would be different for every h264 format, no? like 24fps and 50 fps and 29 fps. Any idea on how I can use the time?
I was thinking something in the line of:
if(!RECORDING_H264 && recording_prev && BGMT_REC && time elapsed 1799 seconds?) But I don;t know how to code this!

And what is the difference between BGMT_REC and BGMT_FLASH_MOVIE?

[Clean up movie restart feature]

Clean up movie restart feature
Current state:
The "Movie Restart" feature is for automatic restarting H264 recording if it was stopped due to reaching 4GiB or 30 min limits.
At the moment this is done by checking some error message dialog id and recording state.
This is a bit hard to port for every model and on firmware change.

Goal:
Rewrite the code so that it is more or less a simple state machine that receives the users keypresses as input (Rec, Set)
and checks if recording started (RECORDING_H264) within a second after the keypress was received. Same for stopping.
If the recording indicator indicates that recording suddenly stopped, it should re-emit a movie_start() and check if it records longer than 10 seconds.
If recording stops in less than 10 seconds again, reset the state and wait for the next user input (Rec, Set)
This check is to make sure that recording didnt stop automatically due to e.g. sensor overheating or disk space.

Hint: It would be a good start to draw a state diagram
(i *never* thought i would ever really say that i like drawing charts )

Rework NotifyBox
Current state:
The NotifyBox feature is an useful on-screen display to notify the user of some happenings.
Unfortunately its implementation is quite crude, just printing the text on screen, providing not much usability.

Goal:
Pimp this functionality by
1) drawing some borders and making it look more like a information dialog, not like a bug.
2) adding e.g. NotifyBoxEx which allows to pass some icon type
(warning , error or information )
3) add an option to make the boxes disappear when the user presses a button

Make sure the icons being used are GPLed! (e.g. GNOME, KDE or any other linux window manager/toolkit provide plenty)

If so, how does the camera know if the button was pushed by user or by the movie restart feature? Because if it can't tell the diference, I think it will never stop recording. Am I right or did I miss something? Perhaps using the time (29'.59") as a marker that it was stopped because it reached the limit time? Any inputs?

There's no such menu on my 5D3.

I have absolutely no use for movie restart, so I'm not going to fix it (especially since a single testing attempt is going to take half an hour). But if anyone else wants to take a look it, nobody is stopping him.

I have no idea if it's actually working on any other DIGIC V camera. There are probably many other things enabled and not working, because very few people actually use them, and the maintainers of these cameras did not try them before publishing the binaries (it would probably take days or weeks just to try every single thing from the menu). I'm actually thinking to implement a feedback form to identify what's working and what not.

And yeah, opening 3 threads on the same subject is not welcome.

Hi A1ex,

I'll try and make the movie restart work on the 5D3. Just a question though: How do I find out why isn't it working? I thought of enabling it and get the dump from debug, but if it don't restart will it leave any marks?
Hope you can help us out.

apparently it was directing to an html. Anyways, it's working now. Thanks again

Figured it out!
Was trying to user MacHG to clone the magic-lantern unified. DO NOT DO THAT. It comes incomplete. Use the command line. Everything working now. For anyone wanting to compile on Mac OS Mavericks do this:

Install Xcode from the appstore

follow this:
http://hackercodex.com/guide/mac-osx-mavericks-10.9-configuration/

now type these lines from dmilligan:

curl -OL https://launchpad.net/gcc-arm-embedded/4.7/4.7-2013-q2-update/+download/gcc-arm-none-eabi-4_7-2013q2-20130614-mac.tar.bz2
bzip2 -d gcc-arm-none-eabi-4_7-2013q2-20130614-mac.tar.bz2
tar -x -f gcc-arm-none-eabi-4_7-2013q2-20130614-mac.tar
brew install hg
hg clone -b unified https://bitbucket.org/hudson/magic-lantern
brew install coreutils
cd magic-lantern
curl -OL https://bitbucket.org/dmilligan/magic-lantern/downloads/Makefile.user
export PATH="$PATH:$(brew --prefix coreutils)/libexec/gnubin"
echo "export PATH=\"\$PATH:\$(brew --prefix coreutils)/libexec/gnubin\"" >> ~/.bash_profile
make clean
make

edit whatever you have to edit from Makefile.user and voila! Happy building

Thanks again to dmilligan for all the help

Nevermind that. Installed home-brew by hand and after did everything else on your script. Edited some addresses on your makefile.user. Kept saying the arm-elf didn't exist. Edited Makefile with the same paths as in makefile.user.
Now it seems to find the armtool but returned this same error:

MacBook-Air-de-Vinicius-Atique:magic-lantern viniciusatique$ make
[ CPP      ]   magiclantern.lds
[ AS       ]   entry.o
[ CC       ]   init.o
[ AS       ]   stubs-5d2.208.o
[ VERSION  ]   version.c
[ CC       ]   version.o
[ CC       ]   stdio.o
stdio.c: In function 'realloc':
stdio.c:277:15: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
[ CC       ]   config.o
[ CC       ]   debug.o
debug.c: In function 'call_setprintmovielog':
debug.c:169:2: warning: format '%d' expects argument of type 'int', but argument 7 has type 'int32_t' [-Wformat]
debug.c:187:2: warning: format '%d' expects argument of type 'int', but argument 5 has type 'int32_t' [-Wformat]
debug.c:187:2: warning: format '%d' expects argument of type 'int', but argument 6 has type 'int32_t' [-Wformat]
debug.c:196:2: warning: format '%d' expects argument of type 'int', but argument 5 has type 'int32_t' [-Wformat]
debug.c:196:2: warning: format '%d' expects argument of type 'int', but argument 6 has type 'int32_t' [-Wformat]
debug.c:196:2: warning: format '%d' expects argument of type 'int', but argument 7 has type 'int32_t' [-Wformat]
debug.c:196:2: warning: format '%d' expects argument of type 'int', but argument 8 has type 'int32_t' [-Wformat]
debug.c:196:2: warning: format '%d' expects argument of type 'int', but argument 9 has type 'int32_t' [-Wformat]
debug.c:201:2: warning: format '%d' expects argument of type 'int', but argument 5 has type 'int32_t' [-Wformat]
debug.c:201:2: warning: format '%d' expects argument of type 'int', but argument 6 has type 'int32_t' [-Wformat]
debug.c:206:2: warning: format '%d' expects argument of type 'int', but argument 5 has type 'int32_t' [-Wformat]
debug.c:206:2: warning: format '%d' expects argument of type 'int', but argument 6 has type 'int32_t' [-Wformat]
debug.c:159:13: warning: unused variable 'div' [-Wunused-variable]
debug.c:158:9: warning: unused variable 'mvrSetQScale' [-Wunused-variable]
debug.c:157:9: warning: unused variable 'mvrFixQScale' [-Wunused-variable]
debug.c:156:9: warning: unused variable 'mvrSetBitRate' [-Wunused-variable]
debug.c:155:10: warning: unused variable 'bps' [-Wunused-variable]
debug.c: In function 'efic_temp_display':
debug.c:249:2: warning: format '%d' expects argument of type 'int', but argument 5 has type 'uint32_t' [-Wformat]
debug.c: At top level:
debug.c:351:3: warning: initialization from incompatible pointer type [enabled by default]
debug.c:351:3: warning: (near initialization for 'debug_menus[4].select') [enabled by default]
debug.c: In function 'debug_property_handler':
debug.c:433:2: warning: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Wformat]
debug.c:433:2: warning: format '%x' expects argument of type 'unsigned int', but argument 8 has type 'long unsigned int' [-Wformat]
debug.c:433:2: warning: format '%x' expects argument of type 'unsigned int', but argument 9 has type 'long unsigned int' [-Wformat]
debug.c:433:2: warning: format '%x' expects argument of type 'unsigned int', but argument 10 has type 'long unsigned int' [-Wformat]
debug.c:433:2: warning: format '%x' expects argument of type 'unsigned int', but argument 11 has type 'long unsigned int' [-Wformat]
debug.c:433:2: warning: format '%x' expects argument of type 'unsigned int', but argument 12 has type 'long unsigned int' [-Wformat]
debug.c: At top level:
debug.c:606:1: warning: initialization from incompatible pointer type [enabled by default]
debug.c:606:1: warning: (near initialization for 'task_create_movie_start.entry') [enabled by default]
[ CC       ]   menu.o
menu.c: In function 'menu_handler':
menu.c:516:2: warning: case value '1' not in enumerated type 'gui_event_t' [-Wswitch]
menu.c:520:2: warning: case value '268435590' not in enumerated type 'gui_event_t' [-Wswitch]
[ CC       ]   property.o
[ MKFONT   ]   font-med.c
[ CC       ]   font-med.o
[ MKFONT   ]   font-small.c
[ CC       ]   font-small.o
[ CC       ]   gui.o
[ CC       ]   bootflags.o
[ CC       ]   bmp.o
[ CC       ]   focus.o
[ CC       ]   lens.o
[ CC       ]   spotmeter.o
[ CC       ]   audio.o
[ CC       ]   zebra.o
[ CC       ]   hotplug.o
[ CC       ]   ptp.o
[ CC       ]   bracket.o
make: *** No rule to make target `/opt/local/arm-elf/lib/libc.a', needed by `lib_a-setjmp.o'.  Stop.
MacBook-Air-de-Vinicius-Atique:magic-lantern viniciusatique$

I really haven't got a clue. :-/

thanks again.

tried your script

got these errors in response

MacBook-Air-de-Vinicius-Atique:~ viniciusatique$ #!/bin/bash
MacBook-Air-de-Vinicius-Atique:~ viniciusatique$ cd
MacBook-Air-de-Vinicius-Atique:~ viniciusatique$ ruby -e "$(curl -fsSL https://raw.github.com/mxcl/homebrew/go)"
-e:6: syntax error, unexpected '<'
<!DOCTYPE html>
^
-e:7: syntax error, unexpected '<'
<html>
^
-e:9: syntax error, unexpected '<'
    <meta charset='utf-8'>
     ^
-e:10: syntax error, unexpected '<'
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
     ^
-e:10: syntax error, unexpected tIDENTIFIER, expecting end-of-input
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
                                              ^
MacBook-Air-de-Vinicius-Atique:~ viniciusatique$ curl -OL https://launchpad.net/gcc-arm-embedded/4.7/4.7-2013-q2-update/+download/gcc-arm-none-eabi-4_7-2013q2-20130614-mac.tar.bz2
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
100 62.5M  100 62.5M    0     0   157k      0  0:06:45  0:06:45 --:--:--  220k
MacBook-Air-de-Vinicius-Atique:~ viniciusatique$ bzip2 -d gcc-arm-none-eabi-4_7-2013q2-20130614-mac.tar.bz2
MacBook-Air-de-Vinicius-Atique:~ viniciusatique$ tar -x -f gcc-arm-none-eabi-4_7-2013q2-20130614-mac.tar
MacBook-Air-de-Vinicius-Atique:~ viniciusatique$ brew doctor
-bash: brew: command not found
MacBook-Air-de-Vinicius-Atique:~ viniciusatique$ brew update
-bash: brew: command not found
MacBook-Air-de-Vinicius-Atique:~ viniciusatique$ brew install hg
-bash: brew: command not found
MacBook-Air-de-Vinicius-Atique:~ viniciusatique$ hg clone -b unified https://bitbucket.org/hudson/magic-lantern
-bash: hg: command not found
MacBook-Air-de-Vinicius-Atique:~ viniciusatique$ brew install coreutils
-bash: brew: command not found
MacBook-Air-de-Vinicius-Atique:~ viniciusatique$ cd magic-lantern
MacBook-Air-de-Vinicius-Atique:magic-lantern viniciusatique$ curl -OL https://bitbucket.org/dmilligan/magic-lantern/downloads/Makefile.user
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
100   375  100   375    0     0    253      0  0:00:01  0:00:01 --:--:--     0
MacBook-Air-de-Vinicius-Atique:magic-lantern viniciusatique$ export PATH="$PATH:$(brew --prefix coreutils)/libexec/gnubin"
-bash: brew: command not found
MacBook-Air-de-Vinicius-Atique:magic-lantern viniciusatique$ echo "export PATH=\"\$PATH:\$(brew --prefix coreutils)/libexec/gnubin\"" >> ~/.bash_profile
MacBook-Air-de-Vinicius-Atique:magic-lantern viniciusatique$ make clean
rm -f \
      *.o \
      *.a \
      .*.d \
      font-*.c \
      magiclantern.lds \
      ./lua/*.o \
      ./lua/.*.d \

MacBook-Air-de-Vinicius-Atique:magic-lantern viniciusatique$ make

that seems to have done the trick. Thanks!

But now I get this:

[ CPP      ]   magiclantern.lds
[ AS       ]   entry.o
[ CC       ]   init.o
[ AS       ]   stubs-5d2.208.o
[ VERSION  ]   version.c
/bin/sh: hg: command not found
[ CC       ]   version.o
[ CC       ]   stdio.o
stdio.c: In function 'realloc':
stdio.c:277:15: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
[ CC       ]   config.o
[ CC       ]   debug.o
debug.c: In function 'call_setprintmovielog':
debug.c:169:2: warning: format '%d' expects argument of type 'int', but argument 7 has type 'int32_t' [-Wformat]
debug.c:187:2: warning: format '%d' expects argument of type 'int', but argument 5 has type 'int32_t' [-Wformat]
debug.c:187:2: warning: format '%d' expects argument of type 'int', but argument 6 has type 'int32_t' [-Wformat]
debug.c:196:2: warning: format '%d' expects argument of type 'int', but argument 5 has type 'int32_t' [-Wformat]
debug.c:196:2: warning: format '%d' expects argument of type 'int', but argument 6 has type 'int32_t' [-Wformat]
debug.c:196:2: warning: format '%d' expects argument of type 'int', but argument 7 has type 'int32_t' [-Wformat]
debug.c:196:2: warning: format '%d' expects argument of type 'int', but argument 8 has type 'int32_t' [-Wformat]
debug.c:196:2: warning: format '%d' expects argument of type 'int', but argument 9 has type 'int32_t' [-Wformat]
debug.c:201:2: warning: format '%d' expects argument of type 'int', but argument 5 has type 'int32_t' [-Wformat]
debug.c:201:2: warning: format '%d' expects argument of type 'int', but argument 6 has type 'int32_t' [-Wformat]
debug.c:206:2: warning: format '%d' expects argument of type 'int', but argument 5 has type 'int32_t' [-Wformat]
debug.c:206:2: warning: format '%d' expects argument of type 'int', but argument 6 has type 'int32_t' [-Wformat]
debug.c:159:13: warning: unused variable 'div' [-Wunused-variable]
debug.c:158:9: warning: unused variable 'mvrSetQScale' [-Wunused-variable]
debug.c:157:9: warning: unused variable 'mvrFixQScale' [-Wunused-variable]
debug.c:156:9: warning: unused variable 'mvrSetBitRate' [-Wunused-variable]
debug.c:155:10: warning: unused variable 'bps' [-Wunused-variable]
debug.c: In function 'efic_temp_display':
debug.c:249:2: warning: format '%d' expects argument of type 'int', but argument 5 has type 'uint32_t' [-Wformat]
debug.c: At top level:
debug.c:351:3: warning: initialization from incompatible pointer type [enabled by default]
debug.c:351:3: warning: (near initialization for 'debug_menus[4].select') [enabled by default]
debug.c: In function 'debug_property_handler':
debug.c:433:2: warning: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Wformat]
debug.c:433:2: warning: format '%x' expects argument of type 'unsigned int', but argument 8 has type 'long unsigned int' [-Wformat]
debug.c:433:2: warning: format '%x' expects argument of type 'unsigned int', but argument 9 has type 'long unsigned int' [-Wformat]
debug.c:433:2: warning: format '%x' expects argument of type 'unsigned int', but argument 10 has type 'long unsigned int' [-Wformat]
debug.c:433:2: warning: format '%x' expects argument of type 'unsigned int', but argument 11 has type 'long unsigned int' [-Wformat]
debug.c:433:2: warning: format '%x' expects argument of type 'unsigned int', but argument 12 has type 'long unsigned int' [-Wformat]
debug.c: At top level:
debug.c:606:1: warning: initialization from incompatible pointer type [enabled by default]
debug.c:606:1: warning: (near initialization for 'task_create_movie_start.entry') [enabled by default]
[ CC       ]   menu.o
menu.c: In function 'menu_handler':
menu.c:516:2: warning: case value '1' not in enumerated type 'gui_event_t' [-Wswitch]
menu.c:520:2: warning: case value '268435590' not in enumerated type 'gui_event_t' [-Wswitch]
[ CC       ]   property.o
[ MKFONT   ]   font-med.c
[ CC       ]   font-med.o
[ MKFONT   ]   font-small.c
[ CC       ]   font-small.o
[ CC       ]   gui.o
[ CC       ]   bootflags.o
[ CC       ]   bmp.o
[ CC       ]   focus.o
[ CC       ]   lens.o
[ CC       ]   spotmeter.o
[ CC       ]   audio.o
[ CC       ]   zebra.o
[ CC       ]   hotplug.o
[ CC       ]   ptp.o
[ CC       ]   bracket.o
make: *** No rule to make target `/opt/local/arm-elf/lib/libc.a', needed by `lib_a-setjmp.o'.  Stop.

I used the makefile that came from the hudson clone and modified the paths. Did I do anything wrong?

I've followed the tutorial from http://magiclantern.wikia.com/wiki/Magic_Lantern_Development_on_Mac up to the point where I was supposed to compile. Instead of his repo, I cloned the unified from bitbucket.

Tried to use coutts makefile but then I get this error: make: *** No rule to make target `500d-empty.fir', needed by `magiclantern.fir'.  Stop.

Then I tried to edit the makefile that came with the bitbucket clone. After editing the paths I left everything else as was and I get this error:

[ AS       ]   entry.o
/bin/sh: /Users/viniciusatique/yagarto/yagarto-4.7.2/bin/arm-none—eabi-gcc-4.7.2: No such file or directory
make: *** [entry.o] Error 127

But my make file is like this:

ARM_PATH=~/yagarto/yagarto-4.7.2
ARM_BINPATH=$(ARM_PATH)/bin
GCC_VERSION=4.7.2
CC=$(ARM_BINPATH)/arm-none—eabi-gcc-4.7.2
OBJCOPY=$(ARM_BINPATH)/arm-none-eabi-objcopy
AR=$(ARM_BINPATH)/arm-none-eabi-ar
RANLIB=$(ARM_BINPATH)/arm-none-eabi-ranlib
LD=$(CC)
HOST_CC=gcc
HOST_CFLAGS=-O3 -W -Wall

Can someone help me?

I shoot Opera and the movie restart feature would be very welcome, since operas usually go on for about 3 hours. I would do it myself if I knew how to code it.
Hope someone accept the challenge and help us out!

Cheers