Magic Lantern Forum

Using Magic Lantern => General Help Q&A => Topic started by: escho on October 13, 2013, 11:30:14 PM

Title: 600D and MLV: hack error
Post by: escho on October 13, 2013, 11:30:14 PM
I enable extra hacks in the raw-rec-module. If I start a record, I get this message on cameradisplay:

hackerror at 0
expected e3a00032, got 0


What´s wrong, what can I do?

(latest mlv-sources from g3gg0-repo)

Edgar
Title: Re: 600D and MLV: hack error
Post by: g3gg0 on October 14, 2013, 12:30:27 AM
does the same happen with the original raw_rec?
Title: Re: 600D and MLV: hack error
Post by: 1% on October 14, 2013, 02:11:24 AM
Did you add the 600D timer address?

cam_600d ? 0xFF37AA18
Title: Re: 600D and MLV: hack error
Post by: Rewind on October 14, 2013, 04:58:18 AM
The same behaviour with 650D and 550D (original raw_rec from latest nightlies)
What are the timer addresses for these cameras and where should we add them?
Title: Re: 600D and MLV: hack error
Post by: Doyle4 on October 14, 2013, 02:43:03 PM
Iv noticed this for awhile now, have posted in Nightly's but didnt hear back, dont know how to code either, sorry :(
Title: Re: 600D and MLV: hack error
Post by: Rewind on October 14, 2013, 03:11:57 PM
I think this is the section of raw_rec.c, where we should add the addresses for orther cameras:

/* change dialog refresh timer from 50ms to 8192ms */
        uint32_t dialog_refresh_timer_addr = /* in StartDialogRefreshTimer */
            cam_50d ? 0xffa84e00 :
            cam_5d2 ? 0xffaac640 :
            cam_5d3 ? 0xff4acda4 :
            cam_7d  ? 0xFF345788 :
            cam_700d ? 0xFF52B53C :
            /* ... */


But how we should figure these addresses out for 550D, 650D and others?
Title: Re: 600D and MLV: hack error
Post by: escho on October 14, 2013, 04:12:16 PM
Quote from: g3gg0 on October 14, 2013, 12:30:27 AM
does the same happen with the original raw_rec?

Yes, the same happens on original ML.

I wrote 1% proposal into my clone of original ML (raw_rec.c)and compiled the module new. But no changes. The same error as before.

Edgar
Title: Re: 600D and MLV: hack error
Post by: 1% on October 14, 2013, 05:42:37 PM
Did you do it right, because I don't get the error, timers slow down and it still checks the address its patching.

https://bitbucket.org/OtherOnePercent/tragic-lantern-2.0/src/fe768c4e30178ab7625346d8530e6b135c92a11d/modules/raw_rec/raw_rec.c?at=unified
Title: Re: 600D and MLV: hack error
Post by: escho on October 14, 2013, 11:15:12 PM
Oh, I did forget raw_rec_ini. Now the error has gone. I will do some more tests tomorrow evening.

ThankYou 1%

Edgar
Title: Re: 600D and MLV: hack error
Post by: escho on October 15, 2013, 08:45:02 PM
Fixed for 600D. Did a pull request to ML. I hope, this will go into MLV too one day.

ThankYou for your help

Edgar
Title: Re: 600D and MLV: hack error
Post by: g3gg0 on October 15, 2013, 10:18:35 PM
merged, can you test?
Title: Re: 600D and MLV: hack error
Post by: escho on October 15, 2013, 10:50:42 PM
Tested. Runs fine without hack error.  :)

Edgar
Title: Re: 600D and MLV: hack error
Post by: mk11174 on October 16, 2013, 09:31:22 AM
Quote from: Rewind on October 14, 2013, 03:11:57 PM
I think this is the section of raw_rec.c, where we should add the addresses for orther cameras:

/* change dialog refresh timer from 50ms to 8192ms */
        uint32_t dialog_refresh_timer_addr = /* in StartDialogRefreshTimer */
            cam_50d ? 0xffa84e00 :
            cam_5d2 ? 0xffaac640 :
            cam_5d3 ? 0xff4acda4 :
            cam_7d  ? 0xFF345788 :
            cam_700d ? 0xFF52B53C :
            /* ... */


But how we should figure these addresses out for 550D, 650D and others?
Found it for 550D cam_550d ? 0xFF2FE5E4
Title: Re: 600D and MLV: hack error
Post by: Rewind on October 16, 2013, 12:16:36 PM
Quote from: mk11174 on October 16, 2013, 09:31:22 AM
Found it for 550D cam_550d ? 0xFF2FE5E4

That's great. Would you mind to describe the process of this finding a little bit in order we can get this address for 650D?

UPD. thanks to mk11174, now we have the right one for 650D: 0xFF527E38
Title: Re: 600D and MLV: hack error
Post by: g3gg0 on October 16, 2013, 12:52:00 PM
can you make a pull request, so i can merge it from here? (not at home at the moment)
Title: Re: 600D and MLV: hack error
Post by: mk11174 on October 17, 2013, 02:47:17 AM
Quote from: g3gg0 on October 16, 2013, 12:52:00 PM
can you make a pull request, so i can merge it from here? (not at home at the moment)
I made the pull request and it was merged  :)