Due to the stretching we need some strange frame heights to come up with 16:9 aspect ratio. here is a list:
To Get : need this
----------------------------------
720x400 => 720x 239 (240 stretches to 400 when multiplied by 1.67 aprox)
960x540 => 960x322
1280x720 => 1280x430
1320x740 => 1320x442
1440x810 => 1440x484
1600x900 => 1600x538
1720x960 => 1720x574
1880x1060 => 1880x633
1920x1080 => 1920x645
Ok so if the stretch ratio (1.674) does not change then we could make use of 239, 322,430, 442, 484, 538, 574, 633, and 645 pixels for frame height.
I tried adding this myself but got errors so we need, when time is available, to have some help from our DEVs.
Thanks for all of this wonderful stuff you are providing us.
This should do the trick (although I didn't try it on 5D3, will do tonight).
http://bitbucket.org/hudson/magic-lantern/commits/2c2ee3590af5
Quote from: a1ex on May 23, 2013, 04:22:38 PM
This should do the trick (although I didn't try it on 5D3, will do tonight).
http://bitbucket.org/hudson/magic-lantern/commits/2c2ee3590af5
Holy Mother of God! This is way awesome. Your implementation is brilliant!!
It kills four birds with one gem!
Bird one: Ease of selection for aspect ratio.
Bird two: Simplifies the process of selecting height x width.
Bird three: Optimizes the use of the hardware by selecting just the right height based on aspect ratio.
Bird four: Implements all of the above for squashed frames at 60fps.
I think 720/60FPS is a separate fix.
Noo 4 in 1
Also dont try on 5D3 the following frame combinations, your camera may explode..
1880x1058 29.9 fps aspect ratio 16:9
1320X742 29.9 fps aspect ratio 16:9
ALSO AT 24 FPS
So you have lockups too...
Yea, Alex will look at it tonight.
We looked so far with no solution. Some Y resolutions get no love from edmac copy rectangle.
TEsted on 5D3 2c2ee35
OK, so here is the complete list of incompatible camera exploding frames. Don use them >:(
Aspect Ratio 3:1
1928x642
1880x626
1720x574
Aspect Ratio 2:39
1928x806
1880x786
Aspect Ratio 2:35
1320x562
Aspect Ratio 16:9
1880x1058
1320X742
Aspect Ratio 3:2
1928x1286
1880x1254
1720x1146
Aspect Ratio 4:3
1320x990
On 5D3 with e0d9c48
The above frame picks have been corrected. Than you. I will be testing the 60 fps frames now.
Test completed on all aspect ratios and frame sizes no crash on 5D3 e0d9c48.
Is it possible to have the width squashed rather then the height?
Anamorphic 1440x1080 for example.
It's not possible we don't know how to change sensor sampling modes.
read, compare and understand:
http://upload.g3gg0.de/pub_files/f00fa2c2cea01ee32408009b6e02fcc6/ADTG_CMOS_Writes.7z
this is only the data written to ADTG and CMOS.
try to find out as much about the registers as you can.
if all that is understood, then we have about 10% of the necessary stuff for custom resolutions.
good luck ;)
Quote from: 1% on May 23, 2013, 06:40:47 PM
I think 720/60FPS is a separate fix.
Hi. What is necessary to get that done? I read about 1920x6xx 60 fps, and I read about 1280x720 24fps, so what is the issue with 1280x720 60fps exactly?