Idea: http://www.magiclantern.fm/forum/index.php?topic=3487.msg17859#msg17859
(and I've also forgot picture quality to JPEG after clearing the settings)
So, I've added a framework where ML can warn you if you change some settings by mistake. I've started with what I'd use:
- Mode: other than M
- Picture quality: other than RAW
Code: https://bitbucket.org/hudson/magic-lantern/changeset/7c3541430760
What other settings can benefit from such warnings?
From the top of my head:
For video mode :
- FPS + Res combo, altough it may be a PITA to code due to different cameras having different settings
- AGC / Manual sound level (for cameras that have it buried in canon menus)
For stills shooting;
- Colorspace (altough the default is sane enough)
I've also added ALO, since there was someone who had exposure problems even if he had manual exposure enabled.
Here's how to add a warning for some arbitrary feature: https://bitbucket.org/hudson/magic-lantern/changeset/cce4e41fc6a5
what about this?
static void warn_step()
{
warn_code = 0;
- if (warn_mode == 1 && shooting_mode != SHOOTMODE_P)
+ if (warn_mode == 1 && shooting_mode != SHOOTMODE_P && !is_movie_mode())
warn_code |= 1;
- if (warn_mode == 2 && shooting_mode != SHOOTMODE_TV)
+ if (warn_mode == 2 && shooting_mode != SHOOTMODE_TV && !is_movie_mode())
warn_code |= 1;
- if (warn_mode == 3 && shooting_mode != SHOOTMODE_AV)
+ if (warn_mode == 3 && shooting_mode != SHOOTMODE_AV && !is_movie_mode())
warn_code |= 1;
- if (warn_mode == 4 && shooting_mode != SHOOTMODE_M)
+ if (warn_mode == 4 && shooting_mode != SHOOTMODE_M && !is_movie_mode())
warn_code |= 1;
when in movie mode is clear we are not in a photo mode and the warning is annoying, not?
Correct, I've written this feature with 5D-like cameras in mind (where movie mode is a separate switch, so you can film in M, P, Tv, Av etc).
This would need an ifdef in internals.h to know which cameras have a separate movie mode and which not.