https://bitbucket.org/miyake_t/magic-lanternmenuextend
Now we got liberty from screen size limitation.
Great job!
Ah, I never think about dynamic show/hide menu_entry.............Need little bit more.
MSG added
Solved issues. currently not freeze any scenes. Dynamic add/del is little bit strange. I'm find the reason now.
OK. All problems was gone. If you have compile environment, please test it and feedback please.
Excellent, I'll test it later when my PC is resurrected from the deads :P
Do you think we can add scrolling to submenus too?
Tested advanced_hide_menu() and another normal menu functions.
It's fine .
And submenu things. May be we can use it. But we also need to add difficult codes.
So I think , We design a lot of global menu and few sub menus.....now....
Do you want to try to add codes ?
Major awesome, have to absorb it in. No more menus covered up.
I know that You 1% like this functions.(lol
Your hacking is everytime a lot of additional menus. ;)
Yup, merged. No problems. I think focus menu scrolled up when lens data is enabled but thats ok.
1%
It's same as normal firmware. So I think it is no problem.
68d9dd6d5240 add exception for audio(meter space) and focus(lens info)
I found one more issue from 1%'s comment.
Now lens info is always showing.
and added miner action tweak. More good feeling now.
Thanks miyake! Great work!
Feel free to open a pull request when think you're done
wow that demo looks great!
@nanomad
made pull request.
Please proceed it.
One little thing, did you test it with semi-transparent menus too? (like shutter control while recording)
Forget it. But just tested quickly.
I can't find problems.
Great, should be merged by the end of the day
Nice work Miyake! :)
Pull requests suck, I'm going to merge stuff manually so it will take a bit longer :-\
?? why you need to merge it?
Pulled code a already merged to unified. So you just type "hg pull, hg update" only I think.
Left the warning in menu.c I think.
I just clone current repo.
But menu.c has no warning.
https://bitbucket.org/hudson/magic-lantern/src/04ef6f499dc2/src/menu.c
beta warning.
Ah, I see.
That, and I would have loved to have separate pull requests for audio and menus. But a1ex just accepted the full pull request it so....
Thanks miyake :P
Quote from: nanomad on September 20, 2012, 08:57:03 AM
That, and I would have loved to have separate pull requests for audio and menus. But a1ex just accepted the full pull request it so....
Doesn't work on 60d (should it? anything else required except replacing autoexec.bin?), ml menu simply refuses to show :-\
Works on my 60D, including scroll.
Quote from: a1ex on September 20, 2012, 11:14:00 AM
Works on my 60D, including scroll.
After the last "-O3 fix", it now also works again if compiled w/ Linaro 4.7 :-)
Current menu has no overflow menu items. If you add new menu item and it's will be overflow from display size, You can see vscroll.
Quote from: nanomad on September 20, 2012, 08:57:03 AM
That, and I would have loved to have separate pull requests for audio and menus. But a1ex just accepted the full pull request it so....
Thanks miyake :P
I made a separate pull request. First I make a scroll menu pull request and then I confirmed pulled.
After that, I make a audio pull request.
Or Do you think that make a your own patch and push it? It's not good , because commit log will be lost.
No, yesterday I was so tired I didn't notice that :(
My bad
Bug report: in Overlay menu (11 items) and Focus menu (9 items), pressing UP on first menu entry causes it to disappear. No scrolling is needed, no scrollbars appear (that part is OK).
I thought it has no problem to use it. So I didn't add exception for simple implementation.
But you feel uneasy, I will solve it.
Give me a few time for solving it. More consider for beautiful code design.
Congratulations, you did a fantastic job. This functionality can be very useful for the project.
All problem was gone, and made a pull request.
Now need to consider that take out from submenu for fast operations.
I'm changed 600D audio gain/boost from submenu. We don't need to open/close submenu when we change 600D audio volumes!!
Works great here.
Same on the mighty 1100D ;)