Magic Lantern Forum

Experimental builds (WIP) => crop_rec and derived builds => Topic started by: theBilalFakhouri on April 01, 2023, 06:37:50 PM

Title: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 01, 2023, 06:37:50 PM
(OP was updated 17/04/2023)

-What's included in this topic, quick toggle:

● April 01 announcement (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#aprilfirst)    ● Preview evolution (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#previewevo)                  ● Crop mood presets (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#presets)
● It's a new source-code (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#newsource)    ● Build features (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#features)                      ● Known issues (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#issues)
● Supported models (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#models)          ● My status with ML (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#mystatus)                ● Thanks (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#thanks)
● Crop mood or Crop mode? (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#moodormode)
● Build walkthrough video (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#buildwalkthrough)  ● Fundraiser campaign (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#campaign)            ● It's online! (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#online)
● Downloads (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#downloads)                      ● Source code (https://www.magiclantern.fm/forum/index.php?action=post;msg=242974;topic=26851.0#magic)


Quote from: theBilalFakhouri on July 01, 2018, 04:34:54 PMAlso I am trying to figure out how to expand the cropped area of LiveView in x5 .. A real time correct framing in 2520x1080 like normal 1080p  ;D .

Quote from: theBilalFakhouri on July 01, 2018, 04:34:54 PMThis is the next big thing will happen to ML .

That was me back in 2018 when I was dreaming about previewing the beloved custom RAW video moods in real-time,
in 2020 (https://www.magiclantern.fm/forum/index.php?topic=25287.msg230160#msg230160) I was wondering if it's even possible on our DIGIC 5 cams from ~10 years old . . Well, after hunders of hours and experiments on one of the most complex thing in our cameras . . it turns out yes:

(https://i.ibb.co/bmzYTqB/Entry-Level-DIGIC5-Family.jpg)


Today, I am very proud to the announce a new major improvement coming to ML RAW video crop moods:

The Full Real-Time Preview


(Direct YouTube link: Crop mood - WYSIWG Edition) (https://www.youtube.com/watch?v=pEVRblaE92E)

-Preview evolution:

[gifv]https://i.imgur.com/ti7NDyX.mp4[/gifv]


(2.5K 1:1 preset as example)


-Crop moods (presets):

All of old presets which were in current custom crop_rec_4k builds (https://www.magiclantern.fm/forum/index.php?board=66.0) (either from me or Danne) are here, some of them were fine-tuned (more Time-Lapse presets can be added later).
Beside that, there are new presets, and they were organized depending on sensor Binning mode as following:

Crop mood have four main options:

-1:1 crop:

Centered crop on sensor, no pixel binning/skipping in this mode.

(https://i.ibb.co/wShMh15/1x1-crop-c-00000.png)

-FRTP:      Full Real-Time Preview.
-Cropped: Has centered cropped real-time preview.
-Crop factor calculation is based on Full frame sensor size.

-Full-Res LV preset has working preview for the first time. You can record 5208x3478 @ 3 FPS continuously in 14-bit lossless (240 MHz, hacks enabled, sound recording off) :) .


-1x3:

a.k.a Anamorphic, reads all vertical pixels, reduces aliasing and moire.

There are three choices for 1x3 preset for each aspect ratio, I made it like this:

-Note:

EOS M and 100D have slightly slower sensor compared to 650D / 700D (hardware limitation),
this limit affects some few 1x3 anamorphic presets (either slightly lower FPS or resolution) as the two tables shows, on the left 650D / 700D list, on the right EOS M / 100D list:




650D / 700D
EOS M / 100D
(https://i.ibb.co/3zt6GGn/1x3-Anamorphic-650-D-700-D-Color.png)(https://i.ibb.co/JpVqrsZ/1x3-Anamorphic-EOS-M-100-D-Color-2.png)

-All of these presets have Full Real-Time preview.
-Crop factor calculation is based on Full frame sensor size.


-3x3:

1080p mode and experimental High Framerate options.

-Notes:
100D has slightly lower FPS compared to 650D / 700D / EOS M because of newer sensor version and currently it causes FPS limit.
1080p preset made mainly for EOS M, other models don't really need it.




650D / 700D / EOS M
(https://i.ibb.co/wKgytZH/3x3-HFR-and-1080p-650-D-700-D-EOSM.png)




100D
(https://i.ibb.co/3FTydhc/3x3-HFR-and-1080p-100-D.png)

-All of these presets have Full Real-Time preview.
-Crop factor calculation is based on Full frame sensor size.
-In 3x3 presets and sometime while idle (not recording) the preview would be black, setting focus box below center or just start recording will make the preview work again.


-New source-code and build:

A new source-code had to be written for many good reasons:


-Build features:

-Known issues:


-Other models support:

-This work is applicable to DIGIC 5 models (without plus, entry-level models):
 EOS M2 port should be easy, will try to port in future (I will need a volunteer for running tests), also EOS M2 shares the same sensor as in 100D.

-DIGIC 5+:
They have diffrenet preview implementation than DIGIC 5 (without plus, 650D / 700D / EOS M / 100D / EOS M2)
Which mean current preview work can't be ported to 5D3, it needs to be reverse engineered which also means a lot of time and work.

I have started working on preview for 5D3 this year (https://www.magiclantern.fm/forum/index.php?topic=25287.msg242336#msg242336), I found some pieces but still missing a main piece. I stopped working last month on 5D3 (to finish the new preview work on entry-level models).
I might continue working on 5D3 this or next month.


-My status with ML, why it's not for free:

I became a ML user back in 2017, in 2018 I started digging into dev stuff, and since then I could give many improvements (with help from other devs) and some of my time to ML project for free until Q3 of 2022.
Unfortunately, I can't do that this way anymore due to increasing responsibility in real life :(, last year I had to make one of the following two choices behind the scenes:

1. Either stop working on ML and move on
2. Charge for the new things I worked on

Obviously *I chose the second option, like what I did with the new sd_uhs last year (https://www.magiclantern.fm/forum/index.php?topic=26634.msg240127#msg240127). I believe the second option is a win-win option.
*I didn't make this choice alone, because without you (the ML community) and your support, there is no second option.

The policy I did choose:
I am offering a feature that works (as described) and already tested, the guarantee of success is very high if not 100% :)
That also means the risk of failure was already taken by me, e.g. I have risked +300 hours working on real-time preview while I could just fail.

I am always open to suggestions and discussion, feel free to discuss.


-Thanks:
-Danne and Walter for providing logs from EOS M and 650D, also running tests.
-ilia3101 for running tests on EOS M, also for his special support, he is going to handle the fundraiser stuff yet again.
-For users who contributed to buy me a 100D (https://www.magiclantern.fm/forum/index.php?topic=26250.msg239078#msg239078), without their support --> 100D port wouldn't happen.
-masc for running tests and for creating crop mood on EOS M demo (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243227#msg243227)
-For people who supported me either by donations or words, I appreciate it!


Speaking of naming - mood or mode?

Originally it was named "crop mode", I changed the word from "mode" to "mood" as some kind of joke (punning) in 1st April.
Crop mode or crop_rec.mo module allows to recrod in higher resolution (beside other things) compared to native resolutions provided by Canon.

First crop_rec.mo (crop mode) version was made in 2016  (https://www.magiclantern.fm/forum/index.php?topic=17021.0)by a1ex and it was only for 5D3, back then it could only enable x3 crop to 720p and 1080p video modes, then in 2017  (https://www.magiclantern.fm/forum/index.php?topic=19300.0)another version (second version) of crop_rec.mo (crop mode) came out which introudced high resolutions presets for first time (e.g. 3K and UHD) beside other stuff, it was only for 5D3 too.

In 2018  (https://www.magiclantern.fm/forum/index.php?topic=19300.msg197697#msg197697)I jumped beside other devs and started porting crop_rec.mo to other models.
Main downside for crop_rec.mo presets (crop_rec.mo 2017-2018 versions) was the preview, you couldn't preview what are you recording in real-time.

crop_rec.mo (crop mood), a 2023 version (this thread), the correct real-time preview was presented to mostly all presets (entry-level cams), beside other tweaks.

Initially I wanted to rename "crop mood" back to "crop mode" after the second release, but I kept it that way because:

1-It would be easier just to say "I am using crop mood", because we already have many "crop mode" versions.
2-It could be a reminder that's an unofficial build, but a community build.

Last thing, I am using "crop mood" in two places:

1- "crop mood" for "crop_rec.mo" module
2- "crop mood" in the build naming: a crop mood build simply means this build include crop_rec.mo (crop mood), the 2023 version.


Okay, here we go:
Crop mood - Build Walkthrough


(YT Link: Crop mood - Build Walkthrough (https://www.youtube.com/watch?v=V0M7n2cAHMM))

-The video shows what to expect from the build
-The build will work in the same way on 650D / 700D / EOS M / 100D
-You missed reading the first post? I will read it because it has useful info (https://www.magiclantern.fm/forum/index.php?topic=26851.0)



Crop mood - WYSIWYG Edition Campaign

(https://i.ibb.co/M8j2FJm/Goal-Reached.png)

Goal reached!

-Pricing: 2214 GBP
-PayPal, debit and credit cards are supported

-Every donation will make us one step closer to a release date.
-You are paying for the things that have been done at its current state.

-Once we reach our goal, both the source-code and the build will be released to everyone!
-Now the thing is forward to ML community hands :)




Crop mood - It's online!



The new crop mood build versions will always be in this link:

Crop mood builds - Downloads (https://bitbucket.org/bilal_fakhouri/crop-mood-builds/downloads/)

(Build is available for 650D / 700D / EOS M / 100D)


-Source code:
 Reveal the magic! (https://github.com/bilalfakhouri/magiclantern_hg_02/commits/crop_rec_4k_mlv_snd)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: petabyte on April 01, 2023, 07:01:07 PM
First ML on ML (https://www.magiclantern.fm/forum/index.php?topic=26850.msg242969#msg242969), then my Fuji DOOM port (https://fujihack.org/doom.html), and now this. Too many amazing things happening today 8)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: elenhil on April 01, 2023, 07:20:42 PM
I don't really know what to think. On the one hand, it is April Fools Day. In the other hand, ML devs seem have a tendency to announce mind-blowing breakthroughs on precisely that date.

Отправлено с моего SM-G960F через Tapatalk

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 02, 2023, 12:40:06 AM
Is it for real? You said you were working on this and showed your progress, but what you show on the video is hard to believe... it would really be the last big step that was missing  :o
I will wait a couple of days to be sure, but the fact that you put a price, gives me hope :D

PS: How can I contribute to the goal?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: SebastianC on April 02, 2023, 05:32:21 AM
I believe you can do it Bilal, and I hope the day will quickly come true, hope eos 100d the 3k 1x1 will get a long time for every shot! because I am keener on 1x1 mode than ever!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mattia on April 02, 2023, 08:17:28 AM
That's a really amazing improvement, Bilal! You've got some real skills, seriously! But... what about us alone and forgotten and sad and abandoned 5d3 users? Is there any hope for us?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 02, 2023, 08:21:58 AM
Nothing more to believe here. I tested all presets on my eos m. They are solidly working as described. Not sure why we are riding on a1ex April 1st date but so be it.

Hopefully the community will value this code very high. It's sort of the final piece of the puzzle. I will put in a few dollars too of course. I really want to see the code  :P.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 02, 2023, 12:07:55 PM
Quote from: kitor on April 01, 2023, 09:15:02 PM
And for users who are wondering, the contents of the announcement video (https://www.youtube.com/watch?v=pEVRblaE92E), also the topic . . were 100% real :)

Will update the first post with more info and details and what expect from this build soon. Will update pricing details and payment methods after that.
Yes, it's real :D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: notthesame on April 02, 2023, 09:17:33 PM
Quote from: Mattia on April 02, 2023, 08:17:28 AM
That's a really amazing improvement, Bilal! You've got some real skills, seriously! But... what about us alone and forgotten and sad and abandoned 5d3 users? Is there any hope for us?

:) I'm now in the same boat: could finally get a 5d3 for cheap. After using Magiclantern on my EOS M since a couple of years. I thought I should finally switch to the Rolls-royce of Magiclantern cameras. Haven't tested much yet: but certainly the quality is improoved and Magiclantern seems more responsive. But, I also see now more clearly the biggest benefit of the EOS M: the size and weight compared to the 5d3 is a factor which I greatly underestimated. EOS M is the perfect travel and always with me cam. The 5d3 in comparison is really, really big and heavy. Still I hope now, that also 5d3 will get improovements.

Thank you so much Billal for always pushing Magiclantern to new heights!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: RumiG on April 02, 2023, 11:20:26 PM
I'm so excited about the development of this camera, l hope the best for the developers, and will support them 👍

AWESOME JOB!!

TO THE MOON 😁
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Grognard on April 03, 2023, 08:47:25 AM
Awesome! Now it's just perfect ! Is it the last update? :D Only minor  improvements could be done in the futur: real 24 FPS instead of 23.976, 280 MHz overclock, FRTP in 3k mode etc..
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Grognard on April 03, 2023, 08:53:29 AM
Quote from: notthesame on April 02, 2023, 09:17:33 PM
The 5d3 in comparison is really, really big and heavy. Still I hope now, that also 5d3 will get improovements.

Yes it's bigger and heavier but it's still a light cam if we compare to an Arri ;) But it's more stable than the M depending of your configuration.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mattia on April 03, 2023, 11:13:14 AM
5d3 it's for sure heavier compared to the M but still way lighter than a Red or an Alexa. And it's a full frame! That's for sure the main advantage over the M, other than being much more responsive, in my opinion.

To have some frtp modes on the 5d3 would make this camera a serious competitor of way more expensive cinema cameras.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ilia3101 on April 03, 2023, 10:38:28 PM
I've had early access on my EOS M. It's 100% real. WYSIWYG.

But there's more...

This feels like magic lantern did in 2016, the menus are snappy, doesn't slow down the camera, and there's almost no bugs/crashes (this actually applies to the 5D3 as well ;))

This is the best Magic Lantern we've ever had.

Bilal is doing amazing work. I can't thank him enough.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ilia3101 on April 03, 2023, 10:44:05 PM
Quote from: Mattia on April 03, 2023, 11:13:14 AM
That's for sure the main advantage over the M, other than being much more responsive, in my opinion.

Oh you'll see about reponsiveness ;)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: pmiramon on April 04, 2023, 12:40:23 AM
Quote from: ilia3101 on April 03, 2023, 10:38:28 PM
I've had early access on my EOS M. It's 100% real. WYSIWYG.

But there's more...

This feels like magic lantern did in 2016, the menus are snappy, doesn't slow down the camera, and there's almost no bugs/crashes (this actually applies to the 5D3 as well ;))

This is the best Magic Lantern we've ever had.

Bilal is doing amazing work. I can't thank him enough.

What good news! It is even better than expected. Each new piece of information is more exciting than the last. We will be happy to support!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 04, 2023, 04:15:09 AM
Thanks everyone!

I have added info/details about the new build in the first post (https://www.magiclantern.fm/forum/index.php?topic=26851.msg242974#msg242974) beside other related stuff.
Will add some more pictures and videos show how the build work too. You should take a look :D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: SebastianC on April 04, 2023, 05:10:10 AM
Very excited!!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 04, 2023, 07:11:39 AM
It gets better and better!
Money more than well deserved, no need for justification, results speak for themselves  :D
I paid 100€ for vlog on a GH4 back in the day, that was unjustified  >:(

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on April 04, 2023, 06:32:23 PM
Now 700D/650D/100D/EOSM are Alexa Classic/XT in a much better ergonomic body, much better battery life, much more affordable media, and with sound!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on April 04, 2023, 06:59:08 PM
EOS M? Ergonomic? Used in one sentence?
Boy!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 04, 2023, 10:00:38 PM
Quote from: Mattia on April 02, 2023, 08:17:28 AM
But... what about us alone and forgotten and sad and abandoned 5d3 users? Is there any hope for us?

I have already answered this question here (https://www.magiclantern.fm/forum/index.php?topic=25287.msg242540#msg242540). Also re-answered in first post (https://www.magiclantern.fm/forum/index.php?topic=26851.msg242974#msg242974) in this topic.
You have chosen a great model with a great hardware, and with great hardware comes great complexity :P

Please don't hold your breath and remember that I may not figure out how preview works on 5D3. I believe the hardware is powerful enough though (take entry-level models as great Proof of Concept).
These kind of stuff may take years or may not happen. I think if there are more devs who are interested to work on this very thing, the progress might be faster. Too bad currently I am the only one.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 04, 2023, 10:08:01 PM
Quote from: Grognard on April 03, 2023, 08:47:25 AM
Only minor  improvements could be done in the futur: real 24 FPS instead of 23.976, 280 MHz overclock, FRTP in 3k mode etc..

Actually, real 24 FPS can be done easily, would you even notice the diffrence?
Limited FRTP in 3K preset is possible, currently it would be limited to 2868 width and the remaining 204 pixels will be black. I think somehow we may exceed 2868 limit too, might figure it out in 2026 :P
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Grognard on April 04, 2023, 10:29:17 PM
Quote from: theBilalFakhouri on April 04, 2023, 10:08:01 PM
Actually, real 24 FPS can be done easily, would you even notice the diffrence?

Yes it's usefull for making a DCP or when we mix rushes from another camera in 24fps with 23.976 fps without sound shift.


Quote from: theBilalFakhouri on April 04, 2023, 10:08:01 PM
Limited FRTP in 3K preset is possible, currently it would be limited to 2868 width and the remaining 204 pixels will be black. I think somehow we may exceed 2868 limit too, might figure it out in 2026 :P

In the next episode  :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: pmiramon on April 05, 2023, 12:37:59 AM
Quote from: Grognard on April 04, 2023, 10:29:17 PM
Yes it's usefull for making a DCP or when we mix rushes from another camera in 24fps with 23.976 fps without sound shift.

This is interesting! I knew that with the free software DCP-o-matic you can transform from 23.976 to 24fps DCP, but with the slight pitch variation in the audio (I don't know how noticeable it is). Clearly, 24 fps native would make things easier.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Ernani on April 06, 2023, 02:27:51 AM
Quote from: ilia3101 on April 03, 2023, 10:44:05 PM
Oh you'll see about reponsiveness ;)

Any news about the crowd funding yet? We're amped up! (Iknow I am)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 06, 2023, 06:00:31 AM
Quote from: Grognard on April 04, 2023, 10:29:17 PM
Yes it's usefull for making a DCP or when we mix rushes from another camera in 24fps with 23.976 fps without sound shift.

I see, well, it won't be real 24.000 FPS, but it will be in 24.00X to 24.0XX range depending on the preset (more accurately, on FPS Timers).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 06, 2023, 06:01:02 AM
Quote from: Ernani on April 06, 2023, 02:27:51 AMAny news about the crowd funding yet? We're amped up! (Iknow I am)
It will probably start in less than 36 hours :)
Will let you know once it's online!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Grognard on April 06, 2023, 10:53:42 AM
Quote from: theBilalFakhouri on April 06, 2023, 06:00:31 AM
I see, well, it won't be real 24.000 FPS, but it will be in 24.00X to 24.0XX range depending on the preset (more accurately, on FPS Timers).

Thank you. The closest is better than nothing.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Grognard on April 06, 2023, 11:23:25 AM
Quote from: theBilalFakhouri on April 04, 2023, 10:08:01 PM
Limited FRTP in 3K preset is possible, currently it would be limited to 2868 width and the remaining 204 pixels will be black.

Before you will find a new magic trick... and I'm sure you will ;) I wonder if the missing data is necessary on the right part of the screen or if it can also be on the left part and if they are a way to switch between the two screens each frame or toggling with info button.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Fabsrl88120 on April 06, 2023, 02:33:18 PM
leBilalFakhouri, thank you for your impressive work. Are you going to develop it on the 70 d?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 06, 2023, 03:00:10 PM
Quote from: Grognard on April 06, 2023, 10:53:42 AM
Thank you. The closest is better than nothing.

Will try to implement an option to round FPS as close as possible to 24.000 FPS, it should be an easy task, why not.

Quote from: Grognard on April 06, 2023, 11:23:25 AM
Before you will find a new magic trick... and I'm sure you will ;) I wonder if the missing data is necessary on the right part of the screen or if it can also be on the left part and if they are a way to switch between the two screens each frame or toggling with info button.

Thanks, I didn't make a try to balance the missing part of frame in both left and right sides yet it could be possible.
Switching the preview each frame more likely will cause corrupted frames while recording, still not quite sure yet.

Will take a further look in future!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 06, 2023, 03:11:38 PM
Quote from: Fabsrl88120 on April 06, 2023, 02:33:18 PM
leBilalFakhouri, thank you for your impressive work. Are you going to develop it on the 70 d?

Thanks, 70D has same preview implementation as in 5D3 and 6D which is different from entry-level models. Current preview stuff can't be ported to 5D3 / 70D / 6D.
More work will be needed for these models, if we could control the preview on 5D3 that would mean 70D will benefit from same research, also 6D.

Already answered (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243065#msg243065) the current state of my preview work on 5D3. I might document the initial findings for 5D3 on the forum in future in case if someone would help.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: amitkattal on April 06, 2023, 03:13:19 PM
Quote from: theBilalFakhouri on April 06, 2023, 03:00:10 PM
Will try to implement an option to round FPS as close as possible to 24.000 FPS, it should be an easy, why not.

Thanks, I didn't make a try to balance the missing part of frame in both left and right sides yet it could be possible.
Switching the preview each frame more likely will cause corrupted frames while recording, still not quite sure yet.

Will take a further look in future!
Or another alternative could be is to not have 204 black pixels on one side but rather have 102 black pixels on either side. Since most people focus on things in center of frame anyway and also it would look less jarring.

You can take such ideas and take time and release such things as "add ons" for your crop mood build. especially if u come up with more improvements and more ideas and still keep this build as perfect as possible.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: pmiramon on April 06, 2023, 04:12:35 PM
Quote from: theBilalFakhouri on April 06, 2023, 03:00:10 PM
Will try to implement an option to round FPS as close as possible to 24.000 FPS, it should be an easy task, why not.

Thank you Bilal, we will keep an eye out for the crowfunding announcement!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 06, 2023, 05:13:02 PM
Quote from: amitkattal on April 06, 2023, 03:13:19 PM
Or another alternative could be is to not have 204 black pixels on one side but rather have 102 black pixels on either side. Since most people focus on things in center of frame anyway and also it would look less jarring.

Yes, that's exactly what I meant. I will dig into it in future and will check its possibility to happen.
Even if it wasn't possible I will make a limited FRTP for 3K preset in future releases (it will still be way better than Canon cropped preview, even with a black bar).

Quote from: amitkattal on April 06, 2023, 03:13:19 PM
You can take such ideas and take time and release such things as "add ons" for your crop mood build. especially if u come up with more improvements and more ideas and still keep this build as perfect as possible.

Yes, that's what I was aiming for in first place :) , in addition when the source code get realased, anyone will be able to contribute too.
Also, the future improvements from my side will be for free as long as it don't take me hundreds of hours of work or a lot of effort.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: BatchGordon on April 07, 2023, 05:17:02 PM
About the crowdfunding, maybe someone will not agree, but why not impose an upper limit on the money offered by each individual person, perhaps around 15/20 dollars?

I don't want to be misunderstood, I certainly don't intend to devalue the work done by Bilal, which I consider extraordinary and incredibly superior to what he asks in return.
I only believe that crowdfunding is good when there is broad participation, in which many people can and are in some way encouraged (if not "forced") to contribute.

By the way, last time, when I saw the subscription, it was already closed thanks to a few generous users. This time I really want to contribute.  :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 07, 2023, 05:52:58 PM
@BatchGordon

Thanks!

Anyone can donate as much as he can, there are no lower or upper limits . . what's the problem with that?
Any amount is welcome.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: andy kh on April 07, 2023, 06:39:37 PM
Quote from: theBilalFakhouri on April 07, 2023, 05:52:58 PM
@BatchGordon

Thanks!

Anyone can donate as much as he can, there are no lower or upper limits . . what's the problem with that?
Any amount is welcome.
he is the only one who has problem. there will always be someone like him on the forum
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 07, 2023, 09:04:17 PM
Okay, here we go:

Crop mood - Build Walkthrough



(YT Link: Crop mood - Build Walkthrough (https://www.youtube.com/watch?v=V0M7n2cAHMM))

-The video shows what to expect from the build
-The build will work in the same way on 650D / 700D / EOS M / 100D
-You missed reading the first post? I will read it because it has useful info (https://www.magiclantern.fm/forum/index.php?topic=26851.0)


Crop mood - WYSIWYG Edition Campaign

(https://i.ibb.co/RC7VfV1/Pay-Pal-Crop-mood.png)

Take me there! (https://mlv.app/crop_mood)

-Pricing: 2214 GBP
-PayPal, debit and credit cards are supported

-Every donation will make us one step closer to a release date.
-You are paying for the things that have been done at its current state.

-Once we reach our goal, both the source-code and the build will be released to everyone!
-Now the thing is forward to ML community hands :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: vincentm on April 08, 2023, 04:32:42 PM
Done. It's not much, but money well spent, happy to pay my share.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: SebastianC on April 08, 2023, 06:04:17 PM
Pay money. I hope 5d3 is future!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Markus on April 08, 2023, 06:57:59 PM
I'm hoping for 5d3 but I sent some support right now. ;-)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 08, 2023, 09:17:01 PM
Quote from: vincentm on April 08, 2023, 04:32:42 PM
Done. It's not much, but money well spent, happy to pay my share.

Thanks! Every amount counts :)




Quote from: SebastianC on April 08, 2023, 06:04:17 PM
Pay money. I hope 5d3 is future!

Quote from: Markus on April 08, 2023, 06:57:59 PM
I'm hoping for 5d3 but I sent some support right now. ;-)

Thank you! as always, will try my best :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 08, 2023, 09:26:58 PM
-Status update:

First 24 hours were passed, 844 from 2214 GBP raised!
It's 38% from the goal.

I am really impressed, thank you for believing in the work I have done.
Thanks everyone for your support and your comments.

The campaign continues. Let me help (https://mlv.app/crop_mood)!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Grognard on April 08, 2023, 09:39:40 PM
Done!

My little contribution to your amazing work. You saved our money by avoiding to buy a new cam ;)
Thank you!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 09, 2023, 09:05:41 PM
Quote from: Grognard on April 08, 2023, 09:39:40 PM
Done!

My little contribution to your amazing work. You saved our money by avoiding to buy a new cam ;)
Thank you!

Thank you for your support :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 09, 2023, 09:15:10 PM
-Status update:

48 hours were passed, 1184 of 2214 GBP raised!
It's 53.4% of the goal.

The campaign continues. I will contribute! (https://mlv.app/crop_mood)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 09, 2023, 09:53:47 PM
If this update is not making every Magic Lantern user that can afford it to contribute, I don't know what will!  :D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mattia on April 10, 2023, 10:58:46 AM
Just donated even if I'm not an Eos M user anymore, I sincerely admire your work, Bilal! and I also hope you'll futher develop ML for 5d3 :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 10, 2023, 01:07:18 PM
Quote from: iaburn on April 09, 2023, 09:53:47 PM
If this update is not making every Magic Lantern user that can afford it to contribute, I don't know what will!  :D

Maybe I failed with making them excited :P
No pressure on anyone though!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 10, 2023, 01:11:50 PM
Quote from: Mattia on April 10, 2023, 10:58:46 AM
Just donated even if I'm not an Eos M user anymore, I sincerely admire your work, Bilal! and I also hope you'll futher develop ML for 5d3 :)

Thank you! I appreciate all the support. Definitely getting something working on 5D3 will me make more excited :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: amitkattal on April 10, 2023, 01:53:38 PM
Anyone know how to donate if paypal isnt supported in the country?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 10, 2023, 02:21:36 PM
Quote from: amitkattal on April 10, 2023, 01:53:38 PM
Anyone know how to donate if paypal isnt supported in the country?

I will need to know which the other option is valid for the donor so I can check (with ilia3101) the possibility if we can accpet it.
Cryptocurrency is valid option for me too if the donor used it before.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 10, 2023, 09:33:40 PM
-Status update:

72 hours were passed, 1279 of 2214 GBP raised.
It's 57.7% of the goal.

Who pressed the brake? Step on the gas (https://mlv.app/crop_mood)!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 10, 2023, 10:39:00 PM
On Facebook and Youtube it looks like Magic Lantern is still a thing, many people talks about it, but it's sad to see how the actual interest is lower than it seems  :(
I hope this project keeps on going for many years, driven by money or self-challenge, it doesn't matter.
Custom firmwares extending hardware functionality over the original purpose is more or less common on video games, but I think it's a unique case for cameras (leaving small hacks aside) and I'm a big fan of taking old hardware to the limit!
Let's give another push to the donations to keep the flow running  :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on April 10, 2023, 10:41:20 PM
Magic Lantern is not firmware!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 11, 2023, 06:58:36 AM
Quote from: Walter Schulz on April 10, 2023, 10:41:20 PM
Magic Lantern is not firmware!
True, but you get the point  ;)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 11, 2023, 12:11:05 PM
(https://i.ibb.co/9qFC1tL/Real-Time-00000.jpg)

Here (https://mlv.app/crop_mood)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on April 11, 2023, 01:13:27 PM
Quote from: iaburn on April 10, 2023, 10:39:00 PM
On Facebook and Youtube it looks like Magic Lantern is still a thing, many people talks about it, but it's sad to see how the actual interest is lower than it seems  :(

People mostly go to the fb group to ask questions and share their videos, so it will take a few days before everyone gets to see the announcement.
The other thing is that fb and YT compression makes the 1080p mode look "Acceptable" (And some of the members have so much talent that the images actually look quite good!)
Some time will be needed for people to realize how significant Bilal's latest work is (and what he means with the post with Drake in it, as some users never used those modes before  :) )
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ozcancelik on April 11, 2023, 04:09:46 PM
Paypal is banned in my country. I found a way and sent it. I'm waiting for the MK3 build, but it's okay if it doesn't come out. Thank you Bilal!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 11, 2023, 04:49:40 PM
Quote from: ozcancelik on April 11, 2023, 04:09:46 PM
Paypal is banned in my country. I found a way and sent it. I'm waiting for the MK3 build, but it's okay if it doesn't come out. Thank you Bilal!

Thanks for your intention to support! I have already talked about 5D3 status in first post .. I hope I get something on 5D3 in future.
Where are you located? Do you know other platforms which work in your country other than PayPal?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ozcancelik on April 11, 2023, 05:30:36 PM
Quote from: theBilalFakhouri on April 11, 2023, 04:49:40 PM
Thanks for your intention to support! I have already talked about 5D3 status in first post .. I hope I get something on 5D3 in future.
Where are you located? Do you know other platforms which work in your country other than PayPal?
Turkey. But I have friend from Netherlands and he already sent. And paypal is still best way i think. Problem is my country, not paypal [emoji3]

Thanks for interest.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 11, 2023, 08:20:01 PM
@ozcancelik

I see, thank you very much for your support!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 11, 2023, 09:11:50 PM
-Status update:

96 hours were passed, 1478 of 2214 GBP raised.
It's 66.7% of the goal.

Remaining: 736 GBP. Give your support if you can, Thanks! (https://mlv.app/crop_mood)

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 12, 2023, 10:01:56 AM
The real reason why donations slowed down, be brave! (https://mlv.app/crop_mood)
(https://i.ibb.co/StRmD3D/Donate-Button.jpg)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 12, 2023, 10:53:02 AM
Quote from: theBilalFakhouri on April 12, 2023, 10:01:56 AM
The real reason why donations slowed down

Very much on point...

Don't want to get political here, but same thing happens when people disagree with something and they wait for others to take the responsibility and the risk of public protesting.

It will help you, you'll benefit from it, so don't wait for others to do it for you  :(
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: whitelight on April 12, 2023, 01:52:52 PM
Donated a small amount on the 1st day, but I am ready to repeat the donation if the situation doesn't improve in a few days. Thanks for your work, Bilal!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: morero10 on April 12, 2023, 02:23:54 PM
first thank you Bilal for your great effort. I tried to donate and When I completed filling out the form, it gives me a message that there is a problem and I must try again. Is there a solution? I'm from morocco
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Bruno Italiano on April 12, 2023, 03:58:03 PM
I haven't seen this donation on the Facebook page of Magic Lantern? Maybe helping to encourage even more?

Mattia:
"Just donated even if I'm not an Eos M user anymore, I sincerely admire your work, Bilal! and I also hope you'll futher develop ML for 5d3 :)"
:)

Bruno Italiano:
"240mhz would improve 5d3?"

https://youtu.be/V0M7n2cAHMM
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 12, 2023, 05:42:21 PM
@iaburn

Of course we don't force anyone to donate, but some memes seem to encourage more people :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 12, 2023, 05:43:36 PM
Quote from: whitelight on April 12, 2023, 01:52:52 PM
Donated a small amount on the 1st day, but I am ready to repeat the donation if the situation doesn't improve in a few days. Thanks for your work, Bilal!

Thank you very much for your support! I appreciate it. I hope everyone whould enjoy the new build when it get released! Can't wait when it comes out to everyone.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 12, 2023, 05:45:39 PM
Quote from: morero10 on April 12, 2023, 02:23:54 PM
first thank you Bilal for your great effort. I tried to donate and When I completed filling out the form, it gives me a message that there is a problem and I must try again. Is there a solution? I'm from morocco

Thank you for your intention to donate :)

Are you donating through PayPal option or Debit/Credit cards option? What kind of error is showing?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 12, 2023, 06:05:22 PM
Quote from: Bruno Italiano on April 12, 2023, 03:58:03 PM
I haven't seen this donation on the Facebook page of Magic Lantern? Maybe helping to encourage even more?

Sure it might help. I don't have direct access to it, but more likely a discussion should be made with ML team to decide what's appropriate to post and what isn't on offical ML accounts.
For now I think official ML FB page is dedicated for more general announcements rather than individual stuff announcements.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: morero10 on April 12, 2023, 07:33:17 PM
i have donating through Debit/Credit cards option

the message is
were sorry that we are experiencing temporarydifficulties please try againlater we apologizefor the inconvenience
return to paypal
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 12, 2023, 09:07:39 PM
Quote from: morero10 on April 12, 2023, 07:33:17 PM
i have donating through Debit/Credit cards option

the message is
were sorry that we are experiencing temporarydifficulties please try againlater we apologizefor the inconvenience
return to paypal

Unfortunately, I don't know what is causing this error. You may want to retry again tomorrow. If it still don't work, would you be able to create PayPal account and donate via PayPal option?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 12, 2023, 09:13:02 PM
-Status update:

5 days were passed, 1754 of 2214 GBP were raised.
It's 79.2% of the goal.

Remaining: 460 GBP. Are you able to donate? Your support is needed (https://mlv.app/crop_mood)

Thanks!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 12, 2023, 11:41:36 PM
We got a leaked footage showing EOS M running Crop mood:



OMG I will DONATE!! (https://mlv.app/crop_mood)


Credit: @masc, thanks for testing and for the demo!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 13, 2023, 11:31:14 AM
(https://i.ibb.co/5G9BDPm/wrer-00000.jpg)

Donate (https://mlv.app/crop_mood)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 13, 2023, 09:06:42 PM
-Status update:

6 days were passed, 1959 of 2214 GBP were raised.
It's 88.5% of the goal.

Remaining: 255 GBP. Help us to close the goal! (https://mlv.app/crop_mood)

Thanks!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Corallaro on April 14, 2023, 11:33:05 AM
Done!! :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: koopg on April 14, 2023, 11:48:54 AM
lol,


NOW 5D3


please

Sent from my SM-N975F using Tapatalk

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 14, 2023, 11:55:00 AM
I had hopes to play with the new build this weekend, but it looks like it will take still longer  :-\
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 14, 2023, 04:36:06 PM
Quote from: Corallaro on April 14, 2023, 11:33:05 AM
Done!! :)

Thank you very much for your support!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 14, 2023, 05:37:59 PM
Quote from: koopg on April 14, 2023, 11:48:54 AM
NOW 5D3

please

WILL DO MY BEST

Read the first post (https://www.magiclantern.fm/forum/index.php?topic=26851.msg242974#msg242974) for more info about 5D3!




Quote from: iaburn on April 14, 2023, 11:55:00 AM
I had hopes to play with the new build this weekend, but it looks like it will take still longer  :-\

We are so close, I hope we will reach the goal very soon!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 14, 2023, 05:41:13 PM
We are so close!

(https://i.ibb.co/WvVG616/2080.png)


2080 of 2214 GPB rasied
It's 93.9% of the goal!

Remaining: 134 GBP

Are you able to support?

Here you go:
https://mlv.app/crop_mood
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 14, 2023, 08:34:58 PM
Last update:

2219 of 2214 GBP raised!
It's 100.2% of the goal!

--> Goal reached!

Thanks everyone for your contribution! The builds and source code will be released shortly, stay stuned!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Corallaro on April 14, 2023, 08:39:27 PM
GREAT!! :D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 14, 2023, 09:31:26 PM
Crop mood - It's online!

https://youtu.be/39S13-HwajA

-Download:

700D:
magiclantern-crop_mood.2023Apr01.700D115.zip (https://bitbucket.org/bilal_fakhouri/magic-lantern/downloads/magiclantern-crop_mood.2023Apr01.700D115.zip)
magiclantern-crop_mood.2023Apr01.700D115_Shutter.zip (https://bitbucket.org/bilal_fakhouri/magic-lantern/downloads/magiclantern-crop_mood.2023Apr01.700D115_Shutter.zip) (if ML doesn't report correct shutter speed, try this one)

650D:
magiclantern-crop_mood.2023Apr01.650D104.zip (https://bitbucket.org/bilal_fakhouri/magic-lantern/downloads/magiclantern-crop_mood.2023Apr01.650D104.zip)

EOS M:
magiclantern-crop_mood.2023Apr01.EOSM202.zip (https://bitbucket.org/bilal_fakhouri/magic-lantern/downloads/magiclantern-crop_mood.2023Apr01.EOSM202.zip)

100D:
magiclantern-crop_mood.2023Apr01.100D101.zip (https://bitbucket.org/bilal_fakhouri/magic-lantern/downloads/magiclantern-crop_mood.2023Apr01.100D101.zip)


-ISOless Dual ISO fix:

If you have ISOless errors on 650D or 700D when using Dual ISO try these dual_iso.mo versions, put dual_iso.mo in ML/modules folder in SD card (replace the old one with the new one):

Dual ISO ISOless fix - 650D - 700D.zip (https://bitbucket.org/bilal_fakhouri/magic-lantern/downloads/Dual_ISO_ISOless_fix_-_650D_-_700D.zip)

-Source code:
Reveal the magic! (https://github.com/bilalfakhouri/magiclantern_hg_02/commits/crop_rec_4k_mlv_snd)


-Notes:

Please make sure you watch "Crop mood - Build Walkthrough" video before asking questions:

https://www.youtube.com/watch?v=V0M7n2cAHMM


-If you have further questions, feel free to ask! Will try to answer them as soon as possible.

Happy testing!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: cedricp on April 14, 2023, 10:13:24 PM
 :'( Lot of undefined symbols on EOSM when loading modules....
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 14, 2023, 10:16:01 PM
@cedricp

Which modules exactly are you loading? Have you checked Crop mood - Build Walkthrough (https://www.youtube.com/watch?v=V0M7n2cAHMM) video?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: cedricp on April 14, 2023, 10:28:21 PM
Dunno, I deactivated some then reenabled, all is OK now.... Awesome :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: SebastianC on April 14, 2023, 10:40:04 PM
Hi, my eos100d 2.8K 1:1 should be 10-bit lossless simultaneously, same with crop mode; if not, it can only be for 2 seconds, and 3k 1:1 cannot be shot and viewed in real-time. Thank you!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: pmiramon on April 14, 2023, 10:41:18 PM
Great job, it goes very smoothly! I just have one question, isn't it possible to see in the preview of the 1:1 modes the aspect ratio provided by the resolution chosen in the "RAW video" options? I mean, if I choose a resolution with an aspect ratio of 4:3 (for example 1400x1080), preview this aspect ratio on screen?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: koopg on April 14, 2023, 10:56:12 PM
Quote from: theBilalFakhouri on April 14, 2023, 09:31:26 PM[full quote deleted]
can you open a 5D3 thread so I can follow?

Sent from my SM-N975F using Tapatalk

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 14, 2023, 11:22:41 PM
Quote from: SebastianC on April 14, 2023, 10:40:04 PM
Hi, my eos100d 2.8K 1:1 should be 10-bit lossless simultaneously, same with crop mode; if not, it can only be for 2 seconds,

Hello, I didn't get what do you mean?

Quote from: SebastianC on April 14, 2023, 10:40:04 PM
and 3k 1:1 cannot be shot and viewed in real-time.

3K 1:1 preset has cropped centered real-time preview, this was mentioned already in first post (https://www.magiclantern.fm/forum/index.php?topic=26851.msg242974#msg242974) and build walkthrough video (https://www.youtube.com/watch?v=V0M7n2cAHMM).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 14, 2023, 11:25:57 PM
Quote from: pmiramon on April 14, 2023, 10:41:18 PM
Great job, it goes very smoothly! I just have one question, isn't it possible to see in the preview of the 1:1 modes the aspect ratio provided by the resolution chosen in the "RAW video" options? I mean, if I choose a resolution with an aspect ratio of 4:3 (for example 1400x1080), preview this aspect ratio on screen?

Thank you!

I think you are refering to RAW video cropmarks when using lower asepct ratio or reslutions from RAW video submenu.
Currently RAW video (mlv_lite) cropmarks are not implemented yet when using Crop mood, it should be easy implement though, will do that in future release!

Thanks for the report!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 15, 2023, 12:33:46 AM
CONGRATULATIONS!!!! No one is writing because everyone is busy testing  :D :D

I have no words, the responsiveness, the real time preview in all modes, the quick access to all the modes... too good to be true  :o

Things that I've discovered and I love:
- Presets were a must for me because of the different tools you could activate due to different preview modes, and also because of the fine tune necessary for each mode, so too much to remember.
  Now there is a consistency across modes that makes all these personalized settings unnecessary, plus it's so easy and convenient to move between modes that I just want to do it!
- Something maybe not directly related to the new features is that on my 100D the 240Mhz SD mode was never working, and now it does work and just as well as on the EOS M! I have a 2.8K clip at  85.97MB/s data rate on the 100D, unthinkable before
- Realtime preview comes with much lower CPU usage, which translates in longer recording times for hi-res modes like 2.8K or 3K.
- I also appreciate having more granularity on the bit depth selection, 11bit might come in handy when pushing the limits (still need to test the practical difference with 10/12bits)
- I tried recording in all combinations I could think of without restarting the camera and I didn't had a single hang/crash. I got use to them and kind of new when will they were going to happen, but having this reliability is awesome.

I got use to Danne's custom shortcuts (ISO with up/down, etc) and I would have to adapt or find how to change shortcuts, but the build is still a pleasure to use. You spent many hours in this update theBilalFakhouri, but that was a very well invested time. Can't wait to go out and test it tomorrow :D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: pmiramon on April 15, 2023, 12:34:13 AM
Quote from: theBilalFakhouri on April 14, 2023, 11:25:57 PM
Thank you!

I think you are fefering to RAW video cropmarks when using lower asepct ratio or reslutions from RAW video submenu.
Currently RAW video (mlv_lite) cropmarks are not implemented yet when using Crop mood, it should be easy implement though, will do that in future release!

Thanks for the report!

Yes, that's exactly what I meant! I seem to remember that the black frames were loaded as images. Thanks for the answer Bilal!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 15, 2023, 12:48:01 AM
I'm reviewing some samples and it looks like the focus pixels removal is not working for some modes like the 2.8K on the EOS M (2880x1226). I have old 2.8K clips (2800x1192) and it works fine on those.
Do some modes need new focus pixels maps for MLVApp?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: 2blackbar on April 15, 2023, 01:38:47 AM
Tried it on M, my cam is gettting very hot, enabed modules like mlv_rec,crop_rec and file_man
I cant even record one video at 1920x1440 where its about 40mb required speed cause it stops after few seconds.
pretty weird especially cause it works for others and it works great with previous builds.

So... quickly tried previous builds and yeah it works great as usual up to 2.8k but this one cant get past 3 seconds in lowest resolutions
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 15, 2023, 03:50:10 AM
@iaburn

Thank you!, I am glad you liked the new build, thanks for sharing your thoughts/results! :)

Quote from: iaburn on April 15, 2023, 12:33:46 AM
I got use to Danne's custom shortcuts (ISO with up/down, etc) and I would have to adapt or find how to change shortcuts, but the build is still a pleasure to use.

I will implement customized buttons in future release, yes it seems useful, beside many EOS M users reported the same thing :)

Quote from: iaburn on April 15, 2023, 12:33:46 AM
You spent many hours in this update theBilalFakhouri, but that was a very well invested time. Can't wait to go out and test it tomorrow :D

Thank again! I think this is the build which I have dreamed to have back in 2018, it's true now :D




Quote from: pmiramon on April 15, 2023, 12:34:13 AM
I seem to remember that the black frames were loaded as images.

Hmmm, didn't understand what do you exactly mean here? :-\
Are you refering to "Cropmarks" from "Overlay" tab in ML menu? These are different from RAW video (mlv_lite) cropmarks . . If yes, I am not sure why you did mention it . .

Quote from: iaburn on April 15, 2023, 12:48:01 AM
I'm reviewing some samples and it looks like the focus pixels removal is not working for some modes like the 2.8K on the EOS M (2880x1226). I have old 2.8K clips (2800x1192) and it works fine on those.
Do some modes need new focus pixels maps for MLVApp?

New presets mean we will need new focus maps. We can use current exiting focus maps and update the offset (RAW height and width with black borders) to match new preset.
I will post a topic explains how to do it tomorrow. It's simple process.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 15, 2023, 03:53:28 AM
@2blackbar

Quote from: theBilalFakhouri on April 14, 2023, 09:31:26 PM
Please make sure you watch "Crop mood - Build Walkthrough" video before asking questions:

Here is the video Crop mood - Build Walkthrough (https://www.youtube.com/watch?v=V0M7n2cAHMM) . Make sure you watch it carefully. Pay attention to the comments.
I will be happy to answer your questions after that if you have any.

For reporting issues:
https://www.chiark.greenend.org.uk/~sgtatham/bugs.html
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: SebastianC on April 15, 2023, 05:51:26 AM
https://youtu.be/Yxpgamcxrqg

Magic Lantern Eos100d raw video 2.8K

Camera: Canon 100d
Lens: EF 24-70mm DI VC USD G2 & Helio 55mm f2 
crop_mood.2023Apr01.100D101.zip

Thanks, BilalFakhouri!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: lightspeed on April 15, 2023, 07:11:18 AM
can you do kill global draw still? is it not needed in this version?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: cedricp on April 15, 2023, 08:53:56 AM
Congratulations, it's finally the release I dreamt for!
It's working flawlessly and it's very responsive. As said previously, the only missing thing is button customisation.
Thank you again
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: essbe on April 15, 2023, 10:53:28 AM
Tested the build now, and it is wonderful, thank you Bilal! As stated earlier, for the eos m the button customisation for changing ISO and aperture with up and down arrows from Dannes build is really the only thing missing. It is quite important for smooth use with the EOS M, as you have to click into menus to change these things otherwise. Again, thank you!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Larouso on April 15, 2023, 11:08:32 AM
Also did the first tests in the morning - this build works so well, it is in fact the promissed game-changer! Thank you so much for your work.
Surely not your motivation but wanted to say anyway: Every Euro of the donation was spent so so well ! Hopefully a model that may continue. 

2 remarks:
- Is there any way to set 10x zoom to a customizable button? EOS-M is not having a dedicated one on the back.
"Zoom on half press shutter" is not working for me in this build. Having a dedicated button or being able not to switch to "framing preview" on half press shutter would be great (I dont need framing prv any more with this beautiful build)  :)

- I do hope so much at some point in thime this will find it`s way to 5D M3 ... What a killer that would be ... just dreaming :)

Thanks again so much Bilal. AND everyone of course, who made it possible in the first place with previous building bocks!!!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: masc on April 15, 2023, 11:12:15 AM
Quote from: iaburn on April 15, 2023, 12:48:01 AM
I'm reviewing some samples and it looks like the focus pixels removal is not working for some modes like the 2.8K on the EOS M (2880x1226). I have old 2.8K clips (2800x1192) and it works fine on those.
Do some modes need new focus pixels maps for MLVApp?
Please try again. Uploaded a map.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 15, 2023, 12:28:58 PM
Quote from: masc on April 15, 2023, 11:12:15 AM
Please try again. Uploaded a map.

I thought I was having visions! I just tried to edit a clip and MLVApp asked to download the map, and after that it worked haha  :o
Thank you!!!!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: 2blackbar on April 15, 2023, 02:06:50 PM
 :o Oh man, i tried setting hacks to MORE and used mlvlite instead of mlv 2 , and i can do even 3k recording now which was not possible, its fantastic
This is pretty amazing , even better than i expected.Also i can finally get 1920x1440 with c mount lenses
Im curious whats the highest crop resolution above 3k that people can record on fastests cards out there....
I agree with bringing back up/down for iso change so we dont have to touch screen at all when recording res is set
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: pmiramon on April 15, 2023, 02:20:24 PM
Quote from: theBilalFakhouri on April 15, 2023, 03:50:10 AM
Hmmm, didn't understand what do you exactly mean here? :-\
Are you refering to "Cropmarks" from "Overlay" tab in ML menu? These are different from RAW video (mlv_lite) cropmarks . . If yes, I am not sure why you did mention it . .

Yes, I was referring to those from Overlay tab. I always thought that was the way to get the aspect ratio frame! :-\  Sorry if I've confused you, you're more knowledgeable about it and you know the way!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Grognard on April 15, 2023, 07:13:08 PM
It is fantastic! Almost perfect.

What are missing in my opinion?

- as already said for the M custom buttons are missing.
- Before we were able to use x3 zoom even when recording it was a really good option even better than x10 zoom too blury for me.
- real 24.00 FPS
- realtime preview in 3k mode or almost realtime preview ;) but not necessary because 2880 are almot the same résolution.

- raw zébras don't work well but it 's not necessary too.

- it's stlll Eos M and 5d mark iii are still much better ;) and I hope for a 3.5 1:1 and 5.7k 1:3 realtime preview ;)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Corallaro on April 15, 2023, 07:55:36 PM
I made some little test with EOS M.....GREAT WORK!!  :D :D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 12:49:10 AM
Thank you everyone! very glad you liked the new build in a way or another :)
Will try to reply on questions/suggestions as soon as possible.

Okay, for now, the most requested feature is Customize buttons, here is a new build,:
(April16)

-Added Customize buttons setting in Prefs tab (thanks Danne, his code helped):

(https://i.ibb.co/qr5xVcZ/CusB1.png)  (https://i.ibb.co/j6qQW6c/CusB2.png)

Choices for each button:

Any suggestions for more choices?

-Added Kill Global Draw option in RAW video submenu:

(https://i.ibb.co/mHF6RRV/KillGD.png)


-Fixed choppy preview while idle in 1080p 3x3 and HFR modes
-INFO button (if not assigned) will be blocked when using HDMI in 1080i output while recording, to prevent preview switch and corrupted frames.

The new crop mood build versions will always be in this link:

Crop mood builds - Downloads (https://bitbucket.org/bilal_fakhouri/crop-mood-builds/downloads/)

Will update the first post later with the download link and make some edits.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on April 16, 2023, 03:20:47 AM
The following applies to the eos m, magiclantern-crop_mood.2023Apr16.EOSM202.zip:
Quote from: theBilalFakhouri on April 16, 2023, 12:49:10 AM
Any suggestions for more choices?

-It would be a good idea to add false colors to SET and/or INFO. When recording Bright colors (Like yellow or red tulips, or neon signs) even if the histogram shows 1.0, some colors will clip.
The false colors catches all the peaks, so as long as you don't see any red, you are good to go. This allows you to stay as close to 1.0 as possible without underexposing too much)

-The x10 options you added will make it easy to pre-focus in one step, nice! (As opposed to having to press INFO, tap the loupe, focus, tap the loupe again and then press info to return to preview and then hit record)

-The autofocus just works! (in idle state) I tried with 3 different lenses (EF and ef-m) and the focus is always spot on, as long as you use the  Zoom x10  and you use the arrows on screen to bring the focus box right where you want it.

-Recording times are comparable to Danne's build, but now those are a lot more consistent.
The 11bit option is a nice addition, as it allows to get decent recording times with the Highest 1x3 option (5.2k) with nicer noise in the shadows than 10bits.

There is one thing requiring a workaround:

It is not possible to take pictures in photo mode. Workaround is to press and hold the set button while powering on the camera. The camera will then work as expected in Canon mode.
Steps to reproduce the issue:

Choose one of the two photo modes
Power on the camera
Half-shutter to focus, take a picture
Try taking a second picture, it won't work. You need to restart the camera. (You may be able to take a picture if you go to x10 mode and snap from there)

Also, when pressing play to review clips, it is not possible to go back to recording mode by pressing MENU, you have to restart the camera or do a battery pull.

For those who miss Danne's tap screen presets:
As every resolution needs a different bitrate to get optimal recording times, switching resolutions can be tedious. You may want to use 5.2k/11bit or 4.8k/12bit to get a wider field of view and then switch to 2.5k/14bit  or 2.8k/12bit on the next shot to get a closeup without the binning artifacts (thin vertical lines, diagonals, etc.)

You could take the easy way and always use 12bits and use 4.8k instead of 5.2k;


OR (this was my favorite method as it kept you from tapping the screen accidentally and changing presets when you didn't feel like it)

By using the Config preset option, you can have a total of 4 different configs at startup, 3 by holding either INFO, MENU or PLAY while turning on the camera, and one by just pressing on/off.

How to do it:

Go in ML menu (Hold Trash can)
Go in Prefs
Go in Config options (first choice)
Go in Config preset, set it to Startup key

Now, turn off the camera.

Turn on the camera while holding either INFO, MENU or PLAY;
The first time, You will have to re-enable the modules and do the whole setup Bilal shows in his walkthrough video: https://www.youtube.com/watch?v=V0M7n2cAHMM (https://www.youtube.com/watch?v=V0M7n2cAHMM)
So each restart will have to be done with the same startup key combination until you are done enabling everything;
Set the proper Crop Mode (or rather Crop mood), Preset, bitrate and button customizations;
Turn off the camera.

Repeat for every Startup key combination.

You will now be able to switch presets on the fly without having to remember all the details.

And finally, for those who forgot:

Pressing the Right button (+/-  button) once will allow you to use the wheel to set the aperture. Right button again to go back to shutter speed (It will go back to shutter speed selection by itself after a while)


Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: DeafEyeJedi on April 16, 2023, 07:20:48 AM
Whaaat the actual F#%k did I just come across to? Ya, I remember seeing those dreamy post back in 2018 from Bilal when he was trying to revamp Danne's work. I mean this is all remarkable and giving me the goosebumps. 8)

Now it's time for me to pull out a bunch of EOSM's/SL1's that I've scooped up over the years in anticipating for this very moment. In fact, I'm already shopping to find some extra used ones on OfferUp locally.

@Danne — what's your PayPal so I can donate you some as well? Much love! :P

@BilalFakhouri — let me know how I can contribute by utilizing M2 again. Happy to lend a hand and troubleshoot.

Been having the itch to revive myself back in this sacred space for quite some time.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 16, 2023, 07:37:20 AM
EDIT: Hi Deafeyejedi! Nice to hear from you :).

I have custom modes in my build if one wants presets. Could be implemented. No need for Startup key.

Af is broken. Works randomly. Turning off hacks doesn´t help. Tested mainly with 1x3 modes. 22mm f2 lens.
mv1080p mode only aspect ratio 3:2? Enabling like 16:9 from RAW video works but no cropmarks?

I miss your focus regs while recording. Magic zoom is working but the overhead with it enabled caused early stop with higher framerates. Generally I think global draw functions costs too much overhead while recording raw.

HDR video now working. No idea how you fixed that. Never worked without workaround before.
Very clean code. Seems you based crop_rec on a1ex later code and then went from there? Pretty impressive stuff.

Customized buttons. L/R makes no sense for eos m. There are no phyiscal buttons here even if seemingly so.
Assigning aperture to a single button (INFO) or similar makes little sense as it´s only moving towards smaller aperture.
Nice with iso buttons up/down again.

Framing could be turned off when in realtime mode. No sense to enable it on halfshutter maybe for except presets with cropped realtime preview.

A lot of stuff could be rearranged into the Movie tab and I would probably automate install and exclude most of the modules to avoid confusion but that´s my personal opinion. I probably would put in tap display too  :P.

Overall very stable build. Very good work.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 09:13:06 AM
Quote from: lightspeed on April 15, 2023, 07:11:18 AM
can you do kill global draw still? is it not needed in this version?

Done! (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243292#msg243292)




@Anyone asking about customize buttons:
Customize buttons for Zoom x10, ISO and Aperture are Done too (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243292#msg243292) :)




Quote from: Larouso on April 15, 2023, 11:08:32 AM
2 remarks:
"Zoom on half press shutter" is not working for me in this build.

This option only work while in x1 LV mode, not meant to be used in x5 mode. When using Crop mood, all of our presets are being patched in x5 mode, if you turn OFF Crop mood and set LiveView to x1, that option will work.
Anyway, Customize buttons (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243292#msg243292) is implemented for Crop mood.

Quote from: Larouso on April 15, 2023, 11:08:32 AM
Having a dedicated button or being able not to switch to "framing preview" on half press shutter would be great (I dont need framing prv any more with this beautiful build)  :)

Yes, I agree. Framing preview on half-shutter press was implemented a long time ago for RAW video, this is the way how it work in all official builds.
Will make an option to skip Framing preview on half-shutter press under RAW video submenu in future release.

Quote from: Larouso on April 15, 2023, 11:08:32 AM
- I do hope so much at some point in thime this will find it`s way to 5D M3 ... What a killer that would be ... just dreaming :)

I hope that too :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 09:15:00 AM
Quote from: 2blackbar on April 15, 2023, 02:06:50 PM
:o Oh man, i tried setting hacks to MORE and used mlvlite instead of mlv 2 , and i can do even 3k recording now which was not possible, its fantastic
This is pretty amazing , even better than i expected.

Now we are talking :D

Quote from: 2blackbar on April 15, 2023, 02:06:50 PM
Also i can finally get 1920x1440 with c mount lenses

I think a preset with 2240x1680 resolution 4:3 AR in 1:1 is possible with real-time preview, the might preview might need more work because in this case we are dealing 4:3 preview on 3:2 screen.
Does it cover C mount lenses without vignetting? You can try 2240x1680 res with Full-Res LV preset, set resolution from RAW video to 2240 and AR to 4:3.

I am wondering why you are using 4:3 aspect ratio?

Quote from: 2blackbar on April 15, 2023, 02:06:50 PM
Im curious whats the highest crop resolution above 3k that people can record on fastests cards out there....

We don't have higher resolution than what can 3K 1:1 preset offer which is 3072x1308 @ 23.976 FPS (we almost reached sensor speed limit).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 09:21:19 AM
Quote from: pmiramon on April 15, 2023, 02:20:24 PM
Yes, I was referring to those from Overlay tab. I always thought that was the way to get the aspect ratio frame! :-\  Sorry if I've confused you, you're more knowledgeable about it and you know the way!

Nope, these are separated from RAW video black crop marks. Cropmarks In Overlay tab were mainly made to help with framing shots and composition.
I am still trying to figure out how get RAW video cropmarks work correctly with Crop mood presets (in other words in x5 mode, since we are patching our presets there).

You didn't confuse me, no problem!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 16, 2023, 09:25:23 AM
Quote from: theBilalFakhouri on April 16, 2023, 12:49:10 AM
Thank you everyone! very glad you liked the new build in a way or another :)
Will try to reply on questions/suggestions as soon as possible.

Okay, for now, the most requested feature is Customize buttons, here is a new build,:

...

Getting better and better, thanks!!  :D

I see that (on EOS M) "Small hacks" includes now the "All" option, in addition to "More". Was that intentional?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 09:36:31 AM
Quote from: Grognard on April 15, 2023, 07:13:08 PM
It is fantastic! Almost perfect.

Thanks!

Quote from: Grognard on April 15, 2023, 07:13:08 PM
What are missing in my opinion?

- as already said for the M custom buttons are missing.

Done (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243292#msg243292) :)

Quote from: Grognard on April 15, 2023, 07:13:08 PM
- Before we were able to use x3 zoom even when recording it was a really good option even better than x10 zoom too blury for me.

Just to make sure, could you record a video shows how this option work? Is it the same as "Magic Zoom V2" in my old builds?

Quote from: theBilalFakhouri on September 18, 2020, 07:51:30 PM
[gifv]https://i.imgur.com/H81QemC.mp4[/gifv]


Quote from: Grognard on April 15, 2023, 07:13:08 PM
- real 24.00 FPS
- realtime preview in 3k mode or almost realtime preview ;) but not necessary because 2880 are almot the same résolution.

Will do these in future release!

Quote from: Grognard on April 15, 2023, 07:13:08 PM
- raw zébras don't work well but it 's not necessary too.

How can I enable RAW Zebras? I don't use this option, but I can check it.

Quote from: Grognard on April 15, 2023, 07:13:08 PM
- it's stlll Eos M and 5d mark iii are still much better ;) and I hope for a 3.5 1:1 and 5.7k 1:3 realtime preview ;)

Maybe someday in future  :)

In near future I will start to make 5D3 builds too, will make it work same as Crop mood (without real-time previews for now).
Any input/opinion on this is welcome. Are current Crop mood menus design good enough to adapt it and keep it? Can we improve it more?




Quote from: Corallaro on April 15, 2023, 07:55:36 PM
I made some little test with EOS M.....GREAT WORK!!  :D :D

Thanks!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on April 16, 2023, 09:44:55 AM
Quote from: Danne on April 16, 2023, 07:37:20 AM
I probably would put in tap display too  :P.
Overall very stable build. Very good work.

If putting tap display, the arrows on screen  near the focus box (Those appear when in x10) need to be available without interfering, as those are needed for proper autofocus.

@danne, could you please confirm that you get inaccurate focus even when in x10 mode? (INFO, Loupe icon, focus)

If so, I will need to test Lens/Cam combinations with my other cams to avoid surprises...
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 09:58:18 AM
Quote from: gabriielangel on April 16, 2023, 03:20:47 AM
-It would be a good idea to add false colors to SET and/or INFO.

Okay, will try to do it in future release.

Quote from: gabriielangel on April 16, 2023, 03:20:47 AM
-The x10 options you added will make it easy to pre-focus in one step, nice!

Happy to hear that!

Quote from: gabriielangel on April 16, 2023, 03:20:47 AM
-The autofocus just works! (in idle state) I tried with 3 different lenses (EF and ef-m) and the focus is always spot on, as long as you use the  Zoom x10  and you use the arrows on screen to bring the focus box right where you want it.

Great! this is how AF supposed to work in this build!

Quote from: gabriielangel on April 16, 2023, 03:20:47 AM
-Recording times are comparable to Danne's build, but now those are a lot more consistent.

Cool, it could be even better that my old builds too (didn't make real tests), I tried to reduce overhead as much as possible in the new build.

Quote from: gabriielangel on April 16, 2023, 03:20:47 AM
The 11bit option is a nice addition, as it allows to get decent recording times with the Highest 1x3 option (5.2k) with nicer noise in the shadows than 10bits.

Yes, same thought here too! 11-bit is nice sweet spot IMO. I use it with 5.2K 1x3 too!

Quote from: gabriielangel on April 16, 2023, 03:20:47 AM
It is not possible to take pictures in photo mode. Workaround is to press and hold the set button while powering on the camera. The camera will then work as expected in Canon mode.

What's the case with Danne build? same issue?
This is an EOS M issue only, other supported models don't have it. Is it the same as shutter bug known issue (https://www.magiclantern.fm/forum/index.php?topic=21728.0)?

Does Photo mode work if modules are not loaded? Why if they are loaded but turned off?

Quote from: gabriielangel on April 16, 2023, 03:20:47 AM
Steps to reproduce the issue:

I might not able to help with solving this issue, mainly because I don't have EOS M. If this issue is also presented in official ML builds, that mean it's not exclusive here (I didn't break photo mode on EOS M, it was already broken).

Quote from: gabriielangel on April 16, 2023, 03:20:47 AM
Also, when pressing play to review clips, it is not possible to go back to recording mode by pressing MENU, you have to restart the camera or do a battery pull.

You could exit by pressing half-shutter button right? or by using arrows and press on "Exit" on MLV play GUI?
On 700D when MLV playback is running, MENU button doesn't do anything too.

What did you excpet it to do? was pressing MENU button in Danne build make the camera exit from playback to LiveView?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 10:07:04 AM
@DeafEyeJedi

Yay! time for fun :D

Quote from: DeafEyeJedi on April 16, 2023, 07:20:48 AM
@BilalFakhouri — let me know how I can contribute by utilizing M2 again. Happy to lend a hand and troubleshoot.

Thanks, shipping isn't an option to me, it's complex in my country. Beside there is a generous donor already donated with his EOS M2 some months ago,
the cam is still in Germany, I am waiting for a chance to get it to my country, Syria BTW!

Will try to port EOS M2 remotely, Walter might help with running the tests.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 10:08:50 AM
Quote from: gabriielangel on April 16, 2023, 03:20:47 AM
Pressing the Right button (+/-  button) once will allow you to use the wheel to set the aperture. Right button again to go back to shutter speed (It will go back to shutter speed selection by itself after a while)

Forgot to mention, I think we are able to add Shutter to customize bottons too.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 16, 2023, 10:45:19 AM
Visual comparison of shadow recovery with the new 11bits option on the EOS M:
(https://i.ibb.co/vqLD6db/animated-bits.png) (https://ibb.co/C8VW39q)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 16, 2023, 10:50:53 AM
Yes, pressing menu button exits liveview here. Inserted that. But you can already exit Mlv play by touching screen, should be enough.

Reminder that left/right buttons not existing on eos m. Have to be reassigned somehow idk.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 10:51:41 AM
Quote from: Danne on April 16, 2023, 07:37:20 AM
Af is broken. Works randomly. Turning off hacks doesn´t help. Tested mainly with 1x3 modes. 22mm f2 lens.

It should always work in x10 mode while idle (that's how it suppsed to work in this build), what are you doing?

Quote from: Danne on April 16, 2023, 07:37:20 AM
mv1080p mode only aspect ratio 3:2? Enabling like 16:9 from RAW video works..

Apsect ratio setting in Crop mood submenu is used mainly to reduce or increase RAW resolution directly from RAW resolution register to allow to get for example higher frame rates and flexibility in presets choices like in 1x3 presets.

On the other hand, Aspect ratio setting from RAW video submenu main task is to crop RAW frame before recording it to SD card.
Having two Apsect ratio is probably a little confusing for new users. I don't want to mix the two options, this may create some mess.

I think once the user play with the settings enough and spend some time with it you will get used to it. I will check if there are some ways to make it more user friendly . .

Quote from: Danne on April 16, 2023, 07:37:20 AM
.. but no cropmarks?

Already mentioned this, cropmarks will be implemetned in future for all crop mood presets, feel free to contribute!

Quote from: Danne on April 16, 2023, 07:37:20 AM
I miss your focus regs while recording.

Preview zoom while recording?

I will check the possibility of doing it again to match the new findings (will document them soon).
The lesson I learned from new preview work is preview configuration must not change during recording, although preview zoom while recording works in previous builds, but only in some cases (it casues corrupted frames with HDMI for example).

Quote from: Danne on April 16, 2023, 07:37:20 AM
HDR video now working. No idea how you fixed that. Never worked without workaround before.

I didn't touch HDR video, did it work in first place with official crop_rec_4k_mlv_snd branch?

Quote from: Danne on April 16, 2023, 07:37:20 AM
Very clean code. Seems you based crop_rec on a1ex later code and then went from there? Pretty impressive stuff.

Thanks, yes some parts are taken from crop_rec with arbitrary resolutions version (mainly PathDriveMode structure). I added a lot of things on my own though, also tried to improve a1ex code.

Quote from: Danne on April 16, 2023, 07:37:20 AM
Customized buttons. L/R makes no sense for eos m. There are no phyiscal buttons here even if seemingly so.

Anyway, the intention is to make customize buttons a general feature accross all models, we can disable L/R for EOS M. Did you make real test?

Quote from: Danne on April 16, 2023, 07:37:20 AM
Assigning aperture to a single button (INFO) or similar makes little sense as it´s only moving towards smaller aperture.

It will change the Aperture/ISO in loop, once you reach max value, it will start from min value again. Isn't it the way you implemented it or maybe I am missing something?
It's still useful anyway.

Quote from: Danne on April 16, 2023, 07:37:20 AM
Nice with iso buttons up/down again.

Thanks!

Quote from: Danne on April 16, 2023, 07:37:20 AM
Framing could be turned off when in realtime mode. No sense to enable it on halfshutter maybe for except presets with cropped realtime preview.

Yes, will add an option to unlink half-shutter and Framing preview.
For me, I always use check Framing preview before hitting recording button on 700D, to make sure real-time preview is showing what I am recording (in case if I reduced RAW resolution from RAW video submenu by mistake).

Quote from: Danne on April 16, 2023, 07:37:20 AM
A lot of stuff could be rearranged into the Movie tab..

If it only makes sense why not. I don't want to change how ML GUI look in general, IMO it should be similar to all other branches and models.
If a model doesn't support X feature, it just should be missing in e.g. Movie tab, and keep the general shape.

A better approach you can follow IMO is to create a new tab, called MyTab or something like that, and create an option to allow what menus which you want go to this tab.

Quote from: Danne on April 16, 2023, 07:37:20 AM
I would probably automate install and exclude most of the modules..

Not a fan of this step for many good reasons. But yes, you can do that.

Quote from: Danne on April 16, 2023, 07:37:20 AM
.. to avoid confusion..

We just need to write a guide to users tell how to use X build for your needs.
I think doing "automate install and exclude most of the modules" will create a confusion in another way.

Quote from: Danne on April 16, 2023, 07:37:20 AM
I probably would put in tap display too  :P.

Could you give some context, I don't know what you mean here :P

Quote from: Danne on April 16, 2023, 07:37:20 AM
Overall very stable build. Very good work.

Thanks again!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 10:55:55 AM
Quote from: iaburn on April 16, 2023, 09:25:23 AM
I see that (on EOS M) "Small hacks" includes now the "All" option, in addition to "More". Was that intentional?

Ops, that was an unintended mistake (when I added Kill Global Draw option). Will fix it in next release.
The option "All" won't have an effect on EOS M.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 10:58:39 AM
Quote from: Danne on April 16, 2023, 10:50:53 AM
Yes, pressing menu button exits liveview here. Inserted that. But you can already exit Mlv play by touching screen, should be enough.

Okay, thanks for the info. I might add MENU button here too, it make sense.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 11:30:50 AM
Quote from: Danne on April 16, 2023, 10:50:53 AM
Reminder that left/right buttons not existing on eos m. Have to be reassigned somehow idk.

Do you know what left/right arrows act as behalf on which buttons?
I mean, if they are not acting as BGMT_PRESS_RIGHT and BGMT_PRESS_LEFT, how do they react?

Also, did you test Left/Right arrows when assigning it to e.g. ISO on EOS M, do they do anything?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 16, 2023, 11:42:33 AM
Left is * (halshutter), right toggles shutter or aperture.
Digital arrows works as left right.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: benoit on April 16, 2023, 11:51:26 AM
Hi,
I 'm not writing often in this forum, but i read it often, today is a special day !
First, thanks a lot, Bilal ! and all others people like ae1x, danne, redeercity etc...
What a piece of software !  8)
I hoped in 2020 redeercity succeeded in a such release with the 5DII ...  :'(
So I donated and you did it for the M !
This is awesome !
You asked for suggestion so here is mine : 
I would like an option in lens info prefs menu :
- take in account a speedbooster coefficient like 0.64, 0.71, 1 (default) or an any other coef
- take in account crop mood factor
- write this new equivalent in metadata
Keep up the good work ! and thanks again !
David
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Grognard on April 16, 2023, 11:55:25 AM
Quote from: theBilalFakhouri on April 16, 2023, 09:36:31 AM


Done (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243292#msg243292) :)

Just to make sure, could you record a video shows how this option work? Is it the same as "Magic Zoom V2" in my old builds?



Yes it is. I was talking about Magic zoom V2 in your old build.

Quote from: theBilalFakhouri on April 16, 2023, 09:36:31 AM
How can I enable RAW Zebras? I don't use this option, but I can check it.


Actually it works, it shows raw zebras but it's not localited in the good area it's shift on left. but we can use other zebras and it works very well even it clips before raw.


This build is fantastic !
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: amitkattal on April 16, 2023, 12:14:18 PM
Quote from: Grognard on April 16, 2023, 11:55:25 AM
Yes it is. I was talking about Magic zoom V2 in your old build.

Actually it works, it shows raw zebras but it's not localited in the good area it's shift on left. but we can use other zebras and it works very well even it clips before raw.


This build is fantastic !
I thinkraw zebras are better because it shows real data. So even if other zebras show clipping, in reality, we can still expose little more because raw zebras shows its not clipping. other zebras dont use raw data. But yeah its shifted on left.It works perfect in 1080p raw mode. Idk how easy it is to fix that . I think it doesnt use the crop preview to show it. Maybe Bilal can look into it if its easy to fix but if not, its still fine.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Lemo777 on April 16, 2023, 03:11:29 PM
Hi. Having a EOS M. Nothing happens when i press the record button. Also no error code, just nothing happens. Any idea?


Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on April 16, 2023, 04:39:23 PM
Quote from: theBilalFakhouri on April 16, 2023, 09:58:18 AM
What's the case with Danne build? same issue?
This is an EOS M issue only, other supported models don't have it. Is it the same as shutter bug known issue (https://www.magiclantern.fm/forum/index.php?topic=21728.0)?
With Danne's build, as long as you shut down the camera before going to the photo modes, everything works fine.
This is not the same as the shutter bug issue. In my case the shutter bug issue happens only with the ef-m 15-45mm.
When this happens, you just unscrew the lens to break the connection, re-screw it and the shutter works again.

With your build doing this won't fix it, you really need to start with Set button pushed.

Quote from: theBilalFakhouri on April 16, 2023, 09:58:18 AM
Does Photo mode work if modules are not loaded? Why if they are loaded but turned off?
With no modules loaded: You can focus and take pictures, but something is broken. You take the picture, and when the picture appears briefly, it is surrounded by a noisy frame before going back to preview.

I don't know how to turn off modules. I can make the module dim and not load at the next restart but don't know how to turn it off

Quote from: theBilalFakhouri on April 16, 2023, 09:58:18 AM
I might not able to help with solving this issue, mainly because I don't have EOS M. If this issue is also presented in official ML builds, that mean it's not exclusive here (I didn't break photo mode on EOS M, it was already broken).
Danne's build never exhibited this issue for as long as I can remember (About 2 years), so I guess it should be fixable.

Quote from: theBilalFakhouri on April 16, 2023, 09:58:18 AM
You could exit by pressing half-shutter button right? or by using arrows and press on "Exit" on MLV play GUI?
On 700D when MLV playback is running, MENU button doesn't do anything too.
Yes this works, my bad!

Quote from: theBilalFakhouri on April 16, 2023, 09:58:18 AM
What did you excpet it to do? was pressing MENU button in Danne build make the camera exit from playback to LiveView?
With Danne's build, pressing Menu would exit. As clicking Exit on the UI or half-shutter works (and as Danne said, you can just touch the screen), I wouldn't change the behaviour. The less unnecessary things or redundancies, the less likely problems are to occur :)

Quote
Quote from: Danne on Today at 07:37:20 AM

    I would probably automate install and exclude most of the modules..

Not a fan of this step for many good reasons. But yes, you can do that.

I think that at least pre-enabling all the necessary modules (those you enable in the video) would be better. Users who know what they are doing will be able to go in there and disable/enable what they need.
Otherwise, we will have to watch your video each time we install your build. (Proof being that most of the problems reported on facebook are because one or some of the modules weren't enabled)
Danne's approach of having a usable cam as soon as you turn it on is a good one. Most users are more "Artists" than "Engineers" :)

Regarding framing mode when using half-shutter, We can already use the * button (Left Button) to see framing.
So it would be more useful to have the cam go to x10 mode automatically and then focus, when using half-shutter.
Would help a lot when using a gimbal, and the cam misses focus very often without x10 mode anyways.
(Right now, when custom setting half-shutter to x10 , the Framing preview seems to be taking precedence, so we cannot see the x10 preview)

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 16, 2023, 05:15:28 PM
Let's give the guy a break😂. I spent so much time on my version. Porting should be done not in a rush. And why the hurry 😎.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: DeafEyeJedi on April 16, 2023, 06:09:06 PM
Quote from: Danne on April 16, 2023, 05:15:28 PM
Let's give the guy a break😂. I spent so much time on my version. Porting should be done not in a rush. And why the hurry 😎.

Agreed. Less is more. Baby steps will eventually get us there. :D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on April 16, 2023, 06:13:15 PM
Quote from: Danne on April 16, 2023, 05:15:28 PM
Let's give the guy a break😂. I spent so much time on my version. Porting should be done not in a rush. And why the hurry 😎.

Ahaha! This is so true. But I think everyone is more than happy with what has been done so far, there's no doubt about it.
When someone looks at what Bilal and yourself have done in the past two years alone, there's a reason for everyone to be overly enthusiastic :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Larouso on April 16, 2023, 06:32:57 PM
x10 zoom on half shutter nailed it now for me.
Thanks so much for that, also Danne for the template code in the first place!

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: masc on April 16, 2023, 07:49:27 PM
Quote from: theBilalFakhouri on April 16, 2023, 12:49:10 AM
...
Choices for each button:

  • Half-Shutter:  OFF, Zoom x10
[li]...
[/li][/list]
...
-Fixed choppy preview while idle in 1080p 3x3 and HFR modes
...
Thanks for your quick update!
Two questions:
->Doing the Zoom on SET button works fine, while on Half-Shutter it just changes from FRTP to Framing. Is there another setting to avoid that, or am I doing something wrong?

->"choppy preview" means the black screen (HFR) and paused liveview (1080p)? 2nd works, 1st not (for me, in 2.35:1 and 2.39:1). Also here: am I doing something wrong?

And another problem: If I toggle between 2.8K and "Full-Res LV", I get crashes. After restart, Full-Res LV doesn't let me record (stops very quickly with invalid MLV).
ML ASSERT:
fullsize_buffers[1] == UNCACHEABLE(raw_info.buffer)
at mlv_lite.c:1514 (free_buffers), task shoot_task
lv:1 mode:3

shoot_task stack: 1f3cc8 [1f3e28-1f1e28]
0x000E8F28 @ c9018:1f3dc0
0xUNKNOWN  @ e8f7c:1f3da8
0x00B8591C @ b89888:1f3d08
0x0009EC30 @ b85980:1f3cf8
0x0009E558 @ 9ec8c:1f3cc8

Magic Lantern version : crop_mood.2023Apr16.EOSM202
Mercurial changeset   : NO HG
Built on 2023-04-15 22:02:10 UTC by bilal@DESKTOP-27BNL6E.
Free Memory  : 213K + 3138K
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 08:47:41 PM
Thanks @benoit! Hopfully I made your EOS M happy :D
Give me a 5D2 so I can give you a real-time preview, working on 5D2 is simpler than 5D3 :P

Quote from: benoit on April 16, 2023, 11:51:26 AM
I would like an option in lens info prefs menu :
- take in account a speedbooster coefficient like 0.64, 0.71, 1 (default) or an any other coef
- take in account crop mood factor
- write this new equivalent in metadata

I will check these, but I don't promise anything . .
Thanks for the suggestions!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 09:02:25 PM
Quote from: Grognard on April 16, 2023, 11:55:25 AM
Yes it is. I was talking about Magic zoom V2 in your old build.

Will check the posibilty of doing it in future, for now I am mostly aiming for more build stability and easy of use, like solving 3x3 bugs and implement mlv_lite cropmarks.

Quote from: Grognard on April 16, 2023, 11:55:25 AM
Actually it works, it shows raw zebras but it's not localited in the good area it's shift on left. but we can use other zebras and it works very well even it clips before raw.

Okay, I have tried RAW zebras, bug reproduced, will look into it in future, currently it's not a high priority.

Quote from: Grognard on April 16, 2023, 11:55:25 AM
This build is fantastic !

The users who use it are fantastic too :D




Quote from: amitkattal on April 16, 2023, 12:14:18 PM
I thinkraw zebras are better because it shows real data.

Yes, it's more accurte. It's based on RAW video steam rather than LiveView YUV stream.
I personally use RAW histogram as main tool for expoure, it helps a lot. I don't use Zebras.

Quote from: amitkattal on April 16, 2023, 12:14:18 PM
But yeah its shifted on left.It works perfect in 1080p raw mode.

It's better in 1080p but still not perfect, it's also shifted there.

Quote from: amitkattal on April 16, 2023, 12:14:18 PM
Idk how easy it is to fix that . I think it doesnt use the crop preview to show it. Maybe Bilal can look into it if its easy to fix but if not, its still fine.

Probably easy, didn't try. Will check in future.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 09:03:49 PM
Quote from: Lemo777 on April 16, 2023, 03:11:29 PM
Hi. Having a EOS M. Nothing happens when i press the record button. Also no error code, just nothing happens. Any idea?

Hi, record a video shows what are you doing and shows your settings so we check what's happening then help you!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 09:39:22 PM
Quote from: gabriielangel on April 16, 2023, 04:39:23 PM
With your build doing this won't fix it, you really need to start with Set button pushed.

Turn off crop mood and raw video from Movie tab, can you take pictures?

Quote from: gabriielangel on April 16, 2023, 04:39:23 PM
but something is broken. You take the picture, and when the picture appears briefly, it is surrounded by a noisy frame before going back to preview.

Some of overlays from "Overlay" tab take an effect and it's being applied on image review, that's not a bug. Turn off all overlays, re-test then report back.

Quote from: gabriielangel on April 16, 2023, 04:39:23 PM
Otherwise, we will have to watch your video each time we install your build. (Proof being that most of the problems reported on facebook are because one or some of the modules weren't enabled)
Danne's approach of having a usable cam as soon as you turn it on is a good one. Most users are more "Artists" than "Engineers" :)

Incorrect arguments, once you learn how to load/unload modules you don't need to watch my video each time. Beside users always watch tutorials like ZEEK's ones so they can learn how things work.
Yes, there are reports like these because loading modules is something they didn't use to do. Expected.

Same as when a new EOS M user with Danne build reports that presets don't work and weird stuff is happenig on screen, then it turns out they need to turn off autofocus.
Loading modules don't require any special skills and it just take few seconds once someone learns how to do it. If "Artists" know how to use a ML build, learning how to load modules would be an easy process too.

I am not against the idea itself "pre-loaded modules", but the method which was used in Danne build was bad IMO, by hardcoding loading modules (I mean you can't unload them anymore).
This way Debugging becomes more difficult from both user and dev ends. Also in the long term, once user switch to other model he will become confused if modules are not pre-loaded.

Alternative method would be to put module load flag in build zip file in SETTINGS folder, e.g. put "mlv_lite.en" inside SETTINGS folder.
This way the module will be loaded, and when it's needed to unload the module, you can do that from ML menu.

It's not tested method, but should work. In general I don't like the idea though. But it's open source code, anyone can do whatever he wants anyway :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 09:42:59 PM
Quote from: gabriielangel on April 16, 2023, 04:39:23 PM
(Right now, when custom setting half-shutter to x10 , the Framing preview seems to be taking precedence, so we cannot see the x10 preview)

Quote from: masc on April 16, 2023, 07:49:27 PM
Two questions:
->Doing the Zoom on SET button works fine, while on Half-Shutter it just changes from FRTP to Framing. Is there another setting to avoid that, or am I doing something wrong?

When Half-Shutter is set to x10 zoom and when autofocus is enabled, you will not be able to use Half-Shutter to get into x10 mode,
autofocus will be triggerd in this case and probably ML or Canon function will block x10 zoom, I tried it.

Half-Shutter x10 will only work with manual focus. or maybe I am missing something, did it work in Danne build?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on April 16, 2023, 09:46:02 PM
Quote from: gabriielangel on April 16, 2023, 04:39:23 PM
I think that at least pre-enabling all the necessary modules (those you enable in the video) would be better. Users who know what they are doing will be able to go in there and disable/enable what they need.
Otherwise, we will have to watch your video each time we install your build. (Proof being that most of the problems reported on facebook are because one or some of the modules weren't enabled)
Danne's approach of having a usable cam as soon as you turn it on is a good one. Most users are more "Artists" than "Engineers" :)

Pre-enabling modules is awkward.  Should you enable them for all users?  Bad if not everyone wants them, or there are side effects that break other use cases, etc.  Should you have multiple builds, some enabled, some not?  Bad because it's confusing about which you should use, and the build info screen would show the same info, extra confusing.  What should you do if the cam crashes?  Currently, this disables all modules on next load, a sensible feature for safety.

Perhaps better: a menu for grouping together and selecting settings?  So you'd have a list of choices, something like "Default / Astrophotography / High-res Raw Video / Secret Special Mode".  You'd select High-res Raw Video, and it would check the right modules exist, enable them if so, set options for overclocking your card, and auto-reboot (with a prompt saying it was going to do that).  A friendly error can be displayed if the pre-requisites aren't met.

That way, anyone can easily configure a complex group of settings, nobody is forced to use it, and we can have one build per cam.  And, we have a more general place to do complex one-button config, which feels like it would be useful for several tasks.  Going back to default settings if problems are encountered is also more intuitive: "cam went weird when I selected High-res Raw Video mode, I'll try Default from the same mode select menu".
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on April 16, 2023, 09:49:28 PM
Quote from: theBilalFakhouri on April 16, 2023, 09:39:22 PM
Alternative method would be to put module load flag in build zip file in SETTINGS folder, e.g. put "mlv_lite.en" inside SETTINGS folder.
This way the module will be loaded, and when it's needed to unload the module, you can do that from ML menu.

It's not tested method, but should work. In general I don't like the idea though. But it's open source code, anyone can do whatever he wants anyway :)

I do this for local testing, it does work, but I agree it's a bad idea for builds we give to users.  We're either forcing all users to use a module (why make it a module then?), or we ship multiple builds, some with it enabled, others without, also an ugly idea.  See prior post for a possibly nicer idea (more work though).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 16, 2023, 10:29:22 PM
I answered Half-Shutter set to x10 zoom here (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243333#msg243333) .

Quote from: masc on April 16, 2023, 07:49:27 PM
->"choppy preview" means the black screen (HFR) and paused liveview (1080p)? 2nd works, 1st not (for me, in 2.35:1 and 2.39:1). Also here: am I doing something wrong?

Nope, choppy preview was a different issue, sometime real-time preview looked like low refresh rate with 3x3 presets while idle when setting focus box in certain positions.

Quote from: masc on April 16, 2023, 07:49:27 PM
And another problem: If I toggle between 2.8K and "Full-Res LV", I get crashes. After restart, Full-Res LV doesn't let me record (stops very quickly with invalid MLV).

Sometime I do have this problem on 700D, but it doesn't make a crash. You had to pull the battery out?
I know what's causing this issue, it only happens sometime with "Full-Res LV" preset, will try to fix it in future.

Settings to record continuously with Full-Res LV preset was mentioned in build walkthrough video (https://youtu.be/V0M7n2cAHMM?t=283).

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on April 17, 2023, 12:50:55 AM
Quote from: theBilalFakhouri on April 16, 2023, 09:39:22 PM
Turn off crop mood and raw video from Movie tab, can you take pictures?
Yes, it works normally. Turning off Crop mood and leaving Raw video on also works (All the modules mentioned in your video are loaded)

Quote from: theBilalFakhouri on April 16, 2023, 09:39:22 PM
Some of overlays from "Overlay" tab take an effect and it's being applied on image review, that's not a bug. Turn off all overlays, re-test then report back.

I am unable to reproduce this issue now. I will let you know if I figure out what happened. (This was regarding the garbled black frame around the picture preview)

Quote from: theBilalFakhouri on April 16, 2023, 09:39:22 PM
Alternative method would be to put module load flag in build zip file in SETTINGS folder, e.g. put "mlv_lite.en" inside SETTINGS folder.
This way the module will be loaded, and when it's needed to unload the module, you can do that from ML menu.

I were under the impression that pre-setting the flag which put the green light on next to the required modules (Whatever happens after we turn those on ourselves) was less involved.
I agree that all the modules should be in the list, ready to be enabled/disabled. In addition to what you pointed out, It makes it easier for a user to try something he/she read on the forum, without having to track down and add a module in the folder after the initial install.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 17, 2023, 07:02:08 AM
Quote from: theBilalFakhouri on April 16, 2023, 09:42:59 PM
Half-Shutter x10 will only work with manual focus. or maybe I am missing something, did it work in Danne build?
I put some effort into getting af working with different zoom functions on. Af works for all presets. All important ones. Af seems all broken in this build?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 17, 2023, 07:08:14 AM
Quote from: names_are_hard on April 16, 2023, 09:46:02 PM
Pre-enabling modules is awkward.  Should you enable them for all users?  Bad if not everyone wants them, or there are side effects that break other use cases, etc.  Should you have multiple builds, some enabled, some not?  Bad because it's confusing about which you should use, and the build info screen would show the same info, extra confusing.  What should you do if the cam crashes?  Currently, this disables all modules on next load, a sensible feature for safety.

Perhaps better: a menu for grouping together and selecting settings?  So you'd have a list of choices, something like "Default / Astrophotography / High-res Raw Video / Secret Special Mode".  You'd select High-res Raw Video, and it would check the right modules exist, enable them if so, set options for overclocking your card, and auto-reboot (with a prompt saying it was going to do that).  A friendly error can be displayed if the pre-requisites aren't met.

That way, anyone can easily configure a complex group of settings, nobody is forced to use it, and we can have one build per cam.  And, we have a more general place to do complex one-button config, which feels like it would be useful for several tasks.  Going back to default settings if problems are encountered is also more intuitive: "cam went weird when I selected High-res Raw Video mode, I'll try Default from the same mode select menu".
.
My opinion. Have two builds. One with usable modules preloaded, the other version with all modules like now. Keeping mlv_rec for instance? For whom?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 17, 2023, 09:10:45 AM
@namre_are hard

Thanks for the input, same thoughts about modules. Your suggeted idea about how to deal with loading modules seems cool, might look into it in future, it's not high priority for me though.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 17, 2023, 09:23:24 AM
Quote from: Danne on April 17, 2023, 07:02:08 AM
I put some effort into getting af working with different zoom functions on.

I was talking about half-shutter set to x10 zoom with af on, does this combo work? could you point to which part of your code does that?

Quote from: Danne on April 17, 2023, 07:02:08 AM
Af seems all broken in this build?

AF works like a charm in crop mood build in x10 mode from all presets (check masc video about crop mood (https://www.youtube.com/watch?v=pQglOLqg3sE), also gabriielangel got it working with three diffrent lenses),
no idea what are you doing, I and gabriielangel asked you what are you doing in previous replies, you don't answer, can't help you.

Quote from: Danne on April 17, 2023, 07:08:14 AM
My opinion. Have two builds. One with usable modules preloaded, the other version with all modules like now.

I won't support this step. Previous replies from me/names_are_hard already answers this . .

Quote from: Danne on April 17, 2023, 07:08:14 AM
Keeping mlv_rec for instance? For whom?

Exactly, we will never know when a user want to use a certain module and for a what purpose, that's why we should keep them.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 17, 2023, 09:25:25 AM
Did anyone get something like "Frame order error" when recording?
I was taking many videos yesterday in 2.5K 12bits, green indicator, and almost in every other video I was getting this error message.
I just had to stop and click record again and the error was gone, but it will appear again the next time.
I was using a 18-135 EFS with an adapter, and autofocus enabled for single area.
I'll do more test and see if I find a way to replicate it always
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: benoit on April 17, 2023, 11:22:34 AM
Quote from: theBilalFakhouri on April 16, 2023, 08:47:41 PM
Give me a 5D2 so I can give you a real-time preview, working on 5D2 is simpler than 5D3 :P
I can't give you a 5D2, I need it for professional needs, but I can donate again for 1/10th of the mpb.com price. It's now 294€ for an used 5D2. Crowdfunding as you did for sd overclock or crop mood, is the solution.
So if there are nine other 5D2 users, it's ok ! Crop mood on 5D2 !!!

Other suggestion came to me yesterday : is it possible to skip a line in crop mood preview in dual-iso mode to get a clean display ? to get only low or high iso lines ?
David
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 17, 2023, 11:39:31 AM
Quote from: iaburn on April 17, 2023, 09:25:25 AM
Did anyone get something like "Frame order error" when recording?
I was taking many videos yesterday in 2.5K 12bits, green indicator, and almost in every other video I was getting this error message.
I just had to stop and click record again and the error was gone, but it will appear again the next time.
I was using a 18-135 EFS with an adapter, and autofocus enabled for single area.
I'll do more test and see if I find a way to replicate it always
How does the footage look? I actually turned that error message to off in my build as it never effected files visually on eos m.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 17, 2023, 11:43:16 AM
Quote from: theBilalFakhouri on April 17, 2023, 09:23:24 AM
AF works like a charm in crop mood build in x10 mode from all presets (check masc video about crop mood (https://www.youtube.com/watch?v=pQglOLqg3sE), also gabriielangel got it working with three diffrent lenses),
no idea what are you doing, I and gabriielangel asked you what are you doing in previous replies, you don't answer, can't help.
While recording, not working. In x10zoom it works. Pretty sure it's the same for Gabrielangel.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 17, 2023, 11:49:38 AM
Quote from: iaburn on April 17, 2023, 09:25:25 AM
Did anyone get something like "Frame order error" when recording?

Sometime it happens on 700D, and yes I just stop and restart recording. This error doesn't produce corrupted frames though.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 17, 2023, 11:55:56 AM
Quote from: Danne on April 17, 2023, 11:43:16 AM
While recording, not working. In x10zoom it works. Pretty sure it's the same for Gabrielangel.
@gabriellangel
If you have time could you check af possibilities while recording in x10zoom and while in regular preview and check behaviour compared to my build? I simply don't have the time atm to dig deeper.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 17, 2023, 11:56:12 AM
Quote from: benoit on April 17, 2023, 11:22:34 AM
I can't give you a 5D2, I need it for professional needs,

I was just kidding :)

Quote from: benoit on April 17, 2023, 11:22:34 AM
It's now 294€ for an used 5D2. Crowdfunding as you did for sd overclock or crop mood, is the solution.
So if there are nine other 5D2 users, it's ok ! Crop mood on 5D2 !!!

Yes, crowdfunding is a valid choice. I might do that in future, for now I will be working on 5D3 (I might get 70D soon too).
Once I finish from DIGIC 5+ models either if I give up or get something working on them (real-time preview), I might consider a 5D2.

Quote from: benoit on April 17, 2023, 11:22:34 AM
Other suggestion came to me yesterday : is it possible to skip a line in crop mood preview in dual-iso mode to get a clean display ? to get only low or high iso lines ?

I tried similar workarounds before, like stretching preview a little, it didn't improve the preview much. Not sure if skipping lines in preview is possible, if so, I don't know how to do it.
In next release I will make Dual ISO to turn off in x10 to check focus easily.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 17, 2023, 11:58:03 AM
Quote from: Danne on April 17, 2023, 11:43:16 AM
While recording, not working.

Turn off small hacks . .
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 17, 2023, 12:06:04 PM
I did. Think I wrote that too? Or let me check again.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: vastunghia on April 17, 2023, 12:07:46 PM
Quote from: theBilalFakhouri on April 17, 2023, 11:56:12 AM
Yes, crowdfunding is a valid choice. I might do that in future, for now I will be working on 5D3 (I might get 70D soon too).

:-*
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 17, 2023, 12:09:58 PM
Quote from: theBilalFakhouri on April 17, 2023, 11:58:03 AM
Turn off small hacks . .
It's the same issue I had. After first recording it stops autofocusing. Has to renew liveview to reset something to make it work again so that was kind of automated in my build. I don't expect you to hack fix this the same way.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 17, 2023, 12:20:59 PM
Quote from: Danne on April 17, 2023, 12:09:58 PM
It's the same issue I had. After first recording it stops autofocusing. Has to renew liveview to reset something to make it work again so that was kind of automated in my build. I don't expect you to hack fix this the same way.

Huh, now we are talking:

Issue was reproduced on 700D, same behaviour happens with WhiteBalance too, after stopping recording the first clip (in x5 mode) you will need to refresh LiveView in order to make WB has an effect after changing it.
Already figured out what's causing this issue earlier today, it's a mlv_lite bug which happens only in x5 mode after stopping recording. Already did the fix, not pushed yet, it will be available in next version.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 17, 2023, 12:58:34 PM
Hehe, figured you'd fix it 😎.
Please notify when you push your commit.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on April 17, 2023, 02:26:45 PM
Quote from: Danne on April 17, 2023, 11:55:56 AM
@gabriellangel
If you have time could you check af possibilities while recording in x10zoom and while in regular preview and check behaviour compared to my build? I simply don't have the time atm to dig deeper.

Yes, You can check back tomorrow morning and I will have something for you.

@bilal, your build works flawlessly at x10 zoom, but only when idle (Pre-recording). This is why I said earlier that it just works, because it works exactly as you advertised it.

Dannes build works differently. In 2.5k  you can focus flawlessly before and while recording, but in other modes, steps have to be taken and it isn't 100%. The problem I found is that the focus box was sometimes too big compared to what you were focusing on, and it wasn't fully centered. So you had to re-enable the Canon GUI to see the arrows, put the focus box where you want it, etc.

I will give you all the details I have tomorrow morning also.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: monkey on April 17, 2023, 05:00:53 PM
@theBilalFakhouri  (https://www.magiclantern.fm/forum/index.php?action=profile;u=73741)many hours was spent and result is  stunning!

I've faced an issue with Shutter fine-tunning (Movie>Image fine-tunning>Shutter fine-tunning)
The setting influences Shutter speed while recording (what is expected) but in other way.

Shutter speed is changing gradually till reached limit. Increasing or decreasing depending if fine-tunning value is negative or positive.

The issue is presented in Dane's build but only for negative fine-tunning value
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 17, 2023, 05:42:13 PM
Quote from: gabriielangel on April 17, 2023, 02:26:45 PM
Dannes build works differently. In 2.5k  you can focus flawlessly before and while recording, but in other modes, steps have to be taken and it isn't 100%. The problem I found is that the focus box was sometimes too big compared to what you were focusing on, and it wasn't fully centered. So you had to re-enable the Canon GUI to see the arrows, put the focus box where you want it, etc.

If you turn off small hacks you can do focusing while recording too in crop mood build (it will be more reliable in next release (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243364#msg243364)).

BTW, the camera doesn't care about focus box size in Canon GUI while focusing (it's big because we are patching our prestes in x5 mode, focus box size is bigger than x1 mode).
I already discoverd how to resize focus box in Canon GUI ( i.e from where the camera load resizing values), the details will be available soon.

I think we can do many more things with crop mood, it's more like just a beginning for now . . a lot of things can be improved.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 17, 2023, 05:45:16 PM
@monkey

Shutter fine-tuning is broken when using Small hacks with "More".
Set it to "ON" if you want to use shutter fine-tuning, but this will make write speed slower, at high resolutions you will have limited recording times.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 17, 2023, 07:13:15 PM
First post (https://www.magiclantern.fm/forum/index.php?topic=26851.msg242974#msg242974) was updated with latest updates, also added download link:

Quote from: theBilalFakhouri on April 01, 2023, 06:37:50 PM
-What's included in this topic, quick toggle:

● April 01 announcement (#post_aprilfirst)    ● Preview evolution (#post_previewevo)                  ● Crop mood presets (#post_presets)
● It's a new source-code (#post_newsource)     ● Build features (#post_features)                       ● Known issues (#post_issues)
● Supported models (#post_models)           ● My status with ML (#post_mystatus)                 ● Thanks (#post_thanks)
● Build walkthrough video (#post_buildwalkthrough)   ● Fundraiser campaign (#post_campaign)             ● It's online! (#post_online)
● Downloads (#post_downloads)                      ● ISOless fix for 650D / 700D (#post_isoless)   ● Source code (#post_magic)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 17, 2023, 07:23:06 PM
Quote from: Danne on April 17, 2023, 11:39:31 AM
How does the footage look? I actually turned that error message to off in my build as it never effected files visually on eos m.

I'm not sure, I stopped recording as soon as I was getting the error because I assumed that it will be broken. I have many clips with a few frames (I guess the ones with the error) and they play normally...
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Doumas on April 17, 2023, 08:34:26 PM
Once again, amazing work Bilal!

I was just wondering how to fix focus dots, since new resolutions don't have proper FPMs?

Thanks
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 17, 2023, 10:05:49 PM
Thanks @Doumas!

Focus pixels maps are not added yet for new presets.

I will do it in few days.



@masc @Danne Could you help with adding focus pixel maps for EOS M in MLVApp repo?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on April 18, 2023, 07:02:28 AM
Quote from: Danne on April 17, 2023, 11:55:56 AM
@gabriellangel
If you have time could you check af possibilities while recording in x10zoom and while in regular preview and check behaviour compared to my build? I simply don't have the time atm to dig deeper.

About Autofocus capabilities: (Some of this has been mentioned in other posts in the past few days, but will repeat nonetheless to facilitate the comparison)

With Danne's build, hacks lvface and AF on.
With Bilal's build, hacks off. (To be able to use it while recording)
Both with a Sandisk Extreme 128G, 170 MB/s.
magiclantern-crop_mood.2023Apr16.EOSM202.zip
crop_rec_4k_mlv_snd_raw_only_2023Mar02.EOSM202.zip

Tested with 2.39:1 Ratio

AF is bitrate dependant (On both Bilal's and Danne's builds). I did not notice a huge difference between 14 and 12 bits, but 10bits misses focus noticeably more often than the other 2.
The difference in AF accuracy between 10 and 11bits on Bilal's build is not significant enough for me to quantify it.

On Bilal's build, 4.4k 1x3 will keep recording while autofocusing, up to 12bits (Because hacks are off).
4.8k and 5.2k just can't record more than a few seconds with hacks off, so autofocus will not be very useful there.

On Bilal's Build, It's not possible to use x10 mode while recording (Recording stops as soon as you hit half-shutter), but when idle, it never misses focus.

AF at X5 mode is not as robust as x10 ATM, but as Danne's build seems to be using x5 mode while recording, it can still work pretty well.

So, on Danne's build:

-2.5k 1:1 Centered 12/14 bits: Focus is near perfect before and while recording and everything is pretty much centered;
-2.8K 1:1 12 bits: Can focus while recording, but misses a lot. When enabling the Canon GUI to see the focus box, putting it a little to the right and 1 step up makes it miss less often, but it's still not perfect;
-3K 1:1: Will work slightly better than 2.8k, but you need to lower frame rate to 20fps to run at 12 bits, so...
-5k ana frtp 12/14 bits: Focus is very good before and while recording, but you sometimes have to aim slightly lower to nail focus;
-5k ana flv: Can only focus before recording. Trying to do so while recording will lead to corrupted frames.
-1080p: Will Focus almost as well as 2.5k 1:1 Centered, but screen turns pink while using AF. The recording is always  corruption-free nonetheless.

On Bilal's build:

-AF works evenly across all modes and resolutions;
-The preview always remains clean while autofocusing, even while recording;
-X10 mode AF while idle never misses with the good lenses. Has the same accuracy as Photo mode;
-X5 mode AF while recording is not as robust as Danne's 2.5k, but it is precise enough. Will nail focus 8-9/10, but will sometimes get lost and completely lose focus for a while;
-AF will sometimes stop working at x5, so you just need to go into x10 mode, focus, then it will start working again.

The things to keep in mind are:

When moving the AF box in x10, it remains where you put it. So if moving the focus box to the side to get  a certain framing/focus subject,
In order to be useful in x10 while recording (If this becomes possible), the AF box would need to be automatically moved to the center of the frame as soon as you hit record. Otherwise AF would become very hard while recording.
This is not a problem in the current implementation, because in x5 mode the focus box is always at the center.

The focus box should be at the center of the sensor area being scanned. It is not a big problem anymore, as most presets in both builds are now very close to the center, the exception being 5k ana frtp on Danne's build.

Some lenses work better with AF than others; the best lenses I have tried are the ef-m 22mm f2.0 and EF 35mm F2.0 IS USM.

Also, when in x5 mode, the zoom looks larger on Danne's build than on Bilal's.

If I forgot something, let me know.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 18, 2023, 07:37:21 AM
Thanks for descriptions on af.

Tested bilals version on 1x3 and it works even while recording when small hacks is turned to off. Note that one can still run small hacks ON if following are turned off while doing af. I do this on my version:
Turn these off but keep the rest on in small hacks.
        call("aewb_enableaewb", unhack ? 1 : 0);  /* for new cameras */
        call("lv_ae",           unhack ? 1 : 0);  /* for old cameras */
        call("lv_wb",           unhack ? 1 : 0);


Framing mode must be turned off as it causes serious overhead on presets now while doing af. Should be easy in mlv_lite to block.

Regarding focus pixel maps I wrote masc and asked if we could symlink to one original map instead of reusing the same map for multiple resolutions. This to keep the package lighter.
personally I have no time copying and finding the correct pixel maps from dfort atm but shouldn´t take too long. Anyone can find some nearby resolution map and put in the mlv resolution to test.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: trashsawce on April 18, 2023, 02:17:33 PM
To get the photo mode working normally just set crop mood to off. Everything else works as a charm!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 18, 2023, 04:15:16 PM
One could block crop_rec while outside movie mode too.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 18, 2023, 04:18:28 PM
New Crop mood builds are out:
April.18.2023

(https://i.ibb.co/w7NmJ08/1080p-3x3-cropmarks.png)

(https://i.ibb.co/gjvMSRr/Preview-Toggle.png) (https://i.ibb.co/4Vcbn1w/SETINFO.png)


Crop mood builds - Downloads (https://www.magiclantern.fm/forum/index.php?topic=26851.msg242974#post_online)

Please test, then report back!
I might not be available until the next month.

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 18, 2023, 04:39:48 PM
Quote from: theBilalFakhouri on April 18, 2023, 04:18:28 PM
I might not be available until the next month.

Awesome update, but I really hope you are really not available for a while!
Take a well deserved time off or you'll get burnout :o

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: julien becker on April 18, 2023, 04:46:49 PM
Wow Bilal, this update looks great on paper ! Can't wait to test it out. Like iaburn wrote, you deserve some time off man !
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: benoit on April 18, 2023, 05:00:07 PM
Quote from: theBilalFakhouri on April 18, 2023, 04:18:28 PM
  • Dual ISO will be disabled in x10 mode to check focus easily.
Clever idea !
What a build !
Thanks again Bilal
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 18, 2023, 11:34:06 PM
By the number of downloads, just a few people is using a 100D, but: Are you having crashes with the 1x3 mode on "Higher" and "Highest" (2.35:1)?
No matter which bit rate I choose, even if the MB/s are not very high, I get fails and errors messages when recording on this modes. With the "Medium" resolution, it works fine. Also 1x1 modes works nicely, even 3K.

Some examples of errors (most of them are "compress_task"):

ML ASSERT:
0
at mlv_lite.c:2847 (compress_task), task compress_task
lv:1 mode:3

compress_task stack: 1f1d50 [1f1de0-1f0de0]
0x0044C9AC @ aa90bc:1f1d80
0x0044C478 @ 44ca08:1f1d50

Magic Lantern version : crop_mood.2023Apr16.100D101
Mercurial changeset   : NO HG
Built on 2023-04-15 22:03:39 UTC by bilal@DESKTOP-27BNL6E.
Free Memory  : 539K + 2267K



ML ASSERT:
((mlv_vidf_hdr_t*)slots[slot_index].ptr)->frameNumber == (uint32_t) slots[slot_index].frame_number - 1
at mlv_lite.c:3636 (raw_video_rec_task), task raw_rec_task
lv:1 mode:3

raw_rec_task stack: 1edd08 [1eddd8-1ecdd8]
0x0044C9AC @ aad3cc:1edd38
0x0044C478 @ 44ca08:1edd08

Magic Lantern version : crop_mood.2023Apr16.100D101
Mercurial changeset   : NO HG
Built on 2023-04-15 22:03:39 UTC by bilal@DESKTOP-27BNL6E.
Free Memory  : 540K + 2270K



ASSERT: !IS_ERROR(semErr)
at ./EekoApp/Color/WB/LV/LvWbAlgorWrap.c:522, CLR_CALC:ff420810
lv:1 mode:3

CLR_CALC stack: 1c8e80 [1c90d8-1c50d8]
0xUNKNOWN  @ d090:1c90d0
0xUNKNOWN  @ 3a758:1c90a8
0x0003A450 @ ff0f9e6c:1c9090
0xUNKNOWN  @ 3a480:1c9080
0xUNKNOWN  @ 3a508:1c9060
0xFF4202C4 @ ff25ab60:1c8f60
0x00001900 @ ff42080c:1c8eb8
0x0044C478 @ 44c57c:1c8e80

Magic Lantern version : crop_mood.2023Apr16.100D101
Mercurial changeset   : NO HG
Built on 2023-04-15 22:03:39 UTC by bilal@DESKTOP-27BNL6E.
Free Memory  : 569K + 2269K
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 19, 2023, 04:17:53 AM
Thanks folks!




I have fixed 100D crash on startup, sometime when switching presets.

Quote from: theBilalFakhouri on April 01, 2023, 06:37:50 PM
-Known issues:

Nothing serious really, small issue, I didn't dig into it yet but I noticed it:

  • 100D issue only: sometime the camera crashes on startup (when switching the camera from OFF to Video mode) when crop mood is already activated, adding a little delay may fix the issue.

Yes, all what needed was a delay.




@iaburn

I have no problem with recording 1736x2214 1x3 on 100D, just tried that in 18 April build. Give this version a try:
magiclantern-crop_mood.2023Apr19.100D101_hot_fix.zip (https://bitbucket.org/bilal_fakhouri/crop-mood-builds/downloads/magiclantern-crop_mood.2023Apr19.100D101_hot_fix.zip)

Feedback please. If the problem still there, share your settings.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 19, 2023, 04:55:31 AM
Another workaround for frozen/black 1080p 3x3 preset was shared by EOS M user (called Cole Power) from FB group:

Set AF method to FlexiZone Mutli, this way 1080p 3x3 will always work (regardless of focus box position).
I tried this method on HFR modes too, the preview will always work there too, not only that, you can have working preview in 738p HFR while idle too :)

(https://i.ibb.co/s1DVt9h/738p.png)


This method will work as long as you are using manual focus. If autofocus is on, AF method will be alawys switched to FlexiZone Single automagically.
It's an interesting find, might lead us to which function we need to look into it so we can have a generic fix which always works.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 19, 2023, 05:26:34 AM
Cool find.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 19, 2023, 06:54:10 AM
Nice to see this version growing by the minute.
I miss one strong preset. The 1x3 full res version. Obviously it´s not gonna be real-time preview but 1x3 with full raw stream could give some like 16fps and it works much more stable than the 1x1 Full-Res LV. The 1x3 full res preset is also nice when doing timelapses in movie mode or even shoot 16fps silent film :).
Also wonder if custom modes would be good in this build as we have no fast acces to presets otherwise. This way one could create 5 or more custom presets with all ratios, bitdepths etc already set and remembered.

EDIT: On a sidenote it´s maybe interesting to rearrange movie functions all under Movie tab. If interested there´s a nice way of doing this with placeholders. Custom modes should probably be accessible under Movie tab as well imo.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 19, 2023, 09:18:46 AM
Quote from: theBilalFakhouri on April 19, 2023, 04:17:53 AM
I have no problem with recording 1736x2214 1x3 on 100D, just tried that in 18 April build. Give this version a try:
magiclantern-crop_mood.2023Apr19.100D101_hot_fix.zip (https://bitbucket.org/bilal_fakhouri/crop-mood-builds/downloads/magiclantern-crop_mood.2023Apr19.100D101_hot_fix.zip)

Feedback please. If the problem still there, share your settings.

Thanks a lot for looking at this, I tested the hot fix and it was the same.
I think it's simply a problem with the overclock.
On your previous 100D build (before the crop mood) I could only make my cards work at 192MHz.
Now they work at 240Mhz and give over 93MB/s on the benchmark, but I realised that they cannot keep up with real recording speeds over 78MB/s approximately (around actual 192MHz speed).
The cards are all SanDisk Extreme Pro (tried 95, 170 and 200MB/s) and they work well on the EOS M, so I guess it's something specific to my camera if it works for you.
Long story short, you can forget about it  ;)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 19, 2023, 09:21:00 AM
Quote from: Danne on April 19, 2023, 06:54:10 AM
I miss one strong preset. The 1x3 full res version.
Which resolution is that? I think I never used that mode on your builds
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 19, 2023, 10:58:38 AM
5k anamorphic flv or similar. Ratios OFF. Not cam here.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on April 19, 2023, 03:50:01 PM
Quote from: Danne on April 19, 2023, 06:54:10 AM
Also wonder if custom modes would be good in this build as we have no fast acces to presets otherwise. This way one could create 5 or more custom presets with all ratios, bitdepths etc already set and remembered.

I have a suggestion here: I have noticed that it is possible to press&hold the SET button to have an extra function, in the same way we press&hold the trash can icon to go into ML Menu.
This button would be a good candidate for a preset menu, because the tap screen is prone to false triggers, and once you tap it (In Danne's build), it will change presets even if you exit without selecting.

One more argument is that, for example, my Sandisk Extreme Pro card can handle 2.5k/14bits, but the Sandisk Extreme card is good at 2.5k/12bits.
Presets makes it possible to switch modes in a more tailor made fashion.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 19, 2023, 09:52:14 PM
Tap screen for president.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 19, 2023, 09:55:25 PM
I found a workaround which make autofocus in normal preview at 10-bit as accurate as in 14-bit :)
It's not implemented yet, I just made a quick test. it will be available in next release, maybe next month.

Thanks @gabriielangel for the report and for the video.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 20, 2023, 07:59:01 AM
Nice progress Bilal.
If you like I could build a custom folder tree for you to look at. I'll place it in Movie mode section. Five presets could be stashed.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 20, 2023, 03:55:12 PM
Thanks Danne.

I have plan to make custom presets yes, also will add more Time-Lapse modes. More likely I will look into these next month since I won't have much time this month.
I will need to check how to implement these with a consideration to make/keep everything as clean as possible. I will take a look into any suggested ideas.

I will check your code regarding custom presets too, never checked that part before.
More likely I will make the custom presets menu in crop mood submenu rather than in Movie tab. I will need to check the possibilities . .

However, the source code is available online, anyone can start experminting and try making stuff if anyone want to try . .
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on April 20, 2023, 10:07:02 PM
Just start testing the Crop Mood built.
5.2k 1x3 ar 2.39 14 bit lossless seems not working, grey out in the raw video module. Seems the Crop Mood module controls. When changing to 10 bit, then the raw video module automatically changes to 10 bit lossless, but still grey out. But the data stream reduces accordingly.
For the same scene. Used the Bil 5/25/22 built, 650D could do 14 bit lossless AR 1.66. Now seems only able to do 10 bit lossless continuously.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 20, 2023, 10:34:10 PM
@mlrocks

Nah, that's the new design, and 14-bit lossless works. just leave it as it is from RAW video submenu (keep Data format at 14-bit lossless), then change bit-depth from crop mood submenu.
Data format in RAW video submenu will print the selected bit-depth from crop mood submenu. There are clear warnings tell what to do (how to change bit-depth).

Maybe it's better to not grey it out, will do that in next release.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on April 20, 2023, 10:55:08 PM
Thanks a lot, Bil.
I just tested full res 1x1, 3 fps, 90 mb/s, 50% idle, good live view, continuous green for 33 minutes. thumbs up.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 21, 2023, 08:07:50 PM
Focus pixels maps for crop mood are ready:

You will find them in the same link which include crop mood builds downloads:
Crop mood builds - Downloads (https://bitbucket.org/bilal_fakhouri/crop-mood-builds/downloads/)

(https://i.ibb.co/z8Y2jQ3/All.png)

(https://i.ibb.co/W0rLNBQ/Allinside.png)

-Download focus pixels maps .zip file for your camera
-Extract the content of "All" folder in MLVApp root or drag and drop them into MLVApp GUI

-100D focus pixels maps are not available yet, they need to be created from scratch (I will do it in future)
-Focus pixels maps will be added soon in MLVApp repo, so MLVApp would be able to download them automagically (Edit: added)

These should cover all crop mood presets for now, let me know if you still have focus pixels in any preset.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on April 21, 2023, 10:09:30 PM
Very good job, Bil. This way MLV App will get rid of all of the focus pixels.

I just found out that when changing small hacks from on to all, I can get the same level of data stream as the 5/25/22 build.

Now with sd overclocking to 240 mhz, sandisk extreme pro 170 mb/s 256 gb, on 650d

UHD 1X3 14 bit lossless AR 1.66 24p continuous orange about 80 mb/s, 10 ms idle.
5.2K 1X3 10 bit lossless AR 2.39 24p continuous orange about 80 mb/s, 10 ms idle.

Two thumbs up!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: SebastianC on April 22, 2023, 05:52:34 AM
Quote from: theBilalFakhouri on April 21, 2023, 08:07:50 PM
Focus pixels maps for crop mood are ready:
..
(Full quote removed by Mod)

I would like ask what is Focus pixels maps, how to use. Thanks!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on April 22, 2023, 07:51:01 AM
https://www.magiclantern.fm/forum/index.php?topic=16054.0
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on April 23, 2023, 07:03:09 PM
ML's auto white balance is much better than Canon's stock auto white balance.
If the ML menu->white balance->auto adjust kevin and g/m can be assigned to a button, one button ML auto white balance is very helpful when changing scenes.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: koopg on April 23, 2023, 09:28:00 PM
any news with 5d3 :(

Sent from my SM-N975F using Tapatalk

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: monkey on April 24, 2023, 06:09:24 PM
Quote from: theBilalFakhouri on April 21, 2023, 08:07:50 PM
Focus pixels maps for crop mood are ready:

...

These should cover all crop mood presets for now, let me know if you still have focus pixels in any preset.

(Full quote removed by monkey)


@theBilalFakhouri


Could you please add pixel map also for 1376x2322 resolution for EOS M?
It's crop mood 1X3, preset Higher, aspect ratio 16:9

Thank you in advance!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: MSAYED801 on April 25, 2023, 05:45:41 PM
Hello Bilal

Can you advise which modes/Ratio & Crop is able to have continuous recording?
i need a clip that is minimum 3 minutes

Your Help would be much appreciated
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 25, 2023, 10:11:17 PM
Quote from: mlrocks on April 21, 2023, 10:09:30 PM
I just found out that when changing small hacks from on to all, I can get the same level of data stream as the 5/25/22 build.

Yup, "All" means all of old and new hacks will be activated, I put them in "Small hacks" setting to simplify the menu.




Quote from: koopg on April 23, 2023, 09:28:00 PM
any news with 5d3 :(

Nope, please don't hold your breath.
If I have news I will send you a message ;)




Quote from: monkey on April 24, 2023, 06:09:24 PM
Could you please add pixel map also for 1376x2322 resolution for EOS M?
It's crop mood 1X3, preset Higher, aspect ratio 16:9

Of course, my bad, I missed it.
I added the map eariler today to MLVApp repo, MLVApp should ask you to download it now when you open 1376x2332 MLV file.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 25, 2023, 10:26:24 PM
Hi @MSAYED801

Quote from: MSAYED801 on April 25, 2023, 05:45:41 PM
Can you advise which modes/Ratio & Crop is able to have continuous recording?
i need a clip that is minimum 3 minutes

I can't, there is no proper answer to this question. It depend on many factors like your SD card and scene and ML settings.
Best way to know is to try and make real world tests on your camera, here are some videos from the community might help you with the settings:



CANON EOS M CROP MOOD - IT WORKS! (https://www.youtube.com/watch?v=JPrt-PV1wn8)




Canon EOSM Crop Mood⎮ Powerful Budged Cinema Camera (https://www.youtube.com/watch?v=JPrt-PV1wn8)

Please note that some of info including in these videos might not be always accurate, but the most info are good, helpful and useful.
These videos are applicable to all supported models. Also it's recommended to watch my build walkthrough video (https://www.youtube.com/watch?v=V0M7n2cAHMM) first.

If you are on Facebook, check MLV RAW ON EOS M (https://www.facebook.com/groups/375018026655820) group, around ~5K members there, you might learn from their experience too.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: monkey on April 26, 2023, 05:57:41 PM
Quote from: theBilalFakhouri on April 25, 2023, 10:11:17 PM
...

Of course, my bad, I missed it.
I added the map eariler today to MLVApp repo, MLVApp should ask you to download it now when you open 1376x2332 MLV file.

(full quote removed by monkey)

Sorry, but it's still not there.

P.S: Resolution is 1376X2322. No doubt it's just typo.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 26, 2023, 06:41:18 PM
@monkey

Please upload short MLV sample (2 frames, cut it with MLVApp) using 1376x2322 preset.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: monkey on April 26, 2023, 08:18:23 PM
@theBilalFakhouri

Here is the example. Hope it fits. Link below.
https://fex.net/uk/s/pdpcyem

Please let e know if you have problem with link or need different example.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 26, 2023, 08:46:06 PM
Thanks, I have added the map to MLVApp repo.
MLVApp should ask you to download it now.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: monkey on April 26, 2023, 09:25:35 PM
@theBilalFakhouri

Many thanks! Focus pixels disappeared from the shot.

Looks like I mislead You with specifications in first request.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on April 27, 2023, 01:38:54 AM
For those who didn't know, it is possible to record Uncompressed (As opposed to Lossless) with some presets.
The advantage is that the Data Rate being constant (No Compression), Scene Complexity and Brightness have little effect on recording times.

As this build is less prone to yield compression errors with very bright scenes, and there is now an 11bit lossless option;
10bit Uncompressed will most likely be advantageous only when the scene is very bright and busy. (Lots of tree branches, bushes, fur, pine trees, busy landscapes etc.)

Possibility is as follows:
2520x1048,  10bit Uncompressed, Orange (Tested over 1 minute of recording)
1472x1846,  10bit Uncompressed, Orange
1736x720, up to 14bit Uncompressed, Green (!)

In order to test, I recorded the same scene at 3 degrees of brightness (F2, F4, F11).
As you can see in the screenshots, varying brightness with Lossless changes the Data Rate, but the latter remains constant when using Uncompressed.

Recording 10bit ettr and lowering exposure in post will yield a cleaner image than 14bit recorded severely underexposed.
Also, 10bit Uncompressed has cleaner shadows than 10bit Lossless (No red tint)

You can see the data rates at various resolutions in the screenshots.
This could be particularly interesting for those using 1080p 3x3.

Tip to get longer recording times: Low-Level Format your card every time it is full (As opposed to deleting the files). There is an option to keep the ML files now (Not sure how this happens, but it works). It is easier to write on a freshly formatted SD card than on one with files deleted.
There is a good primer on that topic here: https://www.memorycard.expert/-Article/SD-Memory-Card-format (https://www.memorycard.expert/-Article/SD-Memory-Card-format)

(https://i.ibb.co/PjqtxXk/Test-f2.png) (https://ibb.co/4thJWvk)
(https://i.ibb.co/YBVY7hj/Test-F4.png) (https://ibb.co/XxGNZtJ)
(https://i.ibb.co/8KV1X7f/Test-F11.png) (https://ibb.co/K0HTmrf)


In order to test it and validate it on your end:

For 10bit Uncompressed, set the bitrate in the RAW video Menu. Choose 10-bit (The bitrate becomes grayed out in the crop mood menu and has no effect. Even if it shows a different bitrate on the main screen when recording, the recorded file will be 10bit Uncompressed. You can choose 12-bit or 14-bit if using 1080p 3x3)

For Lossless, You put back 14-bit lossless in the RAW video menu, then you set the desired bitrate in the Crop mood menu.

Tested with:
magiclantern-crop_mood.2023Apr18.EOSM202.zip
240Mhz Overclock
Sandisk Extreme Pro 170MB/s 128GB

This build is the most robust so far.

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 27, 2023, 07:01:13 AM
I never compared 10bit lossless against 10bit uncompressed, but if they is a difference in the shadows, that could mean that there is an implementation error of some kind...
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: amitkattal on April 27, 2023, 08:18:52 AM
Quote from: gabriielangel on April 27, 2023, 01:38:54 AM
For those who didn't know, it is possible to record Uncompressed (As opposed to Lossless) with some presets.
The advantage is that the Data Rate being constant, Scene Complexity and Brightness have little effect on recording times.
..
(Full quote removed by Mod)

It's normal to select uncompressed and data rate being same..there is no compression happening u like lossless so yeah data rate will be same..for lossless version, the more light or unique details means less redunt bits and final size reduction won't be huge. But if we shoot like a blank wall with no detail in the bright sun, we will get less final size.

Regarding shadows. Last time I tried, I couldn't see any difference in the result. Maybe need to try again.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 27, 2023, 10:50:45 PM
After some testing I can confirm that all the "lossless" modes have a strong red tint in the shadows, even at 14bits.
It is not obvious until you actually compare side by side with the uncompressed clips, but once you do, the difference is very noticeable.

A quick example:
(https://i.ibb.co/3r29qYF/lossless-vs-uncompressed.png) (https://imgbb.com/)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on April 27, 2023, 11:30:46 PM
How are you processing to get these results?  In theory, lossless shouldn't change the data at all, so I'm wondering if this is an mlvapp artifact.

If you can extract the image data via another route that would be a useful comparison.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 28, 2023, 06:52:12 AM
Quote from: names_are_hard on April 27, 2023, 11:30:46 PM
How are you processing to get these results?  In theory, lossless shouldn't change the data at all, so I'm wondering if this is an mlvapp artifact.

If you can extract the image data via another route that would be a useful comparison.

I'll record clips in all bit modes later today, and share a receipt and a frame from each one of them.

I just set ISO 100 and record a scene with high dynamic range. I finally rise the shadows in MLVApp to see the difference visually, without the graphs.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 28, 2023, 09:36:28 AM
Lossless modes aren't exact science here. Reducing four white level registries on top of 14bit lossless14bit lossless vs 14bit uncompressed should look the same though.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: masc on April 28, 2023, 12:38:24 PM
Was RAW black level set to the correct values? If not it is the reason for green/magenta in dark tones.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 28, 2023, 01:03:56 PM
Quote from: masc on April 28, 2023, 12:38:24 PM
Was RAW black level set to the correct values? If not it is the reason for green/magenta in dark tones.

I never touch the black/white levels, should I adjust them manually?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 28, 2023, 01:37:19 PM
I've uploaded some clips and a receipt for testing here:
https://mega.nz/file/Al0UgbqT#9y4aCkDpeMSbQDEPV5QtHZfIHo9lZo6IGWgb-ptdyzI (https://mega.nz/file/Al0UgbqT#9y4aCkDpeMSbQDEPV5QtHZfIHo9lZo6IGWgb-ptdyzI)

Besides the red tone in the shadows, I see some other weird things that maybe the gurus can explain:
- With the provided receipt, the highlight reconstruction in MLVApp cannot get rid of the pink color on the sky on the uncompressed clips, nor the 14 bit lossless, but it does for the other ones.
- The difference between lossless 12 and 14 bits is noticiable in favor of 14bits. On the contrary, the difference between uncompressed 12 and 14 bits is not that big and 12bits looks better.

Edit: I've uploaded another receipt with softer processing to see the difference in a more realistic grade:
https://mega.nz/file/F9sCnbrI#gRfHTUNuTh50qHWWvpNvM8yR7eXXRcI4KqGlSYD6aJo

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: masc on April 28, 2023, 01:57:07 PM
Quote from: iaburn on April 28, 2023, 01:03:56 PM
I never touch the black/white levels, should I adjust them manually?
Yes. You must do this for making Highlight Recovery working and for having clean dark tones. The values coming from the cam aren't always correct.

Downloaded your clips: highlight recovery works for all. General dark tone can be made the same for all.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 28, 2023, 02:21:01 PM
Quote from: masc on April 28, 2023, 01:57:07 PM
Yes. You must do this for making Highlight Recovery working and for having clean dark tones. The values coming from the cam aren't always correct.

Downloaded your clips: highlight recovery works for all. General dark tone can be made the same for all.

Let's take the 10 bit lossless. Which black/white level values do you set to make it look like the 10 bit uncompressed?
By default, black level is 2047. If I set it to 2048, the red tone is improved, but the blacks are clipped. If I set it to 2049 it's totally broken.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: masc on April 28, 2023, 02:38:30 PM
Quote from: iaburn on April 28, 2023, 02:21:01 PM
Let's take the 10 bit lossless. Which black/white level values do you set to make it look like the 10 bit uncompressed?
By default, black level is 2047. If I set it to 2048, the red tone is improved, but the blacks are clipped. If I set it to 2049 it's totally broken.
Try 2047,5 or 2048,5 or whatever fits your needs.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 28, 2023, 02:50:56 PM
Quote from: masc on April 28, 2023, 02:38:30 PM
Try 2047,5 or 2048,5 or whatever fits your needs.

I tried but I cannot find a value that will make the shadows on the 10 bits lossless look like the 10 bits uncompressed. I either get the red tone or clipped blacks.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: masc on April 28, 2023, 04:25:12 PM
I get it close, but not identical. I don't think someone could tell a difference in a real scenary. For more acuracy, more research would be needed, anaysing all the maths - if someone is fan of that, feel free and parse through the thousands of lines of code. :P

Uncompressed 10bit: 127.3   &    980
Lossless 10bit:          2047.4  &   2913

(https://i.ibb.co/hmkbt8d/M28-2010-frame-1.jpg)

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on April 28, 2023, 04:46:12 PM
Quote from: masc on April 28, 2023, 04:25:12 PM
I get it close, but not identical. I don't think someone could tell a difference in a real scenary. For more acuracy, more research would be needed, anaysing all the maths - if someone is fan of that, feel free and parse through the thousands of lines of code. :P

Uncompressed 10bit: 127.3   &    980
Lossless 10bit:          2047.4  &   2913


You cheated a little bit, you changed the black level on the uncompressed to make it more red  ;)

The point I was trying to find is if the so called "lossless" modes are really lossless. If there is no bug on the post processing software as names_are_hard suggested, I think we can say that there is an actual loss of information in the shadows on these modes, which I was not aware off.

Lossless modes are very useful indeed, but it is important to know what the limits and the differences between each mode are, and uncompressed 12bit seems like a winner to me  :D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: masc on April 28, 2023, 04:58:36 PM
Tune to whatever you like. You can also make the other version more green, but that cuts dark tones on both.
I don't see a loss of information, and the lj92 algorithm also should not bring any loss. If you see any loss, it might be a curve thing in processing alogithms (black level offset is quite different, so who knows what other paramter is influenced by this). But this can be tweaked with all the sliders and options in processing software.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: vastunghia on April 28, 2023, 07:16:38 PM
My humble contribution to the discussion:
Does step 2 make any sense? I think it does, but of course would be glad to hear from you.

Here are the results (click to open 100% crop).

14 bit lossless
(https://vastunghia.github.io/14bitLossless_000000_thumb.jpg) (https://vastunghia.github.io/14bitLossless_000000.jpg)

14 bit uncompressed
(https://vastunghia.github.io/14bit_000000_thumb.jpg) (https://vastunghia.github.io/14bit_000000.jpg)

12 bit uncompressed
(https://vastunghia.github.io/12bit_000000_thumb.jpg) (https://vastunghia.github.io/12bit_000000.jpg)

10 bit uncompressed
(https://vastunghia.github.io/10bit_000000_thumb.jpg) (https://vastunghia.github.io/10bit_000000.jpg)

My personal take-aways (which confirm my initial guess btw):
You can download from here (https://www.icloud.com/iclouddrive/038OGCJhzDlI3toOzrRSlrSiQ#vastunghia's_tests) the 4 single frames (MLV files) and the 4 MLV App receipts I used.

Ciao
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: bobolee on April 28, 2023, 08:34:51 PM
Quote from: vastunghia on April 28, 2023, 07:16:38 PM
My personal take-aways (which confirm my initial guess btw):

  • I can see no difference between lossless and uncompressed 14 bit
  • Already at 12 bit some colors are starting to fall apart and show banding (in particular check the purple patch)
  • 10 bit is pure garbage

Ciao
If I don't remember it wrong,ML used to have the option to chose between the uncompressed raw and lossless raw,but after 2021,Major builds disabled the uncompressed option,I was really disappointed by this move.Why?Because My tests showed for all the builds before the "crop moon",the lossless mode in any bits will get corrupted/pink frames here and there,the uncompressed mode won't produce a single bad frame no matter how long time you shoot.The lossless mode is for recording smaller files and improving the fps/resolution,but even a single bad frame will make the audience think your camera is broken! Lucky I saved the old builds around 2018,If I haven't save the old builds,I will be forced to shoot the lossless corrupt builds,because some of the the old  builds I like was all deleted from the web.To save some cloud spaces?
2023,Here we are,we have the "moon",not only everything is back ,you can't even get a single bad frame no matter how long you shoot-in lossless mode!!I tested myself:14bit lossless,1080p,30fps,with magic zoom for manual focus ,waveform for exposure checking,NP-F970 battery power supply,I recorded 110 GB,around 40 .mins perfect video almost non stop.God bless the developers and our hero!
When other 700 dollar camera users beg for 10bit h264,man !we are talking about 700 dollar 14 bit raw here. :)
(Cam eosm ,sd card extreme pro 128G 95MB/s)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on April 28, 2023, 08:53:08 PM
?
There are no "major builds" after 2020. No official builds by Jenkins engine and all other builds are custom by people like Levas, Danne, Arczipl(?) and Bilal.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: bobolee on April 28, 2023, 10:07:39 PM
Sorry,I should say "popular builds ".I also lose a few years of interests on ML.But now ,I'm very excited about it .I will use it to shoot weddings!Get rid of the 8bit h264 washed out ,narrowly spaced rec.709 poops :-* I've ordered a 256GB card and 4TB HDD already,for ML.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on April 28, 2023, 11:53:53 PM
Quote from: vastunghia on April 28, 2023, 07:16:38 PM
My humble contribution to the discussion:

  • Then, for each of the 4 videos, I averaged the same number of frames to get rid of random noise in the same way.
  • Then I graded to taste the 4 resulting single frames in MLV App.
Does step 2 make any sense? I think it does, but of course would be glad to hear from you.

It does to see clearly any differences in gain, color and contrast.
But the amount of noise and its quality are an important component. When using luts, any instability in the noise will be magnified and usually manifests itself as blotchy uneven color dots dancing all around.
So, if one plans to use luts or lift shadows significantly, 12 and 14bits should be preferred.
If the scene is well lit and there are few shaded areas, overexposing slightly (Without Clipping) and lowering in post makes the latest 11bit lossless quite clean and useful to get 5.2k 1x3 continuous, where 10bit lossless should be avoided as much as possible.

On a side note, Bilal's build is quite tolerant when there are a few clipped highlights (Black when using false colors), whereas the previous builds would stop recording almost immediately.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: davidicharp on April 29, 2023, 05:14:44 AM
I noticed when I am in photography mode using the latest Bilal's build that when I press the shutter half-way to do a 10x zoom, it won't work when I am on the magnifier screen in 1x mode to adjust for various focus points. I have to leave the magnifier screen for 10x zoom to work. In Danne's build this function worked perfectly without having to leave the magnifier screen. Is there a work around for this?

I am using an EOS M with only manual focus lenses so I don't need this to work in auto focus mode.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: aiyik on April 29, 2023, 10:59:52 AM
Quick question:

Is there a workaround or a solution for the B&W framing mode (as opposed to LiveView) not being available when using a HDMI monitor (OSEE T5+)?

I tend to use it a lot despite the reduced framerate in cropped framing/non-FRTP modes such as Bilal's and Danne's 3K, and for some reason that function and other functions that are tied to the half-press (Zoom X10, etc) are not available when my monitor is plugged in.

Are there plans to make it useable or is that a limitation of the HDMI output itself?

Thanks!

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: vastunghia on April 29, 2023, 11:31:14 AM
Regarding HDMI out, are you getting correct framing on external monitors with Crop Mood? Not sure I saw this info in this thread.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: aiyik on April 29, 2023, 12:17:35 PM
Quote from: vastunghia on April 29, 2023, 11:31:14 AM
Regarding HDMI out, are you getting correct framing on external monitors with Crop Mood? Not sure I saw this info in this thread.
Yes I'm getting correct framing on my monitor with all the modes that have FRTP (refer to Bilal's first post in this thread to see the full list).

(My only issue is that HDMI/my monitor seems to make real-time the only available mode for preview, which is an issue that seems present on other builds too).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ExitHero on April 29, 2023, 04:30:46 PM
hey sory i didnt know how to post a qustion..has anyone else experienced black and white for ther preview on the eos m?? and lines in it?? i cant get rid of it unless i go to picture not movie wtf??
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 29, 2023, 10:24:54 PM
Quote from: bobolee on April 28, 2023, 08:34:51 PM
ML used to have the option to chose between the uncompressed raw and lossless raw,but after 2021,Major builds disabled the uncompressed option,..

As far as I know Danne hided uncompressed option in his custom builds, all other builds have the uncompressed option.

Quote from: bobolee on April 28, 2023, 08:34:51 PM
the lossless mode in any bits will get corrupted/pink frames here and there,the uncompressed mode won't produce a single bad frame no matter how long time you shoot.

That shouldn't happen in lossless too. Show examples where lossless doesn't work and uncompressed works . .
It's more likely you are dealing with a bad video mode configuration in first place.

Quote from: bobolee on April 28, 2023, 08:34:51 PM
"crop moon"

"crop mars" please :P
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 29, 2023, 10:24:58 PM
Quote from: davidicharp on April 29, 2023, 05:14:44 AM
I noticed when I am in photography mode using the latest Bilal's build that when I press the shutter half-way to do a 10x zoom, it won't work ..

"Customize buttons" in crop mood build only works when "crop mood" is enabled in video mode, also only in x5 mode. It shoudn't work in photo mode (should I make it work there too?).
However, there is already a feature in ML core in "Prefs" tab --> LiveView zoom tweaks --> Zoom on HalfShutter. This will make HalfShutter zoom to x10 from x1 preview in video and photo modes.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on April 29, 2023, 10:29:31 PM
Quote from: aiyik on April 29, 2023, 10:59:52 AM
Is there a workaround or a solution for the B&W framing mode (as opposed to LiveView) not being available when using a HDMI monitor (OSEE T5+)?

Answerd on Discord:

"Framing" preview was never supported in HDMI, it only works on camera LCD. It's not related to custom builds.
It could be possible to make it work with HDMI though, never tried it.




Quote from: ExitHero on April 29, 2023, 04:30:46 PM
hey sory i didnt know how to post a qustion..has anyone else experienced black and white for ther preview on the eos m?? and lines in it?? i cant get rid of it unless i go to picture not movie wtf??

Hello, please share a photo as example shows what you mean . . where is the photo wtf :P?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: amitkattal on April 30, 2023, 11:00:55 AM
Could there be an option to have "sticky zoom" on half press shutter. Like press half shutter to go 10x zoom and press half shutter again to go out of zoom.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: 2blackbar on April 30, 2023, 01:24:58 PM
Quote from: iaburn on April 28, 2023, 01:03:56 PM
I never touch the black/white levels, should I adjust them manually?
I dont mix 10bt with 12 bit presets, i have separate ones for each bit depth  cause you need to adjust black and white level to get rid of that red tint and get the most out of highlight recovery.
Yes even tho mlvapp has builtin defaults you should always try to test them to get the most despite of what everyone including me says, try to get them close .
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on April 30, 2023, 06:14:18 PM
Quote from: masc on April 16, 2023, 07:49:27 PM
And another problem: If I toggle between 2.8K and "Full-Res LV", I get crashes. After restart, Full-Res LV doesn't let me record (stops very quickly with invalid MLV).
Hello,
When trying to use Full-Res LV 1:1, I get a similar problem to what @masc reported, but in my case, I cannot record with Full-Res LV at all, even if I load it first or if I come from the 2.5k preset.
it gets into record mode for less than 1 second then stops. The MLV is empty.
Build is magiclantern-crop_mood.2023Apr18.EOSM202.zip
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on April 30, 2023, 08:30:33 PM
How about upvoting full res 1x3  8) preset
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on May 01, 2023, 02:29:57 AM
Quote from: vastunghia on April 28, 2023, 07:16:38 PM
My humble contribution to the discussion:
..
(Full quote removed by Mod)


which video mode were you using on 5d3. 10 bit had significant color banding. really unexpected.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: vastunghia on May 01, 2023, 08:08:31 AM
Quote from: mlrocks on May 01, 2023, 02:29:57 AM
which video mode were you using on 5d3. 10 bit had significant color banding. really unexpected.

1x1 3.3K I think. I suggest you have a look at the MLV files yourself, I included a download link.

Why unexpected? Shadows were heavily pulled here. If 10 bits were not banding, I don't know what could band.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on May 01, 2023, 05:57:50 PM
Quote from: vastunghia on May 01, 2023, 08:08:31 AM
1x1 3.3K I think. I suggest you have a look at the MLV files yourself, I included a download link.

Why unexpected? Shadows were heavily pulled here. If 10 bits were not banding, I don't know what could band.

Some of modes on ML are not optimized. Not all modes are equal. I used 3.5k 10 bit extensively before due to the low data stream at the time. Field footage is  very good.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: vastunghia on May 01, 2023, 06:08:53 PM
Define "optimized".

10 bits is 10 bits, it may yield banding or not according to the scene, but I don't see why different modes should alter this fact. This is straight maths after all.

Of course would love to be proved wrong, always nice to to learn something new.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: davidicharp on May 01, 2023, 06:20:03 PM
Hey Bilal,

I did tried the suggestions you made to make the 10x zoom feature work in 1x mode in photo mode, but it still won't zoom in at 1x. From what I heard, you don't actually have an EOS M to test on, but rather a DSLR so the feature might work differently on the 650D/700D. When I depress the zoom half-way in Danne's build, the screen will go back to the default screen. The other thing is the EOS M doesn't have a physical magnification button so the magnifier only works by touching the magnifier icon in the canon default screen.

Thanks for all your hard work on this build. Many people are soooo grateful!!!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on May 01, 2023, 09:48:27 PM
Quote from: vastunghia on May 01, 2023, 06:08:53 PM
Define "optimized".

10 bits is 10 bits, it may yield banding or not according to the scene, but I don't see why different modes should alter this fact. This is straight maths after all.

Of course would love to be proved wrong, always nice to to learn something new.

According to my experience, some of the modes on ML are not optimized. Theoretically they should behave better but not in practice. Sometimes the ML versions matter also.

So for me, I have to test my main modes in each new ML version. Not to take granted that previously this mode works, it should work in the latest ML version. Of course, the main modes need thorough stress tests before applying to field projects.

I don't know about the codes side, just from my experience using ML cameras.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: toxotis70 on May 02, 2023, 02:22:27 PM
With the current crop mood, can we compare image quality from eosm/700d etc with canon 5d mk III ?
At least for sharpnes, clean image , colours etc.... dynamic range i suppose is better on 5D cause its full frame.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: omygolly on May 03, 2023, 10:22:24 AM
Thanks for the lovely build, works wonderfully!! The only thing that bugs out for me are the L/R-buttons under Customized buttons. Speaking of which, if I may add a feature request, would it be possible have an option to map REC to the INFO button? Reason is that it would be ideal for shooting in vertical mode, which I'm experimenting with for instagram and social media-posts.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on May 03, 2023, 01:03:52 PM
Quote from: amitkattal on April 30, 2023, 11:00:55 AM
Could there be an option to have "sticky zoom" on half press shutter. Like press half shutter to go 10x zoom and press half shutter again to go out of zoom.

Yes, I think it's possible to do it that way too, will try to put both ways in next version.




Quote from: gabriielangel on April 30, 2023, 06:14:18 PM
When trying to use Full-Res LV 1:1, I get a similar problem to what @masc reported, but in my case, I cannot record with Full-Res LV at all, even if I load it first or if I come from the 2.5k preset.
it gets into record mode for less than 1 second then stops. The MLV is empty.

From first post (also build walkthrough video (https://youtu.be/V0M7n2cAHMM?t=283)):

Quote from: theBilalFakhouri on April 01, 2023, 06:37:50 PM
-Full-Res LV preset has working preview for the first time. You can record 5208x3478 @ 3 FPS continuously in 14-bit lossless (240 MHz, hacks enabled, sound recording off) :) .
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on May 03, 2023, 01:07:58 PM
Quote from: davidicharp on May 01, 2023, 06:20:03 PM
I did tried the suggestions you made to make the 10x zoom feature work in 1x mode in photo mode, but it still won't zoom in at 1x.

Hmmm, strange, I believe this feature should work on EOS M. Have you tried with autofocus truned OFF?
Are there other EOS M users have this feature (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243610#msg243610) broken (Zoom on HalfShutter)?

Quote from: davidicharp on May 01, 2023, 06:20:03 PM
From what I heard, you don't actually have an EOS M to test on, but rather a DSLR so the feature might work differently on the 650D/700D.

Half-shutter press and unpress should work the same on all mentioned models.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on May 03, 2023, 01:12:14 PM
Quote from: toxotis70 on May 02, 2023, 02:22:27 PM
With the current crop mood, can we compare image quality from eosm/700d etc with canon 5d mk III ?
At least for sharpnes, clean image , colours etc.... dynamic range i suppose is better on 5D cause its full frame.

5D3 sensor will always be better if you are comparing 700D against 5D3 in the same modes (3x3, 1x3 and 1:1).

Quote from @masc from FB group on the same question:

QuoteThe sensor of a M or 700D does not become better than a sensor of a 5D3, with a piece of software, if you're asking for that.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on May 03, 2023, 01:20:37 PM
Thanks @omygolly

Quote from: omygolly on May 03, 2023, 10:22:24 AM
The only thing that bugs out for me are the L/R-buttons under Customized buttons.

It seems EOS M doesn't have physical L/R buttons, they are digital buttons.
I read somewhere an EOS M user wrote that you need to press and hold on a certain button to activate L/R digitally then you can make it work.

It could be there a workaround for this, by assigning the actual left and right buttons (Danne told they are * button for the left and something for the right).
On other models like 650D / 700D / 100D have these L/R work fine.

Quote from: omygolly on May 03, 2023, 10:22:24 AM
if I may add a feature request, would it be possible have an option to map REC to the INFO button?

It should be possible, will try to do it.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on May 04, 2023, 03:29:11 PM
Finally there is a demo shows how *L/R arrows* work on EOS M:

https://youtu.be/2fmlfWhF3UM?t=540

Go to 9:00 (https://youtu.be/2fmlfWhF3UM?t=540). I will add a note in next version for EOS M, also will try to print a message so user get notified when *L/R arrows* get activated (if possible).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: canoneer on May 04, 2023, 03:36:30 PM
(Crop Mood 700D issue - card speed or something else)

Bilal - I think your highly apreacheated help is needed.

I have a setup on one of my M´s - working fine and my preferred UHD 1x3 crop runs green and without stopping. When setting up my recently acquired 700D I have really tried to follow your video the same way I did for the M, with all the settings.
I have tried cards working fine on my M with 240MHz, but on 700D I get impossibly low record times, and speed. Newly bought card samme issue. Changed MHz several times.
I have run benchmark on them and the speed vary from 20 to 70 MB/s - on same card - and seem to be inherited between tests.
The only visible problem in the setting is the un-accessable shutterspeed - set to 353-354 degrees 1/25-1/26. Not possible to change, only the referred Tvx.x number - unknown phrase to me. I have re-downloaded, re-formatted and re-installed ML. Please check attached video if you have some time available. Thank you. (I hope access is working) https://vimeo.com/823731441?share=copy

I also have a few crash logs and images - https://www.dropbox.com/sh/mj0b74r7d0049ir/AAADZ1_ke9UCDrsMv51J7_sBa?dl=0

It seems I am alone with the problem - so I guess it is me or my camera, but hope for some help.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on May 04, 2023, 03:52:41 PM
Quote from: theBilalFakhouri on May 04, 2023, 03:29:11 PM
Finally there is a demo shows how *L/R arrows* work on EOS M:

Go to 9:00 (https://youtu.be/2fmlfWhF3UM?t=540). I will add a note in next version for EOS M, also will try to print a message so user get notified when *L/R arrows* get activated (if possible).

I was always using the right arrow to toggle between shutter speed and aperture adjustment when turning the wheel on Danne's builds, and it works the same on yours  :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on May 04, 2023, 05:38:35 PM
No activation of arrows when pushing the wheel.
You can activate right/left on eos m when in Expo tab and selecting aperture or shutter from there. Then you use it like we want it, left and right.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Grognard on May 05, 2023, 12:14:47 AM
It's even not related to magic lantern. Right bouton (no need to hold it 2 secs) toogle between aperture and shutter. Next time we have to read the canon Manual  ;D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: canoneer on May 05, 2023, 12:46:55 PM
Quote from: canoneer on May 04, 2023, 03:36:30 PM
(Crop Mood 700D issue - card speed or something else)

After another uninstall of ML Cr.M., I refomatted card in camera, copied Ml files from Bilals original, installed ML Cr.M. on camera and restarted it - the following is then shown on shutter line when opening ML.

Shutter       N/A, -191       TV10.0

This is in fresh installed and virgan startup window.

It is not possible to change this line at all, at start up or later.




Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: canoneer on May 05, 2023, 12:55:12 PM
Quote from: canoneer on May 05, 2023, 12:46:55 PM
Quote from: canoneer on May 04, 2023, 03:36:30 PM
(Crop Mood 700D issue - card speed or something else)

After another uninstall of ML Cr.M............
Shutter       N/A, -191       TV10.0
This is in fresh installed and virgan startup window.

It is not possible to change this line at all, at start up or later.

After this I tried the off- on-video  on the mode wheel --I have on 700D used the Video position. Tried the On position, and it seems the shutter line is available....witll test more in this position now. Coming from the M it is required to be in the Video position.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: canoneer on May 05, 2023, 01:08:53 PM
Quote from: canoneer on May 05, 2023, 12:55:12 PM
After this I tried the off- on-video  on the mode wheel --I have on 700D used the Video position. Tried the On position, and it seems the shutter line is available....witll test more in this position now. Coming from the M it is required to be in the Video position.

I am able to prepare all until going back from 240Mhz to set Raw video - under the On position - that menu page is greyed out without data. restarting and going to the Video position, I can set all except the shutter speed.- and I am not getting normal record times.

I find this pretty difficult. Going back to my M until a diagnose of what I should do.....
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on May 05, 2023, 05:26:41 PM
@iaburn @Danne @Grognard

Thanks, good to know :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on May 05, 2023, 05:32:59 PM
@canoneer

For SD write drops, make low level format in camera also set "Small hacks" to "All" from RAW video submenu to maximize write speed. Make sure the OC at 240 MHz.

For shutter issue in ML menu, there are two builds for 700D:

(https://i.ibb.co/N1Tvgzj/Shutter.png)

If the one without "Shutter" produce the shutter issue, try the version with "Shutter" (vice versa).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: canoneer on May 05, 2023, 09:22:58 PM
Quote from: theBilalFakhouri on May 05, 2023, 05:32:59 PM
@canoneer

For SD write drops, make low level format in camera also set "Small hacks" to "All" from RAW video submenu to maximize write speed. Make sure the OC at 240 MHz.

For shutter issue in ML menu, there are two builds for 700D:

(https://i.ibb.co/N1Tvgzj/Shutter.png)

If the one without "Shutter" produce the shutter issue, try the version with "Shutter" (vice versa).

Thank you very much. It was a combination of the shutter issue - did not catch that before you told me - and the SD drop, possibly also me testing an avalanche of cards in pure frustration. Now it looks very promising - first UHD take green 23 seconds, 72.4MB/s 14% idle.

Happy camper.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: bobolee on May 06, 2023, 12:23:26 PM
Quote from: theBilalFakhouri on May 04, 2023, 03:29:11 PM
Finally there is a demo shows how *L/R arrows* work on EOS M:
This demo video is misleading like a lot other videos about ML.Why? Because I did a lot of real shooting  ,I shot 3 weddings already.

They do not know the "global draw" "magic zoom""histogram" etc cause too much CPU usage,too much heat will cause disasters.In practical shooting,turn off "global draw",use Canon's original overlay to operate the camera.Use "slightly sharper"to help focus,it won't put burden on the CPU.

Auto focus?That is another wrong way to go.Bad auto focus on video mode is in the DNA of these old cameras.You must get a gimbal with a manual focus motor system.Use 10x zoom before press the record button.While shooting,you can only rely on the "slightly sharper",it's hard...

Even when the recording bar is green,CPU usage is low,temperature is not hight,it's still possible to get a camera crash if the scene changed in a sudden way,especially from dimmer to brighter .

Only 1080P 3x3 mode will get a wide enough field of view on the Canon ef-m lenses. In door shooting is a big part of practical shooting,due to the big crop factor,most of the "crop modes" is not usable in a limited shooting sapce .Hope more effort will be made to enhance the modes with a small crop factor.

Stability and practicality are the biggest weakness of the ML cameras .
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on May 06, 2023, 12:59:01 PM
Quote from: bobolee on May 06, 2023, 12:23:26 PM
This demo video is misleading like a lot other videos about ML.

I don't think it's misleading, it's showing an EOS M user experience with crop mood build (some info could be incorrect).
What are you expecting? Feel free to make a guide and share it. Make sure it's not going to be *misleading *.

Quote from: bobolee on May 06, 2023, 12:23:26 PM
They do not know the "global draw" "magic zoom""histogram" etc cause too much CPU usage,too much heat will cause disasters.

I use these while recording on 700D, didn't have problems. It was stable during my shooting.

Quote from: bobolee on May 06, 2023, 12:23:26 PM
Auto focus?That is another wrong way to go.Bad auto focus on video mode is in the DNA of these old cameras.

What's new here?
Autofocus is preference choice, feel free to not use it. Good news, CAF doesn't work with crop mood presets, you can only trigger it with half-shutter.

Quote from: bobolee on May 06, 2023, 12:23:26 PM
Only 1080P 3x3 mode will get a wide enough field of view on the Canon ef-m lenses.

1x3 can offer no crop at wide aspect ratio or a little crop in other aspect ratios.

Quote from: bobolee on May 06, 2023, 12:23:26 PM
"crop modes" is not usable in a limited shooting sapce .Hope more effort will be made to enhance the modes with a small crop factor.

It's usable depending on the mode and the lens you are using and what's are shooting. You should always make your plans before actual shooting.
Nah, it can't be *enhanced*, we already reached sensor limits with crop mood build.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: davidicharp on May 06, 2023, 01:48:35 PM
Quote from: theBilalFakhouri on April 29, 2023, 10:24:58 PM
"Customize buttons" in crop mood build only works when "crop mood" is enabled in video mode, also only in x5 mode. It shoudn't work in photo mode (should I make it work there too?).
However, there is already a feature in ML core in "Prefs" tab --> LiveView zoom tweaks --> Zoom on HalfShutter. This will make HalfShutter zoom to x10 from x1 preview in video and photo modes.

In Danne's build, the 10x zoom half shutter mode works by default in photo mode without enabling it in Liveview zoom tweaks. It doesn't matter if I turn on "Zoom on HalfShutter" in your build, the x1 preview to half shutter x10 zoom won't work.

When using a manual lens, there is no option to turn off autofocus. Now that you mention it, I think it would be nice to also have x5 zoom mode disabled in photo mode, but working in video mode.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mario1000 on May 07, 2023, 10:17:50 AM
May I ask a simple question to the forum. The Model "EOS m" comprises several model like M200, M50, M100,... Does the software developed by Bilal accounts to all models or is it just valid for the model "EOS M"? Thanks in advance!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on May 07, 2023, 10:22:45 AM
All builds are designed to run on a single camera type and specified firmware version only.
So: EOS M, the first one.

BTW: EOS M3, M5, M6, M10, M100 run with PowerShot software and are therefore part of CHDK project.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: desertman520 on May 08, 2023, 05:05:03 PM
Quote from: bobolee on May 06, 2023, 12:23:26 PM
Only 1080P 3x3 mode will get a wide enough field of view on the Canon ef-m lenses. In door shooting is a big part of practical shooting,due to the big crop factor,most of the "crop modes" is not usable in a limited shooting sapce.

This is why, especially if you already have a gimbal and focus pull system attached, cheap-o C mount lenses are the way to go.  8mm f1.6 and 16mm f1.4 sold by various vendors, such as Arducam, allow for the following equivalent fields of view:
~35mm ff equiv for the 8mm shot at 1920x1080 (its 2/3" imaging circle can't support the higher resolutions)
~55mm ff equiv for the 16mm shot at 2520x1080 (it has a wider imaging circle, so it can be used at higher res)

I haven't done so, but you can get old 16mm cine lenses, new machine vision lenses, etc. in C mount and pay hundreds of dollars for crazy specs just like with normal camera lenses.  Even the performance of the cheapos is pretty solid as long as you don't get a bad copy.  They're $50 and $70 for the 8mm and 16mm respectively...
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on May 10, 2023, 12:29:20 AM
New Crop mood builds are out:
May.09.2023

3K 3072x1308 got semi full real-time preview :)

[gifv]https://i.imgur.com/Djp0aMQ.mp4[/gifv]


Added 30 FPS to 1280p 1:1 preset

(https://i.ibb.co/PC7VZn3/1280p-30-FPS.png)


Changes:

Crop mood builds - Downloads (https://www.magiclantern.fm/forum/index.php?topic=26851.msg242974#post_online)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on May 10, 2023, 01:03:37 AM
For the isoless fix, it looks like you're still relying on heap addresses, which can change each boot, or depending on dial settings, etc.

I have a clean fix for 650d isoless, here: https://github.com/reticulatedpines/magiclantern_simplified/tree/650d_isoless_err_fix

I've only tested in Qemu, if you can confirm it works for you on a real cam I'll merge it to dev.

There's a 550d isoless fix that I did earlier, already merged: https://github.com/reticulatedpines/magiclantern_simplified/commit/215c6fa2c15a26855cf69dcb95cae93d56eb5160
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: iaburn on May 11, 2023, 08:50:49 AM
Hi, can anyone with a 100D using crop mood comment his experience recording on the 1x3 5.2K mode, 2.35:1 at 23.976fps, resulting in 1736x2214 size?
I get constant crashes on this mode, no matter the bit rate.

All other modes works very well, but I record everything at this aspect ratio and cannot use it on 1x3.

For now I'm using the 2.39:1 ratio, 1736x2178 pixels at 12bits add a replacement.  Not the same, but it very solid at least
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on May 11, 2023, 11:22:14 AM
hi bilal,
I just tested your latest crop mood build, all looks great!
unfortunately, I only can record highest resolution for couple seconds though. is it normal?
setting I use: all hack, sd 240Mhz others is default.(14-bit lossless, crop mode 1x1 or 1x3, etc.)
and got some issue when using 1x1 full res. in 10x mode.

thanks.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on May 11, 2023, 11:24:56 AM
Benchmark ok?
Can you tell us average data rate for recording?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on May 11, 2023, 11:27:48 AM
Quote from: Walter Schulz on May 11, 2023, 11:24:56 AM
Benchmark ok?
yes. and done low level format too.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on May 11, 2023, 11:38:23 AM
Quote from: Walter Schulz on May 11, 2023, 11:24:56 AM
Benchmark ok?
Can you tell us average data rate for recording?
80-82Mb/s
unstable sometimes 10 seconds and less.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on May 11, 2023, 11:56:43 AM
That's very edgy IMO
I wouldn't expect 80 to be stable.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on May 11, 2023, 12:15:28 PM
I see..  thanks Walter.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: eardrumfilms on May 12, 2023, 09:41:40 AM
Tested the May Build on the M, the 100D and the 700D it's working great. These builds are awesome! I would say they aren't nightly anymore. Is there any way we can help making the 100D focus pixel maps?
It seems there's an old bug (it's also on Danne's builds) that makes the camera bypass the manual audio level settings everytime the cameras are powered off therefore it's needed to enter the canon menus so the camera remembers the settings each time.

Could it be posible to add an option to change the prefix of the mlv filenames so each camera has distinctive file names? When using different cameras if they are set to the same date sometimes the file names are the same and opening them in MLVapp can cause a big mess.
Infinite gratitude to you Bilal!
PD: I kind of miss the CROP MOOD 3x3 1080 setting as it prevented me from tinkering with the RAW Video settings and affect the other modes.

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: amitkattal on May 12, 2023, 11:22:51 AM
The audio gain bug has been on this camera or any camera which doesnt let magic lantern control audio settings since the begining. I dont know if its possible to fix that (going to canon menu is the only hack to fix it).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: aiyik on May 12, 2023, 11:37:55 AM
Quote from: theBilalFakhouri on May 10, 2023, 12:29:20 AM
New Crop mood builds are out:
May.09.2023

3K 3072x1308 got semi full real-time preview :)


Hell yes! This is awesome! Thank you Bilal  ;D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on May 16, 2023, 09:45:58 PM
Tested the Autofocus on magiclantern-crop_mood.2023May09.EOSM202.zip

-10bit is now almost on par with 14bit when autofocus while recording (Small Hacks must be off), quite nice!
It works within the limits of the camera (Some lenses work better than others depending on brightness, and it works with every mode where it is possible to record with small hacks off.)

But when you autofocus while recording, it goes into framing mode. This makes it hard to know when focus has been nailed.
I think it would be more useful if it went momentarily into zoom mode if feasible, so we would be able to see focus being nailed in realtime.
This is how it is working on Danne's build.
EDIT: Preview Toggle must be set to OFF. It defaults to Half-Shutter. When set to Off, there is no zoom, but the display remains in realtime preview if you focus while recording.
So, for Autofocus to be usable while recording, Small Hacks must be set to Off, and Preview Toggle (Located above Small Hacks) should also be set to OFF

-in 1x3 modes, it is possible to change the aspect ratio in the crop mood menu. I don't know if it is intended to be this way, as it is not possible to do so in 1:1 modes (Where you have to change it in the Raw Video Menu)

-When in 2.5k 1:1, the preview shows vertical lines on screen when using lower bitrates. The lines become more visible as you go down bitrates (No lines at 14bits--->Very visible lines at 10bits). Those lines are not recorded in the file.


Quote from: eardrumfilms on May 12, 2023, 09:41:40 AM

Could it be posible to add an option to change the prefix of the mlv filenames so each camera has distinctive file names? When using different cameras if they are set to the same date sometimes the file names are the same and opening them in MLVapp can cause a big mess.

This is a good suggestion. I often use 3 cams (So that I don't have to switch lenses) and also when using footage from last year, I need to use a batch-rename program to make it more manageable. There is a module to have custom image names, but no such luck for MLV files. Even just One character at the beginning of the filename would do.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: t3dkid on May 17, 2023, 05:19:48 PM
While using even the latest build on my 650D I have experienced trouble getting the shutter angle and shutter speed to display properly in the UHD 1x3 crop. I have been using the 16:9 aspect ratio, but I don't think that is important. When I use the buttons to adjust the settings, they do change (image becomes darker/brighter), and the "TV" followed by a number also changes (e.g. TV 5.6). I think it normally gets locked up while displaying 1/29 and 299 degrees. wondering if this is unique to my camera or if it is a known issue.


Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Deadcode on May 18, 2023, 07:57:38 PM
Hi!

Maybe you already discussed here, but i didnt find it.

Half Press x10 zoom WHILE recording dont work with Crop Mood, 700D, 2023May09. Ok, there is magic zoom 3:1 which is good and usable, but i loved x10 feature as a focus assist before crop mood.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Jonneh on May 19, 2023, 04:35:00 PM
I'm a little late to the party, but I admit to jumping out of my seat with excitement when I saw that this release had appeared. I know we MLers are big on image quality (and Crop Mood delivers on that front too), but usability makes an enormous difference to both efficiency and pleasure while filming. The experience of precisely framing and controlling a smooth pan with accurate feedback on my 100D is wonderful, to the extent that I know I'm going to suffer when I go back to my 5D3 for its low-light performance and dynamic range. Real-time uncropped preview seems like a very hard nut to crack on that one.

So congratulations and thanks Bilal for some impressive breakthroughs!

I'm getting continuous recording in the 2.8K mode with 12-bit lossless in challenging scenes and at 3K with 12-bit lossless or 2.8K with 14-bit lossless with less challenging exposure (Extreme Pro 170Mb/s card, 240 MHz overclocking and with the various hacks turned on and global draw off). I'm a crop mode guy, so I haven't done any testing with the anamorphic modes. Also, I haven't done extensive testing with Danne's build, so I can't make direct comparisons on that front, but I'm thrilled either way.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: bobolee on May 20, 2023, 11:03:37 AM
People treated the camera as a toy or a experiment rather than a professionals movie camera,did a little bit random test then claim it stable.The stability test of a build should be brutal/professional, shoot it with sharp lense,deep depth of field,low iso,faster than 1/100+ shutter speed,bright light ,different complicated scenes,high temperature ,under sunlight for 30min,high humidity conditions,long takes,etc.Make it hard for the camera to handle.Let the professional video shooters use it,see what they say.Do a few real shooting projects,like wedding videos,can you trust the thing doing this ?

I'm still testing,12 bit 1080p still crashing in long takes! Summer is coming,it's getting hot and wet,will try the lowest bitdepth and a different card.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Jonneh on May 20, 2023, 03:28:39 PM
I've put in about 16 hours of filming in over the past few days (100D), and the build has indeed been fairly stable and bug free. My takes don't typically go beyond two minutes in length, for what it's worth.

I do have a couple of bugs to report:

- When initiating recording from the x10 mode, I get a raw detect error or "recording stopped automagically" and a 2kb file is produced. I often frame first and then set focus in the x10 mode and start recording from there.

Another few bugs appear occasionally, although I haven't been able to identify the specific conditions that reproduce the issues.

- I occasionally get staggered horizontal lines in the preview.

(https://i.ibb.co/vxsmmTD/IMG-20230519-175522.jpg)

- Pressing the up and down arrows around the set button crash ML, requiring battery removal.

I'll post back if I get a better idea of the causes of the above.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on May 22, 2023, 02:19:47 AM
I tested HDR video today and it works surprisingly well!
@bilal, the way you made it alternate between both ISO's slowly is genius. It makes it possible to adjust the exposure taking both ISO's into account without having to fiddle with a toggle switch.
It is just superior to dual ISO, as there are no additional aliasing artifacts in overexposed areas, no flickering, and where there is a lot of motion, it just looks like a slow-shutter / slo-mo effect. Very pleasing to the eye.

Is there a way to see the "Merged" image in mlv app? It would be nice if it behaved like dual ISO does, with metadata and all.
To make sure I'd be able to fully recover highlights, I exported a PNG 16 sequence, but right out of the box, the blending is pretty good!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on May 22, 2023, 06:15:41 AM
Hdr is @alex implementation.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: bobolee on May 24, 2023, 10:53:19 AM
Quote from: desertman520 on May 08, 2023, 05:05:03 PM
This is why, especially if you already have a gimbal and focus pull system attached, cheap-o C mount lenses are the way to go.  8mm f1.6 and 16mm f1.4 sold by various vendors, such as Arducam,
I don't like any lens other than Canon EF-M 22mm f/2 STM because of the lens distortion issue of the ML system.If you shoot with the original cannon video function and with a cannon lens,the camera "knows" the lens distortion and will fix it automatically.The MLV APP has no lens distortion correcting function as far as I know,so if you want to get distortion free video,you have to use a lens with minimal distortion,that 22mm 2.0 lens has almost no distortion. CCTV lens?The idea itself is a laughable :-*
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Jonneh on May 24, 2023, 11:34:38 AM
Quote from: bobolee on May 24, 2023, 10:53:19 AM
I don't like any lens other than Canon EF-M 22mm f/2 STM because of the lens distortion issue of the ML system.If you shoot with the original cannon video function and with a cannon lens,the camera "knows" the lens distortion and will fix it automatically.The MLV APP has no lens distortion correcting function as far as I know,so if you want to get distortion free video,you have to use a lens with minimal distortion,that 22mm 2.0 lens has almost no distortion. CCTV lens?The idea itself is a laughable :-*

I don't understand your reasoning here.

This presumably only applies to EF(-S) lenses used with an adapter with contacts. Such lenses used with a dumb adapter or non Canon lenses used with any adapter will show distortion in any mode. Correction can be done in post as normal, if desired.

Even then, certain types of distortion, such as moustache, are likely to affect heavily cropped capture areas less than they would an uncropped image since the flatter part of the moustache is what is cropped, meaning that one might get better results with this category of lenses/adapters in crop modes than in non-crop modes such as the Canon one.

Finally, one may like the distortion given by some lenses. My two most used wide angles are the 16-35 f4L and the Zuiko 24mm f2.8. If 24mm is wide enough for the scene, I often prefer to use the Zuiko because I find the corners produced by the Canon lens, sharp as they are and undistorted as they are, to be very distracting. They have a stretched out look that results from them being further from the image center than the adjacent image edges. They don't suffer from lens distortion but they are also very unnatural looking because of perspective distortion. The Zuiko with its mild moustache produces a much more eye-like scene.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Skinny on May 25, 2023, 07:41:56 AM
Quote from: bobolee on May 24, 2023, 10:53:19 AM
CCTV lens?The idea itself is a laughable :-*
well I actually saw VERY good photos made with c mount lenses, there are some awesome lenses, very fast like 1.2 and you will never guess that the photo was made with c-mount.. I don't really like small sensors though (or small sensor area) but you can actually get very very very good results using c-mount.. Of course there is a lot of different lenses in this category and most of them are probably very crappy. But there are some vintage Japanese lenses that can give you very expensive look with lots of bokeh and character.

QuoteFinally, one may like the distortion given by some lenses.
Exactly  :P I always turn off lens correction :D

Basically with 1x3 modes you have a lot of resolution, and you can actually make your lens corrections in post, it should look better than canon h.264 with correction made on the fly.. I never tried, but it should be so, because you have more resolution and more processing power with better algorithms (you can use adobe camera raw for example, on DNGs)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: bobolee on May 25, 2023, 09:02:01 AM
See the world as what it is!Any artifacts or distortion should be marked bad for a video capture system.You are free to use effects that not exist in nature to make your images look better for your personal taste,but a camera or a lens should always strives for the more accurate representation of the objective world.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Jonneh on May 25, 2023, 12:34:51 PM
Quote from: bobolee on May 25, 2023, 09:02:01 AM
See the world as what it is!

The world is quantum fields. Representing anything above that is a matter of what most closely resembles our experience. We can probably agree that very few people see purple fringing (although human eyes suffer from all sorts of chromatic aberrations, many of which are corrected or at least smoothed over upstream), but when we get into colour and perspective, pretty much everything is up for grabs.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on May 26, 2023, 06:57:04 PM
Just tested Crop mood's 1x1 full resolution 14 bit lossless fps = 3 mode on 650d. Basically, this mode is not working. The script windows pops up for no reason. Also, at 3 fps AR 2.4 the calculated data flow is supposed to be around 40-50 MB/s according to ML, yet after only 1 frame recording stops. This behavior is very similar to the old version before Crop Mood.
I am redeploying my 650d to a dedicated time lapse camera, so this mode is critical to me. I am sure many other MLers like the full res 1x1 mode too. Once trying some full res 1x1 footage, I guarantee more will be addicted to it.
Thanks a lot to Bil's great work!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: desertman520 on May 28, 2023, 02:35:32 AM
Quote from: bobolee on May 24, 2023, 10:53:19 AM
I don't like any lens other than Canon EF-M 22mm f/2 STM because of the lens distortion issue of the ML system.If you shoot with the original cannon video function and with a cannon lens,the camera "knows" the lens distortion and will fix it automatically.The MLV APP has no lens distortion correcting function as far as I know,so if you want to get distortion free video,you have to use a lens with minimal distortion,that 22mm 2.0 lens has almost no distortion.

On the Eos M original, only peripheral illumination and chromatic aberration are corrected in camera, not geometric distortion.  However, as other have pointed out, using 1x1 and being cropped in on the sensor makes the best use of the less distorted center of the image circle.

QuoteCCTV lens?The idea itself is a laughable :-*
I humbly submit a posting of a video I made earlier this year using a danne build. 

https://www.magiclantern.fm/forum/index.php?topic=26758.0

It's 2520x1080, shot variously either stopped down or, once it gets dark, wide open.  You may judge the level of distortion, but for a $70 USD lens it would be far more laughable to try and put a hulking piece of glass like a sigma 16mm f1.4 m mount on, or even a viltrox or something for several times the price.  I tell you, it's a gimballer's dream lens.  Some CCTV lenses do have bad distortion, but you can usually check a data sheet ahead of time.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on May 28, 2023, 06:01:47 PM
Quote from: mlrocks on May 26, 2023, 06:57:04 PM
Just tested Crop mood's 1x1 full resolution 14 bit lossless fps = 3 mode on 650d. Basically, this mode is not working. The script windows pops up for no reason. Also, at 3 fps AR 2.4 the calculated data flow is supposed to be around 40-50 MB/s according to ML, yet after only 1 frame recording stops. This behavior is very similar to the old version before Crop Mood.
I am redeploying my 650d to a dedicated time lapse camera, so this mode is critical to me. I am sure many other MLers like the full res 1x1 mode too. Once trying some full res 1x1 footage, I guarantee more will be addicted to it.
Thanks a lot to Bil's great work!

Have you tried turning sound recording off before recording? The way Bilal stated it in the first post suggests that no sound will be recorded when using that mode, but for it to work, you actually need to turn sound recording off.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: amitkattal on May 31, 2023, 03:07:25 AM
Is it possible to have L/R buttons change shutter speed ? I use manual lenses so it makes more sense to have Up/down buttons change ISO and have L/R buttons change shutter since those two are only things we can control with manual lenses.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Skinny on May 31, 2023, 04:10:40 PM
Quote from: bobolee on May 25, 2023, 09:02:01 AM
See the world as what it is!
That's not for me, it will be so boring... I will never pick up a camera that just records 1:1 everything as you see it..  :D
Why everyone loves film for example? Maybe not everyone but a lot of people..

My favorite lens is Jupiter-21m and this is just the opposite side of what our eyes can see. I love magic that camera can give us. I love anamorphic lenses with all their unusual distortions, flares, depth of field and everything.. It is just so beautiful :)

I don't know guys, everyone can do whatever they want of course.. For example painters, some of them do hyperrealism but it is often considered... let's say not as much of an art, because any camera can do that now :) And you should express your soul and your unique vision through the art. Or maybe not, art is a very broad term and can go in any direction.

So it is your job to select camera/lens combination so it will suit your ideas and creative process, maybe you want to show the world exactly as it is, maybe not :o
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: aiyik on June 02, 2023, 02:03:08 PM
Quote from: bobolee on May 24, 2023, 10:53:19 AM
I don't like any lens other than Canon EF-M 22mm f/2 STM because of the lens distortion issue of the ML system.If you shoot with the original cannon video function and with a cannon lens,the camera "knows" the lens distortion and will fix it automatically.The MLV APP has no lens distortion correcting function as far as I know,so if you want to get distortion free video,you have to use a lens with minimal distortion,that 22mm 2.0 lens has almost no distortion. CCTV lens?The idea itself is a laughable :-*

The EF-M 22mm is undoubtedly a very good lens but get your facts straight: MLVApp is the culprit because it does have lens correction profiles (CA + distortion + vignetting), which are automatically applied, recognized and cannot be toggled off. If you want to deactivate those you'd have to grade using CinemaDNGs inside RawTherapee/Lightroom/CameraRAW/etc.

Besides, any decent CCTV or industrial lens is on par if not superior to the EF-M kit lenses (uncorrected). They have wider fields of view on both Canon's (x1.66) and Bilal's/Danne's various crop factors and way, way faster apertures (i.e f/0.95 25mm Schneider-Kreuznach's Xenon). Not to mention the vast selection of other adapted C-mount lenses that were meant for video/photo/Bolex/whatever (Angénieux, Berthiot, Wollensack etc). Heck, even some properly adapted D-mount lenses are just as good if you can achieve infinity focus.

The only true downside to all those manual lenses is the lack of stabilization.



Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: eardrumfilms on June 03, 2023, 10:44:04 PM
Are the 100D focus pixels maps already available for MLVapp? If they aren't yet, is there any way we users with a 100d but without coding skills can help making them?

PD: probably there are other forums where we can debate about lenses, optical distortion and the nature of reality. The Crop Mood ML build is something complex and interesting enough and this thread used to be a great source of information.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on June 04, 2023, 11:57:00 AM
Quote from: eardrumfilms on June 03, 2023, 10:44:04 PM
Are the 100D focus pixels maps already available for MLVapp?
https://www.magiclantern.fm/forum/index.php?topic=26511.msg239140#msg239140
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: dpjpandone on June 04, 2023, 06:56:39 PM
Quote from: aiyik on June 02, 2023, 02:03:08 PM
The EF-M 22mm is undoubtedly a very good lens but get your facts straight: MLVApp is the culprit because it does have lens correction profiles (CA + distortion + vignetting), which are automatically applied, recognized and cannot be toggled off. If you want to deactivate those you'd have to grade using CinemaDNGs inside RawTherapee/Lightroom/CameraRAW/etc.

Besides, any decent CCTV or industrial lens is on par if not superior to the EF-M kit lenses (uncorrected). They have wider fields of view on both Canon's (x1.66) and Bilal's/Danne's various crop factors and way, way faster apertures (i.e f/0.95 25mm Schneider-Kreuznach's Xenon). Not to mention the vast selection of other adapted C-mount lenses that were meant for video/photo/Bolex/whatever (Angénieux, Berthiot, Wollensack etc). Heck, even some properly adapted D-mount lenses are just as good if you can achieve infinity focus.

The only true downside to all those manual lenses is the lack of stabilization.

You open with "get your facts straight" then end with an opionionated rant about "the superior quality of CCTV lens" ?  How about posting some charts or citing reputable sources that your analysis is based on? 
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: dpjpandone on June 04, 2023, 06:57:18 PM
Quote from: amitkattal on May 31, 2023, 03:07:25 AM
Is it possible to have L/R buttons change shutter speed ? I use manual lenses so it makes more sense to have Up/down buttons change ISO and have L/R buttons change shutter since those two are only things we can control with manual lenses.

scroll the wheel
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ilia3101 on June 05, 2023, 12:21:32 AM
Quote from: aiyik on June 02, 2023, 02:03:08 PM
MLVApp is the culprit because it does have lens correction profiles (CA + distortion + vignetting), which are automatically applied, recognized and cannot be toggled off. If you want to deactivate those you'd have to grade using CinemaDNGs inside RawTherapee/Lightroom/CameraRAW/etc.

None of this is true. There's no correction that can't be toggled off in MLV App. And there's no distortion capability in the app at all.

Quote from: aiyik on June 02, 2023, 02:03:08 PM
Besides, any decent CCTV or industrial lens is on par if not superior to the EF-M kit lenses (uncorrected).

Now that you know, feel free to demonstrate this using MLV App :)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: RhythmicEye on June 10, 2023, 06:39:18 AM
Quote from: theBilalFakhouri on May 10, 2023, 12:29:20 AM
New Crop mood builds are out:
May.09.2023

3K 3072x1308 got semi full real-time preview :)

[gifv]https://i.imgur.com/Djp0aMQ.mp4[/gifv]


Added 30 FPS to 1280p 1:1 preset

(https://i.ibb.co/PC7VZn3/1280p-30-FPS.png)


Changes:

  • Added 30 FPS for 1280p 1:1 preset.
  • Now autofocus in normal preview at lower bit-depths like 10-bit is as accurate as in 14-bit (when using crop mood and lossless).
  • AF method will be switched to FlexiZone Multi automagically when using manual focus, preview works better (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243414#msg243414) with this in 3x3 presets.
  • Implemented semi full real-time preview for 3K 1:1 preset, only 2868 from the middle are being showing in preview from 3072 horizontal pixels.
  • Hidded 1080p 3x3 preset from crop mood for 650D / 700D / 100D (you can use 1080p mode from Canon, crop mood isn't needed in this case).
  • Implemented a simple workaround for ISOless errors for 650D / 700D (works on 700D, 650D needs testing).
  • Fixed horizontal blurry line artifact (https://i.ibb.co/F6NvGfX/HBB.jpg) which appears in some 1x3 presets which affect RAW data.

Crop mood builds - Downloads (https://www.magiclantern.fm/forum/index.php?topic=26851.msg242974#post_online)

Thanks once again for all your excellent work Bilal. Just a spectacular leap in functionality with Crop Mood and with each iteration it gets better.

I have one issue to report on my 700D which is happening in both April release and in the May release as well.

The issue I'm having is that I get a jump in exposure setting after hitting record. Exposure ramp is turned off and I've checked all my settings in both Canon and ML settings and there's nothing obvious to suggest user error.

Exposure jumps one to two stops to the right and it is absolutely consistent across all ML files for about 1 second so it's not too hard to compensate for. It can be seen clearly on the scopes in MLV App as well.

I've also been told by one other person via YT comments that this is also happening on his EOS M. Makes it hard to have confidence that I'm exposing correctly but it does seem to be exactly the same jump in exposure in all lighting conditions. Could be why some users are struggling with over exposing in the highlights when out doors.

My compensation technique is to under expose by one to two stops from what I see on the monitor and scopes when setting my exposure.

Have you or anyone else experienced this issue or know someone who has?

Build: magiclantern-crop_mood.2023May09.700D115_Shutter

So far that's the only real issue I'm having but I'm doing more real world testing today, I'll report any further findings in the coming days.

Thanks again
RE

P.S Do you have a "Buy Me A Coffee" account? :-}
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on June 10, 2023, 11:28:21 AM
Quote from: names_are_hard on May 10, 2023, 01:03:37 AM
I have a clean fix for 650d isoless, here: https://github.com/reticulatedpines/magiclantern_simplified/tree/650d_isoless_err_fix

Thanks for sharing, will check it later.




Quote from: iaburn on May 11, 2023, 08:50:49 AM
Hi, can anyone with a 100D using crop mood comment his experience recording on the 1x3 5.2K mode, 2.35:1 at 23.976fps, resulting in 1736x2214 size?
I get constant crashes on this mode, no matter the bit rate.

It seems 1736x2214 isn't stable on 100D, sometime it works but most time it doesn't work? My previous tests using April 01 I had it working through my tests (maybe I was just lucky in these tests).
Reducing resolution to something like 1728x2206 or 1712x2184 (from crop_rec.c) might make it stable or by reducing FPS a little and keeping 1736x2214 is another a way to make it stable.

Will look into it soon.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on June 10, 2023, 11:32:03 AM
Quote from: ML700D on May 11, 2023, 11:22:14 AM
unfortunately, I only can record highest resolution for couple seconds though. is it normal?
setting I use: all hack, sd 240Mhz others is default.(14-bit lossless, crop mode 1x1 or 1x3, etc.)

At high resolutions you might want to reduce bit-depth to lower than 14-bit lossless if you need continuous recording because 14-bit is a lot of data to write.
Try 12/11/10-bit lossless.

Quote from: ML700D on May 11, 2023, 11:22:14 AM
and got some issue when using 1x1 full res. in 10x mode.

I might help if you could share more info about what's happening.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on June 10, 2023, 12:40:11 PM
Thanks @eardrumfilms!

Quote from: eardrumfilms on May 12, 2023, 09:41:40 AM
Is there any way we can help making the 100D focus pixel maps?

Firstly we to get a single frame for each Binning mode at maximum resolution:

-5208x3478 in 1:1 (maybe we already have the map for this?)
-1736x3478 in 1x3

Then we more likely need to follow dfort tutorial about creating focus pixel maps, maybe it's somewhere in this topic (https://www.magiclantern.fm/forum/index.php?topic=16054.0).
We can already get 5208x3478 1:1 with crop mood build (Full-Res preset). I will need to create 1736x3478 1x3 preset in order to get a frame.

I will into 100D focus pixels maps this week.

Quote from: eardrumfilms on May 12, 2023, 09:41:40 AM
It seems there's an old bug (it's also on Danne's builds) that makes the camera bypass the manual audio level settings everytime the cameras are powered off therefore it's needed to enter the canon menus so the camera remembers the settings each time.

Thanks for mentioning this, I thought (https://www.magiclantern.fm/forum/index.php?topic=25121.msg228273#msg228273) manual audio level settings don't work with RAW recording, this thing was definitely bugging me on 700D.
I will look into it and see if I can do something, will check what's the status on 5D3 too (does it have the same bug?).

Quote from: eardrumfilms on May 12, 2023, 09:41:40 AM
Could it be posible to add an option to change the prefix of the mlv filenames so each camera has distinctive file names?

Should be possible yes, and it seems useful in some ways. I will try to add an option in RAW video submenu to customize MLV file names.

Quote from: eardrumfilms on May 12, 2023, 09:41:40 AM
PD: I kind of miss the CROP MOOD 3x3 1080 setting as it prevented me from tinkering with the RAW Video settings and affect the other modes.

Could you give more details? I might be able to improve something.
I am not sure if I want to bring back 1080p 3x3 for 650D / 700D / 100D . . because they have native 1080p mode and it works better than crop mood 1080p preset.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: amitkattal on June 10, 2023, 12:53:06 PM
Quote from: theBilalFakhouri on June 10, 2023, 12:40:11 PM
Thanks @eardrumfilms!

Firstly we to get a single frame for each Binning mode at maximum resolution:

-5208x3478 in 1:1 (maybe we already have the map for this?)
-1736x3478 in 1x3

Then we more likely need to follow dfort tutorial about creating focus pixel maps, maybe it's somewhere in this topic (https://www.magiclantern.fm/forum/index.php?topic=16054.0).
We can already get 5208x3478 1:1 with crop mood build (Full-Res preset). I will need to create 1736x3478 1x3 preset in order to get a frame.

I will into 100D focus pixels maps this week.

Thanks for mentioning this, I thought (https://www.magiclantern.fm/forum/index.php?topic=25121.msg228273#msg228273) manual audio level settings don't work with RAW recording, this thing was definitely bugging me on 700D.
I will look into it and see if I can do something, will check what's the status on 5D3 too (does it have the same bug?).

Should be possible yes, and it seems useful in some ways. I will try to add an option in RAW video submenu to customize MLV file names.

Could you give more details? I might be able to improve something.
I am not sure if I want to bring back 1080p 3x3 for 650D / 700D / 100D . . because they have native 1080p mode and it works better than crop mood 1080p preset.

Regarding audio gain control. I was able to find a solution from very old forum post. Maybe it might help?
https://www.magiclantern.fm/forum/index.php?topic=5951.msg98839#msg98839
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on June 10, 2023, 12:53:27 PM
Quote from: theBilalFakhouri on June 10, 2023, 11:32:03 AM
At high resolutions you might want to reduce bit-depth to lower than 14-bit lossless if you need continuous recording because 14-bit is a lot of data to write.
Try 12/11/10-bit lossless.
I see.. thanks.

Quote from: theBilalFakhouri on June 10, 2023, 11:32:03 AM
I might help if you could share more info about what's happening.

I forget the step but AFAIK I changed to 1x1 full_res LV then press 10x mode and record from there after that when I changed to 1280p error message appeared on the screen
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: BatchGordon on June 10, 2023, 02:43:36 PM
Is there a way to disable entering ML menu when doing a two-fingers tap on the screen?
Sometimes I enter it by mistake just taking my eosm.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mehmet Kozal on June 10, 2023, 02:49:03 PM
Quote from: RhythmicEye on June 10, 2023, 06:39:18 AM

The issue I'm having is that I get a jump in exposure setting after hitting record. Exposure ramp is turned off and I've checked all my settings in both Canon and ML settings and there's nothing obvious to suggest user error.

Check if shutter fine-tuning is enabled.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on June 10, 2023, 04:34:04 PM
Quote from: gabriielangel on May 16, 2023, 09:45:58 PM
But when you autofocus while recording, it goes into framing mode. This makes it hard to know when focus has been nailed.

I did some research and it turns out that's actually a bug and it seems it's presented in 650D / 700D / 100D / EOS M, and it's not there on 5D3.
I implemented "preview toggle" option as temporary solution.

-Bug details:

This part of code in mlv_lite.c is resnospile for preview toggle on half shutter press, while autofocusing, Framing preview must not be triggerd:

    /* only override on long half-shutter press, when not autofocusing */
    /* todo: move these in core, with a proper API */
    static int long_halfshutter_press = 0;
    static int last_hs_unpress = 0;
    static int autofocusing = 0;

    if (!get_halfshutter_pressed())
    {
        autofocusing = 0;
        long_halfshutter_press = 0;
        last_hs_unpress = get_ms_clock();
    }
    else
    {
        if (lv_focus_status == 3)
        {
            autofocusing = 1;
        }
        if (get_ms_clock() - last_hs_unpress > 500)
        {
            long_halfshutter_press = 1;
        }
    }

    if (autofocusing)
    {
        /* disable our preview during autofocus */
        return 0;
    }


BTW lv_focus_status is coming from property. From property.h:

#define PROP_LV_FOCUS_STATUS    0x80050023 // 1 = idle, 3 = focusing in LiveView

On 5D3 while autofocusing in LiveView in both photo and video modes, lv_focus_status value change to 3, and to 1 while idle.
On 700D (and others) while autofocusing in LiveView in photo mode, lv_focus_status value change to 3 but in video mode it stays 1 even while autofocusing and that isn't what's mlv_lite is expecting.

To fix the bug in affected models we need to find a variable in Canon code which work in the same way as PROP_LV_FOCUS_STATUS to get autofocus status in video mode.




Quote from: gabriielangel on May 16, 2023, 09:45:58 PM
-in 1x3 modes, it is possible to change the aspect ratio in the crop mood menu. I don't know if it is intended to be this way, as it is not possible to do so in 1:1 modes (Where you have to change it in the Raw Video Menu)

I answered this question earlier  (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243309#msg243309)in this thread. I have a plan to get rid of of aspect ratio from crop mood submenu, and link aspect ratio from RAW video submenu to crop mood.
It could be simpler this way, beside you will have one aspect ratio setting.

Also, I might do the same thing with bit-depth.

Quote from: gabriielangel on May 16, 2023, 09:45:58 PM
-When in 2.5k 1:1, the preview shows vertical lines on screen when using lower bitrates. The lines become more visible as you go down bitrates (No lines at 14bits--->Very visible lines at 10bits). Those lines are not recorded in the file.

That's normal, they appear because we are tweaking preview configuration and what you see is the dark frame subtraction data for the preview.
They mainly appear because of using negative analog gain when using lower bit-depths, it could be there a way to control dark frame subtraction layer strength for the preview.

They also appear in other presets, but they look distorted (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243818#msg243818) because of changing horizontal RAW resolution (it should match dark frame subtraction resolution to appear correctly).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on June 10, 2023, 10:57:53 PM
Quote from: t3dkid on May 17, 2023, 05:19:48 PM
While using even the latest build on my 650D I have experienced trouble getting the shutter angle and shutter speed to display properly in the UHD 1x3 crop. I have been using the 16:9 aspect ratio, but I don't think that is important. When I use the buttons to adjust the settings, they do change (image becomes darker/brighter), and the "TV" followed by a number also changes (e.g. TV 5.6). I think it normally gets locked up while displaying 1/29 and 299 degrees. wondering if this is unique to my camera or if it is a known issue.

It's a known old issue which affect some 650D bodies, related to shutter blanking addresses and currnetly there is no solution to this issue. You didn't do anything wrong.
For now, you can rely on Canon shutter speed and set it from Canon overlay.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: eardrumfilms on June 10, 2023, 11:02:46 PM
Quote from: theBilalFakhouri on June 10, 2023, 12:40:11 PM

Could you give more details? I might be able to improve something.
I am not sure if I want to bring back 1080p 3x3 for 650D / 700D / 100D . . because they have native 1080p mode and it works better than crop mood 1080p preset.
I just like the crop mood menus a lot and bugs me a little to have to enter the raw menu to change resolutions and bitrates for 1080 and having to remember that I have to change them again for the crop mood modes. Loved having everything in one place because it made switching modes super easy but I see your point and understand why you prefer to deactivate that option too.
Thanks for your amazing work again!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on June 10, 2023, 11:17:50 PM
Quote from: Deadcode on May 18, 2023, 07:57:38 PM
Half Press x10 zoom WHILE recording dont work with Crop Mood, 700D, 2023May09. Ok, there is magic zoom 3:1 which is good and usable, but i loved x10 feature as a focus assist before crop mood.

Hi, x10 mode will not work while recording and can't work.

I think you are refering to preview zoom while recording in both Danne build and my previous build, crop mood build doesn't have it,
Currently I am not sure if it can be implemented without having corrupted frames and preview artifacts issues.




Quote from: Jonneh on May 19, 2023, 04:35:00 PM
So congratulations and thanks Bilal for some impressive breakthroughs!

Thank you! I appreciate your words. I am glad that the new build was useful for you :)
Have fun!




Quote from: bobolee on May 20, 2023, 11:03:37 AM
People treated the camera as a toy or a experiment rather than a professionals movie camera,did a little bit random test then claim it stable.The stability test of a build should be brutal/professional...
..
can you trust the thing doing this ?

I'm still testing,12 bit 1080p still crashing in long takes!

ML project never intended to be professional, see (https://www.magiclantern.fm/forum/index.php?topic=14779.msg143039#msg143039):

Quote from: dmilligan on March 23, 2015, 02:41:15 PM
Quote from: BennTech on March 23, 2015, 12:58:31 PM
professional-level project.
This is where you are totally mistaken. This is not a professional project. It is not intended to be a professional project. This is a spare time, hobby project that is just for fun. There are all kinds of disclaimers to this end.

Quote from: bobolee on May 20, 2023, 11:03:37 AM
I'm still testing,12 bit 1080p still crashing in long takes!

How long your takes are in minutes?
Consider sharing your settings and if the crash happened because you did something I am not awere of. For me, I never had crashing issues while recording.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: RhythmicEye on June 11, 2023, 04:11:22 AM
Quote from: Mehmet Kozal on June 10, 2023, 02:49:03 PM
Check if shutter fine-tuning is enabled.

Shutter fine-tuning is on and shutter set to 1/48th @23.976FPS (+0.65ms @1080p up through to +0.72ms @5.2K) and shutter lock is set to ON in "Movie Tweaks". I use this workflow in all modes to give me the 180º shutter angle I prefer to use in my shooting method.


This setting is a typical one I've always used with ML and never had this issue before. Maybe something has changed in Crop Mood that now makes this workflow redundant.

If that is the case I will just add a 1-2 stop or variable ND filter to my working method which I've been doing with Crop Mood anyway. I really like how it looks using this workflow, so maybe this will be my long term workaround if it's changed permanently.

Thanks for your reply
RE
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on June 11, 2023, 06:47:02 AM
Issue fixed when turned off? If so your settings have no effect on recordings and might as well be turned off. Even more so if you say you like your results.
Probably one of the hacks in raw video menu causing it. Learn those functions properly and what works or not.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: RhythmicEye on June 11, 2023, 08:32:26 AM
OK will take a look and do some tests and report. That makes a lot of sense though, I just haven't had time to dig much deeper than getting all the basics working more or less flawlessly in each mode. Absolutely loving Crop Mood regardless...

And a huge credit to you for all your work over the years as well Danne.

Much appreciated!
RE
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: RhythmicEye on June 11, 2023, 09:15:46 AM
Quote from: Danne on June 11, 2023, 06:47:02 AM
Issue fixed when turned off? If so your settings have no effect on recordings and might as well be turned off. Even more so if you say you like your results.
Probably one of the hacks in raw video menu causing it. Learn those functions properly and what works or not.

You're 100% correct Danne. I switched "small hacks" to ON instead of more and the issue is gone but so are the RAW performance gains. Recording stops after 40 seconds or so in 5.2K @ 12bit.

As suspected I'll have to compromise somewhere, which is fine, I just need to work out which is more important to me; 180º shutter angle or RAW performance  :-\

Thanks again
RE

EDIT: The compromise solution I came up with to give me total control of the image capture process in "5.2K" RAW (no longer 5.2K but close enough) is below

Resolution: 1712x2184 (slightly reduced from 5.2K to 5136 x 2184 in MLV App)
Aspect Ratio: 2.35:1
Data format: 11bit
Small Hacks: ON
Shutter fine-tuning: +0.63ms
Shutter lock: ON
Shutter: 1/48
FPS: 23.976
Shutter angle: 180º
Sound: Off
SD Overclock: 240Mhz
Data rate: 72MB/s approx

SD Card: Sandisk Extreme Pro 170MB/s
Build: magiclantern-crop_mood.2023May09.700D115_Shutter

These settings are giving me pretty robust RAW performance even when over exposed significantly in controlled lighting. Have not tested in daylight conditions as yet and have not checked properly for image artefacts. Seems to be artefact free atm though

P.S I use aperture, ISO and ND filters to control exposure triangle
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: RhythmicEye on June 11, 2023, 01:39:57 PM
ADDIT: Further testing in 5.2K mode with Sound ON, same settings as above with the following tweak

Resolution: 1696 x 2164 (5088 x 2164 in MLV App)
Sound: ON

Works very nice in controlled lighting so far. Icon mostly orange and green with a little red occasionally in bright highlights but continuous recording is possible.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on June 11, 2023, 02:08:22 PM
Quote from: Jonneh on May 20, 2023, 03:28:39 PM
- When initiating recording from the x10 mode, I get a raw detect error or "recording stopped automagically" and a 2kb file is produced. I often frame first and then set focus in the x10 mode and start recording from there.

Hmm, never had this issue . . at least on 700D. If crop mood is active and you hit recording button in x10 mode, mlv_lite will set the preview back to x5 mode (normal preview), this commit (https://github.com/bilalfakhouri/magiclantern_hg_02/commit/8c501f62ed33f02459e7b84baf5068fdaf5a344f).
The issue you mentioned is probably only happen on 100D, probably something related to buffer reallocation when changing among preview modes, I will check that soon on 100D.


Quote from: Jonneh on May 20, 2023, 03:28:39 PM
- I occasionally get staggered horizontal lines in the preview.

(https://i.ibb.co/vxsmmTD/IMG-20230519-175522.jpg)

These are normal, they appear because of changing preview configuration, more details, vertical lines issue (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243979#msg243979).
on 100D, set focus box to center (horizontally) and they will be less visible.

Quote from: Jonneh on May 20, 2023, 03:28:39 PM
- Pressing the up and down arrows around the set button crash ML, requiring battery removal.

More details are needed so I run a test, what was your camera settings?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on June 11, 2023, 02:13:56 PM
Quote from: gabriielangel on May 22, 2023, 02:19:47 AM
I tested HDR video today and it works surprisingly well!
@bilal, the way you made it alternate between both ISO's slowly is genius.

This is an old good feature was made before my time, as Danne said, it wasn't me, it's a1ex work :D
I didn't change anything regarding HDR video in my fork, it's based on official crop_rec_4k_mlv_snd branch.

Quote from: gabriielangel on May 22, 2023, 02:19:47 AM
Is there a way to see the "Merged" image in mlv app? It would be nice if it behaved like dual ISO does..

You might want to ask MLVApp devs about this in MLVApp thread. It would be useful feature, yes.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on June 11, 2023, 04:05:41 PM
Quote from: RhythmicEye on June 11, 2023, 04:11:22 AM
Shutter fine-tuning is on and shutter set to 1/48th @23.976FPS

Try setting your shutter to 1/42 (or the closest value, depending on the resolution you are using). That way, you don't need to use shutter fine tuning, and there is no appreciable difference. The image remains sharp down to 1/30 (unless you are filming fast cars, etc.). This allows you to use all the hacks and record 3K 12 bit for at least 30 seconds on a freshly formatted card. The gain in clarity / fov trumps the motion blur difference (if any) in my opinion.

By the way, to get the exact same motion blur I am used to at 1/48 on a Sony cam, I need to set my eos m to 1/44 - 1/46.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on June 11, 2023, 10:28:19 PM
Quote from: mlrocks on May 26, 2023, 06:57:04 PM
Just tested Crop mood's 1x1 full resolution 14 bit lossless fps = 3 mode on 650d. Basically, this mode is not working.

You need to turn off sound recording (beside 240 MHz, Small hacks to All/More), I mentioned this in first post, also in my build walkthrough video.




Quote from: amitkattal on May 31, 2023, 03:07:25 AM
Is it possible to have L/R buttons change shutter speed ? I use manual lenses so it makes more sense to have Up/down buttons change ISO and have L/R buttons change shutter since those two are only things we can control with manual lenses.

It seems L/R from customize buttons doesn't do anything on EOS M (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243660#msg243660), beside you can already change shutter speed using the wheel (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243654#msg243654) (check the linked video at 9:00).




Quote from: eardrumfilms on June 03, 2023, 10:44:04 PM
Are the 100D focus pixels maps already available for MLVapp? If they aren't yet, is there any way we users with a 100d but without coding skills can help making them?

It's not available yet, there are old maps but might not fit for all of new crop mood presets. I answered here (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243974#msg243974) too with some info.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on June 11, 2023, 10:53:08 PM
Thanks @RhythmicEye!

Quote from: RhythmicEye on June 10, 2023, 06:39:18 AM
The issue I'm having is that I get a jump in exposure setting after hitting record. Exposure ramp is turned off and I've checked all my settings in both Canon and ML settings and there's nothing obvious to suggest user error.

This an old issue which is related to susepdning aewb task i.e when setting Small hacks to "More" also when using shutter fine-tuning.

Quote from: RhythmicEye on June 11, 2023, 09:15:46 AM
As suspected I'll have to compromise somewhere, which is fine, I just need to work out which is more important to me; 180º shutter angle or RAW performance  :-\

What about having both without a compromise :D :
I was able to find a workaround and fix the issue three days ago, this commit (https://github.com/bilalfakhouri/magiclantern_hg_02/commit/7c1e9dd9c55753799369df9bff73e8d79322f47d) (no one noticed the commit? :P). The fix will be available in next release, you can also compile from the source if you want.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on June 12, 2023, 01:08:15 AM
Quote from: RhythmicEye on June 10, 2023, 06:39:18 AM
P.S Do you have a "Buy Me A Coffee" account? :-}

Thanks! I appreciate it, currently I don't have a personal funding account, also I am not sure if I want to create one.
Well, you can probably still be able to support ML project by donating to ML bitcoin address (https://www.magiclantern.fm/donate.html) (if you are familiar with Bitcoin).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on June 12, 2023, 07:21:06 AM
Quote from: theBilalFakhouri on June 11, 2023, 10:53:08 PM
Thanks @RhythmicEye!

This an old issue which is related to susepdning aewb task i.e when setting Small hacks to "More" also when using shutter fine-tuning.

What about having both without a compromise :D :
I was able to find a workaround and fix the issue three days ago, this commit (https://github.com/bilalfakhouri/magiclantern_hg_02/commit/7c1e9dd9c55753799369df9bff73e8d79322f47d) (no one noticed the commit? :P). The fix will be available in next release, you can also compile from the source if you want.
Hehe, good work!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on June 18, 2023, 04:00:43 PM
If I put a 1TB Sandisk Extreme Pro SD Card into the EOS M, will "Crop Mood" allow me to record in 1080p "Non-RAW" indefinitely with no recording limit (not Raw) for many hours? Also will it split the files or be one big video file? Asking because I want to use the EOS M as sort of a CCTV camera for like 5+ hours at a time (with external power) but Raw files would be too big in filesize for multiple cameras. I remember testing this on Danne's build, but if I remember correctly it might have had artifacts that would need fixed in MLV app, but you can only open Raw files in that. I may have done something wrong, though as I can't remember so don't quote me on that. I also only tested with a 64GB card until the battery ran out. In short, I just need to record in 1080p or higher without Raw for many hours without artifacts, basically. It would be cool to use a higher resolution, but I assume you can only do that with Raw Video. Thank you
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on June 18, 2023, 04:11:44 PM
5 hours: Sure. But not seamless. See https://wiki.magiclantern.fm/faq/#how_do_i_record_stream_for_more_than_30_minutes
You will get a bunch of MOV files. Most likely 3 for each 30 minute take.

If you can keep data rate below 59 MByte/s you may be able to record raw and seamless. Not sure how file handling will do, though. If you don't use ExFAT option (generate files > 4 GB) you will end up with more than 101 chunks and I don't know if file naming can count beyond *.M99. Using the ExFAT option with generate one big file and if anything happens during recording there is a chance file will not be closed correctly and manual bit level wizardry is required. No fun for files in the 900 GB area, I suppose.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on June 19, 2023, 01:18:42 AM
[Mod: full quote deleted]

Yeah I guess seamless would not be smart since it can get corrupted for important footage. I think using RAW will just take up too much space with 4 cameras for 5+ hours and keeping backups of all the data everytime I do it... but I will do a test and calculate anyway. Thanks for the reply!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on June 19, 2023, 04:31:16 AM
I forgot: H.264 with Canon's default settings will only need around 5.5 MByte/s bandwidth. For 5 hours recording you just need
5.5 MByte/s x 5 x 3600s = 99,000 MByte.
A 1 TB card should be good for around 50 hours and you definetely don't need a fast and expensive Extreme Pro. Any Class 10 will do fine.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on June 19, 2023, 06:19:19 PM
Alright thanks. I will probably just get 256GB, but I get Extreme Pros always anyway for everything. How many hours do you think of 1080p raw you can get on 1TB?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on June 19, 2023, 08:13:00 PM
Vertical pixel x horizontal pixel x frame rate x bit depth x compression factor / 8 = Bytes/s

1920 x 1080 x 24 x 14 x 0.4 / 8 = 34836480 Bytes/s = 33.3 MByte/s

953,674 / 33.3 = 28.639 seconds -> almost 8 hours.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on June 20, 2023, 09:26:39 PM
Thanks, Walter. That is pretty good. I might do that. Only issue is backup storage. Would have to remove any parts of the video that is useless.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on June 21, 2023, 06:49:49 PM
So with Crop Mood you can now use EOS M for streaming live good with HDMI?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on June 21, 2023, 08:16:33 PM
Now?
It worked with lua_fix since 2020. And before with 30-min workaround.
No difference.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: RhythmicEye on June 23, 2023, 02:57:37 AM
Quote from: gabriielangel on June 11, 2023, 04:05:41 PM
Try setting your shutter to 1/42 (or the closest value, depending on the resolution you are using). That way, you don't need to use shutter fine tuning, and there is no appreciable difference. The image remains sharp down to 1/30 (unless you are filming fast cars, etc.). This allows you to use all the hacks and record 3K 12 bit for at least 30 seconds on a freshly formatted card. The gain in clarity / fov trumps the motion blur difference (if any) in my opinion.

By the way, to get the exact same motion blur I am used to at 1/48 on a Sony cam, I need to set my eos m to 1/44 - 1/46.

Thanks Gabriielangel!!!

Good advise right here. I just needed a little kick to get past my pedantic nature to see the light. This little tip gave me the clue to get a fully functional set of modes from 1080p through to 5K. I had to make some tweaks in some of the more data intensive modes but more or less totally functional across the park. 3K is the most unstable and the only one where continuous recording is sketchy although it is possible in some conditions.

I'll do some day light testing in the coming days and report back with a detailed list for each mode.

Thanks again
RE
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: RhythmicEye on June 23, 2023, 03:03:09 AM
Quote from: theBilalFakhouri on June 12, 2023, 01:08:15 AM
Thanks! I appreciate it, currently I don't have a personal funding account, also I am not sure if I want to create one.
Well, you can probably still be able to support ML project by donating to ML bitcoin address (https://www.magiclantern.fm/donate.html) (if you are familiar with Bitcoin).



Yes I'm very familiar with Bitcoin. However it's been tanking recently and I'd prefer my donation didn't devalue once donated  ;D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: RhythmicEye on June 23, 2023, 03:06:13 AM
Quote from: theBilalFakhouri on June 11, 2023, 10:53:08 PM
Thanks @RhythmicEye!

This an old issue which is related to susepdning aewb task i.e when setting Small hacks to "More" also when using shutter fine-tuning.

What about having both without a compromise :D :
I was able to find a workaround and fix the issue three days ago, this commit (https://github.com/bilalfakhouri/magiclantern_hg_02/commit/7c1e9dd9c55753799369df9bff73e8d79322f47d) (no one noticed the commit? :P). The fix will be available in next release, you can also compile from the source if you want.

Bilal, Bilal, Bilal!!! Crop Mood is becoming the uber beast of beast ML builds.

Awesome work.
RE
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on June 29, 2023, 03:51:57 AM
Quote from: theBilalFakhouri on June 11, 2023, 10:28:19 PM
You need to turn off sound recording (beside 240 MHz, Small hacks to All/More), I mentioned this in first post, also in my build walkthrough video.

Thank you, Bil. You are right. I had the sound on.





It seems L/R from customize buttons doesn't do anything on EOS M (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243660#msg243660), beside you can already change shutter speed using the wheel (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243654#msg243654) (check the linked video at 9:00).




It's not available yet, there are old maps but might not fit for all of new crop mood presets. I answered here (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243974#msg243974) too with some info.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on June 29, 2023, 03:54:14 AM
Quote from: gabriielangel on May 28, 2023, 06:01:47 PM
Have you tried turning sound recording off before recording? The way Bilal stated it in the first post suggests that no sound will be recorded when using that mode, but for it to work, you actually need to turn sound recording off.

Thanks. I did not. I will try sound off.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on June 29, 2023, 04:01:12 AM
To my eyes, 650d ml footage is even better than that from some famous log based video cameras. Bravo.
I suspect that none of the log based video cameras can compete with 650d/700d/100d/m ml crop mood. Except the Alexas with 12 bit prores4444 (internal actually 14 bit).
In other words, only raw video cameras may compete with ml crop mood cameras and 5d3.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ThePotatoParadox on June 29, 2023, 07:19:05 PM
Are there plans to make the playback fully functional?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on June 29, 2023, 09:19:28 PM
Mission impossible: Not enough processor power.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on June 30, 2023, 11:09:51 PM
Personally I don't have plans to work on in camera real-time MLV playback,
but I believe it might be possible if we understand how camera image processing engines work (i.e hardware accelerators), e.g the camera can already process RAW data in real-time in LiveView.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: bobolee on July 01, 2023, 06:24:05 AM
I'm here to report some minor issues I've encountered:
1,Horizontal lines on "1:1 presets 2.5k 10bit",no issue on 14 bit.

2,Frame order error.Won't get this error message everytime,but it pops up randomly.Seems like it will get this error more if  a slower speed sd card was in use.The footage recorded looks OK on MLV APP.

3,Is there anything you can do to make the temperature lower ?
(https://i.ibb.co/RjzV64b/IMG-20230630-140244.jpg) (https://ibb.co/Vw2PCp9)
4,When using FPS override ,chose "optimize for exact fps",the screen will go corrupt.I don't have picture to show this one,but it's easy for you to find this problem.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: bobolee on July 01, 2023, 09:57:04 AM
Instead of making a "out of the box,ready to be use by newbies" build,this build is likely to give users more freedom to make changes to suit various kinds of shootings.I applaud this idea.But I can't make changes to parameters of cinematography(like:resolution,fps,crop factor,etc) in this build ,it is still "presets" based.Why can't I have my own presets which I can define the resolution-fps-crop factor,etc I like?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on July 02, 2023, 09:20:28 PM
Quote from: bobolee on July 01, 2023, 09:57:04 AM
Why can't I have my own presets which I can define the resolution-fps-crop factor,etc I like?

Because every preset requires dev work to get working correctly.  This is harder than you might expect.

You can have this if you're willing to learn C, experiment, debug the code, determine a reliable algorithm that maps the settings you want to the internal settings needed on the cam, and then finally, exposes this to the user in a new menu system you also need to code.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on July 04, 2023, 02:33:57 PM
hi bilal..
is it possible to add 3:2 ratio 1x1 and 1x3 mood preset?
I think this is more versatile in re-framing in post..

thanks.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: eardrumfilms on July 04, 2023, 02:54:41 PM
Quote from: ML700D on July 04, 2023, 02:33:57 PM
hi bilal..
is it possible to add 3:2 ratio 1x1 and 1x3 mood preset?
I think this is more versatile in re-framing in post..

thanks.

And maybe it's a dumb question but will it be possible in the future to have vertical aspect ratios? Not for having vertical video but for filming horizontal video with the camera in vertical so the rolling shutter doesn't affect horizontal pans and movements. Does it make any sense?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on July 04, 2023, 03:20:23 PM
Quote from: ML700D on July 04, 2023, 02:33:57 PM
hi bilal..
is it possible to add 3:2 ratio 1x1 and 1x3 mood preset?
I think this is more versatile in re-framing in post..

thanks.

** I changed my mind.. 3:2 in 1x3 mood will be 4.5:1 ratio which is  too wide lol..
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on July 04, 2023, 03:31:54 PM
Quote from: eardrumfilms on July 04, 2023, 02:54:41 PM
And maybe it's a dumb question but will it be possible in the future to have vertical aspect ratios? Not for having vertical video but for filming horizontal video with the camera in vertical so the rolling shutter doesn't affect horizontal pans and movements. Does it make any sense?

Not a dumb question, but off topic for this post and has been asked several times before.  Should be possible, don't think anybody has tried to implement it.

It won't remove rolling shutter of course, just change what the effect looks like.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on July 06, 2023, 09:26:52 AM
hi bilal,
when I record using crop mood 1x3 higher (1392x2350) and 1x1 1440p, why its required recording speed is unstable? sometimes it need above 100mb/s or 95mb/s but sometimes I can record more than 10 seconds in the same setting?


Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on July 06, 2023, 10:25:11 AM
Compression efficiency depends on scene and exposure. Overexposure may break compression.
Some guy here did some thorough investigation. Can't find it right now.

https://www.magiclantern.fm/forum/index.php?topic=26851.msg243544#msg243544
https://www.magiclantern.fm/forum/index.php?topic=25781.msg240610#msg240610
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on July 06, 2023, 11:15:39 AM
Quote from: Walter Schulz on July 06, 2023, 10:25:11 AM
Compression efficiency depends on scene and exposure. Overexposure may break compression.
Some guy here did some thorough investigation. Can't find it right now.

https://www.magiclantern.fm/forum/index.php?topic=26851.msg243544#msg243544
https://www.magiclantern.fm/forum/index.php?topic=25781.msg240610#msg240610

I see.. thanks Walter
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 10, 2023, 12:20:36 AM
Hi, I am the guy who cannot run ML / Crop Mood on his EOS 100D.
I am now posting in this thread, as requested by theBilalFakhouri.

Quote from: theBilalFakhouri on July 09, 2023, 11:47:11 PM
The crashes you are having are related to crop mood module because of changing preview configuration or in other words something related to LiveView (that what I can tell from this log (https://www.magiclantern.fm/forum/index.php?topic=26947.msg244287#msg244287)).
Can this be fixed somehow? Any settings that I need to tweak?

Quote from: theBilalFakhouri on July 09, 2023, 11:47:11 PMPlease share your ML settings, which preset exactly are you using at which aspect ratio (from crop mood menu)?
I am using the 5.2K, 4.8K and 4.4K presets at 2.35:1  aspect ratio. 10 bit color depth.

Quote from: theBilalFakhouri on July 09, 2023, 11:47:11 PMDo all crop mood presets cause crashes?
Yes. They all cause crashes. Or at least the ones that I have tried so far (5.2K, 4.8K and 4.4K)

Quote from: theBilalFakhouri on July 09, 2023, 11:47:11 PMCustomize buttons only work while crop mood is active and in normal preview.
I think Crop Mood is active on my camera. Isn't it one of the modules that the user turns ON from the very beginning?
Sorry if my replies sound lame. I have no idea what I am doing.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on July 10, 2023, 12:35:52 AM
Quote
I think Crop Mood is active on my camera. Isn't it one of the modules that the user turns ON from the very beginning?

If the cam crashes, all modules are automatically disabled on the next boot as a safety measure.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 10, 2023, 12:48:14 AM
Quote from: names_are_hard on July 10, 2023, 12:35:52 AM
If the cam crashes, all modules are automatically disabled on the next boot as a safety measure.
This is bizarre, because even after hundreds of crashes, the modules that I turned on in the very beginning are still active.
They are:

(https://i.postimg.cc/d1D6jChs/IMG20230710014434.jpg)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on July 10, 2023, 12:57:54 AM
Not really bizarre, there are many possible reasons.  Perhaps Bilal changed the behaviour on purpose.  Perhaps your camera isn't crashing.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 10, 2023, 01:27:20 AM
Quote from: Wannabe on July 10, 2023, 12:20:36 AM
Can this be fixed somehow? Any settings that I need to tweak?

If we know the cause we might be able to find a workaround, yes.
I think the problem can be fixed if you replace the internal battery (https://youtu.be/GNdNrsYcT0E?t=1680) :P

Quote from: Wannabe on July 10, 2023, 12:20:36 AM
I am using the 5.2K, 4.8K and 4.4K presets at 2.35:1  aspect ratio. 10 bit color depth.
Quote from: Wannabe on July 10, 2023, 12:20:36 AM
Yes. They all cause crashes. Or at least the ones that I have tried so far (5.2K, 4.8K and 4.4K)

5.2K 2.35:1 preset doesn't work fine on 100D (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243972#msg243972), I will make some tweaks to this preset on 100D in next release.
But since all of 2.35:1 1x3 (5.2K, 4.8K and 4.4K) presets are crashing, then crashing issues aren't related to a specifc preset.


-My geuss on what's happening (the following bug only affect 100D):

I had random crashing issues when I ported crop_rec.c (i.e crop_mood.mo) to 100D, the camera could crash at starup when crop mood is already active (from Movie tab) if the camera swtich turned from OFF to movie mode directly.
Crashes could also happen randomly when switching presets, this issue was bugging me for months, until I figured out what was happening:

It seems to happen because of changing zoom modes (among x1, x5 and x10) via ML call in crop_rec.c, if zoom mode changed directly after enerting LiveView the camera sometime crash,
or at least if it didn't crash right away, it can crash when swtiching presets or after some time when crop mood is active in LiveView, maybe that's happening because of changing LV zoom mode while LiveView isn't fully configured yet?

Good news that this issue was fixed with these two (https://github.com/bilalfakhouri/magiclantern_hg_02/commit/57d2701d0d25d5971644c22c7d4bfd99da203a74) commits (https://github.com/bilalfakhouri/magiclantern_hg_02/commit/da5c31a2c7c9d18793ce91e48668aaf652be9ecb), so why it still happen for you:

Probably because of your 100D is asking to set date/time each time (https://www.youtube.com/shorts/WOl37HwIeds) I guess on startup?
At this moment, I am guessing that crop_rec.c is making calls to change zoom mode (outside LV or when LV isn't fully configured yet), the added "msleep(700);" delay isn't enough is this case.

-Test to try:
Swtich camera from OFF to Photo mode first, set date/time (or just press cancel) then switch it to movie mode, try recording in 4.8K with same settings, does it crash?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 10, 2023, 01:43:32 AM
Quote from: Wannabe on July 10, 2023, 12:48:14 AM
..because even after hundreds of crashes, the modules that I turned on in the very beginning are still active.

There is a setting in Debug menu to always load modules even after a crash, it could be that.
The modules will not be loaded only for next camera boot after a crash, but after that (after another boot) modules will load normally.

Quote from: names_are_hard on July 10, 2023, 12:57:54 AM
Perhaps Bilal changed the behaviour on purpose.

Not really, didn't touch that.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 10, 2023, 02:39:54 AM
Quote from: theBilalFakhouri on July 10, 2023, 01:27:20 AM
Swtich camera from OFF to Photo mode first, set date/time (or just press cancel) then switch it to movie mode, try recording in 4.8K with same settings, does it crash?
I believe it worked now. I think I recorded a video in Crop Mood (unless it's been just the regular Canon video mode, not quite sure). When I manually stopped the recording, the camera crashed and turned itself off.

Now I also have to deal with the ISO problem - it's stuck at 6400 and cannot be lowered. Maybe I'm doing something wrong here. How do you change the ISO and aperture in Crop Mood anyway?
The custom buttons are not functional and the aperture dial is not working as well.

If I try to do a 10X zoom using the set button, the camera turns itself off and crashes.

Also, Crop Mood doesn't load anymore. Maybe it went back to what names_are_hard was talking about and stopped loading after a crash.

This camera is a gigantic MESS. Absolutely useless and unreliable in any aspect imaginable.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 10, 2023, 04:14:42 AM
I don't have problems with my 100D and crop mood, it works fine here.
I think it's time to format SD card in PC and make a clean install again, does it work?

ISO stuck? Are you using Manual mode in first place?
If the settings are set to auto then ML can't change these settings, you need to set mode dial to "M", also set ISO to specific value from Canon menu.

You can change ISO and aperture from ML menu in Expo tab or use 100D physical buttons (read Canon manual), you can also use "customize buttons" for ISO and Aperture.

If it still crashes, recrod a video shows what are you doing on your 100D from A to Z (from a fresh ML install to camera crash moment).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 10, 2023, 09:33:32 AM
Thanks!
Regarding the ISO lock: I knew it that it was me who was doing something wrong. I'm still not familiar with all the Canon settings and ML menus.
The crashes are worrying, though.
I am currently out of battery juice and I don't have a charger. Will post an update when my charger arrives. Will try to create a thorough video too.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: [email protected] on July 10, 2023, 06:10:57 PM
Any chance this will become available for the 1200D? I'm guessing DIGIC 4 is a no go, but just curious.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on July 10, 2023, 07:24:58 PM
Quote from: [email protected] on July 10, 2023, 06:10:57 PM
Any chance this will become available for the 1200D? I'm guessing DIGIC 4 is a no go, but just curious.

We haven't found any method to do overclocking on cams hosting Digic 4. So it is 20 MByte/s vs 80 MByte/s. And ATM nobody is working on implementing lossless compression for RAW recording for Digic 4. Compression in controlled environment (no overexposure) gives around 60% data stream reduction. So virtually 20 vs 200 in pixel crunching abilities.

In short: This is a pipe dream. Get yourself a 650D. They are pretty cheap now.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: [email protected] on July 11, 2023, 02:20:03 AM
Will do. Thank you Walter! Appreciate the info
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Skinny on July 11, 2023, 10:25:30 AM
With lossless compression and let's say 10 bit recording digic 4 cameras with SD card COULD be somewhat useful if you want to record only short clips like 10 seconds.. When I film something just for pleasure I rarely do more than 15-20 seconds. Usually it is enough. If you are doing stuff like b-roll then it can be ok..
Of course if you want to record an interview or a long video then obviously you'll need another camera..
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: vstrglv on July 11, 2023, 09:09:11 PM
Any progress for 5D3?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mineralof on July 12, 2023, 06:00:59 PM
What am I doing wrong?
Canon 650d.
speed test in photo mode for writing and reading is consistently above 80mb.
and in video mode 20

(https://i.postimg.cc/jCx6y6XT/1.jpg) (https://postimg.cc/jCx6y6XT) (https://i.postimg.cc/0b3pgTq5/2.jpg) (https://postimg.cc/0b3pgTq5)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on July 12, 2023, 06:35:02 PM
Change Access Mode (oc submenu) to SDR50 and retry.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 12, 2023, 09:18:21 PM
Hi!
So, I now have a battery charger and I can do as many experiments as I want.

Magic Lantrern / Crop Mood still does not work properly and it still shuts my camera down whenever I try to use it.
I cannot record more than 1 seconds (or less) of video on my Canon EOS 100D.

I tried deleting everything from the SD card and then formatting it. I then pasted a new copy of ML/Crop Mood on the freshly formatted SD card and did a re-install from the firmware update menu.
I then turned ON all the necessary modules and set my SD Access mode to SDR50. I also lowered the bit depth to 10 bit. I made sure to set the date and time, and I made sure to turn the camera on in photo mode first, then wait a few seconds before switching to video mode.
All of this did nothing to solve the problem.

I still cannot use my camera with ML/Crop Mood.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on July 12, 2023, 10:20:10 PM
Where's your screen recording? Sounds like a faulty card or some foreseen user mistake. Hard to tell. Maybe hardware since you say it shuts down all the time.
Did you try any other builds for 100D? Another card?
Anyway. Repeating failure messages without screen recording at this stage won't help.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 12, 2023, 10:40:00 PM
Quote from: Danne on July 12, 2023, 10:20:10 PM
Where's your screen recording? Sounds like a faulty card or some foreseen user mistake. Hard to tell. Maybe hardware since you say it shuts down all the time.
Did you try any other builds for 100D? Another card?
Anyway. Repeating failure messages without screen recording at this stage won't help.

Maybe the SD card is faulty... who knows?
The card does very well on the benchmarks, but I realize that this proves nothing.

This is my first experience with Magic Lantern and I haven't tried any other builds. Just the newest Crop Mood build.
I will record a new video showcasing the problem, but I am afraid that the new video will not be much different from the one that I already posted.
Here is the old video:

https://www.youtube.com/watch?v=WOl37HwIeds

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 12, 2023, 11:34:28 PM
Here is a new video that I made.
I try to explain the situation to the best of my abilities with my broken English.
I also show my Sandisk Extreme Pro MICRO SD card which could potentially be causing the issue...


https://www.youtube.com/watch?v=ydODiPUb2cY
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on July 13, 2023, 12:00:29 AM
Some main points from the video:
ML is stable on this cam and runs for over a minute with zero problems.  It does not shut down your cam when you try to use it.  The demonstrated problems only seem to occur when video is recorded.
Video recording error is demonstrated around 1:45 in the video.  This is an error of some kind because we reach the "Movie recording stopped automagically" message in mlv_lite.c
It's not clear if the camera crashes, shuts down, or just goes to sleep because it's idle (recording has stopped and you're not touching the controls, it may go to sleep).

Why do you think it's crashing?
Is anything saved to the card?  I would expect a small video file.  There may also be log files (I think you gave some logs before; please provide the logs associated with this specific video).

I think the most likely problem is you're trying to record at too high a data rate for the card / cam / settings combination.  Can you successfully record in easier, lower resolutions?  Try the lowest available raw video mode.  We want to learn if your cam can record raw video at all with this build.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 13, 2023, 12:18:26 AM
Quote from: names_are_hard on July 13, 2023, 12:00:29 AM
It's not clear if the camera crashes, shuts down, or just goes to sleep because it's idle (recording has stopped and you're not touching the controls, it may go to sleep).
It is a crash, not an automatic shut down. The camera crashes and only pulling the battery out and inserting it back in can return it to working order.

Quote from: names_are_hard on July 13, 2023, 12:00:29 AM
Why do you think it's crashing?
Because there are crash logs and also because it cannot be turned on, unless you remove the battery.

Quote from: names_are_hard on July 13, 2023, 12:00:29 AM
Is anything saved to the card?  I would expect a small video file.  There may also be log files (I think you gave some logs before; please provide the logs associated with this specific video).
Yes, there is a small video file saved. It is about half a second long in duration.

Quote from: names_are_hard on July 13, 2023, 12:00:29 AM
I think the most likely problem is you're trying to record at too high a data rate for the card / cam / settings combination.  Can you successfully record in easier, lower resolutions?  Try the lowest available raw video mode.  We want to learn if your cam can record raw video at all with this build.
I will do a test at the lowest resolution possible. If this test turns out to be successful, this will mean that my SD card is at fault and I need a new card.
Another $200 that ML is going to cost me.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 13, 2023, 12:56:31 AM
Oh, I just made some new tests on my 100D using 9 May build and sometime I did encounter the same issue you described.
Fow now, please try magiclantern-crop_mood.2023Apr19.100D101_hot_fix.zip (https://bitbucket.org/bilal_fakhouri/crop-mood-builds/downloads/magiclantern-crop_mood.2023Apr19.100D101_hot_fix.zip) build, does it have same issue too?

I probably broke something in 9 May build and it affect 100D.

Again the SD card isn't related to this issue (also the internal battery isn't related), it's something related to LiveView and our ENGIO hook (https://www.magiclantern.fm/forum/index.php?topic=26851.msg244345#msg244345) (some delay could solve the issue).

@Wannabe You don't need to turn on the camera to photo mode each time, it was a just a test, you can turn on the camera to video mode directly.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 13, 2023, 01:11:41 AM
Quote from: vstrglv on July 11, 2023, 09:09:11 PM
Any progress for 5D3?

Short answer: for me, no.

Currently I am being barely active on ML, I am trying to organize my life a little and find some balance, I am okay, don't worry.
I didn't do much work on 5D3 since the release of crop mood, I still have a plan to work on 5D3 again and be more active in general.

I will let you know when I have something to share, just like this sneak-peek (https://www.magiclantern.fm/forum/index.php?topic=25287.msg241871#msg241871) :D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 13, 2023, 01:13:20 AM
Quote from: theBilalFakhouri on July 13, 2023, 12:56:31 AM
Oh, I just made some new tests on my 100D using 9 May build and I did encounter the same issue you described.
Fow now, try magiclantern-crop_mood.2023Apr19.100D101_hot_fix.zip (https://bitbucket.org/bilal_fakhouri/crop-mood-builds/downloads/magiclantern-crop_mood.2023Apr19.100D101_hot_fix.zip) build, does it have same issue too?

I probably broke something in 9 May build and it affect 100D.

Again the SD card isn't related to this issue (also the internal battery isn't related), it's something related to LiveView and our ENGIO hook (https://www.magiclantern.fm/forum/index.php?topic=26851.msg244345#msg244345) (some delay could the solve the issue).

@Wannabe You don't need to turn on the camera to photo mode each time, it was a just a test, you can turn on the camera to video mode directly.
Hi Bilal, in a bizarre way it is almost good to hear that I am not the only one experiencing this issue.
I was starting to believe that I'm just too dumb to operate a camera that has Crop Mood installed.

Tomorrow I will check out the alternative build that you posted above.
How do I remove the 9 May build completely? Do I just erase it from the SD card, or do I have to uninstall it somehow from the camera as well?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 13, 2023, 01:28:19 AM
Quote from: bobolee on July 01, 2023, 06:24:05 AM
1,Horizontal lines on "1:1 presets 2.5k 10bit",no issue on 14 bit.

It's normal (https://www.magiclantern.fm/forum/index.php?topic=26851.msg243979;topicseen#msg243979)  (check "vertical lines on screen" part).

Quote from: bobolee on July 01, 2023, 06:24:05 AM
2,Frame order error.Won't get this error message everytime,but it pops up randomly.Seems like it will get this error more if  a slower speed sd card was in use.The footage recorded looks OK on MLV APP.

Sometime I get this error too, but it seem it dosen't affect recording and it doesn't produce corrupted frames.
This error isn't something bad, it's more like a warning.

For example on 5D3 and when using card spanning, this error is always presensted, I just made it hidden and things worked fine, also Danne did the same thing on EOS M in his builds.

I am not sure if it a good step to always hide this error, it might be a good warning for a possibility of corrupted frames?

Quote from: bobolee on July 01, 2023, 06:24:05 AM
3,Is there anything you can do to make the temperature lower ?

With ML? I don't know, probably not.
BTW and IIRC, on 700D the camera shows overheat icon then shut down at around ~85 C° to ~90 C°, so 60 C° isn't that bad (at least to me).

Quote from: bobolee on July 01, 2023, 06:24:05 AM
4,When using FPS override ,chose "optimize for exact fps",the screen will go corrupt.I don't have picture to show this one,but it's easy for you to find this problem.

I am assuming you are using crop mood presets with FPS override, right? This combo doesn't work well togather, same as:

Quote from: a1ex on April 01, 2017, 11:15:41 AM
Does it work with FPS override?

Sort of. It's not reliable at this point, so it's best not to try yet.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 13, 2023, 01:51:50 AM
Quote from: Wannabe on July 13, 2023, 01:13:20 AM
How do I remove the 9 May build completely? Do I just erase it from the SD card, or do I have to uninstall it somehow from the camera as well?

Format SD card in PC or Camera (press AV button to toggle to "remove ML"), then install the mentioned build.
There are other ways too, but let's use this for our case.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 13, 2023, 09:17:55 AM
Alright guys, here is an update: I replaced the 9 May build for Canon EOS 100D with the April 19 build. The camera still crashes after I did the downgrade.

I then lowered the resolution to see if the problem was caused by a slow SD card (as advised by the user names_are_hard). And tada!
The camera now records without interruption at the lowest setting possible and then it records 10-15 second videos at some of the higher resolutions.

I noticed that there was a MB/sec indicator under the green/orange/red camera icon.
In my case this indicator was showing 20 MB/sec most of the time. I tried shooting in both access modes - SDR50 and SDR104. The indicator was reporting around 20 MB/sec regardless of the access mode.
I think that this whole mess may indeed be caused by a crappy SD card.
Is it time for me to open my pocket for a decent SD card? That is the question...  :)


Edit: I stand corrected. In some aspect ratios the indicator shows ~50 BM/sec.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on July 13, 2023, 09:32:45 AM
sandisk extreme pro 170 mb/s is enough for me..
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on July 13, 2023, 09:33:45 AM
Look. It is probably something not working properly with sd_uhs code, meaning your card is ok etc. You shoule test other builds and see if they work as expected, meaning you could get ok raw recordings performance with other builds. If so, your card is probably ok. Remember, you are using bleeding edge builds. If lucky, it will work as expected, but not always.
Been a while I used my 100D but here´s a version with some older code I have shared before. How will it work with sd_uhs enabled?
https://bitbucket.org/Dannephoto/magic-lantern_dannephoto_git/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_100D_2023Jul13.100D101.zip

There´s also nightly builds you could test:
https://builds.magiclantern.fm/
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 13, 2023, 09:44:43 AM
Quote from: Danne on July 13, 2023, 09:33:45 AM
Look. It is probably something not working properly with sd_uhs code, meaning your card is ok etc. You shoule test other builds and see if they work as expected, meaning you could get ok raw recordings performance with other builds. If so, your card is probably ok. Remember, you are using bleeding edge builds. If lucky, it will work as expected, but not always.
Been a while I used my 100D but here´s a version with some older code I have shared before. How will it work with sd_uhs enabled?
https://bitbucket.org/Dannephoto/magic-lantern_dannephoto_git/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_100D_2023Jul13.100D101.zip

There´s also nightly builds you could test:
https://builds.magiclantern.fm/
Thanks, I will test the builds that you posted as soon as possible.
So far I have only tested the two Crop Mood builds by Bilal Fakhouri.

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on July 13, 2023, 09:55:37 AM
Quote from: Wannabe on July 13, 2023, 09:17:55 AM
In my case this indicator was showing 20 MB/sec most of the time. I tried shooting in both access modes - SDR50 and SDR104. The indicator was reporting around 20 MB/sec regardless of the access mode.
I think that this whole mess may indeed be caused by a crappy SD card.

20MB/s is what happens when the card drops back to a safe mode, because we tried to push it too hard.  This doesn't mean the card is bad.  It *can*, but it can also be some configuration problem.  Even very good cards will do this if you pick the wrong options.

Check Bilal's test build and work with him to find out why 100D changed how it behaves.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 13, 2023, 11:16:03 AM
I installed Danne's build ( https://bitbucket.org/Dannephoto/magic-lantern_dannephoto_git/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_100D_2023Jul13.100D101.zip
).
Wow! The camera now works without any issues. It does not shut down and I believe I was able to record at the highest resolution possible (which for this build was 4K anamorphic). I recorded a minute and a half before I got bored and decided to stop recording.
Even the auto focus works with this build! (it wasn't working in Crop Mood).

This is absolutely great. The only problem is that 4K is not big enough for my project.
I need the larger resolutions that come with Crop Mood (5.2K or 4.8K) and I believe Danne's build doesn't offer those.


EDIT: I now get pink and black stripes instead of normal preview.
What is the "correct" resolution for 4K anyway?
There are the crop settings and there are the RAW resolution settings. Both are related to resolution and both can be adjusted separately.
Which one is the correct one that I should worry about?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on July 13, 2023, 01:13:16 PM
Ok, so now we know were to try and fix things. In sd_uhs.c code. Could be timing issues when patching or some registry routine bilal is applying. Maybe possible to fix looking at my code base and using parts in bilals code.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 13, 2023, 01:57:59 PM
I'm sorry, Danne, I spoke too soon.

I get crashes with your build as well in the higher resolutions. And no preview as well.
Maybe I bumped up the resolution way too high?
I don't understand the co-relation between RAW resolution and Crop resolution. They are both adjustable, but which one is the one that I should care about?

I still think that my SD card is crappy.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on July 13, 2023, 03:03:51 PM
Not your card. If it works with regular 1920x1080p your card is fine.
Preview works bad on higher resolutions. Better on bilals builds.
On a general basis it is good to know what to expect from each build and presets. Learn about preview capabilities etc. To be added. 100d is not the most stable camera to begin with.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 13, 2023, 03:13:13 PM
Quote from: Danne on July 13, 2023, 03:03:51 PM
100d is not the most stable camera to begin with.
Tell me about it! :D I learned this the hard way.
I am now selling my 100D, so if anybody needs this piece of junk, drop me a message. LOL!  :D :D :D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 13, 2023, 04:04:58 PM
@Wannabe

Try this build: magiclantern-crop_mood.2023Jul13.100D101_MoreDelay.zip (https://bitbucket.org/bilal_fakhouri/crop-mood-builds/downloads/magiclantern-crop_mood.2023Jul13.100D101_MoreDelay.zip)

I increased the delay with some minor tweaks then I did some tests on my 100D and it no longer crashes.
--- a/modules/crop_rec/crop_rec.c
+++ b/modules/crop_rec/crop_rec.c
@@ -5145,7 +5145,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)
     }

     /* 650D / 700D / EOSM/M2 / 100D preferences */
-    if (is_DIGIC_5)
+    if (is_DIGIC_5 && lv)
     {
         // all of our presets work in x5 mode because of preview, even none-cropped ones
         if (CROP_PRESET_MENU && !RECORDING && is_movie_mode())
@@ -5155,7 +5155,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)
             if (lv_dispsize == 1)
             {
                 gui_uilock(UILOCK_EVERYTHING);
-                msleep(700);
+                msleep(1100);
                 gui_uilock(UILOCK_NONE);
             }

@@ -5197,7 +5197,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)
         }

         /* while idle, check our preview resgisters, force the new values if not set yet */
-        if (!lv_dirty && !crop_rec_needs_lv_refresh() && CROP_PRESET_MENU && !RECORDING && lv_dispsize == 5 && PathDriveMode->zoom == 5 && lv)
+        if (!lv_dirty && !crop_rec_needs_lv_refresh() && CROP_PRESET_MENU && !RECORDING && lv_dispsize == 5 && PathDriveMode->zoom == 5)
         {
             if (Preview_Control && !Preview_Control_Basic) // presets with basic preview don't need it
             {
@@ -5207,7 +5207,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)

         // FIXME: for now, "More" hacks must be on in order to get wokring preview in 3x3 presets while recording
         // see notes in reg_override_3X3
-        if (CROP_PRESET_MENU == CROP_PRESET_3X3 && lv && raw_lv_is_enabled() && !is_more_hacks_selected())
+        if (CROP_PRESET_MENU == CROP_PRESET_3X3 && raw_lv_is_enabled() && !is_more_hacks_selected())
         {
             if (crop_preset_3x3_res_menu != 1) // exclude 1080p mode
             {
@@ -5241,7 +5241,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)
          * let's check picture quality on startup, also when the user change it to other than RAW         
          * let's inform the user to change pic quality back to RAW, and a camera restart would required
          * this extends recording times at high resolutions, also allows to record Full-Res LV @ 3 FPS */
-        if (lv && patch_active && CROP_PRESET_MENU && is_movie_mode())
+        if (patch_active && CROP_PRESET_MENU && is_movie_mode())
         {
             if (pic_quality != 0x4060000)
             {

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mineralof on July 13, 2023, 04:32:21 PM
Quote from: theBilalFakhouri on July 13, 2023, 04:04:58 PM
@Wannabe

Try this build: magiclantern-crop_mood.2023Jul13.100D101_MoreDelay.zip (https://bitbucket.org/bilal_fakhouri/crop-mood-builds/downloads/magiclantern-crop_mood.2023Jul13.100D101_MoreDelay.zip)


Dear Bilal, will this build run on canon 650? Seeing speed drop issue with sd_uhs module with all my eligible sd cards
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on July 13, 2023, 04:35:24 PM
I tested several cards with 650D. Nothing to report. The only fast card not working according to plan: Integral Ultima Pro 256GB. Impressive benchmark numbers on PC (160 MByte/s in write mode) but sucks in cam running higher oc modes.

Are you using recommended card types?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mineralof on July 13, 2023, 04:53:58 PM
Quote from: Walter Schulz on July 13, 2023, 04:35:24 PM
I tested several cards with 650D. Nothing to report. The only fast card not working according to plan: Integral Ultima Pro 256GB. Impressive benchmark numbers on PC (160 MByte/s in write mode) but sucks in cam running higher oc modes.

Are you using recommended card types?

(https://i.postimg.cc/zBF9BzdQ/IMG-6137.jpg)

Yes. Checked on all three recommended SD cards. Sandisk Extreme Pro. They are original and work great. unfortunately, in addition to the crop rec build with the overclocking module
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on July 13, 2023, 05:02:03 PM
In fact we are not sure about 200MB/s with 64 GB. Western Digital specs tell it should be able to run R200/W90. I can retest with 256 GB variety (R200/W140).
170 MByte/s should run fine.
Have you tried both access modes (SDR104 and SDR50)?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mineralof on July 13, 2023, 05:04:37 PM
Quote from: Walter Schulz on July 13, 2023, 05:02:03 PM
In fact we are not sure about 200MB/s with 64 GB. Western Digital specs tell it should be able to run R200/W90. I can retest with 256 GB variety (R200/W140).
170 MByte/s should run fine.
Have you tried both access modes (SDR104 and SDR50)?

I tried, the speed is about 20 mb / s
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on July 13, 2023, 05:18:01 PM
Quick benchmark run with an experimental sd_uhs.mo @280 MHz and my Sandisk Extreme Pro 200 MB/s (R200/W140):
(https://abload.de/img/bench24cae37.png)
Are your benchmark runs show different results? Means: fallback to 20 MByte/s? Try running sd_uhs.mo and bench.mo but no other modules loaded.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mineralof on July 13, 2023, 05:34:31 PM
Quote from: Walter Schulz on July 13, 2023, 05:18:01 PM

Are your benchmark runs show different results? Means: fallback to 20 MByte/s? Try running sd_uhs.mo and bench.mo but no other modules loaded.

Tried. In photo mode up to 90MB. In video mode, it drops to 20.
Sandisk extreme pro 170 mb.
(https://i.postimg.cc/nzRfxPyy/2.jpg)


on sd card Sandisk extreme pro200 mb does not give any overclocking


Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on July 13, 2023, 05:43:20 PM
Got it.
Will have to run some tests here.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mineralof on July 13, 2023, 05:44:40 PM
Quote from: Walter Schulz on July 13, 2023, 05:18:01 PM
Quick benchmark run with an experimental sd_uhs.mo @280 MHz and my Sandisk Extreme Pro 200 MB/s (R200/W140):
please tell me where to download experimental sd_uhs.mo?
is he stable?

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on July 13, 2023, 05:58:12 PM
Cannot share it. And unstable is an understatement...
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 13, 2023, 07:22:24 PM
Quote from: theBilalFakhouri on July 13, 2023, 04:04:58 PM
@Wannabe

Try this build: magiclantern-crop_mood.2023Jul13.100D101_MoreDelay.zip (https://bitbucket.org/bilal_fakhouri/crop-mood-builds/downloads/magiclantern-crop_mood.2023Jul13.100D101_MoreDelay.zip)

I increased the delay with some minor tweaks then I did some tests on my 100D and it no longer crashes.
--- a/modules/crop_rec/crop_rec.c
+++ b/modules/crop_rec/crop_rec.c
@@ -5145,7 +5145,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)
     }

     /* 650D / 700D / EOSM/M2 / 100D preferences */
-    if (is_DIGIC_5)
+    if (is_DIGIC_5 && lv)
     {
         // all of our presets work in x5 mode because of preview, even none-cropped ones
         if (CROP_PRESET_MENU && !RECORDING && is_movie_mode())
@@ -5155,7 +5155,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)
             if (lv_dispsize == 1)
             {
                 gui_uilock(UILOCK_EVERYTHING);
-                msleep(700);
+                msleep(1100);
                 gui_uilock(UILOCK_NONE);
             }

@@ -5197,7 +5197,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)
         }

         /* while idle, check our preview resgisters, force the new values if not set yet */
-        if (!lv_dirty && !crop_rec_needs_lv_refresh() && CROP_PRESET_MENU && !RECORDING && lv_dispsize == 5 && PathDriveMode->zoom == 5 && lv)
+        if (!lv_dirty && !crop_rec_needs_lv_refresh() && CROP_PRESET_MENU && !RECORDING && lv_dispsize == 5 && PathDriveMode->zoom == 5)
         {
             if (Preview_Control && !Preview_Control_Basic) // presets with basic preview don't need it
             {
@@ -5207,7 +5207,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)

         // FIXME: for now, "More" hacks must be on in order to get wokring preview in 3x3 presets while recording
         // see notes in reg_override_3X3
-        if (CROP_PRESET_MENU == CROP_PRESET_3X3 && lv && raw_lv_is_enabled() && !is_more_hacks_selected())
+        if (CROP_PRESET_MENU == CROP_PRESET_3X3 && raw_lv_is_enabled() && !is_more_hacks_selected())
         {
             if (crop_preset_3x3_res_menu != 1) // exclude 1080p mode
             {
@@ -5241,7 +5241,7 @@ static unsigned int crop_rec_polling_cbr(unsigned int unused)
          * let's check picture quality on startup, also when the user change it to other than RAW         
          * let's inform the user to change pic quality back to RAW, and a camera restart would required
          * this extends recording times at high resolutions, also allows to record Full-Res LV @ 3 FPS */
-        if (lv && patch_active && CROP_PRESET_MENU && is_movie_mode())
+        if (patch_active && CROP_PRESET_MENU && is_movie_mode())
         {
             if (pic_quality != 0x4060000)
             {




Hi Bilal, I installed your newest build and I am now able to record in 4.4K / 10 bit indefinitely with a green indicator (in a dark room).
I made a 15 minute long video before I got bored and manually stopped the recording.
If I point the lens towards a brighter object, the indicator turns orange, but almost never goes red.
I will do some tests in daylight in a moment.

Anything above 4.4K stops working after between 1 and 20 seconds of recording time, but this time around the camera doesn't crash, it doesn't show error screens, and it doesn't shut itself down.
The recording simply stops, which I have seen happening in YouTube demos with other people's camera's too.

You are doing a fantastic job making 100D work with Crop Mood.

Is there any chance that the auto focus can be made to work in Crop Mood?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 17, 2023, 06:39:41 AM
@Wannabe

Cool, nice to hear that.

Continuous autofocus doesn't work when using crop mood presets, you can only trigger autofocus by a half-shutter press which work while not recording.
If you want to use autofocus while recording, small hacks must be turned off from RAW video submenu, but this way you will sacrifice some write speed.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 19, 2023, 02:05:56 PM
Hi, I turned Small Hacks off and this did not cause any serious write speed issues, but the auto focus is still not working.
Probably I am missing to turn on (or to turn off) a setting.
Here are my current settings:


(https://i.postimg.cc/GpH8ndLx/IMG20230719145116.jpg)
(https://i.postimg.cc/9fK4WKz5/IMG20230719145217.jpg)
(https://i.postimg.cc/K8c3QtCV/IMG20230719145313.jpg)
(https://i.postimg.cc/2SHbtVD5/IMG20230719145345.jpg)

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on July 19, 2023, 02:08:20 PM
Turn off movie servo af.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 19, 2023, 04:06:22 PM
Quote from: Danne on July 19, 2023, 02:08:20 PM
Turn off movie servo af.


I disabled Movie Servo AF.
Still, the auto focus is not working.




(https://i.postimg.cc/C53T5CkK/IMG20230719170232.jpg)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on July 19, 2023, 05:30:16 PM
It could be conflicting with some other function with halfshutter button.
Is af working with my build?
https://www.magiclantern.fm/forum/index.php?topic=25781.0
In small hacks it still works with af-on setting under raw video menu.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 19, 2023, 06:11:45 PM
Quote from: Danne on July 19, 2023, 05:30:16 PM
It could be conflicting with some other function with halfshutter button.
Is af working with my build?
https://www.magiclantern.fm/forum/index.php?topic=25781.0
In small hacks it still works with af-on setting under raw video menu.

Yes, auto focus works with your build. If I remember correctly, it still works even if small hacks is turned on.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 19, 2023, 11:28:57 PM
@Wannabe

AF works fine here on my 100D, I explained how it works with crop mood build in this reply (https://www.magiclantern.fm/forum/index.php?topic=26851.msg244430#msg244430).
If it still doesn't work for you, show us what are you doing your ML settings (record a video).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 20, 2023, 10:35:43 AM
Hi guys, here is a video that I made. The auto focus in Crop Mood is not working.

I am running the latest Crop Mood build for 100D.
I am using a Canon 18-55mm IS STM kit lens, with the auto focus switch turned "on".


Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on July 20, 2023, 11:30:29 AM
You need to push halfshutter to autofocus. Not gonna work by itself  :P.
I think you shoulld turn off kill canon gui as well on more general note.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 20, 2023, 11:33:23 AM
Already answered three days ago (https://www.magiclantern.fm/forum/index.php?topic=26851.msg244430#msg244430):

Quote from: theBilalFakhouri on July 17, 2023, 06:39:41 AM
Continuous autofocus doesn't work when using crop mood presets, you can only trigger autofocus by a half-shutter press ...
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 20, 2023, 11:38:51 AM
Also, I made some changes which affect AF accuracy, these changes are included in latest 100D build:

from Advanced menu in crop mood submenu, there is a new option called Brighten LV method:

-AeWb: Brighten LV using a regiser related to AeWb task. Stable, inaccurate AF.
-EVF: Brighten LV using regisers related to EVF task. Less stable (might produce corrupted frames), accurate AF.

This only applies when using crop mood and lower bit-depths (less than 14-bit) in lossless compression.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 20, 2023, 12:15:45 PM
Quote from: Danne on July 20, 2023, 11:30:29 AM
You need to push halfshutter to autofocus. Not gonna work by itself  :P.
This is very strange, because with your build the auto focus on my 100D works entirely by itself (without half-pressing the shutter button).
With your build changing the scenes automatically focuses on the new objects. The user does not have to do anything. It is all done autoatically by the camera (which I believe is the idea behind using auto focus).

With the Crop Mood build half-pressing the shutter button makes the camera search for focus for several long seconds. It never works from the first try and it barely manages to nail the focus after 3-4 failed attempts.
If you move the camera away and try to focus on another object, the camera does not autofocus by itself, but it waits for you to to half-press the shutter button once again, which results in 3-4 more seconds of ruined footage.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Wannabe on July 20, 2023, 12:17:05 PM
Quote from: theBilalFakhouri on July 20, 2023, 11:38:51 AM
Also, I made some changes which affect AF accuracy, these changes are included in latest 100D build:

from Advanced menu in crop mood submenu, there is a new option called Brighten LV method:

-AeWb: Brighten LV using a regiser related to AeWb task. Stable, inaccurate AF.
-EVF: Brighten LV using regisers related to EVF task. Less stable (might produce corrupted frames), accurate AF.

This only applies when using crop mood and lower bit-depths (less than 14-bit) in lossless compression.

Thanks. I will try messing with these settings.
Will report back.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on July 20, 2023, 12:34:41 PM
Quote from: Wannabe on July 20, 2023, 12:15:45 PM
This is very strange, because with your build the auto focus on my 100D works entirely by itself (without half-pressing the shutter button).
With your build changing the scenes automatically focuses on the new objects. The user does not have to do anything. It is all done autoatically by the camera (which I believe is the idea behind using auto focus).
I did not mess with my 100dbuild for quite some time so maybe something is working better by luck. I know with eos m where I extensively tested most presets it needed some tweaks to work better.
It is still af even if you need to use halfshutter ;). Problem with af servo while recording it's very unreliable.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 20, 2023, 01:39:21 PM
@Wannabe

You can still use continuous autofocus with crop mood build with native video modes such as 1080p and 720p from Canon menu (turn crop mood off from movie tab).
Make sure Servo AF is turned on from Canon menu and small hacks turned off.




There were some important reasons why I made crop mood presets be applied/patched in x5 mode (where continuous autofocus doesn't work):

1- Patching presets with real-time correct preview in 1080p mode will result in an overhead which lead to corrtuped frames (pretty sure no one want to deal with this).
2- 1080p mode consume more hardware resources (more CPU usage and RAM bandwidth) compared to x5 mode, this make x5 mode perform a notiacble higher write speed --> longer recording time.

For me, continuous autofocus is very important feature to me, I would love to see it work with crop mood presets, but I think we probably reached some hardware limitations here,
if someone can optimize the LiveView for full real-time preview and continuous autofocus, feel free to do it (assuming we can optimize it through software), for me it doesn't worth the effort, AF performance is bad on these cams anyway.

Now, I started to prefer the 70D over my 700D / 100D because of DPAF :D . . and yes, I finally have a 70D (https://discord.com/channels/671072748985909258/844581352082898975/1130240901374021712), thanks to @Trapper from Discord! (who donated the amount so I could buy a 70D).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: andy kh on July 20, 2023, 11:09:01 PM
Quote from: theBilalFakhouri on July 20, 2023, 01:39:21 PMfinally have a 70D[/url], thanks to @Trapper from Discord! (who donated the amount so I could buy a 70D).
congrats bilal
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 23, 2023, 09:31:24 PM
Thanks @andy kh!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 23, 2023, 09:37:37 PM
Some people are being confused about the name of the build and crop_rec module, is it crop mood or crop mode?
I added an answer in the first post (https://www.magiclantern.fm/forum/index.php?topic=26851.0#post_moodormode), hopefully it's clearer now.

Quote from: theBilalFakhouri on April 01, 2023, 06:37:50 PM
Speaking of naming - mood or mode?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: vastunghia on July 24, 2023, 09:41:18 AM
Quote from: theBilalFakhouri on July 20, 2023, 01:39:21 PM
Now, I started to prefer the 70D over my 700D / 100D because of DPAF :D . . and yes, I finally have a 70D (https://discord.com/channels/671072748985909258/844581352082898975/1130240901374021712), thanks to @Trapper from Discord! (who donated the amount so I could buy a 70D).

Lol, you really find all cams to be sexier than the 5D3, don't you? ;D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on July 24, 2023, 11:29:44 AM
Wait what happens after implementing ML overclocking for UHS-II cams! <g>
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 24, 2023, 11:58:48 AM
Quote from: vastunghia on July 24, 2023, 09:41:18 AM
Lol, you really find all cams to be sexier than the 5D3, don't you? ;D

Hahaha, two main downsides for me in 5D3 are:

1. body weight and size (especially when equipped with 24-105 F/4 lens)
2. no flip screen

These two raesons have more impact when I shoot handheld, otherwise the quality is great and I love it.
Just yesterday I picked up my 700D with 18-55 kit lens (to shoot a short family event) instead of 5D3 (just videos, without photos), because of these very two reasons.

Good thing that working on 70D means the 5D3 will be benefited too (both are DIGIC 5+ and e.g. preview stuff is similar among the two models).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: vastunghia on July 24, 2023, 03:41:06 PM
Quote from: theBilalFakhouri on July 24, 2023, 11:58:48 AM
Hahaha, two main downsides for me in 5D3 are:

Agree on both. If Raw recording was not a thing, I would love my 70D way more than my 5D3. Heck, I would not even own a 5D3.

However, Raw recording is a thing (thank you ML!), and 5D3 has a data bandwidth which is *huge* compared to all the other ML cams.

So, even if someone obtained the way to have (say) real-time DPAF with 1:1 crop mode Raw recording on the 70D, that would most likely require a huge crop factor / low res to obtain continuous rec, and maybe only @10 bit. Or am I missing something?

Quote from: theBilalFakhouri on July 24, 2023, 11:58:48 AM
Good thing that working on 70D means the 5D3 will be benefited too (both are DIGIC 5+ and e.g. preview stuff is similar among the two models).

Thanks for letting me see the silver lining ;D

Keep up with your great work man!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Skinny on July 24, 2023, 09:09:57 PM
Quote from: theBilalFakhouri on July 24, 2023, 11:58:48 AM
Hahaha, two main downsides for me in 5D3 are:

1. body weight and size (especially when equipped with 24-105 F/4 lens)
2. no flip screen
3. You can not install vintage lenses with short flange distance or a speedbooster :) Of all ML-enabled cameras only EOS M can do that, and I think it is a huge advantage of EOS M, you can experiment with all kinds of crazy lenses, I have some lenses laying around which I would love to try in RAW recording, but... Only EOS M users can do it.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on July 24, 2023, 10:24:16 PM
Shame the sensor, ergonomics and AF sucks.  But you're right about the mount being versatile.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: amitkattal on July 27, 2023, 04:06:17 PM
Anyone tried full res 3fps mode on EOS M .everytime i try, it doesnt work. Recording stops immediately no matter i chose 10 bit or 14 bit. The sd card is powerful enough. I wonder if something else is causing it
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: BackPackJack on July 28, 2023, 04:18:55 PM
Hi I'm very much a magic lantern noob and I've recently purchased a 700d with the prospect of using crop mood. I'd first like to say a huge thank you to Bilal for his hard work in creating this incredible build.

How do I set up my 700d using crop mood? I'm semi-aware of what's required to get magic lantern up and running on the 700d but there's no reference I've found for this builds firmware requirements.

I'd greatly appreciate if someone could share the steps required to get this up and running and thank you in advance :D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on July 28, 2023, 06:58:32 PM
You need firmware 1.1.5
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 28, 2023, 07:50:28 PM
Quote from: amitkattal on July 27, 2023, 04:06:17 PM
Anyone tried full res 3fps mode on EOS M .everytime i try, it doesnt work. Recording stops immediately no matter i chose 10 bit or 14 bit. The sd card is powerful enough. I wonder if something else is causing it

Yes, it works on 700D and 100D, the answer to you question is already there in first post and my build walkthrough video . . anyway:
You need to turn off sound recording, set small hacks to More, 240 MHz and make sure picture quality is set to RAW from Canon menu (restart camera after setting it to RAW).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 28, 2023, 07:58:10 PM
@BackPackJack

Thank you! best luck with crop mood build and your 700D.
ML installation process is covered in many topics and videos on youtube, you find the steps here  (https://builds.magiclantern.fm/700D-115.html)under "Installation" (if you want to use crop mood build, you can find download link in first post (https://www.magiclantern.fm/forum/index.php?topic=26851.0#post_downloads)).

You can follow my build walkthrough video from first post which show how to load modules beside how I usually configure ML settings, there are many other tutorial videos on youtube which can help you too.

Feel free to ask more questions.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mineralof on July 29, 2023, 12:31:36 PM
Quote from: Walter Schulz on July 13, 2023, 05:43:20 PM
Got it.
Will have to run some tests here.

please let me know if there is any progress?

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: essbe on July 31, 2023, 11:00:55 PM
Really love the crop mood and the work everyone in the magic lantern team has done to make it possible, thanks to everyone involved for that! I have used it alot and have started wondering if another mode could be added:

The downsides of the eos m as a cinema camera are well known: Aliasing in 3x3-mode and rolling shutter in 1x3-modes. I have also found 3x3 the noisiest, 1x1 second most, and 1x3 the cleanest when using high iso:s, but that is probably well known as well. Anyhow I mostly use the 1x1 2.5k crop because of reasonable rolling shutter and little aliasing, the crop is acceptable when considering the colors and overall image quality from the magic lantern eos m. For me, the rolling shutter of about 24ms still requires a stabilised lens for handheld use, to look good (every mode works well on a tripod, of course). The 2.8k mode has as much rolling shutter as the 4.4k 1x3 mode (about 29ms according to ml menu), so the 4.4k seems a better overall choice because of less noise and less crop. Now I have started to wonder if there has been any experiments with smaller crops using the 1x3 mode? Would it be possible to make a 4k or smaller crop of 1x3 to get the rolling shutter closer to 20ms? A super-16mm crop (3x) in 1x3 mode could also be interesting, if possible, with even less rolling shutter. I guess the picture would be softer, and there would be some aliasing compared to the 1:1, but maybe it would be a good compromise considering the problems of the different modes, or are there other downsides?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on July 31, 2023, 11:41:55 PM
Thank you @essbe, glad you liked it :)

Unfortunately, rolling shutter can't be improved even if we lowered the resolution, we already reached the limit (more likely it's a hardware limit).

Timer A (related to framerate) is responsible for rolling shutter too, lowering it will decrease rolling shutter and increase sensor scan speed (i.e increase FPS), the minmum Timer A value on EOS M we can use is 0x1FF (512) . .
lowering it further will result in black image, compared to 700D, the minimum limit is 0x1B9 (442) before th image break which mean a slightly lower rolling shutter on 700D when same preset is used (1x3 presets).

I am not quite sure if Timer A limit can be exceed when using lower resolutions, AFAIK EOS M and 700D share the same sensor (or does it?), why it's faster on 700D?
Could it be a software configuration (some registers)? I am not sure, comparing EOS M vs 700D in this case might lead us to something . .
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: essbe on August 01, 2023, 01:05:39 AM
Ok, that's too bad, but thanks for the quick reply! What's the lowest rolling shutter on the 700d in 1x3 mode?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: metamerism on August 04, 2023, 02:26:06 AM
Hi, are there focus pixel maps for the 100D?

I am noticing some pink focus pixel dots in the 1x1 modes (2.8K, 1440p) and 1x3 mode (1600x2040). I am using the latest MLVApp.

The dots are more obvious in the MLVApp preview, and fainter but still noticeable in the exported video.

This is a 1440p sample taken by me https://drive.google.com/drive/folders/1MubiJmQ0FLGYVI1zNgGDOxqWmxPiGuVk?usp=sharing

This is an example from someone else:





Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Niche on August 06, 2023, 02:27:39 AM
Hey! Great project!

I've been having this issue with my 100D where vertical lines will appear during shooting (shown throughout the attached image, but particularly the top right corner). I had this issue with crop_rec too, and it only seems to happen when using the cropped modules. Any idea what this is or how to fix it? It happens in any cropped mode.

(https://i.postimg.cc/LsC5djGh/Untitled.png) (https://postimg.cc/949CZwmj)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Teamsleepkid on August 13, 2023, 04:13:05 AM
Rolling shutter.. somebody was talking about it a few messages back..in my opinion that's really the last hurdle for magic lantern. If we can reduce the rolling shutter in 5k frtp. That's the grail.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on August 13, 2023, 03:38:49 PM
What settings cause the 1080p Raw to have the LiveView Frozen? I can't seem to figure it out. Also I notice with 1080p Raw when I set it to 10-Bit, the LiveView still says 14-Bit on the bottom in green.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: michael08 on August 14, 2023, 12:55:15 PM
hi, when I shoot through the mir 11 2/12.5 lens there is a vignetting in the upper right corner, I understand that the crop sensor is not exactly in the middle relative to the real sensor? how can I solve this problem? mode 2.8k 2880x1226
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Ernani on August 14, 2023, 09:37:58 PM
Hi Bilal. I always enable Kill Global Draw get more reliability and continuous recording. I noticed that the different modes react differently to KGD, for example: 3x1 modes display an accurate preview on all aspect ratios with and without KGD, whereas 3x3 will ALWAYS display a full sensor preview (3:2) with KGD, no matter what aspect is picked, turning the preview unusable when Kill Global Draw is enabled.

I observed that the KGD preview will work great whenever the aspect ratio is chosen via the Crop Mood menu, but will not when the aspect must be selected from the RAW Video menu (which leads me to the conclusion that RAW Video simply overlays black bars to the preview in order to show the correct aspect, a task that is killed by KGD).

I know this is not a great deal to be bothered by, but since the HFR 3x3 modes are displayed correctly with and without KGD enabled, would it be a simple task to do the same for the regular 1080p previews?

If this is not as simple as it seems, please just ignore my whining.

And thanks a lot for all you did!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: RhythmicEye on August 15, 2023, 04:26:44 AM
Quote from: essbe on July 31, 2023, 11:00:55 PM
Really love the crop mood and the work everyone in the magic lantern team has done to make it possible, thanks to everyone involved for that! I have used it alot and have started wondering if another mode could be added:

Anyhow I mostly use the 1x1 2.5k crop because of reasonable rolling shutter and little aliasing, the crop is acceptable when considering the colors and overall image quality from the magic lantern eos m. For me, the rolling shutter of about 24ms still requires a stabilised lens for handheld use, to look good (every mode works well on a tripod, of course). The 2.8k mode has as much rolling shutter as the 4.4k 1x3 mode (about 29ms according to ml menu), so the 4.4k seems a better overall choice because of less noise and less crop. Now I have started to wonder if there has been any experiments with smaller crops using the 1x3 mode? Would it be possible to make a 4k or smaller crop of 1x3 to get the rolling shutter closer to 20ms? A super-16mm crop (3x) in 1x3 mode could also be interesting, if possible, with even less rolling shutter. I guess the picture would be softer, and there would be some aliasing compared to the 1:1, but maybe it would be a good compromise considering the problems of the different modes, or are there other downsides?

100% agree, I can't thank the ML devs enough for all their excellent work. It's truly remarkable what is now possible with Crop Mood...even with the limitations etc

Here's a link to an excellent article on alternate ways for dealing with and minimising rolling shutter. I know it doesn't answer your questions but may be helpful for others new to the issue of rolling shutter

https://shotkit.com/rolling-shutter/
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: LucasFlores on August 17, 2023, 02:48:37 AM
Hi everyone. I need your help. I have a EOS Rebel T3i / EOS 600D. Can I use the Crop mood built? If not, can you suggest me a good alternative? Thanks so much for your help.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on August 17, 2023, 08:19:10 AM
There is no Crop Mood for any Digic 4 design.

What do you mean by "good alternative"? Cam, build? For what purpose? Bugdet (in case of cam)? Please respond in https://www.magiclantern.fm/forum/index.php?board=4.0
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on August 19, 2023, 12:21:04 AM
Anyone know why the LiveView is frozen with 1080p 3x3? Or does it not have real-time preview in this mode? I have been messing with settings for a week and can't seem to get it to work. I am trying to record in raw in the lowest quality to get the most time for continuous recording and smallest file sizes. I assumed this would be the best mode for that, but not sure.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on August 19, 2023, 06:28:33 AM
I think you need to move the rectangle a little to release preview. A hard to solve bug.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on August 19, 2023, 02:18:49 PM
Thanks Danne. It works. I did try that before but the screen just got messed up so I stopped messing with it, but I see how to do it now.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on August 19, 2023, 03:45:52 PM
New Crop mood builds are out:
Aug.19.2023

-HDMI output resolution:

New module was added "hdmi_out.mo" which let you select HDMI output resolution which are officially supported by camera, now you can choose among these outputs for HDMI:

-480p
-1080i 50Hz
-1080i 60Hz


(https://i.ibb.co/98KP14m/HDMI-output-1.png)  (https://i.ibb.co/F31Xkn0/HDMI-output-2.png)


-SD safe mode warning:
If SD overclocking wasn't stable for your SD card with the selected OC settings, the camera would trigger a "Safe mode" which make write speed drop to 21 MB/s (48 MHz),
In previous builds you will need to run benchmarks to check if safe mode was triggered, now "SD Overclock" will display that when highlighting it in ML menu:

(https://i.ibb.co/WzTgCTV/Safe-mode.png)

Also it will suggest to use lower frequency or different access mode, it's basically a time saver if you ever encounter this kind of case.


-Brighten LV method option:
In 9 May build I made a change which affected RAW recording stabilty at high resolutions in some presets (it prdouced corrupted frames, made recording stops early) especially when HDMI is connected, some context:

We acheive lower bit-depths when using lossless compression by applying negative gain to RAW data to reduce bit-depth, as result preview will become darker than it should be, there are two ways to adjust brightness and make it correct again:

-Brighten LV using a regiser related to AeWb task (18 April and previous builds use this by default):
This give stable RAW recording, but autofocus will be inaccurate (it will hunt) when using crop mood preset and normal preview with lossless compression at lower bit-depths.

-Brighten LV using regisers related to EVF task (9 May build use this by default):
This affect RAW recording stability at high resolutions, but it gives accurate autofocus when using crop mood preset and normal preview with lossless compression at lower bit-depths.

-Now Aug 19 build uses AeWb method by default to ensure stability (you have the option to change it if you want), and it's highly recommended to keep it AeWb, and just use x10 mode for focusing.

(https://i.ibb.co/JrLCZh4/Crop-mood-debug.png)  (https://i.ibb.co/wZH7YWK/AeWb.png)


Changes list:

Crop mood builds - Downloads (https://www.magiclantern.fm/forum/index.php?topic=26851.msg242974#post_online)




Sorry for the delay, I will try to anwer all asked questions as soon as possible.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: chrisfree123 on August 20, 2023, 04:43:58 AM
My crop mood installed. It records video.
But for some reason I can't turn on Crop Mood. The option is 0? It won't let me turn it on?

Am I doing something wrong?

(https://i.ibb.co/Fmww0Z6/7m3k3-Sp-d.jpg)

(Photo was re-uploaded by mod)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Corallaro on August 20, 2023, 01:46:12 PM
Great work!!!!
But, a fix for freeze preview with AF in 1080p mode?
Ciao
Giovanni
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on August 20, 2023, 03:25:01 PM
Quote from: essbe on August 01, 2023, 01:05:39 AM
Ok, that's too bad, but thanks for the quick reply! What's the lowest rolling shutter on the 700d in 1x3 mode?

I will make a new tests soon and will post the results on the forum,
I think 700D will have around probably ~15% less rolling shutter in some 1x3 presets (but not quite sure yet!).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on August 20, 2023, 03:34:34 PM
Quote from: metamerism on August 04, 2023, 02:26:06 AM
Hi, are there focus pixel maps for the 100D?

There are not focus pixel maps yet for crop mood presets (there are old focus pixels maps, iirc I made some tests and they don't cover all focus pixels in crop mood presets, I will double check again),

In this case, focus pixel maps need to be created from scratch for 100D, I mentioned some info about this subject in eariler replies,
Sorry I don't have time to create them, but anyone can create them and there is a guide on the forum shows how to do it.

I have an intention to create them, but I don't know when I am going to actually do it, please don't rely on me,
However, I can help if someone has the inspiration and want to create them, please let me know!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on August 20, 2023, 03:43:59 PM
Quote from: Niche on August 06, 2023, 02:27:39 AM
I've been having this issue with my 100D where vertical lines will appear during shooting (shown throughout the attached image, but particularly the top right corner). I had this issue with crop_rec too, and it only seems to happen when using the cropped modules. Any idea what this is or how to fix it? It happens in any cropped mode.

(https://i.postimg.cc/LsC5djGh/Untitled.png) (https://postimg.cc/949CZwmj)

Hi, thanks for reporting!

Related (https://www.magiclantern.fm/forum/index.php?topic=26511.msg244022#msg244022) issue (https://www.magiclantern.fm/forum/index.php?topic=26511.msg244050#msg244050), I need to take a look into your 100D registers:

-Download this adtg_gui.mo (https://drive.google.com/file/d/1QfBQkORaKQ-cT9-Y4QOm-mpsHhecFOmm/view?usp=sharing), put it in ML/modules folder in SD card
-Unload all modules, and load only adtg_gui.mo, restart camera
-Set video mode to 1080p24 to gain extra speed

-Follow the following video, you can see in the video I am entering Canon menu and toggling between x1/x5/x10 modes, you should do that too to let "ADTG registers" bring the registers into it:

https://www.youtube.com/watch?v=Q-Tdu9YZ4fc

But please:
-Keep "Show" set to "Everything" instead of "Modified from now on"
-Keep "ENGIO Registers" turned OFF (don't turn it on)

-After you finish, you will find "adtg.log" file in ML/LOGS folder in SD card, upload it somewhere and share it.

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on August 20, 2023, 03:55:48 PM
Quote from: Teamsleepkid on August 13, 2023, 04:13:05 AM
Rolling shutter.. somebody was talking about it a few messages back..in my opinion that's really the last hurdle for magic lantern. If we can reduce the rolling shutter in 5k frtp. That's the grail.

Rolling shutter is related to sensor speed, more likely we hit a hardware limitation (unless someone prove me wrong), so in this case ML can't do anything to improve rolling shutter.




Quote from: Mythic Cinema on August 13, 2023, 03:38:49 PM
What settings cause the 1080p Raw to have the LiveView Frozen? I can't seem to figure it out.

You can either set focus box slightly below center to make LiveView work in 1080p 3x3 mode (as shown in build walkthrough video), or use manual focus or set small hacks to More.

Quote from: Mythic Cinema on August 13, 2023, 03:38:49 PM
Also I notice with 1080p Raw when I set it to 10-Bit, the LiveView still says 14-Bit on the bottom in green.

Use latest crop mood build then report back please!




Quote from: michael08 on August 14, 2023, 12:55:15 PM
hi, when I shoot through the mir 11 2/12.5 lens there is a vignetting in the upper right corner, I understand that the crop sensor is not exactly in the middle relative to the real sensor? how can I solve this problem? mode 2.8k 2880x1226

Unfortunately, we can't center cropped presets exactly to the center of the sensor, it will be always shifted slightly (to top or bottom and to left or right),
some presets will have more accurate centering than others (depending on resolution).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on August 20, 2023, 08:32:42 PM
Quote from: theBilalFakhouri on August 20, 2023, 03:55:48 PM
Use latest crop mood build then report back please!

The bit-depth is displayed properly now with latest, but it might have been my fault before as I didn't realize there were two settings for the bit-depth. I notice when you change the bit-depth it changes the other one to match. Maybe it wasn't doing that before or not displaying it properly. Either way it is fine now. Thank you.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Grognard on August 21, 2023, 06:27:04 PM
We all have experimented some raw shootings which looked quite good on the camera screen but actualy were too darkand too noizy.
That's because the exposure in liveview is not accurate. I know that we have to focus on the Histogram and try to expose to the right.
But if it is quite simple for a landscape to adjuste the highlights on the sky it makes no sens on an inside scene without hightlights or in a low key scene.

That's why false colors are useful to expose correctly our scene especially with skin tones.
The problem is that falsecolors are accurate in greyscale liveview  but not in realtime preview!
I did some tests and try to match liveview and greyscale by modified picture style and ML digital ISO.


By using Cinestyle picture style with contrast - 1 and ML digital ISO gain + 1.0EV in 12 bits (by using +1 it becomes in fact a little bit darker) I achieve something very similar.


                               
False color in realtime preview:                                                                  

(https://i.postimg.cc/pVSfprX1/falsecolor.png) (https://postimg.cc/qg8hFkK8)

False color in greyscale preview:


(https://i.postimg.cc/7hj0csWy/falsecolorgreyscale.png) (https://postimg.cc/T5qK59xk)

And it also match better whith raw datas

Realtime preview: 

(https://i.postimg.cc/Hnrb6D32/Liveview-EOS-M.png) (https://postimg.cc/jnrWj1pw)

MLV APP :                                                                                                                                                                                                     

(https://i.postimg.cc/ZRVLfLmT/test-liveview.png) (https://postimg.cc/JDHJ0Ztg)

MLV APP -1.0 exposure:

(https://i.postimg.cc/8ccmxrkL/test-liveview2.png) (https://postimg.cc/H8GMynyL)

ADOBE CAMERA RAW DNG:

(https://i.postimg.cc/CZXB35J4/testliveview-camera-raw.png) (https://postimg.cc/CZXB35J4)


I cheked in photoshop with a spot exposure and I obtain on the TRex skin 52% of grey level which fits with falsecolors middle grey (between 45 and 55 percent exposure).

(https://i.postimg.cc/ZnrjjGJX/Photoshop-vt-YJb-PDeg7.png) (https://postimg.cc/rRwSwY09)

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on August 21, 2023, 09:34:35 PM
Quote from: Ernani on August 14, 2023, 09:37:58 PM
I always enable Kill Global Draw get more reliability and continuous recording. I noticed that the different modes react differently to KGD, for example: 3x1 modes display an accurate preview on all aspect ratios with and without KGD, whereas 3x3 will ALWAYS display a full sensor preview (3:2) with KGD, no matter what aspect is picked, turning the preview unusable when Kill Global Draw is enabled.

.. would it be a simple task to do the same for the regular 1080p previews?

The native 1080p mode from Canon has actually 3:2 RAW resolution (like 1736x1160 on entry-level models and 1920x1280 on 5D3 .. etc) with 3:2 LiveView image,
EOS M act as 720p while idle in 1080p, that's why I created 1080p preset in crop mood, it's basically has the same behavior as native 1080p from Canon.

The way how KGD work in crop mood build is the same as in official builds too, RAW video crop marks will be disabled since it depends on ML global draw,
To solve this issue, we will need to make RAW video crop marks don't rely on global draw or find a way to draw it again after killing global draw, I never checked these stuff, will try to take a look soon.

In the native 1080p mode, we get various aspect ratios by cropping the RAW frame before saving it to SD card, but the sensor is actually always scanning 1736x1160 3:2 and LiveView will always show 3:2 AR,
in other crop mood presets/modes like in HFR and 1x3, we are cropping the RAW frame by actaully scaning a smaller sensor area, e.g.:

-HFR 16:9 will scan 1736x976 --> LiveView will show 1736x976 i.e 16:9 image
-HFR 2.35:1 will scan 1736x738 --> LiveView will show 1736x738 i.e 2.35:1 image
-etc . .

If you choose HFR 16:9 mode (from crop mood), and set aspect ratio from RAW video to 2.35:1 (with KGD) then hit recording button --> now you will see 16:9 image in LiveView, but you will actually be recording 2.35:1.
(basically the same case as 1080p preset).




Current workaround: you mostly don't need to use KGD for 1080p mode since 1080p mode is lite and doesn't require high write speed.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on August 21, 2023, 09:46:29 PM
Quote from: chrisfree123 on August 20, 2023, 04:43:58 AM
My crop mood installed. It records video.
But for some reason I can't turn on Crop Mood. The option is 0? It won't let me turn it on?

Am I doing something wrong?

Format SD card in PC, re-install crop mood build then report back please.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on August 21, 2023, 09:48:53 PM
Quote from: Corallaro on August 20, 2023, 01:46:12 PM
But, a fix for freeze preview with AF in 1080p mode?

Set focus box slightly below center to make LiveView work in 1080p 3x3 mode (as shown in build walkthrough video).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: theBilalFakhouri on August 21, 2023, 10:05:15 PM
Quote from: Grognard on August 21, 2023, 06:27:04 PM
That's because the exposure in liveview is not accurate. I know that we have to focus on the Histogram and try to expose to the right.
..
The problem is that falsecolors are accurate in greyscale liveview  but not in realtime preview!

You should get the same results in any ML build or in native Canon video modes in crop mood build (by turning off crop mood module), that's how Canon designed its LiveView,
because Canon real-time preview doesn't represet how actual RAW data look like, it's lossy and it does throw some of the RAW image info (e.g. it shows less dynamic range . .)

ML does already provide many exposure tools which help you to expose correctly or to the right (I never rely on Canon real-time preview for exposing).
ML falsecolor relies on whatever preview is active either Framing or Real-Time.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on August 22, 2023, 01:52:15 AM
I have a feature recommendation/suggestion that would be really cool. An "Aspect Ratio" option for DCI 1.90:1? Could also make a DCI Mode, like the 1x3 UHD one, since they go hand in hand. DCI is the requirement to have a film displayed in cinemas/theaters with a 4K projector because it's native resolution is 4096x2160 (DCI), instead of 3840x2160 (UHD). Cinema cameras have the DCI option like the recent firmware update for Sony FX3. There are also 4K UHD and 4K DCI Blu-Rays I think.

https://s3-eu-west-1.amazonaws.com/hac-assets/4k+vs+uhd/4K-vs-UHD.jpg
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: metamerism on August 22, 2023, 07:39:19 AM
Quote from: theBilalFakhouri on August 20, 2023, 03:34:34 PM
In this case, focus pixel maps need to be created from scratch for 100D, I mentioned some info about this subject in eariler replies,
Sorry I don't have time to create them, but anyone can create them and there is a guide on the forum shows how to do it.

Can you post the link for the earlier replies regarding focus pixel maps on the 100D, as well as the guide on the forum? I am interested in creating the focus pixel maps.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: bobolee on August 22, 2023, 08:34:56 AM
One stop brighter than the normal exposure on the display screen is the proper brightness of the real raw video.Enable histogram will take  more CPU usage,generate more heat,drain the battery faster,use spot meter instead.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Grognard on August 22, 2023, 10:59:39 AM
Quote from: theBilalFakhouri on August 21, 2023, 10:05:15 PM
You should get the same results in any ML build or in native Canon video modes in crop mood build (by turning off crop mood module), that's how Canon designed its LiveView,
because Canon real-time preview doesn't represet how actual RAW data look like, it's lossy and it does throw some of the RAW image info

Yes is not related with the latest crop mood but the ML iso negative gain in image fine tuning has changed. I was not able to achieve a darker image on previous version.
It shoul be related with what you have changed with aewb.

I agree that real-time preview doesn't represet exactly how actual RAW data look like (e.g. DR). But with other cams which shoot raw, liveview looks the same that raw data, maybe not with all dynamic range but with the correct average exposure.
The probleme here is that the liveview is a little bit to bright compare with raw data.
By additing negative gain in liveview, the exposure in liveview is more close to what raw data really look like.


Quote from: theBilalFakhouri on August 21, 2023, 10:05:15 PM
ML falsecolor relies on whatever preview is active either Framing or Real-Time.

That's why I try to reach the same level of brightness and constrast on realtime than framing. And with negative iso gain that I can add now in liveview it's really close.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on August 22, 2023, 05:06:08 PM
Does the LiveView work with the 1x1 and 1x3 modes? I couldn't get mine to work. Maybe I have some settings on that break it but I only really use fps override 24.0, small hacks, SD overclock, and full shutter range. I couldn't change my shutter angle either on some and everytime i hit MENU button and then go back to ML menu the shutter angle is different.

The 3x3 works good with everything for me though, I just have to move the box to get liveview working. But moving the box didnt work with other modes where the liveview is frozen. Sometimes it doesn't play the beeping sound when pushing on the arrows to move it either.

Edit: Ok The 2.5k Liveview works, but 4.4k, 4.8k, and 5.2k + some others do not. I must be doing something wrong?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: raul791 on August 25, 2023, 01:41:52 PM
Hello all,

in case of SD cards - don't buy SanDisk Extreme Pro 64GB (200MB/s version). I did that mistake and had problems with continuous recording (4.8K 12bit was max and even that it was not stable at all).

It is 100% original (bought from big retailer), the speeds was about ~65mb/s write at first.

Did a low format immidiately and it was better - about ~79mb/s write speed (SD104, 240MH OC), but still have problems (early stop recording, a lot of orange/red indicators etc.).

Later I discovered that 64GB and 128GB versions have W90 max. However, the 256GB and more have W140 max, so I bought the 256GB version (original from the same retailer).

Did low format and first test - ~95mb/s write speed with the same settings! Started recording first time after testing and it is great - on the same settings (4.8K 12bit) almost all time green, even on higher exposure, much more stable, stopped (red indicator) only after super-overexposure (looking at bright window in sunny day from room inside).

If you want to buy SanDisk Extreme Pro 200MB/s version, go for 256GB or more, don't even bother with 64GB/128GB version if you want to have more stable recording.

I'm using Canon 700D body, Canon 18-55mm f/3.5-5.6 IS STM kit lens with latest Crop Mood from August (shutter version).

Hope that helps!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: manifestor on August 27, 2023, 02:26:18 AM
Hi folks, 1st post. First I wanted to thank everybody working on ML and Bilal for Crop Mood. I bought an EOS M two weeks ago (after owning an M6 for 5 years) just because of ML, after stumbling over it on youtube two weeks prior, and I am enjoying it very much, in fact I am eager to learn videography because of you.

A (maybe?) bug report: when setting the INFO button to false color, sometimes I get stuck with Canons GUI (I can trigger it with switching to photo mode and back to video mode). When I get stuck with Canons GUI in video mode, I cannot remove the GUI by pressing the INFO button, because it is still linked to false color. But pressing the INFO button triggers false color nonetheless although nothing happens, because if I trigger false color and go to the customize buttons settings and turn it off (to be able to get out of Canons GUI by pressing the INFO button again - which will work then), false color gets activated. I have to set the INFO button again to false color, to be able to deactivate it again.

Somewhere here I also read that autofocus during video can only be activated when turning small hacks off. I tried it because I am curious to see how good it will work, but ML switches to flexi single automatically when trying to change it from Canons settings. What settings could I have set wrong?

Also is there any way to save my settings in case somebody messes with them or I need to wipe my card? Or does any file on the card store all the settings?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: metamerism on August 27, 2023, 06:36:42 AM
Request: Use LCD face sensor to stop video.

Right now you can use the LCD face (distance) sensor to start video recording. You can turn on the LCD face sensor in the Photo menu, and it will work for videos too. However, you cannot stop the video recording using the LCD face sensor.

Could you add an option to use the LCD face sensor to stop the video recording? This way we can minimise camera shake.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on August 27, 2023, 07:36:25 AM
Quote from: manifestor on August 27, 2023, 02:26:18 AM
Also is there any way to save my settings in case somebody messes with them or I need to wipe my card? Or does any file on the card store all the settings?

ML settings are stored in ML\Settings directory/folder.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on August 28, 2023, 09:49:59 PM
[EOS M] LiveView (Frozen) and Recording Raw does NOT work at all with 1x3 modes while using FPS Override (Exact). I am trying to get True 24p with 1x3 modes. Is this an oversight bug and fixable, or a limitation of the camera? FPS Override only works with 1x1 and 3x3 modes, but not 1x3 (which is a shame because this is the most interesting mode to use). It may seem trivial to want 24 FPS instead of 23.976, but it is important if you are trying to match the framerate of the other cameras being used in a project that requires true 24 FPS. Thanks in advance
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: manifestor on August 29, 2023, 01:25:52 AM
Quote from: Walter Schulz on August 27, 2023, 07:36:25 AM
ML settings are stored in ML\Settings directory/folder.

Thx

Quote from: manifestor on August 27, 2023, 02:26:18 AM
Somewhere here I also read that autofocus during video can only be activated when turning small hacks off. I tried it because I am curious to see how good it will work, but ML switches to flexi single automatically when trying to change it from Canons settings. What settings could I have set wrong?

Never mind, saw Bilals post about autofocus not working in crop mood.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: moloch on August 29, 2023, 05:43:07 AM
Hello!

I am getting an error when recording in 16:9 4.5k using hdmi on the 650d. The recording has many pink frames and stops quickly, with any other mode this does not happen. It also crashes and stops recording, leaving the following .log file in the main folder.

ML ASSERT:
0
at mlv_lite.c:2916 (compress_task), task compress_task
lv:1 mode:3

compress_task stack: 1ab138 [1ab1c8-1aa1c8]
0x0007EB50 @ b05080:1ab168
0x0007E478 @ 7ebac:1ab138

Magic Lantern version : crop_mood.2023Aug19.650D104
Mercurial changeset   : NO HG
Built on 2023-08-19 09:00:42 UTC by bilal@DESKTOP-27BNL6E.
Free Memory  : 121K + 3337K
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on August 29, 2023, 08:30:06 AM
Quote from: Mythic Cinema on August 28, 2023, 09:49:59 PM
[EOS M] LiveView (Frozen) and Recording Raw does NOT work at all with 1x3 modes while using FPS Override (Exact). I am trying to get True 24p with 1x3 modes. Is this an oversight bug and fixable, or a limitation of the camera? FPS Override only works with 1x1 and 3x3 modes, but not 1x3 (which is a shame because this is the most interesting mode to use). It may seem trivial to want 24 FPS instead of 23.976, but it is important if you are trying to match the framerate of the other cameras being used in a project that requires true 24 FPS. Thanks in advance
Shutter fine tuning?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on August 29, 2023, 09:19:17 PM
Yeah, I use shutter fine tuning 1/48 (180 degrees) and shutter "full range" setting. I will have to see if disabling that and keeping the FPS Override on will work.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on August 30, 2023, 08:20:36 AM
Or disable fps override.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on August 30, 2023, 04:43:02 PM
I disabled "Shutter Fine-Tuning", but the 1x3 modes still don't work with "FPS Override" enabled. I can't disable FPS override because I need it to match the framerate of the other cameras and the projects I am working on. I'll have to use another mode instead, but I am just reporting this FPS Override bug with 1x3 modes in case it isn't known. Hopefully it is fixable.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on August 30, 2023, 10:27:00 PM
Fps override is not the best solution in crop rec code as it often conflicts with fps code applied in particular presets in crop rec code. What I mean is that you should select 24 fps and use shutter fine-tuning to match you cameras outside fps override.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on August 31, 2023, 01:50:24 AM
As far as I know FPS Override is the only way to get true 24 FPS, but correct me if I am wrong. I need that framerate, not 23.976 / 23.98. I'll just use 1x1 or 3x3 modes when I need true 24p I guess.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on August 31, 2023, 06:39:42 AM
YOu get equally "true" fps with shutter fine-tuning.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on August 31, 2023, 04:33:07 PM
Really? Not sure I understand. I use it to get 1/48 shutter, but how does it affect framerate? How can I get a flat true 24 FPS and 1/48 shutter (180 degrees) without FPS Override? If possible, or do I have to use a different shutter angle?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: vastunghia on August 31, 2023, 05:27:36 PM
Quote from: Mythic Cinema on August 31, 2023, 01:50:24 AM
I need that framerate, not 23.976 / 23.98

Just out of curiosity - why, if I may ask
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on August 31, 2023, 06:52:22 PM
Quote from: Mythic Cinema on August 31, 2023, 04:33:07 PM
Really? Not sure I understand. I use it to get 1/48 shutter, but how does it affect framerate? How can I get a flat true 24 FPS and 1/48 shutter (180 degrees) without FPS Override? If possible, or do I have to use a different shutter angle?
You are right. I brainfarted.
It is possible to fine tune fps directly in crop rec.c but I don't know if it is implemented. Then again, in practice I can't see it would matter too much.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: falcon on August 31, 2023, 11:59:47 PM
Is there any possibility of getting a centered 4:3 preset?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Mythic Cinema on September 01, 2023, 02:15:57 AM
Quote from: vastunghia on August 31, 2023, 05:27:36 PM
Just out of curiosity - why, if I may ask
DCP (Digital Cinema Package)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: 2blackbar on September 04, 2023, 10:22:41 PM
So.. i read some posts here about cards performance, anyone have the small ones ? DO they work as good as big ones?
(https://a.allegroimg.com/s720/112959/504da430442ab8f20c2667106690/Karta-SANDISK-EXTREME-PRO-256GB-SDXC-200MB-s-V30)
(https://a.allegroimg.com/s720/11e553/853d5ea94de2b4e8556ce5b8ad48/Karta-micro-SD-SANDISK-EXTREME-PRO-256GB-200MB-s)

Do they really work fine for video on M ? Whats the max res possible ? 3K crop at 24 works fine ?
Id pin this info somewhere about best /fastest cards that do work for raw video so there wont be lame questions like this in the future
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on September 05, 2023, 01:17:29 AM
Full size and micro performance is the same

About compatible cards: https://wiki.magiclantern.fm/cards_240mhz
Performance hardly makes a difference. They all do > 90 MByte/s in benchmark and Lexar 1667x tops at over 100. Results are within 10 percent range.
10 percent in bandwidth translates to less than 5 percent difference in horizontal resolution and that is nothing to write home about.
We are far away from reaching card's write limit (140 MByte/s according to specs). Maybe Bilal will succeed in unlocking it but we can't know.


ATM (and for a while) my price/performance favorite is Samsung EVO Plus 256 GB. There is a deal in Germany and you can grab one for 13.99 Euro including shipping.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: bern047 on September 05, 2023, 02:55:14 PM
I am using Samsung plus pro, some excellent prices on Amazon, I got myself 256gb and 512gb they work great at half the price of Sandisk Extreme Pro
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: 2blackbar on September 05, 2023, 06:43:50 PM
Thanks Walt, bought 256 samsung EVO +
--
Ok card arrrived, i am able to get 3k  in 2.40:1 ratio , about 40 seconds ,8-11bits, sometimes not even 5 seconds but its definitely possible  just turn off histogram as its the cause of recording getting cut off much sooner,3072x1286 res.
With 3k 2.35:1 im at 9 secs at 3072x1308.
2012 cam for 120 euro and 3k raw, its pretty incredible even if its crop , its amazing.
I like the 1440 res a lot cause its kinda like 16mm film , with C mount works nicely, i wish there was more resolution choices above 1440 like 1600 , so its square 4:3 like 16mm film footage.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: artem on September 08, 2023, 09:23:06 AM
Quote from: Walter Schulz on September 05, 2023, 01:17:29 AM
ATM (and for a while) my price/performance favorite is Samsung EVO Plus 256 GB.

Walter, could you tell me please is it (a bit) slower then Sandisk Extreme pro 200mb? Or the same? I have two 128Gb Sandisk, and want to buy more before vacation (laptop will not be on hand during daytime, and 12bit 5,2k eats space very fast). I'm a fresh user of eos m, so I test it these days, and 14 bit is unstable sometimes with my settings. Is it possible to record about 20 seconds on maximal quality (in a bright day or shiny docks at night) with Samsung Evo plus/Pro plus? Samsung prices are much reasonable.

UPD: I've found two years old warning on reddit:
>> DON'T BUY Samsung EVO Plus 130mb/s
>> If you want to record Raw Video, don't buy the Samsung EVO Plus 130mb/s.
>> You can not overclock at the moment and will get a max of 38mbit/s on the EOS M.
>> Rather buy a Kingston 95mb/s or Sandisk extreme pro 170/95mb/s

Is it obsolete?..
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on September 08, 2023, 09:31:15 AM
Please read rest of quoted post.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: artem on September 08, 2023, 05:12:56 PM
Oops, didn't notice the hidden part of the discussion there. But now I see, and I'm annoyed:

Works at 160MHz with EOS M and writes at 67 MByte/s. 192 MHz is dropping to 20 MByte and 240 MHz (if it loads at all), too.

So 67 MByte/s is maximum this card can suggest? (sorry for stupid questions, maybe new builds have fixed and boosted speed or so)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on September 08, 2023, 10:48:29 PM
I can't read for you.
https://www.magiclantern.fm/forum/index.php?topic=26851.500#msg244941
This is the message you quoted. This is the message you should read.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: artem on September 09, 2023, 01:48:24 AM
Quote from: Walter Schulz on September 05, 2023, 01:17:29 AM
Results are within 10 percent range. 10 percent in bandwidth translates to less than 5 percent difference in horizontal resolution
This was a bit unclear with my so-so English. I felt I can miss some nuances which are obvious for you and not for me. Thank you for sending me back to this message (and for "nothing to write home about", a new idiom for me). I'll risk to grab a couple of Samsung pro plus 256, as an addition to my Sandisk128 Extreme Pro.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: bobolee on September 17, 2023, 08:00:51 PM
MOD intervention: User is giving incorrect information. I just tested my Samsung PRO Plus 256 GB (2021 edition, MB-SD256K) with Mood Crop 2023Aug19 build and recorded for 5:03 with manual stop. Recording size is 25,569.4 MByte resulting in 84.3 MByte/s. Benchmark is showing > 90 MByte/s in PLAY-PH mode (cam in photo mode).

=============Original post below========================================

Quote from: artem on September 09, 2023, 01:48:24 AM
I'll risk to grab a couple of Samsung pro plus 256, as an addition to my Sandisk128 Extreme Pro.
This Samsung card is not compatible with overclocking on eos m,don't buy it!
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on September 21, 2023, 02:22:36 PM
Quote from: bobolee on September 17, 2023, 08:00:51 PM
MOD intervention: User is giving incorrect information. I just tested my Samsung PRO Plus 256 GB (2021 edition, MB-SD256K) with Mood Crop 2023Aug19 build and recorded for 5:03 with manual stop. Recording size is 25,569.4 MByte resulting in 84.3 MByte/s. Benchmark is showing > 90 MByte/s in PLAY-PH mode (cam in photo mode).

=============Original post below========================================
This Samsung card is not compatible with overclocking on eos m,don't buy it!

MOD: Without the Recording Resolution, Bitrate, and a description or a screenshot of the scene you shot, your statement can be misleading.

For example:

a Sandisk Extreme 256GB 170 MB/s will show 94.1 and 95.1 MB/s write speeds in the benchmark;
a Sandisk Extreme Pro 256GB 200 MB/s will show 94.8 and 95 MB/s.

but at 2.8k/14 bits, only the Sandisk Extreme Pro will be able to record long takes in a reliable fashion in difficult / well exposed  scenes.
In order to do so at -1 EV (1.0 showing on the histogram) , a card needs to be able to handle 85 MB/s continuously and tolerate 93 MB/s peaks (And those peaks can last up to 4-5 seconds on the Extreme Pro).

The benchmark doesn't give you the whole picture. In order for any  speed figures to be really meaningful for actual use, comparison tests between cards shall be made by recording the same scene with identical parameters.

Recording a dynamic scene at -4 EV / 10 Bits will work with a lot of cards, but the noise level and subpar resulting image will seriously misrepresent the actual capabilities of the cam...

Quote from: Walter Schulz on September 05, 2023, 01:17:29 AM

Performance hardly makes a difference. They all do > 90 MByte/s in benchmark and Lexar 1667x tops at over 100. Results are within 10 percent range.
10 percent in bandwidth translates to less than 5 percent difference in horizontal resolution and that is nothing to write home about.

This is exact. But a 4% increase in bandwidth will give you about 1 EV of extra exposure latitude at 2.5k/14 bits. So although marginal, the gain can help mitigate camera hiccup related issues.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: bobolee on September 21, 2023, 03:24:30 PM
I bought the card,so called benchmarks will work,speed is good,but in real shooting,it will stop in a few minutes of raw video recording.This so called Benchmark way of testing cards is misleading.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on September 21, 2023, 03:42:44 PM
Quote from: bobolee on September 21, 2023, 03:24:30 PM
I bought the card,so called benchmarks will work,speed is good,but in real shooting,it will stop in a few minutes of raw video recording.This so called Benchmark way of testing cards is misleading.

Multiple other people have this card working in a real cam, including the M, for long shots.  Not just benchmarks.

If you had said "I couldn't get this card working reliably in my cam" - that would be fine.

Saying this card doesn't work for long videos in *general*, is not true.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on September 21, 2023, 03:46:36 PM
Quote from: bobolee on September 21, 2023, 03:24:30 PM
I bought the card,so called benchmarks will work,speed is good,but in real shooting,it will stop in a few minutes of raw video recording.This so called Benchmark way of testing cards is misleading.

Your report is the only one so far having such problems.
We would like to have more details.
- Have you used Samsung's verification tool? There should be a small checkmark icon on card's back.
- Country of production?
- CID data readable. They can easily be faked but won't hurt to try.
- Have you used tools like h2testw or f3 to verify storage capacity?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: bobolee on September 21, 2023, 05:59:55 PM
Quote from: Walter Schulz on August 05, 2022, 01:21:57 PM
Yesterday I did some tests with Extreme Pro and Extreme Plus R170/W90. They perform quite the same and allowed transfer rates above 70 MByte/s. Didn't test "anamorphic" modes, though.
Samsung PRO Plus R160/W120 performed well in benchmark but really sucks trying to record with overclocking and higher transfer rates.
https://www.magiclantern.fm/forum/index.php?topic=24401.75 (https://www.magiclantern.fm/forum/index.php?topic=24401.75)
You said you have problem with this card also,now you said I'm the only person?although ,your description is not detailed also.
I've already talked about this card in detail in other posts,you've also replied,now ,you ask for details again.Is this a AI account or what ?Fix your memory issue pls.and this is not the right thread to talk about sd cards,so ,I only share some short warnings to people.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on September 21, 2023, 06:05:51 PM
You are quoting one year old tests. I retested with Bilal's latest sd_uhs.mo (several builds) and had no troubles at all.
You can go back in time and find "proof" only 2 specific Sandisk card types are working reliable with oc.

Right now you are the only person reporting issues and you are constantly denying giving any further details. You are claiming this card does not work "at all" while there are at least two persons having working cards
.
And now you are going ad honinem instead of trying to answer with details..
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: raul791 on September 21, 2023, 06:30:46 PM
Hi all,

any tips in using smartphone as a monitor (Android)? There are some videos on youtube, but they are old and based on native ML, not Crop Mood.

I mainly record at 1x3 4.8k 12bit or 1x3 UHD 16:9 12bit (when I need long stable videos).

Using Canon 700D with latest Crop Mood (shutter version).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on September 21, 2023, 07:27:58 PM
Quote from: raul791 on September 21, 2023, 06:30:46 PM
any tips in using smartphone as a monitor (Android)? There are some videos on youtube, but they are old and based on native ML, not Crop Mood.

There is no difference using any camera with HDMI output connected to HDMI capture device.
Smatrphone must support OTG, though.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: raul791 on September 22, 2023, 10:18:52 AM
Quote from: Walter Schulz on September 21, 2023, 07:27:58 PM
There is no difference using any camera with HDMI output connected to HDMI capture device.
Smatrphone must support OTG, though.

Thank you!

That's great - my phone (Poco X4 GT) support USB OTG, so I need to try it.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: scriptmonkey on September 27, 2023, 09:34:58 AM
Hi,
How to use the options Zebras, Focus peaking or Magic Zoom? Activating them has no effect. I set Global Draw to various values but it does not help. There is an orange message about pressing INFO outside the LM menu, but it also does not change anything.

Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on September 27, 2023, 10:20:11 AM
Wait a moment! "Doesn't change anything"? You are not able to toggle screens?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: scriptmonkey on September 27, 2023, 12:22:58 PM
I can toogle screens menu/preview. I can record. Everything works, no matter if the options are enabled or not. It's only that in the preview image Focus peaking does not produce dots, Zebra does not produce zebras and Magic zoom does not produce the zoom window.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on September 27, 2023, 12:29:02 PM
Other overlays work?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: scriptmonkey on September 27, 2023, 01:14:51 PM
In Preview (no recording) I see the usual icons like exposure or ISO. During recording, there is only a green Camera icon, 67MB/s 17% idle and that's all. I enabled LV sharpening and it is visible (very helpful for focus).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Grognard on September 27, 2023, 05:48:28 PM
Quote from: scriptmonkey on September 27, 2023, 01:14:51 PM
In Preview (no recording) I see the usual icons like exposure or ISO. During recording, there is only a green Camera icon, 67MB/s 17% idle and that's all. I enabled LV sharpening and it is visible (very helpful for focus).

You need to disable "kill global draw" in raw options.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: scriptmonkey on September 27, 2023, 08:55:06 PM
Quote from: Grognard on September 27, 2023, 05:48:28 PM
You need to disable "kill global draw" in raw options.

Kill global draw is in the state ON. The buttons disappear during recording. They are there only during the preview.

If by "disable" you mean OFF, it does not help.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: scriptmonkey on September 27, 2023, 11:12:52 PM
It's ok now, thanks. Kill Global Draw must be indeed OFF for the overlays.





Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: scriptmonkey on September 29, 2023, 12:00:14 PM
I loaded the Dual ISO module, tried it out, then I tried to switch off the camera but "sensor cleaning" was there forever. I rebooted several times, maybe five or six, switched between menus and preview, nothing was changing until I removed the Dual iso module. After this, the camera was shutting down properly again.

I reloaded Dual ISO, that time everything was ok.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: scriptmonkey on October 01, 2023, 10:42:37 AM
Overlays are gone again, despite disabled Raw/KillGlobalDraw and enabled Overlays/GlobalDraw. That's why I wanted to make sure before that I needed to disable KillGlobalDraw and not GlobalDraw, as in enable KillGlobalDraw ;) Maybe I am doing something wrong elsewhere. The other problem is that there is no battery level indicator (maybe because there are no overlays). LM docs say something about a Battery Level menu, but I cannot find it anywhere in Crop mood.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on October 01, 2023, 11:10:33 AM
Zip content of ML/SETTINGS and link zip here.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: scriptmonkey on October 01, 2023, 11:27:46 AM
Zipped SETTINGS: https://drive.google.com/file/d/1NlYUKMlia1Joci2bnOO3H3aa_OjRH5zH/view?usp=sharing
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on October 02, 2023, 01:03:46 AM
Thanks!
Using your settings I get histogram overlay visible.
But your overlays are completely gone, right?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: scriptmonkey on October 02, 2023, 11:30:00 AM
Yes they are! My fault: I did not know that I needed to press INFO. Maybe I did press it before accidentally. Thanks Walter.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ThePotatoParadox on October 11, 2023, 12:25:31 PM
I'm trying to get my EOS M to record h264 proxies for an improved playback. Because it says it's not compatible with x5 zoom, I disabled x5 zoom in the LV config but doesn't seem to solve the problem.

Is there a way to get h264 proxies or is this feature still not possible on the EOS M.

To me, a proper playback is the last feature I would need to use the camera for professional work. My clients always want to see the playback.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Apxub on October 15, 2023, 08:11:13 AM
Hello everyone!
Who knows what is the actual sensor readout speed (number in milliseconds) for EOS M ?
I need this number to setup "rolling shutter correction" inside Gyroflow correctly.
Theese ms numbers are different for different fps & resolution settings?
(https://i.postimg.cc/mrFXKftC/Screenshot-20231015-085454.jpg) (https://postimg.cc/d7wjTfRV)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on October 15, 2023, 02:19:25 PM
This depends on what mode you're shooting in.  E.g. higher res takes more time to read out.

I think one of the ML menus lists the read time per line, can't remember if that's a default or in a module.  Hopefully someone else remembers.  FPS override menu possibly?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: essbe on October 18, 2023, 11:45:31 AM
Yes, it is in the FPS-override menu.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: essbe on October 22, 2023, 11:35:19 AM
Have you tested it out yet Apxub, and if so, did it work as intended?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: doktorkrek on October 22, 2023, 07:19:11 PM
Hello, I would like to add a 4:3 preset to crop mood.
I have experience with writing C code. Please, could you point me where it would be the best to start with this codebase?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on October 22, 2023, 08:27:28 PM
Join discord. Easier there for this kind of conversation.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on October 22, 2023, 09:10:34 PM
Quote from: doktorkrek on October 22, 2023, 07:19:11 PM
I have experience with writing C code. Please, could you point me where it would be the best to start with this codebase?

I think the repo Bilal used for this is here: https://github.com/bilalfakhouri/magiclantern_hg_02/commits/crop_rec_4k_mlv_snd

Altering which recording resolutions are available is not trivial, and requires understanding of how the sensor is read.  You might want to read around forum threads on "FPS Timer", and also ADTG.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Alextazee on October 27, 2023, 06:15:44 PM
Hey guys,
I'm kinda new in the ML world, but picking up slowly... :)
Got a couple of questions, I still haven't figured out.
1. Is there a chance to save some personal settings as a preset,
2. Is there a fix for the focus peaking over HDMI? Mine works OK, on the camera's display, but when I connect an external monitor over HDMI, the focus peaking stops working, and shows as a glitchy horisontal stripe.

Oh, btw, I'm using 650D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on October 27, 2023, 06:45:20 PM
Quote from: Alextazee on October 27, 2023, 06:15:44 PM
1. Is there a chance to save some personal settings as a preset,

https://wiki.magiclantern.fm/camera_help#config_files -> Config Presets

Quote from: Alextazee on October 27, 2023, 06:15:44 PM
2. Is there a fix for the focus peaking over HDMI? Mine works OK, on the camera's display, but when I connect an external monitor over HDMI, the focus peaking stops working, and shows as a glitchy horisontal stripe.

ATM ML focus peaking won't work via HDMI. You can try using Display tab/screen -> LV Digic Peaking
https://wiki.magiclantern.fm/camera_help#lv_digic_peaking
Some more sophisticated camera monitors (field monitors) come with focus peaking and more features. With a price tag ...
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Teamsleepkid on November 06, 2023, 07:22:59 AM
Anything going on with rolling shutter? Any way on earth do decrease it and still get 24fps 3x1 anamorphic mode? Love the mode currently using the 4.2k 2:40 71% rolling shutter setting as it's the least. Like 29ms the other settings are like 35ms kinda high. Anyway thanks love the setting just wondering. I asked in mlv app forum post if it's possible to output prores raw. Just would love this tiny eos m with less rolling shutter and pro res raw. Could be the best little cinema camera to ever exist. Just dreaming out loud guys. Thanks for everything.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on November 13, 2023, 04:56:17 PM
[MOD intervention: Full quote edited. Long post, please follow link]
Quote from: gabriielangel on April 27, 2023, 01:38:54 AM
For those who didn't know, it is possible to record Uncompressed (As opposed to Lossless) with some presets.


so 10 bit lossless is not truly lossless?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on November 13, 2023, 06:00:19 PM
Lossless compression is lossless compression. Of course you are loosing information by using a lower bit depth.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on November 13, 2023, 09:24:10 PM
Quote from: Walter Schulz on November 13, 2023, 06:00:19 PM
Lossless compression is lossless compression. Of course you are loosing information by using a lower bit depth.

some user tested that 10 bit uncompressed raw had better shadow than 10 bit lossless.

"In order to test, I recorded the same scene at 3 degrees of brightness (F2, F4, F11).
As you can see in the screenshots, varying brightness with Lossless changes the Data Rate, but the latter remains constant when using Uncompressed.

Recording 10bit ettr and lowering exposure in post will yield a cleaner image than 14bit recorded severely underexposed.
Also, 10bit Uncompressed has cleaner shadows than 10bit Lossless (No red tint)

You can see the data rates at various resolutions in the screenshots.
This could be particularly interesting for those using 1080p 3x3."

https://www.magiclantern.fm/forum/index.php?topic=26851.msg243544#msg243544
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on November 13, 2023, 10:39:59 PM
Ah, that part.  Yes, they did say that, and if you read the following posts you will see people exploring it and get the answer to your question (10-bit lossless is lossless).
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on November 14, 2023, 03:16:22 AM
Quote from: names_are_hard on November 13, 2023, 10:39:59 PM
Ah, that part.  Yes, they did say that, and if you read the following posts you will see people exploring it and get the answer to your question (10-bit lossless is lossless).

thanks, good to know. only arri and ml raw are uncompressed. i really don't like there is any cloudy thought here about the lossless compression algorithm. it is one of the best selling points of ml raw. ml rocks.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on December 07, 2023, 06:48:31 AM
@bilal,
I've got an issue with magiclantern-crop_mood.2023Aug19.700D115_Shutter.zip build
when I record video without crop mood preset the sd overclock is off suddenly with safe mode warning

only 3 seconds with 2096 x 1180 from crop mood 1x1 sd hack 240hz with sandisk extreme pro
(https://i.ibb.co/S3CtNPH/Screenshot-2023-12-08-144527.png)
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on January 11, 2024, 04:53:34 AM
Just installed the crop mood ver 20230809 on Rebel SL1 with firmware updated version 1.01. Aamazing work. Two thumbs up.

I can do continuously recording (green) in 5.2k 1x3 mode, ar 2.67, 10 bit, 14 bit lossless, 24p, sd card overclocking 240 mhz, small hack more, global draw off on, sandisk extreme pro 256 gb. I tested at iso 100, 200, 400, 800, 1600. At ISO 800 and 1600, the recording time is about 30 seconds when global draw off is off, continuous when global draw off on. At ISO 100-400, it is truly continuous even when global draw off is off.

Two issues:
1. when stop the recording, there is error message "audio cannot stop recording".
2. when play back, the screen is black, and I have to take battery off and restart the camera, then I can play back the latest clip, but no other function buttons showing up.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Walter Schulz on January 11, 2024, 07:28:10 AM
Quote from: ML700D on December 07, 2023, 06:48:31 AM
@bilal,
I've got an issue with magiclantern-crop_mood.2023Aug19.700D115_Shutter.zip build
when I record video without crop mood preset the sd overclock is off suddenly with safe mode warning.

Retry using Access Mode SDR50.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on January 11, 2024, 04:43:08 PM
Quote from: Walter Schulz on January 11, 2024, 07:28:10 AM
Retry using Access Mode SDR50.
ok. thanks Walter.. I'll try it later.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Frank7D on January 17, 2024, 05:54:11 PM
I take it there is no build for the 7D? Might have to invest in one of these other cameras...
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on January 18, 2024, 03:53:54 AM
Quote from: Frank7D on January 17, 2024, 05:54:11 PM
I take it there is no build for the 7D? Might have to invest in one of these other cameras...
maybe here.. https://www.magiclantern.fm/forum/index.php?topic=13746.msg245822;topicseen#msg245822
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: names_are_hard on January 18, 2024, 02:57:11 PM
That's a thread on 7D2, different cam to the 7D.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: gabriielangel on January 22, 2024, 11:45:20 PM
I tested the Samsung Evo Plus 128GB 2023/04 thoroughly today (Will post the results soon).
I discovered that with that particular card, I had a clear pattern regarding the "Frame Order Error": One clip records fine, One clip records with frame order error, and so on.
I restarted the camera a few times and that pattern remained constant. This happened recording at 2.5k 2.39:1, 14bits and 12 bits, 1 minute clips.
SDR104 and SDR50 yielded the same results and behavior.
With Bilal's latest build for EOS m, Camera set tp AF, Small Hacks more.

EDIT: I also tested the Samsung Evo Plus 512GB MB-MC512KA. 2023/07, same parameters, and this card did not give me a single Frame Order Error over the course of the session.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on January 29, 2024, 12:34:20 AM
Quote from: mlrocks on January 11, 2024, 04:53:34 AM
Just installed the crop mood ver 20230809 on Rebel SL1 with firmware updated version 1.01. Aamazing work. Two thumbs up.

I can do continuously recording (green) in 5.2k 1x3 mode, ar 2.67, 10 bit, 14 bit lossless, 24p, sd card overclocking 240 mhz, small hack more, global draw off on, sandisk extreme pro 256 gb. I tested at iso 100, 200, 400, 800, 1600. At ISO 800 and 1600, the recording time is about 30 seconds when global draw off is off, continuous when global draw off on. At ISO 100-400, it is truly continuous even when global draw off is off.

Two issues:
1. when stop the recording, there is error message "audio cannot stop recording".
2. when play back, the screen is black, and I have to take battery off and restart the camera, then I can play back the latest clip, but no other function buttons showing up.

update
i found out that after i unload the raw hack module, the mlv playback is normal now.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Frank7D on January 31, 2024, 07:37:32 PM
So I recently got a 650D so I could try out this build. The new previews plus the sd overclocking are very nice, thank you!
I have a question (and I apologize if it has already been answered):
I like to shoot 1920x1080 (x5 1:1 mode to avoid aliasing).
The closest crop mood preview I see for that is 1280P (1920x1280).
This preview matches the video perfectly horizontally but vertically displays extra image above and below the actual video frame.
Is this preview my best bet for proper framing?
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: mlrocks on February 04, 2024, 12:16:28 PM
100d seems not as sharp as 650d. Maybe af is not as precise as 650d. Will test more.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: zenny on February 15, 2024, 08:12:10 AM
Hi,

Thanks for the outstanding work of Bilal and Danne (I use Danne's build from early this year, 2024), yet I am a newbie here. There are no parallels.

I did not see 5.2k or 4.8k in 4:3 format in the chart. I was just wondering if I have to shoot in 4:3 format in a higher resolution possible with the crop_mood, particularly to accommodate more of top and down than left and right (considered as a normal human vision with 50mm focal length in 35mm film photography).

Is 4:3 format possible with crop_mood at 4.8k resolution at least?

Cheers,
/z
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on February 16, 2024, 12:19:42 AM
in 700d you can try crop mood 1x3 16:9 4.5K  then change the resolution in RAW Video setting AR to 4:3 and resolution 1120x2520
it will give you 3360x2520
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on February 16, 2024, 01:01:35 AM
Quote from: Walter Schulz on January 11, 2024, 07:28:10 AM
Retry using Access Mode SDR50.
I have tried but still fail..
after I tried many times I concluded it could only record properly once then I have to restart the camera and so on..
and sometimes when I pull out and insert the battery the camera won't start..
so I still use previous build crop_mood.2023May09, better than nothing..  :D
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: zenny on February 16, 2024, 06:57:04 AM
Quote from: ML700D on February 16, 2024, 12:19:42 AM
in 700d you can try crop mood 1x3 16:9 4.5K  then change the resolution in RAW Video setting AR to 4:3 and resolution 1120x2520
it will give you 3360x2520

Thanks for your useful input, just wondering whether it works in EOS-M, too?

Cheers,
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: ML700D on February 16, 2024, 09:10:03 AM
i think it will work too.. you can try it, if you got some trouble you can ask @danne for help
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: zenny on February 16, 2024, 09:47:14 AM
Quote from: ML700D on February 16, 2024, 09:10:03 AM
i think it will work too.. you can try it, if you got some trouble you can ask @danne for help

Thanks. As you suggested, I shall ask Danne (because I am using his 2024-2-14 crop mood binary build (https://bitbucket.org/Dannephoto/magiclantern_hg_02/downloads/magiclantern-crop_mood.2024Feb12_Custom.EOSM202.zip).

Cheers,
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: Danne on February 16, 2024, 09:50:11 AM
It works. You have to change to 4:3 in RAW video section and scroll down resolution until you get to 4:3. Preview will still be full 16:9 though.
Higher 4:3 in 1x3 fails over here. Fps is already at 22fps in this preset and it will not exceed this with the height. At 1538.
Title: Re: Crop mood - WYSIWYG Edition (650D / 700D / EOS M / 100D)
Post by: zenny on February 22, 2024, 05:57:13 PM
Quote from: Danne on February 16, 2024, 09:50:11 AMIt works. You have to change to 4:3 in RAW video section and scroll down resolution until you get to 4:3. Preview will still be full 16:9 though.
Higher 4:3 in 1x3 fails over here. Fps is already at 22fps in this preset and it will not exceed this with the height. At 1538.

Thanks @Danne for your input. I shall try to go with your recommendation. Cheers,