Magic Lantern Forum

Experimental builds (WIP) => crop_rec and derived builds => Topic started by: theBilalFakhouri on September 18, 2020, 07:51:30 PM

Title: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on September 18, 2020, 07:51:30 PM
**Download links in the End of the post**
   
This new OP created in 24-5-2021

My custom builds are splitted now from the official 650D/700D threads, now we can focus the discussion on my builds, I will share future updates and tutorials frequently in this thread.

Welcome to:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FCKKj96s%2F1620x540-00000.png&hash=cb85d5740bdaecb9233d5a225e99ac1c)

Once upon a time, Trammell Hudson (https://trmm.net/Magic_Lantern_firmware/) said:
"if it breaks your camera, you get to keep both pieces". Nothing changed, same applies here and in every build you are using :D

Q&A:
-Why would you use my builds?
It's included features might be useful or interesting to you, read below.

-Why wouldn't you use my builds?
These builds include bleeding-edge developments, it might break your camera, Don't use it if you are afraid!. However, to some point I know what I am doing, I only use my builds on my camera, never bricked it, some users used my builds too without resulting in a broken camera, the stats look good, Relax.

Features:
-SD Overclocking module with selectable presets 160MHz, 192MHz and 240MHz.
-High resolutions pre-made presets (crop_rec) 1920x1280p/1440p/3K 1:1, 4.5K/4.3K/4K/UHD 1x3 and more (Including preview fixes, correct framing real-time previews in 1x3 modes)
-Magic Zoom V2 (LiveView zoom in to check focus while recording!) for some (crop_rec) presets.
-Changeable resolutions, framerates and binning modes module via (crop_new), you can get Full-Resolution LiveView 5208x3472 continuous in 10-bit lossless @ 5 FPS!
-ISOless 8 & 15 Dual ISO fix (https://www.magiclantern.fm/forum/index.php?topic=7139.msg197139#msg197139) for some 700D users.
-You can use lower bit-depths in lossless compression when shooting in high resolutions.
-Shutter speed is correct when using any preset, or FPS override.

-Enhanced experience for 1x3 Binning modes (Disabled Canon GUI, ML top bar would go to bottom automatically for better preview)
-Bit-depth is showing in ML bottom bar when using Crop mode.





How to use this build? Tutorial
I am preparing full video tutorial about this build included other related info, it may take a while!
Currently you can follow this post as guide, let me know if you have questions

General notes:
-You can load both crop_rec and crop_new modules, but don't activate them at the same time (use "Crop mode" or "Crop mode V2").
-Use maximum aspect ratio from mlv_lite when using crop_rec presets with real-time correct preview, otherwise mlv_lite won't crop the RAW data correctly.

-Loading the modules
After installing the build, some modules should be loaded manually for once to be able to record RAW video, use crop modes, view recorded RAW clips . .
I recommend to load the following modules to get the best out of my builds:

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FsgjYCQn%2FModules.png&hash=75ce4dadfe9354466c643488b7900d57)

crop_new: Second version of crop mode (read below).
crop_rec: First version of crop mode (read below).
dual_iso: Dynamic range improvement (read about it here (https://www.magiclantern.fm/forum/index.php?topic=7139.0)).
mlv_lite:  Records RAW video.
mlv_play: RAW video (MLV) player.
mlv_snd: Adds sound recording to RAW video.
sd_uhs: Does SD overlocking which increase write speed (continue reading).

-Load these modules from "Modules" tab from ML settings, highlight a module and press SET button for each module, then restart the camera.
-Loading other modules is fine if you need them.

-SD Overclocking
We can bypass SD Controllers write/read speed limits using sd_uhs module:

-Select a preset (160, 192 or 240 MHz) then restart the camera.
-The highest preset 240 MHz gives ~ 68 MB/s write speed (https://www.magiclantern.fm/forum/index.php?topic=12862.msg228673#msg228673) in video mode, and 240 MHz preset is stable when using Sandisk Extreme Pro 170MB/s Card (https://www.magiclantern.fm/forum/index.php?topic=12862.msg228673#msg228673).

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FWWPYcJL%2FMenu1.png&hash=def21bf27b6aa7f196525dac3b9d9a01) (https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FHGbT2FD%2FMenu2.png&hash=4584cc61ba400630adc4c779370170c4)

-Best compatible SD card is Sandisk Extreme PRO UHS-I U3 170 MB/s (works in all presets, stable at 240 MHz).
 Second-best is Sandisk Extreme PRO UHS-I U3 95 MB/s (works well in 160 MHz and 192 MHz presets)

-Perform "Low level format" in camera to get stable write speeds (at least for once), image on the left before low level format, image on the right after performing low level format; stable as hell:

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.imgur.com%2FV1t8kKE.jpg&hash=986cd95997368547e14181aebadacf7f) (https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.imgur.com%2FH4KeIhc.jpg&hash=552c23bbf40401c9a995389744f3db5e)


-Crop mode (crop_rec) with Pre-Made Presets
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2Fn15HFWH%2FPresets.png&hash=7360dc077acd4aedd0f77e979d9da5ba) (https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2Fh1L61ZW%2Fcrop-rec-submenu.png&hash=51ed453620aecf3de9e6dd5ee021c435)

1- 2.5K Expanded Preview: Experimental Real-Time Correct Framing Preview in default x5 Mode.
2- 1440p 1:1: 2560x1440 16:9 @ 23.976 or 25 FPS with Fixed Cropped Preview.
3- 3K 1:1: 3072x1308 2.35:1 @ 23.976 FPS with Fixed Cropped Preview.
4- 4.5K 1x3: 1x3 Binning 1504x1782 with 1.86 Crop factor ~2.50:1 @ 23.976 or 25 FPS with Correct (Un-Stretched) Preview.
5- 4.3K 1x3: 1x3 Binning 1440x1836 with 1.94 Crop factor 2.35:1 AR with Correct (Un-Stretched) Preview.
6- 4K 1x3: 1x3 Binning 1360x1976 with 2.05 Crop factor ~2:1 @ 23.976 FPS or 25 with Correct (Un-Stretched) Preview.
7- UHD 1x3: 1x3 Binning 1280x2160 with 2.18 Crop factor 16:9 @ 23.976 or 25 FPS with Correct (Un-Stretched) Preview.
8- 1920x1280p 1:1: 1:1 1920x1280p @ 23.976 or 25 FPS with Correct Preview.
9- Full-Res LV 1:1: 1:1 Full-Resolution LiveView 5208x3478 @ 2 FPS.
10- 720p50 3x3: 3x3 Binning in 720p (square pixels in RAW) 1736x698 @ 50 FPS with Correct (Un-Stretched) Preview.

-You can easily check focus by pressing Half-Shutter in LiveView while not recording (works in all 1x3 presets and 1920x1280p 1:1 preset) to get into x10 mode, unpress Half-Shutter to get back to normal LiveView.



Crop mode submenu settings:
-Shutter range: Full range allows you to get the lowest shutter speed and highest shutter speed possible with camera Hardware, e.g: down to 1/24 shutter speed, up to 1/36K shutter speed @ 23.976 FPS.
-Bit-Depth: This allows you to get 10/12 Bit-Depths with higher resolutions presets:
Always select 14-bit lossless from mlv_lite, select 10-bit or 12-bit from crop_rec submenu.

-Set FPS: Change the framerate for some presets to 25 FPS instead of 23.976 FPS (works in all 1x3 presets, 1920x1280p 1:1 and 1440p 1:1).

-Magic Zoom V2
-3K and 1440p presets aren't supported, you can use regular x10 mode.
-I had corrupted frames when using Magic Zoom V2 with *HDMI monitor, don't use Magic Zoom V2 with HDMI monitor attached while recording.
*However attaching HDMI monitors isn't recommended in general for these small cameras; it cause problems even with official builds.

-4K and UHD 1x3 Presets do have Magic Zoom V2, but with not perfectly centered preview or stretched zoomed preview, but it's valid for focusing.

Features:
-Nail your focus While recording!
-Works with All presets with real-time correct framing preview.
-You can trigger it by Zoom button or SET button.
-No overhead or slowness, didn't have corrupted frames during my tests (on camera LCD screen).
-Real-Time as Canon Preview, it's a Canon preview actually, but zoomed.
-Works with Global Draw OFF.



-Crop mode V2 module (crop_new) with Arbitrary Resolutions:
Instead of pre-made presets, this is the new version of crop_rec from a1ex (https://www.magiclantern.fm/forum/index.php?topic=19300.msg205546#msg205546), which allow you to select any preferred resolution, framerate and binning mode.

-How to use it?

Select "Pixel binning" mode, set your X resolution and Y resolution, set your desired Framerate option, Press SET button in LiveView to apply the settings.

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FbgMffL4%2Fcrop-new-submenu.png&hash=fda404caed698c17e7ff6afb3698db0a) (https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2F6sMbXmm%2FPixel-binning.png&hash=1379220557a91d548d1071f2d712201f) (https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FtcKPGvB%2FFrame-rate.png&hash=5e10cf19b2a44b5db39216548bb40a23)

-Using 10/12 Bit-Depths in crop_new:
Always select 14-bit lossless from mlv_lite, and use 10/12 Bit-Depths option from crop_new submenu.

-Refresh LiveView manually after changing the settings by pressing SET Button in LiveView.

-Shutter range: Full range allows you to get the lowest shutter speed and highest shutter speed possible with camera Hardware (360° to 1°), e.g: down to 1/24 shutter speed, up to 1/36K shutter speed @ 23.976 FPS, or
in low framerate presets e.g @ 2 FPS loweset shutter speed would be 0.5", 360° and highest shutter speed 1/12K, 0°

-Fix Preview: Fix pinkish preview in x5 Mode, max X resolution should be 3112.

-x10 Mode will be valid for focusing, and won't be patched.
-This module doesn't include any recent preview fixes.

-Write speed improvement:
-You can get 2-3 MB/s write speed increase when using "EDMACs hack", more info in this reply (https://www.magiclantern.fm/forum/index.php?topic=25784.msg236507#msg236507).

Downloads:

700D:
Download the New build: crop_rec_4k.2021Aug22.700D115.zip (https://bitbucket.org/bilal_fakhouri/magic-lantern/downloads/crop_rec_4k.2021Aug22.700D115.zip)
Download the New build with re-solved Dual ISO ISOless 8 & 15 for some 700D users: crop_rec_4k.2021Aug22.700D115_ISOless_8_15.zip (https://bitbucket.org/bilal_fakhouri/magic-lantern/downloads/crop_rec_4k.2021Aug22.700D115_ISOless_8_15.zip)

Some users have stuck shutter value issue in ML menu, please try this build: crop_rec_4k.2021Aug22.700D115_Shutter_Blanking.zip (https://bitbucket.org/bilal_fakhouri/magic-lantern/downloads/crop_rec_4k.2021Aug22.700D115_Shutter_Blanking.zip)

650D:
Download the New build: crop_rec_4k.2021Aug22.650D104.zip (https://bitbucket.org/bilal_fakhouri/magic-lantern/downloads/crop_rec_4k.2021Aug22.650D104.zip)

Source-code:
magic-lantern-bilal (6-19-2021).7z (https://drive.google.com/file/d/1X988bhPt7PzF6s9TEXa-qfYVPgVMluFa/view?usp=sharing) (crop_rec_4k branch)

-Original post has been moved to Reply #2 (https://www.magiclantern.fm/forum/index.php?topic=25784.msg231134#msg231134).


Upcoming tutorial: Shooting in Full-Resolution LiveView 5208x3472 continuously in 10-bit lossless @ 5 FPS (or in 12-bit lossless @ 4 FPS).
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: SubZeroz on September 19, 2020, 10:16:51 AM



Really Really cool

Some questions regarding the regular Crop Mode (Because I would like to use the fixed Live-View):

1. All presets are 23.976 fps. Can I change it to 25 via the menu option?

2. Can the 4.5k anamorphic mode resolution be changed? (I prefer going 2.35 ratio)

In the other Danne's build, I could use the 5k Anamorphic and change resolution from the mlv_lite, and also have 25 fps.

Thanks!
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on September 21, 2020, 08:39:23 AM
Original OP started:
**Download links in the End of the post**

New Build for 700D
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2F0cH8jPq%2FNew-Build.png&hash=c218af30d05635f5d1f051303edbe59e) (https://imgbb.com/)
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FDK5GB4g%2FBuild-modules.png&hash=1fac84c61a0e640578afb68164e3f8a3) (https://imgbb.com/)

Included:
-SD Overclock with selectable presets 160, 192, 240 MHz.
-crop_rec with the higher resolutions with fixed LiveView (https://www.magiclantern.fm/forum/index.php?topic=19300.msg229664#msg229664) and the latest real-time (https://www.magiclantern.fm/forum/index.php?topic=25323.0) correct  (https://www.magiclantern.fm/forum/index.php?topic=25323.msg230933#msg230933)preview  (https://www.magiclantern.fm/forum/index.php?topic=25323.msg231048#msg231048)presets.
-The new crop_rec from a1ex with arbitrary resolutions (https://www.magiclantern.fm/forum/index.php?topic=19300.msg205546#msg205546) under the name "crop_new" or Crop mode V2.
-ISOless 8 & 15 Dual ISO fix (https://www.magiclantern.fm/forum/index.php?topic=7139.msg197139#msg197139).
-You can use Lower bit-depths when shooting in high resolutions in both crop_rec and crop_new.
-Shutter speed is correct when using any preset, or FPS override.

Using SD Overclock (sd_uhs.mo):
-Select a preset (160, 192 or 240 MHz) and restart the camera.
-The highest preset 240 MHz gives ~ 68 MB/s write speed (https://www.magiclantern.fm/forum/index.php?topic=12862.msg228673#msg228673) in video mode, and 240 MHz preset is stable when using Sandisk Extreme Pro 170MB/s Card (https://www.magiclantern.fm/forum/index.php?topic=12862.msg228673#msg228673).
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FjgXqzCZ%2FSD-Overclock.png&hash=26e2e0d2c725925009e4f86c18c27a52) (https://imgbb.com/)
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FzGT499N%2FSD-Overclock-Presets.png&hash=07fed98e5c5e337e5842bbfe9ddd64a5) (https://imgbb.com/)

Default Crop mode (crop_rec) with Pre-Made Presets
You have these presets:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FSwSx6pv%2FCrop-rec-with-Presets.png&hash=cf740f25f12a87d3b7a805c7234b15c5) (https://imgbb.com/)

1- 2.5K Expanded Preview: Experimental Real-Time Correct Framing Preview in x5 Mode, To be used in x5 Mode.
2- 2.5K Expanded Preview HDMI: Experimental Real-Time Correct Framing Preview in x5 Mode, To be used in x5 Mode when HDMI monitor is attached @ 1080i in FULL size Canon preview.
3- 1440p 1:1: 2560x1440 16:9 @ 23.976 FPS with Fixed Preview, To be used in x5 Mode.
4- 3K 1:1: 3072x1308 2.35:1 @ 23.976 FPS with Fixed Preview, To be used in x5 Mode.
5- 4.5K Anamorphic 1x3: 1x3 Binning 1504x1782 with 1.86 Crop factor ~2.50:1 @ 23.976 FPS with Correct (Un-Stretched) Preview, *To be used in x5 Mode.
6- 4K Anamorphic 1x3: 1x3 Binning 1360x1976 with 2.05 Crop factor ~2:1 @ 23.976 FPS with Correct (Un-Stretched) Preview, *To be used in x5 Mode.
7- UHD Anamorphic 1x3: 1x3 Binning 1280x2160 with 2.18 Crop factor 16:9 @ 23.976 FPS with Correct (Un-Stretched) Preview, *To be used in x5 Mode.
8- 1920x1280p 1:1 Preview: 1:1 1920x1280p @ 23.976 FPS with Correct Preview, To be used in x5 Mode.
*We are patching back x5 Mode to 1x3 Binning (Anamorphic Mode) to achieve the correct preview.

-Using 10/12 Bit-Depths in higher resolutions with crop_rec:
1-Always select 14-bit lossless from mlv_lite.
2-Go to crop_rec submenu by pressing Q button, Now you can see "Bit-Depth" option, Select 10 or 12, that's it.
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2F5YMhyQp%2FCrop-rec-Shutter-Range.png&hash=270c0a1edaaeedc5ef2984b01647e135) (https://imgbb.com/)

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FdQhb0xT%2FBit-Depths.png&hash=ef3520e640a5b6461ea9cb1d3082ffb9) (https://imgbb.com/)

-Full Shutter range allows you to get the lowest shutter speed and highest shutter speed possible with camera Hardware, down to 1/24 shutter speed, up to 1/36K shutter speed both @ 23.976 FPS.

New Crop mode module (crop_new) with Arbitrary Resolutions:
Instead of pre-made presets, this is the new version of crop_rec from a1ex (https://www.magiclantern.fm/forum/index.php?topic=19300.msg205546#msg205546), which allow you to select any preferred resolution, framerate and binning mode you want.

-How to use it?
Select "Pixel binning" mode, set your X resolution and Y resolution, set your desired Framerate option, press Menu button twice to apply the preset.
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FV97Mcdt%2FNew-crop-rec.png&hash=d944ec4431b2a49acb58b691e6f962aa) (https://imgbb.com/)

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FpQhhPPs%2FShowing-Pixel-binning.png&hash=c9b57829f736c4d8dcb98f892e79d18b) (https://imgbb.com/)

-Using 10/12 Bit-Depths in crop_new: I think you saw it already, remember you should always select 14-bit lossless from mlv_lite when using 10/12 Bit-Depths from here.
-You should always press Menu button twice for refreshing LiveView to apply the new settings, after changing them in crop_new "Crop mode V2", even when you turn off the module, you should press Menu button twice.
-You can create your Time-Lapses from this module in high resolutions, you can use FPS override too.
-x10 Mode will be valid for focusing, and won't be patched.
-This module doesn't include any recent preview fixes.

New Focus pixel maps for the previous presets:
Download it from 700D Focus Pixels Maps.zip (https://raw.githubusercontent.com/bilalfakhouri/magic-lantern/master/700D%20Focus%20Pixels%20Maps.zip), drag and drop them in MLVApp interface directly.

More info about:
-The Advantages of 1x3 Binning (https://www.magiclantern.fm/forum/index.php?topic=22818.0).

Download the New build: crop_rec_4k.2020Sep30.700D115.zip (https://raw.githubusercontent.com/bilalfakhouri/magic-lantern/master/crop_rec_4k.2020Sep30.700D115.zip)
Download the New build with re-solved Dual ISO ISOless 8 & 15 for some 700D users: crop_rec_4k.2020Sep30.700D115_ISOless_8_15.zip (https://raw.githubusercontent.com/bilalfakhouri/magic-lantern/master/crop_rec_4k.2020Sep30.700D115_ISOless_8_15.zip)
-Links are being updated for the Latest build and focus maps.

Great time for 700D users, Have fun :D
Original OP ended.


Then this Reply#1 (https://www.magiclantern.fm/forum/index.php?topic=25784.msg231067#msg231067) comes



Original Reply #2 started:
1. All presets are 23.976 fps. Can I change it to 25 via the menu option?
2. Can the 4.5k anamorphic mode resolution be changed? (I prefer going 2.35 ratio)

1 -Done
2- Done

New Build for 700D:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FtQvfjMf%2FNew-Preset.png&hash=64d30d182c58a71ff9b27563c310ab65) (https://imgbb.com/)

1- Added New 4.3K Anamorphic 1x3 Preset 1440x1836 1.94 Crop factor 2.35:1 AR with Correct Preview
2- Added option for 25 FPS in crop_rec
3- Added 9/8 Bit-Depths for both crop_rec and crop_new
4- In crop_new Now there is an Option for fixing Preview in x5 Mode Max X resolution should be 3112
5- Fixed Black Level in preview when using lower bit-depths 10/9/8 in crop_rec


(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FHXjSFYq%2F9-and-8-Bit-Depths-options.png&hash=c7c450f39a19c5630a321c4c2ec95386) (https://imgbb.com/)

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FXbgpFY3%2F25-FPS-option.png&hash=bde13845b7b046852bb49b41c2c95a28) (https://imgbb.com/)

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FznTBhrX%2FPreview-FIX-crop-new.png&hash=fea000c85cc1a6da34a52164bccc2bec) (https://imgbb.com/)

How to use this Build and more details about it:
https://www.magiclantern.fm/forum/index.php?topic=25784.msg231049#msg231049

Download the New build: crop_rec_4k.2020Sep30.700D115.zip (https://raw.githubusercontent.com/bilalfakhouri/magic-lantern/master/crop_rec_4k.2020Sep30.700D115.zip)
Download the New build with re-solved Dual ISO ISOless 8 & 15 for some 700D users: crop_rec_4k.2020Sep30.700D115_ISOless_8_15.zip (https://raw.githubusercontent.com/bilalfakhouri/magic-lantern/master/crop_rec_4k.2020Sep30.700D115_ISOless_8_15.zip)

New Focus Maps:
https://raw.githubusercontent.com/bilalfakhouri/magic-lantern/master/700D%20Focus%20Pixels%20Maps.zip
-Added 4.3K Anamorphic 1x3 Preset 1440x1836 map.
Original Reply #2 ended:
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Danne on September 21, 2020, 09:45:14 AM
Where do you publish crop rec code changes? Nice with 2.35:1.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on September 21, 2020, 10:04:16 AM
Thanks,
I didn't create another online repository after Bitbucket did what it did :P, Planning to use Heptapod and import the repository, not sure if this would work easily, I am doing it locally for now . .
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on September 23, 2020, 08:46:51 AM
I'm experiencing weird LCD screen artifacting with your latest build whilst utilizing the 2.5K expanded fixed preview crop mode preset.  Both the regular 2.5K and the HDMI 2.5K modes only fill up part of the LCD display while at the same time a pink color bar covers the bottom 1/3 or the LCD screen.   Framing seems correct in the actual footage shot, but the LCD display is just weird looking except for a skewed display of the actual correct framing preview that is offset to the upper left part of the LCD display.   Additionally, the pink color bar is sometimes replaced by an out of focus, pixelated portion of the subject in the frame.    Other times, the entire display seems to just go completely crazy with no discernible image at all, requiring a camera power down to reset it.   

This is normal, the bottom half of preview should be black, these artifacts are showing because there is no RAW data to show on the bottom of the preview, this can be controlled from Canon registers to cut this part and make it black, still working on it, Danne made Crop Marks for now to hide these artifacts, you can find it here:
https://bitbucket.org/Dannephoto/magic-lantern_jip_hop_git/downloads/crpmks_frtp.zip

Also I am working to add black bar baked in each preset directly, and without enabling Global Draw instead of changing it each time from Cropmarks.

Removed off-topic quoted from deleted posts //Audionut
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on September 23, 2020, 06:40:11 PM
Please read through the following article, which I mentioned many times earlier, also included in how use this build (https://www.magiclantern.fm/forum/index.php?topic=25784.msg231049#msg231049) some people are too lazy to read or understand, don't be like them, the article containing:
https://www.magiclantern.fm/forum/index.php?topic=25323.0

Introducing the New Expanded Real-Time preview in x5 Mode
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2F3FdsrpY%2FNew-Expanded-Preview.gif&hash=480115be87b05aa3b8ef67e3e2fd0aa1)
Known Limitations:
-Black Bar in the right instead of the right part of actual RAW data.

Notes:
-The Preview is in the Top Part of the screen, not centered on screen.
-You may compare ML Framing vs The New Preview to trust it.
-Turn OFF Global Draw for better Preview.
-Feel the responsive.
-Instead Normal of x5 Mode Preview? Wow!
-Still working on Black Bar limit.



Known Limitations:
-Black Bar in the right instead of the right part of actual RAW data.
Notes:
-The Preview is in the Top Part of the screen, not centered on screen.
-You may compare ML Framing vs The New Preview to trust it.

-Still working on Black Bar limit.


The artifacts are totally okay, Do you remember when we had the broken-pinkish preview in the initial crop_rec from a1ex:
* Canon preview is broken in most modes; you need to use the grayscale preview in the raw recording module.

It's the same thing here regarding Safety but in a different look, this preview still in Experimental Stage, don't use it if you are afraid, however many 700D, EOS M users have tried it, they pretty happy because they knew how to use it and they read this article before they used it:
https://www.magiclantern.fm/forum/index.php?topic=25323.0


-New build is coming soon containing:
1-All presets will support HDMI output with real-time correct preview.
2-You can ZOOM while recording to check focus instead of stopping recording, checking focus, starting over.
3- Black Bars instead of artifacts.
4-When you enable a preset, you will be automatically get into x5 Mode, to avoid crashes when you are enabling the presets on other modes.

Tidied this post up a little //Audionut
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on September 30, 2020, 10:58:22 AM
**Download links in the End of the post**

New Build for 700D

What's New:
-crop_rec:
1- When you enable any preset you will get into the right mode automatically, No more frozen LiveView or Camera crashes again (Stability :) ).
2- Autodetect HDMI support for the Real-Time presets, which means all presets works with HDMI now, no further selections needed.
3- Magic Zoom V2: Now you can use Magnification button or SET button to get zoomed preview to check focus, and this works while you are recording!
4- Better Centering for 3K preview.

-mlv_lite
1- Black Bar instead of preview artifacts.
2- Prevent using lower bit-depths for 3K and 1920x1280p presets, to avoid corrupted frames, use lower bit-depths in crop_rec submenu.

Autodetect HDMI
-The presets will only work with 1080i output! 720x480 or other outputs won't work.

Magic Zoom V2
-3K and 1440p presets aren't supported, you can use regular x10 mode.
-I had corrupted frames when using Magic Zoom V2 with HDMI monitor, don't use Magic Zoom V2 with HDMI monitor attached while recording.
-4K and UHD 1x3 Presets do have Magic Zoom V2, but with not perfectly centered preview or stretched zoomed preview, but it works for focusing.

Features:
-Nail your focus While recording!
-Works with All preset with real-time correct framing preview.
-You can trigger it by Zoom button or SET button on 700D and 650D.
-No overhead or slowness, didn't have corrupted frames during my tests (on camera LCD screen).
-Real-Time as Canon Preview, it's a Canon preview actually, but zoomed.
-Works with Global Draw OFF.
-It may work also with normal mv1080 Mode in theory, but didn't make a preset yet for this mode.

First Video showing Magic Zoom V2:

-To achieve better preview in real-time correct preview presets use this setting:
Go to ML Settings --> "Display" Tab --> Advanced settings --> Screen Layout --> "Bottom,under 3:2", Here is how it should look like:
https://www.magiclantern.fm/forum/index.php?topic=25323.msg231271#msg231271

How use this build and more Info about it: (Read all of them)
https://www.magiclantern.fm/forum/index.php?topic=25784.msg231049#msg231049
https://www.magiclantern.fm/forum/index.php?topic=25784.msg231134#msg231134
https://www.magiclantern.fm/forum/index.php?topic=25323.0

Download the New build: crop_rec_4k.2020Sep30.700D115.zip (https://raw.githubusercontent.com/bilalfakhouri/magic-lantern/master/crop_rec_4k.2020Sep30.700D115.zip)
Download the New build with re-solved Dual ISO ISOless 8 & 15 for some 700D users: crop_rec_4k.2020Sep30.700D115_ISOless_8_15.zip (https://raw.githubusercontent.com/bilalfakhouri/magic-lantern/master/crop_rec_4k.2020Sep30.700D115_ISOless_8_15.zip)

Download Focus Maps for All Presets: 700D Focus Pixels Maps.zip (https://raw.githubusercontent.com/bilalfakhouri/magic-lantern/master/700D%20Focus%20Pixels%20Maps.zip)

Source Code with All commits: magic-lantern_zoom_function.7z (https://drive.google.com/file/d/1ruoGs_mz3BLijqmxD2QI_DV_iqSicFkT/view?usp=sharing)
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Nigel95 on September 30, 2020, 08:53:56 PM
Amazing to see all the developments on this camera.

I have a few questions does the Eos m offer a lot more features than the 700d for magic lantern raw recording or quite similar now a days? I like the form factor of the 700d more and my EF-S collection fits directly on it.

Beside the 1,6 crop factor of the 700d. Are there any high quality raw recording modes with no additional crop on top of the 1,6? For example would I been able to use my canon 10-18 @ 10mm and get a 16mm equivalent look in any raw video modes? If it's possible at all, is the footage usable as I read that ultra wide angle lenses can suffer from aliasing.

Are there any higher frame rates than 25 for example 50 possible for raw video recording?

Is single autofocus by touch possible to grab focus?

Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on October 01, 2020, 05:08:47 AM
@Nigel95

Thanks,

EOS M and 700D are identical, same capability here and there regarding RAW recording yes, but I would prefer EOS M for Speed Booster support, and 700D for Flip Screen, if the size doesn't matter.

You can't have both 1.61 Crop Factor without aliasing. There are 1x3 Modes which solve aliasing problem but it has crop factors more than 1.61, or 1:1 modes which has a lot of cropping compared to 1x3 modes, also without aliasing.

There is 1x3 Mode which use full width sensor (1.61 Crop) which is 1736x2214 @ 23.976 FPS 2.35:1 AR you can achieve it by crop_new on 700D, however this mode isn't continuous even with the 240 MHz overclock and 10-bit lossless, you may lower the resolution to 1600x2040 @ 23.976 FPS 2.35:1 AR with 1.74 Crop to get continuous recording or You can stuck with 1736x2214 but lower framerate to @ 21 FPS to get continuous recording, However these two modes have stretched (not-correct) previews.

You can get 1736x868 3x3 2:1 AR @ 50 FPS, not continuous, (or 1736x738 2.35:1 @ 48 FPS this would be continuous @10-bit lossless) and with stretched preview. Or you can use the regular 5x3 Mode from Canon which have a lot of aliasing and Moire 1736x522 (1736x868 After stretching) 2:1 AR @ 50 FPS, this one is continuous with correct preview.

Autofocus by touch screen is possible, but the autofocus system is not that good on both EOS M and 700D. Autofocus won't work with the real-time correct preview 1x3 presets or x5 Mode.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: AllWashedOut on October 06, 2020, 10:18:16 PM
Thanks for the new features. Very interesting.

I'm using my 700d for streaming (using the HDMI output). I do not record to the SD card. Do settings like high resolution or dual-iso now have any benefits for HDMI output, or only for the video recorded to SD?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Morfeus77 on October 08, 2020, 02:53:04 PM
Hi to everyone , thanks for you hard work. About 48fps record I have some dudes. Please can someone post the steps for a right configuration. Should I change the resolution in canon menu? Thanks for your attention
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: SubZeroz on October 09, 2020, 04:13:42 PM
Very Cool!

I'm using an Android phone as a screen and found some issues when using this version with HDMI:
(I'm using the 4.3k preset)
1.  In order to get HDMI to work, I need to press the 'info' once, otherwise no image is being updated
2. Sometimes there's a strange and wierd flickering on the sides
3. Focus Peaking doesn't work, just shows lots of noise at the bottom
4. Probably not related to HDMI - I can't set the shutter speed. It's stuck at 1/26 and ignores my cannon shutter speed. I've tried going into the ML menu and change it but I can only change the 'TV' which doesn't seem to affect the shutter?


Because of '2' and '3' I Decided to also check this in Danne's Build listed above.

I've built (Based on source code online with some changes) a small Android app that gets HDMI input and stretches it. The result is actually pretty cool:

Camera:

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.imgur.com%2FPKYZLz1.png&hash=816c752439ab38c93519d2b3acbd2d71)

Vs Phone (6.1 inch):

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.imgur.com%2FYKTK8n8.png&hash=fe26ac5f69977091df72bcbf75a08165)


It seems like Danne's build also has issues with the HDMI:
1. Focus Peaking doesn't work here aswell
2. After recording, I've checked the videos in my computer. it seems like every few seconds there a PINK corrupted frame. This doesn't happen If i record without HDMI.


Any idea how to fix the Focus Peaking & Shutter?

Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Danne on October 09, 2020, 05:01:34 PM
Are you using what code for what cam? Will you share your android app source and application? Would be nice to test it out.
I tested hdmi with eos m and seems to work fine. Try 24 fps and see if that clears corrupted frames.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: SubZeroz on October 09, 2020, 06:52:38 PM
Using this build: https://bitbucket.org/Dannephoto/magic-lantern/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Apr02.700D115.zip
for 700d.

I've tried changing to 24 fps but with no luck :\ Perhaps the HDMI to USB recorder i'm using is causing some issues, But thats a bit strange...


Is there any place I can access the source of that build?

____


The app is based on:
https://github.com/jiangdongguo/AndroidUSBCamera
which is based on some other repo...
I've mostly deleted lots of stuff and added the stretch code.

Currently It only stretches to support 2.35 ratio, and there's some code-mess.
If you'll still wish to get the source before I make some order & clean up I'll create a repo and upload it.

Here is a link to the APK:
https://drive.google.com/file/d/1MOXTtCjS4b0XovfBStPua7nu2Q3pLccD/

1. I've looked at the other git repos, and from a quick look - it seems O.K, but that code was not written by me, so use this app at your own risk :-)
2. Tested it on my phone screen ratio, I have no idea how it would look on your screen (Would appericiate a screenshot though).
3. My phone is running Android 9
4. If people need this I can add other stuff such as choosing the desired ratio etc'


How to install:
allow install apk from unknown sources

Run:
Simply run the app. It would show a blank black screen. Once you plug in the otg cable it would tell you it has recognized the camera.
The best camera liveview mode is the last one (by clicking 'info'), but any should work.
In Bilal's build only the second preview works. The first doesn't show any image.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Danne on October 09, 2020, 07:02:58 PM
Cool. I think I'll wait for a cleaned up build though  :P.
Regarding shutter speed it's probably related to shutter blanking. theBilalFakhouri is aware about that so hopefully he will take a look.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: SubZeroz on October 10, 2020, 12:42:06 PM
Cool. I think I'll wait for a cleaned up build though  :P.
Regarding shutter speed it's probably related to shutter blanking. theBilalFakhouri is aware about that so hopefully he will take a look.

Uploaded it here:
https://www.magiclantern.fm/forum/index.php?topic=25406.0
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on October 10, 2020, 01:55:38 PM
Very Cool!

I'm using an Android phone as a screen and found some issues when using this version with HDMI:
(I'm using the 4.3k preset)
1.  In order to get HDMI to work, I need to press the 'info' once, otherwise no image is being updated
2. Sometimes there's a strange and wierd flickering on the sides
3. Focus Peaking doesn't work, just shows lots of noise at the bottom
4. Probably not related to HDMI - I can't set the shutter speed. It's stuck at 1/26 and ignores my cannon shutter speed. I've tried going into the ML menu and change it but I can only change the 'TV' which doesn't seem to affect the shutter?


1- Yes, you should be in Full Canon preview when you are using HDMI with Real-Time Correct Preview presets, you can toggle between full canon preview and small preview by pressing INFO button.
2- I had flickering on sides problem in the official builds too, this problem not related to this build exclusively, it's related to mlv_lite, also to crop_rec with the new presets, nothing to do, you can get rid of it by pressing Menu button twice or refresh LiveView.
3- Yeah, Focus peaking isn't working fine when using HDMI, this problem are there in the official builds too, not related to this build, no idea how to fix it.
4- I don't have this problem, any steps to reproduce the problem? can you explain more what settings are using and mode etc.. ?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: SubZeroz on October 10, 2020, 02:31:02 PM
1- Yes, you should be in Full Canon preview when you are using HDMI with Real-Time Correct Preview presets, you can toggle between full canon preview and small preview by pressing INFO button.
2- I had flickering on sides problem in the official builds too, this problem not related to this build exclusively, it's related to mlv_lite, also to crop_rec with the new presets, nothing to do, you can get rid of it by pressing Menu button twice or refresh LiveView.
3- Yeah, Focus peaking isn't working fine when using HDMI, this problem are there in the official builds too, not related to this build, no idea how to fix it.
4- I don't have this problem, any steps to reproduce the problem? can you explain more what settings are using and mode etc.. ?

Hi!
I've also replied at the other thread.

1. O.K, just wanted to let you know
3. Yes, as I wrote in that post - It didnt work on Danne's build aswell :-(, I Hoped that mybe you have any clue about this.
4. Do you simply change the shutter speed from the main screen while in Manual mode? its number has red color, and when I go to the Magic Lantern menu it is stuck at 1/26.
Perhaps I should just ignore what's written in the ML menu?
Is there any way to check in-camera the REAL shutter speed?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on October 10, 2020, 02:53:11 PM
3- I don't use focus peaking personally, I will let you know if I get any clue about how to solve it and I will try too . .

4- Tried your steps, shutter speeds are working fine in all presets, and both from ML and Canon menu shutter speed is showing correctly . .
You don't need to ignore what's written in ML menu, this problem is fixable I had something like that in the past . . Let's debug the problem first:

I think your camera are using different addresses for shutter blanking, Does Danne's build have the same shutter speed issue?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: SubZeroz on October 10, 2020, 03:05:05 PM
3. Thanks!
4. In Danne's build its working perfectly. How can the addresses be different? Aren't we running the same 1.1.5 Firmware?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on October 10, 2020, 03:33:42 PM
My theory is correct, in my build, I am using these addresses:
Code: [Select]
#define FRAME_SHUTTER_BLANKING_ZOOM   (*(uint16_t*)0x40452d18) // ADTG register 805f
#define FRAME_SHUTTER_BLANKING_NOZOOM (*(uint16_t*)0x40452d1c) // ADTG register 8061
#define FRAME_SHUTTER_BLANKING_READ   (lv_dispsize > 1 ? FRAME_SHUTTER_BLANKING_NOZOOM : FRAME_SHUTTER_BLANKING_ZOOM) /* when reading, use the other mode, as it contains the original value (not overriden) */
#define FRAME_SHUTTER_BLANKING_WRITE  (lv_dispsize > 1 ? &FRAME_SHUTTER_BLANKING_ZOOM : &FRAME_SHUTTER_BLANKING_NOZOOM)

in Danne build he is using these addresses:
Code: [Select]
#define FRAME_SHUTTER_BLANKING_ZOOM   (*(uint16_t*)0x40452918) // ADTG register 805f
#define FRAME_SHUTTER_BLANKING_NOZOOM (*(uint16_t*)0x4045291c) // ADTG register 8061
#define FRAME_SHUTTER_BLANKING_READ   (lv_dispsize > 1 ? FRAME_SHUTTER_BLANKING_NOZOOM : FRAME_SHUTTER_BLANKING_ZOOM) /* when reading, use the other mode, as it contains the original value (not overriden) */
#define FRAME_SHUTTER_BLANKING_WRITE  (lv_dispsize > 1 ? &FRAME_SHUTTER_BLANKING_ZOOM : &FRAME_SHUTTER_BLANKING_NOZOOM)

Try this build, added Danne addresses:
https://drive.google.com/file/d/11v53g04TANxRxDOS9HfI_aNqPa7HfVpA/view?usp=sharing

4. In Danne's build its working perfectly. How can the addresses be different? Aren't we running the same 1.1.5 Firmware?
This something related when Canon firmware copies something from ROM to RAM, explained by a1ex here:
https://www.magiclantern.fm/forum/index.php?topic=25976.msg231177#msg231177 (a1ex was talking about Dual ISO problem, same thing applies here regarding why we are having shutter blanking issue and different addresses)
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: SubZeroz on October 10, 2020, 07:58:23 PM
Tried it now - WORKS GREAT!!!! Thanks!

Also, You are correct, the preview colors look better.

Couple of questions:
1. Are you going to change the position of the liveview? (Like - putting it in the center?), I need to know because I plan to change the Android-App to stretch the image to the entire screen, removing the black edges (Bigger image, No flickering or black!).

2. Out of 60 seconds 3 seconds with pink flickering. Its not only in ur build, it also happened in Danne's build. Does this happen because the camera CPU is under heavy usage? (This doesnt happen in NON-HDMI), Lowering the resolution should fix it?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Danne on October 10, 2020, 08:13:13 PM
Are you still running 25fps regarding pink frames? On Eosm I only tested 24fps but no pink frames. Also had reports from another user hdmi working with no pink frames.
Moving the full live view content to centre is not trivial.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: SubZeroz on October 10, 2020, 08:23:56 PM
Yes, still going 25fps because 24fps didnt fix it  :'(

Anyways, no need to move the liveview now, I did the following in the Android-APP:

1. Stretch HDMI-INPUT to the bottom & to the sides
2. move the entire INPUT down

Result (Screenshot from my phone):
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.imgur.com%2FK4Ob3tr.png&hash=e0865f30ec2b7ad5555c75bbe71637cf)

Only problem is that u cant see current shooting configuration. Perhaps I'll slice the bottom (Which isn't on the screen) and paste it.
Not sure how much work this is 
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Danne on October 10, 2020, 08:29:32 PM
Cool.

What preset? 16:9? Are the other ones working better?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: SubZeroz on October 10, 2020, 09:59:57 PM
Cool.

What preset? 16:9? Are the other ones working better?

2.35:1

I didn't push it to the git yet, a local repo (So what I've published earlier should work anyway).

All Presets are working great, I just wanted to see it on my entire phone-screen.

The problem was that in that build, the fixed liveview contains a rect at the top of the screen with the real image, so I've pulled it down to the center, and then scaled it to fit my entire screen.
I need to slice the configuration (shutter etc') from the bottom, because its out of the screen, thanks to the changes above :-)
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Danne on October 10, 2020, 10:36:23 PM
I see. So corrupted frames occur with 2.35:1.

I checked 700D sources. in crop_rec.c there´s this for 2.35:1 preset:
Code: [Select]
        case 0xC0F06804: return 0x748018A;

        case 0xC0F06010: return 0x1C9;
        case 0xC0F06008: return 0x1C901C9;
        case 0xC0F0600C: return 0x1C901C9;

        case 0xC0F0713c: return 0x755;

You could try changing C0F0713c to the same as beginning of 0x748. So change it to:
Code: [Select]
        case 0xC0F0713c: return 0x748;If still getting pink frames you could increase timer regs:
Code: [Select]
        case 0xC0F06010: return 0x1C9;
        case 0xC0F06008: return 0x1C901C9;
        case 0xC0F0600C: return 0x1C901C9;
This means you´ll gonna have to decrease reg 6014 to compensate back to 24 or 25 fps.


My preset in eosm code look like this as comparison example:
Code: [Select]
        case 0xC0F06804: return 0x748018A + reg_6804_width + (reg_6804_height << 16);
        case 0xC0F06014: return 0x8ec + reg_6014;
        case 0xC0F0600c: return set_25fps ? 0x2470247 - 24 + reg_6008 + (reg_6008 << 16): 0x2470247 + reg_6008 + (reg_6008 << 16);
        case 0xC0F06008: return set_25fps ? 0x2470247 - 24 + reg_6008 + (reg_6008 << 16): 0x2470247 + reg_6008 + (reg_6008 << 16);
        case 0xC0F06010: return set_25fps ? 0x247 - 24 + reg_6008: 0x247 + reg_6008;
        case 0xC0F0713c: return 0x755 + reg_713c;

I think increasing timer registry around the same as on eosm should do the trick:
Code: [Select]
        case 0xC0F0600c: return 0x2470247;
        case 0xC0F06008: return 0x2470247;
        case 0xC0F06010: return 0x247;
        case 0xC0F06014: return 0x8ec;
        case 0xC0F0713c: return 0x755;
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on October 11, 2020, 12:15:53 PM
Couple of questions:
1. Are you going to change the position of the liveview? (Like - putting it in the center?), I need to know because I plan to change the Android-App to stretch the image to the entire screen, removing the black edges (Bigger image, No flickering or black!).

2. Out of 60 seconds 3 seconds with pink flickering. Its not only in ur build, it also happened in Danne's build. Does this happen because the camera CPU is under heavy usage? (This doesnt happen in NON-HDMI), Lowering the resolution should fix it?

1- Unfortunately it's not a simple task, LiveView is very complex, we can't control this part yet, it may take weeks or months to achieve this, it won't be any time soon.

2- During my previous tests I didn't get corrupted frames in 1x3 Modes with the correct previews, I will make more tests in future, in other normal modes like 1080p or 2.5K I got some corrupted frames, it's an overhead yes when the output is 1080i which affects all builds, changing HDMI output to 720x480 probably would solve this problem, not sure how 720p output would perform.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on October 11, 2020, 12:51:04 PM
It seems I missed two replies here.

Thanks for the new features. Very interesting.

I'm using my 700d for streaming (using the HDMI output). I do not record to the SD card. Do settings like high resolution or dual-iso now have any benefits for HDMI output, or only for the video recorded to SD?

You're welcome

HDMI output won't be benefited from these modes regarding quality also Dual ISO (which needs to be processed in post, otherwise if you used it in streaming you will get lines in the image), as you said you will get the benefits from these modes only when recording RAW data to SD card, the best Mode for streaming using HDMI is the normal 1080p.

Hi to everyone , thanks for you hard work. About 48fps record I have some dudes. Please can someone post the steps for a right configuration. Should I change the resolution in canon menu? Thanks for your attention

Hello, thanks

Set video mode to 720p @ 60 FPS (NTSC) from Canon Menu, then enable "Crop mode V2" and do the following:
https://i.ibb.co/NSGfybb/3x3-48-FPS.png (https://i.ibb.co/NSGfybb/3x3-48-FPS.png)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fi.ibb.co%2FNSGfybb%2F3x3-48-FPS.png&hash=10a63ce46884cce388d181dc69bf20bb)

Then press Menu button twice to apply the new settings, this will give 1736x868 2:1 AR @ 48 FPS in 3x3 Binning mode, the preview would be stretched!
- You can increase Y resolution more, but you may get corrupted frames.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Danne on October 11, 2020, 01:45:38 PM
2- During my previous tests I didn't get corrupted frames in 1x3 Modes with the correct previews,
Do try my last suggestion. Also match 713c with 6804. Typically what will solve pink frame issues.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: SubZeroz on October 11, 2020, 10:22:51 PM
Thanks Danne.

Bilal is there any chance you'll test this?

I'll get an environment ready to compile but it would take me some time.

_______________________________________

I Have a special version of the Android App which should suites the last build.
In this one when you open the App you'll see the same screen as the Camera LiveView, but when you'll single-press the screen it would enlarge only portion of the screen - where the real image is (And not black edges etc')

I Currently use this with HDMI-INPUT 1920x1080, and 4.3k preset. I'm not sure how this will look with the other modes.

But it's really cool that you can see a big preview :-)

https://drive.google.com/file/d/1lGLnwsvirNw-rz3AAu5oJS0ZvhWwNOlY
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: IBIRRU on October 14, 2020, 03:16:00 PM
Hi Bilal, is it possible to add a preset for "full resolution liveview 1:1) in your custom crop_rec module for 700D?

I tried to use crop_rec new but the preview in 5x is not usable and it stop working immediately after the start also if I reduce fps to 4.

I would try to take a video of the full moon at 1600 mm of FL to obtain a "mineral moon" picture.

Thanks for your great work

Fabio
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Morfeus77 on October 16, 2020, 05:03:20 AM
It seems I missed two replies here.

You're welcome

HDMI output won't be benefited from these modes regarding quality also Dual ISO (which needs to be processed in post, otherwise if you used it in streaming you will get lines in the image), as you said you will get the benefits from these modes only when recording RAW data to SD card, the best Mode for streaming using HDMI is the normal 1080p.

Hello, thanks

Set video mode to 720p @ 60 FPS (NTSC) from Canon Menu, then enable "Crop mode V2" and do the following:
https://i.ibb.co/NSGfybb/3x3-48-FPS.png (https://i.ibb.co/NSGfybb/3x3-48-FPS.png)

(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fi.ibb.co%2FNSGfybb%2F3x3-48-FPS.png&hash=10a63ce46884cce388d181dc69bf20bb)

Then press Menu button twice to apply the new settings, this will give 1736x868 2:1 AR @ 48 FPS in 3x3 Binning mode, the preview would be stretched!
- You can increase Y resolution more, but you may get corrupted frames.


Thanks a lot for the explanation, I'll will try now.
Good job
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: alt1 on November 02, 2020, 04:39:54 PM
deleted.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: alt1 on November 05, 2020, 03:30:36 PM

New Focus Maps:
https://raw.githubusercontent.com/bilalfakhouri/magic-lantern/master/700D%20Focus%20Pixels%20Maps.zip
-Added 4.3K Anamorphic 1x3 Preset 1440x1836 map.

Sorry, but I don't see 1440x1836 map in this archive. The latest map here is from 2018 year.
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fsupervid.ru%2F700d_focus_maps.jpg&hash=a84295742ef3efffdaa9e8a59117c803)
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on November 05, 2020, 05:30:51 PM
In focus pixel maps we are calculating the black areas too, so:

Naming of focus pixel map  RAW resolution
Naming of focus pixel map  > RAW resolution

In your case the map you are looking for is "80000326_1512x1864.fpm", extract all the focus pixel maps in MLVApp folder, you should be fine in all crop_rec presets automatically.

-You can also use the latest MLVApp which can download all the required focus maps automatically too, or you can drag and drop the focus maps from the archive into MLVApp interface, and this will install the focus maps in MLVApp.

Original focus map created in 2018 which covers all focus pixels on the sensor, and we are using the same map for all 1x3 Binning modes (I am duplicating it), remaining thing is to identify which RAW resolution we are using now and calculate the offsets for current resolution (to match the focus pixel map with MLV file), and we can achieve this by just changing the naming of the focus pixel map to include RAW resolution + black areas, in this case the focus pixel map date will stay 2018 (renaming won't affect the date).
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: alt1 on November 05, 2020, 05:51:19 PM
New Focus Maps:
https://raw.githubusercontent.com/bilalfakhouri/magic-lantern/master/700D%20Focus%20Pixels%20Maps.zip
-Added 4.3K Anamorphic 1x3 Preset 1440x1836 map.
[/quote]

Unfortunately, with 650D after extracting files into MLVAPP folder when I record 1440x1836 I have focus dots
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fsupervid.ru%2Ffocus_dots_1440.jpg&hash=9706df9a5d4b941943f9a373d2eb2f4a)
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on November 05, 2020, 06:38:28 PM
Ah, I thought you are using 700D (Why not to post on 650D thread?)

Mostly all 700D focus pixels maps are identical to 650D too, in this case you need only to change the ID in focus pixel map files from 700D ID to 650D ID; from "80000326" to "80000301":

Just did it for all focus pixel maps, try these focus maps for 650D (It should work with all crop_rec presets using my 650D build):
650D Focus Pixels Maps.zip (https://github.com/bilalfakhouri/magic-lantern/raw/master/650D%20Focus%20Pixels%20Maps.zip)

Please let me know if these work for 650D in all presets.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: alt1 on November 05, 2020, 06:53:33 PM
Thank you very much theBilalFakhouri. All presets work fine now. Except these presets I use also not registered " 1736*696 1x1  48fps" from new Crop_Rec V2 menu and it has focus dots. Is it simple to create focus map for this preset?
 
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on November 07, 2020, 04:00:41 PM
You're welcome

Please provide short MLV sample for the mode you are using, you can cut it in MLVApp, two frames are enough, export it as MLV (fast pass)

I can make a simple tutorial about how to generte focus pixel map for any resolution (using Crop rec V2) for both 1x3 and 1x1 modes.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on November 07, 2020, 04:15:42 PM
Hi Bilal, is it possible to add a preset for "full resolution liveview 1:1) in your custom crop_rec module for 700D?

I tried to use crop_rec new but the preview in 5x is not usable and it stop working immediately after the start also if I reduce fps to 4.

I would try to take a video of the full moon at 1600 mm of FL to obtain a "mineral moon" picture.

Thanks for your great work

Fabio

Sorry for the delay, I didn't use full resolution LiveView much in the past, so I spent some weeks playing with it.

I am preparing for a new build which solve ML Framing in x5 mode, and also added custom FPS in crop_new, this will allow using the full shutter speed in any framerate, from 360° to 1° angles.

Adding full resolution LiveView preset in crop_rec won't perform any better from crop_new, Canon preview would be broken in both modules, in this case you should use ML Framing (which has a problem currently in my latest build, fortunately I fixed it now, will realease a new build soon)

Guess what: Full resolution LiveView = 5208x3478 @ 5 FPS is continous in 12-bit lossless  :) , of course when using 240 MHz overclock. More info coming soon.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: IBIRRU on November 09, 2020, 02:28:36 PM
Great news !!

Many thanks Bilal!! :D

I will wait the next relaease.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: pteichner on November 11, 2020, 08:18:27 PM
Hey guys, could you point me to the latest mostly stable build that included the sd_uhs mod please. Also what can you achieve on the 700D? Is 240MHz stable? It's been working on on my 6D, need a B-roll camera and I've got a 700D lying around.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: CameraGobbl on November 25, 2020, 04:20:37 AM
Wondering if someone can help me.

I studied and was into filmmaking about a decade ago, and am looking to get back into it. First off, though, I want to get better at photography, so I'm in the market for a very cheap but capable DSLR, and I'm looking at used Rebels and I might be able to get a pretty good deal on a 700D.

I'm also quite interested in using this camera as a low budget cinema camera down the line with ML, though I know it takes a bit of learning and tweaking. I'm fine with that. I've seen some great images come out of both the EOS M and the Canon 700D using ML RAW. The RAW excites me because more than 4k, what I want is something with no compression and higher dynamic range and bit depth. But I'm not completely sure of the 700D's capabilities with ML, so let me just ask some quick questions.

1. Since the EOSM and 700D have the same sensor and processor, can the 700D create the same quality of video I see on EOS M videos like from Zeek's channel?

2. I know ML won't work miracles. I don't care about true 4k or slow mo. But I'd like something stable, RAW, and around 1080p true resolution (I want to shoot 4:3 too, so 1440 x 1080 would be great).

tl;dr- I'm looking for a very cheap camera that I can practice photography on as well as shoot decent video with ML. RAW 1080p with a minimum crop to avoid aliasing (2x would be fine) is essentially what I am aiming for, and was just wondering if the 700D could do all this. If not, I might just go for a cheaper option like a used t2i.

Thanks
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: AllWashedOut on November 29, 2020, 05:55:39 AM
Could you add the option to disable 30-minute live view timeout? It's present in the 700D "Lua Fix" builds. Or perhaps it's just been renamed in this build?

Original name: Prefs tab -> "Powersave in Liveview" -> "30-minutes timer"
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Walter Schulz on December 09, 2020, 09:10:36 AM
Add to which build? What is "this build"?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: lightwriter on December 12, 2020, 01:37:44 AM
@theBilalFakhouri

Hi there!

I have a Canon 700D and a SanDisk Extreme Pro 95MB/s SDHC V30 speed class U3 32GB. Is SD Overclock at 192Mhz stable with this card?

You referred the 1x3 Mode which can be used with this configuration: 1600x2040 @ 23.976 FPS 2.35:1 AR. How can it have a 2.35 aspect ratio with  a resolution of 1600x2040? Does it have to edited in MLV app to get the correct aspect ratio?

Does the 1x3 Mode get rid of the aliasing?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on December 12, 2020, 04:34:10 AM
Hello @lightwriter

Yes, 192MHz overclock is stable for Sandisk Extreme PRO 95MB/S  cards, you need to do low level format in the camera at least for once, this prevent speed drops if it were there.

You can get 1x3 1600x2040 in crop_new (Crop mode V2):

Set Binning mode to 1x3, Y resolution to 2040, FPS to 23.976, keep X resolution as default (zero)

Press Menu button twice for refreshing LiveView to apply our new settings, from mlv_lite set the resolution to 1600, Aspect ratio to 2.35:1, now you should be okay, check the resolution from mlv_lite (RAW video)

MLVApp would read the file as 1x3 Binning, and would stretch the footage automatically --> So the stretched resolution from 1600x2040 file would be after stretching 4800x2040, now it's 2.35:1 AR

The Preview would be stretched in LiveView, there is no real-time correct preview in this mode, you want to use ML Framing to check framing.

Yes there is no aliasing in 1x3 Binning, this is the huge advantage for this mode! also 1x3 Binning reduces moire patterns a lot.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: AlexPace on December 12, 2020, 08:58:53 AM
Is it possible to get a full 16:9 ratio over the HDMI output without the black vertical sidebars at any resolution?  I mean straight out of the camera without processing.  I know the T5i can't do a full-screen 1080i, but stretching or cropping with OBS software introduces some lag that is awkward on Zoom calls.

Note: I tried Canon's EOS WebCam software that uses USB instead of HDMI but the frame rate was way too low for reasonable Zoom calls.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: lightwriter on December 12, 2020, 12:53:09 PM
Hello @theBilalFakhouri

Thank you very much for your detailed answer!
Unfortunately, I followed all your steps but it stops recording the instant I begin, and the frames are corrupted.

In RAW video I selected 1600, but when I go to Crop mode V2, I didn't change X resolution, but it says 1736. What bit depth should I select in Crop Mode V2? Or should it be off? And in RAW video, I chose 12 bit lossless; is this the way to go?

At the bottom, it says in yellow that it will record at 64MB/s, 0x5.4MB, 23.982 (49%). Expect around 0 frames at 56.3MB/s.

Pressing Menu button twice, the resolution of Crop mode V2 shows 1736x2040 1x3, RAW video shows 1600x2040 1.74x and SD Overclock is at 192MHz

I did low level format in the original canon menu when formatting.

What am I doing wrong? Sorry for the trouble.

P.S.: Would the Sandisk Extreme Pro 170MB/s V30 be a better choice by allowing 240MHz?

P.P.S.: In Benchmark, with SD Overclock at 192MHz I'm getting write speeds of about 54 MB/s...it's on the low side, no?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: aserranojr on December 12, 2020, 03:57:17 PM
Hi guys, thank you for this wonderful forum. I am a new ML user. I apologize in advanced if this question is given already. I did search the forum but am having a hard time finding the answer. Is the Eos 700D able to shoot in 50fps in 1080p? I really need to know this. Thank you so much in advance. :)
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on December 13, 2020, 04:09:24 AM
Is it possible to get a full 16:9 ratio over the HDMI output without the black vertical sidebars at any resolution?  I mean straight out of the camera without processing.  I know the T5i can't do a full-screen 1080i, but stretching or cropping with OBS software introduces some lag that is awkward on Zoom calls.

Note: I tried Canon's EOS WebCam software that uses USB instead of HDMI but the frame rate was way too low for reasonable Zoom calls.

Unfortunately clean HDMI output (without the black bars on both sides) from 700D/T5i isn't possible, I was doing some experiments regarding these black bars, I got promising results, you can see here (first post, the HDMI experiment):
https://www.magiclantern.fm/forum/index.php?topic=25287.0

So I think implementing clean HDMI output on T5i is possible and we know where to start, but currently I am unable to continue experimenting, lack of time, sorry.


@lightwriter

You're welcome!

When I mentioned 1600x2040 preset, I think here:

There is 1x3 Mode which use full width sensor (1.61 Crop) which is 1736x2214 @ 23.976 FPS 2.35:1 AR you can achieve it by crop_new on 700D, however this mode isn't continuous even with the 240 MHz overclock and 10-bit lossless, you may lower the resolution to 1600x2040 @ 23.976 FPS 2.35:1 AR with 1.74 Crop to get continuous recording ..

To achieve continuous recording you need to use 10-bit lossless, and you need the 240 MHz overclock (with Sandisk Extreme PRO 170 MB/s card)

In RAW video I selected 1600, but when I go to Crop mode V2, I didn't change X resolution, but it says 1736.

Yes, This seems correct, keeping X value to zero will give the default X resolution which is 1736 in grey color.

What bit depth should I select in Crop Mode V2? Or should it be off?

For continuous recording, you need to select 10-bit from "Crop mode V2" , and keep it 14-bit lossless from "RAW video".

At the bottom, it says in yellow that it will record at 64MB/s, 0x5.4MB, 23.982 (49%). Expect around 0 frames at 56.3MB/s.

You will need to use 10-bit from "Crop mode V2" to lower the data rate, also you will need 240 MHz overclock which gives up to 68 MB/s write speed in video mode, 192 MHz is limited to ~55 MB/s maybe a little more which won't give continuous recording in this mode . .

Pressing Menu button twice, the resolution of Crop mode V2 shows 1736x2040 1x3, RAW video shows 1600x2040 1.74x

Yes, this seems correct too, recording at this stage (after pressing Menu button twice) would allow you to record some seconds without corrupted frames, right?

I did low level format in the original canon menu when formatting.

What am I doing wrong? Sorry for the trouble.

P.S.: Would the Sandisk Extreme Pro 170MB/s V30 be a better choice by allowing 240MHz?

P.P.S.: In Benchmark, with SD Overclock at 192MHz I'm getting write speeds of about 54 MB/s...it's on the low side, no?

Everything you are doing is correct actually, but you will need the 240 MHz overclock with 170 MB/s Sandisk Extreme Pro and 10-bit depth from "Crop mode V2" for continuous recording, the 192 MHz benchmarks looks okay too if you did the benchmark in video mode, try running benchmark in PLAY mode, run benchmark and press PLAY button; this should give you ~80 MB/s write and read speeds.

Have you managed to get some clips without corrupted frames in this mode?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: lightwriter on December 13, 2020, 01:24:24 PM
Hello again @theBilalFakhouri!

Thank you so much for your detailed and easy to follow answer.

I ran the benchmark in play mode and you were right; I'm getting read speeds of 85.6MB/s and write speeds of 79.6MB/s.

Most of my clips over around 10-14 seconds; however, I managed to record one clip with approximately 1 minute of duration. I don't know how this happened, but it was the exception.

1 - I recorded 5 clips - two of the shorter ones don't have any problem; the other two short ones have a lower horizontal stripe corrupted (around 80-100 pixels height, perhaps?), and the longer clip was fine. What can I do to prevent the horizontal corrupted band? Here is one example of a corrupted frame: https://imgur.com/BLhAOr3 (https://imgur.com/BLhAOr3) - all these clips were recorded at 192MHz overclock.

2 - You talked about using ML Framing to check framing. I've searched the options but I can't find it...could you point me to the right direction?

3 - The Sandisk Extreme PRO 170MB/s card you talked about is this one, right?: https://www.amazon.es/SanDisk-Extreme-Pro-Tarjeta-Memoria/dp/B07H9J1YXN/ref=sr_1_1?__mk_es_ES=%C3%85M%C3%85%C5%BD%C3%95%C3%91&dchild=1&keywords=Sandisk+Extreme+PRO+170+MB%2Fs+64&qid=1607862081&quartzVehicle=74-902&replacementKeywords=sandisk+extreme+pro+mb%2Fs+64&sr=8-1 (https://www.amazon.es/SanDisk-Extreme-Pro-Tarjeta-Memoria/dp/B07H9J1YXN/ref=sr_1_1?__mk_es_ES=%C3%85M%C3%85%C5%BD%C3%95%C3%91&dchild=1&keywords=Sandisk+Extreme+PRO+170+MB%2Fs+64&qid=1607862081&quartzVehicle=74-902&replacementKeywords=sandisk+extreme+pro+mb%2Fs+64&sr=8-1)

4 - In MLVapp, in order to export with the correct aspect ratio, I inserted the values of 2400 by 1020 - this method works, but is it the best one?

5 -  Several users posted images of benchmarks with the 170MB/s card, 240Mhz. One user showed the first write speed being high - 66.7MB/s, but the second one reaching only 51.8MB/s. This happened with a EOS M, in movie mode. Are those values normal? https://www.magiclantern.fm/forum/index.php?topic=12862.625 (https://www.magiclantern.fm/forum/index.php?topic=12862.625) - bottom of the page.
In this video: https://www.youtube.com/watch?v=tm1pFNRIlcI&feature=emb_logo&ab_channel=Zeek. (https://www.youtube.com/watch?v=tm1pFNRIlcI&feature=emb_logo&ab_channel=Zeek.), by the 2.14 minutes mark, with an EOS M, using a 64GB 170MB/s card the results were as follow: write speed: 20.4MB/s

6 - In normal situations, the shutter speed appears as N/A (I can change the shutter speed but I can't see the value), even if in Crop mode V2 I activate Full range in Shutter range. If, in the Movie tab, I select FPS override, then it shows a value of 0,4'', but I can't change it. What's the solution?

Thanks again for your help!
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on January 04, 2021, 11:49:15 PM
@lightwriter

Hi again!

1- This corruption due to un-refreshed LiveView, to prevent this:
-You should always press Menu button twice for refreshing LiveView to apply the new settings, after changing them in crop_new "Crop mode V2", even when you turn off the module, you should press Menu button twice.

Also when you startup the camera and if crop_new was already ON you need to refresh LiveView manually!

2- In mlv_lite submenu --> Preview --> Framing

3- Yeah, that's what I am using

4- ?

MLVApp corrects aspect ratio automatically for you, you don't need to change anything regarding resolution. The output would be correct.

5- EOS M has some problems with 240 MHz overclock it doesn't work fine on this camera even with 170 MB/s Sandisk Extreme PRO cards (except one card: Sandisk Extreme PRO 170MB/s with 512 GB Capacity) , doing a "Low Level Format" would fix the speed drop issue e.g: from 66.7 MB/s to 51.8 MB/s -- these things have been discussed before in this topic (https://www.magiclantern.fm/forum/index.php?topic=12862.0).

6- This issue has been discussed here  (https://www.magiclantern.fm/forum/index.php?topic=25784.msg231838#msg231838)
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on January 05, 2021, 12:03:36 AM
Hi guys, thank you for this wonderful forum. I am a new ML user. I apologize in advanced if this question is given already. I did search the forum but am having a hard time finding the answer. Is the Eos 700D able to shoot in 50fps in 1080p? I really need to know this. Thank you so much in advance. :)

Hello!

If you mean 1080p50 in H.264, no you can't (reason: hardware limitations), however:
700D doesn't record native 1920x1080 resolution in H.264, it's actually upscale 1736x976 to 1920x1080 in H.264, so now if your question was " Can we record 1736x976 @ 50 FPS in RAW? "

Kind of, with limitations, the sensor support up to 1736x970 @ 50 FPS:

-You have to record in uncompressed RAW to avoid corrupted frames, @ 10-bit uncompressed the write speed would be 100 MB/s
-You will have stretched LiveView

This can be achieved in crop_new

You're welcome
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: lightwriter on January 10, 2021, 09:25:26 PM
@lightwriter

Hi again!

1- This corruption due to un-refreshed LiveView, to prevent this:
Also when you startup the camera and if crop_new was already ON you need to refresh LiveView manually!

2- In mlv_lite submenu --> Preview --> Framing

3- Yeah, that's what I am using

4- ?

MLVApp corrects aspect ratio automatically for you, you don't need to change anything regarding resolution. The output would be correct.

5- EOS M has some problems with 240 MHz overclock it doesn't work fine on this camera even with 170 MB/s Sandisk Extreme PRO cards (except one card: Sandisk Extreme PRO 170MB/s with 512 GB Capacity) , doing a "Low Level Format" would fix the speed drop issue e.g: from 66.7 MB/s to 51.8 MB/s -- these things have been discussed before in this topic (https://www.magiclantern.fm/forum/index.php?topic=12862.0).

6- This issue has been discussed here  (https://www.magiclantern.fm/forum/index.php?topic=5951.msg231838#msg231838)

Hi @theBilalFajhouri!

Thanks for your answer. Regarding number four you're right, the MLVapp corrects the aspect ratio; I only have to insert the resolution values for exporting.

I have read the answers related to number 6, but there you said "shutter speeds are working fine in all presets, and both from ML and Canon menu shutter speed is showing correctly " My build is crop_rec_4k.2020Sep30.700D115. Is this problem related to this specific build or am I doing something wrong?

I bought the Sandisk Extreme PRO 170MB/s card, and it indeed allows me to record indefinitely (almost always), but I'm having corrupted frames (random frames with the bottom half being pink). Is there some setting I can alter to prevent this from happening?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: far.in.out on March 28, 2021, 12:21:02 AM
Hi. Is H264 cropped recording available on 700D or 650D? 1:1 or 1:3 with binning?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Walter Schulz on March 28, 2021, 12:34:44 AM
Supported cams: https://builds.magiclantern.fm/features.html -> Movie -> CROP_MODE_HACK
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: far.in.out on March 28, 2021, 12:49:05 AM
Thanks. 1x3 binning works for H264 too, right? What about live preview while recording? How good is it? Does hdmi preview work in this mode?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Walter Schulz on March 28, 2021, 01:53:39 AM
Looks like 1:1 to me.
1x3 binning works for H264 too, right?

Looks like 1:1 to me.

What about live preview while recording? How good is it?

Unsure what you want to know. I get a 3x electronically zoomed frame in 16:9 which fills display horizontal. Both in idle and during recording.

Does hdmi preview work in this mode?

If you want to ask what I get via HDMI: Looks like 1620x912 embedded in 1920x1080 and it is the same content (apart from overlays) shown by display when HDMI is not connected.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: masc on March 28, 2021, 02:09:29 PM
Thanks. 1x3 binning works for H264 too, right? What about live preview while recording? How good is it?
No. 1x3 recording can work in RAW only. Liveview is realtime.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: far.in.out on March 28, 2021, 11:36:18 PM
Thanks guys. One last question - when recording in H264 1:1 crop mode, what resolution is it reading from the sensor? Is it 1920x1080 or is it something less than that and it gets upscaled?

I was initially thinking of getting the 600D for it's aliasing free 3x zoom mode for H264. But then I saw the latest progress on RAW and the fact that you can now shoot aliasing free RAW with a crop factor of 2 on several cams. So I'm willing to give RAW another shot while having cropped H264 as a fall back. So that makes 700D a good choice I guess. No point in getting 600D any more.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Walter Schulz on March 28, 2021, 11:57:38 PM
Is it 1920x1080 or is it something less than that and it gets upscaled?

https://wiki.magiclantern.fm/glossary#native_resolution
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: far.in.out on March 29, 2021, 12:06:26 AM
Thanks Walter. It looks like the wiki is about the full sensor mode. Is it the same case with cropped H264?
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: Walter Schulz on March 29, 2021, 07:26:50 PM
Is it the same case with cropped H264?
Do the math on your own, please!
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fabload.de%2Fthumb%2Fmvi_0024-1nujke.png&hash=70ae30fa0e8215c71acc33611e03034a) (https://abload.de/image.php?img=mvi_0024-1nujke.png)
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fabload.de%2Fthumb%2Fmvi_0025-1bgjdg.png&hash=b576bbccee0dcf1d8949aaa3a7d908c7) (https://abload.de/image.php?img=mvi_0025-1bgjdg.png)
Pics taken with 650D.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: far.in.out on March 30, 2021, 11:26:59 PM
OK, millimeters from your pics (425/141) have a ratio of 3.014184397.
While full horizontal sensor res divided by 1920 (5184/1920) is 2.7.
But I don't think this is a reliable way of checking if there's upscaling going on.  :D

Hm, after looking at it for some time I don't see how cropped horiz res can be more than 1/3 of full sensor res, which is 1728.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: ML700D on March 31, 2021, 01:28:17 PM
hi,
thanks for the bilal's crop_rec_4k, I installed it few days ago. This is my first camera I bought.
I still confuse actually for the setting when switching between photo and video.. :P
for instance if I set on crop rec new in video mode with 1x3 binning then switch to photo mode the preview zoomed a bit like in video mode, is it normal?
and if I set the crop mode ON the preview always zoomed. How to get actual preview like normal recording? Thanks.

sorry for my bad english  :)
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: ML700D on April 06, 2021, 07:30:45 AM
hi again,
after I tried several times now I understand a bit.  :D
when I choose preset the preview looks perfect, I tried UHD 1x3 Anamorphic 1280x2160
as described here https://www.magiclantern.fm/forum/index.php?topic=25323.25

I think this is more than enough for me to take some footage.. @theBilalFakhouri you're great!

btw.. the black bar is not always black sometimes it turn like pink zebra flickering and sometimes the preview doesn't change between normal and zoom.

thanks.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: ML700D on April 17, 2021, 02:25:19 PM
Hi again..  :D
I have a problem when the crop_rec is ON then switch to Photo mode and take a photo, the camera got busy quiet long until I turn off and open the battery lid.. I don't know if it's right or not.. but I tried several times it turned out to be the same.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on April 17, 2021, 09:39:32 PM
Hello @ML700D :D!

Sorry for the delay, glad you liked the build ;D

..
for instance if I set on crop rec new in video mode with 1x3 binning then switch to photo mode the preview zoomed a bit like in video mode, is it normal?
and if I set the crop mode ON the preview always zoomed. How to get actual preview like normal recording? Thanks.
..
..
I have a problem when the crop_rec is ON then switch to Photo mode and take a photo, the camera got busy quiet long until I turn off and open the battery lid.. I don't know if it's right or not.. but I tried several times it turned out to be the same.

Thanks for reporting, Crop mode module should be disabled in Photo mode to avoid Zoomed preview and "Busy" state when capturing photos, currently you can do it manually, just set "Crop mode" to "OFF", I will prevent "Crop mode" from being ON when we in Photo mode, and will release a new build.


..
btw.. the black bar is not always black sometimes it turn like pink zebra flickering ..
..
The bottom part of preview would have some flickering and weird patterns in presets which have correct real-time previews, this is normal, current solution is to make sure Global Draw is ON, and use mlv_lite module, this will draw black box on this flickering area.


..
.. and sometimes the preview doesn't change between normal and zoom.
..
I need to know your camera settings to reproduce the issue, which preset have you used? are you in Video mode? which modules are enabled?

You may want to share a video including what are you doing, this make things easier to reproduce the issue.

Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on April 17, 2021, 09:57:38 PM
Hello @lightwriter

Sorry for the delay:

I have read the answers related to number 6, but there you said "shutter speeds are working fine in all presets, and both from ML and Canon menu shutter speed is showing correctly " My build is crop_rec_4k.2020Sep30.700D115. Is this problem related to this specific build or am I doing something wrong?

Your 700D have different shutter blanking addresses, resulting in wrong shutter speeds when using my build, the problem isn't from the build itself, on my 700D it works just fine because the addresses used in my build matches the addresses which my 700D generate, let's say for now some 700D models are different from other 700D models, and your 700D need other shutter blanking addresses.

a1ex did explain this case earlier and I did mention it before, current temporary solution is to release two builds which include the two addresses, or find a way to add them in one build.
I may do it in near future.

I bought the Sandisk Extreme PRO 170MB/s card, and it indeed allows me to record indefinitely (almost always), but I'm having corrupted frames (random frames with the bottom half being pink). Is there some setting I can alter to prevent this from happening?

During my tests, SD overclocking isn't related to corrupted frames in any way.

Please provide a frame or short MLV clip which have corrupted frames your are experiencing, probably you are using "Crop mode V2" which is a bit buggy right now, and always make sure you are refreshing LiveView manually by pressing Menu button twice (I have explained this before).

You may want to stick with "Crop mode" (crop_rec) for now which works better.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: ML700D on April 19, 2021, 09:15:27 AM
Hello @ML700D :D!

Sorry for the delay, glad you liked the build ;D

Thanks for reporting, Crop mode module should be disabled in Photo mode to avoid Zoomed preview and "Busy" state when capturing photos, currently you can do it manually, just set "Crop mode" to "OFF", I will prevent "Crop mode" from being ON when we in Photo mode, and will release a new build.
Ohh.. Ok. thanks  :D

Quote
The bottom part of preview would have some flickering and weird patterns in presets which have correct real-time previews, this is normal, current solution is to make sure Global Draw is ON, and use mlv_lite module, this will draw black box on this flickering area.
If Global Draw is ON the preview looks jittery
I use mlv_lite module.

Quote
I need to know your camera settings to reproduce the issue, which preset have you used? are you in Video mode? which modules are enabled?

I use crop mode UHD Anamorphic 1x3 preset and some setting that you recommended in video mode
the module are mlv_lite, crop_rec, crop_new, dual_iso, ettr and sd_uhs

for first time use without changing the setting is fine then when changing the setting the issue usually comes as I mentioned before, especially change the crop mode setting, even though I've pressed the menu 2x.

Quote
You may want to share a video including what are you doing, this make things easier to reproduce the issue.

https://drive.google.com/file/d/1NRyvbrVhebr3zKLdayeebNtajPmEM4hS/view?usp=sharing

aahh...I just realized the problem is when the global draw is ON.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on April 19, 2021, 10:35:15 AM
If Global Draw is ON the preview looks jittery
I use mlv_lite module.
..
I use crop mode UHD Anamorphic 1x3 preset and some setting that you recommended in video mode
the module are mlv_lite, crop_rec, crop_new, dual_iso, ettr and sd_uhs
..
https://drive.google.com/file/d/1NRyvbrVhebr3zKLdayeebNtajPmEM4hS/view?usp=sharing

aahh...I just realized the problem is when the global draw is ON.

To solve these problems, you need to use Canon preview, highlight "Raw video" --> Press Q button --> Preview --> set it to "real-time"

Now, everything would work as expected ;D
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: ML700D on April 19, 2021, 05:59:34 PM
To solve these problems, you need to use Canon preview, highlight "Raw video" --> Press Q button --> Preview --> set it to "real-time"

Now, everything would work as expected ;D

Nice! thank you..  :D

Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: ML700D on April 19, 2021, 06:46:25 PM
Hello @lightwriter

Sorry for the delay:

Your 700D have different shutter blanking addresses, resulting in wrong shutter speeds when using my build, the problem isn't from the build itself, on my 700D it works just fine because the addresses used in my build matches the addresses which my 700D generate, let's say for now some 700D models are different from other 700D models, and your 700D need other shutter blanking addresses.

a1ex did explain this case earlier and I did mention it before, current temporary solution is to release two builds which include the two addresses, or find a way to add them in one build.
I may do it in near future.


is it like mine? When I use shutter 1/50 on canon setting but on ml preview is wrote 1/26.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on April 19, 2021, 11:38:13 PM
Yes, shutter speeds shows as stuck value or incorrect value in ML menu.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: ML700D on April 20, 2021, 11:01:59 AM
ooh.. I see, thanks.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: ML700D on April 25, 2021, 07:20:08 AM
Hello theBilalFakhouri,

I've got crash this day, I don't know why.
here I attach the crash log file: https://drive.google.com/file/d/140IBe4k-8p4F-TeIAxazwtAEE5fr25EV/view?usp=sharing (https://drive.google.com/file/d/140IBe4k-8p4F-TeIAxazwtAEE5fr25EV/view?usp=sharing)

but the camera run normal again after I turn off and open the battery.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: ML700D on April 29, 2021, 03:44:22 AM
hello again,

@theBilalFakhouri sorry to ask..
can the crop mode be integrated into the raw video menu?
because I had experience when I turn off the raw video but forget turn off the crop mode, to get normal video shoot, the camera freeze..
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on May 14, 2021, 11:10:34 AM
Hi @ML700D

Two requested changes you asked for are done, I will try to release as soon as possible:

1- crop_rec won't be patched in Photo mode.
2- crop_rec only would has effect when RAW video is ON, turning OFF RAW video would disable "Crop mode", and you can record H.264 safely, not of my crop_rec presets works in H.264 anyway.

Other changes for the coming build:

1- mlv_lite: Fixed ML Framing preview when not using real-time correct preview presets.

2- crop_rec: Canon overlays are disabled when using crop modes with real-time correct preview (Enhanced experience).
    crop_rec: ML global draw top bar would go to the bottom automatically when using crop modes with real-time correct preview and vice-versa (Enhanced experience).
    crop_rec: Pressing Half-Shutter in Idle would switch preview to Canon x10; to quickly check focus.
    crop_rec: Added Full-Resolution LiveView preset (5208x3478 @ 2 FPS).

3- crop_new: Enhanced LiveView automatic refreshing after applying new settings or when enabling/disabling the module.
    crop_new: Press SET button in LiveView to refresh LiveView manually.
    crop_new: Added selectable FPS option.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: ML700D on May 14, 2021, 12:43:45 PM
wow.. nice, thanks a lot..  :D
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: IBIRRU on May 14, 2021, 08:37:14 PM
Nice news Bilal!

Thanks!
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: lightwriter on May 21, 2021, 03:16:23 PM
Hello @lightwriter

Sorry for the delay:

Your 700D have different shutter blanking addresses, resulting in wrong shutter speeds when using my build, the problem isn't from the build itself, on my 700D it works just fine because the addresses used in my build matches the addresses which my 700D generate, let's say for now some 700D models are different from other 700D models, and your 700D need other shutter blanking addresses.

a1ex did explain this case earlier and I did mention it before, current temporary solution is to release two builds which include the two addresses, or find a way to add them in one build.
I may do it in near future.

During my tests, SD overclocking isn't related to corrupted frames in any way.

Please provide a frame or short MLV clip which have corrupted frames your are experiencing, probably you are using "Crop mode V2" which is a bit buggy right now, and always make sure you are refreshing LiveView manually by pressing Menu button twice (I have explained this before).

You may want to stick with "Crop mode" (crop_rec) for now which works better.

Hi @theBilalFakhouri!

Sorry for only now replying to your answer.

Thanks for the explanation of the first point; I was going a little nuts, trying to figure out what I was doing wrong.

Regarding the corrupted frames, I exposed this situation to a guy in youtube: https://www.youtube.com/channel/UCA1OBB0Z2EERvT5hHiXLTmw, and he told me to disable Global Draw. That did work flawlessly; however, has it was to be expected, disabling Global Draw stops me from seeing important information like zebras and the histogram...

Oh, and congratulations for the soon to be released build. Seems you added some very welcome additions!
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on May 24, 2021, 01:19:43 AM
Hello!

New Build uploaded for 650D/700D, you can find it in first post:
https://www.magiclantern.fm/forum/index.php?topic=25784.msg231049#msg231049

Changes posted here:
https://www.magiclantern.fm/forum/index.php?topic=25784.msg235480#msg235480
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on May 24, 2021, 01:38:41 AM
I have just re-uploaded the 650D build, missed something, re-download it again.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on May 24, 2021, 08:36:05 AM
Again, sorry! I have just re-uploaded the "crop_rec_4k.2021May24.700D115_Shutter_Blanking" build, missed something, please re-download it again from the first post (https://www.magiclantern.fm/forum/index.php?topic=25784.msg231049#msg231049)!

If you curios: I am using crop_rec_4k branch, when compiling an old version of mlv_snd gets included in the build, I have to replace it manually each time, not a huge thing, will try to update mlv_snd code in crop_rec_4k branch, currently you have the latest mlv_snd in my builds, so don't worry about it and have fun!
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: ML700D on May 25, 2021, 10:09:51 AM
Hello!

New Build uploaded for 650D/700D, you can find it in first post:
https://www.magiclantern.fm/forum/index.php?topic=25784.msg231049#msg231049

Changes posted here:
https://www.magiclantern.fm/forum/index.php?topic=25784.msg235480#msg235480

wow.. thanks. I will try it soon  :D
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: zandette974 on May 29, 2021, 08:43:26 AM
Hi,
I'm using the last 700d's build for "shutter blanking issue" and audio is not recorded.
Maybe i'm doing something wrong.
Audio module is loaded and on.
I did a test with the "regular" build and audio works fine.

Thanks.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on May 29, 2021, 06:43:35 PM
Hi,
I'm using the last 700d's build for "shutter blanking issue" and audio is not recorded.
Maybe i'm doing something wrong.
Audio module is loaded and on.
I did a test with the "regular" build and audio works fine.

Thanks.

Hello!

I don't have this issue, the sound gets recorded fine here with shutter blanking build.

More details are needed:

What modules are loaded, camera settings, which preset are you using?
Could share a picture for ML menu?

Note: I have re-uploaded that build (https://www.magiclantern.fm/forum/index.php?topic=25784.msg235561#msg235561) after few hours of the original upload, the new upload fix the sound recording compatibility issue, if you missed that, please re-download the build from the first post (https://www.magiclantern.fm/forum/index.php?topic=25784.msg231049#msg231049) and test again.
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: zandette974 on May 29, 2021, 08:22:53 PM
Hi Bilal
I re-downloaded and everything is fine now.

Thank you
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: theBilalFakhouri on June 02, 2021, 12:44:19 AM
New builds are posted in the first post (https://www.magiclantern.fm/forum/index.php?topic=25784.0) for 650D/700D

Changes:

crop_rec:
-The preview in mlv_lite will change automatically to "real-time" when selecting presets with real-time correct preview. (some users are missing this step, now it's automatic)

-Added new "720p50 3x3" preset 1736x698 3x3 @ 50 FPS with correct un-stretched preview, this preset is included originally in the official crop_rec_4k builds (https://builds.magiclantern.fm/experiments.html) but without the preview fix, I didn't include 60 FPS option because of overhead and corrupted frames, at 50 FPS it works fine. The preview looks choppy but the recorded RAW data isn't affected.

-crop_rec won't be enabled when autofocus is ON

-Added warning messages to make everything clear in crop_rec


These from first post are no longer needed and have been removed:
...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  .
General notes:
-You need to disable autofocus when using crop_rec module (Important).
-Use "real-time" preview in mlv_lite submenu if you want to use crop_rec presets which support real-time correct preview for better experience.
...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  ...  .
Title: Re: Bilal's crop_rec_4k experiments for 700D / T5i
Post by: barton_senger44 on June 03, 2021, 01:11:00 PM
Hello Bilal,
I have the latest build of yours installed on my 700D but I have a question. I am kind of confused from the different resolutions, formats and crops that are available. My question is what is the highest resolution I can shoot at without crop aka the highest quality the camera can offer without crop and with minimal alliasing
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Saint on June 08, 2021, 04:08:36 PM
Dear Bilal!
Installed your firmware, installed SD card overclocking,
works well, thanks! Filmed without a crop, compressed at 14bit. On some shots, there is a sky, but it was pink. and there are frame drops, 1 or 2 for 30-40 seconds. 190 Mhz card. It may be my imagination, but the colors and dynamic range are better. Thank you! On the crop, of course, 18-55 is not very good quality. At 24 STM, the picture looks better both on crop and without it.

Уважаемый Билал!
Поставил вашу прошивку, установил разгон SDкарты,
работает хорошо, спасибо! Снимал без кропа, на 14bit сжатый. На некоторых шотах, есть небо, но оно было розовым. и есть пропуски кадров, 1 или 2 на 30-40 секунд. Карта на 190 Mhz.  Может это мое воображение, но цвета и динамический диапазон стали лучше. Спасибо! На кропе конечно 18-55 не очень качество. На 24 STM картинка выглядит лучше и на кропе и без него.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on June 08, 2021, 07:13:35 PM
Hello Saint!

If you want me to check why the sky was pink, please provide short MLV sample for that clip, you can cut the MLV file inside MLVApp using "Cut In & Cut Out" tab, two frames are enough, then export it into MLV file, set the "Codec" inside "Export Settings" window to "MLV" "Fast Pass", and upload the sample and give me the link.

I don't have the pink sky issue, a common workarounds for this issue: don't use auto iso, try "Highlights Reconstruction" in "Processing" tab inside MLVApp, try lowering "RAW White Level" in "RAW Correction" tab also inside MLVApp with small steps.


To get continuous RAW recording in normal 1080p mode 3x3 (with no crop), depending on resolution, framerate and what aspect ratio you are using, you may want to use lower bit-depths like 12-bit lossless or 10-bit lossless, the overclock helps too, 192 MHz with Sandisk Extreme PRO UHS-I U3 95 MB/s is pretty good for most modes (~58 to ~61 MB/s Write Speed), Sandisk Extreme PRO UHS-I U3 170 MB/s with 240 MHz is the best (~68 MB/s Write Speed), as described in the first post.

Highlight "RAW video" in "Movie" tab inside ML Settings, you can see the a calculated required write speed in current mode in ML bottom bar, perform benchmarks test for your card in camera in current mode, load "bench.mo" module --> restart the camera --> "Debug" tab --> "Benchmarks" --> "Card Benchmarks" --> Quick R/W benchmark (1 min), you can see how your SD card performs.


If you want to get the best sharp images with 18-55 STM kit lens, you need to use f/5.6 at 18mm, and up to f/8 at 55mm (depending on my own tests), prime lenses are always better, I only have the 50mm 1.8 prime lens, so no much experience with wider focal length prime lenses, you may want to watch YT and see some reviews/advices . . etc.

Sorry for the long answer, glad you liked the build :D
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Saint on June 09, 2021, 12:31:10 AM
Yes, I'll post a short piece. I am translating from MLV to DNG for Davinchi Resolve. Therefore, I do not do anything in MLV, because as I understand it, DNG is pure RAW. I tend to shoot at 24mm STM, from f / 5 to f / 16. M mode, ISO 100-400, rarely up to 800.
 25 frames / sec. 1/50 s. 18-55 used only for crop, but soap is visible. Only now I realized that I removed all MLVs from the filming, only DNG remained. I'll try to catch it next time.
I'm afraid to run a speed test, because you sent a link about a person whose card is broken. And something tells me in my head that I also did the speed test then and it stopped working :-) So I'm AFRAID to do the test. :-)

Да, я выложу короткий кусочек. Я перевожу из MLV в DNG для Davinchi Resolve. Поэтому я ничего не делаю в MLV, потому что как я понял DNG это чистый RAW. Я стараюсь снимать на 24 мм STM, от f / 5 до f / 16. Режим М, ISO 100-400, редко до 800.
 25 кадров / с. 1/50 с. 18-55 использовал только для кропа, но видно мыло. Только сейчас понял что я удалил все MLV со сьемки, остались только DNG. Попробую поймать в следующий раз.
Боюсь запускать тест скорости, так как вы прислали ссылку про человека у которого карта сломалась. И мне что то подсказывает в голове что я тоже делал тогда тест скорости и она перестала работать :-) Так что тест БОЮСЬ делать. Жалко карту :-)
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on June 09, 2021, 01:39:49 PM
Okay, you might prefer DNG for Davinci Resolve, no worries about the MLV clip with pink sky.

I see, if you are afraid to run SD benchmarks, don't do it, that's always up to you, doing anything related to ML is at your own risk.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Icaab on June 18, 2021, 10:30:03 PM
Hello, everybody. I’m delighted that we’ve updated the firmware and made some positive changes. However, I’m concerned about the following:
In my last experimental firmware, I had the ability to configure the screen resolution so that in the editor of MLV App I had a picture like 2:35:1
https://pasteboard.co/K7e6M7f.png

In the current firmware, no matter how many times I’ve gone through the rabbi and crop settings - the height of the video cannot increase and in the application it is not 2214 pixels as before.
https://pasteboard.co/K7e7qv5.png

I like the firmware, but this is a problem for me. I have long wanted to use this very regime, because it creates the ideal balance of sides for my ideas.
I want a ratio 5208 by 2214 :)

(I used to change the following parameters:
Crop mode v2 and RAW video
https://pasteboard.co/K7e9vdG.jpg
But now the line of RAW video stays the same height)
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on June 18, 2021, 10:43:48 PM
Hello @Icaab

1736x2214 does work here, I didn't change anything regarding this, could you share a photo showing your camera settings? or a video showing what are you doing?

I found crop_rec may conflict with crop_new sometimes if both loaded in some cases resulting in crop_new (Crop mode V2) won't apply the selected settings, in this case try turning off "Crop mode V2", press menu button twice in LiveView, or toggle between 1080p and x5 modes by pressing magnification button several times, turn on "Crop mode V2" again, does it work?

Make sure you are getting 1736x2214 resolution from mlv_lite (RAW video) before recording . .
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on June 18, 2021, 10:53:54 PM
Ok, I think I found what is happening, will release a new builds soon might fix this problem (currently unload crop_rec module if you want to use crop_new).
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on June 19, 2021, 03:57:47 AM
New builds are posted in the first post (https://www.magiclantern.fm/forum/index.php?topic=25784.0) for 650D/700D

Changes:

crop_rec:
-Switching between presets now is faster
-Fixed a conflict with crop_new which made "Crop mode V2" in most cases has no effect
-Some code optimizations

RAW video with HDMI:

-Fixed a regression introduced back in "11 Dec, 2016" by this pull request (https://foss.heptapod.net/magic-lantern/magic-lantern/-/merge_requests/778/commits), regression symptoms:
(These symptoms happen when the camera is connected to HDMI monitor, no matter what's the output):

-LiveView freezes after recording some RAW video clips, or when toggling between mv1080 and x5 modes when RAW video is enabled
-Weird flickering/glitches in LiveView when the camera startups up with RAW video enabled

This issue is still presented in official Nightly builds, and probably all of DIGIC 5 cameras are affected, maybe except 5D3, (this issue isn't related to HDMI overhead things).

Some details:
ML use EDMAC write channel #18 for RAW data stream (something related to RAW video recording), back then a1ex asked the developers to find a none-used channel by Canon firmware for each model, channel #18 was available (and worked across all models except for 5D3 1.2.3 (https://www.magiclantern.fm/forum/index.php?topic=10443.msg100979#msg100979)), so we have used it for years . . without a problem, until some days ago I found out this channel is being used by Canon when connecting the camera (my 700D) to HDMI monitor and causes the issues above . .

Well, I started looking for another available EDMAC write channel, I found channel #3 being the best, not used by Canon in anything? (Not used in HDMI, capturing still images, recording H.264, and so) beside channel #3 didn't introduce corrupted frames, same performance as #18 channel in addition to no issues with HDMI connection :).
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Danne on June 19, 2021, 07:40:06 AM
Cool. You've been busy lately :). Would be nice adding some of this to eos m. How would I change edmac channel and hdmi fixes?
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Icaab on June 19, 2021, 11:01:23 AM
New builds are posted in the first post (https://www.magiclantern.fm/forum/index.php?topic=25784.0) for 650D/700D

Changes:

crop_rec:
-Switching between presets now is faster
-Fixed a conflict with crop_new which made "Crop mode V2" in most cases has no effect
-Some code optimizations

RAW video with HDMI:

-Fixed a regression introduced back in "11 Dec, 2016" by this pull request (https://foss.heptapod.net/magic-lantern/magic-lantern/-/merge_requests/778/commits), regression symptoms:
(These symptoms happen when the camera is connected to HDMI monitor, no matter what's the output):

-LiveView freezes after recording some RAW video clips, or when toggling between mv1080 and x5 modes when RAW video is enabled
-Weird flickering/glitches in LiveView when the camera startups up with RAW video enabled

This issue is still presented in official Nightly builds, and probably all of DIGIC 5 cameras are affected, maybe except 5D3, (this issue isn't related to HDMI overhead things).

Some details:
ML use EDMAC write channel #18 for RAW data stream (something related to RAW video recording), back then a1ex asked the developers to find a none-used channel by Canon firmware for each model, channel #18 was available (and worked across all models except for 5D3 1.2.3 (https://www.magiclantern.fm/forum/index.php?topic=10443.msg100979#msg100979)), so we have used it for years . . without a problem, until some days ago I found out this channel is being used by Canon when connecting the camera (my 700D) to HDMI monitor and causes the issues above . .

Well, I started looking for another available EDMAC write channel, I found channel #3 being the best, not used by Canon in anything? (Not used in HDMI, capturing still images, recording H.264, and so) beside channel #3 didn't introduce corrupted frames, same performance as #18 channel in addition to no issues with HDMI connection :).

Thank you very much for such a fast feedback. I downloaded the firmware and tried it. Yes, the switching problem has gone away, but the main problem I’ve always had to worry about with the cropping regime has not been solved:
There is no convenient height in the frame when you preview. This can be eliminated by turning on another preview mode, but for the filming of important work, this is not all and will only cause total discomfort.
For convenience, I flooded the phone footage of the camera settings. There’s a preview comparison between the first crop of fashion and the second one, and you can also see the problem of the shutter value, which when changed on the screen remains in terms of its numerical value the same
https://mega.nz/file/F9AzmAwK#2Lx44NfjflSKbrUJMFdB4bjzfavNFw2OQ9KrxCOMvWM
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on June 19, 2021, 04:17:08 PM
Hello @Danne

I have updated the source code, you will find it in the first post if you want to take a look there, it's really easy,

To change EDMAC write channel for RAW stream from edmac-memcpy.c file:

Code: [Select]
#if defined(CONFIG_5D3)
uint32_t raw_write_chan = 0x4;  /* 0x12 gives corrupted frames on 1.2.3, http://www.magiclantern.fm/forum/index.php?topic=10443 */
#elif defined(EVF_STATE)
uint32_t raw_write_chan = 0x12; /* 60D and newer, including all DIGIC V */
#endif

Change it from:
Code: [Select]
uint32_t raw_write_chan = 0x12; /* 0x12 = channel #18 */ to
Code: [Select]
uint32_t raw_write_chan = 0x3; /* 0x3 = channel #3 */
Not sure if channel 0x3 would work fine on EOS M you need to make tests, check channel activity with edmac.mo module, unload all modules, load edmac.mo, if channel #3 stays like this "0:     <w!>" what ever you do (Capture still photo, record H.264 video, connect HDMI monitor) then this channel isn't being used by Canon at these cases (that's what we need), now compile a build with 0x3 channel if you didn't, try recording RAW video in high frame rates like 1736x586 @ 60 FPS in lossless, try other crop modes, and look if there a corrupted frames or not compared to when using channel #18

Some channels appear to produce more corrupted frames than others, luckily channel #3 have same performance as channel #18 and without HDMI and RAW video issues :) .
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on June 19, 2021, 04:31:45 PM
..but the main problem I’ve always had to worry about with the cropping regime has not been solved:
There is no convenient height in the frame when you preview. This can be eliminated by turning on another preview mode.

From the first post:

-Crop mode V2 module (crop_new) with Arbitrary Resolutions:
...
...
-This module doesn't include any recent preview fixes.

Currently if you want to use 1x3 modes with real-time correct preview you need to use crop_rec "Crop mode", and unfortunately there is no 5K option (*5208x2214), there is 4.3K (*4320x1836) 2.35:1 AR.

*After stretching.

Implementing real-time correct preview in crop_new "Crop mode V2" requires further research and time, processing 1736x2214 in LiveView might not be possible, even if it was possible we may have another problems like corrupted frames due to hardware limitations and limited memory or limited memory bandwidth.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on June 19, 2021, 05:55:39 PM
..and you can also see the problem of the shutter value, which when changed on the screen remains in terms of its numerical value the same..

Okay, I will release two builds for 650D like 700D, this issue affects some 650D users , will try to release a second new build for 650D ASAP solves shutter issue.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Icaab on June 20, 2021, 09:12:40 AM
From the first post:

Currently if you want to use 1x3 modes with real-time correct preview you need to use crop_rec "Crop mode", and unfortunately there is no 5K option (*5208x2214), there is 4.3K (*4320x1836) 2.35:1 AR.

*After stretching.

Implementing real-time correct preview in crop_new "Crop mode V2" requires further research and time, processing 1736x2214 in LiveView might not be possible, even if it was possible we may have another problems like corrupted frames due to hardware limitations and limited memory or limited memory bandwidth.

Thank you. Sorry to bother you with the same question. I wanted to finally wait for the correction of this moment to finally start shooting what I wanted). But I guess I’ll have to work with 4.3k in crop mode 1. And I fully believe that crop mode 2 is more likely to have a good source than the first )
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: mlrocks on June 22, 2021, 05:13:08 PM
Alex and you all are magicians, making 10-year old consumer level still cameras competing with the latest crop of professional video cameras, disrupting the whole Hollywood business. Kudos to you.
I want to not only compete with the big brothers like Red Weapon and Alexa LF, but also to beat them. I am using Alex's crop2 to get 1x3 5200x1160, i.e., 1736x1160, so it has an aspect ratio of 5:1. The 650D can do this at 10-bit raw 23.975 fps continuously, about 57 MB/s. The preview is good, I can use either raw video module to get the wide and narrow correct frame view or use raw video mlv module to get the full screen anamorphic preview which I think is better in this case because it uses the whole screen space. I like the aspect ratio 5 footage. The problem is the color taint. There is severely color taint in footage. Hopefully the color taint can be removed somehow to make this mode practical. Thanks a lot.

Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: mlrocks on June 23, 2021, 09:11:05 AM
I did some concept testing. Using Alex's crop2 new module, set full width 1x3, 1736x1947, i.e., 5200x1947, aspect ratio: 2.67. Bit rate: 10. Using raw video module, 14 bit lossless. It is about 64 MB/s. If ISO is set to 100 to 200, this mode can be continuous. If 400-800, can be over 1 minute. It seems that even going up to 6400, the digital noise does not increase drastically. This is different from 5d3, which has a flat low digital noise at <ISO 3200, but increases rapidly at 6400, and drastically so at 12800 and 25600, rendering the ISO >6400 practically not usable.
Hopefully, color taint can be removed in this mode. Also, using Alex's crop2 new module, the AF does not need to be disabled. However, the crop module requires the lens to turn off the AF.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: mlrocks on June 24, 2021, 02:42:46 AM
I tested in Alex's crop new module full width 1:3 1736x1736 aspect ratio 3. I can do 10 bit 14-bit lossless 24 p continuously. The data is about 56 MB/s. There is color taint, sometimes red in darkness sometimes green in darkness.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on June 24, 2021, 03:42:16 AM
@mlrocks

There is only color tint/taint in LiveView when using lower bit-depths from crop_rec/crop_new submenu, this in normal and doesn't affect RAW footage

Let me check what you are having by providing a sample MLV file which has the taint issue, 5 seconds are enough, you can shorten MLV clip in MLVApp (export as MLV fast pass) then upload it somewhere and share the link


ISOs which are above 3200 are digital on 650D/700D and won't improve shadows it will just make noise more visible, there is a tiny (not noticeable) improvement between ISO 1600 and 3200 ISO, it better to keep ISO lower than 1600 for the best results in general on these cameras
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on June 24, 2021, 04:09:24 AM
@Icaab

It seems only your 650D has shutter value issue (first reported 650D), so we need to check shutter blanking addresses from your camera, but before doing that I want you to check if Danne crop_rec_4k build for 650D have the same issue on your 650D, try this build from Danne (outdated build, no longer maintained), but it would be useful for our test:
crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Apr29.650D104.zip (https://web.archive.org/web/20200812191122/https://bitbucket.org/Dannephoto/magic-lantern/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Apr29.650D104.zip)

Test it and feedback, does it have shutter issue?

Also, does Dual ISO work on your 650D? or it give ISOless errors?
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: bern047 on June 24, 2021, 03:19:58 PM
I have the shutter problem as well on the Canon 700D and Iso here in the UK, but with the right build it works really well, thanks Bilal
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: alt1 on June 24, 2021, 08:17:04 PM
I use autofocus and I have no ability use the crop_mode in the last version with autofocus, but I could use it in the previous one (crop_rec_4k.2021May24.650D104.zip )
Bilal, would you please add the trigger anywhere in submenu to enable crop_mode menu with autofocus, maybe unchecked by default.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Icaab on June 25, 2021, 10:31:31 AM
@Icaab

It seems only your 650D has shutter value issue (first reported 650D), so we need to check shutter blanking addresses from your camera, but before doing that I want you to check if Danne crop_rec_4k build for 650D have the same issue on your 650D, try this build from Danne (outdated build, no longer maintained), but it would be useful for our test:
crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Apr29.650D104.zip (https://web.archive.org/web/20200812191122/https://bitbucket.org/Dannephoto/magic-lantern/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Apr29.650D104.zip)

Test it and feedback, does it have shutter issue?

Also, does Dual ISO work on your 650D? or it give ISOless errors?


Yes, I have problems with double ISO, therefore I do not use it (isoless error)

I put the firmware you suggested. The Dual ISO started to work, and the problem with shutter value - did not disappear (this manifested when included modules for shooting in RAW ).
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: alt1 on June 25, 2021, 11:29:45 AM
@Icaab
Also, does Dual ISO work on your 650D? or it give ISOless errors?
I have the ISOless PH err(2) error with Dual ISO on my 650d, but it seems there is the solution
-The ISOless PH err(2) is still there when i activate Dual ISO in M Mode. Starting in P mode and then moving to M mode works.

Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Icaab on June 28, 2021, 11:13:44 PM
I have the ISOless PH err(2) error with Dual ISO on my 650d, but it seems there is the solution
Thank you for your decision. I hope they will correct this error in the new update.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Icaab on June 28, 2021, 11:28:38 PM
Hello. I have a question: I understand perfectly well how to use the modules for shooting in Crop mode and RAW, but again, I would like to clarify the profile for the camera:
When shooting with such modules - the profiles do not work and we get the image in RAW as you see when the standard style is turned on ,but there is a certain sharpness there.
I take it I have to put it down at the very least, so the video can be even better for post-production? Or does it not make any sense and in RAW format still comes a certain sharpness?
https://ibb.co/NTDHPs3
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Icaab on June 29, 2021, 09:58:02 AM
And one more question:
In my artistic design, it is necessary to shoot in the scene a computer monitor turned on.
When you look at the footage, you see a little aliasing on the monitor.
(I shoot and in 1x3 and procedure in MLVApp, as is required, so that in other cases the muar and aliasing do not manifest)
Can do anything other than buy optical low pass filter?
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on June 29, 2021, 01:44:21 PM
I have the shutter problem as well on the Canon 700D and Iso here in the UK, but with the right build it works really well, thanks Bilal

Welcome :)

I use autofocus and I have no ability use the crop_mode in the last version with autofocus, but I could use it in the previous one (crop_rec_4k.2021May24.650D104.zip )
Bilal, would you please add the trigger anywhere in submenu to enable crop_mode menu with autofocus, maybe unchecked by default.

Yeah, I disabled the ability to use autofocus when crop_rec "Crop mode" is ON due to stability reasons, which modes you want to use autofocus with?

Autofocus might be stable only with 1440p 1:1 and 3K 1:1 modes, so I may re-enable autofocus with these modes.



Yes, I have problems with double ISO, therefore I do not use it (isoless error)

I put the firmware you suggested. The Dual ISO started to work, and the problem with shutter value - did not disappear (this manifested when included modules for shooting in RAW ).

Okay, we need to check your camera shutter registers addresses, I will write another post regarding this and how to it.

Hello. I have a question: I understand perfectly well how to use the modules for shooting in Crop mode and RAW, but again, I would like to clarify the profile for the camera:
When shooting with such modules - the profiles do not work and we get the image in RAW as you see when the standard style is turned on ,but there is a certain sharpness there.
I take it I have to put it down at the very least, so the video can be even better for post-production? Or does it not make any sense and in RAW format still comes a certain sharpness?
https://ibb.co/NTDHPs3

Picture style doesn't affect RAW data, only H.264 video and LiveView

And one more question:
In my artistic design, it is necessary to shoot in the scene a computer monitor turned on.
When you look at the footage, you see a little aliasing on the monitor.
(I shoot and in 1x3 and procedure in MLVApp, as is required, so that in other cases the muar and aliasing do not manifest)
Can do anything other than buy optical low pass filter?

Shooting a monitor is a nightmare for cameras, popular solution is to make the monitor out of focus (using camera lens) a bit, but in your case there are many subjects in the frame, so you probably need to change monitor position, or use a wider aperture . .

1:1 modes (have higher crop) might help to reduce aliasing/moire on monitor . . I have no idea if optical low pass filter can deal with monitor aliasing/moire . .
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Icaab on June 29, 2021, 11:45:16 PM
Welcome :)

Yeah, I disabled the ability to use autofocus when crop_rec "Crop mode" is ON due to stability reasons, which modes you want to use autofocus with?

Autofocus might be stable only with 1440p 1:1 and 3K 1:1 modes, so I may re-enable autofocus with these modes.


Okay, we need to check your camera shutter registers addresses, I will write another post regarding this and how to it.

Picture style doesn't affect RAW data, only H.264 video and LiveView

Shooting a monitor is a nightmare for cameras, popular solution is to make the monitor out of focus (using camera lens) a bit, but in your case there are many subjects in the frame, so you probably need to change monitor position, or use a wider aperture . .

1:1 modes (have higher crop) might help to reduce aliasing/moire on monitor . . I have no idea if optical low pass filter can deal with monitor aliasing/moire . .
Thank you.
I’m going to do a different composition, and I’m going to use focus advice to shoot the monitor.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Icaab on July 06, 2021, 06:07:47 PM
Hello. I have a problem: if you try to record a video with a microphone (boya by-m1) connected, the recording of the sound is disabled during the recording. Without a microphone, the sound is recorded and included in the raw settings.
(It’s probably not a firmware problem, but I don’t have any way to test it with another device right now. That’s why I’m interested, just in case.)

The problem was easily resolved. You can delete this unnecessary message :).
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: elenhil on July 12, 2021, 06:43:57 PM
Bilal, sorry to ping you in the wrong thread, but did you get any luck obtaining ArcziPL's source code? I would really love to see your work combined for a better 70D experience.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on July 12, 2021, 11:28:43 PM
@Icaab

Okay, cool :) , well, I can't really delete replies or posts for other users, that's a moderator role, no problem with keeping your reply.


Bilal, sorry to ping you in the wrong thread, but did you get any luck obtaining ArcziPL's source code? I would really love to see your work combined for a better 70D experience.

Hello @elenhil, feel free to ask anytime . .

I got the source code from ArcziPL yes, but I can't really do much for 70D without having the hardware, at some point I was going to borrow 70D for some time, but plans changed, I don't mind working on 70D if I got the body.

I think higher resolutions in 1:1 and 1x3 are possible on 70D, but I have no idea if we can get real-time correct preview for 1x3 modes, I need to take a closer look, e.g 5D3 is different from 700D which means 5D3 need a new understanding about how preview works, 70D might be similar to 700D (easy) or 5D3 (currently difficult).
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Icaab on July 21, 2021, 01:15:49 PM
Bilal, hey.
Tell me: Is there such a opportunity that in the future in the firmware 650d/700d it will be possible to shoot timelapse with video so that all settings are flexibly adjusted ( shutter speed, for example) as on EOS M?
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on July 21, 2021, 08:31:50 PM
Hi @Icaab

You can already do time-lapses with crop_new (Crop mode V2) which works greatly, do you have any issue with it?


Let's fix the shutter issue on your camera, assuming you have my crop_rec_4k build on your SD card:

1- Download adtg_gui module from here (https://builds.magiclantern.fm/jenkins/job/iso-research/14/artifact/modules/adtg_gui/adtg_gui.mo)
2- Put it in ML/modules folder in SD card
3- Load "adtg_gui.mo" from "Modules" tab in ML settings, restart the camera
4- From "Debug" tab in ML settings, turn ON "ADTG Registers"
5- Highlight "ADTG Registers" then Press Q button

Now you should see bunch of ADTG2[XXXX] registers, you need to find two registers which are:

1-ADTG2[805F] N
2-ADTG2[8061] N

Highlight the first register and give me these numbers in the yellow box (write them down, or take a picture with your smartphone)
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FSvfRwBm%2FShutter-Blanking-Add.png&hash=4bb3821e4491378c8fdd986c3cedce18)

Do the same thing for the second register, and give me the numbers
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Icaab on July 24, 2021, 08:32:52 PM
Hi @Icaab

You can already do time-lapses with crop_new (Crop mode V2) which works greatly, do you have any issue with it?


Let's fix the shutter issue on your camera, assuming you have my crop_rec_4k build on your SD card:

1- Download adtg_gui module from here (https://builds.magiclantern.fm/jenkins/job/iso-research/14/artifact/modules/adtg_gui/adtg_gui.mo)
2- Put it in ML/modules folder in SD card
3- Load "adtg_gui.mo" from "Modules" tab in ML settings, restart the camera
4- From "Debug" tab in ML settings, turn ON "ADTG Registers"
5- Highlight "ADTG Registers" then Press Q button

Now you should see bunch of ADTG2[XXXX] registers, you need to find two registers which are:

1-ADTG2[805F] N
2-ADTG2[8061] N

Highlight the first register and give me these numbers in the yellow box (write them down, or take a picture with your smartphone)
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FSvfRwBm%2FShutter-Blanking-Add.png&hash=4bb3821e4491378c8fdd986c3cedce18)

Do the same thing for the second register, and give me the numbers

Yes, there is a little problem with it: I stopped using it because the real-time preview is transmitted distorted, flattened. (pixel binning 1x3)

Posting photos of registers:
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FH449R19%2F1627151288002.jpg&hash=9a75efc96978c6c94defdad5d5cc58eb) (https://ibb.co/wgg2832)
(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2FhV8ZFdN%2F1627151288010.jpg&hash=71604e5a69d47cb5ecf8c3bed9d0e6b6) (https://ibb.co/jD4WkwY)
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on July 24, 2021, 10:30:34 PM
Yes, there is a little problem with it: I stopped using it because the real-time preview is transmitted distorted, flattened. (pixel binning 1x3)

You asked for time-lapses, "Crop mode V2" is the perfect module for that, for preview you must use "Framing" preview from "RAW video" submenu.

Which resolution are you looking for to do time-lapses?

As far as I know, EOS M has 4080x3000 preset for time-lapses with real-time cropped preview (x5 preview), this preview would be valid for focusing but not for framing, in "Crop mode V2" x10 preview isn't patched you can use it for focusing before recording, then get back to x1 or x5 mode with "Framing" preview and start recording your time-lapse, I tried it and it works fine . .

Are you looking for something else maybe I am missing? please describe it with details or give me a link showing it so I can improve my future builds . .


Thanks for the pictures, weird, the addresses from your camera is exactly what we are using in our 650D custom builds (Me and Danne), the two builds had issue with shutter value in ML settings on your 650D.

Not sure why the stuck shutter problem is only presented on your 650D, doesn't make sense . . I will try to see if I can do something about it.

Edit: Do you have the shutter problem both in none-crop and crop modes? e.g. unload all modules, restart the camera, select 1080p24 from Canon menu, do you have shutter issue? now get into x5 mode by pressing zoom button, do you have shutter problem in this mode?

Use FPS override to 12 FPS in both 1080p and x5 mode, same problem?
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on July 24, 2021, 10:41:54 PM
New builds are posted in the first post (https://www.magiclantern.fm/forum/index.php?topic=25784.msg231049#msg231049) for 650D/700D

Changes:

crop_rec:
-Fixed a regression with "720p50 3x3" preset, now it works fine.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: NykkyC on July 25, 2021, 12:24:25 AM
Hi everyone I'm new to posting.

On my T4i/650d with your crop_rec_4k latest build I get the shutter issue and ISOless LV err(2)

While having the shutter issue, these were the photos of my ADTG registers:

ADTG2[805f] N -> 4049fa18
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fibb.co%2Fb2Cby16&hash=7472a26a6ecbf294c5cd4b5facda1749)

ADTG2[8061] N -> 4049fa1c
(https://www.magiclantern.fm/forum/proxy.php?request=http%3A%2F%2Fibb.co%2FynQK3DZ&hash=293b2291abe49ef2cec7f111de8122fe)
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on July 27, 2021, 04:27:36 PM
Hi @NykkyC, thanks for the values, try this build:

crop_rec_4k.2021Jul27.650D104_Shutter_Blanking.zip (https://bitbucket.org/bilal_fakhouri/magic-lantern/downloads/crop_rec_4k.2021Jul27.650D104_Shutter_Blanking.zip)

Does the shutter issue solved?

@Icaab
Does this build works on your 650D without the shutter issue?


@NykkyC

Let's try to solve ISOless LV err(2) on your 650D:

1- Download adtg_gui module from here (https://builds.magiclantern.fm/jenkins/job/iso-research/14/artifact/modules/adtg_gui/adtg_gui.mo)
2- Put it in ML/modules folder in SD card
3- Load "adtg_gui.mo" from "Modules" tab in ML settings, restart the camera
4- From "Debug" tab in ML settings, turn ON "ADTG Registers"
5- Highlight "ADTG Registers" then Press Q button

Now you should see bunch of CMOS[X] registers, you need to find one register which is:

-CMOS[0]

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2Fcbbts6p%2FVRAM0.png&hash=9368f5b731b10e16ba3a4f47c2f2e594)

We need to check CMOS[0] address multiple times, in video mode at 100 ISO and 200 ISO, also in photo mode at 100 ISO and 200 ISO . .

1- Let's start with Video mode:

Set the camera to video mode, set the ISO to 100, check CMOS[0] address in white box (write it down), now change the ISO to 200, check CMOS[0] address again and write it down.

2- Set the camera to none still Photo mode:

Set the ISO to 100, take a picture (important), check CMOS[0] address and write it down, now change the ISO to 200, take a picture (important), check CMOS[0] address again and write it down.

Now share the values you got here for each mode and ISO, and let me check them . .
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: NykkyC on July 28, 2021, 03:07:44 AM
Hi @NykkyC, thanks for the values, try this build:

I have tested the crop_rec_4k.2021Jul27.650D104_Shutter_Blanking build and It did not solve the issue.

The ADTG registers for CMOS[0]:

1 - ISO 100: 404a048e or 404a038e / ISO 200: 404a04b0 or 404a03b0

2-  ISO 100: 404a048e or 404a038e / ISO 200: 404a04b0 or 404a03b0 (Not sure if I did this correctly, what do you mean by "Set the camera to none still Photo mode"?)

Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: Icaab on August 03, 2021, 10:15:24 PM
Hi @NykkyC, thanks for the values, try this build:

crop_rec_4k.2021Jul27.650D104_Shutter_Blanking.zip (https://bitbucket.org/bilal_fakhouri/magic-lantern/downloads/crop_rec_4k.2021Jul27.650D104_Shutter_Blanking.zip)

Does the shutter issue solved?

@Icaab
Does this build works on your 650D without the shutter issue?


I tried your first tips. Shutter speed with some modules does not work, as I noticed when they were turned off. (looks like most of it)

Installed your new firmware. Without modules included, everything works, and how it turned them on is the same problem.

But there is a way around it: go into photo mode. Shutter speed is displayed correctly.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on August 13, 2021, 03:39:53 AM
I added a piece of text in the first post (https://www.magiclantern.fm/forum/index.php?topic=25784.msg231049#msg231049) which is "-Loading the modules" to make things clearer for users.

I will try to respond for new replies soon, sorry for the delay.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: mlrocks on August 14, 2021, 03:28:49 PM
I tried your first tips. Shutter speed with some modules does not work, as I noticed when they were turned off. (looks like most of it)

Installed your new firmware. Without modules included, everything works, and how it turned them on is the same problem.

But there is a way around it: go into photo mode. Shutter speed is displayed correctly.

Another way is to push the info button, go to the second layout, then you can see the actual shutter speed.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: mlrocks on August 17, 2021, 02:22:15 AM
On 650D, I loaded the following modules,
bench
ettr
file_man
mlv_lite
mlv_play
mlv_snd
pic_view
sd_uhs
slient

I then:
1. activated the "movie crop mode" to "ON",
2. chose "Raw video" to "ON, 1800x1008", 10-bit, AR 16:9,
3. pushed the record button to record a raw video clip,
4. pushed the playback button,
5. the recorded video clip showed dark frames from the begin to the end.

In playback mode, I can see the video clips if they are recorded in 14-bit lossless compression.

I also tested mlv_rec.mo (raw video v2.0) on 650D for 1792x1008, 10-bit, AR 16:9. When I pushed the record button, it started to record. However, when I pushed the record button again to stop the recording, the stopping process did not go through. I had to turn off the camera to start another recording.




Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on August 17, 2021, 03:22:50 AM
..
2. chose "Raw video" to "ON, 1800x1008", 10-bit, AR 16:9,
3. pushed the record button to record a raw video clip,
4. pushed the playback button,
5. the recorded video clip showed dark frames from the begin to the end.

In playback mode, I can see the video clips if they are recorded in 14-bit lossless compression.
...

Currently mlv_play doesn't support uncompressed 10/12 bit RAW video playback in camera natively in all builds, it would give black screen, on PC the footage would be fine.
You need to activate raw_twk.mo module which add 10/12 bit playback support to mlv_play . . currently there is no raw_twk.mo in my builds, I will include it in the next release, but you can get it from here and put it and in "ML/modules" folder:
https://bitbucket.org/bilal_fakhouri/magic-lantern/downloads/raw_twk.mo

During my tests I found raw_twk.mo appears to produce corrupted frames in 700D when recording RAW video in some modes/settings, probably the module is being active in LiveView somehow and affect RAW stream, will make more tests in future and try to disable raw_twk.mo in LiveView, and make it only work in Play Mode, also there is some quirks when raw_twk is activated like you can't navigate mlv_play settings (toggling between clips, pausing playback and switching between color and fast preview . . etc).

I also tested mlv_rec.mo (raw video v2.0) on 650D for 1792x1008, 10-bit, AR 16:9. When I pushed the record button, it started to record. However, when I pushed the record button again to stop the recording, the stopping process did not go through. I had to turn off the camera to start another recording.

I am having the same problem when using mlv_rec, it keeps saying "Stopping" but nothing happens, you have to pull the battery out/turn the camera off after that, there is no point to use mlv_rec (maybe only for the metadata?), currently just use mlv_lite and it has all what you might need.

Edit: it seems I don't have the latest mlv_rec.mo in my builds, will update it in the next release and this might solve the problem.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: mlrocks on August 17, 2021, 10:51:01 PM
Currently mlv_play doesn't support uncompressed 10/12 bit RAW video playback in camera natively in all builds, it would give black screen, on PC the footage would be fine.
You need to activate raw_twk.mo module which add 10/12 bit playback support to mlv_play . . currently there is no raw_twk.mo in my builds, I will include it in the next release, but you can get it from here and put it and in "ML/modules" folder:
https://bitbucket.org/bilal_fakhouri/magic-lantern/downloads/raw_twk.mo

During my tests I found raw_twk.mo appears to produce corrupted frames in 700D when recording RAW video in some modes/settings, probably the module is being active in LiveView somehow and affect RAW stream, will make more tests in future and try to disable raw_twk.mo in LiveView, and make it only work in Play Mode, also there is some quirks when raw_twk is activated like you can't navigate mlv_play settings (toggling between clips, pausing playback and switching between color and fast preview . . etc).

I am having the same problem when using mlv_rec, it keeps saying "Stopping" but nothing happens, you have to pull the battery out/turn the camera off after that, there is no point to use mlv_rec (maybe only for the metadata?), currently just use mlv_lite and it has all what you might need.

Edit: it seems I don't have the latest mlv_rec.mo in my builds, will update it in the next release and this might solve the problem.

Thanks for the explanation, theBilalFakhouri. I now use mlv record v1.1 10-bit and it is good enough. I unloaded the preview and playback and mlv record v2.0 modules. As long as the footage is fine on computer, it is fine for me.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: mlrocks on August 17, 2021, 10:56:40 PM

During my tests I found raw_twk.mo appears to produce corrupted frames in 700D when recording RAW video in some modes/settings, probably the module is being active in LiveView somehow and affect RAW stream, will make more tests in future and try to disable raw_twk.mo in LiveView, and make it only work in Play Mode, also there is some quirks when raw_twk is activated like you can't navigate mlv_play settings (toggling between clips, pausing playback and switching between color and fast preview . . etc).


You are right. I benchmarked before and after unloading the preview and playback modules. The write speed was about 58 MB/s with the modules loaded, and about 60 MB/s without the modules. I think that playback modules are secondary requests, the highest priority is to record high quality mlv raw footage. Thanks a lot for your codes.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on August 22, 2021, 04:18:40 AM
@mlrocks

It seems "Stopping" issue when using mlv_rec is related to mlv_snd module, unload mlv_snd and mlv_rec would work fine, this problem probably introduced after adding mlv_snd support to mlv_lite (3 years ago) and hasn't been fixed, currently it's a low priority for me . . just use mlv_lite.


@Icaab @NykkyC

Shutter blanking / ISOless issues won't be fixed by hardcoding addresses on some 650D cameras, it seems that the addresses are changing back and fourth among two values (probably more?), we need to follow a1ex suggestion by looking into RAM dumps, currently I can't help much with these problems, sorry.



New builds are posted in the first post (https://www.magiclantern.fm/forum/index.php?topic=25784.0) for 650D/700D (22-8-2021)

Changes:

crop_rec:
-Reset movie crop marks at every refresh.
-CBR fixes (sometimes the preview would get into x5 mode while you are in x10 mode when the module is off)

mlv_play:
-Playback for 1x3 footage has correct AR now (thanks to Danne)

General:
-Included raw_twk module
-Used old routine to brighten up LiveView in 10/12 bit-depths (which decrease overhead in high FPS)


-Write speed improvement:
It's a minor increase which is about ~2-3 MB/s write speed increase in LiveView in all modes:

Last week I was looking for ways to gain extra write speed while RAW recording, e.g by disabling Canon tasks in background or something like that . . I thought about disabling some EDMACs channels which might be not necessary while recording RAW video, I played with all channels then found these two:

EDMAC #12 and EDMAC #24
Code: [Select]
AbortEDmac(12);
AbortEDmac(24);

Disabling them doesn't affect LiveView preview and RAW data (doesn't produce corrupted frames) which what we need, but noticed some side effects:

-Switching between modes or x5/x10 previews would have 0.5 second of stutter/lag
-In some cases after capturing still photo the camera would take more time than usual to save one image on card and the camera will display "Busy" state
-Doing a camera restart solves previous symptoms

-This option is turned OFF by default, you can turn it ON from mlv_lite (RAW video) advanced submenu.

(https://www.magiclantern.fm/forum/proxy.php?request=https%3A%2F%2Fi.ibb.co%2Fw4skJhX%2FEDMACs-hack.png&hash=39a1d069767560aaa3d16c374dc918d4)

Results:

1-2560x1440 @ 23.976 FPS in 10-bit lossless, 240 MHz, same scene, mlv_snd on, global draw off, real-time preview, required write speed reported by mlv_lite 70.8 MB/s:
-Without EDMACs hack: 14-15 seconds recorded, write speed reported while recording ~69 MB/s
-With EDMACs hack: 38-45 seconds recorded, write speed reported while recording ~72.4 MB/s

2-3072x1228 @ 23.976 FPS in 10-bit lossless, 240 MHz, same scene, mlv_snd on, global draw off, real-time preview, required write speed reported by mlv_lite 70.9 MB/s:
-Without EDMACs hack: 11-15 seconds recorded, write speed reported while recording ~67.5 MB/s
-With EDMACs hack: 41-47 seconds recorded, write speed reported while recording ~72.0 MB/s

(I recorded three clips for each setting, so I triple checked the results ;))

-Use it at your own risk.

-This might work for all small cameras like 650D/700D/EOS M/100D, feel free to test on these cameras, however on 5D3 aborting EDMAC #24 causes LiveView freeze, aborting EDMAC #12 can only gain 1 MB/s write speed improvement (during my tests).
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: lightwriter on August 25, 2021, 03:55:43 PM
@theBilalFakjouri

Hi there!

I noticed in your last post that you mentioned:" Results:

1-2560x1440 @ 23.976 FPS in 10-bit lossless, 240 MHz, same scene, mlv_snd on, global draw off, real-time preview, required write speed reported by mlv_lite 70.8 MB/s:
-Without EDMACs hack: 14-15 seconds recorded, write speed reported while recording ~69 MB/s
-With EDMACs hack: 38-45 seconds recorded, write speed reported while recording ~72.4 MB/s"

Does this mean I can record real 2560x1440 resolution in 1x3 mode (no aliasing) with real-time preview with my Canon 700D with a Sandisk Extreme 64GB 170MB/s overclocked to 240MHz? That's great news!
If that's so, what are the modules I have to activate/change?

Does the real-time preview show the scene as it is or cropped?
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: theBilalFakhouri on August 25, 2021, 06:55:13 PM
@lightwriter

Hello!

Well, from the first post, 2560x1440 preset is in 1:1 sampling (true 2560x1440 resolution, not stretch needed, no aliasing in this preset) which has 3.28 crop factor, also has real-time cropped preview. It's doesn't have continuous recording (well, that's depending on scene).

If that's so, what are the modules I have to activate/change?

Just read the first post, all info are included there . .
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: lightwriter on August 25, 2021, 08:15:50 PM
@theBilalFakhouri

Thanks for your fast and thorough explanation!
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: ML700D on September 08, 2021, 07:17:40 AM
@theBilalFakhouri thanks for the update..
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: mlrocks on September 08, 2021, 05:11:17 PM
Just tested the 8/22/2021 version on a relative complex scene containing trees full with leaves, kind of stressing test on details.

650D, 1X3, 1736X1954, AR 2.67, 10 bit, 14-bit lossless, 240 mhz, global draw on, mlv-snd on, EDMACs hack on, ISO 100, mlv raw reading 60 MB/s, can record more than 1 minutes, considering continuous.
The same set up with ISO 1600, mlv raw reading 65-70 MB/s, can record more than 180 frames, about 7-8 seconds, long enough for most video shooting.

Great Job, Bilal.
Title: Re: Bilal's crop_rec_4k experiments for 650D / 700D (T4i / T5i)
Post by: mlrocks on September 10, 2021, 03:06:18 AM
Just tested the 8/22/2021 version on a relative complex scene containing trees full with leaves, kind of stressing test on details.

650D, 1X3, 1736X1954, AR 2.67, 10 bit, 14-bit lossless, 240 mhz, global draw on, mlv-snd on, EDMACs hack on, ISO 100, mlv raw reading 60 MB/s, can record more than 1 minutes, considering continuous.
The same set up with ISO 1600, mlv raw reading 65-70 MB/s, can record more than 180 frames, about 7-8 seconds, long enough for most video shooting.

Great Job, Bilal.


More tests on the same scene

650D, 1X3, 1736X1954, AR 2.67, 10 bit, 14-bit lossless, 240 mhz, global draw off, mlv-snd on, EDMACs hack on, ISO 1600, benchmark went 67 MB/s (from 45 MB/s nominal when global draw is on) with a SanDisk Pro 170 MB/s card. Recorded 360 frames, about doubled compared with that when global draw was on.

The same setup and the same scene, a Zacuto EVF is attached to the 650D using a HDMI to mini-HDMI cable. Recorded about 100 frames, about half with global draw on, about 1/4 with global draw off without an external monitor. There were a lot of pink frames. The HDMI output was real time live view, the framing seemed not correct.