Magic Lantern Forum

Developing Magic Lantern => Feature Requests => Topic started by: youshouldtry11 on October 03, 2018, 10:19:59 AM

Title: Save movie crop upon start up
Post by: youshouldtry11 on October 03, 2018, 10:19:59 AM
Hello there,
I have been using the Eos M magic lamtern movie crop mode with raw,
However, the movie crop mode has to be enabled everytime upon startup(powrr on)
I have tried saving the settings but it just would not save the movie crop setting.
Its pretty annoying and I wonder if it could be made.
Cheers
Title: Re: Save movie crop upon start up
Post by: bakersdozen on October 03, 2018, 11:59:39 AM
Read up on .Lua scripts and how you can have them run automatically at start up. Danne has already developed some for this purpose as part of his custom builds on his Bitbucket.
Title: Re: Save movie crop upon start up
Post by: a1ex on October 03, 2018, 12:52:15 PM
Actually it's WIP here: https://bitbucket.org/hudson/magic-lantern/pull-requests/787

Just need to clean it up and find a way to test it without a camera; might be doable in QEMU.

Pretty sure Danne's experimental builds have it included.
Title: Re: Save movie crop upon start up
Post by: domasa on October 03, 2018, 03:53:00 PM
But missing information about crop mode is problem
"Crop mode 1:1 is without message"
https://bitbucket.org/hudson/magic-lantern/issues/2857/crop-mode-1-1-is-without-message (https://bitbucket.org/hudson/magic-lantern/issues/2857/crop-mode-1-1-is-without-message)

The bigger problem is "FullScreen Magic Zoom without message":
https://bitbucket.org/hudson/magic-lantern/issues/2858/fullscreen-magic-zoom-without-message (https://bitbucket.org/hudson/magic-lantern/issues/2858/fullscreen-magic-zoom-without-message)
Title: Re: Save movie crop upon start up
Post by: a1ex on October 03, 2018, 04:33:49 PM
Those two issues are unrelated (offtopic).
Title: Re: Save movie crop upon start up
Post by: domasa on October 03, 2018, 05:12:31 PM
Those two issues are unrelated (offtopic).
Without information about actual display state (1:1 / FullScreen zoom) is better reset this states everytime upon startup.
Title: Re: Save movie crop upon start up
Post by: a1ex on October 03, 2018, 05:35:25 PM
FullScreen Magic Zoom state *is* reset upon startup, and this has nothing to do with OP's question. His post is neither about crop_rec, nor magic zoom.
Title: Re: Save movie crop upon start up
Post by: Danne on October 03, 2018, 08:00:16 PM
Hehe, this re-enabling issue seems to reoccur from time to time. Out on the road but will check into what build I have it on atm. Later.
Stay tuned...
Title: Re: Save movie crop upon start up
Post by: Danne on October 04, 2018, 08:22:12 AM
@youshouldtry11
Try this version:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/magiclantern-Nightly.2018Jul25.EOSM202_2K-3K-4K_10bit_patch_g3gg0.zip
Title: Re: Save movie crop upon start up
Post by: youshouldtry11 on October 04, 2018, 09:59:48 AM
@youshouldtry11
Try this version:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/magiclantern-Nightly.2018Jul25.EOSM202_2K-3K-4K_10bit_patch_g3gg0.zip

Hello Danne, I am happy to report that it saves upon start up!
However, the liveview in this version is really really bad... its unusable...
Am i doing something wrong?

P.S. I get choppy liveview while shooting RAW and movie crop, In other version liveview works great....
Title: Re: Save movie crop upon start up
Post by: Danne on October 04, 2018, 10:47:05 AM
Could be liveview setting. Get into Preview settings in RAW video menu and set it to real-time.
Title: Re: Save movie crop upon start up
Post by: youshouldtry11 on October 04, 2018, 07:34:19 PM
Could be liveview setting. Get into Preview settings in RAW video menu and set it to real-time.

Thanks alot it worked!!!! It worked very well thanks for the help!!!!!!!
Title: Re: Save movie crop upon start up
Post by: dfort on October 04, 2018, 08:27:45 PM
@Danne - just wondering if you tried out your pull request on the 100D. There was a problem on the 700D when I tested it a while back. It would be nice to get this feature working on all camera that support movie crop mode. 100D, 650D, 700D and EOSM, right?


Sent from my iPhone using Tapatalk
Title: Re: Save movie crop upon start up
Post by: Danne on October 04, 2018, 08:53:40 PM
Yes works, just tested, movie crop mode reenables when restarting on my 100D. Strange it won't work on the 700D.
Title: Re: Save movie crop upon start up
Post by: dfort on October 07, 2018, 04:28:50 AM
Interesting. I’ll re-run the 700D test as soon as I can shake this (hopefully 48 hour) bug that knocked me off my feet.


Sent from my iPhone using Tapatalk
Title: Re: Save movie crop upon start up
Post by: dfort on October 07, 2018, 06:48:35 PM
Need to unravel this before doing any tests.

@Danne - your open pull request for this feature is here (https://bitbucket.org/hudson/magic-lantern/pull-requests/787/crop-hack-config/diff). Is it still valid? Is that the build you used for the EOSM and 100D? That didn't work on the 700D. Neither did your pull request that was merged into the unified branch (https://bitbucket.org/hudson/magic-lantern/pull-requests/776/disables-crop-mode-hack-when-turning/diff).

I tried following the comment @alex posted on your active unmerged pull request and I bounced from this (https://bitbucket.org/hudson/magic-lantern/pull-requests/420/refactor-audio-to-use-new-config-var/diff) dmilligan pull request to this (https://bitbucket.org/hudson/magic-lantern/branch/config_var_refactor) branch named config_var_refactor on the main repository.

But wait, there's more!

The build pointed out by @Danne for @youshouldtry11 to try out (yeah, ha ha) is from a branch on @Danne's ML fork named crop_rec_4k_mlv_snd_lossless_croprec_iso_reg (https://bitbucket.org/Dannephoto/magic-lantern/branch/crop_rec_4k_mlv_snd_lossless_croprec_iso_reg).

So that adds up to 5 different branches--which one is the one I should be testing out?
Title: Re: Save movie crop upon start up
Post by: Danne on October 07, 2018, 07:59:03 PM
Try the last one you point too?
crop_rec_4k_mlv_snd_lossless_croprec_iso_reg

Since it's working for 100D and eosm at least that's proof of some kind :)?

Edit:
Wait. I believe this branch:
https://bitbucket.org/Dannephoto/magic-lantern/branch/crop_rec_4k_mlv_lite_snd_sd_uhs_HDR_croprec

Anyway. Please double check that the commit is in there.
Title: Re: Save movie crop upon start up
Post by: dfort on October 08, 2018, 02:07:58 AM
So there's a 6th branch?

Tested it on both the EOSM and 700D. Works on the EOSM but not on the 700D.

Steps to reproduce:
Ok--so if it is working the camera will not be in Movie crop mode.
Now the camera should be in Movie crop mode.

Of course if the camera crashes while in Movie crop mode it probably won't work but the whole point of this is that if someone switches out cards for one without ML it shouldn't remain stuck in Movie crop mode.
Title: Re: Save movie crop upon start up
Post by: Danne on October 08, 2018, 09:16:58 AM
Ok, so 700D not working.
Yes, a lot of branches, and not all of them contains all loose ends...
Title: Re: Save movie crop upon start up
Post by: dfort on October 08, 2018, 09:59:37 PM
I'll bet this also affects the 650D. I posted a test build on my Bitbucket dowloads page (https://bitbucket.org/daniel_fort/magic-lantern/downloads/) if any 650D user wants to try it out. (@Walter?)

Not sure why the 100D is different. You are testing by putting the camera in Movie crop mode then restarting the camera without loading ML, right?

Title: Re: Save movie crop upon start up
Post by: a1ex on October 28, 2018, 07:21:56 PM
the whole point of this is that if someone switches out cards for one without ML it shouldn't remain stuck in Movie crop mode.

I did some tests on 700D (borrowed it again for 2-3 days).

If I comment out movie_crop_hack_disable() from ml_shutdown (tasks.c), this feature becomes persistent, i.e. this setting is going to be restored at startup by Canon firmware. Of course, the crop mode remains enabled when starting with a non-ML card, which is probably not the expected behavior, but one can easily switch it off from Canon menu.

Without any shutdown hacks, when turning off the camera by opening the card door, the setting gets saved. Disabling it at shutdown works, too. So far, so good.

When turning off the camera from the power switch after enabling crop mode, no matter what I tried, I was unable to disable it at shutdown on 700D.

Therefore, why not keep things simple and accept the persistence of crop mode as implemented by Canon? That means, I'm tempted to undo pull request 776 (https://bitbucket.org/hudson/magic-lantern/pull-requests/776/disables-crop-mode-hack-when-turning/diff).

To be tested:
- comment out movie_crop_hack_disable() from tasks.c, in the main repository (any recent branch - unified, crop_rec_4k, io_trace_full... doesn't matter)
- check on 650D, EOSM and 100D to make sure the setting is persistent, can be turned off from Canon menu and doesn't interfere with e.g. photo mode or other stuff.

To be reviewed: around this post (https://www.magiclantern.fm/forum/index.php?topic=9741.msg175593#msg175593).
Title: Re: Save movie crop upon start up
Post by: Danne on October 28, 2018, 07:28:19 PM
If I comment out movie_crop_hack_disable() from ml_shutdown (tasks.c), this feature becomes persistent, i.e. this setting is going to be restored at startup by Canon firmware. Of course, the crop mode remains enabled when starting with a non-ML card, which is probably not the expected behavior, but one can easily switch it off from Canon menu.
Don´t have my camera besides me but how is crop mode turned off from canon if register is set and magic lantern sd card is pulled out after crop mode is set and camera then is put back on?
Title: Re: Save movie crop upon start up
Post by: a1ex on October 28, 2018, 07:50:42 PM
Without any shutdown hacks (i.e. before PR #776), this setting is saved by Canon firmware. It's in the same property that stores video resolution and frame rate, and it's handled by the MPU.

With the shutdown hack from PR #776, you tried to disable this persistence from Canon, to address the following (my best guess):

Would it be possible to turn off crop mode on shutdown then turn it back to the desired state from the configuration file on start up?

On 700D, there are two cases:

1) Shutdown by opening the card door. In this case, ML disables crop mode at shutdown, this setting is sent over to the MPU, the MPU stores it in its EEPROM (or wherever it stores its persistent settings) and turns off the camera.

2) Shutdown by turning off the camera. On 700D, the power button is shared with the movie mode switch, so... turning off the camera inevitably goes through photo mode. Once you are in photo mode, you can no longer change movie settings - the main CPU will send them over to the MPU, but the MPU is not going to save them in its nonvolatile memory.

I've tried to disable this setting before leaving LiveView (tried PROP_LV_ACTION and PROP_SHOOTING_TYPE), but it looks like these events arrive too late; the MPU no longer saves movie settings modified from these property handlers.

Even if I'll eventually figure out the right moment to disable crop mode, that method adds some extra complexity - I'll have to re-enable the crop mode when entering LiveView, then save that setting in the config file, restore it at startup and so on. Canon already has this setting persistent (at least on 700D; others should be tested), so why not reuse their implementation?
Title: Re: Save movie crop upon start up
Post by: Danne on October 28, 2018, 08:18:33 PM
Interesting about the 700D.
Well yes. Two issues were adressed with the pr.
1 - Reenable Movie crop mode upon restart if the setting weren´t manually set to off after enabling
2 - Avoid entering into Movie crop mode if on after shut down decided to change card or start without  card which would start the camera with movie crop mode register still set with no way to disable it but to install ML again.

Keep in mind this was very long time ago and when teting number 2 on my 100D I can´t get it stuck in crop mode anymore by extracting my sd card so can´t even verify this was an issue or still is? Number 1 is still a valid reason so if that works another way than in the pr I´m a happy user.
Title: Re: Save movie crop upon start up
Post by: a1ex on October 28, 2018, 08:30:31 PM
Right; for #2, I've found the "stuck" crop mode to be a minor issue, as it can be turned off easily from Canon menu.

There's also #3 - crop mode not appearing in Modified settings menu. Solved that one locally.

If you can confirm #2 is not (or no longer?) an issue on EOS M and 100D in the main repository, after reverting PR #776, I'm ready to commit it.
Title: Re: Save movie crop upon start up
Post by: Danne on October 28, 2018, 08:55:23 PM
Just to be sure. Main repository=unified?
Tested on crop_rec_4k_mlv_snd branch on my 100D and can´t get it stuck into crop mode so that´s a good thing. Not my eosm here until tomorrow so could test both cams tomorrow. crop_rec_4k_mlv_snd or unified branch?

Test procedure:
Enable Movie crop mode, turning off camera removing card. Restarting camera to check if Movie crop mode is still on.
Title: Re: Save movie crop upon start up
Post by: a1ex on October 28, 2018, 08:58:25 PM
To be tested:
- comment out movie_crop_hack_disable() from tasks.c, in the main repository (any recent branch - unified, crop_rec_4k, io_trace_full... doesn't matter)
- check on 650D, EOSM and 100D to make sure the setting is persistent, can be turned off from Canon menu and doesn't interfere with e.g. photo mode or other stuff.
Title: Re: Save movie crop upon start up
Post by: Danne on October 28, 2018, 09:33:52 PM
Quote
- comment out movie_crop_hack_disable() from tasks.c, in the main repository (any recent branch - unified, crop_rec_4k, io_trace_full... doesn't matter)
Confirmed working good on eos 100D when commenting out movie_crop_hack_disable(). Restarting camera gets me back into Movie crop mode. Taking out the card restarting camera doesn´t get the camera into stuck Movie crop mode even when set in ml menu so that is good. Putting back the card and starting camera after this and we are back to MOvie crop mode unset which is good.
Will try eosm tomorrow.
Title: Re: Save movie crop upon start up
Post by: a1ex on October 28, 2018, 10:44:53 PM
Confirmed working good on eos 100D when commenting out movie_crop_hack_disable(). Restarting camera gets me back into Movie crop mode. Taking out the card restarting camera doesn´t get the camera into stuck Movie crop mode even when set in ml menu so that is good. Putting back the card and starting camera after this and we are back to MOvie crop mode unset which is good.

Wait a minute, this is not the same as 700D. The 700D keeps the movie crop mode enabled, but it's not stuck - you can disable it easily from Canon menu if you start without a ML card.
Title: Re: Save movie crop upon start up
Post by: dfort on October 29, 2018, 04:47:02 AM
...I've found the "stuck" crop mode to be a minor issue, as it can be turned off easily from Canon menu...

Not sure how you're turning off Movie crop mode from the Canon menu but I found out that switching from 1920x1080/24 to 1280x720/60 and back will "unstick" Movie crop mode.

To be tested:
- comment out movie_crop_hack_disable() from tasks.c, in the main repository (any recent branch - unified, crop_rec_4k, io_trace_full... doesn't matter)
- check on 650D, EOSM and 100D to make sure the setting is persistent, can be turned off from Canon menu and doesn't interfere with e.g. photo mode or other stuff.

Commenting out movie_crop_hack_disable() from tasks.c in the unified branch (line 376) will make the EOSM behave the same as the 700D which is a persistent Movie crop mode that doesn't interfere with photo mode.

So it looks like movie_crop_hack_disable() works on the EOSM but not on the 700D, right? Still need to hear back from 100D and 650D users.
Title: Re: Save movie crop upon start up
Post by: a1ex on October 29, 2018, 05:26:59 AM
Just switching to any other frame rate and back from the touch screen does the trick on 700D, e.g. from 1080p25 switch to 1080p24 and back.

If 100D is not persistent (unsure how to interpret Danne's report), we'll have to use the config file trick.
Title: Re: Save movie crop upon start up
Post by: Danne on October 29, 2018, 07:06:10 AM
100D is persistent.
Tests:
1 - Enable Movie crop mode
- Shut off camera, start camera, mcm still on
- Going into photo mode and back to movie mode and mcm is still on. Photo mode is not affected by mcm so regular still photo mode apply
- restarting camera with mcm enabled keeps mcm enabled
- Disabling mcm is possible by toggle between fps modes in canon menu
- Disabling mcm is also possible by simply pulling out battery or starting camera without an sd card inserted

The "stuck" thingy hasn´t been reproduced. Not sure how to do it. Maybe never was an issue, these tests were done in a galaxy far away and long ago  :P
Title: Re: Save movie crop upon start up
Post by: dfort on October 29, 2018, 02:48:00 PM
...e.g. from 1080p25 switch to 1080p24 and back.

Just for the record, I'm using NTSC. Switching to 1080p30 and back to 1080p24 didn't work for me. Movie crop mode stayed persistent until I went to 720p/60.
Title: Re: Save movie crop upon start up
Post by: a1ex on October 30, 2018, 07:39:02 AM
Could not confirm, just tried.

Besides, simply tapping on the same frame rate (e.g. 1080p24) on the touch screen will disable the crop mode on 700D.
Title: Re: Save movie crop upon start up
Post by: dfort on October 31, 2018, 05:05:21 AM
I should do a video on this but my Rebel T5i won't get out of Movie crop mode outside of ML by tapping the same 1080p24 on the touch screen or switching to 1080p30 for that matter.

The whole point of Danne's PR is to unset Movie crop mode on shutdown and read the settings file on startup to restore it to the previous state. This seems like the "right" way to do it instead of having Movie crop mode be persistent when starting the camera without loading ML.
Title: Re: Save movie crop upon start up
Post by: Danne on October 31, 2018, 05:38:07 AM
It is not persistent when loading camera without ml on it . It persists when ml is loaded.
Are you saying the 700D always stays in movie crop mode while ml not loaded?
Title: Re: Save movie crop upon start up
Post by: a1ex on October 31, 2018, 06:07:35 AM
Yes.

- comment out movie_crop_hack_disable()
- enable movie crop mode from ML menu
- turn off the camera (from either power switch or SD card door)
- reboot without card
- crop mode stays enabled (it's saved by Canon firmware)
- changing resolution from Canon menu resets crop mode here, but not on dfort's 700D (?!)
- crop mode cannot be changed outside movie mode (this includes shutdown from power switch, which is done via photo mode)

Giving it one last chance, as I have to return the 700D today.

Logs:

- crop-switch-power-off.log (https://a1ex.magiclantern.fm/bleeding-edge/700D/crop-switch-power-off.log)
- crop-switch-open-card-door.log (https://a1ex.magiclantern.fm/bleeding-edge/700D/crop-switch-open-card-door.log)

The magic happens at:
Code: [Select]
12.206.146     PropMgr:ff11ebd0:00:00: *** mpu_send(1e 1c 01 4e 00 00 00 0c 00 00 00 00 00 00 00 19 00 00 00 0c 00 00 00 02 00 00 00 02 00) ; PROP_VIDEO_MODE

15.015.338  **INT-36h*:ff31af1c:00:00: *** mpu_recv(06 05 06 22 00 00)                               ; ??? [guess: power switch]
15.015.637  **INT-36h*:ff31af1c:00:00: *** mpu_recv(06 05 01 4b 01 00)                               ; PROP_LIVE_VIEW_VIEWTYPE_SELECT [is this the right place to disable crop mode?]
15.015.702    MainCtrl:ff0cc61c:89:03: bindReceiveSwitch (34, 0)
15.021.164     PropMgr:ff0f2e28:81:01: @@@PROP_FIXED_MOVIE 0
15.021.369     PropMgr:ff23ee90:81:03: FixedMovie New 0 Last 1
15.021.388     PropMgr:ff23ef20:81:03: ExitMovMode
15.046.937         Gmt:ff183a88:9a:03: PROP_LIVE_VIEW_VIEWTYPE_SELECT:1
15.077.067  **INT-36h*:ff31af1c:00:00: *** mpu_recv(08 06 04 0c 00 00 01)                            ; PROP_SHOOTING_TYPE
...
17.282.725  **INT-36h*:ff31af1c:00:00: *** mpu_recv(06 05 06 11 00 00)                               ; GMT_GUICMD_START_AS_CHECK
17.282.896    MainCtrl:ff14523c:9c:16: REQ : MultiShotTerminate !!!
17.285.606  GuiMainTas:00090e70:32:03: config_save_file: saving to ML/SETTINGS/magic.cfg
19.817.945     PropMgr:000aed00:00:00: **** movie crop hack dis

and, in the second log (notice the camera stays in movie mode):
Code: [Select]
10.347.198     PropMgr:ff11ebd0:00:00: *** mpu_send(1e 1c 01 4e 00 00 00 0c 00 00 00 00 00 00 00 19 00 00 00 0c 00 00 00 02 00 00 00 02 00) ; PROP_VIDEO_MODE
...
12.964.154  **INT-36h*:ff31af1c:00:00: *** mpu_recv(06 05 06 12 01 00)                               ; GMT_GUICMD_OPEN_SLOT_COVER
12.964.376  **INT-36h*:ff31af1c:00:00: *** mpu_recv(08 06 04 0c 00 00 01)                            ; PROP_SHOOTING_TYPE
12.964.496    MainCtrl:ff14523c:9c:16: REQ : MultiShotTerminate !!!
13.095.675         Gmt:ff183a88:9a:03: PROP_LIVE_VIEW_VIEWTYPE_SELECT:2
13.134.583  GuiMainTas:00090e70:32:03: config_save_file: saving to ML/SETTINGS/magic.cfg
13.249.463     PropMgr:000aed00:00:00: **** movie crop hack dis

in other words, the two shutdown methods (from power switch and from card door) are very different.

Now, disabling the movie crop mode from PROP_LIVE_VIEW_VIEWTYPE_SELECT (first property triggered before switching to photo mode)... still doesn't work on 700D. The crop mode setting is still enabled after rebooting without card.

Code: [Select]
PROP_HANDLER(PROP_LIVE_VIEW_VIEWTYPE)
{
    if (buf[0] != 2)
    {
        //info_led_blink(5, 50, 50);  [ to be able to tell when it runs; throws ERR70 ]
        //DryosDebugMsg(0, 0, "**** movie crop hack dis"); [ visible in io_trace_full or dm-spy-experiments ]
        movie_crop_hack_disable();
    }
}

The procedure does run before the mirror goes down, but apparently that's still too late.

crop-switch-power-off-dis-PROP_LIVE_VIEW_VIEWTYPE.log (https://a1ex.magiclantern.fm/bleeding-edge/700D/crop-switch-power-off-dis-PROP_LIVE_VIEW_VIEWTYPE.log)

Code: [Select]
8.789.033  **INT-36h*:ff31af1c:00:00: *** mpu_recv(06 05 06 22 00 00)                               ; ???
8.789.257  **INT-36h*:ff31af1c:00:00: *** mpu_recv(06 05 01 4b 01 00)                               ; PROP_LIVE_VIEW_VIEWTYPE_SELECT
8.798.111     PropMgr:ff23ee90:81:03: FixedMovie New 0 Last 1
8.798.131     PropMgr:ff23ef20:81:03: ExitMovMode
8.798.180     PropMgr:ff23e800:81:03: !! Convert Start !! 3(5) -> 3(0)
8.799.551     PropMgr:ff23e968:81:03: !! Convert End !!
8.802.361     PropMgr:ff1c6f78:83:01: changeCBR PropID(0x80000034)Parameter(1)Size(4)  ; PROP_LIVE_VIEW_VIEWTYPE_SELECT
8.802.425     PropMgr:000bbcd0:00:00: **** movie crop hack dis                             [ too late? ]
8.806.570     PropMgr:ff1c6f78:83:01: changeCBR PropID(0x80000034)Parameter(1)Size(4)
8.806.642     PropMgr:000bbcd0:00:00: **** movie crop hack dis                             [ triggered again ]
8.833.798     PropMgr:ff11ebd0:00:00: *** mpu_send(1e 1c 01 4e 00 00 00 00 00 00 00 00 00 00 00 1e 00 00 00 0f 00 00 00 00 00 00 00 02 00) ; PROP_VIDEO_MODE
8.835.150     PropMgr:ff11ebd0:00:00: *** mpu_send(1e 1c 01 4e 00 00 00 00 00 00 00 00 00 00 00 1e 00 00 00 0f 00 00 00 00 00 00 00 02 00) ; PROP_VIDEO_MODE
8.835.331  **INT-36h*:ff31af1c:00:00: *** mpu_recv(1e 1c 01 4e 00 00 00 00 00 00 00 00 00 00 00 1e 00 00 00 0f 00 00 00 00 00 00 00 02 00) ; PROP_VIDEO_MODE
8.847.884  **INT-36h*:ff31af1c:00:00: *** mpu_recv(1e 1c 01 4e 00 00 00 00 00 00 00 00 00 00 00 1e 00 00 00 0f 00 00 00 00 00 00 00 02 00) ; PROP_VIDEO_MODE
8.930.835     PropMgr:ff1c6f78:83:01: changeCBR PropID(0x80000034)Parameter(1)Size(4)
8.930.904     PropMgr:000bbcd0:00:00: **** movie crop hack dis                             [ triggered once more]
8.930.985     PropMgr:ff31be1c:01:03: mode 0 size 0x0 , framerate 0x1e , type 0xf zoom 0x0
8.931.316  **INT-36h*:ff31af1c:00:00: *** mpu_recv(50 4e 02 0e 03 03 05 00 03 00 00 60 00 00 03 0d 48 00 00 00 00 83 00 00 06 04 00 00 06 04 00 00 06 04 00 01 01 00 00 00 70 28 00 00 00 00 00 00 1e 00 00 61 00 00 80 48 58 48 00 03 02 01 00 00 00 00 02 01 00 00 00 01 00 00 00 01 00 00 01) ; Mode group
8.932.040     PropMgr:ff228e60:8f:02: PROP_MOVIE_PARAM 0 0 30 15

8.956.203     PropMgr:ff0f2e90:81:03: dwNewAeModeDial = 3                                [ switching to photo mode ]
8.956.256     PropMgr:ff23efb0:81:03: ChangeAEMode -> 3 @AE_MODE_DIAL
...

I don't get it. The "disabled" crop setting is sent over to the MPU, the MPU *confirms* it, yet the setting is not saved in its nonvolatile memory. When powering on without card, crop mode is still enabled.

The first event, bindReceiveSwitch (34, 0), is not forwarded to GuiMainTask, so it's not possible to handle it from there...

We can use a logging hook in either io_trace_full or dm-spy-experiments branch, dm-spy-extra.c:

Code: [Select]
    { 0xFF0CC5D8, "BindReceiveSwitch", 2, BindReceiveSwitch_log },

static void BindReceiveSwitch_log(uint32_t* regs, uint32_t* stack, uint32_t pc)
{
    if (regs[0] == 34 && regs[1] == 0)
    {
        DryosDebugMsg(0, 0, "**** movie crop hack dis from BindReceiveSwitch");
        movie_crop_hack_disable();
    }
}

crop-switch-power-off-dis-BindReceiveSwitch.log (https://a1ex.magiclantern.fm/bleeding-edge/700D/crop-switch-power-off-dis-BindReceiveSwitch.log)

Code: [Select]
7.790.891    MainCtrl:000c74e4:00:00: **** movie crop hack dis from BindReceiveSwitch
7.790.974    MainCtrl:ff0cc61c:89:03: bindReceiveSwitch (34, 0)
7.795.445     PropMgr:ff23ef20:81:03: ExitMovMode
7.804.086     PropMgr:ff11ebd0:00:00: *** mpu_send(1e 1c 01 4e 00 00 00 00 00 00 00 00 00 00 00 1e 00 00 00 0f 00 00 00 00 00 00 00 02 00) ; PROP_VIDEO_MODE
7.805.345  **INT-36h*:ff31af1c:00:00: *** mpu_recv(1e 1c 01 4e 00 00 00 00 00 00 00 00 00 00 00 1e 00 00 00 0f 00 00 00 00 00 00 00 02 00) ; PROP_VIDEO_MODE

TLDR: that doesn't work either.

Giving up.
Title: Re: Save movie crop upon start up
Post by: dfort on October 31, 2018, 06:58:23 AM
What bugs me is that I didn't catch the problem with pull request #776 on the 700D until after it was merged. Seems to work fine on the EOSM and I believe Danne verified it is working on the 100D. We still need someone to test it on the 650D.
Title: Re: Save movie crop upon start up
Post by: a1ex on October 31, 2018, 07:05:26 AM
I don't expect any surprises on the EOS M - its power button is not shared with the photo/video mode switch.

I expect the 650D and 100D to behave in the same way as 700D, judging from the shape of their power button.

Maybe you have turned off the 700D by opening the card door (I do that most of the time); in this case, the crop mode setting can be disabled by ML, so PR #776 worked.

What's not working is when turning off the camera from the main power switch; in this case, no matter what I've tried, the crop mode could not be disabled by ML.
Title: Re: Save movie crop upon start up
Post by: Danne on October 31, 2018, 08:50:49 AM
I expect the 650D and 100D to behave in the same way as 700D, judging from the shape of their power button.

I asked dfort to check following on his 700D:

First test:
1 - Movie crop mode set to on
2 - shut off camera remove sd card
3 - turn camera on
Still in movie crop mode?

Answer: YES(dfort)

Second test:
1 - Movie crop mode set to on
2 - shut off camera, remove battery and put it back
3 - turn camera on
Still in movie crop mode?

Answer: YES(dfort)

The answer in NO on both tests on the 100D.
Title: Re: Save movie crop upon start up
Post by: dfort on October 31, 2018, 03:41:12 PM
Maybe you have turned off the 700D by opening the card door (I do that most of the time); in this case, the crop mode setting can be disabled by ML, so PR #776 worked.

Yes--verified that PR #776 works properly when shutting down the 700D by opening the battery door. Though I usually use the power button to shutdown  :D

What's not working is when turning off the camera from the main power switch; in this case, no matter what I've tried, the crop mode could not be disabled by ML.

Exactly what I'm seeing here on the 700D.

I don't expect any surprises on the EOS M - its power button is not shared with the photo/video mode switch.

The 700D can also be turned on by closing the battery door so maybe that can bypass going into photo mode when booting the camera? Though that doesn't work with PR #776 either.

The answer in NO on both tests on the 100D.

So on the 100D Movie crop mode is never persistent no matter what you try? That doesn't make sense.

I did the tests with and without movie_crop_hack_disable() in tasks.c (PR #776 (https://bitbucket.org/hudson/magic-lantern/pull-requests/776/disables-crop-mode-hack-when-turning/diff)). Have you done the open battery door test on the 100D with a build that includes PR #776? Vanilla unified branch includes it.

BTW--PR #776 works properly on the EOSM when shutting down with either the power button or opening the battery door. So far the only camera that follows the logic in the code is the EOSM.
Title: Re: Save movie crop upon start up
Post by: Danne on October 31, 2018, 03:52:36 PM
Sorry, can't follow what is what anymore. If anyone wants more tests please upload a specific build and a specific test suggestion.
Title: Re: Save movie crop upon start up
Post by: dfort on October 31, 2018, 05:08:46 PM
First test:
1 - Movie crop mode set to on
2 - shut off camera remove sd card
3 - turn camera on
Still in movie crop mode?

Second test:
1 - Movie crop mode set to on
2 - shut off camera, remove battery and put it back
3 - turn camera on
Still in movie crop mode?

That second test should be just to open the battery door to shut off the camera.

We can't use a vanilla unified build for the 100D so use a vanilla crop_rec_4k build--it also incorporates PR #776. Test results? Now comment out movie_crop_hack_disable() in tasks.c

src/tasks.c
Code: [Select]
static void ml_shutdown()
{
    check_pre_shutdown_flag();
#ifdef FEATURE_CROP_MODE_HACK
    // movie_crop_hack_disable();
#endif

Test results?
Title: Re: Save movie crop upon start up
Post by: Danne on October 31, 2018, 05:12:34 PM
Already did that test, already posted my results. Check a few posts back.

You should test both pulling the battery and only open the battery door. One of the should set mcm to off the other one should restart with mcm on.
Title: Re: Save movie crop upon start up
Post by: a1ex on October 31, 2018, 05:19:40 PM
Try this: https://builds.magiclantern.fm/jenkins/view/Experiments/job/crop_mode_test/3/ (for 100D, 700D and 650D)

Test 1:
- start camera in movie mode, enable crop mode
- restart camera by opening card door and closing it back; is crop mode still enabled?

Test 2:
- start camera in movie mode, enable crop mode
- restart camera from power switch; is crop mode still enabled?

Test 3:
- start camera in movie mode, make sure crop mode is enabled
- enter photo mode from the power switch (outside LiveView)
- select "Don't click me" (this will call movie_crop_hack_disable)
- restart camera from power switch; is crop mode still enabled?

Test 4:
- start camera in movie mode, make sure crop mode is enabled
- stay in movie mode
- select "Don't click me" (this will call movie_crop_hack_disable)
- restart camera from power switch; is crop mode still enabled?

Test 5:
- start camera in movie mode, enable crop mode
- turn off camera by opening the card door
- remove the card and reboot; crop mode still enabled?
- can you disable crop mode from Canon menu? any special tricks needed?
Title: Re: Save movie crop upon start up
Post by: Danne on October 31, 2018, 05:40:55 PM
Thanks for the follow up. Of course I forgot my camera at work so any tests from my side on the 100D will have to wait until monday. Anyone else with a 100D feel free to test this meanwhile.
Title: Re: Save movie crop upon start up
Post by: dfort on October 31, 2018, 05:44:10 PM
700D test results.

Test 1: Yes, crop mode still enabled after restart by closing battery door.
Test 2: Yes, crop mode still enabled after restart using power switch.
Test 3: Yes, crop mode still enabled after running "Don't click me" in photo mode (outside LiveView) and restarting using power switch.
Test 4: No, crop mode was disabled after running "Don't click me" in movie mode and restarting using power switch.
Test 5: Yes, crop mode still enabled after opening battery door and restarting without card. Movie crop mode can be disabled from Canon menu by switching movie mode from 1920/24 to 1280/60 or 640/30 but not from 1920/24 to 1920/30.
Title: Re: Save movie crop upon start up
Post by: Walter Schulz on October 31, 2018, 07:32:40 PM
650D.104, using build by a1ex
https://www.magiclantern.fm/forum/index.php?topic=22874.msg207798#msg207798

Test 1: No, crop mode off after restart.
Test 2: No, crop mode off after restart.
Test 3: No, crop mode off after restart.
Test 4: No, crop mode off after restart.
Test 5: No, crop mode off after restart.
Title: Re: Save movie crop upon start up
Post by: dfort on November 01, 2018, 04:18:18 PM
Well those 650D test results just threw every theory out the window.
Title: Re: Save movie crop upon start up
Post by: Walter Schulz on November 01, 2018, 04:26:34 PM
Or I did it wrong.
I'm going to make a short video showing test procedures and hoping there might be another 650D owner willing to run the test.
Don't forget there was another issue where my cam seems to work strange.

EDIT: No vid but retried setup several times (with a1ex's build). Same result. Crop mode off, each and every time. Took care to remove battery after each test.
EDITEDIT: I cross-checked with dfort's build and a1ex's build for 100D. With dfort's 650D build I get very different results.
@a1ex: Haven't checked source for your 650D build. Any explanation why your build and dfort's differ?

Vid would not clear up anything -> Cancelled.
Title: Re: Save movie crop upon start up
Post by: Walter Schulz on November 03, 2018, 07:31:32 PM
To avoid further misinterpretations:
a1ex linked some builds for testing (which I used)
https://www.magiclantern.fm/forum/index.php?topic=22874.msg207798#msg207798
and  dfort has downloads named Movie_crop_mode_test.

Following a1ex's test 1 I tested both builds with 650D.104:
Build a1ex: Nope, crop mode off after opening/closing card lid.
Build dfort: Yes, crop mode on after opening/closing card lid.

I suppose we may be able avoiding going round in circles by mentioning the builds  we are actually using.

So, which way to go? Clockwise or other way round?
Title: Re: Save movie crop upon start up
Post by: Danne on November 03, 2018, 08:03:45 PM
For now run only a1ex provided builds and his tests:
https://www.magiclantern.fm/forum/index.php?topic=22874.msg207798#msg207798
Title: Re: Save movie crop upon start up
Post by: dfort on November 04, 2018, 01:06:52 AM
Ok--let's try to figure this out. There is another user, @Felipe, who posted some test results on the Canon 650D / T4i topic (https://www.magiclantern.fm/forum/index.php?topic=7473.msg207849#msg207849).

On the unified branch (a.k.a. "stable" or "Nightly") and some of the experimental branches there is a line of code that is intended to turn off Movie crop mode. Why? Because users were freaking out when they switch to a non Magic Lantern card. The camera seems to be "stuck" in Movie crop mode. Note that Movie crop mode is only valid in 1920x1080 mode and simply switching to 1280x720 or 640x480 will get the camera out of this mode. So, the expected behavior on all cameras that can do Movie crop mode (EOSM, 100D, 650D, 700D) is for the camera to never be "stuck" in this mode.

However, if you use Movie crop mode regularly it would be nice not to have to keep resetting it every time you start the camera by saving the state of Movie crop mode in a settings file. That is what pull request #787 (https://bitbucket.org/hudson/magic-lantern/pull-requests/787/crop-hack-config/diff) is intended to do.

Ok, so all this works great on the EOSM but--there is a problem with the 700D. The theory is that the way the power switch is configured on the 700D (and 100D, 650D as well) is that it switches from movie mode to photo mode before switching off. Well, turns out you can't switch off Movie crop mode from photo mode, the camera has to be in movie mode. The result is that on shutdown the code that turns off Movie crop mode doesn't work.

Now let's look at the build that a1ex provided for testing. A neat trick is to open autoexec.bin in a text editor to see the details about this build:

Code: [Select]
Magic Lantern Nightly.2018Oct31.650D104
Camera   : 650D
Firmware : 104
Changeset: 565ee36ef132+ (100D_merge_fw101) tip
Built on : 2018-10-31 16:15:32 by jenkins@nightly

diff -r 565ee36ef132 src/debug.c
--- a/src/debug.c Tue Jun 05 18:26:37 2018 +0200
+++ b/src/debug.c Wed Oct 31 17:15:32 2018 +0100
@@ -275,8 +275,13 @@
 }
 #endif
 
+extern void movie_crop_hack_disable();
+
 static void run_test()
 {
+    msleep(2000);
+    movie_crop_hack_disable();
+    NotifyBox(5000, "movie crop disabled");
 }
 
 static void unmount_sd_card()
diff -r 565ee36ef132 src/tasks.c
--- a/src/tasks.c Tue Jun 05 18:26:37 2018 +0200
+++ b/src/tasks.c Wed Oct 31 17:15:32 2018 +0100
@@ -372,9 +372,6 @@
 static void ml_shutdown()
 {
     check_pre_shutdown_flag();
-#ifdef FEATURE_CROP_MODE_HACK
-    movie_crop_hack_disable();
-#endif
     ml_shutdown_requested = 1;
     
     info_led_on();

The code to disable Movie crop mode on shutdown has been removed and a test to run the movie_crop_hack_disable() function was added to the debug "Don't click me" menu.

So if the power switch theory holds true then the only test that a1ex told us to run that would turn off Movie crop mode is this one:

Test 4:
- start camera in movie mode, make sure crop mode is enabled
- stay in movie mode
- select "Don't click me" (this will call movie_crop_hack_disable)
- restart camera from power switch; is crop mode still enabled?

In fact that's what my test results (https://www.magiclantern.fm/forum/index.php?topic=22874.msg207803#msg207803) showed. Note that the question for each test is, "is crop mode still enabled?" so the expected result on test 4 is "No."

In all of Walter's 650D tests using the a1ex test build, Movie crop mode was not persistent after restarting the camera so all of his test results were "No." That wasn't expected.

Ok--so what about that shutdown code that is supposed to turn of Movie crop mode, is that working on the 650D? We have some test results for that because the builds I posted runs movie_crop_hack_disable() as a shutdown task:

Build dfort: Yes, crop mode on after opening/closing card lid.

When I turn off the camera in crop mode and turn it on again remains in crop mode,Fantastic Function. Thank you!!

Wait--this is opposite of the expected behavior! It appears that movie_crop_hack_disable() turned on Movie crop mode.

[EDIT] Or rather, the reports on my build are inconsistent with what we are seeing on the 700D.

Just for completeness, here are the tests run on the 700D showing the expected results.

Title: Re: Save movie crop upon start up
Post by: Felipe on November 04, 2018, 03:19:16 AM
Great Daniel, The 100D Does the same, But does not stay in crope mode when the battery door opens to change battery and then close it.
As well doesn't work when I change the sd card.
Same happens with the 650D Versión 105.

The 2 cameras keep the crop mode only when the camera is turned off from the switch and then turned on. Fantastic!!.

Also the cropmode can be disabled from the Canon Menu for both cameras.

Of course if I take out the sd card the camera does not stay in crop mode.
Title: Re: Save movie crop upon start up
Post by: dfort on November 04, 2018, 07:07:26 AM
@Felipe - could you please run the tests exactly like a1ex described them using the builds provided in Reply #44 (https://www.magiclantern.fm/forum/index.php?topic=22874.msg207798#msg207798) for both the 650D and 100D? Make sure to list the results of each test separately.

Note that on the 700D only test #4 turns off Movie crop mode.
Title: Re: Save movie crop upon start up
Post by: Danne on November 04, 2018, 07:31:34 AM
Try this: https://builds.magiclantern.fm/jenkins/view/Experiments/job/crop_mode_test/ (for 100D, 700D and 650D)

Test 1:
- start camera in movie mode, enable crop mode
- restart camera by opening card door and closing it back; is crop mode still enabled?

Test 2:
- start camera in movie mode, enable crop mode
- restart camera from power switch; is crop mode still enabled?

Test 3:
- start camera in movie mode, make sure crop mode is enabled
- enter photo mode from the power switch (outside LiveView)
- select "Don't click me" (this will call movie_crop_hack_disable)
- restart camera from power switch; is crop mode still enabled?

Test 4:
- start camera in movie mode, make sure crop mode is enabled
- stay in movie mode
- select "Don't click me" (this will call movie_crop_hack_disable)
- restart camera from power switch; is crop mode still enabled?

Test 5:
- start camera in movie mode, enable crop mode
- turn off camera by opening the card door
- remove the card and reboot; crop mode still enabled?
- can you disable crop mode from Canon menu? any special tricks needed?

Eos 100D
Test 1: YES
Test 2: YES
Test 3: YES
Test 4: NO(Movie crop mode is disabled the moment I press don´t click me even before the restart)
Test 5: YES to crop mode still enabled after removing the card.
The trick to disable Movie crop mode does not work when going from 24 to 25 fps
The trick to disable Movie crop mode works when going from 24 to 50 fps

Sidenote: I would like to add removing the battery to the bag of tricks to disable a "stuck in Movie crop mode" scenario like in Test 5.
EDIT: Pulling the battery includes turning the nob also to OFF or else you really are "stuck" in Movie mode even without battery. Card door disablers beware  8).
Title: Re: Save movie crop upon start up
Post by: a1ex on November 04, 2018, 08:53:03 AM
Pretty much like 700D.

When I tried to disable crop mode from Canon's touch-screen menu, I did so by pressing Q, then tapping on the video mode resolution icon. That one worked out of the box.

I did not mention battery door in the above tests, as I highly doubt anyone turns off the camera from there, unless it's already locked up. Canon firmware considers it an "emergency" shutdown; it's much more aggressive than opening the battery door (some notes in the QEMU readme (https://bitbucket.org/hudson/magic-lantern/src/qemu/contrib/qemu/README.rst?fileviewer=file-view-default#rst-header-shutdown-and-reboot)).

In the crop_rec_4k branch, I'm actually preventing Canon firmware from saving their own settings (https://bitbucket.org/hudson/magic-lantern/pull-requests/825/prevent-canon-settings-from-being-saved/diff) when turning off the camera by opening the battery door (though, my trick only covers settings handled by the main CPU, not the ones sent over to the MPU; crop mode setting is from the second group).
Title: Re: Save movie crop upon start up
Post by: dfort on November 04, 2018, 05:43:08 PM
When I tried to disable crop mode from Canon's touch-screen menu, I did so by pressing Q, then tapping on the video mode resolution icon. That one worked out of the box.

I was wondering how you were doing that.

700D in Movie crop mode
(https://farm5.staticflickr.com/4829/31844358698_a7f733c6eb.jpg) (https://flic.kr/p/QvYEpd)

Press Q button
(https://farm5.staticflickr.com/4872/43898580840_d8af433ea2.jpg) (https://flic.kr/p/29TaGFs)

Note that it highlights 1920/30. I don't want to change settings so I'll touch the 1920/24 icon.
(https://farm2.staticflickr.com/1909/31844358108_8d9d90fcac.jpg) (https://flic.kr/p/QvYEe3)

We're out of Movie crop mode!

In the crop_rec_4k branch, I'm actually preventing Canon firmware from saving their own settings (https://bitbucket.org/hudson/magic-lantern/pull-requests/825/prevent-canon-settings-from-being-saved/diff) when turning off the camera by opening the battery door (though, my trick only covers settings handled by the main CPU, not the ones sent over to the MPU; crop mode setting is from the second group).

Ok--so it won't help Movie crop mode but it looks like we could help out by looking up stubs for other cameras.

https://bitbucket.org/hudson/magic-lantern/pull-requests/825/prevent-canon-settings-from-being-saved/diff

5D3 stubs for reference:
Code: [Select]
NSTUB(0x23F4C,     terminateShutdown_save_settings)
NSTUB(0x23F50,     terminateAbort_save_settings)

Getting back to the problem at hand:

Therefore, why not keep things simple and accept the persistence of crop mode as implemented by Canon? That means, I'm tempted to undo pull request 776 (https://bitbucket.org/hudson/magic-lantern/pull-requests/776/disables-crop-mode-hack-when-turning/diff).

I agree. Only the EOSM works properly with that so until something that also works for 100D, 650D and 700D is found we should go back to the simple solution.

[EDIT] In QEMU it is possible to switch between move and photo modes, right? I take it that this isn't possible on the real hardware? What I was thinking was to switch to movie mode before running movie_crop_hack_disable() on shutdown.
Title: Re: Save movie crop upon start up
Post by: a1ex on November 04, 2018, 07:14:38 PM
[EDIT] In QEMU it is possible to switch between move and photo modes, right? I take it that this isn't possible on the real hardware? What I was thinking was to switch to movie mode before running movie_crop_hack_disable() on shutdown.

Switching to movie mode caused issues in the past, including ERR70 in my 60D in the movie mode switched from ML (but not in the native movie mode). For that reason, I've decided to remove the movie mode remap (https://wiki.magiclantern.fm/faq#where_is_movie_mode_remap) feature, even if it apparently worked just fine for a lot of users.

Mode switching is a pretty complex process; I'd like to keep things simple. Shutdown is not simple either.

Still looking for tests on 650D.
Title: Re: Save movie crop upon start up
Post by: dfort on November 04, 2018, 07:43:59 PM
Sidenote: I would like to add removing the battery to the bag of tricks to disable a "stuck in Movie crop mode" scenario like in Test 5.
EDIT: Pulling the battery includes turning the nob also to OFF or else you really are "stuck" in Movie mode even without battery. Card door disablers beware  8).

Pulling the battery doesn't get the 700D out of Movie crop mode. Could you give us the exact steps you are using on the 100D?
Title: Re: Save movie crop upon start up
Post by: Danne on November 04, 2018, 07:52:43 PM
Turn off the camera with the switch, then pull out the battery. Put the battery back in, set your camera to on.
Title: Re: Save movie crop upon start up
Post by: Walter Schulz on November 04, 2018, 07:54:30 PM
Still looking for tests on 650D.

Not covered in reply #47?
Title: Re: Save movie crop upon start up
Post by: a1ex on November 04, 2018, 07:56:12 PM
Covered, but conflicting with the reports from Felipe (unless I'm misunderstanding them).
Title: Re: Save movie crop upon start up
Post by: Walter Schulz on November 04, 2018, 08:04:54 PM
Got confused before, too.
But Felipe runs 105 software and didn't use your build. No conflict so far.
Title: Re: Save movie crop upon start up
Post by: a1ex on November 04, 2018, 08:17:30 PM
I've got that, but he says the crop mode setting is saved. Based on your reports, I cannot explain how the crop mode is saved on his camera, unless he's using a custom build from Danne (which I highly doubt).

I also doubt there is any difference between the two firmware versions, regarding this setting.
Title: Re: Save movie crop upon start up
Post by: Walter Schulz on November 04, 2018, 08:27:39 PM
Using dfort's build (for 104) I think I get the same results as Felipe.

Using your build: No crop mode after restart at all. Not confirmed by a 2nd 650D owner, though.
Title: Re: Save movie crop upon start up
Post by: dfort on November 04, 2018, 08:37:28 PM
The results from the 650D tests on Reply #47 (https://www.magiclantern.fm/forum/index.php?topic=22874.msg207810#msg207810) are inconsistent with the 100D and 700D tests. @Walter -- are you 100% sure of those results? You are saying that the 650D never gets "stuck" in Movie crop mode after a restart?

The tests results from @Felipe are not reported clearly. The report from the 1.0.5 firmware shows the same results as the 700D which is that movie_crop_hack_disable() on shutdown works when opening the card door but not with a normal shutdown using the power switch.

Note that the build @a1ex wants us to use for testing doesn't even have movie_crop_hack_disable() enabled on shutdown.

I deleted the test builds on my downloads page--make sure to use the builds a1ex posted (https://builds.magiclantern.fm/jenkins/view/Experiments/job/crop_mode_test/).
Title: Re: Save movie crop upon start up
Post by: Walter Schulz on November 04, 2018, 08:49:19 PM
You are saying that the 650D never gets "stuck" in Movie crop mode after a restart?

I'm now pretty sure I did everything to the book.
Yes, using a1ex's build for 650D.104 I get *no* persistent crop mode for tests 1 to 5.
Using a1ex's build for 100D I get persistent crop mode for test 1 (none other tested). Using your build for 650D.104 I get persistent crop mode for test 1, too.
Stopped testing right there and waiting for further instructions.
Title: Re: Save movie crop upon start up
Post by: dfort on November 04, 2018, 09:32:31 PM
Test 1:
- start camera in movie mode, enable crop mode
- restart camera by opening card door and closing it back; is crop mode still enabled?

Using a1ex's build for 100D I get persistent crop mode for test 1

Hey Walter, so you have a 100D? Great--that is what is expected with the a1ex test build. Running that same test on a current vanilla unified build should get the 100D out of Movie crop mode.

...using a1ex's build for 650D.104 I get *no* persistent crop mode for tests 1 to 5.

Understood but it breaks the logic. The 100D and 700D test results are consistent.

If you run the 100D and 650D tests side by side you should get the same results.
Title: Re: Save movie crop upon start up
Post by: Felipe on November 04, 2018, 09:48:34 PM
Now the 650D  v105 stays in crop mode when I turn it off , when take out the battery and when I take off the card,
and can be disabled with the Estándar Canon menú.

THE REASON IS I always erase all the modules since I don't use them, but Noticed that having the crop_rec.mo as well as always with the 650D_105.sym.
The camera stays in crop mode.


Title: Re: Save movie crop upon start up
Post by: Felipe on November 04, 2018, 10:20:35 PM
- YESSS THE KEY for total satisfaction with the V105 650D is to use the crop_module included in the dfort build oct 19.

- The 100D is missing that module, that is why only holds crop when turning it off from the switch.

- Tryed to copy de crop_module from the 650D to the modules folder of the 100D and does not work as the 650D.


Title: Re: Save movie crop upon start up
Post by: Walter Schulz on November 04, 2018, 11:07:35 PM
If you run the 100D and 650D tests side by side you should get the same results.

Read it from my lips: I have them side by side and I *do not* get same results. Using a1ex's builds.
Repeated Test 1 and 650D does not go into crop mode after restart. 100D does.
Awaiting instructions.

EDIT: Contacted saulbass via PN and asked to run tests on his 650D.
Title: Re: Save movie crop upon start up
Post by: dfort on November 05, 2018, 01:36:07 AM
I have them side by side and I *do not* get same results. Using a1ex's builds.

Are your 100D results the same as Danne's (https://www.magiclantern.fm/forum/index.php?topic=22874.msg207988#msg207988)?

It isn't that I can't read your lips--well maybe I can't.  :P

- YESSS THE KEY for total satisfaction with the V105 650D is to use the crop_module...

What we are testing has nothing at all to do with the crop_module. We're talking about the Movie crop mode, a.k.a. CROP_MODE_HACK that allows the EOSM, 100D, 650D and 700D to use a feature that only the 600D had. Here's an article about that 600D feature:

https://www.filmkit.net/article/why-the-3x-crop-mode-on-the-canon-600d-is-invaluable

It looks like the few 650D users that are willing to run these tests are also attracted to the 1.0.5 firmware update that I worked on (https://bitbucket.org/hudson/magic-lantern/pull-requests/914/update-to-650d105/diff). I uploaded a test build for the 650D.105 that is the same as the test build that a1ex posted. It is on my Bitbucket downloads page (https://bitbucket.org/daniel_fort/magic-lantern/downloads/).

@Felipe - Please make sure to follow the instructions exactly and report the results of each of the 5 tests. It would be great if you can run them on both the 650D and 100D to see if you get the same results that Danne got on the 100D and Walter got on the 650D.

Title: Re: Save movie crop upon start up
Post by: Felipe on November 05, 2018, 02:25:32 AM
No dfort none of the crop new features work in this build.
The Oct 19 build Everything Works perfect .
Deleted the crop module from the oct 19 build and Works perfect, YES I thought was the module but has nothing to do.

Title: Re: Save movie crop upon start up
Post by: Felipe on November 05, 2018, 02:37:21 AM
Please make the 100D with the same code or whatever it is from October 19.
Holds cropping turning off from the camera switch, Changing the battery and changing the card.
Can be disabled from the Canon menú and from ML Menu. And again has nothing to do with the crop module that I deleted and
the crop new features are totally functional.
Title: Re: Save movie crop upon start up
Post by: dfort on November 05, 2018, 03:14:39 AM
@Felipe - Please make sure to follow the instructions exactly and report the results of each of the 5 tests.

Saying that it works or doesn't or what happens when removing a module or pulling the battery or what happens on another build doesn't help us at all. Just follow the instructions exactly as a1ex posted (https://www.magiclantern.fm/forum/index.php?topic=22874.msg207798#msg207798) and report the results of each of the 5 tests.
Title: Re: Save movie crop upon start up
Post by: Walter Schulz on November 05, 2018, 05:38:26 AM
Eos 100D
Test 1: YES
Test 2: YES
Test 3: YES
Test 4: NO(Movie crop mode is disabled the moment I press don´t click me even before the restart)
Test 5: YES to crop mode still enabled after removing the card.
The trick to disable Movie crop mode does not work when going from 24 to 25 fps
The trick to disable Movie crop mode works when going from 24 to 50 fps

Are your 100D results the same as Danne's (https://www.magiclantern.fm/forum/index.php?topic=22874.msg207988#msg207988)?

Yes, I can reproduce Danne's results with 100D.

I uploaded a test build for the 650D.105 that is the same as the test build that a1ex posted. It is on my Bitbucket downloads page (https://bitbucket.org/daniel_fort/magic-lantern/downloads/).

Test results for 650D.105 are the same: No persistent crop mode at all.
Title: Re: Save movie crop upon start up
Post by: dfort on November 05, 2018, 07:29:04 AM
So on the 650D invoking movie_crop_hack_disable() on shutdown (PR #776 (https://bitbucket.org/hudson/magic-lantern/pull-requests/776/disables-crop-mode-hack-when-turning/diff)) seems to have the opposite effect of what it was designed to do.

Felipe was using builds that included PR #776 (https://bitbucket.org/hudson/magic-lantern/pull-requests/776/disables-crop-mode-hack-when-turning/diff):

The 2 cameras keep the crop mode only when the camera is turned off from the switch and then turned on. Fantastic!!.

Walter also reported on a build that has movie_crop_hack_disable() on shutdown:

Using dfort's build (for 104) I think I get the same results as Felipe.

The builds that a1ex wants us to test, as well as the new 650D.105 test build I made today, doesn't have movie_crop_hack_disable() on shutdown:

Test results for 650D.105 are the same: No persistent crop mode at all.

So if any 650D user is willing to try a few more tests--try running tests 1, 2 and 5 on a plain vanilla Nightly (unified branch).
Title: Re: Save movie crop upon start up
Post by: dfort on November 05, 2018, 03:49:39 PM
Here is an even simpler test that can be done with any build.

Movie crop mode persistence test:
- start camera in movie mode, enable crop mode
- enter photo mode from the power switch (outside LiveView)
- enter LiveView (the camera should now be out of crop mode)
- switch to movie mode; is crop mode still enabled?

On the 700D (and EOSM) Movie crop mode is still enabled. What I'd like to know is what happens on the 650D. Movie crop mode is not persistent on that camera but at what point does it turn off? Is a shutdown needed or is leaving LiveView enough to lose crop mode?

The big mystery on the 650D is why does movie_crop_hack_disable() on shutdown turn on crop mode -- and keep it on when restarting the camera. That's what users are reporting.
Title: Re: Save movie crop upon start up
Post by: dfort on November 06, 2018, 08:12:54 PM
Hum--hope these tests haven't scared off all the 650D users.

We were in the same place with the 100D:

So on the 100D Movie crop mode is never persistent no matter what you try? That doesn't make sense.

Later we found out that it worked the same as the 700D which is what was expected.

The difference with the 650D is that both cameras that were tested have had their firmware updated to 1.0.5. Maybe this has something to do with the results we're seeing? On some firmware updates I found it helps to clear the Canon settings. Maybe we should try that on these cameras?

Somewhat off topic because it doesn't affect Movie crop mode:

In the crop_rec_4k branch, I'm actually preventing Canon firmware from saving their own settings (https://bitbucket.org/hudson/magic-lantern/pull-requests/825/prevent-canon-settings-from-being-saved/diff) when turning off the camera by opening the battery door (though, my trick only covers settings handled by the main CPU, not the ones sent over to the MPU; crop mode setting is from the second group).

It only works on the 5D3. I took a look a the pull request for the unified branch and found the stubs for all the other camera models. Not sure how to run all of the tests but what I was able to run seems to indicate that it is working properly on the EOSM, 700D and 7D.
Title: Re: Save movie crop upon start up
Post by: Walter Schulz on November 06, 2018, 09:48:55 PM
Like to hear a word or two from a1ex before proceeding.
Title: Re: Save movie crop upon start up
Post by: a1ex on November 07, 2018, 09:47:30 AM
I'd say it's best if another 650D user runs the same tests, just in case.
Title: Re: Save movie crop upon start up
Post by: saulbass on November 09, 2018, 03:01:51 AM
650D.104 with 50/1.8 running magiclantern-Nightly.2018Oct31.650D104 from https://builds.magiclantern.fm/jenkins/view/Experiments/job/crop_mode_test/

1 go into crop mode open batt door / close bat door = not in crop mode
manually set to crop mode
2 turn off power / turn on power = not in crop mode
manually set to crop mode
3 - go to photo mode - click don’t click - crop mode off,
restart camera in movie mode = not in crop mode
manually set to crop mode
4 - in movie mode - click don’t click = not in crop mode,
manually set to crop mode
5 - open door remove card / close door = not in crop mode.

So summarising:
1 - No.
2 - No.
3 - No.
4 - No.
5 - No.
Title: Re: Save movie crop upon start up
Post by: dfort on November 09, 2018, 07:39:09 AM
Ok--that matches what Walter reported (https://www.magiclantern.fm/forum/index.php?topic=22874.msg207810#msg207810). So Movie crop mode isn't persistent on the 650D.

@a1ex, do you think my additional tests have any value? I'd like to see if simply switching from movie mode to photo mode outside of LiveView and back to movie mode will take it out of crop mode (Reply #78 (https://www.magiclantern.fm/forum/index.php?topic=22874.msg208040#msg208040)). Then there's the reports that using a build that invokes movie_crop_hack_disable() on shutdown has the opposite effect of what is expected (Reply #77 (https://www.magiclantern.fm/forum/index.php?topic=22874.msg208028#msg208028)).
Title: Re: Save movie crop upon start up
Post by: a1ex on November 09, 2018, 12:50:12 PM
@a1ex, do you think my additional tests have any value? I'd like to see if simply switching from movie mode to photo mode outside of LiveView and back to movie mode will take it out of crop mode (Reply #78 (https://www.magiclantern.fm/forum/index.php?topic=22874.msg208040#msg208040)).

Yes; that means we may have to use Danne's method for saving this setting in ML config file.

I'd also like to find whether enabling movie crop mode while you are in photo mode is going to work. Currently it doesn't if you test it from ML menu; need to prepare a special test build for that.

Why? When you start the camera in movie mode, you do so through photo mode. With Danne's PR - apparently made specifically for 650D - ML will restore the crop mode from the config file. If you move the lever a little slower, ML might enable crop recording while the camera is still in photo mode.

Or, if you start the camera in photo mode, and take a couple of pictures before entering movie mode, you probably don't want to lose the movie crop setting.

If enabling crop mode from photo mode doesn't work, we may have to do so right after entering movie mode (a little harder).

Then there's the reports that using a build that invokes movie_crop_hack_disable() on shutdown has the opposite effect of what is expected (Reply #77 (https://www.magiclantern.fm/forum/index.php?topic=22874.msg208028#msg208028)).

Allow me to not trust these reports.
Title: Re: Save movie crop upon start up
Post by: Walter Schulz on November 09, 2018, 01:34:46 PM
Movie crop mode persistence test:
- start camera in movie mode, enable crop mode
- enter photo mode from the power switch (outside LiveView)
- enter LiveView (the camera should now be out of crop mode)
- switch to movie mode; is crop mode still enabled?

On the 700D (and EOSM) Movie crop mode is still enabled. What I'd like to know is what happens on the 650D. Movie crop mode is not persistent on that camera but at what point does it turn off? Is a shutdown needed or is leaving LiveView enough to lose crop mode?

Using a1ex's test build for 650D.104:
-Start cam in Movie mode, enabled crop mode
-Entered photo mode by power switch*
-Entered photo mode liveview -> No cropping
-Entered movie mode by power switch
2 results:
a) Screen content frozen with histogramm and spot metering flickering. Happenend a few times in a row. Pressed Menu button ... back in business. Documenting and ... power save struck.
b) Back in crop mode. Cannot reproduce a) yet.

*: Unable to take pics in this mode. Have to reenter movie mode and turning crop off. Focus works but no reaction on full shutter button press. Doesn't matter if liveview or not.
Title: Re: Save movie crop upon start up
Post by: dfort on November 09, 2018, 07:44:30 PM
Thanks for testing Walter. More surprises from the 650D.

Allow me to not trust these reports.

I'd still like to find what movie_crop_hack_disable() on shutdown is doing on the 650D. It can be tested with a current Nightly build. Simply put the camera in Movie crop mode, shutdown, remove card and start in movie mode. Is it in crop mode? If it is then things are getting very weird.
Title: Re: Save movie crop upon start up
Post by: Walter Schulz on November 09, 2018, 08:12:56 PM
Dang, I messed up the last one! Cam was running 105 with your 2018Nov04.650D105 build!
About to run 104 with a1ex builds (crop test and plain nightly) now.

Edit: 650D.104 with a1ex crop test build behaves the same way. Couldn't reproduce frozen screen, though.

And plain nightly (2018Jul03): Same.


=====
A1ex's test suite with Nightly build (2018Jul03)

Test 1: No
Test 2: No
Test 3: No (same as 2, of course)
Test 4: No ... see 3
Test 5: No

And thanks to saulbass for testing!
Title: Re: Save movie crop upon start up
Post by: Walter Schulz on November 20, 2018, 09:43:38 AM
Shameless bump!
Where are we standing right now?
Title: Re: Save movie crop upon start up
Post by: a1ex on November 20, 2018, 11:05:21 AM
Looks like we need to keep this setting in our config file (I need to take a closer look). Meanwhile, here's another simple test.

I'd also like to find whether enabling movie crop mode while you are in photo mode is going to work. Currently it doesn't if you test it from ML menu; need to prepare a special test build for that.

Test build posted at https://builds.magiclantern.fm/jenkins/view/Experiments/job/crop_mode_test/6/ (650D, 700D, 100D, M)

This time, "don't click me" will attempt to enable crop mode.

Test procedure:
- make sure crop mode is off
- restart the camera in photo mode
- "don't click me"
- check the printed message (number should be 1)
- switch to movie mode
- is crop mode enabled?

If it doesn't work:
- start in movie mode
- make sure crop mode is off
- "don't click me"
- number should be 1
- crop mode should be enabled
Title: Re: Save movie crop upon start up
Post by: Walter Schulz on November 20, 2018, 11:49:24 AM
Test procedure:
- make sure crop mode is off
- restart the camera in photo mode
- "don't click me"
- check the printed message (number should be 1)
- switch to movie mode
- is crop mode enabled?

650D: Number is 1 and crop mode is enabled.
Title: Re: Save movie crop upon start up
Post by: Danne on November 20, 2018, 05:01:51 PM
Eos 100D
This works and enables Movie crop mode:
Quote
If it doesn't work:
- start in movie mode
- make sure crop mode is off
- "don't click me"
- number should be 1
- crop mode should be enabled

Enabling from photo mode is NOT working for the 100D:
Quote
Test procedure:
- make sure crop mode is off
- restart the camera in photo mode
- "don't click me"
- check the printed message (number should be 1)
- switch to movie mode
- is crop mode enabled?



EOSM
This works:
Quote
Test procedure:
- make sure crop mode is off
- restart the camera in photo mode
- "don't click me"
- check the printed message (number should be 1)
- switch to movie mode
- is crop mode enabled?
Title: Re: Save movie crop upon start up
Post by: dfort on November 20, 2018, 09:39:13 PM
700D

This does not work:
Test procedure:
- make sure crop mode is off
- restart the camera in photo mode
- "don't click me"
- check the printed message (number should be 1)
- switch to movie mode
- is crop mode enabled?
Number is 1 but crop mode is not enabled.

This works:
If it doesn't work:
- start in movie mode
- make sure crop mode is off
- "don't click me"
- number should be 1
- crop mode should be enabled
Number is 1 and crop mode is enabled.
Title: Re: Save movie crop upon start up
Post by: Walter Schulz on December 03, 2018, 09:37:01 PM
Are we done here?
No more testing necessary?
Title: Re: Save movie crop upon start up
Post by: dfort on December 03, 2018, 09:59:26 PM
I think this might be the best solution:

Therefore, why not keep things simple and accept the persistence of crop mode as implemented by Canon? That means, I'm tempted to undo pull request 776 (https://bitbucket.org/hudson/magic-lantern/pull-requests/776/disables-crop-mode-hack-when-turning/diff).
Title: Re: Save movie crop upon start up
Post by: a1ex on December 04, 2018, 08:07:15 AM
That would give persistent crop mode in 700D, 100D and EOS M, but not on 650D, right?
Title: Re: Save movie crop upon start up
Post by: Danne on December 04, 2018, 09:31:51 AM
I think this might be the best solution:

Therefore, why not keep things simple and accept the persistence of crop mode as implemented by Canon? That means, I'm tempted to undo pull request 776 (https://bitbucket.org/hudson/magic-lantern/pull-requests/776/disables-crop-mode-hack-when-turning/diff).

How can persistent crop be the best solution?
Last tests indicated getting closer to a solution but hard to say atm. Config file or not to config file  8)
Title: Re: Save movie crop upon start up
Post by: dfort on December 04, 2018, 02:25:17 PM
That would give persistent crop mode in 700D, 100D and EOS M, but not on 650D, right?

Right.

How can persistent crop be the best solution?

Because pull request 776 (https://bitbucket.org/hudson/magic-lantern/pull-requests/776/disables-crop-mode-hack-when-turning/diff) which is supposed to turn off Movie crop mode on shutdown only works properly on the EOSM. That means it is currently persistent on the 700D and 100D. When we were testing pull request 787 (https://bitbucket.org/hudson/magic-lantern/pull-requests/787/crop-hack-config/diff) which adds the config file it also works properly on the EOSM and yeah, it also works on the 100D and 700D but because PR #776 isn't working the config file isn't really doing its job. Try this -- using a build that incorporates PR #787 on your 100D, put the camera in Movie crop mode, shut down, pull card, restart. You'll see what I mean.

The 650D is the exception because Movie crop mode isn't persistent with or without PR #776.
Title: Re: Save movie crop upon start up
Post by: Danne on December 04, 2018, 02:44:32 PM
Ok, understood.