Magic Lantern Forum

Using Magic Lantern => Raw Video => Raw Video Postprocessing => Topic started by: Ilia3101 on July 08, 2017, 10:19:19 PM

Title: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on July 08, 2017, 10:19:19 PM
MLV App™ :P

Download the latest here (https://ilia3101.github.io/MLV-App/)


A RAW converter for MLV files with ProRes export.


(https://user-images.githubusercontent.com/30245296/41743762-0da2ceb6-75a2-11e8-8c3f-63435cd2c1a8.png)


"Compiler" app/script for macOS (https://bitbucket.org/Dannephoto/mlv_app_compiler/downloads/mlv_app_compiler.dmg) by Danne (source (https://bitbucket.org/Dannephoto/mlv_app_compiler/src)) - very easy way to compile on macOS

Guide for compiling MLV App (Linux) (https://seescho.wordpress.com/tutorial-englisch/) (and in German (https://seescho.wordpress.com/fotos/ml/)) by escho (thx :) )


(some stuff from original post...)

I began doing this this due to general frustration with Adobe, having to convert to DNG, and not being able to run MLVProducer(or any all in one solution) on my Mac. I began doing it, then Footage came along (btw good work martin), which was really exciting, but that never fixed the black level issue on elcapitan, so I continued.

I've had a lot of help with figuring stuff out on here: http://www.magiclantern.fm/forum/index.php?topic=19270.0 (http://www.magiclantern.fm/forum/index.php?topic=19270.0)
Thanks g3gg0 and a1ex and Danne.
And thanks to everyone who is developing: masc, bouncyball... all who wrote GPL code used in the app
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 08, 2017, 10:35:47 PM
This is great. I see the groundwork to something really useful and with a lot of potential. I will check this out asap. And also great that you publish early stages. Easier to follow.
Just checked with the binary. COOL. Would love to be able to use it in some of my scripts  :P
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 08, 2017, 11:58:43 PM
Would be great to see it used with your scripts! I'll add a command line version that will work similar to mlv_dump, which would be useful for integrating with scripts (and would work on Windows and Linux!)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: DeafEyeJedi on July 09, 2017, 12:01:32 AM
What have you been smoking @Ilia3101?!?!

You literally brought me back from the dead, no joke. :D
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 09, 2017, 03:47:06 AM
Nice going  :D , did a test and it crash just a black screen loaded the MLV no problem its a 14bit from my 5d2
here what the command line in terminal said.
Code: [Select]
toshibai7:~ reddeercitytv$ /Users/reddeercitytv/Downloads/MLV\ App ; exit;
2017-07-08 19:10:29.036 MLV App[1708:29213] Screen width: 1920, height: 1080
2017-07-08 19:10:29.036 MLV App[1708:29213] Physical RAM: 16384 MB
2017-07-08 19:10:29.036 MLV App[1708:29213] CPU  threads: 8
[ 2.3260, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.5108 ]
[ 2.3260, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.5108 ]
[ 2.3260, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.5108 ]
[ 5.3437, 0.0000, 0.0000 ]
[ 0.0000, 2.2974, 0.0000 ]
[ 0.0000, 0.0000, 3.4709 ]
2017-07-08 19:10:41.778 MLV App[1708:29213] unlockFocus called too many times. Called on <NSButton: 0x7fbd69c55b80>.
2017-07-08 19:11:42.953 MLV App[1708:29213] New MLV file: /Volumes/2TB Raid 0/Dans House Demo/CF Cards/Lexar1066x64GB/100EOS5D/M19-0957.MLV, strlen: 81
Block #   0  |  MLVI  |       52 Bytes
Block #   1  |  RAWI  |      180 Bytes
Block #   2  |  INFO  |       16 Bytes
Block #   3  |  RTCI  |       44 Bytes
Block #   4  |  EXPO  |       40 Bytes
Block #   5  |  LENS  |       96 Bytes
Block #   6  |  IDNT  |       84 Bytes
Block #   7  |  WBAL  |       44 Bytes
Block #   8  |  STYL  |       52 Bytes
Block #   9  |  NULL  |       36 Bytes
Block #  10  |  RTCI  |       44 Bytes
Block #  11  |  EXPO  |       40 Bytes
Block #  12  |  LENS  |       96 Bytes
Block #  13  |  WBAL  |       44 Bytes
Block #  14  |  WAVI  |       32 Bytes
Block #  15  |  VIDF  |  3070140 Bytes
Block #  16  |  NULL  |     1568 Bytes
Block #  17  |  NULL  |       36 Bytes
Block #  18  |  LENS  |       96 Bytes
Block #  19  |  VIDF  |  3070300 Bytes
Block #  20  |  NULL  |     1568 Bytes
Block #  21  |  VIDF  |  3070432 Bytes
Block #  22  |  NULL  |     1568 Bytes
etc. ........
Block #3013  |  VIDF  |  3070432 Bytes
Block #3014  |  NULL  |     1568 Bytes
Block #3015  |  VIDF  |  3070432 Bytes
Block #3016  |  NULL  |     1568 Bytes
Block #3017  |  VIDF  |  3070432 Bytes
Block #3018  |  NULL  |     1568 Bytes

MLV Info

      MLV Version: v2.0
      File Blocks: 3019

Lens Info

       Lens Model: EF24-70mm f/2.8L USM
    Serial Number:

Camera Info

     Camera Model: Canon EOS 5D Mark II
    Serial Number: ######## (I blanked the serial number)

Video Info

     X Resolution: 1872
     Y Resolution: 936
     Total Frames: 1392
       Frame Rate: 23.976

Exposure Info

          Shutter: 1/46.8
      ISO Setting: 100
     Digital Gain: 0

RAW Info

      Black Level: 1791
      White Level: 15000
     Bits / Pixel: 14

CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.


Edit: tried again and still black screen with the same warning "CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces."

File loads in mlvfs no problem , could it be a issue with Video Card/GPU ? i run a PC GTX 760 2GB Vram on Yosemite 10.10.4
didn't try on my mp5.1 with Sierra 10.12.5 yet .

Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 09, 2017, 04:27:27 AM
This also gives me a idea , since you can decode mlv i was thinking of a plugin for FCPX
Something along the lines of a RED RD3 file , which was it's own raw engine for basic adjustment like your app
with different color space profiles (e.g. red log1 , red log2 etc. ...) then debay it half size (proxy) for editing
then switch to full res for rending . I have tried the RED plugin for FCPX with sample 6K Weapon files and works great .
Really the big problem is importing the image sequences , need same kind of
data base server to tell fcpx there is "####" number of frames like compressor or A.E. . This is something that use too
work in old FCP with DPX file ( i been working off and on with this in FCPX --some success)
but now if you what to import DPX in to FCPX you need a translator (makes a reference QT file from the DPX).
Sorry Off topic , i can see this being very helpful & useful in further developments .
Keep up the good work @Ilia3101 8)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 09, 2017, 01:39:19 PM
Hi Ilia3101. Really like the image quality you already achieved.

Regarding white balance calculations and color matrices dng.c in MLVFS(dmilligan) is a good source.
https://bitbucket.org/dmilligan/mlvfs/src/24ebdf591dba0a0431cf1fb674b3a8fcd2730b62/mlvfs/dng.c?at=master&fileviewer=file-view-default
Row 61-167, color matrices for most cams.

Regarding white balance there is matrice conversion code in ufraw which dmilligan wisely put to use in MLVFS. Code also used in mlv_dump for steroids and in mlv_dump in cr2hdr.app. It works very reliable.
In dng.c row 265-474
I believe numbers are calculated with matrices in mind and kelvin number from MLV metadata. Code also respects canon other white balance modes and also from when manually setting white balance from cam. The only mode left out actually is awb(auto white balance). 

*update
Notice you already put in the matrices. Oh well. Maybe ufraw stuff could be of use...
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 09, 2017, 02:14:55 PM
@DeafEyeJedi yay!

@reddeercity About that crash, if it is a black or frozen screen, try making the app window smaller, as it seems to stop displaying/updating when the image view when it is larger than the video's image resolution. The whole displaying/refreshing code needs a lot fixing. Also it's unlikely a gpu bug, as the whole app uses just the cpu (except whatever macos does to show the window). I get all the same errors in the terminal too.
Also agree that it would be great to make it in to a plug in for final cut, just don't know where to find info about how to do that, all I've found is how to make a final cut plugins with AppleMotion templates, not C  :(

@Danne Thank you :D I'm glad you like the image quality, I do think the colour is quite different from most raw converters which makes it interesting. I will have another go at implementing matrices + proper white balance. I already tried using the matrices from dng.c (that silly attempt is present in the code), but maybe I need to have a deeper look at the other functions in dng.c.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 09, 2017, 02:23:34 PM
Going through your mlv sources and see you already had the matrices there :).

About integration with other scripts and such I think a possibility to open up selected MLV files directly into MLV.app would be great. Something like
Code: [Select]
MLV.app [drag MLV files here] enter
Anyway. Thanks for sharing. Wish I could learn this stuff and tag along the ride more in depth  :P
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 13, 2017, 08:33:34 PM
Hi, great job! For me your app works pretty good! I also own a 5D2 and the developped images are looking very well.

I downloaded your code and tried to exchange your GUI with a QT GUI. QT makes it cross platform. I get your code compiled in my project, but it crashes very often directly after these 2 init functions (initMlvObjectWithClip&mapMlvFrames). I tried to make it 1:1 to your app, but in C++. The window init seems to work without crash in the same way as you do, but the open MLV functions crashes as described. Any idea? Every (maybe) 10th try it does not crash, runs further and shows the printMlvInfo in my debug window  ;)

The app is not mac specific... except the GUI, so there is potential to make it cross platform, if I (or anyone else) finds time.

Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 13, 2017, 10:58:39 PM
Oh my god! That is amazing. It's almost embarrassing to have someone work on my unfinished and amateurish code :-X I don't know how to fix the error, but I realised the make file is missing -lm and -pthread linking flags, I'm just lucky that Apple GCC/clang didn't give an error, don't know if that will help. Thanks a lot for doing what you are. I'll be back at a computer tomorrow and hopefully more helpful :D
@Danne what do you mean by drag and drop: drag on to the app window itself, or drag on to the app's icon?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 13, 2017, 11:32:53 PM
My idea of working the binary is to do something like following:
Drag MLVapp to terminal, then drag MLV files after, then hit enter:
MLVapp [Bunch of MLV files] enter
When I hit enter MLVapp opens up with the MLV files all lined up inside your nice gui. This way it could be integrated easily in other scripts and workflows just as a start off point. Of course command line usage could probably be more advanced with options for exporting prores dng files and other stuff.
Great progress masc as well. Interesting to see where that takes you.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 14, 2017, 07:14:34 PM
Got it Danne, so basically it should work similar to mlv_dump, I didn't understand first time because I've never thought of dragging stuff and just typed it before.
Will put (int argc, char * argv[]) to use now!
It can't have files 'lined up' yet, although that's something I will work on - may be limited to 1 file for now.

Also @masc, I've been testing a few mlv files and it seems my mlv reading is unstable/crashy with older (like mostly pre 2014) or imperfect/unusual mlv files, are you testing on your own newish mlv files? I also get random errors like segmentation fault 11 sometimes(rarely) for no reason at all(can't be reproduced with the same files or actions) - it's pretty buggy right now. But I'm not sure how to really help you right now. Also what system are you running it on... Mac, Linux or Windows?

Some major (internal) changes (caching) coming to the github repository soon! (@masc, they're only internal, gui's functions calls can stay the same, tho some macros are now functions)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 14, 2017, 09:16:23 PM
@Ilia: hm... the mlv's on my system are not the newest. Maybe I should create some with the new nightly and test again.
I use a MBP, OSX 10.11 and Qt 5.9 with clang64 compiler.

I don't get errors. The whole program crashes, so I don't get any information what could be the problem. It happens always just after these two init functions (I commented out the GUIs code after the two init functions for testing inside the open mlv function, the render thread is deactivated for testing as well).

I also tried to compile on Windows, but the compilers (MinGW / Visual Studio) have problems with the SSE2 code parts - so I can't test here easily.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 14, 2017, 10:00:47 PM
@Ilia:
Okay... I tried a brandnew MLV file - but it happens the same.
You printf sometimes this "matrix" ... sometimes there are values [2.3260, 0.0000, 0.0000.... and sometimes I get something like this:

[ -912946357866009707526990653213028058425336148150934686018973565099782945134279966991682517003694157252210673599290002487573580196204258818785280.0000, 14761107278647887298426725252265747037704052213684974621093726581945448424887939218053855964164182298671129527261323489121239772820396108337520159850961657576485312434110972051719515956941968841375744.0000, -5889634654216064054910380984756813016681168569942410618451110124988385579113543784074450534795619622018286200283437444381438824073396224.0000 ]

Is that right?! Can that be the problem?!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 15, 2017, 12:28:53 AM
Oh yes! That must be the problem, thanks for letting me know, I've had the insane long value problem before, probably for other reasons (and fixed it)... could you please share a sample MLV file that is causing those problems so I can have a look? Sorry I didn't reply quickly ::)

And apologies for the insane amount of printing... More is coming with next commit :D
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 15, 2017, 10:18:45 AM
I got it: freeMlvObject is the problem! On first try to open a mlv file, the free commands will crash the app. If I comment it out, the openMlv function ends without error and I can get the file informations. :-)

Hu... sharing the MLV is not easy. My connection is really slow. But I can try to create a very small mlv file which does the same.

Edit: for getting these values, I only run the apps init function. That means, there is no mlv file loaded yet.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 15, 2017, 10:38:29 AM
Just shorten a file with mlv_dump:
Code: [Select]
mlv_dump -f 5 -o OUTPUT.MLV INPUT.MLVGives you a 5 frame MLV file.
Good work by the way masc.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 15, 2017, 03:31:00 PM
@masc Ah! yes I know, sometimes the insane matrix values appear depending on what order you do/initislise or join the 'objects', I guess you might be doing something a little differently with order of stuff in your user interface code. I guess MLV files may not have been the problem, but if possible please still share a mlv file of maybe 3-5 frames, I don't have enough samples form other people really.

@anyone Be honest: is the code awful? Was it right of me do the 'object-oriented' C approach? Should it be in C++? (I just don't know that language yet)

I've uploaded a new release on GitHub with caching, so should be quicker (updated first post link), do read the release though, or your RAM will be full in no time at all ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 15, 2017, 08:25:18 PM
@Danne: thanks, I sent a small mlv to Ilia, hope it helps!

The best work did Ilia. The project is really not small, and for a hobby project it is much more then okay, I think. Respect! The 'object orientated C' is a way you can go. I know a lot of libraries which are programmed in this way. So, if the code does what it shall do, that's good.

I'll check your new release! :-)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 16, 2017, 12:37:40 AM
I really appreciate the generosity and work of @masc, it is leading the app towards being cross platform and amazing 8)

@Danne I have implemented drag and drop:
MLVapp [Bunch of MLV files] enter
Only for one file right now though. Download link in first post is up to date.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 16, 2017, 01:03:16 AM
Works nicely over here for that one file. Good work Ilia3101.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 17, 2017, 01:11:04 AM
I will stop the frequent posts after this... but I must announce: It now has .BMP sequence export, so now more useful for testing. It is an awkward solution.

Made a preview though with some MLV files I could find:

.MLV converted with MLV App, edit in FCP10, and if you think it looks unsharp - there's zero sharpening added, as MLV App can't do that yet and I didn't want to alter the image with other software.

We are on the way to free software MLV workflow (by we I mean me :D)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 17, 2017, 01:22:31 AM
hehe, so cool. Why BMP?
There is also exr and dpx  :P And what about ProRes4444?
Please do keep posting. Very exciting.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 17, 2017, 01:24:09 AM
Only reason is because it's the only format I've figured out how to do right now :D, prores and others definitely coming soon/eventually
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 19, 2017, 08:20:37 PM
Announcement: JPEG and PNG export is added to MLV App. Download (https://github.com/ilia3101/MLV-App/releases/tag/v0.10-pre-alpha-jpeg-png-edition)
(Ultimate goal is still ProRes)

Big announcement!!!
@masc has been doing amazing work with his Qt version of the GUI. The app is now pretty much cross platform. (@masc I hope your okay with me announcing this?)
We've had some back and forth messages, and as far as I know: it compiles on macOS, Windows, and still bugging out on Linux (fault of my messy code). Here's how the Qt UI looks:

(http://image.ibb.co/b9NL9k/masc_gui.png)


@masc, can you try and compile a build for Windows and macOS and make a release on the GitHub page? No hurry, I'll try to get QT up and running and compile it myself too (I don't want to be bothering you with things like that in the future). Or is it too early?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 19, 2017, 08:27:14 PM
Beautiful work guys. Can't wait to try.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Wayne H on July 19, 2017, 09:18:08 PM
Excellent, will be following closely to see how this app develops, looks promising so far.

Do you plan on implementing some code so it can handle MLVS with lossless compression?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 19, 2017, 09:49:17 PM
@Wayne yes definitely will be adding it in the near(est) future, the app is open source and the code for lossless decompression is out there - lj92.c (https://bitbucket.org/dmilligan/mlvfs/src/24ebdf591dba0a0431cf1fb674b3a8fcd2730b62/mlvfs/lj92.c?at=master&fileviewer=file-view-default) - so implementing it should be problem-free, however when I look at it, it seems insanely confusing and I have no clue how I'd use it and what functions to call - I would like help with doing that if someone knows how to use it  ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 19, 2017, 10:29:05 PM
@Ilia: hehe, thanks. I'll try that tomorrow.
@everyone: yes, it is early to prerelease it. We have still lots of bugs. But maybe someone (like me) has fun with it ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: jpegmasterjesse on July 20, 2017, 06:42:46 AM
Looks interesting - but when I open an MLV file the GUI closes and I get something like this in Terminal:

https://drive.google.com/open?id=0B1lCd952bWxQd2FnQTYwT0NtZTQ 
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Wayne H on July 20, 2017, 04:10:23 PM
@jpegmasterjesse Same for me too, i think the code needs to be compiled or something, not sure.

@Ilia gread work dude, looking forward to the new features discussed, batch export with proress 4444 and lossless compression GOLD, :)

Hey i wonder if apple sorted out the problem with exporting to prores 4444XQ, i remember Martin Hering saying that apple's development tools didn't support it, 4444XQ would be amazing (12bit) rather than 4444 (10bit)

Oh and Ilia, as you add new features i'll be happy to test and report any bugs etc, keep up the good work.
i'm so with you on why your making this new app, Magic Lantern has some great post software, but there still isn't a proper native MAC app that does everything, without tedius work arounds, that MLP app looks cool, but not a native mac app and no lossless compression support, and footage app was brilliant but needs batch export and that black level issue is a problem plus,Martin has disapeared off the face of the planet lol, so no updates. MLVFS is a great time saver, but it only spits out CDNG and i find working in da vinci a pain (personal Preferance) i LOVE FCPX,

Hopefully overtime this app will address all these teething problems.

Thanks again for doing this.  :D
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 20, 2017, 04:16:22 PM
Quote
4444XQ would be amazing (12bit) rather than 4444 (10bit)
Prores4444 is as much 12bit as XQ.
XQ is for vfx and green screen mainly. I can't tell the difference inspecting output.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Wayne H on July 20, 2017, 04:27:35 PM
I always thought Prores 4444 was 10bit lol, must have got confused with proress 422HQ being the 10bit one, oh that's great, no need to even worry about 4444XQ then. Thanks for the correction :)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: flostro on July 20, 2017, 05:35:47 PM
"Apple ProRes 4444 XQ and Apple ProRes 4444 support image sources up to 12 bits"

https://images.apple.com/final-cut-pro/docs/Apple_ProRes_White_Paper.pdf

the ffmpeg encoder for example only supports ProRes444 with 10-bits
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 20, 2017, 05:58:26 PM
Looks interesting - but when I open an MLV file the GUI closes and I get something like this in Terminal:
Hmmm, looks weird, its as if your video's frames repeat twice or something... Could you try with another MLV file, it should not happen... if it does, then we can investigate why it happens on your system, it it does not happen with other clips, you can send the MLV file that caused the problem... if you want... so I can try and understand why it happened. @Wayne H You get it too?, on all MLV files you try? If so, tell me what version of macOS you have and what era/what model of Mac you are on and @jpegmasterjesse please do that too if possible.

@Wayne H, yeah I think it's nice that the app can be taking full advantage of macOS in the Cocoa version and be cross-platform because there's a Qt version, I think Linux is particularly in need for such an app right now. For testing: just keep track of MLV App's GitHub release page (https://github.com/ilia3101/MLV-App/releases), and anything significant will be announced on this thread too.

(@main ML people) is the name "MLV App" okay? I feel it makes it sound too official. I was originally planning to come up with something more fancy, but I've started to like it a little bit.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 20, 2017, 06:40:01 PM
Okay. First buggy version of the Qt GUI is online on GitHub. ;)
https://github.com/ilia3101/MLV-App/releases/tag/QTv0.1alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.1alpha)
@Ilia: you can link it on the first post, if you like.
@All: have fun.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 20, 2017, 07:13:06 PM
Promising looking gui. No time to test this yet. For mac users. See to it to hold down ctrl button first time you open the app to bypass gatekeeper. Will test more later. Great efforts guys.
(https://s1.postimg.org/7184ot51b/Screen_Shot_2017-07-20_at_19.16.52.png)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Wayne H on July 20, 2017, 07:28:37 PM
@Ilia Yes the same thing happens to me, the app GUI closes and terminal opens, i'm currently running macOS Sierra 10.12.5 and using late 2016 MacBook pro.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 20, 2017, 07:34:53 PM
@Wayne H thanks, I'll do some more investigation/ testing on 10.12.5, I'm only using 10.11, so there's a chance its related to that.

@masc, I understand it seems to still have a lot of problems compiling on Windows and Linux, and its mostly down to the mlv / processing code, right?
So do you think it would compile with less difficulty if I refactored the code to fit the C standards more strictly? Things like declaring variables at start of scope etc...
(Also added link to first post)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 20, 2017, 07:47:55 PM
@Ilia: "a lot of problems" sounds so bad... no, maybe I take only the wrong flags for compiling. I only got a complete exe by compiling half with a -std=c99 flag and half without this flag. I know I should not do that... ;) Maybe there is someone out there knowing better solutions for such problems.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 20, 2017, 08:10:40 PM
@masc Ah, sorry, so its flag problem mostly, I'll be refactoring the code that needs it over time anyway. Been setting up Qt myself on a windows PC to see what I can do.
Also: I noticed the new Qt version(testing on mac) redraws slower (than the version you sent me a couple of days before) when dragging a slider, have you changed image output setup or compiled it with different flags or something? Otherwise, I probably made a change that slowed it down, all I can think of is the 'single frame cache', but that was to speed up redrawing in pretty much that specific scenario.
Oh wait, I figured out why... I saw before you were only using 2 CPU threads, but now I guess you're using all, and I noticed this slowness only happens when it says caching is active. Maybe its a good idea to use a bit less than all cores for caching? I just set the Cocoa version to be (all cores / 2) + 1.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 20, 2017, 08:41:37 PM
@Ilia: yes, you are right. Before I used only 2 cores, now all for background caching. Thats why it is slow when caching and fast when idle. But it is very fast, when I disable the processing in the code (getting 23 frames on my Core2Duo) ;-)

Edit: set it now to All-1, thats much faster in the GUI! Thx!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 21, 2017, 06:40:28 AM
Tried the Wins version and no joy !

(http://image.ibb.co/hE1c75/error_1.jpg) (http://imgbb.com/)

and

(http://image.ibb.co/kXhjn5/error_2.jpg) (http://imgbb.com/)

Win7 pro AMD FX8350 dual GPU's GTX580's
I'll try in on my dell laptop i5

Edit: Same thing on i5 Intel dell laptop Wins7 Pro , 8GB ram , gpu radeon HD 4300
 
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 21, 2017, 08:02:45 AM
 MP5.1 Sierra 10.12.5 dual quad core cpu (16 thread) 24GB ECC ram GPU GTX570 2.5GB Vram
Works here --but i have pink hi lights , are you using apple camera raw ?
happen when i drop the exposure to -2 something .
good job so far . 3x crop mlv from about 3years ago
(http://preview.ibb.co/ntDRZk/Screen_Shot_2017_07_20_at_11_41_44_PM.png) (http://ibb.co/dGFvS5)(http://image.ibb.co/iaNg0Q/Screen_Shot_2017_07_20_at_11_44_34_PM.png) (http://imgbb.com/)

The BPM export , FYI --in A.E. ACR & Resolve i don't have pink hi lights

(http://preview.ibb.co/gWGMZk/M27_1210_00145.png) (http://ibb.co/bFvtfQ)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 21, 2017, 08:19:44 AM
Same file in Footage.App --no pink hi lights .
(http://preview.ibb.co/mB4KLQ/Screen_Shot_2017_07_21_at_12_13_10_AM.png) (http://ibb.co/mKnH75)

What Color Space are you using ? sRGB ?
wonder it that could be a issue .
Anyways Great job --keep it going  :)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 21, 2017, 09:47:09 AM
Tried the Wins version and no joy !

Win7 pro AMD FX8350 dual GPU's GTX580's
I'll try in on my dell laptop i5

Edit: Same thing on i5 Intel dell laptop Wins7 Pro , 8GB ram , gpu radeon HD 4300

Ups... thanks for trying it out! On my PC that does not happen, because the whole framework is installed. But I think I found out which libraries are missing. Will upload it this evening!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 21, 2017, 09:52:01 AM
@reddeercity, the pink highlihgts most likely are because MLV App reads the white level from the MLV files, I think most apps don't do that, and in that MLV file, the white level was probably too low, so the app was cutting off much of the information. In the next release I'll add an automatic correction if it seems unusually low, see if it helps. If it remains... I will have to research why everything else does better, maybe theree's a simple algortihtm to fix it to an extent. What about RAWTherappeee or one of the opensource apps, do they have these problems with the same file??

Also no, i'm no using 'Apple Camera RAW', I've made my own, which is the whole reason it can be cross platform.

Colour space: welll.... this one's not done yet, but I've had many conversations with g3gg0/a1ex/Danne and understand it, just had a few difficulties implementing so its not done yet, but I'm going to have another go at implementing colour space management, right now it is something along the lines of 'Camera RAW (RGB) Space - Probably Close to sRGB'

@masc Forgot to mentiion, I had the same issue as reddeercity running on PC - pentium n4200 laptop (not mine :D)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 21, 2017, 12:05:41 PM
I found it and updated the version on git. Some .dlls were missing...
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 21, 2017, 09:15:24 PM
Works here --but i have pink hi lights , are you using apple camera raw ?
Could you please try again with with the same clip and this (https://github.com/ilia3101/MLV-App/releases/tag/v0.11-pre-alpha-white-level-repair) release? I've added auto white level repair, seeing if it helps. However I hear my GUI has problems with 10.12.5, so you may have to run it on a different Mac or wait for another Qt release, the mac you run it on makes zero difference... though it may in the future (once I figure out openCL and GPU ;))
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 22, 2017, 04:44:37 AM
Yea No Joy with that release , GUI fires up but crash when loading the same mlv files from before. The crossplatform MLV-App (Qt) version works on my mp5.1 on sierra 10.12.5 but not other ones , I'll try may mbp on Yosemite and report back .
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 22, 2017, 04:51:45 AM
I found it and updated the version on git. Some .dlls were missing...
Great thanks --GUI fires up but crashes on loading mlv file , the same one i've being testing in the previous posts with my mac
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 22, 2017, 06:12:25 AM
Testing on MBP Early 2011 Yosemite 10.10.5 , i7 , 8GB ram, GPU : Intel HD Graphics 4000
Version:MVP APP (Jul21 2017 19:56:17 @llia-EliteBook-2560p.local) White level Fix
Same thing pink hi lights with that special white level build . There no problem with the white level it's at 15000
as per the info from terminal as this app open up .

Code: [Select]
MLV Info
MLV Version: v2.0
      File Blocks: 728
etc. ......
RAW Info
       Black Level: 1791
      White Level: 15000
     Bits / Pixel: 14

Notice that the slider for adjustment did not register any number change for "1" see image below
(http://preview.ibb.co/fqksaQ/Screen_Shot_2017_07_21_at_9_17_52_PM.png) (http://ibb.co/jxffUk)

If i load the version: (MLV APP Jul 19 2017 19:15:46 @ilias-iMAC.home) main download with out white level fix the screen is black after i load the same mlv file  see below image
(http://preview.ibb.co/nnpw25/Screen_Shot_2017_07_21_at_9_31_51_PM.png) (http://ibb.co/iBmyFQ)

hope this helps .
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 22, 2017, 03:36:14 PM
@reddeercity thanks for testing, now I know that my RAW processing is not that great yet :D, still need to learn how proper highlight handling works :(, the reason the old version didn't work at all for you was not to do with white level, but rather the way I did GUI redrawing, so good to know I've fixed the GUI that didn't work on some systems before.

Don't worry about it not registering the numerical value on the sliders, I'll fix that soon, it does not affect processing, simply not linked up the text with the value yet.

Genuine question: Does anyone have any knowledge about how to fix pink highlights? What kind of algorithm is needed?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 22, 2017, 03:41:10 PM
Are they blown highlights? Dcraw get pinks when rebuilding blown highlights. I couldn't test this because the app closes upon selecting a mlv file. Mac os sierra 12.3.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 22, 2017, 03:49:23 PM
Are they blown highlights?
Yes, they are blown highlights, but as reddeeercity said, pretty much every other piece of software showed less pink highlights, ACR, resolve, even footage. I have seen pink highlights in all of those softwares before, but it seems mine is particularly bad, so I'm wondering if there's an obvious/well known way of fixing them.
Dcraw get pinks when rebuilding blown highlights.
Hmm, mine doesn't rebuild highlights at all, so is there something relatively simple that all raw converters do that I'm not aware of?
I couldn't test this because the app closes upon selecting a mlv file. Mac os sierra 12.3.
Yea that's strange, I sometimes get that, I'm testing on Sierra 10.12.6 and 10.11, the way I've avoided it most of the time is either trying a different file, or opening files with a single click, then pressing open button in the dialog instead of double click, for some reason I've noticed it helps ::)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 22, 2017, 04:04:59 PM
I will try some fresh 14bit files later. Thanks for reminder. Good luch on highlights meanwhile. Sorry I couldn't help more on this issue.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: DanHaag on July 23, 2017, 01:09:43 AM
I always get a crash with "Segmentation fault: 11" mentioned in the Terminal window. No matter how often I try - it happens with all my MLVs (shot just a couple of month ago). Downloaded the Cocoa Mac app, using it on the latest Sierra 10.12.06.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 23, 2017, 06:20:40 AM
Are they blown highlights?
Yes, they are blown highlights .....
No , they are not blown hi light --that was the point of all this
I'll post frames with example of the hi lights thought different app shortly
 
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 23, 2017, 08:50:22 AM
Ok here we go -- As you can see there's no blown out hi light as seen in your new app.
Top image is from A.E. ACR CS6 Cdng's from Quick-mount with mlvfs on my PC exported as a 16bit Tiff from A.E.ACR

(https://farm5.staticflickr.com/4321/35260941094_dae67af5e7.jpg) (https://flic.kr/p/VHTxjf)
A.E.ACR_M27-1210_00000 (https://flic.kr/p/VHTxjf) by RedDeerCityTV (https://www.flickr.com/photos/67942440@N06/), on Flickr

Bottom Image is from MLVProducer Exported as  a 16bit Tiff (tried to quickly match the 2 , close  :D )

(https://farm5.staticflickr.com/4323/36100868285_0cbc26b0fb.jpg) (https://flic.kr/p/X17opx)
mlvproducer_M27-1210_00001 (https://flic.kr/p/X17opx) by RedDeerCityTV (https://www.flickr.com/photos/67942440@N06/), on Flickr

I also export a ProRes4444 from A.E.ACR CS6 , if you would like to view locally (about 450MB) 
https://drive.google.com/file/d/0BxNY4d4Aa7KuOTJmcUJlX3VtcVk/view?usp=sharing

and also export a ProRes4444 from MLVProducer , if you would like to view locally (about 450MB)
https://drive.google.com/file/d/0BxNY4d4Aa7KudkdpaVZmOFl1TEE/view?usp=sharing

Here is the Original MLV(M27-1210.MLV) I being test with (1.13GB)
https://drive.google.com/file/d/0BxNY4d4Aa7KuaU5TX0ZQUXVyNkk/view?usp=sharing
hope this helps
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 23, 2017, 09:00:42 AM
..... but as reddeeercity said, pretty much every other piece of software showed less pink highlights, ACR, resolve, even footage.
No sorry I think you miss understood , I Do Not See any pink Hi lights in those apps at all just in your new app.
I think maybe some how you are clipping the hi lights in the mlv raw decode ? or the conversion  to 8bit color space ?
Just a thought  ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 23, 2017, 03:38:27 PM
No sorry I think you miss understood , I Do Not See any pink Hi lights in those apps at all just in your new app.
I think maybe some how you are clipping the hi lights in the mlv raw decode ? or the conversion  to 8bit color space ?
Just a thought  ;)
Ok I completely understand what you are saying now: the clip does not have blown out highlights (according to you)

I decided to investigate a little bit... (thank you for sending the clip)

Here's MLV App handling it:

(http://thumb.ibb.co/iUse5Q/MLV_App_Highlights.png) (http://ibb.co/iUse5Q)

...not too well

I tried opening it in RawTherapee, and looked like no highlights were blown:

(http://thumb.ibb.co/btqcs5/RT_Default.png) (http://ibb.co/btqcs5)

But then I turned off highlight reconstruction, it suddenly showed the highlights had no detail, similar to my app:

(http://thumb.ibb.co/jWatX5/RT_Highlight_Reconstruction_Disabled.png) (http://ibb.co/jWatX5)
 
However they were not pink like MLV App, but white instead, it is probably doing some kind of equal clipping.

Then I opened it in MLRawViewer, and the highlights looked like this:

(http://thumb.ibb.co/iqVGkQ/MLRaw_Viewer_Highlights.png) (http://ibb.co/iqVGkQ)

The brightest highlights had discolouration, suggesting MLRawViewer is reconstructing them.

Then I looked at highlights in darktable RAW converter:

(http://thumb.ibb.co/ctPLC5/Dark_Table_Highlights.png) (http://ibb.co/ctPLC5)

And results were similar to MLV App.

So I have concluded that the highlights in that video are clipped, but all of your software did a good job of reconstructing them (leading you to believe they were not clipped).
Thank you for starting the whole discussion reddeercity and sending me the clip, so now I can be certain that MLV App needs highlight reconstruction.

... the reason clipped highlights are pink is that green channel clips first.

If anyone has any links to info about how highlight reconstruction works, it would be greatly appreciated, but I think I have an idea of how it could be done.

@DanHaag, unfortunately I can't help at this time specifically, as those errors are hard to track down... especially when someone else is having it,
but that kind of error tends to eventually get resolved over time as the app gets more stable (from my experience).
If you want, you can send an MLV sample that causes problems for you and I can check if it's the file causing problems or not.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: DanHaag on July 23, 2017, 03:49:03 PM
That's all right, I'll just try your app again when you've developed it further and report back with more intel in case the error still keeps happening. Thanks for all your work so far btw.!  :)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 23, 2017, 07:16:40 PM
@reddeercity, ok it turned out basic highlight reconstruction is really easy and even most simple software should do it... New release (https://github.com/ilia3101/MLV-App/releases/tag/v0.12-pre-alpha-highlight-reconstruction-edition)

How it works:
Program checks if highest possible green value is below white (65535), and if it is, every green value that high will be replaced by an average of that pixel's red and blue channel.

Comparison gif:

(http://image.ibb.co/iZwpN5/reconstruction.gif)


@DanHaag cheers
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 23, 2017, 08:33:41 PM
I also added Ilias Highlight Reconstruction (for me that works really good!) to the Qt GUI. I deleted the BMP, JPG and PNG export but added a ProRes 4444 export (8 bit atm, we are working on more... ;) ).

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.2alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.2alpha)

Windows port comes in the next days (I hope).
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 23, 2017, 08:53:17 PM
Nice!

Just tested it though, and got this:

(http://image.ibb.co/fe5PN5/error_MLVApp.png)

I highlighted what I guess must have been the error ::) Seems to be a forgotten DLL or something (Got the same error on 10.11.6 and 10.12.6)

Now it's time to make the Cocoa GUI catch up to the Qt one :D still needs to : get native Apple video export working and add a play button.

A small request to people with other cameras:
My 5D mark II does not have 720p or high framerate mode, so could someone please send a sample file shot in 50/60p or 720p in Canon menu,
I want to get 1.66x desqueezing working for mv720/3x5, but first I need to know what the headers in those files say, and of course an mlv file to test on.

Thanks  ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 23, 2017, 09:10:27 PM
:( Sry for that, but QtWidgets is in the package, so I don't understand that. I compiled it on OSX 10.9 today. I'll search for a solution.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 23, 2017, 09:31:40 PM
Okay friends... new try! I uploaded it again, on my other mac with OSX 10.11 it runs now (had the same problem before).
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 23, 2017, 09:36:01 PM
Niiiiiice - works now!

Still looking for a high framerate/720p sample ;) ...anyone?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 23, 2017, 09:39:56 PM
When you say high framerate... in the QtGui the ProRes export is forced to 25fps at the moment. But will work on that as well. If someone has a highspeed sample, I would be interested too!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 24, 2017, 06:22:03 AM
@Ilia3101 Yes I can confirm on Yosemite 10.10.5 , no more pink hi lights  ;D
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: pc_bel on July 25, 2017, 04:02:23 PM
Quote
Still looking for a high framerate/720p sample ;) ...anyone?

Just sent by Wetransfer via PM.

By the way. I can't open any mlv in your APP. Every time I try, APP crashes. I'm using v0.2 alpha (Cross platform version) on Windows 10.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 25, 2017, 07:24:11 PM
By the way. I can't open any mlv in your APP. Every time I try, APP crashes. I'm using v0.2 alpha (Cross platform version) on Windows 10.

Thanks for trying it out and giving a feedback! I have the same problem for nearly all my mlv files. The maximal file size I got opened was about 200MB. We did not yet figure out why it crashes on windows.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: pc_bel on July 25, 2017, 07:37:59 PM
@masc
Oh! sorry!!!.. You are the developer for the windows version... I thought was Ilia3101...
I'm waiting for an app to review mlv files without to need to convert to dng (I don't know why but can't make working MLVFS), so your app is my main hope!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 25, 2017, 08:59:56 PM
@pc_bel Thank you very much for the sample! I already got one from Danne, but having different ones is very important, so thanks a lot
I'm sorry... I hope the Windows issue gets sorted out soon, me and masc are having some DMs about it today, we may be close to finding the cause.

@masc, I'm sorry for not testing MLV App v0.2 yet (despite saying I'd do so this morning)... The laptop I used before has been stuck on Configuring Windows Updates 35% for hours :'( not sure what to do.

@reddeercity good ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: pc_bel on July 25, 2017, 09:14:41 PM
@Ilia3101 @masc

You are wellcome!!!... If you need some more sample, just let me know. Thanks for all your hard work. You are awesome.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 26, 2017, 10:25:23 AM
Nice! No more crashing on macOS Sierra 10.12.3
Exported to format png. Not bad. Files are looking really good. Any plans for dng exports ;).
Anyway.
How are prores exports in the cross platform version handled? Thought I read ffmpeg somewhere but I must have dreamt that.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 26, 2017, 11:06:59 AM
You didn't dream it ;) not sure about all the details of how masc's implementation works though, but it is definitely ffmpeg. The Cocoa version will hopefully get native macOS/AVFoundation powered prores export, but AVFoundation is taking me a while to figure out.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 26, 2017, 12:46:02 PM
How are prores exports in the cross platform version handled? Thought I read ffmpeg somewhere but I must have dreamt that.
Yes, since version "Qt 0.2 alpha" we have prores export for Windows and Linux. I had problems to include a library version of FFmpeg. That's why I took the command line app to the package. So at the moment it is realized very easy: first a png sequence is rendered and then these pictures are converted to the mov. This is not optimal, because the pngs have only 3x8bit.  For the future I plan to take the library of FFmpeg, because we get more than 8bits... ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 26, 2017, 12:54:02 PM
I see, intermediate png. You should be able to get 10bit prores4444 out of ffmpeg. I run that in Switch.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 26, 2017, 08:32:13 PM
Right, it is 10 bit. Unfortunately the png output of Qt is only 8 bit... What do you mean with Switch?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 26, 2017, 08:34:58 PM
Switch, open source scriptbased macproject.
http://www.magiclantern.fm/forum/index.php?topic=15108.0

 
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 26, 2017, 09:06:39 PM
Ah okay. Thx. I read that a time ago, great project... :)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 29, 2017, 02:41:07 PM
I uploaded a new version of the Qt app for OSX & Windows. The windows version has caching disabled, so we have only a view crashes, but it is a little slower. Now it crashes (for me) only on files >2GB. Have fun!
https://github.com/ilia3101/MLV-App/releases/tag/QTv0.3alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.3alpha)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on July 31, 2017, 11:24:13 PM
New release of Cocoa version! (https://github.com/ilia3101/MLV-App/releases/tag/v0.14-pre-alpha-prores-export-added-edition)

Has ProRes 4444 export. Finally!
It is a temporary solution as it uses ffmpeg, not AVFoundation, but it makes the app a whole lot more usable. Used masc's intermediate PNG method for now.
Note: When you export prores, the app will freeze with the spinning ball, this is it exporting, not a crash. Just leave it until done for a few minutes.

Also converted it in to a .app bundle - in it's current state where it uses ffmpeg, it cannot work outside the bundle as a command-line app, but this ability will be returned once it gains AVFoundation export, as it will be able to live as a single executable file.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 01, 2017, 12:03:06 AM
hehe, great progress!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on August 02, 2017, 01:19:23 PM
Fixed the main problem of the app's processing: poor highlight rolloff
There is now a 'Reinhard Tonemapping' option.

Comparison:
(http://image.ibb.co/i4ns4k/Reinhard_Highlights.png) (http://ibb.co/m1F1x5)
Tone mapping disabled on the left, enabled on the right.

Also it's different from highlight reconstruction, as it does not create new highlights, it simply avoids clipping existing ones.

New release on GitHub. (https://github.com/ilia3101/MLV-App/releases/tag/v0.15-pre-alpha-highlight-rolloff-edition)

Next step is adding audio support. Is MLV sound compressed?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 02, 2017, 01:24:14 PM
Looks very nice Ilia!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 02, 2017, 02:08:58 PM
Sound from MLVs not compressed it's pure PCM.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 03, 2017, 11:29:59 PM
Not bad, Reinhard tonemapping. I tried to export to ProRes4444 but couldn´t get a file out. After pressing button a prompt want s me to "open"? A folder perhaps :)? Anyway. Pressing open didn´t get me a file.

Speaking of tone mapping. FFmpeg seems to be doing something...
https://patchwork.ffmpeg.org/patch/4361/

Hable tonemapping?
Slide 140
https://www.slideshare.net/ozlael/hable-john-uncharted2-hdr-lighting
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on August 04, 2017, 12:07:11 AM
@bouncyball Thanks, working on sound currently

@Danne yeah, I guess the open dialog is confusing, its a slight hack I had to do before I put it in an .app bundle - I had to use an open dialog instead of a save dialog.
You are right: you choose a folder and it exports to there after you click open (the app & dialog freeze as if to crash, but you just need to wait a couple of minutes while it exports - it is in need of a progress bar, I promise I'll fix that soon)

And speaking of the "Hable tonemapping" - I came across it while looking in to tone mapping, just Reinhard was the easiest to implement - literally: value = value / (1.0 + value), but adding a better more complex tone mapping formula wouldn't hurt the performance at all, as the app precalculates a 0-65535 look up table (processing is done in 16 bit integers), instead of calculating all pixels individually. I might do that soon, as from what I've seen Uncharted2 mapping looks a little better.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 04, 2017, 12:43:48 AM
You´re right. I chose an unshortened file and as expected created PNG files and then...nothing :). Got this message. Last line.
Code: [Select]
2017-08-04 00:47:42.136 MLV App[85848:713418] Exported frame 143 to: /Users/dan/Desktop/MLV_files/test_Ilia/.temp_png/frame_00143.png
sh: (null): command not found

Does it mean I have 143 png files in a hidden temp folder?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on August 04, 2017, 01:15:18 AM
The files are most likely deleted by the app, but to check, do this in terminal: 
Code: [Select]
defaults write com.apple.finder AppleShowAllFiles YES.
Then go to the export directory (that you chose) in finder, and if there is a greyed out looking folder called .temp_png, delete it, if not, then the app automatically deleted it and it's fine. You can then do the terminal command but with 'NO'

Not sure why it didn't work for you, did you use the executable file on its own outside the app bundle?

I've done the prores 4444 export on videos up to 245 frames long by the way ;D
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 04, 2017, 01:18:19 AM
I compiled from source "make" and double click the mlv app binary. Gui opens and terminal window is also opened.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on August 04, 2017, 01:23:04 AM
Ah I see! The way I've got the makefile set up is: you need to type 'make app' not just 'make', if you want an app bundle.

There's a whole shell script and a compiled+executed c program inside the makefile that builds the app bundle during the make process.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 04, 2017, 01:50:25 AM
Now that is badass. Got my first baby ProRes :)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: DeafEyeJedi on August 04, 2017, 01:54:55 AM
@Ilia3101 continues to make waves. This is all indeed badass!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 04, 2017, 02:06:15 AM
Yes. You can make a "log"-like prores with corrected white balance in no time. Makes all the difference. The file comes out looking real nice.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: pc_bel on August 04, 2017, 10:46:51 AM
Hi,
Now with v0.3 alpha I don't have any crash!!!! :) but I can see... nothing. Just pink noise. I'm playing 14bit lossless files in the qt version of the app.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 04, 2017, 11:58:22 AM
but I can see... nothing. Just pink noise. I'm playing 14bit lossless files in the qt version of the app.

What platform do you use? And what size do the files have? I am not sure, if the code from @Ilia supports lossless already.
I get a lot of pink noise when (normal) mlv files are bigger 2GB, on both, Mac & Windows. We have plans to avoid that in future...
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on August 04, 2017, 03:21:57 PM
I haven't implemented lossless yet, but I looked at the lj92 library yesterday, and it looks kind of understandable actually.

I'll try to send a commit to github with lossless today.

@Danne Soon we'll add options for ouput curve, featuring a few different variations of log. I think I've found a seemingly good explanation of how to generate a log curve: http://renderstory.com/log-color-in-depth/ (http://renderstory.com/log-color-in-depth/)

You can make a "log"-like prores with corrected white balance in no time.
Enabling Reinhard + using the lighten adjustment actually shold give a similar curve to log, except for the shadows probably.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: pc_bel on August 04, 2017, 06:06:38 PM
Oh!!! Sorry. I didn't notice that lossless is a To Do think.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on August 05, 2017, 06:18:16 AM
Good morning!!!1!!!!!!!

Lossless is added. (https://github.com/ilia3101/MLV-App/commit/a990912b869823f9926478a01b42dddc379d9753) Have fun, 5D mark III users :D

Download New Release (https://github.com/ilia3101/MLV-App/releases/tag/v0.16-pre-alpha-lossless-edition)

The LJ92 decompression library is fast af.

Or wait for @masc to make a release of the Qt version if you want a more stable and featurefull app :-X
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: mesebar2 on August 05, 2017, 09:58:18 AM
Thank You, Ilia3101!!!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 05, 2017, 11:08:17 AM
hehe, great work Ilia.
By the way. If anybody wants to unhide hidden folders I found a short command for this:
Hold down CMD Shift . (dot)
Just redo it to go back to hidden again.

I did this to delete the png folder after interrupting processing.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 05, 2017, 01:44:11 PM
Or wait for @masc to make a release of the Qt version if you want a more stable and featurefull app :-X

Thanks to @Ilia3101! Here comes the Qt version, at least for OSX (Windows version has to be compiled, but atm I have no PC nearby):

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.4alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.4alpha)

New in this version:
- Lossless support
- Reinhard tone mapping
- Full bit depth ProRes 422 Proxy, LT, Standard, HQ and 4444 export
- Multithread export
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Wayne H on August 05, 2017, 03:06:46 PM
Excellent work @masc and @Ilia, superb progress, just ran a lossless file, and exported to prores 4444 really well, quick question though, you say it supports full bit depth, does that mean prores 4444 is exported to 4444 12bit??

Danne kindly pointed out that you really can't see any quality difference between 10bit and 12bit prores files, which for the most part i agree, but i use colour finale within FCPX alot, so every extra (bit) help's,

so i just wanted to know, if the 4444 files are 12bit, or did you just mean the exported prores files are all now 10bit, as previously this app was only producing 8bit 4444 files.

Many thanks.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 05, 2017, 03:55:27 PM
Big difference between 10bit and 12bit prores4444. What I pointed out was the quality between 12bit prores4444 and 12bit prores4444XQ.
What is the winning deal in this app is that you retain scene referred dynamic range prior to export. This can't be done in apple compressor for instance. I'd take FFmpeg 10bit prores4444 scene referred log before display referred apple compressor XQ files any day of the week.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Wayne H on August 05, 2017, 05:24:22 PM
Hi Danne, thank's for correcting me once again :), you was indeed referring to 4444 12bit vs 4444XQ 12bit,my bad lol, so does this app spit out 4444 12bit files or 10bit 4444 files?? I always seem to get confused with some magic lantern apps, as some only support 4444 10bit, (or so i've read) get's a little confusing.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 05, 2017, 05:55:18 PM
It's 10bit from FFmpeg. You can get 12bit from AE, not from FFmpeg.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on August 05, 2017, 06:33:07 PM
@Danne Thanks for the shortcut, that's amazing :o

The Cocoa version will soon get 12bit ProRes export (I hope).. once I switch to using AVFoundation instead of FFMpeg.

And credit to those who did the real work in this case(lj92): Andrew Baldwin and Martin Herring

Also what does 'scene referred dynamic range' mean? Does it just mean you can use the whole range of the raw data? (I don't know all the technical video terms)

Also, everyone seems to love using log here... just wondering, what are the technical reasons for that? Do you linearise it and somehow edit it like raw again? or just grade it with plugins in other apps? I personally find I get better results when I use the raw converter to add all the main effects like contrast and saturation, it just feels more flexible than dealing with colour too much once it is no longer in RAW
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: kyrobb on August 05, 2017, 06:45:27 PM
Thank to Ilia and Masc! This is truly incredible. I think the reason people want LOG so bad may be to apply LUTS later on more easily. I can't say for certain. I would agree with you that it is awesome to be able to tune your look right in the raw processor. Maybe built-in LUT support would satisfy everyone? Thanks again though you guys this is already amazing for my use!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 05, 2017, 06:48:39 PM
Quote
Does it just mean you can use the whole range of the raw data?
Yes. Check a dng and it´s all rec709 clipping whites. Clipping applies to ProRes in apple compressor and then a lot of information is gone.
Logs are perfect for batch encoding. Export for instance cineon based log ProRes4444 and then apply any additional color correction in a NLE. Another workflow would be to apply a log as a base and then color correct in MLV app. If it could add several logs in a row even better. So there is 1D luts and 3D luts and colorspace stuff. These are just thoughts Ilia and masc. I see you´re app as a great tool even without any lut adding...

Built in logs would be great.
cineon
logC
Bmdfilm
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 05, 2017, 07:10:41 PM
Full bit depth means, we use the maximum FFmpeg supports (via 3x16bit PNG). Before we had only 8 bit, now it is 10 bit I think. I heard FFmpeg can also export 12 bit ProRes 4444 XQ, but I had no luck until now. I found that for 4444 XQ:
Code: [Select]
ffmpeg -i input.mov -codec prores_ks -pix_fmt yuva444p10le -alpha_bits 16 -profile:v 4444 -f mov output.movBut when I tried the file size was half from 10 bit 4444, and VLC was not able to play the file :D Anyone tried that before?

Edit: -pix_fmt yuva444p10le means 10bit, or?! Really confusing!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 05, 2017, 07:18:05 PM
I've been down that road with dfort. Not tested that one in particular masc but a lot of other settings. Nothing topped 10bit prores4444. Well maybe RAW export but those files are humongous and nothing can edit those whale files natively :).
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on August 05, 2017, 07:50:54 PM
Built in logs would be great.
cineon
logC
Bmdfilm

This is exactly what I aim for ;D An output curve(and or colourspcae) selector with options such as those. One of the next steps.

Maybe built-in LUT support would satisfy everyone?
Sounds like a good idea, might be one of the more difficult ones to do though. Might happen little later down the line.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: DeafEyeJedi on August 05, 2017, 10:35:46 PM
Can't disagree w @Danne's suggestions. So far a pretty solid foundation. Looking forward to it's further development and much thanks to @Ilia3101 & @masc...

Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 05, 2017, 11:44:42 PM
That app is getting pretty cool, histogram and progress bar.
I see you use darkframe averaged MLV files Deafeyejedi. Never though about it but it will yield even nicer results regarding vertical stripes in shadows and better color rendering.
Are those files compressed or uncompressed? * nevermind "Lossless".
Is the pinkish areas coming from lossless files? Could you try the same file decompressed Deafeyejedi? You can decompress in Switch by selecting (11) in the mlv_dump menu. Then select (d) and (r) to get the file decompressed.

(https://s2.postimg.org/90viqa24p/Screen_Shot_2017-08-05_at_23.55.23.png)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on August 06, 2017, 07:08:01 AM
@ Ilia3101 --this may help clear up color space , LOG and ProRes4444QX (which is up to 16bit linear with alpha  BT2020 (9-1-9) color space/profile and Rec 709 (HD1-1-1) color space/ profile
 https://images.apple.com/final-cut-pro/docs/Apple_ProRes_White_Paper.pdf

FFmeg is 10bit no matter 444 or 422hq , 422 , etc. ..... and at rec709 so (HD 1-1-1) color profile and yes still clipping hi-lights .

ProRes 4444XQ(AVFoundation) in Apple Compressor& Motion ,  Resolve  is the only way to retain Full D.R. in Linear Space So No Clipping.

I first uses to backup all my MLV's to ProRes 4444XQ LOG Space to rec709 , now I backup to Linear LOG ProRes 4444XQ+Alpha(16bit) in BT2020 Wide Gamut .

using FFmpeg there's a quality loss compared to OSX AVFoundation , especially with heavy grading & or FX (green screen etc...) breaks down quickly when push were
10bit does not have the gradation needed --only Billions of Color Vs Trillions+ Color in XQ or even plain old 4444 from AVFoundation.

That's what stops me from using any App that exports FFMpeg ProRes .
My 2 Cents worth




Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 06, 2017, 09:10:37 AM
How can going from 14 to 12 bit be lossless? 2 bits are gone, even with 16bit alpha.
Also linear? How? Last I tried it was still the same srgb curve output in ac.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on August 06, 2017, 10:51:38 AM
I'll have to look in to colour spaces and stuff more, but tell me if I'm wrong... I think it works like this: in most processing software, the processing is done in floating point, meaning the values can be in a massive range, and deciding where to clip them for encoding a video is difficult. In my app however, this range is limited to 0-1 (0-65535 really), so it does lots of tricks to avoid clipping highlights(values reaching the limit), and as far as I know anything that remains in that range, will be kept in the image, no matter if the accuracy is reduced to 8 bit or 10 bit.

Unless the software (ffmpeg) is doing something horrific, I don't see why there's a big problem. Definitely going to use AVFoundation in the future, as it is faster and makes sense for the cocoa app.

Gone for 2 weeks...
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: DeafEyeJedi on August 07, 2017, 09:31:47 PM

Is the pinkish areas coming from lossless files? Could you try the same file decompressed Deafeyejedi? You can decompress in Switch by selecting (11) in the mlv_dump menu. Then select (d) and (r) to get the file decompressed.

Done. Seems to be slightly better if not the same? Maybe it's cuz I ETTR'd a bit too much. Or could this be related to the 3.5k experimental stuff? I wanted to get the most details as possible in shadows @ ISO 6400 regardless during this test clip especially after DF process.  8)


Also here's a second example in 12-bit lossless 1080p @ ISO 800 with the Reinhard tonemapping comparisons below. Even opens up large MLV files w ease such as this one was over 61 GB's.


Notice when using Waveform Monitor which shows pretty good details and as accurate as possible whereas if you go back to the Histogram Monitor which shows a complete under exposed diagram when clearly it isn't. Is this a bug? Does this happen on your end as well?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: kyrobb on August 07, 2017, 09:59:50 PM
Is there any way to adjust values by typing the desired value? Or is it slider only? That feature would be very useful for more precise adjustment.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 08, 2017, 12:12:19 PM
Notice when using Waveform Monitor which shows pretty good details and as accurate as possible whereas if you go back to the Histogram Monitor which shows a complete under exposed diagram when clearly it isn't. Is this a bug? Does this happen on your end as well?
Thanks for testing! I am impressed that it handles such big files... The histogram is the same on my side. But I don't see a underexposed picture, I see an extremly overexposed picture when you disable the Tonemapping. The histogram normalizes all values to the maximum value. On the very right the histogram shows a very huge value, that all other values seems to be very small. I don't know how other applications handle that... Photoshop for example shows exactly the same on my computer, but cuts of such peaks... however they are doing that.
What you could try: when exporting, MLV App creates all frames as PNG first. If you are fast enough (I think so if you handle big files  ;D) get one of these PNGs and open in another application offering a histogram. You can compare then.

Is there any way to adjust values by typing the desired value? Or is it slider only? That feature would be very useful for more precise adjustment.
It is slider only for now. On windows you can use the arrow keys for the most precise steps supported. On OSX that seems not to work. On OSX you can scroll on the slider, but system default is 3 steps, so scrolling once on exposure changes by 0.03. Typing the value is a bigger change to the software, because it is not supported by default.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 09, 2017, 07:38:58 PM
In the last days (or nights) I found a solution for the value adjustment: Is it okay to doubleclick the value label and a small spinbox pops up? There it is possible to enter the value and the slider will be set. That works for all sliders but saturation... there we have a log curve behind the slider, so the precision is not the best  ;D

For the histogram I was playing a lot around, but found no solution so far. If anyone has an idea how to cut peaks without cutting half of the histogram, let me know please. I tried a log-y-axis, but it was not really better with that.

I prepared nearly everything for batch export. I created "sessions", what means you can open many clips to the app, adjust the sliders independant for each clip, you can open and save these sessions. Now I am working on the export. I hope I have that implemented until the weekend.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 09, 2017, 07:46:13 PM
Super nice!
Quote
I prepared nearly everything for batch export. I created "sessions", what means you can open many clips to the app, adjust the sliders independant for each clip, you can open and save these sessions
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: kyrobb on August 10, 2017, 12:22:25 AM
Wow. Even more incredible! Amazing work masc! Save-able sessions is genius!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: pc_bel on August 10, 2017, 10:22:46 PM
Masc!!!
Thanks fot all your dedication!!!! (Same for Ilia3101 ;) )
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 11, 2017, 08:07:48 PM
Here comes the MLV App cross platform GUI v0.5 alpha. The nice engine from Ilia3103 is still the same, but the GUI was growing:

- Receipts: copy and paste the slider settings from one clip to another, reset settings to default
- Sessions: new, open & save (with receipts), import MLV to session, delete selected MLVs from session
- Export selected clips from session at once
      - For batch export the filename stays equal to the MLV, but with .mov ending, folder is selectable
      - Free filename at single file export
- "Near-to-fullscreen-mode", by pressing S and E (makes right and left sidebar un-/visible)
- Context menus on picture and scope for easier control
- Popup on each slider value label for typing the value
- Some bugfixes

Problems:
- Real fullscreen is implemented, but so buggy (a known Qt problem, the documentation tells) -> disabled for this version
- Still problems on Windows with files >2GB
- Caching is disabled on both, Win & OSX, because I had lots of problems when changing the MLV.

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.5alpha

Have fun. I hope there are not too many bugs inside...  :P
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: DeafEyeJedi on August 11, 2017, 08:13:06 PM
Thanks for keeping up with us trolling over this thread. I just tested briefly w v0.5 alpha and noticed that if I try to import by clicking on the Folder Icon (it wont let me choose anything since it's all greyed out even the MLV's) and if I instead do File > Import MLV (Command+I) which then works like normal. Is this to be expected?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 11, 2017, 08:16:29 PM
Yes, that is okay. I changed the Icon, because I think the MLV is imported and the main file type is the session. That is different to the version before. The "Film"-Icon is for importing the MLV files now (4th icon).
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: kyrobb on August 12, 2017, 12:06:57 AM
Thanks again for all your hard work! I'd make another suggestion but I honestly couldn't if I tried. This app wonderfully simplifies my workflow and is working beautifully so far!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 12, 2017, 02:05:40 PM
@Ilia3101, masc:

Hey guys great progress!
Can you provide me with any Linux/GCC Makefile for easy kickstart?
I want to compile QT version on linux.

br
bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 12, 2017, 07:30:23 PM
Can you provide me with any Linux/GCC Makefile for easy kickstart?
I want to compile QT version on linux.
Great! You don't need a makefile. You just need Qt (with QtCreator), zlib and libpng (development version, I use 1.6.31). Then you open the .pro file in the folder platform/qt/ and with some luck you are able to compile. When I tried that on Linux, I had no luck, because my Ubuntu was to old. I had only a Qt4.x, but you need 5.x (I know that it works on 5.6 and later on Win&OSX).
First you will have to add a equivalent for in the .pro file:
Code: [Select]
macx: INCLUDEPATH += /usr/local/include/libpng16/
macx: LIBS += -L/usr/local/lib/ -lz -lpng
You can write something starting with
Code: [Select]
linux-g++*: ....and you won't break the Windows and Mac version.
The libraries from Ilia will be compiled first. I had the same problems on linux as on windows: some of the files will compile only with (have a look in the *.pro):
Code: [Select]
linux-g++*: QMAKE_CFLAGS_RELEASE += -msse2the other files only with:
Code: [Select]
linux-g++*: QMAKE_CFLAGS_RELEASE += -msse2 -std=c99So activate the first line, compile (will end with errors), activate the second line, compile again and it should work. Maybe anyone knows how to set the flags independently for different source code files... I don't know ;)
With some luck that's it and you are able to open it on Linux. Maybe you know how to build a complete package for distribution.
Good luck!

Edit: one more thing: It won't start from QtCreator without a little trick: in Creator, when the project is opened: go to the left "Project",  chose your Dev-Kit, chose Run, and there is a checkbox... don't know how it is named in english... maybe something with "Library path... DYLD_LIBRARY..." uncheck it and it will run in Creator.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 12, 2017, 09:08:29 PM
Thanks :) I'll try with QtCreator tomorrow.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 13, 2017, 10:51:08 AM
crashing everytime I try to open lj92 mlv :/ (OS X el capitan 10.11.6)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 13, 2017, 11:16:01 AM
crashing everytime I try to open lj92 mlv :/ (OS X el capitan 10.11.6)
Could you please provide such a file? (A small one please ;))
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 13, 2017, 09:17:50 PM
Could you please provide such a file? (A small one please ;))

Ok I'm doing it asa I can reach décent connexion (I'm making a shooting in india now :) )


Envoyé de mon iPhone en utilisant Tapatalk
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 14, 2017, 07:00:14 PM
@masc: I've managed to compile "MLV App" for linux with QT 5.9.1

1. Linux section in MLVApp.pro looks like this:
Code: [Select]
# Linux
linux-g++*: QMAKE_CFLAGS_RELEASE += -O3 -msse4.1 -mssse3 -msse3 -msse2 -msse
linux-g++*: INCLUDEPATH += /usr/local/include/
linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng
Compiled/installed zlib and libpng and MLV App compiles smoothly on the very first pass. No other hoop jumping needed (with about 30 warnings though).

2. I had to add "*.MLV" in dialog because file names are case sensitive here:
Code: [Select]
void MainWindow::on_actionOpen_triggered()
{
    //Stop playback if active
    ui->actionPlay->setChecked( false );

    //Open File Dialog
    QStringList files = QFileDialog::getOpenFileNames( this, tr("Open one or more MLV..."),
                                                    m_lastSaveFileName.left( m_lastSaveFileName.lastIndexOf( "/" ) ),
                                                    tr("Magic Lantern Video (*.mlv *.MLV)") );

3. Some more stuff: when "MainWindow::openMlv( QString fileName )" invoked first time there is no MLV object exists hence "freeMlvObject( m_pMlvObject )" causes immediate core dump. I don't actually understand why it works for mac or mingw :P. Commenting out "free" does a trick and MLV loads and can be processed. However If you need to import second MLV, dialog freeses. I guess it's expected. Can you collaborate on this issue?
Code: [Select]
void MainWindow::openMlv( QString fileName )
{
    //Set window title to filename
    this->setWindowTitle( QString( "MLV App | %1" ).arg( fileName ) );

    //disable drawing and kill old timer and old WaveFormMonitor
    killTimer( m_timerId );
    delete m_pWaveFormMonitor;
    m_dontDraw = true;

    /* Destroy it just for simplicity... and make a new one */
    //freeMlvObject( m_pMlvObject );

    /* Create a NEW object with a NEW MLV clip! */
    m_pMlvObject = initMlvObjectWithClip( fileName.toLatin1().data() );

4. When exporting to prores - everytime this process stops on 50% of PNGs files. Don't know why yet :)

regards
bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 14, 2017, 08:54:43 PM
Could you please provide such a file? (A small one please ;))

https://drive.google.com/open?id=0B1B8Pb9cDF2YUlJFSVcwNTcydjA

here a link to one small MLV
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 14, 2017, 10:19:33 PM
@masc: I've managed to compile "MLV App" for linux with QT 5.9.1

1. Linux section in MLVApp.pro looks like this:
Code: [Select]
# Linux
linux-g++*: QMAKE_CFLAGS_RELEASE += -O3 -msse4.1 -mssse3 -msse3 -msse2 -msse
linux-g++*: INCLUDEPATH += /usr/local/include/
linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng
Compiled/installed zlib and libpng and MLV App compiles smoothly on the very first pass. No other hoop jumping needed (with about 30 warnings though).

2. I had to add "*.MLV" in dialog because file names are case sensitive here:
Code: [Select]
void MainWindow::on_actionOpen_triggered()
{
    //Stop playback if active
    ui->actionPlay->setChecked( false );

    //Open File Dialog
    QStringList files = QFileDialog::getOpenFileNames( this, tr("Open one or more MLV..."),
                                                    m_lastSaveFileName.left( m_lastSaveFileName.lastIndexOf( "/" ) ),
                                                    tr("Magic Lantern Video (*.mlv *.MLV)") );

3. Some more stuff: when "MainWindow::openMlv( QString fileName )" invoked first time there is no MLV object exists hence "freeMlvObject( m_pMlvObject )" causes immediate core dump. I don't actually understand why it works for mac or mingw :P. Commenting out "free" does a trick and MLV loads and can be processed. However If you need to import second MLV, dialog freeses. I guess it's expected. Can you collaborate on this issue?
Code: [Select]
void MainWindow::openMlv( QString fileName )
{
    //Set window title to filename
    this->setWindowTitle( QString( "MLV App | %1" ).arg( fileName ) );

    //disable drawing and kill old timer and old WaveFormMonitor
    killTimer( m_timerId );
    delete m_pWaveFormMonitor;
    m_dontDraw = true;

    /* Destroy it just for simplicity... and make a new one */
    //freeMlvObject( m_pMlvObject );

    /* Create a NEW object with a NEW MLV clip! */
    m_pMlvObject = initMlvObjectWithClip( fileName.toLatin1().data() );

4. When exporting to prores - everytime this process stops on 50% of PNGs files. Don't know why yet :)

regards
bb
@bouncyball
Great!!! Thank you!
1.&2. I'll add that.
3. That's strange. I'll have a look at that.
4. Ups... I forgot to tell you, that you need ffmpeg. In the function startExport() it is called... I think we need a #ifdef for Linux then.

@12georgiadis
Thx. I'll have a look!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 14, 2017, 10:56:21 PM
3. Some more stuff: when "MainWindow::openMlv( QString fileName )" invoked first time there is no MLV object exists hence "freeMlvObject( m_pMlvObject )" causes immediate core dump. I don't actually understand why it works for mac or mingw :P. Commenting out "free" does a trick and MLV loads and can be processed. However If you need to import second MLV, dialog freeses. I guess it's expected. Can you collaborate on this issue?
@bouncyball:
For 3.: I don't find a reason why that crashes on Linux. The pMlvObject exists, it comes from initLib(), which is called in the constructor. And freeMlvObject frees only the memory which initMlvObject() allocated. Can you try in which line it crashes?

@12georgiadis:
For me the app does not crash, but I get a clean darkred single colour picture for all frames. It seems to be a 14bit lossless file, is that right?
Edit: if I look into the code of your file, there is nearly everywhere the same data... are you sure this file is not currupted in any way? Do get it opened with another application?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 15, 2017, 05:46:10 AM
@bouncyball:
For 3.: I don't find a reason why that crashes on Linux. The pMlvObject exists, it comes from initLib(), which is called in the constructor. And freeMlvObject frees only the memory which initMlvObject() allocated. Can you try in which line it crashes?

@12georgiadis:
For me the app does not crash, but I get a clean darkred single colour picture for all frames. It seems to be a 14bit lossless file, is that right?
Edit: if I look into the code of your file, there is nearly everywhere the same data... are you sure this file is not currupted in any way? Do get it opened with another application?

Yes, I can open it with mlvfs + mlrawviewer/resolve/cliphouse etc.


Envoyé de mon iPhone en utilisant Tapatalk
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 15, 2017, 08:58:00 AM
Yes, I can open it with mlvfs + mlrawviewer/resolve/cliphouse etc.

Okay. I can open it in mlvfs+resolve, too. But it looks 100% the same as in MLVApp (only white balance adapted to the result of resolve).

(https://image.ibb.co/gcG6cF/Resolve_MLVApp.jpg)

Sorry, but I still think your file is corrupted!

Edit: MlRawViewer also shows the same.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 15, 2017, 01:27:14 PM
@masc

For 3.: I don't find a reason why that crashes on Linux. The pMlvObject exists, it comes from initLib(), which is called in the constructor. And freeMlvObject frees only the memory which initMlvObject() allocated. Can you try in which line it crashes?
Crash been caused by fclose(video->file) in freeMlvObject()

This patch is working:
Code: [Select]
/* Free all memory and close file */
void freeMlvObject(mlvObject_t * video)
{
    isMlvActive(video) = 0;

    /* Close MLV file */
    if(video->file) fclose(video->file);

I wanted to patch it like this:
Code: [Select]
    if(video->is_active) fclose(video->file);
but, unfortunatelly as I understand, "is_active" field of "mlvObject_t" never used in code yet ;) (not used in openMlvClip() either)

Now I can load several MLVs without a problem. Next is to test it with ffmpeg :D

bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 15, 2017, 02:43:01 PM
Putting ffmpeg side by side with MLV App binary solved exporting stuck at 50% issue.

BTW no slash "\ -> /" fixing in PATH needed.

So exporting is working fine :)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 15, 2017, 02:52:59 PM
Okay. I can open it in mlvfs+resolve, too. But it looks 100% the same as in MLVApp (only white balance adapted to the result of resolve).

(https://image.ibb.co/gcG6cF/Resolve_MLVApp.jpg)

Sorry, but I still think your file is corrupted!

Edit: MlRawViewer also shows the same.

Excellent, now working with another clip without crashing ! Good app for preview ! Now I can get rid of mlrawviewer ;-) Do you think you'll add cdng export and fixing issues settings ?
thx !

Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 15, 2017, 06:39:23 PM
This patch is working:
Code: [Select]
/* Free all memory and close file */
void freeMlvObject(mlvObject_t * video)
{
    isMlvActive(video) = 0;

    /* Close MLV file */
    if(video->file) fclose(video->file);
Superb! Thank you so much! I changed that and commited it into the repos.

BTW no slash "\ -> /" fixing in PATH needed.
I don't get that. What did you do? \" is just a " in QString. It is for getting spaces in the paths and filenames to work, for example.

But very cool, that you got it working on Linux! Is it possible to make a kind of package, or has it to be compiled always for using it on Linux? I'm not deep enough in Linux...

Excellent, now working with another clip without crashing ! Good app for preview ! Now I can get rid of mlrawviewer ;-) Do you think you'll add cdng export and fixing issues settings ?
thx !
Hej, cool, fine that it works for you too now. Thanks. MlRawViewer is still better in performance, because it uses GPU - we don't do for now.

Can cdng hold processed picture data? I thought it is also a kind of RAW, that is why I did not think about exporting cdng yet (don't know if Ilia3103 did).

What do you mean with "fixing issues settings"?

We just started developping this little app, we'll see where our way goes.  ;D
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 15, 2017, 07:32:33 PM
I don't get that. What did you do? \" is just a " in QString. It is for getting spaces in the paths and filenames to work, for example.
Ah, I meant there is no need to handle Windows/Unix slash differences in paths separately. I guess QT lib does it for you.

But very cool, that you got it working on Linux! Is it possible to make a kind of package, or has it to be compiled always for using it on Linux? I'm not deep enough in Linux...
Well if we link MLV App statically with libpng16 and zlib libraries It should run on any 64bit linux system.

Also It's possible to make deb or rpm package from it, maybe I'll try if I have more time :). It's just have some dependencies: QT, libegl1-mesa, pthread, zlib1, libpng16.

Btw, when proggie's running every slider movement causes lots of debug info output on stdout like:
Code: [Select]
[ 1.6808, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.3847 ]
[ 2.0365, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.0108 ]
[ 2.3260, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.5108 ]
[ 5.3437, 0.0000, 0.0000 ]
[ 0.0000, 2.2974, 0.0000 ]
[ 0.0000, 0.0000, 3.4709 ]
m_lastActiveClipInSession 0

regards
bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 15, 2017, 08:00:19 PM
Ah, I meant there is no reason to handle Windows/Unix slash differences in paths separately.

Ah okay. Did I handle that sparately anywhere?

Well if we link MLV App statically with libpng16 and zlib libraries It should run on any 64bit linux system.
Also It's possible to make deb or rpm package from it, maybe I'll try if I have more time :). It's just have some dependencies: QT, libegl1-mesa, pthread, zlib1, libpng16.

That would be really cool! Hope you'll find time... ;)

Btw, when proggie's running every slider movement causes lots of debug info output on stdout like:
Code: [Select]
[ 1.6808, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.3847 ]
[ 2.0365, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.0108 ]
[ 2.3260, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.5108 ]
[ 5.3437, 0.0000, 0.0000 ]
[ 0.0000, 2.2974, 0.0000 ]
[ 0.0000, 0.0000, 3.4709 ]
m_lastActiveClipInSession 0

Yes, right. Most of that comes from Ilias code. But that is no problem to switch off. Maybe we could implement some #ifdef DEBUG or whatever around.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 15, 2017, 08:10:13 PM
Ah okay. Did I handle that sparately anywhere?
Nope, but I always have to do it when using plain C and I hate this so much, hahaha :P
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 15, 2017, 08:35:22 PM
LOL, okay. Got it now.  8)

I did something against all the debug outputs now. It is on github.

Another question: can you open files bigger than 2GB on Linux? On OSX it is no problem, on Windows some while(..) will never end... It think the comparisons between uint64_t and long are the problem (see compiler warnings), but I did not get it fixed until now... maybe I'll wait for Ilia to let him fix that. :)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 15, 2017, 09:33:37 PM
Superb! Thank you so much! I changed that and commited it into the repos.
I don't get that. What did you do? \" is just a " in QString. It is for getting spaces in the paths and filenames to work, for example.

But very cool, that you got it working on Linux! Is it possible to make a kind of package, or has it to be compiled always for using it on Linux? I'm not deep enough in Linux...
Hej, cool, fine that it works for you too now. Thanks. MlRawViewer is still better in performance, because it uses GPU - we don't do for now.

Can cdng hold processed picture data? I thought it is also a kind of RAW, that is why I did not think about exporting cdng yet (don't know if Ilia3103 did).

What do you mean with "fixing issues settings"?

We just started developping this little app, we'll see where our way goes.  ;D


Ok, didn't know that it was cpu based.
Cdng may Be a good export option because we often Color correct after the editing but mlv are still not covered by NLEs. ProRes is ok with cinelog and xq option (not ffmpeg 10bits only export). With that option, we'd have the choice to correct raw Before and after the editing.
Fixing issues settings : bad pixels, v. Stripes... etc (all options available in mlvfs/mlv dump/ mlv producer)



Envoyé de mon iPhone en utilisant Tapatalk
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on August 15, 2017, 09:39:15 PM
I'm still going to be gone for a week ish(no code), but now I've got more of an internet connection.

@masc Sessions looks perfect, does it save it in a format yet? I'd like to be able to read that on the cocoa GUI in the future too (that needs lots of catching up).
See if you can fix any of the bugs easily, if you can, why wait for me :D
And yes, CDNG is a raw format (holds only Bayer data and almost identical to DNG), but it's ok to do some processing like removing vertical stripes or fixed pattern noise. I have thought about it, I like the idea of making a separate DNGing 'library', but I really have no idea how the dng format works.
Also audio_mlv.c might get done soon ;)

@bouncyball oh, I thought I had already put is_active to use... I'm probably going mad then. Maybe that's why I always had annoying problems trying to do certain things before.

Lots of good progress going on here.

And proper log output curves are still on the to-do list  :-\
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 16, 2017, 09:02:09 AM
Another question: can you open files bigger than 2GB on Linux? On OSX it is no problem, on Windows some while(..) will never end... It think the comparisons between uint64_t and long are the problem (see compiler warnings), but I did not get it fixed until now... maybe I'll wait for Ilia to let him fix that. :)
Yes I noticed those warnings too.

As I see windows build is 32 bit thas is why "-D_FILE_OFFSET_BITS=64" switch needed to pass to the compiler to seek more than 2gb files.Try:
Code: [Select]
win32: QMAKE_CFLAGS_RELEASE += -msse2 -std=c99 -D_FILE_OFFSET_BITS=64
or compile x64 binary with mingw.

I don't experience this issue because Linux binary is 64bit.

regards
bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 16, 2017, 09:26:11 AM
And yes, CDNG is a raw format (holds only Bayer data and almost identical to DNG), but it's ok to do some processing like removing vertical stripes or fixed pattern noise. I have thought about it, I like the idea of making a separate DNGing 'library', but I really have no idea how the dng format works.
Also audio_mlv.c might get done soon ;)
Here all latest stuff for ML raw data handling/processing ever written/modified by ML developers or me :) It's all structured in my version of mlv_dump on steroids:
1. all latest cDNG handling stuff - cDNG Library  (https://bitbucket.org/bouncyball/magic-lantern/src/41e69f78254d40bd2ce65c4001b41560cd965c75/modules/mlv_rec/dng/?at=mlv_dump-on-steroids) and more.
2. latest Raw Processing Stuff (https://bitbucket.org/bouncyball/magic-lantern/src/41e69f78254d40bd2ce65c4001b41560cd965c75/modules/mlv_rec/raw_proc/?at=mlv_dump-on-steroids) modified and restructured. Includes stripes correction, bad/focus pixel fix, pattern noise fix and chroma smooth.

@bouncyball oh, I thought I had already put is_active to use... I'm probably going mad then. Maybe that's why I always had annoying problems trying to do certain things before.
Maybe :D

regards
bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 16, 2017, 12:13:18 PM
@masc Sessions looks perfect, does it save it in a format yet? I'd like to be able to read that on the cocoa GUI in the future too (that needs lots of catching up).

Thx. Yes it saves in a XML, I called it MASXML (MLV App Session XML). It holds all files and parameter settings of the session. Atm I have only one file opened with your lib, so caching makes no sense. All cached frames get deleted when changing the clip. So I disabled it for now.

See if you can fix any of the bugs easily, if you can, why wait for me :D

I just wait because I did not got it resolved yet ;) ... the 2 whiles work with a small change, but I run into other problems then.

And yes, CDNG is a raw format (holds only Bayer data and almost identical to DNG)

So if we only want MLV -> cDNG, why not just using mlv_dump? It does exaclty that. This means just not needed complexity in this app, because it is a processing app and exporting to cDNG means exporting unprocessed frames... maybe we could just add a menu item which "remote controlles" mlv_dump. Or did I missunderstood?

As I see windows build is 32 bit thas is why "-D_FILE_OFFSET_BITS=64" switch needed to pass to the compiler to seek more than 2gb files.Try:
Code: [Select]
win32: QMAKE_CFLAGS_RELEASE += -msse2 -std=c99 -D_FILE_OFFSET_BITS=64
or compile x64 binary with mingw.

Thanks again! Unfortunately that does not do the job :( I have still the problem with the never-ending while loops. When looking for Qt on Windows 64bit on the Qt download page, there is only a version with VC compiler (or we have to build it ourself). But when trying before I did not get it to work with MSVC. :( Maybe I should spend more time on that again.

The processing stuff of mlv_dump looks really interesting! Bad pixel fix, pattern noise and so on... would be great to have it in MLV App!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 16, 2017, 12:34:30 PM
Quote
So if we only want MLV -> cDNG, why not just using mlv_dump?
+1
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 16, 2017, 03:14:19 PM
maybe we could just add a menu item which "remote controlles" mlv_dump. Or did I missunderstood?
Yup, would be right decision, the whole point of this app is to skip creation of intermediate files. This also concerns DNGs. When you implement ffmpeg vial lib, MLV App is gonna be truly end to end processing tool.

The processing stuff of mlv_dump looks really interesting! Bad pixel fix, pattern noise and so on... would be great to have it in MLV App!
If you'll have any questions regarding processing I'm ready to answer with pleasure :)

bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 16, 2017, 04:19:10 PM
What is still missing in osx MLV apps in general is a GUI that covers the preview function and the corrections before transcoding/rewrapping. If we can avoid MLV => CDNG and do all corrections/check in MLV, it would be perfect. I'm currently shooting a documentary and I'm using this workflow :

0) shoot lossless MLV + H264 proxys with sound
1) offload cards and checksum with rsync
2) visual check with Mlrawviewer/MLV app
3) open MLVFS to generate virtual CDNGs => fix settings (v. stripes etc.) (sometimes also using Swtich from Danne and MLV_Dump)
4) Resolve 14 => cinelog or Alexa Lut => sync sound from H264 proxys (find average offset) => export 444 12 bits XQ
5) Fcpx => import 444 XQ => generate proxys + lut r709
6) editing on any NLE
7) online edit, back on Resolve 14, color correct
8) Export APR 444 (DSM)

ideal workflow would be :

0) shoot lossless
1) offload, visual check, apply LUT, color correct, fix settings, sync sound, export APR 444 12 XQ + APR Proxys in the same time (or CNDG + DPX/TIFF if necessary) ALL this steps in one app and one batch ;-)

Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 16, 2017, 07:23:12 PM
@Ilia3101, @masc

I forgot one thing to ask

In amaze_demosaic.c there are 3 inline funcs:
Code: [Select]
__inline float xmul2f(float d)
__inline float xdiv2f(float d)
__inline float xdivf( float d, int n)
gcc (under linux) or mingw-gcc (under windows) always complains and outputs error that they are not defined.

changing "__inline" to "static INLINE" solves the issue.
How do you compile w/o applying these changes?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 16, 2017, 10:06:00 PM
If you'll have any questions regarding processing I'm ready to answer with pleasure :)

:) I think Ilia or me, we will do that! Cool!

gcc (under linux) or mingw-gcc (under windows) always complains and outputs error that they are not defined.
changing "__inline" to "static INLINE" solves the issue.
How do you compile w/o applying these changes?

Okaay, I had always one big problem under windows, maybe this could solve it: I don't get everything compiled with
Code: [Select]
win32: QMAKE_CFLAGS_RELEASE += -msse2 -std=c99so I did a compiler run with this before
Code: [Select]
win32: QMAKE_CFLAGS_RELEASE += -msse2some module(s?) compile, others with error, I switch the flag again and the other modules compile and link in the end. Not the best to do so... I know... but I found no other solution so far. Maybe your hint solves this issue. I'll try tomorrow! Do you think that's it?

1) offload, visual check, apply LUT, color correct, fix settings, sync sound, export APR 444 12 XQ + APR Proxys in the same time (or CNDG + DPX/TIFF if necessary) ALL this steps in one app and one batch ;-)

I think this is not so far away from what I think MLV App could do in the future ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 17, 2017, 07:29:59 AM
:) I think Ilia or me, we will do that! Cool!

Okaay, I had always one big problem under windows, maybe this could solve it: I don't get everything compiled with
Code: [Select]
win32: QMAKE_CFLAGS_RELEASE += -msse2 -std=c99so I did a compiler run with this before
Code: [Select]
win32: QMAKE_CFLAGS_RELEASE += -msse2some module(s?) compile, others with error, I switch the flag again and the other modules compile and link in the end. Not the best to do so... I know... but I found no other solution so far. Maybe your hint solves this issue. I'll try tomorrow! Do you think that's it?

I think this is not so far away from what I think MLV App could do in the future ;)

Great ! I'll Be here to test and give feedback ;-)


Envoyé de mon iPhone en utilisant Tapatalk
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 17, 2017, 08:11:30 AM
@Ilia3101, @masc

I forgot one thing to ask

In amaze_demosaic.c there are 3 inline funcs:
Code: [Select]
__inline float xmul2f(float d)
__inline float xdiv2f(float d)
__inline float xdivf( float d, int n)
gcc (under linux) or mingw-gcc (under windows) always complains and outputs error that they are not defined.

changing "__inline" to "static INLINE" solves the issue.
How do you compile w/o applying these changes?

I changed that and tried again on windows. That does not change anything for me. Other source files need the -std=c99 flag, if I activate that the compiler brings 172 errors for these few lines in amaze_demosaic.c:
Code: [Select]
#define min(a,b) \
   ({ typeof ((a)+(b)) _a = (a); \
      typeof ((a)+(b)) _b = (b); \
     _a < _b ? _a : _b; })

#define MAX(a,b) \
   ({ typeof ((a)+(b)) _a = (a); \
       typeof ((a)+(b)) _b = (b); \
     _a > _b ? _a : _b; })

#define SQR(a) \
   ({ typeof (a) _a = (a); \
     _a * _a; })
Do you have an idea why? The output is to long for a message in this forum :(
Mostly it is something like "expected ';' before '_a'" or "....before '_b'".
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Ilia3101 on August 17, 2017, 11:24:15 AM
@masc..

1. Yes, it is a good idea to just use mlv_dump for dng export, to avoid unnecessary complexity.

2. The AMaZE code is a disgusting mess to be honest, I don't even know what language you could call it, but if I remember correctly it compiled with some c++ standards flags.

3. Also could you get me a nice screenshot of the Qt GUI that you like so I can put it in the first post?

4. About caching: I think it should work like this... When there is many clips open, the one being worked on should be allowed full cache (whatever we did when only one clip was supported), and others would be allowed 0 cache.. Of course this would need for me to rewrite the caching to actually work so it can be adjusted in size while running.

@bouncyball...

Could you possibly by any chance provide a Linux build for @masc to put on the release page?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 17, 2017, 12:21:14 PM
@masc

Which QT and mingw versions do you use?
I use QT 5.9.1 with mingw 5.3.0 and able to compile on one pass :)
Btw under windows as well. However can not fix the MLV size >2GB issue yet.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on August 17, 2017, 07:57:18 PM
Ok, I think I found out where I had issues. When I try to open it my files from a complex folder structure (like I often use for editing) it crashes. But when I moved them to a simple one, like HDD root, it opens perfectly.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 17, 2017, 08:14:41 PM
@masc

try:
Code: [Select]
win32: QMAKE_CFLAGS_DEBUG += -msse2 -D_FILE_OFFSET_BITS=64In conjunction with replacing all "fseek" with "fseeko". Should resolve >2gb isuue.

I also compiled MLV App with mingw64-x64 (using MSYS2 enviroment, very cool stuff), got 64bit native binary for windows but 2gb issue persisted. Then I changed all fseek calls with fseeko and 2.8GB MLV loaded and processed :) I'm too lazy to compile libpng and zlib again for win32 MLV App testing. Try yourself what I said abobe, I think it should help even for 32bit binary.

Meanwhile trying to compile all static MLV App... not succeded yet...

bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 17, 2017, 08:24:32 PM
@masc..

1. Yes, it is a good idea to just use mlv_dump for dng export, to avoid unnecessary complexity.

2. The AMaZE code is a disgusting mess to be honest, I don't even know what language you could call it, but if I remember correctly it compiled with some c++ standards flags.

3. Also could you get me a nice screenshot of the Qt GUI that you like so I can put it in the first post?

4. About caching: I think it should work like this... When there is many clips open, the one being worked on should be allowed full cache (whatever we did when only one clip was supported), and others would be allowed 0 cache.. Of course this would need for me to rewrite the caching to actually work so it can be adjusted in size while running.

@bouncyball...

Could you possibly by any chance provide a Linux build for @masc to put on the release page?

3.: http://image.ibb.co/h7tvma/Bildschirmfoto_2017_08_12_um_12_21_47.png this was the last one...
4.: yes, this should easily be possible. I did it also like this (you provide this functionality), but I had some problems - some crashes and some pinkish frames. So I disabled it... with some debugging this should work!
5.: I was talking with bouncyball about that... some posts above. But to build a linux package that needs some extra work ;)

@masc
Which QT and mingw versions do you use?
I use QT 5.9.1 with mingw 5.3.0 and able to compile on one pass :)
Btw under windows as well. However can not fix the MLV size >2GB issue yet.

Good question. I think it is a Qt 5.6.0 and MinGW 4.9.x or something like that on Windows. Maybe I should just update MinGW. But with this 2GB issue, the best option will be to try it again with MSVC I think.

When I try to open it my files from a complex folder structure (like I often use for editing) it crashes. But when I moved them to a simple one, like HDD root, it opens perfectly.

Hm, sounds strange. At least my part can handle each path I think. Maybe I look for that deeper in the sources...
try:
Code: [Select]
win32: QMAKE_CFLAGS_DEBUG += -msse2 -D_FILE_OFFSET_BITS=64In conjunction with replacing all "fseek" with "fseeko". Should resolve >2gb isuue.
...
Try yourself what I said abobe, I think it should help even for 32bit binary.
Wow, sounds good... I'll try that tomorrow when I'm back on my windows PC! Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 17, 2017, 08:52:14 PM
HERE (https://bitbucket.org/bouncyball/mlv-tools/downloads/MLV_App_x64.zip) is a proof of concept ;) Win x64 MLV App with > 2GB support. Just exported mov for 4.2gb MLV.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 17, 2017, 09:19:06 PM
Could you possibly by any chance provide a Linux build for @masc to put on the release page?
Can not compile all static binary yet. There is no chance to put libs side by side with binary in Linux. It's not gonna work.

It's how it looks like on my desktop :)

(http://thumb.ibb.co/eyxOBa/MLV_App_Linux.jpg) (http://ibb.co/eyxOBa)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 17, 2017, 09:26:54 PM
I'm too lazy to compile libpng and zlib again for win32 MLV App testing. Try yourself what I said abobe, I think it should help even for 32bit binary.

The win32 versions of libpng and zlib are in the repos. You mustn't compile again...

HERE is a proof of concept ;) Win x64 MLV App with > 2GB support. Just exported mov for 4.2gb MLV.

Yeaaayyy... will try it tomorrow!  8) And: so cool to see it on Linux! Hahahaa
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 17, 2017, 09:56:12 PM
Aah, Linux too  8) Goood...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: mario1000 on August 18, 2017, 09:59:16 AM
HERE (https://bitbucket.org/bouncyball/mlv-tools/downloads/MLV_App_x64.zip) is a proof of concept ;) Win x64 MLV App with > 2GB support. Just exported mov for 4.2gb MLV.

Dear bouncyball,

I would like to try this version, but after start an error message appears: "This application fails to start because it could not find or load the Qt platform plugin "windows" in "". Reinstallating the application may fix this problem."
I use Windows 8.1 . Any suggestions?

Thanks in advance!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 18, 2017, 10:08:35 AM
@bouncyball:
Same for me. Should be a problem with the libraries. You can try opening on your system after renaming your Qt installation folder...

I tried what you wrote for >2GB file support with Win32... but the problem still persists :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 18, 2017, 10:17:27 AM
@masc

The solution I always use is:
Code: [Select]
uint32_t file_set_pos(FILE *stream, uint64_t offset, int whence)
{
#if defined(__WIN32)
    return fseeko64(stream, offset, whence);
#else
    return fseeko(stream, offset, whence);
#endif
}

I forgot to mention that in addition to
"win32: QMAKE_CFLAGS_DEBUG += -msse2 -D_FILE_OFFSET_BITS=64"
fseeko64 should be used for mingw32. So change all fseek to fseeko64 or use the universal routine posted above.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 18, 2017, 10:49:36 AM
@mario1000

I would like to try this version, but after start an error message appears: "This application fails to start because it could not find or load the Qt platform plugin "windows" in "". Reinstallating the application may fix this problem."
Ah yes windows platform plugin for QT was missing.
Download the MLV App (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x64.zip) again.
Now it runs on my testing clean Windows 7 x64.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 18, 2017, 11:06:00 AM
Now I ask, if I test with currupted files :( But i get them opened in other apps/tools, and they open on OSX.

I get your version opened now, but it crashes on open a big mlv in the same way as my 32 bit build does. Same for fseeko64.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 18, 2017, 11:22:12 AM
Hmm... what can I say I'm lost :) Let's wait for others to test it and report.

Just opened two, 4.1 and 4.2 GB, files and play them w/o a problem (on win10 x64).
Regarding my suggestion of fseeko64, will try today with win32 enviroment.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on August 18, 2017, 11:27:55 AM
I'll add the screenshot later today.
@bouncyball if you want, I can add you with commit ability to the github repository if you have an account. Might speed up little things like getting the big files working.
Linux screenshot looks good, maybe I can switch to Linux sooner now :)
Also why does fseeko and fseeko64 exist? How are they different from fseek?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 18, 2017, 12:00:29 PM
@bouncyball if you want, I can add you with commit ability to the github repository if you have an account. Might speed up little things like getting the big files working.
Would be very nice thank you.

Linux screenshot looks good, maybe I can switch to Linux sooner now :)
:)

Also why does fseeko and fseeko64 exist? How are they different from fseek?
difference between fseek and fseeko is the offset type. fseeko offset type is "off_t" and fseek offset type is "long".
fseeko64 addresses 64bit offsets (>2GB files) for 32bit platforms.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 18, 2017, 12:03:28 PM
@masc:

Please try this 32bit build (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x86.zip) (fseeko64).
It opens >2gb files here on windows 10 x64.

And here (http://nic.caucasus.net/mlvapp/?dir=&download=MLV-App-src-mingw32.zip) is a source from which I built it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ottoga on August 18, 2017, 01:29:52 PM
Hi

Just some feedback

I tried both the 32 and 64 bit versions of the app today on a W10 Professional Notebook.

Unfortunately I get the following error on both versions:


"This application fails to start because it could not find or load the Qt platform plugin "windows" in "". Reinstalling the application may fix this problem."


After acknowledging the error message I get the following (which is probably normal due to the original error):


Runtime Error!

[Path]/MLVP App.exe

The application has requested the Runtime to terminate in an unusual way.
Please contact the application's support team for more information.


Cheers
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 18, 2017, 02:42:11 PM
I tested both 64 and 32 bit versions on 3 machines. My work pc win 10, My notebook win10 clean install where QT was not installed ever and win 7 x64 virtual machine clean install.

@Ottoga: You mightbe downloaded 64 bit version from earlier post. Because it works here. However you are right about 32 bit one. qwindows.dll was from older QT version.

Now both checked, updated and are working on all my PCs and VMs with 2GB+ file support _flawlessly!_

Download 32bit (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x86.zip) and 64bit (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x64.zip) versions again.

And if someone says it's not working again I'm not gonna believe him in no way :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DanHaag on August 19, 2017, 01:14:20 AM
Tried the latest native Mac version with new MLV footage I shot about a week ago. Now it works! The best standalone MLV/MLraw app I've ever used! Great work, thank you so much!  8) :)

Will keep using it and report here in case of any issues but so far (except for the known resizing UI bug) I didn't run into any further problems.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: reddeercity on August 19, 2017, 07:01:53 AM
And if someone says it's not working again I'm not gonna believe him in no way :P
@bouncyball --Really ! that very arrogant of you!! >:(
I just tested it on Win7 Pro Workstation (8core fx8350 , 8GB ram , ssd OS, 8TB raid0 , dual gpu's (gtx580)
I can confirm It Crashes on 32bit version on 4 GB or bigger
from this link http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x86.zip


(http://preview.ibb.co/mhsQRk/crashed_app.png) (http://ibb.co/nNBwXQ)

The file is 4 GB 14bit 1920x960 from my 5D Mark ii , open fine with MLVProducer & MLVFS PC(version) It is a spanning file
(http://image.ibb.co/jgrKmk/mlvproducer_app_Info_menu.png) (http://imgbb.com/)

Same file in MLVProducer
(http://preview.ibb.co/kiGGz5/small_mlvproducer_app.png) (http://ibb.co/htW5sQ)

I did try a 3.2 GB file and it open up in this app , I would say that there no Spanning file support --of course as All digic 4 cam don't support exfat.
So something is broken it need to be fixed.

I did notice that the image in the preview is really blown out
(http://preview.ibb.co/dCnye5/small_mlv_app.png) (http://ibb.co/iT8RXQ)

Same file in mlvproducer with default setting no adjustments (adobe RGB color space)

(http://preview.ibb.co/jyAtwk/small_mlvproducer_app_2_GB_file.png) (http://ibb.co/hJrNp5)

If I'm not mistaken this app uses either sRGB or rec709 color space right ?
to match mlvproducer I have to drop the exposure down to negative -3.5 to get correct exposure
so there something going on that's blowing out the image in MLV app.
Maybe a decoding problem ? or reading wrong metadata ? just a thought .



Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on August 19, 2017, 09:35:58 AM
@reddeercity
The colour space, while not properly managed yet is treated as sRGB (by default), by the PNG library... Most likely, im certain that's the case on Mac version and probably same is true for the PNG library used in Qt version. So yes, it is sRGB, however ffmpeg which is currently used probably adapts it to rec 709 (which as you know only differs in gamma curve)
It should look the same throughout the process.
But I'm still going to try and add some more colour space stuff in to the app, it's all much clearer to me now.

Also, the overexposure is supposed to be there, we lie by +1.2 stops when it is set to 0. You do good ettr I guess, so for you it seems really overexposed, but for normally (badly) exposed shots it is only a tiny bit bright.

Did you try 64bit version though?

@DanHaag in my opinion at this moment the Qt GUI is a lot better for real world usage, it has more features, so at this moment I recommend using that, however cocoa GUI should eventually catch up on features and get AVFoundation export, which will make it worth using.

@bouncyball just tell me your github account name if/when you have one.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 19, 2017, 11:20:12 AM
@Ilia3101
@bouncyball just tell me your github account name if/when you have one.
My username is bouncyball-git

@reddeercity
Did you try 64bit version though?
? same question.

Spanning file could be reason though, will check.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: snipeua on August 19, 2017, 04:05:35 PM
Good day!
I have the same problems as reddeercity on both 32 and 64 bit versions (Windows 7 64bit). The application crashes on every spanning files larger than 3 GB.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 19, 2017, 07:19:43 PM
@snipeua

Hi, thank you for feedback. I'm just curious it crashes when you import spanning MLV or after, when you export final video?

And would be very nice if you'll also try to test with some standalone ~2.5-3.5GB MLV (not the part of spanning MLV files) and report back.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on August 19, 2017, 11:01:26 PM
O yeah, it still needs spanning support.

@bouncyball I've added you on github invite link that github gave (https://github.com/ilia3101/MLV-App/invitations)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 19, 2017, 11:12:27 PM
Succeeded to run it under Linux. A first feedback:

1. Exporting to prores results in png. The number of pngs is correct, but the progress bar stops at 50%.
2. I see nothing in histogramm, looking at a small object like the planet mars. Histogramm of the big moon looks fine:
   Histogramm mars: https://seescho.files.wordpress.com/2017/08/mars1.jpg
   Histogramm moon: https://seescho.files.wordpress.com/2017/08/mond.jpg
   
Tomorrow I will do same more tests.

Very nice app!

Edgar
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ottoga on August 20, 2017, 03:45:08 AM
@bounceyball

Both versions working fine with a small sample file. I don't have anything larger than 4gb anyway so I wouldn't have picked up reddeercity's error.

One option that would be really useful would be a button to reset the sliders back to their default settings.

A couple of questions if I may:


Cheers
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 20, 2017, 10:15:43 AM
@Ilia3101: Thank you, I really appreciate it!

@escho
1. Exporting to prores results in png. The number of pngs is correct, but the progress bar stops at 50%.
You gotta put ffmpeg binary to the same dir as MLV App and it's gonna pass the 50% :) (will encode to MOV and then delete PNGs)

@Ottoga: Thank you, can you be more specific about "small sample file". What was exact size, b/c MLVs less then 2GB were working from the beginning.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 20, 2017, 11:17:54 AM

@eschoYou gotta put ffmpeg binary to the same dir as MLV App and it's gonna pass the 50% :) (will encode to MOV and then delete PNGs)


Got it. Thankyou!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 20, 2017, 12:17:37 PM
Hey guys patched - frame number not reported correctly for 2GB+ MLVs in the info dialog.

Download 32bit (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x86.zip) and 64bit (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x64.zip) versions again.

Both 32/64bit versions should hopefully work for everyone now ;)

EDIT: just converted 6.87GB MLV from 0 to the last 2025th frame :)

@Ilia3101, @masc
Intermediate PNG export is a huuuge waste of space, for 1920x1080 one PNG frame is ~10MB (imagine size for 3K). Had to free some space on my SSD to make this export.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: snipeua on August 20, 2017, 04:58:23 PM
@bouncyball
Hi, it crashes in first stage when i import spanning MLV.

UPDATE: New version still crashes - nothing change.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 20, 2017, 05:45:55 PM
Woooow, 2 days off and so much feedback. Thank you guys.

@Bouncyball: I'm sorry, I won't see a Windows PC for the next 4 weeks, so I hope other members of the forum will test and help to get feedback until then.

Somebody was asking for resetting the sliders: Menu -> Edit -> Reset receipt does the job.

@reddeercity: you think the exposure is wrong in MLV App? I always thought it is wrong in MlRawViewer and MLVProducer, because when opening any of my clips there I always get a "near to black" image, and I start seeing anything when doing something like exposure +3EV - then it looks near to what I saw on my camera. I don't have that problem when opening files in Resolve. But if I am right, we don't use metadata for processing, so it may be wrong... don't know what Ilia says about...

@Ilia3101, @masc
Intermediate PNG export is a huuuge waste of space, for 1920x1080 one PNG frame is ~10MB (imagine size for 3K). Had to free some space on my SSD to make this export.

Yes, you're right, I know. I already tried to get the ffmpeg library working... but... after some days I gave up. I did not understand that library interface - it is really huge. But if you know how to do that, we could try another time. That should be faster and consume a lot less temp memory. And that would be much more elegant.

And... what did you change for your last upload? :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 20, 2017, 05:57:12 PM
Succeeded to run it under Linux. A first feedback:
1. Exporting to prores results in png. The number of pngs is correct, but the progress bar stops at 50%.
2. I see nothing in histogramm, looking at a small object like the planet mars. Histogramm of the big moon looks fine:
   Histogramm mars: https://seescho.files.wordpress.com/2017/08/mars1.jpg
   Histogramm moon: https://seescho.files.wordpress.com/2017/08/mond.jpg
Edgar
Thanks for testing on Linux! I think the histograms are both right. The picture with the mars is really dark, so the black in the histogram is so huge, that you nearly can't see the rest. Atm we are anywhere between linear and log scaling on the y axis. Log would be good for pics like that, but "normal" pictures would result in a line. Linear is good for normal pics but if there is a peak, you'll see only the peak.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 20, 2017, 07:17:28 PM
UPDATE: New version still crashes - nothing change.
Oh man... I can't believe this :D, then I guess it really depends on footage, I tried mostly 1080p/14bit/Uncompressed, any file size works here (on my four windows systems).

@snipeua:
Please tell us which:
1. Windows version you used;
2. MLV App version you used (32bit or 64bit);
3. What hardware you used;
4. Would be very nice if you upload exact MLV file which causes crash, please do it and I will test it asap.
Thank you in advance.

@masc
And... what did you change for your last upload? :)
I saw that if file size is more than 2GB, info dialog always shows 591 or 592 frames. Then I remember that in addition to 'fseek' there are lots of 'ftell' used in 'video_mlv.c'. And of course they also should be replaced by 'ftello64' for mingw :P. That's what I changed last time and now info panel shows correct frame count.

I have to test this code also for Linux (if it works for Linux it should work on Mac without change) and then I will push changes to repo (thanx to Ilia, he gave me access).

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 20, 2017, 07:22:53 PM
@mascI forgot that in addition to 'fseek' there are lots of 'ftell' used in 'video_mlv.c'. And of course they also should be replaced by 'ftello64' for mingw :P.

I have to test this code also for Linux (if it works for Linux it should work on Mac without change) and then I will push changes to repo (thanx to Ilia, he gave me access).

Perfect! Thx! :-)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 20, 2017, 09:25:01 PM
I wrote for me a little step by step howto for running MLV-App under Linux. I share it with you, but it´s in German:
https://seescho.wordpress.com/fotos/ml/
Edgar
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 20, 2017, 09:51:14 PM
@Edgar: na das triffts doch ganz gut! ;) I always wanted to write that, and I even should do that. Some remarks:
1.: The app does not search for ffmpeg. I told the app, it is located exactly next to the executable, because on Win&OSX this was the easiest to do. So for Linux, if the location is anywhere else, we can add this special path.
2.: MLV App does not only need ffmpeg. It also needs libpng 1.6 and zlib. Otherwise it won't compile. On Win&OSX this was the most difficult part (at least for me).
3.: The histogram thing: I even think it is not wrong, I wrote it some messages above. There is just this peak in the very left (that is the black in your picture)... but if anyone has an idea how to cut peaks without making the histogram to flat... pleeeaaase tell me... this problem drives me crazy!  :P ;D

Anyway... thanks for this very good installation manual! I like it :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 21, 2017, 12:58:03 PM
Hey guys patched - frame number not reported correctly for 2GB+ MLVs in the info dialog.

Download 32bit (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x86.zip) and 64bit (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x64.zip) versions again.

Both 32/64bit versions should hopefully work for everyone now ;)

Tested the 32bit version emulated in Wine on OSX without problems Could also open a 2.3GB file.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ottoga on August 21, 2017, 03:42:22 PM
@bouncyball

This is the first time that I have ever downloaded and tried the app so I wasn't doing any serious testing. I really just wanted to confirm that the versions that you provided the links for were working.

The actual file only had a few hundred frames captured when testing the 10/12bit raw recording on my 7D as I didn't have access to anything larger on the night.

Playing around with it tonight and it seems to be handling spanned files >4gb without any problems.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on August 21, 2017, 03:53:36 PM
wow this programs is so good. thank you bouncyball,masc and Ilia for making such a wonderful app
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on August 21, 2017, 05:26:43 PM
Terrific Progress guy's, amazing work, quick question though.... anyone know how to batch import?? i can only seem to import one clip at a time, or am i missing something???????
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 21, 2017, 07:01:55 PM
Terrific Progress guy's, amazing work, quick question though.... anyone know how to batch import?? i can only seem to import one clip at a time, or am i missing something???????
I am not sure, if the latest version we uploaded as binary had already a filedialog for multiple files. Are you on Windows or OSX?
Windows: take the version from bouncyball, that should be new enough, select as many files you want in the dialog.
OSX: if it is new enough, try the same. If that does not work: select the files in Finder and chose "Open with..." -> MLV App.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on August 21, 2017, 07:26:07 PM
anyone know how to batch import?? i can only seem to import one clip at a time, or am i missing something???????

i can import as many as i want. btw im on windows 7 64bit
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on August 21, 2017, 07:46:40 PM
Hi Masc, i'm on MacOS, i'm currently using the 0.5 alpha version.. the latest version on the download page, just tried finder to select multiple MVLs to import, but when i go to "open with", the MLV app is grey'd out and won't let me select it, to open with, guess i'll wait for the app to be updated, again fantastic work, thanks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 21, 2017, 07:54:37 PM
Hi Masc, i'm on MacOS, i'm currently using the 0.5 alpha version.. the latest version on the download page, just tried finder to select multiple MVLs to import, but when i go to "open with", the MLV app is grey'd out and won't let me select it, to open with, guess i'll wait for the app to be updated, again fantastic work, thanks.
Yes, I have that on Mavericks too, on El Capitan it works for me, whyever. There is a option "Show only recommended" or something like that (have never seen the english version ;) ), and when you uncheck that, it also works on Mavericks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on August 21, 2017, 08:05:25 PM
Hi Masc, PERFECT. Just unchecked recommended apps, to ALL apps (MAC SIERRA)... and all MLV's loaded straight into MLV app. Thanks for feedback, really appreciate it. GREAT APP  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ottoga on August 22, 2017, 04:10:38 AM
I tested an MLV clip with sound last night. w10 64bit version.

Video exported fine, however there is no sound and/or no separate audio file created.

When reviewing the app preferences Export Audio is ticked but greyed out.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 22, 2017, 08:58:11 AM
I tested an MLV clip with sound last night. w10 64bit version.

Video exported fine, however there is no sound and/or no separate audio file created.

When reviewing the app preferences Export Audio is ticked but greyed out.
Audio is not implemented, that is the reason why it is still greyed out. Ilia wants to implement audio read out, I also wait for that :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 22, 2017, 05:03:52 PM
Wow! Finally it works :D for 2GB+ files thanks for feedback guys.

@masc: I pushed my latest stuff to repo. I think you'll appreciate commit 1aadb46 ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 22, 2017, 06:10:23 PM
Btw I noticed that FPS, while playing MLV, differs for Win and Linux builds (no matter 32 or 64 bit):

Win ~7-10 fps
Linux ~15-18 fps (even 20 sometimes)

Tested on the same PC with the same hardware and MLV files.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on August 22, 2017, 07:03:15 PM
Thanks a lot @escho, I've added it to first post.

@bouncyball I know two potential causes for slowness:
Linux kernel can be up to ~40-50% better in cpu performance than Windows (I know this from the Blender world)
(More likely) The UI widget/component used by Qt in Linux is more efficient than the one used in windows, as I noticed on Cocoa version, the NSImageView widget refreshes much faster when the window is small - it seems to be the main bottle neck for Mac.

@masc I see you added mlv dump sources to the repository. I will try and implement them, although some of them will probably need to be moved from src/processing to src/mlv, as they work mostly with bayer data, not RGB which the processing module does.
Caching rewrite still on the list :( ugh
I'm back and more stuff is coming.

We also need a really nice icon.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 22, 2017, 08:16:00 PM
I know two potential causes for slowness
Yes I also thought about the same two reasons you mentioned.

The icon refresh would be very nice :).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 22, 2017, 08:31:46 PM
Btw I noticed that FPS, while playing MLV, differs for Win and Linux builds (no matter 32 or 64 bit):

Win ~7-10 fps
Linux ~15-18 fps (even 20 sometimes)

Tested on the same PC with the same hardware and MLV files.
Haha... with Windows it is so slow... yes, I have seen that too, so I am not alone:
- Win 8.1 Pro i7@3.67GHz (PC from 2013): 10 fps
- OSX 10.9 Core2Duo 2.4 GHz (MBP 2010): 10 fps
- OSX 10.10 i5 2.5 GHz (iMac 2011): 17 fps :)

@masc: I pushed my latest stuff to repo. I think you'll appreciate commit 1aadb46 ;)
I'll check that out this evening!

@masc I see you added mlv dump sources to the repository. I will try and implement them, although some of them will probably need to be moved from src/processing to src/mlv, as they work mostly with bayer data, not RGB which the processing module does.
Caching rewrite still on the list :( ugh
I'm back and more stuff is coming.

We also need a really nice icon.
Oh yes! A nice icon would be cool. I just created this ugly thing for having anything... but I don't like it!

I added the mlv dump sources because I was playing around. I tried to add chroma smoothing, but without luck. Maybe I did not call it at the right step. When do we have to call it? I thought before the debayering when I understood the code and the comments right. Is that right? But it works with integer and Ilia implemented float. Is that a problem?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 22, 2017, 08:47:07 PM
@Ilia3101, @masc

When do we have to call it? I thought before the debayering when I understood the code and the comments right. Is that right? But it works with integer and Ilia implemented float. Is that a problem?
All processing routines, the original MLVFS/cr2hdr ones or the ones added/modified by me, work only on RAW bayer data. It's all done on any bit raw unpacked to uint16_t image buffers. I have to take closer look at Ilia's implementation before debayer. I think he also unpacks raw bits to 16bit and there won't be a problem, just performance/fps penalty of processing, bad pixels/focus pixels/stripes are less heavy, chroma smooth and pattern noise are slower.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 22, 2017, 09:20:53 PM
@bouncyball:
I think anywhere in the near of getMlvRawFrameFloat() in video_mlv.c would be right then (or where this one gets called).

Cool stuff at the repos! I made a new release and counted up to v0.6 alpha. Would you please compile and upload the windows version(s)?
https://github.com/ilia3101/MLV-App/releases/tag/QTv0.6alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.6alpha)

@all:
New in v0.6 alpha:
- Bugfixes for >2GB file support on Windows
- Changed histogram algorithm (cuts peaks at very low and high end, and is something between linear and log now) @escho & @DeafEyeJedi: please try out if shows better would you like to see
- Preview pictures in sessions (list mode and picture mode)
- Scrolling and dragging support at 100% zoom in picture viewer
- Small bugfixes
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 23, 2017, 10:48:31 AM
Would you please compile and upload the windows version(s)?
Done :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 23, 2017, 11:12:43 AM
Newest version works fine hier in Linux. And for compiing in QT Creator there is only one pass needed now. Great.

The histogramm of Mars is now OK. I uploaded a comparition between MLV App and darktable on my website: https://seescho.wordpress.com/fotos/ml/

I will change my howto later. Nice to found the link on the first post of this Tread :)  I think, I will add some english text into the howto.

btw. What is this for in MLVApp.pro?

Code: [Select]
#Linux
linux-g++*: INCLUDEPATH += /usr/local/include/
linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng

/usr/local/include and /usr/local/lib are empty on my system.

Edgar
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 23, 2017, 12:04:37 PM
Code: [Select]
#Linux
linux-g++*: INCLUDEPATH += /usr/local/include/
linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng

/usr/local/include and /usr/local/lib are empty on my system.
And where are compiled libpng16 and zlib1 in your case?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 23, 2017, 12:50:59 PM
The histogramm of Mars is now OK. I uploaded a comparition between MLV App and darktable on my website: https://seescho.wordpress.com/fotos/ml/

btw. What is this for in MLVApp.pro?

Code: [Select]
#Linux
linux-g++*: INCLUDEPATH += /usr/local/include/
linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng

/usr/local/include and /usr/local/lib are empty on my system.

Edgar
Hey cool... the simple trick seems to work in the histogram.

How can you compile when that is empty? That's strange.  In the repos under platform/qt/ there is a folder: libpng. Here you find the source for this library - unpack, compile and install. Zlib should work if you install the dev version with apt-get or whatever you use. If not, you can download this in the internet, compile and install.

Done :)
Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 23, 2017, 02:30:37 PM
And where are compiled libpng16 and zlib1 in your case?
Code: [Select]
libpng16-16 - Library for the Portable Network Graphics Format (PNG)

/usr/lib64/libpng16.so.16
/usr/lib64/libpng16.so.16.8.0



libpng16-devel - Development Tools for applications which will use the Libpng

/usr/bin/libpng16-config
/usr/include/libpng16
/usr/include/libpng16/png.h
/usr/include/libpng16/pngconf.h
/usr/include/libpng16/pnglibconf.h
/usr/lib64/libpng16.so
/usr/lib64/pkgconfig/libpng16.pc
/usr/share/doc/packages/libpng16-devel
/usr/share/doc/packages/libpng16-devel/ANNOUNCE
/usr/share/doc/packages/libpng16-devel/CHANGES
/usr/share/doc/packages/libpng16-devel/LICENSE
/usr/share/doc/packages/libpng16-devel/README
/usr/share/doc/packages/libpng16-devel/TODO
/usr/share/doc/packages/libpng16-devel/libpng-manual.txt


zlib-devel - Development files for zlib, a data compression library

/usr/include/zconf.h
/usr/include/zlib.h
/usr/include/zutil.h
/usr/lib64/libz.so
/usr/lib64/pkgconfig/zlib.pc
/usr/share/doc/packages/zlib
/usr/share/doc/packages/zlib-devel
/usr/share/doc/packages/zlib-devel/ChangeLog
/usr/share/doc/packages/zlib-devel/README
/usr/share/doc/packages/zlib/examples
/usr/share/doc/packages/zlib/examples/README.examples
/usr/share/doc/packages/zlib/examples/enough.c
/usr/share/doc/packages/zlib/examples/fitblk.c
/usr/share/doc/packages/zlib/examples/gun.c
/usr/share/doc/packages/zlib/examples/gzappend.c
/usr/share/doc/packages/zlib/examples/gzjoin.c
/usr/share/doc/packages/zlib/examples/gzlog.c
/usr/share/doc/packages/zlib/examples/gzlog.h
/usr/share/doc/packages/zlib/examples/zlib_how.html
/usr/share/doc/packages/zlib/examples/zpipe.c
/usr/share/doc/packages/zlib/examples/zran.c
/usr/share/man/man3/zlib.3.gz

I can compile with QT creator without problems and don´t have to chance anything. Maybee, QT Creator adds the paths itself?

Edgar
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 23, 2017, 03:06:20 PM
Another thing

I use MLV-videos for nothing else than my astronomical stuff. Autostakkert, the program, which I use to stack the videoframes, need uncompressed avi-files as input. It does not run with prores. It would be nice to can export such avi-files with MLVApp sometime in the future.

For my needs I did a workaround, quick and very dirty. Looks like that:

I changed MainWindow.cpp line 636 ff

Code: [Select]
QString program = QCoreApplication::applicationDirPath();
    program.append( QString( "/ffmpeg\"" ) );
    program.prepend( QString( "\"" ) );
    program.append( QString( " -r %1 -i \"%2\" -c:v rawvideo -pix_fmt %3 \"%4\"" )
                    .arg( getMlvFramerate( m_pMlvObject ) )
                    .arg( numberedFileName )
                    .arg( "yuv420p" )
                    .arg( output ) );
                   
And I replaced all .mov strigs, i found in MainWindow.cpp with .avi.

Edgar
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 23, 2017, 09:13:15 PM
I can compile with QT creator without problems and don´t have to chance anything. Maybee, QT Creator adds the paths itself?
I don't think Qt adds paths (at least it does not do that for me ;D). But maybe there is set a system variable with that path.

For my needs I did a workaround, quick and very dirty. Looks like that:
That does not look so quick and dirty. That patch should do the job. Maybe I add this in future to the other codecs. What does this codec "rawvideo" exactly? Does it convert the png to tiff and adds it to the avi?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 24, 2017, 08:30:34 AM
Nice progress all.
I wanted to ask about HDR implementation. Since you´re in FFmpeg domain there´s something called tblend filter that, at least when I run real life footage, yields very good results. It´s more or less same speed as transcoding regular prores and it also keeps the original framerate.
Example footage:
http://www.magiclantern.fm/forum/index.php?topic=13512.msg160592#msg160592
averaged footage at around 1:05.

It works with an average filter. I think it will work nicely in Mlv app since we now can tweak output. Here´s a syntax example from Switch:
Code: [Select]
find . -maxdepth 1 -iname '*.dng' -print0 | xargs -0 dcraw +M $h2 $o $S -c -6 -W $qual $gam $wb $pix $br | ffmpeg $wav1 -f image2pipe -vcodec ppm -r $fps -i pipe:0 $sd -vcodec prores -pix_fmt yuv422p10le -n -r $fps -vf tblend=all_mode=average Output.movWhat it boils down to is the simple filter syntax added:
Code: [Select]
-vf tblend=all_mode=average Output.mov
The idea is that the HDR PNG files gets averaged of course.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on August 24, 2017, 10:17:59 AM
If that HDR using ffmpeg will be implemented, it will be in the qt version, as Cocoa version will leave ffmpeg soon.

I would like to implement HDR internally though... it seems simple.

Also new release of Cocoa version (v0.17) (https://github.com/ilia3101/MLV-App/releases/tag/v0.17-pre-alpha-print-value-edition) This time it show's the sliders value.
... sessions like Qt GUI will be implemented soon
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 24, 2017, 10:26:37 AM
Code: [Select]
I would like to implement HDR internally though... it seems simple.Great.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 24, 2017, 04:30:52 PM
Another thing

I use MLV-videos for nothing else than my astronomical stuff. Autostakkert, the program, which I use to stack the videoframes, need uncompressed avi-files as input. It does not run with prores. It would be nice to can export such avi-files with MLVApp sometime in the future.

For my needs I did a workaround, quick and very dirty. Looks like that:

I changed MainWindow.cpp line 636 ff

Code: [Select]
QString program = QCoreApplication::applicationDirPath();
    program.append( QString( "/ffmpeg\"" ) );
    program.prepend( QString( "\"" ) );
    program.append( QString( " -r %1 -i \"%2\" -c:v rawvideo -pix_fmt %3 \"%4\"" )
                    .arg( getMlvFramerate( m_pMlvObject ) )
                    .arg( numberedFileName )
                    .arg( "yuv420p" )
                    .arg( output ) );
                   
And I replaced all .mov strigs, i found in MainWindow.cpp with .avi.

Edgar

I added export to uncompressed AVI in my latest commit. Hope it works :-) Thanks for your code!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 24, 2017, 08:38:25 PM
I added export to uncompressed AVI in my latest commit. Hope it works :-) Thanks for your code!

Works like a charm. Exactly, what I needed. Thankyou very much :)

Rawvideo
Im not sure, but as far as I understand this, it should work like this:
The inputfiles are moved as a bitstream into the avi-container. No changes, no compression.

Edit: I updated my installation-guide for openSUSE :)

Edgar
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on August 26, 2017, 03:26:07 AM
As many requested, the app has Log now.

There is 4 processing image profile options:

More profiles and Log options to be added... any links to formulas for other Log profiles are very welcome

(https://camo.githubusercontent.com/67969614146a058b0f6050c556ef5d751d785cf5/68747470733a2f2f696d6167652e6962622e636f2f667a717148512f416c6578615f4c6f675f537769746368696e672e676966)
(Tone mapped vs Log profile comparison)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: AWPStar on August 26, 2017, 04:51:35 AM
I did some changes in lj92 sources. it's about 46% faster than original.(30 -> 44fps decoding on 1920x720)
I will test stability. If everything will be ok - i will send you the sources.

Very promising application. I have no MacOS and windows gui cannot be ported to it. So mlvp is only for windows (
If you need some features form mlvp - feel free to ask.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 26, 2017, 07:35:39 AM
@AWPStar
Very interesting about the speed optimisation. Probably beneficial to have access to your changes even if it´s not stable.

@Ilia3101
Logs. Check bottom at this post from Baldavenger. Especially linear to .... Think he got them from nuke. I always liked working with cineon and logC.
http://www.magiclantern.fm/forum/index.php?topic=15801.msg158145#msg158145

s-log formula on page 10 here:
https://pro.sony.com/bbsccms/assets/files/mkt/cinema/solutions/slog_manual.pdf

Would be nice to have bmdfilm but havn´t seen any official formula here.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on August 26, 2017, 07:47:19 AM
@AWPStar
Very interesting about the speed optimisation. Probably beneficial to have access to your changes even if it´s not stable.

+1
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Teamsleepkid on August 26, 2017, 08:12:50 AM
really cool app guys. having it faster sounds like a really great idea. sounds like its windows only though right awpstar? also focus pixel correction would be useful.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: AWPStar on August 26, 2017, 08:14:52 AM
>Very interesting about the speed optimisation. Probably beneficial to have access to your changes even if it´s not stable.
I dont use git's.
https://sourceforge.net/projects/mlvproducer/files/src/lj92.c/download

Some curves. 256 points, int32
https://sourceforge.net/projects/mlvproducer/files/src/curves.zip/download
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 26, 2017, 08:43:14 AM
Thanks AWPStar.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: flostro on August 26, 2017, 09:54:19 AM
Here is something about canon log and sony slog3

https://www.sony.de/pro/support/attachment/1237494271390/1237494271406/technical-summary-for-s-gamut3-cine-s-log3-and-s-gamut3-s-log3.pdf

http://learn.usa.canon.com/app/pdfs/white_papers/White_Paper_Clog_optoelectronic.pdf
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on August 26, 2017, 01:19:50 PM
@AWPStar Thanks a lot for the speed optimisation!

@Danne @flostro Thanks for the Log info, I literally couldn't find any formulas myself. Will add all the log curves.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on August 26, 2017, 06:37:14 PM
Added many more Log profiles and eliminated clipping in Log. Download (https://github.com/ilia3101/MLV-App/releases/tag/v0.19-pre-alpha-no-clipping-edition)

Added Cineon and S-Log3, however couldn't get Canon-Log formula right.

To avoid any clipping, set exposure to -1.2
Ignore this advice now.

I had a thought: Log == tonemaping, so now that is how the log functions are treated, like a form of tonemapping function, so there is no longer any clipping!!!

Adjust exposure as much as you want, and it will be Log-ically correct.

What is the winning deal in this app is that you retain scene referred dynamic range prior to export.
This is now the case with Log^^^

Please don't ruin any footage by using the previous version (maybe that's exaggeration).

Might avoid developing MLV App for some time, to actually create (edit) a video ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 26, 2017, 07:08:04 PM
Cineon, logC, yummy!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 26, 2017, 07:39:55 PM
MLV App on Linux openSUSE, actual version

Looks like tonemapping is applied on the first run of MLV App, but not marked as applied. I have to press the button "apply tonemapping" twice to turn off tonemapping.

Edgar
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 26, 2017, 07:59:54 PM
I hope I'll find some time to add it also to the cross platform version in the next days... Started my 3 weeks holidays today. But internet connection seems to work :-D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 26, 2017, 08:11:39 PM
Happy holidays :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 26, 2017, 08:56:45 PM
Thx :-) It was not to complicated. It is added to the repos. But there is a tiny bug... Ilia, please check my log :-)
But in general it seems to work fine. Good work Ilia!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 27, 2017, 04:41:30 PM
It was not to complicated. It is added to the repos.
Works fine
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 27, 2017, 06:18:37 PM
Unfortunately, version MLV.App.v0.6.alpha.x64.Win crashes when I try to export a 14-bit MLV clip from the EOS 100D.  Here is what it says:

------------------------------------------
Problem signature:
  Problem Event Name:   APPCRASH
  Application Name:   MLV App.exe
  Application Version:   0.0.0.0
  Application Timestamp:   599d3f51
  Fault Module Name:   MLV App.exe
  Fault Module Version:   0.0.0.0
  Fault Module Timestamp:   599d3f51
  Exception Code:   c000001d
  Exception Offset:   000000000001247b
  OS Version:   6.1.7601.2.1.0.256.48
  Locale ID:   1033
  Additional Information 1:   e2e5
  Additional Information 2:   e2e5dca40ff74952f8dea9391c49a9c1
  Additional Information 3:   9c18
  Additional Information 4:   9c18eac52f9d534f72d434fbdb235140
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 27, 2017, 07:13:12 PM
Unfortunately, version MLV.App.v0.6.alpha.x64.Win crashes when I try to export a 14-bit MLV clip from the EOS 100D.
How do you export (setting & single file or batch) and when does it crash? Can you chose the file/folder name, crashes it just after pressing save, at 50%,... ? Can you provide a small file which provokes the error please (best if only some single frames inside)?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 27, 2017, 09:08:02 PM
It is a single MLV file of about 300 MB size (109 frames).  Regardless of the export format that I set in the Preferences, when I press Ctrl+E, it opens the export window and allows me to select the folder for export.  When I press Save, the software crashes and I get a message saying: MLVApp.exe has stoped working. 

Unfortunately, I have a very slow internet connection and cannot send you the file now but if you wait until tomorrow, I can try to send it from work where the net is way faster.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 27, 2017, 09:52:39 PM
It is a single MLV file of about 300 MB size (109 frames).  Regardless of the export format that I set in the Preferences, when I press Ctrl+E, it opens the export window and allows me to select the folder for export.  When I press Save, the software crashes and I get a message saying: MLVApp.exe has stoped working. 

Unfortunately, I have a very slow internet connection and cannot send you the file now but if you wait until tomorrow, I can try to send it from work where the net is way faster.
You can use mlv_dump to shorten the clip to some frames, then the file is only some MBs. Does this happen with any MLV file for you?
Just shorten a file with mlv_dump:
Code: [Select]
mlv_dump -f 5 -o OUTPUT.MLV INPUT.MLVGives you a 5 frame MLV file.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 28, 2017, 12:41:29 AM
masc,

I have now done what you requested and created a 5 frame MLV file (about 17 MB) from the original.  It is called OUTPUT.MLV and the download link is:

https://we.tl/namZYCHTpp

It will be active for one week. 

I also checked with other MLV files from other cameras (5D3 and 7D), also on different Win x 64 computers.  The same behavior is observed.  The software crashes on export as I described above.

I wish you a nice vacation!

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 28, 2017, 06:58:36 PM
Okay, thank you very much, I downloaded the file. It is not a general problem, because on OSX I can export your file without issue.
@bouncyball: could you please download the file as well and try on your Windows PCs?
@IDA_ML: happens the same with the 32bit version?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 28, 2017, 09:47:52 PM
Masc,

Yes, version 0.6 x86 crashes too.  However, the old 0.3 version that I happened to keep, exports just fine.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 30, 2017, 11:22:57 AM
Hey guys I'm also on a vacation and got quite lousy connection. Well... sometimes it works ;)

@masc
Tried with uploaded 5 frame MLV and both x86/x64 win versions export it w/o a problem.

@IDA_ML
Do you have enough space on HDD? And does this exact shortened MLV, that you uploaded, also really crashes MLV App?

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on August 30, 2017, 11:32:02 AM
masc,

I have now done what you requested and created a 5 frame MLV file (about 17 MB) from the original.  It is called OUTPUT.MLV and the download link is:

https://we.tl/namZYCHTpp

It will be active for one week. 

I also checked with other MLV files from other cameras (5D3 and 7D), also on different Win x 64 computers.  The same behavior is observed.  The software crashes on export as I described above.

I wish you a nice vacation!

i have downloaded your file and i can export without any problem on my win 7. i have been using this softaware for more than a week and i havent experience any crash
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 30, 2017, 12:03:19 PM
@bouncyball

Yes, I do have enough space on my HDD.  And I checked the shortened 5 frame file too.  I can open it, make adjustments to it, and play it in MLVApp.  However, when I try to export it, MLVApp crashes.  I tested that on three different computers running Win7x64, I tried also files from 7D and 5D3.  The same thing happens with all of them - crash on export.  Version 3 works just fine though.

I used the download link for Version 6 from the first page.  I unzipped the package in a separate directory, started MLVApp.exe by clicking on it and then opened the file using the "Import MLV" command in the file menue.  I am not sure if I am doing anything wrong and what that may be.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 30, 2017, 01:45:10 PM
@IDA_ML

Hm... strange crash on export only, what's really interesting I personally never experienced any serious crash with this app. Have to be seen the differences between those versions in repo.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 30, 2017, 03:45:38 PM
@bouncyball

Could it be that MLVApp requires some additional software installed to work properly?  Just like MLVS required Dokan.  If that is the case, please advise me on what should I install and give me a download link if possible.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 30, 2017, 04:08:40 PM
Nope, no additional software needed (just static ffmpeg.exe in the same folder, which is supplied in the zip). However there maybe some tampering software/lib or different version of QT installed/registered. IDK :)

As I said I never had issues with this software and I tried it on several win7/10 systems.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 30, 2017, 06:52:15 PM
I tried installing the Windows version into Wine on OSX. Also with that I can export your MLV. The crash appears starting version 0.4? The main difference between 0.3 and 0.4 is the use of libpng, to have 16bit PNGs instead of 8bit PNGs Qt supports only.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 30, 2017, 06:59:39 PM
Masc,

Do you think this can be fixed?  I would love to try out version 6 due to all the new features and faster speed.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 30, 2017, 09:22:25 PM
Do you think this can be fixed?  I would love to try out version 6 due to all the new features and faster speed.
I really do not know what happens. So I don't know how to prevent the crash and can't say if it can be fixed. Sorry. This needs more research. But I can't do that here on my MacBook.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 31, 2017, 02:28:04 PM
Masc,

I am sure, other people on Win7x64 will experience the same behaviour and will be able ti identify the problem.  Don't worry about this now.  Just enjoy your vacation!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on August 31, 2017, 02:46:44 PM
i haven't experience a single crash on my win7X64
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 10, 2017, 07:23:35 PM
In order to get ffmpeg started in qt-platform under Linux, it is necessary, that ffmpeg is located in the same folder, where MLV App can be found.

I´m no QT or C++ programmer, I can only do some little bash scripting. So the most, I do here, is try and error.

In my bash-scripts, I start ffmpeg by just typing "ffmpeg", thanks to the PATH envirement variable. I tried that with MLV App and it worked for me. Here the code, I changed in MainWindow.cpp lines 696 ff for testing:

Code: [Select]
//FFMpeg export
QString program = "ffmpeg";
//QString program = QCoreApplication::applicationDirPath();
//program.append( QString( "/ffmpeg\"" ) );
//program.prepend( QString( "\"" ) );
...

With this method, I don´t need to copy ffmpeg to the "MLV APP-folder" anymore. But I don´t know, what Windows and OSX say to such a method?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 10, 2017, 11:00:07 PM
On OSX that does not work out of the box. It would work if you install ffmpeg, but I wanted to have it in the application bundle, because for most users that is the easiest way (because the user hasn't do install anything but the app itself). For windows I am not sure, but I expect the same.

Edit: I could make a define which takes your string for Linux, and the other string for the other platforms. Would that be easier for Linux?

Edit2: Did that now. I think that should be better for Linux users.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 11, 2017, 07:45:07 PM
Wanted to try this version and downloaded zip from github. But QT-Creator says:
Code: [Select]
Project ERROR: Unknown module(s) in QT: multimedia
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 11, 2017, 08:36:06 PM
Installed "libqt5-qtmultimedia-devel" and it compiles.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 11, 2017, 09:43:47 PM
Yes, you'll need this for the latest revisions. I started implementing audio playback. But... it still a bit buggy ;-)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 11, 2017, 10:07:30 PM
Could anyone on macOS 10.10-10.12 please test the app and see if the preview refreshes when opening clips and making adjustments?
You'll have to compile it yourself, just enter this in the terminal:
Code: [Select]
rm -rf MLV-App && git clone https://github.com/ilia3101/MLV-App.git && cd MLV-App/platform/cocoa && make app && cd - && open MLV-App/platform/cocoa/ && open MLV-App/platform/cocoa/MLV\ App.app... as I'm having some issues on macOS 10.13 beta
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 11, 2017, 10:26:08 PM
I´m on 10.12.3 and yes, the preview does not refresh anymore. Just compiled the latest. Hope it helps even if I´m not on 10.10

Nice :)
(https://s26.postimg.org/6l0ucdh7t/Screen_Shot_2017-09-11_at_22.34.00.png)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 11, 2017, 10:33:14 PM
Thanks a lot for the quick response!
All I needed to know.

Pretty sure it's broken :(

About the icon: The "source code" is in src/icon, so if you know Blender and icon design you're welcome to improve it ;););) (@anyone)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 11, 2017, 11:11:37 PM
aaah, blender. Tried to make sense of that very professional, open source program but never really got my head around it.
Like your progress with Mlv app. Will be very useful.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on September 13, 2017, 03:01:46 AM
I'm on 10.10.5 and the native macOS version says 10.11 is required. The app has a crossmark icon and can't be opened obviously.
Reading through the thread it seems people are running this on 10.10 or am I wrong?

The cross-platform version works though.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 13, 2017, 08:17:37 AM
@FBongcam (If you find time!) Could you please try and compile the app yourself:
Code: [Select]
rm -rf MLV-App && git clone https://github.com/ilia3101/MLV-App.git && cd MLV-App/platform/cocoa && make app && cd - && open MLV-App/platform/cocoa/ && open MLV-App/platform/cocoa/MLV\ App.appIf that doesn't instantly work you might have to quickly do this: http://osxdaily.com/2014/02/12/install-command-line-tools-mac-os-x/ (http://osxdaily.com/2014/02/12/install-command-line-tools-mac-os-x/)
The app is in a slightly broken state right now, but it will be fixed later today. But if possible, it would be great to see if it compiles on 10.10 :)

EDIT: app is fixed, should now refresh view 100% of the time (display mechanism has been completely "reengineered")
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 13, 2017, 11:14:37 PM
In the last weeks Ilia implemented many new features and I integrated them into the Qt version of MLV App. Here we also have the image profiles now and audio support: we can playback audio on preview, export and draw the audio track in the GUI (maybe audio is not perfectly in sync, but Ilia had already an idea how to fix that...).
Windows version will come if @bouncyball (or someone else) finds some time to build it for you. So here is first the OSX 10.9.5+ version:
https://github.com/ilia3101/MLV-App/releases/tag/QTv0.7alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.7alpha)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on September 14, 2017, 12:32:19 AM
@FBongcam (If you find time!) Could you please try and compile the app yourself:
Code: [Select]
git clone https://github.com/ilia3101/MLV-App.git && cd MLV-App/platform/cocoa && make app && cd - && open MLV-App/platform/cocoa/ && open MLV-App/platform/cocoa/MLV\ App.app
I ran this and the app still won't open. It says the app is damaged or incomplete.


Terminal gives me this error (if it's of any help):

Code: [Select]
Initial app name: MLV App (Sep 14 2017 00:14:10)
rm: main.o: No such file or directory
gcc  -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c main.m
main.m:80:40: error: use of undeclared identifier
      'NSWindowStyleMaskFullSizeContentView'
        | NSMiniaturizableWindowMask | NSWindowStyleMaskFullSizeContentView;
                                       ^
1 error generated.
make[2]: *** [main.o] Error 1
cp: MLV App: No such file or directory
cp: checkupdate.py: No such file or directory
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg 

The application cannot be opened because its executable is missing.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on September 14, 2017, 01:40:05 AM
In the last weeks Ilia implemented many new features and I integrated them into the Qt version of MLV App. Here we also have the image profiles now and audio support: we can playback audio on preview, export and draw the audio track in the GUI (maybe audio is not perfectly in sync, but Ilia had already an idea how to fix that...).
Windows version will come if @bouncyball (or someone else) finds some time to build it for you. So here is first the OSX 10.9.5+ version:
https://github.com/ilia3101/MLV-App/releases/tag/QTv0.7alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.7alpha)

This new version (QTv0.7alpha) doesn't output the prores file for me. I can see the png files being created while it's rendering but when it's finished the folder is just empty. I've tried with different settings and also by leaving everything default without any luck.
I'm on OSX 10.10.5.

Edit:
After reading the app page "Support for mlv_dump uncompressed MLV files seems to be broken", maybe that's what I'm experiencing :), I tried both 10bit and 14bit though.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 14, 2017, 08:36:02 AM
"Support for mlv_dump uncompressed MLV files seems to be broken", maybe that's what I'm experiencing :)
..Hmmm, but does the app actually work? if you can see the clips and adjust them, then the problem is something else.

Terminal gives me this error (if it's of any help):
Thanks! it was useful... figured out from it that Apple must have made a little lie about API support, because I remember reading them saying that was 10.10+, but seems its actually 10.11+, so I've changed it back to what I used before (older API). Could you test again if you find time? It should work now. I'm almost surprised that there was only one error :D

@masc's v0.7 release is getting really good!!!
I don't think ill be able to match it with the cocoa GUI ever :(
Also @masc could you make Tonemapped the default profile for next release? I think it's a better default for most people
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 14, 2017, 09:21:44 AM
This new version (QTv0.7alpha) doesn't output the prores file for me. I can see the png files being created while it's rendering but when it's finished the folder is just empty. I've tried with different settings and also by leaving everything default without any luck.
I'm on OSX 10.10.5.
@FBongcam: Does someone else have this problem? For me that works. Does the progressbar jump from 50 to 100%? If you see pictures in the app it is not the issue I wrote about. It must be an issue with ffmpeg.

@Ilia: Thanks. Qt on OSX is also just wrapped cocoa... ;) I'll try that with the default profile.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on September 14, 2017, 05:02:08 PM
Thanks! it was useful... figured out from it that Apple must have made a little lie about API support, because I remember reading them saying that was 10.10+, but seems its actually 10.11+, so I've changed it back to what I used before (older API). Could you test again if you find time? It should work now. I'm almost surprised that there was only one error :D
Yes it does work now, thanks  :)
However the app crashes every time it has finished exporting the prores, maybe it's something related to 10.10 or is it a known issue?

@FBongcam: Does someone else have this problem? For me that works. Does the progressbar jump from 50 to 100%? If you see pictures in the app it is not the issue I wrote about. It must be an issue with ffmpeg.
Yes it seems to jump from about 50% straight to the notification that the export has finished, as you described. I can see pictures in the app, yes.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 14, 2017, 08:44:00 PM
Yes it does work now, thanks  :)
However the app crashes every time it has finished exporting the prores, maybe it's something related to 10.10 or is it a known issue?
Yes it seems to jump from about 50% straight to the notification that the export has finished, as you described. I can see pictures in the app, yes.
Okay, if Ilias cocoa app crashes on export, and my Qt App jumps from 50..100% then I am nearly 100% sure that ffmpeg does not work on your machine (whyever). If you see the png files - could you please convert manually using ffmpeg in the application bundle? In the Qt app it is located under "MLV App/Contents/MacOS/ffmpeg". Go to this directory in terminal and type
Code: [Select]
./ffmpeg -i "<path to your pngs>/chosenFileName_\%05d.png" -c:v prores_ks -profile:v 2 "<path to your desktop>/test.mov"Does that work? I think it will end with an error. But can you tell us what ffmpeg tells exactly?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on September 14, 2017, 10:06:57 PM
Okay, if Ilias cocoa app crashes on export, and my Qt App jumps from 50..100% then I am nearly 100% sure that ffmpeg does not work on your machine (whyever). If you see the png files - could you please convert manually using ffmpeg in the application bundle? In the Qt app it is located under "MLV App/Contents/MacOS/ffmpeg". Go to this directory in terminal and type
Code: [Select]
./ffmpeg -i "<path to your pngs>/chosenFileName_\%05d.png" -c:v prores_ks -profile:v 2 "<path to your desktop>/test.mov"Does that work? I think it will end with an error. But can you tell us what ffmpeg tells exactly?
The png files also disappear when it's finished but I can see them while it's exporting and as soon as the export says it's finished, everything is gone.

I forced quit MLV App during export to keep some png files it managed to render, just to get a sequence of png files. Then I ran ffmpeg on the files and it created the file succesfully.
Here's what terminal gave me:

Code: [Select]
./ffmpeg -i M12-1835_test_\%05d.png -c:v prores_ks -profile:v 2 "test.mov"
ffmpeg version 3.3.2-tessus Copyright (c) 2000-2017 the FFmpeg developers
  built with Apple LLVM version 8.0.0 (clang-800.0.42.1)
  configuration: --cc=/usr/bin/clang --prefix=/opt/ffmpeg --extra-version=tessus --enable-avisynth --enable-fontconfig --enable-gpl --enable-libass --enable-libbluray --enable-libfreetype --enable-libgsm --enable-libmodplug --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopus --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libtheora --enable-libvidstab --enable-libvo-amrwbenc --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libx264 --enable-libx265 --enable-libxavs --enable-libxvid --enable-libzmq --enable-libzvbi --enable-version3 --disable-ffplay --disable-indev=qtkit
  libavutil      55. 58.100 / 55. 58.100
  libavcodec     57. 89.100 / 57. 89.100
  libavformat    57. 71.100 / 57. 71.100
  libavdevice    57.  6.100 / 57.  6.100
  libavfilter     6. 82.100 /  6. 82.100
  libswscale      4.  6.100 /  4.  6.100
  libswresample   2.  7.100 /  2.  7.100
  libpostproc    54.  5.100 / 54.  5.100
Input #0, image2, from 'M12-1835_test_%05d.png':
  Duration: 00:00:04.28, start: 0.000000, bitrate: N/A
    Stream #0:0: Video: png, rgb48be(pc), 1920x1080, 25 tbr, 25 tbn, 25 tbc
Stream mapping:
  Stream #0:0 -> #0:0 (png (native) -> prores (prores_ks))
Press [q] to stop, [?] for help
Output #0, mov, to 'test.mov':
  Metadata:
    encoder         : Lavf57.71.100
    Stream #0:0: Video: prores (prores_ks) (apcn / 0x6E637061), yuv444p10le, 1920x1080, q=2-31, 200 kb/s, 25 fps, 12800 tbn, 25 tbc
    Metadata:
      encoder         : Lavc57.89.100 prores_ks
frame=    3 fps=0.0 q=-0.0 size=    1889kB time=00:00:00.08 bitrate=193250.8kbitframe=    7 fps=6.3 q=-0.0 size=    4405kB time=00:00:00.24 bitrate=150313.2kbitframe=   11 fps=6.5 q=-0.0 size=    6922kB time=00:00:00.40 bitrate=141740.9kbitframe=   15 fps=6.5 q=-0.0 size=    9442kB time=00:00:00.56 bitrate=138109.9kbitframe=   19 fps=6.6 q=-0.0 size=   11959kB time=00:00:00.72 bitrate=136053.1kbitframe=   23 fps=6.6 q=-0.0 size=   14476kB time=00:00:00.88 bitrate=134747.5kbitframe=   27 fps=6.6 q=-0.0 size=   16992kB time=00:00:01.04 bitrate=133833.9kbitframe=   31 fps=6.6 q=-0.0 size=   19509kB time=00:00:01.20 bitrate=133176.1kbitframe=   35 fps=6.6 q=-0.0 size=   22025kB time=00:00:01.36 bitrate=132662.3kbitframe=   39 fps=6.6 q=-0.0 size=   24543kB time=00:00:01.52 bitrate=132265.1kbitframe=   43 fps=6.7 q=-0.0 size=   27060kB time=00:00:01.68 bitrate=131942.6kbitframe=   47 fps=6.7 q=-0.0 size=   29576kB time=00:00:01.84 bitrate=131673.7kbitframe=   51 fps=6.7 q=-0.0 size=   32094kB time=00:00:02.00 bitrate=131450.9kbitframe=   55 fps=6.7 q=-0.0 size=   34609kB time=00:00:02.16 bitrate=131253.6kbitframe=   59 fps=6.7 q=-0.0 size=   37128kB time=00:00:02.32 bitrate=131094.3kbitframe=   63 fps=6.7 q=-0.0 size=   39647kB time=00:00:02.48 bitrate=130957.6kbitframe=   67 fps=6.7 q=-0.0 size=   42164kB time=00:00:02.64 bitrate=130830.9kbitframe=   71 fps=6.7 q=-0.0 size=   44680kB time=00:00:02.80 bitrate=130716.8kbitframe=   75 fps=6.7 q=-0.0 size=   47197kB time=00:00:02.96 bitrate=130617.7kbitframe=   79 fps=6.7 q=-0.0 size=   49716kB time=00:00:03.12 bitrate=130532.0kbitframe=   83 fps=6.7 q=-0.0 size=   52231kB time=00:00:03.28 bitrate=130447.8kbit[png @ 0x7f8fbc013e00] chunk too big
[png @ 0x7f8fbc014a00] chunk too big
[png @ 0x7f8fbc015600] chunk too big
frame=   87 fps=6.7 q=-0.0 size=   54751kB time=00:00:03.44 bitrate=130380.2kbit[png @ 0x7f8fbc016200] chunk too big
[png @ 0x7f8fbc016e00] chunk too big
[png @ 0x7f8fbc017a00] chunk too big
[png @ 0x7f8fbc018600] chunk too big
frame=   91 fps=6.7 q=-0.0 size=   57267kB time=00:00:03.60 bitrate=130312.5kbit[png @ 0x7f8fbc019200] chunk too big
[png @ 0x7f8fbc010800] chunk too big
[png @ 0x7f8fbc010e00] chunk too big
[png @ 0x7f8fbc011a00] chunk too big
frame=   95 fps=6.7 q=-0.0 size=   59787kB time=00:00:03.76 bitrate=130256.6kbitError while decoding stream #0:0: Invalid data found when processing input
frame=   96 fps=6.6 q=-0.0 Lsize=   60420kB time=00:00:03.80 bitrate=130249.5kbits/s speed=0.263x   
video:60418kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.002408%

A few files in the end of the sequence were broken obviously so maybe that gave some errors, but the prores file is working.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 14, 2017, 10:13:31 PM
Some feedback to qt v0.7 on Linux

Video converts fine (I cannot test audio, because I don´t use it).

Is there a limit for the size of the mlv? Converting a 3GB MLV works, but converting a 7GB MLV let the app crash on importing:
Code: [Select]
*** Error in `/home/edgar/MLV App/MLV-App-master/platform/build-MLVApp-Desktop-Release/MLV App': malloc(): memory corruption: 0x0000000002e05730 ***
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 14, 2017, 11:25:04 PM
@FBongcam: thank you. So that works. Can you tell me the framerate of your clips? If there is a "." in the framerate, some qt librarys could make the "." to a "," and so ffmpeg does not run. Before
Code: [Select]
-i in the command I made a
Code: [Select]
-r 25 for 25 fps in the app. In my case it was always the "." (at 23.x fps), but that may be different from country to country.
Does it work with a 25fps file in your case? Or, easier: check in the preferences menu framerate override and type 25! Does it export now?

Edit: tried it with another locale and have exactly your problem :-) Anyway... does 25fps work for you? Then I can fix it!

@escho: The maximum file size I could test with my 5D2 was 4GB, so I can't tell you. If I get such a big file one day I could debug and help...  :-\
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on September 15, 2017, 12:02:34 AM
@FBongcam: thank you. So that works. Can you tell me the framerate of your clips? If there is a "." in the framerate, some qt librarys could make the "." to a "," and so ffmpeg does not run. Before
Code: [Select]
-i in the command I made a
Code: [Select]
-r 25 for 25 fps in the app. In my case it was always the "." (at 23.x fps), but that may be different from country to country.
Does it work with a 25fps file in your case? Or, easier: check in the preferences menu framerate override and type 25! Does it export now?

Edit: tried it with another locale and have exactly your problem :-) Anyway... does 25fps work for you? Then I can fix it!
Clips are shot at 24p.

I can confirm, turning on framerate override to 25p did work  :)

Edit:
Turning on framerate override to 24p worked as well.
I shoot with fps override set on Exact fps to 24 in magic lantern so the clips should be exactly 24 from the beginning. Just some extra info if it's relevant to your issues with the "." (at 23.x fps).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ottoga on September 15, 2017, 12:49:33 AM
Just had a look at v0.7 cross platform.  The download zip file is for MAC only. IS an x86 build on its way?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 15, 2017, 12:22:27 PM
Clips are shot at 24p.

I can confirm, turning on framerate override to 25p did work  :)

Edit:
Turning on framerate override to 24p worked as well.
I shoot with fps override set on Exact fps to 24 in magic lantern so the clips should be exactly 24 from the beginning. Just some extra info if it's relevant to your issues with the "." (at 23.x fps).
Okay, thanks a lot! That really helped. I think I fixed the Qt version in the repos (don't know how to do in cocoa).

The download zip file is for MAC only. IS an x86 build on its way?
You mean a Windows version? -> Windows version will come if @bouncyball (or someone else) finds some time to build it for you. I only have a mac here atm. But it will come... it just has to be compiled.
Or do you mean OSX x86? I am not sure if it is possible to compile it. Maybe somebody has a SnowLeopard and can compile it...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ottoga on September 15, 2017, 02:59:44 PM
Quote
You mean a Windows version?

Yes,  NP i'm patient.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 15, 2017, 04:25:00 PM
However the app crashes every time it has finished exporting the prores, maybe it's something related to 10.10 or is it a known issue?

Ah yes, this is a bug that appeared recently, it happens for em on 10.13 beta too, the clip does export fully (ffmpeg runs 100% to the end as far as I know @masc, so the bugs in our versions are different probably), but for some reason the app crashes, right before notification gets shown/as it gets shown. I need to fix this before I can make another little testing release.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 15, 2017, 06:09:54 PM
Ah okay, so it is something different. But if it happens for you too, you can debug it... :-)
Did you have some time to look for the processing things like chroma and bad pixel (I commited the source from mlv_dump a while ago)? I had no luck to get it to work yet :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 15, 2017, 06:20:33 PM
Ah yes, I did look at that code a couple of weeks ago, to use it, I'll have to move them to src/mlv because they work on raw data before it is even debayered, what this also means is that if the chroma smoothing and bad pixel features are enabled, the caching will have to be re-done as debarred results will change. Also an idea for Qt app: close clips when switching between them so you can enable caching? Or maybe close clips after a few seconds in case user quickly switches back, then enable caching when all others are closed??
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 15, 2017, 06:32:30 PM
Hey guys!

@masc, @ilia3101

While on vacation I did some progress with low level raw processing integration to MLV App. I ported almost everything I did in the past with mlv_dump on steroids: stripes, focus pixels, bad pixels, chroma smooth, pattern noise and even deflicker function of MLVFS. There is only rudimentary visual GUI implementation though. However all settings can be changed in 'initLLRawProcObject' routine. Also there 'DEFINES += STDOUT_SILENT' is commented out and you can watch on console all verbose messages during raw processing. Later, I will upload focus pixel maps and some testing 100D and EOSM footage MLVs to test it with.

Look at my fork here: https://github.com/bouncyball-git/MLV-App/commits/master (https://github.com/bouncyball-git/MLV-App/commits/master).
I would really appreciate opinions of both of you :)

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 15, 2017, 06:38:58 PM
@bouncyball: great! I'll test that! :)
@Ilia: In the Qt app there is always only one file opened, the files in the session are only listed. But when enabling caching I get crashes and pink frames.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 15, 2017, 07:02:48 PM
Wohooo... I like the processing! All the bad pixels are gone! :) In the GUI I would place the fields a bit different, because my 1280x800 display is too small now :) But that is really no problem. But between the GUI elements and your processing object is no connection yet, or? You planned to implement the functions to change the settings (I think so)... Nice work! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 15, 2017, 07:29:41 PM
@bouncball Awesome of you to do that! Thanks a lot.
Will see how it works.
When do you plan to commit it to main repository? (Or "pull request" it)

Sorry about some of the code from my C learning phase(overcommented :-[)

After you merge it, I'll work on getting caching compatible with your module (needs clearing on changes), probably a full rewrite. (unless you did that, but I don't ask that of you if you haven't ;), as Qt doesn't even use it at this moment)

Anyway thanks again!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 15, 2017, 07:51:58 PM
@bouncyball
I know your code works, but it won't compile for me, I'm just not sure why it would just randomly begin erroring like this:

(http://image.ibb.co/huXGJk/Screen_Shot_2017_09_15_at_18_48_24.png)

Does it need some special compile flags? Do you know what it could be?
The type errors should be a matter of #including stdint, but what are the undeclared identifiers?

EDIT: never mind, found my idiotic mistake :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 15, 2017, 09:17:18 PM
@Ilia: strange... with clang in Qt it compiles... :-/
@bouncyball: I would draw the MainWindow like that: https://www.dropbox.com/s/elhz5plgy55qfwx/MainWindow.ui?dl=0 (https://www.dropbox.com/s/elhz5plgy55qfwx/MainWindow.ui?dl=0)
What do you think?

Edit: I found one thing: if vertical stripes is enabled, Highlight reconstruction does not work. And for the first clip opened, bad pixel does not work. If I switch to another clip, and switch back, all is fine. But those things we can debug later ;) It is a huge change!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 16, 2017, 07:21:55 AM
@ilia3101: I will do pull request when we settle all issues/problems. It's a working draft which can be changed anytime especially when connection to GUI is implemented (it's not implemented right now).

@masc: I'm ok with any gui you offer and will appreciate your help on implementing it (will look at your .ui file later) I'm still learning QT basics :). Nice bug catching, as you mentioned changes are big.

I had to rewrite lot of my code to port this. There I used lots of static local variables in mlv_dump because it works only with one MLV at a time and this approach very convenient. Now in MLV App there can be any number of MLV object instances (I know, now, objects are freed every time when choosing another MLV but anyway) so it would not work here.

BTW I noticed very annoying and strange bug under linux when using MLV App. When resizing main window if no MLV is imported yet, window can be enlarged horizontally but can not be made smaller again ;). This issue disappears if MLV imported and window can be shrunk again. Have not tried this under windows though.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 16, 2017, 07:25:27 AM
Great effort BB. Will check this out soon.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 16, 2017, 07:29:15 AM
@Danne: :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 16, 2017, 01:43:37 PM
BTW I noticed very annoying and strange bug under linux when using MLV App. When resizing main window if no MLV is imported yet, window can be enlarged horizontally but can not be made smaller again ;).
Also had this on Mac

I found one thing: if vertical stripes is enabled, Highlight reconstruction does not work. And for the first clip opened, bad pixel does not work. If I switch to another clip, and switch back, all is fine. But those things we can debug later ;) It is a huge change!
These kind of things are normally silly bugs by me, I'll have a look what is causing it today(or maybe this one is deeper?).

@bouncyball what are the default settings in your module already doing? Is stripe correction on by default?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 16, 2017, 04:29:51 PM
@bouncyball what are the default settings in your module already doing? Is stripe correction on by default?

This is the 'llrawprocObject_t' struct:
Code: [Select]
typedef struct
{
    /* flags */
    int vertical_stripes; // fix vertical stripes, 0 - do not fix", 1 - fix, 2 - calculate for every frame
    int focus_pixels;     // fix focus pixels, 0 - do not fix, 1 - fix
    int fpi_method;       // focus pixel interpolation method: 0 - mlvfs, 1 - raw2dng
    int bad_pixels;       // fix bad pixels, 0 - do not fix, 1 - fix, 2 - makes algorithm aggresive to reveal more bad pixels
    int bpi_method;       // bad pixel interpolation method: 0 - mlvfs, 1 - raw2dng
    int chroma_smooth;    // chroma smooth, 2 - cs2x2, 3 - cs3x3, 5 - cs5x5
    int pattern_noise;    // fix pattern noise (0, 1)
    int deflicker_target; // deflicker value
    int first_time;       // controls some events which should occur only once per object instance
    int fpm_status;       // focus pixel map status: 0 = not loaded, 1 = loaded, 2 = not exist
    int bpm_status;       // bad pixel map status: 0 = not loaded, 1 = loaded, 2 = not exist, 3 = no bad pixels found
    int dual_iso;         // is RAW data dualiso or not (0, 1, for correctly prosessing of bad/focus pixels, can be removed if DISO block parsing is implemented)

    /* LUTs */
    int * raw2ev;
    int * ev2raw;

    /* pixel maps */
    pixel_map focus_pixel_map;
    pixel_map bad_pixel_map;

    /* stripe corrections */
    stripes_correction stripe_corrections;

    /* image buffer */
    uint16_t * raw_image_buff;
    size_t raw_image_size;

} llrawprocObject_t;

And the defaults are:
Code: [Select]
/* set defaults */
    llrawproc->vertical_stripes = 1; // enabled
    llrawproc->focus_pixels = 1; // enabled
    llrawproc->fpi_method = 1; // raw2dng interpolation method
    llrawproc->bad_pixels = 1; // enabled
    llrawproc->bpi_method = 1; // raw2dng interpolation method
    llrawproc->chroma_smooth = 0; // disabled
    llrawproc->pattern_noise = 0; // disabled
    llrawproc->deflicker_target = 0; // disabled
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 16, 2017, 07:31:18 PM
Thanks @bouncyball for yet bringing another life into this already remarkable app with so much potential. Will test out QTv0.7alpha and report my findings!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 16, 2017, 09:05:16 PM
I'm ok with any gui you offer and will appreciate your help on implementing it (will look at your .ui file later) I'm still learning QT basics :).
I help where I can! :) Or, just give me the interfaces and I'll do it - no problem ;)

I had to rewrite lot of my code to port this. ...
Wow, good job. I see, it was even more work than I thought!

BTW I noticed very annoying and strange bug under linux when using MLV App. When resizing main window if no MLV is imported yet, window can be enlarged horizontally but can not be made smaller again ;). This issue disappears if MLV imported and window can be shrunk again. Have not tried this under windows though.
Yes, my fault. I fixed that yesterday. See Ilias github. https://github.com/ilia3101/MLV-App/commit/76a727395e6f2c5bef4d559d76809806cb4046f8 (https://github.com/ilia3101/MLV-App/commit/76a727395e6f2c5bef4d559d76809806cb4046f8)

Will test out QTv0.7alpha and report my findings!
Thx! Perfect! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 17, 2017, 10:03:29 AM
I'm going to work on getting bouncyball's work implemented in the Cocoa GUI. @masc what do you think of having tabs on the right panel, one for the raw level processing by bouncyball, one for the standard raw adjustments we already have, and in the future, a final tweaks tab with more colour adjustment type things.

@bouncyball I see you have to set internal properties on the llrawprocObject (raw_image_buff and raw_image_size), I know maybe it wouldn't be how you want it, but what do you think of making it an option to do something like applyLLRawProcObject() but with extra arguments for the image buffer and image size, as I think in the future(when cache is fixed), there will be a few threads caching separate frames at the same time, so the object having it's one image buffer internally could be an issue.

Something approximately like: applyLLRawProcObjectToBuffer(mlvObject, buffer, size) ?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 17, 2017, 12:14:08 PM
@Ilia: this is exactly what I thought too. You have Qt not installed, so you could not see my .ui I uploaded some posts above. Here how it looks:

(https://image.ibb.co/bEb7tk/Bildschirmfoto_2017_09_17_um_12_09_40.png)

Process is what we had before (but without the profile combobox), Correct is the RAW correction, and Profile is the profile combobox + LUT (maybe we want support that in the future? Would be cool to import .cube files).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 17, 2017, 04:03:23 PM
Hey guys!

I've fixed severe bug caused by overwritten black and white levels right after opening and reading MLV headers in openMlvClip routine. Bayered raw data processing requires original values from MLV. Look at my commits here (https://github.com/bouncyball-git/MLV-App/commits/master).

Here is a console output example when everything is set to ON:
Code: [Select]
Per-frame exposure compensation: 'ON'
Deflicker target: '3072'

Fixing pattern noise...

Using focus pixel map: '80000326_1808x726.fpm'
37440 pixels loaded

Searching for bad pixel types:
HOT  - p = 2271, dark_min = 1949, dark_max = 2141
COLD - p = 1943, dark_min = 1949, dark_max = 2141
COLD - p = 1938, dark_min = 1949, dark_max = 2141
HOT  - p = 2147, dark_min = 1949, dark_max = 2141
HOT  - p = 2207, dark_min = 1949, dark_max = 2141
HOT  - p = 2148, dark_min = 1949, dark_max = 2141
COLD - p = 1948, dark_min = 1949, dark_max = 2141
HOT  - p = 2154, dark_min = 1949, dark_max = 2141
HOT  - p = 2151, dark_min = 1949, dark_max = 2141
HOT  - p = 2145, dark_min = 1949, dark_max = 2141
COLD - p = 1931, dark_min = 1949, dark_max = 2141
COLD - p = 1915, dark_min = 1949, dark_max = 2141
HOT  - p = 2167, dark_min = 1949, dark_max = 2141
COLD - p = 1925, dark_min = 1949, dark_max = 2141
HOT  - p = 2195, dark_min = 1949, dark_max = 2141
HOT  - p = 2790, dark_min = 1949, dark_max = 2141
COLD - p = 1946, dark_min = 1949, dark_max = 2141
HOT  - p = 2156, dark_min = 1949, dark_max = 2141
COLD - p = 1888, dark_min = 1949, dark_max = 2141
COLD - p = 1938, dark_min = 1949, dark_max = 2141
HOT  - p = 2315, dark_min = 1949, dark_max = 2141
COLD - p = 1943, dark_min = 1949, dark_max = 2141
COLD - p = 1947, dark_min = 1949, dark_max = 2141
COLD - p = 1941, dark_min = 1949, dark_max = 2141
HOT  - p = 2157, dark_min = 1949, dark_max = 2141
HOT  - p = 2226, dark_min = 1949, dark_max = 2141
HOT  - p = 2207, dark_min = 1949, dark_max = 2141

Using bad pixel revealing method: 'NORMAL'
27 bad pixels found (crop: 152, 132)

Using chroma smooth method: '2x2'

Vertical stripes correction: 'UNNEEDED'
  1.00000  1.00000  1.00035  1.00047  0.99953  0.99930  0.99995  0.99875

@masc: I loved your .ui file! Tabbed version is very good! :). Still tracking bug which causes not fixing bad pixels on first load.

HERE (http://nic.caucasus.net/mlvapp/?dir=&download=Test_footage_and_focus_pixel_maps.zip) is a zip file with 3 MLVs for testing (EOSM, 100D and 700D ones, thanx to Danne and dfort) and focus pixel maps which should be placed in the same dir with MLV App binary.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 17, 2017, 04:18:35 PM
I see you have to set internal properties on the llrawprocObject (raw_image_buff and raw_image_size), I know maybe it wouldn't be how you want it, but what do you think of making it an option to do something like applyLLRawProcObject() but with extra arguments for the image buffer and image size, as I think in the future(when cache is fixed), there will be a few threads caching separate frames at the same time, so the object having it's one image buffer internally could be an issue.

Something approximately like: applyLLRawProcObjectToBuffer(mlvObject, buffer, size) ?
Technically there is no problem with passing extra parameters at all. However I thought llrawproc object should be separate for each mlvObject instance in the future with all it's unique parameters. For example raw2ev and ev2raw LUTs are calculated every time for every MLV because of the black level and bit depth, also stripe corrections array and bad/focus pixel map arrays are specific to particular mlvObject. We should discuss this on github I guess.

In contrary, if I understand it correctly, ProsessingObject allocated once and its values are refreshing according to recipe every time we switch the mlv, am I right?

EDIT: Right. Now I understand what you mean by saying "there will be a few threads caching separate frames at the same time, so the object having it's one image buffer internally could be an issue". Will see what can I do about it.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 17, 2017, 04:37:50 PM
@DeafEyeJedi

Thanks @bouncyball for yet bringing another life into this already remarkable app with so much potential. Will test out QTv0.7alpha and report my findings!
It's nice to see you still watching and testing things like in a good old times :D

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 17, 2017, 05:28:57 PM
@bouncyball Ah, the overwritten black level, I'm sorry that was there, if you want, you can remove it and keep the original levels, and remove the whole 16 bit conversion bitshift, and simply pass the original 10/12/14 bit values to the processingObject, as it should be competely fine if you give it the right black and white levels that match the smaller range.

Yes I agree with having a unique object for every clip, I just meant that I want to pass the image data directly to the 'apply' function, so that it can be used from many threads (on the same clip of course).

@deafeyejedi :)

@masc that looks pretty much like what I imagined! Although I don't think it's worth having a separate profile tab yet, as the customisability isn't that interestingly yet, I think it would be fine to keep it in the processing tab for now.
Cube luts are definitely something I want to add, just don't know how they work yet, although I think the LUT tool would go in with the final adjustments section.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 17, 2017, 07:25:06 PM
you can remove it and keep the original levels, and remove the whole 16 bit conversion bitshift, and simply pass the original 10/12/14 bit values to the processingObject, as it should be competely fine if you give it the right black and white levels that match the smaller range.
Hmm... did you try this and it worked well? Why we need to convert data to 16 bits if debayering and processing code does not really need this? Did you have something different on your mind doing this? Or was it just for simplicity to not handle all 10/12/14 bit black correction separately?

@masc that looks pretty much like what I imagined! Although I don't think it's worth having a separate profile tab yet, as the customisability isn't that interestingly yet, I think it would be fine to keep it in the processing tab for now.
Well guys, if you liked changes (and I can confirm that ~98% of it working correctly ;) ) then maybe I will do pull request before we start integrating it with GUI?

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 17, 2017, 07:54:44 PM
@masc that looks pretty much like what I imagined! Although I don't think it's worth having a separate profile tab yet, as the customisability isn't that interestingly yet, I think it would be fine to keep it in the processing tab for now.
Cube luts are definitely something I want to add, just don't know how they work yet, although I think the LUT tool would go in with the final adjustments section.
Cool. Yes, I also would like to have the profiles in the process tab for now. But because of the tab bar it was one element to high to work at 1280x800 with dock. So I was thinking about a 3rd tab... What we also could do: adding a scrolling area (instead or inside the tabs) Adobe Lightroom-like.

Well guys, if you liked changes (and I can confirm that ~98% of it working correctly ;) ) then maybe I will do pull request before we start integrating it with GUI?
The GUI is often the nice part. But I think the GUI should be the last thing to do. The non-Qt part of the app - all the processing stuff - is the most important and should work as good as possible before! This also makes implementing a nice GUI very easy ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 17, 2017, 08:41:16 PM
@bouncyball originally this program was a single .c file(pre-gui), and mostly hard coded, so yeah, I originally did that just for simplicity ( I wasn't even reading mlv headers properly), but now it should be fine without that, I tried it recently, but I only tested briefly with 14 bit files, not 100% sure how AMaZE demosaic would react to a <1023 value range, as it already crushes the blacks a little too much (compare it with the bilinear some time), but most likely will be completely fine.

EDIT: Oh yeah, the black level correction relies on black level being in 14 bit world, maybe do something with pow? (for short code, efficiency doesn't matter there anyway)

And yeah, you can pull request as it seems to work without any changes to the GUI required. And I like it 8)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 18, 2017, 11:18:38 AM
What we also could do: adding a scrolling area (instead or inside the tabs) Adobe Lightroom-like.
I've been also thinking about it. Scrolling area instead of tab.

I tried it recently, but I only tested briefly with 14 bit files, not 100% sure how AMaZE demosaic would react to a <1023 value range, as it already crushes the blacks a little too much (compare it with the bilinear some time), but most likely will be completely fine.
Unfortunatelly with 10/12 bits just deleting black level correction code not working, e.g. all debayered image is light gray. For 14 bits it's working as expected. That is why, as a workaround, I introduced 2 variables in llrawprocObject to back up black/white levels right before altering them in openMlvClip.

And... I made PR :D

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 18, 2017, 07:57:49 PM
Cool. Yes, I also would like to have the profiles in the process tab for now. But because of the tab bar it was one element to high to work at 1280x800 with dock. So I was thinking about a 3rd tab... What we also could do: adding a scrolling area (instead or inside the tabs) Adobe Lightroom-like.

+1

The GUI is often the nice part. But I think the GUI should be the last thing to do. The non-Qt part of the app - all the processing stuff - is the most important and should work as good as possible before! This also makes implementing a nice GUI very easy ;)

Agreed.

And... I made PR :D

regards
bb

Thanks for this!  :)

Anyway here's my brief test run on MLV App v0.7 alpha. To be honest I was rather more anxious and tempted for BB's work to be implemented in the near future. Especially with mlv_dump on steroids. Just imagine being able to spit out Dual-ISO stuff directly from this app? Still this is all exciting stuff regardless.

So far it seems to work as advertised even though it's still in alpha stages. I noticed my Mac didn't like having FCPX running in the background while running this app. It does this random quick restart. No big deal since that's just me pushing the limits of my mid-2012 MBP 15" (OS X 10.12.6, 2.6 i7, 16GB Ram, 500GB + 1TB SSD w NVIDIA GeForce GT 650M 124 MB/ Intel HD Graphics 4000 1536 MB) which is not too shabby for ML stuff, right? Ha.

Anyway off to my findings:

1) I was pleased to see that it can open 12-bit lossless files with ease even FRSP Timelapse MLV's with the exception of spanning files. I noticed the app doesn't seem to pick up from the end of MLV to the next spanning files (.M00, .M01, .M02, etc) so therefore the footage just cuts in short from the original large MLV files w the spanning. Perhaps this was to be expected since it's still in alpha mode. Though it would be important to include this fix asap.  :P

2) I was also pleased with how the Audio files look when viewing the player from underneath. Makes it feel like a classic MLRawViewer from the future. Will have to test this more thoroughly in terms of length of the audio file matching the length of video file. Will get more into this later.

3) I was bummed to see that I couldn't copy and paste the preferred settings from one file to ALL files at once. Seems the app only allows you to copy and paste one file at a time. Maybe this is intended for now until we progress further. Would be nice to be able to paste the entire batch at once w ease.

4) I actually enjoy using the 100% viewer option (even during playback) which is handy for focus checking especially with 3.5-4K footage. Maybe in the future we can add 200%-400% zoom in as options?

5) Maybe this is to be expected but regardless of how nice it is to be able to batch export ProRes into an output folder since it is still spitting out png files (not that big of a deal but seems unnecessary) however it does delete them automatically once the ProRes is rendered. So not complaining about disk space in here but rather than work amount being involved? Is it required to do the png route in order to spit out ProRes? Hopefully once we get the AVFoundation installed within the app then we will be able to spit out 4444XQ especially with logs.

According to my eyes -- it seems when shooting clouds up in the sky and spitting out logs in 4444 comparing them to 4444XQ you will see more gradient pattern effects on the 4444 as oppose to smoother look of 4444XQ. Correct me on this @reddeercity if you can.

6) I also like how when you select ColorSpace to a certain Log (most of the sliders become disabled not allowing you to affect the footage as expected) w the exception to Exposure, Temp and Tint which is plus. Is this a safety feature intended for rookies? Bold decision.

More to come later. Will upload a quick screen recording of my findings when I can. Thanks to everyone on board in getting this revamped up!  8)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 18, 2017, 08:10:12 PM
@masc Sorry for ignoring the post above, yeah I think eventually we might have to add a scroll area once more capability is added to processing, such as highlight reconstruction. Although it would be sad to add it now, as it would only be a small annoying amount of scrolling. Do you think there's any chance of compressing the sliders and labels a little more? Or is Qt layout at it's limit.
Also the tint slider in Qt GUI still seems to go wrong(image is blue) when fully to the green side, could you copy the Cocoa app's mehtod for doing it?:
Code: [Select]
-(void)tintSliderMethod
{
    double tintSliderValue = [self doubleValue] - 0.5;
    /* Control should be more fine when its closer to zero... */
    double tintValue = tintSliderValue;
    if (tintValue < 0) tintValue = -tintValue;
    tintValue = pow(tintValue, 1.7) * 20.0;
    if (tintSliderValue < 0) tintValue = -tintValue;
    processingSetWhiteBalanceTint(App->processingSettings, tintValue);
    [App->tintValueLabel setStringValue: [NSString stringWithFormat:@"%6.3f", ([self doubleValue] - 0.5) * 2 ]];
}
I think it produces a good range and correct feel. (of course adapt for Qt's integer slider)
Also, important: can you add the "cHRM Chunk" to libpng files? From this documentation: http://www.libpng.org/pub/png/book/chapter10.html
Might begin filling it with values once actual gamut/space options are added(and hopefully ffmpeg won't ignore that info).

@bouncyball We begin the pull request process! whatever that means :D Will look on github
I will have a go at making bitdepth work in its native value range later, once pull request is merged.

@deafeyejedi Thanks for the testing and feedback!
6) I also like how when you select ColorSpace to a certain Log (most of the sliders become disabled not allowing you to affect the footage as expected) w the exception to Exposure, Temp and Tint which is plus. Is this a safety feature intended for rookies? Bold decision.
I thought that might be better for accuracy of the profiles, although I haven't got colour spaces fully implemented so I can't talk too much ;)
It's about time to nag andy600 with questions if he has time to answer :)... does anyone know where to do that? (haven't managed to make it look right with camera specific matrices yet, but get most of the math now)
Also AVFoundation slowly coming along, will make it as a library so Qt App can implement it too, I hear ffmpeg has flaws in its prores encoding in terms of colour(according to reddeercity), or is limited in colour space, dunno, maybe what I asked masc about may help fix it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 18, 2017, 10:29:07 PM
Thank you DeafEyeJedi!

I noticed my Mac didn't like having FCPX running in the background while running this app. It does this random quick restart.

What exactly do you mean with that? Does the App crash when working with FPCX?

1) I noticed the app doesn't seem to pick up from the end of MLV to the next spanning files (.M00, .M01, .M02, etc)

Yes, this is still not implemented. We should do it soon.

2)Will have to test this more thoroughly in terms of length of the audio file matching the length of video file.

That would be interesting, but I expect it will not fit after a longer playback time. But when stopping and restarting anywhere in the clip it should fit again.

3) I was bummed to see that I couldn't copy and paste the preferred settings from one file to ALL files at once. Seems the app only allows you to copy and paste one file at a time. Maybe this is intended for now until we progress further. Would be nice to be able to paste the entire batch at once w ease.

That is a good idea. How would you do it? Selecting the files in the left and then paste?

4) Maybe in the future we can add 200%-400% zoom in as options?

That should not be too complicated.

5) Maybe this is to be expected but regardless of how nice it is to be able to batch export ProRes into an output folder since it is still spitting out png files (not that big of a deal but seems unnecessary) however it does delete them automatically once the ProRes is rendered. So not complaining about disk space in here but rather than work amount being involved? Is it required to do the png route in order to spit out ProRes?

Yes, it is necessary, because the mov is built from the pngs. After that the pngs are not needed anymore and are deleted. What I could do - making it like Ilia does in the cocoa app: making the pngs invisible.

Hopefully once we get the AVFoundation installed within the app...

+1

@masc Sorry for ignoring the post above, yeah I think eventually we might have to add a scroll area once more capability is added to processing, such as highlight reconstruction. Although it would be sad to add it now, as it would only be a small annoying amount of scrolling. Do you think there's any chance of compressing the sliders and labels a little more? Or is Qt layout at it's limit.

I tried to compress it a bit and I think it could work. Waiting for the pull request and then I'll add it.

Also the tint slider in Qt GUI still seems to go wrong(image is blue) when fully to the green side, could you copy the Cocoa app's mehtod for doing it?

I'll look deeper into that. I also recognized that in the past.

Also, important: can you add the "cHRM Chunk" to libpng files? From this documentation: http://www.libpng.org/pub/png/book/chapter10.html
Might begin filling it with values once actual gamut/space options are added(and hopefully ffmpeg won't ignore that info).

Yes, I wanted to do that. Thx for the reminder...

I now add all this points to the issue tracker that we don't forget that. At least for my head this is too much input  ;D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 20, 2017, 11:26:14 PM
Since imageio doesn´t exist anymore in the src-folder, these lines are no longer needed in MLVApp.pro, I guess.

Lines 92, 93
Code: [Select]
../../src/imageio/structs/imagestruct.h \
../../src/imageio/imageio.h \

Line 136
Code: [Select]
../../src/imageio/README.md \
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 21, 2017, 12:44:03 PM
Since imageio doesn´t exist anymore in the src-folder, these lines are no longer needed in MLVApp.pro, I guess.
Right. I changed it. Thank you!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 21, 2017, 04:16:46 PM
Hey!

@Ilia3101: I pushed the commit you asked - removed pointers to raw image buffer from the struct and passed as parameters of apply function. You are right, it's not only convenient, like this it's more elegant too :).

@masc: pushed commit with the fix of the issue we experienced. Now all is working ( hopefully ;) ). And thank you for implementing raw fixes GUI tab. Works great! Just one comment: default values in the source code and in the GUI (Correct tab) are not synced. Can you fix this?

defaults are:
Code: [Select]
Focus dots ON int 1
Bad pixels ON int 1
Chroma smooth OFF
Pattern noise OFF
Vertical stripes ON
Deflicker target 0

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 21, 2017, 10:59:30 PM
Thanks bouncyball
I can begin implementing a multithreaded cache that works :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2017, 11:00:20 AM
@Ilia3101: Cool! :D
@masc: Loved your changes in "Correct" tab :)

I pushed commit which fixes my bug causing slowing down the playback by about 30-50% :P

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 22, 2017, 05:35:14 PM
Did some python removal and reinstalling and maybe something else but now I can´t compile "make app" anymore. clang complaining and some other stuff. Can you spot what I need here(mac)?:
Code: [Select]
Undefined symbols for architecture x86_64:
  "_applyLLRawProcObject", referenced from:
      _getMlvRawFrameFloat in video_mlv.o
  "_initLLRawProcObject", referenced from:
      _initMlvObjectWithClip in video_mlv.o
      _initMlvObject in video_mlv.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [build] Error 1
cp: MLV App: No such file or directory
cp: checkupdate.py: No such file or directory
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg 
dans-MBP:cocoa dan$ make clean
rm -rf "MLV App" "MLV App".app main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o *.o
dans-MBP:cocoa dan$

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 22, 2017, 06:08:49 PM
Weird... not sure why that would happen, doesn't seem like it's related to python. It seems to be a linking error...
As it appears bouncyball's new functions are not compiling for you, so when they are called in other code they can't be found.

I had a minor macOS update recently, which broke all apple developer tools including the clang compiler, way I fixed it then was just a quick re-run of xcode-select --install
Maybe all the python reinstallations messed some minor thing up in the folders where your apple tools are.

... speaking of bouncyball's new work, there's not yet access to it in the Cocoa GUI, so you can't really test it much unless you change llrawprocobject's defaults and recompile to see changes :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 22, 2017, 06:20:04 PM
Will dig further. Probably not realted to python at all as you mention.
Tested 0.7 from first post and realtime previewing. Dude, that´s amazing.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 22, 2017, 06:43:02 PM
Same here having issues with compiling after 'make app'. May be just because I am using a Mac Mini that's been sitting here for months and may not have proper set-up for it?

Code: [Select]
Last login: Fri Sep 22 09:29:52 on ttys000
Seans-Mac-mini-385:~ DeafEyeJedi$ git clone https://github.com/ilia3101/MLV-App.git
Cloning into 'MLV-App'...
remote: Counting objects: 2031, done.
remote: Total 2031 (delta 0), reused 0 (delta 0), pack-reused 2031
Receiving objects: 100% (2031/2031), 40.37 MiB | 345.00 KiB/s, done.
Resolving deltas: 100% (1395/1395), done.
Seans-Mac-mini-385:~ DeafEyeJedi$ cd MLV-App/platform/cocoa
Seans-Mac-mini-385:cocoa DeafEyeJedi$ make app
rm "MLV App".app; \
gcc  -mmacosx-version-min=10.10 -O3 -Ofast -m64 generate_info_plist.c -o generate_info_plist; \
./generate_info_plist "MLV App"; \
make main; \
rm -rf "MLV App".app; \
mkdir "MLV App".app; \
mkdir "MLV App".app/Contents; \
mkdir "MLV App".app/Contents/MacOS; \
mkdir "MLV App".app/Contents/Resources; \
cp -i "MLV App" "MLV App".app/Contents/MacOS/; \
cp -i info.plist "MLV App".app/Contents/; \
cp -i checkupdate.py "MLV App".app/Contents/Resources/; \
unzip ../qt/FFmpeg/ffmpegOSX.zip -d "MLV App".app/Contents/Resources; \
rm -rf "MLV App".app/Contents/Resources/__MACOSX; \
cp ../../src/icon/icon.icns "MLV App".app/Contents/Resources/MLV\ App.icns; \
rm generate_info_plist; \
rm info.plist; \

rm: MLV App.app: No such file or directory
ld: warning: object file (/var/folders/t9/v524s9d54pqd8920btl0zjch0000gn/T//ccnIPcw2.o) was built for newer OSX version (10.12) than being linked (10.10)
ld: warning: object file (/usr/local/Cellar/gcc/5.2.0/lib/gcc/5/gcc/x86_64-apple-darwin15.0.0/5.2.0/crtfastmath.o) was built for newer OSX version (10.11) than being linked (10.10)
gcc  -mmacosx-version-min=10.10 -O3 -Ofast -m64 compile_time_code.m -o compile_time_code -framework Cocoa; \
./compile_time_code; \
rm main.o; \
make build; \
rm compile_time_code; \
rm app_defines.h
In file included from /usr/include/Availability.h:184:0,
                 from /usr/local/Cellar/gcc/5.2.0/lib/gcc/5/gcc/x86_64-apple-darwin15.0.0/5.2.0/include-fixed/math.h:46,
                 from /System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:24,
                 from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:6,
                 from /System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:12,
                 from compile_time_code.m:5:
/System/Library/Frameworks/CoreFoundation.framework/Headers/CFDateFormatter.h:53:34: error: expected ',' or '}' before '__attribute__'
     kCFISO8601DateFormatWithYear API_AVAILABLE(macosx(10.12), ios(10.0), watchos(3.0), tvos(10.0)) = (1UL << 0),
                                  ^
/System/Library/Frameworks/CoreFoundation.framework/Headers/CFDateFormatter.h:80:126: error: 'introduced' undeclared here (not in a function)
 CFDateFormatterRef CFDateFormatterCreateISO8601Formatter(CFAllocatorRef allocator, CFISO8601DateFormatOptions formatOptions) API_AVAILABLE(macosx(10.12), ios(10.0), watchos(3.0), tvos(10.0));
                                                                                                                              ^
/System/Library/Frameworks/CoreFoundation.framework/Headers/CFURL.h:777:39: error: 'deprecated' undeclared here (not in a function)
 const CFStringRef kCFURLLabelColorKey API_DEPRECATED("Use NSURLLabelColorKey", macosx(10.6, 10.12), ios(4.0, 10.0), watchos(2.0, 3.0), tvos(9.0, 10.0));
                                       ^
/System/Library/Frameworks/CoreFoundation.framework/Headers/CFURL.h:777:39: error: 'message' undeclared here (not in a function)
 const CFStringRef kCFURLLabelColorKey API_DEPRECATED("Use NSURLLabelColorKey", macosx(10.6, 10.12), ios(4.0, 10.0), watchos(2.0, 3.0), tvos(9.0, 10.0));

Code: [Select]
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:95:166: error: expected ')' before 'NSString'
 - (instancetype)initWithFetchRequest:(NSFetchRequest<ResultType> *)fetchRequest managedObjectContext: (NSManagedObjectContext *)context sectionNameKeyPath:(nullable NSString *)sectionNameKeyPath cacheName:(nullable NSString *)name;
                                                                                                                                                                      ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:95:207: error: unknown type name 'nullable'
 - (instancetype)initWithFetchRequest:(NSFetchRequest<ResultType> *)fetchRequest managedObjectContext: (NSManagedObjectContext *)context sectionNameKeyPath:(nullable NSString *)sectionNameKeyPath cacheName:(nullable NSString *)name;
                                                                                                                                                                                                               ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:95:216: error: expected ')' before 'NSString'
 - (instancetype)initWithFetchRequest:(NSFetchRequest<ResultType> *)fetchRequest managedObjectContext: (NSManagedObjectContext *)context sectionNameKeyPath:(nullable NSString *)sectionNameKeyPath cacheName:(nullable NSString *)name;
                                                                                                                                                                                                                        ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:110:1: error: cannot find protocol declaration for 'ResultType'
 @property(readonly) NSFetchRequest<ResultType> *fetchRequest;
 ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:118:20: error: unknown property attribute before ',' token
 @property (nullable, readonly) NSString *sectionNameKeyPath;
                    ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:118:1: note: 'assign' can be unsafe for Objective-C objects; please state explicitly if you need it
 @property (nullable, readonly) NSString *sectionNameKeyPath;
 ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:122:20: error: unknown property attribute before ',' token
 @property (nullable, readonly) NSString *cacheName;
                    ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:122:1: note: 'assign' can be unsafe for Objective-C objects; please state explicitly if you need it
 @property (nullable, readonly) NSString *cacheName;
 ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:126:19: error: unknown property attribute before ',' token
 @property(nullable, nonatomic, assign) id< NSFetchedResultsControllerDelegate > delegate;
                   ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:126:1: note: 'assign' can be unsafe for Objective-C objects; please state explicitly if you need it
 @property(nullable, nonatomic, assign) id< NSFetchedResultsControllerDelegate > delegate;
 ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:131:30: error: unknown type name 'nullable'
 + (void)deleteCacheWithName:(nullable NSString *)name;
                              ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:131:39: error: expected ')' before 'NSString'
 + (void)deleteCacheWithName:(nullable NSString *)name;
                                       ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:140:21: error: unknown property attribute before ',' token
 @property  (nullable, nonatomic, readonly) NSArray<ResultType> *fetchedObjects;
                     ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:140:21: error: cannot find protocol declaration for 'ResultType'
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:140:1: note: 'assign' can be unsafe for Objective-C objects; please state explicitly if you need it
 @property  (nullable, nonatomic, readonly) NSArray<ResultType> *fetchedObjects;
 ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:144:4: error: unknown type name 'ResultType'
 - (ResultType)objectAtIndexPath:(NSIndexPath *)indexPath;
    ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:148:3: error: unknown type name 'nullable'
 -(nullable NSIndexPath *)indexPathForObject:(ResultType)object;
   ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:148:12: error: expected ')' before 'NSIndexPath'
 -(nullable NSIndexPath *)indexPathForObject:(ResultType)object;
            ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:148:46: error: unknown type name 'ResultType'
 -(nullable NSIndexPath *)indexPathForObject:(ResultType)object;
                                              ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:161:4: error: unknown type name 'nullable'
 - (nullable NSString *)sectionIndexTitleForSectionName:(NSString *)sectionName;
    ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:161:13: error: expected ')' before 'NSString'
 - (nullable NSString *)sectionIndexTitleForSectionName:(NSString *)sectionName;
             ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:168:50: error: expected '>' before '*' token
 @property (nonatomic, readonly) NSArray<NSString *> *sectionIndexTitles;
                                                  ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:168:50: error: cannot find protocol declaration for 'NSString'
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:177:20: error: unknown property attribute before ',' token
 @property (nullable, nonatomic, readonly) NSArray<id<NSFetchedResultsSectionInfo>> *sections;
                    ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:177:53: error: expected '>' before '<' token
 @property (nullable, nonatomic, readonly) NSArray<id<NSFetchedResultsSectionInfo>> *sections;
                                                     ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:177:53: error: cannot find protocol declaration for 'id'
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:195:19: error: unknown property attribute before ',' token
 @property(nullable, nonatomic, readonly) NSString *indexTitle;
                   ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:195:1: note: 'assign' can be unsafe for Objective-C objects; please state explicitly if you need it
 @property(nullable, nonatomic, readonly) NSString *indexTitle;
 ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:203:20: error: unknown property attribute before ',' token
 @property (nullable, nonatomic, readonly) NSArray *objects;
                    ^
main.m:34:25: fatal error: app_defines.h: No such file or directory
compilation terminated.
make[2]: *** [main.o] Error 1
rm: compile_time_code: No such file or directory
rm: app_defines.h: No such file or directory
make[1]: *** [main] Error 1
cp: MLV App: No such file or directory
cp: checkupdate.py: No such file or directory
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg 
Seans-Mac-mini-385:cocoa DeafEyeJedi$

(https://farm5.staticflickr.com/4379/37247218511_1dbb3ede22.jpg) (https://flic.kr/p/YKpJoB)

Will give this another try on the MBP and report back. Also how would we know when BB's work has been implemented (other than relying on this thread) before we try compiling again?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2017, 07:09:16 PM
@Ilia3101: You mentioned that your 5D2 sometimes suffers from bad vertical stripes. Can you upload sample MLV with clearly pronounced vertical stripes? I need it for some testing.

@Danne, @DeafEyeJedi
Meanwhile, for testing you can try to compile QT version for Mac. QT version has all raw fix features implemented in the GUI (thanks to @masc).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 22, 2017, 07:22:46 PM
@Ilia & bouncyball: what would you think about releasing a 0.8? There are many new features and the Windows version also works again (some commits before I tested, hope it works with the latest too).
@DeafEyeJedi: I also implemented some of your ideas: 200%&400% zoom and batch paste.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2017, 07:28:29 PM
Sure 0.8 would be great. What do you think Ilia3101?

@masc: Would be so nice if playback controls had additional 2 buttons next frame and previous frame. What do you think?

Edit: I really dig 200/400 zoom! used it for pixel peeping a lot when testing code :)
Edit2: can you also implement mouse scroll wheel to zoom 100-400?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 22, 2017, 07:29:48 PM
Quote
Meanwhile, for testing you can try to compile QT version for Mac.
Link please. What source exactly are you referring to?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2017, 07:36:53 PM
@Danne: masc actually develops QT vesion on MAC. I think he can answer all your questions.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 22, 2017, 07:42:04 PM
@masc: Would be so nice if playback controls had additional 2 buttons next frame and previous frame. What do you think?
No problem.

Edit2: can you also implement mouse scroll wheel to zoom 100-400?
This will not work, because we already have 2D scrolling for the position in the frame. I am not sure, if it could work with scrolling while holding down a button for example (never tried that).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 22, 2017, 07:45:15 PM
How about implmenting Command + I (Info) to be able to quickly see MLV information promptly without having to manualy scroll our mouse over every time?

@DeafEyeJedi: I also implemented some of your ideas: 200%&400% zoom and batch paste.

Thanks. Will check it out once I get past the compiling issues.

Sure 0.8 would be great. What do you think Ilia3101?

@masc: Would be so nice if playback controls had additional 2 buttons next frame and previous frame. What do you think?

+1

Quote
Edit: I really dig 200/400 zoom! used it for pixel peeping a lot when testing code :)
Edit2: can you also implement mouse scroll wheel to zoom 100-400?

Clever idea with the mouse scroll wheel zoom function. Hopefully this is plausible while in playback mode.  :P Bummer.

Link please. What source exactly are you referring to?

Please let us know when you can @masc
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 22, 2017, 07:56:07 PM
@masc: Would be so nice if playback controls had additional 2 buttons next frame and previous frame. What do you think?
Implemented and working.

How about implmenting Command + I (Info) to be able to quickly see MLV information promptly without having to manualy scroll our mouse over every time?
You can press Command+Shift+I.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 22, 2017, 08:18:58 PM
Hmmm.. weird that it's broken, although it seems you guys might be having different issues... not sure what do to.
Qt version has bb's work implemented in the GUI I think, so you can test if you can compile that, which requires installing Qt creator, and you can follow the 'Linux tutorial' linked in the first post, should be the same on all platforms.

@bouncyball Will find one and upload!

And good idea to release 0.8, as it seems to be quite in demand right now :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 22, 2017, 08:37:09 PM
Ok, I'll try to compile and upload the 0.8 tomorrow.
Edit: found some time, so OSX version is there. @bouncyball: could you please build the windows versions? If not I can do that sunday.
Sources (as always): https://github.com/ilia3101/MLV-App (https://github.com/ilia3101/MLV-App)
Release: https://github.com/ilia3101/MLV-App/releases/tag/QTv0.8alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.8alpha)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 22, 2017, 09:01:55 PM
Next, previous frame buttons are great.

Is it possible to display the frame number, which ist actually shown, maybe in the field of Caching - Playback? That would make a later cutting easier (Implementing some kind of cut-in - cut-out function would be fine too  8) ).

The new correct tab looks great now.

What is the difference between Method 1 and 2 in bad - focus pixel fix?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2017, 09:59:29 PM
@masc

This will not work, because we already have 2D scrolling for the position in the frame. I am not sure, if it could work with scrolling while holding down a button for example (never tried that).
Really? Did not notice this as I'm just dragging zoomed screen by left mouse click and this is very convenient. Could we disable scrolling and use scroll wheel for zooming?

[/quote]
@bouncyball: could you please build the windows versions? If not I can do that sunday.
Sure I'll do it tomorrow.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2017, 10:02:18 PM
@Ilia3101

@bouncyball Will find one and upload!
Thank you would be very nice :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2017, 10:22:45 PM
@escho

What is the difference between Method 1 and 2 in bad - focus pixel fix?
Both averaging neighbor pixels but do it differently. Some footage looks good with 1 other with 2, try it yourself. Method 1 is used in MLVFS, method 2 is used in mlv_dump (raw2dng code) so your mileage may vary. Also when using it with chroma smooth at the same time results could be different, even ugly in some combination ;)

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 22, 2017, 10:26:31 PM
here's something: https://drive.google.com/file/d/0BwvDlbhZgsGGT0xFUl9ERFFialk/view?usp=sharing
Couldn't find any particularly strong examples just now, but this uninspiring clip has some stripes, I don't know if they're string enough for your testing purposes ::)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 23, 2017, 12:08:19 AM
Is it possible to display the frame number, which ist actually shown, maybe in the field of Caching - Playback?

Done in my last commit. The cut-in and cut-out is a good idea, maybe I'll do that in the future, too. Thx.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 23, 2017, 09:27:08 AM
Win x86 32bit version uploaded.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 23, 2017, 09:46:09 AM
I don't know if they're string enough for your testing purposes ::)
They are "OK" on the blue sky :D thank you.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 23, 2017, 09:50:51 AM
@masc

I was testing the scrolling of zoomed image by scroll wheel.

Well, scrolling vertically when you can just drag it in any direction IMHO useless. So if QT mouse input handling will let us free the scroll wheel for other purpose (zooming) would be very cool :)

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on September 23, 2017, 11:01:45 AM
new version of win works great. love those new features...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 23, 2017, 11:31:54 AM
@masc

I was testing the scrolling of zoomed image by scroll wheel.

Well, scrolling vertically when you can just drag it in any direction IMHO useless. So if QT mouse input handling will let us free the scroll wheel for other purpose (zooming) would be very cool :)

regards
bb

I always loved it using the trackpad. Have you tested also scrolling+cmd or strg? This could be the 2nd dimension for mouse users, I don't know. But I can have a look if I can disable that. On the other side I think I have to reimplement the whole zooming, because 3 zoom steps with scrolling makes no sense. I think we need a kind of "step-less" zoom then.

Thanks for the upload!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 23, 2017, 12:11:16 PM
I always loved it using the trackpad.
Hehe :) I didn't think about it. I'm using desktop PC at work most of the time.

On the other side I think I have to reimplement the whole zooming, because 3 zoom steps with scrolling makes no sense. I think we need a kind of "step-less" zoom then.
+1 if that's not very hard to do.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 23, 2017, 02:12:52 PM
The most difficult should be to forbit a scrollarea the scrolling via mouse ;) So I have to overwrite some Qt classes, and atm I don't know how. But I'll do some research...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 23, 2017, 05:39:20 PM
@bouncyball: do you like to test? I think I got it ... after some hours of wondering what Qt can (or can't) do... :o
The behaviour is now:
- "Zoom: fit" can be checked and unchecked. If it is checked, it fits, if not, you are leaded to 100% and can zoom from there as you like
- "Zoom: 100%" returns always to 100%. If it is clicked while "fit" was active, "fit" will be unchecked.
Is that okay? Sometimes I had problems when zooming the very first time: it did not recognize where the curser was and jumped to the upper left corner. But that happend not often. Does it happen for you?
Edit: now I know why it happens, but I don't know how to fix it  ;D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 23, 2017, 07:48:28 PM
@bouncyball

ThankYou for the answer. I will look at the code later to fully understand the difference.

@masc

Display of the frame number works great. ThankYou!

@all

Crash in importing (QTApp on linux). No pngs are created. App crashes.
The crash comes in with commit 82a3a5e (Fixed the very broken sharpening filter). Previous commit works without problem. I tried to import my moon-test-video, containing 21 frames.
Here ist the debug-output of qt-creator:
https://seescho.files.wordpress.com/2017/08/auswahl_004.jpg
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on September 23, 2017, 07:56:08 PM
@BB
after doing some test i found that i can import only 9 clips at once. if i try to import more than 9 mlv files the app crash
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 23, 2017, 07:56:36 PM
Crash in importing (QTApp on linux). No pngs are created. App crashes.
The crash comes in with commit 82a3a5e (Fixed the very broken sharpening filter). Previous commit works without problem. I tried to import my moon-test-video, containing 21 frames.
Here ist the debug-output of qt-creator:
https://seescho.files.wordpress.com/2017/08/auswahl_004.jpg
Jopp, same on OSX. Take the old raw_processing.c (before this commit) and it should work (at least for me it does).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 23, 2017, 07:58:34 PM
@BB
after doing some test i found that i can import only 9 clips at once. if i try to import more than 9 mlv files the app crash

Some more information please. Which version, which OS,... I can import as many clips I want on OSX and MLVAPP [Qt] v0.8 or latest revision.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on September 23, 2017, 08:03:51 PM
Some more information please. Which version, which OS,... I can import as many clips I want on OSX and MLVAPP [Qt] v0.8 or latest revision.

windows v0.8

edit: i can import more than 9 clips. i have 10 clips in a folder. i select all and tried to import but the app crash. if i select only those 9 clips it doesnt crash. now i tried importing one by one and found that the problem is with the last mlv file in my folder. whenver i tried importing that file, this app keep crashing
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 23, 2017, 08:10:18 PM
Jopp, same on OSX. Take the old raw_processing.c (before this commit) and it should work (at least for me it does).
Yes, run with the old one on latest commit.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 24, 2017, 10:05:06 AM

Crash in importing (QTApp on linux). No pngs are created. App crashes.
The crash comes in with commit 82a3a5e (Fixed the very broken sharpening filter). Previous commit works without problem. I tried to import my moon-test-video, containing 21 frames.
Here ist the debug-output of qt-creator:
https://seescho.files.wordpress.com/2017/08/auswahl_004.jpg

The crash is fixed with commit c25b987. ThankYou!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 10:43:25 AM
Hey Guys I found so many cool commits today! Hahaha! :)

@ilia3101:
Sharpening is fantastic! is that algo "unsharp musk"? Works very intelligently for my taste. Slows playback for ~50% but is worth it :). Now we're just missing good denoiser :P

@masc:
Zoom also fantastic! Works smoothly and I did not experienced the behavior you mentioned yet.
I've got one proposition though: the right click menu is very good for switching zoom and zebras, but it would be very nice to switch between zoom and fit also with just a left click of a mouse or maybe better double click. What do you think?

Edit: Surely double click. My bad, just a left click is busy with drag mode.

br
bb

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 24, 2017, 10:53:42 AM
I'm glad the commit fixed crashing! To be honest I never pinned down the bug, just rewrote the bit that crashed.

@bouncyball Yep, it is something like unsharp mask with a really small radius. Even simpler though... Goes something like: multiply main pixel by something, and reduce it back to normal by slightly subtracting some of the ones around it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 10:59:32 AM
@Ilia3101: Well... I really like it very much :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 02:39:03 PM
@masc:
I've got one proposition though: the right click menu is very good for switching zoom and zebras, but it would be very nice to switch between zoom and fit also with just a left click of a mouse or maybe better double click. What do you think?

Edit: Surely double click. My bad, just a left click is busy with drag mode.
Both makes problems with Touchpad, because DoubleClick is used by tapping to select the drag mode and Click is used normaly to drag.
What I can offer... and I already pushed the commit because it was easy... I added the shortcut "F" (Fit) to toggle between Fit and Scaling mode. Hope it is cool enough  ;D
And by using F you will never see this bug.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 05:54:16 PM
Great! "F" is perfect :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 06:07:43 PM
Windows x64 version (https://github.com/ilia3101/MLV-App/releases/download/QTv0.8alpha/MLV.App.v0.8.alpha.x64.Win.static.zip) uploaded to github ( release v0.8 )

Windows x86:
    includes all dynamic QT libraries

Windows x64:
    this mlvapp.exe release is one static binary
    focus pixel maps are included (EOSM, 700D, 100D)

both Windows releases include ffmpeg.exe
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 06:13:00 PM
@bouncyball: thanks for building the versions! How do you include the focus pixel maps? Is this only in this version? Can we add that also for the other versions?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 06:20:09 PM
Sure we can :) my bad I forgot to include it to the x86 version. Focus maps should be in the same dir with binary. You can quickly generate them with my utility called fpmutil (https://bitbucket.org/bouncyball/mlv-tools/downloads/).

BTW this windows static binary (just one mlvapp.exe) I compiled under Linux :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 06:31:35 PM
Just generate and copy to the directory works? On OSX too?  Can we add the generated files to the repos?

Edit: on OSX that does not work... :(

Do you have Qt in Wine?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 06:40:21 PM
What do you mean it does not work? Of course it will work anywhere. Binary searches maps in the same dir it resides. Just copy maps from x64 release zip to the dir in your MAC with mlv app.

Edit: Do you have MLV from focus dot affected cameras?
Edit2: on the bottom of this post (http://www.magiclantern.fm/forum/index.php?topic=20025.msg190039#msg190039) there is a link with sample MLVs
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 06:44:02 PM
Yes, that was what I did. I tried inside the package and outside the package...
I have a file from a 100D with lots of focus pixels.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 06:45:32 PM
Hmm... very strange. It works on Linux and on Windows. What is wrong with mac? :)

I don't use wine, I have dual boot on my PC - Linux Ubuntu / Windows 10
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 06:54:37 PM
Just a hint - take a look at the DMG structure of the Mac version of MLVFS, it can use exact same maps.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 07:34:04 PM
I tested it on Windows. My 100D file has focus pixels, I can remove them. But on Windows it only works if I open MLV App itself. If I call it though QtCreator it does not work. Is it possible to set the directory anywhere in the code (or at least printf the path)? I am doing the same as MLVFS (I think... - I found them...).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 07:49:41 PM
Is it possible to set the directory anywhere in the code (or at least printf the path)?
Path not changeable at the moment. What the console output says on mac when "Using focus pixel map: 'path/id_xres_yres.fpm' " is displayed?

Edit: fopen is done with file name without the path hence the dir always currentt dir.
Edit2: does ffmped calling work though QtCreator run?
Edit3: MLVFS also searches all its additional files in the current dir, so you absolutly need to cd to the MLVFS folder
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 08:03:00 PM
Path not changeable at the moment. What the console output says on mac when "Using focus pixel map: 'path/id_xres_yres.fpm' " is displayed?

Edit: fopen is done with file name without the path hence the dir always currentt dir.
Edit2: does ffmped calling work though QtCreator run?

ffmpeg runs also through QtCreator. In exactly the same folder I copied the fpm files. In the console there is nothing with focus pixels... all the other corrections write an output... strange...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 08:06:02 PM
In the console there is nothing with focus pixels...
This means the maps are not found. I need to look at how you are calling ffmpeg. Specifying the dir can be implemented anyway.

Edit: In debugger you can watch the fpm_status variable. If it stays 0 or equals to 2 maps are not found.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 08:08:51 PM
WAIT! If I have the files next to the ffmpeg and start MLV App through QtCreator it works! Starting MLV App by doubleclicking it does not work. (Exactly the opposit from Windows)
Edit: it would be interesting to see where the app is searching.
Edit2: QDir::currentPath() and QCoreApplication::applicationDirPath(), both bring the folder where the fpm files are. :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 08:57:27 PM
This opposite behavior on osx and win is very strange.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 10:58:27 PM
Doubleclicking the App on OSX sets "/" as working directory for the C code part. :(
For the Qt part, the working dir is the path of the executable inside the app package.
If I copy the files in "/" it works.
@bouncyball: Any suggestion? Is it possible to implement a bypass to set the directory in the correction module?

Edit: I did a call in the Qt part:
Code: [Select]
chdir( QCoreApplication::applicationDirPath().toLatin1().data() );First test on OSX: works! :-)
Edit: Second test on Windows: works too! ;D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 24, 2017, 11:25:31 PM
Haven't followed the discussion much so not 100% sure whats going on :(
Does the app need to contain focus pixel maps or something for the llrawprocobject to remove focus pixels?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 25, 2017, 08:53:08 AM
Haven't followed the discussion much so not 100% sure whats going on :(
Does the app need to contain focus pixel maps or something for the llrawprocobject to remove focus pixels?
Yes. And they must be located in the working dir. Maybe you have to set the working dir in the C code (at least in Qt I had to do that, otherwise it was at "/"). But you could do that from the cocoa classes using chdir().
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 09:16:35 AM
@bouncyball: Any suggestion? Is it possible to implement a bypass to set the directory in the correction module?
If you think this is the more correct approach we can pass the map directory as a parameter.

I got another idea. I'm gonna implement the on the fly pixel map generation code right into mlvapp, but there'll be possibility to override this behavior by manually placing the map to the working dir as now. What do you think about placing as few files in working DIR as possible without sacrificing functionality? ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 25, 2017, 09:20:54 AM
fpmutil code pure joy(fpm.sh on steroids ;)).
http://www.magiclantern.fm/forum/index.php?topic=15108.msg187641#msg187641
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 09:22:36 AM
Yes it's very fast, faster then searching bad pixels.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 09:29:53 AM
@Ilia3101, @masc

I had a linking problem caused by "MLV App" space in the middle of TARGET name.
Can we rename the app binary to "MLVApp" of maybe just to plain "mlvapp"?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 25, 2017, 09:31:55 AM
If you think this is the more correct approach we can pass the map directory as a parameter.
Yes! Yes! Yes!
I was just looking at the code, seeing how I could do that.
As the Cocoa API allows getting the path to the app bundle's resources directory, where they would be stored.
(It would be perfect!)

Seems like a directory path argument would need to be added to load_pixel_map (of course do it how you feel is right):
Code: [Select]
static int load_pixel_map(pixel_map * map, char * path, uint32_t camera_id, int raw_width, int raw_height, int dual_iso)And have a parameter for it inside of llrawprocobject which it will pass to that(Is that how it works?)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 25, 2017, 09:34:07 AM
I had a linking problem caused by "MLV App" space in the middle of TARGET name.
Can we rename the app binary to "MLVApp" of maybe just to plain "mlvapp"?
Yea sure, why not rename the binary. On macOS this wouldn't even matter as the app bundle and binary can have any names at all.
Or maybe just rename it on Linux if that's the only place where it's causing problems?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 25, 2017, 10:56:14 AM
@Ilia3101, @masc
I had a linking problem caused by "MLV App" space in the middle of TARGET name.
Can we rename the app binary to "MLVApp" of maybe just to plain "mlvapp"?

We can rename it. Where do you have that problem? On Linux? On Win & OSX I never had a problem with that. Maybe change the .pro to that:
Code: [Select]
win32: TARGET = "MLV App"
linux-g++*: TARGET = "MLVApp"
osx: TARGET = "MLV App"
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 11:58:58 AM
This was the error:
Code: [Select]
/usr/bin/x86_64-w64-mingw32.static-ld: cannot find ./release/mlv
/usr/bin/x86_64-w64-mingw32.static-ld: cannot find app_plugin_import.o
"mlv app_plugin_import.o" divided to "mlv" and remainder.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 12:02:54 PM
I thought about adding parameter "path" to related functions and can admit that this complicates things quite a bit and makes ugly, can we just use some global variable with working dir set?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 12:07:39 PM
This:
Code: [Select]
win32: TARGET = "MLVApp"
linux-g++*: TARGET = "mlvapp"
osx: TARGET = "MLV App"
did the trick.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 25, 2017, 03:45:47 PM
Linux compile howto & 64bit build

sudo apt-get install libpng16-dev qtmultimedia5-dev qt5-qmake qtbase5-dev

ubuntu 16.04 with kubuntu backports ppa activated, so qt 5.6.1


I had to change line 22 of MainWindow.cpp to

#include <libpng16/png.h>

and line 55 of MLVApp.pro to
linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng16

then the ususal
Code: [Select]
qt5-qmake MLVApp.pro
Code: [Select]
make
MLVApp + static FFMpeg, 64bit (http://openartisthq.org/magiclantern/mlvapp.tar.xz)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 04:06:58 PM
Thank you, but it's gonna make more sense if you make the binary static.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 25, 2017, 04:11:24 PM
To not change MainWindow.cpp (OSX and Win port would be broken) you also could change line 56 in the .pro to:
Code: [Select]
linux-g++*: INCLUDEPATH += /usr/local/include/libpng16/
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 25, 2017, 05:05:19 PM

Quote
Thank you, but it's gonna make more sense if you make the binary static.

show me how.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 25, 2017, 06:06:34 PM
Linux compile howto & 64bit build

sudo apt-get install libpng16-dev qtmultimedia5-dev qt5-qmake qtbase5-dev

ubuntu 16.04 with kubuntu backports ppa activated, so qt 5.6.1


I had to change line 22 of MainWindow.cpp to

#include <libpng16/png.h>

and line 55 of MLVApp.pro to
linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng16

then the ususal
Code: [Select]
qt5-qmake MLVApp.pro
Code: [Select]
make
MLVApp + static FFMpeg, 64bit (http://openartisthq.org/magiclantern/mlvapp.tar.xz)

On my system ( Linux opensuse leap ) I don´t have to change MainWindow.cpp and MLVApp.pro to get MLV App compiled. Just the syntax is a bit different:

Code: [Select]
qmake-qt5
make

I need no static ffmpeg. I use the ffmpeg, installed with Yast. MLV App find the ffmpeg-bin via the PATH-envirement-variabe of my system.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 25, 2017, 06:09:20 PM
Yes! Yes! Yes!
I was just looking at the code, seeing how I could do that.
As the Cocoa API allows getting the path to the app bundle's resources directory, where they would be stored.
(It would be perfect!)

But would it be a problem to copy it to the resources directory and setting chdir to it? So (nearly) nothing has to be changed.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 25, 2017, 07:15:18 PM
But would it be a problem to copy it to the resources directory and setting chdir to it? So (nearly) nothing has to be changed.
I guess I could easily do that and it's completely fine.
But it's app-global, so if ever another library gets introduced to the app that also happens to depend on being in a certain directory(which of course shouldn't happen), it will become an issue.
Maybe I'm being paranoid, but isn't it good practice to keep as much local as possible?

I'll do that for now anyway as it seems like it won't break anything :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 25, 2017, 07:32:23 PM
This:
Code: [Select]
win32: TARGET = "MLVApp"
linux-g++*: TARGET = "mlvapp"
osx: TARGET = "MLV App"
did the trick.

Is it necessary to have three different targets for the three OS? Why not one Target MLVApp for all?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 07:34:43 PM
@revast
show me how.
Good question ;) (I hoped you know how to do it without me)

Well... In the best case you have to compile all QT libs as static and link all s**t together including zlib, libpng16 and pthread. I'm doing this with Mingw64 (under linux) to compile static windows binary. But I never did that with GCC. That is why we never released binary for Linux version of the MLV App.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 07:40:35 PM
@escho
Is it necessary to have three different targets for the three OS? Why not one Target MLVApp for all?
Yeah... right.

Quite funny but, I changed win32 TARGET because I had a linking problem, changed linux TARGET because I'm tired of typing upper-lower case binary name :P and leaved unchanged macx TARGET with respect to Author.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 07:50:17 PM
Hey @masc I have an issue with QT designer. To the focus pixel combo box I added additional 3rd item, but this item, strangely, never shows up in compiled version despite the fact that the related part of MainWindow.ui looks like this:
Code: [Select]
<widget class="QComboBox" name="comboBoxFocusPixelSwitch">
               <property name="maximumSize">
                <size>
                 <width>90</width>
                 <height>16777215</height>
                </size>
               </property>
               <property name="font">
                <font>
                 <pointsize>10</pointsize>
                </font>
               </property>
               <item>
                <property name="text">
                 <string>Off</string>
                </property>
               </item>
               <item>
                <property name="text">
                 <string>On</string>
                </property>
               </item>
               <item>
                <property name="text">
                 <string>Croprec</string>
                </property>
               </item>
              </widget>
Can you enlighten me what am I doing wrong?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 25, 2017, 09:52:12 PM
@bouncyball: whooaaa... sry, I never work with the ui code. I just paint the GUI in the QtCreator-Designer-Plugin and I am happy when it does what I want. So you want a third switch: Off, On, CropRec? Where is the difference between On and CropRec? CropRec is =2 in your lib and works with the same functions? I can do it for you...

Edit: Done.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 26, 2017, 09:12:42 AM
@masc:

I did it exactly from designer plugin. Now I pulled your changes and the item is not showing again hahaha :). Some black magic I guess. Then I deleted all and cloned the fresh repository. Compiled and Croprec is there ;). Well I guess when I'm doing qmake from Mingw64 it creates a lot of files in addition to Makefile and maybe somewhere it caches the ui.

Anyway thank you for helping! I'm gonna push my changes as soon as they are stable :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 26, 2017, 12:46:39 PM
I have now made an AppImage (http://openartist.org/magiclantern/MLVApp-x86_64.AppImage).
Just download, make executeable, launch.

Turned out to be quite easy, thanks to linuxdeployqt (https://github.com/probonopd/linuxdeployqt/releases/download/continuous/linuxdeployqt-continuous-x86_64.AppImage)
Code: [Select]
./linuxdeployqt  m/MLVApp -appimage -bundle-non-qt-libs -verbose=2where in folder m is the a MLVApp.png, a static FFMpeg executeable, the MLVApp executeable,  as well as a MLVApp.desktop file with 

Code: [Select]
[Desktop Entry]
Type=Application
Name=MLVApp
Exec=MLVApp
Icon=MLVApp

To see how it looks like inside, use: ./MLVApp-x86_64.AppImage --appimage-extract

What it actually does is to grab all libs which are needed to run the executeable, and deploys that in a compressed package which is built like an ISO file - you can even mount it - which is also executeable via fuse.
The wiki (https://github.com/AppImage/AppImageKit/wiki) has more info, the one thing that has to be considered for a release package is that the older the platform where the appimage was made, the better in terms of compatibility to different linux distributions.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 26, 2017, 01:01:41 PM
@revast

Very cool it's like make portable application under win. Runs fast!
Just one note: it's almost 2 times bigger (~43mb) then it would be as statically linked binary (~24mb).
But anyway I think in this form it could be released as Linux version.

Thank you for your time :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 26, 2017, 02:47:03 PM
Quote
Just one note: it's almost 2 times bigger (~43mb) then it would be as statically linked binary (~24mb).
Thats because its bundled with ffmpeg static binary, which is about 14mb with upx compression applied, without it, the AppImage would have around 30mb.

Quote
But anyway I think in this form it could be released as Linux version.

Yeah, I think so, too :). Using an older base system (like ubuntu 12.04, depends on the minimum qt5 version I guess) to compile MLVApp and make the AppImage would be better though.

I now uploaded another version which should respect the theming of the Linux Distribution the AppImage is run on
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 26, 2017, 06:58:36 PM
I have now made an AppImage (http://openartist.org/magiclantern/MLVApp-x86_64.AppImage).
Just download, make executeable, launch.

Turned out to be quite easy, thanks to linuxdeployqt (https://github.com/probonopd/linuxdeployqt/releases/download/continuous/linuxdeployqt-continuous-x86_64.AppImage)
Very cool! That is exactly the same way I go on OSX, here it's called macdeployqt. Can you please build this this version (https://github.com/ilia3101/MLV-App/commit/56c8511739d3e5dda1fc01d2d2e0e9c2a7bb31ea)? Then I could add it to the latest release page.

In the latest commit I added some lines to the .pro, now you can (manually) switch between ubuntu and opensuse.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 26, 2017, 08:31:49 PM

Code: [Select]
Can you please build this this version? Then I could add it to the latest release pageok, done :). But bear in mind: the older the libc version is the more compatible the package. The appimage creator uses centos 6 for example...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 26, 2017, 10:36:18 PM
Yes, that's the same on OSX. I always build it on 10.9.5.
The link is the same as above? I'll load it on github. Thank you!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on September 26, 2017, 11:46:54 PM
Tried out Linux build, on a Qt-virgin Ubuntu system, got this error:

(http://image.ibb.co/kgzOR5/Screenshot_from_2017_09_26_22_42_23.png)

Does all of Qt need to be installed? Or could it be packaged with the downlad?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 27, 2017, 12:39:22 AM
hmmm all dependencies should be bundled in the one file, yes.
Sorry, I haven't tried it out on vanilla ubuntu till now. I am downloading a xubuntu 17.10 daily image and try for myself

all I can say right now is that that library definitely is inside the .AppImage, I checked that.

try this (http://openartist.org/magiclantern/MLVApp-x86_64.AppImage) version

if that does not help, 
Code: [Select]
sudo apt-get install libqt5multimedia5 for now..
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 27, 2017, 07:10:36 AM
If linuxdeploayqt does the same as macdeployqt I think I know what you did and how you could solve that. If you do that it won't work:
compile, linuxdeployqt, compile, (linuxdeployqt, ) upload
because the compiling breaks the dependencies.

If you do:
delete binary/package, compile, linuxdeployqt, upload
there should be no problem.

This was the problem I had in the very beginning here.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 27, 2017, 07:40:31 AM
I figured it out, looks like linuxdeployqt did not set the paths right,
there is a line:
Code: [Select]
prefix=./in qt.conf, which should point to the prefix dir (usr..) of the appimage. But that does not work, even if my lib folder is in APPimageDIR/usr/

Nevertheless, that is easily fixed with a little script which replaces the default AppRun symlink :

Code: [Select]
#! /bin/bash
export APPDIR="$(dirname "$(readlink -f "$0")")"  #get the path inside the appimage
export LD_LIBRARY_PATH=lib:LD_LIBRARY_PATH #set libray path
export QT_PLUGIN_PATH=plugins:QT_PLUGIN_PATH #setting this explicitly as well, just for safety
export QT_QPA_PLATFORMTHEME="fusion"  #set theme path (does not work so far)

cd $APPDIR
./MLVApp -style=fusion
   

As you can see, the fix I had in mind regarding the theme issues did not work out so well so far.
I explicitly set the style to the built-in fusion style for now, via the -style=fusion argument and will figure out the theme details later.

At least the appimage  (http://openartisthq.org/magiclantern/MLVApp-x86_64.AppImage) works now..
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 27, 2017, 12:04:18 PM
Maybe you don't need the theme fix in the latest revision. Yesterday I added a theme switch. Now you can select a darksytle - this one has Fusion as base. I'll exchange the package this afternoon.

Edit: Done.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 27, 2017, 07:09:01 PM
i like the darkstyle, but the playback buttons are a bit difficult to recognize.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 27, 2017, 07:21:05 PM
i like the darkstyle, but the playback buttons are a bit difficult to recognize.
+1 :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 27, 2017, 07:27:21 PM
Hey guys!

Some changes to the raw correction part:

Now focus pixel maps not needed in the working directory any more. MLV App will generate maps according to MLV metadata on the fly, including crop_rec mode MLVs (EOSM, 100D, 700D, 650D). If .fpm map intentionally placed to the working directory it will be used instead of internal generator (overriding possibility).

Fix focus dots combo box now has 3rd option, CropRec, which turns on the map generator for raw videos recorded with crop_rec module.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 27, 2017, 08:00:50 PM
I'm literally lost in this puddle of mud. For good reasons though. Am I still to be testing with the latest 0.8 version or is there later revision?  :P

Anyway here's what I came across when using SL1 RAW footage (that has Focus Pixels) which was shot in crop_rec and noticed few strange things in case you guys haven't already?

When selecting Fix Focus Dots option to ON while having Chroma Smoothing off then shows the focus pixels. But with FFD ON while having CS_2x2 ON then cleans up nicely except for the border lines if you look closely.

However, even more strange was the fact when I deselect the FFD to OFF while having just CS_2x2 ON still keeps the image clean from showing Focus Pixels? Will test more thoroughly on this with varieties of files later.




I remember this very similar matter when testing out Focus Pixels back in the day w @dfort & @Danne. Fond memories!   :D

Some changes to the raw correction part:

Now focus pixel maps not needed in the working directory any more. MLV App will generate maps according to MLV metadata on the fly, including crop_rec mode MLVs (EOSM, 100D, 700D, 650D). If .fpm map intentionally placed to the working directory it will be used instead of internal generator (overriding possibility).

Fix focus dots combo box now has 3rd option, CropRec, which turns on the map generator for raw videos recorded with crop_rec module.

This is really nice actually. Keep on rockin' BB McFly!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 27, 2017, 08:39:44 PM
@DeafEyeJedi: The focus pixel maps were missing in the v0.8 OSX, and there was still a little bug. So that does not work correctly there for OSX... There are newer working revisions on the repos (->with focus pixels working), but not as release yet.

i like the darkstyle, but the playback buttons are a bit difficult to recognize.
Yes, that is correct. So I created some new ones today. They are on github now. Hope you like them.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 27, 2017, 08:47:05 PM
I created some new ones today. They are on github now. Hope you like them.
Look nice  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 27, 2017, 09:17:56 PM
@DeafEyeJedi: yeah @masc is right. There where no focus maps supplied in this release. That is why cs2x2 gets rid of the most dots except border ones :). It will not be case in the later updated version because map will be generated on the fly.

@masc: loved new look and buttons! :D

Edit: loop button is a bit vague.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 27, 2017, 09:40:27 PM
Edit: loop button is a bit vague.
Yepp. New try.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 27, 2017, 10:10:12 PM
@revast

Could you please change the .pro file like this (Should be lines 55 ff)

Code: [Select]
#Linux (opensuse)
#linux-g++*: INCLUDEPATH += /usr/local/include/
#linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng
#Linux (Ubuntu)
#linux-g++*: INCLUDEPATH += /usr/local/include/libpng16/
linux-g++*: LIBS += -lz -lpng16

and try to compile using

Code: [Select]
make clean
qt5-qmake MLVApp.pro
make

I would like to know, whether this works on your ubuntu.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 28, 2017, 10:12:39 AM
New icons are good! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 28, 2017, 11:12:05 PM
Quote
Could you please change the .pro file like this

Yeah, works.
except the fact its qmake-qt5 on ubuntu :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 29, 2017, 08:06:26 PM
@escho & @revast: did I understand right that I can change
Code: [Select]
#Linux (opensuse)
#linux-g++*: INCLUDEPATH += /usr/local/include/
#linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng
#Linux (Ubuntu)
#linux-g++*: INCLUDEPATH += /usr/local/include/libpng16/
linux-g++*: LIBS += -lz -lpng16
to
Code: [Select]
#Linux
linux-g++*: LIBS += -lz -lpng16
?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 29, 2017, 08:35:20 PM
@masc
I guess, most of the linux-distros should compile out of the box with this change
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 29, 2017, 09:32:44 PM
Ok, thx. Commited.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: erikbaldwinson on September 29, 2017, 09:47:40 PM
Cool program! Thank you for sharing.

Is there a solution for adding the H264 audio to the final proress export in windows using this program?

Cheers
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 29, 2017, 10:39:53 PM
Thx. H264 audio? You record H264 and mlv at the same time and now you like to add the audio track from the H264 to the output of MLV App? Is that right? Hmmm...  I never thought about that, but for now we do not decode H264 files, just MLV.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 29, 2017, 10:53:55 PM
I do this in Switch. Need to cut off black frames in the beginning of the file and then match the file with frame amount of the mlv file. Works with ffmpeg.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: erikbaldwinson on September 29, 2017, 11:10:33 PM
Thx. H264 audio? You record H264 and mlv at the same time and now you like to add the audio track from the H264 to the output of MLV App? Is that right? Hmmm...  I never thought about that, but for now we do not decode H264 files, just MLV.

Yes that's correct. I'm on windows and there does not seem to be an easy way to do this. The way I have been doing it is manually clip by clip in Resolve.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on September 30, 2017, 11:52:09 PM
I am awfully sorry to report that v.08 does not work on either of my Win7x64 PCs.  This time, it crashes when I try to import a MLV file.  Is anybody else experiencing this?  Is there anything I could do?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 01, 2017, 09:22:38 AM
Don't be sorry ;) just tell us which version crashes - 32bit or 64bit?

Also provide additional details about MLV(s) which crashes program and upload it somewhere.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 01, 2017, 10:56:31 AM
I am awfully sorry to report that v.08 does not work on either of my Win7x64 PCs.  This time, it crashes when I try to import a MLV file.  Is anybody else experiencing this?  Is there anything I could do?
Hm... we have so many Windows PCs where it does not crash and for you it does crash on every PC. Very strange. I could imagine that it could be an localization problem. Could you please tell us your Windows country (& maybe language) settings? I could simulate this on my computers... maybe I have luck and it does crash for me too  :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on October 01, 2017, 11:07:54 AM
i can import some files but it crash while trying to import some other  MLV files. im on win7 X64
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on October 01, 2017, 02:46:46 PM
Don't be sorry ;) just tell us which version crashes - 32bit or 64bit?

Also provide additional details about MLV(s) which crashes program and upload it somewhere.

I tried both - the 64 and the 32 bit versions.  They both crash when I try to import a 10-bit MLV file (2496x1080) with sound from the 100D.  Later on I can upload a short file for you.

Hm... we have so many Windows PCs where it does not crash and for you it does crash on every PC. Very strange. I could imagine that it could be an localization problem. Could you please tell us your Windows country (& maybe language) settings? I could simulate this on my computers... maybe I have luck and it does crash for me too  :P


I am in Bulgaria and my regional and language settings are:

Location: Bulgaria
Format: English (United States)
Current System Locale: Bulgarian (Bulgaria)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 01, 2017, 05:35:11 PM
i updated my tutorial for compiling MLV App under Linux openSUSE Leap 42.3. And I translated the whole stuff into english:
https://seescho.wordpress.com/fotos/ml/
Hope, it will be useful
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 01, 2017, 06:27:03 PM
@IDA_ML: ok, please upload sample.

@escho: sadly it's only german :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 01, 2017, 06:29:25 PM

@escho: sadly it's only german :)

contains english translation, too :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on October 01, 2017, 07:16:29 PM
@IDA_ML: ok, please upload sample.

Here we go:

https://we.tl/2TlV9r9I3u

A 2.5K 10-bit MLV file with sound (270 MB).  The above link will be active for 7 days.  Hope this helps and if yes, I will be looking forward to test MLVApp.  Thanks. 
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on October 01, 2017, 07:54:41 PM

(http://thumb.ibb.co/bZWELb/Capture.png) (http://ibb.co/bZWELb)

upload photograph (http://imgbb.com/)
Here we go:

https://we.tl/2TlV9r9I3u

A 2.5K 10-bit MLV file with sound (270 MB).  The above link will be active for 7 days.  Hope this helps and if yes, I will be looking forward to test MLVApp.  Thanks.

i can import your mlv file. i have some files from 70D which keep crashing while importing and i can't share those files as they are very large. i tried shortening but it works if i shorten those files
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: smasry on October 01, 2017, 08:09:11 PM
Hi guys,

I don't understand it, but I can't 'make' the app. I'm on Sierra 10.12.6, but what's strange is that I've compiled it successfully on another Sierra, with no problems.

The error I'm getting is:

Code: [Select]
$ make app

Code: [Select]
...
Initial app name: MLV App (Oct  1 2017 18:55:55 @cabian.local)
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c main.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/llrawproc.c
../../src/mlv/llrawproc/llrawproc.c:70:16: error: no member named 'raw2evf' in
      'llrawprocObject_t'; did you mean 'raw2ev'?
    llrawproc->raw2evf = NULL;
               ^~~~~~~
               raw2ev
../../src/mlv/llrawproc/../llrawproc/llrawproc_object.h:55:11: note: 'raw2ev'
      declared here
    int * raw2ev;
          ^
1 error generated.
make[2]: *** [llrawproc.o] Error 1
cp: MLV App: No such file or directory
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg 

The only thing I can think of to explain this discrepancy is that one or more dependencies may be missing, but I can't find any mention of any hard (macOS) dependencies either in your repository nor in this thread.

Any idea what I'm doing wrong/missing?

Thanks
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 01, 2017, 08:42:28 PM
Same error here on Linux. Looks like the declaration of raw2evf is missing in llrawproc_object.h
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 01, 2017, 09:53:16 PM
Please try one revision earlier. It seems as the second last commit of bouncyball does not compile. Before that it was working.
https://github.com/ilia3101/MLV-App/commit/1188472ee5eac5f65dc3a8454499b9bd7f36920e (https://github.com/ilia3101/MLV-App/commit/1188472ee5eac5f65dc3a8454499b9bd7f36920e)
This one can be compiled.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 01, 2017, 10:03:44 PM
Guys sorry about that, just delete the line to which error's referring. I forgot to delete it after some experimenting. This commit has working full20bit mean32 interpolation mode dual iso processing. Amaze interpolation is not there yet. Will finish it tomorrow I think and gonna add some more widgets to the gui.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 01, 2017, 10:12:44 PM
@IDA_ML: Thanks for your upload and your information. I set the programs "QLocale" to Bulgaria and English, but I can load your file without problem. I really have no idea where to search :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on October 01, 2017, 10:44:49 PM
Masc,

At work we have a PC with Win XPx32.  Does it make sense to try the 32-bit version on it?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: smasry on October 02, 2017, 09:49:56 AM
Quote
Please try one revision earlier. It seems as the second last commit of bouncyball does not compile. Before that it was working.
https://github.com/ilia3101/MLV-App/commit/1188472ee5eac5f65dc3a8454499b9bd7f36920e
This one can be compiled.

I reverted the checked-out repository to revision 1188472ee5eac5f65dc3a8454499b9bd7f36920e, as well as (separately) deleting the line in the .c file as bouncy ball asks here:

Guys sorry about that, just delete the line to which error's referring. I forgot to delete it after some experimenting. This commit has working full20bit mean32 interpolation mode dual iso processing. Amaze interpolation is not there yet. Will finish it tomorrow I think and gonna add some more widgets to the gui.

Now I get this error:

Code: [Select]
...
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o llrawproc.o pixelproc.o stripes.o patternnoise.o hist.o -o "MLV App" -framework Cocoa;
Undefined symbols for architecture x86_64:
  "_diso_get_preview", referenced from:
      _applyLLRawProcObject in llrawproc.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [build] Error 1
cp: MLV App: No such file or directory
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on October 02, 2017, 10:01:10 AM
Strange, I'll see what's happened when I try to build mlv app on my Mac later.
It does still look like bouncyball's stuff isn't compiling for you :(

@IDA_ML please do try, although I'm not 100% certain XP will even support the binary :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 02, 2017, 11:01:13 AM
I fixed the error. Delete repository then clone the fresh copy of it and try to compile again.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 02, 2017, 11:56:55 AM
@Ilia3101: Hi man :) it seems you are very busy these days.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: smasry on October 02, 2017, 01:20:40 PM
Hi @bouncyball,

I fixed the error. Delete repository then clone the fresh copy of it and try to compile again.

I did this, but sorry to report, it seems to produce the same error.

Code: [Select]
...
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o llrawproc.o pixelproc.o stripes.o patternnoise.o hist.o -o "MLV App" -framework Cocoa;
Undefined symbols for architecture x86_64:
  "_diso_get_full20bit", referenced from:
      _applyLLRawProcObject in llrawproc.o
  "_diso_get_preview", referenced from:
      _applyLLRawProcObject in llrawproc.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [build] Error 1
cp: MLV App: No such file or directory
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg 
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: smasry on October 02, 2017, 01:51:05 PM
@bouncyball:

Can I run 'make app' with more verbosity, or with command line arguments to produce output more useful to aid debugging?

Don't stress because of this error, I have a working MLV App on another computer, and am happy using mlv_dump in the meantime.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 02, 2017, 01:54:12 PM
The error happens because you try to compile the cocoa app. The newest stuff is only working in the Qt version, until Ilia makes some changes to the cocoa makefile. The new implemented files should be added there I think.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on October 02, 2017, 03:36:50 PM
Ilia3101,

I tried MLVApp (x86) v.08 on a WinXP x32 machine but it will not even start.  Here is what I get:


(https://thumb.ibb.co/mpK2Qb/MLVApp_entry_point.png) (https://ibb.co/mpK2Qb)


No luck for me with MLVApp.  Will have to stick with other methods.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: smasry on October 02, 2017, 04:38:35 PM
Thanks @masc!

The error happens because you try to compile the cocoa app. The newest stuff is only working in the Qt version, until Ilia makes some changes to the cocoa makefile. The new implemented files should be added there I think.

I guess I rushed ahead of myself, into the 'bleeding edge' even before the documentation has been updated.

Instead, I downloaded release 7b63, and will make do.

I'd still like to test the app, as you develop it, and didn't find macOS (instead of Linux) instructions for building from '/qt' instead of '/cocoa'. When you have a minute, would you mind updating the README with the necessary dependencies, and build instructions?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 02, 2017, 05:01:16 PM
@smasry: Compiling on OSX:
-unzip ffmpeg in its folder.
-compile and install libpng (is also in the repos) as described in its readme.
-load the .pro in QtCreator
-unchecking Add build library search path to DYLD_LIBRARY_PATH and DYLD_FRAMEWORK_PATH checkbox in my project Run section
-press the "Play" Icon and have fun.
Hope I did not forget anything...
It runs nearly out of the box, so I was to lazy to write a readme... sry ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 02, 2017, 05:04:29 PM
Ilia3101,

I tried MLVApp (x86) v.08 on a WinXP x32 machine but it will not even start.  Here is what I get:


(https://thumb.ibb.co/mpK2Qb/MLVApp_entry_point.png) (https://ibb.co/mpK2Qb)


No luck for me with MLVApp.  Will have to stick with other methods.
What a shame... I first thought with this error message I can search... but it will only tell us MinGw (our Windows compiler) is not supported on WinXP :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: canneloni on October 02, 2017, 05:53:29 PM
Would anybody care to explain how i can compile the qt version on Windows using Linux subsytem? I'm fairly new at this and only followed the instruction to compile ML which was great and worked well. I already cloned git repository on my disk but was unable to use make in qt folder since there is no make file (i guess).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 02, 2017, 06:01:03 PM
I already cloned git repository on my disk but was unable to use make in qt folder since there is no make file (i guess).
I don't know how to compile the exe from Linux. But qmake creates automatically the makefile for a Qt project (.pro file).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on October 02, 2017, 08:33:45 PM
Cocoa app compiling is fixed (https://github.com/ilia3101/MLV-App/commit/f0db1830b68baa5b36d597d86b92e4fe383e7b1f), no GUI access to bouncyball's features though - yet

@bouncyball I'm not that busy, but more than before, I am still working on things (caching, GUI for LLRawProc etc... sessions is going slower). I haven't given up or abandoned it ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 02, 2017, 08:40:57 PM
Great to hear @Ilia3101!  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 02, 2017, 09:06:15 PM
@Ilia3101

I haven't given up or abandoned it ;)
Cool to know!!! :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: canneloni on October 03, 2017, 09:31:27 AM
I don't know how to compile the exe from Linux. But qmake creates automatically the makefile for a Qt project (.pro file).

Okay let me rephrase. Whats the best way to compile this for Windows ? The Git page only shows how to do it for cocoa and mac.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 03, 2017, 09:45:47 AM
Okay let me rephrase. Whats the best way to compile this for Windows ? The Git page only shows how to do it for cocoa and mac.
To compile static x64 Windows binary on Linux I'm using MXE (http://mxe.cc). There is all information how to set it up. Also take a look at this (https://askubuntu.com/questions/656219/building-a-windows-executable-in-qt-on-a-linux-system) thread.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 03, 2017, 10:17:28 AM
Maybe you know, that I have problems, importing files bigger than 4 Gbyte. The app crashes. These files are way to big for uploading somewhere.

So I startet QT Creator in debugging mode with a file with 7,6 GByte. With this file, MLV App always crashes in "frame_cashing.c" Is it possible to run MLV App without cashing for a test? What must I do to disable cashing?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 03, 2017, 11:11:27 AM
Maybe you know, that I have problems, importing files bigger than 4 Gbyte. The app crashes. These files are way to big for uploading somewhere.

So I startet QT Creator in debugging mode with a file with 7,6 GByte. With this file, MLV App always crashes in "frame_cashing.c" Is it possible to run MLV App without cashing for a test? What must I do to disable cashing?
That is strange. Caching is deactivated for the Qt App. In which line does it crash?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 03, 2017, 11:14:52 AM
Okay let me rephrase. Whats the best way to compile this for Windows ? The Git page only shows how to do it for cocoa and mac.
Get QtCreator for Windows. Unzip ffmpeg. Start QtCreator. Open .pro. Click on Play-Icon. Have fun.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on October 03, 2017, 01:04:21 PM
Seems everyone wants how to compile Qt app in the read me. I'll put one together this evening (unless masc or bouncyball beat me to it). shouldn't be too hard as I just installed Qt
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 03, 2017, 03:19:17 PM
Seems everyone wants how to compile Qt app in the read me. I'll put one together this evening (unless masc or bouncyball beat me to it). shouldn't be too hard as I just installed Qt
That would be cool! If you need help, let me know... but it is really not hard.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 03, 2017, 03:49:58 PM
With this file, MLV App always crashes in "frame_cashing.c" Is it possible to run MLV App without cashing for a test?
Does this MLV pass through other programs? mlv_dump, mlvfs?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 03, 2017, 05:37:25 PM
Does this MLV pass through other programs? mlv_dump, mlvfs?
I´m a bit busy at the moment, so sorry for only a short answer:
No problems with mlv_dump. All frames are decoded to dng, no frame is corrupted.
I will do some screenshots later this evening, maybe tomorrow.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: hjfilmspeed on October 04, 2017, 05:00:26 AM
Not sure If this has been addressed. Just really excited to use this. I get a crash every time on import of 14bit lossless 1920 x 1080 23.976 clip.  Sorry for the terrible report but this app looks so good. I haven't had enough time to review this part of the forum but I will delete if this has been addressed. I'm on a On a windows 7 x64 Machine here is the windows error report:
Problem signature:
  Problem Event Name:   APPCRASH
  Application Name:   mlvapp.exe
  Application Version:   0.0.0.0
  Application Timestamp:   59c7c736
  Fault Module Name:   mlvapp.exe
  Fault Module Version:   0.0.0.0
  Fault Module Timestamp:   59c7c736
  Exception Code:   c000001d
  Exception Offset:   0000000000017fc6
  OS Version:   6.1.7601.2.1.0.256.1
  Locale ID:   1033
  Additional Information 1:   907b
  Additional Information 2:   907bc937f1d4b6de41bbc9e5a303a085
  Additional Information 3:   a276
  Additional Information 4:   a27670abb9f65021d2cba031d8026e8f

Read our privacy statement online:
  http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0409

If the online privacy statement is not available, please read our privacy statement offline:
  C:\Windows\system32\en-US\erofflps.txt
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 04, 2017, 09:46:13 AM
Well this error dump gives no hint at all to anybody ( as usual, thanks MS ;) ).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 05, 2017, 07:39:55 PM
Quick question -- upon compiling and making app is it normal for me to receive all these warnings?

Look on the bottom of this code.

Code: [Select]
Seans-Mini-385:~ DeafEyeJedi$ cd MLV-App/platform/cocoa
Seans-Mini-385:cocoa DeafEyeJedi$ make app
rm "MLV App".app; \
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 generate_info_plist.c -o generate_info_plist; \
./generate_info_plist "MLV App"; \
make main; \
rm -rf "MLV App".app; \
mkdir "MLV App".app; \
mkdir "MLV App".app/Contents; \
mkdir "MLV App".app/Contents/MacOS; \
mkdir "MLV App".app/Contents/Resources; \
cp -i "MLV App" "MLV App".app/Contents/MacOS/; \
cp -i info.plist "MLV App".app/Contents/; \
mkdir "MLV App".app/Contents/Resources/pixelmaps; \
cp -i ../../src/mlv/llrawproc/pixelmaps/*.fpm "MLV App".app/Contents/Resources/pixelmaps; \
unzip ../qt/FFmpeg/ffmpegOSX.zip -d "MLV App".app/Contents/Resources; \
rm -rf "MLV App".app/Contents/Resources/__MACOSX; \
cp ../../src/icon/icon.icns "MLV App".app/Contents/Resources/MLV\ App.icns; \
rm generate_info_plist; \
rm info.plist; \

rm: MLV App.app: No such file or directory
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 compile_time_code.m -o compile_time_code -framework Cocoa; \
./compile_time_code; \
rm main.o; \
make build; \
rm compile_time_code; \
rm app_defines.h
Initial app name: MLV App (Oct  5 2017 10:37:16 @Seans-Mini-385)
rm: main.o: No such file or directory
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c main.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/video_mlv.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -pthread ../../src/debayer/debayer.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/debayer/amaze_demosaic.c
In file included from ../../src/debayer/amaze_demosaic.c:36:
../../src/debayer/sleefsseavx.c:27:9: warning: 'M_PI' macro redefined
      [-Wmacro-redefined]
#define M_PI 3.14159265358979323846
        ^
/usr/include/math.h:703:9: note: previous definition is here
#define M_PI        3.14159265358979323846264338327950288   /* pi             */
        ^
In file included from ../../src/debayer/amaze_demosaic.c:36:
../../src/debayer/sleefsseavx.c:28:9: warning: 'M_1_PI' macro redefined
      [-Wmacro-redefined]
#define M_1_PI 0.31830988618379067154
        ^
/usr/include/math.h:706:9: note: previous definition is here
#define M_1_PI      0.318309886183790671537767526745028724  /* 1/pi           */
        ^
In file included from ../../src/debayer/amaze_demosaic.c:36:
../../src/debayer/sleefsseavx.c:29:9: warning: 'M_2_PI' macro redefined
      [-Wmacro-redefined]
#define M_2_PI 0.63661977236758134308
        ^
/usr/include/math.h:707:9: note: previous definition is here
#define M_2_PI      0.636619772367581343075535053490057448  /* 2/pi           */
        ^
3 warnings generated.
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/processing/raw_processing.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c main_methods.m
main_methods.m:265:63: warning: null passed to a callee that requires a non-null
      argument [-Wnonnull]
  ...[[App->rawBitmap representationUsingType: NSPNGFileType properties: nil...
                      ^                                                  ~~~
1 warning generated.
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c gui_stuff/useful_methods.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c background_thread.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/matrix/matrix.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/camera_matrices.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/frame_caching.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/liblj92/lj92.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c session_methods.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c delegate.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c mlv_view.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/llrawproc.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/pixelproc.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/stripes.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/patternnoise.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/hist.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/dualiso.c
../../src/mlv/llrawproc/dualiso.c:34:9: warning: 'M_PI' macro redefined
      [-Wmacro-redefined]
#define M_PI 3.14159265358979323846 /* pi */
        ^
/usr/include/math.h:703:9: note: previous definition is here
#define M_PI        3.14159265358979323846264338327950288   /* pi             */
        ^
1 warning generated.
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o llrawproc.o pixelproc.o stripes.o patternnoise.o hist.o dualiso.o -o "MLV App" -framework Cocoa;
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg 
Seans-Mini-385:cocoa DeafEyeJedi$

I have a feeling it's because my Mac Mini just became a virgin last week after accidentally typing in incorrectly to try and remove a directory as oppose to the entire drive. So excuse for my stupidity in here.  Forgot that I have to start everything again from scratch on this machine. :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 05, 2017, 08:41:36 PM
When I'm compiling QTApp I got 63 warnings :P (of course someday all these warnings should be addressed, but mostly they are not harmful)
As far as it compiles and runs I guess this is true for cocoa version too.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 05, 2017, 08:50:08 PM
When I'm compiling QTApp I got 63 warnings :P (of course someday all these warnings should be addressed, but mostly they are not harmful) I guess this is true for cocoa version too.

HeHe. Just checked the platform. Saw an MLV App build under Cocoa. Opened it. Wont let me batch import. One file works fine. Upon exporting I get error message after it crashed. I also got a prompt message from MLV App saying that 'export completed' but nothing showed up in destination folder.

Here's a log report in case they are any hints or clues...

https://mega.nz/#!7kEzSRQB!7dLqraZ8kOuBoX2AsUWqNDY98aliEWZgHqBak2Nx2cM
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on October 05, 2017, 11:06:16 PM
Quote from: DeafEyeJedi
Quick question -- upon compiling and making app is it normal for me to receive all these warnings?
Only one used to be there, but the new ones are harmless as far as I can tell.

Quote from: DeafEyeJedi
Wont let me batch import.
Ah yes, batch import isn't done yet in Cocoa app, that's on the way. Though Cocoa app is probably gonna take a little while to catch up with Qt.

And sorry about the crash on ending of export. Also, I find that the non-exporting clip thing happens only in some directories :/

My current thing is getting cache working which I was going to commit yesterday, then today, but nothing got done today(zero), so gonna have to be tommorow.
@bouncyball we'll have to find a way of detecting LLRawProc changes to know when to re-cache, maybe we can add a flag?
Anyway, first I'll commit it to the cache branch then we sort that out.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 06, 2017, 08:11:54 AM
@bouncyball we'll have to find a way of detecting LLRawProc changes to know when to re-cache, maybe we can add a flag?
Anyway, first I'll commit it to the cache branch then we sort that out.
OK, I think the simplest way will be to introduce some "is_changed" variable in the llrawproc struct which will be set to true when gui widget handlers get called and then reset to false by caching module.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 06, 2017, 05:32:07 PM

Quote
Quote from: escho on October 03, 2017, 10:17:28 AM

    Maybe you know, that I have problems, importing files bigger than 4 Gbyte. The app crashes. These files are way to big for uploading somewhere.

    So I startet QT Creator in debugging mode with a file with 7,6 GByte. With this file, MLV App always crashes in "frame_cashing.c" Is it possible to run MLV App without cashing for a test? What must I do to disable cashing?


That is strange. Caching is deactivated for the Qt App. In which line does it crash?

It crashes in line 61: https://seescho.files.wordpress.com/2017/10/screenshot_20171005_191349.jpg
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 06, 2017, 07:11:19 PM
Any chance I can compile/make the QT version instead of the MLV App for me to try the latest Dual-ISO implementation?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 06, 2017, 07:34:14 PM
It crashes in line 61: https://seescho.files.wordpress.com/2017/10/screenshot_20171005_191349.jpg
Thank you! I'll have a look at that! That information really helps!

Any chance I can compile/make  the QT version instead of the MLV App for me to try the latest Dual-ISO implementation?
Sure, if you like, download Qt (free version, I think 5.9.1 is the latest), install, and do what I wrote somewhere above. The most difficult part is to compile and install libpng and zlib on mac (done in terminal, without Qt). The libraries are also in the repos (zip files).

Edit: there are some bugs inside atm, that is (for me) the main reason why I don't like to build a next release for everybody. We are working on it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 06, 2017, 07:52:55 PM
It crashes in line 61: https://seescho.files.wordpress.com/2017/10/screenshot_20171005_191349.jpg

Hm, okay, this function is called from MainWindow, openMlv(). For a quick test you could comment this function out there. For the future this may not be the solution...

@Ilia: do you need this function still after your big cache update, or will it be changed? Maybe have a look on that...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 06, 2017, 07:55:41 PM
Edit: there are some bugs inside atm, that is (for me) the main reason why I don't like to build a next release for everybody. We are working on it.

No worries. Was just curious of the current state being. It's definitely getting closer as we all can feel it, right? Thanks! ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 06, 2017, 09:27:58 PM
Hm, okay, this function is called from MainWindow, openMlv(). For a quick test you could comment this function out there. For the future this may not be the solution...

I commented out line 461 in MainWindow.cpp. Now the app crashes in line 468 in MainWindow.cpp:  https://seescho.files.wordpress.com/2017/10/2.jpg

I did another test. I cut the 7,6 G-file using "mlv_dump -fxxxx":

1318frames.MLV run with no problems
1319frames.MLV let the app crash.

Here are the filesizes of the two MLVs:

Code: [Select]
edgar@localhost:~/test/frames> ls -l
insgesamt 8440240
-rw-r--r-- 1 edgar users 4319763492  6. Okt 20:57 1318frames.MLV
-rw-r--r-- 1 edgar users 4323038516  6. Okt 20:58 1319frames.MLV

I cannot locate, where the crash with 1319frames.MLV appears, since QT Creator tells me, it cannot find binary debug informations for this stack frame.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 08, 2017, 12:09:09 PM
I commented out line 461 in MainWindow.cpp. Now the app crashes in line 468 in MainWindow.cpp:  https://seescho.files.wordpress.com/2017/10/2.jpg

I did another test. I cut the 7,6 G-file using "mlv_dump -fxxxx":

1318frames.MLV run with no problems
1319frames.MLV let the app crash.

Here are the filesizes of the two MLVs:

Code: [Select]
edgar@localhost:~/test/frames> ls -l
insgesamt 8440240
-rw-r--r-- 1 edgar users 4319763492  6. Okt 20:57 1318frames.MLV
-rw-r--r-- 1 edgar users 4323038516  6. Okt 20:58 1319frames.MLV

I cannot locate, where the crash with 1319frames.MLV appears, since QT Creator tells me, it cannot find binary debug informations for this stack frame.

Thx for your work! Unfortunately I can't test or debug that, because I can't create such a big file with my 5D2. But I created an issue on github for that problem and inserted your messages as quote.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 08, 2017, 03:05:10 PM
Thx for your work! Unfortunately I can't test or debug that, because I can't create such a big file with my 5D2. But I created an issue on github for that problem and inserted your messages as quote.

Thanks for opening an issue. You can find my answer in github :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 11, 2017, 11:23:48 AM
@escho

Can you confirm that under Linux audio is not working as expected in the latest github version?
Which distribution do you use?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 12, 2017, 08:55:07 AM
Can you confirm that under Linux audio is not working as expected in the latest github version?
Which distribution do you use?

Since I  use rawvideo only for my astromomical shootings ( https://seescho.wordpress.com/ ), I have no sound in the MLVs. I must wait for the weekend to record some clips with sound and will report.

I´m on openSUSE Leap42.3 or (for some reasons at tho moment) on the "near bleeding edge" openSUSE Thumbleweed.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 16, 2017, 11:50:12 AM
@masc
Importing a MLV. via menue
File - import mlv - irgendetwas.MLV:  leftclick
This imports the MLV immedeately whithout pressing the open button. Is this expected behavior?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 16, 2017, 12:06:03 PM
@masc
Importing a MLV. via menue
File - import mlv - irgendetwas.MLV:  leftclick
This imports the MLV immedeately whithout pressing the open button. Is this expected behavior?

This should be operating system behaviour. For me, I have to select the file(s), doubleclick one file or press open. Qt can't change the behaviour of the systems open dialog. I must implement a own file dialog in order to change it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 16, 2017, 10:56:49 PM
Thanks for the hint. I had a big fight in the last few hours with the big files doing funny things. So I will look later, how I can tune my OP.  ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on October 21, 2017, 11:25:14 PM
New Cocoa App release (v0.21)

(https://user-images.githubusercontent.com/23642861/31855848-4d05911c-b6ab-11e7-8a87-5e0a546b9417.png)

Main news:

Working on getting session implemented too like the Qt App - still not there.

Not sure where to go next with this GUI :-\

Download (https://github.com/ilia3101/MLV-App/releases/tag/v0.21-pre-alpha-xyY-edition)

Note: I still recommend using Qt app for anything relatively serious, this is only for testing.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on October 21, 2017, 11:54:46 PM
Looking good Ilia.
Is vertical stripes set to off as default?
I prefer raw2dng code pixel fix code set to default. Maybe the new workflow works better with mlvfs code nowadays.
I think crop_rec code could be automated since we have RAWC metadata.
How is dualiso working? On the fly prores making?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 22, 2017, 12:08:52 AM
It does look good indeed!

What part of your not sure where to go next with the gui?
I think its growing up very fast
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 22, 2017, 11:12:05 AM
And here comes after a very long time a new MLVApp Qt version. We had many problems with old and new features. Some of them are still present... you'll see when trying out.  Download (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.9alpha)
New features:
- more RAW corrections, focus pixels working
- dual ISO working
- free zoom
- new caching
- sharpening
- pipe ffmpeg export (no more intermediate PNG, much faster)
- new export options for ffmpeg (ProRes 422 way faster with ffmpeg Anatolyi option)
- single 48bit (3x16bit) PNG frame export
- RGB parade
- dark style
- many detail enhancements
- many bugfixes
Problems:
- big audio (sync) problems on Linux, small audio problems on Windows (app may crash when looping very small clips with audio)
- maybe still some instability with caching (has to be tested more)
- ... :P

@bouncyball: could you please again compile and upload the windows versions on github release page?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on October 22, 2017, 11:46:31 AM
Great! A slight warning about Prores422. I tested it with my piping in Switch but it doesn´t hold up in shadows like the slower prores_ks is doing. Could maybe work better here, idk. As a matter of fact I got better, smaller and faster output with H.264 like this:
-c:v libx264 -preset ultrafast -crf 18
or bigger, lossless:
-c:v libx264 -preset ultrafast -crf 0

Maybe not the best format to work with in post...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 22, 2017, 04:04:56 PM
@bouncyball: could you please again compile and upload the windows versions on github release page?
Yes sure :) 64bit very soon. 32 bit maybe later.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 22, 2017, 04:33:53 PM
Uploaded
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 22, 2017, 07:38:00 PM
@bouncyball: thank you!
@Danne: Ok, I did no quality checks with it yet. I only saw, that 422 Proxy is 4 times bigger and looks way better in prores_aw than prores_ks. Best quality will be prores_ks 4444. I thought it could be interesting for people who don't want to wait a long time to preview the files and maybe use the same files as proxy... Thanks for writing your experience! ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on October 22, 2017, 07:50:14 PM
I see if I find some time to test more. It may very well be the way dcraw pipes the dng files. By the way. How are you piping atm? Mlv straight to ffmpeg? Would be nice if mlv_dump could pipe straight to ffmpeg  :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 22, 2017, 08:40:41 PM
We do this: mlv->raw corrections->debayer->processing->pipe to ffmpeg (audio still via .wav)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 24, 2017, 04:38:06 PM
@masc:

I compiled Winx86 version but unfortunately can not upload it to the release page b/c it crashed every time I import any MLV.

Debugger stops in the "an_mlv_cache_thread()" function on the initialization of "amaze_params" struct.... very strange.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 24, 2017, 05:52:52 PM
This is what I described here: https://github.com/ilia3101/MLV-App/issues/35
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on November 05, 2017, 09:33:13 AM
Just tested the quicktime version and it works so good batch exporting. Question. I lined up 10 MLV files in the queue. How do I abort processing? Pushed esc but it continues after closing down the app. Had to go into terminal and do:
Code: [Select]
killall ffmpeg
Now I am really curious if it would be possible to export HDR MLV files? All it takes is a small ffmpeg filter:
Code: [Select]
-vf tblend=all_mode=averagehttp://www.magiclantern.fm/forum/index.php?topic=20025.msg189033;topicseen#msg189033

Coud be worth trying out.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 05, 2017, 03:59:03 PM
Where did you find a quicktime version? Never heard that it is ready yet.

For the Qt version, abort processing works when clicking the "Abort" button in the status dialog. It is implemented for the latest revisions on github. There is no release yet, so you have to compile it yourself for now. For the old releases you can only wait or kill the processes yourself.

This HDR thing I could try out. Thx.
Edit: is this for any mlv or for hdr-mlraw?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on November 05, 2017, 04:27:28 PM
Any plans on adding DNG as an export option in the future?

Great progress on the app so far  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on November 05, 2017, 04:52:47 PM
I downloaded 0.9 version in first post so probably not the latest. Would be nice if there was a description of dependencies for compiling on mac :).
The tblend filter can be applied to any footage but will only be useful when used with hdr material. Averaging filter will create ghosting so 48, 50 or 60 fps is better to use as opposed to slower fps.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 05, 2017, 06:01:01 PM
Any plans on adding DNG as an export option in the future?

https://github.com/ilia3101/MLV-App/issues/28
It is discussed here.

I downloaded 0.9 version in first post so probably not the latest. Would be nice if there was a description of dependencies for compiling on mac :).

https://github.com/ilia3101/MLV-App
See the readme, all neccessairy information should be there.

The tblend filter can be applied to any footage but will only be useful when used with hdr material. Averaging filter will create ghosting so 48, 50 or 60 fps is better to use as opposed to slower fps.
So if I test with a hdr mlv with my 5D2, it will be 25fps out of the cam. I export to 12.5fps then?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on November 05, 2017, 06:08:24 PM
It will still be 25fps. Averaging consecutive frames retains original fps so just export as usual.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on November 05, 2017, 06:48:19 PM
Damn. I've been struggling looking for a stable workflow. I aldready lost so much footage going back and forth between mlvdump, mlvp, resolve or converters. I'm trying this one now. Hope it sorts me out. Thanks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 05, 2017, 07:07:45 PM
Code: [Select]
-vf tblend=all_mode=average

Unfortunately that does not work for piped output:

Code: [Select]
Option vf (set video filters) cannot be applied to input url - -- you are trying to apply an input option to an output file or vice versa. Move this option before the file it belongs to.
Error parsing options for input file -.
Error opening input files: Invalid argument

"-" is the pipe and ffmpeg can't parse the input before it is created. Any ideas?

Edit: okay okay... I have to set it at the end of the command. Then it works fine. But one problem is: you never get what you see... :-(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on November 05, 2017, 07:30:35 PM
Why? Isn't the piping working the same for prores previewer? I used to preview by piping to ffplay in Switch...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 05, 2017, 07:43:45 PM
Works... I made a mistake: I have to set it at the end of the command. Then it works fine. But one problem is: you never get what you see... :-(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on November 05, 2017, 07:50:36 PM
What do you mean? What do you get, what do you see?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 05, 2017, 07:55:58 PM
I see a processed picture in MLV App, and I get a processed + averaged picture on output. I think it might be better to implement this averaging in MLV App, then you can see what you get.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 10, 2017, 09:58:18 PM
I uploaded a new version of MLV App - v0.10 alpha.
- chroma blur --> use it to blur moiree and/or noise
- 2 different sharpeners: RGB and Luma
- rendering is now done in a render thread --> so the GUI is much more responsive, also while playback
- audio problems on Linux (hopefully) fixed
- new "Edit" sidebar with collapsable group boxes instead of tabs
- new UI for "RAW Correction" with button groups
- many bugfixes

(https://image.ibb.co/jp5BVm/Bildschirmfoto.png)

Problems:
- maybe still some small audio issues?! (hopefully not)
- sometimes instability when caching is enabled and clip is switched
- caching crashes app (Windows 32bit version)

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.10alpha

There is no Linux version uploaded... so Linux users: please compile it... :)
@bouncyball: could you again please upload a Win64 version? Thx!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on November 11, 2017, 12:20:43 AM
Hi, Masc. This app really is starting to become fully featured, excellent. Been testing out this new alpha 0.10 version, first bug report is that when using chroma blur radius it crashes the app everytime, (only managed to get away with using it once without the app crashing) using macOS High sierra 10.13
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on November 11, 2017, 01:44:27 AM
Thanks for your working, this is a really useful app. I use this app to decode dual iso video, but one question puzzles me. If I set the original iso higher than recovery iso, the image will be broken, otherwise it works good.(for example 1600/100 setting will result in a strange image) What did i miss?

Sorry for my english, hoping it won't bother you.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on November 11, 2017, 09:33:52 AM
(for example 1600/100 setting will result in a strange image) What did i miss?
Try this MLV of yours with classic cr2hdr command line utility from a1ex. I think the result will be the same strange image because base iso should be smaller than recovery iso. That is how it designed to work.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 11, 2017, 10:46:16 AM
Hi, Masc. This app really is starting to become fully featured, excellent. Been testing out this new alpha 0.10 version, first bug report is that when using chroma blur radius it crashes the app everytime, (only managed to get away with using it once without the app crashing) using macOS High sierra 10.13
Thx. And thanks for testing! macOS 10.13 I could not test. It works well on 10.9 & 10.11, Win7, Win8.1 and some Linux. Ilia should also have a 10.13, maybe he has same problems in cocoa version of the app and can debug?!
Does your 10.13 show a crash report? This would be interesting...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on November 11, 2017, 11:01:11 AM
Tested chroma blur on 10.13, didn't crash or do anything weird. Crash report would be good.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on November 11, 2017, 11:23:12 AM
Hi Masc & illia here are the crash reports as requested.    Crash report (App crashes when using the Chroma blur radius)

https://www.dropbox.com/s/ivn99gq4vrd0gpi/MLV%20APP%20crash%20report.rtf?dl=0


Crash report (App Crashes then importing a large amount of files)

https://www.dropbox.com/s/hfg5lje7ghi5te3/MLV%20APP%20crash%20report%2C%20%28crashes%20on%20import%20a%20large%20amount%20of%20files.rtf?dl=0
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 11, 2017, 12:54:02 PM
Thank you!
First one crashes in applyProcessingObject(), called from getMlvProcessedFrame8(), called from our renderThread.
Second one crashes in getMlvRawFrameFloat().
Does first one happen with special files or always? Could you upload some frames (short mlv) for us?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on November 11, 2017, 02:56:37 PM
Try this MLV of yours with classic cr2hdr command line utility from a1ex. I think the result will be the same strange image because base iso should be smaller than recovery iso. That is how it designed to work.
Thanks for your reply. Will you consider adding an export mode to export DNG sequences? Because ACR has lens profiles and AE can export videos in many other formats. Think of it as a suggestion.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on November 11, 2017, 03:27:48 PM
Think of it as a suggestion.
I already thought about it here (https://github.com/ilia3101/MLV-App/issues/28). Just had no enough time yet.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on November 11, 2017, 04:15:46 PM
Of course lovely Mlv app should have cDNG support. All for it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on November 11, 2017, 05:32:38 PM
Hi masc, All the MLV files where shot in 11-8bit lossless, currently i'm away untill monday, My camera and cards are at home, but when i return i will upload a small MLV file. Many thanks wayne.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on November 13, 2017, 11:37:41 AM
Hi Masc, here's the smallest file i could find that crashes the app, (repeatable crashes when loaded into sessions with other clips and using the chroma blur radius) https://www.dropbox.com/s/jj125nr36wbul8i/M31-0921.MLV?dl=0 The app crashes with other much larger clips too. All shot on 5d3, 1.2.3 Crop mode 3520 x 1320 11-8bit lossless. hope this helps, thanks wayne
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 13, 2017, 12:53:46 PM
Hi Wayne, thanks! Great, it crashes for me too with this file (Great?! LOL)
@Ilia: could you download the file and have look too? My debugger tells raw_processing.c, line 274.
Edit: changing this line to
Code: [Select]
sum += row[MIN(x+radius_x+3,limit_x)]; solves the problem for me. Would that be okay, Ilia? Should the other lines in these three for()... also be limited?
Or before
Code: [Select]
for (int32_t x = radius_x; x < (limit_x-radius_x-3); x+=3)also does the job...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on November 13, 2017, 11:03:23 PM
Thanks masc 4 the debugger info. I'll download the file and have a test.
EDIT: saw you had a couple solutions, will check both and make sure they're 100% ok (I feel there might be one issue)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on November 13, 2017, 11:20:44 PM
First solution causes slowdown because adding MIN/MAX macro in the middle of a long long loop that only needs it for edge case.
Maybe not noticeable but I worked to remove such things. Also might end up subtracting a few incorrect pixels for the blur.
Second solution caused big colourful noticeable artifact on right edge of picture.

Try out changing line 253 to:
Code: [Select]
int32_t limit_x = (imageX-radius-1)*3;
To be honest, I couldn't get it to crash, and still haven't been able to compile Qt app. But I think this should stop it going past the edge without causing other problems.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 14, 2017, 08:24:00 AM
With the MLV from Wayne H it crashes for me... but only with this file, but also with the cocoa version. I'll try that out! Thx.
Works for me without crash. But won't that give a problem with lines 277 and following?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on November 14, 2017, 12:42:45 PM
Weird.. I used the same file from WayneH.
Code: [Select]
But won't that give a problem with lines 277 and following?It only changes how far the 'fast' part of the code goes, as I assume it must have been going past the edge due to the lack of MIN/MAX protection. Shouldn't affect image at all.

Also tried with Qt App v0.10, still didn't crash.
I am using a 'beta' version of next macOS 10.13 update (can't figure out how to get out of the beta programme), so it's a little ahead of the rest of 10.13s in the world. Could be something to do with that.

So my solution did fix it? If it's all fine commit it :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 14, 2017, 08:46:10 PM
Commited to the repos. @Wayne: in the next release you can try again. Or you try to compile yourself (don't know if it is fun for you).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on November 17, 2017, 06:41:48 PM
Thank you Masc & Illia, think i'll wait for the new version rather than compile tho, (not so much fun, confusing lol) + something to look forward too, haha, on the post production side, xmas 2017 is going rather fun, the soon to be released FCPX 10.4 with new colour tool goodies + i'm hoping a new version of this great app too, also potentially with new goodies, :) fingers crossed. lol

I'm really really impressed with this app, i'm curious to know what other feature's and option's you have planned for future releases (roadmap) lol?

One side note, the dual ISO feature, i've tested this, Loaded dual ISO file (11-8bit lossless), raw corrections D_ISO enabled, everything is fine lines gone etc, However once i click on export, the alternating lines re-appear, and the final exported dual iso file is with the line's, exported un proccessed it would seem, i'm not sure whether you guy's are aware of this, or whether the dual iso feature is a work in progress, just thought i'd share my experiance with using it,

AGAIN, GREAT WORK GUYS, Masc, llia, Bouncyball, Danne and anyone else who has contributed to this app,

Thanks Wayne.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on November 18, 2017, 10:12:56 AM
Thanks for kind words :)

once i click on export, the alternating lines re-appear, and the final exported dual iso file is with the line's, exported un proccessed it would seem, i'm not sure whether you guy's are aware of this, or whether the dual iso feature is a work in progress, just thought i'd share my experiance with using it,
Here, just a plain uncompressed dual iso mlv exports w/o problem. I never tried to do this with losless MLV though. Can you cut short clip of your mlv and post somewhere to test?

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 18, 2017, 05:23:30 PM
Thank you Wayne! ;)
Yes, I can understand, if you don't like to compile yourself. There are already some new features & fixes ready (receipt import/export) and some other ones are in the pipeline (better sync between audio&video, AVFoundation export on OSX,... for example). You won't have to wait until xmas for v0.11 ;-) When there is a revsision, which is not to buggy, it will be this version  :P
The enhancements and fixes where we are working on and which we are planning can be seen in the issue page of github: https://github.com/ilia3101/MLV-App/issues (https://github.com/ilia3101/MLV-App/issues)
Dual ISO should be ready, but there may be always some bugs. Sorry for that. As bouncyball wrote: please upload a short file on which you have problems and we will try to solve the bugs!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 21, 2017, 08:51:49 AM
One side note, the dual ISO feature, i've tested this, Loaded dual ISO file (11-8bit lossless), raw corrections D_ISO enabled, everything is fine lines gone etc, However once i click on export, the alternating lines re-appear, and the final exported dual iso file is with the line's, exported un proccessed it would seem, i'm not sure whether you guy's are aware of this, or whether the dual iso feature is a work in progress, just thought i'd share my experiance with using it,

I think I also found this one. All RAW corrections settings were at default when exporting. In many clips we did not see this error. But now I had the same with bad pixels... :-D
Bouncyball implemented Cinema DNG export. We need some more testing and then I think it is time for v0.11...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 22, 2017, 04:38:24 PM
We are indeed a little proud to present our new release MLV App v0.11!

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.11alpha

New in this release:
- better (corrected) AMaZE, artefacts are minimized to a minimum. Thanks to a1ex, giving Ilia the right input for this correction!
- Cinema DNG export (uncompressed, lossless & fast pass), first two also working with dual iso 20bit->16bit
- H.264 & H.265 export
- receipt file import / export
- many fixes and detail enhancements

Windows version is on the way...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on November 22, 2017, 04:48:29 PM
Great! You guys are quicker in developing, than I can test :)

One small question for cdng-export:
Processing and Y/CR-separation doesn´t affect the exported dngs. Is this correct?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 22, 2017, 04:55:28 PM
CDNG is Raw, so no processing is done. Just RAW corrections are done for uncompressed and lossless.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on November 22, 2017, 04:59:45 PM
thanks for clarifying
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on November 22, 2017, 06:03:40 PM
The AMaZE demosaic quality has massively improved:

(http://image.ibb.co/j2KFiR/old.png) (http://image.ibb.co/h1FMOR/fixed.png)

(Guess what's before and what's after ;) )

And of course thanks a lot a1ex
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on November 22, 2017, 06:06:37 PM
Can not upload win64 build. It crashes when exporting DNGs. Does 32 bit build work as expected?

Edit: nope :P it crashes too. Will check tomorrow.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on November 22, 2017, 06:20:01 PM
Now that's amaze @Ilia :D.
Great that you implemented cdng support mr B.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 22, 2017, 06:33:10 PM
Can not upload win64 build. It crashes when exporting DNGs. Does 32 bit build work as expected?

Edit: nope :P it crashes too. Will check tomorrow.
Woah... (nearly) always the Windows version which makes unexpected things... :P
Title: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 23, 2017, 03:00:18 AM
Now that's amaze @Ilia [emoji2].
Great that you implemented cdng support mr B.

Indeed amazing @Ilia3101 and also thanks for implementing cdng support @bouncyball!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on November 23, 2017, 10:00:49 AM
Now DNG export is fixed on Win32/64 and both working builds are uploaded. Link (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.11alpha)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: noir on November 23, 2017, 11:21:30 AM
Wow, nice progress!

By the way, now that Cineform is open source, are you considering implementing Cineform RAW output?

IIRC, it has a 5:1 or so lossy wavelet compression, which would make working with RAW files very easy.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on November 23, 2017, 06:33:27 PM
Well, I love cineform and use it in premiere and resolve exclusively because I'm not a mac guy and lacking prores in windows, but think it is not on the top of our priority list and we'll wait for implementing it officially to the ffmpeg (at the moment ffmpeg supports only decoding of some cineform footage based on reversed engineered codec)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: noir on November 24, 2017, 09:33:34 AM
Understandable.

Thanks for considering it :)
Looking forward to the ffmpeg implementation as well
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on November 28, 2017, 03:15:29 PM
Hi guys. Dayum you have all been busy, seems like a really nice solid update, i will do some stress tests over the week and report back any bugs, Happy to report no crashes from the previous issues i reported :)

It looks like you all have implemented some sort of new debayering, the results are stunning with 3584x1320 crop footage, (previously some shots would exhibit some nasty aliasing and moire. In conjunction with the alexa log c profile, and sharpening.. the gradabilty within FCPX is a joy, that log profile makes matching scenes effortless, saves a whole heap of time, and seems to nullify a ton of noise too.

Excellent progress Ilia, Masc, Bouncyball, this app really is coming along nicely. I LOVE IT :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 28, 2017, 10:22:41 PM
Thank you for your nice words and for testing!  8)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on November 29, 2017, 12:27:01 AM
Anyone know the optimal Deflicker target when working with dual ISO files with this app?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: smasry on November 29, 2017, 02:09:44 AM
I second that @Wayne H, I just came over from the cr2hdr thread.

I tried a few random numbers in the 'Deflicker target' box, and can clearly see that the footage overall is darkened for raised values, however the flicker is still there. I can't find any documentation in your source code for this function, and would like to know how to determine the 'best' values to try, or what values have shown themselves as most effective?

Thanks
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on November 29, 2017, 02:12:17 PM
Deflicker feature is taken from MLVFS as is, If it worked there it should work here, but if not... then we have to ask dmilligan how to use it :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: a1ex on November 29, 2017, 02:36:54 PM
https://www.magiclantern.fm/forum/index.php?topic=12585.0
https://www.magiclantern.fm/forum/index.php?topic=8443.msg174075#msg174075 (images no longer valid, unfortunately)

The target level is just exposure compensation (how bright you want the result to be).

The debug screen from Auto ETTR tells you where the median falls on the image. If the median falls right on the line between "bright" and "dark" in your scene (e.g. the sky line is right in the middle of the image), then you'll have to use a different percentile (e.g. 75% to keep the sky flicker-free, or 25% to keep the buildings - or whatever is darker in your image - flicker-free); otherwise, median should be fine in most cases. TODO: experiment with trimmed mean (https://en.wikipedia.org/wiki/Truncated_mean).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: SirWhiteFox on November 29, 2017, 11:29:45 PM
We are indeed a little proud to present our new release MLV App v0.11!

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.11alpha

New in this release:
- better (corrected) AMaZE, artefacts are minimized to a minimum. Thanks to a1ex, giving Ilia the right input for this correction!
- Cinema DNG export (uncompressed, lossless & fast pass), first two also working with dual iso 20bit->16bit
- H.264 & H.265 export
- receipt file import / export
- many fixes and detail enhancements

Windows version is on the way...


This is by far the best MLV App created... Thx!!!  8)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on November 30, 2017, 09:13:31 AM
Hello to everybody! :)
How can we add aspect ratio to the menu?

That way we can see properly anamorphic footage.


(https://thumb.ibb.co/gkM8Cw/Screen_Shot_2017_11_30_at_10_08_20_AM.png) (https://ibb.co/gkM8Cw)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 30, 2017, 02:44:26 PM
@SirWhiteFox: Thx!  8)
@OlegK: I already thought about that. Stretching the picture is possible in principle. But we plan some other new features - and they in combination with stretching will cause some problems... Maybe it will be possible one day. What already works in the latest revision on the repos and in the next release: resizing video on export to a desired resolution.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on November 30, 2017, 08:20:18 PM
Wow Good news! Only on export? or preview too? much easier look at correct picture while working on coloring  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 01, 2017, 07:31:57 PM
Now I added this feature to the repos. It will be availlable in the next release, or you compile yourself.
You can now stretch the height by any factor. One planned feature is partially broken with that and I don't know how to fix atm... a lot of math is required by such an "easy" feature :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 01, 2017, 07:45:04 PM
Thanks a lot! :D
How I do it by myself?

Copy & paste code?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 01, 2017, 09:01:10 PM
Check out latest revision and compile as described.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 01, 2017, 09:07:30 PM
Cannot find it :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 01, 2017, 09:09:44 PM
The Link is also in the first post of this thread:
https://github.com/ilia3101/MLV-App
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 01, 2017, 09:12:29 PM
Cannot find it :(


https://github.com/ilia3101/MLV-App/commit/40b764610c979ba5d0175ae52a11734a5aca5672#diff-dc9439299160bd6fbdf881ff0355be17



Ok I found them> where I should paste all this text? or what I should do?
Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 01, 2017, 09:21:41 PM
???What do you want to paste???
There is a download button on the first page - the link I wrote. With that you'll get the sources. Also on the page is a short howto compile. But you'll need the whole development environment.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 01, 2017, 09:27:31 PM
I don't think I will be able to do it:(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 01, 2017, 09:40:58 PM
Then I recommend to wait for the next release... maybe in 1-2 week(s).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Lars Steenhoff on December 01, 2017, 10:40:04 PM
I hope the native osx app will be getting a new build also ( cocoa )
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 01, 2017, 10:47:05 PM
I think there will come an update. Ilia is busy in making it better too.
Note: Qt uses also cocoa and the same compilers on OSX.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 01, 2017, 11:54:21 PM
I think there will come an update. Ilia is busy in making it better too.
Note: Qt uses also cocoa and the same compilers on OSX.

Cocoa looks better to me, But so glitchy. Not working.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on December 02, 2017, 12:09:11 AM
Yeah, Cocoa app is not the "main" or "official" GUI, and probably won't be, I simply use it for writing the processing and MLV code because it's easier for me(and anyone wanting to test) to compile, but I have been improving it lately... it will have sessions and AVFoundation in next release (Yo @martinherring, how do you append a 16bit buffer to an AVAsset :D).

To compile Cocoa app, all you need is this one terminal command:
Code: [Select]
rm -rf MLV-App && xcode-select --install || git clone https://github.com/ilia3101/MLV-App.git && cd MLV-App/platform/cocoa && make app -j4 && rm *.o && open ./When it finishes, the folder with compiled app will open up.

If you don't have apple developer tools, macos will create a pop up saying "install software", just click ok and wait a minute or two for it to install compilers and git (it's a really small download).
Although, I'm not sure if at this moment it works on < macOS 10.13

Quote
Cocoa looks better to me, But so glitchy. Not working.
What's glitchy?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 02, 2017, 09:40:40 AM
import and sliders not working
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 02, 2017, 10:20:09 AM
If you post problems, please write a bit more than "not working". Which exact version do you use, which OS, what special kind of MLV is it, what did you exactly do to come to the problem? Import and sliders for standard MLV were working in each of my tests in both - cocoa and Qt version.

@Ilia: on 10.9 it does not compile (since first revision), on 10.11 all is fine.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: lordwilli on December 02, 2017, 06:14:34 PM
Could you please give another download link than github.com? it takes 6 kb/s i can't even download it
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on December 03, 2017, 10:45:34 PM
I love the new 16bit-tiff-export  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 04, 2017, 01:01:35 AM
 :)ask a question, will this app support HDR video processing?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 04, 2017, 08:28:11 PM
If you post problems, please write a bit more than "not working". Which exact version do you use, which OS, what special kind of MLV is it, what did you exactly do to come to the problem? Import and sliders for standard MLV were working in each of my tests in both - cocoa and Qt version.

@Ilia: on 10.9 it does not compile (since first revision), on 10.11 all is fine.

Ok! I am using Cocoa latest
(https://thumb.ibb.co/dFr30G/Screen_Shot_2017_12_04_at_9_18_16_PM.png) (https://ibb.co/dFr30G)


on a
(https://thumb.ibb.co/ePb30G/Screen_Shot_2017_12_04_at_9_17_13_PM.png) (https://ibb.co/ePb30G)


First problem I experiencing is:
When I add MLV file to program it doesn't show them in window,I CAN ADD ONE FILE ONLY,when I add one or more, the first one disappearing.
Notice windows where files should be empty, even one file added I cannot see it
(https://thumb.ibb.co/bvySSw/Screen_Shot_2017_12_04_at_9_21_15_PM.png) (https://ibb.co/bvySSw)


2nd. There is no option settings in this version, No settings I can change, can only export Prores4444
(https://thumb.ibb.co/i80Sub/Screen_Shot_2017_12_04_at_9_23_35_PM.png) (https://ibb.co/i80Sub)


3rd. cannot play the file, when press spacebar. it doesn't play at all.

4st. No zoom Button.

I like Footage program its so simple u don't need to save or load the files they are alway there u can delete them if u don't use them.

(https://thumb.ibb.co/h5Enub/Screen_Shot_2017_12_04_at_9_31_13_PM.png) (https://ibb.co/h5Enub)

upload my photo (https://imgbb.com/)


Its easy but no Batch export, playback not working, and Quality is not good.

Also like Information on the button, and aspect ration options
(https://thumb.ibb.co/e0bHub/Screen_Shot_2017_12_04_at_9_36_08_PM.png) (https://ibb.co/e0bHub)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 04, 2017, 09:37:48 PM
Ok. Now I can answer.
1. Sessions are not yet implemented for cocoa app. It is on its way.
2. Cocoa app can only export ProRes 4444, other codecs will be implemented here
3. Cocoa app has no playback, maybe Ilia will implement this in the future
4. Cocoa app has no zoom, maybe Ilia will implement this in the future

If you like to have this features now, simple use the Qt OSX version. The cocoa version is Ilias test app, to test new features in the decoding and processing library in the background easily. Therefor the cocoa version maybe a little faster here and there and compiles fast without all the chichi.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 05, 2017, 12:13:49 AM
Ok. Now I can answer.
1. Sessions are not yet implemented for cocoa app. It is on its way.
2. Cocoa app can only export ProRes 4444, other codecs will be implemented here
3. Cocoa app has no playback, maybe Ilia will implement this in the future
4. Cocoa app has no zoom, maybe Ilia will implement this in the future

If you like to have this features now, simple use the Qt OSX version. The cocoa version is Ilias test app, to test new features in the decoding and processing library in the background easily. Therefor the cocoa version maybe a little faster here and there and compiles fast without all the chichi.


Thank you Masc!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 11:15:49 AM
After I tried Latest Cocoa, then deleted and now my QT not working at all. Always crashing:(
From console:
Failed to start process notifications for pid 870 (16)


Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 06, 2017, 12:06:34 PM
The 2 apps are 100% independent in terms of processes. You can install cocoa and delete as often you want and the Qt version won't recognize it. I think you made a mistake here... maybe you try to start the app in the trash or something like that.
And you start the Qt version from console?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 01:34:41 PM
The 2 apps are 100% independent in terms of processes. You can install cocoa and delete as often you want and the Qt version won't recognize it. I think you made a mistake here... maybe you try to start the app in the trash or something like that.
And you start the Qt version from console?

From Application folder>(

What it can be? I don't know!

Its crash on opening, exporting, pasting settings.

Can you help me with this?
Thanks`!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 02:24:00 PM
The 2 apps are 100% independent in terms of processes. You can install cocoa and delete as often you want and the Qt version won't recognize it. I think you made a mistake here... maybe you try to start the app in the trash or something like that.
And you start the Qt version from console?

What should I do? The program worked before just fine?

Maybe trash preferences?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 06, 2017, 05:01:36 PM
I am sorry, but here I can't help. I compiled, copied and deleted MLV App thousand times, and never had an issue like that.
What I can tell you: "Failed to start process notifications for pid 870 (16)" comes not from MLV App, this comes from OSX (google tells).
But here you must solve the problem yourself, or anyone else can help you with that. If you have a solution, I would be very interested!
Is there a crash report maybe?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 05:53:34 PM
I am sorry, but here I can't help. I compiled, copied and deleted MLV App thousand times, and never had an issue like that.
What I can tell you: "Failed to start process notifications for pid 870 (16)" comes not from MLV App, this comes from OSX (google tells).
But here you must solve the problem yourself, or anyone else can help you with that. If you have a solution, I would be very interested!
Is there a crash report maybe?

Date/Time:       2017-12-06 16:27:52.646163 +0200
OS Version:      Mac OS X 10.12.6 (Build 16G29)
Architecture:    x86_64
Report Version:  19

Command:         MLV App
Path:            /Applications/MLV App.app/Contents/MacOS/MLV App
Version:         0.11 alpha (???)
Parent:          launchd [1]
PID:             1424

Event:           wakeups
Wakeups:         45024 wakeups over the last 76 seconds (594 wakeups per second average), exceeding limit of 150 wakeups per second over 300 seconds
Duration:        75.73s
Steps:           28

Hardware model:  iMac14,2
Active cpus:     8


Powerstats for:  MLV App [1424]
UUID:            60C9EA13-6340-310C-9220-DF5B4728C71E
Start time:      2017-12-06 16:27:53 +0200
End time:        2017-12-06 16:29:03 +0200
Microstackshots: 28 samples (100%)
Primary state:   12 samples Frontmost App, User mode, Effective Thread QoS User Interactive, Requested Thread QoS User Interactive, Override Thread QoS Unspecified
User Activity:   0 samples Idle, 28 samples Active
Power Source:    0 samples on Battery, 28 samples on AC
  14 start + 1 (libdyld.dylib) [0x7fff916f7235]
    12 main + 107 (MLV App) [0x10d04850b]
      12 QCoreApplication::exec() + 341 (QtCore) [0x1106ad115]
        12 QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) + 401 (QtCore) [0x1106a8eb1]
          12 ??? (libqcocoa.dylib + 156991) [0x11300e53f]
            12 -[NSApplication run] + 926 (AppKit) [0x7fff79a5c3db]
              12 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796 (AppKit) [0x7fff7a1e37ee]
                12 _DPSNextEvent + 1120 (AppKit) [0x7fff79a67a54]
                  12 _BlockUntilNextEventMatchingListInModeWithFilter + 71 (HIToolbox) [0x7fff7b4ceb26]
                    9  ReceiveNextEventCommon + 184 (HIToolbox) [0x7fff7b4cebf9]
                      9  RunCurrentEventLoopInMode + 240 (HIToolbox) [0x7fff7b4ceebc]
                        9  CFRunLoopRunSpecific + 420 (CoreFoundation) [0x7fff7bf6e114]
                          9  __CFRunLoopRun + 934 (CoreFoundation) [0x7fff7bf6e716]
                            9  __CFRunLoopDoSources0 + 557 (CoreFoundation) [0x7fff7bf6f21d]
                              9  __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 (CoreFoundation) [0x7fff7bf8e321]
                                9  ??? (libqcocoa.dylib + 161329) [0x11300f631]
                                  9  QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) + 155 (QtGui) [0x110aa206b]
                                    9  QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) + 2794 (QtGui) [0x110ab888a]
                                      9  QCoreApplication::notifyInternal2(QObject*, QEvent*) + 164 (QtCore) [0x1106acaa4]
                                        9  QApplication::notify(QObject*, QEvent*) + 5906 (QtWidgets) [0x110ff9822]
                                          9  QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269 (QtWidgets) [0x110ff6edd]
                                            9  ??? (QtWidgets + 464319) [0x1110565bf]
                                              9  ??? (QtWidgets + 468267) [0x11105752b]
                                                9  QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool) + 871 (QtWidgets) [0x110ff7847]
                                                  9  QCoreApplication::notifyInternal2(QObject*, QEvent*) + 164 (QtCore) [0x1106acaa4]
                                                    9  QApplication::notify(QObject*, QEvent*) + 9440 (QtWidgets) [0x110ffa5f0]
                                                      9  QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269 (QtWidgets) [0x110ff6edd]
                                                        9  QToolButton::event(QEvent*) + 323 (QtWidgets) [0x1111bbef3]
                                                          9  QAbstractButton::event(QEvent*) + 175 (QtWidgets) [0x1110e64ff]
                                                            9  QWidget::event(QEvent*) + 1681 (QtWidgets) [0x111036cc1]
                                                              9  QToolButton::mouseReleaseEvent(QMouseEvent*) + 15 (QtWidgets) [0x1111bb93f]
                                                                9  QAbstractButton::mouseReleaseEvent(QMouseEvent*) + 270 (QtWidgets) [0x1110e67ae]
                                                                  9  ??? (QtWidgets + 1050184) [0x1110e5648]
                                                                    9  QAction::activate(QAction::ActionEvent) + 303 (QtWidgets) [0x110fede4f]
                                                                      9  QMetaObject::activate(QObject*, int, int, void**) + 2027 (QtCore) [0x1106ddd9b]
                                                                        9  MainWindow::qt_metacall(QMetaObject::Call, int, void**) + 80 (MLV App) [0x10d0a8d70]
                                                                          4  MainWindow::on_actionExport_triggered() + 2043 (MLV App) [0x10d060c7b]
                                                                            4  QFileDialog::getSaveFileName(QWidget*, QString const&, QString const&, QString const&, QString*, QFlags<QFileDialog::Option>) + 260 (QtWidgets) [0x111205b74]
                                                                              4  QFileDialog::getSaveFileUrl(QWidget*, QString const&, QUrl const&, QString const&, QString*, QFlags<QFileDialog::Option>, QStringList const&) + 377 (QtWidgets) [0x111205db9]
                                                                                4  QDialog::exec() + 284 (QtWidgets) [0x1111f51dc]
                                                                                  4  ??? (libqcocoa.dylib + 269411) [0x113029c63]
                                                                                    4  ??? (libqcocoa.dylib + 253990) [0x113026026]
                                                                                      4  -[NSSavePanel runModal] + 629 (AppKit) [0x7fff7a16af48]
                                                                                        4  -[NSApplication runModalForWindow:] + 137 (AppKit) [0x7fff79cbbb98]
                                                                                          4  __35-[NSApplication runModalForWindow:]_block_invoke + 64 (AppKit) [0x7fff79e9e374]
                                                                                            4  -[NSApplication _doModalLoop:peek:] + 497 (AppKit) [0x7fff79cbe0b6]
                                                                                              4  -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796 (AppKit) [0x7fff7a1e37ee]
                                                                                                4  _DPSNextEvent + 1120 (AppKit) [0x7fff79a67a54]
                                                                                                  4  _BlockUntilNextEventMatchingListInModeWithFilter + 71 (HIToolbox) [0x7fff7b4ceb26]
                                                                                                    4  ReceiveNextEventCommon + 432 (HIToolbox) [0x7fff7b4cecf1]
                                                                                                      4  RunCurrentEventLoopInMode + 240 (HIToolbox) [0x7fff7b4ceebc]
                                                                                                        4  CFRunLoopRunSpecific + 420 (CoreFoundation) [0x7fff7bf6e114]
                                                                                                          4  __CFRunLoopRun + 2065 (CoreFoundation) [0x7fff7bf6eb81]
                                                                                                            4  __CFRunLoopDoTimers + 177 (CoreFoundation) [0x7fff7bf773c1]
                                                                                                              2  CFArrayCreateMutable + 27 (CoreFoundation) [0x7fff7bf0c9bb]
                                                                                                              1  objc_msgSend + 33 (libobjc.A.dylib) [0x7fff90e03061]
                                                                                                              1  objc_msgSend + 26 (libobjc.A.dylib) [0x7fff90e0305a]
                                                                          3  MainWindow::on_actionExport_triggered() + 3435 (MLV App) [0x10d0611eb]
                                                                            3  MainWindow::exportHandler() + 1988 (MLV App) [0x10d061f74]
                                                                              3  MainWindow::startExportPipe(QString) + 5244 (MLV App) [0x10d052f2c]
                                                                                3  getMlvProcessedFrame16 + 100 (MLV App) [0x10d083394]
                                                                                  2  applyProcessingObject + 326 (MLV App) [0x10d090276]
                                                                                  1  applyProcessingObject + 126 (MLV App) [0x10d0901ae]
                                                                          1  MainWindow::on_actionExportSettings_triggered() + 111 (MLV App) [0x10d062d4f]
                                                                            1  ExportSettingsDialog::ExportSettingsDialog(QWidget*, unsigned char, unsigned char, unsigned char, bool, double, bool, int) + 35 (MLV App) [0x10d0a0803]
                                                                              1  ExportSettingsDialog::ExportSettingsDialog(QWidget*, unsigned char, unsigned char, unsigned char, bool, double, bool, int) + 110 (MLV App) [0x10d09fdbe]
                                                                                1  QWidgetPrivate::setWindowFlags(QFlags<Qt::WindowType>) + 162 (QtWidgets) [0x111039002]
                                                                                  1  QWidget::setParent(QWidget*, QFlags<Qt::WindowType>) + 1823 (QtWidgets) [0x111024d0f]
                                                                                    1  QWidgetPrivate::inheritStyle() + 515 (QtWidgets) [0x111029a83]
                                                                                      1  QWidgetPrivate::setStyle_helper(QStyle*, bool, bool) + 673 (QtWidgets) [0x111029d81]
                                                                                        1  QWidgetPrivate::inheritStyle() + 515 (QtWidgets) [0x111029a83]
                                                                                          1  QWidgetPrivate::setStyle_helper(QStyle*, bool, bool) + 673 (QtWidgets) [0x111029d81]
                                                                                            1  QWidgetPrivate::inheritStyle() + 515 (QtWidgets) [0x111029a83]
                                                                                              1  QWidgetPrivate::setStyle_helper(QStyle*, bool, bool) + 831 (QtWidgets) [0x111029e1f]
                                                                                                1  QCoreApplication::notifyInternal2(QObject*, QEvent*) + 164 (QtCore) [0x1106acaa4]
                                                                                                  1  QApplication::notify(QObject*, QEvent*) + 5906 (QtWidgets) [0x110ff9822]
                                                                                                    1  QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269 (QtWidgets) [0x110ff6edd]
                                                                                                      1  QComboBox::event(QEvent*) + 403 (QtWidgets) [0x1111049c3]
                                                                                                        1  QWidget::event(QEvent*) + 4494 (QtWidgets) [0x1110377be]
                                                                                                          1  QComboBox::changeEvent(QEvent*) + 202 (QtWidgets) [0x1111045aa]
                                                                                                            1  ??? (QtWidgets + 1154536) [0x1110fede8]
                                                                                                              1  ??? (QtWidgets + 1145340) [0x1110fc9fc]
                                                                                                                1  QListView::QListView(QWidget*) + 291 (QtWidgets) [0x111282bf3]
                                                                                                                  1  QAbstractItemView::QAbstractItemView(QAbstractItemViewPrivate&, QWidget*) + 14 (QtWidgets) [0x1112613fe]
                                                                                                                    1  QAbstractScrollAreaPrivate::init() + 197 (QtWidgets) [0x1111bcf65]
                                                                                                                      1  ??? (QtWidgets + 1931469) [0x1111bc8cd]
                                                                                                                        1  ??? (QtWidgets + 1716838) [0x111188266]
                                                                                                                          1  ??? (QtWidgets + 809348) [0x1110aa984]
                                                                                                                            1  ??? (QtWidgets + 704841) [0x111091149]
                                                                                                                              1  ??? (QtWidgets + 731241) [0x111097869]
                                                                                                                                1  ??? (QtWidgets + 729621) [0x111097215]
                                                                                                                                  1  QCss::StyleSelector::styleRulesForNode(QCss::StyleSelector::NodePtr) + 1150 (QtGui) [0x110c3267e]
                                                                                                                                    1  QCss::StyleSelector::matchRule(QCss::StyleSelector::NodePtr, QCss::StyleRule const&, QCss::StyleSheetOrigin, int, QMap<unsigned int, QCss::StyleRule>*) + 49 (QtGui) [0x110c31e21]
                                                                          1  MainWindow::on_actionOpen_triggered() + 198 (MLV App) [0x10d04f986]
                                                                            1  QFileDialog::getOpenFileNames(QWidget*, QString const&, QString const&, QString const&, QString*, QFlags<QFileDialog::Option>) + 260 (QtWidgets) [0x111205544]
                                                                              1  QFileDialog::getOpenFileUrls(QWidget*, QString const&, QUrl const&, QString const&, QString*, QFlags<QFileDialog::Option>, QStringList const&) + 361 (QtWidgets) [0x1112058b9]
                                                                                1  QDialog::exec() + 284 (QtWidgets) [0x1111f51dc]
                                                                                  1  ??? (libqcocoa.dylib + 269411) [0x113029c63]
                                                                                    1  ??? (libqcocoa.dylib + 253990) [0x113026026]
                                                                                      1  -[NSSavePanel runModal] + 629 (AppKit) [0x7fff7a16af48]
                                                                                        1  -[NSApplication runModalForWindow:] + 137 (AppKit) [0x7fff79cbbb98]
                                                                                          1  __35-[NSApplication runModalForWindow:]_block_invoke + 64 (AppKit) [0x7fff79e9e374]
                                                                                            1  -[NSApplication _doModalLoop:peek:] + 497 (AppKit) [0x7fff79cbe0b6]
                                                                                              1  -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796 (AppKit) [0x7fff7a1e37ee]
                                                                                                1  _DPSNextEvent + 1120 (AppKit) [0x7fff79a67a54]
                                                                                                  1  _BlockUntilNextEventMatchingListInModeWithFilter + 71 (HIToolbox) [0x7fff7b4ceb26]
                                                                                                    1  ReceiveNextEventCommon + 184 (HIToolbox) [0x7fff7b4cebf9]
                                                                                                      1  RunCurrentEventLoopInMode + 240 (HIToolbox) [0x7fff7b4ceebc]
                                                                                                        1  CFRunLoopRunSpecific + 420 (CoreFoundation) [0x7fff7bf6e114]
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 05:58:53 PM
Process:               MLV App [1424]
Path:                  /Applications/MLV App.app/Contents/MacOS/MLV App
Identifier:            magiclantern.MLV App
Version:               0.11 alpha (0)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           MLV App [1424]
User ID:               501

Date/Time:             2017-12-06 18:50:53.896 +0200
OS Version:            Mac OS X 10.12.6 (16G29)
Report Version:        12
Anonymous UUID:        DB788A4A-4B40-04B1-85DC-5346F1362521


Time Awake Since Boot: 12000 seconds

System Integrity Protection: disabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x000000011c427000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler

VM Regions Near 0x11c427000:
    MALLOC_LARGE           000000011c159000-000000011c427000 [ 2872K] rw-/rwx SM=PRV 
-->
    MALLOC metadata        000000011c536000-000000011c537000 [    4K] r--/rwx SM=ZER 

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   magiclantern.MLV App             0x000000010d0830b1 getMlvRawFrameFloat + 513
1   magiclantern.MLV App             0x000000010d082765 get_mlv_raw_frame_debayered + 53
2   magiclantern.MLV App             0x000000010d083293 getMlvRawFrameDebayered + 227
3   magiclantern.MLV App             0x000000010d083417 getMlvProcessedFrame8 + 103
4   magiclantern.MLV App             0x000000010d04bf94 MainWindow::previewPicture(int) + 68
5   magiclantern.MLV App             0x000000010d04fdcf MainWindow::on_actionOpen_triggered() + 1295
6   magiclantern.MLV App             0x000000010d0a8d70 MainWindow::qt_metacall(QMetaObject::Call, int, void**) + 80
7   org.qt-project.QtCore            0x00000001106ddd9b QMetaObject::activate(QObject*, int, int, void**) + 2027
8   org.qt-project.QtWidgets         0x0000000110fede4f QAction::activate(QAction::ActionEvent) + 303
9   org.qt-project.QtWidgets         0x00000001110e5648 0x110fe5000 + 1050184
10  org.qt-project.QtWidgets         0x00000001110e67ae QAbstractButton::mouseReleaseEvent(QMouseEvent*) + 270
11  org.qt-project.QtWidgets         0x00000001111bb93f QToolButton::mouseReleaseEvent(QMouseEvent*) + 15
12  org.qt-project.QtWidgets         0x0000000111036cc1 QWidget::event(QEvent*) + 1681
13  org.qt-project.QtWidgets         0x00000001110e64ff QAbstractButton::event(QEvent*) + 175
14  org.qt-project.QtWidgets         0x00000001111bbef3 QToolButton::event(QEvent*) + 323
15  org.qt-project.QtWidgets         0x0000000110ff6edd QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269
16  org.qt-project.QtWidgets         0x0000000110ffa5f0 QApplication::notify(QObject*, QEvent*) + 9440
17  org.qt-project.QtCore            0x00000001106acaa4 QCoreApplication::notifyInternal2(QObject*, QEvent*) + 164
18  org.qt-project.QtWidgets         0x0000000110ff7847 QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool) + 871
19  org.qt-project.QtWidgets         0x000000011105752b 0x110fe5000 + 468267
20  org.qt-project.QtWidgets         0x00000001110565bf 0x110fe5000 + 464319
21  org.qt-project.QtWidgets         0x0000000110ff6edd QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269
22  org.qt-project.QtWidgets         0x0000000110ff9822 QApplication::notify(QObject*, QEvent*) + 5906
23  org.qt-project.QtCore            0x00000001106acaa4 QCoreApplication::notifyInternal2(QObject*, QEvent*) + 164
24  org.qt-project.QtGui             0x0000000110ab888a QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) + 2794
25  org.qt-project.QtGui             0x0000000110aa206b QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) + 155
26  libqcocoa.dylib                  0x000000011300f631 0x112fe8000 + 161329
27  com.apple.CoreFoundation         0x00007fff7bf8e321 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
28  com.apple.CoreFoundation         0x00007fff7bf6f21d __CFRunLoopDoSources0 + 557
29  com.apple.CoreFoundation         0x00007fff7bf6e716 __CFRunLoopRun + 934
30  com.apple.CoreFoundation         0x00007fff7bf6e114 CFRunLoopRunSpecific + 420
31  com.apple.HIToolbox              0x00007fff7b4ceebc RunCurrentEventLoopInMode + 240
32  com.apple.HIToolbox              0x00007fff7b4cebf9 ReceiveNextEventCommon + 184
33  com.apple.HIToolbox              0x00007fff7b4ceb26 _BlockUntilNextEventMatchingListInModeWithFilter + 71
34  com.apple.AppKit                 0x00007fff79a67a54 _DPSNextEvent + 1120
35  com.apple.AppKit                 0x00007fff7a1e37ee -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796
36  com.apple.AppKit                 0x00007fff79a5c3db -[NSApplication run] + 926
37  libqcocoa.dylib                  0x000000011300e53f 0x112fe8000 + 156991
38  org.qt-project.QtCore            0x00000001106a8eb1 QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) + 401
39  org.qt-project.QtCore            0x00000001106ad115 QCoreApplication::exec() + 341
40  magiclantern.MLV App             0x000000010d04850b main + 107
41  libdyld.dylib                    0x00007fff916f7235 start + 1

Thread 1:: RenderFrameThread
0   libsystem_kernel.dylib           0x00007fff91825f46 __semwait_signal + 10
1   libsystem_c.dylib                0x00007fff917acb72 nanosleep + 199
2   org.qt-project.QtCore            0x000000011059ec2b 0x1104c7000 + 883755
3   magiclantern.MLV App             0x000000010d0a5662 RenderFrameThread::run() + 34
4   org.qt-project.QtCore            0x00000001104f0b3a 0x1104c7000 + 170810
5   libsystem_pthread.dylib          0x00007fff9191093b _pthread_body + 180
6   libsystem_pthread.dylib          0x00007fff91910887 _pthread_start + 286
7   libsystem_pthread.dylib          0x00007fff9191008d thread_start + 13

Thread 2:: com.apple.NSEventThread
0   libsystem_kernel.dylib           0x00007fff9181e34a mach_msg_trap + 10
1   libsystem_kernel.dylib           0x00007fff9181d797 mach_msg + 55
2   com.apple.CoreFoundation         0x00007fff7bf6f434 __CFRunLoopServiceMachPort + 212
3   com.apple.CoreFoundation         0x00007fff7bf6e8c1 __CFRunLoopRun + 1361
4   com.apple.CoreFoundation         0x00007fff7bf6e114 CFRunLoopRunSpecific + 420
5   com.apple.AppKit                 0x00007fff79bb4f02 _NSEventThread + 205
6   libsystem_pthread.dylib          0x00007fff9191093b _pthread_body + 180
7   libsystem_pthread.dylib          0x00007fff91910887 _pthread_start + 286
8   libsystem_pthread.dylib          0x00007fff9191008d thread_start + 13

Thread 3:
0   libsystem_kernel.dylib           0x00007fff9182644e __workq_kernreturn + 10
1   libsystem_pthread.dylib          0x00007fff91910621 _pthread_wqthread + 1426
2   libsystem_pthread.dylib          0x00007fff9191007d start_wqthread + 13

Thread 4:
0   libsystem_kernel.dylib           0x00007fff9182644e __workq_kernreturn + 10
1   libsystem_pthread.dylib          0x00007fff91910621 _pthread_wqthread + 1426
2   libsystem_pthread.dylib          0x00007fff9191007d start_wqthread + 13

Thread 5:
0   libsystem_kernel.dylib           0x00007fff9182644e __workq_kernreturn + 10
1   libsystem_pthread.dylib          0x00007fff91910621 _pthread_wqthread + 1426
2   libsystem_pthread.dylib          0x00007fff9191007d start_wqthread + 13

Thread 6:
0   libsystem_kernel.dylib           0x00007fff9182644e __workq_kernreturn + 10
1   libsystem_pthread.dylib          0x00007fff91910621 _pthread_wqthread + 1426
2   libsystem_pthread.dylib          0x00007fff9191007d start_wqthread + 13

Thread 7:
0   libsystem_kernel.dylib           0x00007fff9182644e __workq_kernreturn + 10
1   libsystem_pthread.dylib          0x00007fff91910621 _pthread_wqthread + 1426
2   libsystem_pthread.dylib          0x00007fff9191007d start_wqthread + 13

Thread 8:
0   libsystem_kernel.dylib           0x00007fff9182644e __workq_kernreturn + 10
1   libsystem_pthread.dylib          0x00007fff91910621 _pthread_wqthread + 1426
2   libsystem_pthread.dylib          0x00007fff9191007d start_wqthread + 13

Thread 9:
0   libsystem_kernel.dylib           0x00007fff9182644e __workq_kernreturn + 10
1   libsystem_pthread.dylib          0x00007fff91910621 _pthread_wqthread + 1426
2   libsystem_pthread.dylib          0x00007fff9191007d start_wqthread + 13

Thread 10:
0   libsystem_kernel.dylib           0x00007fff9182644e __workq_kernreturn + 10
1   libsystem_pthread.dylib          0x00007fff91910621 _pthread_wqthread + 1426
2   libsystem_pthread.dylib          0x00007fff9191007d start_wqthread + 13

Thread 0 crashed with X86 Thread State (64-bit):
  rax: 0x00000000000d7fff  rbx: 0x0000000000086fff  rcx: 0x0000000000000020  rdx: 0x0000000000000006
  rdi: 0x000000000086fff6  rsi: 0x0000000000000016  rbp: 0x00007fff52bb8f30  rsp: 0x00007fff52bb8ec0
   r8: 0x000000000000000a   r9: 0x00000000000103ff  r10: 0xffffffffffffffff  r11: 0x0000000000012068
  r12: 0x00000000000d8000  r13: 0x000000011c319000  r14: 0x0000000124603000  r15: 0x00000001263ee000
  rip: 0x000000010d0830b1  rfl: 0x0000000000010202  cr2: 0x000000011c427000
 
Logical CPU:     6
Error Code:      0x00000004
Trap Number:     14


Binary Images:
       0x10d044000 -        0x10d22aff7 +magiclantern.MLV App (0.11 alpha - 0) <60C9EA13-6340-310C-9220-DF5B4728C71E> /Applications/MLV App.app/Contents/MacOS/MLV App
       0x110267000 -        0x110290ff7 +libpng16.16.dylib (0) <0599E6DB-21BC-39D5-9CCE-14DAFA04CF19> /Applications/MLV App.app/Contents/Frameworks/libpng16.16.dylib
       0x11029a000 -        0x11032bfe7 +org.qt-project.QtMultimedia (5.7 - 5.7.0) <E9B4404B-21EB-36E4-B06B-99F9794B8A18> /Applications/MLV App.app/Contents/Frameworks/QtMultimedia.framework/Versions/5/QtMultimedia
       0x11037f000 -        0x110483ff7 +org.qt-project.QtNetwork (5.7 - 5.7.0) <B40B02F2-BD1A-3593-831A-6E9C83FA1D61> /Applications/MLV App.app/Contents/Frameworks/QtNetwork.framework/Versions/5/QtNetwork
       0x1104c7000 -        0x1109dbff7 +org.qt-project.QtCore (5.7 - 5.7.0) <5F2F454C-CEE8-3E59-A3B7-94F51F5B9F96> /Applications/MLV App.app/Contents/Frameworks/QtCore.framework/Versions/5/QtCore
       0x110a90000 -        0x110ef0ff7 +org.qt-project.QtGui (5.7 - 5.7.0) <A41CBDE5-2955-3A57-BAE9-69001B210588> /Applications/MLV App.app/Contents/Frameworks/QtGui.framework/Versions/5/QtGui
       0x110fe5000 -        0x1114deff7 +org.qt-project.QtWidgets (5.7 - 5.7.0) <9029D91F-7F7E-3DE0-BD66-FC91DD8112C3> /Applications/MLV App.app/Contents/Frameworks/QtWidgets.framework/Versions/5/QtWidgets
       0x112fe8000 -        0x113159fff +libqcocoa.dylib (0) <24BD273C-5A40-3322-89BE-D5AC9640FF31> /Applications/MLV App.app/Contents/PlugIns/platforms/libqcocoa.dylib
       0x11319d000 -        0x113204ff7 +org.qt-project.QtDBus (5.7 - 5.7.0) <A3B1C34A-7EBC-36D6-B053-9CEE4A3D14CE> /Applications/MLV App.app/Contents/Frameworks/QtDBus.framework/Versions/5/QtDBus
       0x11321c000 -        0x11324fff7 +org.qt-project.QtPrintSupport (5.7 - 5.7.0) <67BB0DB0-88B2-3802-92D5-7B326C90AFB0> /Applications/MLV App.app/Contents/Frameworks/QtPrintSupport.framework/Versions/5/QtPrintSupport
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 06, 2017, 07:21:45 PM
First one: I don't find a problem with MLV App.
Second one: The App had a problem with the file you imported. The file may be corrupted in some way. Here you could upload this particular file and we could try to debug.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 07:50:47 PM
only happens when I open two these file. if you open just one by one its not crashing.
One is 50fps another 24fps.

https://ufile.io/u8rq4
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 06, 2017, 09:44:41 PM
I now have downloaded your files. I tried out with the actual revision and v0.10. In v0.10 it crashes when switching between these files - so I can reproduce. The last days bouncyball, Ilia and me, we were searching many bugs and also found+fixed many bugs. Good news: with the latest revision it does not crash. The bad news: we still have some small bugs on the list to fix before we release next version.

Could you please tell me, which horizontal stretch factor is needed to have M06-1260 in the correct aspect ratio? In the actual revision I build a combobox where you can select 1.0x, 1.33x, 1.5x and 2.0x as factor. I am not sure if it is 1.5x, 2.0x or something between...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 10:18:03 PM
I now have downloaded your files. I tried out with the actual revision and v0.10. In v0.10 it crashes when switching between these files - so I can reproduce. The last days bouncyball, Ilia and me, we were searching many bugs and also found+fixed many bugs. Good news: with the latest revision it does not crash. The bad news: we still have some small bugs on the list to fix before we release next version.

Could you please tell me, which horizontal stretch factor is needed to have M06-1260 in the correct aspect ratio? In the actual revision I build a combobox where you can select 1.0x, 1.33x, 1.5x and 2.0x as factor. I am not sure if it is 1.5x, 2.0x or something between...

Thanks! when you releasing?

I think its 1,75X or 1,80x You can add both:)

Can you make stretch for each individual file? Will it work on export too?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: a1ex on December 06, 2017, 10:29:01 PM
Could you please tell me, which horizontal stretch factor is needed to have M06-1260 in the correct aspect ratio? In the actual revision I build a combobox where you can select 1.0x, 1.33x, 1.5x and 2.0x as factor. I am not sure if it is 1.5x, 2.0x or something between...

All MLV files from current and past ML builds*) have their pixel aspect ratio either 1:1 (square pixels) or 5:3 (requiring vertical stretch).

*) The only exception is if you have changed the line skipping register (http://www.magiclantern.fm/forum/index.php?topic=17021.msg165204#msg165204) with adtg_gui or similar.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 06, 2017, 10:32:05 PM
@a1ex: I think @OlegK uses a special lens for that...
@OlegK: 1.75x horizontal stretch looks right for my eyes. Yes, you can select the factor in the clip receipt now. So each clip can have another factor here. It is also exported with the factor (png & ffmpeg export, not dng). As I wrote, we still have some bugs to fix... when we have a solution here, we will make a release.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on December 06, 2017, 10:34:54 PM
Is it a combination of anamorphic and high framerate stretch? We also need to be able to handle that together with anamorphic. I think best way is to have anamorphic ratio options: 1.33, 1.5, 1.75, 2.0, and an On/Off for additional vertical 1.67x (5:3) stretch
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 11:21:51 PM
@a1ex: I think @OlegK uses a special lens for that...
@OlegK: 1.75x horizontal stretch looks right for my eyes. Yes, you can select the factor in the clip receipt now. So each clip can have another factor here. It is also exported with the factor (png & ffmpeg export, not dng). As I wrote, we still have some bugs to fix... when we have a solution here, we will make a release.

Thanks Man! :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 11:24:10 PM
Is it a combination of anamorphic and high framerate stretch?

yes! i didn't touch it:)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 11:44:07 PM
Is it a combination of anamorphic and high framerate stretch? We also need to be able to handle that together with anamorphic. I think best way is to have anamorphic ratio options: 1.33, 1.5, 1.75, 2.0, and an On/Off for additional vertical 1.67x (5:3) stretch

If you can add 1.80X Would be cool! :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 07, 2017, 08:11:31 AM
Is it a combination of anamorphic and high framerate stretch? We also need to be able to handle that together with anamorphic. I think best way is to have anamorphic ratio options: 1.33, 1.5, 1.75, 2.0, and an On/Off for additional vertical 1.67x (5:3) stretch
Exactly that I implemented.
Edit: 1.8x is added too.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 07, 2017, 02:00:27 PM
Exactly that I implemented.
Edit: 1.8x is added too.

Now I have to wait! ;D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 07, 2017, 04:23:49 PM
Is it a combination of anamorphic and high framerate stretch? We also need to be able to handle that together with anamorphic. I think best way is to have anamorphic ratio options: 1.33, 1.5, 1.75, 2.0, and an On/Off for additional vertical 1.67x (5:3) stretch

Ilia I have no moire in your program its really good!
Is there any way to fix rolling shutter in MLV?
Thanks!


Also purple fringing
(https://thumb.ibb.co/gf7MQG/Screen_Shot_2017_12_07_at_5_27_41_PM.png) (https://ibb.co/gf7MQG)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 07, 2017, 08:39:09 PM
Would be nice to have all shoot info at the Botton like this:
(https://thumb.ibb.co/dxPPvG/Screen_Shot_2017_12_07_at_8_21_52_PM.png) (https://ibb.co/dxPPvG)

upload photos (https://imgbb.com/)


And in Footage if your WB at the moment of the shooting was 5600, when you open the file it opens with same value it was shoot, very handy. than you can change if you want, or reset to defaults. 
(https://thumb.ibb.co/iUuk2w/Screen_Shot_2017_12_07_at_8_22_03_PM.png) (https://ibb.co/iUuk2w)


If you can do "reset to default settings" for all buttons would be nice too!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 07, 2017, 09:21:57 PM
Is there any way to fix rolling shutter in MLV?
Not yet. If you know how to do (image processing)... please help...

Would be nice to have all shoot info at the Botton like this:
You can open the "Information" dialog and have it always at the side. I think that is sufficient...

And in Footage if your WB at the moment of the shooting was 5600, when you open the file it opens with same value it was shoot, very handy. than you can change if you want, or reset to defaults. 
Yeah, would be nice... but I have not found out how exactly to read that atm. When I understood the mlv header right, that won't work for automatic and custom mode.

If you can do "reset to default settings" for all buttons would be nice too!
Edit->Reset Receipt.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: goldenchild9to5 on December 07, 2017, 09:32:27 PM
Great App.. I tried it and it's awesome.  The only feature that I think it needs is a Highlight slider, if you can implement that it would be awesome.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 07, 2017, 09:52:20 PM
Great App.. I tried it and it's awesome.  The only feature that I think it needs is a Highlight slider, if you can implement that it would be awesome.
Yes, I miss it too. But how you can get that indirectly: lower exposure and raise lighten. I use that atm and I am satisfied for now :-)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on December 07, 2017, 10:51:17 PM
A lot of good ideas from @OlegK

Rolling shutter: With magic lantern we can estimate very precisely the rolling shutter interval, and if we track a few points' movement in the image, we can also figure out the (approximate) direction of movement... and in turn how much to skew the image. However that is something I'd rather do at a later stage of MLV App development (if ever.........), as it involves spatial transformations...

Great App.. I tried it and it's awesome.  The only feature that I think it needs is a Highlight slider, if you can implement that it would be awesome.
thxx... highlights are something I've been putting back, as it involves more than one pixel at a time and would be quite a big slow down, slower than the chroma blur. It is however getting closer, it will debut roughly the same time when OpenCL (GPU) processing mode is released (then everything will be really quick)... yes that's coming ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 07, 2017, 11:19:05 PM
A lot of good ideas from @OlegK

Rolling shutter: With magic lantern we can estimate very precisely the rolling shutter interval, and if we track a few points' movement in the image, we can also figure out the (approximate) direction of movement... and in turn how much to skew the image. However that is something I'd rather do at a later stage of MLV App development, as it involves spatial transformations... :-\
thxx... highlights are something I've been putting back, as it involves more than one pixel at a time and would be quite a big slow down, slower than the chroma blur. It is however getting much closer, it will debut roughly the same time when OpenCL (GPU) processing mode is released (then everything will be really quick)... yes that's coming ;)


I remember long time ago when i opened cinema dng files in Photoshop to correct them before making a video file i noticed one quality improvement over basic _-like save them as tiff and make video from them.
 When files were opened with RAW converter photoshop i changed bit from if i remember correctly 8bit to 16 bit and upscale image don't remember how much. Than i saved it and made movie from it. This way of editing DNG files make my footage look held more information, image became crisper (not sharper), like it has more resolution.
 So what do you think guys?
You can try and compare results.

I circled parameters that i changed in PS.


(http://thumb.ibb.co/kYn5Kb/Photoshop_Step_2_1_dragged.png) (http://ibb.co/kYn5Kb)

 

Also is it possible to implement it to MLV App?
Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 08, 2017, 08:03:15 AM
The whole internal processing is at 3x16bit in MLV App. If you like you also can export 16bit TIFF.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 08, 2017, 05:51:45 PM
The whole internal processing is at 3x16bit in MLV App. If you like you also can export 16bit TIFF.

Good!

What about upscale pictures before bouncing into the video?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 09, 2017, 12:18:49 PM
Upscale to any resolution you like on export.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: mesebar2 on December 09, 2017, 12:22:22 PM
Upscale to any resolution you like on export.

You guys are great!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 09, 2017, 06:38:51 PM
:) thank you @mesebar2!

Next we will change the apps code a little more, so we decided to release a version now... next version will need a little more time. So here comes v0.12:
- Support for spanned mlv
- TIFF export
- Force bilinear export
- Resize resolution on (batch) export (overrides any clip resolution)
- File error handling on import
- Horizontal and vertical stretch per clip
- Cut in & cut out
- New profile "Film"
- Auto load white balance, if mlv was filmed at sunny, shade, cloudy, thungsten, fluorescent, flash or kelvin
- MASXML saves relative path additionally, so a session can be ported easy to different computers/locations/...
- Changed single frame export to (3x)8bit PNG, so libpng & zlib is not needed anymore
- Many fixes and detail enhancements

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.12alpha

There are some known bugs and maybe you'll find some new ones ;)
Windows version will be compiled and uploaded next. Have fun!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on December 09, 2017, 07:32:19 PM
Yay. that's awesome, really glad there's finally a release to use with all the new stuff.

I also apologize to masc and whoever else for not yet finishing the AVFoundation library that will allow for slightly better quality export on macs.
Also begun on OpenCL processing, nothing to show yet.

Hopefully OlegK will be a bit satisfied with this for a bit until I release the next Cocoa App version :/
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 09, 2017, 10:39:21 PM
Yay. that's awesome, really glad there's finally a release to use with all the new stuff.

I also apologize to masc and whoever else for not yet finishing the AVFoundation library that will allow for slightly better quality export on macs.
Also begun on OpenCL processing, nothing to show yet.

Hopefully OlegK will be a bit satisfied with this for a bit until I release the next Cocoa App version :/


Thanks a lot guys! So fast!

prorez 4444 Is 8bit?

 Going to check now!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 09, 2017, 10:41:15 PM

Hopefully OlegK will be a bit satisfied with this for a bit until I release the next Cocoa App version :/

For sure! :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 09, 2017, 11:23:40 PM
prorez 4444 Is 8bit?
Who tells that? No, it is 10bit.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 09, 2017, 11:41:32 PM
Who tells that? No, it is 10bit.

Cool!.
Thanks Masc! :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 10, 2017, 01:37:13 AM
:) thank you @mesebar2!

Next we will change the apps code a little more, so we decided to release a version now... next version will need a little more time. So here comes v0.12:
- Support for spanned mlv
- TIFF export
- Force bilinear export
- Resize resolution on (batch) export (overrides any clip resolution)
- File error handling on import
- Horizontal and vertical stretch per clip
- Cut in & cut out
- New profile "Film"
- Auto load white balance, if mlv was filmed at sunny, shade, cloudy, thungsten, fluorescent, flash or kelvin
- MASXML saves relative path additionally, so a session can be ported easy to different computers/locations/...
- Changed single frame export to (3x)8bit PNG, so libpng & zlib is not needed anymore
- Many fixes and detail enhancements

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.12alpha

There are some known bugs and maybe you'll find some new ones ;)
Windows version will be compiled and uploaded next. Have fun!


Lets start from first:

The export is really long. 2 small( 16sec. and 10 sec.clips) files took like 7 min. to complete.

I was using my old iMac at home maybe thats why>.


2nd. I cannot remove small colorful dots (weird like Moire) In Slow motion 50fps like twice more of them sharpness 100% so u can really see them.

Regular 24fps:
(http://thumb.ibb.co/btJfnw/Screen_Shot_2017_12_10_at_1_59_16_AM.png) (http://ibb.co/btJfnw)


Slow 50fps:
(http://thumb.ibb.co/n1jxZb/Screen_Shot_2017_12_10_at_1_58_42_AM.png) (http://ibb.co/n1jxZb)


Without sharpness is much better but still.:(
P.S. i didn't notice them in previous build.


3rd.

 Really need 1.67x in width stretch menu.

Beside this i like this program a lot!

Questions:

When i increase file resolution on export does the quality increasing? or its just stretched video file?

What difference between Amaze and Bilinear on export?



Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 10, 2017, 01:41:24 AM
Thanks for your working, but there're some problems:
1.App crashes if choose cDNG lossless mode.
2.The edit palette is incomplete. I don't know how to adjust the width of the palette, and some contents are not shown.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 08:58:16 AM
Really need 1.67x in width stretch menu.
This aspect will be very unusual not 16:9, not even 16:10....( none of existing anamorphic lenses do these kind of squeezing). I wonder what are your settings during video recording :P

When i increase file resolution on export does the quality increasing? or its just stretched video file?
Nope just plain ffmpeg upscale without any sophisticated before/after frame processing methods.

What difference between Amaze and Bilinear on export?
I think your example pictures you posted above are bilinear ones. Try amaze, should be better.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 09:03:48 AM
@Doofii

Sorry but your feedback is "a bit" vague ;)
1. tell us it is win or mac version you are talking about
2. post the mlv which crashes during dng export

@ilia, @masc: hey am I missing something? When we implemented "edit palette"?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 10, 2017, 09:22:53 AM
@Doofii

Sorry but your feedback is "a bit" vague ;)
1. tell us it is win or mac version you are talking about
2. post the mlv which crashes during dng export

@ilia, @masc: hey am I missing something? When we implemented "edit palette"?
So sorry, it's win 10, and the MLV file is too large, I have no idea how to upload it...
As for the edit palette, maybe there's some misunderstanding.

(http://thumb.ibb.co/dFYY7w/123.png) (http://ibb.co/dFYY7w)

Some contents are not shown. Sorry for my English, and thanks for your patience.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 10, 2017, 09:57:46 AM
This aspect will be very unusual not 16:9, not even 16:10....( none of existing anamorphic lenses do these kind of squeezing). I wonder what are your settings during video recording :P

Its regular 2x lens. I am shooting in 3:2 mode. So when i choose 2x from menu i didn't  get proper image, i think its because your 2x mode works with 16:9 or 3:2 footage?
So i isn't works like its shoud:(

 Just something wrong.

1.67 i know  its wrong its what gets me final image with program.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 10, 2017, 10:03:23 AM
Lets start from first:
The export is really long. 2 small( 16sec. and 10 sec.clips) files took like 7 min. to complete.
I was using my old iMac at home maybe thats why.
The higher the resolution, the higher the quality, the slower the export. Did you ever render a video on your computer using another proggi? For me that is not way different.

2nd. I cannot remove small colorful dots (weird like Moire) In Slow motion 50fps like twice more of them sharpness 100% so u can really see them.

Without sharpness is much better but still.:(
P.S. i didn't notice them in previous build.
Nothing did change here. That is moiree. Specially in 50fps you'll get more moiree. If you use the sharpen slider you will amplify moiree.

3rd.
 Really need 1.67x in width stretch menu.
May I ask what hardware you use? I heard about 1.33, 1.5 and 2.0 lenses.

Questions:

When i increase file resolution on export does the quality increasing? or its just stretched video file?
No it won't. From where shall come the quality? You may not lose so much quality when cutting and reencoding using a cutting tool like premiere or fcpx.

What difference between Amaze and Bilinear on export?
It is the demosaic algorithm used. Mostly AMaZE looks better, but not always.

@Doofii:
You did not expand the groupboxes, so the elements are invisible. Press the triangle.
And what font do you have there?! I can't allign the program for any font used by all users... sry. If you use system standard, it should work.

For cDNG export: @bouncyball: did you have the same problem on Windows? Me not.
@Doofii: you can shorten the file using mlv_dump. Then you upload only some single megabytes.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 10, 2017, 10:05:04 AM
Its regular 2x lens. I am shooting in 3:2 mode. So when i choose 2x from menu i didn't  get proper image, i think its because your 2x mode works with 16:9 or 3:2 footage?
So i isn't works like its shoud:(

 Just something wrong.

1.67 i know  its wrong its what gets me final image with program.
If you use a 2x lens, you use 2x width stretch! And nothing else! The 3:2/16:9 mode plays no role here. Pixels have an aspect ratio of 1:1. If you use 50/60fps, you additionally need height stretch 1.67x, because here the pixel aspect ratio is 5:3.

Topic sharpness: the clips you sent me were really unsharp. Here you can't make it better using the sharpen slider. You need to focus right, or if you did, you need a sharper lens.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 10, 2017, 10:34:06 AM
If you use a 2x lens, you use 2x width stretch! And nothing else! The 3:2/16:9 mode plays no role here. Pixels have an aspect ratio of 1:1. If you use 50/60fps, you additionally need height stretch 1.67x, because here the pixel aspect ratio is 5:3.

Topic sharpness: the clips you sent me were really unsharp. Here you can't make it better using the sharpen slider. You need to focus right, or if you did, you need a sharper lens.

Whatever i don't understand what i am rtying to tell you! With whole your stretch structure i cannot get proper image in your program. the lens is 2x. and please don't tell me Lessons about focus here.

Look here anamorphic stretch works correct here: https://www.magiclantern.fm/forum/index.php?topic=18949.250
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 10, 2017, 10:39:38 AM
If you don't like the presets, you can always calculate your factors and setup export settings. You can stretch to any resolution / aspect ratio you like. (maximum is 9999x9999, hope that is enough  :D)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 10, 2017, 10:56:28 AM
If you don't like the presets, you can always calculate your factors and setup export settings. You can stretch to any resolution / aspect ratio you like. (maximum is 9999x9999, hope that is enough  :D)

Yeah thats what i did. its not big problem here.

Just thinking how to remove those dots
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 10, 2017, 11:04:07 AM
Did you try activating Chroma Separation and Chroma Blur Radius around =3 ? The color may become unsharper, bot those dots are away. And activate Playback->Use AMaZE before settings something up (preview may be slower, but quality is better).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 10, 2017, 11:22:43 AM
Did you try activating Chroma Separation and Chroma Blur Radius around =3 ? The color may become unsharper, bot those dots are away. And activate Playback->Use AMaZE before settings something up (preview may be slower, but quality is better).

I tried everything nothing seems to work.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 10, 2017, 11:24:48 AM
Has one of these two clips you sent me these artefacts? I could try here. (but don't find any artefacts)
(https://image.ibb.co/gGAMSw/M06_1261_frame_1.png)
M06_1261
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 11:48:10 AM
@masc: Doofii's right I also can not see right part of controls under win10.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 11:52:07 AM
@OlegK: I'm so eager to see your MLVs which need 1.67x horizontal stretch. Please upload originals somewhere.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 10, 2017, 11:54:51 AM
So...there's nothing to do with the font? I changed the system language to ENG and the right part is still invisible.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 11:57:19 AM
@Doofii: maybe you can shorten mlv file which crashed on dng output?

Code: [Select]
mlv_dump -f 4 -o 5frame.mlv your_input.mlv
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 10, 2017, 12:01:59 PM
I'd really like to help, but I do know nothing about the programming... That's why I use APP with GUI. Could you please specify how to use this code?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 10, 2017, 12:21:07 PM
@bouncyball: last time when we had nearly the same on Linux, the "Chroma Separation..." was to long. Is it better if you shorten this?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 12:30:33 PM
IDK really what is the issue (default standard install of the win10 without gui tweaking) but all controls are now horizontally scrollable by 2 finger touch pad gesture ;) (horizontall scroll bar is not visible tough)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 12:33:34 PM
@Doofii

This is not a code just a command which you have to run in console ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 10, 2017, 12:34:48 PM
I did it. Download link: https://pan.baidu.com/s/1i5KlQVb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 10, 2017, 12:38:18 PM
I'm not sure where should I upload the file... If you have any problems when you download the file, maybe I can e-mail you directly?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 10, 2017, 01:27:07 PM
Thx @Doofii. Got the file and program crashes on cdng lossless export (Yeay :) ). @Bouncyball : could you try the same?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 01:52:25 PM
Yes it's dual iso mlv. I'm already digging into this issue :)

Thank you Doofii.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 01:56:52 PM
Exporting to losless DNG is fine with preview dual iso mode. Crashes for full20bit mode (Real 16bit DNGs) and for losless ones only. I need more time. I think LJ92 encoder does not like something.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 05:26:58 PM
I was right. LJ92 encoder loops forever and causes buffer overflow (writes outside of buffer). I also used vanilla Baldand's encoder (we are using encoder modified a bit by g3gg0) and the same thing's happened.

For some, not known by me, reason LJ92 encoder does not like the 16bit raw data produced by dual iso processor and can not encode it properly and unfortunately I can not fix this.

This does not apply to all dualiso processed raw, because I have some dualiso footage recorded by me which encodes normally. @masc: u know this :).

@Doofii: 2 questions:

1. Do you have some other dual iso MLVs with the same issue, other scene (more light), other resolution, no high (50/60) frame rate? Give the sample.
2. Do you experience issues when exporting lossless dngs for no dual iso MLVs? If yes please give the sample.

On the other hand this is not the end of the world because you can export uncompressed DNGs and they are healthy.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 11, 2017, 02:10:02 AM
I tried various combinations of dual iso/resolution/frame rates, but none of them crashed till present moment. Probably the file I uploaded was just exceptional.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 11, 2017, 02:29:27 AM
Another clip I shot in the same palace
(http://thumb.ibb.co/ns1Dsw/234.png) (http://ibb.co/ns1Dsw)

Same camera settings, same export settings, weird...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 11, 2017, 09:16:06 AM
Yes I guess it is exceptional. Nice to have one for testing :)

Second crashed on 54% that means something is wrong with middle frame(s). Please upload these example too. Thx in advance.

Meanwhile, despite I really can not fix this issue in the Baldand's jungle ;) I'll try to handle this exception gracefully without a crash (still needs to dig to lj92 code but I can handle this without touching main algorithm)

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: canneloni on December 11, 2017, 10:23:25 AM
Had a similar problem with a specific configuration with the 100d once. I used fps overeride and 10bit lossless and it crahed. When i processed the file with mlv_dump on steroids i saw there was a frame missing somewhere in the middle, like frame 333 jumped to 335.

Maybe its the same here?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 11, 2017, 11:36:33 AM
When I'm gonna have the original MLV will be able to tell what the actual reason is :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 11, 2017, 01:38:24 PM
It seems that the APP crashes when it's exporting the 161st frame. I processed the file with mlv_dump then, but found no frame missed.
Can you give me some code so that I can upload, for example, 160-162 frame?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 11, 2017, 04:03:26 PM
I also noticed sometimes if you copy and paste attributes to another clip, it could stop playing the file at some point, when you bounce this file it bounce just the part that was playing not whole clip.


I am on Mac Sierra 10.12.6.

QTv0.12alpha
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 11, 2017, 05:25:58 PM
I also noticed sometimes if you copy and paste attributes to another clip, it could stop playing the file at some point, when you bounce this file it bounce just the part that was playing not whole clip.
Haha, sure... the cutIn/cutOut is also in the receipt. So if you copy from a shorter clip, you paste the shorter cutOut. Will think about that...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 11, 2017, 05:30:08 PM
@Doofii

Code: [Select]
mlv_dump -f 150-170 -o middle_part.mlv your_input.mlv
20 frames would be eanough.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 11, 2017, 05:30:24 PM
Let me check!

Also when I trying import MLV files mouse freeze only arrows works, the same in previous build.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 11, 2017, 05:37:31 PM
Also something weird in MLV App the bokeh looks chopped, with color fringing, None of this in Footage app.

(https://thumb.ibb.co/cANt9b/Screen_Shot_2017_12_11_at_6_33_04_PM.png) (https://ibb.co/cANt9b)


I tried my best with chroma slier  but cannot make it smooth like in Footage app.

Maybe you can add some sliders to correct this issue?
Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 11, 2017, 06:15:07 PM
You can't compare Footage, because this is completely different processing. As I understood Footage uses Apple Standard Functions / Libraries which only work on Mac (not cross platform) and which don't work with all Cameras. My 5D2 did not work at all at Footage. It may be that Apple Functions are here and there better (Apple is a little bigger than us three hobby developpers). In the end, nobody knows what Apple exactly did in this processing functions, so we can't just copy it. If you know a algorithm (best in C/C++) let us know and we add it if we can.

Also when I trying import MLV files mouse freeze only arrows works, the same in previous build.
It needs some time to parse the GigaBytes... quite normal. But we are working on another solution here.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 11, 2017, 07:59:55 PM
You can't compare Footage, because this is completely different processing. As I understood Footage uses Apple Standard Functions / Libraries which only work on Mac (not cross platform) and which don't work with all Cameras. My 5D2 did not work at all at Footage. It may be that Apple Functions are here and there better (Apple is a little bigger than us three hobby developpers). In the end, nobody knows what Apple exactly did in this processing functions, so we can't just copy it. If you know a algorithm (best in C/C++) let us know and we add it if we can.
ok got it. Can you do something in your program to improve it?
Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 12, 2017, 03:18:43 AM
@bouncyball
https://pan.baidu.com/s/1pKIx8EJ
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 12, 2017, 08:25:36 AM
@Doofii: thank you :)

@OlegK: personally I prefer amaze version of your samples. It is a LOT sharper! With lots of details. Even martinherring himself says that apple raw engine in not up to the task as he would desire and wants to replace it by something more robust.

Apple example has more saturation and I'm sure has applied the canon matrix to raw color. That's it.

You could just blur the amaze version and would get your smoother anamorphic bokeh ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 12, 2017, 08:36:10 AM
@Doofii

I exported your mlv w/o a problem. It seems that all frame are healthy. Maybe other frame is corrupted.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 12, 2017, 12:15:12 PM
@bouncyball: you remember my mlv file with missing frames I sent you? When exporting this file (lossless cdng), the missing frames end in strange corrupted dngs. Maybe on other systems this could also lead to a crash - who knows.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 12, 2017, 01:45:57 PM
Yes maybe :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: erikbaldwinson on December 14, 2017, 08:43:37 PM
When exporting 14bit lossless in MLV.App.v0.12.alpha.Win64.static every few seconds a frame is black. This is not the case in Resolve?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 14, 2017, 09:18:01 PM
A reason may be that the frames in your MLV are not in the right order. In v0.12 we did not care about this yet, what could result in black frames. Some days ago bouncyball fixed that by replacing the false frames in the right order. This will come with the next release.
With this few information you gave, I don't know if it is really this reason. Best is, if you upload some seconds of your MLV (the seconds where you get the problems), so we can debug.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: erikbaldwinson on December 15, 2017, 12:24:27 AM
A reason may be that the frames in your MLV are not in the right order. In v0.12 we did not care about this yet, what could result in black frames. Some days ago bouncyball fixed that by replacing the false frames in the right order. This will come with the next release.
With this few information you gave, I don't know if it is really this reason. Best is, if you upload some seconds of your MLV (the seconds where you get the problems), so we can debug.

https://drive.google.com/open?id=1eU2t2cCUMTy6fXudJ3F-QCUMTIsXrpzz
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 15, 2017, 12:12:39 PM
I've taken a look at your mlv (investigated with mlv_dump, it is healthy), with latest mlv app there are none of black or corrupted frames. The issue was what @masc said. Please wait for next release, use other tools for now.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: erikbaldwinson on December 16, 2017, 08:45:01 PM
I've taken a look at your mlv (investigated with mlv_dump, it is healthy), with latest mlv app there are none of black or corrupted frames. The issue was what @masc said. Please wait for next release, use other tools for now.

Thx! I used resolve with MLVFS and the results look better than the pro-res 444 output with bilinear. Maybe the Amaze option is better? I saw the bokeh problem and thought to use Bilinear.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 16, 2017, 10:08:56 PM
Thx! I used resolve with MLVFS and the results look better than the pro-res 444 output with bilinear. Maybe the Amaze option is better? I saw the bokeh problem and thought to use Bilinear.
You can't say that any way is better than another before having seen the result of the special clip. I also did many tests with bokeh clips (using my lenses), but had never an issue as OlegK - not with Resolve, not with bilinear and not with AMaZE. Watch each result and than decide which fits best for the clip! ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on December 17, 2017, 10:19:20 PM
New Cocoa App release!!! (v0.22)

Github release page (https://github.com/ilia3101/MLV-App/releases/tag/v0.22-pre-alpha-a-lot-better-edition) or go to download page (https://ilia3101.github.io/MLV-App/)

(https://user-images.githubusercontent.com/23642861/34083688-87a4b332-e36c-11e7-8ed3-c88517319c1a.png)

Highlights:
 - AVFoundation export - much faster
 - Multiple clips - saveable sessions like QtApp (compatible as well)

Issues:
 - No audio support yet (in Cocoa App)

So that no one ever has to download that 2 month old version ever again (it was painful watching the download count go up to 100) ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on December 17, 2017, 11:00:11 PM
Great work !!! I'm downloading it to make some speed tests
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on December 17, 2017, 11:15:02 PM
some random crashes at startup on el capitan but I an open it and export
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 21, 2017, 09:56:05 PM
Here comes a next release of the Qt version of MLV App with some new features:

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.13alpha
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 21, 2017, 10:13:18 PM
Fantastic Ilia, mas and Bouncyball. Will try it out as soon as possible.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 21, 2017, 11:31:22 PM
Works great. Just set export settings to av foundation and boom prores4444 comes flying out.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 23, 2017, 02:00:11 PM
Works great. Just set export settings to av foundation and boom prores4444 comes flying out.
Yeah, that is as it should be. Cool if it works.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: SoyLeo on December 23, 2017, 02:12:40 PM
I used MLRW APP before and now I love this APP, it works great ... good job  8) ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 23, 2017, 04:19:09 PM
I also tried it on my old, dusty (2008) mac mini with El Capitan (apple enlightened me that my system is so old that it's not gonna upgrade to sierra+). Works :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 23, 2017, 05:56:38 PM
This app is getting so good. Just tried the cinema dng export feature. Question. How do I select different bits output? For instance 14bit from 10bit etc? Maybe not implemented? AV foundation ProRes4444 files are golden.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 23, 2017, 06:38:36 PM
True @Danne, found this one yesterday and started experimenting with it. Right away I just processed a MLV and found white balance too blue for starting a starting point to color correct. Corrected it with CameraRAW. Do you know why?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 23, 2017, 07:24:13 PM
White balance will be applied according to either what your camera kelvin is set to or what wb mode you are working with. Watch out for using AWB(auto white balance) since MLV will instead read whatever kelvin your camera is set to when recording.
Short answer. Use any white balance mode but AWB if you want to use white balance from camera.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 23, 2017, 07:42:17 PM
White balance will be applied according to either what your camera kelvin is set to or what wb mode you are working with. Watch out for using AWB(auto white balance) since MLV will instead read whatever kelvin your camera is set to when recording.
Short answer. Use any white balance mode but AWB if you want to use white balance from camera.

Oooh! Get it! All scenes were filmed using AWB. Thought it will not make any change when using RAW. Thanks for the info! Color corrected it, so amazing to see what RAW can do thanks to all the color data available.

Can you help me with this? First DNG frame recognize all camera color profiles using ACR, color corrected it nicely, but all of the rest (400 or so frames) goes dark when applying Syn Settings. Found that on all of the rest DNGs there is no selection available for Camera Profile section, just Embedded. And thats the problem. How can I let ACR be able to see all Camera Profiles normally? This is the first time I see this irregularity.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 23, 2017, 07:50:51 PM
OK!

(http://i64.tinypic.com/rkdkjt.png)

Not OK!

(http://i64.tinypic.com/j0k2v5.png)

As you may note, Camera Profile is set to Embedded and can't change it because there is no list.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 23, 2017, 08:19:30 PM
Could be something related to the name. Look at the first file and the look at the next one. They should all be named to their "unique camera model" name(5D mark III) in this case. Did you develop your dng files with MLV app? If so upload a dng file here.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 23, 2017, 08:44:42 PM
Yes, used MLV App with codec Cinema DNGUncompressed . Here are the first 12 DNG sequence with .xmp color correction file (used VisionLOG) if want to use it...

https://we.tl/GYnF2r9XKZ

Really appreciate your help! Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 23, 2017, 08:52:49 PM
Only the first file seems to have the correct name tag then it goes into this:
Code: [Select]
Unique Camera Model             : Canon EOS 5D Mark III????????????۸.A bug. I´m sure Bouncyball will check into it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 23, 2017, 08:56:26 PM
So, it is a bug with MLV App at the moment of processing?  ???
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 23, 2017, 09:01:07 PM
Yes. Meanwhile you could work with for instance batch mlv. It uses the same mlv_dump from bouncyball as in Mlv app.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 23, 2017, 10:39:22 PM
Is it possible to upload the MLV which causes this problem? I tried with some of my MLVs and this does not happen.
Edit: is your rar archive corrupted? I tried to unpack with 3 different proggis... no success. But the MLV would be more interesting for us.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: reddeercity on December 24, 2017, 06:33:20 AM
@JADURCA this is how to my knowledge arc (viva A.E.) works -- it save changes to the first dng then applies the changes to the rest of your video file or image sequence (e.g. Tiff , PNG , MOV. etc...) I just check your dng's and there no problem with camera raw profiles , all where there to be selected . Test on Win 7 Pro With CS6 After Effects , didn't have 5d3 VisionLOG profile to check only have one for 5d2 . So you want Cdng that are W/B & color corrected from ACR/Camera Raw ? Any reason why ? tiff or PNG not good enough or I'm I missing something here .

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 24, 2017, 03:43:25 PM
@Danne

This app is getting so good. Just tried the cinema dng export feature. Question. How do I select different bits output? For instance 14bit from 10bit etc? Maybe not implemented?
You can't :), the output Bit depth always matched to input Bit depth. MLV App does not support bit depth conversion. I think it is pointless.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 24, 2017, 03:50:30 PM
Is it possible to upload the MLV which causes this problem? I tried with some of my MLVs and this does not happen.
+1. Please upload MLV.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 24, 2017, 04:45:49 PM
Only the first file seems to have the correct name tag then it goes into this:
Code: [Select]
Unique Camera Model             : Canon EOS 5D Mark III????????????۸.A bug. I´m sure Bouncyball will check into it.
Hmm... until today this same code served for Switch (trought mlv_dump on steroids) and MLV App without problem, IDK why it happened in this case but I did some changes to make sure the "Unique Name" always zero terminated after last symbol.

Still waiting for sample MLV ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 24, 2017, 05:13:00 PM
Hi guys! I'm uploading MLV right away. Takes a few minutes. Uploading...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 24, 2017, 05:27:53 PM
@JADURCA this is how to my knowledge arc (viva A.E.) works -- it save changes to the first dng then applies the changes to the rest of your video file or image sequence (e.g. Tiff , PNG , MOV. etc...) I just check your dng's and there no problem with camera raw profiles , all where there to be selected . Test on Win 7 Pro With CS6 After Effects , didn't have 5d3 VisionLOG profile to check only have one for 5d2 . So you want Cdng that are W/B & color corrected from ACR/Camera Raw ? Any reason why ? tiff or PNG not good enough or I'm I missing something here .

I'm uploading MLV and VisionLOG camera profile (for like 23 cameras) at the same time, so, if you still have color correction .xmp I uploaded yesterday, then you can use it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 24, 2017, 05:58:52 PM
MLV and VisionLOG => https://we.tl/6dZHdVwnzM
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 24, 2017, 07:58:52 PM
@Danne
Can not reproduce this:
Code: [Select]
Unique Camera Model             : Canon EOS 5D Mark III????????????۸.Used MLV App 0.13 to export DNGs. First and all consecutive frames are fine regarding this tag.
Could it be that ACR screws up all consecutive files? I'm on Linux now and can not run AE.

@JADURCA
This kind of issue been reported by MLVFS users when there was a bug in there and XMP could not be written to the virtual folder. As I understand you use physical DNGs on the HDD and that's why it's strange. When you feed ACR/AE with DNGs telling that it's a sequence of frames, everything should be fine and XMP made for 1st frame have to be used for other remaining ones.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 24, 2017, 08:21:48 PM
Also tested exporting Jadurcas clip in Mlv app but coud not reproduce the issue either.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 24, 2017, 08:42:52 PM
@Danne: OK thx. I changed the code anyway ;), now it is more reliable.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on December 24, 2017, 08:59:46 PM
Confirmed @JADURCA’s MLV works like normal and unable to reproduce either. Still a wonderful upgrade to this app and yet it just keeps on getting better. A true version of ‘never ending story’ no pen intended.

Also found a bunch of interesting things within this app especially w lossless Dual-ISO stuff (even tho it isn’t intended to be useful atm) but hey I can’t help myself not refrain from using this fun feature especially in 2.8K from a 5D3 regardless.

Will report my findings and ideas when I can. Thanks again for making this possible for all of us in here!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: reddeercity on December 25, 2017, 06:41:10 AM
@JADURCA I downloaded your mlv file and tested it on my win7 laptop -- a few things I noticed .
I used mlvproducer to extract the cdng to if it's a issue with MLV App. and I thing so .
In a nut shell ,  both Cdng give access to the Vision Log in ACR thou A.E. , but the mlv app Cdng's do not keep the changes in the timeline (camera raw profile & lens correction) see screen shots below.
See the Red hi-lighted boxes
(https://farm5.staticflickr.com/4739/39276171291_fb2698267f_z.jpg) (https://flic.kr/p/22QGDn6)
MLV_App_CS6_AE_CamRaw_Profile_Vision_log_fails (https://flic.kr/p/22QGDn6) by RedDeerCityTV (https://www.flickr.com/photos/67942440@N06/), on Flickr
Cdng's from mlvproducer keep the changes see below
(https://farm5.staticflickr.com/4647/38399373775_cb48434900_z.jpg) (https://flic.kr/p/21vdQ1x)
MLVPro_CS6_AE_CamRaw_Profile_Vision_log_TimeLine (https://flic.kr/p/21vdQ1x) by RedDeerCityTV (https://www.flickr.com/photos/67942440@N06/), on Flickr

I think it may be this 
Code: [Select]
Unique Camera Model             : Canon EOS 5D Mark III≈  τ≈  σ≈  α█╕.this is not in the Cdng from mlvproducer  , even the Exif info is really different between the two see below
Cdng from MLP App
Code: [Select]
ExifTool Version Number         : 10.02
File Name                       : M17-1643_000003.dng
Directory                       : C:/Users/i5Dell/Downloads/exiftool-10.02
File Size                       : 2.6 MB
File Modification Date/Time     : 2017:12:23 12:28:44-07:00
File Access Date/Time           : 2017:12:24 17:19:08-07:00
File Creation Date/Time         : 2017:12:24 17:19:08-07:00
File Permissions                : rw-rw-rw-
File Type                       : DNG
File Type Extension             : dng
MIME Type                       : image/x-adobe-dng
Exif Byte Order                 : Little-endian (Intel, II)
Subfile Type                    : Full-resolution Image
Image Width                     : 1920
Image Height                    : 800
Bits Per Sample                 : 14
Compression                     : Uncompressed
Photometric Interpretation      : Color Filter Array
Fill Order                      : Normal
Make                            : Canon
Camera Model Name               : Canon EOS 5D Mark III
Strip Offsets                   : 1208
Orientation                     : Horizontal (normal)
Samples Per Pixel               : 1
Rows Per Strip                  : 800
Strip Byte Counts               : 2688000
Planar Configuration            : Chunky
Software                        : MLV App
Modify Date                     : 2017:12:17 16:43:28
CFA Repeat Pattern Dim          : 2 2
CFA Pattern 2                   : 0 1 1 2
Exposure Time                   : 1/143
F Number                        : 7.0
ISO                             : 100
Sensitivity Type                : ISO Speed
Exif Version                    : 0230
Subject Distance                : 524 m
Focal Length                    : 24.0 mm
Focal Plane X Resolution        : 48.67290288
Focal Plane Y Resolution        : 48.67290288
Focal Plane Resolution Unit     : inches
Lens Model                      : EF24-105mm f/4L IS USM
DNG Version                     : 1.4.0.0
Unique Camera Model             : Canon EOS 5D Mark III≈  τ≈  σ≈  α█╕.
Black Level                     : 2047
White Level                     : 16200
Default Scale                   : 1 1
Default Crop Origin             : 0 0
Default Crop Size               : 1920 800
Color Matrix 1                  : 0.7234 -0.1413 -0.06 -0.3631 1.115 0.285 -0.03
82 0.1335 0.6437
Color Matrix 2                  : 0.6722 -0.0635 -0.0963 -0.4287 1.246 0.2028 -0
.0908 0.2162 0.5668
As Shot Neutral                 : 0.7939645987 1 0.3541823983
Baseline Exposure               : 0
Camera Serial Number            : 2CB548B5FE
Calibration Illuminant 1        : Standard Light A
Calibration Illuminant 2        : D65
Active Area                     : 0 0 800 1920
Forward Matrix 1                : 0.7868 0.0092 0.1683 0.2291 0.8615 -0.0906 0.0
027 -0.4752 1.2976
Forward Matrix 2                : 0.7637 0.0805 0.1201 0.2649 0.9179 -0.1828 0.0
137 -0.2456 1.057
Time Codes                      : 00:00:07.16
Frame Rate                      : 59.94
Reel Name                       : M17-1643
Baseline Exposure Offset        : 0
Aperture                        : 7.0
CFA Pattern                     : [Red,Green][Green,Blue]
Image Size                      : 1920x800
Megapixels                      : 1.5
Shutter Speed                   : 1/143
Focal Length                    : 24.0 mm
Light Value                     : 12.8

Cdng from MLVProducer
Code: [Select]
ExifTool Version Number         : 10.02
File Name                       : M17-1643_00000.dng
Directory                       : C:/Users/i5Dell/Downloads/exiftool-10.02
File Size                       : 2.9 MB
File Modification Date/Time     : 2017:12:24 16:22:41-07:00
File Access Date/Time           : 2017:12:24 16:45:10-07:00
File Creation Date/Time         : 2017:12:24 16:45:10-07:00
File Permissions                : rw-rw-rw-
File Type                       : DNG
File Type Extension             : dng
MIME Type                       : image/x-adobe-dng
Exif Byte Order                 : Little-endian (Intel, II)
Subfile Type                    : Full-resolution Image
Image Width                     : 1920
Image Height                    : 800
Bits Per Sample                 : 16
Compression                     : Uncompressed
Photometric Interpretation      : Color Filter Array
Make                            : Canon
Camera Model Name               : Canon EOS 5D Mark III
Strip Offsets                   : 1016
Orientation                     : Horizontal (normal)
Samples Per Pixel               : 1
Rows Per Strip                  : 800
Strip Byte Counts               : 3072000
Planar Configuration            : Chunky
Software                        : MLVProducer
Artist                          : noname
Sample Format                   : Unsigned
CFA Repeat Pattern Dim          : 2 2
CFA Pattern 2                   : 0 1 1 2
Copyright                       : noname
Date/Time Original              :
Lens Model                      : EF24-105mm f/4L IS USM
DNG Version                     : 1.4.0.0
Unique Camera Model             : Canon EOS 5D Mark III
CFA Plane Color                 : Red,Green,Blue
CFA Layout                      : Rectangular
Black Level Repeat Dim          : 1 1
Black Level                     : 2047
White Level                     : 9153
Default Scale                   : 1 1
Default Crop Origin             : 0 0
Default Crop Size               : 1920 800
Color Matrix 1                  : 0.5852 -0.0578 -0.0041 -0.4691 1.1696 0.3427 -
0.0886 0.2323 0.6879
Color Matrix 2                  : 0.492 0.0616 -0.0593 -0.6493 1.3964 0.2784 -0.
1774 0.3178 0.7005
As Shot Neutral                 : 461 795 471
Baseline Exposure               : undef
Bayer Green Split               : 0
Active Area                     : 0 0 800 1920
Forward Matrix 1                : 0.8716 -0.0692 0.1618 0.3408 0.8077 -0.1486 -0
.0013 -0.6583 1.4847
Forward Matrix 2                : 0.9485 -0.115 0.1308 0.4313 0.7807 -0.212 0.02
93 -0.2826 1.0785
Time Codes                      : 00:00:00.00
Frame Rate                      : 59.939
Reel Name                       : M17-1643
Warning                         : Bad IFD1 directory
CFA Pattern                     : [Red,Green][Green,Blue]
Image Size                      : 1920x800
Megapixels                      : 1.5

notice the Color Matrix  are different  between the two app's  , I do see mlv app is exporting the cdng as 14bit instead of 16bit (could that be a issue ?) shouldn't I wouldn't  think.

I though this was odd , the W/B in win7 file explorer is way off from mlv app Vs. mlvproducer (from left to right mlvproducer then mlv app)
(https://farm5.staticflickr.com/4592/38568813434_152a63ab75_b.jpg) (https://flic.kr/p/21LcfvY)
mlvpro_Vs_mlvapp_wb (https://flic.kr/p/21LcfvY) by RedDeerCityTV (https://www.flickr.com/photos/67942440@N06/), on Flickr

but importing in A.E. is not a problem as it show correct W/B , I did notice "as shot" w/b from mlv app was at 4200k and the one from mlvproducer was 5200k , thought that was odd.
Is all this a problem with decoding lossless compression ? Also I wondering do you really need "Unique Camera Mode" the only time I seen this being use in the Band Software Raw Magic , in Mac OSX .
with out that tag some cams like the 5d2 are pink cast in mac finder (black level is hard coded to 2048 & 5d2 has black level of 1792)
Seems there is a lot of extra tags are there all necessary ?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 25, 2017, 08:31:03 AM
@reddeercity

Hey thank you for taking time and writing up all these. You did what I wanted to do long time ago - compare mlvp and mlvfs/mlvapp cdng headers :). Can you also test DNG files produced by MLVFS? Then we'll have 3 way comparison.

Indeed mlvp has strange white level (9153, not taken from MLV, seems edited in mlvp), very different color/forward matrixes and unusual "as shot neutral" (this MLV recorded in ABW mode and MLV has no real kelvin value, so setting WB is up to processing software).

Also if you did not notice yet it is not a real 16bit dng, the raw data values just bit unpacked to 16 bits and saved as is (like MLVFS does for speed's sake). Also black level is not hardcoded to 2048, in both cases it is taken from MLV (2047).

What puzzles me why preset is saved in mlvp case, which tag is responsible for this behavior.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 25, 2017, 10:58:06 AM
Answering #706
Mlv producer is using color matrices from eos 50D. That will most certainly screw with color accuracy for the 5D mark III.
Unique Camera Model is essential for acr and dcp profiling.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on December 25, 2017, 03:28:36 PM
Hi, Masc, ilia, bouncyball, Merry Xmas to you all. Noticed a bug when i try to export, using apple AV Foundation, it crashes when i hit the export button, although for some strange reason it always seems to crash when i hit export for the first time, then i re-boot the app, and it seems not to crash after that, only sometimes..

Here's the crash report https://www.dropbox.com/s/s4mvlijbb72toch/crash%20report%200.13%20mlv%20app.rtf?dl=0
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 25, 2017, 04:18:03 PM
@DeafEyeJedi

Will report my findings and ideas when I can. Thanks again for making this possible for all of us in here!
Thanks for your feedback as per usual :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 25, 2017, 07:00:44 PM
Hi, Masc, ilia, bouncyball, Merry Xmas to you all. Noticed a bug when i try to export, using apple AV Foundation, it crashes when i hit the export button, although for some strange reason it always seems to crash when i hit export for the first time, then i re-boot the app, and it seems not to crash after that, only sometimes..

Here's the crash report https://www.dropbox.com/s/s4mvlijbb72toch/crash%20report%200.13%20mlv%20app.rtf?dl=0
Merry xmas!
Please be exact and write more information. The report tells, that the app crashed while building a frame. This does not happen when pressing the export button, that happens between filedialog and export ready. Then: what format did you export, there are 3 AVFoundation formats. The MLV which causes the problem would also be a nice to have for debugging.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on December 26, 2017, 03:29:29 PM
Hi Masc, sorry yes i should have been more precise and informative and less vague, my bad.

I applied minimal corrections (just sharpening and added alexa log c) then i click on export, screen comes up with save as (file name), and where to (desktop etc), then i click on save to start export and it crashes.

Using apple AV Foundation apple prores 4444, and AMAZE Debayer, what is weird though, is that it always crashes, when i first open the app and run my first export ALWAYS, i restart the app and sometimes then the export starts and it’s ok, other times it will crash again, i took the liberty of downloading JADURCA’s MLV upload https://we.tl/6dZHdVwnzM to see if the same thing happens with that MLV and i can confirm, it does, crash on trying to export, then i re-launch the app, and it renders export fine,

Using macOS High Sierra 10.13.2 Macbook pro late 2016

Using JADURCAS MLV (as it's already uploaded for you to test) First time it crashed, re launched app, it worked and started writing export file. third time tried, crashed again, hope this helps..

PS great work guys this is now (in my humble opinion) the go to, must have MLV app for every Magic Lantern user, the progress has been phenomenal.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 26, 2017, 04:45:29 PM
Thanks a lot for the information and the nice words.
Does it even crash when you have just one MLV to export, or does it happen for batch? Do you load/save sessions, or just import -> adjustments -> export?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 26, 2017, 04:52:10 PM
Indeed, pro app.
Suggestion. Make a screenrecording of your workflow to show exactly what steps are causing the crashes.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 26, 2017, 05:10:41 PM
Okay... I think I have it. Got the crash now too and can debug.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on December 26, 2017, 05:19:47 PM
Yes the latest test i did using jadurca’s mlv (easy for you all to download), just one mlv exported no sessions loaded or saved, import -> adjustments -> export. i even just loaded that one clip into the app, same crash. As danne suggested here’s a video. https://www.dropbox.com/s/edhkq951lwfqeap/mlv%20app%20crash.mp4?dl=0 Hope this helps. PS well since as you got the same crash to masc, you probably dont need this now, hahaha.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 26, 2017, 09:38:57 PM
Thanks, yes that is the same I got the crash now to... but only each 4th or 5th try, but it happens. I also think I found the reason why, but I have to clearify with Ilia, because I don't understand the code 100% there.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: domasa on December 29, 2017, 06:22:24 PM
Please, can you add more key shortcuts?
I used this key shortcut in unsupported application  MlRawViewer:
- Cut In/Out (e. g. Shift+I/Shift+O when 'I' is used for Info)
- go to previous/next video (e. g. K / J)

- delete selected video from session (e. g. Del)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 29, 2017, 10:26:34 PM
Please, can you add more key shortcuts?
Sure...
I used this key shortcut in unsupported application  MlRawViewer:
- Cut In/Out (e. g. Shift+I/Shift+O when 'I' is used for Info)
- go to previous/next video (e. g. K / J)
- delete selected video from session (e. g. Del)
Done.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: domasa on December 30, 2017, 12:37:49 AM
Thx! I will download next alpha version.

Quote
- delete selected video from session (e. g. Del)
When I delete some video, first video is always selected. It will be better select next video with nereast index ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on December 30, 2017, 10:30:25 AM
A few requests, mostly stuff that are present on mlrawviewer:

1) Total time (min:sec:frame?) just beside the total frame count on the bottom

2) Smooth realtime playback.

3) Basic lut for colorspace (c-log, rec etc etc.) and importing of new ones if you really want to.

4) Better handling of hotpixels? I've tested it in a rush and I could still see some.

Thanks a lot for the development, mlrawviewer is too buggy and a fresh alternative is really appreciated.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 30, 2017, 10:37:45 AM
1) Total time (min:sec:frame?) just beside the total frame count on the bottom
Doable

2) Smooth realtime playback.
Not so easy to implement, needs rewriting all of the processing.

3) Basic lut for colorspace (c-log, rec etc etc.) and importing of new ones if you really want to.
Doable

4) Better handling of hotpixels? I've tested it in a rush and I could still see some.
Please upload sample MLV

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on December 30, 2017, 11:18:35 AM
Oh, I wonder how it was done on mlrw, preview it's an important thing but I guess it's still usable at 5-8 fps.

I'll upload a couple of MLV asap!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on December 30, 2017, 11:20:09 AM
More colour space functionality soon with AVFoundation (rec2020 wink wink reddeercity) add maybe with FFMpeg too.

Also playback is already realtime if your CPU is > 6 GHz :D
But incase it isn't, an OpenCL GPU processing mode is coming (!!!)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 30, 2017, 11:53:32 AM
When I delete some video, first video is always selected. It will be better select next video with nereast index ;)
Was already done.

Oh, I wonder how it was done on mlrw, preview it's an important thing but I guess it's still usable at 5-8 fps.
So slow?! On my 8 years old Core2Duo MacBook I get something between 10-12 fps with v0.13... that looks not so bad...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on December 30, 2017, 11:58:46 AM
I have a mbpr 2.3 i7, it's not the best but it should be able to handle something okeish!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 30, 2017, 12:05:24 PM
What??? That should be way faster! Have you found the caching option? Let it cache until it says "Idle" again and then play. You should get around 15 frames with an i7!!!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on December 30, 2017, 05:55:37 PM
I updated my tutorial for compiling  MLV-App in Linux openSUSE (german version).:
https://seescho.wordpress.com/fotos/ml/
An updated english version will follow soon.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 30, 2017, 06:37:19 PM
@escho: COOL! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Dmytro_ua on December 30, 2017, 07:11:23 PM
Wow! This app looks so promising!
I'm wondering, is it possible to implement different fps playback function? For example, I have 50-60fps footage, but I'd like to preview it at 25fps (in slow motion). It would be great to have some options like:
- native fps (as it is now)
- custom fps (speed playback options)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on December 30, 2017, 10:43:37 PM
What??? That should be way faster! Have you found the caching option? Let it cache until it says "Idle" again and then play. You should get around 15 frames with an i7!!!

I don't know what to say. I'll try with different drives.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Dmytro_ua on December 30, 2017, 11:03:16 PM
I have 10-15fps on my working i7 desktop. There is great realtime preview on MlRawViewer even on my old notebook.

p.s.
I've found a bug. All my footage stops on 354 frame. Will try different footage to get more information.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 31, 2017, 11:36:34 AM
Guys like I said I wish we could play video in real time BUT...

MLRawViewer uses pure OpenGL engine for debayer, basic tonmapping and color balancing (and there is none of more sophisticated processing like denoise, etc)

We use CPU engine for all of these.

We did some experiments with OpenCL debayer and now @Ilia3101 experimenting with OpenCL processing (and I guess bilinear OpenCL demosaic).

It is pointless to debayer with OpenGL/OpenCL and then color process with CPU. Technically as OpenGL is by far different than CPU coding it is hard to use for complicated graphics processing. That is why all in one OpenCL (not OpenGL) pipeline is our choice and it needs lots of time to understand ;), implement and tune.

@Dmytro_ua
The FPS override is implemented long time ago and is accessible via export settings "fps override" and It works for playback too.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 31, 2017, 11:44:36 AM
I've found a bug. All my footage stops on 354 frame. Will try different footage to get more information.
Please collaborate more on this (what is your OS, which - 32 or 64 bit version of MLV App you use) and upload some affecting MLVs to check.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on December 31, 2017, 12:19:08 PM
MLV-App: Compiling for Linux openSUSE
I just finished the english version of my tutorial:
https://seescho.wordpress.com/tutorial-englisch/
I hope, I didn´t forget to much...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 31, 2017, 12:50:40 PM
Wow! This app looks so promising!
I'm wondering, is it possible to implement different fps playback function? For example, I have 50-60fps footage, but I'd like to preview it at 25fps (in slow motion). It would be great to have some options like:
- native fps (as it is now)
- custom fps (speed playback options)
This is implemented. Go to export settings and set fps override. That also works for playback.

MLV-App: Compiling for Linux openSUSE
I just finished the english version of my tutorial:
https://seescho.wordpress.com/tutorial-englisch/
I hope, I didn´t forget to much...
Thank you! :)

And... funny: on none of my computers MlRawViewer feels faster as MLV App... am I doing something wrong?! How do you get it so fast?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 31, 2017, 02:40:17 PM
I hope, I didn´t forget to much...
Small correction ;)

Code: [Select]
cdng (up to 16bit, lossless or uncompressed)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 31, 2017, 02:50:11 PM
And... funny: on none of my computers MlRawViewer feels faster as MLV App... am I doing something wrong?! How do you get it so fast?
MLV App feels very snappy in all aspects except REAL realtime playback ;)

In the beginning I was also eager to implement the same shaders as in mlrawviewer (even have draft concept using QT openGL somewhere on hdd at my work) but then droped this because our goal is different (add more processing features in the future and it would be very hard to do in opengl shaders) hence it should be implemented differently. I did not say it's easy to do this in OpenCL :P, but it's better and future proof.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 31, 2017, 03:31:51 PM
Previewer is more than good enough for what it does imo. Even get 8fps on my macbook air  1.6 cpu and around 15-17fps on my macbook pro.
(https://s18.postimg.org/s5g9607xl/Ska_rmavbild_2017-12-31_kl._15.30.11.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 31, 2017, 03:32:16 PM
Hm, but MlRawViewer is far away from real realtime as well. I would say MLRV bilinear = MLVAPP AMaZE cached and MLRV AMaZE = MLVAPP bilinear in terms of speed on all of my systems, no matter if Win or OSX.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on December 31, 2017, 04:38:08 PM
Thanks a lot escho!

Speaking of real time playback... very soon there will be another upgrade to CPU processing performance, so maybe real time playback :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Dmytro_ua on December 31, 2017, 04:41:12 PM
Don't you think it is possible to lower playback resolution to make it more realtime?

All my footage stops on 354 frame. Will try different footage to get more information.

Never mind. It was footage from some early (summer) experimental builds. Installed the latest build and playback works fine.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 31, 2017, 10:12:58 PM
I don't know what to say. I'll try with different drives.

@togg, I believe that what @masc is telling you to wait until 'Caching' status changes from "active" to "idle" when changing 'Debayer for preview' option. Check screenshot below.

(http://i66.tinypic.com/suya0i.jpg)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 31, 2017, 10:40:28 PM
@JADURCA this is how to my knowledge arc (viva A.E.) works -- it save changes to the first dng then applies the changes to the rest of your video file or image sequence (e.g. Tiff , PNG , MOV. etc...) I just check your dng's and there no problem with camera raw profiles , all where there to be selected . Test on Win 7 Pro With CS6 After Effects , didn't have 5d3 VisionLOG profile to check only have one for 5d2 . So you want Cdng that are W/B & color corrected from ACR/Camera Raw ? Any reason why ? tiff or PNG not good enough or I'm I missing something here .

It's all about using all the data available with RAW to color correct at it best. So much latitude for intense correction before image breaks, then when finish color correcting I process all images using just .JPEG at 12 quality setting. I once tested and compared image sequences quality pixels using JPEG, Tiff, PNG and even PSD using the same image. Found that there was no difference when using JPEG with all the others regarding pixel quality, just the storage space each one finally takes and performance (JPEG take less Memory from your video editor). JPEG was a clear winner for me, only thing is that if you want to make major adjustments then you better go back to DNG's and make corrections using ACR and process again.

Here's an footage (where it was possible to recover the sky details and three guys there where almots dark) from a music video project I'm working right now. Workflow: MLV, Extracted using MLV App, DNG's color corrected using (VisionLOG profile) with ACR, saved using JPEG 8-bit 12 quality setting and final rendering using H.264 with Sony Vegas.

https://we.tl/jF2BvBW0DV
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on January 01, 2018, 10:43:01 AM
Small correction ;)

Code: [Select]
cdng (up to 16bit, lossless or uncompressed)

Changed it. Thank You! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on January 01, 2018, 12:37:23 PM
@reddeercity A tip for getting better results in MLV App: use profile "tonemapped" - I can see there is some harsh clipping in the image you posted, on his hat for example. Makes it look like it was shot on a Sony.
@masc What do you think of making it default profile? I think it looks better on 97% of images. (Edit: didn't we already do this? Default seems to be standard for me on every version I open so I might be going insane)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 01, 2018, 01:08:58 PM
@masc What do you think of making it default profile? I think it looks better on 97% of images. (Edit: didn't we already do this? Default seems to be standard for me on every version I open so I might be going insane)
Tonmapped is the default profile. You'll see when importing a file.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on January 01, 2018, 01:11:38 PM
Ah nevermind :D Remembered couple minutes after I wrote the post (thought it was a sierra bug at one point). Going to be using the app a lot today.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on January 01, 2018, 04:16:30 PM
@escho: :D

@masc: can't you really get realtime playback in mlrawviewer? I can get realtime+ at 3k w/o problem (windows, linux, never tried it on mac) on all of my available PCs/NBs. Bilinear is always realtime, amaze is CPU (same as in mlv app), hence lags quite a bit.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on January 02, 2018, 08:07:21 PM
Hello everyone,

I'd like to know if we can add the H264 proxy workflow that already exists on Danne's switch software ? It allows you "to start to before the MLV files are processed. There's an option in Switch that allows you to trim the H.264 proxies without having to process the MLV files. While not as fast as simply copying the files off the card, it does cut down the wait time between shooting and editing. As an example, on a day that I shot 51 clips totaling 31.5 minutes it took only 17.5 minutes to trim the H.264 proxies compared to processing the MLV files to DNGs which took 4 hours. Yes, you can also use MLVFS or whatever other post workflow you want, just remember that the audio must be extracted from the H.264 proxies and Switch does that for you." (cf. Dfort Reply #314 on Switch Thread). Then, you edit with h264 with audio and make a conformation after your edit to relink to the original MLV for color grading in resolve (in addition to MLVFS).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 02, 2018, 09:29:18 PM
Hi, no sry. ATM we still do nothing with H264 Proxys. You only can open MLVs and look at them, cut them and build new proxies. With the same cut settings but processed, you export ProRes or whatever then and exchange the files in FCPX or whatever you use. A workflow can be then:
1. Open files in MLVApp, sort out bad ones (delete them).
2. Create proxys
3. Cut in FCPX, Premiere, ...
4. Color-Correct MLVs in MLVApp
5. Export ProRes4444
6. Relink files in FCPX,...
7. Export final video
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on January 02, 2018, 09:41:01 PM
Thank you for the reply Masc. I often use your workflow for small personal projects but that takes too much time and process for a pro indy workflow. I love your app but most of the time I need h264 proxy workflow. I keep it for playback and hope for realtime soon ;-)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on January 04, 2018, 04:09:07 PM
How do you guys process dual iso mlv's? I click the "on" button on the dual iso tab but the end files still have lines.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 04, 2018, 08:33:17 PM
Yeah... just switch it on and all should be fine. Can you upload the file (at least some frames of it)? So we could analyse what is going wrong. What was the setting used, and on what camera? Are you on Win/OSX/Linux?
Title: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on January 05, 2018, 12:01:51 AM
Hello ilia3101 and masc,
Do you think it’s possible to implement an antialiasing script like the one used by danne and the one used by a1ex? A lot of people there doesn’t have money to pay a vaf-filter, so it can be a good alternative to process it and then export from mlv free of aliasing to ProRes.

Edit :  it can also allow us to check the before/after in real-time for more accurate comparison

Envoyé de mon iPhone en utilisant Tapatalk
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 05, 2018, 05:13:43 PM
Hello ilia3101 and masc,
Do you think it’s possible to implement an antialiasing script like the one used by danne and the one used by a1ex? A lot of people there doesn’t have money to pay a vaf-filter, so it can be a good alternative to process it and then export from mlv free of aliasing to ProRes.

Edit :  it can also allow us to check the before/after in real-time for more accurate comparison

I can't tell you, if we can implement that, because it is the first time I have heard about antialiasing in SW here. Do you or does anyone else (@Danne?!) have/has more information? That sounds interesting... Or is it just this ffmpeg antialiasing? Then we can't show it in realtime and can't export to "real" prores.
The best algorithm I knew until now is AMaZE against moiree: not perfect, but way better than most others...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on January 05, 2018, 05:46:18 PM
A work in progress :)
http://www.magiclantern.fm/forum/index.php?topic=21089.msg193622#msg193622
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on January 05, 2018, 06:10:48 PM
How do you guys process dual iso mlv's? I click the "on" button on the dual iso tab but the end files still have lines.
Let me guess, you exported DNGs as "fast pass".
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 05, 2018, 06:37:39 PM
A work in progress :)
http://www.magiclantern.fm/forum/index.php?topic=21089.msg193622#msg193622
Ah okay, that was this story, I remember. Is there a way to use this with pipes or something like that? ATM I am happy that we don't need temp files. Using these programs would make a big mess again. Do you see a possibility?!  ;D
What you could do: combine the two solutions: take MLV App first to get AMaZE debayered TIFF and then take (a part of) the script fullfilling the antialiasing. That should bring nice results!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on January 06, 2018, 08:28:49 AM
Using these programs would make a big mess again. Do you see a possibility?!  ;D
To avoid using external programs, the optical flow should be implemented into the mlv app processing. Ilia! Where are you? :P

Enfuse/hugin align_image_stack approach proposed by Danne as an aliasing cure is a bit different but indeed gives very clean results.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on January 06, 2018, 06:37:26 PM
Debayered tiffs and using the script in post of course if not using  integrated code like optical flow is my opinion :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on January 06, 2018, 08:27:11 PM
Yeah, Danne's script is pretty straightforward and gives nice result. It could be a good implementation on MLV app. Even if you have VAF-filter, in certain cases it's not enough. Indeed, with wide lenses, VAF-filter doesn't work (they will update their filters this year) and the VAF is bluring the picture. With the next version, it will be sharp but hey, it's still very expansive. An all in one post-solution is a good alternative especially for cheap cameras
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 06, 2018, 08:59:42 PM
I agree with bouncyball and Danne: if we want a nice solution (with preview, without memory mess, without external programs which always bring problems,...) we only can implement a in-program-solution. This means implementing optical flow and aligning... yeah... if there is someone out there who can help with that... we are here and waiting for you! ;)

Btw: how good is the script solution working with moving objects and wide angle?! I always have big problems when using optical flow for slowmotion with my clips - that nearly never works (brings missing or double objects flimmering in the clip; tested with FCPX & Resolve).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on January 06, 2018, 09:16:25 PM
From my comparison test with interpolation frames through ffmpeg "minterpolate" and the hugin/enfuse solution I got more stable results with the latter. Unfortunately I cannot say much about the optical flow technique but they do things different so I say it´s for testers to decide. Got any test files :)?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 06, 2018, 10:33:30 PM
Sure. But I had to search for a while. Here you have: https://www.dropbox.com/s/xw260tdkmalnja6/M25-1225s.MLV.zip?dl=0
When reducing speed to 50% there happens this: (left original frame, right generated frame, happens in the end of the clip)
(https://image.ibb.co/hKA22G/Testpic.png)
Unfortunately there is not much aliasing in the clip... maybe the glass border line?!

Scenes with water also nearly never work with optical flow.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on January 06, 2018, 10:43:01 PM
Yeah, I often get something similar. No free lunch here with interpolation. My take is that averaging multiple frames and aligning those into one new file gets nice clean images with reduced aliasing without the intrpolation issues. Still, it needs more testing.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on January 07, 2018, 08:32:17 AM
if there is someone out there who can help with that... we are here and waiting for you! ;)
+1 !
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on January 17, 2018, 11:20:06 PM
I've been using MLV app for reviewing shots before conversion. It is very nice, the image is very nice in the program and simple light and darken options can simulate very well the look one was looking for. Though like everyone here said before, no way to get real time playback. Still saves one having to convert all Lossless files to then review and delete.

A small bug I noticed, is when importing multiple mlv's and maximizing the window while it is importing, the program will crash.

Also, would be nice if you could add keyboard commands, like CTRL+Z to undo changes in the parameters, one has done by mistake.

I can not see any difference with Highlight Reconstruction ON and OFF. I always set it to ON and choose Film.

EDIT: Win 8.1
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 18, 2018, 09:34:04 AM
You can get nearly realtime by activating caching and wait until caching is idle. On 8 years old notebooks you can reach more than 10 fps easily, on better computers more than 15 fps what nearly looks like realtime preview.

Yes, while importing you should not do anything. I think I can make that safer. Edit: got it fixed.

Undo changes is very very hard to realize, because we would have to protocol everything you do in the app. We don't do that atm, and for sliders this is even harder to realize, because of showing all changes in realtime.

Highlight Reconstruction only works, if you have a overexposed clip. Then drag exposure to something around -2. The overexposed areas will be pink now. Activate Highlight Reconstruction - now the pink is away. So if you don't have overexposed pinkish areas, you don't need to activate this option.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on January 18, 2018, 08:28:35 PM
Okey, thank you for the explanation.

I always use Amaze caching and i noticed the speed increasing when it is Idle, but I only get 7 fps. Is the app runned by CPU only? i7, 980m, 32 gb ram.

I have only used mlv app for 3,5k mlv's. I will try with HD, it should theoretically almost tripple the speed?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 18, 2018, 09:29:18 PM
Yes, the higher the resolution, the slower the playback. What also helps to increase the playback speed: do not use highres displays (e.g. Apple Retina - external displays can nearly double the speed) and/or make the Apps window smaller (fullscreen is the slowest). The fps I wrote were reached for MLVs at 1856x1044 (5D2).
And yes, all is running on CPU atm. So it runs on almost every computer, the graphics card plays no role. I always had big problems with apps like MLRV and Resolve - long time I did not find any computer where these apps were working, while MLVProducer was working well (even on OSX via Wine).
Bouncyball and Ilia were trying out OpenCL, but this is not so easy as the CPU based C/C++ code (at least I don't understand this) and the first experiments were also not really faster because of memory copy actions. We will see if someone has a good solution for making it faster in the future... ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on January 18, 2018, 10:22:10 PM
The binaries listed on the first post haven't been updated in a while and I wanted to check out the new focus pixel commits so I decided to compile the qt version on my Mac.

A couple of important steps:

Code: [Select]
brew install qt caskroom/cask/qt-creator
echo 'export PATH="/usr/local/opt/qt/bin:$PATH"' >> ~/.bash_profile

You also have to tweak the preferences:

(https://farm5.staticflickr.com/4616/38868763905_f004268349_z.jpg) (https://flic.kr/p/22dGzkP)

Yay!

(https://farm5.staticflickr.com/4701/38868807505_382506aba7_z.jpg) (https://flic.kr/p/22dGNix)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on January 18, 2018, 10:44:22 PM
Nice dfort.
Meoow.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on January 18, 2018, 11:57:09 PM
It even works with this EOSM crop_rec pre-RAWC shot if you play around with the options:

(https://farm5.staticflickr.com/4615/25897082238_3ba41bbc8f.jpg) (https://flic.kr/p/FsrjiU)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 19, 2018, 08:15:27 AM
A couple of important steps:

Code: [Select]
brew install qt caskroom/cask/qt-creator
echo 'export PATH="/usr/local/opt/qt/bin:$PATH"' >> ~/.bash_profile

You also have to tweak the preferences:

(https://farm5.staticflickr.com/4616/38868763905_f004268349_z.jpg) (https://flic.kr/p/22dGzkP)

Yay!

You mustn't do that. Just install the version provided on the Qt homepage and you don't have to adjust anything.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on January 19, 2018, 09:33:04 AM
You mustn't do that.

Most of what I do I mustn't do.

Ok, so the download link on the www.qt.io website took me to a Russian page but the next link went back to English--that was weird. I opened a QT account in order to run the installer, figured out what I wanted to install (there are lots of options) and when I finally got it working--

Code: [Select]
:-1: error: No rule to make target `FFmpeg/ffmpeg', needed by `MLV App.app/Contents/MacOS/ffmpeg'.  Stop.
Oh yeah--go back and read the MLV App instructions. Ah ha, - unpack ffmpegOSX.zip in `platform/qt/FFmpeg` and - go to tab project, add command line argument -j4 (for quad core)

Yay!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 19, 2018, 09:36:55 AM
Hehe. Yes. And it also works without Qt login/account. If you don't like the online installer, there is also a offline installer.
Using Qt5.10 has one bug for me - at least in the UI editor: the frame position slider is too short. But this happens only for OSX style, not for dark style. Qt5.9.3 is fine.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on January 19, 2018, 01:45:49 PM
Most of what I do I mustn't do.
Yay!
Haha, now, that very familiar cat looks beautiful everywhere ;)

@dfort: Congrats! Now you are the part of us, "MLV App"ers :)

Ilia, Masc, and I did our best to make this proggie as useful as it is now... more is coming, (@DeafEyeJedi, I'm not teasing... well, may be a lil' bit :P)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on January 19, 2018, 10:48:38 PM
Some improvments coming to playback...

(https://image.ibb.co/dmhbzG/Screen_Shot_2018_01_19_at_21_43_31.png)

;) (https://github.com/ilia3101/MLV-App/commit/dd242c518599bdf6f79cb8114ec10812857f54e9);) (https://github.com/ilia3101/MLV-App/commit/7c587b2f247c85c353c03e521e93c7cd6d28d682)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: reddeercity on January 20, 2018, 07:09:11 AM
Had a problem trying to download the latest windows version thought windows explorer (on Win7Pro , I don't use win10 ,  don't like it at all waiting for wins 12  :P)
I tried with this link  https://ilia3101.github.io/MLV-App/
Anyways here the screen shot with Explorer

(https://preview.ibb.co/me2JWw/MLVApp_download_page_windows_explorer_small_error.jpg) (https://ibb.co/d4nVdb)

So I had to use Google Chrome   >:( ,  the download links show up and could be downloaded .

(https://preview.ibb.co/gxW3Ww/MLVApp_download_page_windows_Google_Chrome.jpg) (https://ibb.co/i9gRjG)

Appears to be errors on the download web page with github , maybe have you downloads on a different hosting site even bitbucket
just a thought
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 20, 2018, 11:37:27 AM
Atm we just have it on github. Does the same happen if you load it from here?
https://github.com/ilia3101/MLV-App/releases
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on January 20, 2018, 01:16:31 PM
@reddeercity
Yes try the github release page.
Internet explorer has been deprecated for years, so it's a vulnerability and may not support some javascript features that are used to fetch the releases through Github API.
I could be able to fix it if you tried to track down some what causes the problem specifically, but probably not worth the time.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: reddeercity on January 20, 2018, 10:52:59 PM
Atm we just have it on github. Does the same happen if you load it from here?
https://github.com/ilia3101/MLV-App/releases
Works  :D thanks
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ZakWestbrook on January 21, 2018, 01:27:15 AM
This is incredible! I personally don’t know much about coding and what would be involved but if it were possible to incorporate ACR’s “clarity” function and ACR’s highlight function this would be the perfect app for magic lantern! Also the app on my OSX just randomly closed the second time I used it when I tried to export the file. Awesome work though. It does really simplify things
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on January 21, 2018, 10:33:02 PM
@ZakWestbrook Features like that are coming next. I agree "clarity" and highlights/shadows are the main thing it needs right now to be even better.

Also the app on my OSX just randomly closed the second time I used it when I tried to export the file.

Which app version, which export settings? Explain as much as you can!!!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ZakWestbrook on January 23, 2018, 07:10:07 AM
This app actually does an incredible job of reproducing the image I see in my cameras LCD. I've always used MLVFS in the past, ran it into davinci and exported prores 422 and for whatever reason, the image renders a few stops darker than what's actually on my LCD (without changing any settings). Then when I would bring the exposure back up, a TON of noise and red lines from the ISO would show up. It's always been a battle finding a good middle ground of how to properly expose. In general I always like to over expose a stop or two to eliminate as much noise as possible and ACR's highlight and clarity function have saved me on numerous occasions. Having those functions in the MLV App would be incredible for the flexibility alone. This is a recent test I did with hardly any light at all at 400ISO with my Mark III using the MLV App. I wanted to test out the flexibility of the White Balance in the MLV App in low light and I wanted to see how well I could get rid of noise in the shadow areas in the MLV App. Here it is below..there is no noise reduction on the clip.

https://vimeo.com/252102973/89c08d20e5

I'm using the QT MLV.App.v0.13.alpha.OSX on a Macbook air OSX El Capitan Version 10.11.6. (Idk if that matters). I've used the app a couple of times now and half the time it's been great, however the other half it's been quitting unexpectedly right when I go to "Export Selected Clips". I played around with it a ton tonight and I can't find any consistency as to why it's closing out. The only thing that's consistent is that it quits unexpectedly right as I click "Export Selected clips".

 A couple other minor suggestions I have are
1. When going to save the project, I have to retype the project name in every time I save it to overwrite the project. Is there a way to streamline that and have it populate when I go to save the project?
2. Playback seems to skip for me and looks like it's only showing every 3rd frame in the actual app. (it's fine once it's actually exported though) so right now what I'm doing is opening up the MLV in MLRawViewer to decide whether or not I like the clip and then export into the MLV App. (it'd be awesome to have everything in 1 place)
3. The White Balance temperature and tint doesn't seem to be as flexible as Davinci or ACR. There's some weird things happening when I push the white balance in the darker areas as seen in the clip that doesn't happen in ACR or Davinci.

I love the work that's being done here though! I'd love to use this app for every project I have moving forward and there's no doubt that this has some serious potential! Keep up the great work!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 23, 2018, 08:20:20 AM
Thanks! Each info can be useful.

Not bad... I see no noise! :) But at ISO400 I only expect that... :) I often record at >=ISO1000 @f/1.4 and there the noise starts in the darks using my 5D2.

When the app crashes, OSX brings a Messagebox. There is a button "Report". It would be interesting what it tells (OSX is so kind telling the crashing function ;) ).

1. You mustn't type the name. Just click the file. But yes, I also can improve that.
2. Deactivate "Drop Frame Mode" and you'll see every frame in playback, with the maximum speed you Mac is able to render. (Drop Frame = Realtime with dropping frames it can not render in time)
3. Do you have example pictures? I don't understand it completely...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on January 23, 2018, 04:30:15 PM
often record at >=ISO1000 @f/1.4 and there the noise starts in the darks using my 5D2.
Yes with that popular lovely 50mil I often use ISO 1600 @ f1.4 on my 5D3, the noise in shadows very manageable.

btw: the coolest thing is that Canon's 50mm @ f1.4 is ~0.5 stop brighter then it should be :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: domo94 on January 27, 2018, 01:55:01 AM
I'm so glad I found this.

As an editor, I would like to see blacks, shadows, highlights, and whites, instead of whatever is on the interface already.
It runs opposite to what's the standard in this industry for any type of image correction.

That's just my 2 cents: coming from an editor who would like to further use these programs consistently in his workflow.

Overall great app so far though. I love the option for Pros Res 422 and the likes.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Akurra on February 04, 2018, 04:24:48 PM
It seems to repeat the problem from raw2cdng and Davinci Resolve - the WAV files generated are few frames shorter than DNG sequence, and Davinci is not attaching it automatically to the DNG sequence.
The files were from 5D2 - system fps setting was 24 fps.

Also a corrupt MLV file - the one that did not fit into memory card, crashed it.

Otherwise - great APP. Even more than great!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on February 04, 2018, 06:24:36 PM
@Akurra
Can you upload your file? Also, test the same mlv against batch_mlv, it also should work with automatic resolve embedding.
Wav being a few frames shorter is common. As a matter of fact I never recorded a mlv file plus wav that matched exactly yet.
Wav being shorter is better, when longer it disables resolve embedding.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Akurra on February 04, 2018, 07:37:29 PM
A correction. It does not seem to be a *.wav file length problem.
The same problem occurs when using raw2cdng 2.7.9.

Batch_mlv outputs works fine.


I checked again: even when the *.wav file has correct length this is what happens:

In the Davinci media explorer file shows as video with audio (a little musical note sign). And when I click the "audio track" icon in the bottom-left of viewer to display just the audio there seems to be an audio file, which plays ok.
But when I switch back to video track, the video playback is mute,
and when I drag the file to the "Bins" window, the audio is corrupted? shifted? ... as you see on the image below, there is just a very short wave peak at the beginning.
Below is audio imported separately.

Dropbox file: https://www.dropbox.com/s/e85swbxwfjj913l/M04-1853.MLV?dl=0






(https://thumb.ibb.co/cTNQdx/wav_problem.jpg) (https://ibb.co/cTNQdx)

darmowa galeria allegro (https://pl.imgbb.com/)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 04, 2018, 10:26:04 PM
It seems to repeat the problem from raw2cdng and Davinci Resolve - the WAV files generated are few frames shorter than DNG sequence, and Davinci is not attaching it automatically to the DNG sequence.
The files were from 5D2 - system fps setting was 24 fps.

MLVApp cuts audio only when it is longer than the video. So if audio is shorter (whyever, I also have a 5D2 and audio is always longer), then you have only one chance: move cutOut some frames to the front. Then it should automatically attach in Resolve. It is not only the length, it is also the metadata inside the wav what is needed by Resolve. But MLVApp writes that - at least in newer versions.

Also a corrupt MLV file - the one that did not fit into memory card, crashed it.

Are you using latest version of MLVApp? We had this problems many versions ago, but fixed that. Can you please upload the file which crashed MLVApp, or is it too big? Would be nice to have it for debugging.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Akurra on February 04, 2018, 11:10:28 PM
@masc

As I wrote above, it does not seem to be a problem with wav lenght after all.

I downloaded MLVApp just yesterday for the first time, so I guess it's up to date.

Unfortunately I deleted the file that used to crash it (stupid me).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 05, 2018, 11:45:18 AM
@Akurra:
It must be something in your workflow: I downloaded your file, exported to dng and imported to Resolve: Audio+Video is automatically linked. I used MLVApp 0.13 and Davinci 14.2.1.

Edit: now I think I found what your problem is: audio plays only for the first few frames and then it is like muted in Resolve. Playing the original WAV works fine... that is strange. Could you test if you have the same problem for a "rounded" fps? You use 23.976 - maybe try with 25. If that works we know where to search ;-)

Edit2:
I think I found it:
Timecode audio: starts always at 0
Timecode video: starts not at 0
So video and audio does not fit, even when it is linked. We have a bug issue for that now: https://github.com/ilia3101/MLV-App/issues/72
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 07, 2018, 08:28:28 AM
Yeah seems this issue is fixed now, however when we're gonna release the v0.14 all testers are welcome :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Akurra on February 07, 2018, 06:15:13 PM
Thanks for info!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on February 10, 2018, 05:47:32 PM
Three things:

1.
Is it possible and makes it sense to add some kind of progressbar, when importing a mlv? What do you think?

2.
I found a way to create some kind of "table of content" in wordpress. I added this to my german-compile-tutorial ( https://seescho.wordpress.com/fotos/ml/ ). I will add this to the english version too. Later...

3.
Did someone with Linux try to enable filter?
Without mlv loaded, no problem. With a mlv loaded, mlvapp freezes and crash 10 seconds later:
Code: [Select]
Speicherzugriffsfehler (Speicherabzug geschrieben)Tested with opensuse leap and tumbleweed.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 10, 2018, 06:43:27 PM
Hej escho,
1.: does it still take long time for you to import? On my old Macbook I can import a lot of MLVs from USB 2.0 HDD within seconds... When it was slow some versions ago, I also thought implementing that.

2. Cool!  8) I like your tutorials a lot! It is much more detailed than my one.

3. Hmmm... I had that when playing around on macOS. But with the version in the repos I get no error on Win & macOS. Maybe bouncyball can test with his Linux?! ;) Are you able to debug and tell us the line where it crashes? v0.14 won't take longtime until release - so each bug found before will be good for everybody :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on February 10, 2018, 07:08:01 PM
Servus masc

1.
My mlvs are quite big. 4 GByte and more... The last one had 7,6 GByte.

2.
hankYou. I love doing this. I wrote this guide for me. And than I thougt: Why not sharing it?

3.
This is difficult. I tried using qt-creator in debug-mode, but no crash here. All is fine! Using qt-creator normal: crash. And compiling outside qt-creator: crash. I´m a bit lost at the moment. I will search the commit, the crash comes in, later.
Would be interesting, whether the crash exists on Ubuntu too. So waiting for boucyball :)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 10, 2018, 07:17:58 PM
1. Ahhh... you mean when importing just one big file?! Yes... that is still a problem. But the GUI gets no information about the importing process and progress. The only I can do is a statusbar which file from how many files is imported.

3. Did you try make clean, and then again qmake and make? Sounds strange...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on February 10, 2018, 08:30:28 PM
1.
Yes. It´s always one big file, I´m importing. So, if the gui gives no progrssinfo, let´s forget it.

3.
I always compile a clean project. Sometimes I´m lazy. So I wrote a nice little bash-script for me to do this (delete all, clone git, make clean, qmake, make and some more...). And when I do this stuff manual, mlvapp crash too.

Since I had a bigger hardisk-crash this week, I´m working on a brand new opensuse now. But with my old opensuse ,before the hd died, I had the same crash.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on February 10, 2018, 08:44:47 PM
I went back to this commit:
"fixed compilation error saying type 'uint16_t' is not defined"
Same crash

Shoudn´t we go to github-issues with this problem?

edit:
Since my script write a compile-log: Maybe this implicit declaration is interesting:

Code: [Select]
g++ -o filter.o ../../src/processing/filter/filter.c
../../src/processing/filter/filter.c: In function ‘initFilterObject’:
../../src/processing/filter/filter.c:41:24: warning: implicit declaration of function ‘fmemopen’; did you mean ‘freopen’? [-Wimplicit-function-declaration]

nochmal edit:
created an issue on github: https://github.com/ilia3101/MLV-App/issues/74


Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Justus on February 11, 2018, 12:19:27 AM
I have some difficulties with the App. I came back to Magic Lantern after a few month of not using it. Before I used raw2cdng, which didnt work for me with lossless 10bit recording now.
This app did work perfectly but I am missing the sound in Davinci. I have sound in the app and can playback the clips with sound. Also I have sound when I preview clips in the Media Storage in Davinci. As soon I pull the clip from Media Storage into the Media Pool I lose the sound. It still shows a sound clip in the Edit Tab but there is nothing to hear and no waveform.
Maybe you guys know whats going on.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 11, 2018, 12:52:46 AM
How did you export? CDNG? There was a bug with timecode, which is fixed now. You will get it with the coming v0.14 (hopefully) in the next days. Or you compile yourself and you'll have it faster ;)
Workaround for now without compiling anything: add the wav manually to Resolve.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Justus on February 11, 2018, 01:08:52 AM
Oh okay, thank you. Yeah, CNDG Lossless. I will propably wait then. Changing the wav in a few hundred clips is nothing I am interested in^^
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 11, 2018, 12:14:26 PM
@escho

Please try with latest commit.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 14, 2018, 09:04:48 PM
New release v0.14alpha (https://github.com/ilia3101/MLV-App/releases) :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 14, 2018, 09:58:50 PM
Yay... we finally got it. Thank you all for reporting bugs and wishes.
New in v0.14 alpha:
- Faster playback and export (the more cores, the more you'll feel the difference)
- Added processing filters for film emulation powered by neural networks :ghost:
- New actions and shortcuts for better user experience
- MLV export (Fast Pass, Compressed, Averaged Frame (for darkframe creation), Extract Internal Darkframe)
- MLV darkframe subtraction (external / internal)
- Autodetection for focus pixels and vertical stretching
- Stretching CDNG export frames
- Vector scope
- Added markers for over-/underexposed in histogram
- Timecode label / Duration (edited clip) label
- Audio only batch export
- Bugfixes
Have fun!

(https://user-images.githubusercontent.com/30245296/35821380-24619114-0aa9-11e8-85ed-0a97e125ad96.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on February 14, 2018, 10:01:04 PM
Best release yet!

AI (neural network) powered film emulation filters!!! <-- Maybe a first in open source image processing software! (gonna overtake adobe at this rate)
Much better performance in export and playback (which is often realtime now)
All of the other problems complained about should be solved.
+ lots of other stuff <3

How I feel about this release. (https://www.youtube.com/watch?v=49AiqH-DuR0)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on February 15, 2018, 08:38:33 AM
did a quick test on my windows pc. it works wonderful. love it
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 15, 2018, 08:40:34 AM
@Ilia3101

Hey why you dumped the cocoa version from THIS (https://ilia3101.github.io/MLV-App/) page? It had 200+ downloads anyway! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on February 15, 2018, 12:56:20 PM
This version is bad ass! Briefly checked it but had no darkframes available. Tell me since I am lazy over here, will the darkframe subtracion function work with multiple darkframes with various sizes or is one at the time and applies to all corresponding MLV files?
(https://s17.postimg.org/kxbkju3b3/Screen_Shot_2018-02-15_at_12.52.15.png)

Filter function, awesome:
(https://s17.postimg.org/lo4apb85r/Screen_Shot_2018-02-15_at_12.58.25.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 15, 2018, 01:19:00 PM
You can have one darkframe per clip. You can use a MLV for that, or load the darkframe into your clip.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 15, 2018, 03:54:48 PM
Yes one DF per clip.

If you export MLV with dark frame loaded, exported MLV will include the dark frame internally and loading this MLV after that will activate the 'Int' button.

It is possible to have one internal and one external dark frame simultaneously and switching between them (the effect of subtraction is seen straight away)

Also you can cut MLV including audio and it will be in sync and time code in resolve also will be correctly shown (after DNG export).

MLV export has 4 options (no raw correction is done):
1. export MLV untouched (fast pass)
2. export compressed MLV (only if original was uncompressed)
3. export averaged frame MLV (dark frame)
4. extract existing internal dark frame from MLV and save as a separate MLV.

With full compatibility of mlv_dump's averaging/subtraction.

As for filter option, there is an endless possibility to add more :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: mario1000 on February 15, 2018, 05:15:14 PM
Hello dear developers,

congratulation and a very big THANK YOU for this new version. Everything works very nice exept one thnig: when i try to import a MLV file for dark frame substraction the program craches reproducible. I am using windows 8.1.  The only error message I get is that windows is looking for a solution and I am asked to close the program. Any ideas? Thanks in advance
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 15, 2018, 05:44:10 PM
Which version of MLV App - 32bit or 64bit?

Upload that MLV somewhere and I'll take a look :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: mario1000 on February 15, 2018, 06:12:33 PM
Which version of MLV App - 32bit or 64bit?

Upload that MLV somewhere and I'll take a look :)

I tested it with both versions (32 and 64 bit) and get the same result.
Here you can download my test files (video file and  the darkframe file):

https://ufile.io/3pa2v
https://ufile.io/3bauu

Best regards
M.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 15, 2018, 06:50:13 PM
You recorded but did not average all frames of m15-1742.mlv.

How to average it:
1. just load m15-1742.mlv to MLV app (not as dark frame)
2. press 'Ctrl-,' or the export settings button
3. select codec MLV and the option below - Averaged Frame, then close export settings dialog
4. export MLV (name it the way to recognize that this is a dark frame, e.g. m15-1742_Dark_Frame.mlv)
5. delete m15-1742.mlv from session
6. load m15-1741.mlv into session and load m15-1742_Dark_Frame.mlv as a dark frame
7. play with Off/Ext, you should see the difference immediately
8. optionally, you can now export m15-1741.mlv from MLV App and it will include your dark frame internally, after loading exported MLV the Int button will be activated and you can play with Off/Int to see difference
9. Phew... the end :)

Anyway thank you for the feedback, the app crashes because it can not import compressed MLV as dark frame (my bad, I should've added check for it) otherwise as far as MLV, loaded as dark frame, is not compressed you can subtract any MLV from any MLV, again as far as video resolutions match :)

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: mario1000 on February 15, 2018, 08:25:33 PM
Thanks for the help, now it works! Indeed it makes a very big difference using the darkframe.

regards
M.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on February 17, 2018, 01:02:21 PM
I just did some initial testing as i was interested in this neural network film look. What is the difference between this, dare I say, A.I.? And a LUT?

And should i be worried that it will become aware of itself and send robots in to the past?

Joke aside, where are these film looks/emulations from? It reminds me of filmconvert's looks, where in it turns everything brownish.

Also i could not see lossless mlv's (from one of the first versions) 59'976 fps in the import window, but when i dragged and dropped them from folder there was no problem.

Win 64 version.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on February 17, 2018, 01:32:29 PM
There shouldn't be much of a difference between this and a LUT in terms of what it does(just does it a lot differently and slower :D), and it was even trained on some samples that someone I know filmconverted(shhhhh) WHOOps I mean real film

LUT support might be added at some point too, they seem quite simple actually.

The "AI" only has 3 inputs and 3 outputs... I would imagine its difficult to do any damage with just three floating point variables. Don't worry :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on February 17, 2018, 02:31:26 PM
You should talk to hyjalinim or how you spell it, he has some really nice examples of Ektar 100 film. I find his Ektar 100 LUT requires a very specific exposure to yield nice results, perhaps that is something the A.I can learn to do for us? Just a suggsstion.

I could chime in some examples myself, if need be. Have some pictures that nailed the exposure for that Ektar 100 LUT.  But I suppose its better to talk to the man who made the film emulation. And i dont know how the A.I learns exactly.

Anyways, keep up the good work. Its very nice that there is so much work done on the post-processing side of ML.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 17, 2018, 02:49:21 PM
Also i could not see lossless mlv's (from one of the first versions) 59'976 fps in the import window
Could you upload the sample? I'm curious about it :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ToniX on February 17, 2018, 03:00:32 PM
I have a problem with MLV GUI that severely limits the usability of the program, either with MLV.App.v0.13 /0.14.alpha.Win64.static.

The "edit area" panel is not displayed correctly.

 In fact, all the commands on the extreme right of the panel are not completely visible and therefore are not accessible.

I tried different screen resolutions without solving.

I use win 8.1 x64 and I wonder if anyone else has the same issue.

Any solution? (detachable panel, a drop menu, more extended stretching ...)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Walter Schulz on February 17, 2018, 03:26:11 PM
Wild guess: Item/font size off.

Run
Code: [Select]
control /name Microsoft.Display
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on February 17, 2018, 04:23:16 PM
@bouncyball

Yes, Later this evening.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 17, 2018, 06:14:44 PM
@ Kharak:
What we need for teaching a look is some sample pictures with and without a look applied. Import is to have as many colors as possible inside such pictures. It can be also more than one picture per look. We then have a little command line tool what teaches the look to some numbers, and this numbers can be compiled with a new name to MLV App. ;-)

@ToniX:
I also think it is a Windows font setting. If Windows overrides our font settings, the fonts may be to big for the GUI. We had the same problem on Linux. If fonts are system standard all should be fine.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: GianlucaM83 on February 17, 2018, 07:12:02 PM
@ToniX: I had the same problem. Text in the right panel appeared truncated. I have solved using this way: mlvapp.exe -> Properties > compatibility -> check "override high dpi scaling behavior -> select "system", OK.
I hope this helps you.
EDIT: I use windows 10 x64. In windows 8.1 the procedure may be slightly different.

PS:Sorry for my very bad english.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ToniX on February 17, 2018, 07:34:57 PM
Wild guess: Item/font size off.

Run
Code: [Select]
control /name Microsoft.Display

Hi @Walter Schulz 

 I restricted the characters to the minimum size, actually allowing  the view of the parts of the panel that were missing. Unfortunately, this client side solution involves making the rest of the PC unusable, as the texts are for the most part illegible.
 
Perhaps solving at level of  programming, would be more logical and functional.

Thanks anyway, at least so I will get to test the app  (which looks to be very cool!)


@ToniX: I had the same problem. Text in the right panel appeared truncated. I have solved using this way: mlvapp.exe -> Properties > compatibility -> check "override high dpi scaling behavior -> select "system", OK.
I hope this helps you.
EDIT: I use windows 10 x64. In windows 8.1 the procedure may be slightly different.

PS:Sorry for my very bad english.

Grazie @GianlucaM83 - I've tried, it would have been a preferable solution but it does not work for me. :(



Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Walter Schulz on February 17, 2018, 07:40:37 PM
High DPI monitor?
Try tuning your Windows settings:
https://support.microsoft.com/en-us/help/3025083/windows-scaling-issues-for-high-dpi-devices
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ToniX on February 17, 2018, 07:55:19 PM

@ToniX:
I also think it is a Windows font setting. If Windows overrides our font settings, the fonts may be to big for the GUI. We had the same problem on Linux. If fonts are system standard all should be fine.

@masc,  I saw your comment just now. Pardon
 It is certainly a problem caused by windows, known and annoying ..The default settings are too small, so I switched to "BIG" (or Large),  while sizes of specific items (menu, icons, etc) are set  between 9-11 .... ::)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on February 17, 2018, 08:02:24 PM
@bouncyball

I post it tomorrow, no time this evening.

@Masc

So with this learning, one could skip the steps of mlv - converting to a Log image -> corrections - grade - final look? I guess i am asking could the A.I take an MLV - "fake all the steps" - final look? Too complex? Further more, is this perhaps what fhe future of post processing looks like? And it eventually sends robots back in time ;)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Walter Schulz on February 17, 2018, 08:05:48 PM
@ToniX: Had the same issue with several java and web apps after setting item size to 150 (W7) at the company. Thought giving users with not so optimal vision something good. Had to revert it because of login screen troubles and such like.

Windows, application GUIs and high dpi monitors ... <sigh>.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 18, 2018, 09:49:07 AM
I have this problem on my 13inch high DPI notebook too.

It seems for QT there is not only macos DPI scalability is possible: Link (http://doc.qt.io/archives/qt-5.5/highdpi.html).

@Kharak: take your time.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 18, 2018, 11:38:33 AM
Topic highres: is there something we can do? I use already the Qt's highres support with devicePixelRatio and Fusion style. I am not sure if I can do something else. There is absolutely no problem on OSX retina for me - it is only way slower as without retina.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 18, 2018, 01:14:42 PM
Thank you!
I shot today a video with x5 crop mode at 14bit lossless resolution 1920x818 (14bit uncompressed works perfectly.)
The pixel dots pattern was different compared with full 2520x1072 resolution so no map worked for it.
Make your tests:
https://drive.google.com/open?id=1WdY7djRxC9tJjnJvQw_gQ5er30t_joKF
That particular file has the focus pixels shifted 8-frames. I think it has happened before but I can't find the post.

(https://farm5.staticflickr.com/4644/39541580182_1c2d8bd15c_o.gif) (https://flic.kr/p/23f9Wbs)

zoom mode is a special case because we're not sure what part of the sensor it was recorded on. I thought we covered all possible locations but maybe not?

In other news, the fpm2pbm.sh and pbm2fpm.sh scrips got a big speed boost:...

Look like the same problem here in MLVApp, the problem was solved in MLVFS and MLVProducer, I don't know if the new focus maps solved the problem or the developers added some codes in their software.

Amazing app thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 18, 2018, 06:37:38 PM
@theBilalFakhouri

This MLV of yours is very special case:

1. it is 8-12 bit lossless but has white level at 16200
2. it has 1107 vertical resolution of raw buffer

Because of 1st reason it is not detected as 8-12bit lossless, hence MLV App does not generate the correct map.

Use this map from @dfort for this case: 80000326_2592x1107.fpm (https://bitbucket.org/daniel_fort/ml-focus-pixels/src/8e01b06d4d12b3dff074dd33362e708473b673b2/focus_pixel_map_files/80000326_2592x1107.fpm?at=default). Put it into the same directory where MLV App binary is.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 18, 2018, 06:40:13 PM
@Masc
So with this learning, one could skip the steps of mlv - converting to a Log image -> corrections - grade - final look? I guess i am asking could the A.I take an MLV - "fake all the steps" - final look? Too complex? Further more, is this perhaps what fhe future of post processing looks like? And it eventually sends robots back in time ;)
It could be possible for a set of very equal clips. But the AI is not intelligent in correcting pictures. It is just intelligent in learning a difference between two looks in the same picture.

You should talk to hyjalinim or how you spell it, he has some really nice examples of Ektar 100 film. I find his Ektar 100 LUT requires a very specific exposure to yield nice results, perhaps that is something the A.I can learn to do for us? Just a suggsstion.
I trained the Ektar 100 look to MLV App. But I think it is not good as it is now, because it is very difficult to get a clean set of pictures, where
a) the MLV App look is the basic
b) the converted look is the same picture with Ektar100 applied
Both apps bring a different look - also without the LUT. Very difficult... so it may work for some clips, but it will not work good for other ones. In my opinion the result is too intense... see examples... and I had to decrease saturation a lot for not getting screaming colors.
(https://image.ibb.co/hFAMT7/M23_1205_frame_1c.png)
(https://preview.ibb.co/mews1S/M21_2106_frame_1c.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on February 18, 2018, 07:20:59 PM
Hard to tell by the flowers, but that top one of the boat looks very nice. Atleast on my phone it does.

Edit: Just looked again at the pictures on my computer, did not see the boat picture on the right before. So that is the Ektar one, yeah it is not too nice, way too intense. Normal one looks kinda like what I imagined the Ektar 100 to look like when correctly applied.

 The LUT is very intense, hence why I only use it for photography, because i always, after setting DCP to ML Log in ACR, have to pull highlights -85 or -100 and boost shadows around +30 to not lose too much detail.

I dont know which LUT you used, but Hyjalinim and Danne made the LUT for Danne's ML log. So that might be why it is so intense. There are many versions of ghd lut in his thread. And applying the LUT to Log-C turns the colours wrong.

Edit: @Bouncyball,

 I was about to upload MLV example of the ones I could not see in the Import Window, tried the import window one more time now and I can see the MLV's. So all good!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 18, 2018, 08:14:50 PM
I was about to upload MLV example of the ones I could not see in the Import Window, tried the import window one more time now and I can see the MLV's. So all good!
Heh, good to know, b/c that was weird :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 18, 2018, 09:06:07 PM
I used the "BMD to Etkar C", minus a lot of saturation. I trained the AI again with more pictures and it looks a bit better now... but like the LUT - I don't know - I don't think so  :P  :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 18, 2018, 09:22:56 PM
Thanks! @bouncyball it worked.

But it's just 14bit lossless with white level of 16200 not 8-12 lossless.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 19, 2018, 11:31:56 AM
But it's just 14bit lossless with white level of 16200 not 8-12 lossless.
Hehe :) you mean you did not record it as 8-10 or 12 bit lossless?! (In some rare cases somehow 8-12bit restricted lossless has full range white level like 16000+)

But if you say it was initially recorded as 14bit lossless... then... Houston we've got a problem - @dfort: new special case arrived! Our restricted lossless check is down the drain ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 19, 2018, 12:04:54 PM
Yes I didn't record at 8-12bit lossless, it's 14bit lossless form the beginning :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on February 19, 2018, 04:53:23 PM
@dfort: new special case arrived! Our restricted lossless check is down the drain ;)

In my script I'm just reporting whether it looks like a lossless compression clip but always applying the most aggressive focus pixel map. It doesn't seem to hurt the image and is better than having focus pixels showing up because the lossless check failed.

Code: [Select]
  if [ $bits_per_pixel -eq 14 ] && [ $white_level -lt 15000 ]; then echo "Detected a 12 or lower logical bit depth lossless compressed file"; fi

BTW -- This test passes. The file was recorded 14bit lossless. We've already found out that sometimes the focus pixels shift 8-pixels when recording in 14bit so we need to account for that. The reduced bit depth clips map files just cover more of the sensor area.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 19, 2018, 06:29:43 PM
We've already found out that sometimes the focus pixels shift 8-pixels when recording in 14bit so we need to account for that. The reduced bit depth clips map files just cover more of the sensor area.
Right, then zoom mode pattern generator have to account 2nd pass of shifted pixels for any lossless MLV.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 28, 2018, 08:58:02 AM
Hello everybody!

What's up guys it's so silent here. Any feedback? Any bugs? Any suggestions? Anything else? :D

Edit: LINK (https://ilia3101.github.io/MLV-App/) - good rate of downloads for 2 weeks anyway :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on February 28, 2018, 10:31:42 AM
Bouncyball,

I would love to test the latest version of MLVApp and provide feedback on it but as I stated seval times it will not run on any of my computers.  Initially I thought, the reason is the OS but then I installed Win10x64 and the software continues to crash every time I try to import an MLV file.  It starts normally and displays the GUI though.  The PC on which this happens has now two OS-es:  Win10x64 and XPx32.  The same software crash is observed on both OS-es with the 64-bit and the 32-bit MLVApp versions, accordingly.  My PC has the following configuration:

MoBo: Intel DP35DP
CPU: Quad core Q6600
RAM: 8 GB DDR2
GPU: GTX 750 Ti

I observe exactly the same behavior also with my laptop Lenovo 3000 N200 with 4GB of RAM on it.  No luck here either.

I have never ever observed any problems with any other software on the above two computers, even DaVinci Resolve 14.3 runs perfectly on the Q6600 PC.  It is very powerful, despite being 10 years old.  Just MLVApp refuses to work on it and on my laptop too.  And since there are many friends of mine who experience exactly the same problem with MLVApp on their older PCs, I have a request to you.  Could you please check and see if a colleague or friend of yours has an older PC similar to the ones listed above?  If you find such a person and ask him to let you run MLVApp on his computer maybe you could find out what causes the crash and perform a fix, accordingly.  My friends and I really should greatly appreciate if you could do that.  On my part, I promise to provide feedback on the latest MLVApp as soon as I get it working on my PCs.

Thank you in advance.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 28, 2018, 01:53:53 PM
Hello @bouncyball

I have some suggestions:

1-Can you add the resolution + frame rate info in the bottom bar :D
2-Negative controls especially for "Light Strength", it will help a lot for restoring highlights in dual iso footage after shifting the exposure up 4 stops.
3-I don't really use "Fix Bad Pixels" (it somehow hurt the image for me) , so if I can turn it off once instead of doing it for each clip would be a lot helpful.

And thanks for amazing App  ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: chger on February 28, 2018, 02:17:11 PM
Hello,

I've been using and testing a while now under Windows x64. So far I did not encounter any problems or bugs, but have two feature requests though.

* Integration of DNxHD as an export codec:

I'd prefer using DNxHD or DNxHR as a codec in a .mov-Container (though .mxf would be recognised by Avid MC, Adobe PR has its problems with it.). An example list of command line options and settings for DNX-coding in ffmpeg can be found here: http://www.deb-indus.org/tuto/ffmpeg-howto.htm#Encoding_VC-3 or https://askubuntu.com/questions/907398/how-to-convert-a-video-with-ffmpeg-into-the-dnxhd-format-for-the-purpose-of-usin. Idealy one option would include a 10bit-output.

A direct command line input in the GUI by the user would be an alternative and provide total freedom of codec choice!

* Integration of custom LUTs

As of now I can select from a variety of LUTs (e.g. S-Log 3), but using custom LUTs (thinking of the LUT calc over here: http://cameramanben.github.io/LUTCalc) would be awesome.

2-Negative controls especially for "Light Strength", it will help a lot for restoring highlights in dual iso footage after shifting the exposure up 4 stops.

+1

Cheers and THANK YOU!!!! for your amazing work on the App!

With best regards,
Chris

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 28, 2018, 05:23:33 PM
...  Initially I thought, the reason is the OS but then I installed Win10x64 and the software continues to crash every time I try to import an MLV file.
Thanks for your report. I can't believe it has something to do with your hardware - I successful use it on a 10 years old Core2duo, without any problem. I would really love to know what causes this problem. I think it could be something with localization - some parts of our app had problems there before too. But I think the only way to debug is, if you install Qt on one of your PCs, load our sourcecode, compile as Debug version and run in Debug mode. The debugger will tell us the line of the crash and then we could help solving the issue. Do you think you get that done? We have a little compilation guide, but you also can PM me, if you have problems or questions.
Edit: you get it running on XP? It was not compiled for that and I also don't get it opened there...

1-Can you add the resolution + frame rate info in the bottom bar :D
If you press "I" once, you see this info, if you press "I" twice, it is hidden again. You also can have opened the info dialog all the time on the left or right or... and the app will work as it is not opened.
2-Negative controls especially for "Light Strength", it will help a lot for restoring highlights in dual iso footage after shifting the exposure up 4 stops.
You don't mean to invert the slider, but to have a negative range on the slider? Ilia trys to implement a kind of photoshops "Shadows & Highlights", but has still problems and bugs. We all hope he solves it soon.
3-I don't really use "Fix Bad Pixels" (it somehow hurt the image for me) , so if I can turn it off once instead of doing it for each clip would be a lot helpful.
If you import many MLVs, just change it first for one clip. Then Ctrl-C, Ctrl-A, Ctrl-V and you're done.


I've been using and testing a while now under Windows x64. So far I did not encounter any problems or bugs, but have two feature requests though.
Good to hear! :)
* Integration of DNxHD as an export codec:

I'd prefer using DNxHD or DNxHR as a codec in a .mov-Container (though .mxf would be recognised by Avid MC, Adobe PR has its problems with it.). An example list of command line options and settings for DNX-coding in ffmpeg can be found here: http://www.deb-indus.org/tuto/ffmpeg-howto.htm#Encoding_VC-3 or https://askubuntu.com/questions/907398/how-to-convert-a-video-with-ffmpeg-into-the-dnxhd-format-for-the-purpose-of-usin. Idealy one option would include a 10bit-output.
Yes, I also thought about adding that. In the tables you posted: are the options so limited for this codec?! For all existing codecs the input plays no role... so that makes it really difficult, which option is chosable for which clip... in a batch it would not be usable at all :(
A direct command line input in the GUI by the user would be an alternative and provide total freedom of codec choice!
That is very very complicated to realize regarding error handling: in the past it was already a challenge to get predefined export options to work without a crash. If the user can type what he wants... oh oh  :P

* Integration of custom LUTs

As of now I can select from a variety of LUTs (e.g. S-Log 3), but using custom LUTs (thinking of the LUT calc over here: http://cameramanben.github.io/LUTCalc) would be awesome.
There is a enhancement topic added on github for that already, but we will see if and when it is possible to realize that (I am also waiting for that).



Thank you all for your feedback!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 28, 2018, 05:56:52 PM
There is nothing left for me to answer :)

Thanks @masc

P.S. @IDA_ML
As I understand your problem is not related to particular MLV file right? Then you're gonna be very helpful if you do what masc asked.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on February 28, 2018, 06:22:14 PM
P.S. @IDA_ML
As I understand your problem is not related to particular MLV file right? Then you're gonna be very helpful if you do what masc asked.

I am afraid, I have no coding/compilation skills whatsoever.  This is like Chinese to me.  I would be more than happy to try but I will need very detailed step by step instructions on how to do the compilation.  I am not sure if you guys would have the patience with me to do that.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Walter Schulz on February 28, 2018, 06:26:58 PM
Easy to follow for OS X/macOS users:
https://www.magiclantern.fm/forum/index.php?topic=16012.0
Just copy text found at the end to console and your first compiler run is done.

The guys here will guide you through compiling code for this app, too.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 28, 2018, 07:25:43 PM
I am afraid, I have no coding/compilation skills whatsoever.  This is like Chinese to me.  I would be more than happy to try but I will need very detailed step by step instructions on how to do the compilation.  I am not sure if you guys would have the patience with me to do that.
You don't have to know anything about coding. It is just downloading and installing Qt for Windows (just for Windows (MinGw, 32bit), with QtCreator, all other options disabled in online installer). https://www.qt.io/download
In the source folders MLVApp/platform/qt open MLVApp.pro in QtCreator, set target to debug (just some clicks on/after import), press debug button (2nd button low left corner). Then MLVApp should start. Open a MLV - bang - crash. Qt will show you the code line where it crashes... make a screenshot. The rest we will do.
After all is done, you can uninstall it easily. (unfortunately Qt is some GB big)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on February 28, 2018, 07:49:02 PM
Thank you Masc,

I have just registered on the Qt site and downloaded a file called "qt-unified-windows-x86-3.0.2-online.exe".  However, it is only 19 MB.  Is this what I need?  Should I install it on my Win7x64 machine?

Also, I don't understand the following statement:

"In the source folders MLVApp/platform/qt open MLVApp.pro in QtCreator ... "

Is MLVApp.pro the MLVApp.exe that I have downloaded from the first page of this thread or is it something else?

Sorry for the stupid questions but please be patient with me!  Thanks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 28, 2018, 07:56:37 PM
You dont need to register - there is a very small "skip" (also in the installer).
Yes, the Online installer is right. It downloads all what is needed on install. Open it, click a few times "next", when you are on the register page search for the "skip". At one point you choose the parts to install. Enable Qt for windows 5.10.1 with mingw, and QtCreator, you won't need more for that. Mingw must be enabled somewhere (it is a long time ago I installed on Windows... sry).

Download the sources from here: https://github.com/ilia3101/MLV-App/archive/master.zip
If you unzip it, you'll understand the path I wrote. Open the .pro file in QtCreator. Creator will ask you then, what environment you like to use (there is a little triangle to enlarge, make sure Debug is enabled).
The project should be configured automatically then. On the left there is a computer icon. Press it and make sure Debug is chosen. Below there is the Debug button. Press it. It will compile (needs maybe some minutes) and start MLVApp when ready. Thats all.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on February 28, 2018, 08:35:07 PM
I cant say that I have used the app exstensively, but so far no real bugs to be found. However it did crash yesterday after i had reviewed and tinkered with a lot of 3.5k mlv's. I think it was about 50 mlv's imported and i had tinkered around with about 30 of yhem when it just suddenly crashed, a windows message appeared "the program has encountered an error" something like that. Not a big deal for me, as i so far only used mlv app for reviewing lossless files before converting to DNG with Danne's windows batch script.

One thing I think is off with MLV App is the White Balance slider, i am on a fairly calibrated monitor and i think the Kelvin does not coincide with the normal temperatures, that I am used to from other software e.g. ACR, Resolve etc. what I mean is that I think it is overly warm. A shot under normal daylight with 5600 k looks wrong, i push it to 4800-5000 to get it to look right. Same goes for the AI Film Emulations, they are very warm. Film Convert has a very warm look, so if it learned from that, I understand.

I will compare head to head when i have the time between mlv app and acr to see if there is a difference. So far it looks off.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 28, 2018, 08:57:45 PM
...However it did crash yesterday after i had reviewed and tinkered with a lot of 3.5k mlv's. I think it was about 50 mlv's imported and i had tinkered around with about 30 of yhem when it just suddenly crashed, a windows message appeared "the program has encountered an error" something like that. ...
Yes, for me that also happens - but I have not found yet a defined way how to crash it. If you can reproduce that, please let us know!

One thing I think is off with MLV App is the White Balance slider, i am on a fairly calibrated monitor and i think the Kelvin does not coincide with the normal temperatures, that I am used to from other software e.g. ACR, Resolve etc. what I mean is that I think it is overly warm. A shot under normal daylight with 5600 k looks wrong, i push it to 4800-5000 to get it to look right.
Really? Do you have examples (jpeg and MLV(just one frame is enough))? I did a quick test, because I did not notice that yet... but can't see a big difference. Whitebalance is identical (4973K), for all other parameters I tried to find a equivalent. 1st: MLVApp, 2nd: Lightroom:
(https://image.ibb.co/ipLgTH/M23_1205_frame_1.png)

Edit: I think I remember... @bouncyball: is this a camera matrices problem? 5D2 is best and all others are more or less off?!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on February 28, 2018, 10:44:07 PM
It's my fault that white balance is wrong. I'll have this fixed some time soon (I've written a really nice black body simulator which I'll put to use in white balance). Also matrices.... I've almost got to that :D

@IDA_ML I have ran it on a Lenovo x61 from 2007 with linux. It's probably something to do with windows being bad as usual.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 01, 2018, 10:58:24 AM
Not a big deal for me, as i so far only used mlv app for reviewing lossless files before converting to DNG with Danne's windows batch script.
You could batch export DNGs from MLV App directly. Is there any reason why you don't do this? If yes, then there will be some info for me to chew on.

I will compare head to head when i have the time between mlv app and acr to see if there is a difference. So far it looks off.
If it is not 5d2 then it can be so. I have implemented (in my test build) ufraw black body code modded by alex->dmilligan->(humbly me) to account camera matrixes and it woked lot better for my 5D3 than actual current release. I did not post or commited it anywhere at the moment (needs some more work).

@Ilia3101: very interested in you approach of black body radiation emulation!!! :) (you did great job emulating and interpolating wb multiplier values troughout of 2000-20000K range, unfortunatelly it's for 5D2 only)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 01, 2018, 11:48:53 AM
Good guess Kharak is using the darkframe automation in the script ;).
So, not knowing too much how this darkframe workflow is fully working in Mlv app i'd like to make a suggestion to it.
1 - have the user select any amount of darkframe footage recorded and then have Mlv app all files averaged and ready for usage.
2 - have these darkframes stashed away in a storage folder, always active and used if matched footage is used. There could be an 'activate storage' button for instance.

I'm thinking every user can now keep on filling their darkframe storage and in time it would be more or less complete.

Of course unwanted scenarious could happen such as user selecting non darkframes so some sort of exposure control would be good here. Also ways to erase darkframes etc and the location of the storage folder.

Or maybe easiest way is to select a darkframe storage folder from within Mlv app and that way a user can reuse the folder with every new version coming. Mlv app could then create averaged darkframes that will work with matched footage and the storage can be activated from within the app. Every time a vanilla darkframe mlv is added to the folder Mlv app would average and standardize to suit Mlv app workflow. That way you could skip a lot of hassling steps described above and I think it would be kind of a game changer.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on March 01, 2018, 12:45:42 PM
Thanks @masc

You don't mean to invert the slider, but to have a negative range on the slider?

Yes, I meant to have extended values for dropping highlights down.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 01, 2018, 01:26:56 PM
@Danne: Hehe, that is one of the reasons maybe :)

1 - have the user select any amount of darkframe footage recorded and then have Mlv app all files averaged and ready for usage.
This is no problem. Just import all dark frame footage clips and make averaged MLVs for each in batch export.

2 - have these darkframes stashed away in a storage folder, always active and used if matched footage is used. There could be an 'activate storage' button for instance.
Automatically matching DF with clips - this is what's not implemented (and have not been considered to be implemented) in MLV App :)

Of course unwanted scenarious could happen such as user selecting non darkframes
This can be kinda overcome b/c after loading you see all thumbnails of all imported clips. If it is not black then it certainly not DF footage.

That way you could skip a lot of hassling steps described above and I think it would be kind of a game changer.
Right... that kind of automation certainly great to have. Automatically averaging newly added DF clip also nice, but matching is kinda main problem here it must work like focus maps in the folder. There could be not only one folder of DFs, but whole DIR structure like CameraID/Resolution/ISO and also there are parameters like shutter speed, digital/analog gain, binning/skipping...

In short all this have to be coded somehow in filename or dir structure for fast access (for not reading every time all DF MLVs, or some headers in case of some new format for DFs) or implement some kind of database to quickly access those dark frame files (with any names) to match current clip parameters.

Do you use anything like this in your script for DF automation?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 01, 2018, 02:03:10 PM
I did a lot around df automation and the most intuitive way is that you can add darkframe MLV,s and regular MLV files in the same folder and Switch will sort them out by reading pixel brightness. Well, I use convert(imagemagick) for this.

Here is a workflow I use with a storage folder and as you say this includes renaming, prefixing the created, averaged darkframe for fast matching. Only if it finds MLV files without the prefix avg_ then it will start processing the darkframe.
Movietime
https://www.youtube.com/watch?v=A36KsIpVDJw&feature=youtu.be

These are my matching features, there might be more to account for as you say:
avg_14bit_EOS5DMarkIII_res_1920x672_iso_100_fps_59.940000.MLV
avg_14bit_EOS5DMarkIII_res_1920x800_iso_200_fps_59.940000.ML
V

Let me know if I could share anything else here but matching is pretty straight forward. Getting the values:
Code: [Select]
    bit=$($mlv_dump -v "$FILE" | awk '/bits_per_pixel/ { print $2; exit }')
    res=$($mlv_dump -v "$FILE" | awk '/Res/ { print $2; exit }')
    iso=$($mlv_dump -v "$FILE" | awk '/ISO:/ { print $2; exit }')
    fra=$($mlv_dump -v "$FILE" | awk '/FPS/ { print $3; exit }')
    cn=$($mlv_dump -v "$FILE" | awk '/Camera Name/ { print $4,$5,$6,$7; exit }' | cut -d "'" -f1 | tr -d ' ')

Then check if those values will marry with the regular MLV recordings.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 01, 2018, 04:24:31 PM
...Switch will sort them out by reading pixel brightness. Well, I use convert(imagemagick) for this.
Very smart move :D

avg_14bit_EOS5DMarkIII_res_1920x800_iso_200_fps_59.940000.MLV
Got it, you use simple and effective file name coding. Great! :) (I should've known it if I were mac user :P)

Matching clip and DF parameters is easy in MLV App b/c you have all information at your fingertips after importing MLV, but IDK when and IF this kind of automation will be implemented and available any soon. Instead I chose the path of implementing builtin DF for cut and exported MLVs.

Anyway thanks for sharing!

And I'm interesting what personally Kharak gonna say.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on March 01, 2018, 05:57:35 PM
Yo! Later this evening :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on March 01, 2018, 08:33:21 PM
Or maybe easiest way is to select a darkframe storage folder from within Mlv app and that way a user can reuse the folder with every new version coming. Mlv app could then create averaged darkframes that will work with matched footage and the storage can be activated from within the app. Every time a vanilla darkframe mlv is added to the folder Mlv app would average and standardize to suit Mlv app workflow. That way you could skip a lot of hassling steps described above and I think it would be kind of a game changer.

OoOoOoh yeahhh I'm feelin' this one, @Danne!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 01, 2018, 08:40:15 PM
@deafeyejedi
Darkframe hero nr1  :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on March 01, 2018, 09:36:24 PM
@Bouncyball @Masc

I use the 5D3.

And I use Danne's Batch Script because of the Batch Process, just select Card/Folder containing MLV and select output and batch convert to DNG with Darkframe Automation.

Yes, for me that also happens - but I have not found yet a defined way how to crash it. If you can reproduce that, please let us know!
I have not found anything reproducible. It happened again yesterday evening, when I was going through about the same amount of MLV's, maybe 20-30 MLV's. So far this the most "reproducible" thing I have found, in being, that it happens after going through several MLV's. The error was a Runtime Error. It was so late, so I was not bothered enough to take a screenshot of it, but it was just a general Windows Runtime error, no specific code or anything.

Really? Do you have examples (jpeg and MLV(just one frame is enough))? I did a quick test, because I did not notice that yet... but can't see a big difference. Whitebalance is identical (4973K), for all other parameters I tried to find a equivalent. 1st: MLVApp, 2nd: Lightroom:
The lightroom DNG, is it exported from MLV App? That might be why they give similar results, but I don't know if you have some sort of bake-in going on with DNG export. Also 5000k for what looks to me like a sunny day, does not seem correct to me, but ofcourse, I was not there and if its your shot, then you know how it was supposed to look like that day.

Here are 4 examples of mine. 3 different softwares: MLV App, ACR and Resolve, I added a 2nd version from MLV App where I (quickly) tried to match exposure to the other two and added some saturation.

All set at 5500k
Tint on 0 on all.

No colour correction.

https://mega.nz/#!wAAHnRwA!On_Allt6g0jzkNe_gej6DEJo-mFRb0rVwqN8Lr0qhII https://mega.nz/#!RVYFVDaa!Gx_v4JU1nNnzwh73XxMOY75W0YIbf6qwCOC79UUtipk https://mega.nz/#!FYQGBIJD!jsfhJCui_qT34ItGF8xsCvrPXW4Itjyc1_2wX8geLzg https://mega.nz/#!pd4kiKxB!h8LCWwdAGmYEqQvb34rDNVIEge1mxaxEB7MqbjPw69g

All exported as PNG because MLV App exports Frames as PNG (very nice feature btw).

Some Notes:

Resolve version is DNG set to Linear to LOG-C and added Arri-Log-C to Rec709 to normalize it, 5500K in Raw Tab and exposure +1.0 to make it match the others more. Maybe there is a better way in Resolve to get a normal look with a DNG, but I never work with DNG's in Resolve.

I think the White Balance of ACR and Resolve matches a lot, even though they dont have a similar look, the overall temperature/colours look to be the same. 

But this might not be an issue with White Balance, it might just come down to how the software process' the RAW information. ACR uses process' of different kind to pop colours and Black Magic have been working a lot on there debayering since they introduced their BMCC cameras. And again, MLV App just looked off to me, maybe because I am so used to ACR and Resolve and "see colours" with their eyes.

I'd like to add that I also think its a good idea with some basic information about the MLV at the bottom bar like Resolution, Frame Rate, Lens, Aperture, ISO and Date/Time. And if one wants the full info, one can click the Info button.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 02, 2018, 09:37:12 AM
@Kharak

Right now I'm looking @ your posted PNGs. You are right all 3 software use very different processing.

The main reason I never been satisfied with MLVProducer (despite it is great software) is pale desaturated reds and this is what also shown on your PNGs from mlv app (used only 5d2 color multipliers, matrix not suited for other cameras like 5d3, also there are other reasons for sure which IDK exactly). IMHO the difference (not featurewise but imagewise) between MLVP and MLV App is that in MLV App you can achieve more pleasing results after less tweaking (but not ideal), what I'm not able to do even with curves, etc in MLVP. For me colors are always wrong there, no matter what I do. In short - out of the box image is better in mlv app for my eye. I think in regard of color and WB accuracy MLV App can not really compete with resolve or ACR at the moment. Besides, like Ilia already said, he's working on a lot of improvements in this field.

All exported as PNG because MLV App exports Frames as PNG (very nice feature btw).
You better export 16bit TIFFs not 8 bit PNG which is only for quick peek.

I'd like to add that I also think its a good idea with some basic information about the MLV at the bottom bar like Resolution, Frame Rate, Lens, Aperture, ISO and Date/Time. And if one wants the full info, one can click the Info button.
As Masc mentioned already you can open info dialog and leave it open while switching between clips (the dialog info will update every time you go to the next MLV).

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Lars Steenhoff on March 02, 2018, 08:58:50 PM
I woud love to see a 2X resize preset. ( 200% )


So I can easy export and upscaled to 4k

(https://thumb.ibb.co/ggtAa7/Screen_Shot_2018_03_02_at_20_56_15.png) (https://ibb.co/ggtAa7)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Markus on March 03, 2018, 08:07:08 AM
So you can use this app now for DF averaging and put out new cdng files on Win (or maybe soon)?
If that's so I have to try this out!

@Danne, You have a program for osx that does this aswell?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 03, 2018, 09:31:41 AM
@Markus
Check out Switch for darkframe automation:
https://www.magiclantern.fm/forum/index.php?topic=15108.0
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 03, 2018, 12:10:46 PM
So you can use this app now for DF averaging and put out new cdng files on Win (or maybe soon)?
If that's so I have to try this out!
Yes, you can create averaged darkframes with MLV App. You can also subtract them from your clips and export a subtracted corrected clip or a darkframe to cdng.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 03, 2018, 02:59:05 PM
I woud love to see a 2X resize preset. ( 200% )
So I can easy export and upscaled to 4k

@masc

Looks like there is a request for aspect ratio locking check box in export settings dialog ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 03, 2018, 03:50:52 PM
Yes, very handy indeed.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Markus on March 03, 2018, 05:40:11 PM
Thanks for reply Danne & masc!

@Danne: Switch seems awsome but still on Windows here though :-).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 03, 2018, 05:59:47 PM
Best bet is Mlv app. I created a script for windows which also automates df subtraction. @Kharak seems to like it but it's very basic. It's called batch_mlv.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Markus on March 03, 2018, 06:33:17 PM
@Danne: that sounds sweet, gonna try it out!
:-)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 03, 2018, 08:44:14 PM
Looks like there is a request for aspect ratio locking check box in export settings dialog ;)
I woud love to see a 2X resize preset. ( 200% )
So I can easy export and upscaled to 4k
I did it a bit different - as bouncyball proposed. Exactly 2x is useful mostly only for 5D3. Now you can enter the width you like and MLV-App will calculate the height automatically for every clip in the batch in dependency to aspect ratio settings and clip size, if lock button is pressed.
(https://user-images.githubusercontent.com/30245296/36938492-8002b664-1f22-11e8-91bc-e37cf29330e9.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 03, 2018, 09:37:42 PM
Great thinking.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on March 04, 2018, 01:23:27 AM
Indeed excellent thinking by @masc!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Lars Steenhoff on March 04, 2018, 01:02:02 PM
Nice !

I have some suggestion for the icons, to make them more modern.
I used the font awesome icons to replace the header bar icons, see the screenshot.


(https://thumb.ibb.co/dHN6YS/Screen_Shot_2018_03_04_at_12_59_14.png) (https://ibb.co/dHN6YS)

(https://thumb.ibb.co/cAKyf7/Screen_Shot_2018_03_04_at_12_59_28.png) (https://ibb.co/cAKyf7)


https://fontawesome.com
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on March 04, 2018, 02:15:23 PM
Is it possible to set preferred frame rate when previewing ? I cant seem to find that option

Sometimes when playing 60 fps files, it reaches 30 fps or will vary between 20-30, would be nice if one could set a limit at 24 or what ever one prefers.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 04, 2018, 02:17:50 PM
Having monochrome icons is no good idea. Let me explain: we had that already for the player icons - they were black and the design was very close to what you suggested - the icons are nice - no question. They were visible very good on the systems theme (light grey), and also in the menus. Then we got the dark theme, and the black icons were invisible. But already before - for all users on mac or linux who are using a systems dark theme these icons were invisible.
Now, using white icons may look cool on the dark theme in the app - but in a standard OSX menu white icons become nearly invisible.
So the icons we have now - 75% I found after very long research, and the other 25% there was no icon in the net - so I build them myself. And I hope everybody can see it on each OS and each theme.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 04, 2018, 02:22:53 PM
Is it possible to set preferred frame rate when previewing ? I cant seem to find that option

Sometimes when playing 60 fps files, it reaches 30 fps or will vary between 20-30, would be nice if one could set a limit at 24 or what ever one prefers.

Yes you can set that up. Standard is the fps of your clip - depending on your clip and your computer it is possible to reach that or not. Then we have 2 playback modes
- one mode shows each frame: that means if you computer is too slow, playback will be slower than it should be
- and drop mode drops frames it can't handle over time: here playback is realtime, but maybe some frames are not shown

If you like to override the original framerate, you can setup that in the export settings dialog. Now the two modes above try to reach that framerate - again: depending on your computer.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 04, 2018, 02:28:06 PM
@Lars Steenhoff

What can I say, looks not bad at all, but Masc is a chief designer of QT App ;). We even decided not to have more themes for simplicity of maintenance.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 04, 2018, 02:33:02 PM
Hey guys I think I probably have good news for @IDA_ML and others who have older PCs with older Core2 Duo CPU models where MLV App crashes during file import (I've been able to reproduce this behavior).

Download those fixed 2 windows builds (now they are running smoothly on my E6800 CPU):

MLV.App.v0.14.alpha.Win32.zip (http://nic.caucasus.net/mlvapp/?dir=&download=MLV.App.v0.14.alpha.Win32.zip)
MLV.App.v0.14.alpha.Win64.static.zip (http://nic.caucasus.net/mlvapp/?dir=&download=MLV.App.v0.14.alpha.Win64.static.zip)
Latest 64bit exe with some bugs fixed (https://bitbucket.org/bouncyball/mlv-tools/downloads/MLVApp_v014_old_cpu_win64.zip)

Try and report back your findings.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Lars Steenhoff on March 04, 2018, 04:44:43 PM
Having monochrome icons is no good idea. Let me explain: we had that already for the player icons - they were black and the design was very close to what you suggested - the icons are nice - no question. They were visible very good on the systems theme (light grey), and also in the menus. Then we got the dark theme, and the black icons were invisible. But already before - for all users on mac or linux who are using a systems dark theme these icons were invisible.
Now, using white icons may look cool on the dark theme in the app - but in a standard OSX menu white icons become nearly invisible.
So the icons we have now - 75% I found after very long research, and the other 25% there was no icon in the net - so I build them myself. And I hope everybody can see it on each OS and each theme.

I have thought about what you encountered and I see a few possible variations:

1 use the coloured icons.
2 use  white icons when the theme is dark
3 invert the white icons when the theme is white ( they will be black )
4 use a grey color that works in both dark and light theme.

I'm happy to contribute to making this work. and at the same time understand it not the most important thing. and that to save complicating te project only one theme is used.
It just for me personally I prefer a clean icon. it can even be a coloured one.  so the good thing is that the project is open source and I was able to change the icons the way I want them and make a new build.
and like to share back to you what I did.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on March 04, 2018, 04:54:41 PM
Yes you can set that up. Standard is the fps of your clip - depending on your clip and your computer it is possible to reach that or not. Then we have 2 playback modes
- one mode shows each frame: that means if you computer is too slow, playback will be slower than it should be
- and drop mode drops frames it can't handle over time: here playback is realtime, but maybe some frames are not shown

If you like to override the original framerate, you can setup that in the export settings dialog. Now the two modes above try to reach that framerate - again: depending on your computer.

Just to be clear, the Framerate Override box in Export settings also affects the Preview within MLV App ?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 04, 2018, 05:21:20 PM
Just to be clear, the Framerate Override box in Export settings also affects the Preview within MLV App ?
Yes. Exactly.

And yes it is a bit misleading. Would be nice to have FPS override per clip. We never discussed this before.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 04, 2018, 08:08:30 PM
Just to be clear, the Framerate Override box in Export settings also affects the Preview within MLV App ?

Yes, that still comes from the time, where this dialog was the App-Preferences and Export-Settings were just a part of it. At this time we said, having just one framerate override for all clips is enough - but maybe this changed ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on March 04, 2018, 08:11:13 PM
alright, thanks! Works for me ;)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 04, 2018, 08:29:23 PM
I have thought about what you encountered and I see a few possible variations:

1 use the coloured icons.
2 use  white icons when the theme is dark
It is okay for the app, but on OSX you won't see the icons in the menu if theme is light. For OSX dark it is okay.
3 invert the white icons when the theme is white ( they will be black )
Now it is okay in OSX light, but in the App you won't see them. Inverting means having more than one icon set in the app? Complexity will rise a lot for such a feature. And I did not search if I can read which theme is loaded in OSX.
4 use a grey color that works in both dark and light theme.
In principle yes, but OSX light is a light grey - so then we have also a bad contrast between icons and background :(
On Windows it will always look good with white icons, because the menu is inside the app and always black. But we always must think on all OS with all themes... and sometimes even this is not enough :D

I'm happy to contribute to making this work. and at the same time understand it not the most important thing. and that to save complicating te project only one theme is used.
It just for me personally I prefer a clean icon. it can even be a coloured one.  so the good thing is that the project is open source and I was able to change the icons the way I want them and make a new build.
and like to share back to you what I did.
Yes, thanks for sharing! So don't understand my wrong. Most of the features in MLVApp are good ideas from users - that is very important for us!
And yes - it is open source. So, if you don't like the design, you can change what you want for your personal version. If you like to play with that - all what is called darkstyle in the code has many parameters, which make the app look as it is. You can change all colours like you like them! ;)
darkstyle.h
darkstyleOSX.qss (on OSX)
darkstyle.qss (non OSX)
What I started one day (but I stopped because it was too much work for my taste) was another darkstyle with orange instead of blue... a bit Resolve like ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Bernie54 on March 05, 2018, 12:03:07 PM
@bouncyball: Hi, I triend to download this new files for testing because I had excactly the same problem on a Core2 - however the link seems to be broken. Any idea?
Regards,
Bernie54

Hey guys I think I probably have good news for @IDA_ML and others who have older PCs with older Core2 Duo CPU models where MLV App crashes during file import (I've been able to reproduce this behavior).

Download those fixed 2 windows builds (now they are running smoothly on my E6800 CPU):

MLV.App.v0.14.alpha.Win32.zip (http://nic.caucasus.net/mlvapp/?dir=&download=MLV.App.v0.14.alpha.Win32.zip)
MLV.App.v0.14.alpha.Win64.static.zip (http://nic.caucasus.net/mlvapp/?dir=&download=MLV.App.v0.14.alpha.Win64.static.zip)

Try and report back your findings.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 07, 2018, 10:14:26 AM
Edit: Links above are working now.

Try this 64bit exe (https://bitbucket.org/bouncyball/mlv-tools/downloads/MLVApp_v014_old_cpu_win64.zip) (some bugs fixed). Get ffmpeg from officially released v0.14 here (https://github.com/ilia3101/MLV-App/releases/download/QTv0.14alpha/MLV.App.v0.14.alpha.Win64.static.zip).

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 07, 2018, 10:26:37 AM
This is incredible news for me, Bouncyball!  Thank you so much!  I still cannot believe that MLVApp is finally working on my 11-year old laptop.  Please give me some time to test and I will report on my impressions later in this thread.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: chger on March 07, 2018, 11:22:44 AM
Yes, I also thought about adding that. In the tables you posted: are the options so limited for this codec?! For all existing codecs the input plays no role... so that makes it really difficult, which option is chosable for which clip... in a batch it would not be usable at all :(

I see, DNxHD is very limited, but I think DNxHR is more flexible. I will do some testing with ffmpeg handling non-standard resolutions and framerates and report back.
I assume from what I read so far that with DNxHR you can just assign a profile (dnxhr_444, dnxhr_hqx, dnxhr_hq, dnxhr_sq, dnxhr_lb) without providing any further options (e.g. framerate, resolution). That is atleast for converting file a to file b.

Cheers,
Chris
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 07, 2018, 11:54:29 AM
This is incredible news for me, Bouncyball!  Thank you so much!  I still cannot believe that MLVApp is finally working on my 11-year old laptop.  Please give me some time to test and I will report on my impressions later in this thread.
W.w.what?! Bouncyball, you got it to work for IDA_ML? What was the reason? Was it the optimization -O3 for the compiler!? NICE!

I see, DNxHD is very limited, but I think DNxHR is more flexible. I will do some testing with ffmpeg handling non-standard resolutions and framerates and report back.
I assume from what I read so far that with DNxHR you can just assign a profile (dnxhr_444, dnxhr_hqx, dnxhr_hq, dnxhr_sq, dnxhr_lb) without providing any further options (e.g. framerate, resolution). That is atleast for converting file a to file b.
If that is more flexible, that would be nice. Adding these single options is no problem. What we do with further options, must be evaluated. There are many aspect ratios for MLVs out there, not only 16:9 ... but I could stretch it always to 16:9 if DNxHD is chosen - but I don't know if someone needs/likes that. If you could some testing it would be nice to report back! If it works for a TIFF sequence to DNxHD.mov, it should also work for our export pipe. (You can export a TIFF sequence with MLVApp, if you haven't one.)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: chger on March 07, 2018, 12:21:06 PM
Another thing that came to my mind:

The following keyboard-shortcut would be useful: Alt + I (since I is already in use for Clip-Info) for setting the In-Point right at cursor / playhead-position within the "timeline". Same with Alt + O for the Out-point.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 07, 2018, 12:26:30 PM
DNxHD seems not to be so easy too. I tried to export a 5D2 16:9 1856x1044 MLV, without much parameters...
Code: [Select]
ffmpeg -r 25 -y -f rawvideo -s 1856x1044 -pix_fmt rgb48 -i - -i M15-1953.wav -c:a copy -c:v dnxhd -pix_fmt yuv422p M15-1953.mov
That brings:
Code: [Select]
Input #0, rawvideo, from 'pipe:':
  Duration: N/A, start: 0.000000, bitrate: 2325196 kb/s
    Stream #0:0: Video: rawvideo (RGB0 / 0x30424752), rgb48le, 1856x1044, 2325196 kb/s, 25 tbr, 25 tbn, 25 tbc
Guessed Channel Layout for Input Stream #1.0 : stereo
Input #1, wav, from '/Users/masc/Desktop/M15-1953.wav':
  Metadata:
    comment         : Exported MLV Audio
    encoded_by      : Canon EOS 5D Mark II
    originator_reference: JPCAN-2...
    date            : 2017:07:15
    creation_time   : 19:52:50
    time_reference  : 0
    coding_history  : PCM
  Duration: 00:00:00.34, bitrate: 1575 kb/s
    Stream #1:0: Audio: pcm_s16le ([1][0][0][0] / 0x0001), 48000 Hz, stereo, s16, 1536 kb/s
Stream mapping:
  Stream #0:0 -> #0:0 (rawvideo (native) -> dnxhd (native))
  Stream #1:0 -> #0:1 (copy)
[dnxhd @ 0x7ff07b014c00] video parameters incompatible with DNxHD. Valid DNxHD profiles:
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 175Mbps; pixel format: yuv422p10; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 185Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 365Mbps; pixel format: yuv422p10; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 440Mbps; pixel format: yuv422p10; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 115Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 120Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 145Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 240Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 290Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 175Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 185Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 220Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 365Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 440Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 185Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 220Mbps; pixel format: yuv422p10; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 120Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 145Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 185Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 220Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 120Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 145Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p10; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 180Mbps; pixel format: yuv422p10; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 220Mbps; pixel format: yuv422p10; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 110Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 180Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 220Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 60Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 60Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 75Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 120Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 145Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 36Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 36Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 45Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 75Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 90Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 350Mbps; pixel format: yuv422p10; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 390Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 440Mbps; pixel format: yuv422p10; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 730Mbps; pixel format: yuv422p10; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 880Mbps; pixel format: yuv422p10; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 42Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 60Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 75Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 115Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 63Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 84Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 100Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 110Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 80Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 90Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 100Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 110Mbps; pixel format: yuv422p; framerate: 0/0
Error initializing output stream 0:0 -- Error while opening encoder for output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width or height
Conversion failed!

So it has definitively to be resized to the supported size - using it is really limited :(

Another thing that came to my mind:

The following keyboard-shortcut would be useful: Alt + I (since I is already in use for Clip-Info) for setting the In-Point right at cursor / playhead-position within the "timeline". Same with Alt + O for the Out-point.
Try Shift+I and Shift+O ;) (You see the hint when cursor is on the buttons)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 07, 2018, 12:43:33 PM
Okay, I got a very first DNxHD export file out of MLVApp. There are only the listed options available, not more, not less. We now have to search for a good idea, how to combine this with our export settings dialog in a way it makes sense...
Code: [Select]
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 175Mbps; pixel format: yuv422p10; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 185Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 365Mbps; pixel format: yuv422p10; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 440Mbps; pixel format: yuv422p10; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 115Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 120Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 145Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 240Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 290Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 175Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 185Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 220Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 365Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 440Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 185Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 220Mbps; pixel format: yuv422p10; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 120Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 145Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 185Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 220Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 120Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 145Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p10; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 180Mbps; pixel format: yuv422p10; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 220Mbps; pixel format: yuv422p10; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 110Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 180Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 220Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 60Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 60Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 75Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 120Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 145Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 36Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 36Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 45Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 75Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 90Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 350Mbps; pixel format: yuv422p10; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 390Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 440Mbps; pixel format: yuv422p10; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 730Mbps; pixel format: yuv422p10; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 880Mbps; pixel format: yuv422p10; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 42Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 60Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 75Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 115Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 63Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 84Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 100Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 110Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 80Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 90Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 100Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 110Mbps; pixel format: yuv422p; framerate: 0/0
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 07, 2018, 12:49:49 PM
Haha... tried the profile dnxhr_444 as you mentioned... exports without parameters and without crash. But: I don't have a program what can play it back :D

Edit: profile dnxhr_hq needs also resolution and format parameters - but after export is ready, I don't find a program what can open it - even VLC can't.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 07, 2018, 02:50:07 PM
Masc,

You may want to try MPV player:

https://mpv.io/installation/

It plays DNxHR 444 files perfectly.

And yes, Bouncyball did it for me.  MLVApp v.014 works on both of my computers (the laptop Lenovo 3000 200N and the PC from my post #849).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 08, 2018, 02:14:40 PM
Thanks @IDA_ML. That works.

I added DNxHD export to MLVApp. It is commited to the repos for now and I got some first test export files.
But that will need a lot of test - DNxHD is a very angry codec @ ffmpeg: if there is just one false character in the command -> BAAMMM. And the commands are not sooo short :)

I added 4 export options: 1080p & 720p, both @ 8 and 10 bit. Aspect ratio will be forced to 16:9, whatever it was before. Export will work only, if clips are 23.976, 25, 29.97, 50 or 59.94 fps, or if they are forced to that.

Hope anyone can use that... :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on March 08, 2018, 02:28:58 PM
Have you tried looking at Gopro Cineform codec, which is open source now?

10 bit YUV, 12 bit RGBA, custom aspect ratio/resolutions up to 4K and I read somewhere it can be exported as 16 bit aswell. Though i have not seen 16 bit option in any of the software i have used.

https://gopro.github.io/cineform-sdk/
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 08, 2018, 02:43:10 PM
Now there is also DNxHR 444 codec - for now only 1080p 10bit. Does someone need DNxHR 444 at 8bit and/or 720p?

Have you tried looking at Gopro Cineform codec, which is open source now?

Yes we did. But nobody of us understands this code. That is why we decided to wait until it is supported by ffmpeg as encoder, then we could add it very easily. See https://github.com/ilia3101/MLV-App/issues/38 for latest information...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 08, 2018, 05:08:11 PM
Hi  guys!

Here is the LINK (http://www.dvinfo.net/forum/cineform-software-showcase/534863-cineform-sdk-now-open-source.html#post1939158) explaining why cineform official inclusion to ffmpeg is kinda stalled. Sad but we can't do anything about it.

However, VirtualDub-FilterMod supports native cineform encoding/decoding (version 10) and I'm using it with great success. There is a plugin to support cineform and it is open source. I guess it is LOT of time/work but can be considered as doable.

@masc, yes it was -O3->-O2 which I committed lately :)

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 09, 2018, 12:23:38 PM
@masc, yes it was -O3->-O2 which I committed lately :)
Nice one!

I now added DNxHR HQX, HQ, SQ & LB - all in 1080p - to MLVApp as export codec.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 09, 2018, 03:26:00 PM
It's not very nice that this codec forces us to particular resolutions.

I always preferred cineform.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 09, 2018, 04:04:48 PM
It's not very nice that this codec forses us to particular resolutions.

I always preferred cineform.

Word...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 14, 2018, 06:45:27 PM
Hello guys,

After playing for more than a week with v.014 of MLVApp which Bouncyball was so kind to adopt for usage with very OLD PCs, I am now ready to report my first impressions:

BUGs
====

1) The software crashes when rendering large MLV files shot at 24 fps.  I tried to render a 1,25 GB  from the 100D and it crashed every time at different locations of the time line.  It works fine with smaller files though.

2) MLV files shot at the full sensor resolution (FRSP) as timelapse sequences with the silent module do not record properly in the destination folder after rendering is completed.  Just an empty file (0 bytes) gets recorded.

3) Sound does not play while playing a clip in the main window.

4) Dark frame subtraction does not seem to be doing anything.  I recorded a MLV file at ISO 3200 (quite noisy) and then a dark-frame MLV at the same settings with the lens cap on that I used for the subtraction.  The software imports it fine as Ext file but the noise on the original does not get affected even after export.  Am I doing something wrong?

Overall Impression:
============

I am quite satisfied with MLVApp.  I love the nice and vibrant colors and the fact that they are fairly easy to adjust.  My favorite feature is the Chroma Separation which kills color noise while preserving fine detail - very useful.  I wish, export was a little faster but all in all, MLVApp is a great and efficient tool for working with MLV files.

--------------------------------------------------

I have to run now but I will continue with suggestions and comparisons when I find some time for that.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 14, 2018, 08:04:34 PM
Hej IDA_ML, thanks for your feedback! Happy to hear that you like the app. You are using a 32 or 64bit version?

1. & 2.: Could you please upload these two MLVs? I never had such problems, so it would be nice to have such files for debugging!

3. Is the audio output and drop frame mode active? Otherwise sound can't be played back.

4. Do you use the darkframe file as it is, or have you averaged it? You can do this by opening your noise file, exporting as MLV->Averaged Frame. Then import this averaged file as darkframe. The dynamic noise won't be filtered with that. But static noise is filtered. For 5D3 files the left side of the picture is less pink than for example.

MLVApp renders 100% CPU based. That's why speed could be better - but as it is it runs on nearly every computer of the last 10 years. ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 15, 2018, 09:10:29 AM
1. and 2. agree with @masc. Giving us original uncut samples will be very helpful.

3. With latest Win32 build sound does not work at all for some unknown reason. Please use 64bit version when possible. (if 64bit has no audio then check what @masc explained)

4. As @masc mentioned above Dark Frame has to be prepared before using it. 200-300 frame DF MLV has to be averaged. Select in export options averaged frame. This will export real averaged 1 frame MLV for you. Then it can be loaded as Ext DF. Effect will be seen immediately when clicking Off/Ext/Off...

Speed is the matter of heavy optimizations. Maybe someday... :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 15, 2018, 09:26:54 AM
4. As @masc mentioned above Dark Frame has to be prepared before using it. 200-300 frame DF MLV has to be averaged. Select in export options averaged frame. This will export real averaged 1 frame MLV for you. Then it can be loaded as Ext DF. Effect will be seen immediately when clicking Off/Ext/Off...

Could this step be automated? Check for black MLV file and determine whether the darkframe has been averaged or not? Should be simple to determine if there´s one averaged frame or around 200 non averaged ones?

Since you are using ffmpeg it´s rather easy to check for black frames.
Code: [Select]
#detect blackframe thorugh ffmpeg(example is with a mov file):
if grep -q 'pblack' <<< $(ffmpeg -i $(ls *.MOV | head -1) -vframes 1 -y -vf blackframe -f null /dev/null 2>&1 | grep -m1 'pblack')
then
echo yes
fi
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 15, 2018, 10:44:37 AM
Hey Danne,

Yeah, there could be done any checks you want.

1. Black (dark image) or one frame MLV.
2. Say in message box that this MLV is not right one for DF subtracting, "But hey wait a minute!"
3. If frames are dark all along the whole clip, average them to DF.
4. Add DF with defined name to appropriate DIR to be used with appropriate footage.
5. Play some hurray song and congratulate user with 1st ever dark frame subtraction accomplishment, despite he even has no idea what it is and what he's done :P
6. Do it again and again...

Well... may be some day ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 15, 2018, 11:01:31 AM
Or maybe only adding a check for if the selected darkframe is averaged or not and react accordingly. Don´t even need to be checking for dark/bright, only size of MLV.
Cheers  :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 15, 2018, 12:46:01 PM
Some while back I wanted to introduce the separate DF file format but after thinking a bit more I decided to go with mlv_dump compatible way (MLV) despite this was more work than just new format import/export. I was making MLV export anyway so I added averaging as an option.

Also my point was to include DF to the mlv itself. So does MLV App during MLV export if external DF is loaded. I fully understand that this is not an optimal approach when you have to quickly process dozens of clips, it is just for people like me who keeps lots of clips in acquisition format. The dedicated DIR with preaveraged DFs for various cases is the way to go to automate and make clip processing fast.

For the beginning just checking the MLV frame amount (1 or more) is a good thing to warn user and tell him he needs to average the clip first.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 15, 2018, 12:49:34 PM
3. With latest Win32 build sound does not work at all for some unknown reason. Please use 64bit version when possible. (if 64bit has no audio then check what @masc explained)
Really? For me that works on Win32.

For the beginning just checking the MLV frame amount (1 or more) is a good thing to warn user and tell him he needs to average the clip first.
No prob... that is done easily.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 15, 2018, 12:55:53 PM
Really? For me that works on Win32.
Yes :( after -O2 sound does not work on my Core2 CPU PC for win32 build.

No prob... that is done easily.
Yes sure it's not hard, but check should be done in C lib not in mainwindow.cpp. I'll take care of it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 15, 2018, 06:24:53 PM
Hello Bouncyball and Masc,

Following your instructions, I got sound during playback working.  Thanks a lot!  As far as Dark Frame Averaging is concerned, I did exactly what you suggested ("200-300 frame DF MLV has to be averaged. Select in export options averaged frame. This will export real averaged 1 frame MLV for you. Then it can be loaded as Ext DF. Effect will be seen immediately when clicking Off/Ext/Off...") BUT I still do not see the effect, although the averaged 1 frame MLV was successfully created and I loaded it as Ext DF (see B. below for the dark frame footage). Could it be that the dark frame footage was not long enough for averaging?

As you requested, I have prepared a few MLV files for you to see what's wrong:

A) A 1,25 GB file (shot on the 100D, in movie crop mode at 24 fps, 1800x1012 and ISO 3200) for Masc.  With this file, after a few basic adjustments MLVApp crashes while rendering at different locations of the timeline, every time I open and render it.  Download link:

https://we.tl/tQs3enc3D6

B) A 116 MB Dark frame footage file shot at  exactly the same settings as in A) but with the lens cap on.  Download link:

https://we.tl/Y1eg2hf84d

C) A 950 MB file shot with the Silent module of the 100D as a FRSP sequence (30 frames) to see how MLVApp hangs at the end of the export.  After waiting for several minutes, I pres Abort and get the usual message: MLVApp has stopped working.  Download link:

https://we.tl/BD5NQBikma

===================
I hope, this helps.  Links will be active for 7 days.
 
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 15, 2018, 07:34:58 PM
At this point, I would like to make a few suggestions for improvement that, in my opinion, will make MLVApp better and more user friendly:
------------------------------------------------------------------------------------------------------------------------------------------------------------

1) I am missing the White Balance Eye Dropper Tool and the Contrast Slider.  Right now, we have two sliders for the Dark and Light ranges and strengths.  In my opinion, it would be much more intuitive if the two pairs of sliders are replaced with single sliders called "Blacks" and "Whites", respectively.  This will make centering the histogram easier and save some time too.  And most important: MLVApp's interface  will become almost identical with ACR!

2) I am missing also the Monochrome Noise Reduction slider.  Right now, the Chroma Separation slider works miracles with killing the color noise.  Why not adding also a tool for monocrhome noise reduction, as in MLV Producer?

3) I fully agree with the other suggestions made in this thread (see posts #850, #851 and #917).  These will be very helpful.

4) One of the greatest features of MLVApp in my opinion is that it opens almost instantaneously.  I have made my file associations in such manner that files with MLV-extention open with MLVApp.  This makes the software a great replacement of the highly popular MLRAW Viewer that was unfortunately abandoned by his author.  Now, w.r.t. MLVApp, I have the following suggestions:

a) When more than one MLV files are selected in Explorer and dragged onto the  MLVApp icon, they should all open up as thumb nails in the session window.  This will make it easy to view the thumb nails of multiple files at a glance.  Right now, only the first of the highlighted MLV files gets loaded in the Session window.

b) I was wondering if it may be possible to get MLVApp creating thumbnail  previews of all MLV files in a folder right in Windows Explorer.  Windows does this with MOV and MP4 video files already.  Would it be possible to have thumbnail previews with MLV-files too?  This will make  lives of all of us a whole lot easier, especially when sorting, cleaning up, moving clips, etc.

5) The greatest feature of MLVApp is its ability to run on older computers and laptops which are not powerful enough to run software like DaVinci Resolve for example - important for mobility and field work.  On the other hand, MLVApp runs painfully slow, especially with larger resolutions.  I made a few speed tests rendering the same file with MLV Producer and then with MLVApp in H.264 format on the same laptop.  MLVApp is more than 3x slower.  On the other hand, I have noticed that I can open 3 or 4 times MLVApp, split my clips between them and have them render simultaneously.  This works and I notice substantial reduction in render times when I do that. This makes me wonder if MLVApp could be optimized in such manner that it uses multi threading in a more efficient way and run faster eventually.
--------------------------------------------

I am sure, the developers will feel totally overwhelmed by so many suggestions but please guys, take your time, see what is doable and what not and continue improving your amazing software step by step as you have been doing so far.   You are doing a great job and I am sure, many people in this community greatly appreciate your enormous efforts.  So, keep up your excellent work!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 15, 2018, 08:36:13 PM
Thank you but I could never manage to download files from wetransfer :(. Downloading ALWAYS stalls and can not be resumed.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 15, 2018, 08:44:00 PM
Nice feedback IDA_ML.
I tested around a bit with your darkframe and additional crop mode footage. The averaging effect is very subtle but it´s there. I tested in Switch(sorry Mlv app) but wanted to check fast what mlv_dump is producing.
Darkframe averaging will work best with stressed footage. A bit under exposed(shadows will be cleaned) and also color cast from lenses so if the footage is properly exposed and you are using some good lenses the averaging effect will probably be minor.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 15, 2018, 09:58:03 PM
Thank you but I could never manage to download files from wetransfer :(. Downloading ALWAYS stalls and can not be resumed.

Bouncyball,

May I suggest that you ask Masc to download the files for you (a total of about 2,4 GB).  I uploaded for him big files with Wetransfer in the past and he always succeeded downloading them.

Nice feedback IDA_ML.
I tested around a bit with your darkframe and additional crop mode footage. The averaging effect is very subtle but it´s there. I tested in Switch(sorry Mlv app) but wanted to check fast what mlv_dump is producing.
Darkframe averaging will work best with stressed footage. A bit under exposed(shadows will be cleaned) and also color cast from lenses so if the footage is properly exposed and you are using some good lenses the averaging effect will probably be minor.

Indeed, I used a good lens, Danne - the EF 24/2,8 IS.  Also, I try to expose to the right.  If the footage is underexposed, then the signal to noise ratio will be worse and at this high ISO (3200), the picture will look much noisier.  In that case, DF averaging and subtraction will probably not help much either.  That is why I think that a monochrome noise reduction, in combination with Chroma Separation will work better.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 15, 2018, 10:23:45 PM
Thanks for the uploads and all you wrote here... that's really a lot! :)

Your clip A: it seems there is another problem with your processor and MLVApp. On my Core2Duo on macOS I can export without any problem. @bouncyball: can you test on your Windows? Edit: hmm... you can't... I could try to upload it somewhere else for you... but that will need some time @60kB/s :D

Your clip B: Indeed there is only very low static noise in this clip. That is why you can't see something. I tried to subtract it averaged from clip A, and yes... I see a very tiny difference in the low right corner of frame 1 (dark area)... but it is soooo small the difference...

Your clip C: When MLVApp tells 100% on export, MLVApp has finished rendering - but ffmpeg is still on the run. For me ffmpeg run ~1min after MLVApp was at 100%. Then OK was shown. Maybe this takes still more time on your PC - I don't know - but ffmpeg is what the app is waiting for. You should see ffmpeg in task manager - if it is still running - just wait ;)

Your ideas:
1. Whitebalance picker is a thing we want to realize since a long time. It is realized in the GUI already (only invisible for now), but in the apps core the functionality is still missing. I hope Ilia will find the time on day to realize it. :)
Dark/Light Strengh/Range is different from black & whites & contrast in ACR. Maybe Ilia finds a way one day to add that additionally. I never missed it, because Dark/Light Strengh/Range can do more (it is only harder to understand what it does).

2. If someone knows algorithms which do desired tasks it is not such big deal to realize that. Until now I did not hear something about a noise reduction algorithm here... maybe Ilia has an idea?! ;) Would be cool, no question.

4a: You can't drag all files to MLVApp?! Okaaay... for me that was working even on Windows. What not works: "Open with" with more than one file on Windows - on macOS that was no problem (works different). I'll try to search for that...

4b: Hm... I don't know how to create special thumbnails. Could be another task for the future. ;)

5: Speed optimization is very hard to realize. H264 is one of the slowest codecs to export. Maybe the settings are different to MLV Producer - no idea what settings it uses. If you like having a fast export - ProRes with option Anatolyi is one of the fastest (at least for me).
It may be that opening MLVApp more than once and exporting is faster: MLVApp and ffmpeg has be to synced. For syncing we get nearly never 100% CPU for processors with more than 2 cores - but I don't know how to change that. But maybe we have other ideas in future how to make that better! :)

Thanks again for all you wrote!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 15, 2018, 10:37:19 PM
Tried this? Pretty fast:
Code: [Select]
-c:v libx264 -preset ultrafast -crf 10
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 15, 2018, 10:45:18 PM
Thanks @Danne. Maybe I add that as additional export option. Until now we use
Code: [Select]
-preset medium -crf 24
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 15, 2018, 10:53:41 PM
Yes, lot of alternatives :).
By the way. Maybe multprocess exports working in parallell? I noticed exporting one instance of ffmpeg at the time is time consuming so I start off 4 processes in parallell and my computer fans start working :).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 16, 2018, 12:04:02 AM
Finally, to complete my feedback, I would like to share with you part of a private communication in which Bouncyball and I were discussing the question:

MLVApp versus MLV Producer:  Which one is better?
==================================

In my opinion, since both software products work perfectly on laptops that are not powerful enough to run professional video editors such as DaVinci Resolve, they both are well suited for travel, mobility and field work - for checking the video clips directly from the camera card using a card reader, performing basic corrections on the clips and archiving them in ProRes 422 or another editable format for further work on them later.  The main advantage of MLVApp vs. MLVProducer in my opinion are the natural and vivid colors that indeed are difficult, even sometimes impossible to achieve with Producer.   On the other hand, Producer offers more intuitive controls and is quite a bit faster at export.  My honest opinion is that both products do not compete but complement each other and are perfect for travel when you cannot take your powerful desktop  with you.   I have them both installed on my laptop and plan to use them as follows:

1) I would use MLVApp if I do not plan further color corrections or grading and also for archiving my clips, (b.t.w., I love the file sizes).  In this case I would just apply all corrections that I need in MLVApp and export the clips in ProRes422 or 422LT.  Then I would just cut and mount the entire movie with Filmora or some other simple software that works fine on my old laptop which I like to take with me while traveling.

2)  I would use Producer when I plan to perform the basic color corrections and grading later, on a powerful desktop with DaVinci Resolve.  In that case, I would import all clips into Producer, apply a flat profile and/or LUT and possibly some basic adjustments and export in ProResFast 4444, accepted as ProRes 422 by Resolve.  This goes really fast with Producer on the same laptop and file sizes are quite acceptable.  Then I simply get rid of the huge MLV files and save more than 75% disk space on my laptop.  All the rest I do on my desktop with Resolve  when I get back home.

Bottom line:
========

The developer of MLV Producer AWPStar and the developers of MLVApp have done a fantastic job with their advanced and powerful software which is perfectly suited for travel and mobility work on a laptop.  Both products complement each other and work very well with MLV files.  Hopefully, the authors will continue improving them and making them faster and more efficient.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 16, 2018, 06:57:44 AM
@Bouncyball: here you are: https://www.dropbox.com/s/4tv2bj2b877skuc/100D_1800x1012_MvCropMode_ISO3200.MLV?dl=0
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 16, 2018, 09:04:53 AM
@IDA_ML: if you like only fast export: deactivate RAW Corrections, set profile to a LOG curve and set in export settings AMaZE to Bilinear. Now your export should be more than 2x faster (in my example from 22sec to 9sec for exporting a special clip). For me, speed and look is very similar then to what MLV Producer exports.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 16, 2018, 10:03:36 AM
Thank you IDA_ML for such a comprehensive feedback! :)

Edit: hmm... you can't... I could try to upload it somewhere else for you... but that will need some time @60kB/s :D
Thank you! I've downloaded them now :)
All files importing and can be processed here on Linux 64 bit w/o an issue or crashes after fiddling with sliders correction etc. At home I have my kids' computer with old CPU and windows 7 on it, but I don't have access to it ATM.

I see a very tiny difference in the low right corner of frame 1 (dark area)... but it is soooo small the difference...
Yes static magenta noise contaminating colors is quite low here so difference is really subtle, anyway you always can look at histogram, it changes in the dark/shadows part when activating deactivating DF.

Dark/Light Strengh/Range is different from black & whites & contrast in ACR. Maybe Ilia finds a way one day to add that additionally. I never missed it, because Dark/Light Strengh/Range can do more (it is only harder to understand what it does).
All is said about WB picker so I'm not stopping to discuss this further :)
Regarding Dark/Light Strengh/Range sliders used in MLV App. I fully agree with @masc, they are very powerful and nice to operate when you used to it. They almost substitute Curves editor b/c you can alter whole range of the histo. In addition we have highlights and shadows sliders which BTW present in the windows binaries I posted for older CPU compatibility ;) despite we did not release this feature officially yet.

Regarding noise reduction: there is only chroma blur function which kinda cleans color noise but this is not the full blown wavelet based noise reduction and should be taken with a grain of salt :)

4b: Hm... I don't know how to create special thumbnails. Could be another task for the future. ;)
Here (https://en.wikipedia.org/wiki/Windows_Imaging_Component) is the explanation how this could be done for windows with Windows Imaging Component (WIC). Sorry but this is really out of the scope of the MLV App itself :). However windows programmers are always welcome to implement this kind of stuff.

Regarding export or playback speed: these can be altered by optimizing mlv app debayering/processing and ffmpeg behavior.

AFAIK mlvp uses ASM level optimised stuff and is quite fast.
Fast CinemaDNG uses directly CUDA and is blazing fast on my GTX1080.

We know that there is a lot of room for performance improvement and we really appreciate if anyone with spare time and more experience willing to join the project and help out.

Edit: now higher priority is the new color handling stuff added by Ilia and we are testing it, this concerns also more advanced white balancing and occasionally WB picker.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 16, 2018, 11:02:52 AM
@Danne

Added DF validity check. If it has more than 1 frame MLV App warns with the message box but does allow to load file anyway. Why? ;)

Now I regret I did not introduce dedicated DF file format for our proggie for the mlv_dump's compatibility sake. mlv_dump does not correct framecount in the header of averaged DF MLV and it has full frame count of the original clip in the header. So there is nothing to check and if used mlv_dump made DF we can not check the amount of frames correctly. It will fail as any other non DF MLV (now it just warns you but allow to use mlv_dump made DF).

Anyway it is sometimes interesting to see the effect of the subtracting any image from any image so let it be there with just warning :D (I'm too lazy to dig into mlv_dump again :P, besides if someone has a collection of DFs made by switch they already are made by old not patched mlv_dump)

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 16, 2018, 11:44:25 AM
Bouncyball and Masc,

I really am very satisfied with how you reacted to our suggestions for improvements.  With this kind of positive attitude and listening to the users, I am sure, MLVApp will continue to improve and become more efficient and powerful.  Thank you so much!

Bouncyball,

It looks like, that not only you but also your kids with their old CPU computer saved my MLVApp life by allowing you to reproduce my problem.  This is the reason why I never throw away my old computers.  You never know when you may need to use them again :-)))!  May I suggest that, before releasing a new build, you make sure that it also works on your kids' old computer?

Masc,

Thanks a lot for your very useful suggestions.  Of course, I will continue testing in trying to optimize my workflow and will report my findings.

Danne,

I am trying to figure out the darkframe averaging stuff and w.r.t. that I have a question to you too.  How important is it that darkframe footage is shot at exactly the same settings, (F-stop, focal length, ISO, shutter speed, etc.) as the clip that needs noise cleaning?  Can't I just shoot some darkframe footage for every lens that I use, at some reasonable ISO, (say 800) and then use this footage for creating an averaged frame for all the videos that I film with that lens?  What if the settings are different from those the clip was shot at?  Noise is noise - it's a random process, right?  Then why should it depend so much on particular settings?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 16, 2018, 12:37:51 PM
@IDA_ML
What lens you are using won't matter(check flat frame subtraction for this. Also included in mlv_dump).
Also check some basics evolving df subtraction and where it's primarily used and why:
https://en.m.wikipedia.org/wiki/Dark-frame_subtraction

Reason it's used in movie sequences are availability and automation procedures.
Dark frame automation is what it is. Sometimes the impact will be major, sometimes not. Removing cold/hot pixels, cleaning magenta cast, color noise, banding in shadows etc. It won't destroy image like a denoiser which I think is important since df could then be used on any footage with any lenses all the time. It will have an impact even at iso 100. You can check this by raising shadow parts which reveals canon sensor flaws and how it's cleaned with df.
Matching iso is vital. Maybe even shooting the df right after the regular footage was recorded but I have been using darkframes recorded on a different time with great results.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 16, 2018, 02:01:15 PM
Thanks a lot, Danne, I will experiment more with dark frames and will do what you suggested.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 16, 2018, 02:26:08 PM
It looks like, that not only you but also your kids with their old CPU computer saved my MLVApp life by allowing you to reproduce my problem.
:D

May I suggest that, before releasing a new build, you make sure that it also works on your kids' old computer?
Sure. The reason of this issue is known and patch committed to the repository additionally with Ilia's fine tuning :)

Matching iso is vital. Maybe even shooting the df right after the regular footage was recorded but I have been using darkframes recorded on a different time with great results.
Danne's absolutely right, the roots of this suggestion came from the fact that when sensor is warming up the HW noise increases.

But we are not gonna process NASA photos, are we? :) So DF recorded with this particular camera and same settings earlier is OK.

BTW the video mode you are recording to also matters. Example: if you use same ISO for plain 1080p and crop_rec module enabled modes (even with the same resolution) the noise will be different because in some modes camera uses various bining and skipping, in some 1 to 1 readout and that 'in camera' processing affects output raw image, hence noise footprint.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 16, 2018, 03:13:24 PM
Thanks for this important clarification, Bouncyball.  Different noise at different shooting modes makes perfect sense.  I will probably generate several averaged DF at different ISOs and shooting modes for my 100D and use them whenever necessary.

At this moment another small improvement suggestion dawns on me.  Would it be possible to add to the "I" (information panel) the bit and compression settings for every clip, e.g. 8, 10, 11, 12 or 14 bits uncompressed or losslessly compressed video?  That would helpful too.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 16, 2018, 05:25:04 PM
Hmm... do you mean this info should be on the right side of the clip thumbnail in session list?

Otherwise here is the info panel examples with all the info you need (4th line from the bottom):

(https://thumb.ibb.co/c9pr4c/Screenshot_from_2018_03_16_20_13_53.png) (https://ibb.co/c9pr4c)

(https://thumb.ibb.co/mPbtHx/Screenshot_from_2018_03_16_20_14_46.png) (https://ibb.co/mPbtHx)

(https://thumb.ibb.co/iyePPc/Screenshot_from_2018_03_16_20_15_33.png) (https://ibb.co/iyePPc)


That info panel can be left open while double clicking on clips in session list and the info will update on every selection.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on March 16, 2018, 05:43:11 PM
Loving the app!  There is an old experimental version of the dual-iso.mo for the 5d2 that actually works pretty great!  The tough part was finding a post-processing workflow that worked for it.  The current version of switch works fine.

Unfortunately MLVApp has a hard time doing anything with it - my guess is that it's almost certainly a black level issue.

As I'm a complete fool for bleeding edge 5d2 stuff, I paired this experimental 12/10 bit build: https://www.magiclantern.fm/forum/index.php?topic=5601.msg198349#msg198349 (https://www.magiclantern.fm/forum/index.php?topic=5601.msg198349#msg198349)
with the dual-iso module, and attempted to do some darkframe subtraction as well.

Normal (non-dual) 10/12 bit stuff from that build works just perfectly in MLVApp.

By turning Switch to default settings, and then setting it to full-auto I was able to do 12 bit, dual-iso, darkframe subtraction in one fell swoop - which felt lucky.

Here's the problem - I end up with converted DNG's and would like to import them into MLVApp for editing/organizing.  I don't know of any way to repackage DNG's back into an MLV.

I know that's a lot of info, but I included some sample files, including the experimental Dual-Iso module here:
https://drive.google.com/open?id=1O2P64L0uvF3ai2GPuj3s5foJYL-rHyB9 (https://drive.google.com/open?id=1O2P64L0uvF3ai2GPuj3s5foJYL-rHyB9)





Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 16, 2018, 06:15:00 PM
Hmm... do you mean this info should be on the right side of the clip thumbnail in session list?

There is a shooting mode called "8 ... 11 bit lossless" and the camera selects 8, 9, 10 or 11 bits automatically, dependent on the light and ISO.  I am not sure if MLVApp can recognize if the clip was shot at say 9 bits or 11 bits or it will interpret these numbers as 8 or 10 bits.  This is what I mean.  Other than that, the Info panel is great!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 16, 2018, 06:49:38 PM
@IDA_ML

Ah.. yes now I got it.

It's not possible to tell exact bit depth of those MLVs b/c in reality they are 14bit with restricted values (with amplified gain).

One can approximately say that the footage is 12bit lossless if 4500<white level<8000 and 8-11bits lossless if white level is less then 4500. Otherwise real 14bit data has >15000 value.

However I don't think that implementing this logic to the MLV App will give us the chance to make reliable assumption. This was one of the main reasons I added white/black levels to the Info Panel's 3rd line from the bottom :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 16, 2018, 07:03:29 PM
Unfortunately MLVApp has a hard time doing anything with it - my guess is that it's almost certainly a black level issue.
I'm not sure what is the exact reason (full 20bit dualiso processing gives error and can not process this MLV). Preview mode does work. It is nice that you uploaded this sample. Can you also upload the dark frame original (not averaged) MLV for this 12bit clip?

Edit: Danne's doing some black magic with the switch/cr2hdr I guess ;)

Here's the problem - I end up with converted DNG's and would like to import them into MLVApp for editing/organizing.  I don't know of any way to repackage DNG's back into an MLV.
It is possible and g3gg0 was doing this long time ago for experimenting/developing. However I can not imagine the use case of that backward conversion now :)

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: a1ex on March 16, 2018, 07:08:20 PM
One can approximately say that the footage is 12bit lossless if 4500<white level<8000 and 8-11bits lossless if white level is less then 4500. Otherwise real 14bit data has >15000 value.

However I don't think that implementing this logic to the MLV App will give us the chance to make reliable assumption.

Using ceil(log2(white - black)) should be a reliable assumption, as this quantity is always 14 for 14-bit raw.

Examples:
ceil(log2(5586-2047)) = 12 (source (https://www.magiclantern.fm/forum/index.php?topic=19300.msg185746#msg185746))
ceil(log2(10500-2047)) = 14 (worst case; lowest white level I'm aware of at default settings is about 13500)

Displaying the fractional value of log2(white - black) should be fine as well, as you can see how many "bits" are lost because of the non-ideal black and white levels. In this case, the user can do the upper rounding to find the number of bits.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 16, 2018, 07:11:25 PM
Hehe :) fantastic! Thank you a1ex.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 16, 2018, 07:42:07 PM
Unfortunately MLVApp has a hard time doing anything with it - my guess is that it's almost certainly a black level issue.

By turning Switch to default settings, and then setting it to full-auto I was able to do 12 bit, dual-iso, darkframe subtraction in one fell swoop - which felt lucky.

Interesting finding. I downloaded your file and it worked with my older version of mlv_dump (m) passing the dng to cr2hdr but cr2hdr wouldn´t recognise the dng files as dualiso if run with mlv_dump_on_steroids.

(https://s17.postimg.org/sib5drs2n/Screen_Shot_2018-03-16_at_19.35.14.png)

Code mlv_dump versions:
mlv_dump(ml-dng version)
https://bitbucket.org/Dannephoto/magic-lantern/branch/ml-dng-unified_11f

mlv_dump on steroids:
https://bitbucket.org/Dannephoto/magic-lantern_steroids/branch/mlv_dump-on-steroids

After some more testing it works also with mlv_dump on steroids if you set mlv output to 14bit:
(https://s17.postimg.org/e0dy60t4f/Screen_Shot_2018-03-16_at_19.49.35.png)


You can actually force dng to process as dualiso in later version of cr2hdr. Grab cr2hdr inside Switch and do following:
Code: [Select]
cr2hdr --force [drag your dng here]
The file won´t look good though but it forces through 12bit.





Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on March 17, 2018, 01:52:13 AM
It is possible and g3gg0 was doing this long time ago for experimenting/developing. However I can not imagine the use case of that backward conversion now :)

After a (forced) update to High Sierra I am short on workflows for raw.  I used to use MLraw viewer but the .mov export no longer works on High Sierra.  MLVApp can't import DNGs (as far as I know) and premiere doesn't like the sequence either.  Even Lightroom crashes kinda frequently  after importing these  DNGs (although it's also been crashing dealing with standard 20bit dual iso files.) I haven't tried after effects yet.

So yes, it is backwards, but I'm low on options.

I will upgrade the dark frame in a few hours! It may not have actually worked as I tried it - it automatically ran dark frame subtraction without me providing mine.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 17, 2018, 06:48:57 AM
As Danne have stated it's because of cr2hdr (MLV App uses code derived from cr2hdr/mlvfs) needs real 14bit data on input to work properly. This is not the first time we have issues with 12bit dual iso MLVs. I'll take a look when have time and see what I can do about it. Guess it won't be hard to fix.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 17, 2018, 07:01:48 AM
@jpegmasterjesse

I guess you already have switch so grab mlv_dump from it and with this command convert bit depth:
Code: [Select]
./mlv_dump -b 14 -o output_14bit.mlv your_12bit.mlv
Then try to open it in MLV App, process as dualiso and report back please.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 17, 2018, 07:08:32 AM
Cool, didn't know you could convert the mlv file itself to other bits.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on March 17, 2018, 08:18:44 AM
Can you also upload the dark frame original (not averaged) MLV for this 12bit clip?

Here you go!
https://drive.google.com/open?id=1pMlInFFL2kb-TXY6rPeVbJTiWG8OXiYK (https://drive.google.com/open?id=1pMlInFFL2kb-TXY6rPeVbJTiWG8OXiYK)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on March 17, 2018, 08:25:09 AM
@jpegmasterjesse

I guess you already have switch so grab mlv_dump from it and with this command convert bit depth:
Code: [Select]
./mlv_dump -b 14 -o output_14bit.mlv your_12bit.mlv
Then try to open it in MLV App, process as dualiso and report back please.

I wish I had the necessary knowledge! I'm a bit out of my depth.  Here's the 12 bit dual-iso file:
https://drive.google.com/open?id=1W9IG53Nn-AG1EWKV-trCVyfpPNt5VtTA (https://drive.google.com/open?id=1W9IG53Nn-AG1EWKV-trCVyfpPNt5VtTA)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 17, 2018, 09:36:46 AM
@jpegmasterjesse

Here (http://nic.caucasus.net/mlvapp/?dir=&download=14bit-dual-5d2-M16-1054.MLV) is your MLV converted to 14bit
Here (http://nic.caucasus.net/mlvapp/?dir=&download=M16-1053_14bit_DF.MLV) is the 14bit Dark frame ready to use

Import this 14bit MLV to MLV App and also load 14bit Dark frame into the Raw Correction. Now full blown 20bit dualiso processing is working as expected :)
 
@Danne: Thank you for quickly finding the cause of this issue :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Lars Steenhoff on March 18, 2018, 03:18:40 PM
Is it possible to make a cocoa version with thumbnails and dng export?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 18, 2018, 06:14:59 PM
If you like thumbnails you need a kind of extra program which is automatically driven by the OS, which opens all MLV in a folder and makes thumbnail pics (as I understood). If you are using cocoa or something else doesn't matter.
DNG export works already with MLVApp (which also uses cocoa on macOS).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 19, 2018, 07:54:40 AM
Ilia is a father of coca app, let's wait what he says.

BTW I've always been curious why GUI matters so much if functionality is what you need :) (I'm the guy who never pay attention to theming/skins/looks of applications but its functionality).

Example: Simple default GUI of the foobar2000 player is the best for me.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ilia3101 on March 19, 2018, 08:53:52 AM
One thing where I believe the Qt app is worse than cocoa app is the control sliders, you can't just click anywhere on the slider and start moving it, you have to click the knob, which feels a lot clunkier to me. Could you make the slider draggable from any position @masc?
Maybe those who like cocoa app would be happier if the Qt version had a simpler theme, but that isn't really a big deal for me.

As for Cocoa app coming back, probably not. It's currently in a bad mess and doesn't work fully (the last release is about as good as it is going to get). It's just too much work for what it does - it was written without XCode, no interface builder which I think Apple never intends anyone to do. Also written by me with no clue about how Objective C works (the real issue).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Lars Steenhoff on March 19, 2018, 10:50:36 AM
Ah you made it without xcode, wow yea I can understand.   

For me the reason why I like the cocoa version, it feels more native to Mac, and it also is easier to compile.

But I managed to compile the qt version, so thats allright now.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 19, 2018, 12:14:46 PM
One thing where I believe the Qt app is worse than cocoa app is the control sliders, you can't just click anywhere on the slider and start moving it...
Haha, right. I never noticed this before :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 19, 2018, 01:48:25 PM
@jpegmasterjesse
Added -b(bit) function in a mlv_dump_on_steroids in Switch so it´s now possible to convert the MLV file itself for use in Mlv app for instance:

Select (12)
(https://s9.postimg.org/hayfknbi7/Screen_Shot_2018-03-19_at_13.55.52.png)

Select b for bits information
(https://s9.postimg.org/wjocyfcwf/Screen_Shot_2018-03-19_at_13.55.41.png)

Noticed that converting to different bits doesn´t work with lossless MLV files but works otherwise.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 19, 2018, 02:43:26 PM
@jpegmasterjesse, @Danne

I added 10/12bit Uncompressed dualiso support to MLV App (which is exactly your case). Link (https://github.com/ilia3101/MLV-App/commit/e0ffd06430227016ba06db5176db553341947cc6).

Lossless 8-11/12bit dualiso is not supported because it is very different and needs deeply digging into a1ex's cr2hdr code.

Anyway using dualiso means wide DR is needed, data bits less then 14 already restricts DR and this makes no sense b/c, during 14bit lossless raw recording, writing speed is good enough.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Bernie54 on March 19, 2018, 04:24:10 PM
MLV App v0.14 (latest version from bouncyball, btw, this now works well on a Core Duo PC - Thanks!) crashes at PNG Frame Export:

When trying to export single frames from a MLV taken with a EOS M (1728x692px) as a PNG file, Windows reports a crash an ends the app but a PNG was created with a black area - see example posted. This happens when the aspect ratio is set to "Height Stretch 1.67x" (works well with "Height Stretch 1.0x"). The bug appears on all the following configurations tested:
- MLV.App.v0.14.alpha.Win32 on a 32bit-Windows
- MLV.App.v0.14.alpha.Win32 on a 64bit-Windows
- MLV.App.v0.14.alpha.Win64.static on a 64bit-Windows

regards


(https://thumb.ibb.co/nkcAKc/Crash_PNG_Frame_Export_MLV_App_v0_14_win32_alpha.jpg) (https://ibb.co/nkcAKc)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 19, 2018, 04:51:30 PM
Nice.
I also noticed you can decompress and change bits in one take with mlv_dump and lossless will then become clean 10/12/14 bit or whatever you specify. For example apply this to a lossless file:
Code: [Select]
mlv_dump -d -b 10 -o OUT.MOV IN.MLVPretty nice.
As you point out dualiso is another parameter that will or will not work here...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 19, 2018, 05:29:47 PM
@Danne

Yes sure you can do both at the same time. But I think it is perfectly valid for real full range 14bit raw data only.

Losslessly compressed raw from the camera _always_ 14bits, even when you recording it as 8-11/12bit lossless with restricted values.

Converting 8-11bit lossless to, say 10bits, will result with very low converted to 10bit white level. For example as low as 350. Did you tried this and it worked as expected?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 19, 2018, 05:33:01 PM
I tried converting to 8bit back to 14bit. Sucked big time  :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 19, 2018, 05:33:47 PM
LOL
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 19, 2018, 06:39:36 PM
Another BUG in v. 014_old_CPU:
=====================

When I try to export Actual Frame, it exports it just fine as a .PNG file, even a thumbnail preview is shown in Explorer.  But when I try to open that PNG with Photoshop CS6, it (Photoshop) crashes.  It opens with FastStone Image Viewer and IrfanView fine but there is no EXIF data in that file.  I was wondering if the Actual Frame could be exported as a TIF-File containing all adjustments made in MLVApp, in the same resolution as in the video and if EXIF data could be added.

Also, MLVApp still crashes during rendering MLV files from the 100D that are about 1 GB in size.  I posted such a file a few days ago already but if you may need more files please let me know.  Could this stability bug be fixed?

AmaZe is AMAZING !!!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 19, 2018, 06:53:44 PM
As @Bernie54 stated in the message above there is a real problem exporting actual PNG frame. It is corrupted when the aspect ratio is set automatically to "Height Stretch 1.67x".

PNG corrupted example:

(https://thumb.ibb.co/b0hVKc/mv720_1736x688_Stretch1152_frame_1.png) (https://ibb.co/b0hVKc)


Exported TIFF frame is healthy.

@masc: Houston we've got a problem :) maybe something with buffer passed to QT image writer.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 19, 2018, 06:56:14 PM
@IDA_ML

Unfortunately I could not reproduce the crash on Linux with posted by you 100D MLV. Could you upload some more? I'll try it with older CPU under windows at home.

Edit: Fully processed frame(s) can be exported as 16bit TIFF through export settings dialog (ffmpeg exporter). For pixel peeping/quality checking it's the best.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 19, 2018, 09:18:47 PM
MLV App v0.14 (latest version from bouncyball, btw, this now works well on a Core Duo PC - Thanks!) crashes at PNG Frame Export:
When trying to export single frames from a MLV taken with a EOS M (1728x692px) as a PNG file, Windows reports a crash an ends the app but a PNG was created with a black area - see example posted. This happens when the aspect ratio is set to "Height Stretch 1.67x" (works well with "Height Stretch 1.0x").

@masc: Houston we've got a problem :) maybe something with buffer passed to QT image writer.

@bouncyball... no no, no qt problem... I was a little stupid here. @bernie54: thanks for reporting! That was my fault and I fixed it now.

Another BUG in v. 014_old_CPU:
=====================

When I try to export Actual Frame, it exports it just fine as a .PNG file, even a thumbnail preview is shown in Explorer.  But when I try to open that PNG with Photoshop CS6, it (Photoshop) crashes.  It opens with FastStone Image Viewer and IrfanView fine but there is no EXIF data in that file.  I was wondering if the Actual Frame could be exported as a TIF-File containing all adjustments made in MLVApp, in the same resolution as in the video and if EXIF data could be added.

Hm, strange. I have no problem to open it in PS. There is no EXIF in the png, that is right. You can exort as TIFF via normal export. You should set cutIn and cutOut if you want only one frame.

Also, MLVApp still crashes during rendering MLV files from the 100D that are about 1 GB in size.  I posted such a file a few days ago already but if you may need more files please let me know.  Could this stability bug be fixed?

"Unfortunately" I don't get MLVApp to crash on my computers with your file - that's why I don't know what to fix :(

One thing where I believe the Qt app is worse than cocoa app is the control sliders, you can't just click anywhere on the slider and start moving it, you have to click the knob, which feels a lot clunkier to me. Could you make the slider draggable from any position @masc?
Maybe those who like cocoa app would be happier if the Qt version had a simpler theme, but that isn't really a big deal for me.

Hehe, yes - there is another functionality in Qt: let the sliders jump in steps. I can set a step width. And if you click in the left or right of the handle, the slider jumps this width. At least I like this Qt feature - but it might be different from clean cocoa. But unfortunately I don't get the cocoa version compiled on my system... so I can't test atm how the sliders work there.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on March 19, 2018, 09:34:18 PM
It took some time, but now i added a Table of Contents to the english version of my mlvapp-compile guide for linux: https://sternenkarten.com/tutorial-englisch/
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 20, 2018, 08:46:00 AM
@escho: Great! :)

@masc: Now PNG frame export works flawlessly :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 20, 2018, 10:28:57 AM
Could need some help with compiling on mac. I get the following error codes:
(https://s9.postimg.cc/dz5n83u8f/Screen_Shot_2018-03-20_at_10.37.59.png)

(https://s9.postimg.cc/h606rqme7/Screen_Shot_2018-03-20_at_10.38.07.png)

(https://s9.postimg.cc/a2sbc3ttb/Screen_Shot_2018-03-20_at_10.38.13.png)


After some tinkering I removed an older Mlv app project and now QT is asking for stuff. Maybe this could clear out a few issues?
(https://s9.postimg.cc/eiaqgwo2n/Screen_Shot_2018-03-20_at_10.58.18.png)

(https://s9.postimg.cc/e49ehw45b/Screen_Shot_2018-03-20_at_10.58.28.png)

(https://s9.postimg.cc/d1z7zcdm7/Screen_Shot_2018-03-20_at_10.58.37.png)


Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 11:32:14 AM
@Danne: If I see it right you are on Qt 4.8.7. Minimum Qt for MLVApp is 5.6. So the compiler won't find some things we are using. The most compatible version should be 5.9.4 atm (support for most OSes), best performance should have 5.6/5.7.
On the "Configuration Project" page chose "clang 64bit" Release (& Debug if you like to debug).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 20, 2018, 11:37:21 AM
I compiled with Qt 5.10.2 on my mac mini without problem, however @masc doesn't like this version ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 11:55:51 AM
Hehe... I don't want to say I don't like 5.10. But 5.10 dropped support for some OS and has some stupid slider bugs. :)
But I recognized with my tests, that 5.7 is way faster then the newer versions. For me nearly factor 2 at playback on a MBP-Retina on OSX.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 20, 2018, 12:03:18 PM
Something is conflicting. I downloaded qr creator 5.9.3 and that is what I'm opening up but still it seems I have som old version still in there as well.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 12:09:07 PM
You downloaded only Creator, or the whole Qt? What does it output?

Here it looks like that:
(https://image.ibb.co/cehXzc/Bildschirmfoto_2018_03_20_um_12_09_57.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 20, 2018, 12:10:41 PM
But I recognized with my tests, that 5.7 is way faster then the newer versions. For me nearly factor 2 at playback on a MBP-Retina on OSX.
It is very interesting! I have to try this version under Linux. Is it performing better under windows too?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 12:13:02 PM
@bouncyball: I don't know. Under Windows my 32bit 5.6 is slower than your 64bit 5.9.1 - but 32 vs. 64 bit ... that is no real comparison.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 20, 2018, 01:17:29 PM
There is nothing when checking "kits".

When checking "about" this is showing:
(https://s9.postimg.cc/ve3nlgqbz/Screen_Shot_2018-03-20_at_13.21.01.png)
Qtcreator 4.4.1 based on 5.9.3??

Anyway. Here is what I downloaded and installed:
https://download.qt.io/official_releases/qt/5.9/5.9.3/qt-opensource-mac-x64-5.9.3.dmg
Coming from here:
https://download.qt.io/official_releases/qt/5.9/5.9.3/

It would really help if you would point to direct download links of which qt version most likely will work. In this particular case it´s even more problematic as since there are open source versions, commercial versions, the need for email adress etc. And the file itself is around 3.5gb  8)

Hopefully you can help me solve the issue :)


@bouncyball. Howdid you install QTcreator on your mac mini?


Ok, think I´m on to something:
Reinstalled and selected macOS this time:
(https://s9.postimg.cc/clwdvee3z/Screen_Shot_2018-03-20_at_14.02.48.png)

Now I get this:
(https://s9.postimg.cc/vqzn55l27/Screen_Shot_2018-03-20_at_14.06.38.png)

Will try to compile in a while....
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 20, 2018, 02:10:11 PM
Wohoo, compiling:
(https://s9.postimg.org/hodpq3v33/Screen_Shot_2018-03-20_at_14.17.40.png)

It´s smaller in size 38mb as opposed to 64mb from official version.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 20, 2018, 02:36:56 PM
@Danne

Congrats!!! Welcome to our club :)

Official version includes ffmpeg in the archive and also .app has structure with needed files.

You can compile it as debug or release version. Debug is good if you will find the bug/crash and the Qt creator debugger will show you exact line in the code where bail out has happened. Otherwise the release version a bit faster than debug version.

Hehe since you are real BugBuster I hope you will reveal some nasty ones, if any :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 03:06:00 PM
Woohoo, it works! NICE! Yes, you need to install Qt for macOS, otherwise you have no libs...

Your version is now smaller, that is right. It will work for now only on this particular mac (or another mac where Qt is installed in exactly the same way). The app gets its libraries from the Qt installation directory.

With (at least on my system)
Code: [Select]
/Applications/Qt5.9.0/5.9/clang_64/bin/macdeployqt <path to MLVApp>/MLVApp/platform/build-MLVApp-Desktop_Qt_5_9_0_clang_64bit-Release/MLV\ App.app/ (adapt that to your system) you can insert the Qt libs into the app. But do this only once! If you compile after that again, the links inside the app are broken - it would not work on another mac,