Magic Lantern Forum

Using Magic Lantern => Raw Video => Raw Video Postprocessing => Topic started by: ilia3101 on July 08, 2017, 10:19:19 PM

Title: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 08, 2017, 10:19:19 PM

Ṃ𝕃Ṽ ÀᵖṔ

Download the latest here! (https://mlv.app/)



MLV App is the world's only software for raw video that combines
native MLV support with a familiar photographic editing workflow!


(https://user-images.githubusercontent.com/30245296/110171956-c4af8580-7dfc-11eb-81a9-769ddc2c879c.png)


Cinematic results are effortless in MLV App...


Sample videos:









(If anyone has suggestions of nice cinematic videos processed in MLV App that could be added here please tell me!!!)



If you are new to MLV App, this will teach you almost everything about using it:


То же самое видео, но на русском (https://www.youtube.com/watch?v=X17jzHjuHOo)


Useful links:

"Compiler" app/script for macOS (https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/mlv_app_compiler.dmg) by Danne (source (https://bitbucket.org/Dannephoto/mlv_app_compiler-git/src/master/)) - very easy way to compile on macOS

Guide for compiling MLV App (Linux) (https://seescho.wordpress.com/tutorial-englisch/) (and in German (https://seescho.wordpress.com/fotos/ml/)) by escho (thx :) )


(some stuff from original post...)
Quote
I began doing this this due to general frustration with Adobe, having to convert to DNG, and not being able to run MLVProducer(or any all in one solution) on my Mac. I began doing it, then Footage came along (btw good work martin), which was really exciting, but that never fixed the black level issue on elcapitan, so I continued.

I've had a lot of help with figuring stuff out on here: http://www.magiclantern.fm/forum/index.php?topic=19270.0 (http://www.magiclantern.fm/forum/index.php?topic=19270.0)
Thanks g3gg0 and a1ex and Danne.
And thanks to everyone who is developing: masc, bouncyball... all who wrote GPL code used in the app
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 08, 2017, 10:35:47 PM
This is great. I see the groundwork to something really useful and with a lot of potential. I will check this out asap. And also great that you publish early stages. Easier to follow.
Just checked with the binary. COOL. Would love to be able to use it in some of my scripts  :P
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 08, 2017, 11:58:43 PM
Would be great to see it used with your scripts! I'll add a command line version that will work similar to mlv_dump, which would be useful for integrating with scripts (and would work on Windows and Linux!)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: DeafEyeJedi on July 09, 2017, 12:01:32 AM
What have you been smoking @Ilia3101?!?!

You literally brought me back from the dead, no joke. :D
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 09, 2017, 03:47:06 AM
Nice going  :D , did a test and it crash just a black screen loaded the MLV no problem its a 14bit from my 5d2
here what the command line in terminal said.
toshibai7:~ reddeercitytv$ /Users/reddeercitytv/Downloads/MLV\ App ; exit;
2017-07-08 19:10:29.036 MLV App[1708:29213] Screen width: 1920, height: 1080
2017-07-08 19:10:29.036 MLV App[1708:29213] Physical RAM: 16384 MB
2017-07-08 19:10:29.036 MLV App[1708:29213] CPU  threads: 8
[ 2.3260, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.5108 ]
[ 2.3260, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.5108 ]
[ 2.3260, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.5108 ]
[ 5.3437, 0.0000, 0.0000 ]
[ 0.0000, 2.2974, 0.0000 ]
[ 0.0000, 0.0000, 3.4709 ]
2017-07-08 19:10:41.778 MLV App[1708:29213] unlockFocus called too many times. Called on <NSButton: 0x7fbd69c55b80>.
2017-07-08 19:11:42.953 MLV App[1708:29213] New MLV file: /Volumes/2TB Raid 0/Dans House Demo/CF Cards/Lexar1066x64GB/100EOS5D/M19-0957.MLV, strlen: 81
Block #   0  |  MLVI  |       52 Bytes
Block #   1  |  RAWI  |      180 Bytes
Block #   2  |  INFO  |       16 Bytes
Block #   3  |  RTCI  |       44 Bytes
Block #   4  |  EXPO  |       40 Bytes
Block #   5  |  LENS  |       96 Bytes
Block #   6  |  IDNT  |       84 Bytes
Block #   7  |  WBAL  |       44 Bytes
Block #   8  |  STYL  |       52 Bytes
Block #   9  |  NULL  |       36 Bytes
Block #  10  |  RTCI  |       44 Bytes
Block #  11  |  EXPO  |       40 Bytes
Block #  12  |  LENS  |       96 Bytes
Block #  13  |  WBAL  |       44 Bytes
Block #  14  |  WAVI  |       32 Bytes
Block #  15  |  VIDF  |  3070140 Bytes
Block #  16  |  NULL  |     1568 Bytes
Block #  17  |  NULL  |       36 Bytes
Block #  18  |  LENS  |       96 Bytes
Block #  19  |  VIDF  |  3070300 Bytes
Block #  20  |  NULL  |     1568 Bytes
Block #  21  |  VIDF  |  3070432 Bytes
Block #  22  |  NULL  |     1568 Bytes
etc. ........
Block #3013  |  VIDF  |  3070432 Bytes
Block #3014  |  NULL  |     1568 Bytes
Block #3015  |  VIDF  |  3070432 Bytes
Block #3016  |  NULL  |     1568 Bytes
Block #3017  |  VIDF  |  3070432 Bytes
Block #3018  |  NULL  |     1568 Bytes

MLV Info

      MLV Version: v2.0
      File Blocks: 3019

Lens Info

       Lens Model: EF24-70mm f/2.8L USM
    Serial Number:

Camera Info

     Camera Model: Canon EOS 5D Mark II
    Serial Number: ######## (I blanked the serial number)

Video Info

     X Resolution: 1872
     Y Resolution: 936
     Total Frames: 1392
       Frame Rate: 23.976

Exposure Info

          Shutter: 1/46.8
      ISO Setting: 100
     Digital Gain: 0

RAW Info

      Black Level: 1791
      White Level: 15000
     Bits / Pixel: 14

CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.
CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces.


Edit: tried again and still black screen with the same warning "CoreAnimation: warning, deleted thread with uncommitted CATransaction; set CA_DEBUG_TRANSACTIONS=1 in environment to log backtraces."

File loads in mlvfs no problem , could it be a issue with Video Card/GPU ? i run a PC GTX 760 2GB Vram on Yosemite 10.10.4
didn't try on my mp5.1 with Sierra 10.12.5 yet .

Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 09, 2017, 04:27:27 AM
This also gives me a idea , since you can decode mlv i was thinking of a plugin for FCPX
Something along the lines of a RED RD3 file , which was it's own raw engine for basic adjustment like your app
with different color space profiles (e.g. red log1 , red log2 etc. ...) then debay it half size (proxy) for editing
then switch to full res for rending . I have tried the RED plugin for FCPX with sample 6K Weapon files and works great .
Really the big problem is importing the image sequences , need same kind of
data base server to tell fcpx there is "####" number of frames like compressor or A.E. . This is something that use too
work in old FCP with DPX file ( i been working off and on with this in FCPX --some success)
but now if you what to import DPX in to FCPX you need a translator (makes a reference QT file from the DPX).
Sorry Off topic , i can see this being very helpful & useful in further developments .
Keep up the good work @Ilia3101 8)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 09, 2017, 01:39:19 PM
Hi Ilia3101. Really like the image quality you already achieved.

Regarding white balance calculations and color matrices dng.c in MLVFS(dmilligan) is a good source.
https://bitbucket.org/dmilligan/mlvfs/src/24ebdf591dba0a0431cf1fb674b3a8fcd2730b62/mlvfs/dng.c?at=master&fileviewer=file-view-default
Row 61-167, color matrices for most cams.

Regarding white balance there is matrice conversion code in ufraw which dmilligan wisely put to use in MLVFS. Code also used in mlv_dump for steroids and in mlv_dump in cr2hdr.app. It works very reliable.
In dng.c row 265-474
I believe numbers are calculated with matrices in mind and kelvin number from MLV metadata. Code also respects canon other white balance modes and also from when manually setting white balance from cam. The only mode left out actually is awb(auto white balance). 

*update
Notice you already put in the matrices. Oh well. Maybe ufraw stuff could be of use...
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 09, 2017, 02:14:55 PM
@DeafEyeJedi yay! (many things)

@reddeercity About that crash, if it is a black or frozen screen, try making the app window smaller, as it seems to stop displaying/updating when the image view when it is larger than the video's image resolution. The whole displaying/refreshing code needs a lot fixing. Also it's unlikely a gpu bug, as the whole app uses just the cpu (except whatever macos does to show the window). I get all the same errors in the terminal too.
Also agree that it would be great to make it in to a plug in for final cut, just don't know where to find info about how to do that, all I've found is how to make a final cut plugins with AppleMotion templates, not C  :(

@Danne Thank you :D I'm glad you like the image quality, I do think the colour is quite different from most raw converters which makes it interesting. I will have another go at implementing matrices + proper white balance. I already tried using the matrices from dng.c (that silly attempt is present in the code), but maybe I need to have a deeper look at the other functions in dng.c.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 09, 2017, 02:23:34 PM
Going through your mlv sources and see you already had the matrices there :).

About integration with other scripts and such I think a possibility to open up selected MLV files directly into MLV.app would be great. Something like MLV.app [drag MLV files here] enter
Anyway. Thanks for sharing. Wish I could learn this stuff and tag along the ride more in depth  :P
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 13, 2017, 08:33:34 PM
Hi, great job! For me your app works pretty good! I also own a 5D2 and the developped images are looking very well.

I downloaded your code and tried to exchange your GUI with a QT GUI. QT makes it cross platform. I get your code compiled in my project, but it crashes very often directly after these 2 init functions (initMlvObjectWithClip&mapMlvFrames). I tried to make it 1:1 to your app, but in C++. The window init seems to work without crash in the same way as you do, but the open MLV functions crashes as described. Any idea? Every (maybe) 10th try it does not crash, runs further and shows the printMlvInfo in my debug window  ;)

Quote from: Ilia3101 on July 08, 2017, 10:19:19 PM
The app is not mac specific... except the GUI, so there is potential to make it cross platform, if I (or anyone else) finds time.

Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 13, 2017, 10:58:39 PM
Oh my god! That is amazing. It's almost embarrassing to have someone work on my unfinished and amateurish code :-X I don't know how to fix the error, but I realised the make file is missing -lm and -pthread linking flags, I'm just lucky that Apple GCC/clang didn't give an error, don't know if that will help. Thanks a lot for doing what you are. I'll be back at a computer tomorrow and hopefully more helpful :D
@Danne what do you mean by drag and drop: drag on to the app window itself, or drag on to the app's icon?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 13, 2017, 11:32:53 PM
My idea of working the binary is to do something like following:
Drag MLVapp to terminal, then drag MLV files after, then hit enter:
MLVapp [Bunch of MLV files] enter
When I hit enter MLVapp opens up with the MLV files all lined up inside your nice gui. This way it could be integrated easily in other scripts and workflows just as a start off point. Of course command line usage could probably be more advanced with options for exporting prores dng files and other stuff.
Great progress masc as well. Interesting to see where that takes you.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 14, 2017, 07:14:34 PM
Got it Danne, so basically it should work similar to mlv_dump, I didn't understand first time because I've never thought of dragging stuff and just typed it before.
Will put (int argc, char * argv[]) to use now!
It can't have files 'lined up' yet, although that's something I will work on - may be limited to 1 file for now.

Also @masc, I've been testing a few mlv files and it seems my mlv reading is unstable/crashy with older (like mostly pre 2014) or imperfect/unusual mlv files, are you testing on your own newish mlv files? I also get random errors like segmentation fault 11 sometimes(rarely) for no reason at all(can't be reproduced with the same files or actions) - it's pretty buggy right now. But I'm not sure how to really help you right now. Also what system are you running it on... Mac, Linux or Windows?

Some major (internal) changes (caching) coming to the github repository soon! (@masc, they're only internal, gui's functions calls can stay the same, tho some macros are now functions)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 14, 2017, 09:16:23 PM
@Ilia: hm... the mlv's on my system are not the newest. Maybe I should create some with the new nightly and test again.
I use a MBP, OSX 10.11 and Qt 5.9 with clang64 compiler.

I don't get errors. The whole program crashes, so I don't get any information what could be the problem. It happens always just after these two init functions (I commented out the GUIs code after the two init functions for testing inside the open mlv function, the render thread is deactivated for testing as well).

I also tried to compile on Windows, but the compilers (MinGW / Visual Studio) have problems with the SSE2 code parts - so I can't test here easily.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 14, 2017, 10:00:47 PM
@Ilia:
Okay... I tried a brandnew MLV file - but it happens the same.
You printf sometimes this "matrix" ... sometimes there are values [2.3260, 0.0000, 0.0000.... and sometimes I get something like this:

[ -912946357866009707526990653213028058425336148150934686018973565099782945134279966991682517003694157252210673599290002487573580196204258818785280.0000, 14761107278647887298426725252265747037704052213684974621093726581945448424887939218053855964164182298671129527261323489121239772820396108337520159850961657576485312434110972051719515956941968841375744.0000, -5889634654216064054910380984756813016681168569942410618451110124988385579113543784074450534795619622018286200283437444381438824073396224.0000 ]

Is that right?! Can that be the problem?!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 15, 2017, 12:28:53 AM
Oh yes! That must be the problem, thanks for letting me know, I've had the insane long value problem before, probably for other reasons (and fixed it)... could you please share a sample MLV file that is causing those problems so I can have a look? Sorry I didn't reply quickly ::)

And apologies for the insane amount of printing... More is coming with next commit :D
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 15, 2017, 10:18:45 AM
I got it: freeMlvObject is the problem! On first try to open a mlv file, the free commands will crash the app. If I comment it out, the openMlv function ends without error and I can get the file informations. :-)

Hu... sharing the MLV is not easy. My connection is really slow. But I can try to create a very small mlv file which does the same.

Edit: for getting these values, I only run the apps init function. That means, there is no mlv file loaded yet.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 15, 2017, 10:38:29 AM
Just shorten a file with mlv_dump:
mlv_dump -f 5 -o OUTPUT.MLV INPUT.MLV
Gives you a 5 frame MLV file.
Good work by the way masc.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 15, 2017, 03:31:00 PM
@masc Ah! yes I know, sometimes the insane matrix values appear depending on what order you do/initislise or join the 'objects', I guess you might be doing something a little differently with order of stuff in your user interface code. I guess MLV files may not have been the problem, but if possible please still share a mlv file of maybe 3-5 frames, I don't have enough samples form other people really.

@anyone Be honest: is the code awful? Was it right of me do the 'object-oriented' C approach? Should it be in C++? (I just don't know that language yet)

I've uploaded a new release on GitHub with caching, so should be quicker (updated first post link), do read the release though, or your RAM will be full in no time at all ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 15, 2017, 08:25:18 PM
@Danne: thanks, I sent a small mlv to Ilia, hope it helps!

The best work did Ilia. The project is really not small, and for a hobby project it is much more then okay, I think. Respect! The 'object orientated C' is a way you can go. I know a lot of libraries which are programmed in this way. So, if the code does what it shall do, that's good.

I'll check your new release! :-)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 16, 2017, 12:37:40 AM
I really appreciate the generosity and work of @masc, it is leading the app towards being cross platform and amazing 8)

@Danne I have implemented drag and drop:
Quote from: Danne on July 13, 2017, 11:32:53 PM
MLVapp [Bunch of MLV files] enter
Only for one file right now though. Download link in first post is up to date.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 16, 2017, 01:03:16 AM
Works nicely over here for that one file. Good work Ilia3101.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 17, 2017, 01:11:04 AM
I will stop the frequent posts after this... but I must announce: It now has .BMP sequence export, so now more useful for testing. It is an awkward solution.

Made a preview though with some MLV files I could find:


.MLV converted with MLV App, edit in FCP10, and if you think it looks unsharp - there's zero sharpening added, as MLV App can't do that yet and I didn't want to alter the image with other software.

We are on the way to free software MLV workflow (by we I mean me :D)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 17, 2017, 01:22:31 AM
hehe, so cool. Why BMP?
There is also exr and dpx  :P And what about ProRes4444?
Please do keep posting. Very exciting.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 17, 2017, 01:24:09 AM
Only reason is because it's the only format I've figured out how to do right now :D, prores and others definitely coming soon/eventually
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 19, 2017, 08:20:37 PM
Announcement: JPEG and PNG export is added to MLV App. Download (https://github.com/ilia3101/MLV-App/releases/tag/v0.10-pre-alpha-jpeg-png-edition)
(Ultimate goal is still ProRes)

Big announcement!!!
@masc has been doing amazing work with his Qt version of the GUI. The app is now pretty much cross platform. (@masc I hope your okay with me announcing this?)
We've had some back and forth messages, and as far as I know: it compiles on macOS, Windows, and still bugging out on Linux (fault of my messy code). Here's how the Qt UI looks:

(http://image.ibb.co/b9NL9k/masc_gui.png)


@masc, can you try and compile a build for Windows and macOS and make a release on the GitHub page? No hurry, I'll try to get QT up and running and compile it myself too (I don't want to be bothering you with things like that in the future). Or is it too early?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 19, 2017, 08:27:14 PM
Beautiful work guys. Can't wait to try.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Wayne H on July 19, 2017, 09:18:08 PM
Excellent, will be following closely to see how this app develops, looks promising so far.

Do you plan on implementing some code so it can handle MLVS with lossless compression?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 19, 2017, 09:49:17 PM
@Wayne yes definitely will be adding it in the near(est) future, the app is open source and the code for lossless decompression is out there - lj92.c (https://bitbucket.org/dmilligan/mlvfs/src/24ebdf591dba0a0431cf1fb674b3a8fcd2730b62/mlvfs/lj92.c?at=master&fileviewer=file-view-default) - so implementing it should be problem-free, however when I look at it, it seems insanely confusing and I have no clue how I'd use it and what functions to call - I would like help with doing that if someone knows how to use it  ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 19, 2017, 10:29:05 PM
@Ilia: hehe, thanks. I'll try that tomorrow.
@everyone: yes, it is early to prerelease it. We have still lots of bugs. But maybe someone (like me) has fun with it ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: jpegmasterjesse on July 20, 2017, 06:42:46 AM
Looks interesting - but when I open an MLV file the GUI closes and I get something like this in Terminal:

https://drive.google.com/open?id=0B1lCd952bWxQd2FnQTYwT0NtZTQ 
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Wayne H on July 20, 2017, 04:10:23 PM
@jpegmasterjesse Same for me too, i think the code needs to be compiled or something, not sure.

@Ilia gread work dude, looking forward to the new features discussed, batch export with proress 4444 and lossless compression GOLD, :)

Hey i wonder if apple sorted out the problem with exporting to prores 4444XQ, i remember Martin Hering saying that apple's development tools didn't support it, 4444XQ would be amazing (12bit) rather than 4444 (10bit)

Oh and Ilia, as you add new features i'll be happy to test and report any bugs etc, keep up the good work.
i'm so with you on why your making this new app, Magic Lantern has some great post software, but there still isn't a proper native MAC app that does everything, without tedius work arounds, that MLP app looks cool, but not a native mac app and no lossless compression support, and footage app was brilliant but needs batch export and that black level issue is a problem plus,Martin has disapeared off the face of the planet lol, so no updates. MLVFS is a great time saver, but it only spits out CDNG and i find working in da vinci a pain (personal Preferance) i LOVE FCPX,

Hopefully overtime this app will address all these teething problems.

Thanks again for doing this.  :D
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 20, 2017, 04:16:22 PM
Quote4444XQ would be amazing (12bit) rather than 4444 (10bit)
Prores4444 is as much 12bit as XQ.
XQ is for vfx and green screen mainly. I can't tell the difference inspecting output.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Wayne H on July 20, 2017, 04:27:35 PM
I always thought Prores 4444 was 10bit lol, must have got confused with proress 422HQ being the 10bit one, oh that's great, no need to even worry about 4444XQ then. Thanks for the correction :)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: flostro on July 20, 2017, 05:35:47 PM
"Apple ProRes 4444 XQ and Apple ProRes 4444 support image sources up to 12 bits"

https://images.apple.com/final-cut-pro/docs/Apple_ProRes_White_Paper.pdf

the ffmpeg encoder for example only supports ProRes444 with 10-bits
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 20, 2017, 05:58:26 PM
Quote from: jpegmasterjesse on July 20, 2017, 06:42:46 AM
Looks interesting - but when I open an MLV file the GUI closes and I get something like this in Terminal:
Hmmm, looks weird, its as if your video's frames repeat twice or something... Could you try with another MLV file, it should not happen... if it does, then we can investigate why it happens on your system, it it does not happen with other clips, you can send the MLV file that caused the problem... if you want... so I can try and understand why it happened. @Wayne H You get it too?, on all MLV files you try? If so, tell me what version of macOS you have and what era/what model of Mac you are on and @jpegmasterjesse please do that too if possible.

@Wayne H, yeah I think it's nice that the app can be taking full advantage of macOS in the Cocoa version and be cross-platform because there's a Qt version, I think Linux is particularly in need for such an app right now. For testing: just keep track of MLV App's GitHub release page (https://github.com/ilia3101/MLV-App/releases), and anything significant will be announced on this thread too.

(@main ML people) is the name "MLV App" okay? I feel it makes it sound too official. I was originally planning to come up with something more fancy, but I've started to like it a little bit.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 20, 2017, 06:40:01 PM
Okay. First buggy version of the Qt GUI is online on GitHub. ;)
https://github.com/ilia3101/MLV-App/releases/tag/QTv0.1alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.1alpha)
@Ilia: you can link it on the first post, if you like.
@All: have fun.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 20, 2017, 07:13:06 PM
Promising looking gui. No time to test this yet. For mac users. See to it to hold down ctrl button first time you open the app to bypass gatekeeper. Will test more later. Great efforts guys.
(https://s1.postimg.org/7184ot51b/Screen_Shot_2017-07-20_at_19.16.52.png)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Wayne H on July 20, 2017, 07:28:37 PM
@Ilia Yes the same thing happens to me, the app GUI closes and terminal opens, i'm currently running macOS Sierra 10.12.5 and using late 2016 MacBook pro.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 20, 2017, 07:34:53 PM
@Wayne H thanks, I'll do some more investigation/ testing on 10.12.5, I'm only using 10.11, so there's a chance its related to that.

@masc, I understand it seems to still have a lot of problems compiling on Windows and Linux, and its mostly down to the mlv / processing code, right?
So do you think it would compile with less difficulty if I refactored the code to fit the C standards more strictly? Things like declaring variables at start of scope etc...
(Also added link to first post)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 20, 2017, 07:47:55 PM
@Ilia: "a lot of problems" sounds so bad... no, maybe I take only the wrong flags for compiling. I only got a complete exe by compiling half with a -std=c99 flag and half without this flag. I know I should not do that... ;) Maybe there is someone out there knowing better solutions for such problems.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 20, 2017, 08:10:40 PM
@masc Ah, sorry, so its flag problem mostly, I'll be refactoring the code that needs it over time anyway. Been setting up Qt myself on a windows PC to see what I can do.
Also: I noticed the new Qt version(testing on mac) redraws slower (than the version you sent me a couple of days before) when dragging a slider, have you changed image output setup or compiled it with different flags or something? Otherwise, I probably made a change that slowed it down, all I can think of is the 'single frame cache', but that was to speed up redrawing in pretty much that specific scenario.
Oh wait, I figured out why... I saw before you were only using 2 CPU threads, but now I guess you're using all, and I noticed this slowness only happens when it says caching is active. Maybe its a good idea to use a bit less than all cores for caching? I just set the Cocoa version to be (all cores / 2) + 1.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 20, 2017, 08:41:37 PM
@Ilia: yes, you are right. Before I used only 2 cores, now all for background caching. Thats why it is slow when caching and fast when idle. But it is very fast, when I disable the processing in the code (getting 23 frames on my Core2Duo) ;-)

Edit: set it now to All-1, thats much faster in the GUI! Thx!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 21, 2017, 06:40:28 AM
Tried the Wins version and no joy !

(http://image.ibb.co/hE1c75/error_1.jpg) (http://imgbb.com/)

and

(http://image.ibb.co/kXhjn5/error_2.jpg) (http://imgbb.com/)

Win7 pro AMD FX8350 dual GPU's GTX580's
I'll try in on my dell laptop i5

Edit: Same thing on i5 Intel dell laptop Wins7 Pro , 8GB ram , gpu radeon HD 4300
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 21, 2017, 08:02:45 AM
 MP5.1 Sierra 10.12.5 dual quad core cpu (16 thread) 24GB ECC ram GPU GTX570 2.5GB Vram
Works here --but i have pink hi lights , are you using apple camera raw ?
happen when i drop the exposure to -2 something .
good job so far . 3x crop mlv from about 3years ago
(http://preview.ibb.co/ntDRZk/Screen_Shot_2017_07_20_at_11_41_44_PM.png) (http://ibb.co/dGFvS5)(http://image.ibb.co/iaNg0Q/Screen_Shot_2017_07_20_at_11_44_34_PM.png) (http://imgbb.com/)

The BPM export , FYI --in A.E. ACR & Resolve i don't have pink hi lights

(http://preview.ibb.co/gWGMZk/M27_1210_00145.png) (http://ibb.co/bFvtfQ)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 21, 2017, 08:19:44 AM
Same file in Footage.App --no pink hi lights .
(http://preview.ibb.co/mB4KLQ/Screen_Shot_2017_07_21_at_12_13_10_AM.png) (http://ibb.co/mKnH75)

What Color Space are you using ? sRGB ?
wonder it that could be a issue .
Anyways Great job --keep it going  :)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 21, 2017, 09:47:09 AM
Quote from: reddeercity on July 21, 2017, 06:40:28 AM
Tried the Wins version and no joy !

Win7 pro AMD FX8350 dual GPU's GTX580's
I'll try in on my dell laptop i5

Edit: Same thing on i5 Intel dell laptop Wins7 Pro , 8GB ram , gpu radeon HD 4300

Ups... thanks for trying it out! On my PC that does not happen, because the whole framework is installed. But I think I found out which libraries are missing. Will upload it this evening!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 21, 2017, 09:52:01 AM
@reddeercity, the pink highlihgts most likely are because MLV App reads the white level from the MLV files, I think most apps don't do that, and in that MLV file, the white level was probably too low, so the app was cutting off much of the information. In the next release I'll add an automatic correction if it seems unusually low, see if it helps. If it remains... I will have to research why everything else does better, maybe theree's a simple algortihtm to fix it to an extent. What about RAWTherappeee or one of the opensource apps, do they have these problems with the same file??

Also no, i'm no using 'Apple Camera RAW', I've made my own, which is the whole reason it can be cross platform.

Colour space: welll.... this one's not done yet, but I've had many conversations with g3gg0/a1ex/Danne and understand it, just had a few difficulties implementing so its not done yet, but I'm going to have another go at implementing colour space management, right now it is something along the lines of 'Camera RAW (RGB) Space - Probably Close to sRGB'

@masc Forgot to mentiion, I had the same issue as reddeercity running on PC - pentium n4200 laptop (not mine :D)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 21, 2017, 12:05:41 PM
I found it and updated the version on git. Some .dlls were missing...
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 21, 2017, 09:15:24 PM
Quote from: reddeercity on July 21, 2017, 08:02:45 AM
Works here --but i have pink hi lights , are you using apple camera raw ?
Could you please try again with with the same clip and this (https://github.com/ilia3101/MLV-App/releases/tag/v0.11-pre-alpha-white-level-repair) release? I've added auto white level repair, seeing if it helps. However I hear my GUI has problems with 10.12.5, so you may have to run it on a different Mac or wait for another Qt release, the mac you run it on makes zero difference... though it may in the future (once I figure out openCL and GPU ;))
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 22, 2017, 04:44:37 AM
Yea No Joy with that release , GUI fires up but crash when loading the same mlv files from before. The crossplatform MLV-App (Qt) version works on my mp5.1 on sierra 10.12.5 but not other ones , I'll try may mbp on Yosemite and report back .
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 22, 2017, 04:51:45 AM
Quote from: masc on July 21, 2017, 12:05:41 PM
I found it and updated the version on git. Some .dlls were missing...
Great thanks --GUI fires up but crashes on loading mlv file , the same one i've being testing in the previous posts with my mac
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 22, 2017, 06:12:25 AM
Testing on MBP Early 2011 Yosemite 10.10.5 , i7 , 8GB ram, GPU : Intel HD Graphics 4000
Version:MVP APP (Jul21 2017 19:56:17 @llia-EliteBook-2560p.local) White level Fix
Same thing pink hi lights with that special white level build . There no problem with the white level it's at 15000
as per the info from terminal as this app open up .

MLV Info
MLV Version: v2.0
      File Blocks: 728
etc. ......
RAW Info
       Black Level: 1791
      White Level: 15000
     Bits / Pixel: 14


Notice that the slider for adjustment did not register any number change for "1" see image below
(http://preview.ibb.co/fqksaQ/Screen_Shot_2017_07_21_at_9_17_52_PM.png) (http://ibb.co/jxffUk)

If i load the version: (MLV APP Jul 19 2017 19:15:46 @ilias-iMAC.home) main download with out white level fix the screen is black after i load the same mlv file  see below image
(http://preview.ibb.co/nnpw25/Screen_Shot_2017_07_21_at_9_31_51_PM.png) (http://ibb.co/iBmyFQ)

hope this helps .
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 22, 2017, 03:36:14 PM
@reddeercity thanks for testing, now I know that my RAW processing is not that great yet :D, still need to learn how proper highlight handling works :(, the reason the old version didn't work at all for you was not to do with white level, but rather the way I did GUI redrawing, so good to know I've fixed the GUI that didn't work on some systems before.

Don't worry about it not registering the numerical value on the sliders, I'll fix that soon, it does not affect processing, simply not linked up the text with the value yet.

Genuine question: Does anyone have any knowledge about how to fix pink highlights? What kind of algorithm is needed?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 22, 2017, 03:41:10 PM
Are they blown highlights? Dcraw get pinks when rebuilding blown highlights. I couldn't test this because the app closes upon selecting a mlv file. Mac os sierra 12.3.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 22, 2017, 03:49:23 PM
Quote from: Danne on July 22, 2017, 03:41:10 PM
Are they blown highlights?
Yes, they are blown highlights, but as reddeeercity said, pretty much every other piece of software showed less pink highlights, ACR, resolve, even footage. I have seen pink highlights in all of those softwares before, but it seems mine is particularly bad, so I'm wondering if there's an obvious/well known way of fixing them.
Quote from: Danne on July 22, 2017, 03:41:10 PM
Dcraw get pinks when rebuilding blown highlights.
Hmm, mine doesn't rebuild highlights at all, so is there something relatively simple that all raw converters do that I'm not aware of?
Quote from: Danne on July 22, 2017, 03:41:10 PM
I couldn't test this because the app closes upon selecting a mlv file. Mac os sierra 12.3.
Yea that's strange, I sometimes get that, I'm testing on Sierra 10.12.6 and 10.11, the way I've avoided it most of the time is either trying a different file, or opening files with a single click, then pressing open button in the dialog instead of double click, for some reason I've noticed it helps ::)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 22, 2017, 04:04:59 PM
I will try some fresh 14bit files later. Thanks for reminder. Good luch on highlights meanwhile. Sorry I couldn't help more on this issue.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: DanHaag on July 23, 2017, 01:09:43 AM
I always get a crash with "Segmentation fault: 11" mentioned in the Terminal window. No matter how often I try - it happens with all my MLVs (shot just a couple of month ago). Downloaded the Cocoa Mac app, using it on the latest Sierra 10.12.06.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 23, 2017, 06:20:40 AM
Quote from: Danne on July 22, 2017, 03:41:10 PM
Are they blown highlights?
Quote from: Ilia3101 on July 22, 2017, 03:49:23 PM
Yes, they are blown highlights .....
No , they are not blown hi light --that was the point of all this
I'll post frames with example of the hi lights thought different app shortly

Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 23, 2017, 08:50:22 AM
Ok here we go -- As you can see there's no blown out hi light as seen in your new app.
Top image is from A.E. ACR CS6 Cdng's from Quick-mount with mlvfs on my PC exported as a 16bit Tiff from A.E.ACR

(https://farm5.staticflickr.com/4321/35260941094_dae67af5e7.jpg) (https://flic.kr/p/VHTxjf)
A.E.ACR_M27-1210_00000 (https://flic.kr/p/VHTxjf) by RedDeerCityTV (https://www.flickr.com/photos/67942440@N06/), on Flickr

Bottom Image is from MLVProducer Exported as  a 16bit Tiff (tried to quickly match the 2 , close  :D )

(https://farm5.staticflickr.com/4323/36100868285_0cbc26b0fb.jpg) (https://flic.kr/p/X17opx)
mlvproducer_M27-1210_00001 (https://flic.kr/p/X17opx) by RedDeerCityTV (https://www.flickr.com/photos/67942440@N06/), on Flickr

I also export a ProRes4444 from A.E.ACR CS6 , if you would like to view locally (about 450MB) 
https://drive.google.com/file/d/0BxNY4d4Aa7KuOTJmcUJlX3VtcVk/view?usp=sharing

and also export a ProRes4444 from MLVProducer , if you would like to view locally (about 450MB)
https://drive.google.com/file/d/0BxNY4d4Aa7KudkdpaVZmOFl1TEE/view?usp=sharing

Here is the Original MLV(M27-1210.MLV) I being test with (1.13GB)
https://drive.google.com/file/d/0BxNY4d4Aa7KuaU5TX0ZQUXVyNkk/view?usp=sharing
hope this helps
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 23, 2017, 09:00:42 AM
Quote from: Ilia3101 on July 22, 2017, 03:49:23 PM
..... but as reddeeercity said, pretty much every other piece of software showed less pink highlights, ACR, resolve, even footage.
No sorry I think you miss understood , I Do Not See any pink Hi lights in those apps at all just in your new app.
I think maybe some how you are clipping the hi lights in the mlv raw decode ? or the conversion  to 8bit color space ?
Just a thought  ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 23, 2017, 03:38:27 PM
Quote from: reddeercity on July 23, 2017, 09:00:42 AM
No sorry I think you miss understood , I Do Not See any pink Hi lights in those apps at all just in your new app.
I think maybe some how you are clipping the hi lights in the mlv raw decode ? or the conversion  to 8bit color space ?
Just a thought  ;)
Ok I completely understand what you are saying now: the clip does not have blown out highlights (according to you)

I decided to investigate a little bit... (thank you for sending the clip)

Here's MLV App handling it:

(http://thumb.ibb.co/iUse5Q/MLV_App_Highlights.png) (http://ibb.co/iUse5Q)

...not too well

I tried opening it in RawTherapee, and looked like no highlights were blown:

(http://thumb.ibb.co/btqcs5/RT_Default.png) (http://ibb.co/btqcs5)

But then I turned off highlight reconstruction, it suddenly showed the highlights had no detail, similar to my app:

(http://thumb.ibb.co/jWatX5/RT_Highlight_Reconstruction_Disabled.png) (http://ibb.co/jWatX5)
 
However they were not pink like MLV App, but white instead, it is probably doing some kind of equal clipping.

Then I opened it in MLRawViewer, and the highlights looked like this:

(http://thumb.ibb.co/iqVGkQ/MLRaw_Viewer_Highlights.png) (http://ibb.co/iqVGkQ)

The brightest highlights had discolouration, suggesting MLRawViewer is reconstructing them.

Then I looked at highlights in darktable RAW converter:

(http://thumb.ibb.co/ctPLC5/Dark_Table_Highlights.png) (http://ibb.co/ctPLC5)

And results were similar to MLV App.

So I have concluded that the highlights in that video are clipped, but all of your software did a good job of reconstructing them (leading you to believe they were not clipped).
Thank you for starting the whole discussion reddeercity and sending me the clip, so now I can be certain that MLV App needs highlight reconstruction.

... the reason clipped highlights are pink is that green channel clips first.

If anyone has any links to info about how highlight reconstruction works, it would be greatly appreciated, but I think I have an idea of how it could be done.

@DanHaag, unfortunately I can't help at this time specifically, as those errors are hard to track down... especially when someone else is having it,
but that kind of error tends to eventually get resolved over time as the app gets more stable (from my experience).
If you want, you can send an MLV sample that causes problems for you and I can check if it's the file causing problems or not.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: DanHaag on July 23, 2017, 03:49:03 PM
That's all right, I'll just try your app again when you've developed it further and report back with more intel in case the error still keeps happening. Thanks for all your work so far btw.!  :)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 23, 2017, 07:16:40 PM
@reddeercity, ok it turned out basic highlight reconstruction is really easy and even most simple software should do it... New release (https://github.com/ilia3101/MLV-App/releases/tag/v0.12-pre-alpha-highlight-reconstruction-edition)

How it works:
Program checks if highest possible green value is below white (65535), and if it is, every green value that high will be replaced by an average of that pixel's red and blue channel.

Comparison gif:

(http://image.ibb.co/iZwpN5/reconstruction.gif)


@DanHaag cheers
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 23, 2017, 08:33:41 PM
I also added Ilias Highlight Reconstruction (for me that works really good!) to the Qt GUI. I deleted the BMP, JPG and PNG export but added a ProRes 4444 export (8 bit atm, we are working on more... ;) ).

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.2alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.2alpha)

Windows port comes in the next days (I hope).
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 23, 2017, 08:53:17 PM
Nice!

Just tested it though, and got this:

(http://image.ibb.co/fe5PN5/error_MLVApp.png)

I highlighted what I guess must have been the error ::) Seems to be a forgotten DLL or something (Got the same error on 10.11.6 and 10.12.6)

Now it's time to make the Cocoa GUI catch up to the Qt one :D still needs to : get native Apple video export working and add a play button.

A small request to people with other cameras:
My 5D mark II does not have 720p or high framerate mode, so could someone please send a sample file shot in 50/60p or 720p in Canon menu,
I want to get 1.66x desqueezing working for mv720/3x5, but first I need to know what the headers in those files say, and of course an mlv file to test on.

Thanks  ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 23, 2017, 09:10:27 PM
:( Sry for that, but QtWidgets is in the package, so I don't understand that. I compiled it on OSX 10.9 today. I'll search for a solution.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 23, 2017, 09:31:40 PM
Okay friends... new try! I uploaded it again, on my other mac with OSX 10.11 it runs now (had the same problem before).
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 23, 2017, 09:36:01 PM
Niiiiiice - works now!

Still looking for a high framerate/720p sample ;) ...anyone?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 23, 2017, 09:39:56 PM
When you say high framerate... in the QtGui the ProRes export is forced to 25fps at the moment. But will work on that as well. If someone has a highspeed sample, I would be interested too!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on July 24, 2017, 06:22:03 AM
@Ilia3101 Yes I can confirm on Yosemite 10.10.5 , no more pink hi lights  ;D
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: pc_bel on July 25, 2017, 04:02:23 PM
QuoteStill looking for a high framerate/720p sample ;) ...anyone?

Just sent by Wetransfer via PM.

By the way. I can't open any mlv in your APP. Every time I try, APP crashes. I'm using v0.2 alpha (Cross platform version) on Windows 10.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 25, 2017, 07:24:11 PM
Quote from: pc_bel on July 25, 2017, 04:02:23 PM
By the way. I can't open any mlv in your APP. Every time I try, APP crashes. I'm using v0.2 alpha (Cross platform version) on Windows 10.

Thanks for trying it out and giving a feedback! I have the same problem for nearly all my mlv files. The maximal file size I got opened was about 200MB. We did not yet figure out why it crashes on windows.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: pc_bel on July 25, 2017, 07:37:59 PM
@masc
Oh! sorry!!!.. You are the developer for the windows version... I thought was Ilia3101...
I'm waiting for an app to review mlv files without to need to convert to dng (I don't know why but can't make working MLVFS), so your app is my main hope!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 25, 2017, 08:59:56 PM
@pc_bel Thank you very much for the sample! I already got one from Danne, but having different ones is very important, so thanks a lot
I'm sorry... I hope the Windows issue gets sorted out soon, me and masc are having some DMs about it today, we may be close to finding the cause.

@masc, I'm sorry for not testing MLV App v0.2 yet (despite saying I'd do so this morning)... The laptop I used before has been stuck on Configuring Windows Updates 35% for hours :'( not sure what to do.

@reddeercity good ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: pc_bel on July 25, 2017, 09:14:41 PM
@Ilia3101 @masc

You are wellcome!!!... If you need some more sample, just let me know. Thanks for all your hard work. You are awesome.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 26, 2017, 10:25:23 AM
Nice! No more crashing on macOS Sierra 10.12.3
Exported to format png. Not bad. Files are looking really good. Any plans for dng exports ;).
Anyway.
How are prores exports in the cross platform version handled? Thought I read ffmpeg somewhere but I must have dreamt that.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 26, 2017, 11:06:59 AM
You didn't dream it ;) not sure about all the details of how masc's implementation works though, but it is definitely ffmpeg. The Cocoa version will hopefully get native macOS/AVFoundation powered prores export, but AVFoundation is taking me a while to figure out.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 26, 2017, 12:46:02 PM
Quote from: Danne on July 26, 2017, 10:25:23 AM
How are prores exports in the cross platform version handled? Thought I read ffmpeg somewhere but I must have dreamt that.
Yes, since version "Qt 0.2 alpha" we have prores export for Windows and Linux. I had problems to include a library version of FFmpeg. That's why I took the command line app to the package. So at the moment it is realized very easy: first a png sequence is rendered and then these pictures are converted to the mov. This is not optimal, because the pngs have only 3x8bit.  For the future I plan to take the library of FFmpeg, because we get more than 8bits... ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 26, 2017, 12:54:02 PM
I see, intermediate png. You should be able to get 10bit prores4444 out of ffmpeg. I run that in Switch.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 26, 2017, 08:32:13 PM
Right, it is 10 bit. Unfortunately the png output of Qt is only 8 bit... What do you mean with Switch?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on July 26, 2017, 08:34:58 PM
Switch, open source scriptbased macproject.
http://www.magiclantern.fm/forum/index.php?topic=15108.0

Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 26, 2017, 09:06:39 PM
Ah okay. Thx. I read that a time ago, great project... :)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on July 29, 2017, 02:41:07 PM
I uploaded a new version of the Qt app for OSX & Windows. The windows version has caching disabled, so we have only a view crashes, but it is a little slower. Now it crashes (for me) only on files >2GB. Have fun!
https://github.com/ilia3101/MLV-App/releases/tag/QTv0.3alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.3alpha)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on July 31, 2017, 11:24:13 PM
New release of Cocoa version! (https://github.com/ilia3101/MLV-App/releases/tag/v0.14-pre-alpha-prores-export-added-edition)

Has ProRes 4444 export. Finally!
It is a temporary solution as it uses ffmpeg, not AVFoundation, but it makes the app a whole lot more usable. Used masc's intermediate PNG method for now.
Note: When you export prores, the app will freeze with the spinning ball, this is it exporting, not a crash. Just leave it until done for a few minutes.

Also converted it in to a .app bundle - in it's current state where it uses ffmpeg, it cannot work outside the bundle as a command-line app, but this ability will be returned once it gains AVFoundation export, as it will be able to live as a single executable file.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 01, 2017, 12:03:06 AM
hehe, great progress!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on August 02, 2017, 01:19:23 PM
Fixed the main problem of the app's processing: poor highlight rolloff
There is now a 'Reinhard Tonemapping' option.

Comparison:
(http://image.ibb.co/i4ns4k/Reinhard_Highlights.png) (http://ibb.co/m1F1x5)
Tone mapping disabled on the left, enabled on the right.

Also it's different from highlight reconstruction, as it does not create new highlights, it simply avoids clipping existing ones.

New release on GitHub. (https://github.com/ilia3101/MLV-App/releases/tag/v0.15-pre-alpha-highlight-rolloff-edition)

Next step is adding audio support. Is MLV sound compressed?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 02, 2017, 01:24:14 PM
Looks very nice Ilia!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 02, 2017, 02:08:58 PM
Sound from MLVs not compressed it's pure PCM.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 03, 2017, 11:29:59 PM
Not bad, Reinhard tonemapping. I tried to export to ProRes4444 but couldn´t get a file out. After pressing button a prompt want s me to "open"? A folder perhaps :)? Anyway. Pressing open didn´t get me a file.

Speaking of tone mapping. FFmpeg seems to be doing something...
https://patchwork.ffmpeg.org/patch/4361/

Hable tonemapping?
Slide 140
https://www.slideshare.net/ozlael/hable-john-uncharted2-hdr-lighting
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on August 04, 2017, 12:07:11 AM
@bouncyball Thanks, working on sound currently

@Danne yeah, I guess the open dialog is confusing, its a slight hack I had to do before I put it in an .app bundle - I had to use an open dialog instead of a save dialog.
You are right: you choose a folder and it exports to there after you click open (the app & dialog freeze as if to crash, but you just need to wait a couple of minutes while it exports - it is in need of a progress bar, I promise I'll fix that soon)

And speaking of the "Hable tonemapping" - I came across it while looking in to tone mapping, just Reinhard was the easiest to implement - literally: value = value / (1.0 + value), but adding a better more complex tone mapping formula wouldn't hurt the performance at all, as the app precalculates a 0-65535 look up table (processing is done in 16 bit integers), instead of calculating all pixels individually. I might do that soon, as from what I've seen Uncharted2 mapping looks a little better.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 04, 2017, 12:43:48 AM
You´re right. I chose an unshortened file and as expected created PNG files and then...nothing :). Got this message. Last line.
2017-08-04 00:47:42.136 MLV App[85848:713418] Exported frame 143 to: /Users/dan/Desktop/MLV_files/test_Ilia/.temp_png/frame_00143.png
sh: (null): command not found


Does it mean I have 143 png files in a hidden temp folder?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on August 04, 2017, 01:15:18 AM
The files are most likely deleted by the app, but to check, do this in terminal:  defaults write com.apple.finder AppleShowAllFiles YES.

Then go to the export directory (that you chose) in finder, and if there is a greyed out looking folder called .temp_png, delete it, if not, then the app automatically deleted it and it's fine. You can then do the terminal command but with 'NO'

Not sure why it didn't work for you, did you use the executable file on its own outside the app bundle?

I've done the prores 4444 export on videos up to 245 frames long by the way ;D
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 04, 2017, 01:18:19 AM
I compiled from source "make" and double click the mlv app binary. Gui opens and terminal window is also opened.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on August 04, 2017, 01:23:04 AM
Ah I see! The way I've got the makefile set up is: you need to type 'make app' not just 'make', if you want an app bundle.

There's a whole shell script and a compiled+executed c program inside the makefile that builds the app bundle during the make process.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 04, 2017, 01:50:25 AM
Now that is badass. Got my first baby ProRes :)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: DeafEyeJedi on August 04, 2017, 01:54:55 AM
@Ilia3101 continues to make waves. This is all indeed badass!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 04, 2017, 02:06:15 AM
Yes. You can make a "log"-like prores with corrected white balance in no time. Makes all the difference. The file comes out looking real nice.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: pc_bel on August 04, 2017, 10:46:51 AM
Hi,
Now with v0.3 alpha I don't have any crash!!!! :) but I can see... nothing. Just pink noise. I'm playing 14bit lossless files in the qt version of the app.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 04, 2017, 11:58:22 AM
Quote from: pc_bel on August 04, 2017, 10:46:51 AM
but I can see... nothing. Just pink noise. I'm playing 14bit lossless files in the qt version of the app.

What platform do you use? And what size do the files have? I am not sure, if the code from @Ilia supports lossless already.
I get a lot of pink noise when (normal) mlv files are bigger 2GB, on both, Mac & Windows. We have plans to avoid that in future...
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on August 04, 2017, 03:21:57 PM
I haven't implemented lossless yet, but I looked at the lj92 library yesterday, and it looks kind of understandable actually.

I'll try to send a commit to github with lossless today.

@Danne Soon we'll add options for ouput curve, featuring a few different variations of log. I think I've found a seemingly good explanation of how to generate a log curve: http://renderstory.com/log-color-in-depth/ (http://renderstory.com/log-color-in-depth/)

Quote from: Danne on August 04, 2017, 02:06:15 AM
You can make a "log"-like prores with corrected white balance in no time.
Enabling Reinhard + using the lighten adjustment actually shold give a similar curve to log, except for the shadows probably.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: pc_bel on August 04, 2017, 06:06:38 PM
Oh!!! Sorry. I didn't notice that lossless is a To Do think.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on August 05, 2017, 06:18:16 AM
Good morning!!!1!!!!!!!

Lossless is added. (https://github.com/ilia3101/MLV-App/commit/a990912b869823f9926478a01b42dddc379d9753) Have fun, 5D mark III users :D

Download New Release (https://github.com/ilia3101/MLV-App/releases/tag/v0.16-pre-alpha-lossless-edition)

The LJ92 decompression library is fast af.

Or wait for @masc to make a release of the Qt version if you want a more stable and featurefull app :-X
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: mesebar2 on August 05, 2017, 09:58:18 AM
Thank You, Ilia3101!!!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 05, 2017, 11:08:17 AM
hehe, great work Ilia.
By the way. If anybody wants to unhide hidden folders I found a short command for this:
Hold down CMD Shift . (dot)
Just redo it to go back to hidden again.

I did this to delete the png folder after interrupting processing.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 05, 2017, 01:44:11 PM
Quote from: Ilia3101 on August 05, 2017, 06:18:16 AM
Or wait for @masc to make a release of the Qt version if you want a more stable and featurefull app :-X

Thanks to @Ilia3101! Here comes the Qt version, at least for OSX (Windows version has to be compiled, but atm I have no PC nearby):

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.4alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.4alpha)

New in this version:
- Lossless support
- Reinhard tone mapping
- Full bit depth ProRes 422 Proxy, LT, Standard, HQ and 4444 export
- Multithread export
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Wayne H on August 05, 2017, 03:06:46 PM
Excellent work @masc and @Ilia, superb progress, just ran a lossless file, and exported to prores 4444 really well, quick question though, you say it supports full bit depth, does that mean prores 4444 is exported to 4444 12bit??

Danne kindly pointed out that you really can't see any quality difference between 10bit and 12bit prores files, which for the most part i agree, but i use colour finale within FCPX alot, so every extra (bit) help's,

so i just wanted to know, if the 4444 files are 12bit, or did you just mean the exported prores files are all now 10bit, as previously this app was only producing 8bit 4444 files.

Many thanks.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 05, 2017, 03:55:27 PM
Big difference between 10bit and 12bit prores4444. What I pointed out was the quality between 12bit prores4444 and 12bit prores4444XQ.
What is the winning deal in this app is that you retain scene referred dynamic range prior to export. This can't be done in apple compressor for instance. I'd take FFmpeg 10bit prores4444 scene referred log before display referred apple compressor XQ files any day of the week.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Wayne H on August 05, 2017, 05:24:22 PM
Hi Danne, thank's for correcting me once again :), you was indeed referring to 4444 12bit vs 4444XQ 12bit,my bad lol, so does this app spit out 4444 12bit files or 10bit 4444 files?? I always seem to get confused with some magic lantern apps, as some only support 4444 10bit, (or so i've read) get's a little confusing.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 05, 2017, 05:55:18 PM
It's 10bit from FFmpeg. You can get 12bit from AE, not from FFmpeg.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on August 05, 2017, 06:33:07 PM
@Danne Thanks for the shortcut, that's amazing :o

The Cocoa version will soon get 12bit ProRes export (I hope).. once I switch to using AVFoundation instead of FFMpeg.

And credit to those who did the real work in this case(lj92): Andrew Baldwin and Martin Herring

Also what does 'scene referred dynamic range' mean? Does it just mean you can use the whole range of the raw data? (I don't know all the technical video terms)

Also, everyone seems to love using log here... just wondering, what are the technical reasons for that? Do you linearise it and somehow edit it like raw again? or just grade it with plugins in other apps? I personally find I get better results when I use the raw converter to add all the main effects like contrast and saturation, it just feels more flexible than dealing with colour too much once it is no longer in RAW
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: kyrobb on August 05, 2017, 06:45:27 PM
Thank to Ilia and Masc! This is truly incredible. I think the reason people want LOG so bad may be to apply LUTS later on more easily. I can't say for certain. I would agree with you that it is awesome to be able to tune your look right in the raw processor. Maybe built-in LUT support would satisfy everyone? Thanks again though you guys this is already amazing for my use!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 05, 2017, 06:48:39 PM
QuoteDoes it just mean you can use the whole range of the raw data?
Yes. Check a dng and it´s all rec709 clipping whites. Clipping applies to ProRes in apple compressor and then a lot of information is gone.
Logs are perfect for batch encoding. Export for instance cineon based log ProRes4444 and then apply any additional color correction in a NLE. Another workflow would be to apply a log as a base and then color correct in MLV app. If it could add several logs in a row even better. So there is 1D luts and 3D luts and colorspace stuff. These are just thoughts Ilia and masc. I see you´re app as a great tool even without any lut adding...

Built in logs would be great.
cineon
logC
Bmdfilm
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 05, 2017, 07:10:41 PM
Full bit depth means, we use the maximum FFmpeg supports (via 3x16bit PNG). Before we had only 8 bit, now it is 10 bit I think. I heard FFmpeg can also export 12 bit ProRes 4444 XQ, but I had no luck until now. I found that for 4444 XQ:
ffmpeg -i input.mov -codec prores_ks -pix_fmt yuva444p10le -alpha_bits 16 -profile:v 4444 -f mov output.mov
But when I tried the file size was half from 10 bit 4444, and VLC was not able to play the file :D Anyone tried that before?

Edit: -pix_fmt yuva444p10le means 10bit, or?! Really confusing!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 05, 2017, 07:18:05 PM
I've been down that road with dfort. Not tested that one in particular masc but a lot of other settings. Nothing topped 10bit prores4444. Well maybe RAW export but those files are humongous and nothing can edit those whale files natively :).
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on August 05, 2017, 07:50:54 PM
Quote from: Danne on August 05, 2017, 06:48:39 PM
Built in logs would be great.
cineon
logC
Bmdfilm

This is exactly what I aim for ;D An output curve(and or colourspcae) selector with options such as those. One of the next steps.

Quote from: kyrobb on August 05, 2017, 06:45:27 PM
Maybe built-in LUT support would satisfy everyone?
Sounds like a good idea, might be one of the more difficult ones to do though. Might happen little later down the line.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: DeafEyeJedi on August 05, 2017, 10:35:46 PM
Can't disagree w @Danne's suggestions. So far a pretty solid foundation. Looking forward to it's further development and much thanks to @Ilia3101 & @masc...

Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 05, 2017, 11:44:42 PM
That app is getting pretty cool, histogram and progress bar.
I see you use darkframe averaged MLV files Deafeyejedi. Never though about it but it will yield even nicer results regarding vertical stripes in shadows and better color rendering.
Are those files compressed or uncompressed? * nevermind "Lossless".
Is the pinkish areas coming from lossless files? Could you try the same file decompressed Deafeyejedi? You can decompress in Switch by selecting (11) in the mlv_dump menu. Then select (d) and (r) to get the file decompressed.

(https://s2.postimg.org/90viqa24p/Screen_Shot_2017-08-05_at_23.55.23.png)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: reddeercity on August 06, 2017, 07:08:01 AM
@ Ilia3101 --this may help clear up color space , LOG and ProRes4444QX (which is up to 16bit linear with alpha  BT2020 (9-1-9) color space/profile and Rec 709 (HD1-1-1) color space/ profile
https://images.apple.com/final-cut-pro/docs/Apple_ProRes_White_Paper.pdf

FFmeg is 10bit no matter 444 or 422hq , 422 , etc. ..... and at rec709 so (HD 1-1-1) color profile and yes still clipping hi-lights .

ProRes 4444XQ(AVFoundation) in Apple Compressor& Motion ,  Resolve  is the only way to retain Full D.R. in Linear Space So No Clipping.

I first uses to backup all my MLV's to ProRes 4444XQ LOG Space to rec709 , now I backup to Linear LOG ProRes 4444XQ+Alpha(16bit) in BT2020 Wide Gamut .

using FFmpeg there's a quality loss compared to OSX AVFoundation , especially with heavy grading & or FX (green screen etc...) breaks down quickly when push were
10bit does not have the gradation needed --only Billions of Color Vs Trillions+ Color in XQ or even plain old 4444 from AVFoundation.

That's what stops me from using any App that exports FFMpeg ProRes .
My 2 Cents worth




Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 06, 2017, 09:10:37 AM
How can going from 14 to 12 bit be lossless? 2 bits are gone, even with 16bit alpha.
Also linear? How? Last I tried it was still the same srgb curve output in ac.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on August 06, 2017, 10:51:38 AM
I'll have to look in to colour spaces and stuff more, but tell me if I'm wrong... I think it works like this: in most processing software, the processing is done in floating point, meaning the values can be in a massive range, and deciding where to clip them for encoding a video is difficult. In my app however, this range is limited to 0-1 (0-65535 really), so it does lots of tricks to avoid clipping highlights(values reaching the limit), and as far as I know anything that remains in that range, will be kept in the image, no matter if the accuracy is reduced to 8 bit or 10 bit.

Unless the software (ffmpeg) is doing something horrific, I don't see why there's a big problem. Definitely going to use AVFoundation in the future, as it is faster and makes sense for the cocoa app.

Gone for 2 weeks...
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: DeafEyeJedi on August 07, 2017, 09:31:47 PM
Quote from: Danne on August 05, 2017, 11:44:42 PM
Is the pinkish areas coming from lossless files? Could you try the same file decompressed Deafeyejedi? You can decompress in Switch by selecting (11) in the mlv_dump menu. Then select (d) and (r) to get the file decompressed.

Done. Seems to be slightly better if not the same? Maybe it's cuz I ETTR'd a bit too much. Or could this be related to the 3.5k experimental stuff? I wanted to get the most details as possible in shadows @ ISO 6400 regardless during this test clip especially after DF process.  8)



Also here's a second example in 12-bit lossless 1080p @ ISO 800 with the Reinhard tonemapping comparisons below. Even opens up large MLV files w ease such as this one was over 61 GB's.



Notice when using Waveform Monitor which shows pretty good details and as accurate as possible whereas if you go back to the Histogram Monitor which shows a complete under exposed diagram when clearly it isn't. Is this a bug? Does this happen on your end as well?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: kyrobb on August 07, 2017, 09:59:50 PM
Is there any way to adjust values by typing the desired value? Or is it slider only? That feature would be very useful for more precise adjustment.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 08, 2017, 12:12:19 PM
Quote from: DeafEyeJedi on August 07, 2017, 09:31:47 PM
Notice when using Waveform Monitor which shows pretty good details and as accurate as possible whereas if you go back to the Histogram Monitor which shows a complete under exposed diagram when clearly it isn't. Is this a bug? Does this happen on your end as well?
Thanks for testing! I am impressed that it handles such big files... The histogram is the same on my side. But I don't see a underexposed picture, I see an extremly overexposed picture when you disable the Tonemapping. The histogram normalizes all values to the maximum value. On the very right the histogram shows a very huge value, that all other values seems to be very small. I don't know how other applications handle that... Photoshop for example shows exactly the same on my computer, but cuts of such peaks... however they are doing that.
What you could try: when exporting, MLV App creates all frames as PNG first. If you are fast enough (I think so if you handle big files  ;D) get one of these PNGs and open in another application offering a histogram. You can compare then.

Quote from: kyrobb on August 07, 2017, 09:59:50 PM
Is there any way to adjust values by typing the desired value? Or is it slider only? That feature would be very useful for more precise adjustment.
It is slider only for now. On windows you can use the arrow keys for the most precise steps supported. On OSX that seems not to work. On OSX you can scroll on the slider, but system default is 3 steps, so scrolling once on exposure changes by 0.03. Typing the value is a bigger change to the software, because it is not supported by default.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 09, 2017, 07:38:58 PM
In the last days (or nights) I found a solution for the value adjustment: Is it okay to doubleclick the value label and a small spinbox pops up? There it is possible to enter the value and the slider will be set. That works for all sliders but saturation... there we have a log curve behind the slider, so the precision is not the best  ;D

For the histogram I was playing a lot around, but found no solution so far. If anyone has an idea how to cut peaks without cutting half of the histogram, let me know please. I tried a log-y-axis, but it was not really better with that.

I prepared nearly everything for batch export. I created "sessions", what means you can open many clips to the app, adjust the sliders independant for each clip, you can open and save these sessions. Now I am working on the export. I hope I have that implemented until the weekend.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 09, 2017, 07:46:13 PM
Super nice!
QuoteI prepared nearly everything for batch export. I created "sessions", what means you can open many clips to the app, adjust the sliders independant for each clip, you can open and save these sessions
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: kyrobb on August 10, 2017, 12:22:25 AM
Wow. Even more incredible! Amazing work masc! Save-able sessions is genius!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: pc_bel on August 10, 2017, 10:22:46 PM
Masc!!!
Thanks fot all your dedication!!!! (Same for Ilia3101 ;) )
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 11, 2017, 08:07:48 PM
Here comes the MLV App cross platform GUI v0.5 alpha. The nice engine from Ilia3103 is still the same, but the GUI was growing:

- Receipts: copy and paste the slider settings from one clip to another, reset settings to default
- Sessions: new, open & save (with receipts), import MLV to session, delete selected MLVs from session
- Export selected clips from session at once
      - For batch export the filename stays equal to the MLV, but with .mov ending, folder is selectable
      - Free filename at single file export
- "Near-to-fullscreen-mode", by pressing S and E (makes right and left sidebar un-/visible)
- Context menus on picture and scope for easier control
- Popup on each slider value label for typing the value
- Some bugfixes

Problems:
- Real fullscreen is implemented, but so buggy (a known Qt problem, the documentation tells) -> disabled for this version
- Still problems on Windows with files >2GB
- Caching is disabled on both, Win & OSX, because I had lots of problems when changing the MLV.

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.5alpha

Have fun. I hope there are not too many bugs inside...  :P
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: DeafEyeJedi on August 11, 2017, 08:13:06 PM
Thanks for keeping up with us trolling over this thread. I just tested briefly w v0.5 alpha and noticed that if I try to import by clicking on the Folder Icon (it wont let me choose anything since it's all greyed out even the MLV's) and if I instead do File > Import MLV (Command+I) which then works like normal. Is this to be expected?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 11, 2017, 08:16:29 PM
Yes, that is okay. I changed the Icon, because I think the MLV is imported and the main file type is the session. That is different to the version before. The "Film"-Icon is for importing the MLV files now (4th icon).
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: kyrobb on August 12, 2017, 12:06:57 AM
Thanks again for all your hard work! I'd make another suggestion but I honestly couldn't if I tried. This app wonderfully simplifies my workflow and is working beautifully so far!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 12, 2017, 02:05:40 PM
@Ilia3101, masc:

Hey guys great progress!
Can you provide me with any Linux/GCC Makefile for easy kickstart?
I want to compile QT version on linux.

br
bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 12, 2017, 07:30:23 PM
Quote from: bouncyball on August 12, 2017, 02:05:40 PM
Can you provide me with any Linux/GCC Makefile for easy kickstart?
I want to compile QT version on linux.
Great! You don't need a makefile. You just need Qt (with QtCreator), zlib and libpng (development version, I use 1.6.31). Then you open the .pro file in the folder platform/qt/ and with some luck you are able to compile. When I tried that on Linux, I had no luck, because my Ubuntu was to old. I had only a Qt4.x, but you need 5.x (I know that it works on 5.6 and later on Win&OSX).
First you will have to add a equivalent for in the .pro file:
macx: INCLUDEPATH += /usr/local/include/libpng16/
macx: LIBS += -L/usr/local/lib/ -lz -lpng

You can write something starting with
linux-g++*: ....
and you won't break the Windows and Mac version.
The libraries from Ilia will be compiled first. I had the same problems on linux as on windows: some of the files will compile only with (have a look in the *.pro):
linux-g++*: QMAKE_CFLAGS_RELEASE += -msse2
the other files only with:
linux-g++*: QMAKE_CFLAGS_RELEASE += -msse2 -std=c99
So activate the first line, compile (will end with errors), activate the second line, compile again and it should work. Maybe anyone knows how to set the flags independently for different source code files... I don't know ;)
With some luck that's it and you are able to open it on Linux. Maybe you know how to build a complete package for distribution.
Good luck!

Edit: one more thing: It won't start from QtCreator without a little trick: in Creator, when the project is opened: go to the left "Project",  chose your Dev-Kit, chose Run, and there is a checkbox... don't know how it is named in english... maybe something with "Library path... DYLD_LIBRARY..." uncheck it and it will run in Creator.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 12, 2017, 09:08:29 PM
Thanks :) I'll try with QtCreator tomorrow.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 13, 2017, 10:51:08 AM
crashing everytime I try to open lj92 mlv :/ (OS X el capitan 10.11.6)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 13, 2017, 11:16:01 AM
Quote from: 12georgiadis on August 13, 2017, 10:51:08 AM
crashing everytime I try to open lj92 mlv :/ (OS X el capitan 10.11.6)
Could you please provide such a file? (A small one please ;))
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 13, 2017, 09:17:50 PM
Quote from: masc on August 13, 2017, 11:16:01 AM
Could you please provide such a file? (A small one please ;))

Ok I'm doing it asa I can reach décent connexion (I'm making a shooting in india now :) )


Envoyé de mon iPhone en utilisant Tapatalk
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 14, 2017, 07:00:14 PM
@masc: I've managed to compile "MLV App" for linux with QT 5.9.1

1. Linux section in MLVApp.pro looks like this:

# Linux
linux-g++*: QMAKE_CFLAGS_RELEASE += -O3 -msse4.1 -mssse3 -msse3 -msse2 -msse
linux-g++*: INCLUDEPATH += /usr/local/include/
linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng

Compiled/installed zlib and libpng and MLV App compiles smoothly on the very first pass. No other hoop jumping needed (with about 30 warnings though).

2. I had to add "*.MLV" in dialog because file names are case sensitive here:

void MainWindow::on_actionOpen_triggered()
{
    //Stop playback if active
    ui->actionPlay->setChecked( false );

    //Open File Dialog
    QStringList files = QFileDialog::getOpenFileNames( this, tr("Open one or more MLV..."),
                                                    m_lastSaveFileName.left( m_lastSaveFileName.lastIndexOf( "/" ) ),
                                                    tr("Magic Lantern Video (*.mlv *.MLV)") );


3. Some more stuff: when "MainWindow::openMlv( QString fileName )" invoked first time there is no MLV object exists hence "freeMlvObject( m_pMlvObject )" causes immediate core dump. I don't actually understand why it works for mac or mingw :P. Commenting out "free" does a trick and MLV loads and can be processed. However If you need to import second MLV, dialog freeses. I guess it's expected. Can you collaborate on this issue?

void MainWindow::openMlv( QString fileName )
{
    //Set window title to filename
    this->setWindowTitle( QString( "MLV App | %1" ).arg( fileName ) );

    //disable drawing and kill old timer and old WaveFormMonitor
    killTimer( m_timerId );
    delete m_pWaveFormMonitor;
    m_dontDraw = true;

    /* Destroy it just for simplicity... and make a new one */
    //freeMlvObject( m_pMlvObject );

    /* Create a NEW object with a NEW MLV clip! */
    m_pMlvObject = initMlvObjectWithClip( fileName.toLatin1().data() );


4. When exporting to prores - everytime this process stops on 50% of PNGs files. Don't know why yet :)

regards
bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 14, 2017, 08:54:43 PM
Quote from: masc on August 13, 2017, 11:16:01 AM
Could you please provide such a file? (A small one please ;))

https://drive.google.com/open?id=0B1B8Pb9cDF2YUlJFSVcwNTcydjA

here a link to one small MLV
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 14, 2017, 10:19:33 PM
Quote from: bouncyball on August 14, 2017, 07:00:14 PM
@masc: I've managed to compile "MLV App" for linux with QT 5.9.1

1. Linux section in MLVApp.pro looks like this:

# Linux
linux-g++*: QMAKE_CFLAGS_RELEASE += -O3 -msse4.1 -mssse3 -msse3 -msse2 -msse
linux-g++*: INCLUDEPATH += /usr/local/include/
linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng

Compiled/installed zlib and libpng and MLV App compiles smoothly on the very first pass. No other hoop jumping needed (with about 30 warnings though).

2. I had to add "*.MLV" in dialog because file names are case sensitive here:

void MainWindow::on_actionOpen_triggered()
{
    //Stop playback if active
    ui->actionPlay->setChecked( false );

    //Open File Dialog
    QStringList files = QFileDialog::getOpenFileNames( this, tr("Open one or more MLV..."),
                                                    m_lastSaveFileName.left( m_lastSaveFileName.lastIndexOf( "/" ) ),
                                                    tr("Magic Lantern Video (*.mlv *.MLV)") );


3. Some more stuff: when "MainWindow::openMlv( QString fileName )" invoked first time there is no MLV object exists hence "freeMlvObject( m_pMlvObject )" causes immediate core dump. I don't actually understand why it works for mac or mingw :P. Commenting out "free" does a trick and MLV loads and can be processed. However If you need to import second MLV, dialog freeses. I guess it's expected. Can you collaborate on this issue?

void MainWindow::openMlv( QString fileName )
{
    //Set window title to filename
    this->setWindowTitle( QString( "MLV App | %1" ).arg( fileName ) );

    //disable drawing and kill old timer and old WaveFormMonitor
    killTimer( m_timerId );
    delete m_pWaveFormMonitor;
    m_dontDraw = true;

    /* Destroy it just for simplicity... and make a new one */
    //freeMlvObject( m_pMlvObject );

    /* Create a NEW object with a NEW MLV clip! */
    m_pMlvObject = initMlvObjectWithClip( fileName.toLatin1().data() );


4. When exporting to prores - everytime this process stops on 50% of PNGs files. Don't know why yet :)

regards
bb
@bouncyball
Great!!! Thank you!
1.&2. I'll add that.
3. That's strange. I'll have a look at that.
4. Ups... I forgot to tell you, that you need ffmpeg. In the function startExport() it is called... I think we need a #ifdef for Linux then.

@12georgiadis
Thx. I'll have a look!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 14, 2017, 10:56:21 PM
Quote from: bouncyball on August 14, 2017, 07:00:14 PM
3. Some more stuff: when "MainWindow::openMlv( QString fileName )" invoked first time there is no MLV object exists hence "freeMlvObject( m_pMlvObject )" causes immediate core dump. I don't actually understand why it works for mac or mingw :P. Commenting out "free" does a trick and MLV loads and can be processed. However If you need to import second MLV, dialog freeses. I guess it's expected. Can you collaborate on this issue?
@bouncyball:
For 3.: I don't find a reason why that crashes on Linux. The pMlvObject exists, it comes from initLib(), which is called in the constructor. And freeMlvObject frees only the memory which initMlvObject() allocated. Can you try in which line it crashes?

@12georgiadis:
For me the app does not crash, but I get a clean darkred single colour picture for all frames. It seems to be a 14bit lossless file, is that right?
Edit: if I look into the code of your file, there is nearly everywhere the same data... are you sure this file is not currupted in any way? Do get it opened with another application?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 15, 2017, 05:46:10 AM
Quote from: masc on August 14, 2017, 10:56:21 PM
@bouncyball:
For 3.: I don't find a reason why that crashes on Linux. The pMlvObject exists, it comes from initLib(), which is called in the constructor. And freeMlvObject frees only the memory which initMlvObject() allocated. Can you try in which line it crashes?

@12georgiadis:
For me the app does not crash, but I get a clean darkred single colour picture for all frames. It seems to be a 14bit lossless file, is that right?
Edit: if I look into the code of your file, there is nearly everywhere the same data... are you sure this file is not currupted in any way? Do get it opened with another application?

Yes, I can open it with mlvfs + mlrawviewer/resolve/cliphouse etc.


Envoyé de mon iPhone en utilisant Tapatalk
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 15, 2017, 08:58:00 AM
Quote from: 12georgiadis on August 15, 2017, 05:46:10 AM
Yes, I can open it with mlvfs + mlrawviewer/resolve/cliphouse etc.

Okay. I can open it in mlvfs+resolve, too. But it looks 100% the same as in MLVApp (only white balance adapted to the result of resolve).

(https://image.ibb.co/gcG6cF/Resolve_MLVApp.jpg)

Sorry, but I still think your file is corrupted!

Edit: MlRawViewer also shows the same.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 15, 2017, 01:27:14 PM
@masc

Quote from: masc on August 14, 2017, 10:56:21 PM
For 3.: I don't find a reason why that crashes on Linux. The pMlvObject exists, it comes from initLib(), which is called in the constructor. And freeMlvObject frees only the memory which initMlvObject() allocated. Can you try in which line it crashes?
Crash been caused by fclose(video->file) in freeMlvObject()

This patch is working:

/* Free all memory and close file */
void freeMlvObject(mlvObject_t * video)
{
    isMlvActive(video) = 0;

    /* Close MLV file */
    if(video->file) fclose(video->file);


I wanted to patch it like this:

    if(video->is_active) fclose(video->file);

but, unfortunatelly as I understand, "is_active" field of "mlvObject_t" never used in code yet ;) (not used in openMlvClip() either)

Now I can load several MLVs without a problem. Next is to test it with ffmpeg :D

bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 15, 2017, 02:43:01 PM
Putting ffmpeg side by side with MLV App binary solved exporting stuck at 50% issue.

BTW no slash "\ -> /" fixing in PATH needed.

So exporting is working fine :)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 15, 2017, 02:52:59 PM
Quote from: masc on August 15, 2017, 08:58:00 AM
Okay. I can open it in mlvfs+resolve, too. But it looks 100% the same as in MLVApp (only white balance adapted to the result of resolve).

(https://image.ibb.co/gcG6cF/Resolve_MLVApp.jpg)

Sorry, but I still think your file is corrupted!

Edit: MlRawViewer also shows the same.

Excellent, now working with another clip without crashing ! Good app for preview ! Now I can get rid of mlrawviewer ;-) Do you think you'll add cdng export and fixing issues settings ?
thx !

Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 15, 2017, 06:39:23 PM
Quote from: bouncyball on August 15, 2017, 01:27:14 PM
This patch is working:

/* Free all memory and close file */
void freeMlvObject(mlvObject_t * video)
{
    isMlvActive(video) = 0;

    /* Close MLV file */
    if(video->file) fclose(video->file);

Superb! Thank you so much! I changed that and commited it into the repos.

Quote from: bouncyball on August 15, 2017, 02:43:01 PM
BTW no slash "\ -> /" fixing in PATH needed.
I don't get that. What did you do? \" is just a " in QString. It is for getting spaces in the paths and filenames to work, for example.

But very cool, that you got it working on Linux! Is it possible to make a kind of package, or has it to be compiled always for using it on Linux? I'm not deep enough in Linux...

Quote from: 12georgiadis on August 15, 2017, 02:52:59 PM
Excellent, now working with another clip without crashing ! Good app for preview ! Now I can get rid of mlrawviewer ;-) Do you think you'll add cdng export and fixing issues settings ?
thx !
Hej, cool, fine that it works for you too now. Thanks. MlRawViewer is still better in performance, because it uses GPU - we don't do for now.

Can cdng hold processed picture data? I thought it is also a kind of RAW, that is why I did not think about exporting cdng yet (don't know if Ilia3103 did).

What do you mean with "fixing issues settings"?

We just started developping this little app, we'll see where our way goes.  ;D
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 15, 2017, 07:32:33 PM
Quote from: masc on August 15, 2017, 06:39:23 PM
I don't get that. What did you do? \" is just a " in QString. It is for getting spaces in the paths and filenames to work, for example.
Ah, I meant there is no need to handle Windows/Unix slash differences in paths separately. I guess QT lib does it for you.

Quote from: masc on August 15, 2017, 06:39:23 PM
But very cool, that you got it working on Linux! Is it possible to make a kind of package, or has it to be compiled always for using it on Linux? I'm not deep enough in Linux...
Well if we link MLV App statically with libpng16 and zlib libraries It should run on any 64bit linux system.

Also It's possible to make deb or rpm package from it, maybe I'll try if I have more time :). It's just have some dependencies: QT, libegl1-mesa, pthread, zlib1, libpng16.

Btw, when proggie's running every slider movement causes lots of debug info output on stdout like:

[ 1.6808, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.3847 ]
[ 2.0365, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.0108 ]
[ 2.3260, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.5108 ]
[ 5.3437, 0.0000, 0.0000 ]
[ 0.0000, 2.2974, 0.0000 ]
[ 0.0000, 0.0000, 3.4709 ]
m_lastActiveClipInSession 0


regards
bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 15, 2017, 08:00:19 PM
Quote from: bouncyball on August 15, 2017, 07:32:33 PM
Ah, I meant there is no reason to handle Windows/Unix slash differences in paths separately.

Ah okay. Did I handle that sparately anywhere?

Quote from: bouncyball on August 15, 2017, 07:32:33 PM
Well if we link MLV App statically with libpng16 and zlib libraries It should run on any 64bit linux system.
Also It's possible to make deb or rpm package from it, maybe I'll try if I have more time :). It's just have some dependencies: QT, libegl1-mesa, pthread, zlib1, libpng16.

That would be really cool! Hope you'll find time... ;)

Quote from: bouncyball on August 15, 2017, 07:32:33 PM
Btw, when proggie's running every slider movement causes lots of debug info output on stdout like:

[ 1.6808, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.3847 ]
[ 2.0365, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.0108 ]
[ 2.3260, 0.0000, 0.0000 ]
[ 0.0000, 1.0000, 0.0000 ]
[ 0.0000, 0.0000, 1.5108 ]
[ 5.3437, 0.0000, 0.0000 ]
[ 0.0000, 2.2974, 0.0000 ]
[ 0.0000, 0.0000, 3.4709 ]
m_lastActiveClipInSession 0


Yes, right. Most of that comes from Ilias code. But that is no problem to switch off. Maybe we could implement some #ifdef DEBUG or whatever around.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 15, 2017, 08:10:13 PM
Quote from: masc on August 15, 2017, 08:00:19 PM
Ah okay. Did I handle that sparately anywhere?
Nope, but I always have to do it when using plain C and I hate this so much, hahaha :P
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 15, 2017, 08:35:22 PM
LOL, okay. Got it now.  8)

I did something against all the debug outputs now. It is on github.

Another question: can you open files bigger than 2GB on Linux? On OSX it is no problem, on Windows some while(..) will never end... It think the comparisons between uint64_t and long are the problem (see compiler warnings), but I did not get it fixed until now... maybe I'll wait for Ilia to let him fix that. :)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 15, 2017, 09:33:37 PM
Quote from: masc on August 15, 2017, 06:39:23 PM
Superb! Thank you so much! I changed that and commited it into the repos.
I don't get that. What did you do? \" is just a " in QString. It is for getting spaces in the paths and filenames to work, for example.

But very cool, that you got it working on Linux! Is it possible to make a kind of package, or has it to be compiled always for using it on Linux? I'm not deep enough in Linux...
Hej, cool, fine that it works for you too now. Thanks. MlRawViewer is still better in performance, because it uses GPU - we don't do for now.

Can cdng hold processed picture data? I thought it is also a kind of RAW, that is why I did not think about exporting cdng yet (don't know if Ilia3103 did).

What do you mean with "fixing issues settings"?

We just started developping this little app, we'll see where our way goes.  ;D


Ok, didn't know that it was cpu based.
Cdng may Be a good export option because we often Color correct after the editing but mlv are still not covered by NLEs. ProRes is ok with cinelog and xq option (not ffmpeg 10bits only export). With that option, we'd have the choice to correct raw Before and after the editing.
Fixing issues settings : bad pixels, v. Stripes... etc (all options available in mlvfs/mlv dump/ mlv producer)



Envoyé de mon iPhone en utilisant Tapatalk
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on August 15, 2017, 09:39:15 PM
I'm still going to be gone for a week ish(no code), but now I've got more of an internet connection.

@masc Sessions looks perfect, does it save it in a format yet? I'd like to be able to read that on the cocoa GUI in the future too (that needs lots of catching up).
See if you can fix any of the bugs easily, if you can, why wait for me :D
And yes, CDNG is a raw format (holds only Bayer data and almost identical to DNG), but it's ok to do some processing like removing vertical stripes or fixed pattern noise. I have thought about it, I like the idea of making a separate DNGing 'library', but I really have no idea how the dng format works.
Also audio_mlv.c might get done soon ;)

@bouncyball oh, I thought I had already put is_active to use... I'm probably going mad then. Maybe that's why I always had annoying problems trying to do certain things before.

Lots of good progress going on here.

And proper log output curves are still on the to-do list  :-\
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 16, 2017, 09:02:09 AM
Quote from: masc on August 15, 2017, 08:35:22 PM
Another question: can you open files bigger than 2GB on Linux? On OSX it is no problem, on Windows some while(..) will never end... It think the comparisons between uint64_t and long are the problem (see compiler warnings), but I did not get it fixed until now... maybe I'll wait for Ilia to let him fix that. :)
Yes I noticed those warnings too.

As I see windows build is 32 bit thas is why "-D_FILE_OFFSET_BITS=64" switch needed to pass to the compiler to seek more than 2gb files.Try:

win32: QMAKE_CFLAGS_RELEASE += -msse2 -std=c99 -D_FILE_OFFSET_BITS=64

or compile x64 binary with mingw.

I don't experience this issue because Linux binary is 64bit.

regards
bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 16, 2017, 09:26:11 AM
Quote from: Ilia3101 on August 15, 2017, 09:39:15 PM
And yes, CDNG is a raw format (holds only Bayer data and almost identical to DNG), but it's ok to do some processing like removing vertical stripes or fixed pattern noise. I have thought about it, I like the idea of making a separate DNGing 'library', but I really have no idea how the dng format works.
Also audio_mlv.c might get done soon ;)
Here all latest stuff for ML raw data handling/processing ever written/modified by ML developers or me :) It's all structured in my version of mlv_dump on steroids:
1. all latest cDNG handling stuff - cDNG Library  (https://bitbucket.org/bouncyball/magic-lantern/src/41e69f78254d40bd2ce65c4001b41560cd965c75/modules/mlv_rec/dng/?at=mlv_dump-on-steroids) and more.
2. latest Raw Processing Stuff (https://bitbucket.org/bouncyball/magic-lantern/src/41e69f78254d40bd2ce65c4001b41560cd965c75/modules/mlv_rec/raw_proc/?at=mlv_dump-on-steroids) modified and restructured. Includes stripes correction, bad/focus pixel fix, pattern noise fix and chroma smooth.

Quote from: Ilia3101 on August 15, 2017, 09:39:15 PM
@bouncyball oh, I thought I had already put is_active to use... I'm probably going mad then. Maybe that's why I always had annoying problems trying to do certain things before.
Maybe :D

regards
bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 16, 2017, 12:13:18 PM
Quote from: Ilia3101 on August 15, 2017, 09:39:15 PM
@masc Sessions looks perfect, does it save it in a format yet? I'd like to be able to read that on the cocoa GUI in the future too (that needs lots of catching up).

Thx. Yes it saves in a XML, I called it MASXML (MLV App Session XML). It holds all files and parameter settings of the session. Atm I have only one file opened with your lib, so caching makes no sense. All cached frames get deleted when changing the clip. So I disabled it for now.

Quote from: Ilia3101 on August 15, 2017, 09:39:15 PM
See if you can fix any of the bugs easily, if you can, why wait for me :D

I just wait because I did not got it resolved yet ;) ... the 2 whiles work with a small change, but I run into other problems then.

Quote from: Ilia3101 on August 15, 2017, 09:39:15 PM
And yes, CDNG is a raw format (holds only Bayer data and almost identical to DNG)

So if we only want MLV -> cDNG, why not just using mlv_dump? It does exaclty that. This means just not needed complexity in this app, because it is a processing app and exporting to cDNG means exporting unprocessed frames... maybe we could just add a menu item which "remote controlles" mlv_dump. Or did I missunderstood?

Quote from: bouncyball on August 16, 2017, 09:02:09 AM
As I see windows build is 32 bit thas is why "-D_FILE_OFFSET_BITS=64" switch needed to pass to the compiler to seek more than 2gb files.Try:

win32: QMAKE_CFLAGS_RELEASE += -msse2 -std=c99 -D_FILE_OFFSET_BITS=64

or compile x64 binary with mingw.

Thanks again! Unfortunately that does not do the job :( I have still the problem with the never-ending while loops. When looking for Qt on Windows 64bit on the Qt download page, there is only a version with VC compiler (or we have to build it ourself). But when trying before I did not get it to work with MSVC. :( Maybe I should spend more time on that again.

The processing stuff of mlv_dump looks really interesting! Bad pixel fix, pattern noise and so on... would be great to have it in MLV App!
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: Danne on August 16, 2017, 12:34:30 PM
QuoteSo if we only want MLV -> cDNG, why not just using mlv_dump?
+1
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 16, 2017, 03:14:19 PM
Quote from: masc on August 16, 2017, 12:13:18 PM
maybe we could just add a menu item which "remote controlles" mlv_dump. Or did I missunderstood?
Yup, would be right decision, the whole point of this app is to skip creation of intermediate files. This also concerns DNGs. When you implement ffmpeg vial lib, MLV App is gonna be truly end to end processing tool.

Quote from: masc on August 16, 2017, 12:13:18 PM
The processing stuff of mlv_dump looks really interesting! Bad pixel fix, pattern noise and so on... would be great to have it in MLV App!
If you'll have any questions regarding processing I'm ready to answer with pleasure :)

bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 16, 2017, 04:19:10 PM
What is still missing in osx MLV apps in general is a GUI that covers the preview function and the corrections before transcoding/rewrapping. If we can avoid MLV => CDNG and do all corrections/check in MLV, it would be perfect. I'm currently shooting a documentary and I'm using this workflow :

0) shoot lossless MLV + H264 proxys with sound
1) offload cards and checksum with rsync
2) visual check with Mlrawviewer/MLV app
3) open MLVFS to generate virtual CDNGs => fix settings (v. stripes etc.) (sometimes also using Swtich from Danne and MLV_Dump)
4) Resolve 14 => cinelog or Alexa Lut => sync sound from H264 proxys (find average offset) => export 444 12 bits XQ
5) Fcpx => import 444 XQ => generate proxys + lut r709
6) editing on any NLE
7) online edit, back on Resolve 14, color correct
8) Export APR 444 (DSM)

ideal workflow would be :

0) shoot lossless
1) offload, visual check, apply LUT, color correct, fix settings, sync sound, export APR 444 12 XQ + APR Proxys in the same time (or CNDG + DPX/TIFF if necessary) ALL this steps in one app and one batch ;-)

Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 16, 2017, 07:23:12 PM
@Ilia3101, @masc

I forgot one thing to ask

In amaze_demosaic.c there are 3 inline funcs:

__inline float xmul2f(float d)
__inline float xdiv2f(float d)
__inline float xdivf( float d, int n)

gcc (under linux) or mingw-gcc (under windows) always complains and outputs error that they are not defined.

changing "__inline" to "static INLINE" solves the issue.
How do you compile w/o applying these changes?
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 16, 2017, 10:06:00 PM
Quote from: bouncyball on August 16, 2017, 03:14:19 PM
If you'll have any questions regarding processing I'm ready to answer with pleasure :)

:) I think Ilia or me, we will do that! Cool!

Quote from: bouncyball on August 16, 2017, 07:23:12 PM
gcc (under linux) or mingw-gcc (under windows) always complains and outputs error that they are not defined.
changing "__inline" to "static INLINE" solves the issue.
How do you compile w/o applying these changes?

Okaay, I had always one big problem under windows, maybe this could solve it: I don't get everything compiled with
win32: QMAKE_CFLAGS_RELEASE += -msse2 -std=c99
so I did a compiler run with this before
win32: QMAKE_CFLAGS_RELEASE += -msse2
some module(s?) compile, others with error, I switch the flag again and the other modules compile and link in the end. Not the best to do so... I know... but I found no other solution so far. Maybe your hint solves this issue. I'll try tomorrow! Do you think that's it?

Quote from: 12georgiadis on August 16, 2017, 04:19:10 PM
1) offload, visual check, apply LUT, color correct, fix settings, sync sound, export APR 444 12 XQ + APR Proxys in the same time (or CNDG + DPX/TIFF if necessary) ALL this steps in one app and one batch ;-)

I think this is not so far away from what I think MLV App could do in the future ;)
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: 12georgiadis on August 17, 2017, 07:29:59 AM
Quote from: masc on August 16, 2017, 10:06:00 PM
:) I think Ilia or me, we will do that! Cool!

Okaay, I had always one big problem under windows, maybe this could solve it: I don't get everything compiled with
win32: QMAKE_CFLAGS_RELEASE += -msse2 -std=c99
so I did a compiler run with this before
win32: QMAKE_CFLAGS_RELEASE += -msse2
some module(s?) compile, others with error, I switch the flag again and the other modules compile and link in the end. Not the best to do so... I know... but I found no other solution so far. Maybe your hint solves this issue. I'll try tomorrow! Do you think that's it?

I think this is not so far away from what I think MLV App could do in the future ;)

Great ! I'll Be here to test and give feedback ;-)


Envoyé de mon iPhone en utilisant Tapatalk
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 17, 2017, 08:11:30 AM
Quote from: bouncyball on August 16, 2017, 07:23:12 PM
@Ilia3101, @masc

I forgot one thing to ask

In amaze_demosaic.c there are 3 inline funcs:

__inline float xmul2f(float d)
__inline float xdiv2f(float d)
__inline float xdivf( float d, int n)

gcc (under linux) or mingw-gcc (under windows) always complains and outputs error that they are not defined.

changing "__inline" to "static INLINE" solves the issue.
How do you compile w/o applying these changes?

I changed that and tried again on windows. That does not change anything for me. Other source files need the -std=c99 flag, if I activate that the compiler brings 172 errors for these few lines in amaze_demosaic.c:

#define min(a,b) \
   ({ typeof ((a)+(b)) _a = (a); \
      typeof ((a)+(b)) _b = (b); \
     _a < _b ? _a : _b; })

#define MAX(a,b) \
   ({ typeof ((a)+(b)) _a = (a); \
       typeof ((a)+(b)) _b = (b); \
     _a > _b ? _a : _b; })

#define SQR(a) \
   ({ typeof (a) _a = (a); \
     _a * _a; })

Do you have an idea why? The output is to long for a message in this forum :(
Mostly it is something like "expected ';' before '_a'" or "....before '_b'".
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on August 17, 2017, 11:24:15 AM
@masc..

1. Yes, it is a good idea to just use mlv_dump for dng export, to avoid unnecessary complexity.

2. The AMaZE code is a disgusting mess to be honest, I don't even know what language you could call it, but if I remember correctly it compiled with some c++ standards flags.

3. Also could you get me a nice screenshot of the Qt GUI that you like so I can put it in the first post?

4. About caching: I think it should work like this... When there is many clips open, the one being worked on should be allowed full cache (whatever we did when only one clip was supported), and others would be allowed 0 cache.. Of course this would need for me to rewrite the caching to actually work so it can be adjusted in size while running.

@bouncyball...

Could you possibly by any chance provide a Linux build for @masc to put on the release page?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 17, 2017, 12:21:14 PM
@masc

Which QT and mingw versions do you use?
I use QT 5.9.1 with mingw 5.3.0 and able to compile on one pass :)
Btw under windows as well. However can not fix the MLV size >2GB issue yet.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on August 17, 2017, 07:57:18 PM
Ok, I think I found out where I had issues. When I try to open it my files from a complex folder structure (like I often use for editing) it crashes. But when I moved them to a simple one, like HDD root, it opens perfectly.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 17, 2017, 08:14:41 PM
@masc

try:
win32: QMAKE_CFLAGS_DEBUG += -msse2 -D_FILE_OFFSET_BITS=64
In conjunction with replacing all "fseek" with "fseeko". Should resolve >2gb isuue.

I also compiled MLV App with mingw64-x64 (using MSYS2 enviroment, very cool stuff), got 64bit native binary for windows but 2gb issue persisted. Then I changed all fseek calls with fseeko and 2.8GB MLV loaded and processed :) I'm too lazy to compile libpng and zlib again for win32 MLV App testing. Try yourself what I said abobe, I think it should help even for 32bit binary.

Meanwhile trying to compile all static MLV App... not succeded yet...

bb
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: masc on August 17, 2017, 08:24:32 PM
Quote from: Ilia3101 on August 17, 2017, 11:24:15 AM
@masc..

1. Yes, it is a good idea to just use mlv_dump for dng export, to avoid unnecessary complexity.

2. The AMaZE code is a disgusting mess to be honest, I don't even know what language you could call it, but if I remember correctly it compiled with some c++ standards flags.

3. Also could you get me a nice screenshot of the Qt GUI that you like so I can put it in the first post?

4. About caching: I think it should work like this... When there is many clips open, the one being worked on should be allowed full cache (whatever we did when only one clip was supported), and others would be allowed 0 cache.. Of course this would need for me to rewrite the caching to actually work so it can be adjusted in size while running.

@bouncyball...

Could you possibly by any chance provide a Linux build for @masc to put on the release page?

3.: http://image.ibb.co/h7tvma/Bildschirmfoto_2017_08_12_um_12_21_47.png this was the last one...
4.: yes, this should easily be possible. I did it also like this (you provide this functionality), but I had some problems - some crashes and some pinkish frames. So I disabled it... with some debugging this should work!
5.: I was talking with bouncyball about that... some posts above. But to build a linux package that needs some extra work ;)

Quote from: bouncyball on August 17, 2017, 12:21:14 PM
@masc
Which QT and mingw versions do you use?
I use QT 5.9.1 with mingw 5.3.0 and able to compile on one pass :)
Btw under windows as well. However can not fix the MLV size >2GB issue yet.

Good question. I think it is a Qt 5.6.0 and MinGW 4.9.x or something like that on Windows. Maybe I should just update MinGW. But with this 2GB issue, the best option will be to try it again with MSVC I think.

Quote from: 12georgiadis on August 17, 2017, 07:57:18 PM
When I try to open it my files from a complex folder structure (like I often use for editing) it crashes. But when I moved them to a simple one, like HDD root, it opens perfectly.

Hm, sounds strange. At least my part can handle each path I think. Maybe I look for that deeper in the sources...
Quote from: bouncyball on August 17, 2017, 08:14:41 PM
try:
win32: QMAKE_CFLAGS_DEBUG += -msse2 -D_FILE_OFFSET_BITS=64
In conjunction with replacing all "fseek" with "fseeko". Should resolve >2gb isuue.
...
Try yourself what I said abobe, I think it should help even for 32bit binary.
Wow, sounds good... I'll try that tomorrow when I'm back on my windows PC! Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 17, 2017, 08:52:14 PM
HERE (https://bitbucket.org/bouncyball/mlv-tools/downloads/MLV_App_x64.zip) is a proof of concept ;) Win x64 MLV App with > 2GB support. Just exported mov for 4.2gb MLV.
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: bouncyball on August 17, 2017, 09:19:06 PM
Quote from: Ilia3101 on August 17, 2017, 11:24:15 AM
Could you possibly by any chance provide a Linux build for @masc to put on the release page?
Can not compile all static binary yet. There is no chance to put libs side by side with binary in Linux. It's not gonna work.

It's how it looks like on my desktop :)

(http://thumb.ibb.co/eyxOBa/MLV_App_Linux.jpg) (http://ibb.co/eyxOBa)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 17, 2017, 09:26:54 PM
Quote from: bouncyball on August 17, 2017, 08:14:41 PM
I'm too lazy to compile libpng and zlib again for win32 MLV App testing. Try yourself what I said abobe, I think it should help even for 32bit binary.

The win32 versions of libpng and zlib are in the repos. You mustn't compile again...

Quote from: bouncyball on August 17, 2017, 08:52:14 PM
HERE is a proof of concept ;) Win x64 MLV App with > 2GB support. Just exported mov for 4.2gb MLV.

Yeaaayyy... will try it tomorrow!  8) And: so cool to see it on Linux! Hahahaa
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 17, 2017, 09:56:12 PM
Aah, Linux too  8) Goood...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: mario1000 on August 18, 2017, 09:59:16 AM
Quote from: bouncyball on August 17, 2017, 08:52:14 PM
HERE (https://bitbucket.org/bouncyball/mlv-tools/downloads/MLV_App_x64.zip) is a proof of concept ;) Win x64 MLV App with > 2GB support. Just exported mov for 4.2gb MLV.

Dear bouncyball,

I would like to try this version, but after start an error message appears: "This application fails to start because it could not find or load the Qt platform plugin "windows" in "". Reinstallating the application may fix this problem."
I use Windows 8.1 . Any suggestions?

Thanks in advance!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 18, 2017, 10:08:35 AM
@bouncyball:
Same for me. Should be a problem with the libraries. You can try opening on your system after renaming your Qt installation folder...

I tried what you wrote for >2GB file support with Win32... but the problem still persists :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 18, 2017, 10:17:27 AM
@masc

The solution I always use is:

uint32_t file_set_pos(FILE *stream, uint64_t offset, int whence)
{
#if defined(__WIN32)
    return fseeko64(stream, offset, whence);
#else
    return fseeko(stream, offset, whence);
#endif
}


I forgot to mention that in addition to
"win32: QMAKE_CFLAGS_DEBUG += -msse2 -D_FILE_OFFSET_BITS=64"
fseeko64 should be used for mingw32. So change all fseek to fseeko64 or use the universal routine posted above.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 18, 2017, 10:49:36 AM
@mario1000

Quote from: mario1000 on August 18, 2017, 09:59:16 AM
I would like to try this version, but after start an error message appears: "This application fails to start because it could not find or load the Qt platform plugin "windows" in "". Reinstallating the application may fix this problem."
Ah yes windows platform plugin for QT was missing.
Download the MLV App (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x64.zip) again.
Now it runs on my testing clean Windows 7 x64.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 18, 2017, 11:06:00 AM
Now I ask, if I test with currupted files :( But i get them opened in other apps/tools, and they open on OSX.

I get your version opened now, but it crashes on open a big mlv in the same way as my 32 bit build does. Same for fseeko64.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 18, 2017, 11:22:12 AM
Hmm... what can I say I'm lost :) Let's wait for others to test it and report.

Just opened two, 4.1 and 4.2 GB, files and play them w/o a problem (on win10 x64).
Regarding my suggestion of fseeko64, will try today with win32 enviroment.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on August 18, 2017, 11:27:55 AM
I'll add the screenshot later today.
@bouncyball if you want, I can add you with commit ability to the github repository if you have an account. Might speed up little things like getting the big files working.
Linux screenshot looks good, maybe I can switch to Linux sooner now :)
Also why does fseeko and fseeko64 exist? How are they different from fseek?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 18, 2017, 12:00:29 PM
Quote from: Ilia3101 on August 18, 2017, 11:27:55 AM
@bouncyball if you want, I can add you with commit ability to the github repository if you have an account. Might speed up little things like getting the big files working.
Would be very nice thank you.

Quote from: Ilia3101 on August 18, 2017, 11:27:55 AM
Linux screenshot looks good, maybe I can switch to Linux sooner now :)
:)

Quote from: Ilia3101 on August 18, 2017, 11:27:55 AM
Also why does fseeko and fseeko64 exist? How are they different from fseek?
difference between fseek and fseeko is the offset type. fseeko offset type is "off_t" and fseek offset type is "long".
fseeko64 addresses 64bit offsets (>2GB files) for 32bit platforms.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 18, 2017, 12:03:28 PM
@masc:

Please try this 32bit build (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x86.zip) (fseeko64).
It opens >2gb files here on windows 10 x64.

And here (http://nic.caucasus.net/mlvapp/?dir=&download=MLV-App-src-mingw32.zip) is a source from which I built it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ottoga on August 18, 2017, 01:29:52 PM
Hi

Just some feedback

I tried both the 32 and 64 bit versions of the app today on a W10 Professional Notebook.

Unfortunately I get the following error on both versions:



"This application fails to start because it could not find or load the Qt platform plugin "windows" in "". Reinstalling the application may fix this problem."



After acknowledging the error message I get the following (which is probably normal due to the original error):



Runtime Error!

[Path]/MLVP App.exe

The application has requested the Runtime to terminate in an unusual way.
Please contact the application's support team for more information.



Cheers
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 18, 2017, 02:42:11 PM
I tested both 64 and 32 bit versions on 3 machines. My work pc win 10, My notebook win10 clean install where QT was not installed ever and win 7 x64 virtual machine clean install.

@Ottoga: You mightbe downloaded 64 bit version from earlier post. Because it works here. However you are right about 32 bit one. qwindows.dll was from older QT version.

Now both checked, updated and are working on all my PCs and VMs with 2GB+ file support _flawlessly!_

Download 32bit (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x86.zip) and 64bit (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x64.zip) versions again.

And if someone says it's not working again I'm not gonna believe him in no way :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DanHaag on August 19, 2017, 01:14:20 AM
Tried the latest native Mac version with new MLV footage I shot about a week ago. Now it works! The best standalone MLV/MLraw app I've ever used! Great work, thank you so much!  8) :)

Will keep using it and report here in case of any issues but so far (except for the known resizing UI bug) I didn't run into any further problems.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: reddeercity on August 19, 2017, 07:01:53 AM
Quote from: bouncyball on August 18, 2017, 02:42:11 PM
And if someone says it's not working again I'm not gonna believe him in no way :P
@bouncyball --Really ! that very arrogant of you!! >:(
I just tested it on Win7 Pro Workstation (8core fx8350 , 8GB ram , ssd OS, 8TB raid0 , dual gpu's (gtx580)
I can confirm It Crashes on 32bit version on 4 GB or bigger
from this link http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x86.zip


(http://preview.ibb.co/mhsQRk/crashed_app.png) (http://ibb.co/nNBwXQ)

The file is 4 GB 14bit 1920x960 from my 5D Mark ii , open fine with MLVProducer & MLVFS PC(version) It is a spanning file
(http://image.ibb.co/jgrKmk/mlvproducer_app_Info_menu.png) (http://imgbb.com/)

Same file in MLVProducer
(http://preview.ibb.co/kiGGz5/small_mlvproducer_app.png) (http://ibb.co/htW5sQ)

I did try a 3.2 GB file and it open up in this app , I would say that there no Spanning file support --of course as All digic 4 cam don't support exfat.
So something is broken it need to be fixed.

I did notice that the image in the preview is really blown out
(http://preview.ibb.co/dCnye5/small_mlv_app.png) (http://ibb.co/iT8RXQ)

Same file in mlvproducer with default setting no adjustments (adobe RGB color space)

(http://preview.ibb.co/jyAtwk/small_mlvproducer_app_2_GB_file.png) (http://ibb.co/hJrNp5)

If I'm not mistaken this app uses either sRGB or rec709 color space right ?
to match mlvproducer I have to drop the exposure down to negative -3.5 to get correct exposure
so there something going on that's blowing out the image in MLV app.
Maybe a decoding problem ? or reading wrong metadata ? just a thought .



Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on August 19, 2017, 09:35:58 AM
@reddeercity
The colour space, while not properly managed yet is treated as sRGB (by default), by the PNG library... Most likely, im certain that's the case on Mac version and probably same is true for the PNG library used in Qt version. So yes, it is sRGB, however ffmpeg which is currently used probably adapts it to rec 709 (which as you know only differs in gamma curve)
It should look the same throughout the process.
But I'm still going to try and add some more colour space stuff in to the app, it's all much clearer to me now.

Also, the overexposure is supposed to be there, we lie by +1.2 stops when it is set to 0. You do good ettr I guess, so for you it seems really overexposed, but for normally (badly) exposed shots it is only a tiny bit bright.

Did you try 64bit version though?

@DanHaag in my opinion at this moment the Qt GUI is a lot better for real world usage, it has more features, so at this moment I recommend using that, however cocoa GUI should eventually catch up on features and get AVFoundation export, which will make it worth using.

@bouncyball just tell me your github account name if/when you have one.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 19, 2017, 11:20:12 AM
@Ilia3101
Quote from: Ilia3101 on August 19, 2017, 09:35:58 AM
@bouncyball just tell me your github account name if/when you have one.
My username is bouncyball-git

@reddeercity
Quote from: Ilia3101 on August 19, 2017, 09:35:58 AM
Did you try 64bit version though?
? same question.

Spanning file could be reason though, will check.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: snipeua on August 19, 2017, 04:05:35 PM
Good day!
I have the same problems as reddeercity on both 32 and 64 bit versions (Windows 7 64bit). The application crashes on every spanning files larger than 3 GB.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 19, 2017, 07:19:43 PM
@snipeua

Hi, thank you for feedback. I'm just curious it crashes when you import spanning MLV or after, when you export final video?

And would be very nice if you'll also try to test with some standalone ~2.5-3.5GB MLV (not the part of spanning MLV files) and report back.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on August 19, 2017, 11:01:26 PM
O yeah, it still needs spanning support.

@bouncyball I've added you on github invite link that github gave (https://github.com/ilia3101/MLV-App/invitations)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 19, 2017, 11:12:27 PM
Succeeded to run it under Linux. A first feedback:

1. Exporting to prores results in png. The number of pngs is correct, but the progress bar stops at 50%.
2. I see nothing in histogramm, looking at a small object like the planet mars. Histogramm of the big moon looks fine:
   Histogramm mars: https://seescho.files.wordpress.com/2017/08/mars1.jpg
   Histogramm moon: https://seescho.files.wordpress.com/2017/08/mond.jpg
   
Tomorrow I will do same more tests.

Very nice app!

Edgar
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ottoga on August 20, 2017, 03:45:08 AM
@bounceyball

Both versions working fine with a small sample file. I don't have anything larger than 4gb anyway so I wouldn't have picked up reddeercity's error.

One option that would be really useful would be a button to reset the sliders back to their default settings.

A couple of questions if I may:


Cheers
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 20, 2017, 10:15:43 AM
@Ilia3101: Thank you, I really appreciate it!

@escho
Quote from: escho on August 19, 2017, 11:12:27 PM
1. Exporting to prores results in png. The number of pngs is correct, but the progress bar stops at 50%.
You gotta put ffmpeg binary to the same dir as MLV App and it's gonna pass the 50% :) (will encode to MOV and then delete PNGs)

@Ottoga: Thank you, can you be more specific about "small sample file". What was exact size, b/c MLVs less then 2GB were working from the beginning.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 20, 2017, 11:17:54 AM
Quote from: bouncyball on August 20, 2017, 10:15:43 AM

@eschoYou gotta put ffmpeg binary to the same dir as MLV App and it's gonna pass the 50% :) (will encode to MOV and then delete PNGs)


Got it. Thankyou!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 20, 2017, 12:17:37 PM
Hey guys patched - frame number not reported correctly for 2GB+ MLVs in the info dialog.

Download 32bit (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x86.zip) and 64bit (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x64.zip) versions again.

Both 32/64bit versions should hopefully work for everyone now ;)

EDIT: just converted 6.87GB MLV from 0 to the last 2025th frame :)

@Ilia3101, @masc
Intermediate PNG export is a huuuge waste of space, for 1920x1080 one PNG frame is ~10MB (imagine size for 3K). Had to free some space on my SSD to make this export.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: snipeua on August 20, 2017, 04:58:23 PM
@bouncyball
Hi, it crashes in first stage when i import spanning MLV.

UPDATE: New version still crashes - nothing change.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 20, 2017, 05:45:55 PM
Woooow, 2 days off and so much feedback. Thank you guys.

@Bouncyball: I'm sorry, I won't see a Windows PC for the next 4 weeks, so I hope other members of the forum will test and help to get feedback until then.

Somebody was asking for resetting the sliders: Menu -> Edit -> Reset receipt does the job.

@reddeercity: you think the exposure is wrong in MLV App? I always thought it is wrong in MlRawViewer and MLVProducer, because when opening any of my clips there I always get a "near to black" image, and I start seeing anything when doing something like exposure +3EV - then it looks near to what I saw on my camera. I don't have that problem when opening files in Resolve. But if I am right, we don't use metadata for processing, so it may be wrong... don't know what Ilia says about...

Quote from: bouncyball on August 20, 2017, 12:17:37 PM
@Ilia3101, @masc
Intermediate PNG export is a huuuge waste of space, for 1920x1080 one PNG frame is ~10MB (imagine size for 3K). Had to free some space on my SSD to make this export.

Yes, you're right, I know. I already tried to get the ffmpeg library working... but... after some days I gave up. I did not understand that library interface - it is really huge. But if you know how to do that, we could try another time. That should be faster and consume a lot less temp memory. And that would be much more elegant.

And... what did you change for your last upload? :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 20, 2017, 05:57:12 PM
Quote from: escho on August 19, 2017, 11:12:27 PM
Succeeded to run it under Linux. A first feedback:
1. Exporting to prores results in png. The number of pngs is correct, but the progress bar stops at 50%.
2. I see nothing in histogramm, looking at a small object like the planet mars. Histogramm of the big moon looks fine:
   Histogramm mars: https://seescho.files.wordpress.com/2017/08/mars1.jpg
   Histogramm moon: https://seescho.files.wordpress.com/2017/08/mond.jpg
Edgar
Thanks for testing on Linux! I think the histograms are both right. The picture with the mars is really dark, so the black in the histogram is so huge, that you nearly can't see the rest. Atm we are anywhere between linear and log scaling on the y axis. Log would be good for pics like that, but "normal" pictures would result in a line. Linear is good for normal pics but if there is a peak, you'll see only the peak.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 20, 2017, 07:17:28 PM
Quote from: snipeua on August 20, 2017, 04:58:23 PM
UPDATE: New version still crashes - nothing change.
Oh man... I can't believe this :D, then I guess it really depends on footage, I tried mostly 1080p/14bit/Uncompressed, any file size works here (on my four windows systems).

@snipeua:
Please tell us which:
1. Windows version you used;
2. MLV App version you used (32bit or 64bit);
3. What hardware you used;
4. Would be very nice if you upload exact MLV file which causes crash, please do it and I will test it asap.
Thank you in advance.

@masc
Quote from: masc on August 20, 2017, 05:45:55 PM
And... what did you change for your last upload? :)
I saw that if file size is more than 2GB, info dialog always shows 591 or 592 frames. Then I remember that in addition to 'fseek' there are lots of 'ftell' used in 'video_mlv.c'. And of course they also should be replaced by 'ftello64' for mingw :P. That's what I changed last time and now info panel shows correct frame count.

I have to test this code also for Linux (if it works for Linux it should work on Mac without change) and then I will push changes to repo (thanx to Ilia, he gave me access).

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 20, 2017, 07:22:53 PM
Quote from: bouncyball on August 20, 2017, 07:17:28 PM
@mascI forgot that in addition to 'fseek' there are lots of 'ftell' used in 'video_mlv.c'. And of course they also should be replaced by 'ftello64' for mingw :P.

I have to test this code also for Linux (if it works for Linux it should work on Mac without change) and then I will push changes to repo (thanx to Ilia, he gave me access).

Perfect! Thx! :-)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 20, 2017, 09:25:01 PM
I wrote for me a little step by step howto for running MLV-App under Linux. I share it with you, but it´s in German:
https://seescho.wordpress.com/fotos/ml/
Edgar
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 20, 2017, 09:51:14 PM
@Edgar: na das triffts doch ganz gut! ;) I always wanted to write that, and I even should do that. Some remarks:
1.: The app does not search for ffmpeg. I told the app, it is located exactly next to the executable, because on Win&OSX this was the easiest to do. So for Linux, if the location is anywhere else, we can add this special path.
2.: MLV App does not only need ffmpeg. It also needs libpng 1.6 and zlib. Otherwise it won't compile. On Win&OSX this was the most difficult part (at least for me).
3.: The histogram thing: I even think it is not wrong, I wrote it some messages above. There is just this peak in the very left (that is the black in your picture)... but if anyone has an idea how to cut peaks without making the histogram to flat... pleeeaaase tell me... this problem drives me crazy!  :P ;D

Anyway... thanks for this very good installation manual! I like it :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 21, 2017, 12:58:03 PM
Quote from: bouncyball on August 20, 2017, 12:17:37 PM
Hey guys patched - frame number not reported correctly for 2GB+ MLVs in the info dialog.

Download 32bit (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x86.zip) and 64bit (http://nic.caucasus.net/mlvapp/?dir=&download=MLV_App_x64.zip) versions again.

Both 32/64bit versions should hopefully work for everyone now ;)

Tested the 32bit version emulated in Wine on OSX without problems Could also open a 2.3GB file.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ottoga on August 21, 2017, 03:42:22 PM
@bouncyball

This is the first time that I have ever downloaded and tried the app so I wasn't doing any serious testing. I really just wanted to confirm that the versions that you provided the links for were working.

The actual file only had a few hundred frames captured when testing the 10/12bit raw recording on my 7D as I didn't have access to anything larger on the night.

Playing around with it tonight and it seems to be handling spanned files >4gb without any problems.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on August 21, 2017, 03:53:36 PM
wow this programs is so good. thank you bouncyball,masc and Ilia for making such a wonderful app
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on August 21, 2017, 05:26:43 PM
Terrific Progress guy's, amazing work, quick question though.... anyone know how to batch import?? i can only seem to import one clip at a time, or am i missing something???????
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 21, 2017, 07:01:55 PM
Quote from: Wayne H on August 21, 2017, 05:26:43 PM
Terrific Progress guy's, amazing work, quick question though.... anyone know how to batch import?? i can only seem to import one clip at a time, or am i missing something???????
I am not sure, if the latest version we uploaded as binary had already a filedialog for multiple files. Are you on Windows or OSX?
Windows: take the version from bouncyball, that should be new enough, select as many files you want in the dialog.
OSX: if it is new enough, try the same. If that does not work: select the files in Finder and chose "Open with..." -> MLV App.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on August 21, 2017, 07:26:07 PM
Quote from: Wayne H on August 21, 2017, 05:26:43 PM
anyone know how to batch import?? i can only seem to import one clip at a time, or am i missing something???????

i can import as many as i want. btw im on windows 7 64bit
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on August 21, 2017, 07:46:40 PM
Hi Masc, i'm on MacOS, i'm currently using the 0.5 alpha version.. the latest version on the download page, just tried finder to select multiple MVLs to import, but when i go to "open with", the MLV app is grey'd out and won't let me select it, to open with, guess i'll wait for the app to be updated, again fantastic work, thanks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 21, 2017, 07:54:37 PM
Quote from: Wayne H on August 21, 2017, 07:46:40 PM
Hi Masc, i'm on MacOS, i'm currently using the 0.5 alpha version.. the latest version on the download page, just tried finder to select multiple MVLs to import, but when i go to "open with", the MLV app is grey'd out and won't let me select it, to open with, guess i'll wait for the app to be updated, again fantastic work, thanks.
Yes, I have that on Mavericks too, on El Capitan it works for me, whyever. There is a option "Show only recommended" or something like that (have never seen the english version ;) ), and when you uncheck that, it also works on Mavericks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on August 21, 2017, 08:05:25 PM
Hi Masc, PERFECT. Just unchecked recommended apps, to ALL apps (MAC SIERRA)... and all MLV's loaded straight into MLV app. Thanks for feedback, really appreciate it. GREAT APP  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ottoga on August 22, 2017, 04:10:38 AM
I tested an MLV clip with sound last night. w10 64bit version.

Video exported fine, however there is no sound and/or no separate audio file created.

When reviewing the app preferences Export Audio is ticked but greyed out.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 22, 2017, 08:58:11 AM
Quote from: Ottoga on August 22, 2017, 04:10:38 AM
I tested an MLV clip with sound last night. w10 64bit version.

Video exported fine, however there is no sound and/or no separate audio file created.

When reviewing the app preferences Export Audio is ticked but greyed out.
Audio is not implemented, that is the reason why it is still greyed out. Ilia wants to implement audio read out, I also wait for that :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 22, 2017, 05:03:52 PM
Wow! Finally it works :D for 2GB+ files thanks for feedback guys.

@masc: I pushed my latest stuff to repo. I think you'll appreciate commit 1aadb46 ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 22, 2017, 06:10:23 PM
Btw I noticed that FPS, while playing MLV, differs for Win and Linux builds (no matter 32 or 64 bit):

Win ~7-10 fps
Linux ~15-18 fps (even 20 sometimes)

Tested on the same PC with the same hardware and MLV files.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on August 22, 2017, 07:03:15 PM
Thanks a lot @escho, I've added it to first post.

@bouncyball I know two potential causes for slowness:
Linux kernel can be up to ~40-50% better in cpu performance than Windows (I know this from the Blender world)
(More likely) The UI widget/component used by Qt in Linux is more efficient than the one used in windows, as I noticed on Cocoa version, the NSImageView widget refreshes much faster when the window is small - it seems to be the main bottle neck for Mac.

@masc I see you added mlv dump sources to the repository. I will try and implement them, although some of them will probably need to be moved from src/processing to src/mlv, as they work mostly with bayer data, not RGB which the processing module does.
Caching rewrite still on the list :( ugh
I'm back and more stuff is coming.

We also need a really nice icon.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 22, 2017, 08:16:00 PM
Quote from: Ilia3101 on August 22, 2017, 07:03:15 PM
I know two potential causes for slowness
Yes I also thought about the same two reasons you mentioned.

The icon refresh would be very nice :).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 22, 2017, 08:31:46 PM
Quote from: bouncyball on August 22, 2017, 06:10:23 PM
Btw I noticed that FPS, while playing MLV, differs for Win and Linux builds (no matter 32 or 64 bit):

Win ~7-10 fps
Linux ~15-18 fps (even 20 sometimes)

Tested on the same PC with the same hardware and MLV files.
Haha... with Windows it is so slow... yes, I have seen that too, so I am not alone:
- Win 8.1 Pro [email protected] (PC from 2013): 10 fps
- OSX 10.9 Core2Duo 2.4 GHz (MBP 2010): 10 fps
- OSX 10.10 i5 2.5 GHz (iMac 2011): 17 fps :)

Quote from: bouncyball on August 22, 2017, 05:03:52 PM
@masc: I pushed my latest stuff to repo. I think you'll appreciate commit 1aadb46 ;)
I'll check that out this evening!

Quote from: Ilia3101 on August 22, 2017, 07:03:15 PM
@masc I see you added mlv dump sources to the repository. I will try and implement them, although some of them will probably need to be moved from src/processing to src/mlv, as they work mostly with bayer data, not RGB which the processing module does.
Caching rewrite still on the list :( ugh
I'm back and more stuff is coming.

We also need a really nice icon.
Oh yes! A nice icon would be cool. I just created this ugly thing for having anything... but I don't like it!

I added the mlv dump sources because I was playing around. I tried to add chroma smoothing, but without luck. Maybe I did not call it at the right step. When do we have to call it? I thought before the debayering when I understood the code and the comments right. Is that right? But it works with integer and Ilia implemented float. Is that a problem?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 22, 2017, 08:47:07 PM
@Ilia3101, @masc

Quote from: masc on August 22, 2017, 08:31:46 PM
When do we have to call it? I thought before the debayering when I understood the code and the comments right. Is that right? But it works with integer and Ilia implemented float. Is that a problem?
All processing routines, the original MLVFS/cr2hdr ones or the ones added/modified by me, work only on RAW bayer data. It's all done on any bit raw unpacked to uint16_t image buffers. I have to take closer look at Ilia's implementation before debayer. I think he also unpacks raw bits to 16bit and there won't be a problem, just performance/fps penalty of processing, bad pixels/focus pixels/stripes are less heavy, chroma smooth and pattern noise are slower.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 22, 2017, 09:20:53 PM
@bouncyball:
I think anywhere in the near of getMlvRawFrameFloat() in video_mlv.c would be right then (or where this one gets called).

Cool stuff at the repos! I made a new release and counted up to v0.6 alpha. Would you please compile and upload the windows version(s)?
https://github.com/ilia3101/MLV-App/releases/tag/QTv0.6alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.6alpha)

@all:
New in v0.6 alpha:
- Bugfixes for >2GB file support on Windows
- Changed histogram algorithm (cuts peaks at very low and high end, and is something between linear and log now) @escho & @DeafEyeJedi: please try out if shows better would you like to see
- Preview pictures in sessions (list mode and picture mode)
- Scrolling and dragging support at 100% zoom in picture viewer
- Small bugfixes
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 23, 2017, 10:48:31 AM
Quote from: masc on August 22, 2017, 09:20:53 PM
Would you please compile and upload the windows version(s)?
Done :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 23, 2017, 11:12:43 AM
Newest version works fine hier in Linux. And for compiing in QT Creator there is only one pass needed now. Great.

The histogramm of Mars is now OK. I uploaded a comparition between MLV App and darktable on my website: https://seescho.wordpress.com/fotos/ml/

I will change my howto later. Nice to found the link on the first post of this Tread :)  I think, I will add some english text into the howto.

btw. What is this for in MLVApp.pro?

#Linux
linux-g++*: INCLUDEPATH += /usr/local/include/
linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng


/usr/local/include and /usr/local/lib are empty on my system.

Edgar
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 23, 2017, 12:04:37 PM
Quote from: escho on August 23, 2017, 11:12:43 AM
#Linux
linux-g++*: INCLUDEPATH += /usr/local/include/
linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng


/usr/local/include and /usr/local/lib are empty on my system.
And where are compiled libpng16 and zlib1 in your case?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 23, 2017, 12:50:59 PM
Quote from: escho on August 23, 2017, 11:12:43 AM
The histogramm of Mars is now OK. I uploaded a comparition between MLV App and darktable on my website: https://seescho.wordpress.com/fotos/ml/

btw. What is this for in MLVApp.pro?

#Linux
linux-g++*: INCLUDEPATH += /usr/local/include/
linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng


/usr/local/include and /usr/local/lib are empty on my system.

Edgar
Hey cool... the simple trick seems to work in the histogram.

How can you compile when that is empty? That's strange.  In the repos under platform/qt/ there is a folder: libpng. Here you find the source for this library - unpack, compile and install. Zlib should work if you install the dev version with apt-get or whatever you use. If not, you can download this in the internet, compile and install.

Quote from: bouncyball on August 23, 2017, 10:48:31 AM
Done :)
Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 23, 2017, 02:30:37 PM
Quote from: bouncyball on August 23, 2017, 12:04:37 PM
And where are compiled libpng16 and zlib1 in your case?

libpng16-16 - Library for the Portable Network Graphics Format (PNG)

/usr/lib64/libpng16.so.16
/usr/lib64/libpng16.so.16.8.0



libpng16-devel - Development Tools for applications which will use the Libpng

/usr/bin/libpng16-config
/usr/include/libpng16
/usr/include/libpng16/png.h
/usr/include/libpng16/pngconf.h
/usr/include/libpng16/pnglibconf.h
/usr/lib64/libpng16.so
/usr/lib64/pkgconfig/libpng16.pc
/usr/share/doc/packages/libpng16-devel
/usr/share/doc/packages/libpng16-devel/ANNOUNCE
/usr/share/doc/packages/libpng16-devel/CHANGES
/usr/share/doc/packages/libpng16-devel/LICENSE
/usr/share/doc/packages/libpng16-devel/README
/usr/share/doc/packages/libpng16-devel/TODO
/usr/share/doc/packages/libpng16-devel/libpng-manual.txt


zlib-devel - Development files for zlib, a data compression library

/usr/include/zconf.h
/usr/include/zlib.h
/usr/include/zutil.h
/usr/lib64/libz.so
/usr/lib64/pkgconfig/zlib.pc
/usr/share/doc/packages/zlib
/usr/share/doc/packages/zlib-devel
/usr/share/doc/packages/zlib-devel/ChangeLog
/usr/share/doc/packages/zlib-devel/README
/usr/share/doc/packages/zlib/examples
/usr/share/doc/packages/zlib/examples/README.examples
/usr/share/doc/packages/zlib/examples/enough.c
/usr/share/doc/packages/zlib/examples/fitblk.c
/usr/share/doc/packages/zlib/examples/gun.c
/usr/share/doc/packages/zlib/examples/gzappend.c
/usr/share/doc/packages/zlib/examples/gzjoin.c
/usr/share/doc/packages/zlib/examples/gzlog.c
/usr/share/doc/packages/zlib/examples/gzlog.h
/usr/share/doc/packages/zlib/examples/zlib_how.html
/usr/share/doc/packages/zlib/examples/zpipe.c
/usr/share/doc/packages/zlib/examples/zran.c
/usr/share/man/man3/zlib.3.gz


I can compile with QT creator without problems and don´t have to chance anything. Maybee, QT Creator adds the paths itself?

Edgar
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 23, 2017, 03:06:20 PM
Another thing

I use MLV-videos for nothing else than my astronomical stuff. Autostakkert, the program, which I use to stack the videoframes, need uncompressed avi-files as input. It does not run with prores. It would be nice to can export such avi-files with MLVApp sometime in the future.

For my needs I did a workaround, quick and very dirty. Looks like that:

I changed MainWindow.cpp line 636 ff

QString program = QCoreApplication::applicationDirPath();
    program.append( QString( "/ffmpeg\"" ) );
    program.prepend( QString( "\"" ) );
    program.append( QString( " -r %1 -i \"%2\" -c:v rawvideo -pix_fmt %3 \"%4\"" )
                    .arg( getMlvFramerate( m_pMlvObject ) )
                    .arg( numberedFileName )
                    .arg( "yuv420p" )
                    .arg( output ) );

                   
And I replaced all .mov strigs, i found in MainWindow.cpp with .avi.

Edgar
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 23, 2017, 09:13:15 PM
Quote from: escho on August 23, 2017, 02:30:37 PM
I can compile with QT creator without problems and don´t have to chance anything. Maybee, QT Creator adds the paths itself?
I don't think Qt adds paths (at least it does not do that for me ;D). But maybe there is set a system variable with that path.

Quote from: escho on August 23, 2017, 03:06:20 PM
For my needs I did a workaround, quick and very dirty. Looks like that:
That does not look so quick and dirty. That patch should do the job. Maybe I add this in future to the other codecs. What does this codec "rawvideo" exactly? Does it convert the png to tiff and adds it to the avi?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 24, 2017, 08:30:34 AM
Nice progress all.
I wanted to ask about HDR implementation. Since you´re in FFmpeg domain there´s something called tblend filter that, at least when I run real life footage, yields very good results. It´s more or less same speed as transcoding regular prores and it also keeps the original framerate.
Example footage:
http://www.magiclantern.fm/forum/index.php?topic=13512.msg160592#msg160592
averaged footage at around 1:05.

It works with an average filter. I think it will work nicely in Mlv app since we now can tweak output. Here´s a syntax example from Switch:
find . -maxdepth 1 -iname '*.dng' -print0 | xargs -0 dcraw +M $h2 $o $S -c -6 -W $qual $gam $wb $pix $br | ffmpeg $wav1 -f image2pipe -vcodec ppm -r $fps -i pipe:0 $sd -vcodec prores -pix_fmt yuv422p10le -n -r $fps -vf tblend=all_mode=average Output.mov
What it boils down to is the simple filter syntax added:
-vf tblend=all_mode=average Output.mov

The idea is that the HDR PNG files gets averaged of course.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on August 24, 2017, 10:17:59 AM
If that HDR using ffmpeg will be implemented, it will be in the qt version, as Cocoa version will leave ffmpeg soon.

I would like to implement HDR internally though... it seems simple.

Also new release of Cocoa version (v0.17) (https://github.com/ilia3101/MLV-App/releases/tag/v0.17-pre-alpha-print-value-edition) This time it show's the sliders value.
... sessions like Qt GUI will be implemented soon
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 24, 2017, 10:26:37 AM
I would like to implement HDR internally though... it seems simple.
Great.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 24, 2017, 04:30:52 PM
Quote from: escho on August 23, 2017, 03:06:20 PM
Another thing

I use MLV-videos for nothing else than my astronomical stuff. Autostakkert, the program, which I use to stack the videoframes, need uncompressed avi-files as input. It does not run with prores. It would be nice to can export such avi-files with MLVApp sometime in the future.

For my needs I did a workaround, quick and very dirty. Looks like that:

I changed MainWindow.cpp line 636 ff

QString program = QCoreApplication::applicationDirPath();
    program.append( QString( "/ffmpeg\"" ) );
    program.prepend( QString( "\"" ) );
    program.append( QString( " -r %1 -i \"%2\" -c:v rawvideo -pix_fmt %3 \"%4\"" )
                    .arg( getMlvFramerate( m_pMlvObject ) )
                    .arg( numberedFileName )
                    .arg( "yuv420p" )
                    .arg( output ) );

                   
And I replaced all .mov strigs, i found in MainWindow.cpp with .avi.

Edgar

I added export to uncompressed AVI in my latest commit. Hope it works :-) Thanks for your code!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 24, 2017, 08:38:25 PM
Quote from: masc on August 24, 2017, 04:30:52 PM
I added export to uncompressed AVI in my latest commit. Hope it works :-) Thanks for your code!

Works like a charm. Exactly, what I needed. Thankyou very much :)

Rawvideo
Im not sure, but as far as I understand this, it should work like this:
The inputfiles are moved as a bitstream into the avi-container. No changes, no compression.

Edit: I updated my installation-guide for openSUSE :)

Edgar
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on August 26, 2017, 03:26:07 AM
As many requested, the app has Log now.

There is 4 processing image profile options:

More profiles and Log options to be added... any links to formulas for other Log profiles are very welcome

(https://camo.githubusercontent.com/67969614146a058b0f6050c556ef5d751d785cf5/68747470733a2f2f696d6167652e6962622e636f2f667a717148512f416c6578615f4c6f675f537769746368696e672e676966)
(Tone mapped vs Log profile comparison)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: AWPStar on August 26, 2017, 04:51:35 AM
I did some changes in lj92 sources. it's about 46% faster than original.(30 -> 44fps decoding on 1920x720)
I will test stability. If everything will be ok - i will send you the sources.

Very promising application. I have no MacOS and windows gui cannot be ported to it. So mlvp is only for windows (
If you need some features form mlvp - feel free to ask.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 26, 2017, 07:35:39 AM
@AWPStar
Very interesting about the speed optimisation. Probably beneficial to have access to your changes even if it´s not stable.

@Ilia3101
Logs. Check bottom at this post from Baldavenger. Especially linear to .... Think he got them from nuke. I always liked working with cineon and logC.
http://www.magiclantern.fm/forum/index.php?topic=15801.msg158145#msg158145

s-log formula on page 10 here:
https://pro.sony.com/bbsccms/assets/files/mkt/cinema/solutions/slog_manual.pdf

Would be nice to have bmdfilm but havn´t seen any official formula here.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on August 26, 2017, 07:47:19 AM
Quote from: Danne on August 26, 2017, 07:35:39 AM
@AWPStar
Very interesting about the speed optimisation. Probably beneficial to have access to your changes even if it´s not stable.

+1
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Teamsleepkid on August 26, 2017, 08:12:50 AM
really cool app guys. having it faster sounds like a really great idea. sounds like its windows only though right awpstar? also focus pixel correction would be useful.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: AWPStar on August 26, 2017, 08:14:52 AM
>Very interesting about the speed optimisation. Probably beneficial to have access to your changes even if it´s not stable.
I dont use git's.
https://sourceforge.net/projects/mlvproducer/files/src/lj92.c/download

Some curves. 256 points, int32
https://sourceforge.net/projects/mlvproducer/files/src/curves.zip/download
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 26, 2017, 08:43:14 AM
Thanks AWPStar.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: flostro on August 26, 2017, 09:54:19 AM
Here is something about canon log and sony slog3

https://www.sony.de/pro/support/attachment/1237494271390/1237494271406/technical-summary-for-s-gamut3-cine-s-log3-and-s-gamut3-s-log3.pdf

http://learn.usa.canon.com/app/pdfs/white_papers/White_Paper_Clog_optoelectronic.pdf
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on August 26, 2017, 01:19:50 PM
@AWPStar Thanks a lot for the speed optimisation!

@Danne @flostro Thanks for the Log info, I literally couldn't find any formulas myself. Will add all the log curves.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on August 26, 2017, 06:37:14 PM
Added many more Log profiles and eliminated clipping in Log. Download (https://github.com/ilia3101/MLV-App/releases/tag/v0.19-pre-alpha-no-clipping-edition)

Added Cineon and S-Log3, however couldn't get Canon-Log formula right.

Quote from: Ilia3101 on August 26, 2017, 03:26:07 AMTo avoid any clipping, set exposure to -1.2
Ignore this advice now.

I had a thought: Log == tonemaping, so now that is how the log functions are treated, like a form of tonemapping function, so there is no longer any clipping!!!

Adjust exposure as much as you want, and it will be Log-ically correct.

Quote from: Danne on August 05, 2017, 03:55:27 PMWhat is the winning deal in this app is that you retain scene referred dynamic range prior to export.
This is now the case with Log^^^

Please don't ruin any footage by using the previous version (maybe that's exaggeration).

Might avoid developing MLV App for some time, to actually create (edit) a video ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 26, 2017, 07:08:04 PM
Cineon, logC, yummy!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 26, 2017, 07:39:55 PM
MLV App on Linux openSUSE, actual version

Looks like tonemapping is applied on the first run of MLV App, but not marked as applied. I have to press the button "apply tonemapping" twice to turn off tonemapping.

Edgar
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 26, 2017, 07:59:54 PM
I hope I'll find some time to add it also to the cross platform version in the next days... Started my 3 weeks holidays today. But internet connection seems to work :-D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 26, 2017, 08:11:39 PM
Happy holidays :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 26, 2017, 08:56:45 PM
Thx :-) It was not to complicated. It is added to the repos. But there is a tiny bug... Ilia, please check my log :-)
But in general it seems to work fine. Good work Ilia!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on August 27, 2017, 04:41:30 PM
Quote from: masc on August 26, 2017, 08:56:45 PM
It was not to complicated. It is added to the repos.
Works fine
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 27, 2017, 06:18:37 PM
Unfortunately, version MLV.App.v0.6.alpha.x64.Win crashes when I try to export a 14-bit MLV clip from the EOS 100D.  Here is what it says:

------------------------------------------
Problem signature:
  Problem Event Name:   APPCRASH
  Application Name:   MLV App.exe
  Application Version:   0.0.0.0
  Application Timestamp:   599d3f51
  Fault Module Name:   MLV App.exe
  Fault Module Version:   0.0.0.0
  Fault Module Timestamp:   599d3f51
  Exception Code:   c000001d
  Exception Offset:   000000000001247b
  OS Version:   6.1.7601.2.1.0.256.48
  Locale ID:   1033
  Additional Information 1:   e2e5
  Additional Information 2:   e2e5dca40ff74952f8dea9391c49a9c1
  Additional Information 3:   9c18
  Additional Information 4:   9c18eac52f9d534f72d434fbdb235140
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 27, 2017, 07:13:12 PM
Quote from: IDA_ML on August 27, 2017, 06:18:37 PM
Unfortunately, version MLV.App.v0.6.alpha.x64.Win crashes when I try to export a 14-bit MLV clip from the EOS 100D.
How do you export (setting & single file or batch) and when does it crash? Can you chose the file/folder name, crashes it just after pressing save, at 50%,... ? Can you provide a small file which provokes the error please (best if only some single frames inside)?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 27, 2017, 09:08:02 PM
It is a single MLV file of about 300 MB size (109 frames).  Regardless of the export format that I set in the Preferences, when I press Ctrl+E, it opens the export window and allows me to select the folder for export.  When I press Save, the software crashes and I get a message saying: MLVApp.exe has stoped working. 

Unfortunately, I have a very slow internet connection and cannot send you the file now but if you wait until tomorrow, I can try to send it from work where the net is way faster.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 27, 2017, 09:52:39 PM
Quote from: IDA_ML on August 27, 2017, 09:08:02 PM
It is a single MLV file of about 300 MB size (109 frames).  Regardless of the export format that I set in the Preferences, when I press Ctrl+E, it opens the export window and allows me to select the folder for export.  When I press Save, the software crashes and I get a message saying: MLVApp.exe has stoped working. 

Unfortunately, I have a very slow internet connection and cannot send you the file now but if you wait until tomorrow, I can try to send it from work where the net is way faster.
You can use mlv_dump to shorten the clip to some frames, then the file is only some MBs. Does this happen with any MLV file for you?
Quote from: Danne on July 15, 2017, 10:38:29 AM
Just shorten a file with mlv_dump:
mlv_dump -f 5 -o OUTPUT.MLV INPUT.MLV
Gives you a 5 frame MLV file.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 28, 2017, 12:41:29 AM
masc,

I have now done what you requested and created a 5 frame MLV file (about 17 MB) from the original.  It is called OUTPUT.MLV and the download link is:

https://we.tl/namZYCHTpp

It will be active for one week. 

I also checked with other MLV files from other cameras (5D3 and 7D), also on different Win x 64 computers.  The same behavior is observed.  The software crashes on export as I described above.

I wish you a nice vacation!

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 28, 2017, 06:58:36 PM
Okay, thank you very much, I downloaded the file. It is not a general problem, because on OSX I can export your file without issue.
@bouncyball: could you please download the file as well and try on your Windows PCs?
@IDA_ML: happens the same with the 32bit version?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 28, 2017, 09:47:52 PM
Masc,

Yes, version 0.6 x86 crashes too.  However, the old 0.3 version that I happened to keep, exports just fine.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 30, 2017, 11:22:57 AM
Hey guys I'm also on a vacation and got quite lousy connection. Well... sometimes it works ;)

@masc
Tried with uploaded 5 frame MLV and both x86/x64 win versions export it w/o a problem.

@IDA_ML
Do you have enough space on HDD? And does this exact shortened MLV, that you uploaded, also really crashes MLV App?

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on August 30, 2017, 11:32:02 AM
Quote from: IDA_ML on August 28, 2017, 12:41:29 AM
masc,

I have now done what you requested and created a 5 frame MLV file (about 17 MB) from the original.  It is called OUTPUT.MLV and the download link is:

https://we.tl/namZYCHTpp

It will be active for one week. 

I also checked with other MLV files from other cameras (5D3 and 7D), also on different Win x 64 computers.  The same behavior is observed.  The software crashes on export as I described above.

I wish you a nice vacation!

i have downloaded your file and i can export without any problem on my win 7. i have been using this softaware for more than a week and i havent experience any crash
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 30, 2017, 12:03:19 PM
@bouncyball

Yes, I do have enough space on my HDD.  And I checked the shortened 5 frame file too.  I can open it, make adjustments to it, and play it in MLVApp.  However, when I try to export it, MLVApp crashes.  I tested that on three different computers running Win7x64, I tried also files from 7D and 5D3.  The same thing happens with all of them - crash on export.  Version 3 works just fine though.

I used the download link for Version 6 from the first page.  I unzipped the package in a separate directory, started MLVApp.exe by clicking on it and then opened the file using the "Import MLV" command in the file menue.  I am not sure if I am doing anything wrong and what that may be.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 30, 2017, 01:45:10 PM
@IDA_ML

Hm... strange crash on export only, what's really interesting I personally never experienced any serious crash with this app. Have to be seen the differences between those versions in repo.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 30, 2017, 03:45:38 PM
@bouncyball

Could it be that MLVApp requires some additional software installed to work properly?  Just like MLVS required Dokan.  If that is the case, please advise me on what should I install and give me a download link if possible.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 30, 2017, 04:08:40 PM
Nope, no additional software needed (just static ffmpeg.exe in the same folder, which is supplied in the zip). However there maybe some tampering software/lib or different version of QT installed/registered. IDK :)

As I said I never had issues with this software and I tried it on several win7/10 systems.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 30, 2017, 06:52:15 PM
I tried installing the Windows version into Wine on OSX. Also with that I can export your MLV. The crash appears starting version 0.4? The main difference between 0.3 and 0.4 is the use of libpng, to have 16bit PNGs instead of 8bit PNGs Qt supports only.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 30, 2017, 06:59:39 PM
Masc,

Do you think this can be fixed?  I would love to try out version 6 due to all the new features and faster speed.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 30, 2017, 09:22:25 PM
Quote from: IDA_ML on August 30, 2017, 06:59:39 PM
Do you think this can be fixed?  I would love to try out version 6 due to all the new features and faster speed.
I really do not know what happens. So I don't know how to prevent the crash and can't say if it can be fixed. Sorry. This needs more research. But I can't do that here on my MacBook.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 31, 2017, 02:28:04 PM
Masc,

I am sure, other people on Win7x64 will experience the same behaviour and will be able ti identify the problem.  Don't worry about this now.  Just enjoy your vacation!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on August 31, 2017, 02:46:44 PM
i haven't experience a single crash on my win7X64
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 10, 2017, 07:23:35 PM
In order to get ffmpeg started in qt-platform under Linux, it is necessary, that ffmpeg is located in the same folder, where MLV App can be found.

I´m no QT or C++ programmer, I can only do some little bash scripting. So the most, I do here, is try and error.

In my bash-scripts, I start ffmpeg by just typing "ffmpeg", thanks to the PATH envirement variable. I tried that with MLV App and it worked for me. Here the code, I changed in MainWindow.cpp lines 696 ff for testing:

//FFMpeg export
QString program = "ffmpeg";
//QString program = QCoreApplication::applicationDirPath();
//program.append( QString( "/ffmpeg\"" ) );
//program.prepend( QString( "\"" ) );
...


With this method, I don´t need to copy ffmpeg to the "MLV APP-folder" anymore. But I don´t know, what Windows and OSX say to such a method?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 10, 2017, 11:00:07 PM
On OSX that does not work out of the box. It would work if you install ffmpeg, but I wanted to have it in the application bundle, because for most users that is the easiest way (because the user hasn't do install anything but the app itself). For windows I am not sure, but I expect the same.

Edit: I could make a define which takes your string for Linux, and the other string for the other platforms. Would that be easier for Linux?

Edit2: Did that now. I think that should be better for Linux users.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 11, 2017, 07:45:07 PM
Wanted to try this version and downloaded zip from github. But QT-Creator says:
Project ERROR: Unknown module(s) in QT: multimedia
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 11, 2017, 08:36:06 PM
Installed "libqt5-qtmultimedia-devel" and it compiles.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 11, 2017, 09:43:47 PM
Yes, you'll need this for the latest revisions. I started implementing audio playback. But... it still a bit buggy ;-)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 11, 2017, 10:07:30 PM
Could anyone on macOS 10.10-10.12 please test the app and see if the preview refreshes when opening clips and making adjustments?
You'll have to compile it yourself, just enter this in the terminal:
rm -rf MLV-App && git clone https://github.com/ilia3101/MLV-App.git && cd MLV-App/platform/cocoa && make app && cd - && open MLV-App/platform/cocoa/ && open MLV-App/platform/cocoa/MLV\ App.app
... as I'm having some issues on macOS 10.13 beta
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 11, 2017, 10:26:08 PM
I´m on 10.12.3 and yes, the preview does not refresh anymore. Just compiled the latest. Hope it helps even if I´m not on 10.10

Nice :)
(https://s26.postimg.org/6l0ucdh7t/Screen_Shot_2017-09-11_at_22.34.00.png)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 11, 2017, 10:33:14 PM
Thanks a lot for the quick response!
All I needed to know.

Pretty sure it's broken :(

About the icon: The "source code" is in src/icon, so if you know Blender and icon design you're welcome to improve it ;););) (@anyone)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 11, 2017, 11:11:37 PM
aaah, blender. Tried to make sense of that very professional, open source program but never really got my head around it.
Like your progress with Mlv app. Will be very useful.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on September 13, 2017, 03:01:46 AM
I'm on 10.10.5 and the native macOS version says 10.11 is required. The app has a crossmark icon and can't be opened obviously.
Reading through the thread it seems people are running this on 10.10 or am I wrong?

The cross-platform version works though.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 13, 2017, 08:17:37 AM
@FBongcam (If you find time!) Could you please try and compile the app yourself:
rm -rf MLV-App && git clone https://github.com/ilia3101/MLV-App.git && cd MLV-App/platform/cocoa && make app && cd - && open MLV-App/platform/cocoa/ && open MLV-App/platform/cocoa/MLV\ App.app
If that doesn't instantly work you might have to quickly do this: http://osxdaily.com/2014/02/12/install-command-line-tools-mac-os-x/ (http://osxdaily.com/2014/02/12/install-command-line-tools-mac-os-x/)
The app is in a slightly broken state right now, but it will be fixed later today. But if possible, it would be great to see if it compiles on 10.10 :)

EDIT: app is fixed, should now refresh view 100% of the time (display mechanism has been completely "reengineered")
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 13, 2017, 11:14:37 PM
In the last weeks Ilia implemented many new features and I integrated them into the Qt version of MLV App. Here we also have the image profiles now and audio support: we can playback audio on preview, export and draw the audio track in the GUI (maybe audio is not perfectly in sync, but Ilia had already an idea how to fix that...).
Windows version will come if @bouncyball (or someone else) finds some time to build it for you. So here is first the OSX 10.9.5+ version:
https://github.com/ilia3101/MLV-App/releases/tag/QTv0.7alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.7alpha)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on September 14, 2017, 12:32:19 AM
Quote from: Ilia3101 on September 13, 2017, 08:17:37 AM
@FBongcam (If you find time!) Could you please try and compile the app yourself:
git clone https://github.com/ilia3101/MLV-App.git && cd MLV-App/platform/cocoa && make app && cd - && open MLV-App/platform/cocoa/ && open MLV-App/platform/cocoa/MLV\ App.app
I ran this and the app still won't open. It says the app is damaged or incomplete.


Terminal gives me this error (if it's of any help):


Initial app name: MLV App (Sep 14 2017 00:14:10)
rm: main.o: No such file or directory
gcc  -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c main.m
main.m:80:40: error: use of undeclared identifier
      'NSWindowStyleMaskFullSizeContentView'
        | NSMiniaturizableWindowMask | NSWindowStyleMaskFullSizeContentView;
                                       ^
1 error generated.
make[2]: *** [main.o] Error 1
cp: MLV App: No such file or directory
cp: checkupdate.py: No such file or directory
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg 

The application cannot be opened because its executable is missing.


Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on September 14, 2017, 01:40:05 AM
Quote from: masc on September 13, 2017, 11:14:37 PM
In the last weeks Ilia implemented many new features and I integrated them into the Qt version of MLV App. Here we also have the image profiles now and audio support: we can playback audio on preview, export and draw the audio track in the GUI (maybe audio is not perfectly in sync, but Ilia had already an idea how to fix that...).
Windows version will come if @bouncyball (or someone else) finds some time to build it for you. So here is first the OSX 10.9.5+ version:
https://github.com/ilia3101/MLV-App/releases/tag/QTv0.7alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.7alpha)

This new version (QTv0.7alpha) doesn't output the prores file for me. I can see the png files being created while it's rendering but when it's finished the folder is just empty. I've tried with different settings and also by leaving everything default without any luck.
I'm on OSX 10.10.5.

Edit:
After reading the app page "Support for mlv_dump uncompressed MLV files seems to be broken", maybe that's what I'm experiencing :), I tried both 10bit and 14bit though.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 14, 2017, 08:36:02 AM
Quote from: FBongcam on September 14, 2017, 01:40:05 AM
"Support for mlv_dump uncompressed MLV files seems to be broken", maybe that's what I'm experiencing :)
..Hmmm, but does the app actually work? if you can see the clips and adjust them, then the problem is something else.

Quote from: FBongcam on September 14, 2017, 12:32:19 AM
Terminal gives me this error (if it's of any help):
Thanks! it was useful... figured out from it that Apple must have made a little lie about API support, because I remember reading them saying that was 10.10+, but seems its actually 10.11+, so I've changed it back to what I used before (older API). Could you test again if you find time? It should work now. I'm almost surprised that there was only one error :D

@masc's v0.7 release is getting really good!!!
I don't think ill be able to match it with the cocoa GUI ever :(
Also @masc could you make Tonemapped the default profile for next release? I think it's a better default for most people
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 14, 2017, 09:21:44 AM
Quote from: FBongcam on September 14, 2017, 01:40:05 AM
This new version (QTv0.7alpha) doesn't output the prores file for me. I can see the png files being created while it's rendering but when it's finished the folder is just empty. I've tried with different settings and also by leaving everything default without any luck.
I'm on OSX 10.10.5.
@FBongcam: Does someone else have this problem? For me that works. Does the progressbar jump from 50 to 100%? If you see pictures in the app it is not the issue I wrote about. It must be an issue with ffmpeg.

@Ilia: Thanks. Qt on OSX is also just wrapped cocoa... ;) I'll try that with the default profile.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on September 14, 2017, 05:02:08 PM
Quote from: Ilia3101 on September 14, 2017, 08:36:02 AM
Thanks! it was useful... figured out from it that Apple must have made a little lie about API support, because I remember reading them saying that was 10.10+, but seems its actually 10.11+, so I've changed it back to what I used before (older API). Could you test again if you find time? It should work now. I'm almost surprised that there was only one error :D
Yes it does work now, thanks  :)
However the app crashes every time it has finished exporting the prores, maybe it's something related to 10.10 or is it a known issue?

Quote from: masc on September 14, 2017, 09:21:44 AM
@FBongcam: Does someone else have this problem? For me that works. Does the progressbar jump from 50 to 100%? If you see pictures in the app it is not the issue I wrote about. It must be an issue with ffmpeg.
Yes it seems to jump from about 50% straight to the notification that the export has finished, as you described. I can see pictures in the app, yes.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 14, 2017, 08:44:00 PM
Quote from: FBongcam on September 14, 2017, 05:02:08 PM
Yes it does work now, thanks  :)
However the app crashes every time it has finished exporting the prores, maybe it's something related to 10.10 or is it a known issue?
Yes it seems to jump from about 50% straight to the notification that the export has finished, as you described. I can see pictures in the app, yes.
Okay, if Ilias cocoa app crashes on export, and my Qt App jumps from 50..100% then I am nearly 100% sure that ffmpeg does not work on your machine (whyever). If you see the png files - could you please convert manually using ffmpeg in the application bundle? In the Qt app it is located under "MLV App/Contents/MacOS/ffmpeg". Go to this directory in terminal and type
./ffmpeg -i "<path to your pngs>/chosenFileName_\%05d.png" -c:v prores_ks -profile:v 2 "<path to your desktop>/test.mov"
Does that work? I think it will end with an error. But can you tell us what ffmpeg tells exactly?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on September 14, 2017, 10:06:57 PM
Quote from: masc on September 14, 2017, 08:44:00 PM
Okay, if Ilias cocoa app crashes on export, and my Qt App jumps from 50..100% then I am nearly 100% sure that ffmpeg does not work on your machine (whyever). If you see the png files - could you please convert manually using ffmpeg in the application bundle? In the Qt app it is located under "MLV App/Contents/MacOS/ffmpeg". Go to this directory in terminal and type
./ffmpeg -i "<path to your pngs>/chosenFileName_\%05d.png" -c:v prores_ks -profile:v 2 "<path to your desktop>/test.mov"
Does that work? I think it will end with an error. But can you tell us what ffmpeg tells exactly?
The png files also disappear when it's finished but I can see them while it's exporting and as soon as the export says it's finished, everything is gone.

I forced quit MLV App during export to keep some png files it managed to render, just to get a sequence of png files. Then I ran ffmpeg on the files and it created the file succesfully.
Here's what terminal gave me:


./ffmpeg -i M12-1835_test_\%05d.png -c:v prores_ks -profile:v 2 "test.mov"
ffmpeg version 3.3.2-tessus Copyright (c) 2000-2017 the FFmpeg developers
  built with Apple LLVM version 8.0.0 (clang-800.0.42.1)
  configuration: --cc=/usr/bin/clang --prefix=/opt/ffmpeg --extra-version=tessus --enable-avisynth --enable-fontconfig --enable-gpl --enable-libass --enable-libbluray --enable-libfreetype --enable-libgsm --enable-libmodplug --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopus --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libtheora --enable-libvidstab --enable-libvo-amrwbenc --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libx264 --enable-libx265 --enable-libxavs --enable-libxvid --enable-libzmq --enable-libzvbi --enable-version3 --disable-ffplay --disable-indev=qtkit
  libavutil      55. 58.100 / 55. 58.100
  libavcodec     57. 89.100 / 57. 89.100
  libavformat    57. 71.100 / 57. 71.100
  libavdevice    57.  6.100 / 57.  6.100
  libavfilter     6. 82.100 /  6. 82.100
  libswscale      4.  6.100 /  4.  6.100
  libswresample   2.  7.100 /  2.  7.100
  libpostproc    54.  5.100 / 54.  5.100
Input #0, image2, from 'M12-1835_test_%05d.png':
  Duration: 00:00:04.28, start: 0.000000, bitrate: N/A
    Stream #0:0: Video: png, rgb48be(pc), 1920x1080, 25 tbr, 25 tbn, 25 tbc
Stream mapping:
  Stream #0:0 -> #0:0 (png (native) -> prores (prores_ks))
Press [q] to stop, [?] for help
Output #0, mov, to 'test.mov':
  Metadata:
    encoder         : Lavf57.71.100
    Stream #0:0: Video: prores (prores_ks) (apcn / 0x6E637061), yuv444p10le, 1920x1080, q=2-31, 200 kb/s, 25 fps, 12800 tbn, 25 tbc
    Metadata:
      encoder         : Lavc57.89.100 prores_ks
frame=    3 fps=0.0 q=-0.0 size=    1889kB time=00:00:00.08 bitrate=193250.8kbitframe=    7 fps=6.3 q=-0.0 size=    4405kB time=00:00:00.24 bitrate=150313.2kbitframe=   11 fps=6.5 q=-0.0 size=    6922kB time=00:00:00.40 bitrate=141740.9kbitframe=   15 fps=6.5 q=-0.0 size=    9442kB time=00:00:00.56 bitrate=138109.9kbitframe=   19 fps=6.6 q=-0.0 size=   11959kB time=00:00:00.72 bitrate=136053.1kbitframe=   23 fps=6.6 q=-0.0 size=   14476kB time=00:00:00.88 bitrate=134747.5kbitframe=   27 fps=6.6 q=-0.0 size=   16992kB time=00:00:01.04 bitrate=133833.9kbitframe=   31 fps=6.6 q=-0.0 size=   19509kB time=00:00:01.20 bitrate=133176.1kbitframe=   35 fps=6.6 q=-0.0 size=   22025kB time=00:00:01.36 bitrate=132662.3kbitframe=   39 fps=6.6 q=-0.0 size=   24543kB time=00:00:01.52 bitrate=132265.1kbitframe=   43 fps=6.7 q=-0.0 size=   27060kB time=00:00:01.68 bitrate=131942.6kbitframe=   47 fps=6.7 q=-0.0 size=   29576kB time=00:00:01.84 bitrate=131673.7kbitframe=   51 fps=6.7 q=-0.0 size=   32094kB time=00:00:02.00 bitrate=131450.9kbitframe=   55 fps=6.7 q=-0.0 size=   34609kB time=00:00:02.16 bitrate=131253.6kbitframe=   59 fps=6.7 q=-0.0 size=   37128kB time=00:00:02.32 bitrate=131094.3kbitframe=   63 fps=6.7 q=-0.0 size=   39647kB time=00:00:02.48 bitrate=130957.6kbitframe=   67 fps=6.7 q=-0.0 size=   42164kB time=00:00:02.64 bitrate=130830.9kbitframe=   71 fps=6.7 q=-0.0 size=   44680kB time=00:00:02.80 bitrate=130716.8kbitframe=   75 fps=6.7 q=-0.0 size=   47197kB time=00:00:02.96 bitrate=130617.7kbitframe=   79 fps=6.7 q=-0.0 size=   49716kB time=00:00:03.12 bitrate=130532.0kbitframe=   83 fps=6.7 q=-0.0 size=   52231kB time=00:00:03.28 bitrate=130447.8kbit[png @ 0x7f8fbc013e00] chunk too big
[png @ 0x7f8fbc014a00] chunk too big
[png @ 0x7f8fbc015600] chunk too big
frame=   87 fps=6.7 q=-0.0 size=   54751kB time=00:00:03.44 bitrate=130380.2kbit[png @ 0x7f8fbc016200] chunk too big
[png @ 0x7f8fbc016e00] chunk too big
[png @ 0x7f8fbc017a00] chunk too big
[png @ 0x7f8fbc018600] chunk too big
frame=   91 fps=6.7 q=-0.0 size=   57267kB time=00:00:03.60 bitrate=130312.5kbit[png @ 0x7f8fbc019200] chunk too big
[png @ 0x7f8fbc010800] chunk too big
[png @ 0x7f8fbc010e00] chunk too big
[png @ 0x7f8fbc011a00] chunk too big
frame=   95 fps=6.7 q=-0.0 size=   59787kB time=00:00:03.76 bitrate=130256.6kbitError while decoding stream #0:0: Invalid data found when processing input
frame=   96 fps=6.6 q=-0.0 Lsize=   60420kB time=00:00:03.80 bitrate=130249.5kbits/s speed=0.263x   
video:60418kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.002408%


A few files in the end of the sequence were broken obviously so maybe that gave some errors, but the prores file is working.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 14, 2017, 10:13:31 PM
Some feedback to qt v0.7 on Linux

Video converts fine (I cannot test audio, because I don´t use it).

Is there a limit for the size of the mlv? Converting a 3GB MLV works, but converting a 7GB MLV let the app crash on importing:

*** Error in `/home/edgar/MLV App/MLV-App-master/platform/build-MLVApp-Desktop-Release/MLV App': malloc(): memory corruption: 0x0000000002e05730 ***
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 14, 2017, 11:25:04 PM
@FBongcam: thank you. So that works. Can you tell me the framerate of your clips? If there is a "." in the framerate, some qt librarys could make the "." to a "," and so ffmpeg does not run. Before -i in the command I made a -r 25 for 25 fps in the app. In my case it was always the "." (at 23.x fps), but that may be different from country to country.
Does it work with a 25fps file in your case? Or, easier: check in the preferences menu framerate override and type 25! Does it export now?

Edit: tried it with another locale and have exactly your problem :-) Anyway... does 25fps work for you? Then I can fix it!

@escho: The maximum file size I could test with my 5D2 was 4GB, so I can't tell you. If I get such a big file one day I could debug and help...  :-\
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on September 15, 2017, 12:02:34 AM
Quote from: masc on September 14, 2017, 11:25:04 PM
@FBongcam: thank you. So that works. Can you tell me the framerate of your clips? If there is a "." in the framerate, some qt librarys could make the "." to a "," and so ffmpeg does not run. Before -i in the command I made a -r 25 for 25 fps in the app. In my case it was always the "." (at 23.x fps), but that may be different from country to country.
Does it work with a 25fps file in your case? Or, easier: check in the preferences menu framerate override and type 25! Does it export now?

Edit: tried it with another locale and have exactly your problem :-) Anyway... does 25fps work for you? Then I can fix it!
Clips are shot at 24p.

I can confirm, turning on framerate override to 25p did work  :)

Edit:
Turning on framerate override to 24p worked as well.
I shoot with fps override set on Exact fps to 24 in magic lantern so the clips should be exactly 24 from the beginning. Just some extra info if it's relevant to your issues with the "." (at 23.x fps).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ottoga on September 15, 2017, 12:49:33 AM
Just had a look at v0.7 cross platform.  The download zip file is for MAC only. IS an x86 build on its way?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 15, 2017, 12:22:27 PM
Quote from: FBongcam on September 15, 2017, 12:02:34 AM
Clips are shot at 24p.

I can confirm, turning on framerate override to 25p did work  :)

Edit:
Turning on framerate override to 24p worked as well.
I shoot with fps override set on Exact fps to 24 in magic lantern so the clips should be exactly 24 from the beginning. Just some extra info if it's relevant to your issues with the "." (at 23.x fps).
Okay, thanks a lot! That really helped. I think I fixed the Qt version in the repos (don't know how to do in cocoa).

Quote from: Ottoga on September 15, 2017, 12:49:33 AM
The download zip file is for MAC only. IS an x86 build on its way?
You mean a Windows version? -> Windows version will come if @bouncyball (or someone else) finds some time to build it for you. I only have a mac here atm. But it will come... it just has to be compiled.
Or do you mean OSX x86? I am not sure if it is possible to compile it. Maybe somebody has a SnowLeopard and can compile it...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ottoga on September 15, 2017, 02:59:44 PM
QuoteYou mean a Windows version?

Yes,  NP i'm patient.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 15, 2017, 04:25:00 PM
Quote from: FBongcam on September 14, 2017, 05:02:08 PM
However the app crashes every time it has finished exporting the prores, maybe it's something related to 10.10 or is it a known issue?

Ah yes, this is a bug that appeared recently, it happens for em on 10.13 beta too, the clip does export fully (ffmpeg runs 100% to the end as far as I know @masc, so the bugs in our versions are different probably), but for some reason the app crashes, right before notification gets shown/as it gets shown. I need to fix this before I can make another little testing release.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 15, 2017, 06:09:54 PM
Ah okay, so it is something different. But if it happens for you too, you can debug it... :-)
Did you have some time to look for the processing things like chroma and bad pixel (I commited the source from mlv_dump a while ago)? I had no luck to get it to work yet :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 15, 2017, 06:20:33 PM
Ah yes, I did look at that code a couple of weeks ago, to use it, I'll have to move them to src/mlv because they work on raw data before it is even debayered, what this also means is that if the chroma smoothing and bad pixel features are enabled, the caching will have to be re-done as debarred results will change. Also an idea for Qt app: close clips when switching between them so you can enable caching? Or maybe close clips after a few seconds in case user quickly switches back, then enable caching when all others are closed??
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 15, 2017, 06:32:30 PM
Hey guys!

@masc, @ilia3101

While on vacation I did some progress with low level raw processing integration to MLV App. I ported almost everything I did in the past with mlv_dump on steroids: stripes, focus pixels, bad pixels, chroma smooth, pattern noise and even deflicker function of MLVFS. There is only rudimentary visual GUI implementation though. However all settings can be changed in 'initLLRawProcObject' routine. Also there 'DEFINES += STDOUT_SILENT' is commented out and you can watch on console all verbose messages during raw processing. Later, I will upload focus pixel maps and some testing 100D and EOSM footage MLVs to test it with.

Look at my fork here: https://github.com/bouncyball-git/MLV-App/commits/master (https://github.com/bouncyball-git/MLV-App/commits/master).
I would really appreciate opinions of both of you :)

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 15, 2017, 06:38:58 PM
@bouncyball: great! I'll test that! :)
@Ilia: In the Qt app there is always only one file opened, the files in the session are only listed. But when enabling caching I get crashes and pink frames.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 15, 2017, 07:02:48 PM
Wohooo... I like the processing! All the bad pixels are gone! :) In the GUI I would place the fields a bit different, because my 1280x800 display is too small now :) But that is really no problem. But between the GUI elements and your processing object is no connection yet, or? You planned to implement the functions to change the settings (I think so)... Nice work! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 15, 2017, 07:29:41 PM
@bouncball Awesome of you to do that! Thanks a lot.
Will see how it works.
When do you plan to commit it to main repository? (Or "pull request" it)

Sorry about some of the code from my C learning phase(overcommented :-[)

After you merge it, I'll work on getting caching compatible with your module (needs clearing on changes), probably a full rewrite. (unless you did that, but I don't ask that of you if you haven't ;), as Qt doesn't even use it at this moment)

Anyway thanks again!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 15, 2017, 07:51:58 PM
@bouncyball
I know your code works, but it won't compile for me, I'm just not sure why it would just randomly begin erroring like this:

(http://image.ibb.co/huXGJk/Screen_Shot_2017_09_15_at_18_48_24.png)

Does it need some special compile flags? Do you know what it could be?
The type errors should be a matter of #including stdint, but what are the undeclared identifiers?

EDIT: never mind, found my idiotic mistake :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 15, 2017, 09:17:18 PM
@Ilia: strange... with clang in Qt it compiles... :-/
@bouncyball: I would draw the MainWindow like that: https://www.dropbox.com/s/elhz5plgy55qfwx/MainWindow.ui?dl=0 (https://www.dropbox.com/s/elhz5plgy55qfwx/MainWindow.ui?dl=0)
What do you think?

Edit: I found one thing: if vertical stripes is enabled, Highlight reconstruction does not work. And for the first clip opened, bad pixel does not work. If I switch to another clip, and switch back, all is fine. But those things we can debug later ;) It is a huge change!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 16, 2017, 07:21:55 AM
@ilia3101: I will do pull request when we settle all issues/problems. It's a working draft which can be changed anytime especially when connection to GUI is implemented (it's not implemented right now).

@masc: I'm ok with any gui you offer and will appreciate your help on implementing it (will look at your .ui file later) I'm still learning QT basics :). Nice bug catching, as you mentioned changes are big.

I had to rewrite lot of my code to port this. There I used lots of static local variables in mlv_dump because it works only with one MLV at a time and this approach very convenient. Now in MLV App there can be any number of MLV object instances (I know, now, objects are freed every time when choosing another MLV but anyway) so it would not work here.

BTW I noticed very annoying and strange bug under linux when using MLV App. When resizing main window if no MLV is imported yet, window can be enlarged horizontally but can not be made smaller again ;). This issue disappears if MLV imported and window can be shrunk again. Have not tried this under windows though.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 16, 2017, 07:25:27 AM
Great effort BB. Will check this out soon.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 16, 2017, 07:29:15 AM
@Danne: :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 16, 2017, 01:43:37 PM
Quote from: bouncyball on September 16, 2017, 07:21:55 AMBTW I noticed very annoying and strange bug under linux when using MLV App. When resizing main window if no MLV is imported yet, window can be enlarged horizontally but can not be made smaller again ;).
Also had this on Mac

Quote from: masc on September 15, 2017, 09:17:18 PMI found one thing: if vertical stripes is enabled, Highlight reconstruction does not work. And for the first clip opened, bad pixel does not work. If I switch to another clip, and switch back, all is fine. But those things we can debug later ;) It is a huge change!
These kind of things are normally silly bugs by me, I'll have a look what is causing it today(or maybe this one is deeper?).

@bouncyball what are the default settings in your module already doing? Is stripe correction on by default?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 16, 2017, 04:29:51 PM
Quote from: Ilia3101 on September 16, 2017, 01:43:37 PM
@bouncyball what are the default settings in your module already doing? Is stripe correction on by default?

This is the 'llrawprocObject_t' struct:

typedef struct
{
    /* flags */
    int vertical_stripes; // fix vertical stripes, 0 - do not fix", 1 - fix, 2 - calculate for every frame
    int focus_pixels;     // fix focus pixels, 0 - do not fix, 1 - fix
    int fpi_method;       // focus pixel interpolation method: 0 - mlvfs, 1 - raw2dng
    int bad_pixels;       // fix bad pixels, 0 - do not fix, 1 - fix, 2 - makes algorithm aggresive to reveal more bad pixels
    int bpi_method;       // bad pixel interpolation method: 0 - mlvfs, 1 - raw2dng
    int chroma_smooth;    // chroma smooth, 2 - cs2x2, 3 - cs3x3, 5 - cs5x5
    int pattern_noise;    // fix pattern noise (0, 1)
    int deflicker_target; // deflicker value
    int first_time;       // controls some events which should occur only once per object instance
    int fpm_status;       // focus pixel map status: 0 = not loaded, 1 = loaded, 2 = not exist
    int bpm_status;       // bad pixel map status: 0 = not loaded, 1 = loaded, 2 = not exist, 3 = no bad pixels found
    int dual_iso;         // is RAW data dualiso or not (0, 1, for correctly prosessing of bad/focus pixels, can be removed if DISO block parsing is implemented)

    /* LUTs */
    int * raw2ev;
    int * ev2raw;

    /* pixel maps */
    pixel_map focus_pixel_map;
    pixel_map bad_pixel_map;

    /* stripe corrections */
    stripes_correction stripe_corrections;

    /* image buffer */
    uint16_t * raw_image_buff;
    size_t raw_image_size;

} llrawprocObject_t;


And the defaults are:

/* set defaults */
    llrawproc->vertical_stripes = 1; // enabled
    llrawproc->focus_pixels = 1; // enabled
    llrawproc->fpi_method = 1; // raw2dng interpolation method
    llrawproc->bad_pixels = 1; // enabled
    llrawproc->bpi_method = 1; // raw2dng interpolation method
    llrawproc->chroma_smooth = 0; // disabled
    llrawproc->pattern_noise = 0; // disabled
    llrawproc->deflicker_target = 0; // disabled
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 16, 2017, 07:31:18 PM
Thanks @bouncyball for yet bringing another life into this already remarkable app with so much potential. Will test out QTv0.7alpha and report my findings!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 16, 2017, 09:05:16 PM
Quote from: bouncyball on September 16, 2017, 07:21:55 AM
I'm ok with any gui you offer and will appreciate your help on implementing it (will look at your .ui file later) I'm still learning QT basics :).
I help where I can! :) Or, just give me the interfaces and I'll do it - no problem ;)

Quote from: bouncyball on September 16, 2017, 07:21:55 AM
I had to rewrite lot of my code to port this. ...
Wow, good job. I see, it was even more work than I thought!

Quote from: bouncyball on September 16, 2017, 07:21:55 AM
BTW I noticed very annoying and strange bug under linux when using MLV App. When resizing main window if no MLV is imported yet, window can be enlarged horizontally but can not be made smaller again ;). This issue disappears if MLV imported and window can be shrunk again. Have not tried this under windows though.
Yes, my fault. I fixed that yesterday. See Ilias github. https://github.com/ilia3101/MLV-App/commit/76a727395e6f2c5bef4d559d76809806cb4046f8 (https://github.com/ilia3101/MLV-App/commit/76a727395e6f2c5bef4d559d76809806cb4046f8)

Quote from: DeafEyeJedi on September 16, 2017, 07:31:18 PM
Will test out QTv0.7alpha and report my findings!
Thx! Perfect! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 17, 2017, 10:03:29 AM
I'm going to work on getting bouncyball's work implemented in the Cocoa GUI. @masc what do you think of having tabs on the right panel, one for the raw level processing by bouncyball, one for the standard raw adjustments we already have, and in the future, a final tweaks tab with more colour adjustment type things.

@bouncyball I see you have to set internal properties on the llrawprocObject (raw_image_buff and raw_image_size), I know maybe it wouldn't be how you want it, but what do you think of making it an option to do something like applyLLRawProcObject() but with extra arguments for the image buffer and image size, as I think in the future(when cache is fixed), there will be a few threads caching separate frames at the same time, so the object having it's one image buffer internally could be an issue.

Something approximately like: applyLLRawProcObjectToBuffer(mlvObject, buffer, size) ?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 17, 2017, 12:14:08 PM
@Ilia: this is exactly what I thought too. You have Qt not installed, so you could not see my .ui I uploaded some posts above. Here how it looks:

(https://image.ibb.co/bEb7tk/Bildschirmfoto_2017_09_17_um_12_09_40.png)

Process is what we had before (but without the profile combobox), Correct is the RAW correction, and Profile is the profile combobox + LUT (maybe we want support that in the future? Would be cool to import .cube files).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 17, 2017, 04:03:23 PM
Hey guys!

I've fixed severe bug caused by overwritten black and white levels right after opening and reading MLV headers in openMlvClip routine. Bayered raw data processing requires original values from MLV. Look at my commits here (https://github.com/bouncyball-git/MLV-App/commits/master).

Here is a console output example when everything is set to ON:

Per-frame exposure compensation: 'ON'
Deflicker target: '3072'

Fixing pattern noise...

Using focus pixel map: '80000326_1808x726.fpm'
37440 pixels loaded

Searching for bad pixel types:
HOT  - p = 2271, dark_min = 1949, dark_max = 2141
COLD - p = 1943, dark_min = 1949, dark_max = 2141
COLD - p = 1938, dark_min = 1949, dark_max = 2141
HOT  - p = 2147, dark_min = 1949, dark_max = 2141
HOT  - p = 2207, dark_min = 1949, dark_max = 2141
HOT  - p = 2148, dark_min = 1949, dark_max = 2141
COLD - p = 1948, dark_min = 1949, dark_max = 2141
HOT  - p = 2154, dark_min = 1949, dark_max = 2141
HOT  - p = 2151, dark_min = 1949, dark_max = 2141
HOT  - p = 2145, dark_min = 1949, dark_max = 2141
COLD - p = 1931, dark_min = 1949, dark_max = 2141
COLD - p = 1915, dark_min = 1949, dark_max = 2141
HOT  - p = 2167, dark_min = 1949, dark_max = 2141
COLD - p = 1925, dark_min = 1949, dark_max = 2141
HOT  - p = 2195, dark_min = 1949, dark_max = 2141
HOT  - p = 2790, dark_min = 1949, dark_max = 2141
COLD - p = 1946, dark_min = 1949, dark_max = 2141
HOT  - p = 2156, dark_min = 1949, dark_max = 2141
COLD - p = 1888, dark_min = 1949, dark_max = 2141
COLD - p = 1938, dark_min = 1949, dark_max = 2141
HOT  - p = 2315, dark_min = 1949, dark_max = 2141
COLD - p = 1943, dark_min = 1949, dark_max = 2141
COLD - p = 1947, dark_min = 1949, dark_max = 2141
COLD - p = 1941, dark_min = 1949, dark_max = 2141
HOT  - p = 2157, dark_min = 1949, dark_max = 2141
HOT  - p = 2226, dark_min = 1949, dark_max = 2141
HOT  - p = 2207, dark_min = 1949, dark_max = 2141

Using bad pixel revealing method: 'NORMAL'
27 bad pixels found (crop: 152, 132)

Using chroma smooth method: '2x2'

Vertical stripes correction: 'UNNEEDED'
  1.00000  1.00000  1.00035  1.00047  0.99953  0.99930  0.99995  0.99875


@masc: I loved your .ui file! Tabbed version is very good! :). Still tracking bug which causes not fixing bad pixels on first load.

HERE (http://nic.caucasus.net/mlvapp/?dir=&download=Test_footage_and_focus_pixel_maps.zip) is a zip file with 3 MLVs for testing (EOSM, 100D and 700D ones, thanx to Danne and dfort) and focus pixel maps which should be placed in the same dir with MLV App binary.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 17, 2017, 04:18:35 PM
Quote from: Ilia3101 on September 17, 2017, 10:03:29 AM
I see you have to set internal properties on the llrawprocObject (raw_image_buff and raw_image_size), I know maybe it wouldn't be how you want it, but what do you think of making it an option to do something like applyLLRawProcObject() but with extra arguments for the image buffer and image size, as I think in the future(when cache is fixed), there will be a few threads caching separate frames at the same time, so the object having it's one image buffer internally could be an issue.

Something approximately like: applyLLRawProcObjectToBuffer(mlvObject, buffer, size) ?
Technically there is no problem with passing extra parameters at all. However I thought llrawproc object should be separate for each mlvObject instance in the future with all it's unique parameters. For example raw2ev and ev2raw LUTs are calculated every time for every MLV because of the black level and bit depth, also stripe corrections array and bad/focus pixel map arrays are specific to particular mlvObject. We should discuss this on github I guess.

In contrary, if I understand it correctly, ProsessingObject allocated once and its values are refreshing according to recipe every time we switch the mlv, am I right?

EDIT: Right. Now I understand what you mean by saying "there will be a few threads caching separate frames at the same time, so the object having it's one image buffer internally could be an issue". Will see what can I do about it.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 17, 2017, 04:37:50 PM
@DeafEyeJedi

Quote from: DeafEyeJedi on September 16, 2017, 07:31:18 PM
Thanks @bouncyball for yet bringing another life into this already remarkable app with so much potential. Will test out QTv0.7alpha and report my findings!
It's nice to see you still watching and testing things like in a good old times :D

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 17, 2017, 05:28:57 PM
@bouncyball Ah, the overwritten black level, I'm sorry that was there, if you want, you can remove it and keep the original levels, and remove the whole 16 bit conversion bitshift, and simply pass the original 10/12/14 bit values to the processingObject, as it should be competely fine if you give it the right black and white levels that match the smaller range.

Yes I agree with having a unique object for every clip, I just meant that I want to pass the image data directly to the 'apply' function, so that it can be used from many threads (on the same clip of course).

@deafeyejedi :)

@masc that looks pretty much like what I imagined! Although I don't think it's worth having a separate profile tab yet, as the customisability isn't that interestingly yet, I think it would be fine to keep it in the processing tab for now.
Cube luts are definitely something I want to add, just don't know how they work yet, although I think the LUT tool would go in with the final adjustments section.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 17, 2017, 07:25:06 PM
Quote from: Ilia3101 on September 17, 2017, 05:28:57 PM
you can remove it and keep the original levels, and remove the whole 16 bit conversion bitshift, and simply pass the original 10/12/14 bit values to the processingObject, as it should be competely fine if you give it the right black and white levels that match the smaller range.
Hmm... did you try this and it worked well? Why we need to convert data to 16 bits if debayering and processing code does not really need this? Did you have something different on your mind doing this? Or was it just for simplicity to not handle all 10/12/14 bit black correction separately?

Quote from: Ilia3101 on September 17, 2017, 05:28:57 PM
@masc that looks pretty much like what I imagined! Although I don't think it's worth having a separate profile tab yet, as the customisability isn't that interestingly yet, I think it would be fine to keep it in the processing tab for now.
Well guys, if you liked changes (and I can confirm that ~98% of it working correctly ;) ) then maybe I will do pull request before we start integrating it with GUI?

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 17, 2017, 07:54:44 PM
Quote from: Ilia3101 on September 17, 2017, 05:28:57 PM
@masc that looks pretty much like what I imagined! Although I don't think it's worth having a separate profile tab yet, as the customisability isn't that interestingly yet, I think it would be fine to keep it in the processing tab for now.
Cube luts are definitely something I want to add, just don't know how they work yet, although I think the LUT tool would go in with the final adjustments section.
Cool. Yes, I also would like to have the profiles in the process tab for now. But because of the tab bar it was one element to high to work at 1280x800 with dock. So I was thinking about a 3rd tab... What we also could do: adding a scrolling area (instead or inside the tabs) Adobe Lightroom-like.

Quote from: bouncyball on September 17, 2017, 07:25:06 PM
Well guys, if you liked changes (and I can confirm that ~98% of it working correctly ;) ) then maybe I will do pull request before we start integrating it with GUI?
The GUI is often the nice part. But I think the GUI should be the last thing to do. The non-Qt part of the app - all the processing stuff - is the most important and should work as good as possible before! This also makes implementing a nice GUI very easy ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 17, 2017, 08:41:16 PM
@bouncyball originally this program was a single .c file(pre-gui), and mostly hard coded, so yeah, I originally did that just for simplicity ( I wasn't even reading mlv headers properly), but now it should be fine without that, I tried it recently, but I only tested briefly with 14 bit files, not 100% sure how AMaZE demosaic would react to a <1023 value range, as it already crushes the blacks a little too much (compare it with the bilinear some time), but most likely will be completely fine.

EDIT: Oh yeah, the black level correction relies on black level being in 14 bit world, maybe do something with pow? (for short code, efficiency doesn't matter there anyway)

And yeah, you can pull request as it seems to work without any changes to the GUI required. And I like it 8)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 18, 2017, 11:18:38 AM
Quote from: masc on September 17, 2017, 07:54:44 PM
What we also could do: adding a scrolling area (instead or inside the tabs) Adobe Lightroom-like.
I've been also thinking about it. Scrolling area instead of tab.

Quote from: Ilia3101 on September 17, 2017, 08:41:16 PM
I tried it recently, but I only tested briefly with 14 bit files, not 100% sure how AMaZE demosaic would react to a <1023 value range, as it already crushes the blacks a little too much (compare it with the bilinear some time), but most likely will be completely fine.
Unfortunatelly with 10/12 bits just deleting black level correction code not working, e.g. all debayered image is light gray. For 14 bits it's working as expected. That is why, as a workaround, I introduced 2 variables in llrawprocObject to back up black/white levels right before altering them in openMlvClip.

And... I made PR :D

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 18, 2017, 07:57:49 PM
Quote from: masc on September 17, 2017, 07:54:44 PM
Cool. Yes, I also would like to have the profiles in the process tab for now. But because of the tab bar it was one element to high to work at 1280x800 with dock. So I was thinking about a 3rd tab... What we also could do: adding a scrolling area (instead or inside the tabs) Adobe Lightroom-like.

+1

Quote from: masc on September 17, 2017, 07:54:44 PM
The GUI is often the nice part. But I think the GUI should be the last thing to do. The non-Qt part of the app - all the processing stuff - is the most important and should work as good as possible before! This also makes implementing a nice GUI very easy ;)

Agreed.

Quote from: bouncyball on September 18, 2017, 11:18:38 AM
And... I made PR :D

regards
bb

Thanks for this!  :)

Anyway here's my brief test run on MLV App v0.7 alpha. To be honest I was rather more anxious and tempted for BB's work to be implemented in the near future. Especially with mlv_dump on steroids. Just imagine being able to spit out Dual-ISO stuff directly from this app? Still this is all exciting stuff regardless.

So far it seems to work as advertised even though it's still in alpha stages. I noticed my Mac didn't like having FCPX running in the background while running this app. It does this random quick restart. No big deal since that's just me pushing the limits of my mid-2012 MBP 15" (OS X 10.12.6, 2.6 i7, 16GB Ram, 500GB + 1TB SSD w NVIDIA GeForce GT 650M 124 MB/ Intel HD Graphics 4000 1536 MB) which is not too shabby for ML stuff, right? Ha.

Anyway off to my findings:

1) I was pleased to see that it can open 12-bit lossless files with ease even FRSP Timelapse MLV's with the exception of spanning files. I noticed the app doesn't seem to pick up from the end of MLV to the next spanning files (.M00, .M01, .M02, etc) so therefore the footage just cuts in short from the original large MLV files w the spanning. Perhaps this was to be expected since it's still in alpha mode. Though it would be important to include this fix asap.  :P

2) I was also pleased with how the Audio files look when viewing the player from underneath. Makes it feel like a classic MLRawViewer from the future. Will have to test this more thoroughly in terms of length of the audio file matching the length of video file. Will get more into this later.

3) I was bummed to see that I couldn't copy and paste the preferred settings from one file to ALL files at once. Seems the app only allows you to copy and paste one file at a time. Maybe this is intended for now until we progress further. Would be nice to be able to paste the entire batch at once w ease.

4) I actually enjoy using the 100% viewer option (even during playback) which is handy for focus checking especially with 3.5-4K footage. Maybe in the future we can add 200%-400% zoom in as options?

5) Maybe this is to be expected but regardless of how nice it is to be able to batch export ProRes into an output folder since it is still spitting out png files (not that big of a deal but seems unnecessary) however it does delete them automatically once the ProRes is rendered. So not complaining about disk space in here but rather than work amount being involved? Is it required to do the png route in order to spit out ProRes? Hopefully once we get the AVFoundation installed within the app then we will be able to spit out 4444XQ especially with logs.

According to my eyes -- it seems when shooting clouds up in the sky and spitting out logs in 4444 comparing them to 4444XQ you will see more gradient pattern effects on the 4444 as oppose to smoother look of 4444XQ. Correct me on this @reddeercity if you can.

6) I also like how when you select ColorSpace to a certain Log (most of the sliders become disabled not allowing you to affect the footage as expected) w the exception to Exposure, Temp and Tint which is plus. Is this a safety feature intended for rookies? Bold decision.

More to come later. Will upload a quick screen recording of my findings when I can. Thanks to everyone on board in getting this revamped up!  8)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 18, 2017, 08:10:12 PM
@masc Sorry for ignoring the post above, yeah I think eventually we might have to add a scroll area once more capability is added to processing, such as highlight reconstruction. Although it would be sad to add it now, as it would only be a small annoying amount of scrolling. Do you think there's any chance of compressing the sliders and labels a little more? Or is Qt layout at it's limit.
Also the tint slider in Qt GUI still seems to go wrong(image is blue) when fully to the green side, could you copy the Cocoa app's mehtod for doing it?:
-(void)tintSliderMethod
{
    double tintSliderValue = [self doubleValue] - 0.5;
    /* Control should be more fine when its closer to zero... */
    double tintValue = tintSliderValue;
    if (tintValue < 0) tintValue = -tintValue;
    tintValue = pow(tintValue, 1.7) * 20.0;
    if (tintSliderValue < 0) tintValue = -tintValue;
    processingSetWhiteBalanceTint(App->processingSettings, tintValue);
    [App->tintValueLabel setStringValue: [NSString stringWithFormat:@"%6.3f", ([self doubleValue] - 0.5) * 2 ]];
}

I think it produces a good range and correct feel. (of course adapt for Qt's integer slider)
Also, important: can you add the "cHRM Chunk" to libpng files? From this documentation: http://www.libpng.org/pub/png/book/chapter10.html
Might begin filling it with values once actual gamut/space options are added(and hopefully ffmpeg won't ignore that info).

@bouncyball We begin the pull request process! whatever that means :D Will look on github
I will have a go at making bitdepth work in its native value range later, once pull request is merged.

@deafeyejedi Thanks for the testing and feedback!
Quote from: DeafEyeJedi on September 18, 2017, 07:57:49 PM
6) I also like how when you select ColorSpace to a certain Log (most of the sliders become disabled not allowing you to affect the footage as expected) w the exception to Exposure, Temp and Tint which is plus. Is this a safety feature intended for rookies? Bold decision.
I thought that might be better for accuracy of the profiles, although I haven't got colour spaces fully implemented so I can't talk too much ;)
It's about time to nag andy600 with questions if he has time to answer :)... does anyone know where to do that? (haven't managed to make it look right with camera specific matrices yet, but get most of the math now)
Also AVFoundation slowly coming along, will make it as a library so Qt App can implement it too, I hear ffmpeg has flaws in its prores encoding in terms of colour(according to reddeercity), or is limited in colour space, dunno, maybe what I asked masc about may help fix it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 18, 2017, 10:29:07 PM
Thank you DeafEyeJedi!

Quote from: DeafEyeJedi on September 18, 2017, 07:57:49 PM
I noticed my Mac didn't like having FCPX running in the background while running this app. It does this random quick restart.

What exactly do you mean with that? Does the App crash when working with FPCX?

Quote from: DeafEyeJedi on September 18, 2017, 07:57:49 PM
1) I noticed the app doesn't seem to pick up from the end of MLV to the next spanning files (.M00, .M01, .M02, etc)

Yes, this is still not implemented. We should do it soon.

Quote from: DeafEyeJedi on September 18, 2017, 07:57:49 PM
2)Will have to test this more thoroughly in terms of length of the audio file matching the length of video file.

That would be interesting, but I expect it will not fit after a longer playback time. But when stopping and restarting anywhere in the clip it should fit again.

Quote from: DeafEyeJedi on September 18, 2017, 07:57:49 PM
3) I was bummed to see that I couldn't copy and paste the preferred settings from one file to ALL files at once. Seems the app only allows you to copy and paste one file at a time. Maybe this is intended for now until we progress further. Would be nice to be able to paste the entire batch at once w ease.

That is a good idea. How would you do it? Selecting the files in the left and then paste?

Quote from: DeafEyeJedi on September 18, 2017, 07:57:49 PM
4) Maybe in the future we can add 200%-400% zoom in as options?

That should not be too complicated.

Quote from: DeafEyeJedi on September 18, 2017, 07:57:49 PM
5) Maybe this is to be expected but regardless of how nice it is to be able to batch export ProRes into an output folder since it is still spitting out png files (not that big of a deal but seems unnecessary) however it does delete them automatically once the ProRes is rendered. So not complaining about disk space in here but rather than work amount being involved? Is it required to do the png route in order to spit out ProRes?

Yes, it is necessary, because the mov is built from the pngs. After that the pngs are not needed anymore and are deleted. What I could do - making it like Ilia does in the cocoa app: making the pngs invisible.

Quote from: DeafEyeJedi on September 18, 2017, 07:57:49 PM
Hopefully once we get the AVFoundation installed within the app...

+1

Quote from: Ilia3101 on September 18, 2017, 08:10:12 PM
@masc Sorry for ignoring the post above, yeah I think eventually we might have to add a scroll area once more capability is added to processing, such as highlight reconstruction. Although it would be sad to add it now, as it would only be a small annoying amount of scrolling. Do you think there's any chance of compressing the sliders and labels a little more? Or is Qt layout at it's limit.

I tried to compress it a bit and I think it could work. Waiting for the pull request and then I'll add it.

Quote from: Ilia3101 on September 18, 2017, 08:10:12 PM
Also the tint slider in Qt GUI still seems to go wrong(image is blue) when fully to the green side, could you copy the Cocoa app's mehtod for doing it?

I'll look deeper into that. I also recognized that in the past.

Quote from: Ilia3101 on September 18, 2017, 08:10:12 PM
Also, important: can you add the "cHRM Chunk" to libpng files? From this documentation: http://www.libpng.org/pub/png/book/chapter10.html
Might begin filling it with values once actual gamut/space options are added(and hopefully ffmpeg won't ignore that info).

Yes, I wanted to do that. Thx for the reminder...

I now add all this points to the issue tracker that we don't forget that. At least for my head this is too much input  ;D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 20, 2017, 11:26:14 PM
Since imageio doesn´t exist anymore in the src-folder, these lines are no longer needed in MLVApp.pro, I guess.

Lines 92, 93
../../src/imageio/structs/imagestruct.h \
../../src/imageio/imageio.h \


Line 136
../../src/imageio/README.md \
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 21, 2017, 12:44:03 PM
Quote from: escho on September 20, 2017, 11:26:14 PM
Since imageio doesn´t exist anymore in the src-folder, these lines are no longer needed in MLVApp.pro, I guess.
Right. I changed it. Thank you!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 21, 2017, 04:16:46 PM
Hey!

@Ilia3101: I pushed the commit you asked - removed pointers to raw image buffer from the struct and passed as parameters of apply function. You are right, it's not only convenient, like this it's more elegant too :).

@masc: pushed commit with the fix of the issue we experienced. Now all is working ( hopefully ;) ). And thank you for implementing raw fixes GUI tab. Works great! Just one comment: default values in the source code and in the GUI (Correct tab) are not synced. Can you fix this?

defaults are:

Focus dots ON int 1
Bad pixels ON int 1
Chroma smooth OFF
Pattern noise OFF
Vertical stripes ON
Deflicker target 0


regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 21, 2017, 10:59:30 PM
Thanks bouncyball
I can begin implementing a multithreaded cache that works :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2017, 11:00:20 AM
@Ilia3101: Cool! :D
@masc: Loved your changes in "Correct" tab :)

I pushed commit which fixes my bug causing slowing down the playback by about 30-50% :P

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 22, 2017, 05:35:14 PM
Did some python removal and reinstalling and maybe something else but now I can´t compile "make app" anymore. clang complaining and some other stuff. Can you spot what I need here(mac)?:
Undefined symbols for architecture x86_64:
  "_applyLLRawProcObject", referenced from:
      _getMlvRawFrameFloat in video_mlv.o
  "_initLLRawProcObject", referenced from:
      _initMlvObjectWithClip in video_mlv.o
      _initMlvObject in video_mlv.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [build] Error 1
cp: MLV App: No such file or directory
cp: checkupdate.py: No such file or directory
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg 
dans-MBP:cocoa dan$ make clean
rm -rf "MLV App" "MLV App".app main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o *.o
dans-MBP:cocoa dan$

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 22, 2017, 06:08:49 PM
Weird... not sure why that would happen, doesn't seem like it's related to python. It seems to be a linking error...
As it appears bouncyball's new functions are not compiling for you, so when they are called in other code they can't be found.

I had a minor macOS update recently, which broke all apple developer tools including the clang compiler, way I fixed it then was just a quick re-run of xcode-select --install
Maybe all the python reinstallations messed some minor thing up in the folders where your apple tools are.

... speaking of bouncyball's new work, there's not yet access to it in the Cocoa GUI, so you can't really test it much unless you change llrawprocobject's defaults and recompile to see changes :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 22, 2017, 06:20:04 PM
Will dig further. Probably not realted to python at all as you mention.
Tested 0.7 from first post and realtime previewing. Dude, that´s amazing.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 22, 2017, 06:43:02 PM
Same here having issues with compiling after 'make app'. May be just because I am using a Mac Mini that's been sitting here for months and may not have proper set-up for it?

Last login: Fri Sep 22 09:29:52 on ttys000
Seans-Mac-mini-385:~ DeafEyeJedi$ git clone https://github.com/ilia3101/MLV-App.git
Cloning into 'MLV-App'...
remote: Counting objects: 2031, done.
remote: Total 2031 (delta 0), reused 0 (delta 0), pack-reused 2031
Receiving objects: 100% (2031/2031), 40.37 MiB | 345.00 KiB/s, done.
Resolving deltas: 100% (1395/1395), done.
Seans-Mac-mini-385:~ DeafEyeJedi$ cd MLV-App/platform/cocoa
Seans-Mac-mini-385:cocoa DeafEyeJedi$ make app
rm "MLV App".app; \
gcc  -mmacosx-version-min=10.10 -O3 -Ofast -m64 generate_info_plist.c -o generate_info_plist; \
./generate_info_plist "MLV App"; \
make main; \
rm -rf "MLV App".app; \
mkdir "MLV App".app; \
mkdir "MLV App".app/Contents; \
mkdir "MLV App".app/Contents/MacOS; \
mkdir "MLV App".app/Contents/Resources; \
cp -i "MLV App" "MLV App".app/Contents/MacOS/; \
cp -i info.plist "MLV App".app/Contents/; \
cp -i checkupdate.py "MLV App".app/Contents/Resources/; \
unzip ../qt/FFmpeg/ffmpegOSX.zip -d "MLV App".app/Contents/Resources; \
rm -rf "MLV App".app/Contents/Resources/__MACOSX; \
cp ../../src/icon/icon.icns "MLV App".app/Contents/Resources/MLV\ App.icns; \
rm generate_info_plist; \
rm info.plist; \

rm: MLV App.app: No such file or directory
ld: warning: object file (/var/folders/t9/v524s9d54pqd8920btl0zjch0000gn/T//ccnIPcw2.o) was built for newer OSX version (10.12) than being linked (10.10)
ld: warning: object file (/usr/local/Cellar/gcc/5.2.0/lib/gcc/5/gcc/x86_64-apple-darwin15.0.0/5.2.0/crtfastmath.o) was built for newer OSX version (10.11) than being linked (10.10)
gcc  -mmacosx-version-min=10.10 -O3 -Ofast -m64 compile_time_code.m -o compile_time_code -framework Cocoa; \
./compile_time_code; \
rm main.o; \
make build; \
rm compile_time_code; \
rm app_defines.h
In file included from /usr/include/Availability.h:184:0,
                 from /usr/local/Cellar/gcc/5.2.0/lib/gcc/5/gcc/x86_64-apple-darwin15.0.0/5.2.0/include-fixed/math.h:46,
                 from /System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:24,
                 from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:6,
                 from /System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:12,
                 from compile_time_code.m:5:
/System/Library/Frameworks/CoreFoundation.framework/Headers/CFDateFormatter.h:53:34: error: expected ',' or '}' before '__attribute__'
     kCFISO8601DateFormatWithYear API_AVAILABLE(macosx(10.12), ios(10.0), watchos(3.0), tvos(10.0)) = (1UL << 0),
                                  ^
/System/Library/Frameworks/CoreFoundation.framework/Headers/CFDateFormatter.h:80:126: error: 'introduced' undeclared here (not in a function)
CFDateFormatterRef CFDateFormatterCreateISO8601Formatter(CFAllocatorRef allocator, CFISO8601DateFormatOptions formatOptions) API_AVAILABLE(macosx(10.12), ios(10.0), watchos(3.0), tvos(10.0));
                                                                                                                              ^
/System/Library/Frameworks/CoreFoundation.framework/Headers/CFURL.h:777:39: error: 'deprecated' undeclared here (not in a function)
const CFStringRef kCFURLLabelColorKey API_DEPRECATED("Use NSURLLabelColorKey", macosx(10.6, 10.12), ios(4.0, 10.0), watchos(2.0, 3.0), tvos(9.0, 10.0));
                                       ^
/System/Library/Frameworks/CoreFoundation.framework/Headers/CFURL.h:777:39: error: 'message' undeclared here (not in a function)
const CFStringRef kCFURLLabelColorKey API_DEPRECATED("Use NSURLLabelColorKey", macosx(10.6, 10.12), ios(4.0, 10.0), watchos(2.0, 3.0), tvos(9.0, 10.0));


/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:95:166: error: expected ')' before 'NSString'
- (instancetype)initWithFetchRequest:(NSFetchRequest<ResultType> *)fetchRequest managedObjectContext: (NSManagedObjectContext *)context sectionNameKeyPath:(nullable NSString *)sectionNameKeyPath cacheName:(nullable NSString *)name;
                                                                                                                                                                      ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:95:207: error: unknown type name 'nullable'
- (instancetype)initWithFetchRequest:(NSFetchRequest<ResultType> *)fetchRequest managedObjectContext: (NSManagedObjectContext *)context sectionNameKeyPath:(nullable NSString *)sectionNameKeyPath cacheName:(nullable NSString *)name;
                                                                                                                                                                                                               ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:95:216: error: expected ')' before 'NSString'
- (instancetype)initWithFetchRequest:(NSFetchRequest<ResultType> *)fetchRequest managedObjectContext: (NSManagedObjectContext *)context sectionNameKeyPath:(nullable NSString *)sectionNameKeyPath cacheName:(nullable NSString *)name;
                                                                                                                                                                                                                        ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:110:1: error: cannot find protocol declaration for 'ResultType'
@property(readonly) NSFetchRequest<ResultType> *fetchRequest;
^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:118:20: error: unknown property attribute before ',' token
@property (nullable, readonly) NSString *sectionNameKeyPath;
                    ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:118:1: note: 'assign' can be unsafe for Objective-C objects; please state explicitly if you need it
@property (nullable, readonly) NSString *sectionNameKeyPath;
^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:122:20: error: unknown property attribute before ',' token
@property (nullable, readonly) NSString *cacheName;
                    ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:122:1: note: 'assign' can be unsafe for Objective-C objects; please state explicitly if you need it
@property (nullable, readonly) NSString *cacheName;
^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:126:19: error: unknown property attribute before ',' token
@property(nullable, nonatomic, assign) id< NSFetchedResultsControllerDelegate > delegate;
                   ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:126:1: note: 'assign' can be unsafe for Objective-C objects; please state explicitly if you need it
@property(nullable, nonatomic, assign) id< NSFetchedResultsControllerDelegate > delegate;
^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:131:30: error: unknown type name 'nullable'
+ (void)deleteCacheWithName:(nullable NSString *)name;
                              ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:131:39: error: expected ')' before 'NSString'
+ (void)deleteCacheWithName:(nullable NSString *)name;
                                       ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:140:21: error: unknown property attribute before ',' token
@property  (nullable, nonatomic, readonly) NSArray<ResultType> *fetchedObjects;
                     ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:140:21: error: cannot find protocol declaration for 'ResultType'
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:140:1: note: 'assign' can be unsafe for Objective-C objects; please state explicitly if you need it
@property  (nullable, nonatomic, readonly) NSArray<ResultType> *fetchedObjects;
^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:144:4: error: unknown type name 'ResultType'
- (ResultType)objectAtIndexPath:(NSIndexPath *)indexPath;
    ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:148:3: error: unknown type name 'nullable'
-(nullable NSIndexPath *)indexPathForObject:(ResultType)object;
   ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:148:12: error: expected ')' before 'NSIndexPath'
-(nullable NSIndexPath *)indexPathForObject:(ResultType)object;
            ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:148:46: error: unknown type name 'ResultType'
-(nullable NSIndexPath *)indexPathForObject:(ResultType)object;
                                              ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:161:4: error: unknown type name 'nullable'
- (nullable NSString *)sectionIndexTitleForSectionName:(NSString *)sectionName;
    ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:161:13: error: expected ')' before 'NSString'
- (nullable NSString *)sectionIndexTitleForSectionName:(NSString *)sectionName;
             ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:168:50: error: expected '>' before '*' token
@property (nonatomic, readonly) NSArray<NSString *> *sectionIndexTitles;
                                                  ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:168:50: error: cannot find protocol declaration for 'NSString'
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:177:20: error: unknown property attribute before ',' token
@property (nullable, nonatomic, readonly) NSArray<id<NSFetchedResultsSectionInfo>> *sections;
                    ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:177:53: error: expected '>' before '<' token
@property (nullable, nonatomic, readonly) NSArray<id<NSFetchedResultsSectionInfo>> *sections;
                                                     ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:177:53: error: cannot find protocol declaration for 'id'
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:195:19: error: unknown property attribute before ',' token
@property(nullable, nonatomic, readonly) NSString *indexTitle;
                   ^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:195:1: note: 'assign' can be unsafe for Objective-C objects; please state explicitly if you need it
@property(nullable, nonatomic, readonly) NSString *indexTitle;
^
/System/Library/Frameworks/CoreData.framework/Headers/NSFetchedResultsController.h:203:20: error: unknown property attribute before ',' token
@property (nullable, nonatomic, readonly) NSArray *objects;
                    ^
main.m:34:25: fatal error: app_defines.h: No such file or directory
compilation terminated.
make[2]: *** [main.o] Error 1
rm: compile_time_code: No such file or directory
rm: app_defines.h: No such file or directory
make[1]: *** [main] Error 1
cp: MLV App: No such file or directory
cp: checkupdate.py: No such file or directory
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg 
Seans-Mac-mini-385:cocoa DeafEyeJedi$


(https://farm5.staticflickr.com/4379/37247218511_1dbb3ede22.jpg) (https://flic.kr/p/YKpJoB)

Will give this another try on the MBP and report back. Also how would we know when BB's work has been implemented (other than relying on this thread) before we try compiling again?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2017, 07:09:16 PM
@Ilia3101: You mentioned that your 5D2 sometimes suffers from bad vertical stripes. Can you upload sample MLV with clearly pronounced vertical stripes? I need it for some testing.

@Danne, @DeafEyeJedi
Meanwhile, for testing you can try to compile QT version for Mac. QT version has all raw fix features implemented in the GUI (thanks to @masc).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 22, 2017, 07:22:46 PM
@Ilia & bouncyball: what would you think about releasing a 0.8? There are many new features and the Windows version also works again (some commits before I tested, hope it works with the latest too).
@DeafEyeJedi: I also implemented some of your ideas: 200%&400% zoom and batch paste.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2017, 07:28:29 PM
Sure 0.8 would be great. What do you think Ilia3101?

@masc: Would be so nice if playback controls had additional 2 buttons next frame and previous frame. What do you think?

Edit: I really dig 200/400 zoom! used it for pixel peeping a lot when testing code :)
Edit2: can you also implement mouse scroll wheel to zoom 100-400?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 22, 2017, 07:29:48 PM
QuoteMeanwhile, for testing you can try to compile QT version for Mac.
Link please. What source exactly are you referring to?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2017, 07:36:53 PM
@Danne: masc actually develops QT vesion on MAC. I think he can answer all your questions.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 22, 2017, 07:42:04 PM
Quote from: bouncyball on September 22, 2017, 07:28:29 PM
@masc: Would be so nice if playback controls had additional 2 buttons next frame and previous frame. What do you think?
No problem.

Quote from: bouncyball on September 22, 2017, 07:28:29 PM
Edit2: can you also implement mouse scroll wheel to zoom 100-400?
This will not work, because we already have 2D scrolling for the position in the frame. I am not sure, if it could work with scrolling while holding down a button for example (never tried that).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 22, 2017, 07:45:15 PM
How about implmenting Command + I (Info) to be able to quickly see MLV information promptly without having to manualy scroll our mouse over every time?

Quote from: masc on September 22, 2017, 07:22:46 PM
@DeafEyeJedi: I also implemented some of your ideas: 200%&400% zoom and batch paste.

Thanks. Will check it out once I get past the compiling issues.

Quote from: bouncyball on September 22, 2017, 07:28:29 PM
Sure 0.8 would be great. What do you think Ilia3101?

@masc: Would be so nice if playback controls had additional 2 buttons next frame and previous frame. What do you think?

+1

Quote
Edit: I really dig 200/400 zoom! used it for pixel peeping a lot when testing code :)
Edit2: can you also implement mouse scroll wheel to zoom 100-400?

Clever idea with the mouse scroll wheel zoom function. Hopefully this is plausible while in playback mode.  :P Bummer.

Quote from: Danne on September 22, 2017, 07:29:48 PM
Link please. What source exactly are you referring to?

Please let us know when you can @masc
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 22, 2017, 07:56:07 PM
Quote from: bouncyball on September 22, 2017, 07:28:29 PM
@masc: Would be so nice if playback controls had additional 2 buttons next frame and previous frame. What do you think?
Implemented and working.

Quote from: DeafEyeJedi on September 22, 2017, 07:45:15 PM
How about implmenting Command + I (Info) to be able to quickly see MLV information promptly without having to manualy scroll our mouse over every time?
You can press Command+Shift+I.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 22, 2017, 08:18:58 PM
Hmmm.. weird that it's broken, although it seems you guys might be having different issues... not sure what do to.
Qt version has bb's work implemented in the GUI I think, so you can test if you can compile that, which requires installing Qt creator, and you can follow the 'Linux tutorial' linked in the first post, should be the same on all platforms.

@bouncyball Will find one and upload!

And good idea to release 0.8, as it seems to be quite in demand right now :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 22, 2017, 08:37:09 PM
Ok, I'll try to compile and upload the 0.8 tomorrow.
Edit: found some time, so OSX version is there. @bouncyball: could you please build the windows versions? If not I can do that sunday.
Sources (as always): https://github.com/ilia3101/MLV-App (https://github.com/ilia3101/MLV-App)
Release: https://github.com/ilia3101/MLV-App/releases/tag/QTv0.8alpha (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.8alpha)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 22, 2017, 09:01:55 PM
Next, previous frame buttons are great.

Is it possible to display the frame number, which ist actually shown, maybe in the field of Caching - Playback? That would make a later cutting easier (Implementing some kind of cut-in - cut-out function would be fine too  8) ).

The new correct tab looks great now.

What is the difference between Method 1 and 2 in bad - focus pixel fix?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2017, 09:59:29 PM
@masc

Quote from: masc on September 22, 2017, 07:42:04 PM
This will not work, because we already have 2D scrolling for the position in the frame. I am not sure, if it could work with scrolling while holding down a button for example (never tried that).
Really? Did not notice this as I'm just dragging zoomed screen by left mouse click and this is very convenient. Could we disable scrolling and use scroll wheel for zooming?

[/quote]
Quote from: masc on September 22, 2017, 08:37:09 PM
@bouncyball: could you please build the windows versions? If not I can do that sunday.
Sure I'll do it tomorrow.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2017, 10:02:18 PM
@Ilia3101

Quote from: Ilia3101 on September 22, 2017, 08:18:58 PM
@bouncyball Will find one and upload!
Thank you would be very nice :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2017, 10:22:45 PM
@escho

Quote from: escho on September 22, 2017, 09:01:55 PM
What is the difference between Method 1 and 2 in bad - focus pixel fix?
Both averaging neighbor pixels but do it differently. Some footage looks good with 1 other with 2, try it yourself. Method 1 is used in MLVFS, method 2 is used in mlv_dump (raw2dng code) so your mileage may vary. Also when using it with chroma smooth at the same time results could be different, even ugly in some combination ;)

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 22, 2017, 10:26:31 PM
here's something: https://drive.google.com/file/d/0BwvDlbhZgsGGT0xFUl9ERFFialk/view?usp=sharing
Couldn't find any particularly strong examples just now, but this uninspiring clip has some stripes, I don't know if they're string enough for your testing purposes ::)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 23, 2017, 12:08:19 AM
Quote from: escho on September 22, 2017, 09:01:55 PM
Is it possible to display the frame number, which ist actually shown, maybe in the field of Caching - Playback?

Done in my last commit. The cut-in and cut-out is a good idea, maybe I'll do that in the future, too. Thx.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 23, 2017, 09:27:08 AM
Win x86 32bit version uploaded.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 23, 2017, 09:46:09 AM
Quote from: Ilia3101 on September 22, 2017, 10:26:31 PM
I don't know if they're string enough for your testing purposes ::)
They are "OK" on the blue sky :D thank you.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 23, 2017, 09:50:51 AM
@masc

I was testing the scrolling of zoomed image by scroll wheel.

Well, scrolling vertically when you can just drag it in any direction IMHO useless. So if QT mouse input handling will let us free the scroll wheel for other purpose (zooming) would be very cool :)

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on September 23, 2017, 11:01:45 AM
new version of win works great. love those new features...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 23, 2017, 11:31:54 AM
Quote from: bouncyball on September 23, 2017, 09:50:51 AM
@masc

I was testing the scrolling of zoomed image by scroll wheel.

Well, scrolling vertically when you can just drag it in any direction IMHO useless. So if QT mouse input handling will let us free the scroll wheel for other purpose (zooming) would be very cool :)

regards
bb

I always loved it using the trackpad. Have you tested also scrolling+cmd or strg? This could be the 2nd dimension for mouse users, I don't know. But I can have a look if I can disable that. On the other side I think I have to reimplement the whole zooming, because 3 zoom steps with scrolling makes no sense. I think we need a kind of "step-less" zoom then.

Thanks for the upload!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 23, 2017, 12:11:16 PM
Quote from: masc on September 23, 2017, 11:31:54 AM
I always loved it using the trackpad.
Hehe :) I didn't think about it. I'm using desktop PC at work most of the time.

Quote from: masc on September 23, 2017, 11:31:54 AM
On the other side I think I have to reimplement the whole zooming, because 3 zoom steps with scrolling makes no sense. I think we need a kind of "step-less" zoom then.
+1 if that's not very hard to do.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 23, 2017, 02:12:52 PM
The most difficult should be to forbit a scrollarea the scrolling via mouse ;) So I have to overwrite some Qt classes, and atm I don't know how. But I'll do some research...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 23, 2017, 05:39:20 PM
@bouncyball: do you like to test? I think I got it ... after some hours of wondering what Qt can (or can't) do... :o
The behaviour is now:
- "Zoom: fit" can be checked and unchecked. If it is checked, it fits, if not, you are leaded to 100% and can zoom from there as you like
- "Zoom: 100%" returns always to 100%. If it is clicked while "fit" was active, "fit" will be unchecked.
Is that okay? Sometimes I had problems when zooming the very first time: it did not recognize where the curser was and jumped to the upper left corner. But that happend not often. Does it happen for you?
Edit: now I know why it happens, but I don't know how to fix it  ;D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 23, 2017, 07:48:28 PM
@bouncyball

ThankYou for the answer. I will look at the code later to fully understand the difference.

@masc

Display of the frame number works great. ThankYou!

@all

Crash in importing (QTApp on linux). No pngs are created. App crashes.
The crash comes in with commit 82a3a5e (Fixed the very broken sharpening filter). Previous commit works without problem. I tried to import my moon-test-video, containing 21 frames.
Here ist the debug-output of qt-creator:
https://seescho.files.wordpress.com/2017/08/auswahl_004.jpg
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on September 23, 2017, 07:56:08 PM
@BB
after doing some test i found that i can import only 9 clips at once. if i try to import more than 9 mlv files the app crash
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 23, 2017, 07:56:36 PM
Quote from: escho on September 23, 2017, 07:48:28 PM
Crash in importing (QTApp on linux). No pngs are created. App crashes.
The crash comes in with commit 82a3a5e (Fixed the very broken sharpening filter). Previous commit works without problem. I tried to import my moon-test-video, containing 21 frames.
Here ist the debug-output of qt-creator:
https://seescho.files.wordpress.com/2017/08/auswahl_004.jpg
Jopp, same on OSX. Take the old raw_processing.c (before this commit) and it should work (at least for me it does).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 23, 2017, 07:58:34 PM
Quote from: andy kh on September 23, 2017, 07:56:08 PM
@BB
after doing some test i found that i can import only 9 clips at once. if i try to import more than 9 mlv files the app crash

Some more information please. Which version, which OS,... I can import as many clips I want on OSX and MLVAPP [Qt] v0.8 or latest revision.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on September 23, 2017, 08:03:51 PM
Quote from: masc on September 23, 2017, 07:58:34 PM
Some more information please. Which version, which OS,... I can import as many clips I want on OSX and MLVAPP [Qt] v0.8 or latest revision.

windows v0.8

edit: i can import more than 9 clips. i have 10 clips in a folder. i select all and tried to import but the app crash. if i select only those 9 clips it doesnt crash. now i tried importing one by one and found that the problem is with the last mlv file in my folder. whenver i tried importing that file, this app keep crashing
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 23, 2017, 08:10:18 PM
Quote from: masc on September 23, 2017, 07:56:36 PM
Jopp, same on OSX. Take the old raw_processing.c (before this commit) and it should work (at least for me it does).
Yes, run with the old one on latest commit.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 24, 2017, 10:05:06 AM
Quote from: escho on September 23, 2017, 07:48:28 PM

Crash in importing (QTApp on linux). No pngs are created. App crashes.
The crash comes in with commit 82a3a5e (Fixed the very broken sharpening filter). Previous commit works without problem. I tried to import my moon-test-video, containing 21 frames.
Here ist the debug-output of qt-creator:
https://seescho.files.wordpress.com/2017/08/auswahl_004.jpg

The crash is fixed with commit c25b987. ThankYou!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 10:43:25 AM
Hey Guys I found so many cool commits today! Hahaha! :)

@ilia3101:
Sharpening is fantastic! is that algo "unsharp musk"? Works very intelligently for my taste. Slows playback for ~50% but is worth it :). Now we're just missing good denoiser :P

@masc:
Zoom also fantastic! Works smoothly and I did not experienced the behavior you mentioned yet.
I've got one proposition though: the right click menu is very good for switching zoom and zebras, but it would be very nice to switch between zoom and fit also with just a left click of a mouse or maybe better double click. What do you think?

Edit: Surely double click. My bad, just a left click is busy with drag mode.

br
bb

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 24, 2017, 10:53:42 AM
I'm glad the commit fixed crashing! To be honest I never pinned down the bug, just rewrote the bit that crashed.

@bouncyball Yep, it is something like unsharp mask with a really small radius. Even simpler though... Goes something like: multiply main pixel by something, and reduce it back to normal by slightly subtracting some of the ones around it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 10:59:32 AM
@Ilia3101: Well... I really like it very much :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 02:39:03 PM
Quote from: bouncyball on September 24, 2017, 10:43:25 AM
@masc:
I've got one proposition though: the right click menu is very good for switching zoom and zebras, but it would be very nice to switch between zoom and fit also with just a left click of a mouse or maybe better double click. What do you think?

Edit: Surely double click. My bad, just a left click is busy with drag mode.
Both makes problems with Touchpad, because DoubleClick is used by tapping to select the drag mode and Click is used normaly to drag.
What I can offer... and I already pushed the commit because it was easy... I added the shortcut "F" (Fit) to toggle between Fit and Scaling mode. Hope it is cool enough  ;D
And by using F you will never see this bug.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 05:54:16 PM
Great! "F" is perfect :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 06:07:43 PM
Windows x64 version (https://github.com/ilia3101/MLV-App/releases/download/QTv0.8alpha/MLV.App.v0.8.alpha.x64.Win.static.zip) uploaded to github ( release v0.8 )

Windows x86:
    includes all dynamic QT libraries

Windows x64:
    this mlvapp.exe release is one static binary
    focus pixel maps are included (EOSM, 700D, 100D)

both Windows releases include ffmpeg.exe
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 06:13:00 PM
@bouncyball: thanks for building the versions! How do you include the focus pixel maps? Is this only in this version? Can we add that also for the other versions?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 06:20:09 PM
Sure we can :) my bad I forgot to include it to the x86 version. Focus maps should be in the same dir with binary. You can quickly generate them with my utility called fpmutil (https://bitbucket.org/bouncyball/mlv-tools/downloads/).

BTW this windows static binary (just one mlvapp.exe) I compiled under Linux :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 06:31:35 PM
Just generate and copy to the directory works? On OSX too?  Can we add the generated files to the repos?

Edit: on OSX that does not work... :(

Do you have Qt in Wine?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 06:40:21 PM
What do you mean it does not work? Of course it will work anywhere. Binary searches maps in the same dir it resides. Just copy maps from x64 release zip to the dir in your MAC with mlv app.

Edit: Do you have MLV from focus dot affected cameras?
Edit2: on the bottom of this post (http://www.magiclantern.fm/forum/index.php?topic=20025.msg190039#msg190039) there is a link with sample MLVs
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 06:44:02 PM
Yes, that was what I did. I tried inside the package and outside the package...
I have a file from a 100D with lots of focus pixels.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 06:45:32 PM
Hmm... very strange. It works on Linux and on Windows. What is wrong with mac? :)

I don't use wine, I have dual boot on my PC - Linux Ubuntu / Windows 10
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 06:54:37 PM
Just a hint - take a look at the DMG structure of the Mac version of MLVFS, it can use exact same maps.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 07:34:04 PM
I tested it on Windows. My 100D file has focus pixels, I can remove them. But on Windows it only works if I open MLV App itself. If I call it though QtCreator it does not work. Is it possible to set the directory anywhere in the code (or at least printf the path)? I am doing the same as MLVFS (I think... - I found them...).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 07:49:41 PM
Quote from: masc on September 24, 2017, 07:34:04 PM
Is it possible to set the directory anywhere in the code (or at least printf the path)?
Path not changeable at the moment. What the console output says on mac when "Using focus pixel map: 'path/id_xres_yres.fpm' " is displayed?

Edit: fopen is done with file name without the path hence the dir always currentt dir.
Edit2: does ffmped calling work though QtCreator run?
Edit3: MLVFS also searches all its additional files in the current dir, so you absolutly need to cd to the MLVFS folder
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 08:03:00 PM
Quote from: bouncyball on September 24, 2017, 07:49:41 PM
Path not changeable at the moment. What the console output says on mac when "Using focus pixel map: 'path/id_xres_yres.fpm' " is displayed?

Edit: fopen is done with file name without the path hence the dir always currentt dir.
Edit2: does ffmped calling work though QtCreator run?

ffmpeg runs also through QtCreator. In exactly the same folder I copied the fpm files. In the console there is nothing with focus pixels... all the other corrections write an output... strange...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 08:06:02 PM
Quote from: masc on September 24, 2017, 08:03:00 PM
In the console there is nothing with focus pixels...
This means the maps are not found. I need to look at how you are calling ffmpeg. Specifying the dir can be implemented anyway.

Edit: In debugger you can watch the fpm_status variable. If it stays 0 or equals to 2 maps are not found.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 08:08:51 PM
WAIT! If I have the files next to the ffmpeg and start MLV App through QtCreator it works! Starting MLV App by doubleclicking it does not work. (Exactly the opposit from Windows)
Edit: it would be interesting to see where the app is searching.
Edit2: QDir::currentPath() and QCoreApplication::applicationDirPath(), both bring the folder where the fpm files are. :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2017, 08:57:27 PM
This opposite behavior on osx and win is very strange.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 24, 2017, 10:58:27 PM
Doubleclicking the App on OSX sets "/" as working directory for the C code part. :(
For the Qt part, the working dir is the path of the executable inside the app package.
If I copy the files in "/" it works.
@bouncyball: Any suggestion? Is it possible to implement a bypass to set the directory in the correction module?

Edit: I did a call in the Qt part:
chdir( QCoreApplication::applicationDirPath().toLatin1().data() );
First test on OSX: works! :-)
Edit: Second test on Windows: works too! ;D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 24, 2017, 11:25:31 PM
Haven't followed the discussion much so not 100% sure whats going on :(
Does the app need to contain focus pixel maps or something for the llrawprocobject to remove focus pixels?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 25, 2017, 08:53:08 AM
Quote from: Ilia3101 on September 24, 2017, 11:25:31 PM
Haven't followed the discussion much so not 100% sure whats going on :(
Does the app need to contain focus pixel maps or something for the llrawprocobject to remove focus pixels?
Yes. And they must be located in the working dir. Maybe you have to set the working dir in the C code (at least in Qt I had to do that, otherwise it was at "/"). But you could do that from the cocoa classes using chdir().
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 09:16:35 AM
Quote from: masc on September 24, 2017, 10:58:27 PM
@bouncyball: Any suggestion? Is it possible to implement a bypass to set the directory in the correction module?
If you think this is the more correct approach we can pass the map directory as a parameter.

I got another idea. I'm gonna implement the on the fly pixel map generation code right into mlvapp, but there'll be possibility to override this behavior by manually placing the map to the working dir as now. What do you think about placing as few files in working DIR as possible without sacrificing functionality? ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 25, 2017, 09:20:54 AM
fpmutil code pure joy(fpm.sh on steroids ;)).
http://www.magiclantern.fm/forum/index.php?topic=15108.msg187641#msg187641
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 09:22:36 AM
Yes it's very fast, faster then searching bad pixels.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 09:29:53 AM
@Ilia3101, @masc

I had a linking problem caused by "MLV App" space in the middle of TARGET name.
Can we rename the app binary to "MLVApp" of maybe just to plain "mlvapp"?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 25, 2017, 09:31:55 AM
Quote from: bouncyball on September 25, 2017, 09:16:35 AM
If you think this is the more correct approach we can pass the map directory as a parameter.
Yes! Yes! Yes!
I was just looking at the code, seeing how I could do that.
As the Cocoa API allows getting the path to the app bundle's resources directory, where they would be stored.
(It would be perfect!)

Seems like a directory path argument would need to be added to load_pixel_map (of course do it how you feel is right):
static int load_pixel_map(pixel_map * map, char * path, uint32_t camera_id, int raw_width, int raw_height, int dual_iso)
And have a parameter for it inside of llrawprocobject which it will pass to that(Is that how it works?)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 25, 2017, 09:34:07 AM
Quote from: bouncyball on September 25, 2017, 09:29:53 AM
I had a linking problem caused by "MLV App" space in the middle of TARGET name.
Can we rename the app binary to "MLVApp" of maybe just to plain "mlvapp"?
Yea sure, why not rename the binary. On macOS this wouldn't even matter as the app bundle and binary can have any names at all.
Or maybe just rename it on Linux if that's the only place where it's causing problems?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 25, 2017, 10:56:14 AM
Quote from: bouncyball on September 25, 2017, 09:29:53 AM
@Ilia3101, @masc
I had a linking problem caused by "MLV App" space in the middle of TARGET name.
Can we rename the app binary to "MLVApp" of maybe just to plain "mlvapp"?

We can rename it. Where do you have that problem? On Linux? On Win & OSX I never had a problem with that. Maybe change the .pro to that:

win32: TARGET = "MLV App"
linux-g++*: TARGET = "MLVApp"
osx: TARGET = "MLV App"
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 11:58:58 AM
This was the error:

/usr/bin/x86_64-w64-mingw32.static-ld: cannot find ./release/mlv
/usr/bin/x86_64-w64-mingw32.static-ld: cannot find app_plugin_import.o

"mlv app_plugin_import.o" divided to "mlv" and remainder.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 12:02:54 PM
I thought about adding parameter "path" to related functions and can admit that this complicates things quite a bit and makes ugly, can we just use some global variable with working dir set?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 12:07:39 PM
This:

win32: TARGET = "MLVApp"
linux-g++*: TARGET = "mlvapp"
osx: TARGET = "MLV App"

did the trick.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 25, 2017, 03:45:47 PM
Linux compile howto & 64bit build

sudo apt-get install libpng16-dev qtmultimedia5-dev qt5-qmake qtbase5-dev

ubuntu 16.04 with kubuntu backports ppa activated, so qt 5.6.1


I had to change line 22 of MainWindow.cpp to

#include <libpng16/png.h>

and line 55 of MLVApp.pro to
linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng16

then the ususal
qt5-qmake MLVApp.pro
make

MLVApp + static FFMpeg, 64bit (http://openartisthq.org/magiclantern/mlvapp.tar.xz)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 04:06:58 PM
Thank you, but it's gonna make more sense if you make the binary static.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 25, 2017, 04:11:24 PM
To not change MainWindow.cpp (OSX and Win port would be broken) you also could change line 56 in the .pro to:
linux-g++*: INCLUDEPATH += /usr/local/include/libpng16/
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 25, 2017, 05:05:19 PM

QuoteThank you, but it's gonna make more sense if you make the binary static.

show me how.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 25, 2017, 06:06:34 PM
Quote from: revast on September 25, 2017, 03:45:47 PM
Linux compile howto & 64bit build

sudo apt-get install libpng16-dev qtmultimedia5-dev qt5-qmake qtbase5-dev

ubuntu 16.04 with kubuntu backports ppa activated, so qt 5.6.1


I had to change line 22 of MainWindow.cpp to

#include <libpng16/png.h>

and line 55 of MLVApp.pro to
linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng16

then the ususal
qt5-qmake MLVApp.pro
make

MLVApp + static FFMpeg, 64bit (http://openartisthq.org/magiclantern/mlvapp.tar.xz)

On my system ( Linux opensuse leap ) I don´t have to change MainWindow.cpp and MLVApp.pro to get MLV App compiled. Just the syntax is a bit different:

qmake-qt5
make


I need no static ffmpeg. I use the ffmpeg, installed with Yast. MLV App find the ffmpeg-bin via the PATH-envirement-variabe of my system.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 25, 2017, 06:09:20 PM
Quote from: Ilia3101 on September 25, 2017, 09:31:55 AM
Yes! Yes! Yes!
I was just looking at the code, seeing how I could do that.
As the Cocoa API allows getting the path to the app bundle's resources directory, where they would be stored.
(It would be perfect!)

But would it be a problem to copy it to the resources directory and setting chdir to it? So (nearly) nothing has to be changed.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 25, 2017, 07:15:18 PM
Quote from: masc on September 25, 2017, 06:09:20 PM
But would it be a problem to copy it to the resources directory and setting chdir to it? So (nearly) nothing has to be changed.
I guess I could easily do that and it's completely fine.
But it's app-global, so if ever another library gets introduced to the app that also happens to depend on being in a certain directory(which of course shouldn't happen), it will become an issue.
Maybe I'm being paranoid, but isn't it good practice to keep as much local as possible?

I'll do that for now anyway as it seems like it won't break anything :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 25, 2017, 07:32:23 PM
Quote from: bouncyball on September 25, 2017, 12:07:39 PM
This:

win32: TARGET = "MLVApp"
linux-g++*: TARGET = "mlvapp"
osx: TARGET = "MLV App"

did the trick.

Is it necessary to have three different targets for the three OS? Why not one Target MLVApp for all?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 07:34:43 PM
@revast
Quote from: revast on September 25, 2017, 05:05:19 PM
show me how.
Good question ;) (I hoped you know how to do it without me)

Well... In the best case you have to compile all QT libs as static and link all s**t together including zlib, libpng16 and pthread. I'm doing this with Mingw64 (under linux) to compile static windows binary. But I never did that with GCC. That is why we never released binary for Linux version of the MLV App.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 07:40:35 PM
@escho
Quote from: escho on September 25, 2017, 07:32:23 PM
Is it necessary to have three different targets for the three OS? Why not one Target MLVApp for all?
Yeah... right.

Quite funny but, I changed win32 TARGET because I had a linking problem, changed linux TARGET because I'm tired of typing upper-lower case binary name :P and leaved unchanged macx TARGET with respect to Author.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 25, 2017, 07:50:17 PM
Hey @masc I have an issue with QT designer. To the focus pixel combo box I added additional 3rd item, but this item, strangely, never shows up in compiled version despite the fact that the related part of MainWindow.ui looks like this:

<widget class="QComboBox" name="comboBoxFocusPixelSwitch">
               <property name="maximumSize">
                <size>
                 <width>90</width>
                 <height>16777215</height>
                </size>
               </property>
               <property name="font">
                <font>
                 <pointsize>10</pointsize>
                </font>
               </property>
               <item>
                <property name="text">
                 <string>Off</string>
                </property>
               </item>
               <item>
                <property name="text">
                 <string>On</string>
                </property>
               </item>
               <item>
                <property name="text">
                 <string>Croprec</string>
                </property>
               </item>
              </widget>

Can you enlighten me what am I doing wrong?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 25, 2017, 09:52:12 PM
@bouncyball: whooaaa... sry, I never work with the ui code. I just paint the GUI in the QtCreator-Designer-Plugin and I am happy when it does what I want. So you want a third switch: Off, On, CropRec? Where is the difference between On and CropRec? CropRec is =2 in your lib and works with the same functions? I can do it for you...

Edit: Done.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 26, 2017, 09:12:42 AM
@masc:

I did it exactly from designer plugin. Now I pulled your changes and the item is not showing again hahaha :). Some black magic I guess. Then I deleted all and cloned the fresh repository. Compiled and Croprec is there ;). Well I guess when I'm doing qmake from Mingw64 it creates a lot of files in addition to Makefile and maybe somewhere it caches the ui.

Anyway thank you for helping! I'm gonna push my changes as soon as they are stable :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 26, 2017, 12:46:39 PM
I have now made an AppImage (http://openartist.org/magiclantern/MLVApp-x86_64.AppImage).
Just download, make executeable, launch.

Turned out to be quite easy, thanks to linuxdeployqt (https://github.com/probonopd/linuxdeployqt/releases/download/continuous/linuxdeployqt-continuous-x86_64.AppImage)
./linuxdeployqt  m/MLVApp -appimage -bundle-non-qt-libs -verbose=2
where in folder m is the a MLVApp.png, a static FFMpeg executeable, the MLVApp executeable,  as well as a MLVApp.desktop file with 

[Desktop Entry]
Type=Application
Name=MLVApp
Exec=MLVApp
Icon=MLVApp


To see how it looks like inside, use: ./MLVApp-x86_64.AppImage --appimage-extract

What it actually does is to grab all libs which are needed to run the executeable, and deploys that in a compressed package which is built like an ISO file - you can even mount it - which is also executeable via fuse.
The wiki (https://github.com/AppImage/AppImageKit/wiki) has more info, the one thing that has to be considered for a release package is that the older the platform where the appimage was made, the better in terms of compatibility to different linux distributions.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 26, 2017, 01:01:41 PM
@revast

Very cool it's like make portable application under win. Runs fast!
Just one note: it's almost 2 times bigger (~43mb) then it would be as statically linked binary (~24mb).
But anyway I think in this form it could be released as Linux version.

Thank you for your time :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 26, 2017, 02:47:03 PM
QuoteJust one note: it's almost 2 times bigger (~43mb) then it would be as statically linked binary (~24mb).
Thats because its bundled with ffmpeg static binary, which is about 14mb with upx compression applied, without it, the AppImage would have around 30mb.

QuoteBut anyway I think in this form it could be released as Linux version.

Yeah, I think so, too :). Using an older base system (like ubuntu 12.04, depends on the minimum qt5 version I guess) to compile MLVApp and make the AppImage would be better though.

I now uploaded another version which should respect the theming of the Linux Distribution the AppImage is run on
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 26, 2017, 06:58:36 PM
Quote from: revast on September 26, 2017, 12:46:39 PM
I have now made an AppImage (http://openartist.org/magiclantern/MLVApp-x86_64.AppImage).
Just download, make executeable, launch.

Turned out to be quite easy, thanks to linuxdeployqt (https://github.com/probonopd/linuxdeployqt/releases/download/continuous/linuxdeployqt-continuous-x86_64.AppImage)
Very cool! That is exactly the same way I go on OSX, here it's called macdeployqt. Can you please build this this version (https://github.com/ilia3101/MLV-App/commit/56c8511739d3e5dda1fc01d2d2e0e9c2a7bb31ea)? Then I could add it to the latest release page.

In the latest commit I added some lines to the .pro, now you can (manually) switch between ubuntu and opensuse.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 26, 2017, 08:31:49 PM

Can you please build this this version? Then I could add it to the latest release page
ok, done :). But bear in mind: the older the libc version is the more compatible the package. The appimage creator uses centos 6 for example...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 26, 2017, 10:36:18 PM
Yes, that's the same on OSX. I always build it on 10.9.5.
The link is the same as above? I'll load it on github. Thank you!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 26, 2017, 11:46:54 PM
Tried out Linux build, on a Qt-virgin Ubuntu system, got this error:

(http://image.ibb.co/kgzOR5/Screenshot_from_2017_09_26_22_42_23.png)

Does all of Qt need to be installed? Or could it be packaged with the downlad?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 27, 2017, 12:39:22 AM
hmmm all dependencies should be bundled in the one file, yes.
Sorry, I haven't tried it out on vanilla ubuntu till now. I am downloading a xubuntu 17.10 daily image and try for myself

all I can say right now is that that library definitely is inside the .AppImage, I checked that.

try this (http://openartist.org/magiclantern/MLVApp-x86_64.AppImage) version

if that does not help,  sudo apt-get install libqt5multimedia5 for now..
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 27, 2017, 07:10:36 AM
If linuxdeploayqt does the same as macdeployqt I think I know what you did and how you could solve that. If you do that it won't work:
compile, linuxdeployqt, compile, (linuxdeployqt, ) upload
because the compiling breaks the dependencies.

If you do:
delete binary/package, compile, linuxdeployqt, upload
there should be no problem.

This was the problem I had in the very beginning here.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 27, 2017, 07:40:31 AM
I figured it out, looks like linuxdeployqt did not set the paths right,
there is a line:

prefix=./

in qt.conf, which should point to the prefix dir (usr..) of the appimage. But that does not work, even if my lib folder is in APPimageDIR/usr/

Nevertheless, that is easily fixed with a little script which replaces the default AppRun symlink :

#! /bin/bash
export APPDIR="$(dirname "$(readlink -f "$0")")"  #get the path inside the appimage
export LD_LIBRARY_PATH=lib:LD_LIBRARY_PATH #set libray path
export QT_PLUGIN_PATH=plugins:QT_PLUGIN_PATH #setting this explicitly as well, just for safety
export QT_QPA_PLATFORMTHEME="fusion"  #set theme path (does not work so far)

cd $APPDIR
./MLVApp -style=fusion
   

As you can see, the fix I had in mind regarding the theme issues did not work out so well so far.
I explicitly set the style to the built-in fusion style for now, via the -style=fusion argument and will figure out the theme details later.

At least the appimage  (http://openartisthq.org/magiclantern/MLVApp-x86_64.AppImage) works now..
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 27, 2017, 12:04:18 PM
Maybe you don't need the theme fix in the latest revision. Yesterday I added a theme switch. Now you can select a darksytle - this one has Fusion as base. I'll exchange the package this afternoon.

Edit: Done.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 27, 2017, 07:09:01 PM
i like the darkstyle, but the playback buttons are a bit difficult to recognize.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 27, 2017, 07:21:05 PM
Quote from: escho on September 27, 2017, 07:09:01 PM
i like the darkstyle, but the playback buttons are a bit difficult to recognize.
+1 :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 27, 2017, 07:27:21 PM
Hey guys!

Some changes to the raw correction part:

Now focus pixel maps not needed in the working directory any more. MLV App will generate maps according to MLV metadata on the fly, including crop_rec mode MLVs (EOSM, 100D, 700D, 650D). If .fpm map intentionally placed to the working directory it will be used instead of internal generator (overriding possibility).

Fix focus dots combo box now has 3rd option, CropRec, which turns on the map generator for raw videos recorded with crop_rec module.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 27, 2017, 08:00:50 PM
I'm literally lost in this puddle of mud. For good reasons though. Am I still to be testing with the latest 0.8 version or is there later revision?  :P

Anyway here's what I came across when using SL1 RAW footage (that has Focus Pixels) which was shot in crop_rec and noticed few strange things in case you guys haven't already?

When selecting Fix Focus Dots option to ON while having Chroma Smoothing off then shows the focus pixels. But with FFD ON while having CS_2x2 ON then cleans up nicely except for the border lines if you look closely.

However, even more strange was the fact when I deselect the FFD to OFF while having just CS_2x2 ON still keeps the image clean from showing Focus Pixels? Will test more thoroughly on this with varieties of files later.







I remember this very similar matter when testing out Focus Pixels back in the day w @dfort & @Danne. Fond memories!   :D

Quote from: bouncyball on September 27, 2017, 07:27:21 PM
Some changes to the raw correction part:

Now focus pixel maps not needed in the working directory any more. MLV App will generate maps according to MLV metadata on the fly, including crop_rec mode MLVs (EOSM, 100D, 700D, 650D). If .fpm map intentionally placed to the working directory it will be used instead of internal generator (overriding possibility).

Fix focus dots combo box now has 3rd option, CropRec, which turns on the map generator for raw videos recorded with crop_rec module.

This is really nice actually. Keep on rockin' BB McFly!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 27, 2017, 08:39:44 PM
@DeafEyeJedi: The focus pixel maps were missing in the v0.8 OSX, and there was still a little bug. So that does not work correctly there for OSX... There are newer working revisions on the repos (->with focus pixels working), but not as release yet.

Quote from: escho on September 27, 2017, 07:09:01 PM
i like the darkstyle, but the playback buttons are a bit difficult to recognize.
Yes, that is correct. So I created some new ones today. They are on github now. Hope you like them.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 27, 2017, 08:47:05 PM
Quote from: masc on September 27, 2017, 08:39:44 PM
I created some new ones today. They are on github now. Hope you like them.
Look nice  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 27, 2017, 09:17:56 PM
@DeafEyeJedi: yeah @masc is right. There where no focus maps supplied in this release. That is why cs2x2 gets rid of the most dots except border ones :). It will not be case in the later updated version because map will be generated on the fly.

@masc: loved new look and buttons! :D

Edit: loop button is a bit vague.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 27, 2017, 09:40:27 PM
Quote from: bouncyball on September 27, 2017, 09:17:56 PM
Edit: loop button is a bit vague.
Yepp. New try.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 27, 2017, 10:10:12 PM
@revast

Could you please change the .pro file like this (Should be lines 55 ff)

#Linux (opensuse)
#linux-g++*: INCLUDEPATH += /usr/local/include/
#linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng
#Linux (Ubuntu)
#linux-g++*: INCLUDEPATH += /usr/local/include/libpng16/
linux-g++*: LIBS += -lz -lpng16


and try to compile using

make clean
qt5-qmake MLVApp.pro
make


I would like to know, whether this works on your ubuntu.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on September 28, 2017, 10:12:39 AM
New icons are good! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: revast on September 28, 2017, 11:12:05 PM
QuoteCould you please change the .pro file like this

Yeah, works.
except the fact its qmake-qt5 on ubuntu :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 29, 2017, 08:06:26 PM
@escho & @revast: did I understand right that I can change

#Linux (opensuse)
#linux-g++*: INCLUDEPATH += /usr/local/include/
#linux-g++*: LIBS += -L/usr/local/lib/ -lz -lpng
#Linux (Ubuntu)
#linux-g++*: INCLUDEPATH += /usr/local/include/libpng16/
linux-g++*: LIBS += -lz -lpng16

to

#Linux
linux-g++*: LIBS += -lz -lpng16

?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on September 29, 2017, 08:35:20 PM
@masc
I guess, most of the linux-distros should compile out of the box with this change
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 29, 2017, 09:32:44 PM
Ok, thx. Commited.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: erikbaldwinson on September 29, 2017, 09:47:40 PM
Cool program! Thank you for sharing.

Is there a solution for adding the H264 audio to the final proress export in windows using this program?

Cheers
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 29, 2017, 10:39:53 PM
Thx. H264 audio? You record H264 and mlv at the same time and now you like to add the audio track from the H264 to the output of MLV App? Is that right? Hmmm...  I never thought about that, but for now we do not decode H264 files, just MLV.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on September 29, 2017, 10:53:55 PM
I do this in Switch. Need to cut off black frames in the beginning of the file and then match the file with frame amount of the mlv file. Works with ffmpeg.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: erikbaldwinson on September 29, 2017, 11:10:33 PM
Quote from: masc on September 29, 2017, 10:39:53 PM
Thx. H264 audio? You record H264 and mlv at the same time and now you like to add the audio track from the H264 to the output of MLV App? Is that right? Hmmm...  I never thought about that, but for now we do not decode H264 files, just MLV.

Yes that's correct. I'm on windows and there does not seem to be an easy way to do this. The way I have been doing it is manually clip by clip in Resolve.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on September 30, 2017, 11:52:09 PM
I am awfully sorry to report that v.08 does not work on either of my Win7x64 PCs.  This time, it crashes when I try to import a MLV file.  Is anybody else experiencing this?  Is there anything I could do?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 01, 2017, 09:22:38 AM
Don't be sorry ;) just tell us which version crashes - 32bit or 64bit?

Also provide additional details about MLV(s) which crashes program and upload it somewhere.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 01, 2017, 10:56:31 AM
Quote from: IDA_ML on September 30, 2017, 11:52:09 PM
I am awfully sorry to report that v.08 does not work on either of my Win7x64 PCs.  This time, it crashes when I try to import a MLV file.  Is anybody else experiencing this?  Is there anything I could do?
Hm... we have so many Windows PCs where it does not crash and for you it does crash on every PC. Very strange. I could imagine that it could be an localization problem. Could you please tell us your Windows country (& maybe language) settings? I could simulate this on my computers... maybe I have luck and it does crash for me too  :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on October 01, 2017, 11:07:54 AM
i can import some files but it crash while trying to import some other  MLV files. im on win7 X64
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on October 01, 2017, 02:46:46 PM
Quote from: bouncyball on October 01, 2017, 09:22:38 AM
Don't be sorry ;) just tell us which version crashes - 32bit or 64bit?

Also provide additional details about MLV(s) which crashes program and upload it somewhere.

I tried both - the 64 and the 32 bit versions.  They both crash when I try to import a 10-bit MLV file (2496x1080) with sound from the 100D.  Later on I can upload a short file for you.

Quote from: masc on October 01, 2017, 10:56:31 AM
Hm... we have so many Windows PCs where it does not crash and for you it does crash on every PC. Very strange. I could imagine that it could be an localization problem. Could you please tell us your Windows country (& maybe language) settings? I could simulate this on my computers... maybe I have luck and it does crash for me too  :P

I am in Bulgaria and my regional and language settings are:

Location: Bulgaria
Format: English (United States)
Current System Locale: Bulgarian (Bulgaria)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 01, 2017, 05:35:11 PM
i updated my tutorial for compiling MLV App under Linux openSUSE Leap 42.3. And I translated the whole stuff into english:
https://seescho.wordpress.com/fotos/ml/
Hope, it will be useful
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 01, 2017, 06:27:03 PM
@IDA_ML: ok, please upload sample.

@escho: sadly it's only german :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 01, 2017, 06:29:25 PM
Quote from: bouncyball on October 01, 2017, 06:27:03 PM

@escho: sadly it's only german :)

contains english translation, too :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on October 01, 2017, 07:16:29 PM
Quote from: bouncyball on October 01, 2017, 06:27:03 PM
@IDA_ML: ok, please upload sample.

Here we go:

https://we.tl/2TlV9r9I3u

A 2.5K 10-bit MLV file with sound (270 MB).  The above link will be active for 7 days.  Hope this helps and if yes, I will be looking forward to test MLVApp.  Thanks. 
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on October 01, 2017, 07:54:41 PM

(http://thumb.ibb.co/bZWELb/Capture.png) (http://ibb.co/bZWELb)

upload photograph (http://imgbb.com/)
Quote from: IDA_ML on October 01, 2017, 07:16:29 PM
Here we go:

https://we.tl/2TlV9r9I3u

A 2.5K 10-bit MLV file with sound (270 MB).  The above link will be active for 7 days.  Hope this helps and if yes, I will be looking forward to test MLVApp.  Thanks.

i can import your mlv file. i have some files from 70D which keep crashing while importing and i can't share those files as they are very large. i tried shortening but it works if i shorten those files
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: smasry on October 01, 2017, 08:09:11 PM
Hi guys,

I don't understand it, but I can't 'make' the app. I'm on Sierra 10.12.6, but what's strange is that I've compiled it successfully on another Sierra, with no problems.

The error I'm getting is:


$ make app



...
Initial app name: MLV App (Oct  1 2017 18:55:55 @cabian.local)
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c main.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/llrawproc.c
../../src/mlv/llrawproc/llrawproc.c:70:16: error: no member named 'raw2evf' in
      'llrawprocObject_t'; did you mean 'raw2ev'?
    llrawproc->raw2evf = NULL;
               ^~~~~~~
               raw2ev
../../src/mlv/llrawproc/../llrawproc/llrawproc_object.h:55:11: note: 'raw2ev'
      declared here
    int * raw2ev;
          ^
1 error generated.
make[2]: *** [llrawproc.o] Error 1
cp: MLV App: No such file or directory
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg 


The only thing I can think of to explain this discrepancy is that one or more dependencies may be missing, but I can't find any mention of any hard (macOS) dependencies either in your repository nor in this thread.

Any idea what I'm doing wrong/missing?

Thanks
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 01, 2017, 08:42:28 PM
Same error here on Linux. Looks like the declaration of raw2evf is missing in llrawproc_object.h
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 01, 2017, 09:53:16 PM
Please try one revision earlier. It seems as the second last commit of bouncyball does not compile. Before that it was working.
https://github.com/ilia3101/MLV-App/commit/1188472ee5eac5f65dc3a8454499b9bd7f36920e (https://github.com/ilia3101/MLV-App/commit/1188472ee5eac5f65dc3a8454499b9bd7f36920e)
This one can be compiled.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 01, 2017, 10:03:44 PM
Guys sorry about that, just delete the line to which error's referring. I forgot to delete it after some experimenting. This commit has working full20bit mean32 interpolation mode dual iso processing. Amaze interpolation is not there yet. Will finish it tomorrow I think and gonna add some more widgets to the gui.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 01, 2017, 10:12:44 PM
@IDA_ML: Thanks for your upload and your information. I set the programs "QLocale" to Bulgaria and English, but I can load your file without problem. I really have no idea where to search :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on October 01, 2017, 10:44:49 PM
Masc,

At work we have a PC with Win XPx32.  Does it make sense to try the 32-bit version on it?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: smasry on October 02, 2017, 09:49:56 AM
QuotePlease try one revision earlier. It seems as the second last commit of bouncyball does not compile. Before that it was working.
https://github.com/ilia3101/MLV-App/commit/1188472ee5eac5f65dc3a8454499b9bd7f36920e
This one can be compiled.

I reverted the checked-out repository to revision 1188472ee5eac5f65dc3a8454499b9bd7f36920e, as well as (separately) deleting the line in the .c file as bouncy ball asks here:

Quote from: bouncyball on October 01, 2017, 10:03:44 PM
Guys sorry about that, just delete the line to which error's referring. I forgot to delete it after some experimenting. This commit has working full20bit mean32 interpolation mode dual iso processing. Amaze interpolation is not there yet. Will finish it tomorrow I think and gonna add some more widgets to the gui.

Now I get this error:


...
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o llrawproc.o pixelproc.o stripes.o patternnoise.o hist.o -o "MLV App" -framework Cocoa;
Undefined symbols for architecture x86_64:
  "_diso_get_preview", referenced from:
      _applyLLRawProcObject in llrawproc.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [build] Error 1
cp: MLV App: No such file or directory
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on October 02, 2017, 10:01:10 AM
Strange, I'll see what's happened when I try to build mlv app on my Mac later.
It does still look like bouncyball's stuff isn't compiling for you :(

@IDA_ML please do try, although I'm not 100% certain XP will even support the binary :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 02, 2017, 11:01:13 AM
I fixed the error. Delete repository then clone the fresh copy of it and try to compile again.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 02, 2017, 11:56:55 AM
@Ilia3101: Hi man :) it seems you are very busy these days.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: smasry on October 02, 2017, 01:20:40 PM
Hi @bouncyball,

Quote from: bouncyball on October 02, 2017, 11:01:13 AM
I fixed the error. Delete repository then clone the fresh copy of it and try to compile again.

I did this, but sorry to report, it seems to produce the same error.


...
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o llrawproc.o pixelproc.o stripes.o patternnoise.o hist.o -o "MLV App" -framework Cocoa;
Undefined symbols for architecture x86_64:
  "_diso_get_full20bit", referenced from:
      _applyLLRawProcObject in llrawproc.o
  "_diso_get_preview", referenced from:
      _applyLLRawProcObject in llrawproc.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [build] Error 1
cp: MLV App: No such file or directory
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg 
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: smasry on October 02, 2017, 01:51:05 PM
@bouncyball:

Can I run 'make app' with more verbosity, or with command line arguments to produce output more useful to aid debugging?

Don't stress because of this error, I have a working MLV App on another computer, and am happy using mlv_dump in the meantime.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 02, 2017, 01:54:12 PM
The error happens because you try to compile the cocoa app. The newest stuff is only working in the Qt version, until Ilia makes some changes to the cocoa makefile. The new implemented files should be added there I think.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on October 02, 2017, 03:36:50 PM
Ilia3101,

I tried MLVApp (x86) v.08 on a WinXP x32 machine but it will not even start.  Here is what I get:


(https://thumb.ibb.co/mpK2Qb/MLVApp_entry_point.png) (https://ibb.co/mpK2Qb)


No luck for me with MLVApp.  Will have to stick with other methods.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: smasry on October 02, 2017, 04:38:35 PM
Thanks @masc!

Quote from: masc on October 02, 2017, 01:54:12 PM
The error happens because you try to compile the cocoa app. The newest stuff is only working in the Qt version, until Ilia makes some changes to the cocoa makefile. The new implemented files should be added there I think.

I guess I rushed ahead of myself, into the 'bleeding edge' even before the documentation has been updated.

Instead, I downloaded release 7b63, and will make do.

I'd still like to test the app, as you develop it, and didn't find macOS (instead of Linux) instructions for building from '/qt' instead of '/cocoa'. When you have a minute, would you mind updating the README with the necessary dependencies, and build instructions?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 02, 2017, 05:01:16 PM
@smasry: Compiling on OSX:
-unzip ffmpeg in its folder.
-compile and install libpng (is also in the repos) as described in its readme.
-load the .pro in QtCreator
-unchecking Add build library search path to DYLD_LIBRARY_PATH and DYLD_FRAMEWORK_PATH checkbox in my project Run section
-press the "Play" Icon and have fun.
Hope I did not forget anything...
It runs nearly out of the box, so I was to lazy to write a readme... sry ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 02, 2017, 05:04:29 PM
Quote from: IDA_ML on October 02, 2017, 03:36:50 PM
Ilia3101,

I tried MLVApp (x86) v.08 on a WinXP x32 machine but it will not even start.  Here is what I get:


(https://thumb.ibb.co/mpK2Qb/MLVApp_entry_point.png) (https://ibb.co/mpK2Qb)


No luck for me with MLVApp.  Will have to stick with other methods.
What a shame... I first thought with this error message I can search... but it will only tell us MinGw (our Windows compiler) is not supported on WinXP :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: canneloni on October 02, 2017, 05:53:29 PM
Would anybody care to explain how i can compile the qt version on Windows using Linux subsytem? I'm fairly new at this and only followed the instruction to compile ML which was great and worked well. I already cloned git repository on my disk but was unable to use make in qt folder since there is no make file (i guess).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 02, 2017, 06:01:03 PM
Quote from: canneloni on October 02, 2017, 05:53:29 PM
I already cloned git repository on my disk but was unable to use make in qt folder since there is no make file (i guess).
I don't know how to compile the exe from Linux. But qmake creates automatically the makefile for a Qt project (.pro file).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on October 02, 2017, 08:33:45 PM
Cocoa app compiling is fixed (https://github.com/ilia3101/MLV-App/commit/f0db1830b68baa5b36d597d86b92e4fe383e7b1f), no GUI access to bouncyball's features though - yet

@bouncyball I'm not that busy, but more than before, I am still working on things (caching, GUI for LLRawProc etc... sessions is going slower). I haven't given up or abandoned it ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 02, 2017, 08:40:57 PM
Great to hear @Ilia3101!  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 02, 2017, 09:06:15 PM
@Ilia3101

Quote from: Ilia3101 on October 02, 2017, 08:33:45 PM
I haven't given up or abandoned it ;)
Cool to know!!! :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: canneloni on October 03, 2017, 09:31:27 AM
Quote from: masc on October 02, 2017, 06:01:03 PM
I don't know how to compile the exe from Linux. But qmake creates automatically the makefile for a Qt project (.pro file).

Okay let me rephrase. Whats the best way to compile this for Windows ? The Git page only shows how to do it for cocoa and mac.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 03, 2017, 09:45:47 AM
Quote from: canneloni on October 03, 2017, 09:31:27 AM
Okay let me rephrase. Whats the best way to compile this for Windows ? The Git page only shows how to do it for cocoa and mac.
To compile static x64 Windows binary on Linux I'm using MXE (http://mxe.cc). There is all information how to set it up. Also take a look at this (https://askubuntu.com/questions/656219/building-a-windows-executable-in-qt-on-a-linux-system) thread.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 03, 2017, 10:17:28 AM
Maybe you know, that I have problems, importing files bigger than 4 Gbyte. The app crashes. These files are way to big for uploading somewhere.

So I startet QT Creator in debugging mode with a file with 7,6 GByte. With this file, MLV App always crashes in "frame_cashing.c" Is it possible to run MLV App without cashing for a test? What must I do to disable cashing?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 03, 2017, 11:11:27 AM
Quote from: escho on October 03, 2017, 10:17:28 AM
Maybe you know, that I have problems, importing files bigger than 4 Gbyte. The app crashes. These files are way to big for uploading somewhere.

So I startet QT Creator in debugging mode with a file with 7,6 GByte. With this file, MLV App always crashes in "frame_cashing.c" Is it possible to run MLV App without cashing for a test? What must I do to disable cashing?
That is strange. Caching is deactivated for the Qt App. In which line does it crash?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 03, 2017, 11:14:52 AM
Quote from: canneloni on October 03, 2017, 09:31:27 AM
Okay let me rephrase. Whats the best way to compile this for Windows ? The Git page only shows how to do it for cocoa and mac.
Get QtCreator for Windows. Unzip ffmpeg. Start QtCreator. Open .pro. Click on Play-Icon. Have fun.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on October 03, 2017, 01:04:21 PM
Seems everyone wants how to compile Qt app in the read me. I'll put one together this evening (unless masc or bouncyball beat me to it). shouldn't be too hard as I just installed Qt
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 03, 2017, 03:19:17 PM
Quote from: Ilia3101 on October 03, 2017, 01:04:21 PM
Seems everyone wants how to compile Qt app in the read me. I'll put one together this evening (unless masc or bouncyball beat me to it). shouldn't be too hard as I just installed Qt
That would be cool! If you need help, let me know... but it is really not hard.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 03, 2017, 03:49:58 PM
Quote from: escho on October 03, 2017, 10:17:28 AM
With this file, MLV App always crashes in "frame_cashing.c" Is it possible to run MLV App without cashing for a test?
Does this MLV pass through other programs? mlv_dump, mlvfs?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 03, 2017, 05:37:25 PM
Quote from: bouncyball on October 03, 2017, 03:49:58 PM
Does this MLV pass through other programs? mlv_dump, mlvfs?
I´m a bit busy at the moment, so sorry for only a short answer:
No problems with mlv_dump. All frames are decoded to dng, no frame is corrupted.
I will do some screenshots later this evening, maybe tomorrow.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: hjfilmspeed on October 04, 2017, 05:00:26 AM
Not sure If this has been addressed. Just really excited to use this. I get a crash every time on import of 14bit lossless 1920 x 1080 23.976 clip.  Sorry for the terrible report but this app looks so good. I haven't had enough time to review this part of the forum but I will delete if this has been addressed. I'm on a On a windows 7 x64 Machine here is the windows error report:
Problem signature:
  Problem Event Name:   APPCRASH
  Application Name:   mlvapp.exe
  Application Version:   0.0.0.0
  Application Timestamp:   59c7c736
  Fault Module Name:   mlvapp.exe
  Fault Module Version:   0.0.0.0
  Fault Module Timestamp:   59c7c736
  Exception Code:   c000001d
  Exception Offset:   0000000000017fc6
  OS Version:   6.1.7601.2.1.0.256.1
  Locale ID:   1033
  Additional Information 1:   907b
  Additional Information 2:   907bc937f1d4b6de41bbc9e5a303a085
  Additional Information 3:   a276
  Additional Information 4:   a27670abb9f65021d2cba031d8026e8f

Read our privacy statement online:
  http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0409

If the online privacy statement is not available, please read our privacy statement offline:
  C:\Windows\system32\en-US\erofflps.txt
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 04, 2017, 09:46:13 AM
Well this error dump gives no hint at all to anybody ( as usual, thanks MS ;) ).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 05, 2017, 07:39:55 PM
Quick question -- upon compiling and making app is it normal for me to receive all these warnings?

Look on the bottom of this code.

Seans-Mini-385:~ DeafEyeJedi$ cd MLV-App/platform/cocoa
Seans-Mini-385:cocoa DeafEyeJedi$ make app
rm "MLV App".app; \
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 generate_info_plist.c -o generate_info_plist; \
./generate_info_plist "MLV App"; \
make main; \
rm -rf "MLV App".app; \
mkdir "MLV App".app; \
mkdir "MLV App".app/Contents; \
mkdir "MLV App".app/Contents/MacOS; \
mkdir "MLV App".app/Contents/Resources; \
cp -i "MLV App" "MLV App".app/Contents/MacOS/; \
cp -i info.plist "MLV App".app/Contents/; \
mkdir "MLV App".app/Contents/Resources/pixelmaps; \
cp -i ../../src/mlv/llrawproc/pixelmaps/*.fpm "MLV App".app/Contents/Resources/pixelmaps; \
unzip ../qt/FFmpeg/ffmpegOSX.zip -d "MLV App".app/Contents/Resources; \
rm -rf "MLV App".app/Contents/Resources/__MACOSX; \
cp ../../src/icon/icon.icns "MLV App".app/Contents/Resources/MLV\ App.icns; \
rm generate_info_plist; \
rm info.plist; \

rm: MLV App.app: No such file or directory
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 compile_time_code.m -o compile_time_code -framework Cocoa; \
./compile_time_code; \
rm main.o; \
make build; \
rm compile_time_code; \
rm app_defines.h
Initial app name: MLV App (Oct  5 2017 10:37:16 @Seans-Mini-385)
rm: main.o: No such file or directory
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c main.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/video_mlv.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -pthread ../../src/debayer/debayer.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/debayer/amaze_demosaic.c
In file included from ../../src/debayer/amaze_demosaic.c:36:
../../src/debayer/sleefsseavx.c:27:9: warning: 'M_PI' macro redefined
      [-Wmacro-redefined]
#define M_PI 3.14159265358979323846
        ^
/usr/include/math.h:703:9: note: previous definition is here
#define M_PI        3.14159265358979323846264338327950288   /* pi             */
        ^
In file included from ../../src/debayer/amaze_demosaic.c:36:
../../src/debayer/sleefsseavx.c:28:9: warning: 'M_1_PI' macro redefined
      [-Wmacro-redefined]
#define M_1_PI 0.31830988618379067154
        ^
/usr/include/math.h:706:9: note: previous definition is here
#define M_1_PI      0.318309886183790671537767526745028724  /* 1/pi           */
        ^
In file included from ../../src/debayer/amaze_demosaic.c:36:
../../src/debayer/sleefsseavx.c:29:9: warning: 'M_2_PI' macro redefined
      [-Wmacro-redefined]
#define M_2_PI 0.63661977236758134308
        ^
/usr/include/math.h:707:9: note: previous definition is here
#define M_2_PI      0.636619772367581343075535053490057448  /* 2/pi           */
        ^
3 warnings generated.
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/processing/raw_processing.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c main_methods.m
main_methods.m:265:63: warning: null passed to a callee that requires a non-null
      argument [-Wnonnull]
  ...[[App->rawBitmap representationUsingType: NSPNGFileType properties: nil...
                      ^                                                  ~~~
1 warning generated.
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c gui_stuff/useful_methods.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c background_thread.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/matrix/matrix.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/camera_matrices.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/frame_caching.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/liblj92/lj92.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c session_methods.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c delegate.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c -x objective-c mlv_view.m
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/llrawproc.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/pixelproc.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/stripes.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/patternnoise.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/hist.c
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 -c ../../src/mlv/llrawproc/dualiso.c
../../src/mlv/llrawproc/dualiso.c:34:9: warning: 'M_PI' macro redefined
      [-Wmacro-redefined]
#define M_PI 3.14159265358979323846 /* pi */
        ^
/usr/include/math.h:703:9: note: previous definition is here
#define M_PI        3.14159265358979323846264338327950288   /* pi             */
        ^
1 warning generated.
clang -mmacosx-version-min=10.10 -O3 -Ofast -m64 main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o llrawproc.o pixelproc.o stripes.o patternnoise.o hist.o dualiso.o -o "MLV App" -framework Cocoa;
Archive:  ../qt/FFmpeg/ffmpegOSX.zip
  inflating: MLV App.app/Contents/Resources/ffmpeg 
   creating: MLV App.app/Contents/Resources/__MACOSX/
  inflating: MLV App.app/Contents/Resources/__MACOSX/._ffmpeg 
Seans-Mini-385:cocoa DeafEyeJedi$


I have a feeling it's because my Mac Mini just became a virgin last week after accidentally typing in incorrectly to try and remove a directory as oppose to the entire drive. So excuse for my stupidity in here.  Forgot that I have to start everything again from scratch on this machine. :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 05, 2017, 08:41:36 PM
When I'm compiling QTApp I got 63 warnings :P (of course someday all these warnings should be addressed, but mostly they are not harmful)
As far as it compiles and runs I guess this is true for cocoa version too.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 05, 2017, 08:50:08 PM
Quote from: bouncyball on October 05, 2017, 08:41:36 PM
When I'm compiling QTApp I got 63 warnings :P (of course someday all these warnings should be addressed, but mostly they are not harmful) I guess this is true for cocoa version too.

HeHe. Just checked the platform. Saw an MLV App build under Cocoa. Opened it. Wont let me batch import. One file works fine. Upon exporting I get error message after it crashed. I also got a prompt message from MLV App saying that 'export completed' but nothing showed up in destination folder.

Here's a log report in case they are any hints or clues...

https://mega.nz/#!7kEzSRQB!7dLqraZ8kOuBoX2AsUWqNDY98aliEWZgHqBak2Nx2cM
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on October 05, 2017, 11:06:16 PM
Quote from: DeafEyeJedi
Quick question -- upon compiling and making app is it normal for me to receive all these warnings?
Only one used to be there, but the new ones are harmless as far as I can tell.

Quote from: DeafEyeJedi
Wont let me batch import.
Ah yes, batch import isn't done yet in Cocoa app, that's on the way. Though Cocoa app is probably gonna take a little while to catch up with Qt.

And sorry about the crash on ending of export. Also, I find that the non-exporting clip thing happens only in some directories :/

My current thing is getting cache working which I was going to commit yesterday, then today, but nothing got done today(zero), so gonna have to be tommorow.
@bouncyball we'll have to find a way of detecting LLRawProc changes to know when to re-cache, maybe we can add a flag?
Anyway, first I'll commit it to the cache branch then we sort that out.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 06, 2017, 08:11:54 AM
Quote from: Ilia3101 on October 05, 2017, 11:06:16 PM
@bouncyball we'll have to find a way of detecting LLRawProc changes to know when to re-cache, maybe we can add a flag?
Anyway, first I'll commit it to the cache branch then we sort that out.
OK, I think the simplest way will be to introduce some "is_changed" variable in the llrawproc struct which will be set to true when gui widget handlers get called and then reset to false by caching module.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 06, 2017, 05:32:07 PM

QuoteQuote from: escho on October 03, 2017, 10:17:28 AM

    Maybe you know, that I have problems, importing files bigger than 4 Gbyte. The app crashes. These files are way to big for uploading somewhere.

    So I startet QT Creator in debugging mode with a file with 7,6 GByte. With this file, MLV App always crashes in "frame_cashing.c" Is it possible to run MLV App without cashing for a test? What must I do to disable cashing?


Quote from: masc on October 03, 2017, 11:11:27 AM
That is strange. Caching is deactivated for the Qt App. In which line does it crash?

It crashes in line 61: https://seescho.files.wordpress.com/2017/10/screenshot_20171005_191349.jpg
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 06, 2017, 07:11:19 PM
Any chance I can compile/make the QT version instead of the MLV App for me to try the latest Dual-ISO implementation?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 06, 2017, 07:34:14 PM
Quote from: escho on October 06, 2017, 05:32:07 PM
It crashes in line 61: https://seescho.files.wordpress.com/2017/10/screenshot_20171005_191349.jpg
Thank you! I'll have a look at that! That information really helps!

Quote from: DeafEyeJedi on October 06, 2017, 07:11:19 PM
Any chance I can compile/make  the QT version instead of the MLV App for me to try the latest Dual-ISO implementation?
Sure, if you like, download Qt (free version, I think 5.9.1 is the latest), install, and do what I wrote somewhere above. The most difficult part is to compile and install libpng and zlib on mac (done in terminal, without Qt). The libraries are also in the repos (zip files).

Edit: there are some bugs inside atm, that is (for me) the main reason why I don't like to build a next release for everybody. We are working on it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 06, 2017, 07:52:55 PM
Quote from: escho on October 06, 2017, 05:32:07 PM
It crashes in line 61: https://seescho.files.wordpress.com/2017/10/screenshot_20171005_191349.jpg

Hm, okay, this function is called from MainWindow, openMlv(). For a quick test you could comment this function out there. For the future this may not be the solution...

@Ilia: do you need this function still after your big cache update, or will it be changed? Maybe have a look on that...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 06, 2017, 07:55:41 PM
Quote from: masc on October 06, 2017, 07:34:14 PM
Edit: there are some bugs inside atm, that is (for me) the main reason why I don't like to build a next release for everybody. We are working on it.

No worries. Was just curious of the current state being. It's definitely getting closer as we all can feel it, right? Thanks! ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 06, 2017, 09:27:58 PM
Quote from: masc on October 06, 2017, 07:52:55 PM
Hm, okay, this function is called from MainWindow, openMlv(). For a quick test you could comment this function out there. For the future this may not be the solution...

I commented out line 461 in MainWindow.cpp. Now the app crashes in line 468 in MainWindow.cpp:  https://seescho.files.wordpress.com/2017/10/2.jpg

I did another test. I cut the 7,6 G-file using "mlv_dump -fxxxx":

1318frames.MLV run with no problems
1319frames.MLV let the app crash.

Here are the filesizes of the two MLVs:

edgar@localhost:~/test/frames> ls -l
insgesamt 8440240
-rw-r--r-- 1 edgar users 4319763492  6. Okt 20:57 1318frames.MLV
-rw-r--r-- 1 edgar users 4323038516  6. Okt 20:58 1319frames.MLV


I cannot locate, where the crash with 1319frames.MLV appears, since QT Creator tells me, it cannot find binary debug informations for this stack frame.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 08, 2017, 12:09:09 PM
Quote from: escho on October 06, 2017, 09:27:58 PM
I commented out line 461 in MainWindow.cpp. Now the app crashes in line 468 in MainWindow.cpp:  https://seescho.files.wordpress.com/2017/10/2.jpg

I did another test. I cut the 7,6 G-file using "mlv_dump -fxxxx":

1318frames.MLV run with no problems
1319frames.MLV let the app crash.

Here are the filesizes of the two MLVs:

edgar@localhost:~/test/frames> ls -l
insgesamt 8440240
-rw-r--r-- 1 edgar users 4319763492  6. Okt 20:57 1318frames.MLV
-rw-r--r-- 1 edgar users 4323038516  6. Okt 20:58 1319frames.MLV


I cannot locate, where the crash with 1319frames.MLV appears, since QT Creator tells me, it cannot find binary debug informations for this stack frame.

Thx for your work! Unfortunately I can't test or debug that, because I can't create such a big file with my 5D2. But I created an issue on github for that problem and inserted your messages as quote.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 08, 2017, 03:05:10 PM
Quote from: masc on October 08, 2017, 12:09:09 PM
Thx for your work! Unfortunately I can't test or debug that, because I can't create such a big file with my 5D2. But I created an issue on github for that problem and inserted your messages as quote.

Thanks for opening an issue. You can find my answer in github :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 11, 2017, 11:23:48 AM
@escho

Can you confirm that under Linux audio is not working as expected in the latest github version?
Which distribution do you use?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 12, 2017, 08:55:07 AM
Quote from: bouncyball on October 11, 2017, 11:23:48 AM
Can you confirm that under Linux audio is not working as expected in the latest github version?
Which distribution do you use?

Since I  use rawvideo only for my astromomical shootings ( https://seescho.wordpress.com/ ), I have no sound in the MLVs. I must wait for the weekend to record some clips with sound and will report.

I´m on openSUSE Leap42.3 or (for some reasons at tho moment) on the "near bleeding edge" openSUSE Thumbleweed.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 16, 2017, 11:50:12 AM
@masc
Importing a MLV. via menue
File - import mlv - irgendetwas.MLV:  leftclick
This imports the MLV immedeately whithout pressing the open button. Is this expected behavior?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 16, 2017, 12:06:03 PM
Quote from: escho on October 16, 2017, 11:50:12 AM
@masc
Importing a MLV. via menue
File - import mlv - irgendetwas.MLV:  leftclick
This imports the MLV immedeately whithout pressing the open button. Is this expected behavior?

This should be operating system behaviour. For me, I have to select the file(s), doubleclick one file or press open. Qt can't change the behaviour of the systems open dialog. I must implement a own file dialog in order to change it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on October 16, 2017, 10:56:49 PM
Thanks for the hint. I had a big fight in the last few hours with the big files doing funny things. So I will look later, how I can tune my OP.  ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on October 21, 2017, 11:25:14 PM
New Cocoa App release (v0.21)

(https://user-images.githubusercontent.com/23642861/31855848-4d05911c-b6ab-11e7-8a87-5e0a546b9417.png)

Main news:

Working on getting session implemented too like the Qt App - still not there.

Not sure where to go next with this GUI :-\

Download (https://github.com/ilia3101/MLV-App/releases/tag/v0.21-pre-alpha-xyY-edition)

Note: I still recommend using Qt app for anything relatively serious, this is only for testing.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on October 21, 2017, 11:54:46 PM
Looking good Ilia.
Is vertical stripes set to off as default?
I prefer raw2dng code pixel fix code set to default. Maybe the new workflow works better with mlvfs code nowadays.
I think crop_rec code could be automated since we have RAWC metadata.
How is dualiso working? On the fly prores making?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 22, 2017, 12:08:52 AM
It does look good indeed!

What part of your not sure where to go next with the gui?
I think its growing up very fast
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 22, 2017, 11:12:05 AM
And here comes after a very long time a new MLVApp Qt version. We had many problems with old and new features. Some of them are still present... you'll see when trying out.  Download (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.9alpha)
New features:
- more RAW corrections, focus pixels working
- dual ISO working
- free zoom
- new caching
- sharpening
- pipe ffmpeg export (no more intermediate PNG, much faster)
- new export options for ffmpeg (ProRes 422 way faster with ffmpeg Anatolyi option)
- single 48bit (3x16bit) PNG frame export
- RGB parade
- dark style
- many detail enhancements
- many bugfixes
Problems:
- big audio (sync) problems on Linux, small audio problems on Windows (app may crash when looping very small clips with audio)
- maybe still some instability with caching (has to be tested more)
- ... :P

@bouncyball: could you please again compile and upload the windows versions on github release page?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on October 22, 2017, 11:46:31 AM
Great! A slight warning about Prores422. I tested it with my piping in Switch but it doesn´t hold up in shadows like the slower prores_ks is doing. Could maybe work better here, idk. As a matter of fact I got better, smaller and faster output with H.264 like this:
-c:v libx264 -preset ultrafast -crf 18
or bigger, lossless:
-c:v libx264 -preset ultrafast -crf 0

Maybe not the best format to work with in post...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 22, 2017, 04:04:56 PM
Quote from: masc on October 22, 2017, 11:12:05 AM
@bouncyball: could you please again compile and upload the windows versions on github release page?
Yes sure :) 64bit very soon. 32 bit maybe later.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 22, 2017, 04:33:53 PM
Uploaded
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 22, 2017, 07:38:00 PM
@bouncyball: thank you!
@Danne: Ok, I did no quality checks with it yet. I only saw, that 422 Proxy is 4 times bigger and looks way better in prores_aw than prores_ks. Best quality will be prores_ks 4444. I thought it could be interesting for people who don't want to wait a long time to preview the files and maybe use the same files as proxy... Thanks for writing your experience! ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on October 22, 2017, 07:50:14 PM
I see if I find some time to test more. It may very well be the way dcraw pipes the dng files. By the way. How are you piping atm? Mlv straight to ffmpeg? Would be nice if mlv_dump could pipe straight to ffmpeg  :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 22, 2017, 08:40:41 PM
We do this: mlv->raw corrections->debayer->processing->pipe to ffmpeg (audio still via .wav)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 24, 2017, 04:38:06 PM
@masc:

I compiled Winx86 version but unfortunately can not upload it to the release page b/c it crashed every time I import any MLV.

Debugger stops in the "an_mlv_cache_thread()" function on the initialization of "amaze_params" struct.... very strange.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 24, 2017, 05:52:52 PM
This is what I described here: https://github.com/ilia3101/MLV-App/issues/35
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on November 05, 2017, 09:33:13 AM
Just tested the quicktime version and it works so good batch exporting. Question. I lined up 10 MLV files in the queue. How do I abort processing? Pushed esc but it continues after closing down the app. Had to go into terminal and do:
killall ffmpeg

Now I am really curious if it would be possible to export HDR MLV files? All it takes is a small ffmpeg filter:
-vf tblend=all_mode=average
http://www.magiclantern.fm/forum/index.php?topic=20025.msg189033;topicseen#msg189033

Coud be worth trying out.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 05, 2017, 03:59:03 PM
Where did you find a quicktime version? Never heard that it is ready yet.

For the Qt version, abort processing works when clicking the "Abort" button in the status dialog. It is implemented for the latest revisions on github. There is no release yet, so you have to compile it yourself for now. For the old releases you can only wait or kill the processes yourself.

This HDR thing I could try out. Thx.
Edit: is this for any mlv or for hdr-mlraw?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on November 05, 2017, 04:27:28 PM
Any plans on adding DNG as an export option in the future?

Great progress on the app so far  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on November 05, 2017, 04:52:47 PM
I downloaded 0.9 version in first post so probably not the latest. Would be nice if there was a description of dependencies for compiling on mac :).
The tblend filter can be applied to any footage but will only be useful when used with hdr material. Averaging filter will create ghosting so 48, 50 or 60 fps is better to use as opposed to slower fps.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 05, 2017, 06:01:01 PM
Quote from: FBongcam on November 05, 2017, 04:27:28 PM
Any plans on adding DNG as an export option in the future?

https://github.com/ilia3101/MLV-App/issues/28
It is discussed here.

Quote from: Danne on November 05, 2017, 04:52:47 PM
I downloaded 0.9 version in first post so probably not the latest. Would be nice if there was a description of dependencies for compiling on mac :).

https://github.com/ilia3101/MLV-App
See the readme, all neccessairy information should be there.

Quote from: Danne on November 05, 2017, 04:52:47 PM
The tblend filter can be applied to any footage but will only be useful when used with hdr material. Averaging filter will create ghosting so 48, 50 or 60 fps is better to use as opposed to slower fps.
So if I test with a hdr mlv with my 5D2, it will be 25fps out of the cam. I export to 12.5fps then?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on November 05, 2017, 06:08:24 PM
It will still be 25fps. Averaging consecutive frames retains original fps so just export as usual.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on November 05, 2017, 06:48:19 PM
Damn. I've been struggling looking for a stable workflow. I aldready lost so much footage going back and forth between mlvdump, mlvp, resolve or converters. I'm trying this one now. Hope it sorts me out. Thanks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 05, 2017, 07:07:45 PM
Quote from: Danne on November 05, 2017, 09:33:13 AM
-vf tblend=all_mode=average

Unfortunately that does not work for piped output:

Option vf (set video filters) cannot be applied to input url - -- you are trying to apply an input option to an output file or vice versa. Move this option before the file it belongs to.
Error parsing options for input file -.
Error opening input files: Invalid argument


"-" is the pipe and ffmpeg can't parse the input before it is created. Any ideas?

Edit: okay okay... I have to set it at the end of the command. Then it works fine. But one problem is: you never get what you see... :-(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on November 05, 2017, 07:30:35 PM
Why? Isn't the piping working the same for prores previewer? I used to preview by piping to ffplay in Switch...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 05, 2017, 07:43:45 PM
Works... I made a mistake: I have to set it at the end of the command. Then it works fine. But one problem is: you never get what you see... :-(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on November 05, 2017, 07:50:36 PM
What do you mean? What do you get, what do you see?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 05, 2017, 07:55:58 PM
I see a processed picture in MLV App, and I get a processed + averaged picture on output. I think it might be better to implement this averaging in MLV App, then you can see what you get.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 10, 2017, 09:58:18 PM
I uploaded a new version of MLV App - v0.10 alpha.
- chroma blur --> use it to blur moiree and/or noise
- 2 different sharpeners: RGB and Luma
- rendering is now done in a render thread --> so the GUI is much more responsive, also while playback
- audio problems on Linux (hopefully) fixed
- new "Edit" sidebar with collapsable group boxes instead of tabs
- new UI for "RAW Correction" with button groups
- many bugfixes

(https://image.ibb.co/jp5BVm/Bildschirmfoto.png)

Problems:
- maybe still some small audio issues?! (hopefully not)
- sometimes instability when caching is enabled and clip is switched
- caching crashes app (Windows 32bit version)

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.10alpha

There is no Linux version uploaded... so Linux users: please compile it... :)
@bouncyball: could you again please upload a Win64 version? Thx!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on November 11, 2017, 12:20:43 AM
Hi, Masc. This app really is starting to become fully featured, excellent. Been testing out this new alpha 0.10 version, first bug report is that when using chroma blur radius it crashes the app everytime, (only managed to get away with using it once without the app crashing) using macOS High sierra 10.13
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on November 11, 2017, 01:44:27 AM
Thanks for your working, this is a really useful app. I use this app to decode dual iso video, but one question puzzles me. If I set the original iso higher than recovery iso, the image will be broken, otherwise it works good.(for example 1600/100 setting will result in a strange image) What did i miss?

Sorry for my english, hoping it won't bother you.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on November 11, 2017, 09:33:52 AM
Quote from: Doofii on November 11, 2017, 01:44:27 AM
(for example 1600/100 setting will result in a strange image) What did i miss?
Try this MLV of yours with classic cr2hdr command line utility from a1ex. I think the result will be the same strange image because base iso should be smaller than recovery iso. That is how it designed to work.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 11, 2017, 10:46:16 AM
Quote from: Wayne H on November 11, 2017, 12:20:43 AM
Hi, Masc. This app really is starting to become fully featured, excellent. Been testing out this new alpha 0.10 version, first bug report is that when using chroma blur radius it crashes the app everytime, (only managed to get away with using it once without the app crashing) using macOS High sierra 10.13
Thx. And thanks for testing! macOS 10.13 I could not test. It works well on 10.9 & 10.11, Win7, Win8.1 and some Linux. Ilia should also have a 10.13, maybe he has same problems in cocoa version of the app and can debug?!
Does your 10.13 show a crash report? This would be interesting...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on November 11, 2017, 11:01:11 AM
Tested chroma blur on 10.13, didn't crash or do anything weird. Crash report would be good.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on November 11, 2017, 11:23:12 AM
Hi Masc & illia here are the crash reports as requested.    Crash report (App crashes when using the Chroma blur radius)

https://www.dropbox.com/s/ivn99gq4vrd0gpi/MLV%20APP%20crash%20report.rtf?dl=0


Crash report (App Crashes then importing a large amount of files)

https://www.dropbox.com/s/hfg5lje7ghi5te3/MLV%20APP%20crash%20report%2C%20%28crashes%20on%20import%20a%20large%20amount%20of%20files.rtf?dl=0
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 11, 2017, 12:54:02 PM
Thank you!
First one crashes in applyProcessingObject(), called from getMlvProcessedFrame8(), called from our renderThread.
Second one crashes in getMlvRawFrameFloat().
Does first one happen with special files or always? Could you upload some frames (short mlv) for us?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on November 11, 2017, 02:56:37 PM
Quote from: bouncyball on November 11, 2017, 09:33:52 AM
Try this MLV of yours with classic cr2hdr command line utility from a1ex. I think the result will be the same strange image because base iso should be smaller than recovery iso. That is how it designed to work.
Thanks for your reply. Will you consider adding an export mode to export DNG sequences? Because ACR has lens profiles and AE can export videos in many other formats. Think of it as a suggestion.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on November 11, 2017, 03:27:48 PM
Quote from: Doofii on November 11, 2017, 02:56:37 PM
Think of it as a suggestion.
I already thought about it here (https://github.com/ilia3101/MLV-App/issues/28). Just had no enough time yet.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on November 11, 2017, 04:15:46 PM
Of course lovely Mlv app should have cDNG support. All for it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on November 11, 2017, 05:32:38 PM
Hi masc, All the MLV files where shot in 11-8bit lossless, currently i'm away untill monday, My camera and cards are at home, but when i return i will upload a small MLV file. Many thanks wayne.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on November 13, 2017, 11:37:41 AM
Hi Masc, here's the smallest file i could find that crashes the app, (repeatable crashes when loaded into sessions with other clips and using the chroma blur radius) https://www.dropbox.com/s/jj125nr36wbul8i/M31-0921.MLV?dl=0 The app crashes with other much larger clips too. All shot on 5d3, 1.2.3 Crop mode 3520 x 1320 11-8bit lossless. hope this helps, thanks wayne
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 13, 2017, 12:53:46 PM
Hi Wayne, thanks! Great, it crashes for me too with this file (Great?! LOL)
@Ilia: could you download the file and have look too? My debugger tells raw_processing.c, line 274.
Edit: changing this line to sum += row[MIN(x+radius_x+3,limit_x)]; solves the problem for me. Would that be okay, Ilia? Should the other lines in these three for()... also be limited?
Or before
for (int32_t x = radius_x; x < (limit_x-radius_x-3); x+=3)
also does the job...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on November 13, 2017, 11:03:23 PM
Thanks masc 4 the debugger info. I'll download the file and have a test.
EDIT: saw you had a couple solutions, will check both and make sure they're 100% ok (I feel there might be one issue)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on November 13, 2017, 11:20:44 PM
First solution causes slowdown because adding MIN/MAX macro in the middle of a long long loop that only needs it for edge case.
Maybe not noticeable but I worked to remove such things. Also might end up subtracting a few incorrect pixels for the blur.
Second solution caused big colourful noticeable artifact on right edge of picture.

Try out changing line 253 to:
int32_t limit_x = (imageX-radius-1)*3;

To be honest, I couldn't get it to crash, and still haven't been able to compile Qt app. But I think this should stop it going past the edge without causing other problems.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 14, 2017, 08:24:00 AM
With the MLV from Wayne H it crashes for me... but only with this file, but also with the cocoa version. I'll try that out! Thx.
Works for me without crash. But won't that give a problem with lines 277 and following?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on November 14, 2017, 12:42:45 PM
Weird.. I used the same file from WayneH.
But won't that give a problem with lines 277 and following?
It only changes how far the 'fast' part of the code goes, as I assume it must have been going past the edge due to the lack of MIN/MAX protection. Shouldn't affect image at all.

Also tried with Qt App v0.10, still didn't crash.
I am using a 'beta' version of next macOS 10.13 update (can't figure out how to get out of the beta programme), so it's a little ahead of the rest of 10.13s in the world. Could be something to do with that.

So my solution did fix it? If it's all fine commit it :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 14, 2017, 08:46:10 PM
Commited to the repos. @Wayne: in the next release you can try again. Or you try to compile yourself (don't know if it is fun for you).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on November 17, 2017, 06:41:48 PM
Thank you Masc & Illia, think i'll wait for the new version rather than compile tho, (not so much fun, confusing lol) + something to look forward too, haha, on the post production side, xmas 2017 is going rather fun, the soon to be released FCPX 10.4 with new colour tool goodies + i'm hoping a new version of this great app too, also potentially with new goodies, :) fingers crossed. lol

I'm really really impressed with this app, i'm curious to know what other feature's and option's you have planned for future releases (roadmap) lol?

One side note, the dual ISO feature, i've tested this, Loaded dual ISO file (11-8bit lossless), raw corrections D_ISO enabled, everything is fine lines gone etc, However once i click on export, the alternating lines re-appear, and the final exported dual iso file is with the line's, exported un proccessed it would seem, i'm not sure whether you guy's are aware of this, or whether the dual iso feature is a work in progress, just thought i'd share my experiance with using it,

AGAIN, GREAT WORK GUYS, Masc, llia, Bouncyball, Danne and anyone else who has contributed to this app,

Thanks Wayne.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on November 18, 2017, 10:12:56 AM
Thanks for kind words :)

Quote from: Wayne H on November 17, 2017, 06:41:48 PM
once i click on export, the alternating lines re-appear, and the final exported dual iso file is with the line's, exported un proccessed it would seem, i'm not sure whether you guy's are aware of this, or whether the dual iso feature is a work in progress, just thought i'd share my experiance with using it,
Here, just a plain uncompressed dual iso mlv exports w/o problem. I never tried to do this with losless MLV though. Can you cut short clip of your mlv and post somewhere to test?

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 18, 2017, 05:23:30 PM
Thank you Wayne! ;)
Yes, I can understand, if you don't like to compile yourself. There are already some new features & fixes ready (receipt import/export) and some other ones are in the pipeline (better sync between audio&video, AVFoundation export on OSX,... for example). You won't have to wait until xmas for v0.11 ;-) When there is a revsision, which is not to buggy, it will be this version  :P
The enhancements and fixes where we are working on and which we are planning can be seen in the issue page of github: https://github.com/ilia3101/MLV-App/issues (https://github.com/ilia3101/MLV-App/issues)
Dual ISO should be ready, but there may be always some bugs. Sorry for that. As bouncyball wrote: please upload a short file on which you have problems and we will try to solve the bugs!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 21, 2017, 08:51:49 AM
Quote from: Wayne H on November 17, 2017, 06:41:48 PM
One side note, the dual ISO feature, i've tested this, Loaded dual ISO file (11-8bit lossless), raw corrections D_ISO enabled, everything is fine lines gone etc, However once i click on export, the alternating lines re-appear, and the final exported dual iso file is with the line's, exported un proccessed it would seem, i'm not sure whether you guy's are aware of this, or whether the dual iso feature is a work in progress, just thought i'd share my experiance with using it,

I think I also found this one. All RAW corrections settings were at default when exporting. In many clips we did not see this error. But now I had the same with bad pixels... :-D
Bouncyball implemented Cinema DNG export. We need some more testing and then I think it is time for v0.11...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 22, 2017, 04:38:24 PM
We are indeed a little proud to present our new release MLV App v0.11!

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.11alpha

New in this release:
- better (corrected) AMaZE, artefacts are minimized to a minimum. Thanks to a1ex, giving Ilia the right input for this correction!
- Cinema DNG export (uncompressed, lossless & fast pass), first two also working with dual iso 20bit->16bit
- H.264 & H.265 export
- receipt file import / export
- many fixes and detail enhancements

Windows version is on the way...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on November 22, 2017, 04:48:29 PM
Great! You guys are quicker in developing, than I can test :)

One small question for cdng-export:
Processing and Y/CR-separation doesn´t affect the exported dngs. Is this correct?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 22, 2017, 04:55:28 PM
CDNG is Raw, so no processing is done. Just RAW corrections are done for uncompressed and lossless.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on November 22, 2017, 04:59:45 PM
thanks for clarifying
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on November 22, 2017, 06:03:40 PM
The AMaZE demosaic quality has massively improved:

(http://image.ibb.co/j2KFiR/old.png) (http://image.ibb.co/h1FMOR/fixed.png)

(Guess what's before and what's after ;) )

And of course thanks a lot a1ex
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on November 22, 2017, 06:06:37 PM
Can not upload win64 build. It crashes when exporting DNGs. Does 32 bit build work as expected?

Edit: nope :P it crashes too. Will check tomorrow.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on November 22, 2017, 06:20:01 PM
Now that's amaze @Ilia :D.
Great that you implemented cdng support mr B.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 22, 2017, 06:33:10 PM
Quote from: bouncyball on November 22, 2017, 06:06:37 PM
Can not upload win64 build. It crashes when exporting DNGs. Does 32 bit build work as expected?

Edit: nope :P it crashes too. Will check tomorrow.
Woah... (nearly) always the Windows version which makes unexpected things... :P
Title: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 23, 2017, 03:00:18 AM
Quote from: Danne on November 22, 2017, 06:20:01 PM
Now that's amaze @Ilia [emoji2].
Great that you implemented cdng support mr B.

Indeed amazing @Ilia3101 and also thanks for implementing cdng support @bouncyball!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on November 23, 2017, 10:00:49 AM
Now DNG export is fixed on Win32/64 and both working builds are uploaded. Link (https://github.com/ilia3101/MLV-App/releases/tag/QTv0.11alpha)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: noir on November 23, 2017, 11:21:30 AM
Wow, nice progress!

By the way, now that Cineform is open source, are you considering implementing Cineform RAW output?

IIRC, it has a 5:1 or so lossy wavelet compression, which would make working with RAW files very easy.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on November 23, 2017, 06:33:27 PM
Well, I love cineform and use it in premiere and resolve exclusively because I'm not a mac guy and lacking prores in windows, but think it is not on the top of our priority list and we'll wait for implementing it officially to the ffmpeg (at the moment ffmpeg supports only decoding of some cineform footage based on reversed engineered codec)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: noir on November 24, 2017, 09:33:34 AM
Understandable.

Thanks for considering it :)
Looking forward to the ffmpeg implementation as well
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on November 28, 2017, 03:15:29 PM
Hi guys. Dayum you have all been busy, seems like a really nice solid update, i will do some stress tests over the week and report back any bugs, Happy to report no crashes from the previous issues i reported :)

It looks like you all have implemented some sort of new debayering, the results are stunning with 3584x1320 crop footage, (previously some shots would exhibit some nasty aliasing and moire. In conjunction with the alexa log c profile, and sharpening.. the gradabilty within FCPX is a joy, that log profile makes matching scenes effortless, saves a whole heap of time, and seems to nullify a ton of noise too.

Excellent progress Ilia, Masc, Bouncyball, this app really is coming along nicely. I LOVE IT :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 28, 2017, 10:22:41 PM
Thank you for your nice words and for testing!  8)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on November 29, 2017, 12:27:01 AM
Anyone know the optimal Deflicker target when working with dual ISO files with this app?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: smasry on November 29, 2017, 02:09:44 AM
I second that @Wayne H, I just came over from the cr2hdr thread.

I tried a few random numbers in the 'Deflicker target' box, and can clearly see that the footage overall is darkened for raised values, however the flicker is still there. I can't find any documentation in your source code for this function, and would like to know how to determine the 'best' values to try, or what values have shown themselves as most effective?

Thanks
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on November 29, 2017, 02:12:17 PM
Deflicker feature is taken from MLVFS as is, If it worked there it should work here, but if not... then we have to ask dmilligan how to use it :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: a1ex on November 29, 2017, 02:36:54 PM
https://www.magiclantern.fm/forum/index.php?topic=12585.0
https://www.magiclantern.fm/forum/index.php?topic=8443.msg174075#msg174075 (images no longer valid, unfortunately)

The target level is just exposure compensation (how bright you want the result to be).

The debug screen from Auto ETTR tells you where the median falls on the image. If the median falls right on the line between "bright" and "dark" in your scene (e.g. the sky line is right in the middle of the image), then you'll have to use a different percentile (e.g. 75% to keep the sky flicker-free, or 25% to keep the buildings - or whatever is darker in your image - flicker-free); otherwise, median should be fine in most cases. TODO: experiment with trimmed mean (https://en.wikipedia.org/wiki/Truncated_mean).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: SirWhiteFox on November 29, 2017, 11:29:45 PM
Quote from: masc on November 22, 2017, 04:38:24 PM
We are indeed a little proud to present our new release MLV App v0.11!

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.11alpha

New in this release:
- better (corrected) AMaZE, artefacts are minimized to a minimum. Thanks to a1ex, giving Ilia the right input for this correction!
- Cinema DNG export (uncompressed, lossless & fast pass), first two also working with dual iso 20bit->16bit
- H.264 & H.265 export
- receipt file import / export
- many fixes and detail enhancements

Windows version is on the way...


This is by far the best MLV App created... Thx!!!  8)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on November 30, 2017, 09:13:31 AM
Hello to everybody! :)
How can we add aspect ratio to the menu?

That way we can see properly anamorphic footage.


(https://thumb.ibb.co/gkM8Cw/Screen_Shot_2017_11_30_at_10_08_20_AM.png) (https://ibb.co/gkM8Cw)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on November 30, 2017, 02:44:26 PM
@SirWhiteFox: Thx!  8)
@OlegK: I already thought about that. Stretching the picture is possible in principle. But we plan some other new features - and they in combination with stretching will cause some problems... Maybe it will be possible one day. What already works in the latest revision on the repos and in the next release: resizing video on export to a desired resolution.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on November 30, 2017, 08:20:18 PM
Wow Good news! Only on export? or preview too? much easier look at correct picture while working on coloring  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 01, 2017, 07:31:57 PM
Now I added this feature to the repos. It will be availlable in the next release, or you compile yourself.
You can now stretch the height by any factor. One planned feature is partially broken with that and I don't know how to fix atm... a lot of math is required by such an "easy" feature :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 01, 2017, 07:45:04 PM
Thanks a lot! :D
How I do it by myself?

Copy & paste code?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 01, 2017, 09:01:10 PM
Check out latest revision and compile as described.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 01, 2017, 09:07:30 PM
Cannot find it :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 01, 2017, 09:09:44 PM
The Link is also in the first post of this thread:
https://github.com/ilia3101/MLV-App
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 01, 2017, 09:12:29 PM
Quote from: OlegK on December 01, 2017, 09:07:30 PM
Cannot find it :(


https://github.com/ilia3101/MLV-App/commit/40b764610c979ba5d0175ae52a11734a5aca5672#diff-dc9439299160bd6fbdf881ff0355be17



Ok I found them> where I should paste all this text? or what I should do?
Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 01, 2017, 09:21:41 PM
???What do you want to paste???
There is a download button on the first page - the link I wrote. With that you'll get the sources. Also on the page is a short howto compile. But you'll need the whole development environment.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 01, 2017, 09:27:31 PM
I don't think I will be able to do it:(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 01, 2017, 09:40:58 PM
Then I recommend to wait for the next release... maybe in 1-2 week(s).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Lars Steenhoff on December 01, 2017, 10:40:04 PM
I hope the native osx app will be getting a new build also ( cocoa )
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 01, 2017, 10:47:05 PM
I think there will come an update. Ilia is busy in making it better too.
Note: Qt uses also cocoa and the same compilers on OSX.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 01, 2017, 11:54:21 PM
Quote from: masc on December 01, 2017, 10:47:05 PM
I think there will come an update. Ilia is busy in making it better too.
Note: Qt uses also cocoa and the same compilers on OSX.

Cocoa looks better to me, But so glitchy. Not working.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on December 02, 2017, 12:09:11 AM
Yeah, Cocoa app is not the "main" or "official" GUI, and probably won't be, I simply use it for writing the processing and MLV code because it's easier for me(and anyone wanting to test) to compile, but I have been improving it lately... it will have sessions and AVFoundation in next release (Yo @martinherring, how do you append a 16bit buffer to an AVAsset :D).

To compile Cocoa app, all you need is this one terminal command:
rm -rf MLV-App && xcode-select --install || git clone https://github.com/ilia3101/MLV-App.git && cd MLV-App/platform/cocoa && make app -j4 && rm *.o && open ./
When it finishes, the folder with compiled app will open up.

If you don't have apple developer tools, macos will create a pop up saying "install software", just click ok and wait a minute or two for it to install compilers and git (it's a really small download).
Although, I'm not sure if at this moment it works on < macOS 10.13

QuoteCocoa looks better to me, But so glitchy. Not working.
What's glitchy?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 02, 2017, 09:40:40 AM
import and sliders not working
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 02, 2017, 10:20:09 AM
If you post problems, please write a bit more than "not working". Which exact version do you use, which OS, what special kind of MLV is it, what did you exactly do to come to the problem? Import and sliders for standard MLV were working in each of my tests in both - cocoa and Qt version.

@Ilia: on 10.9 it does not compile (since first revision), on 10.11 all is fine.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: lordwilli on December 02, 2017, 06:14:34 PM
Could you please give another download link than github.com? it takes 6 kb/s i can't even download it
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on December 03, 2017, 10:45:34 PM
I love the new 16bit-tiff-export  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 04, 2017, 01:01:35 AM
 :)ask a question, will this app support HDR video processing?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 04, 2017, 08:28:11 PM
Quote from: masc on December 02, 2017, 10:20:09 AM
If you post problems, please write a bit more than "not working". Which exact version do you use, which OS, what special kind of MLV is it, what did you exactly do to come to the problem? Import and sliders for standard MLV were working in each of my tests in both - cocoa and Qt version.

@Ilia: on 10.9 it does not compile (since first revision), on 10.11 all is fine.

Ok! I am using Cocoa latest
(https://thumb.ibb.co/dFr30G/Screen_Shot_2017_12_04_at_9_18_16_PM.png) (https://ibb.co/dFr30G)


on a
(https://thumb.ibb.co/ePb30G/Screen_Shot_2017_12_04_at_9_17_13_PM.png) (https://ibb.co/ePb30G)


First problem I experiencing is:
When I add MLV file to program it doesn't show them in window,I CAN ADD ONE FILE ONLY,when I add one or more, the first one disappearing.
Notice windows where files should be empty, even one file added I cannot see it
(https://thumb.ibb.co/bvySSw/Screen_Shot_2017_12_04_at_9_21_15_PM.png) (https://ibb.co/bvySSw)


2nd. There is no option settings in this version, No settings I can change, can only export Prores4444
(https://thumb.ibb.co/i80Sub/Screen_Shot_2017_12_04_at_9_23_35_PM.png) (https://ibb.co/i80Sub)


3rd. cannot play the file, when press spacebar. it doesn't play at all.

4st. No zoom Button.

I like Footage program its so simple u don't need to save or load the files they are alway there u can delete them if u don't use them.

(https://thumb.ibb.co/h5Enub/Screen_Shot_2017_12_04_at_9_31_13_PM.png) (https://ibb.co/h5Enub)

upload my photo (https://imgbb.com/)


Its easy but no Batch export, playback not working, and Quality is not good.

Also like Information on the button, and aspect ration options
(https://thumb.ibb.co/e0bHub/Screen_Shot_2017_12_04_at_9_36_08_PM.png) (https://ibb.co/e0bHub)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 04, 2017, 09:37:48 PM
Ok. Now I can answer.
1. Sessions are not yet implemented for cocoa app. It is on its way.
2. Cocoa app can only export ProRes 4444, other codecs will be implemented here
3. Cocoa app has no playback, maybe Ilia will implement this in the future
4. Cocoa app has no zoom, maybe Ilia will implement this in the future

If you like to have this features now, simple use the Qt OSX version. The cocoa version is Ilias test app, to test new features in the decoding and processing library in the background easily. Therefor the cocoa version maybe a little faster here and there and compiles fast without all the chichi.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 05, 2017, 12:13:49 AM
Quote from: masc on December 04, 2017, 09:37:48 PM
Ok. Now I can answer.
1. Sessions are not yet implemented for cocoa app. It is on its way.
2. Cocoa app can only export ProRes 4444, other codecs will be implemented here
3. Cocoa app has no playback, maybe Ilia will implement this in the future
4. Cocoa app has no zoom, maybe Ilia will implement this in the future

If you like to have this features now, simple use the Qt OSX version. The cocoa version is Ilias test app, to test new features in the decoding and processing library in the background easily. Therefor the cocoa version maybe a little faster here and there and compiles fast without all the chichi.


Thank you Masc!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 11:15:49 AM
After I tried Latest Cocoa, then deleted and now my QT not working at all. Always crashing:(
From console:
Failed to start process notifications for pid 870 (16)


Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 06, 2017, 12:06:34 PM
The 2 apps are 100% independent in terms of processes. You can install cocoa and delete as often you want and the Qt version won't recognize it. I think you made a mistake here... maybe you try to start the app in the trash or something like that.
And you start the Qt version from console?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 01:34:41 PM
Quote from: masc on December 06, 2017, 12:06:34 PM
The 2 apps are 100% independent in terms of processes. You can install cocoa and delete as often you want and the Qt version won't recognize it. I think you made a mistake here... maybe you try to start the app in the trash or something like that.
And you start the Qt version from console?

From Application folder>(

What it can be? I don't know!

Its crash on opening, exporting, pasting settings.

Can you help me with this?
Thanks`!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 02:24:00 PM
Quote from: masc on December 06, 2017, 12:06:34 PM
The 2 apps are 100% independent in terms of processes. You can install cocoa and delete as often you want and the Qt version won't recognize it. I think you made a mistake here... maybe you try to start the app in the trash or something like that.
And you start the Qt version from console?

What should I do? The program worked before just fine?

Maybe trash preferences?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 06, 2017, 05:01:36 PM
I am sorry, but here I can't help. I compiled, copied and deleted MLV App thousand times, and never had an issue like that.
What I can tell you: "Failed to start process notifications for pid 870 (16)" comes not from MLV App, this comes from OSX (google tells).
But here you must solve the problem yourself, or anyone else can help you with that. If you have a solution, I would be very interested!
Is there a crash report maybe?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 05:53:34 PM
Quote from: masc on December 06, 2017, 05:01:36 PM
I am sorry, but here I can't help. I compiled, copied and deleted MLV App thousand times, and never had an issue like that.
What I can tell you: "Failed to start process notifications for pid 870 (16)" comes not from MLV App, this comes from OSX (google tells).
But here you must solve the problem yourself, or anyone else can help you with that. If you have a solution, I would be very interested!
Is there a crash report maybe?

Date/Time:       2017-12-06 16:27:52.646163 +0200
OS Version:      Mac OS X 10.12.6 (Build 16G29)
Architecture:    x86_64
Report Version:  19

Command:         MLV App
Path:            /Applications/MLV App.app/Contents/MacOS/MLV App
Version:         0.11 alpha (???)
Parent:          launchd [1]
PID:             1424

Event:           wakeups
Wakeups:         45024 wakeups over the last 76 seconds (594 wakeups per second average), exceeding limit of 150 wakeups per second over 300 seconds
Duration:        75.73s
Steps:           28

Hardware model:  iMac14,2
Active cpus:     8


Powerstats for:  MLV App [1424]
UUID:            60C9EA13-6340-310C-9220-DF5B4728C71E
Start time:      2017-12-06 16:27:53 +0200
End time:        2017-12-06 16:29:03 +0200
Microstackshots: 28 samples (100%)
Primary state:   12 samples Frontmost App, User mode, Effective Thread QoS User Interactive, Requested Thread QoS User Interactive, Override Thread QoS Unspecified
User Activity:   0 samples Idle, 28 samples Active
Power Source:    0 samples on Battery, 28 samples on AC
  14 start + 1 (libdyld.dylib) [0x7fff916f7235]
    12 main + 107 (MLV App) [0x10d04850b]
      12 QCoreApplication::exec() + 341 (QtCore) [0x1106ad115]
        12 QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) + 401 (QtCore) [0x1106a8eb1]
          12 ??? (libqcocoa.dylib + 156991) [0x11300e53f]
            12 -[NSApplication run] + 926 (AppKit) [0x7fff79a5c3db]
              12 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796 (AppKit) [0x7fff7a1e37ee]
                12 _DPSNextEvent + 1120 (AppKit) [0x7fff79a67a54]
                  12 _BlockUntilNextEventMatchingListInModeWithFilter + 71 (HIToolbox) [0x7fff7b4ceb26]
                    9  ReceiveNextEventCommon + 184 (HIToolbox) [0x7fff7b4cebf9]
                      9  RunCurrentEventLoopInMode + 240 (HIToolbox) [0x7fff7b4ceebc]
                        9  CFRunLoopRunSpecific + 420 (CoreFoundation) [0x7fff7bf6e114]
                          9  __CFRunLoopRun + 934 (CoreFoundation) [0x7fff7bf6e716]
                            9  __CFRunLoopDoSources0 + 557 (CoreFoundation) [0x7fff7bf6f21d]
                              9  __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 (CoreFoundation) [0x7fff7bf8e321]
                                9  ??? (libqcocoa.dylib + 161329) [0x11300f631]
                                  9  QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) + 155 (QtGui) [0x110aa206b]
                                    9  QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) + 2794 (QtGui) [0x110ab888a]
                                      9  QCoreApplication::notifyInternal2(QObject*, QEvent*) + 164 (QtCore) [0x1106acaa4]
                                        9  QApplication::notify(QObject*, QEvent*) + 5906 (QtWidgets) [0x110ff9822]
                                          9  QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269 (QtWidgets) [0x110ff6edd]
                                            9  ??? (QtWidgets + 464319) [0x1110565bf]
                                              9  ??? (QtWidgets + 468267) [0x11105752b]
                                                9  QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool) + 871 (QtWidgets) [0x110ff7847]
                                                  9  QCoreApplication::notifyInternal2(QObject*, QEvent*) + 164 (QtCore) [0x1106acaa4]
                                                    9  QApplication::notify(QObject*, QEvent*) + 9440 (QtWidgets) [0x110ffa5f0]
                                                      9  QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269 (QtWidgets) [0x110ff6edd]
                                                        9  QToolButton::event(QEvent*) + 323 (QtWidgets) [0x1111bbef3]
                                                          9  QAbstractButton::event(QEvent*) + 175 (QtWidgets) [0x1110e64ff]
                                                            9  QWidget::event(QEvent*) + 1681 (QtWidgets) [0x111036cc1]
                                                              9  QToolButton::mouseReleaseEvent(QMouseEvent*) + 15 (QtWidgets) [0x1111bb93f]
                                                                9  QAbstractButton::mouseReleaseEvent(QMouseEvent*) + 270 (QtWidgets) [0x1110e67ae]
                                                                  9  ??? (QtWidgets + 1050184) [0x1110e5648]
                                                                    9  QAction::activate(QAction::ActionEvent) + 303 (QtWidgets) [0x110fede4f]
                                                                      9  QMetaObject::activate(QObject*, int, int, void**) + 2027 (QtCore) [0x1106ddd9b]
                                                                        9  MainWindow::qt_metacall(QMetaObject::Call, int, void**) + 80 (MLV App) [0x10d0a8d70]
                                                                          4  MainWindow::on_actionExport_triggered() + 2043 (MLV App) [0x10d060c7b]
                                                                            4  QFileDialog::getSaveFileName(QWidget*, QString const&, QString const&, QString const&, QString*, QFlags<QFileDialog::Option>) + 260 (QtWidgets) [0x111205b74]
                                                                              4  QFileDialog::getSaveFileUrl(QWidget*, QString const&, QUrl const&, QString const&, QString*, QFlags<QFileDialog::Option>, QStringList const&) + 377 (QtWidgets) [0x111205db9]
                                                                                4  QDialog::exec() + 284 (QtWidgets) [0x1111f51dc]
                                                                                  4  ??? (libqcocoa.dylib + 269411) [0x113029c63]
                                                                                    4  ??? (libqcocoa.dylib + 253990) [0x113026026]
                                                                                      4  -[NSSavePanel runModal] + 629 (AppKit) [0x7fff7a16af48]
                                                                                        4  -[NSApplication runModalForWindow:] + 137 (AppKit) [0x7fff79cbbb98]
                                                                                          4  __35-[NSApplication runModalForWindow:]_block_invoke + 64 (AppKit) [0x7fff79e9e374]
                                                                                            4  -[NSApplication _doModalLoop:peek:] + 497 (AppKit) [0x7fff79cbe0b6]
                                                                                              4  -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796 (AppKit) [0x7fff7a1e37ee]
                                                                                                4  _DPSNextEvent + 1120 (AppKit) [0x7fff79a67a54]
                                                                                                  4  _BlockUntilNextEventMatchingListInModeWithFilter + 71 (HIToolbox) [0x7fff7b4ceb26]
                                                                                                    4  ReceiveNextEventCommon + 432 (HIToolbox) [0x7fff7b4cecf1]
                                                                                                      4  RunCurrentEventLoopInMode + 240 (HIToolbox) [0x7fff7b4ceebc]
                                                                                                        4  CFRunLoopRunSpecific + 420 (CoreFoundation) [0x7fff7bf6e114]
                                                                                                          4  __CFRunLoopRun + 2065 (CoreFoundation) [0x7fff7bf6eb81]
                                                                                                            4  __CFRunLoopDoTimers + 177 (CoreFoundation) [0x7fff7bf773c1]
                                                                                                              2  CFArrayCreateMutable + 27 (CoreFoundation) [0x7fff7bf0c9bb]
                                                                                                              1  objc_msgSend + 33 (libobjc.A.dylib) [0x7fff90e03061]
                                                                                                              1  objc_msgSend + 26 (libobjc.A.dylib) [0x7fff90e0305a]
                                                                          3  MainWindow::on_actionExport_triggered() + 3435 (MLV App) [0x10d0611eb]
                                                                            3  MainWindow::exportHandler() + 1988 (MLV App) [0x10d061f74]
                                                                              3  MainWindow::startExportPipe(QString) + 5244 (MLV App) [0x10d052f2c]
                                                                                3  getMlvProcessedFrame16 + 100 (MLV App) [0x10d083394]
                                                                                  2  applyProcessingObject + 326 (MLV App) [0x10d090276]
                                                                                  1  applyProcessingObject + 126 (MLV App) [0x10d0901ae]
                                                                          1  MainWindow::on_actionExportSettings_triggered() + 111 (MLV App) [0x10d062d4f]
                                                                            1  ExportSettingsDialog::ExportSettingsDialog(QWidget*, unsigned char, unsigned char, unsigned char, bool, double, bool, int) + 35 (MLV App) [0x10d0a0803]
                                                                              1  ExportSettingsDialog::ExportSettingsDialog(QWidget*, unsigned char, unsigned char, unsigned char, bool, double, bool, int) + 110 (MLV App) [0x10d09fdbe]
                                                                                1  QWidgetPrivate::setWindowFlags(QFlags<Qt::WindowType>) + 162 (QtWidgets) [0x111039002]
                                                                                  1  QWidget::setParent(QWidget*, QFlags<Qt::WindowType>) + 1823 (QtWidgets) [0x111024d0f]
                                                                                    1  QWidgetPrivate::inheritStyle() + 515 (QtWidgets) [0x111029a83]
                                                                                      1  QWidgetPrivate::setStyle_helper(QStyle*, bool, bool) + 673 (QtWidgets) [0x111029d81]
                                                                                        1  QWidgetPrivate::inheritStyle() + 515 (QtWidgets) [0x111029a83]
                                                                                          1  QWidgetPrivate::setStyle_helper(QStyle*, bool, bool) + 673 (QtWidgets) [0x111029d81]
                                                                                            1  QWidgetPrivate::inheritStyle() + 515 (QtWidgets) [0x111029a83]
                                                                                              1  QWidgetPrivate::setStyle_helper(QStyle*, bool, bool) + 831 (QtWidgets) [0x111029e1f]
                                                                                                1  QCoreApplication::notifyInternal2(QObject*, QEvent*) + 164 (QtCore) [0x1106acaa4]
                                                                                                  1  QApplication::notify(QObject*, QEvent*) + 5906 (QtWidgets) [0x110ff9822]
                                                                                                    1  QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269 (QtWidgets) [0x110ff6edd]
                                                                                                      1  QComboBox::event(QEvent*) + 403 (QtWidgets) [0x1111049c3]
                                                                                                        1  QWidget::event(QEvent*) + 4494 (QtWidgets) [0x1110377be]
                                                                                                          1  QComboBox::changeEvent(QEvent*) + 202 (QtWidgets) [0x1111045aa]
                                                                                                            1  ??? (QtWidgets + 1154536) [0x1110fede8]
                                                                                                              1  ??? (QtWidgets + 1145340) [0x1110fc9fc]
                                                                                                                1  QListView::QListView(QWidget*) + 291 (QtWidgets) [0x111282bf3]
                                                                                                                  1  QAbstractItemView::QAbstractItemView(QAbstractItemViewPrivate&, QWidget*) + 14 (QtWidgets) [0x1112613fe]
                                                                                                                    1  QAbstractScrollAreaPrivate::init() + 197 (QtWidgets) [0x1111bcf65]
                                                                                                                      1  ??? (QtWidgets + 1931469) [0x1111bc8cd]
                                                                                                                        1  ??? (QtWidgets + 1716838) [0x111188266]
                                                                                                                          1  ??? (QtWidgets + 809348) [0x1110aa984]
                                                                                                                            1  ??? (QtWidgets + 704841) [0x111091149]
                                                                                                                              1  ??? (QtWidgets + 731241) [0x111097869]
                                                                                                                                1  ??? (QtWidgets + 729621) [0x111097215]
                                                                                                                                  1  QCss::StyleSelector::styleRulesForNode(QCss::StyleSelector::NodePtr) + 1150 (QtGui) [0x110c3267e]
                                                                                                                                    1  QCss::StyleSelector::matchRule(QCss::StyleSelector::NodePtr, QCss::StyleRule const&, QCss::StyleSheetOrigin, int, QMap<unsigned int, QCss::StyleRule>*) + 49 (QtGui) [0x110c31e21]
                                                                          1  MainWindow::on_actionOpen_triggered() + 198 (MLV App) [0x10d04f986]
                                                                            1  QFileDialog::getOpenFileNames(QWidget*, QString const&, QString const&, QString const&, QString*, QFlags<QFileDialog::Option>) + 260 (QtWidgets) [0x111205544]
                                                                              1  QFileDialog::getOpenFileUrls(QWidget*, QString const&, QUrl const&, QString const&, QString*, QFlags<QFileDialog::Option>, QStringList const&) + 361 (QtWidgets) [0x1112058b9]
                                                                                1  QDialog::exec() + 284 (QtWidgets) [0x1111f51dc]
                                                                                  1  ??? (libqcocoa.dylib + 269411) [0x113029c63]
                                                                                    1  ??? (libqcocoa.dylib + 253990) [0x113026026]
                                                                                      1  -[NSSavePanel runModal] + 629 (AppKit) [0x7fff7a16af48]
                                                                                        1  -[NSApplication runModalForWindow:] + 137 (AppKit) [0x7fff79cbbb98]
                                                                                          1  __35-[NSApplication runModalForWindow:]_block_invoke + 64 (AppKit) [0x7fff79e9e374]
                                                                                            1  -[NSApplication _doModalLoop:peek:] + 497 (AppKit) [0x7fff79cbe0b6]
                                                                                              1  -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796 (AppKit) [0x7fff7a1e37ee]
                                                                                                1  _DPSNextEvent + 1120 (AppKit) [0x7fff79a67a54]
                                                                                                  1  _BlockUntilNextEventMatchingListInModeWithFilter + 71 (HIToolbox) [0x7fff7b4ceb26]
                                                                                                    1  ReceiveNextEventCommon + 184 (HIToolbox) [0x7fff7b4cebf9]
                                                                                                      1  RunCurrentEventLoopInMode + 240 (HIToolbox) [0x7fff7b4ceebc]
                                                                                                        1  CFRunLoopRunSpecific + 420 (CoreFoundation) [0x7fff7bf6e114]
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 05:58:53 PM
Process:               MLV App [1424]
Path:                  /Applications/MLV App.app/Contents/MacOS/MLV App
Identifier:            magiclantern.MLV App
Version:               0.11 alpha (0)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           MLV App [1424]
User ID:               501

Date/Time:             2017-12-06 18:50:53.896 +0200
OS Version:            Mac OS X 10.12.6 (16G29)
Report Version:        12
Anonymous UUID:        DB788A4A-4B40-04B1-85DC-5346F1362521


Time Awake Since Boot: 12000 seconds

System Integrity Protection: disabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x000000011c427000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 06, 2017, 07:21:45 PM
First one: I don't find a problem with MLV App.
Second one: The App had a problem with the file you imported. The file may be corrupted in some way. Here you could upload this particular file and we could try to debug.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 07:50:47 PM
only happens when I open two these file. if you open just one by one its not crashing.
One is 50fps another 24fps.

https://ufile.io/u8rq4
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 06, 2017, 09:44:41 PM
I now have downloaded your files. I tried out with the actual revision and v0.10. In v0.10 it crashes when switching between these files - so I can reproduce. The last days bouncyball, Ilia and me, we were searching many bugs and also found+fixed many bugs. Good news: with the latest revision it does not crash. The bad news: we still have some small bugs on the list to fix before we release next version.

Could you please tell me, which horizontal stretch factor is needed to have M06-1260 in the correct aspect ratio? In the actual revision I build a combobox where you can select 1.0x, 1.33x, 1.5x and 2.0x as factor. I am not sure if it is 1.5x, 2.0x or something between...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 10:18:03 PM
Quote from: masc on December 06, 2017, 09:44:41 PM
I now have downloaded your files. I tried out with the actual revision and v0.10. In v0.10 it crashes when switching between these files - so I can reproduce. The last days bouncyball, Ilia and me, we were searching many bugs and also found+fixed many bugs. Good news: with the latest revision it does not crash. The bad news: we still have some small bugs on the list to fix before we release next version.

Could you please tell me, which horizontal stretch factor is needed to have M06-1260 in the correct aspect ratio? In the actual revision I build a combobox where you can select 1.0x, 1.33x, 1.5x and 2.0x as factor. I am not sure if it is 1.5x, 2.0x or something between...

Thanks! when you releasing?

I think its 1,75X or 1,80x You can add both:)

Can you make stretch for each individual file? Will it work on export too?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: a1ex on December 06, 2017, 10:29:01 PM
Quote from: masc on December 06, 2017, 09:44:41 PM
Could you please tell me, which horizontal stretch factor is needed to have M06-1260 in the correct aspect ratio? In the actual revision I build a combobox where you can select 1.0x, 1.33x, 1.5x and 2.0x as factor. I am not sure if it is 1.5x, 2.0x or something between...

All MLV files from current and past ML builds*) have their pixel aspect ratio either 1:1 (square pixels) or 5:3 (requiring vertical stretch).

*) The only exception is if you have changed the line skipping register (http://www.magiclantern.fm/forum/index.php?topic=17021.msg165204#msg165204) with adtg_gui or similar.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 06, 2017, 10:32:05 PM
@a1ex: I think @OlegK uses a special lens for that...
@OlegK: 1.75x horizontal stretch looks right for my eyes. Yes, you can select the factor in the clip receipt now. So each clip can have another factor here. It is also exported with the factor (png & ffmpeg export, not dng). As I wrote, we still have some bugs to fix... when we have a solution here, we will make a release.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on December 06, 2017, 10:34:54 PM
Is it a combination of anamorphic and high framerate stretch? We also need to be able to handle that together with anamorphic. I think best way is to have anamorphic ratio options: 1.33, 1.5, 1.75, 2.0, and an On/Off for additional vertical 1.67x (5:3) stretch
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 11:21:51 PM
Quote from: masc on December 06, 2017, 10:32:05 PM
@a1ex: I think @OlegK uses a special lens for that...
@OlegK: 1.75x horizontal stretch looks right for my eyes. Yes, you can select the factor in the clip receipt now. So each clip can have another factor here. It is also exported with the factor (png & ffmpeg export, not dng). As I wrote, we still have some bugs to fix... when we have a solution here, we will make a release.

Thanks Man! :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 11:24:10 PM
Quote from: Ilia3101 on December 06, 2017, 10:34:54 PM
Is it a combination of anamorphic and high framerate stretch?

yes! i didn't touch it:)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 06, 2017, 11:44:07 PM
Quote from: Ilia3101 on December 06, 2017, 10:34:54 PM
Is it a combination of anamorphic and high framerate stretch? We also need to be able to handle that together with anamorphic. I think best way is to have anamorphic ratio options: 1.33, 1.5, 1.75, 2.0, and an On/Off for additional vertical 1.67x (5:3) stretch

If you can add 1.80X Would be cool! :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 07, 2017, 08:11:31 AM
Quote from: Ilia3101 on December 06, 2017, 10:34:54 PM
Is it a combination of anamorphic and high framerate stretch? We also need to be able to handle that together with anamorphic. I think best way is to have anamorphic ratio options: 1.33, 1.5, 1.75, 2.0, and an On/Off for additional vertical 1.67x (5:3) stretch
Exactly that I implemented.
Edit: 1.8x is added too.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 07, 2017, 02:00:27 PM
Quote from: masc on December 07, 2017, 08:11:31 AM
Exactly that I implemented.
Edit: 1.8x is added too.

Now I have to wait! ;D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 07, 2017, 04:23:49 PM
Quote from: Ilia3101 on December 06, 2017, 10:34:54 PM
Is it a combination of anamorphic and high framerate stretch? We also need to be able to handle that together with anamorphic. I think best way is to have anamorphic ratio options: 1.33, 1.5, 1.75, 2.0, and an On/Off for additional vertical 1.67x (5:3) stretch

Ilia I have no moire in your program its really good!
Is there any way to fix rolling shutter in MLV?
Thanks!


Also purple fringing
(https://thumb.ibb.co/gf7MQG/Screen_Shot_2017_12_07_at_5_27_41_PM.png) (https://ibb.co/gf7MQG)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 07, 2017, 08:39:09 PM
Would be nice to have all shoot info at the Botton like this:
(https://thumb.ibb.co/dxPPvG/Screen_Shot_2017_12_07_at_8_21_52_PM.png) (https://ibb.co/dxPPvG)

upload photos (https://imgbb.com/)


And in Footage if your WB at the moment of the shooting was 5600, when you open the file it opens with same value it was shoot, very handy. than you can change if you want, or reset to defaults. 
(https://thumb.ibb.co/iUuk2w/Screen_Shot_2017_12_07_at_8_22_03_PM.png) (https://ibb.co/iUuk2w)


If you can do "reset to default settings" for all buttons would be nice too!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 07, 2017, 09:21:57 PM
Quote from: OlegK on December 07, 2017, 04:23:49 PM
Is there any way to fix rolling shutter in MLV?
Not yet. If you know how to do (image processing)... please help...

Quote from: OlegK on December 07, 2017, 08:39:09 PM
Would be nice to have all shoot info at the Botton like this:
You can open the "Information" dialog and have it always at the side. I think that is sufficient...

Quote from: OlegK on December 07, 2017, 08:39:09 PM
And in Footage if your WB at the moment of the shooting was 5600, when you open the file it opens with same value it was shoot, very handy. than you can change if you want, or reset to defaults. 
Yeah, would be nice... but I have not found out how exactly to read that atm. When I understood the mlv header right, that won't work for automatic and custom mode.

Quote from: OlegK on December 07, 2017, 08:39:09 PM
If you can do "reset to default settings" for all buttons would be nice too!
Edit->Reset Receipt.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: goldenchild9to5 on December 07, 2017, 09:32:27 PM
Great App.. I tried it and it's awesome.  The only feature that I think it needs is a Highlight slider, if you can implement that it would be awesome.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 07, 2017, 09:52:20 PM
Quote from: goldenchild9to5 on December 07, 2017, 09:32:27 PM
Great App.. I tried it and it's awesome.  The only feature that I think it needs is a Highlight slider, if you can implement that it would be awesome.
Yes, I miss it too. But how you can get that indirectly: lower exposure and raise lighten. I use that atm and I am satisfied for now :-)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on December 07, 2017, 10:51:17 PM
A lot of good ideas from @OlegK

Rolling shutter: With magic lantern we can estimate very precisely the rolling shutter interval, and if we track a few points' movement in the image, we can also figure out the (approximate) direction of movement... and in turn how much to skew the image. However that is something I'd rather do at a later stage of MLV App development (if ever.........), as it involves spatial transformations...

Quote from: goldenchild9to5 on December 07, 2017, 09:32:27 PM
Great App.. I tried it and it's awesome.  The only feature that I think it needs is a Highlight slider, if you can implement that it would be awesome.
thxx... highlights are something I've been putting back, as it involves more than one pixel at a time and would be quite a big slow down, slower than the chroma blur. It is however getting closer, it will debut roughly the same time when OpenCL (GPU) processing mode is released (then everything will be really quick)... yes that's coming ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 07, 2017, 11:19:05 PM
Quote from: Ilia3101 on December 07, 2017, 10:51:17 PM
A lot of good ideas from @OlegK

Rolling shutter: With magic lantern we can estimate very precisely the rolling shutter interval, and if we track a few points' movement in the image, we can also figure out the (approximate) direction of movement... and in turn how much to skew the image. However that is something I'd rather do at a later stage of MLV App development, as it involves spatial transformations... :-\
thxx... highlights are something I've been putting back, as it involves more than one pixel at a time and would be quite a big slow down, slower than the chroma blur. It is however getting much closer, it will debut roughly the same time when OpenCL (GPU) processing mode is released (then everything will be really quick)... yes that's coming ;)


I remember long time ago when i opened cinema dng files in Photoshop to correct them before making a video file i noticed one quality improvement over basic _-like save them as tiff and make video from them.
When files were opened with RAW converter photoshop i changed bit from if i remember correctly 8bit to 16 bit and upscale image don't remember how much. Than i saved it and made movie from it. This way of editing DNG files make my footage look held more information, image became crisper (not sharper), like it has more resolution.
So what do you think guys?
You can try and compare results.

I circled parameters that i changed in PS.


(http://thumb.ibb.co/kYn5Kb/Photoshop_Step_2_1_dragged.png) (http://ibb.co/kYn5Kb)



Also is it possible to implement it to MLV App?
Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 08, 2017, 08:03:15 AM
The whole internal processing is at 3x16bit in MLV App. If you like you also can export 16bit TIFF.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 08, 2017, 05:51:45 PM
Quote from: masc on December 08, 2017, 08:03:15 AM
The whole internal processing is at 3x16bit in MLV App. If you like you also can export 16bit TIFF.

Good!

What about upscale pictures before bouncing into the video?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 09, 2017, 12:18:49 PM
Upscale to any resolution you like on export.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: mesebar2 on December 09, 2017, 12:22:22 PM
Quote from: masc on December 09, 2017, 12:18:49 PM
Upscale to any resolution you like on export.

You guys are great!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 09, 2017, 06:38:51 PM
:) thank you @mesebar2!

Next we will change the apps code a little more, so we decided to release a version now... next version will need a little more time. So here comes v0.12:
- Support for spanned mlv
- TIFF export
- Force bilinear export
- Resize resolution on (batch) export (overrides any clip resolution)
- File error handling on import
- Horizontal and vertical stretch per clip
- Cut in & cut out
- New profile "Film"
- Auto load white balance, if mlv was filmed at sunny, shade, cloudy, thungsten, fluorescent, flash or kelvin
- MASXML saves relative path additionally, so a session can be ported easy to different computers/locations/...
- Changed single frame export to (3x)8bit PNG, so libpng & zlib is not needed anymore
- Many fixes and detail enhancements

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.12alpha

There are some known bugs and maybe you'll find some new ones ;)
Windows version will be compiled and uploaded next. Have fun!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on December 09, 2017, 07:32:19 PM
Yay. that's awesome, really glad there's finally a release to use with all the new stuff.

I also apologize to masc and whoever else for not yet finishing the AVFoundation library that will allow for slightly better quality export on macs.
Also begun on OpenCL processing, nothing to show yet.

Hopefully OlegK will be a bit satisfied with this for a bit until I release the next Cocoa App version :/
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 09, 2017, 10:39:21 PM
Quote from: Ilia3101 on December 09, 2017, 07:32:19 PM
Yay. that's awesome, really glad there's finally a release to use with all the new stuff.

I also apologize to masc and whoever else for not yet finishing the AVFoundation library that will allow for slightly better quality export on macs.
Also begun on OpenCL processing, nothing to show yet.

Hopefully OlegK will be a bit satisfied with this for a bit until I release the next Cocoa App version :/

Thanks a lot guys! So fast!

prorez 4444 Is 8bit?

Going to check now!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 09, 2017, 10:41:15 PM
Quote from: Ilia3101 on December 09, 2017, 07:32:19 PM

Hopefully OlegK will be a bit satisfied with this for a bit until I release the next Cocoa App version :/

For sure! :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 09, 2017, 11:23:40 PM
Quote from: OlegK on December 09, 2017, 10:39:21 PM
prorez 4444 Is 8bit?
Who tells that? No, it is 10bit.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 09, 2017, 11:41:32 PM
Quote from: masc on December 09, 2017, 11:23:40 PM
Who tells that? No, it is 10bit.

Cool!.
Thanks Masc! :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 10, 2017, 01:37:13 AM
Quote from: masc on December 09, 2017, 06:38:51 PM
:) thank you @mesebar2!

Next we will change the apps code a little more, so we decided to release a version now... next version will need a little more time. So here comes v0.12:
- Support for spanned mlv
- TIFF export
- Force bilinear export
- Resize resolution on (batch) export (overrides any clip resolution)
- File error handling on import
- Horizontal and vertical stretch per clip
- Cut in & cut out
- New profile "Film"
- Auto load white balance, if mlv was filmed at sunny, shade, cloudy, thungsten, fluorescent, flash or kelvin
- MASXML saves relative path additionally, so a session can be ported easy to different computers/locations/...
- Changed single frame export to (3x)8bit PNG, so libpng & zlib is not needed anymore
- Many fixes and detail enhancements

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.12alpha

There are some known bugs and maybe you'll find some new ones ;)
Windows version will be compiled and uploaded next. Have fun!


Lets start from first:

The export is really long. 2 small( 16sec. and 10 sec.clips) files took like 7 min. to complete.

I was using my old iMac at home maybe thats why>.


2nd. I cannot remove small colorful dots (weird like Moire) In Slow motion 50fps like twice more of them sharpness 100% so u can really see them.

Regular 24fps:
(http://thumb.ibb.co/btJfnw/Screen_Shot_2017_12_10_at_1_59_16_AM.png) (http://ibb.co/btJfnw)


Slow 50fps:
(http://thumb.ibb.co/n1jxZb/Screen_Shot_2017_12_10_at_1_58_42_AM.png) (http://ibb.co/n1jxZb)


Without sharpness is much better but still.:(
P.S. i didn't notice them in previous build.


3rd.

Really need 1.67x in width stretch menu.

Beside this i like this program a lot!

Questions:

When i increase file resolution on export does the quality increasing? or its just stretched video file?

What difference between Amaze and Bilinear on export?



Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 10, 2017, 01:41:24 AM
Thanks for your working, but there're some problems:
1.App crashes if choose cDNG lossless mode.
2.The edit palette is incomplete. I don't know how to adjust the width of the palette, and some contents are not shown.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 08:58:16 AM
Quote from: OlegK on December 10, 2017, 01:37:13 AM
Really need 1.67x in width stretch menu.
This aspect will be very unusual not 16:9, not even 16:10....( none of existing anamorphic lenses do these kind of squeezing). I wonder what are your settings during video recording :P

Quote from: OlegK on December 10, 2017, 01:37:13 AM
When i increase file resolution on export does the quality increasing? or its just stretched video file?
Nope just plain ffmpeg upscale without any sophisticated before/after frame processing methods.

Quote from: OlegK on December 10, 2017, 01:37:13 AM
What difference between Amaze and Bilinear on export?
I think your example pictures you posted above are bilinear ones. Try amaze, should be better.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 09:03:48 AM
@Doofii

Sorry but your feedback is "a bit" vague ;)
1. tell us it is win or mac version you are talking about
2. post the mlv which crashes during dng export

@ilia, @masc: hey am I missing something? When we implemented "edit palette"?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 10, 2017, 09:22:53 AM
Quote from: bouncyball on December 10, 2017, 09:03:48 AM
@Doofii

Sorry but your feedback is "a bit" vague ;)
1. tell us it is win or mac version you are talking about
2. post the mlv which crashes during dng export

@ilia, @masc: hey am I missing something? When we implemented "edit palette"?
So sorry, it's win 10, and the MLV file is too large, I have no idea how to upload it...
As for the edit palette, maybe there's some misunderstanding.

(http://thumb.ibb.co/dFYY7w/123.png) (http://ibb.co/dFYY7w)

Some contents are not shown. Sorry for my English, and thanks for your patience.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 10, 2017, 09:57:46 AM
Quote from: bouncyball on December 10, 2017, 08:58:16 AM
This aspect will be very unusual not 16:9, not even 16:10....( none of existing anamorphic lenses do these kind of squeezing). I wonder what are your settings during video recording :P

Its regular 2x lens. I am shooting in 3:2 mode. So when i choose 2x from menu i didn't  get proper image, i think its because your 2x mode works with 16:9 or 3:2 footage?
So i isn't works like its shoud:(

Just something wrong.

1.67 i know  its wrong its what gets me final image with program.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 10, 2017, 10:03:23 AM
Quote from: OlegK on December 10, 2017, 01:37:13 AM
Lets start from first:
The export is really long. 2 small( 16sec. and 10 sec.clips) files took like 7 min. to complete.
I was using my old iMac at home maybe thats why.
The higher the resolution, the higher the quality, the slower the export. Did you ever render a video on your computer using another proggi? For me that is not way different.

Quote from: OlegK on December 10, 2017, 01:37:13 AM
2nd. I cannot remove small colorful dots (weird like Moire) In Slow motion 50fps like twice more of them sharpness 100% so u can really see them.

Without sharpness is much better but still.:(
P.S. i didn't notice them in previous build.
Nothing did change here. That is moiree. Specially in 50fps you'll get more moiree. If you use the sharpen slider you will amplify moiree.

Quote from: OlegK on December 10, 2017, 01:37:13 AM
3rd.
Really need 1.67x in width stretch menu.
May I ask what hardware you use? I heard about 1.33, 1.5 and 2.0 lenses.

Quote from: OlegK on December 10, 2017, 01:37:13 AM
Questions:

When i increase file resolution on export does the quality increasing? or its just stretched video file?
No it won't. From where shall come the quality? You may not lose so much quality when cutting and reencoding using a cutting tool like premiere or fcpx.

Quote from: OlegK on December 10, 2017, 01:37:13 AM
What difference between Amaze and Bilinear on export?
It is the demosaic algorithm used. Mostly AMaZE looks better, but not always.

@Doofii:
You did not expand the groupboxes, so the elements are invisible. Press the triangle.
And what font do you have there?! I can't allign the program for any font used by all users... sry. If you use system standard, it should work.

For cDNG export: @bouncyball: did you have the same problem on Windows? Me not.
@Doofii: you can shorten the file using mlv_dump. Then you upload only some single megabytes.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 10, 2017, 10:05:04 AM
Quote from: OlegK on December 10, 2017, 09:57:46 AM
Its regular 2x lens. I am shooting in 3:2 mode. So when i choose 2x from menu i didn't  get proper image, i think its because your 2x mode works with 16:9 or 3:2 footage?
So i isn't works like its shoud:(

Just something wrong.

1.67 i know  its wrong its what gets me final image with program.
If you use a 2x lens, you use 2x width stretch! And nothing else! The 3:2/16:9 mode plays no role here. Pixels have an aspect ratio of 1:1. If you use 50/60fps, you additionally need height stretch 1.67x, because here the pixel aspect ratio is 5:3.

Topic sharpness: the clips you sent me were really unsharp. Here you can't make it better using the sharpen slider. You need to focus right, or if you did, you need a sharper lens.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 10, 2017, 10:34:06 AM
Quote from: masc on December 10, 2017, 10:05:04 AM
If you use a 2x lens, you use 2x width stretch! And nothing else! The 3:2/16:9 mode plays no role here. Pixels have an aspect ratio of 1:1. If you use 50/60fps, you additionally need height stretch 1.67x, because here the pixel aspect ratio is 5:3.

Topic sharpness: the clips you sent me were really unsharp. Here you can't make it better using the sharpen slider. You need to focus right, or if you did, you need a sharper lens.

Whatever i don't understand what i am rtying to tell you! With whole your stretch structure i cannot get proper image in your program. the lens is 2x. and please don't tell me Lessons about focus here.

Look here anamorphic stretch works correct here: https://www.magiclantern.fm/forum/index.php?topic=18949.250
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 10, 2017, 10:39:38 AM
If you don't like the presets, you can always calculate your factors and setup export settings. You can stretch to any resolution / aspect ratio you like. (maximum is 9999x9999, hope that is enough  :D)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 10, 2017, 10:56:28 AM
Quote from: masc on December 10, 2017, 10:39:38 AM
If you don't like the presets, you can always calculate your factors and setup export settings. You can stretch to any resolution / aspect ratio you like. (maximum is 9999x9999, hope that is enough  :D)

Yeah thats what i did. its not big problem here.

Just thinking how to remove those dots
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 10, 2017, 11:04:07 AM
Did you try activating Chroma Separation and Chroma Blur Radius around =3 ? The color may become unsharper, bot those dots are away. And activate Playback->Use AMaZE before settings something up (preview may be slower, but quality is better).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 10, 2017, 11:22:43 AM
Quote from: masc on December 10, 2017, 11:04:07 AM
Did you try activating Chroma Separation and Chroma Blur Radius around =3 ? The color may become unsharper, bot those dots are away. And activate Playback->Use AMaZE before settings something up (preview may be slower, but quality is better).

I tried everything nothing seems to work.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 10, 2017, 11:24:48 AM
Has one of these two clips you sent me these artefacts? I could try here. (but don't find any artefacts)
(https://image.ibb.co/gGAMSw/M06_1261_frame_1.png)
M06_1261
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 11:48:10 AM
@masc: Doofii's right I also can not see right part of controls under win10.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 11:52:07 AM
@OlegK: I'm so eager to see your MLVs which need 1.67x horizontal stretch. Please upload originals somewhere.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 10, 2017, 11:54:51 AM
So...there's nothing to do with the font? I changed the system language to ENG and the right part is still invisible.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 11:57:19 AM
@Doofii: maybe you can shorten mlv file which crashed on dng output?


mlv_dump -f 4 -o 5frame.mlv your_input.mlv
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 10, 2017, 12:01:59 PM
I'd really like to help, but I do know nothing about the programming... That's why I use APP with GUI. Could you please specify how to use this code?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 10, 2017, 12:21:07 PM
@bouncyball: last time when we had nearly the same on Linux, the "Chroma Separation..." was to long. Is it better if you shorten this?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 12:30:33 PM
IDK really what is the issue (default standard install of the win10 without gui tweaking) but all controls are now horizontally scrollable by 2 finger touch pad gesture ;) (horizontall scroll bar is not visible tough)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 12:33:34 PM
@Doofii

This is not a code just a command which you have to run in console ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 10, 2017, 12:34:48 PM
I did it. Download link: https://pan.baidu.com/s/1i5KlQVb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 10, 2017, 12:38:18 PM
I'm not sure where should I upload the file... If you have any problems when you download the file, maybe I can e-mail you directly?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 10, 2017, 01:27:07 PM
Thx @Doofii. Got the file and program crashes on cdng lossless export (Yeay :) ). @Bouncyball : could you try the same?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 01:52:25 PM
Yes it's dual iso mlv. I'm already digging into this issue :)

Thank you Doofii.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 01:56:52 PM
Exporting to losless DNG is fine with preview dual iso mode. Crashes for full20bit mode (Real 16bit DNGs) and for losless ones only. I need more time. I think LJ92 encoder does not like something.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2017, 05:26:58 PM
I was right. LJ92 encoder loops forever and causes buffer overflow (writes outside of buffer). I also used vanilla Baldand's encoder (we are using encoder modified a bit by g3gg0) and the same thing's happened.

For some, not known by me, reason LJ92 encoder does not like the 16bit raw data produced by dual iso processor and can not encode it properly and unfortunately I can not fix this.

This does not apply to all dualiso processed raw, because I have some dualiso footage recorded by me which encodes normally. @masc: u know this :).

@Doofii: 2 questions:

1. Do you have some other dual iso MLVs with the same issue, other scene (more light), other resolution, no high (50/60) frame rate? Give the sample.
2. Do you experience issues when exporting lossless dngs for no dual iso MLVs? If yes please give the sample.

On the other hand this is not the end of the world because you can export uncompressed DNGs and they are healthy.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 11, 2017, 02:10:02 AM
I tried various combinations of dual iso/resolution/frame rates, but none of them crashed till present moment. Probably the file I uploaded was just exceptional.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 11, 2017, 02:29:27 AM
Another clip I shot in the same palace
(http://thumb.ibb.co/ns1Dsw/234.png) (http://ibb.co/ns1Dsw)

Same camera settings, same export settings, weird...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 11, 2017, 09:16:06 AM
Yes I guess it is exceptional. Nice to have one for testing :)

Second crashed on 54% that means something is wrong with middle frame(s). Please upload these example too. Thx in advance.

Meanwhile, despite I really can not fix this issue in the Baldand's jungle ;) I'll try to handle this exception gracefully without a crash (still needs to dig to lj92 code but I can handle this without touching main algorithm)

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: canneloni on December 11, 2017, 10:23:25 AM
Had a similar problem with a specific configuration with the 100d once. I used fps overeride and 10bit lossless and it crahed. When i processed the file with mlv_dump on steroids i saw there was a frame missing somewhere in the middle, like frame 333 jumped to 335.

Maybe its the same here?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 11, 2017, 11:36:33 AM
When I'm gonna have the original MLV will be able to tell what the actual reason is :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 11, 2017, 01:38:24 PM
It seems that the APP crashes when it's exporting the 161st frame. I processed the file with mlv_dump then, but found no frame missed.
Can you give me some code so that I can upload, for example, 160-162 frame?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 11, 2017, 04:03:26 PM
I also noticed sometimes if you copy and paste attributes to another clip, it could stop playing the file at some point, when you bounce this file it bounce just the part that was playing not whole clip.


I am on Mac Sierra 10.12.6.

QTv0.12alpha
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 11, 2017, 05:25:58 PM
Quote from: OlegK on December 11, 2017, 04:03:26 PM
I also noticed sometimes if you copy and paste attributes to another clip, it could stop playing the file at some point, when you bounce this file it bounce just the part that was playing not whole clip.
Haha, sure... the cutIn/cutOut is also in the receipt. So if you copy from a shorter clip, you paste the shorter cutOut. Will think about that...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 11, 2017, 05:30:08 PM
@Doofii

mlv_dump -f 150-170 -o middle_part.mlv your_input.mlv

20 frames would be eanough.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 11, 2017, 05:30:24 PM
Let me check!

Also when I trying import MLV files mouse freeze only arrows works, the same in previous build.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 11, 2017, 05:37:31 PM
Also something weird in MLV App the bokeh looks chopped, with color fringing, None of this in Footage app.

(https://thumb.ibb.co/cANt9b/Screen_Shot_2017_12_11_at_6_33_04_PM.png) (https://ibb.co/cANt9b)


I tried my best with chroma slier  but cannot make it smooth like in Footage app.

Maybe you can add some sliders to correct this issue?
Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 11, 2017, 06:15:07 PM
You can't compare Footage, because this is completely different processing. As I understood Footage uses Apple Standard Functions / Libraries which only work on Mac (not cross platform) and which don't work with all Cameras. My 5D2 did not work at all at Footage. It may be that Apple Functions are here and there better (Apple is a little bigger than us three hobby developpers). In the end, nobody knows what Apple exactly did in this processing functions, so we can't just copy it. If you know a algorithm (best in C/C++) let us know and we add it if we can.

Quote from: OlegK on December 11, 2017, 05:30:24 PM
Also when I trying import MLV files mouse freeze only arrows works, the same in previous build.
It needs some time to parse the GigaBytes... quite normal. But we are working on another solution here.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on December 11, 2017, 07:59:55 PM
Quote from: masc on December 11, 2017, 06:15:07 PM
You can't compare Footage, because this is completely different processing. As I understood Footage uses Apple Standard Functions / Libraries which only work on Mac (not cross platform) and which don't work with all Cameras. My 5D2 did not work at all at Footage. It may be that Apple Functions are here and there better (Apple is a little bigger than us three hobby developpers). In the end, nobody knows what Apple exactly did in this processing functions, so we can't just copy it. If you know a algorithm (best in C/C++) let us know and we add it if we can.
ok got it. Can you do something in your program to improve it?
Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Doofii on December 12, 2017, 03:18:43 AM
@bouncyball
https://pan.baidu.com/s/1pKIx8EJ
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 12, 2017, 08:25:36 AM
@Doofii: thank you :)

@OlegK: personally I prefer amaze version of your samples. It is a LOT sharper! With lots of details. Even martinherring himself says that apple raw engine in not up to the task as he would desire and wants to replace it by something more robust.

Apple example has more saturation and I'm sure has applied the canon matrix to raw color. That's it.

You could just blur the amaze version and would get your smoother anamorphic bokeh ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 12, 2017, 08:36:10 AM
@Doofii

I exported your mlv w/o a problem. It seems that all frame are healthy. Maybe other frame is corrupted.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 12, 2017, 12:15:12 PM
@bouncyball: you remember my mlv file with missing frames I sent you? When exporting this file (lossless cdng), the missing frames end in strange corrupted dngs. Maybe on other systems this could also lead to a crash - who knows.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 12, 2017, 01:45:57 PM
Yes maybe :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: erikbaldwinson on December 14, 2017, 08:43:37 PM
When exporting 14bit lossless in MLV.App.v0.12.alpha.Win64.static every few seconds a frame is black. This is not the case in Resolve?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 14, 2017, 09:18:01 PM
A reason may be that the frames in your MLV are not in the right order. In v0.12 we did not care about this yet, what could result in black frames. Some days ago bouncyball fixed that by replacing the false frames in the right order. This will come with the next release.
With this few information you gave, I don't know if it is really this reason. Best is, if you upload some seconds of your MLV (the seconds where you get the problems), so we can debug.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: erikbaldwinson on December 15, 2017, 12:24:27 AM
Quote from: masc on December 14, 2017, 09:18:01 PM
A reason may be that the frames in your MLV are not in the right order. In v0.12 we did not care about this yet, what could result in black frames. Some days ago bouncyball fixed that by replacing the false frames in the right order. This will come with the next release.
With this few information you gave, I don't know if it is really this reason. Best is, if you upload some seconds of your MLV (the seconds where you get the problems), so we can debug.

https://drive.google.com/open?id=1eU2t2cCUMTy6fXudJ3F-QCUMTIsXrpzz
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 15, 2017, 12:12:39 PM
I've taken a look at your mlv (investigated with mlv_dump, it is healthy), with latest mlv app there are none of black or corrupted frames. The issue was what @masc said. Please wait for next release, use other tools for now.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: erikbaldwinson on December 16, 2017, 08:45:01 PM
Quote from: bouncyball on December 15, 2017, 12:12:39 PM
I've taken a look at your mlv (investigated with mlv_dump, it is healthy), with latest mlv app there are none of black or corrupted frames. The issue was what @masc said. Please wait for next release, use other tools for now.

Thx! I used resolve with MLVFS and the results look better than the pro-res 444 output with bilinear. Maybe the Amaze option is better? I saw the bokeh problem and thought to use Bilinear.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 16, 2017, 10:08:56 PM
Quote from: erikbaldwinson on December 16, 2017, 08:45:01 PM
Thx! I used resolve with MLVFS and the results look better than the pro-res 444 output with bilinear. Maybe the Amaze option is better? I saw the bokeh problem and thought to use Bilinear.
You can't say that any way is better than another before having seen the result of the special clip. I also did many tests with bokeh clips (using my lenses), but had never an issue as OlegK - not with Resolve, not with bilinear and not with AMaZE. Watch each result and than decide which fits best for the clip! ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on December 17, 2017, 10:19:20 PM
New Cocoa App release!!! (v0.22)

Github release page (https://github.com/ilia3101/MLV-App/releases/tag/v0.22-pre-alpha-a-lot-better-edition) or go to download page (https://ilia3101.github.io/MLV-App/)

(https://user-images.githubusercontent.com/23642861/34083688-87a4b332-e36c-11e7-8ed3-c88517319c1a.png)

Highlights:
- AVFoundation export - much faster
- Multiple clips - saveable sessions like QtApp (compatible as well)

Issues:
- No audio support yet (in Cocoa App)

So that no one ever has to download that 2 month old version ever again (it was painful watching the download count go up to 100) ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on December 17, 2017, 11:00:11 PM
Great work !!! I'm downloading it to make some speed tests
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on December 17, 2017, 11:15:02 PM
some random crashes at startup on el capitan but I an open it and export
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 21, 2017, 09:56:05 PM
Here comes a next release of the Qt version of MLV App with some new features:

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.13alpha
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 21, 2017, 10:13:18 PM
Fantastic Ilia, mas and Bouncyball. Will try it out as soon as possible.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 21, 2017, 11:31:22 PM
Works great. Just set export settings to av foundation and boom prores4444 comes flying out.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 23, 2017, 02:00:11 PM
Quote from: Danne on December 21, 2017, 11:31:22 PM
Works great. Just set export settings to av foundation and boom prores4444 comes flying out.
Yeah, that is as it should be. Cool if it works.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: SoyLeo on December 23, 2017, 02:12:40 PM
I used MLRW APP before and now I love this APP, it works great ... good job  8) ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 23, 2017, 04:19:09 PM
I also tried it on my old, dusty (2008) mac mini with El Capitan (apple enlightened me that my system is so old that it's not gonna upgrade to sierra+). Works :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 23, 2017, 05:56:38 PM
This app is getting so good. Just tried the cinema dng export feature. Question. How do I select different bits output? For instance 14bit from 10bit etc? Maybe not implemented? AV foundation ProRes4444 files are golden.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 23, 2017, 06:38:36 PM
True @Danne, found this one yesterday and started experimenting with it. Right away I just processed a MLV and found white balance too blue for starting a starting point to color correct. Corrected it with CameraRAW. Do you know why?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 23, 2017, 07:24:13 PM
White balance will be applied according to either what your camera kelvin is set to or what wb mode you are working with. Watch out for using AWB(auto white balance) since MLV will instead read whatever kelvin your camera is set to when recording.
Short answer. Use any white balance mode but AWB if you want to use white balance from camera.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 23, 2017, 07:42:17 PM
Quote from: Danne on December 23, 2017, 07:24:13 PM
White balance will be applied according to either what your camera kelvin is set to or what wb mode you are working with. Watch out for using AWB(auto white balance) since MLV will instead read whatever kelvin your camera is set to when recording.
Short answer. Use any white balance mode but AWB if you want to use white balance from camera.

Oooh! Get it! All scenes were filmed using AWB. Thought it will not make any change when using RAW. Thanks for the info! Color corrected it, so amazing to see what RAW can do thanks to all the color data available.

Can you help me with this? First DNG frame recognize all camera color profiles using ACR, color corrected it nicely, but all of the rest (400 or so frames) goes dark when applying Syn Settings. Found that on all of the rest DNGs there is no selection available for Camera Profile section, just Embedded. And thats the problem. How can I let ACR be able to see all Camera Profiles normally? This is the first time I see this irregularity.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 23, 2017, 07:50:51 PM
OK!

(http://i64.tinypic.com/rkdkjt.png)

Not OK!

(http://i64.tinypic.com/j0k2v5.png)

As you may note, Camera Profile is set to Embedded and can't change it because there is no list.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 23, 2017, 08:19:30 PM
Could be something related to the name. Look at the first file and the look at the next one. They should all be named to their "unique camera model" name(5D mark III) in this case. Did you develop your dng files with MLV app? If so upload a dng file here.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 23, 2017, 08:44:42 PM
Yes, used MLV App with codec Cinema DNGUncompressed . Here are the first 12 DNG sequence with .xmp color correction file (used VisionLOG) if want to use it...

https://we.tl/GYnF2r9XKZ

Really appreciate your help! Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 23, 2017, 08:52:49 PM
Only the first file seems to have the correct name tag then it goes into this:
Unique Camera Model             : Canon EOS 5D Mark III????????????۸.
A bug. I´m sure Bouncyball will check into it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 23, 2017, 08:56:26 PM
So, it is a bug with MLV App at the moment of processing?  ???
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 23, 2017, 09:01:07 PM
Yes. Meanwhile you could work with for instance batch mlv. It uses the same mlv_dump from bouncyball as in Mlv app.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 23, 2017, 10:39:22 PM
Is it possible to upload the MLV which causes this problem? I tried with some of my MLVs and this does not happen.
Edit: is your rar archive corrupted? I tried to unpack with 3 different proggis... no success. But the MLV would be more interesting for us.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: reddeercity on December 24, 2017, 06:33:20 AM
@JADURCA this is how to my knowledge arc (viva A.E.) works -- it save changes to the first dng then applies the changes to the rest of your video file or image sequence (e.g. Tiff , PNG , MOV. etc...) I just check your dng's and there no problem with camera raw profiles , all where there to be selected . Test on Win 7 Pro With CS6 After Effects , didn't have 5d3 VisionLOG profile to check only have one for 5d2 . So you want Cdng that are W/B & color corrected from ACR/Camera Raw ? Any reason why ? tiff or PNG not good enough or I'm I missing something here .

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 24, 2017, 03:43:25 PM
@Danne

Quote from: Danne on December 23, 2017, 05:56:38 PM
This app is getting so good. Just tried the cinema dng export feature. Question. How do I select different bits output? For instance 14bit from 10bit etc? Maybe not implemented?
You can't :), the output Bit depth always matched to input Bit depth. MLV App does not support bit depth conversion. I think it is pointless.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 24, 2017, 03:50:30 PM
Quote from: masc on December 23, 2017, 10:39:22 PM
Is it possible to upload the MLV which causes this problem? I tried with some of my MLVs and this does not happen.
+1. Please upload MLV.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 24, 2017, 04:45:49 PM
Quote from: Danne on December 23, 2017, 08:52:49 PM
Only the first file seems to have the correct name tag then it goes into this:
Unique Camera Model             : Canon EOS 5D Mark III????????????۸.
A bug. I´m sure Bouncyball will check into it.
Hmm... until today this same code served for Switch (trought mlv_dump on steroids) and MLV App without problem, IDK why it happened in this case but I did some changes to make sure the "Unique Name" always zero terminated after last symbol.

Still waiting for sample MLV ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 24, 2017, 05:13:00 PM
Hi guys! I'm uploading MLV right away. Takes a few minutes. Uploading...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 24, 2017, 05:27:53 PM
Quote from: reddeercity on December 24, 2017, 06:33:20 AM
@JADURCA this is how to my knowledge arc (viva A.E.) works -- it save changes to the first dng then applies the changes to the rest of your video file or image sequence (e.g. Tiff , PNG , MOV. etc...) I just check your dng's and there no problem with camera raw profiles , all where there to be selected . Test on Win 7 Pro With CS6 After Effects , didn't have 5d3 VisionLOG profile to check only have one for 5d2 . So you want Cdng that are W/B & color corrected from ACR/Camera Raw ? Any reason why ? tiff or PNG not good enough or I'm I missing something here .

I'm uploading MLV and VisionLOG camera profile (for like 23 cameras) at the same time, so, if you still have color correction .xmp I uploaded yesterday, then you can use it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 24, 2017, 05:58:52 PM
MLV and VisionLOG => https://we.tl/6dZHdVwnzM
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 24, 2017, 07:58:52 PM
@Danne
Can not reproduce this:
Unique Camera Model             : Canon EOS 5D Mark III????????????۸.
Used MLV App 0.13 to export DNGs. First and all consecutive frames are fine regarding this tag.
Could it be that ACR screws up all consecutive files? I'm on Linux now and can not run AE.

@JADURCA
This kind of issue been reported by MLVFS users when there was a bug in there and XMP could not be written to the virtual folder. As I understand you use physical DNGs on the HDD and that's why it's strange. When you feed ACR/AE with DNGs telling that it's a sequence of frames, everything should be fine and XMP made for 1st frame have to be used for other remaining ones.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 24, 2017, 08:21:48 PM
Also tested exporting Jadurcas clip in Mlv app but coud not reproduce the issue either.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 24, 2017, 08:42:52 PM
@Danne: OK thx. I changed the code anyway ;), now it is more reliable.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on December 24, 2017, 08:59:46 PM
Confirmed @JADURCA's MLV works like normal and unable to reproduce either. Still a wonderful upgrade to this app and yet it just keeps on getting better. A true version of 'never ending story' no pen intended.

Also found a bunch of interesting things within this app especially w lossless Dual-ISO stuff (even tho it isn't intended to be useful atm) but hey I can't help myself not refrain from using this fun feature especially in 2.8K from a 5D3 regardless.

Will report my findings and ideas when I can. Thanks again for making this possible for all of us in here!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: reddeercity on December 25, 2017, 06:41:10 AM
@JADURCA I downloaded your mlv file and tested it on my win7 laptop -- a few things I noticed .
I used mlvproducer to extract the cdng to if it's a issue with MLV App. and I thing so .
In a nut shell ,  both Cdng give access to the Vision Log in ACR thou A.E. , but the mlv app Cdng's do not keep the changes in the timeline (camera raw profile & lens correction) see screen shots below.
See the Red hi-lighted boxes
(https://farm5.staticflickr.com/4739/39276171291_fb2698267f_z.jpg) (https://flic.kr/p/22QGDn6)
MLV_App_CS6_AE_CamRaw_Profile_Vision_log_fails (https://flic.kr/p/22QGDn6) by RedDeerCityTV (https://www.flickr.com/photos/67942440@N06/), on Flickr
Cdng's from mlvproducer keep the changes see below
(https://farm5.staticflickr.com/4647/38399373775_cb48434900_z.jpg) (https://flic.kr/p/21vdQ1x)
MLVPro_CS6_AE_CamRaw_Profile_Vision_log_TimeLine (https://flic.kr/p/21vdQ1x) by RedDeerCityTV (https://www.flickr.com/photos/67942440@N06/), on Flickr

I think it may be this  Unique Camera Model             : Canon EOS 5D Mark III≈  τ≈  σ≈  α█╕.
this is not in the Cdng from mlvproducer  , even the Exif info is really different between the two see below
Cdng from MLP App
ExifTool Version Number         : 10.02
File Name                       : M17-1643_000003.dng
Directory                       : C:/Users/i5Dell/Downloads/exiftool-10.02
File Size                       : 2.6 MB
File Modification Date/Time     : 2017:12:23 12:28:44-07:00
File Access Date/Time           : 2017:12:24 17:19:08-07:00
File Creation Date/Time         : 2017:12:24 17:19:08-07:00
File Permissions                : rw-rw-rw-
File Type                       : DNG
File Type Extension             : dng
MIME Type                       : image/x-adobe-dng
Exif Byte Order                 : Little-endian (Intel, II)
Subfile Type                    : Full-resolution Image
Image Width                     : 1920
Image Height                    : 800
Bits Per Sample                 : 14
Compression                     : Uncompressed
Photometric Interpretation      : Color Filter Array
Fill Order                      : Normal
Make                            : Canon
Camera Model Name               : Canon EOS 5D Mark III
Strip Offsets                   : 1208
Orientation                     : Horizontal (normal)
Samples Per Pixel               : 1
Rows Per Strip                  : 800
Strip Byte Counts               : 2688000
Planar Configuration            : Chunky
Software                        : MLV App
Modify Date                     : 2017:12:17 16:43:28
CFA Repeat Pattern Dim          : 2 2
CFA Pattern 2                   : 0 1 1 2
Exposure Time                   : 1/143
F Number                        : 7.0
ISO                             : 100
Sensitivity Type                : ISO Speed
Exif Version                    : 0230
Subject Distance                : 524 m
Focal Length                    : 24.0 mm
Focal Plane X Resolution        : 48.67290288
Focal Plane Y Resolution        : 48.67290288
Focal Plane Resolution Unit     : inches
Lens Model                      : EF24-105mm f/4L IS USM
DNG Version                     : 1.4.0.0
Unique Camera Model             : Canon EOS 5D Mark III≈  τ≈  σ≈  α█╕.
Black Level                     : 2047
White Level                     : 16200
Default Scale                   : 1 1
Default Crop Origin             : 0 0
Default Crop Size               : 1920 800
Color Matrix 1                  : 0.7234 -0.1413 -0.06 -0.3631 1.115 0.285 -0.03
82 0.1335 0.6437
Color Matrix 2                  : 0.6722 -0.0635 -0.0963 -0.4287 1.246 0.2028 -0
.0908 0.2162 0.5668
As Shot Neutral                 : 0.7939645987 1 0.3541823983
Baseline Exposure               : 0
Camera Serial Number            : 2CB548B5FE
Calibration Illuminant 1        : Standard Light A
Calibration Illuminant 2        : D65
Active Area                     : 0 0 800 1920
Forward Matrix 1                : 0.7868 0.0092 0.1683 0.2291 0.8615 -0.0906 0.0
027 -0.4752 1.2976
Forward Matrix 2                : 0.7637 0.0805 0.1201 0.2649 0.9179 -0.1828 0.0
137 -0.2456 1.057
Time Codes                      : 00:00:07.16
Frame Rate                      : 59.94
Reel Name                       : M17-1643
Baseline Exposure Offset        : 0
Aperture                        : 7.0
CFA Pattern                     : [Red,Green][Green,Blue]
Image Size                      : 1920x800
Megapixels                      : 1.5
Shutter Speed                   : 1/143
Focal Length                    : 24.0 mm
Light Value                     : 12.8


Cdng from MLVProducer
ExifTool Version Number         : 10.02
File Name                       : M17-1643_00000.dng
Directory                       : C:/Users/i5Dell/Downloads/exiftool-10.02
File Size                       : 2.9 MB
File Modification Date/Time     : 2017:12:24 16:22:41-07:00
File Access Date/Time           : 2017:12:24 16:45:10-07:00
File Creation Date/Time         : 2017:12:24 16:45:10-07:00
File Permissions                : rw-rw-rw-
File Type                       : DNG
File Type Extension             : dng
MIME Type                       : image/x-adobe-dng
Exif Byte Order                 : Little-endian (Intel, II)
Subfile Type                    : Full-resolution Image
Image Width                     : 1920
Image Height                    : 800
Bits Per Sample                 : 16
Compression                     : Uncompressed
Photometric Interpretation      : Color Filter Array
Make                            : Canon
Camera Model Name               : Canon EOS 5D Mark III
Strip Offsets                   : 1016
Orientation                     : Horizontal (normal)
Samples Per Pixel               : 1
Rows Per Strip                  : 800
Strip Byte Counts               : 3072000
Planar Configuration            : Chunky
Software                        : MLVProducer
Artist                          : noname
Sample Format                   : Unsigned
CFA Repeat Pattern Dim          : 2 2
CFA Pattern 2                   : 0 1 1 2
Copyright                       : noname
Date/Time Original              :
Lens Model                      : EF24-105mm f/4L IS USM
DNG Version                     : 1.4.0.0
Unique Camera Model             : Canon EOS 5D Mark III
CFA Plane Color                 : Red,Green,Blue
CFA Layout                      : Rectangular
Black Level Repeat Dim          : 1 1
Black Level                     : 2047
White Level                     : 9153
Default Scale                   : 1 1
Default Crop Origin             : 0 0
Default Crop Size               : 1920 800
Color Matrix 1                  : 0.5852 -0.0578 -0.0041 -0.4691 1.1696 0.3427 -
0.0886 0.2323 0.6879
Color Matrix 2                  : 0.492 0.0616 -0.0593 -0.6493 1.3964 0.2784 -0.
1774 0.3178 0.7005
As Shot Neutral                 : 461 795 471
Baseline Exposure               : undef
Bayer Green Split               : 0
Active Area                     : 0 0 800 1920
Forward Matrix 1                : 0.8716 -0.0692 0.1618 0.3408 0.8077 -0.1486 -0
.0013 -0.6583 1.4847
Forward Matrix 2                : 0.9485 -0.115 0.1308 0.4313 0.7807 -0.212 0.02
93 -0.2826 1.0785
Time Codes                      : 00:00:00.00
Frame Rate                      : 59.939
Reel Name                       : M17-1643
Warning                         : Bad IFD1 directory
CFA Pattern                     : [Red,Green][Green,Blue]
Image Size                      : 1920x800
Megapixels                      : 1.5


notice the Color Matrix  are different  between the two app's  , I do see mlv app is exporting the cdng as 14bit instead of 16bit (could that be a issue ?) shouldn't I wouldn't  think.

I though this was odd , the W/B in win7 file explorer is way off from mlv app Vs. mlvproducer (from left to right mlvproducer then mlv app)
(https://farm5.staticflickr.com/4592/38568813434_152a63ab75_b.jpg) (https://flic.kr/p/21LcfvY)
mlvpro_Vs_mlvapp_wb (https://flic.kr/p/21LcfvY) by RedDeerCityTV (https://www.flickr.com/photos/67942440@N06/), on Flickr

but importing in A.E. is not a problem as it show correct W/B , I did notice "as shot" w/b from mlv app was at 4200k and the one from mlvproducer was 5200k , thought that was odd.
Is all this a problem with decoding lossless compression ? Also I wondering do you really need "Unique Camera Mode" the only time I seen this being use in the Band Software Raw Magic , in Mac OSX .
with out that tag some cams like the 5d2 are pink cast in mac finder (black level is hard coded to 2048 & 5d2 has black level of 1792)
Seems there is a lot of extra tags are there all necessary ?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 25, 2017, 08:31:03 AM
@reddeercity

Hey thank you for taking time and writing up all these. You did what I wanted to do long time ago - compare mlvp and mlvfs/mlvapp cdng headers :). Can you also test DNG files produced by MLVFS? Then we'll have 3 way comparison.

Indeed mlvp has strange white level (9153, not taken from MLV, seems edited in mlvp), very different color/forward matrixes and unusual "as shot neutral" (this MLV recorded in ABW mode and MLV has no real kelvin value, so setting WB is up to processing software).

Also if you did not notice yet it is not a real 16bit dng, the raw data values just bit unpacked to 16 bits and saved as is (like MLVFS does for speed's sake). Also black level is not hardcoded to 2048, in both cases it is taken from MLV (2047).

What puzzles me why preset is saved in mlvp case, which tag is responsible for this behavior.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 25, 2017, 10:58:06 AM
Answering #706
Mlv producer is using color matrices from eos 50D. That will most certainly screw with color accuracy for the 5D mark III.
Unique Camera Model is essential for acr and dcp profiling.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on December 25, 2017, 03:28:36 PM
Hi, Masc, ilia, bouncyball, Merry Xmas to you all. Noticed a bug when i try to export, using apple AV Foundation, it crashes when i hit the export button, although for some strange reason it always seems to crash when i hit export for the first time, then i re-boot the app, and it seems not to crash after that, only sometimes..

Here's the crash report https://www.dropbox.com/s/s4mvlijbb72toch/crash%20report%200.13%20mlv%20app.rtf?dl=0
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 25, 2017, 04:18:03 PM
@DeafEyeJedi

Quote from: DeafEyeJedi on December 24, 2017, 08:59:46 PM
Will report my findings and ideas when I can. Thanks again for making this possible for all of us in here!
Thanks for your feedback as per usual :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 25, 2017, 07:00:44 PM
Quote from: Wayne H on December 25, 2017, 03:28:36 PM
Hi, Masc, ilia, bouncyball, Merry Xmas to you all. Noticed a bug when i try to export, using apple AV Foundation, it crashes when i hit the export button, although for some strange reason it always seems to crash when i hit export for the first time, then i re-boot the app, and it seems not to crash after that, only sometimes..

Here's the crash report https://www.dropbox.com/s/s4mvlijbb72toch/crash%20report%200.13%20mlv%20app.rtf?dl=0
Merry xmas!
Please be exact and write more information. The report tells, that the app crashed while building a frame. This does not happen when pressing the export button, that happens between filedialog and export ready. Then: what format did you export, there are 3 AVFoundation formats. The MLV which causes the problem would also be a nice to have for debugging.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on December 26, 2017, 03:29:29 PM
Hi Masc, sorry yes i should have been more precise and informative and less vague, my bad.

I applied minimal corrections (just sharpening and added alexa log c) then i click on export, screen comes up with save as (file name), and where to (desktop etc), then i click on save to start export and it crashes.

Using apple AV Foundation apple prores 4444, and AMAZE Debayer, what is weird though, is that it always crashes, when i first open the app and run my first export ALWAYS, i restart the app and sometimes then the export starts and it's ok, other times it will crash again, i took the liberty of downloading JADURCA's MLV upload https://we.tl/6dZHdVwnzM to see if the same thing happens with that MLV and i can confirm, it does, crash on trying to export, then i re-launch the app, and it renders export fine,

Using macOS High Sierra 10.13.2 Macbook pro late 2016

Using JADURCAS MLV (as it's already uploaded for you to test) First time it crashed, re launched app, it worked and started writing export file. third time tried, crashed again, hope this helps..

PS great work guys this is now (in my humble opinion) the go to, must have MLV app for every Magic Lantern user, the progress has been phenomenal.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 26, 2017, 04:45:29 PM
Thanks a lot for the information and the nice words.
Does it even crash when you have just one MLV to export, or does it happen for batch? Do you load/save sessions, or just import -> adjustments -> export?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 26, 2017, 04:52:10 PM
Indeed, pro app.
Suggestion. Make a screenrecording of your workflow to show exactly what steps are causing the crashes.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 26, 2017, 05:10:41 PM
Okay... I think I have it. Got the crash now too and can debug.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Wayne H on December 26, 2017, 05:19:47 PM
Yes the latest test i did using jadurca's mlv (easy for you all to download), just one mlv exported no sessions loaded or saved, import -> adjustments -> export. i even just loaded that one clip into the app, same crash. As danne suggested here's a video. https://www.dropbox.com/s/edhkq951lwfqeap/mlv%20app%20crash.mp4?dl=0 Hope this helps. PS well since as you got the same crash to masc, you probably dont need this now, hahaha.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 26, 2017, 09:38:57 PM
Thanks, yes that is the same I got the crash now to... but only each 4th or 5th try, but it happens. I also think I found the reason why, but I have to clearify with Ilia, because I don't understand the code 100% there.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: domasa on December 29, 2017, 06:22:24 PM
Please, can you add more key shortcuts?
I used this key shortcut in unsupported application  MlRawViewer:
- Cut In/Out (e. g. Shift+I/Shift+O when 'I' is used for Info)
- go to previous/next video (e. g. K / J)

- delete selected video from session (e. g. Del)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 29, 2017, 10:26:34 PM
Quote from: domasa on December 29, 2017, 06:22:24 PM
Please, can you add more key shortcuts?
Sure...
Quote from: domasa on December 29, 2017, 06:22:24 PM
I used this key shortcut in unsupported application  MlRawViewer:
- Cut In/Out (e. g. Shift+I/Shift+O when 'I' is used for Info)
- go to previous/next video (e. g. K / J)
- delete selected video from session (e. g. Del)
Done.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: domasa on December 30, 2017, 12:37:49 AM
Thx! I will download next alpha version.

Quote- delete selected video from session (e. g. Del)
When I delete some video, first video is always selected. It will be better select next video with nereast index ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on December 30, 2017, 10:30:25 AM
A few requests, mostly stuff that are present on mlrawviewer:

1) Total time (min:sec:frame?) just beside the total frame count on the bottom

2) Smooth realtime playback.

3) Basic lut for colorspace (c-log, rec etc etc.) and importing of new ones if you really want to.

4) Better handling of hotpixels? I've tested it in a rush and I could still see some.

Thanks a lot for the development, mlrawviewer is too buggy and a fresh alternative is really appreciated.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 30, 2017, 10:37:45 AM
Quote from: togg on December 30, 2017, 10:30:25 AM
1) Total time (min:sec:frame?) just beside the total frame count on the bottom
Doable

Quote from: togg on December 30, 2017, 10:30:25 AM
2) Smooth realtime playback.
Not so easy to implement, needs rewriting all of the processing.

Quote from: togg on December 30, 2017, 10:30:25 AM
3) Basic lut for colorspace (c-log, rec etc etc.) and importing of new ones if you really want to.
Doable

Quote from: togg on December 30, 2017, 10:30:25 AM
4) Better handling of hotpixels? I've tested it in a rush and I could still see some.
Please upload sample MLV

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on December 30, 2017, 11:18:35 AM
Oh, I wonder how it was done on mlrw, preview it's an important thing but I guess it's still usable at 5-8 fps.

I'll upload a couple of MLV asap!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on December 30, 2017, 11:20:09 AM
More colour space functionality soon with AVFoundation (rec2020 wink wink reddeercity) add maybe with FFMpeg too.

Also playback is already realtime if your CPU is > 6 GHz :D
But incase it isn't, an OpenCL GPU processing mode is coming (!!!)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 30, 2017, 11:53:32 AM
Quote from: domasa on December 30, 2017, 12:37:49 AM
When I delete some video, first video is always selected. It will be better select next video with nereast index ;)
Was already done.

Quote from: togg on December 30, 2017, 11:18:35 AM
Oh, I wonder how it was done on mlrw, preview it's an important thing but I guess it's still usable at 5-8 fps.
So slow?! On my 8 years old Core2Duo MacBook I get something between 10-12 fps with v0.13... that looks not so bad...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on December 30, 2017, 11:58:46 AM
I have a mbpr 2.3 i7, it's not the best but it should be able to handle something okeish!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 30, 2017, 12:05:24 PM
What??? That should be way faster! Have you found the caching option? Let it cache until it says "Idle" again and then play. You should get around 15 frames with an i7!!!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on December 30, 2017, 05:55:37 PM
I updated my tutorial for compiling  MLV-App in Linux openSUSE (german version).:
https://seescho.wordpress.com/fotos/ml/
An updated english version will follow soon.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 30, 2017, 06:37:19 PM
@escho: COOL! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Dmytro_ua on December 30, 2017, 07:11:23 PM
Wow! This app looks so promising!
I'm wondering, is it possible to implement different fps playback function? For example, I have 50-60fps footage, but I'd like to preview it at 25fps (in slow motion). It would be great to have some options like:
- native fps (as it is now)
- custom fps (speed playback options)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on December 30, 2017, 10:43:37 PM
Quote from: masc on December 30, 2017, 12:05:24 PM
What??? That should be way faster! Have you found the caching option? Let it cache until it says "Idle" again and then play. You should get around 15 frames with an i7!!!

I don't know what to say. I'll try with different drives.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Dmytro_ua on December 30, 2017, 11:03:16 PM
I have 10-15fps on my working i7 desktop. There is great realtime preview on MlRawViewer even on my old notebook.

p.s.
I've found a bug. All my footage stops on 354 frame. Will try different footage to get more information.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 31, 2017, 11:36:34 AM
Guys like I said I wish we could play video in real time BUT...

MLRawViewer uses pure OpenGL engine for debayer, basic tonmapping and color balancing (and there is none of more sophisticated processing like denoise, etc)

We use CPU engine for all of these.

We did some experiments with OpenCL debayer and now @Ilia3101 experimenting with OpenCL processing (and I guess bilinear OpenCL demosaic).

It is pointless to debayer with OpenGL/OpenCL and then color process with CPU. Technically as OpenGL is by far different than CPU coding it is hard to use for complicated graphics processing. That is why all in one OpenCL (not OpenGL) pipeline is our choice and it needs lots of time to understand ;), implement and tune.

@Dmytro_ua
The FPS override is implemented long time ago and is accessible via export settings "fps override" and It works for playback too.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 31, 2017, 11:44:36 AM
Quote from: Dmytro_ua on December 30, 2017, 11:03:16 PM
I've found a bug. All my footage stops on 354 frame. Will try different footage to get more information.
Please collaborate more on this (what is your OS, which - 32 or 64 bit version of MLV App you use) and upload some affecting MLVs to check.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on December 31, 2017, 12:19:08 PM
MLV-App: Compiling for Linux openSUSE
I just finished the english version of my tutorial:
https://seescho.wordpress.com/tutorial-englisch/
I hope, I didn´t forget to much...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 31, 2017, 12:50:40 PM
Quote from: Dmytro_ua on December 30, 2017, 07:11:23 PM
Wow! This app looks so promising!
I'm wondering, is it possible to implement different fps playback function? For example, I have 50-60fps footage, but I'd like to preview it at 25fps (in slow motion). It would be great to have some options like:
- native fps (as it is now)
- custom fps (speed playback options)
This is implemented. Go to export settings and set fps override. That also works for playback.

Quote from: escho on December 31, 2017, 12:19:08 PM
MLV-App: Compiling for Linux openSUSE
I just finished the english version of my tutorial:
https://seescho.wordpress.com/tutorial-englisch/
I hope, I didn´t forget to much...
Thank you! :)

And... funny: on none of my computers MlRawViewer feels faster as MLV App... am I doing something wrong?! How do you get it so fast?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 31, 2017, 02:40:17 PM
Quote from: escho on December 31, 2017, 12:19:08 PM
I hope, I didn´t forget to much...
Small correction ;)

cdng (up to 16bit, lossless or uncompressed)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on December 31, 2017, 02:50:11 PM
Quote from: masc on December 31, 2017, 12:50:40 PM
And... funny: on none of my computers MlRawViewer feels faster as MLV App... am I doing something wrong?! How do you get it so fast?
MLV App feels very snappy in all aspects except REAL realtime playback ;)

In the beginning I was also eager to implement the same shaders as in mlrawviewer (even have draft concept using QT openGL somewhere on hdd at my work) but then droped this because our goal is different (add more processing features in the future and it would be very hard to do in opengl shaders) hence it should be implemented differently. I did not say it's easy to do this in OpenCL :P, but it's better and future proof.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on December 31, 2017, 03:31:51 PM
Previewer is more than good enough for what it does imo. Even get 8fps on my macbook air  1.6 cpu and around 15-17fps on my macbook pro.
(https://s18.postimg.org/s5g9607xl/Ska_rmavbild_2017-12-31_kl._15.30.11.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on December 31, 2017, 03:32:16 PM
Hm, but MlRawViewer is far away from real realtime as well. I would say MLRV bilinear = MLVAPP AMaZE cached and MLRV AMaZE = MLVAPP bilinear in terms of speed on all of my systems, no matter if Win or OSX.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on December 31, 2017, 04:38:08 PM
Thanks a lot escho!

Speaking of real time playback... very soon there will be another upgrade to CPU processing performance, so maybe real time playback :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Dmytro_ua on December 31, 2017, 04:41:12 PM
Don't you think it is possible to lower playback resolution to make it more realtime?

Quote from: Dmytro_ua on December 30, 2017, 11:03:16 PM
All my footage stops on 354 frame. Will try different footage to get more information.

Never mind. It was footage from some early (summer) experimental builds. Installed the latest build and playback works fine.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 31, 2017, 10:12:58 PM
Quote from: togg on December 30, 2017, 10:43:37 PM
I don't know what to say. I'll try with different drives.

@togg, I believe that what @masc is telling you to wait until 'Caching' status changes from "active" to "idle" when changing 'Debayer for preview' option. Check screenshot below.

(http://i66.tinypic.com/suya0i.jpg)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on December 31, 2017, 10:40:28 PM
Quote from: reddeercity on December 24, 2017, 06:33:20 AM
@JADURCA this is how to my knowledge arc (viva A.E.) works -- it save changes to the first dng then applies the changes to the rest of your video file or image sequence (e.g. Tiff , PNG , MOV. etc...) I just check your dng's and there no problem with camera raw profiles , all where there to be selected . Test on Win 7 Pro With CS6 After Effects , didn't have 5d3 VisionLOG profile to check only have one for 5d2 . So you want Cdng that are W/B & color corrected from ACR/Camera Raw ? Any reason why ? tiff or PNG not good enough or I'm I missing something here .

It's all about using all the data available with RAW to color correct at it best. So much latitude for intense correction before image breaks, then when finish color correcting I process all images using just .JPEG at 12 quality setting. I once tested and compared image sequences quality pixels using JPEG, Tiff, PNG and even PSD using the same image. Found that there was no difference when using JPEG with all the others regarding pixel quality, just the storage space each one finally takes and performance (JPEG take less Memory from your video editor). JPEG was a clear winner for me, only thing is that if you want to make major adjustments then you better go back to DNG's and make corrections using ACR and process again.

Here's an footage (where it was possible to recover the sky details and three guys there where almots dark) from a music video project I'm working right now. Workflow: MLV, Extracted using MLV App, DNG's color corrected using (VisionLOG profile) with ACR, saved using JPEG 8-bit 12 quality setting and final rendering using H.264 with Sony Vegas.

https://we.tl/jF2BvBW0DV
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on January 01, 2018, 10:43:01 AM
Quote from: bouncyball on December 31, 2017, 02:40:17 PM
Small correction ;)

cdng (up to 16bit, lossless or uncompressed)

Changed it. Thank You! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on January 01, 2018, 12:37:23 PM
@reddeercity A tip for getting better results in MLV App: use profile "tonemapped" - I can see there is some harsh clipping in the image you posted, on his hat for example. Makes it look like it was shot on a Sony.
@masc What do you think of making it default profile? I think it looks better on 97% of images. (Edit: didn't we already do this? Default seems to be standard for me on every version I open so I might be going insane)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 01, 2018, 01:08:58 PM
Quote from: Ilia3101 on January 01, 2018, 12:37:23 PM
@masc What do you think of making it default profile? I think it looks better on 97% of images. (Edit: didn't we already do this? Default seems to be standard for me on every version I open so I might be going insane)
Tonmapped is the default profile. You'll see when importing a file.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on January 01, 2018, 01:11:38 PM
Ah nevermind :D Remembered couple minutes after I wrote the post (thought it was a sierra bug at one point). Going to be using the app a lot today.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on January 01, 2018, 04:16:30 PM
@escho: :D

@masc: can't you really get realtime playback in mlrawviewer? I can get realtime+ at 3k w/o problem (windows, linux, never tried it on mac) on all of my available PCs/NBs. Bilinear is always realtime, amaze is CPU (same as in mlv app), hence lags quite a bit.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on January 02, 2018, 08:07:21 PM
Hello everyone,

I'd like to know if we can add the H264 proxy workflow that already exists on Danne's switch software ? It allows you "to start to before the MLV files are processed. There's an option in Switch that allows you to trim the H.264 proxies without having to process the MLV files. While not as fast as simply copying the files off the card, it does cut down the wait time between shooting and editing. As an example, on a day that I shot 51 clips totaling 31.5 minutes it took only 17.5 minutes to trim the H.264 proxies compared to processing the MLV files to DNGs which took 4 hours. Yes, you can also use MLVFS or whatever other post workflow you want, just remember that the audio must be extracted from the H.264 proxies and Switch does that for you." (cf. Dfort Reply #314 on Switch Thread). Then, you edit with h264 with audio and make a conformation after your edit to relink to the original MLV for color grading in resolve (in addition to MLVFS).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 02, 2018, 09:29:18 PM
Hi, no sry. ATM we still do nothing with H264 Proxys. You only can open MLVs and look at them, cut them and build new proxies. With the same cut settings but processed, you export ProRes or whatever then and exchange the files in FCPX or whatever you use. A workflow can be then:
1. Open files in MLVApp, sort out bad ones (delete them).
2. Create proxys
3. Cut in FCPX, Premiere, ...
4. Color-Correct MLVs in MLVApp
5. Export ProRes4444
6. Relink files in FCPX,...
7. Export final video
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on January 02, 2018, 09:41:01 PM
Thank you for the reply Masc. I often use your workflow for small personal projects but that takes too much time and process for a pro indy workflow. I love your app but most of the time I need h264 proxy workflow. I keep it for playback and hope for realtime soon ;-)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on January 04, 2018, 04:09:07 PM
How do you guys process dual iso mlv's? I click the "on" button on the dual iso tab but the end files still have lines.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 04, 2018, 08:33:17 PM
Yeah... just switch it on and all should be fine. Can you upload the file (at least some frames of it)? So we could analyse what is going wrong. What was the setting used, and on what camera? Are you on Win/OSX/Linux?
Title: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on January 05, 2018, 12:01:51 AM
Hello ilia3101 and masc,
Do you think it's possible to implement an antialiasing script like the one used by danne and the one used by a1ex? A lot of people there doesn't have money to pay a vaf-filter, so it can be a good alternative to process it and then export from mlv free of aliasing to ProRes.

Edit :  it can also allow us to check the before/after in real-time for more accurate comparison

Envoyé de mon iPhone en utilisant Tapatalk
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 05, 2018, 05:13:43 PM
Quote from: 12georgiadis on January 05, 2018, 12:01:51 AM
Hello ilia3101 and masc,
Do you think it's possible to implement an antialiasing script like the one used by danne and the one used by a1ex? A lot of people there doesn't have money to pay a vaf-filter, so it can be a good alternative to process it and then export from mlv free of aliasing to ProRes.

Edit :  it can also allow us to check the before/after in real-time for more accurate comparison

I can't tell you, if we can implement that, because it is the first time I have heard about antialiasing in SW here. Do you or does anyone else (@Danne?!) have/has more information? That sounds interesting... Or is it just this ffmpeg antialiasing? Then we can't show it in realtime and can't export to "real" prores.
The best algorithm I knew until now is AMaZE against moiree: not perfect, but way better than most others...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on January 05, 2018, 05:46:18 PM
A work in progress :)
http://www.magiclantern.fm/forum/index.php?topic=21089.msg193622#msg193622
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on January 05, 2018, 06:10:48 PM
Quote from: Kanakori on January 04, 2018, 04:09:07 PM
How do you guys process dual iso mlv's? I click the "on" button on the dual iso tab but the end files still have lines.
Let me guess, you exported DNGs as "fast pass".
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 05, 2018, 06:37:39 PM
Quote from: Danne on January 05, 2018, 05:46:18 PM
A work in progress :)
http://www.magiclantern.fm/forum/index.php?topic=21089.msg193622#msg193622
Ah okay, that was this story, I remember. Is there a way to use this with pipes or something like that? ATM I am happy that we don't need temp files. Using these programs would make a big mess again. Do you see a possibility?!  ;D
What you could do: combine the two solutions: take MLV App first to get AMaZE debayered TIFF and then take (a part of) the script fullfilling the antialiasing. That should bring nice results!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on January 06, 2018, 08:28:49 AM
Quote from: masc on January 05, 2018, 06:37:39 PM
Using these programs would make a big mess again. Do you see a possibility?!  ;D
To avoid using external programs, the optical flow should be implemented into the mlv app processing. Ilia! Where are you? :P

Enfuse/hugin align_image_stack approach proposed by Danne as an aliasing cure is a bit different but indeed gives very clean results.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on January 06, 2018, 06:37:26 PM
Debayered tiffs and using the script in post of course if not using  integrated code like optical flow is my opinion :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on January 06, 2018, 08:27:11 PM
Yeah, Danne's script is pretty straightforward and gives nice result. It could be a good implementation on MLV app. Even if you have VAF-filter, in certain cases it's not enough. Indeed, with wide lenses, VAF-filter doesn't work (they will update their filters this year) and the VAF is bluring the picture. With the next version, it will be sharp but hey, it's still very expansive. An all in one post-solution is a good alternative especially for cheap cameras
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 06, 2018, 08:59:42 PM
I agree with bouncyball and Danne: if we want a nice solution (with preview, without memory mess, without external programs which always bring problems,...) we only can implement a in-program-solution. This means implementing optical flow and aligning... yeah... if there is someone out there who can help with that... we are here and waiting for you! ;)

Btw: how good is the script solution working with moving objects and wide angle?! I always have big problems when using optical flow for slowmotion with my clips - that nearly never works (brings missing or double objects flimmering in the clip; tested with FCPX & Resolve).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on January 06, 2018, 09:16:25 PM
From my comparison test with interpolation frames through ffmpeg "minterpolate" and the hugin/enfuse solution I got more stable results with the latter. Unfortunately I cannot say much about the optical flow technique but they do things different so I say it´s for testers to decide. Got any test files :)?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 06, 2018, 10:33:30 PM
Sure. But I had to search for a while. Here you have: https://www.dropbox.com/s/xw260tdkmalnja6/M25-1225s.MLV.zip?dl=0
When reducing speed to 50% there happens this: (left original frame, right generated frame, happens in the end of the clip)
(https://image.ibb.co/hKA22G/Testpic.png)
Unfortunately there is not much aliasing in the clip... maybe the glass border line?!

Scenes with water also nearly never work with optical flow.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on January 06, 2018, 10:43:01 PM
Yeah, I often get something similar. No free lunch here with interpolation. My take is that averaging multiple frames and aligning those into one new file gets nice clean images with reduced aliasing without the intrpolation issues. Still, it needs more testing.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on January 07, 2018, 08:32:17 AM
Quote from: masc on January 06, 2018, 08:59:42 PM
if there is someone out there who can help with that... we are here and waiting for you! ;)
+1 !
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on January 17, 2018, 11:20:06 PM
I've been using MLV app for reviewing shots before conversion. It is very nice, the image is very nice in the program and simple light and darken options can simulate very well the look one was looking for. Though like everyone here said before, no way to get real time playback. Still saves one having to convert all Lossless files to then review and delete.

A small bug I noticed, is when importing multiple mlv's and maximizing the window while it is importing, the program will crash.

Also, would be nice if you could add keyboard commands, like CTRL+Z to undo changes in the parameters, one has done by mistake.

I can not see any difference with Highlight Reconstruction ON and OFF. I always set it to ON and choose Film.

EDIT: Win 8.1
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 18, 2018, 09:34:04 AM
You can get nearly realtime by activating caching and wait until caching is idle. On 8 years old notebooks you can reach more than 10 fps easily, on better computers more than 15 fps what nearly looks like realtime preview.

Yes, while importing you should not do anything. I think I can make that safer. Edit: got it fixed.

Undo changes is very very hard to realize, because we would have to protocol everything you do in the app. We don't do that atm, and for sliders this is even harder to realize, because of showing all changes in realtime.

Highlight Reconstruction only works, if you have a overexposed clip. Then drag exposure to something around -2. The overexposed areas will be pink now. Activate Highlight Reconstruction - now the pink is away. So if you don't have overexposed pinkish areas, you don't need to activate this option.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on January 18, 2018, 08:28:35 PM
Okey, thank you for the explanation.

I always use Amaze caching and i noticed the speed increasing when it is Idle, but I only get 7 fps. Is the app runned by CPU only? i7, 980m, 32 gb ram.

I have only used mlv app for 3,5k mlv's. I will try with HD, it should theoretically almost tripple the speed?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 18, 2018, 09:29:18 PM
Yes, the higher the resolution, the slower the playback. What also helps to increase the playback speed: do not use highres displays (e.g. Apple Retina - external displays can nearly double the speed) and/or make the Apps window smaller (fullscreen is the slowest). The fps I wrote were reached for MLVs at 1856x1044 (5D2).
And yes, all is running on CPU atm. So it runs on almost every computer, the graphics card plays no role. I always had big problems with apps like MLRV and Resolve - long time I did not find any computer where these apps were working, while MLVProducer was working well (even on OSX via Wine).
Bouncyball and Ilia were trying out OpenCL, but this is not so easy as the CPU based C/C++ code (at least I don't understand this) and the first experiments were also not really faster because of memory copy actions. We will see if someone has a good solution for making it faster in the future... ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on January 18, 2018, 10:22:10 PM
The binaries listed on the first post haven't been updated in a while and I wanted to check out the new focus pixel commits so I decided to compile the qt version on my Mac.

A couple of important steps:

brew install qt caskroom/cask/qt-creator
echo 'export PATH="/usr/local/opt/qt/bin:$PATH"' >> ~/.bash_profile


You also have to tweak the preferences:

(https://farm5.staticflickr.com/4616/38868763905_f004268349_z.jpg) (https://flic.kr/p/22dGzkP)

Yay!

(https://farm5.staticflickr.com/4701/38868807505_382506aba7_z.jpg) (https://flic.kr/p/22dGNix)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on January 18, 2018, 10:44:22 PM
Nice dfort.
Meoow.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on January 18, 2018, 11:57:09 PM
It even works with this EOSM crop_rec pre-RAWC shot if you play around with the options:

(https://farm5.staticflickr.com/4615/25897082238_3ba41bbc8f.jpg) (https://flic.kr/p/FsrjiU)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 19, 2018, 08:15:27 AM
Quote from: dfort on January 18, 2018, 10:22:10 PM
A couple of important steps:

brew install qt caskroom/cask/qt-creator
echo 'export PATH="/usr/local/opt/qt/bin:$PATH"' >> ~/.bash_profile


You also have to tweak the preferences:

(https://farm5.staticflickr.com/4616/38868763905_f004268349_z.jpg) (https://flic.kr/p/22dGzkP)

Yay!

You mustn't do that. Just install the version provided on the Qt homepage and you don't have to adjust anything.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on January 19, 2018, 09:33:04 AM
Quote from: masc on January 19, 2018, 08:15:27 AM
You mustn't do that.

Most of what I do I mustn't do.

Ok, so the download link on the www.qt.io website took me to a Russian page but the next link went back to English--that was weird. I opened a QT account in order to run the installer, figured out what I wanted to install (there are lots of options) and when I finally got it working--

:-1: error: No rule to make target `FFmpeg/ffmpeg', needed by `MLV App.app/Contents/MacOS/ffmpeg'.  Stop.

Oh yeah--go back and read the MLV App instructions. Ah ha, - unpack ffmpegOSX.zip in `platform/qt/FFmpeg` and - go to tab project, add command line argument -j4 (for quad core)

Yay!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 19, 2018, 09:36:55 AM
Hehe. Yes. And it also works without Qt login/account. If you don't like the online installer, there is also a offline installer.
Using Qt5.10 has one bug for me - at least in the UI editor: the frame position slider is too short. But this happens only for OSX style, not for dark style. Qt5.9.3 is fine.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on January 19, 2018, 01:45:49 PM
Quote from: dfort on January 19, 2018, 09:33:04 AM
Most of what I do I mustn't do.
Yay!
Haha, now, that very familiar cat looks beautiful everywhere ;)

@dfort: Congrats! Now you are the part of us, "MLV App"ers :)

Ilia, Masc, and I did our best to make this proggie as useful as it is now... more is coming, (@DeafEyeJedi, I'm not teasing... well, may be a lil' bit :P)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on January 19, 2018, 10:48:38 PM
Some improvments coming to playback...

(https://image.ibb.co/dmhbzG/Screen_Shot_2018_01_19_at_21_43_31.png)

;) (https://github.com/ilia3101/MLV-App/commit/dd242c518599bdf6f79cb8114ec10812857f54e9);) (https://github.com/ilia3101/MLV-App/commit/7c587b2f247c85c353c03e521e93c7cd6d28d682)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: reddeercity on January 20, 2018, 07:09:11 AM
Had a problem trying to download the latest windows version thought windows explorer (on Win7Pro , I don't use win10 ,  don't like it at all waiting for wins 12  :P)
I tried with this link  https://ilia3101.github.io/MLV-App/
Anyways here the screen shot with Explorer

(https://preview.ibb.co/me2JWw/MLVApp_download_page_windows_explorer_small_error.jpg) (https://ibb.co/d4nVdb)

So I had to use Google Chrome   >:( ,  the download links show up and could be downloaded .

(https://preview.ibb.co/gxW3Ww/MLVApp_download_page_windows_Google_Chrome.jpg) (https://ibb.co/i9gRjG)

Appears to be errors on the download web page with github , maybe have you downloads on a different hosting site even bitbucket
just a thought
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 20, 2018, 11:37:27 AM
Atm we just have it on github. Does the same happen if you load it from here?
https://github.com/ilia3101/MLV-App/releases
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on January 20, 2018, 01:16:31 PM
@reddeercity
Yes try the github release page.
Internet explorer has been deprecated for years, so it's a vulnerability and may not support some javascript features that are used to fetch the releases through Github API.
I could be able to fix it if you tried to track down some what causes the problem specifically, but probably not worth the time.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: reddeercity on January 20, 2018, 10:52:59 PM
Quote from: masc on January 20, 2018, 11:37:27 AM
Atm we just have it on github. Does the same happen if you load it from here?
https://github.com/ilia3101/MLV-App/releases
Works  :D thanks
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ZakWestbrook on January 21, 2018, 01:27:15 AM
This is incredible! I personally don't know much about coding and what would be involved but if it were possible to incorporate ACR's "clarity" function and ACR's highlight function this would be the perfect app for magic lantern! Also the app on my OSX just randomly closed the second time I used it when I tried to export the file. Awesome work though. It does really simplify things
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on January 21, 2018, 10:33:02 PM
@ZakWestbrook Features like that are coming next. I agree "clarity" and highlights/shadows are the main thing it needs right now to be even better.

Quote from: ZakWestbrook on January 21, 2018, 01:27:15 AM
Also the app on my OSX just randomly closed the second time I used it when I tried to export the file.

Which app version, which export settings? Explain as much as you can!!!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ZakWestbrook on January 23, 2018, 07:10:07 AM
This app actually does an incredible job of reproducing the image I see in my cameras LCD. I've always used MLVFS in the past, ran it into davinci and exported prores 422 and for whatever reason, the image renders a few stops darker than what's actually on my LCD (without changing any settings). Then when I would bring the exposure back up, a TON of noise and red lines from the ISO would show up. It's always been a battle finding a good middle ground of how to properly expose. In general I always like to over expose a stop or two to eliminate as much noise as possible and ACR's highlight and clarity function have saved me on numerous occasions. Having those functions in the MLV App would be incredible for the flexibility alone. This is a recent test I did with hardly any light at all at 400ISO with my Mark III using the MLV App. I wanted to test out the flexibility of the White Balance in the MLV App in low light and I wanted to see how well I could get rid of noise in the shadow areas in the MLV App. Here it is below..there is no noise reduction on the clip.

https://vimeo.com/252102973/89c08d20e5

I'm using the QT MLV.App.v0.13.alpha.OSX on a Macbook air OSX El Capitan Version 10.11.6. (Idk if that matters). I've used the app a couple of times now and half the time it's been great, however the other half it's been quitting unexpectedly right when I go to "Export Selected Clips". I played around with it a ton tonight and I can't find any consistency as to why it's closing out. The only thing that's consistent is that it quits unexpectedly right as I click "Export Selected clips".

A couple other minor suggestions I have are
1. When going to save the project, I have to retype the project name in every time I save it to overwrite the project. Is there a way to streamline that and have it populate when I go to save the project?
2. Playback seems to skip for me and looks like it's only showing every 3rd frame in the actual app. (it's fine once it's actually exported though) so right now what I'm doing is opening up the MLV in MLRawViewer to decide whether or not I like the clip and then export into the MLV App. (it'd be awesome to have everything in 1 place)
3. The White Balance temperature and tint doesn't seem to be as flexible as Davinci or ACR. There's some weird things happening when I push the white balance in the darker areas as seen in the clip that doesn't happen in ACR or Davinci.

I love the work that's being done here though! I'd love to use this app for every project I have moving forward and there's no doubt that this has some serious potential! Keep up the great work!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on January 23, 2018, 08:20:20 AM
Thanks! Each info can be useful.

Not bad... I see no noise! :) But at ISO400 I only expect that... :) I often record at >=ISO1000 @f/1.4 and there the noise starts in the darks using my 5D2.

When the app crashes, OSX brings a Messagebox. There is a button "Report". It would be interesting what it tells (OSX is so kind telling the crashing function ;) ).

1. You mustn't type the name. Just click the file. But yes, I also can improve that.
2. Deactivate "Drop Frame Mode" and you'll see every frame in playback, with the maximum speed you Mac is able to render. (Drop Frame = Realtime with dropping frames it can not render in time)
3. Do you have example pictures? I don't understand it completely...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on January 23, 2018, 04:30:15 PM
Quote from: masc on January 23, 2018, 08:20:20 AM
often record at >=ISO1000 @f/1.4 and there the noise starts in the darks using my 5D2.
Yes with that popular lovely 50mil I often use ISO 1600 @ f1.4 on my 5D3, the noise in shadows very manageable.

btw: the coolest thing is that Canon's 50mm @ f1.4 is ~0.5 stop brighter then it should be :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: domo94 on January 27, 2018, 01:55:01 AM
I'm so glad I found this.

As an editor, I would like to see blacks, shadows, highlights, and whites, instead of whatever is on the interface already.
It runs opposite to what's the standard in this industry for any type of image correction.

That's just my 2 cents: coming from an editor who would like to further use these programs consistently in his workflow.

Overall great app so far though. I love the option for Pros Res 422 and the likes.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Akurra on February 04, 2018, 04:24:48 PM
It seems to repeat the problem from raw2cdng and Davinci Resolve - the WAV files generated are few frames shorter than DNG sequence, and Davinci is not attaching it automatically to the DNG sequence.
The files were from 5D2 - system fps setting was 24 fps.

Also a corrupt MLV file - the one that did not fit into memory card, crashed it.

Otherwise - great APP. Even more than great!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on February 04, 2018, 06:24:36 PM
@Akurra
Can you upload your file? Also, test the same mlv against batch_mlv, it also should work with automatic resolve embedding.
Wav being a few frames shorter is common. As a matter of fact I never recorded a mlv file plus wav that matched exactly yet.
Wav being shorter is better, when longer it disables resolve embedding.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Akurra on February 04, 2018, 07:37:29 PM
A correction. It does not seem to be a *.wav file length problem.
The same problem occurs when using raw2cdng 2.7.9.

Batch_mlv outputs works fine.


I checked again: even when the *.wav file has correct length this is what happens:

In the Davinci media explorer file shows as video with audio (a little musical note sign). And when I click the "audio track" icon in the bottom-left of viewer to display just the audio there seems to be an audio file, which plays ok.
But when I switch back to video track, the video playback is mute,
and when I drag the file to the "Bins" window, the audio is corrupted? shifted? ... as you see on the image below, there is just a very short wave peak at the beginning.
Below is audio imported separately.

Dropbox file: https://www.dropbox.com/s/e85swbxwfjj913l/M04-1853.MLV?dl=0






(https://thumb.ibb.co/cTNQdx/wav_problem.jpg) (https://ibb.co/cTNQdx)

darmowa galeria allegro (https://pl.imgbb.com/)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 04, 2018, 10:26:04 PM
Quote from: Akurra on February 04, 2018, 04:24:48 PM
It seems to repeat the problem from raw2cdng and Davinci Resolve - the WAV files generated are few frames shorter than DNG sequence, and Davinci is not attaching it automatically to the DNG sequence.
The files were from 5D2 - system fps setting was 24 fps.

MLVApp cuts audio only when it is longer than the video. So if audio is shorter (whyever, I also have a 5D2 and audio is always longer), then you have only one chance: move cutOut some frames to the front. Then it should automatically attach in Resolve. It is not only the length, it is also the metadata inside the wav what is needed by Resolve. But MLVApp writes that - at least in newer versions.

Quote from: Akurra on February 04, 2018, 04:24:48 PM
Also a corrupt MLV file - the one that did not fit into memory card, crashed it.

Are you using latest version of MLVApp? We had this problems many versions ago, but fixed that. Can you please upload the file which crashed MLVApp, or is it too big? Would be nice to have it for debugging.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Akurra on February 04, 2018, 11:10:28 PM
@masc

As I wrote above, it does not seem to be a problem with wav lenght after all.

I downloaded MLVApp just yesterday for the first time, so I guess it's up to date.

Unfortunately I deleted the file that used to crash it (stupid me).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 05, 2018, 11:45:18 AM
@Akurra:
It must be something in your workflow: I downloaded your file, exported to dng and imported to Resolve: Audio+Video is automatically linked. I used MLVApp 0.13 and Davinci 14.2.1.

Edit: now I think I found what your problem is: audio plays only for the first few frames and then it is like muted in Resolve. Playing the original WAV works fine... that is strange. Could you test if you have the same problem for a "rounded" fps? You use 23.976 - maybe try with 25. If that works we know where to search ;-)

Edit2:
I think I found it:
Timecode audio: starts always at 0
Timecode video: starts not at 0
So video and audio does not fit, even when it is linked. We have a bug issue for that now: https://github.com/ilia3101/MLV-App/issues/72
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 07, 2018, 08:28:28 AM
Yeah seems this issue is fixed now, however when we're gonna release the v0.14 all testers are welcome :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Akurra on February 07, 2018, 06:15:13 PM
Thanks for info!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on February 10, 2018, 05:47:32 PM
Three things:

1.
Is it possible and makes it sense to add some kind of progressbar, when importing a mlv? What do you think?

2.
I found a way to create some kind of "table of content" in wordpress. I added this to my german-compile-tutorial ( https://seescho.wordpress.com/fotos/ml/ ). I will add this to the english version too. Later...

3.
Did someone with Linux try to enable filter?
Without mlv loaded, no problem. With a mlv loaded, mlvapp freezes and crash 10 seconds later:
Speicherzugriffsfehler (Speicherabzug geschrieben)
Tested with opensuse leap and tumbleweed.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 10, 2018, 06:43:27 PM
Hej escho,
1.: does it still take long time for you to import? On my old Macbook I can import a lot of MLVs from USB 2.0 HDD within seconds... When it was slow some versions ago, I also thought implementing that.

2. Cool!  8) I like your tutorials a lot! It is much more detailed than my one.

3. Hmmm... I had that when playing around on macOS. But with the version in the repos I get no error on Win & macOS. Maybe bouncyball can test with his Linux?! ;) Are you able to debug and tell us the line where it crashes? v0.14 won't take longtime until release - so each bug found before will be good for everybody :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on February 10, 2018, 07:08:01 PM
Servus masc

1.
My mlvs are quite big. 4 GByte and more... The last one had 7,6 GByte.

2.
hankYou. I love doing this. I wrote this guide for me. And than I thougt: Why not sharing it?

3.
This is difficult. I tried using qt-creator in debug-mode, but no crash here. All is fine! Using qt-creator normal: crash. And compiling outside qt-creator: crash. I´m a bit lost at the moment. I will search the commit, the crash comes in, later.
Would be interesting, whether the crash exists on Ubuntu too. So waiting for boucyball :)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 10, 2018, 07:17:58 PM
1. Ahhh... you mean when importing just one big file?! Yes... that is still a problem. But the GUI gets no information about the importing process and progress. The only I can do is a statusbar which file from how many files is imported.

3. Did you try make clean, and then again qmake and make? Sounds strange...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on February 10, 2018, 08:30:28 PM
1.
Yes. It´s always one big file, I´m importing. So, if the gui gives no progrssinfo, let´s forget it.

3.
I always compile a clean project. Sometimes I´m lazy. So I wrote a nice little bash-script for me to do this (delete all, clone git, make clean, qmake, make and some more...). And when I do this stuff manual, mlvapp crash too.

Since I had a bigger hardisk-crash this week, I´m working on a brand new opensuse now. But with my old opensuse ,before the hd died, I had the same crash.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on February 10, 2018, 08:44:47 PM
I went back to this commit:
"fixed compilation error saying type 'uint16_t' is not defined"
Same crash

Shoudn´t we go to github-issues with this problem?

edit:
Since my script write a compile-log: Maybe this implicit declaration is interesting:

g++ -o filter.o ../../src/processing/filter/filter.c
../../src/processing/filter/filter.c: In function 'initFilterObject':
../../src/processing/filter/filter.c:41:24: warning: implicit declaration of function 'fmemopen'; did you mean 'freopen'? [-Wimplicit-function-declaration]


nochmal edit:
created an issue on github: https://github.com/ilia3101/MLV-App/issues/74


Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Justus on February 11, 2018, 12:19:27 AM
I have some difficulties with the App. I came back to Magic Lantern after a few month of not using it. Before I used raw2cdng, which didnt work for me with lossless 10bit recording now.
This app did work perfectly but I am missing the sound in Davinci. I have sound in the app and can playback the clips with sound. Also I have sound when I preview clips in the Media Storage in Davinci. As soon I pull the clip from Media Storage into the Media Pool I lose the sound. It still shows a sound clip in the Edit Tab but there is nothing to hear and no waveform.
Maybe you guys know whats going on.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 11, 2018, 12:52:46 AM
How did you export? CDNG? There was a bug with timecode, which is fixed now. You will get it with the coming v0.14 (hopefully) in the next days. Or you compile yourself and you'll have it faster ;)
Workaround for now without compiling anything: add the wav manually to Resolve.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Justus on February 11, 2018, 01:08:52 AM
Oh okay, thank you. Yeah, CNDG Lossless. I will propably wait then. Changing the wav in a few hundred clips is nothing I am interested in^^
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 11, 2018, 12:14:26 PM
@escho

Please try with latest commit.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 14, 2018, 09:04:48 PM
New release v0.14alpha (https://github.com/ilia3101/MLV-App/releases) :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 14, 2018, 09:58:50 PM
Yay... we finally got it. Thank you all for reporting bugs and wishes.
New in v0.14 alpha:
- Faster playback and export (the more cores, the more you'll feel the difference)
- Added processing filters for film emulation powered by neural networks :ghost:
- New actions and shortcuts for better user experience
- MLV export (Fast Pass, Compressed, Averaged Frame (for darkframe creation), Extract Internal Darkframe)
- MLV darkframe subtraction (external / internal)
- Autodetection for focus pixels and vertical stretching
- Stretching CDNG export frames
- Vector scope
- Added markers for over-/underexposed in histogram
- Timecode label / Duration (edited clip) label
- Audio only batch export
- Bugfixes
Have fun!

(https://user-images.githubusercontent.com/30245296/35821380-24619114-0aa9-11e8-85ed-0a97e125ad96.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on February 14, 2018, 10:01:04 PM
Best release yet!

AI (neural network) powered film emulation filters!!! <-- Maybe a first in open source image processing software! (gonna overtake adobe at this rate)
Much better performance in export and playback (which is often realtime now)
All of the other problems complained about should be solved.
+ lots of other stuff <3

How I feel about this release. (https://www.youtube.com/watch?v=49AiqH-DuR0)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on February 15, 2018, 08:38:33 AM
did a quick test on my windows pc. it works wonderful. love it
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 15, 2018, 08:40:34 AM
@Ilia3101

Hey why you dumped the cocoa version from THIS (https://ilia3101.github.io/MLV-App/) page? It had 200+ downloads anyway! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on February 15, 2018, 12:56:20 PM
This version is bad ass! Briefly checked it but had no darkframes available. Tell me since I am lazy over here, will the darkframe subtracion function work with multiple darkframes with various sizes or is one at the time and applies to all corresponding MLV files?
(https://s17.postimg.org/kxbkju3b3/Screen_Shot_2018-02-15_at_12.52.15.png)

Filter function, awesome:
(https://s17.postimg.org/lo4apb85r/Screen_Shot_2018-02-15_at_12.58.25.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 15, 2018, 01:19:00 PM
You can have one darkframe per clip. You can use a MLV for that, or load the darkframe into your clip.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 15, 2018, 03:54:48 PM
Yes one DF per clip.

If you export MLV with dark frame loaded, exported MLV will include the dark frame internally and loading this MLV after that will activate the 'Int' button.

It is possible to have one internal and one external dark frame simultaneously and switching between them (the effect of subtraction is seen straight away)

Also you can cut MLV including audio and it will be in sync and time code in resolve also will be correctly shown (after DNG export).

MLV export has 4 options (no raw correction is done):
1. export MLV untouched (fast pass)
2. export compressed MLV (only if original was uncompressed)
3. export averaged frame MLV (dark frame)
4. extract existing internal dark frame from MLV and save as a separate MLV.

With full compatibility of mlv_dump's averaging/subtraction.

As for filter option, there is an endless possibility to add more :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: mario1000 on February 15, 2018, 05:15:14 PM
Hello dear developers,

congratulation and a very big THANK YOU for this new version. Everything works very nice exept one thnig: when i try to import a MLV file for dark frame substraction the program craches reproducible. I am using windows 8.1.  The only error message I get is that windows is looking for a solution and I am asked to close the program. Any ideas? Thanks in advance
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 15, 2018, 05:44:10 PM
Which version of MLV App - 32bit or 64bit?

Upload that MLV somewhere and I'll take a look :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: mario1000 on February 15, 2018, 06:12:33 PM
Quote from: bouncyball on February 15, 2018, 05:44:10 PM
Which version of MLV App - 32bit or 64bit?

Upload that MLV somewhere and I'll take a look :)

I tested it with both versions (32 and 64 bit) and get the same result.
Here you can download my test files (video file and  the darkframe file):

https://ufile.io/3pa2v
https://ufile.io/3bauu

Best regards
M.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 15, 2018, 06:50:13 PM
You recorded but did not average all frames of m15-1742.mlv.

How to average it:
1. just load m15-1742.mlv to MLV app (not as dark frame)
2. press 'Ctrl-,' or the export settings button
3. select codec MLV and the option below - Averaged Frame, then close export settings dialog
4. export MLV (name it the way to recognize that this is a dark frame, e.g. m15-1742_Dark_Frame.mlv)
5. delete m15-1742.mlv from session
6. load m15-1741.mlv into session and load m15-1742_Dark_Frame.mlv as a dark frame
7. play with Off/Ext, you should see the difference immediately
8. optionally, you can now export m15-1741.mlv from MLV App and it will include your dark frame internally, after loading exported MLV the Int button will be activated and you can play with Off/Int to see difference
9. Phew... the end :)

Anyway thank you for the feedback, the app crashes because it can not import compressed MLV as dark frame (my bad, I should've added check for it) otherwise as far as MLV, loaded as dark frame, is not compressed you can subtract any MLV from any MLV, again as far as video resolutions match :)

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: mario1000 on February 15, 2018, 08:25:33 PM
Thanks for the help, now it works! Indeed it makes a very big difference using the darkframe.

regards
M.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on February 17, 2018, 01:02:21 PM
I just did some initial testing as i was interested in this neural network film look. What is the difference between this, dare I say, A.I.? And a LUT?

And should i be worried that it will become aware of itself and send robots in to the past?

Joke aside, where are these film looks/emulations from? It reminds me of filmconvert's looks, where in it turns everything brownish.

Also i could not see lossless mlv's (from one of the first versions) 59'976 fps in the import window, but when i dragged and dropped them from folder there was no problem.

Win 64 version.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on February 17, 2018, 01:32:29 PM
There shouldn't be much of a difference between this and a LUT in terms of what it does(just does it a lot differently and slower :D), and it was even trained on some samples that someone I know filmconverted(shhhhh) WHOOps I mean real film

LUT support might be added at some point too, they seem quite simple actually.

The "AI" only has 3 inputs and 3 outputs... I would imagine its difficult to do any damage with just three floating point variables. Don't worry :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on February 17, 2018, 02:31:26 PM
You should talk to hyjalinim or how you spell it, he has some really nice examples of Ektar 100 film. I find his Ektar 100 LUT requires a very specific exposure to yield nice results, perhaps that is something the A.I can learn to do for us? Just a suggsstion.

I could chime in some examples myself, if need be. Have some pictures that nailed the exposure for that Ektar 100 LUT.  But I suppose its better to talk to the man who made the film emulation. And i dont know how the A.I learns exactly.

Anyways, keep up the good work. Its very nice that there is so much work done on the post-processing side of ML.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 17, 2018, 02:49:21 PM
Quote from: Kharak on February 17, 2018, 01:02:21 PM
Also i could not see lossless mlv's (from one of the first versions) 59'976 fps in the import window
Could you upload the sample? I'm curious about it :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ToniX on February 17, 2018, 03:00:32 PM
I have a problem with MLV GUI that severely limits the usability of the program, either with MLV.App.v0.13 /0.14.alpha.Win64.static.

The "edit area" panel is not displayed correctly.

In fact, all the commands on the extreme right of the panel are not completely visible and therefore are not accessible.

I tried different screen resolutions without solving.

I use win 8.1 x64 and I wonder if anyone else has the same issue.

Any solution? (detachable panel, a drop menu, more extended stretching ...)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Walter Schulz on February 17, 2018, 03:26:11 PM
Wild guess: Item/font size off.

Run
control /name Microsoft.Display
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on February 17, 2018, 04:23:16 PM
@bouncyball

Yes, Later this evening.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 17, 2018, 06:14:44 PM
@ Kharak:
What we need for teaching a look is some sample pictures with and without a look applied. Import is to have as many colors as possible inside such pictures. It can be also more than one picture per look. We then have a little command line tool what teaches the look to some numbers, and this numbers can be compiled with a new name to MLV App. ;-)

@ToniX:
I also think it is a Windows font setting. If Windows overrides our font settings, the fonts may be to big for the GUI. We had the same problem on Linux. If fonts are system standard all should be fine.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: GianlucaM83 on February 17, 2018, 07:12:02 PM
@ToniX: I had the same problem. Text in the right panel appeared truncated. I have solved using this way: mlvapp.exe -> Properties > compatibility -> check "override high dpi scaling behavior -> select "system", OK.
I hope this helps you.
EDIT: I use windows 10 x64. In windows 8.1 the procedure may be slightly different.

PS:Sorry for my very bad english.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ToniX on February 17, 2018, 07:34:57 PM
Quote from: Walter Schulz on February 17, 2018, 03:26:11 PM
Wild guess: Item/font size off.

Run
control /name Microsoft.Display

Hi @Walter Schulz 

I restricted the characters to the minimum size, actually allowing  the view of the parts of the panel that were missing. Unfortunately, this client side solution involves making the rest of the PC unusable, as the texts are for the most part illegible.

Perhaps solving at level of  programming, would be more logical and functional.

Thanks anyway, at least so I will get to test the app  (which looks to be very cool!)

Quote from: GianlucaM83 on February 17, 2018, 07:12:02 PM

@ToniX: I had the same problem. Text in the right panel appeared truncated. I have solved using this way: mlvapp.exe -> Properties > compatibility -> check "override high dpi scaling behavior -> select "system", OK.
I hope this helps you.
EDIT: I use windows 10 x64. In windows 8.1 the procedure may be slightly different.

PS:Sorry for my very bad english.

Grazie @GianlucaM83 - I've tried, it would have been a preferable solution but it does not work for me. :(



Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Walter Schulz on February 17, 2018, 07:40:37 PM
High DPI monitor?
Try tuning your Windows settings:
https://support.microsoft.com/en-us/help/3025083/windows-scaling-issues-for-high-dpi-devices
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ToniX on February 17, 2018, 07:55:19 PM
Quote from: masc on February 17, 2018, 06:14:44 PM

@ToniX:
I also think it is a Windows font setting. If Windows overrides our font settings, the fonts may be to big for the GUI. We had the same problem on Linux. If fonts are system standard all should be fine.

@masc,  I saw your comment just now. Pardon
It is certainly a problem caused by windows, known and annoying ..The default settings are too small, so I switched to "BIG" (or Large),  while sizes of specific items (menu, icons, etc) are set  between 9-11 .... ::)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on February 17, 2018, 08:02:24 PM
@bouncyball

I post it tomorrow, no time this evening.

@Masc

So with this learning, one could skip the steps of mlv - converting to a Log image -> corrections - grade - final look? I guess i am asking could the A.I take an MLV - "fake all the steps" - final look? Too complex? Further more, is this perhaps what fhe future of post processing looks like? And it eventually sends robots back in time ;)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Walter Schulz on February 17, 2018, 08:05:48 PM
@ToniX: Had the same issue with several java and web apps after setting item size to 150 (W7) at the company. Thought giving users with not so optimal vision something good. Had to revert it because of login screen troubles and such like.

Windows, application GUIs and high dpi monitors ... <sigh>.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 18, 2018, 09:49:07 AM
I have this problem on my 13inch high DPI notebook too.

It seems for QT there is not only macos DPI scalability is possible: Link (http://doc.qt.io/archives/qt-5.5/highdpi.html).

@Kharak: take your time.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 18, 2018, 11:38:33 AM
Topic highres: is there something we can do? I use already the Qt's highres support with devicePixelRatio and Fusion style. I am not sure if I can do something else. There is absolutely no problem on OSX retina for me - it is only way slower as without retina.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 18, 2018, 01:14:42 PM
Quote from: theBilalFakhouri on January 07, 2018, 09:48:59 PM
Thank you!
I shot today a video with x5 crop mode at 14bit lossless resolution 1920x818 (14bit uncompressed works perfectly.)
The pixel dots pattern was different compared with full 2520x1072 resolution so no map worked for it.
Make your tests:
https://drive.google.com/open?id=1WdY7djRxC9tJjnJvQw_gQ5er30t_joKF
Quote from: dfort on January 08, 2018, 08:03:44 AM
That particular file has the focus pixels shifted 8-frames. I think it has happened before but I can't find the post.

(https://farm5.staticflickr.com/4644/39541580182_1c2d8bd15c_o.gif) (https://flic.kr/p/23f9Wbs)

zoom mode is a special case because we're not sure what part of the sensor it was recorded on. I thought we covered all possible locations but maybe not?

In other news, the fpm2pbm.sh and pbm2fpm.sh scrips got a big speed boost:...

Look like the same problem here in MLVApp, the problem was solved in MLVFS and MLVProducer, I don't know if the new focus maps solved the problem or the developers added some codes in their software.

Amazing app thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 18, 2018, 06:37:38 PM
@theBilalFakhouri

This MLV of yours is very special case:

1. it is 8-12 bit lossless but has white level at 16200
2. it has 1107 vertical resolution of raw buffer

Because of 1st reason it is not detected as 8-12bit lossless, hence MLV App does not generate the correct map.

Use this map from @dfort for this case: 80000326_2592x1107.fpm (https://bitbucket.org/daniel_fort/ml-focus-pixels/src/8e01b06d4d12b3dff074dd33362e708473b673b2/focus_pixel_map_files/80000326_2592x1107.fpm?at=default). Put it into the same directory where MLV App binary is.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 18, 2018, 06:40:13 PM
Quote from: Kharak on February 17, 2018, 08:02:24 PM
@Masc
So with this learning, one could skip the steps of mlv - converting to a Log image -> corrections - grade - final look? I guess i am asking could the A.I take an MLV - "fake all the steps" - final look? Too complex? Further more, is this perhaps what fhe future of post processing looks like? And it eventually sends robots back in time ;)
It could be possible for a set of very equal clips. But the AI is not intelligent in correcting pictures. It is just intelligent in learning a difference between two looks in the same picture.

Quote from: Kharak on February 17, 2018, 02:31:26 PM
You should talk to hyjalinim or how you spell it, he has some really nice examples of Ektar 100 film. I find his Ektar 100 LUT requires a very specific exposure to yield nice results, perhaps that is something the A.I can learn to do for us? Just a suggsstion.
I trained the Ektar 100 look to MLV App. But I think it is not good as it is now, because it is very difficult to get a clean set of pictures, where
a) the MLV App look is the basic
b) the converted look is the same picture with Ektar100 applied
Both apps bring a different look - also without the LUT. Very difficult... so it may work for some clips, but it will not work good for other ones. In my opinion the result is too intense... see examples... and I had to decrease saturation a lot for not getting screaming colors.
(https://image.ibb.co/hFAMT7/M23_1205_frame_1c.png)
(https://preview.ibb.co/mews1S/M21_2106_frame_1c.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on February 18, 2018, 07:20:59 PM
Hard to tell by the flowers, but that top one of the boat looks very nice. Atleast on my phone it does.

Edit: Just looked again at the pictures on my computer, did not see the boat picture on the right before. So that is the Ektar one, yeah it is not too nice, way too intense. Normal one looks kinda like what I imagined the Ektar 100 to look like when correctly applied.

The LUT is very intense, hence why I only use it for photography, because i always, after setting DCP to ML Log in ACR, have to pull highlights -85 or -100 and boost shadows around +30 to not lose too much detail.

I dont know which LUT you used, but Hyjalinim and Danne made the LUT for Danne's ML log. So that might be why it is so intense. There are many versions of ghd lut in his thread. And applying the LUT to Log-C turns the colours wrong.

Edit: @Bouncyball,

I was about to upload MLV example of the ones I could not see in the Import Window, tried the import window one more time now and I can see the MLV's. So all good!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 18, 2018, 08:14:50 PM
Quote from: Kharak on February 18, 2018, 07:20:59 PM
I was about to upload MLV example of the ones I could not see in the Import Window, tried the import window one more time now and I can see the MLV's. So all good!
Heh, good to know, b/c that was weird :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 18, 2018, 09:06:07 PM
I used the "BMD to Etkar C", minus a lot of saturation. I trained the AI again with more pictures and it looks a bit better now... but like the LUT - I don't know - I don't think so  :P  :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 18, 2018, 09:22:56 PM
Thanks! @bouncyball it worked.

But it's just 14bit lossless with white level of 16200 not 8-12 lossless.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 19, 2018, 11:31:56 AM
Quote from: theBilalFakhouri on February 18, 2018, 09:22:56 PM
But it's just 14bit lossless with white level of 16200 not 8-12 lossless.
Hehe :) you mean you did not record it as 8-10 or 12 bit lossless?! (In some rare cases somehow 8-12bit restricted lossless has full range white level like 16000+)

But if you say it was initially recorded as 14bit lossless... then... Houston we've got a problem - @dfort: new special case arrived! Our restricted lossless check is down the drain ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 19, 2018, 12:04:54 PM
Yes I didn't record at 8-12bit lossless, it's 14bit lossless form the beginning :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on February 19, 2018, 04:53:23 PM
Quote from: bouncyball on February 19, 2018, 11:31:56 AM
@dfort: new special case arrived! Our restricted lossless check is down the drain ;)

In my script I'm just reporting whether it looks like a lossless compression clip but always applying the most aggressive focus pixel map. It doesn't seem to hurt the image and is better than having focus pixels showing up because the lossless check failed.

  if [ $bits_per_pixel -eq 14 ] && [ $white_level -lt 15000 ]; then echo "Detected a 12 or lower logical bit depth lossless compressed file"; fi


BTW -- This test passes. The file was recorded 14bit lossless. We've already found out that sometimes the focus pixels shift 8-pixels when recording in 14bit so we need to account for that. The reduced bit depth clips map files just cover more of the sensor area.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 19, 2018, 06:29:43 PM
Quote from: dfort on February 19, 2018, 04:53:23 PM
We've already found out that sometimes the focus pixels shift 8-pixels when recording in 14bit so we need to account for that. The reduced bit depth clips map files just cover more of the sensor area.
Right, then zoom mode pattern generator have to account 2nd pass of shifted pixels for any lossless MLV.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 28, 2018, 08:58:02 AM
Hello everybody!

What's up guys it's so silent here. Any feedback? Any bugs? Any suggestions? Anything else? :D

Edit: LINK (https://ilia3101.github.io/MLV-App/) - good rate of downloads for 2 weeks anyway :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on February 28, 2018, 10:31:42 AM
Bouncyball,

I would love to test the latest version of MLVApp and provide feedback on it but as I stated seval times it will not run on any of my computers.  Initially I thought, the reason is the OS but then I installed Win10x64 and the software continues to crash every time I try to import an MLV file.  It starts normally and displays the GUI though.  The PC on which this happens has now two OS-es:  Win10x64 and XPx32.  The same software crash is observed on both OS-es with the 64-bit and the 32-bit MLVApp versions, accordingly.  My PC has the following configuration:

MoBo: Intel DP35DP
CPU: Quad core Q6600
RAM: 8 GB DDR2
GPU: GTX 750 Ti

I observe exactly the same behavior also with my laptop Lenovo 3000 N200 with 4GB of RAM on it.  No luck here either.

I have never ever observed any problems with any other software on the above two computers, even DaVinci Resolve 14.3 runs perfectly on the Q6600 PC.  It is very powerful, despite being 10 years old.  Just MLVApp refuses to work on it and on my laptop too.  And since there are many friends of mine who experience exactly the same problem with MLVApp on their older PCs, I have a request to you.  Could you please check and see if a colleague or friend of yours has an older PC similar to the ones listed above?  If you find such a person and ask him to let you run MLVApp on his computer maybe you could find out what causes the crash and perform a fix, accordingly.  My friends and I really should greatly appreciate if you could do that.  On my part, I promise to provide feedback on the latest MLVApp as soon as I get it working on my PCs.

Thank you in advance.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 28, 2018, 01:53:53 PM
Hello @bouncyball

I have some suggestions:

1-Can you add the resolution + frame rate info in the bottom bar :D
2-Negative controls especially for "Light Strength", it will help a lot for restoring highlights in dual iso footage after shifting the exposure up 4 stops.
3-I don't really use "Fix Bad Pixels" (it somehow hurt the image for me) , so if I can turn it off once instead of doing it for each clip would be a lot helpful.

And thanks for amazing App  ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: chger on February 28, 2018, 02:17:11 PM
Hello,

I've been using and testing a while now under Windows x64. So far I did not encounter any problems or bugs, but have two feature requests though.

* Integration of DNxHD as an export codec:

I'd prefer using DNxHD or DNxHR as a codec in a .mov-Container (though .mxf would be recognised by Avid MC, Adobe PR has its problems with it.). An example list of command line options and settings for DNX-coding in ffmpeg can be found here: http://www.deb-indus.org/tuto/ffmpeg-howto.htm#Encoding_VC-3 or https://askubuntu.com/questions/907398/how-to-convert-a-video-with-ffmpeg-into-the-dnxhd-format-for-the-purpose-of-usin. Idealy one option would include a 10bit-output.

A direct command line input in the GUI by the user would be an alternative and provide total freedom of codec choice!

* Integration of custom LUTs

As of now I can select from a variety of LUTs (e.g. S-Log 3), but using custom LUTs (thinking of the LUT calc over here: http://cameramanben.github.io/LUTCalc) would be awesome.

Quote from: theBilalFakhouri on February 28, 2018, 01:53:53 PM
2-Negative controls especially for "Light Strength", it will help a lot for restoring highlights in dual iso footage after shifting the exposure up 4 stops.

+1

Cheers and THANK YOU!!!! for your amazing work on the App!

With best regards,
Chris

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 28, 2018, 05:23:33 PM
Quote from: IDA_ML on February 28, 2018, 10:31:42 AM
...  Initially I thought, the reason is the OS but then I installed Win10x64 and the software continues to crash every time I try to import an MLV file.
Thanks for your report. I can't believe it has something to do with your hardware - I successful use it on a 10 years old Core2duo, without any problem. I would really love to know what causes this problem. I think it could be something with localization - some parts of our app had problems there before too. But I think the only way to debug is, if you install Qt on one of your PCs, load our sourcecode, compile as Debug version and run in Debug mode. The debugger will tell us the line of the crash and then we could help solving the issue. Do you think you get that done? We have a little compilation guide, but you also can PM me, if you have problems or questions.
Edit: you get it running on XP? It was not compiled for that and I also don't get it opened there...

Quote from: theBilalFakhouri on February 28, 2018, 01:53:53 PM
1-Can you add the resolution + frame rate info in the bottom bar :D
If you press "I" once, you see this info, if you press "I" twice, it is hidden again. You also can have opened the info dialog all the time on the left or right or... and the app will work as it is not opened.
Quote from: theBilalFakhouri on February 28, 2018, 01:53:53 PM
2-Negative controls especially for "Light Strength", it will help a lot for restoring highlights in dual iso footage after shifting the exposure up 4 stops.
You don't mean to invert the slider, but to have a negative range on the slider? Ilia trys to implement a kind of photoshops "Shadows & Highlights", but has still problems and bugs. We all hope he solves it soon.
Quote from: theBilalFakhouri on February 28, 2018, 01:53:53 PM
3-I don't really use "Fix Bad Pixels" (it somehow hurt the image for me) , so if I can turn it off once instead of doing it for each clip would be a lot helpful.
If you import many MLVs, just change it first for one clip. Then Ctrl-C, Ctrl-A, Ctrl-V and you're done.


Quote from: chger on February 28, 2018, 02:17:11 PM
I've been using and testing a while now under Windows x64. So far I did not encounter any problems or bugs, but have two feature requests though.
Good to hear! :)
Quote from: chger on February 28, 2018, 02:17:11 PM
* Integration of DNxHD as an export codec:

I'd prefer using DNxHD or DNxHR as a codec in a .mov-Container (though .mxf would be recognised by Avid MC, Adobe PR has its problems with it.). An example list of command line options and settings for DNX-coding in ffmpeg can be found here: http://www.deb-indus.org/tuto/ffmpeg-howto.htm#Encoding_VC-3 or https://askubuntu.com/questions/907398/how-to-convert-a-video-with-ffmpeg-into-the-dnxhd-format-for-the-purpose-of-usin. Idealy one option would include a 10bit-output.
Yes, I also thought about adding that. In the tables you posted: are the options so limited for this codec?! For all existing codecs the input plays no role... so that makes it really difficult, which option is chosable for which clip... in a batch it would not be usable at all :(
Quote from: chger on February 28, 2018, 02:17:11 PM
A direct command line input in the GUI by the user would be an alternative and provide total freedom of codec choice!
That is very very complicated to realize regarding error handling: in the past it was already a challenge to get predefined export options to work without a crash. If the user can type what he wants... oh oh  :P
Quote from: chger on February 28, 2018, 02:17:11 PM

* Integration of custom LUTs

As of now I can select from a variety of LUTs (e.g. S-Log 3), but using custom LUTs (thinking of the LUT calc over here: http://cameramanben.github.io/LUTCalc) would be awesome.
There is a enhancement topic added on github for that already, but we will see if and when it is possible to realize that (I am also waiting for that).



Thank you all for your feedback!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on February 28, 2018, 05:56:52 PM
There is nothing left for me to answer :)

Thanks @masc

P.S. @IDA_ML
As I understand your problem is not related to particular MLV file right? Then you're gonna be very helpful if you do what masc asked.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on February 28, 2018, 06:22:14 PM
Quote from: bouncyball on February 28, 2018, 05:56:52 PM
P.S. @IDA_ML
As I understand your problem is not related to particular MLV file right? Then you're gonna be very helpful if you do what masc asked.

I am afraid, I have no coding/compilation skills whatsoever.  This is like Chinese to me.  I would be more than happy to try but I will need very detailed step by step instructions on how to do the compilation.  I am not sure if you guys would have the patience with me to do that.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Walter Schulz on February 28, 2018, 06:26:58 PM
Easy to follow for OS X/macOS users:
https://www.magiclantern.fm/forum/index.php?topic=16012.0
Just copy text found at the end to console and your first compiler run is done.

The guys here will guide you through compiling code for this app, too.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 28, 2018, 07:25:43 PM
Quote from: IDA_ML on February 28, 2018, 06:22:14 PM
I am afraid, I have no coding/compilation skills whatsoever.  This is like Chinese to me.  I would be more than happy to try but I will need very detailed step by step instructions on how to do the compilation.  I am not sure if you guys would have the patience with me to do that.
You don't have to know anything about coding. It is just downloading and installing Qt for Windows (just for Windows (MinGw, 32bit), with QtCreator, all other options disabled in online installer). https://www.qt.io/download
In the source folders MLVApp/platform/qt open MLVApp.pro in QtCreator, set target to debug (just some clicks on/after import), press debug button (2nd button low left corner). Then MLVApp should start. Open a MLV - bang - crash. Qt will show you the code line where it crashes... make a screenshot. The rest we will do.
After all is done, you can uninstall it easily. (unfortunately Qt is some GB big)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on February 28, 2018, 07:49:02 PM
Thank you Masc,

I have just registered on the Qt site and downloaded a file called "qt-unified-windows-x86-3.0.2-online.exe".  However, it is only 19 MB.  Is this what I need?  Should I install it on my Win7x64 machine?

Also, I don't understand the following statement:

"In the source folders MLVApp/platform/qt open MLVApp.pro in QtCreator ... "

Is MLVApp.pro the MLVApp.exe that I have downloaded from the first page of this thread or is it something else?

Sorry for the stupid questions but please be patient with me!  Thanks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 28, 2018, 07:56:37 PM
You dont need to register - there is a very small "skip" (also in the installer).
Yes, the Online installer is right. It downloads all what is needed on install. Open it, click a few times "next", when you are on the register page search for the "skip". At one point you choose the parts to install. Enable Qt for windows 5.10.1 with mingw, and QtCreator, you won't need more for that. Mingw must be enabled somewhere (it is a long time ago I installed on Windows... sry).

Download the sources from here: https://github.com/ilia3101/MLV-App/archive/master.zip
If you unzip it, you'll understand the path I wrote. Open the .pro file in QtCreator. Creator will ask you then, what environment you like to use (there is a little triangle to enlarge, make sure Debug is enabled).
The project should be configured automatically then. On the left there is a computer icon. Press it and make sure Debug is chosen. Below there is the Debug button. Press it. It will compile (needs maybe some minutes) and start MLVApp when ready. Thats all.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on February 28, 2018, 08:35:07 PM
I cant say that I have used the app exstensively, but so far no real bugs to be found. However it did crash yesterday after i had reviewed and tinkered with a lot of 3.5k mlv's. I think it was about 50 mlv's imported and i had tinkered around with about 30 of yhem when it just suddenly crashed, a windows message appeared "the program has encountered an error" something like that. Not a big deal for me, as i so far only used mlv app for reviewing lossless files before converting to DNG with Danne's windows batch script.

One thing I think is off with MLV App is the White Balance slider, i am on a fairly calibrated monitor and i think the Kelvin does not coincide with the normal temperatures, that I am used to from other software e.g. ACR, Resolve etc. what I mean is that I think it is overly warm. A shot under normal daylight with 5600 k looks wrong, i push it to 4800-5000 to get it to look right. Same goes for the AI Film Emulations, they are very warm. Film Convert has a very warm look, so if it learned from that, I understand.

I will compare head to head when i have the time between mlv app and acr to see if there is a difference. So far it looks off.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on February 28, 2018, 08:57:45 PM
Quote from: Kharak on February 28, 2018, 08:35:07 PM
...However it did crash yesterday after i had reviewed and tinkered with a lot of 3.5k mlv's. I think it was about 50 mlv's imported and i had tinkered around with about 30 of yhem when it just suddenly crashed, a windows message appeared "the program has encountered an error" something like that. ...
Yes, for me that also happens - but I have not found yet a defined way how to crash it. If you can reproduce that, please let us know!

Quote from: Kharak on February 28, 2018, 08:35:07 PM
One thing I think is off with MLV App is the White Balance slider, i am on a fairly calibrated monitor and i think the Kelvin does not coincide with the normal temperatures, that I am used to from other software e.g. ACR, Resolve etc. what I mean is that I think it is overly warm. A shot under normal daylight with 5600 k looks wrong, i push it to 4800-5000 to get it to look right.
Really? Do you have examples (jpeg and MLV(just one frame is enough))? I did a quick test, because I did not notice that yet... but can't see a big difference. Whitebalance is identical (4973K), for all other parameters I tried to find a equivalent. 1st: MLVApp, 2nd: Lightroom:
(https://image.ibb.co/ipLgTH/M23_1205_frame_1.png)

Edit: I think I remember... @bouncyball: is this a camera matrices problem? 5D2 is best and all others are more or less off?!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on February 28, 2018, 10:44:07 PM
It's my fault that white balance is wrong. I'll have this fixed some time soon (I've written a really nice black body simulator which I'll put to use in white balance). Also matrices.... I've almost got to that :D

@IDA_ML I have ran it on a Lenovo x61 from 2007 with linux. It's probably something to do with windows being bad as usual.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 01, 2018, 10:58:24 AM
Quote from: Kharak on February 28, 2018, 08:35:07 PM
Not a big deal for me, as i so far only used mlv app for reviewing lossless files before converting to DNG with Danne's windows batch script.
You could batch export DNGs from MLV App directly. Is there any reason why you don't do this? If yes, then there will be some info for me to chew on.

Quote from: Kharak on February 28, 2018, 08:35:07 PM
I will compare head to head when i have the time between mlv app and acr to see if there is a difference. So far it looks off.
If it is not 5d2 then it can be so. I have implemented (in my test build) ufraw black body code modded by alex->dmilligan->(humbly me) to account camera matrixes and it woked lot better for my 5D3 than actual current release. I did not post or commited it anywhere at the moment (needs some more work).

@Ilia3101: very interested in you approach of black body radiation emulation!!! :) (you did great job emulating and interpolating wb multiplier values troughout of 2000-20000K range, unfortunatelly it's for 5D2 only)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 01, 2018, 11:48:53 AM
Good guess Kharak is using the darkframe automation in the script ;).
So, not knowing too much how this darkframe workflow is fully working in Mlv app i'd like to make a suggestion to it.
1 - have the user select any amount of darkframe footage recorded and then have Mlv app all files averaged and ready for usage.
2 - have these darkframes stashed away in a storage folder, always active and used if matched footage is used. There could be an 'activate storage' button for instance.

I'm thinking every user can now keep on filling their darkframe storage and in time it would be more or less complete.

Of course unwanted scenarious could happen such as user selecting non darkframes so some sort of exposure control would be good here. Also ways to erase darkframes etc and the location of the storage folder.

Or maybe easiest way is to select a darkframe storage folder from within Mlv app and that way a user can reuse the folder with every new version coming. Mlv app could then create averaged darkframes that will work with matched footage and the storage can be activated from within the app. Every time a vanilla darkframe mlv is added to the folder Mlv app would average and standardize to suit Mlv app workflow. That way you could skip a lot of hassling steps described above and I think it would be kind of a game changer.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on March 01, 2018, 12:45:42 PM
Thanks @masc

Quote from: masc on February 28, 2018, 05:23:33 PM
You don't mean to invert the slider, but to have a negative range on the slider?

Yes, I meant to have extended values for dropping highlights down.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 01, 2018, 01:26:56 PM
@Danne: Hehe, that is one of the reasons maybe :)

Quote from: Danne on March 01, 2018, 11:48:53 AM
1 - have the user select any amount of darkframe footage recorded and then have Mlv app all files averaged and ready for usage.
This is no problem. Just import all dark frame footage clips and make averaged MLVs for each in batch export.

Quote from: Danne on March 01, 2018, 11:48:53 AM
2 - have these darkframes stashed away in a storage folder, always active and used if matched footage is used. There could be an 'activate storage' button for instance.
Automatically matching DF with clips - this is what's not implemented (and have not been considered to be implemented) in MLV App :)

Quote from: Danne on March 01, 2018, 11:48:53 AM
Of course unwanted scenarious could happen such as user selecting non darkframes
This can be kinda overcome b/c after loading you see all thumbnails of all imported clips. If it is not black then it certainly not DF footage.

Quote from: Danne on March 01, 2018, 11:48:53 AM
That way you could skip a lot of hassling steps described above and I think it would be kind of a game changer.
Right... that kind of automation certainly great to have. Automatically averaging newly added DF clip also nice, but matching is kinda main problem here it must work like focus maps in the folder. There could be not only one folder of DFs, but whole DIR structure like CameraID/Resolution/ISO and also there are parameters like shutter speed, digital/analog gain, binning/skipping...

In short all this have to be coded somehow in filename or dir structure for fast access (for not reading every time all DF MLVs, or some headers in case of some new format for DFs) or implement some kind of database to quickly access those dark frame files (with any names) to match current clip parameters.

Do you use anything like this in your script for DF automation?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 01, 2018, 02:03:10 PM
I did a lot around df automation and the most intuitive way is that you can add darkframe MLV,s and regular MLV files in the same folder and Switch will sort them out by reading pixel brightness. Well, I use convert(imagemagick) for this.

Here is a workflow I use with a storage folder and as you say this includes renaming, prefixing the created, averaged darkframe for fast matching. Only if it finds MLV files without the prefix avg_ then it will start processing the darkframe.
Movietime
https://www.youtube.com/watch?v=A36KsIpVDJw&feature=youtu.be

These are my matching features, there might be more to account for as you say:
avg_14bit_EOS5DMarkIII_res_1920x672_iso_100_fps_59.940000.MLV
avg_14bit_EOS5DMarkIII_res_1920x800_iso_200_fps_59.940000.ML
V

Let me know if I could share anything else here but matching is pretty straight forward. Getting the values:
    bit=$($mlv_dump -v "$FILE" | awk '/bits_per_pixel/ { print $2; exit }')
    res=$($mlv_dump -v "$FILE" | awk '/Res/ { print $2; exit }')
    iso=$($mlv_dump -v "$FILE" | awk '/ISO:/ { print $2; exit }')
    fra=$($mlv_dump -v "$FILE" | awk '/FPS/ { print $3; exit }')
    cn=$($mlv_dump -v "$FILE" | awk '/Camera Name/ { print $4,$5,$6,$7; exit }' | cut -d "'" -f1 | tr -d ' ')


Then check if those values will marry with the regular MLV recordings.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 01, 2018, 04:24:31 PM
Quote from: Danne on March 01, 2018, 02:03:10 PM
...Switch will sort them out by reading pixel brightness. Well, I use convert(imagemagick) for this.
Very smart move :D

Quote from: Danne on March 01, 2018, 02:03:10 PM
avg_14bit_EOS5DMarkIII_res_1920x800_iso_200_fps_59.940000.MLV
Got it, you use simple and effective file name coding. Great! :) (I should've known it if I were mac user :P)

Matching clip and DF parameters is easy in MLV App b/c you have all information at your fingertips after importing MLV, but IDK when and IF this kind of automation will be implemented and available any soon. Instead I chose the path of implementing builtin DF for cut and exported MLVs.

Anyway thanks for sharing!

And I'm interesting what personally Kharak gonna say.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on March 01, 2018, 05:57:35 PM
Yo! Later this evening :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on March 01, 2018, 08:33:21 PM
Quote from: Danne on March 01, 2018, 11:48:53 AM
Or maybe easiest way is to select a darkframe storage folder from within Mlv app and that way a user can reuse the folder with every new version coming. Mlv app could then create averaged darkframes that will work with matched footage and the storage can be activated from within the app. Every time a vanilla darkframe mlv is added to the folder Mlv app would average and standardize to suit Mlv app workflow. That way you could skip a lot of hassling steps described above and I think it would be kind of a game changer.

OoOoOoh yeahhh I'm feelin' this one, @Danne!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 01, 2018, 08:40:15 PM
@deafeyejedi
Darkframe hero nr1  :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on March 01, 2018, 09:36:24 PM
@Bouncyball @Masc

I use the 5D3.

And I use Danne's Batch Script because of the Batch Process, just select Card/Folder containing MLV and select output and batch convert to DNG with Darkframe Automation.

Quote from: masc on February 28, 2018, 08:57:45 PM
Yes, for me that also happens - but I have not found yet a defined way how to crash it. If you can reproduce that, please let us know!
I have not found anything reproducible. It happened again yesterday evening, when I was going through about the same amount of MLV's, maybe 20-30 MLV's. So far this the most "reproducible" thing I have found, in being, that it happens after going through several MLV's. The error was a Runtime Error. It was so late, so I was not bothered enough to take a screenshot of it, but it was just a general Windows Runtime error, no specific code or anything.

Quote from: masc on February 28, 2018, 08:57:45 PM
Really? Do you have examples (jpeg and MLV(just one frame is enough))? I did a quick test, because I did not notice that yet... but can't see a big difference. Whitebalance is identical (4973K), for all other parameters I tried to find a equivalent. 1st: MLVApp, 2nd: Lightroom:
The lightroom DNG, is it exported from MLV App? That might be why they give similar results, but I don't know if you have some sort of bake-in going on with DNG export. Also 5000k for what looks to me like a sunny day, does not seem correct to me, but ofcourse, I was not there and if its your shot, then you know how it was supposed to look like that day.

Here are 4 examples of mine. 3 different softwares: MLV App, ACR and Resolve, I added a 2nd version from MLV App where I (quickly) tried to match exposure to the other two and added some saturation.

All set at 5500k
Tint on 0 on all.

No colour correction.

https://mega.nz/#!wAAHnRwA!On_Allt6g0jzkNe_gej6DEJo-mFRb0rVwqN8Lr0qhII https://mega.nz/#!RVYFVDaa!Gx_v4JU1nNnzwh73XxMOY75W0YIbf6qwCOC79UUtipk https://mega.nz/#!FYQGBIJD!jsfhJCui_qT34ItGF8xsCvrPXW4Itjyc1_2wX8geLzg https://mega.nz/#!pd4kiKxB!h8LCWwdAGmYEqQvb34rDNVIEge1mxaxEB7MqbjPw69g

All exported as PNG because MLV App exports Frames as PNG (very nice feature btw).

Some Notes:

Resolve version is DNG set to Linear to LOG-C and added Arri-Log-C to Rec709 to normalize it, 5500K in Raw Tab and exposure +1.0 to make it match the others more. Maybe there is a better way in Resolve to get a normal look with a DNG, but I never work with DNG's in Resolve.

I think the White Balance of ACR and Resolve matches a lot, even though they dont have a similar look, the overall temperature/colours look to be the same. 

But this might not be an issue with White Balance, it might just come down to how the software process' the RAW information. ACR uses process' of different kind to pop colours and Black Magic have been working a lot on there debayering since they introduced their BMCC cameras. And again, MLV App just looked off to me, maybe because I am so used to ACR and Resolve and "see colours" with their eyes.

I'd like to add that I also think its a good idea with some basic information about the MLV at the bottom bar like Resolution, Frame Rate, Lens, Aperture, ISO and Date/Time. And if one wants the full info, one can click the Info button.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 02, 2018, 09:37:12 AM
@Kharak

Right now I'm looking @ your posted PNGs. You are right all 3 software use very different processing.

The main reason I never been satisfied with MLVProducer (despite it is great software) is pale desaturated reds and this is what also shown on your PNGs from mlv app (used only 5d2 color multipliers, matrix not suited for other cameras like 5d3, also there are other reasons for sure which IDK exactly). IMHO the difference (not featurewise but imagewise) between MLVP and MLV App is that in MLV App you can achieve more pleasing results after less tweaking (but not ideal), what I'm not able to do even with curves, etc in MLVP. For me colors are always wrong there, no matter what I do. In short - out of the box image is better in mlv app for my eye. I think in regard of color and WB accuracy MLV App can not really compete with resolve or ACR at the moment. Besides, like Ilia already said, he's working on a lot of improvements in this field.

Quote from: Kharak on March 01, 2018, 09:36:24 PM
All exported as PNG because MLV App exports Frames as PNG (very nice feature btw).
You better export 16bit TIFFs not 8 bit PNG which is only for quick peek.

Quote from: Kharak on March 01, 2018, 09:36:24 PM
I'd like to add that I also think its a good idea with some basic information about the MLV at the bottom bar like Resolution, Frame Rate, Lens, Aperture, ISO and Date/Time. And if one wants the full info, one can click the Info button.
As Masc mentioned already you can open info dialog and leave it open while switching between clips (the dialog info will update every time you go to the next MLV).

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Lars Steenhoff on March 02, 2018, 08:58:50 PM
I woud love to see a 2X resize preset. ( 200% )


So I can easy export and upscaled to 4k

(https://thumb.ibb.co/ggtAa7/Screen_Shot_2018_03_02_at_20_56_15.png) (https://ibb.co/ggtAa7)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Markus on March 03, 2018, 08:07:08 AM
So you can use this app now for DF averaging and put out new cdng files on Win (or maybe soon)?
If that's so I have to try this out!

@Danne, You have a program for osx that does this aswell?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 03, 2018, 09:31:41 AM
@Markus
Check out Switch for darkframe automation:
https://www.magiclantern.fm/forum/index.php?topic=15108.0
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 03, 2018, 12:10:46 PM
Quote from: Markus on March 03, 2018, 08:07:08 AM
So you can use this app now for DF averaging and put out new cdng files on Win (or maybe soon)?
If that's so I have to try this out!
Yes, you can create averaged darkframes with MLV App. You can also subtract them from your clips and export a subtracted corrected clip or a darkframe to cdng.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 03, 2018, 02:59:05 PM
Quote from: Lars Steenhoff on March 02, 2018, 08:58:50 PM
I woud love to see a 2X resize preset. ( 200% )
So I can easy export and upscaled to 4k

@masc

Looks like there is a request for aspect ratio locking check box in export settings dialog ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 03, 2018, 03:50:52 PM
Yes, very handy indeed.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Markus on March 03, 2018, 05:40:11 PM
Thanks for reply Danne & masc!

@Danne: Switch seems awsome but still on Windows here though :-).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 03, 2018, 05:59:47 PM
Best bet is Mlv app. I created a script for windows which also automates df subtraction. @Kharak seems to like it but it's very basic. It's called batch_mlv.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Markus on March 03, 2018, 06:33:17 PM
@Danne: that sounds sweet, gonna try it out!
:-)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 03, 2018, 08:44:14 PM
Quote from: bouncyball on March 03, 2018, 02:59:05 PM
Looks like there is a request for aspect ratio locking check box in export settings dialog ;)
Quote from: Lars Steenhoff on March 02, 2018, 08:58:50 PM
I woud love to see a 2X resize preset. ( 200% )
So I can easy export and upscaled to 4k
I did it a bit different - as bouncyball proposed. Exactly 2x is useful mostly only for 5D3. Now you can enter the width you like and MLV-App will calculate the height automatically for every clip in the batch in dependency to aspect ratio settings and clip size, if lock button is pressed.
(https://user-images.githubusercontent.com/30245296/36938492-8002b664-1f22-11e8-91bc-e37cf29330e9.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 03, 2018, 09:37:42 PM
Great thinking.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: DeafEyeJedi on March 04, 2018, 01:23:27 AM
Indeed excellent thinking by @masc!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Lars Steenhoff on March 04, 2018, 01:02:02 PM
Nice !

I have some suggestion for the icons, to make them more modern.
I used the font awesome icons to replace the header bar icons, see the screenshot.


(https://thumb.ibb.co/dHN6YS/Screen_Shot_2018_03_04_at_12_59_14.png) (https://ibb.co/dHN6YS)

(https://thumb.ibb.co/cAKyf7/Screen_Shot_2018_03_04_at_12_59_28.png) (https://ibb.co/cAKyf7)


https://fontawesome.com
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on March 04, 2018, 02:15:23 PM
Is it possible to set preferred frame rate when previewing ? I cant seem to find that option

Sometimes when playing 60 fps files, it reaches 30 fps or will vary between 20-30, would be nice if one could set a limit at 24 or what ever one prefers.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 04, 2018, 02:17:50 PM
Having monochrome icons is no good idea. Let me explain: we had that already for the player icons - they were black and the design was very close to what you suggested - the icons are nice - no question. They were visible very good on the systems theme (light grey), and also in the menus. Then we got the dark theme, and the black icons were invisible. But already before - for all users on mac or linux who are using a systems dark theme these icons were invisible.
Now, using white icons may look cool on the dark theme in the app - but in a standard OSX menu white icons become nearly invisible.
So the icons we have now - 75% I found after very long research, and the other 25% there was no icon in the net - so I build them myself. And I hope everybody can see it on each OS and each theme.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 04, 2018, 02:22:53 PM
Quote from: Kharak on March 04, 2018, 02:15:23 PM
Is it possible to set preferred frame rate when previewing ? I cant seem to find that option

Sometimes when playing 60 fps files, it reaches 30 fps or will vary between 20-30, would be nice if one could set a limit at 24 or what ever one prefers.

Yes you can set that up. Standard is the fps of your clip - depending on your clip and your computer it is possible to reach that or not. Then we have 2 playback modes
- one mode shows each frame: that means if you computer is too slow, playback will be slower than it should be
- and drop mode drops frames it can't handle over time: here playback is realtime, but maybe some frames are not shown

If you like to override the original framerate, you can setup that in the export settings dialog. Now the two modes above try to reach that framerate - again: depending on your computer.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 04, 2018, 02:28:06 PM
@Lars Steenhoff

What can I say, looks not bad at all, but Masc is a chief designer of QT App ;). We even decided not to have more themes for simplicity of maintenance.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 04, 2018, 02:33:02 PM
Hey guys I think I probably have good news for @IDA_ML and others who have older PCs with older Core2 Duo CPU models where MLV App crashes during file import (I've been able to reproduce this behavior).

Download those fixed 2 windows builds (now they are running smoothly on my E6800 CPU):

MLV.App.v0.14.alpha.Win32.zip (http://nic.caucasus.net/mlvapp/?dir=&download=MLV.App.v0.14.alpha.Win32.zip)
MLV.App.v0.14.alpha.Win64.static.zip (http://nic.caucasus.net/mlvapp/?dir=&download=MLV.App.v0.14.alpha.Win64.static.zip)
Latest 64bit exe with some bugs fixed (https://bitbucket.org/bouncyball/mlv-tools/downloads/MLVApp_v014_old_cpu_win64.zip)

Try and report back your findings.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Lars Steenhoff on March 04, 2018, 04:44:43 PM
Quote from: masc on March 04, 2018, 02:17:50 PM
Having monochrome icons is no good idea. Let me explain: we had that already for the player icons - they were black and the design was very close to what you suggested - the icons are nice - no question. They were visible very good on the systems theme (light grey), and also in the menus. Then we got the dark theme, and the black icons were invisible. But already before - for all users on mac or linux who are using a systems dark theme these icons were invisible.
Now, using white icons may look cool on the dark theme in the app - but in a standard OSX menu white icons become nearly invisible.
So the icons we have now - 75% I found after very long research, and the other 25% there was no icon in the net - so I build them myself. And I hope everybody can see it on each OS and each theme.

I have thought about what you encountered and I see a few possible variations:

1 use the coloured icons.
2 use  white icons when the theme is dark
3 invert the white icons when the theme is white ( they will be black )
4 use a grey color that works in both dark and light theme.

I'm happy to contribute to making this work. and at the same time understand it not the most important thing. and that to save complicating te project only one theme is used.
It just for me personally I prefer a clean icon. it can even be a coloured one.  so the good thing is that the project is open source and I was able to change the icons the way I want them and make a new build.
and like to share back to you what I did.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on March 04, 2018, 04:54:41 PM
Quote from: masc on March 04, 2018, 02:22:53 PM
Yes you can set that up. Standard is the fps of your clip - depending on your clip and your computer it is possible to reach that or not. Then we have 2 playback modes
- one mode shows each frame: that means if you computer is too slow, playback will be slower than it should be
- and drop mode drops frames it can't handle over time: here playback is realtime, but maybe some frames are not shown

If you like to override the original framerate, you can setup that in the export settings dialog. Now the two modes above try to reach that framerate - again: depending on your computer.

Just to be clear, the Framerate Override box in Export settings also affects the Preview within MLV App ?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 04, 2018, 05:21:20 PM
Quote from: Kharak on March 04, 2018, 04:54:41 PM
Just to be clear, the Framerate Override box in Export settings also affects the Preview within MLV App ?
Yes. Exactly.

And yes it is a bit misleading. Would be nice to have FPS override per clip. We never discussed this before.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 04, 2018, 08:08:30 PM
Quote from: Kharak on March 04, 2018, 04:54:41 PM
Just to be clear, the Framerate Override box in Export settings also affects the Preview within MLV App ?

Yes, that still comes from the time, where this dialog was the App-Preferences and Export-Settings were just a part of it. At this time we said, having just one framerate override for all clips is enough - but maybe this changed ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on March 04, 2018, 08:11:13 PM
alright, thanks! Works for me ;)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 04, 2018, 08:29:23 PM
Quote from: Lars Steenhoff on March 04, 2018, 04:44:43 PM
I have thought about what you encountered and I see a few possible variations:

1 use the coloured icons.
2 use  white icons when the theme is dark
It is okay for the app, but on OSX you won't see the icons in the menu if theme is light. For OSX dark it is okay.
Quote from: Lars Steenhoff on March 04, 2018, 04:44:43 PM
3 invert the white icons when the theme is white ( they will be black )
Now it is okay in OSX light, but in the App you won't see them. Inverting means having more than one icon set in the app? Complexity will rise a lot for such a feature. And I did not search if I can read which theme is loaded in OSX.
Quote from: Lars Steenhoff on March 04, 2018, 04:44:43 PM
4 use a grey color that works in both dark and light theme.
In principle yes, but OSX light is a light grey - so then we have also a bad contrast between icons and background :(
On Windows it will always look good with white icons, because the menu is inside the app and always black. But we always must think on all OS with all themes... and sometimes even this is not enough :D

Quote from: Lars Steenhoff on March 04, 2018, 04:44:43 PM
I'm happy to contribute to making this work. and at the same time understand it not the most important thing. and that to save complicating te project only one theme is used.
It just for me personally I prefer a clean icon. it can even be a coloured one.  so the good thing is that the project is open source and I was able to change the icons the way I want them and make a new build.
and like to share back to you what I did.
Yes, thanks for sharing! So don't understand my wrong. Most of the features in MLVApp are good ideas from users - that is very important for us!
And yes - it is open source. So, if you don't like the design, you can change what you want for your personal version. If you like to play with that - all what is called darkstyle in the code has many parameters, which make the app look as it is. You can change all colours like you like them! ;)
darkstyle.h
darkstyleOSX.qss (on OSX)
darkstyle.qss (non OSX)
What I started one day (but I stopped because it was too much work for my taste) was another darkstyle with orange instead of blue... a bit Resolve like ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Bernie54 on March 05, 2018, 12:03:07 PM
@bouncyball: Hi, I triend to download this new files for testing because I had excactly the same problem on a Core2 - however the link seems to be broken. Any idea?
Regards,
Bernie54

Quote from: bouncyball on March 04, 2018, 02:33:02 PM
Hey guys I think I probably have good news for @IDA_ML and others who have older PCs with older Core2 Duo CPU models where MLV App crashes during file import (I've been able to reproduce this behavior).

Download those fixed 2 windows builds (now they are running smoothly on my E6800 CPU):

MLV.App.v0.14.alpha.Win32.zip (http://nic.caucasus.net/mlvapp/?dir=&download=MLV.App.v0.14.alpha.Win32.zip)
MLV.App.v0.14.alpha.Win64.static.zip (http://nic.caucasus.net/mlvapp/?dir=&download=MLV.App.v0.14.alpha.Win64.static.zip)

Try and report back your findings.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 07, 2018, 10:14:26 AM
Edit: Links above are working now.

Try this 64bit exe (https://bitbucket.org/bouncyball/mlv-tools/downloads/MLVApp_v014_old_cpu_win64.zip) (some bugs fixed). Get ffmpeg from officially released v0.14 here (https://github.com/ilia3101/MLV-App/releases/download/QTv0.14alpha/MLV.App.v0.14.alpha.Win64.static.zip).

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 07, 2018, 10:26:37 AM
This is incredible news for me, Bouncyball!  Thank you so much!  I still cannot believe that MLVApp is finally working on my 11-year old laptop.  Please give me some time to test and I will report on my impressions later in this thread.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: chger on March 07, 2018, 11:22:44 AM
Quote from: masc on February 28, 2018, 05:23:33 PM
Yes, I also thought about adding that. In the tables you posted: are the options so limited for this codec?! For all existing codecs the input plays no role... so that makes it really difficult, which option is chosable for which clip... in a batch it would not be usable at all :(

I see, DNxHD is very limited, but I think DNxHR is more flexible. I will do some testing with ffmpeg handling non-standard resolutions and framerates and report back.
I assume from what I read so far that with DNxHR you can just assign a profile (dnxhr_444, dnxhr_hqx, dnxhr_hq, dnxhr_sq, dnxhr_lb) without providing any further options (e.g. framerate, resolution). That is atleast for converting file a to file b.

Cheers,
Chris
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 07, 2018, 11:54:29 AM
Quote from: IDA_ML on March 07, 2018, 10:26:37 AM
This is incredible news for me, Bouncyball!  Thank you so much!  I still cannot believe that MLVApp is finally working on my 11-year old laptop.  Please give me some time to test and I will report on my impressions later in this thread.
W.w.what?! Bouncyball, you got it to work for IDA_ML? What was the reason? Was it the optimization -O3 for the compiler!? NICE!

Quote from: chger on March 07, 2018, 11:22:44 AM
I see, DNxHD is very limited, but I think DNxHR is more flexible. I will do some testing with ffmpeg handling non-standard resolutions and framerates and report back.
I assume from what I read so far that with DNxHR you can just assign a profile (dnxhr_444, dnxhr_hqx, dnxhr_hq, dnxhr_sq, dnxhr_lb) without providing any further options (e.g. framerate, resolution). That is atleast for converting file a to file b.
If that is more flexible, that would be nice. Adding these single options is no problem. What we do with further options, must be evaluated. There are many aspect ratios for MLVs out there, not only 16:9 ... but I could stretch it always to 16:9 if DNxHD is chosen - but I don't know if someone needs/likes that. If you could some testing it would be nice to report back! If it works for a TIFF sequence to DNxHD.mov, it should also work for our export pipe. (You can export a TIFF sequence with MLVApp, if you haven't one.)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: chger on March 07, 2018, 12:21:06 PM
Another thing that came to my mind:

The following keyboard-shortcut would be useful: Alt + I (since I is already in use for Clip-Info) for setting the In-Point right at cursor / playhead-position within the "timeline". Same with Alt + O for the Out-point.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 07, 2018, 12:26:30 PM
DNxHD seems not to be so easy too. I tried to export a 5D2 16:9 1856x1044 MLV, without much parameters...
ffmpeg -r 25 -y -f rawvideo -s 1856x1044 -pix_fmt rgb48 -i - -i M15-1953.wav -c:a copy -c:v dnxhd -pix_fmt yuv422p M15-1953.mov

That brings:
Input #0, rawvideo, from 'pipe:':
  Duration: N/A, start: 0.000000, bitrate: 2325196 kb/s
    Stream #0:0: Video: rawvideo (RGB0 / 0x30424752), rgb48le, 1856x1044, 2325196 kb/s, 25 tbr, 25 tbn, 25 tbc
Guessed Channel Layout for Input Stream #1.0 : stereo
Input #1, wav, from '/Users/masc/Desktop/M15-1953.wav':
  Metadata:
    comment         : Exported MLV Audio
    encoded_by      : Canon EOS 5D Mark II
    originator_reference: JPCAN-2...
    date            : 2017:07:15
    creation_time   : 19:52:50
    time_reference  : 0
    coding_history  : PCM
  Duration: 00:00:00.34, bitrate: 1575 kb/s
    Stream #1:0: Audio: pcm_s16le ([1][0][0][0] / 0x0001), 48000 Hz, stereo, s16, 1536 kb/s
Stream mapping:
  Stream #0:0 -> #0:0 (rawvideo (native) -> dnxhd (native))
  Stream #1:0 -> #0:1 (copy)
[dnxhd @ 0x7ff07b014c00] video parameters incompatible with DNxHD. Valid DNxHD profiles:
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 175Mbps; pixel format: yuv422p10; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 185Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 365Mbps; pixel format: yuv422p10; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 440Mbps; pixel format: yuv422p10; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 115Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 120Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 145Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 240Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 290Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 175Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 185Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 220Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 365Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 440Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 185Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 220Mbps; pixel format: yuv422p10; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 120Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 145Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 185Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 220Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 120Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 145Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p10; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 180Mbps; pixel format: yuv422p10; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 220Mbps; pixel format: yuv422p10; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 110Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 180Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 220Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 60Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 60Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 75Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 120Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 145Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 36Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 36Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 45Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 75Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 90Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 350Mbps; pixel format: yuv422p10; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 390Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 440Mbps; pixel format: yuv422p10; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 730Mbps; pixel format: yuv422p10; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 880Mbps; pixel format: yuv422p10; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 42Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 60Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 75Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 115Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 63Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 84Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 100Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 110Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 80Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 90Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 100Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 110Mbps; pixel format: yuv422p; framerate: 0/0
Error initializing output stream 0:0 -- Error while opening encoder for output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width or height
Conversion failed!


So it has definitively to be resized to the supported size - using it is really limited :(

Quote from: chger on March 07, 2018, 12:21:06 PM
Another thing that came to my mind:

The following keyboard-shortcut would be useful: Alt + I (since I is already in use for Clip-Info) for setting the In-Point right at cursor / playhead-position within the "timeline". Same with Alt + O for the Out-point.
Try Shift+I and Shift+O ;) (You see the hint when cursor is on the buttons)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 07, 2018, 12:43:33 PM
Okay, I got a very first DNxHD export file out of MLVApp. There are only the listed options available, not more, not less. We now have to search for a good idea, how to combine this with our export settings dialog in a way it makes sense...
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 175Mbps; pixel format: yuv422p10; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 185Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 365Mbps; pixel format: yuv422p10; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 440Mbps; pixel format: yuv422p10; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 115Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 120Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 145Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 240Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 290Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 175Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 185Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 220Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 365Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 440Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 185Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 220Mbps; pixel format: yuv422p10; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 120Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 145Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 185Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080i; bitrate: 220Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 120Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 145Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p10; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 180Mbps; pixel format: yuv422p10; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 220Mbps; pixel format: yuv422p10; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 90Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 110Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 180Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 220Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 60Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 60Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 75Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 120Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1280x720p; bitrate: 145Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 36Mbps; pixel format: yuv422p; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 36Mbps; pixel format: yuv422p; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 45Mbps; pixel format: yuv422p; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 75Mbps; pixel format: yuv422p; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 90Mbps; pixel format: yuv422p; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 350Mbps; pixel format: yuv422p10; framerate: 24000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 390Mbps; pixel format: yuv422p10; framerate: 25/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 440Mbps; pixel format: yuv422p10; framerate: 30000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 730Mbps; pixel format: yuv422p10; framerate: 50/1
[dnxhd @ 0x7ff07b014c00] Frame size: 1920x1080p; bitrate: 880Mbps; pixel format: yuv422p10; framerate: 60000/1001
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 42Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 60Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 75Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 960x720p; bitrate: 115Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 63Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 84Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 100Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080p; bitrate: 110Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 80Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 90Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 100Mbps; pixel format: yuv422p; framerate: 0/0
[dnxhd @ 0x7ff07b014c00] Frame size: 1440x1080i; bitrate: 110Mbps; pixel format: yuv422p; framerate: 0/0
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 07, 2018, 12:49:49 PM
Haha... tried the profile dnxhr_444 as you mentioned... exports without parameters and without crash. But: I don't have a program what can play it back :D

Edit: profile dnxhr_hq needs also resolution and format parameters - but after export is ready, I don't find a program what can open it - even VLC can't.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 07, 2018, 02:50:07 PM
Masc,

You may want to try MPV player:

https://mpv.io/installation/

It plays DNxHR 444 files perfectly.

And yes, Bouncyball did it for me.  MLVApp v.014 works on both of my computers (the laptop Lenovo 3000 200N and the PC from my post #849).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 08, 2018, 02:14:40 PM
Thanks @IDA_ML. That works.

I added DNxHD export to MLVApp. It is commited to the repos for now and I got some first test export files.
But that will need a lot of test - DNxHD is a very angry codec @ ffmpeg: if there is just one false character in the command -> BAAMMM. And the commands are not sooo short :)

I added 4 export options: 1080p & 720p, both @ 8 and 10 bit. Aspect ratio will be forced to 16:9, whatever it was before. Export will work only, if clips are 23.976, 25, 29.97, 50 or 59.94 fps, or if they are forced to that.

Hope anyone can use that... :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on March 08, 2018, 02:28:58 PM
Have you tried looking at Gopro Cineform codec, which is open source now?

10 bit YUV, 12 bit RGBA, custom aspect ratio/resolutions up to 4K and I read somewhere it can be exported as 16 bit aswell. Though i have not seen 16 bit option in any of the software i have used.

https://gopro.github.io/cineform-sdk/
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 08, 2018, 02:43:10 PM
Now there is also DNxHR 444 codec - for now only 1080p 10bit. Does someone need DNxHR 444 at 8bit and/or 720p?

Quote from: Kharak on March 08, 2018, 02:28:58 PM
Have you tried looking at Gopro Cineform codec, which is open source now?

Yes we did. But nobody of us understands this code. That is why we decided to wait until it is supported by ffmpeg as encoder, then we could add it very easily. See https://github.com/ilia3101/MLV-App/issues/38 for latest information...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 08, 2018, 05:08:11 PM
Hi  guys!

Here is the LINK (http://www.dvinfo.net/forum/cineform-software-showcase/534863-cineform-sdk-now-open-source.html#post1939158) explaining why cineform official inclusion to ffmpeg is kinda stalled. Sad but we can't do anything about it.

However, VirtualDub-FilterMod supports native cineform encoding/decoding (version 10) and I'm using it with great success. There is a plugin to support cineform and it is open source. I guess it is LOT of time/work but can be considered as doable.

@masc, yes it was -O3->-O2 which I committed lately :)

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 09, 2018, 12:23:38 PM
Quote from: bouncyball on March 08, 2018, 05:08:11 PM
@masc, yes it was -O3->-O2 which I committed lately :)
Nice one!

I now added DNxHR HQX, HQ, SQ & LB - all in 1080p - to MLVApp as export codec.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 09, 2018, 03:26:00 PM
It's not very nice that this codec forces us to particular resolutions.

I always preferred cineform.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 09, 2018, 04:04:48 PM
Quote from: bouncyball on March 09, 2018, 03:26:00 PM
It's not very nice that this codec forses us to particular resolutions.

I always preferred cineform.

Word...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 14, 2018, 06:45:27 PM
Hello guys,

After playing for more than a week with v.014 of MLVApp which Bouncyball was so kind to adopt for usage with very OLD PCs, I am now ready to report my first impressions:

BUGs
====

1) The software crashes when rendering large MLV files shot at 24 fps.  I tried to render a 1,25 GB  from the 100D and it crashed every time at different locations of the time line.  It works fine with smaller files though.

2) MLV files shot at the full sensor resolution (FRSP) as timelapse sequences with the silent module do not record properly in the destination folder after rendering is completed.  Just an empty file (0 bytes) gets recorded.

3) Sound does not play while playing a clip in the main window.

4) Dark frame subtraction does not seem to be doing anything.  I recorded a MLV file at ISO 3200 (quite noisy) and then a dark-frame MLV at the same settings with the lens cap on that I used for the subtraction.  The software imports it fine as Ext file but the noise on the original does not get affected even after export.  Am I doing something wrong?

Overall Impression:
============

I am quite satisfied with MLVApp.  I love the nice and vibrant colors and the fact that they are fairly easy to adjust.  My favorite feature is the Chroma Separation which kills color noise while preserving fine detail - very useful.  I wish, export was a little faster but all in all, MLVApp is a great and efficient tool for working with MLV files.

--------------------------------------------------

I have to run now but I will continue with suggestions and comparisons when I find some time for that.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 14, 2018, 08:04:34 PM
Hej IDA_ML, thanks for your feedback! Happy to hear that you like the app. You are using a 32 or 64bit version?

1. & 2.: Could you please upload these two MLVs? I never had such problems, so it would be nice to have such files for debugging!

3. Is the audio output and drop frame mode active? Otherwise sound can't be played back.

4. Do you use the darkframe file as it is, or have you averaged it? You can do this by opening your noise file, exporting as MLV->Averaged Frame. Then import this averaged file as darkframe. The dynamic noise won't be filtered with that. But static noise is filtered. For 5D3 files the left side of the picture is less pink than for example.

MLVApp renders 100% CPU based. That's why speed could be better - but as it is it runs on nearly every computer of the last 10 years. ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 15, 2018, 09:10:29 AM
1. and 2. agree with @masc. Giving us original uncut samples will be very helpful.

3. With latest Win32 build sound does not work at all for some unknown reason. Please use 64bit version when possible. (if 64bit has no audio then check what @masc explained)

4. As @masc mentioned above Dark Frame has to be prepared before using it. 200-300 frame DF MLV has to be averaged. Select in export options averaged frame. This will export real averaged 1 frame MLV for you. Then it can be loaded as Ext DF. Effect will be seen immediately when clicking Off/Ext/Off...

Speed is the matter of heavy optimizations. Maybe someday... :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 15, 2018, 09:26:54 AM
Quote from: bouncyball on March 15, 2018, 09:10:29 AM
4. As @masc mentioned above Dark Frame has to be prepared before using it. 200-300 frame DF MLV has to be averaged. Select in export options averaged frame. This will export real averaged 1 frame MLV for you. Then it can be loaded as Ext DF. Effect will be seen immediately when clicking Off/Ext/Off...

Could this step be automated? Check for black MLV file and determine whether the darkframe has been averaged or not? Should be simple to determine if there´s one averaged frame or around 200 non averaged ones?

Since you are using ffmpeg it´s rather easy to check for black frames.
#detect blackframe thorugh ffmpeg(example is with a mov file):
if grep -q 'pblack' <<< $(ffmpeg -i $(ls *.MOV | head -1) -vframes 1 -y -vf blackframe -f null /dev/null 2>&1 | grep -m1 'pblack')
then
echo yes
fi
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 15, 2018, 10:44:37 AM
Hey Danne,

Yeah, there could be done any checks you want.

1. Black (dark image) or one frame MLV.
2. Say in message box that this MLV is not right one for DF subtracting, "But hey wait a minute!"
3. If frames are dark all along the whole clip, average them to DF.
4. Add DF with defined name to appropriate DIR to be used with appropriate footage.
5. Play some hurray song and congratulate user with 1st ever dark frame subtraction accomplishment, despite he even has no idea what it is and what he's done :P
6. Do it again and again...

Well... may be some day ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 15, 2018, 11:01:31 AM
Or maybe only adding a check for if the selected darkframe is averaged or not and react accordingly. Don´t even need to be checking for dark/bright, only size of MLV.
Cheers  :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 15, 2018, 12:46:01 PM
Some while back I wanted to introduce the separate DF file format but after thinking a bit more I decided to go with mlv_dump compatible way (MLV) despite this was more work than just new format import/export. I was making MLV export anyway so I added averaging as an option.

Also my point was to include DF to the mlv itself. So does MLV App during MLV export if external DF is loaded. I fully understand that this is not an optimal approach when you have to quickly process dozens of clips, it is just for people like me who keeps lots of clips in acquisition format. The dedicated DIR with preaveraged DFs for various cases is the way to go to automate and make clip processing fast.

For the beginning just checking the MLV frame amount (1 or more) is a good thing to warn user and tell him he needs to average the clip first.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 15, 2018, 12:49:34 PM
Quote from: bouncyball on March 15, 2018, 09:10:29 AM
3. With latest Win32 build sound does not work at all for some unknown reason. Please use 64bit version when possible. (if 64bit has no audio then check what @masc explained)
Really? For me that works on Win32.

Quote from: bouncyball on March 15, 2018, 12:46:01 PM
For the beginning just checking the MLV frame amount (1 or more) is a good thing to warn user and tell him he needs to average the clip first.
No prob... that is done easily.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 15, 2018, 12:55:53 PM
Quote from: masc on March 15, 2018, 12:49:34 PM
Really? For me that works on Win32.
Yes :( after -O2 sound does not work on my Core2 CPU PC for win32 build.

Quote from: masc on March 15, 2018, 12:49:34 PM
No prob... that is done easily.
Yes sure it's not hard, but check should be done in C lib not in mainwindow.cpp. I'll take care of it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 15, 2018, 06:24:53 PM
Hello Bouncyball and Masc,

Following your instructions, I got sound during playback working.  Thanks a lot!  As far as Dark Frame Averaging is concerned, I did exactly what you suggested ("200-300 frame DF MLV has to be averaged. Select in export options averaged frame. This will export real averaged 1 frame MLV for you. Then it can be loaded as Ext DF. Effect will be seen immediately when clicking Off/Ext/Off...") BUT I still do not see the effect, although the averaged 1 frame MLV was successfully created and I loaded it as Ext DF (see B. below for the dark frame footage). Could it be that the dark frame footage was not long enough for averaging?

As you requested, I have prepared a few MLV files for you to see what's wrong:

A) A 1,25 GB file (shot on the 100D, in movie crop mode at 24 fps, 1800x1012 and ISO 3200) for Masc.  With this file, after a few basic adjustments MLVApp crashes while rendering at different locations of the timeline, every time I open and render it.  Download link:

https://we.tl/tQs3enc3D6

B) A 116 MB Dark frame footage file shot at  exactly the same settings as in A) but with the lens cap on.  Download link:

https://we.tl/Y1eg2hf84d

C) A 950 MB file shot with the Silent module of the 100D as a FRSP sequence (30 frames) to see how MLVApp hangs at the end of the export.  After waiting for several minutes, I pres Abort and get the usual message: MLVApp has stopped working.  Download link:

https://we.tl/BD5NQBikma

===================
I hope, this helps.  Links will be active for 7 days.
 
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 15, 2018, 07:34:58 PM
At this point, I would like to make a few suggestions for improvement that, in my opinion, will make MLVApp better and more user friendly:
------------------------------------------------------------------------------------------------------------------------------------------------------------

1) I am missing the White Balance Eye Dropper Tool and the Contrast Slider.  Right now, we have two sliders for the Dark and Light ranges and strengths.  In my opinion, it would be much more intuitive if the two pairs of sliders are replaced with single sliders called "Blacks" and "Whites", respectively.  This will make centering the histogram easier and save some time too.  And most important: MLVApp's interface  will become almost identical with ACR!

2) I am missing also the Monochrome Noise Reduction slider.  Right now, the Chroma Separation slider works miracles with killing the color noise.  Why not adding also a tool for monocrhome noise reduction, as in MLV Producer?

3) I fully agree with the other suggestions made in this thread (see posts #850, #851 and #917).  These will be very helpful.

4) One of the greatest features of MLVApp in my opinion is that it opens almost instantaneously.  I have made my file associations in such manner that files with MLV-extention open with MLVApp.  This makes the software a great replacement of the highly popular MLRAW Viewer that was unfortunately abandoned by his author.  Now, w.r.t. MLVApp, I have the following suggestions:

a) When more than one MLV files are selected in Explorer and dragged onto the  MLVApp icon, they should all open up as thumb nails in the session window.  This will make it easy to view the thumb nails of multiple files at a glance.  Right now, only the first of the highlighted MLV files gets loaded in the Session window.

b) I was wondering if it may be possible to get MLVApp creating thumbnail  previews of all MLV files in a folder right in Windows Explorer.  Windows does this with MOV and MP4 video files already.  Would it be possible to have thumbnail previews with MLV-files too?  This will make  lives of all of us a whole lot easier, especially when sorting, cleaning up, moving clips, etc.

5) The greatest feature of MLVApp is its ability to run on older computers and laptops which are not powerful enough to run software like DaVinci Resolve for example - important for mobility and field work.  On the other hand, MLVApp runs painfully slow, especially with larger resolutions.  I made a few speed tests rendering the same file with MLV Producer and then with MLVApp in H.264 format on the same laptop.  MLVApp is more than 3x slower.  On the other hand, I have noticed that I can open 3 or 4 times MLVApp, split my clips between them and have them render simultaneously.  This works and I notice substantial reduction in render times when I do that. This makes me wonder if MLVApp could be optimized in such manner that it uses multi threading in a more efficient way and run faster eventually.
--------------------------------------------

I am sure, the developers will feel totally overwhelmed by so many suggestions but please guys, take your time, see what is doable and what not and continue improving your amazing software step by step as you have been doing so far.   You are doing a great job and I am sure, many people in this community greatly appreciate your enormous efforts.  So, keep up your excellent work!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 15, 2018, 08:36:13 PM
Thank you but I could never manage to download files from wetransfer :(. Downloading ALWAYS stalls and can not be resumed.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 15, 2018, 08:44:00 PM
Nice feedback IDA_ML.
I tested around a bit with your darkframe and additional crop mode footage. The averaging effect is very subtle but it´s there. I tested in Switch(sorry Mlv app) but wanted to check fast what mlv_dump is producing.
Darkframe averaging will work best with stressed footage. A bit under exposed(shadows will be cleaned) and also color cast from lenses so if the footage is properly exposed and you are using some good lenses the averaging effect will probably be minor.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 15, 2018, 09:58:03 PM
Quote from: bouncyball on March 15, 2018, 08:36:13 PM
Thank you but I could never manage to download files from wetransfer :(. Downloading ALWAYS stalls and can not be resumed.

Bouncyball,

May I suggest that you ask Masc to download the files for you (a total of about 2,4 GB).  I uploaded for him big files with Wetransfer in the past and he always succeeded downloading them.

Quote from: Danne on March 15, 2018, 08:44:00 PM
Nice feedback IDA_ML.
I tested around a bit with your darkframe and additional crop mode footage. The averaging effect is very subtle but it´s there. I tested in Switch(sorry Mlv app) but wanted to check fast what mlv_dump is producing.
Darkframe averaging will work best with stressed footage. A bit under exposed(shadows will be cleaned) and also color cast from lenses so if the footage is properly exposed and you are using some good lenses the averaging effect will probably be minor.

Indeed, I used a good lens, Danne - the EF 24/2,8 IS.  Also, I try to expose to the right.  If the footage is underexposed, then the signal to noise ratio will be worse and at this high ISO (3200), the picture will look much noisier.  In that case, DF averaging and subtraction will probably not help much either.  That is why I think that a monochrome noise reduction, in combination with Chroma Separation will work better.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 15, 2018, 10:23:45 PM
Thanks for the uploads and all you wrote here... that's really a lot! :)

Your clip A: it seems there is another problem with your processor and MLVApp. On my Core2Duo on macOS I can export without any problem. @bouncyball: can you test on your Windows? Edit: hmm... you can't... I could try to upload it somewhere else for you... but that will need some time @60kB/s :D

Your clip B: Indeed there is only very low static noise in this clip. That is why you can't see something. I tried to subtract it averaged from clip A, and yes... I see a very tiny difference in the low right corner of frame 1 (dark area)... but it is soooo small the difference...

Your clip C: When MLVApp tells 100% on export, MLVApp has finished rendering - but ffmpeg is still on the run. For me ffmpeg run ~1min after MLVApp was at 100%. Then OK was shown. Maybe this takes still more time on your PC - I don't know - but ffmpeg is what the app is waiting for. You should see ffmpeg in task manager - if it is still running - just wait ;)

Your ideas:
1. Whitebalance picker is a thing we want to realize since a long time. It is realized in the GUI already (only invisible for now), but in the apps core the functionality is still missing. I hope Ilia will find the time on day to realize it. :)
Dark/Light Strengh/Range is different from black & whites & contrast in ACR. Maybe Ilia finds a way one day to add that additionally. I never missed it, because Dark/Light Strengh/Range can do more (it is only harder to understand what it does).

2. If someone knows algorithms which do desired tasks it is not such big deal to realize that. Until now I did not hear something about a noise reduction algorithm here... maybe Ilia has an idea?! ;) Would be cool, no question.

4a: You can't drag all files to MLVApp?! Okaaay... for me that was working even on Windows. What not works: "Open with" with more than one file on Windows - on macOS that was no problem (works different). I'll try to search for that...

4b: Hm... I don't know how to create special thumbnails. Could be another task for the future. ;)

5: Speed optimization is very hard to realize. H264 is one of the slowest codecs to export. Maybe the settings are different to MLV Producer - no idea what settings it uses. If you like having a fast export - ProRes with option Anatolyi is one of the fastest (at least for me).
It may be that opening MLVApp more than once and exporting is faster: MLVApp and ffmpeg has be to synced. For syncing we get nearly never 100% CPU for processors with more than 2 cores - but I don't know how to change that. But maybe we have other ideas in future how to make that better! :)

Thanks again for all you wrote!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 15, 2018, 10:37:19 PM
Tried this? Pretty fast:
-c:v libx264 -preset ultrafast -crf 10
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 15, 2018, 10:45:18 PM
Thanks @Danne. Maybe I add that as additional export option. Until now we use -preset medium -crf 24
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 15, 2018, 10:53:41 PM
Yes, lot of alternatives :).
By the way. Maybe multprocess exports working in parallell? I noticed exporting one instance of ffmpeg at the time is time consuming so I start off 4 processes in parallell and my computer fans start working :).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 16, 2018, 12:04:02 AM
Finally, to complete my feedback, I would like to share with you part of a private communication in which Bouncyball and I were discussing the question:

MLVApp versus MLV Producer:  Which one is better?
==================================

In my opinion, since both software products work perfectly on laptops that are not powerful enough to run professional video editors such as DaVinci Resolve, they both are well suited for travel, mobility and field work - for checking the video clips directly from the camera card using a card reader, performing basic corrections on the clips and archiving them in ProRes 422 or another editable format for further work on them later.  The main advantage of MLVApp vs. MLVProducer in my opinion are the natural and vivid colors that indeed are difficult, even sometimes impossible to achieve with Producer.   On the other hand, Producer offers more intuitive controls and is quite a bit faster at export.  My honest opinion is that both products do not compete but complement each other and are perfect for travel when you cannot take your powerful desktop  with you.   I have them both installed on my laptop and plan to use them as follows:

1) I would use MLVApp if I do not plan further color corrections or grading and also for archiving my clips, (b.t.w., I love the file sizes).  In this case I would just apply all corrections that I need in MLVApp and export the clips in ProRes422 or 422LT.  Then I would just cut and mount the entire movie with Filmora or some other simple software that works fine on my old laptop which I like to take with me while traveling.

2)  I would use Producer when I plan to perform the basic color corrections and grading later, on a powerful desktop with DaVinci Resolve.  In that case, I would import all clips into Producer, apply a flat profile and/or LUT and possibly some basic adjustments and export in ProResFast 4444, accepted as ProRes 422 by Resolve.  This goes really fast with Producer on the same laptop and file sizes are quite acceptable.  Then I simply get rid of the huge MLV files and save more than 75% disk space on my laptop.  All the rest I do on my desktop with Resolve  when I get back home.

Bottom line:
========

The developer of MLV Producer AWPStar and the developers of MLVApp have done a fantastic job with their advanced and powerful software which is perfectly suited for travel and mobility work on a laptop.  Both products complement each other and work very well with MLV files.  Hopefully, the authors will continue improving them and making them faster and more efficient.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 16, 2018, 06:57:44 AM
@Bouncyball: here you are: https://www.dropbox.com/s/4tv2bj2b877skuc/100D_1800x1012_MvCropMode_ISO3200.MLV?dl=0
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 16, 2018, 09:04:53 AM
@IDA_ML: if you like only fast export: deactivate RAW Corrections, set profile to a LOG curve and set in export settings AMaZE to Bilinear. Now your export should be more than 2x faster (in my example from 22sec to 9sec for exporting a special clip). For me, speed and look is very similar then to what MLV Producer exports.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 16, 2018, 10:03:36 AM
Thank you IDA_ML for such a comprehensive feedback! :)

Quote from: masc on March 15, 2018, 10:23:45 PM
Edit: hmm... you can't... I could try to upload it somewhere else for you... but that will need some time @60kB/s :D
Thank you! I've downloaded them now :)
All files importing and can be processed here on Linux 64 bit w/o an issue or crashes after fiddling with sliders correction etc. At home I have my kids' computer with old CPU and windows 7 on it, but I don't have access to it ATM.

Quote from: masc on March 15, 2018, 10:23:45 PM
I see a very tiny difference in the low right corner of frame 1 (dark area)... but it is soooo small the difference...
Yes static magenta noise contaminating colors is quite low here so difference is really subtle, anyway you always can look at histogram, it changes in the dark/shadows part when activating deactivating DF.

Quote from: masc on March 15, 2018, 10:23:45 PM
Dark/Light Strengh/Range is different from black & whites & contrast in ACR. Maybe Ilia finds a way one day to add that additionally. I never missed it, because Dark/Light Strengh/Range can do more (it is only harder to understand what it does).
All is said about WB picker so I'm not stopping to discuss this further :)
Regarding Dark/Light Strengh/Range sliders used in MLV App. I fully agree with @masc, they are very powerful and nice to operate when you used to it. They almost substitute Curves editor b/c you can alter whole range of the histo. In addition we have highlights and shadows sliders which BTW present in the windows binaries I posted for older CPU compatibility ;) despite we did not release this feature officially yet.

Regarding noise reduction: there is only chroma blur function which kinda cleans color noise but this is not the full blown wavelet based noise reduction and should be taken with a grain of salt :)

Quote from: masc on March 15, 2018, 10:23:45 PM
4b: Hm... I don't know how to create special thumbnails. Could be another task for the future. ;)
Here (https://en.wikipedia.org/wiki/Windows_Imaging_Component) is the explanation how this could be done for windows with Windows Imaging Component (WIC). Sorry but this is really out of the scope of the MLV App itself :). However windows programmers are always welcome to implement this kind of stuff.

Regarding export or playback speed: these can be altered by optimizing mlv app debayering/processing and ffmpeg behavior.

AFAIK mlvp uses ASM level optimised stuff and is quite fast.
Fast CinemaDNG uses directly CUDA and is blazing fast on my GTX1080.

We know that there is a lot of room for performance improvement and we really appreciate if anyone with spare time and more experience willing to join the project and help out.

Edit: now higher priority is the new color handling stuff added by Ilia and we are testing it, this concerns also more advanced white balancing and occasionally WB picker.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 16, 2018, 11:02:52 AM
@Danne

Added DF validity check. If it has more than 1 frame MLV App warns with the message box but does allow to load file anyway. Why? ;)

Now I regret I did not introduce dedicated DF file format for our proggie for the mlv_dump's compatibility sake. mlv_dump does not correct framecount in the header of averaged DF MLV and it has full frame count of the original clip in the header. So there is nothing to check and if used mlv_dump made DF we can not check the amount of frames correctly. It will fail as any other non DF MLV (now it just warns you but allow to use mlv_dump made DF).

Anyway it is sometimes interesting to see the effect of the subtracting any image from any image so let it be there with just warning :D (I'm too lazy to dig into mlv_dump again :P, besides if someone has a collection of DFs made by switch they already are made by old not patched mlv_dump)

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 16, 2018, 11:44:25 AM
Bouncyball and Masc,

I really am very satisfied with how you reacted to our suggestions for improvements.  With this kind of positive attitude and listening to the users, I am sure, MLVApp will continue to improve and become more efficient and powerful.  Thank you so much!

Bouncyball,

It looks like, that not only you but also your kids with their old CPU computer saved my MLVApp life by allowing you to reproduce my problem.  This is the reason why I never throw away my old computers.  You never know when you may need to use them again :-)))!  May I suggest that, before releasing a new build, you make sure that it also works on your kids' old computer?

Masc,

Thanks a lot for your very useful suggestions.  Of course, I will continue testing in trying to optimize my workflow and will report my findings.

Danne,

I am trying to figure out the darkframe averaging stuff and w.r.t. that I have a question to you too.  How important is it that darkframe footage is shot at exactly the same settings, (F-stop, focal length, ISO, shutter speed, etc.) as the clip that needs noise cleaning?  Can't I just shoot some darkframe footage for every lens that I use, at some reasonable ISO, (say 800) and then use this footage for creating an averaged frame for all the videos that I film with that lens?  What if the settings are different from those the clip was shot at?  Noise is noise - it's a random process, right?  Then why should it depend so much on particular settings?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 16, 2018, 12:37:51 PM
@IDA_ML
What lens you are using won't matter(check flat frame subtraction for this. Also included in mlv_dump).
Also check some basics evolving df subtraction and where it's primarily used and why:
https://en.m.wikipedia.org/wiki/Dark-frame_subtraction

Reason it's used in movie sequences are availability and automation procedures.
Dark frame automation is what it is. Sometimes the impact will be major, sometimes not. Removing cold/hot pixels, cleaning magenta cast, color noise, banding in shadows etc. It won't destroy image like a denoiser which I think is important since df could then be used on any footage with any lenses all the time. It will have an impact even at iso 100. You can check this by raising shadow parts which reveals canon sensor flaws and how it's cleaned with df.
Matching iso is vital. Maybe even shooting the df right after the regular footage was recorded but I have been using darkframes recorded on a different time with great results.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 16, 2018, 02:01:15 PM
Thanks a lot, Danne, I will experiment more with dark frames and will do what you suggested.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 16, 2018, 02:26:08 PM
Quote from: IDA_ML on March 16, 2018, 11:44:25 AM
It looks like, that not only you but also your kids with their old CPU computer saved my MLVApp life by allowing you to reproduce my problem.
:D

Quote from: IDA_ML on March 16, 2018, 11:44:25 AM
May I suggest that, before releasing a new build, you make sure that it also works on your kids' old computer?
Sure. The reason of this issue is known and patch committed to the repository additionally with Ilia's fine tuning :)

Quote from: Danne on March 16, 2018, 12:37:51 PM
Matching iso is vital. Maybe even shooting the df right after the regular footage was recorded but I have been using darkframes recorded on a different time with great results.
Danne's absolutely right, the roots of this suggestion came from the fact that when sensor is warming up the HW noise increases.

But we are not gonna process NASA photos, are we? :) So DF recorded with this particular camera and same settings earlier is OK.

BTW the video mode you are recording to also matters. Example: if you use same ISO for plain 1080p and crop_rec module enabled modes (even with the same resolution) the noise will be different because in some modes camera uses various bining and skipping, in some 1 to 1 readout and that 'in camera' processing affects output raw image, hence noise footprint.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 16, 2018, 03:13:24 PM
Thanks for this important clarification, Bouncyball.  Different noise at different shooting modes makes perfect sense.  I will probably generate several averaged DF at different ISOs and shooting modes for my 100D and use them whenever necessary.

At this moment another small improvement suggestion dawns on me.  Would it be possible to add to the "I" (information panel) the bit and compression settings for every clip, e.g. 8, 10, 11, 12 or 14 bits uncompressed or losslessly compressed video?  That would helpful too.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 16, 2018, 05:25:04 PM
Hmm... do you mean this info should be on the right side of the clip thumbnail in session list?

Otherwise here is the info panel examples with all the info you need (4th line from the bottom):

(https://thumb.ibb.co/c9pr4c/Screenshot_from_2018_03_16_20_13_53.png) (https://ibb.co/c9pr4c)

(https://thumb.ibb.co/mPbtHx/Screenshot_from_2018_03_16_20_14_46.png) (https://ibb.co/mPbtHx)

(https://thumb.ibb.co/iyePPc/Screenshot_from_2018_03_16_20_15_33.png) (https://ibb.co/iyePPc)


That info panel can be left open while double clicking on clips in session list and the info will update on every selection.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on March 16, 2018, 05:43:11 PM
Loving the app!  There is an old experimental version of the dual-iso.mo for the 5d2 that actually works pretty great!  The tough part was finding a post-processing workflow that worked for it.  The current version of switch works fine.

Unfortunately MLVApp has a hard time doing anything with it - my guess is that it's almost certainly a black level issue.

As I'm a complete fool for bleeding edge 5d2 stuff, I paired this experimental 12/10 bit build: https://www.magiclantern.fm/forum/index.php?topic=5601.msg198349#msg198349 (https://www.magiclantern.fm/forum/index.php?topic=5601.msg198349#msg198349)
with the dual-iso module, and attempted to do some darkframe subtraction as well.

Normal (non-dual) 10/12 bit stuff from that build works just perfectly in MLVApp.

By turning Switch to default settings, and then setting it to full-auto I was able to do 12 bit, dual-iso, darkframe subtraction in one fell swoop - which felt lucky.

Here's the problem - I end up with converted DNG's and would like to import them into MLVApp for editing/organizing.  I don't know of any way to repackage DNG's back into an MLV.

I know that's a lot of info, but I included some sample files, including the experimental Dual-Iso module here:
https://drive.google.com/open?id=1O2P64L0uvF3ai2GPuj3s5foJYL-rHyB9 (https://drive.google.com/open?id=1O2P64L0uvF3ai2GPuj3s5foJYL-rHyB9)





Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 16, 2018, 06:15:00 PM
Quote from: bouncyball on March 16, 2018, 05:25:04 PM
Hmm... do you mean this info should be on the right side of the clip thumbnail in session list?

There is a shooting mode called "8 ... 11 bit lossless" and the camera selects 8, 9, 10 or 11 bits automatically, dependent on the light and ISO.  I am not sure if MLVApp can recognize if the clip was shot at say 9 bits or 11 bits or it will interpret these numbers as 8 or 10 bits.  This is what I mean.  Other than that, the Info panel is great!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 16, 2018, 06:49:38 PM
@IDA_ML

Ah.. yes now I got it.

It's not possible to tell exact bit depth of those MLVs b/c in reality they are 14bit with restricted values (with amplified gain).

One can approximately say that the footage is 12bit lossless if 4500<white level<8000 and 8-11bits lossless if white level is less then 4500. Otherwise real 14bit data has >15000 value.

However I don't think that implementing this logic to the MLV App will give us the chance to make reliable assumption. This was one of the main reasons I added white/black levels to the Info Panel's 3rd line from the bottom :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 16, 2018, 07:03:29 PM
Quote from: jpegmasterjesse on March 16, 2018, 05:43:11 PM
Unfortunately MLVApp has a hard time doing anything with it - my guess is that it's almost certainly a black level issue.
I'm not sure what is the exact reason (full 20bit dualiso processing gives error and can not process this MLV). Preview mode does work. It is nice that you uploaded this sample. Can you also upload the dark frame original (not averaged) MLV for this 12bit clip?

Edit: Danne's doing some black magic with the switch/cr2hdr I guess ;)

Quote from: jpegmasterjesse on March 16, 2018, 05:43:11 PM
Here's the problem - I end up with converted DNG's and would like to import them into MLVApp for editing/organizing.  I don't know of any way to repackage DNG's back into an MLV.
It is possible and g3gg0 was doing this long time ago for experimenting/developing. However I can not imagine the use case of that backward conversion now :)

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: a1ex on March 16, 2018, 07:08:20 PM
Quote from: bouncyball on March 16, 2018, 06:49:38 PM
One can approximately say that the footage is 12bit lossless if 4500<white level<8000 and 8-11bits lossless if white level is less then 4500. Otherwise real 14bit data has >15000 value.

However I don't think that implementing this logic to the MLV App will give us the chance to make reliable assumption.

Using ceil(log2(white - black)) should be a reliable assumption, as this quantity is always 14 for 14-bit raw.

Examples:
ceil(log2(5586-2047)) = 12 (source (https://www.magiclantern.fm/forum/index.php?topic=19300.msg185746#msg185746))
ceil(log2(10500-2047)) = 14 (worst case; lowest white level I'm aware of at default settings is about 13500)

Displaying the fractional value of log2(white - black) should be fine as well, as you can see how many "bits" are lost because of the non-ideal black and white levels. In this case, the user can do the upper rounding to find the number of bits.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 16, 2018, 07:11:25 PM
Hehe :) fantastic! Thank you a1ex.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 16, 2018, 07:42:07 PM
Quote from: jpegmasterjesse on March 16, 2018, 05:43:11 PM
Unfortunately MLVApp has a hard time doing anything with it - my guess is that it's almost certainly a black level issue.

By turning Switch to default settings, and then setting it to full-auto I was able to do 12 bit, dual-iso, darkframe subtraction in one fell swoop - which felt lucky.

Interesting finding. I downloaded your file and it worked with my older version of mlv_dump (m) passing the dng to cr2hdr but cr2hdr wouldn´t recognise the dng files as dualiso if run with mlv_dump_on_steroids.

(https://s17.postimg.org/sib5drs2n/Screen_Shot_2018-03-16_at_19.35.14.png)

Code mlv_dump versions:
mlv_dump(ml-dng version)
https://bitbucket.org/Dannephoto/magic-lantern/branch/ml-dng-unified_11f

mlv_dump on steroids:
https://bitbucket.org/Dannephoto/magic-lantern_steroids/branch/mlv_dump-on-steroids

After some more testing it works also with mlv_dump on steroids if you set mlv output to 14bit:
(https://s17.postimg.org/e0dy60t4f/Screen_Shot_2018-03-16_at_19.49.35.png)


You can actually force dng to process as dualiso in later version of cr2hdr. Grab cr2hdr inside Switch and do following:
cr2hdr --force [drag your dng here]
The file won´t look good though but it forces through 12bit.





Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on March 17, 2018, 01:52:13 AM
Quote from: bouncyball on March 16, 2018, 07:03:29 PM
It is possible and g3gg0 was doing this long time ago for experimenting/developing. However I can not imagine the use case of that backward conversion now :)

After a (forced) update to High Sierra I am short on workflows for raw.  I used to use MLraw viewer but the .mov export no longer works on High Sierra.  MLVApp can't import DNGs (as far as I know) and premiere doesn't like the sequence either.  Even Lightroom crashes kinda frequently  after importing these  DNGs (although it's also been crashing dealing with standard 20bit dual iso files.) I haven't tried after effects yet.

So yes, it is backwards, but I'm low on options.

I will upgrade the dark frame in a few hours! It may not have actually worked as I tried it - it automatically ran dark frame subtraction without me providing mine.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 17, 2018, 06:48:57 AM
As Danne have stated it's because of cr2hdr (MLV App uses code derived from cr2hdr/mlvfs) needs real 14bit data on input to work properly. This is not the first time we have issues with 12bit dual iso MLVs. I'll take a look when have time and see what I can do about it. Guess it won't be hard to fix.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 17, 2018, 07:01:48 AM
@jpegmasterjesse

I guess you already have switch so grab mlv_dump from it and with this command convert bit depth:

./mlv_dump -b 14 -o output_14bit.mlv your_12bit.mlv

Then try to open it in MLV App, process as dualiso and report back please.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 17, 2018, 07:08:32 AM
Cool, didn't know you could convert the mlv file itself to other bits.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on March 17, 2018, 08:18:44 AM
Quote from: bouncyball on March 16, 2018, 07:03:29 PMCan you also upload the dark frame original (not averaged) MLV for this 12bit clip?

Here you go!
https://drive.google.com/open?id=1pMlInFFL2kb-TXY6rPeVbJTiWG8OXiYK (https://drive.google.com/open?id=1pMlInFFL2kb-TXY6rPeVbJTiWG8OXiYK)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on March 17, 2018, 08:25:09 AM
Quote from: bouncyball on March 17, 2018, 07:01:48 AM
@jpegmasterjesse

I guess you already have switch so grab mlv_dump from it and with this command convert bit depth:

./mlv_dump -b 14 -o output_14bit.mlv your_12bit.mlv

Then try to open it in MLV App, process as dualiso and report back please.

I wish I had the necessary knowledge! I'm a bit out of my depth.  Here's the 12 bit dual-iso file:
https://drive.google.com/open?id=1W9IG53Nn-AG1EWKV-trCVyfpPNt5VtTA (https://drive.google.com/open?id=1W9IG53Nn-AG1EWKV-trCVyfpPNt5VtTA)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 17, 2018, 09:36:46 AM
@jpegmasterjesse

Here (http://nic.caucasus.net/mlvapp/?dir=&download=14bit-dual-5d2-M16-1054.MLV) is your MLV converted to 14bit
Here (http://nic.caucasus.net/mlvapp/?dir=&download=M16-1053_14bit_DF.MLV) is the 14bit Dark frame ready to use

Import this 14bit MLV to MLV App and also load 14bit Dark frame into the Raw Correction. Now full blown 20bit dualiso processing is working as expected :)

@Danne: Thank you for quickly finding the cause of this issue :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Lars Steenhoff on March 18, 2018, 03:18:40 PM
Is it possible to make a cocoa version with thumbnails and dng export?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 18, 2018, 06:14:59 PM
If you like thumbnails you need a kind of extra program which is automatically driven by the OS, which opens all MLV in a folder and makes thumbnail pics (as I understood). If you are using cocoa or something else doesn't matter.
DNG export works already with MLVApp (which also uses cocoa on macOS).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 19, 2018, 07:54:40 AM
Ilia is a father of coca app, let's wait what he says.

BTW I've always been curious why GUI matters so much if functionality is what you need :) (I'm the guy who never pay attention to theming/skins/looks of applications but its functionality).

Example: Simple default GUI of the foobar2000 player is the best for me.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on March 19, 2018, 08:53:52 AM
One thing where I believe the Qt app is worse than cocoa app is the control sliders, you can't just click anywhere on the slider and start moving it, you have to click the knob, which feels a lot clunkier to me. Could you make the slider draggable from any position @masc?
Maybe those who like cocoa app would be happier if the Qt version had a simpler theme, but that isn't really a big deal for me.

As for Cocoa app coming back, probably not. It's currently in a bad mess and doesn't work fully (the last release is about as good as it is going to get). It's just too much work for what it does - it was written without XCode, no interface builder which I think Apple never intends anyone to do. Also written by me with no clue about how Objective C works (the real issue).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Lars Steenhoff on March 19, 2018, 10:50:36 AM
Ah you made it without xcode, wow yea I can understand.   

For me the reason why I like the cocoa version, it feels more native to Mac, and it also is easier to compile.

But I managed to compile the qt version, so thats allright now.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 19, 2018, 12:14:46 PM
Quote from: Ilia3101 on March 19, 2018, 08:53:52 AM
One thing where I believe the Qt app is worse than cocoa app is the control sliders, you can't just click anywhere on the slider and start moving it...
Haha, right. I never noticed this before :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 19, 2018, 01:48:25 PM
@jpegmasterjesse
Added -b(bit) function in a mlv_dump_on_steroids in Switch so it´s now possible to convert the MLV file itself for use in Mlv app for instance:

Select (12)
(https://s9.postimg.org/hayfknbi7/Screen_Shot_2018-03-19_at_13.55.52.png)

Select b for bits information
(https://s9.postimg.org/wjocyfcwf/Screen_Shot_2018-03-19_at_13.55.41.png)

Noticed that converting to different bits doesn´t work with lossless MLV files but works otherwise.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 19, 2018, 02:43:26 PM
@jpegmasterjesse, @Danne

I added 10/12bit Uncompressed dualiso support to MLV App (which is exactly your case). Link (https://github.com/ilia3101/MLV-App/commit/e0ffd06430227016ba06db5176db553341947cc6).

Lossless 8-11/12bit dualiso is not supported because it is very different and needs deeply digging into a1ex's cr2hdr code.

Anyway using dualiso means wide DR is needed, data bits less then 14 already restricts DR and this makes no sense b/c, during 14bit lossless raw recording, writing speed is good enough.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Bernie54 on March 19, 2018, 04:24:10 PM
MLV App v0.14 (latest version from bouncyball, btw, this now works well on a Core Duo PC - Thanks!) crashes at PNG Frame Export:

When trying to export single frames from a MLV taken with a EOS M (1728x692px) as a PNG file, Windows reports a crash an ends the app but a PNG was created with a black area - see example posted. This happens when the aspect ratio is set to "Height Stretch 1.67x" (works well with "Height Stretch 1.0x"). The bug appears on all the following configurations tested:
- MLV.App.v0.14.alpha.Win32 on a 32bit-Windows
- MLV.App.v0.14.alpha.Win32 on a 64bit-Windows
- MLV.App.v0.14.alpha.Win64.static on a 64bit-Windows

regards


(https://thumb.ibb.co/nkcAKc/Crash_PNG_Frame_Export_MLV_App_v0_14_win32_alpha.jpg) (https://ibb.co/nkcAKc)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 19, 2018, 04:51:30 PM
Nice.
I also noticed you can decompress and change bits in one take with mlv_dump and lossless will then become clean 10/12/14 bit or whatever you specify. For example apply this to a lossless file:
mlv_dump -d -b 10 -o OUT.MOV IN.MLV
Pretty nice.
As you point out dualiso is another parameter that will or will not work here...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 19, 2018, 05:29:47 PM
@Danne

Yes sure you can do both at the same time. But I think it is perfectly valid for real full range 14bit raw data only.

Losslessly compressed raw from the camera _always_ 14bits, even when you recording it as 8-11/12bit lossless with restricted values.

Converting 8-11bit lossless to, say 10bits, will result with very low converted to 10bit white level. For example as low as 350. Did you tried this and it worked as expected?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 19, 2018, 05:33:01 PM
I tried converting to 8bit back to 14bit. Sucked big time  :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 19, 2018, 05:33:47 PM
LOL
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 19, 2018, 06:39:36 PM
Another BUG in v. 014_old_CPU:
=====================

When I try to export Actual Frame, it exports it just fine as a .PNG file, even a thumbnail preview is shown in Explorer.  But when I try to open that PNG with Photoshop CS6, it (Photoshop) crashes.  It opens with FastStone Image Viewer and IrfanView fine but there is no EXIF data in that file.  I was wondering if the Actual Frame could be exported as a TIF-File containing all adjustments made in MLVApp, in the same resolution as in the video and if EXIF data could be added.

Also, MLVApp still crashes during rendering MLV files from the 100D that are about 1 GB in size.  I posted such a file a few days ago already but if you may need more files please let me know.  Could this stability bug be fixed?

AmaZe is AMAZING !!!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 19, 2018, 06:53:44 PM
As @Bernie54 stated in the message above there is a real problem exporting actual PNG frame. It is corrupted when the aspect ratio is set automatically to "Height Stretch 1.67x".

PNG corrupted example:

(https://thumb.ibb.co/b0hVKc/mv720_1736x688_Stretch1152_frame_1.png) (https://ibb.co/b0hVKc)


Exported TIFF frame is healthy.

@masc: Houston we've got a problem :) maybe something with buffer passed to QT image writer.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 19, 2018, 06:56:14 PM
@IDA_ML

Unfortunately I could not reproduce the crash on Linux with posted by you 100D MLV. Could you upload some more? I'll try it with older CPU under windows at home.

Edit: Fully processed frame(s) can be exported as 16bit TIFF through export settings dialog (ffmpeg exporter). For pixel peeping/quality checking it's the best.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 19, 2018, 09:18:47 PM
Quote from: Bernie54 on March 19, 2018, 04:24:10 PM
MLV App v0.14 (latest version from bouncyball, btw, this now works well on a Core Duo PC - Thanks!) crashes at PNG Frame Export:
When trying to export single frames from a MLV taken with a EOS M (1728x692px) as a PNG file, Windows reports a crash an ends the app but a PNG was created with a black area - see example posted. This happens when the aspect ratio is set to "Height Stretch 1.67x" (works well with "Height Stretch 1.0x").

Quote from: bouncyball on March 19, 2018, 06:53:44 PM
@masc: Houston we've got a problem :) maybe something with buffer passed to QT image writer.

@bouncyball... no no, no qt problem... I was a little stupid here. @bernie54: thanks for reporting! That was my fault and I fixed it now.

Quote from: IDA_ML on March 19, 2018, 06:39:36 PM
Another BUG in v. 014_old_CPU:
=====================

When I try to export Actual Frame, it exports it just fine as a .PNG file, even a thumbnail preview is shown in Explorer.  But when I try to open that PNG with Photoshop CS6, it (Photoshop) crashes.  It opens with FastStone Image Viewer and IrfanView fine but there is no EXIF data in that file.  I was wondering if the Actual Frame could be exported as a TIF-File containing all adjustments made in MLVApp, in the same resolution as in the video and if EXIF data could be added.

Hm, strange. I have no problem to open it in PS. There is no EXIF in the png, that is right. You can exort as TIFF via normal export. You should set cutIn and cutOut if you want only one frame.

Quote from: IDA_ML on March 19, 2018, 06:39:36 PM
Also, MLVApp still crashes during rendering MLV files from the 100D that are about 1 GB in size.  I posted such a file a few days ago already but if you may need more files please let me know.  Could this stability bug be fixed?

"Unfortunately" I don't get MLVApp to crash on my computers with your file - that's why I don't know what to fix :(

Quote from: Ilia3101 on March 19, 2018, 08:53:52 AM
One thing where I believe the Qt app is worse than cocoa app is the control sliders, you can't just click anywhere on the slider and start moving it, you have to click the knob, which feels a lot clunkier to me. Could you make the slider draggable from any position @masc?
Maybe those who like cocoa app would be happier if the Qt version had a simpler theme, but that isn't really a big deal for me.

Hehe, yes - there is another functionality in Qt: let the sliders jump in steps. I can set a step width. And if you click in the left or right of the handle, the slider jumps this width. At least I like this Qt feature - but it might be different from clean cocoa. But unfortunately I don't get the cocoa version compiled on my system... so I can't test atm how the sliders work there.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on March 19, 2018, 09:34:18 PM
It took some time, but now i added a Table of Contents to the english version of my mlvapp-compile guide for linux: https://sternenkarten.com/tutorial-englisch/
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 20, 2018, 08:46:00 AM
@escho: Great! :)

@masc: Now PNG frame export works flawlessly :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 20, 2018, 10:28:57 AM
Could need some help with compiling on mac. I get the following error codes:
(https://s9.postimg.cc/dz5n83u8f/Screen_Shot_2018-03-20_at_10.37.59.png)

(https://s9.postimg.cc/h606rqme7/Screen_Shot_2018-03-20_at_10.38.07.png)

(https://s9.postimg.cc/a2sbc3ttb/Screen_Shot_2018-03-20_at_10.38.13.png)


After some tinkering I removed an older Mlv app project and now QT is asking for stuff. Maybe this could clear out a few issues?
(https://s9.postimg.cc/eiaqgwo2n/Screen_Shot_2018-03-20_at_10.58.18.png)

(https://s9.postimg.cc/e49ehw45b/Screen_Shot_2018-03-20_at_10.58.28.png)

(https://s9.postimg.cc/d1z7zcdm7/Screen_Shot_2018-03-20_at_10.58.37.png)


Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 11:32:14 AM
@Danne: If I see it right you are on Qt 4.8.7. Minimum Qt for MLVApp is 5.6. So the compiler won't find some things we are using. The most compatible version should be 5.9.4 atm (support for most OSes), best performance should have 5.6/5.7.
On the "Configuration Project" page chose "clang 64bit" Release (& Debug if you like to debug).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 20, 2018, 11:37:21 AM
I compiled with Qt 5.10.2 on my mac mini without problem, however @masc doesn't like this version ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 11:55:51 AM
Hehe... I don't want to say I don't like 5.10. But 5.10 dropped support for some OS and has some stupid slider bugs. :)
But I recognized with my tests, that 5.7 is way faster then the newer versions. For me nearly factor 2 at playback on a MBP-Retina on OSX.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 20, 2018, 12:03:18 PM
Something is conflicting. I downloaded qr creator 5.9.3 and that is what I'm opening up but still it seems I have som old version still in there as well.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 12:09:07 PM
You downloaded only Creator, or the whole Qt? What does it output?

Here it looks like that:
(https://image.ibb.co/cehXzc/Bildschirmfoto_2018_03_20_um_12_09_57.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 20, 2018, 12:10:41 PM
Quote from: masc on March 20, 2018, 11:55:51 AM
But I recognized with my tests, that 5.7 is way faster then the newer versions. For me nearly factor 2 at playback on a MBP-Retina on OSX.
It is very interesting! I have to try this version under Linux. Is it performing better under windows too?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 12:13:02 PM
@bouncyball: I don't know. Under Windows my 32bit 5.6 is slower than your 64bit 5.9.1 - but 32 vs. 64 bit ... that is no real comparison.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 20, 2018, 01:17:29 PM
There is nothing when checking "kits".

When checking "about" this is showing:
(https://s9.postimg.cc/ve3nlgqbz/Screen_Shot_2018-03-20_at_13.21.01.png)
Qtcreator 4.4.1 based on 5.9.3??

Anyway. Here is what I downloaded and installed:
https://download.qt.io/official_releases/qt/5.9/5.9.3/qt-opensource-mac-x64-5.9.3.dmg
Coming from here:
https://download.qt.io/official_releases/qt/5.9/5.9.3/

It would really help if you would point to direct download links of which qt version most likely will work. In this particular case it´s even more problematic as since there are open source versions, commercial versions, the need for email adress etc. And the file itself is around 3.5gb  8)

Hopefully you can help me solve the issue :)


@bouncyball. Howdid you install QTcreator on your mac mini?


Ok, think I´m on to something:
Reinstalled and selected macOS this time:
(https://s9.postimg.cc/clwdvee3z/Screen_Shot_2018-03-20_at_14.02.48.png)

Now I get this:
(https://s9.postimg.cc/vqzn55l27/Screen_Shot_2018-03-20_at_14.06.38.png)

Will try to compile in a while....
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 20, 2018, 02:10:11 PM
Wohoo, compiling:
(https://s9.postimg.org/hodpq3v33/Screen_Shot_2018-03-20_at_14.17.40.png)

It´s smaller in size 38mb as opposed to 64mb from official version.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 20, 2018, 02:36:56 PM
@Danne

Congrats!!! Welcome to our club :)

Official version includes ffmpeg in the archive and also .app has structure with needed files.

You can compile it as debug or release version. Debug is good if you will find the bug/crash and the Qt creator debugger will show you exact line in the code where bail out has happened. Otherwise the release version a bit faster than debug version.

Hehe since you are real BugBuster I hope you will reveal some nasty ones, if any :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 03:06:00 PM
Woohoo, it works! NICE! Yes, you need to install Qt for macOS, otherwise you have no libs...

Your version is now smaller, that is right. It will work for now only on this particular mac (or another mac where Qt is installed in exactly the same way). The app gets its libraries from the Qt installation directory.

With (at least on my system) /Applications/Qt5.9.0/5.9/clang_64/bin/macdeployqt <path to MLVApp>/MLVApp/platform/build-MLVApp-Desktop_Qt_5_9_0_clang_64bit-Release/MLV\ App.app/ (adapt that to your system) you can insert the Qt libs into the app. But do this only once! If you compile after that again, the links inside the app are broken - it would not work on another mac, also if you do macdeployqt.
So always manually delete app -> build -> macdeployqt (at least if you like to deliver the binary).

In principle any Qt version newer 5.6 should work on most systems... (if OS is new enough)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 20, 2018, 04:24:37 PM
Quote from: masc on March 20, 2018, 03:06:00 PM
With (at least on my system) /Applications/Qt5.9.0/5.9/clang_64/bin/macdeployqt <path to MLVApp>/MLVApp/platform/build-MLVApp-Desktop_Qt_5_9_0_clang_64bit-Release/MLV\ App.app/ (adapt that to your system) you can insert the Qt libs into the app. But do this only once! If you compile after that again, the links inside the app are broken - it would not work on another mac, also if you do macdeployqt.
So always manually delete app -> build -> macdeployqt (at least if you like to deliver the binary).

I´m lost  :P. Could you add some more info about statically compile Mlv app?


I´m trying to follow this but can´t even find the src folder they are referring to:
https://doc.qt.io/archives/qq/qq09-mac-deployment.html#staticlinking

*update
Ok, so in terminal:
/Users/dan/Qt5.9.3/5.9.3/clang_64/bin/macdeployqt /Users/dan/MLV-App-master/platform/build-MLVApp-Desktop_Qt_5_9_3_clang_64bit-Debug/MLV\ App.app
Will beef my version to 62.4mb. That easy?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 04:27:36 PM
I have no idea what you want to try... :D
Just type the command I wrote and all will be fine... ;) In the end you won't see a difference on OSX if it is static or dynamically linked - you'll get a .app and you can doubleclick it in order to start MLVApp.

As I wrote:
1. delete MLVApp.app in your build folder.
2. compile with Creator.
3. type this macdeployqt command in terminal
Ready. Your app should have 62.x MB now and work on many Macs... (depends on your OS, your XCode,... thats why I use an old Mavericks to have a big compatibility from 10.8-10.13)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 20, 2018, 04:34:48 PM
Awesome!
Actually, I tested your suggestion and updated my answer just before you posted not knowing it was that easy :)

/Users/dan/Qt5.9.3/5.9.3/clang_64/bin/macdeployqt /Users/dan/MLV-App-master/platform/build-MLVApp-Desktop_Qt_5_9_3_clang_64bit-Debug/MLV\ App.app
All done! Size is 62.4MB

Thanks a lot for your help.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 04:38:40 PM
Cool! If your debug version is slow... compile as release - should be way faster! ;) Debug is good for searching a crashing line in the project. You can toggle in Creator in the low left corner (computer icon).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 20, 2018, 04:47:48 PM
Hell yeah. Added -j4 and went to release and twice as fast previewing. Feel free to have a look at my compiled baby  :P
https://bitbucket.org/Dannephoto/magic-lantern/downloads/MLV%20App.app.zip
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 05:58:06 PM
Looks good. But now it is getting compilcated... on which OS have you compiled? And with which XCode? Depending on this and some hidden settings in Qt you define the minimum OS on which the app will work. On 10.9 it does not work...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 20, 2018, 05:58:18 PM
Bouncyball,

I have now shot two more large files with the 100D for you to try on an old CPU computer and see if you can reproduce the crash issue.  The files were shot in the Normal 1736x976 and the Movie Crop Mode at 1800x1012 and download links are as follows:

100D_Norm_1736x976.MLV
-------------------------------
https://we.tl/IpIRL4TTao


100D_3x_MvCM_1800x1012.MLV
------------------------------------
https://we.tl/xRka2hENRH

Please note, the crash happens every time at different moments of the timeline - sometimes at 23%, sometimes at 85%, sometimes not at all but this is rarely the case.  So, please render them more than once, maybe at different MLVApp settings until you end up with  a crash event.  I also tested both files on a more powerful machine of a colleague of mine at work and they both rendered fine, without crashes.  So, the crash issue seems to occur only on old CPU machines under Windows x64.

You said, you fixed the Actual Frame export issue.  Is there a new old-CPU build with that bug fixed and if yes, where should I download it from?

Thanks.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 20, 2018, 06:34:03 PM
Quote from: masc on March 20, 2018, 05:58:06 PM
Looks good. But now it is getting compilcated... on which OS have you compiled? And with which XCode? Depending on this and some hidden settings in Qt you define the minimum OS on which the app will work. On 10.9 it does not work...

Compiled on mac OS Sierra and xcode 8.3

Tested just now also on Mac OS High Sierra and works buttersmooth on that workstation too. So backward compatibilty will be an issue. Couldn´t find the QT minimum OS setting anywhere.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 07:18:36 PM
Exactly... it is only backward compatible. Please don't ask exactly how to get it to work in the other direction - I got it only one time to work:
First you must get an older MacOS-SDK from apple - each OS has it's SDK. I have 10.9 and 10.10 here:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKsMacOSX10.9.sdk

Somehow this must be registered in XCode - but here I forgot how to do.

Then you must activate the SDK in Qt:
/Applications/Qt5.7.0/5.7/clang_64/mkspecs/macx-clang/qmake.conf

In this file there is a line with QMAKE_MACOSX_DEPLOYMENT_TARGET = 10.x
With this I got the compatibility in forward direction - at least up to 10.8... (SDK 10.9 seems to have 10.8 compatibility somehow)

Sry - I really forgot how I set this up some years before. Some month ago I tried another time and failed. Something is missing...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 20, 2018, 07:29:55 PM
I will take a dive some other day on this. Right now I am thinking about how to fire of a shell command from within Mlv app just to run darkframe storage scripts on my mac  :P. I´m sure bouncyball likes that idea  :P 8)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 20, 2018, 07:43:25 PM
A while ago we started ffmpeg from Qt as program command:

QProcess::execute( QString programCall );

But there are also other possibilities in Qt...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 20, 2018, 08:26:59 PM
Quote from: Danne on March 20, 2018, 07:29:55 PM
I will take a dive some other day on this. Right now I am thinking about how to fire of a shell command from within Mlv app just to run darkframe storage scripts on my mac  :P. I´m sure bouncyball likes that idea  :P 8)
Yeah why not we need more developers! :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 20, 2018, 08:30:54 PM
Quote from: IDA_ML on March 20, 2018, 05:58:18 PM
You said, you fixed the Actual Frame export issue.  Is there a new old-CPU build with that bug fixed and if yes, where should I download it from?
Yes masc fixed it but there is no release or compiled build for win yet. If you need to get highest quality frames from MLV App you need to export TIFF sequence. This PNG is just a quick show-me-the-frame thingy and is 8bit per channel. In contrary exported TIFFs are 16bit!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 20, 2018, 10:44:37 PM
One nice thing I noticed is that you can drag all MLV files onto Mlv app and the lot will open inside the application. Might be a really nice starting point calling Mlv app from a bash script in Switch for instance. Very nice previewing capabilities and toggling mlv functions on and off along with sliders makes it very intutive and useful.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on March 21, 2018, 12:51:13 AM
@Danne You can launch MLV App from bash with mac open command open -a "MLV App" file_1 file_2 file_3 This will launch default version of MLV app on the Mac and load all the specified files in to it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 21, 2018, 07:08:55 AM
Cool tip. I think I add some binding through that command in Switch for fast acces to Mlv app.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 21, 2018, 09:37:48 AM
Ah yes I also wanted to tell you that MLV App can be used from cli, however there are no interesting features accessible except importing of files.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 21, 2018, 10:00:42 AM
Perfect.
Added integration to Mlv App like following:
https://youtu.be/sDqZTzJRYlk

I could include the whole Mlv App package but I´d rather keep the already overweight "Switch" package on a strict diet nowadays  8).
Thank you all for a great tool.


Another question:
Is it possible to move on to the next MLV file when using the arrow keys(up or down)? Right now I can move the up or down but if I want to preview the file I also need an addittional step to double click the file before it becomes viewable/selected.
(https://s9.postimg.cc/g2h15m1pb/Screen_Shot_2018-03-21_at_10.16.23.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 21, 2018, 11:02:01 AM
@Danne: hehe, great! Thank you!

For changing the clip press J or K. You'll also find the actions in Playback menu (menubar).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 21, 2018, 11:12:43 AM
Quote from: masc on March 21, 2018, 11:02:01 AM
For changing the clip press J or K. You'll also find the actions in Playback menu (menubar).
Awesomeness!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 21, 2018, 11:15:33 AM
@masc I've been always curious why J/K and not something more intuitive :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 21, 2018, 11:38:18 AM
Quote from: bouncyball on March 21, 2018, 11:15:33 AM
@masc I've been always curious why J/K and not something more intuitive :)
Someone made a proposal, the keys were not used, so I realized that... :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 21, 2018, 11:44:23 AM
:D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 21, 2018, 12:06:50 PM
Quote from: masc on March 21, 2018, 11:38:18 AM
Someone made a proposal, the keys were not used, so I realized that... :)

Where are the keys specified in qt code? Searching but can´t find :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 21, 2018, 12:07:45 PM
Look into MainWindow.ui (under Forms in QtCreator) - in the designer window there is a list of actions.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on March 21, 2018, 12:45:15 PM
Quote from: bouncyball on March 19, 2018, 02:43:26 PM
@jpegmasterjesse, @Danne

Anyway using dualiso means wide DR is needed, data bits less then 14 already restricts DR and this makes no sense b/c, during 14bit lossless raw recording, writing speed is good enough.

Interesting - do we know the exact degree to which bit reduction reduces dynamic range?

I still greatly appreciate the easy work-arounds, in this case, as the 5d2 build I used to create the dual-iso 12 bit .mlvs has dysfunctional 14bit raw (I should test this again to be sure.)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 21, 2018, 03:49:50 PM
Quote from: IDA_ML on March 20, 2018, 05:58:18 PM
So, please render them more than once, maybe at different MLVApp settings until you end up with  a crash event.  I also tested both files on a more powerful machine of a colleague of mine at work and they both rendered fine, without crashes.  So, the crash issue seems to occur only on old CPU machines under Windows x64.
I've downloaded both files and tested them together with your older files on my Core2 Duo but unfortunately I could not reproduce crashes.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 21, 2018, 03:51:54 PM
@jpegmasterjesse

Latest MLV App directly supports your 12bit uncompressed dualiso MLVs recorded by 5D2. Ask @masc or @Danne for Mac build to test.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 21, 2018, 04:48:02 PM
Danne made a testbuild yesterday.
https://www.magiclantern.fm/forum/index.php?topic=20025.msg198721#msg198721
If you are using macOS 10.12 or 10.13 this should work.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 21, 2018, 06:46:16 PM
Quote from: bouncyball on March 21, 2018, 03:49:50 PM
I've downloaded both files and tested them together with your older files on my Core2 Duo but unfortunately I could not reproduce crashes.

Bouncyball,

I have just tested on my laptop the version that you sent to me this morning and IT WORKS WITHOUT CRASHES !!!  Please keep a good record of this version so you know what to do if crashes start occurring again.  Also the Actual Frame export works perfectly now.  Thank you so much!  I'll keep testing and report if I find further problems.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 21, 2018, 07:24:00 PM
Well there have been done some changes (fixes) since previously posted version, so I'm glad to hear that! :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: hjfilmspeed on March 22, 2018, 03:50:10 AM
Same!!! the version you sent me is still working great! I have an older CPU and I was having trouble with the other builds. The fast CDNG is awesome. I had some 5D3 footage today that didn't seem to have any vert stripes or bad pix so I blasted that out with the fast CDNG. This is becoming a super awesome MLV tool!!!! Great work!!!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 22, 2018, 02:06:55 PM
Now that I have played with MLVApp for more than a week, I have a few questions to Masc and Bouncyball:
------------------------------------------------------------------------------------------------------------------------

1) What is the difference between "AMaZe" and "Bilinear", as well as "Kostya" and "Anatolij" and how does this difference affect video quality?  Which combination of both parameters would you recommend for best video quality when exporting to ProRess422 or ProRes422 HQ for color grading and/or further processing in DaVinci Resolve?

2) I have noticed that the H.264 and H.265 codecs provide very compact file sizes, much smaller than DaVinci Resolve for example.  This means quite high compression.  Does this cause any visible loss of quality when exporting to the original MLV resolution or to some downsized resolutions, compared to DaVinci Resolve?  Have you performed any comparisons on that?

3) Now that Actual Frame export works so well, would it be possible to automate the process in such manner that, instead of exporting a PNG file, it exports it in 16-bit ProPhoto RGB TIFF at the resolution set in the export settings OR at the resolution of the original MLV video file (selectable option).  I know, I know, I asked this already and know that now this can be done with the Cut-In and Cut-Out option and subsequent TIFF export, but if the process is automated, just as this is the case with the PNG export at the cursor position, this would save some tweaking time.

4) Would it be possible to implement in MLVApp the possibility for opening video files that have already been saved in one of its own export formats (ProRes4444, ProRes422, H.264, etc.)?   This would be very useful for at least two practical reasons:

a) It would allow to extract an Actual Frame from those compressed videos to check quality of the final video clips;

b) This would allow small additional adjustments on certain clips to match basic adjustments between clips, clean color noise with Chroma separation, etc.
----------------------------

Thank you.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 22, 2018, 04:26:16 PM
Quote from: IDA_ML on March 22, 2018, 02:06:55 PM
1) What is the difference between "AMaZe" and "Bilinear", as well as "Kostya" and "Anatolij" and how does this difference affect video quality?  Which combination of both parameters would you recommend for best video quality when exporting to ProRess422 or ProRes422 HQ for color grading and/or further processing in DaVinci Resolve?
AMaZE and Bilinear are two types of debayer algorithms. Bilinear is ugly but fast, AMaZE is slower (on most machines) but amazing. Zoom 100% or more into the picture and toggle - you'll see a big difference in detail.

Kostya and Anatolij are two encoding algorithms from ffmpeg. I can't tell what the exact difference is - it is different. Mostly Anatolij is a bit faster for me... quality: I don't know.

If you grade in DaVinci, I would export as CDNG! When just cutting in FCPX I use ProRes4444.

Quote from: IDA_ML on March 22, 2018, 02:06:55 PM
2) I have noticed that the H.264 and H.265 codecs provide very compact file sizes, much smaller than DaVinci Resolve for example.  This means quite high compression.  Does this cause any visible loss of quality when exporting to the original MLV resolution or to some downsized resolutions, compared to DaVinci Resolve?  Have you performed any comparisons on that?
For these two codecs we set a medium crf 24 setting. I don't know what Resolve sets. Sure: H264 & H265 means always loss of quality. The resolution is what you set up - or what the clip is.

Quote from: IDA_ML on March 22, 2018, 02:06:55 PM
3) Now that Actual Frame export works so well, would it be possible to automate the process in such manner that, instead of exporting a PNG file, it exports it in 16-bit ProPhoto RGB TIFF at the resolution set in the export settings OR at the resolution of the original MLV video file (selectable option).  I know, I know, I asked this already and know that now this can be done with the Cut-In and Cut-Out option and subsequent TIFF export, but if the process is automated, just as this is the case with the PNG export at the cursor position, this would save some tweaking time.
The single frame export was a quick and easy function realized by Qt libs. Qt does not support 16bit graphics. That is why we added the ffmpeg 16bit TIFF option to the main clip export.

Quote from: IDA_ML on March 22, 2018, 02:06:55 PM
4) Would it be possible to implement in MLVApp the possibility for opening video files that have already been saved in one of its own export formats (ProRes4444, ProRes422, H.264, etc.)?
Nothing is impossible. But this would mean to reimplement nearly half of the low level functionality...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 22, 2018, 09:19:33 PM
Thanks a lot for this very comprehensive and informative reply, Masc.  MLVApp is great!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 22, 2018, 10:07:32 PM
Quote from: escho on March 19, 2018, 09:34:18 PM
It took some time, but now i added a Table of Contents to the english version of my mlvapp-compile guide for linux: https://sternenkarten.com/tutorial-englisch/

@escho: I linked your nice guide to the readme at github! Thanks for your work!

@IDA_ML: Thanks. If you have further questions, you can always ask ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 22, 2018, 10:50:05 PM
Yea, love this collaborative all in one mlv tool.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 23, 2018, 09:04:18 AM
@IDA_ML

1) Yes @masc already answered that. There are several popular debayer methods and on this scale Bilinear sits on the low end (not the last one thought) and Amaze sits on the upper end (not the 1st one as well, because it depends on raw source, can be achieved some better results with other methods in some cases). Overall Amaze is good almost for everything and it is quite universal. We are using very good and popular multi threaded open source lib a bit modified by @Ilia3101 and now it works great for canon raw.

I can't say anything about prores modes of ffmpeg. Just refer to the ffmpeg help/manual.

2) We are using ffmpeg H264 and H265 which are based on x264 and x265 sources. The constant quality level 24 (which is the default for MLV App) is the best you can achieve with it for reasonable file size and believe me x264/265 is the best codec ever written, better than almost every commercial encoders. I've read some while ago that there lots of commercial BluRay releases were encoded with it and not with other commercial encoders.

3) Yes we got rid of external 16bit PNG lib dependency and use Qt 8 bit PNG writer for quick export. 16bit TIFF export realized via ffmpeg and is great.

4) I don't think this will be implemented ever. Because there are small and convenient open source tools which do this for you. Example: under windows there is VirtuaDub-filtermod (https://sourceforge.net/projects/vdfiltermod/) which even supports cineform codec natively.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 23, 2018, 09:27:24 AM
Kostya prores4444 is better when I compare to Antoliy which is 422 but faster. I see a difference in shadows. This might not be an issue in Mlv App. I pipe through dcraw in Switch.
H.264 is as good looking as prores4444 to me. Only this format should be considered end product. H264 will not hold up in post as good.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 23, 2018, 12:24:52 PM
Thanks for this additional informationn Bouncyball and Danne,

The reason I am asking these questions is quite serious for me.  All my disk space (internal and external) is full of MLV files, most of which were shot in full uncompressed 14-bit MLV format before lossless was released about a year ago.  So, I desperately need to free up some disk space to store my RAW footage.  What I plan to do is use MLVApp to convert my MLV files into Kostya  ProRes 422 or ProRes 422 HQ after applying some basic corrections to them (Exposure, Temperature, Shadows/Highlights Dark/Light Strengths and Chroma Separation).  After that, I plan to store the converted files for further usage, mainly with DaVinci Resolve and delete the MLV originals which will free up 60 to 75% of disk space.  Initially, I wanted to archive in ProRes4444 but this will free up just 20-25% of disk space which is not enough.  If you guys share some more thoughts on that archiving issue, I should greatly appreciate that.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 23, 2018, 12:41:44 PM
Well you can save a lot of space by compressing the mlv files as well. Or you can also compress the cdng output and also save a lot of space that way.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on March 23, 2018, 12:42:00 PM
@IDA_ML

Just make sure that you are outputting in a Log Space. Like the Alexa Log-C. that way you simultaneously retain the most information from the MLV.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 23, 2018, 01:54:27 PM
Exporting as compressed MLV you can save around 35-40% without any loss of quality.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 23, 2018, 02:54:05 PM
Quote from: Kharak on March 23, 2018, 12:42:00 PM
Just make sure that you are outputting in a Log Space. Like the Alexa Log-C. that way you simultaneously retain the most information from the MLV.

Well, except for saving the files, I would like to take advantage of the adjustment features of MLVApp to apply some basic adjustments to the files and make them easier to work with later.  I am kind of reluctant to just apply a flat profile like Alexa Log-C and then save the file.  I want it to have at least some contrast and color.  So my question to you is:

Should I first apply the Alexa Log-C profile, then do my adjustments, listed in my previous post and finally save the file in ProRes 422 or ProRes 422 HQ format or you suggest that I leave the adjustments out and just save in Log?  In other words, how would you process and save a MLV file in MLVApp in such manner that:

1) You save the maximum amount of disk space and
2) Simultaneously retain most information?

Thanks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 23, 2018, 03:04:23 PM
Looks like you could benefit from canon wideDR. Not quite log but easier to work with.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 23, 2018, 03:37:36 PM
Quote from: Danne on March 23, 2018, 03:04:23 PM
Looks like you could benefit from canon wideDR. Not quite log but easier to work with.

Sorry Danne,

I don't understand what you mean.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 23, 2018, 04:12:58 PM
An alternative to log signal which sometimes is hard to work with in post there are friendlier output which you could make yourself in Mlv App by tweaking the settings. Canon WideDR is only an example.
There are math and a lot of philosophies which will take you where you want. Guess it all comes down to what you film and how you work and future plans.
There is also the parameter with color science which I don't fully grasp and where Mlv App is right now.
Many questions out there  :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on March 23, 2018, 04:58:05 PM
If i had to output to a compressed codec, then it would be straight to Log. And to not mess up the log file i would not mess with it other than setting correct wb and raise exposure to increase the files signal strenght (as needed).

Log-c is a really nice log, its easy to work with and is designed for higher DR than our cameras can capture.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on March 23, 2018, 11:55:00 PM
Quote from: Danne on March 23, 2018, 04:12:58 PM
There is also the parameter with color science which I don't fully grasp and where Mlv App is right now.

Colour science: MLV App is getting better in this soon. Current version has no camera calibration (those matrices not used), but in a version maybe two that will be implemented (as well as "correct" whitebalance stuff that g3gg0 was explaining ages ago) - You can have a preview of this stuff if you look at "WhiteBalance" branch on GitHub. Colour matches Davinci/Adobe quite well with new colour processing methods.

Output colour space: it's sRGB/rec709 I think. I hope we figure out how to encode in wider space with FFmpeg (already can with AVFoudnation), as output in other colour spaces will soon be supported in processing(watch that "WhiteBalance" branch).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 24, 2018, 07:25:15 AM
Really nice too hear :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Petter Sand on March 26, 2018, 04:14:50 PM
Hi! Thank you for making this software. I think it is super. I tried to process a dual iso MLV-file(HDR video). Is there any specifications that i have to follow when processing an dualiso HDR video file? I had a 1280 50p file from the latest nightlybuild on my 5dmk3. When processing  from mlv to prores the video is still flashing like these unprocessed HDR-videos do. I checked the box "on"  at the dualiso section. Please enlighten me. Best regards Petter
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 26, 2018, 05:10:37 PM
Magic lantern HDR video and dual iso are two very different things. HDR MLVs are not supported by MLV App for now. For HDR processing better use 'Switch' from @Danne. Ask him and he will help you for sure :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on March 26, 2018, 05:57:29 PM
@petter sand
In Switch main menu select (p) for prores output. Then select (01) or something else and also select HDR at the bottom then run Switch.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on March 27, 2018, 09:37:11 PM
"MLVApp has stopped working"

That is when I select a MLV File for Darkframe Subtraction option.

Any help?

Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on March 28, 2018, 12:49:35 AM
Quote from: Danne on March 24, 2018, 07:25:15 AM
Really nice too hear :)


Can I add more filters? any LUTs?
Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 28, 2018, 08:35:44 AM
Quote from: JADURCA on March 27, 2018, 09:37:11 PM
"MLVApp has stopped working"

That is when I select a MLV File for Darkframe Subtraction option.

Any help?

Thanks!

Could you please upload such a file and provide some more information (OS, version, ...). Thx.

Quote from: OlegK on March 28, 2018, 12:49:35 AM

Can I add more filters? any LUTs?
Thanks!

You can add one of the implemented filters. There is no LUT support atm.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on March 28, 2018, 07:14:49 PM
Quote from: masc on March 28, 2018, 08:35:44 AM
Could you please upload such a file and provide some more information (OS, version, ...). Thx.

You can add one of the implemented filters. There is no LUT support atm.

HOW I CAN DO THAT?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 28, 2018, 10:02:10 PM
Quote from: OlegK on March 28, 2018, 07:14:49 PM
HOW I CAN DO THAT?
? ? ?
Chose a filter and enable it.
(https://image.ibb.co/hVBGqS/Bildschirmfoto_2018_03_28_um_22_00_02.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on March 28, 2018, 11:17:46 PM
Quote from: masc on March 28, 2018, 08:35:44 AM
Could you please upload such a file and provide some more information (OS, version, ...). Thx.

You can add one of the implemented filters. There is no LUT support atm.

Here are the files => https://we.tl/UtdYLcW4Fw

M22-1506 (footage) and M27-1523 (darkframe)


Windows 10 Home, Version 1709, OS Build 16299.309

Using MLV.App.v0.14.alpha.Win64.static.zip

Magic Lantern version: crop_rec_4k.2017Oct28.5D3113
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 29, 2018, 09:33:26 AM
Thanks @JADURCA! I load and try to analyze.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 29, 2018, 09:49:16 AM
@JADURCA: this bug is already fixed, but not yet released. For darkframes lossless is not supported - but this is no problem for you. I think you tried to load the full MLV as darkframe - this is the problem. First you need to load the darkframe clip to the session as normal clip (here lossless is supported). Then export it as averaged MLV (now it is not lossless). This file now can be loaded as darkframe to your clip. Always when using the darkframe feature it must be an MLV with ONE frame (best averaged with our average MLV export).

In v0.14 MLVApp was not that stable when loading something else than we expected. In the actual revision on github the app won't crash and will give some informative message boxes. You will get that with v0.15 ...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on March 29, 2018, 11:59:49 AM
@JADURCA

Download this (http://nic.caucasus.net/mlvapp/?dir=&download=MLV.App.de82432.Win64.static.zip) and it should work.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: nicolaselhani on March 29, 2018, 03:58:21 PM
Hello,

New to ML in general, and just jumped ship from MLRawViewer thread, where unfortunately exporting in ProRes is not compatible with High Sierra. I was recommended to try MLV App, and so far it is great. I did go through a lot of the threads on this forum and some of the posts on this thread.

I have a couple of issues if anyone could of any help. I'm sorry in advance if the questions have been previously answered as I did keyword searches and didn't find much.

1. For white balance, I know there's a bump on including a picker for the future. But for the 'Temperature' it seems that the cooler I move the slider towards 2000K, the image does respond and get properly cool/blue. But as I move the slider towards the warm end of the spectrum there seems to be very little if any change to the image, is this a know issue?

2. During Playback of the MLV in the preview window, I usually get 17-20 fps on a 24 fps file. Is this normal? I tried changing the Debayer for Preview Setting from Bilinear to Amaze to Amaze Cached. The Amaze and Amaze Cached both played back files at half the Bilinear (10-12 fps), even when I left the Amaze Cache, cache the video it made no difference.

3. For exporting, what is the most used/popular setting for ffmpeg and Debayer?

I shoot on a 5DM2 1856*1044 @ 23.976 fps 14-bit uncompressed. Running MLV app on a 2013 MBPr.

Thanks for all your help,

Nicolas
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 29, 2018, 04:21:48 PM
Quote from: nicolaselhani on March 29, 2018, 03:58:21 PM
1. For white balance, I know there's a bump on including a picker for the future. But for the 'Temperature' it seems that the cooler I move the slider towards 2000K, the image does respond and get properly cool/blue. But as I move the slider towards the warm end of the spectrum there seems to be very little if any change to the image, is this a know issue?
A picker is planned and realized in GUI already (but is hidden until low level functionality is implemented). That will come in the future when Ilia finds time to realize it. The issue with cold=blue vs. warm I don't understand. Maybe you must try to explain more what your issue is.

Quote from: nicolaselhani on March 29, 2018, 03:58:21 PM
2. During Playback of the MLV in the preview window, I usually get 17-20 fps on a 24 fps file. Is this normal? I tried changing the Debayer for Preview Setting from Bilinear to Amaze to Amaze Cached. The Amaze and Amaze Cached both played back files at half the Bilinear (10-12 fps), even when I left the Amaze Cache, cache the video it made no difference.
17-20 fps on a MBP 2013 is really superb! I get 8 fps on my MBP 2013! MLVApp shows as many frames your CPU is capable to render in time. AMaZE is slower but better than Bilinear. With AMaZE cache: activate it and wait until status bar tells "idle" again - then start playback. Caching needs some time. It should be way faster then AMaZE without caching (when clip is in cache).
But even if MLVApp shows 10 fps - in "dropmode" each shown frame is synced to realtime and audio - so it doesn't matter what your "real" fps is.

Quote from: nicolaselhani on March 29, 2018, 03:58:21 PM
3. For exporting, what is the most used/popular setting for ffmpeg and Debayer?

I shoot on a 5DM2 1856*1044 @ 23.976 fps 14-bit uncompressed. Running MLV app on a 2013 MBPr.
For exporting it is a question of your workflow, so I can't answer the question. I cut mostly on FCPX and use ProRes4444 with AMaZE, but this is my workflow - yours may be different.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: nicolaselhani on March 29, 2018, 06:18:42 PM
masc thanks so much for your quick reply.

that's good to know that fps is outputting better than expected, because i came from a trial with MLRawViewer, where it played back every frame in real time without using much cpu, maybe it was using some form of low res cached proxy? but it's good to know it's normal behavior on MLV App.

for the exporting, I cut mostly on FCPX as well, you picked AMaZE because it renders closer to the original RAW video than Bilinear?
I just exported the same video using ffmpeg Kostya and Apple AVFoundation, but cannot seem to tell the difference. Do you use the standard ffmpeg Kostya?

For the white balance temperature example, here are a couple of screenshots showing cool (2000K) neutral (5500K) and warm (10000K) as you can see the difference between neutral and warm is negligible, but when I modify white balance in for example MLRawViewer there is a pronounced difference between neutral and warm.

Thanks again for your help,

Nick


(https://thumb.ibb.co/joEczn/1.png) (https://ibb.co/joEczn)

(https://thumb.ibb.co/mZ7KC7/2.png) (https://ibb.co/mZ7KC7)

(https://thumb.ibb.co/dG89C7/3.png) (https://ibb.co/dG89C7)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 29, 2018, 06:25:28 PM
Masc,

Based on your own experience, is there much difference in the quality of the MLVApp-adjusted and exported file between the ProRes4444 and ProRes422_HQ formats?  My impression is that the quality difference between the two export formats is visually very subtle to nonexistent even when pixel peeping files with quite extreme MLVApp adjustments, filters, etc..  However the  ProRes422_HQ format provides a substantial file size reduction (2,5 to 3x) compared to ProRes4444.  Could you please let us know in what practical cases, again in your opinion, ProRes4444 will provide a substantial advantage, compared to ProRes422_HQ?  And in what cases you are not satisfied with ProRes422_HQ?

Thanks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 29, 2018, 06:59:29 PM
Quote from: nicolaselhani on March 29, 2018, 06:18:42 PM
that's good to know that fps is outputting better than expected, because i came from a trial with MLRawViewer, where it played back every frame in real time without using much cpu, maybe it was using some form of low res cached proxy? but it's good to know it's normal behavior on MLV App.
MlRawViewer uses GPU, that is why it is so fast if you have a GPU - but it is also why it does not run at all if you don't have a GPU (my problem for years and the main reason why I help developing MLVApp).

Quote from: nicolaselhani on March 29, 2018, 06:18:42 PM
for the exporting, I cut mostly on FCPX as well, you picked AMaZE because it renders closer to the original RAW video than Bilinear?
I just exported the same video using ffmpeg Kostya and Apple AVFoundation, but cannot seem to tell the difference. Do you use the standard ffmpeg Kostya?
AMaZE and Bilinear are debayering algorithms. You can zoom to 100% and change between them - mostly you'll see the difference!

AVFoundation is better regarding colors, but we don't support audio here atm (is also in work if there is time or someone else can help us with that). I mostly use ffmpeg, because I need sound.

Quote from: nicolaselhani on March 29, 2018, 06:18:42 PM
For the white balance temperature example, here are a couple of screenshots showing cool (2000K) neutral (5500K) and warm (10000K) as you can see the difference between neutral and warm is negligible, but when I modify white balance in for example MLRawViewer there is a pronounced difference between neutral and warm.
Ah okay. I see. Hmmm... I think that depends on the image you have and the light in it... I have other example pictures which are really orange and never get blue :)
Since some weeks Ilia is working an a completely new white balance algorithm which shall fit better with all cameras and not only 5D2. We'll see what this changes...

@IDA_ML: indeed at least for clips from my camera I see a difference in quality between prores422hq and prores4444. Especially when I used my EF16-35mm 2.8 II, where I can have much details in trees or houses, the very fine detail got here and there lost when using 422HQ. I had no such problem with prores4444 - that is why I use it. And I've seen it already at 1:1 on a HD screen - without pixelpeeping. If you don't see a difference in your clips - go with 422HQ - as you wrote - it is way smaller on your HDD what is also nice!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: nicolaselhani on March 29, 2018, 07:38:56 PM
masc, thanks again for your in-depth answers and explanations, really helps a lot.

Since I don't use audio at all on MLV files, I think I'll just Apple's AVFoundation, thanks for the precision.

Looking forward to the new white balance algorithm we've been hearing so much about.

In the meantime I'll enjoy this amazing application.

Thanks for all your good work.

Nick
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on March 29, 2018, 09:08:33 PM
A big THANKS from me too, Masc.  Keep up the excellent work!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on March 29, 2018, 11:23:54 PM
Quote from: masc on March 28, 2018, 10:02:10 PM
? ? ?
Chose a filter and enable it.
(https://image.ibb.co/hVBGqS/Bildschirmfoto_2018_03_28_um_22_00_02.png)

Custom filter/
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on March 29, 2018, 11:59:29 PM
Quote from: OlegK on March 29, 2018, 11:23:54 PM
Custom filter/
Can be added in C code. You'll have to train the neuronal network and add the result to the app.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: OlegK on March 30, 2018, 12:07:55 AM
Quote from: masc on March 29, 2018, 11:59:29 PM
Can be added in C code. You'll have to train the neuronal network and add the result to the app.

don't know nothing about it, but tanks! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on April 01, 2018, 09:11:24 AM
MLV App 0.15alpha (https://github.com/ilia3101/MLV-App/releases) released. Downloads. (https://ilia3101.github.io/MLV-App/)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: sveinpetter on April 01, 2018, 01:14:18 PM
Hhmm, I get an error when I try to unzipp win 64
-News....
Tried many times, always error , also with 7zip.
Then I tried 7-zip, open, opens ok. In that view of 7-zip, MLVApp.exe don't show compressed size.

From that view, its ok with unzip.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 01, 2018, 03:03:58 PM
Quote from: bouncyball on April 01, 2018, 09:11:24 AM
MLV App 0.15alpha (https://github.com/ilia3101/MLV-App/releases) released. Downloads. (https://ilia3101.github.io/MLV-App/)
New in this version is:
- Shadows & Highlights sliders and processing (finally! yeah! But: still slows down playback and export when used!)
- Colored whitebalance sliders
- Added upside down mode
- Added colorspace correction on all ffmpeg exports
- Added export codecs: DNxHD, DNxHR
- better sync between video & audio
- Bugfix: more stability on old Windows computers on startup
- Bugfix: app was crashing when changing clips and preparing export
- Bugfix: single frame PNG export failed if aspect ratio was not set to 1.0
- Further minor bugfixes and enhancements

(https://user-images.githubusercontent.com/30245296/37848667-37aea932-2ed5-11e8-9373-88ef728e5ef8.png)

Minimum OS:
- OSX 10.8.5 Mountain Lion
- Windows 7

Known issues:
- still no caching for Win32
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dariSSight on April 01, 2018, 04:20:16 PM
Thanks for MLV app, I will shoot a wide range of video clips this week to test the range quality of my Canon 5D Mark II (Dynamic Range, Sharpness, Color Vivid, Natural Mosiac/Aliasing Preventions and Clean Upconversion Range). I have decided to divert from my normal post process (MLV 2.0 Files to MLVFS to Adobe AfterEffect to Adobe Camera RAW to ProRes4444XQ to Final Cut Pro X or Premiere Pro CC 2018), instead use your MLV app. Any tips or steps that would give me the cleanest Video Clips to import into Final Cut Pro X or Premiere Pro, What is your most stable firmware release that you're  testing your app with, and are you using a Canon 5D Mark II? Also are you guys think about input a upscaling algorithm system that would be accurate to adding pixel that would be true to image processing, something like what Sharp did on their Quattron Plus models (example Sharp AQUOS Quattron +). Finally did you guys make a tutorial, I'll look but I thought I ask. I know it's a lot but your answer to these questions should help most novice Magic Lantern user get closer to a stable workflow. Thanks again
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 01, 2018, 06:44:48 PM
Quote from: dariSSight on April 01, 2018, 04:20:16 PM
Any tips or steps that would give me the cleanest Video Clips to import into Final Cut Pro X or Premiere Pro,
Just set all up as you like, export using AMaZE and chose the codec you like the most.
Quote from: dariSSight on April 01, 2018, 04:20:16 PM
What is your most stable firmware release that you're  testing your app with, and are you using a Canon 5D Mark II?
Ilia and me, we both own a 5D2. I use the nightly build from 2017Mar30 without problems. Maybe I could update - but I don't miss anything and for me it is very stable. When testing we have a big set of files from users of all cameras and versions... when something does not work - upload the file for us and we will search!
Quote from: dariSSight on April 01, 2018, 04:20:16 PM
Also are you guys think about input a upscaling algorithm system that would be accurate to adding pixel that would be true to image processing, something like what Sharp did on their Quattron Plus models (example Sharp AQUOS Quattron +).
Not yet. For now we use the ffmpeg scaling filter for resizing. If you have algorithms or source code for that, it might be easier to add it to the app.
Quote from: dariSSight on April 01, 2018, 04:20:16 PM
Finally did you guys make a tutorial, I'll look but I thought I ask.
No, we did not make a tutorial for using it - @escho made a tutorial for building it on Linux. We think the app is very easy to use - if you know Lightroom, you won't have big problems to use it. (I think - again: let us know if you have problems!)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 02, 2018, 09:58:47 AM
Quote from: sveinpetter on April 01, 2018, 01:14:18 PM
Hhmm, I get an error when I try to unzipp win 64
Thanks for the information! @bouncyball: I also don't get it unzipped. Is there something wrong or can someone unpack it? The zip file is around 5MB too small... :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on April 02, 2018, 10:40:11 AM
I was able to unzip it using 7-zip.  It's working fine despite the reduced file size.  Good work, developers!

Masc,

I have a question.  In what cases would you use DNxHD or DNxHR and what is the difference in video quality compared to ProRes422?  I love the reduced file size of these two added codecs.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 02, 2018, 11:21:07 AM
Quote from: IDA_ML on April 02, 2018, 10:40:11 AM
I was able to unzip it using 7-zip.  It's working fine despite the reduced file size.  Good work, developers!

Masc,

I have a question.  In what cases would you use DNxHD or DNxHR and what is the difference in video quality compared to ProRes422?  I love the reduced file size of these two added codecs.
For you it works?! Okay, cool. What do you mean with reduced file size?

Hehe, I would not use DNxHD or DNxHR at all, because it does not fit in my workflow and the resolution is very limited. But there was a user asking for it, so I added the codec. I am sure there are reasons for chosing these codecs... ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on April 02, 2018, 11:32:17 AM
Quote from: masc on April 02, 2018, 11:21:07 AM
What do you mean with reduced file size?

The zipped file of v.015 is 20,6 MB vs. 26,5 MB of the previous version I used.  Probably it was compressed with 7-zip or some other compressor that provides higher compression ratio.

As far as DNxHD and DNxHR codecs are concerned, clips exported with them are 40-50% smaler in size compared to ProRes422 exports.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on April 02, 2018, 05:47:42 PM
@dariSSight masc's advice is good I agree with all of it. However I always use a 10/12 bit build for the 5D2, it's surprisingly stable, the reduced bits saves space when recording in crop mode(however it corrupts normal shots because it's not fully working yet). mlv_lite also gives a bit more horizontal resolution: 1880x1056 vs 1856x1044, but I don't use it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: hjfilmspeed on April 03, 2018, 05:36:53 AM
I can't wait to try the newest build! I love this!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on April 03, 2018, 06:08:32 AM
MLV App v0.15 is superb. i love it
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Petter Sand on April 03, 2018, 01:28:03 PM
Hi! Thanks for developing this App. Here is some feedback.
I noticed some vertical lines in the blue in this picture:

https://www.dropbox.com/s/7sl296msl7vdoli/windmill.jpg?dl=0

I had enabled RAW correction and vertical stripes (normal)
I have the MLV App v0.14 alpha. Use it with this build: Latest Build (2018-02-04 01:12)    5DMK3 FW. 1.2.3
Any suggestions on how to proceed to get rid of the lines? Thankful for help.
Best regards Petter

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 03, 2018, 01:58:33 PM
@Petter Sand
Upload the MLV file.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 03, 2018, 03:54:38 PM
@Petter Sand: please upload the MLV or at least some frames of the MLV (you can export as MLV and set cutIn&cutOut before). We will analyse what is going on there...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on April 03, 2018, 04:04:47 PM
@Danne and @masc

Can Vertical Stripes (Force) enabled correct @Petter Sand footage?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: hjfilmspeed on April 03, 2018, 05:17:55 PM
MLV.App.v0.15.alpha.Win32.zip worked great! Unfortunately I couldn't get the MLV.App.v0.15.alpha.Win64.static.zip version to extract from the zip.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dariSSight on April 03, 2018, 06:53:25 PM
Quote from: Ilia3101 on April 02, 2018, 05:47:42 PM
@dariSSight masc's advice is good I agree with all of it. However I always use a 10/12 bit build for the 5D2, it's surprisingly stable, the reduced bits saves space when recording in crop mode(however it corrupts normal shots because it's not fully working yet). mlv_lite also gives a bit more horizontal resolution: 1880x1056 vs 1856x1044, but I don't use it.

I love to test out the lower bit but Where can i get the 10/12 bit build you're using, also which build do you recommend for mlv_lite for 1880x1056?
Thanks for the Advice
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Petter Sand on April 03, 2018, 09:25:48 PM
@Danne.  @ Masc
here is link to MLV file.  https://www.dropbox.com/s/iq0faj0tpqb6n26/M29-1034.MLV?dl=0

I zoomed in in MLV APP, looking at the actual MLV file, seems to be burned in the MLV-file.


(https://thumb.ibb.co/cqqKmc/Sk_rmklipp_2018_04_03_21_43_02.png) (https://ibb.co/cqqKmc)


(i used MLV.App.v0.15.alpha.)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 03, 2018, 10:05:16 PM
Quote from: Petter Sand on April 03, 2018, 09:25:48 PM
@Danne.  @ Masc
here is link to MLV file.  https://www.dropbox.com/s/iq0faj0tpqb6n26/M29-1034.MLV?dl=0

I zoomed in in MLV APP, looking at the actual MLV file, seems to be burned in the MLV-file.


(https://thumb.ibb.co/cqqKmc/Sk_rmklipp_2018_04_03_21_43_02.png) (https://ibb.co/cqqKmc)


(i used MLV.App.v0.15.alpha.)
When opening your file I also have the stripes. But in RAW Correction group box there is the option "Vertical Stripes". If I set it to Normal or Force, the stripes are completely away. Which OS and which MLVApp version (32/64bit) do you use?
(https://image.ibb.co/hmVK4x/Bildschirmfoto_2018_04_03_um_22_03_06.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Petter Sand on April 03, 2018, 10:18:59 PM
@masc Thanks for your help. I get the same result as you now. I could be mistaken of course, beliving I had checked the box. Maybe I checked the pixel box instead.
Happy that it works. Puh! 

i am on Mac. (i used MLV.App.v0.15.alpha.)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 04, 2018, 04:55:49 PM
@Petter Sand: Thanks for your feedback. Good to hear that is works.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on April 04, 2018, 05:59:00 PM
no chroma separation

(https://thumb.ibb.co/ize6HH/chroma_before.png) (https://ibb.co/ize6HH)


chroma separation

(https://thumb.ibb.co/cHXU4x/chroma_after.png) (https://ibb.co/cHXU4x)


what i like most about this converter is the chroma separation. it works fantastic. i get annoying color moire in all my clips so this chroma separation is very useful. i can even see in peter sands's mlv so i test and here is the result
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theetech on April 04, 2018, 06:45:46 PM
Dear Developer & Fellow RAW Shooters,
I'm noob of ML RAW Shooting. sure there is something wrong or missing in my workflow. Could you please help me to fix. Using EOS-M Crop_rec ML Experimental Build

When I export 10-bit RAW to 444 PRORES (mov) in MLV APP I get static flickers on the Top like this
(https://thumb.ibb.co/kKnhrc/Screen_Shot_2018_04_05_at_12_34_57_AM.png) (https://ibb.co/kKnhrc)


When Playback in RAW I cannot find flickers
My Export Settings

(https://thumb.ibb.co/hnzqcH/Screen_Shot_2018_04_05_at_12_34_33_AM.png) (https://ibb.co/hnzqcH)


My File Info

(https://thumb.ibb.co/gSc7rc/Screen_Shot_2018_04_05_at_12_36_40_AM.png) (https://ibb.co/gSc7rc)



My MLV APP Version

(https://thumb.ibb.co/fZv5cH/Screen_Shot_2018_04_05_at_12_37_06_AM.png) (https://ibb.co/fZv5cH)



@Moderator,
Please forgive me If I'm not precise. I will correct next time....
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JADURCA on April 04, 2018, 06:47:55 PM
@andy kh

Why are you getting that moire and artifacts? I processed the same clip using ProRes444 and don't see anything like that.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on April 04, 2018, 06:53:52 PM
Quote from: JADURCA on April 04, 2018, 06:47:55 PM
@andy kh

Why are you getting that moire and artifacts? I processed the same clip using ProRes444 and don't see anything like that.

in peter sand's pic you hav to zoom in to see them
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 04, 2018, 07:36:04 PM
@theetech: please upload the MLV, or at least some frames of it (you can set cutIn & cutOut and export as MLV, but if you do so, check if that happens also for the shortend MLV). We will search what happens...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 04, 2018, 07:38:40 PM
@andy kh: I only get these artefacts when using bilinear... nothing like that with AMaZE. But I also love the chroma separation ;) Good work by Ilia.
(https://image.ibb.co/ePJx7H/Bildschirmfoto_2018_04_04_um_19_39_28.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on April 04, 2018, 08:55:19 PM
Quote from: masc on April 04, 2018, 07:38:40 PM
@andy kh: I only get these artefacts when using bilinear... nothing like that with AMaZE. But I also love the chroma separation ;) Good work by Ilia.
(https://image.ibb.co/ePJx7H/Bildschirmfoto_2018_04_04_um_19_39_28.png)

oh my bad. i have been using bilinear
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ultimatemale on April 05, 2018, 01:41:28 PM
Loving this new app but issue am having with it is when i drag a whole folder into it, it never accept the last recorded clip on the card. Anyone experiencing the same issue

Am on a mac and experiencing the problem with version version 14 and 15 of this app


(https://ibb.co/hpwNsH)


(https://thumb.ibb.co/hpwNsH/Screen_Shot_2018_04_05_at_12_49_51_copy.jpg) (https://ibb.co/hpwNsH)


Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 05, 2018, 02:10:32 PM
@ultimatemale: nope, never saw this. MLV App does not allow dropping folders... so you only drag the files in a folder? No problem for me. Could you please explain how exactly you do that?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ultimatemale on April 05, 2018, 07:16:31 PM
Quote from: masc on April 05, 2018, 02:10:32 PM
@ultimatemale: nope, never saw this. MLV App does not allow dropping folders... so you only drag the files in a folder? No problem for me. Could you please explain how exactly you do that?
I opened the folder and drag the whole clips into the app and for some reason it won't accept the last clip in that folder. Am talking about clips recorded with the usual MLV RAW build(not this new 4k RAW build)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 05, 2018, 09:42:28 PM
I am very sorry, but I can't reproduce that. In your picture, the message wrote about a file which were already opened. So somehow you try to open the last file twice...  ::)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theetech on April 06, 2018, 08:23:32 AM
Quote from: masc on April 04, 2018, 07:36:04 PM
@theetech: please upload the MLV, or at least some frames of it (you can set cutIn & cutOut and export as MLV, but if you do so, check if that happens also for the shortend MLV). We will search what happens...

Here is the Link to mlv file
https://drive.google.com/file/d/1nvfOpojT4ngAhQW5xIGWpVn_t33jIzHE/view?usp=sharing

I used the Magic Lantern Crop Rec 4K Latest Experimental Build
Crop mode 3x3 720p
10 bit RAW Recording
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ultimatemale on April 06, 2018, 02:25:23 PM
Quote from: masc on April 05, 2018, 09:42:28 PM
I am very sorry, but I can't reproduce that. In your picture, the message wrote about a file which were already opened. So somehow you try to open the last file twice...  ::)

It opened every file except for the last file and it says its corrupt (i only opened it once). But RAWmagic opens this file, so i know its not corrupt
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 06, 2018, 02:52:48 PM
Quote from: ultimatemale on April 06, 2018, 02:25:23 PM
It opened every file except for the last file and it says its corrupt (i only opened it once). But RAWmagic opens this file, so i know its not corrupt
What happens if you only open this file? The same? If yes, please upload it!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ultimatemale on April 06, 2018, 04:58:12 PM
Quote from: masc on April 06, 2018, 02:52:48 PM
What happens if you only open this file? The same? If yes, please upload it!
When i try opening just that file alone in the new MLV App, it says corrupt. It also happened with some other clips in other folders. Pls bear in mind these are files recorded in the usual MLV RAW build (not the new 4k build)
The files recorded with the 4k build all open fine though
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 06, 2018, 06:47:29 PM
Quote from: theetech on April 06, 2018, 08:23:32 AM
Here is the Link to mlv file
https://drive.google.com/file/d/1nvfOpojT4ngAhQW5xIGWpVn_t33jIzHE/view?usp=sharing

I used the Magic Lantern Crop Rec 4K Latest Experimental Build
Crop mode 3x3 720p
10 bit RAW Recording

Thanks for uploading! For me frame 30 of your clip is corrupted. But in MLVApp and in the exported file. Have you tested to open and export it with any other application? Was it the same? For me it looks like something went wrong while recording (clips from my 5D2 with an experimental build were similar).

Quote from: ultimatemale on April 06, 2018, 04:58:12 PM
When i try opening just that file alone in the new MLV App, it says corrupt. It also happened with some other clips in other folders. Pls bear in mind these are files recorded in the usual MLV RAW build (not the new 4k build)
The files recorded with the 4k build all open fine though

Okay. This is an important fact: The error does not only happen if you open all files of a folder. It happens for this special file! Bouncyball implemented many checks. These checks prevent the app from crashing. Something seems to be corrupted in your file. Are you able to open the file with another application? Is this file very big - could you please upload it? Bouncyball is in holiday this weel. When he is back he could analyse your file and tell you what is wrong with it - or in a better case: make MLVApp open it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 06, 2018, 07:44:03 PM
surely dng 29 is corrupted but it opens fine in Mlv app also when dragged to binary(through Switch). I´m on mac by the way:
(https://s18.postimg.cc/y51490wvt/Screen_Shot_2018-04-06_at_19.54.04.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: hjfilmspeed on April 07, 2018, 02:18:16 AM
Hmm I am not able to extract the windows 64bit version after downloading.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 07, 2018, 08:01:22 PM
Quote from: hjfilmspeed on April 07, 2018, 02:18:16 AM
Hmm I am not able to extract the windows 64bit version after downloading.
Same for me. Some posts before we had this topic already and someone got it opened:
Quote-News....
Tried many times, always error , also with 7zip.
Then I tried 7-zip, open, opens ok. In that view of 7-zip, MLVApp.exe don't show compressed size.
Atm bouncyball is in holiday. When he's back, maybe he can compress with standard zip and upload again...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: hjfilmspeed on April 07, 2018, 09:54:53 PM
Oh gotcha!!! Sorry I just love this app! Can't wait to play with the new release! Thank you!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 07, 2018, 10:26:58 PM
Ha! Now I got it unzipped and compressed it again with standard zip. It is uploaded for everybody who also had problems before... ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dariSSight on April 08, 2018, 02:59:13 PM
Quote from: Ilia3101 on April 02, 2018, 05:47:42 PM
@dariSSight masc's advice is good I agree with all of it. However I always use a 10/12 bit build for the 5D2, it's surprisingly stable, the reduced bits saves space when recording in crop mode(however it corrupts normal shots because it's not fully working yet). mlv_lite also gives a bit more horizontal resolution: 1880x1056 vs 1856x1044, but I don't use it.

I love to test out the lower bit but Where can i get the 10/12 bit build you're using, also which build do you recommend for mlv_lite for 1880x1056?
Thanks for the Advice
Also are you guys looking at the new ProRes RAW Codec from Apple?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 08, 2018, 07:46:45 PM
Quote from: dariSSight on April 08, 2018, 02:59:13 PM
Also are you guys looking at the new ProRes RAW Codec from Apple?
Until now I don't know if it is/will be supported by AVFoundation or ffmpeg. But from what I understood it is also RAW, in principle near to what cdng is. So what will bring it for this processing application? All parameters set in the app will get lost on export... you can't use the AMaZE debayer and all the other stuff. So the benefit would only be transcoding...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: zims on April 09, 2018, 05:25:41 PM
Super noob here! First of all this app is baked into my work flow at this point and I wanted to say how thankful I am!

In the section to the right side of the app where you can apply different logs (ex: Alexa Log C) it doesn't seem to actually write to the file after export. I import all of my clips into the app, "apply" Alexa Log to them and then hit export, however when I pop them into Premiere CC they look as if they don't have the log applied to them. What am I doing wrong?

Thanks a ton for the help guys :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on April 09, 2018, 05:44:23 PM
What format are you exporting to?

Cinemadng is a raw format and will not bake in log gammas or looks
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: zims on April 09, 2018, 05:46:11 PM
Quote from: Kharak on April 09, 2018, 05:44:23 PM
What format are you exporting to?

Cinemadng is a raw format and will not bake in log gammas or looks

Hah, of course. Yeah I'm exporting to CDNG. I shot ML Raw using my 5D2 and I want to work in Premiere with my CDNG's that look like Alexa Log C. Essentially what do I have to do to get those CDNG's to look like a basic Log?

Thanks a lot for replying! :) @kharak
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on April 09, 2018, 07:10:10 PM
Quote from: dariSSight on April 08, 2018, 02:59:13 PM
I love to test out the lower bit but Where can i get the 10/12 bit build you're using, also which build do you recommend for mlv_lite for 1880x1056?
Thanks for the Advice
You have to compile the 10/12bit branch yourself (it is the one that allows 1880x1056), I'll see if i can find a build on my computer, if not I'll compile it.
I'll send it to you.

Quote from: dariSSight on April 08, 2018, 02:59:13 PM
Also are you guys looking at the new ProRes RAW Codec from Apple?
Seems like its 100% proprietary and will take a while before anyone except big companies can put it to use. So not yet (possibly not for ages who knows).

Also download (https://ilia3101.github.io/MLV-App/) the new version everyone!!!
I see it has very few downloads compared to the old one. Improvements and bugfixes are important.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on April 09, 2018, 08:06:20 PM
Quote from: masc on April 07, 2018, 10:26:58 PM
Ha! Now I got it unzipped and compressed it again with standard zip. It is uploaded for everybody who also had problems before... ;)
Thanks, I was in a hurry and possibly archived it with .7z by default but named as .zip.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on April 09, 2018, 08:20:56 PM
If MLV App spits error like File Is Corrupted this means that the block size in the last read block header is wrong and when actual data is read and next block header offset calculated it did not start with "VIDF" signature. Hence unknown "X$5^" block can be printed out. Files like this actually also give address error in mlv_dump and it quits but all pre-error DNGs are leaved exported. MLV App indexes MLV in the beginning (to access all data by index) and if any block is corrupted just gives up to open it and spits error.

There is a way to heuristically search next VIDF header and try to go on extracting from it but this is wholly different story (try to handle corrupted MLVs) and is not implemented in the MLV App.

Edit: However it could be done this way: just stop indexing on corrupted bock and pretend this is the end of the MLV clip.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 09, 2018, 10:08:43 PM
Quote from: zims on April 09, 2018, 05:46:11 PM
Hah, of course. Yeah I'm exporting to CDNG. I shot ML Raw using my 5D2 and I want to work in Premiere with my CDNG's that look like Alexa Log C. Essentially what do I have to do to get those CDNG's to look like a basic Log?
CDNG (and MLV) export is incompatible to any log look, because it is RAW. You'll have to export using another non-RAW codec or you'll have to configure your NLE to make them look like log.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on April 10, 2018, 12:26:06 AM
@zims

As masc says, and I said in my first reply. CinemaDNG is a RAW format, you can not bake in a look or a Log Gamma. What you can do, is interpret the RAW data to Log-C. But I highly doubt Premiere can do that. I stopped using Premiere when they released 2015 version, so I am not familiar with what it offers today, but from every post about RAW and Premiere, it seems like the worst NLE at handling RAW files, Colour and in my experience, sound.

If you really need to work in Premiere, then you have to import the DNG's in After Effects and either buy Cinelog-C and follows its route of operation, or download Danne's Log-C DCP for Adobe Camera RAW(which I believe is only for 5D3). Then Dynamic Link your DNG's to Premiere, which in return then will run like shit in Premiere, which most likely will make you render Proxies of the Log-C footage.
Or perhaps, if possible, import DNGs in Premiere, finish the edit, dynamic link to AE change DCP to Log-C in ACR, and grade it back in Premiere (if that is your thing). I dont remember how the DNG's act when Dynamic Linked from Pr to AE, I think they behaved funky going that route. In my opinion, the entire Dynamic Link thing is not a functioning way with RAW footage, as ACR is CPU based and will completely hog down your edit, unless you are 100% done with the edit and only wants to apply the look/log in AE and dont touch any edit again in Pr, just render to final product, then yes... maybe..

In Resolve you can "interpret" the RAW data and set to your preferred Log Gamma and target Colour space. I don't think Premiere even knows the word 'Colour Space'.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: zims on April 10, 2018, 04:04:35 PM
Quote from: Kharak on April 10, 2018, 12:26:06 AM
@zims

As masc says, and I said in my first reply. CinemaDNG is a RAW format, you can not bake in a look or a Log Gamma. What you can do, is interpret the RAW data to Log-C. But I highly doubt Premiere can do that. I stopped using Premiere when they released 2015 version, so I am not familiar with what it offers today, but from every post about RAW and Premiere, it seems like the worst NLE at handling RAW files, Colour and in my experience, sound.

If you really need to work in Premiere, then you have to import the DNG's in After Effects and either buy Cinelog-C and follows its route of operation, or download Danne's Log-C DCP for Adobe Camera RAW(which I believe is only for 5D3). Then Dynamic Link your DNG's to Premiere, which in return then will run like shit in Premiere, which most likely will make you render Proxies of the Log-C footage.
Or perhaps, if possible, import DNGs in Premiere, finish the edit, dynamic link to AE change DCP to Log-C in ACR, and grade it back in Premiere (if that is your thing). I dont remember how the DNG's act when Dynamic Linked from Pr to AE, I think they behaved funky going that route. In my opinion, the entire Dynamic Link thing is not a functioning way with RAW footage, as ACR is CPU based and will completely hog down your edit, unless you are 100% done with the edit and only wants to apply the look/log in AE and dont touch any edit again in Pr, just render to final product, then yes... maybe..

In Resolve you can "interpret" the RAW data and set to your preferred Log Gamma and target Colour space. I don't think Premiere even knows the word 'Colour Space'.

Thanks a ton for the reply. Essentially my thought process is this: "Why go through all the trouble of capturing MLV if when I take it into my color grade it still has contrast and 'sweeteners' ". I cannot run Davinci on my current hardware. I was doing a project for a client on Davinci using 5D2 MLV and it was working great until it just refused to open the program. I researched for several days trying to find a fix or if this was a common issue. As of today, even after re-installing Davinci (after going in and deleting hidden archives and such) I still can't even open the program.

What you're saying about Dynamic Link is right, and that shit takes a ton of time ingesting and then making proxies and baking in that C-Log that you're talking about. That also isn't an option.

So my overall question is this: my MLV raw converted to CDNG is still going to have all the "information" of a raw it will just appear to have been sweetened? In other words, I will be able to adjust exposure and regain information in my shadows and highlights? If not then I see no point in shoot Magic Lantern Raw and might just bite the bullet and buy a Black Magic camera for the native log that it shoots.

Thanks again for your swift replies, guys.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 10, 2018, 04:30:29 PM
@zims: MLV and CDNG is more or less the same - it is RAW. Just "the bits and bytes look a little different". The only adjustments exported into CDNG over MLV is RAW-Correction. All other adjustments is for all the other export codecs - such as ProRes - but not for CDNG.
Note: if you have ML on your EOS or buy a BlackMagic Camera doesn't change anything here. You'll have the same problem: it always depends on how your grading/RAW-processing tool interprets RAW. Therefor you can use Davinci, ACR, ... or MLV App. 
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: zims on April 10, 2018, 04:34:03 PM
Quote from: masc on April 10, 2018, 04:30:29 PM
@zims: MLV and CDNG is more or less the same - it is RAW. The only adjustments exported into CDNG over MLV is RAW-Correction. All other adjustments is for all the other export codecs - such as ProRes - but not for CDNG. Note: if you have ML on your EOS or buy a BlackMagic Camera doesn't change anything here. You'll have the same problem: it always depends on how your grading tool interprets RAW. Therefor you can use Davinci, ACR, ... or MLV App.

@masc -> Is there a way I can get the MLV App to convert to CDNG while interpreting without sweetening? You say my software is going to interpret all of these files the same, Premiere, Davinci etc but you mention MLV App, how is this going to interpret my footage? When I try to make the adjustments in MLV App it doesn't apply the Alexa Log or whatever log I try and slap on there. Are you saying the sliders will actually bake into the file though? I haven't tried that yet.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 10, 2018, 04:41:47 PM
@zims: Yes, all these apps interpret RAW data. Each app does it a little different, but they do. And MLV App applies AlexaLog and all other sliders into the exported file: For all codecs, except CDNG and MLV, because they are RAW! Chose another codec and all settings are visible in the exported files.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: zims on April 10, 2018, 04:46:24 PM
Quote from: masc on April 10, 2018, 04:41:47 PM
@zims: Yes, all these apps interpret RAW data. Each app does it a little different, but they do. And MLV App applies AlexaLog and all other sliders into the exported file: For all codecs, except CDNG and MLV, because they are RAW! Chose another codec and all settings are visible in the exported files.

Okay thanks so much for your help. I'm getting the understanding that no matter how the codec is interpreted, all the rich information is still intact if you are working with a RAW format. Even if it looks like a bunch of things are applied to the footage from step 1 it doesn't matter because you can just slide it up and down for exposure and other things as the information will still be there.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on April 11, 2018, 08:11:07 AM
This software is so good. Thanks a lot @ilia3101 @masc4ii and @bouncyball . Absolutely fantastic. I'll see if I can donate some money soon.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on April 11, 2018, 03:40:40 PM
So, here's some ideas/opinions that could (or not) help. I wish I could help with code, but I never really got into C/C++ prog. If there's anything other than coding I can do, I'll do my best (could compile and test the git code at least). Been thinking about training a new Film look, based on Vision3 50D negative (from ImpulZ - don't know if it's legal either).

Here it goes:

1- The ProRes 4:4:4 exported is 12-bit? Would be cool to have the control over bit depth in configs

2- 3D LUT support, as @masc4ii suggested (https://github.com/ilia3101/MLV-App/issues/50)

3- Color space options would also be useful. Maybe a ACES implementation? This (https://www.magiclantern.fm/forum/index.php?topic=20677.0) discussion have some information from @Andy600 :^)

4- The highlight reconstruction uses also considers color? Rawtherapee has this method called "Color Propagation" (https://github.com/Beep6581/RawTherapee/blob/4344603a3d9c50e8268e33fd40f71edd95edf81b/rtengine/hilite_recon.cc) that has better results on HL reconstruction.

5- A option for monochrome demosaicing would be useful for people working on b&w projects

6- For denoising, definetly check out the KNLMeansCL (https://github.com/Khanattila/KNLMeansCL). It's quite fast (about 7fps in my testing using 1080p). There's also Deathray (https://github.com/JawedAshraf/Deathray), that seem to be the same algorithm. Although I've read some papers showing NL-Bayes (https://github.com/npd/nl-bayes), Shrinkage Fields (https://github.com/uschmidt83/shrinkage-fields), and Nonlinear difusion (http://www.escience.cn/people/chenyunjin/index.html) getting better results

6- Sharpen. Would be very cool to have a high-res sharpen tool, such as Plum (https://github.com/IFeelBloated/Plum), using deconvolution instead of wavelet edge-constrast.

7- Aliasing and moire removal. People from Doom9 recomended this Tlsophote (http://avisynth.nl/index.php/TIsophote) AVISynth script.

8- Lens correction through LCP profiles. The code from Rawtherapee could help (https://github.com/Beep6581/RawTherapee/blob/dev/rtengine/lcp.cc) (CA auto-correction too (https://github.com/Beep6581/RawTherapee/blob/dev/rtengine/CA_correct_RT.cc)), or the OpenFX code (https://github.com/NatronGitHub/openfx-misc/blob/master/Distortion/Distortion.cpp) from Natron too (it's in C++, though)...

9- Better demosaicing. As I said here (https://www.magiclantern.fm/forum/index.php?topic=15271.msg199612#msg199612), Bart Goossens have some really interesting research on this (http://www.imagesensors.org/Past%20Workshops/2015%20Workshop/2015%20Papers/Sessions/Session_12/12-01_Goossens.pdf): he gest better image quality doing efficient pre-demosaicing manipulation (better than AMaZE)

10- Improved tone mapping with Fattal method (http://www.cs.huji.ac.il/%7Edanix/hdr/hdrc.pdf). There's a implementation here (https://github.com/Ockhius/hdr_tonemapping_fattal02)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 11, 2018, 09:07:17 PM
@50mm1200s: many thanks for your long message. I really liked that you gave us links to papers and code. Maybe the one or the other link could really help us - who knows?! ;)

Some comments to some of your points:

1: ffmpeg offers 10bit (and indirectly 8bit) ProRes4444, AVFoundtion offers 12bit ProRes4444. So controlling the bitdepth is very limited and tricky.

3: with AVFoundation there is some color space control possible. Using ffmpeg it is again very limited and hard to understand. If you have an idea how to control color space in ffmpeg, let us know!

9: On github we have 2 more branches: "OpenCL-Processing" and "better-demosaic". This (https://github.com/ilia3101/MLV-App/issues/39) is the issue page for it. There we tested two other demosaic algorithms. One should be faster (but wasn't in our implementation), the other should be better than AMaZE (maybe was - note that in this stage AMaZE was not working right), but was waaaay to slow (around 5min per picture). In the end we got AMaZE working correctly, and we were so satisfied, that we stopped working on the other solutions. But maybe the link you posted helps improving again...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 70MM13 on April 12, 2018, 02:01:03 AM
Wow, the "denoisaicing" from that linked paper is quite incredible.  The example image of the zebras is phenomenal.

If you guys can utilise that method, mlv app would be other worldly in its greatness!

Please try!!!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: reddeercity on April 12, 2018, 05:10:08 AM
Sorry for the long post  :D
Quote from: masc on April 11, 2018, 09:07:17 PM
....... Using ffmpeg it is again very limited and hard to understand. If you have an idea how to control color space in ffmpeg, let us know!
https://trac.ffmpeg.org/wiki/Encode/VFX#Prores
good info on the prores encoder , before I add more info does the Win. Version use cmd line to encode or is it feed to ffmpeg.exe to encode with a preset string ?

There a lot you can do with ffmpeg , it even support .mlv (that right magic lantern raw video files) I play with it on win7 had a issue with black level (green cast) I could play back in real time
with ffmpeg play . From what I could understand about color space is it's base on the input file . ffmpeg prores conforms to the apple prores white paper ,
expect the max bit depth is 10 in stead of 12bit on 4444 .
The 2 color space it supports is full range(0-255) & limited (rec709/BT.709 16-235) as long as it conform to apple as they say .
So more great info on prores , I bet you didn't know you can now encode to 4444XQ
https://www.ffmpeg.org/ffmpeg-codecs.html#toc-ProRes
profile integer
Select the ProRes profile to encode
'proxy'
'lt'
'standard'
'hq'
'4444'
'4444xq'

https://www.ffmpeg.org/ffmpeg-codecs.html#toc-Private-Options-for-prores_002dks
quant_mat integer
Select quantization matrix
'auto'
'default'
'proxy''lt'
'standard'
'hq'
If set to auto, the matrix matching the profile will be picked. If not set, the matrix providing the highest quality, default, will be picked.

Color space integers ( If you use cmd. line then you add these values)
color_primaries integer (decoding/encoding,video)
Possible values:
'bt709'
BT.709
'bt470m'
BT.470 M
'bt470bg'
BT.470 BG
'smpte170m'
SMPTE 170 M
'smpte240m'
SMPTE 240 M
'film'
Film
'bt2020'
BT.2020
'smpte428''smpte428_1'
SMPTE ST 428-1
'smpte431'
SMPTE 431-2
'smpte432'
SMPTE 432-1
'jedec-p22'
JEDEC P22


color_trc integer (decoding/encoding,video)
Possible values:
'bt709'
BT.709
'gamma22'
BT.470 M
'gamma28'
BT.470 BG
'smpte170m'
SMPTE 170 M
'smpte240m'
SMPTE 240 M
'linear'
Linear
'log''log100'
Log
'log_sqrt''log316'
Log square root
'iec61966_2_4''iec61966-2-4'
IEC 61966-2-4
'bt1361''bt1361e'
BT.1361
'iec61966_2_1''iec61966-2-1'
IEC 61966-2-1
'bt2020_10''bt2020_10bit'
BT.2020 - 10 bit
'bt2020_12''bt2020_12bit'
BT.2020 - 12 bit
'smpte2084'
SMPTE ST 2084
'smpte428''smpte428_1'
SMPTE ST 428-1
'arib-std-b67'
ARIB STD-B67


colorspace integer (decoding/encoding,video)
Possible values:
'rgb'
RGB
'bt709'
BT.709
'fcc'
FCC
'bt470bg'
BT.470 BG
'smpte170m'
SMPTE 170 M
'smpte240m'
SMPTE 240 M
'ycocg'
YCOCG
'bt2020nc''bt2020_ncl'
BT.2020 NCL
'bt2020c''bt2020_cl'
BT.2020 CL
'smpte2085'
SMPTE 2085


https://www.ffmpeg.org/ffmpeg-devices.html#toc-Options-2
pixel_format <FORMAT>
monob,
rgb555be,
rgb555le,
rgb565be,
rgb565le,
rgb24,
bgr24,
0rgb,
bgr0,
0bgr,
rgb0,
bgr48be,
uyvy422,
yuva444p,
yuva444p16le,
yuv444p,
yuv422p16,
yuv422p10,
yuv444p10,
yuv420p,
nv12,
yuyv422,
gray

https://www.ffmpeg.org/ffmpeg-codecs.html#toc-vc2
If you wonder how to encode to 12bit in ffmpeg  , SMPTE VC-2 (previously BBC Dirac Pro).
QuoteThis codec was primarily aimed at professional broadcasting but since it supports yuv420, yuv422 and yuv444 at 8 (limited range or full range), 10 or 12 bits,
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on April 12, 2018, 07:20:38 AM
Quote from: masc on April 11, 2018, 09:07:17 PM
@50mm1200s: many thanks for your long message. I really liked that you gave us links to papers and code. Maybe the one or the other link could really help us - who knows?! ;)

Yeah, who knows. I'm by no means a academic on the subject.

Quote
3: with AVFoundation there is some color space control possible. Using ffmpeg it is again very limited and hard to understand. If you have an idea how to control color space in ffmpeg, let us know!

I'll if I can get some info about that.

Quote
9: On github we have 2 more branches: "OpenCL-Processing" and "better-demosaic". This (https://github.com/ilia3101/MLV-App/issues/39) is the issue page for it. There we tested two other demosaic algorithms. One should be faster (but wasn't in our implementation), the other should be better than AMaZE (maybe was - note that in this stage AMaZE was not working right), but was waaaay to slow (around 5min per picture). In the end we got AMaZE working correctly, and we were so satisfied, that we stopped working on the other solutions. But maybe the link you posted helps improving again...

Oh, that's nice. I'll get more information about this, trying to read as many papers as possible and summarize everything here later.


Quote from: reddeercity on April 12, 2018, 05:10:08 AM
[/code]
Color space integers ( If you use cmd. line then you add these values)
color_primaries integer (decoding/encoding,video)
Possible values:
'bt709'
BT.709
'bt470m'
BT.470 M
'bt470bg'
BT.470 BG
'smpte170m'
SMPTE 170 M
'smpte240m'
SMPTE 240 M
'film'
Film
'bt2020'
BT.2020
'smpte428''smpte428_1'
SMPTE ST 428-1
'smpte431'
SMPTE 431-2
'smpte432'
SMPTE 432-1
'jedec-p22'
JEDEC P22


Well, there's at least bt2020, that's a improvement. Maybe hack ffmpeg to use OpenColorIO functions? Natron seems (https://github.com/MrKepzie/Natron/blob/master/Documentation/source/plugins/fr.inria.openfx.WriteFFmpeg.rst) to have something working already, perhaps we could ask them on git...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 12, 2018, 09:12:48 AM
@reddeercity: did you try this parameters with success? I tried them out and in current MLVApp version we also use that (set to bt709). But in my tests I can set whatever I want - the exported file looks identical. The only difference seems to be metadata inside the exported file (tested with MediaInfo).
I found another parameter, e.g. -vf scale=in_color_matrix=bt601:out_color_matrix=bt709, this is visible in output.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on April 12, 2018, 03:31:02 PM
@Andy600 suggestion here (https://www.magiclantern.fm/forum/index.php?topic=21931.msg199831#msg199831):

Quote from: Andy600 on April 12, 2018, 02:17:28 PM
...you're also likely losing some color information when rendering to Prores 'AlexaLog' in MLVApp.

The matrices are originally from Adobe. MLVApp looks to be writing a single matrix (D65) which should be ok for most daylight shots but white balance accuracy would be improved a bit if it also included the tungsten matrix.

Couldn't find the tungsten matrix, so I already asked him about it.
Thanks the suggestion @Andy600, if you're reading this.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on April 12, 2018, 04:01:01 PM
So, another idea: improved tone mapping with Fattal method (http://www.cs.huji.ac.il/%7Edanix/hdr/hdrc.pdf). There's a implementation here (https://github.com/Ockhius/hdr_tonemapping_fattal02). That's really work looking into, even if it's too difficult to implement (doesn't seem to, rawtherapee has a working version), it is still very fun to read.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on April 12, 2018, 10:58:04 PM
Ok, so I've read some time about ffmpeg, and it doesn't seem to support custom colorspace/colormatrix, only the ones linked in documentation. I searched if avisynth has some script for conversions using colormatrix, but they don't. :(
It seems we are limited to 444XQ in Rec.2020 (10-bit). That's the maximum ffmpeg handles in ProRes, from the documents I've read.

Using the option "-pix_fmt yuv444p10le" together with profile 5 or 6 (444 and 4444XQ):

ffmpeg -i input.avi -c:v prores_ks -profile:v 5 -quant_mat 4 -pix_fmt yuv444p10le output.mov


Could'nt get profile 6 (supposedly 4444XQ) to work. Maybe my build is too old (version 3.4)
ffprobe log:

Stream #0:0(eng): Video: prores (ap4x / 0x78347061), yuv444p10le(progressive), 1920x1080, 142603 kb/s, 24 fps, 24
tbr, 12288 tbn, 12288 tbc (default)
    Metadata:
      handler_name    : DataHandler
      encoder         : Lavc57.107.100 prores_ks


Just a note: ffmpeg documentation suggests Kostya (https://trac.ffmpeg.org/wiki/Encode/VFX) instead of Anatolyi, so it can be removed, right?


In our testing we've used the "prores" and the "prores_ks" encoders and found "prores_ks" to be the best encoder to use. It is the only one that supports the 4444 colorspace and although it may be slightly slower. The color quality of the videos produced by these two codecs was visually indistinguishable Because of the 4444 support we've decided to go with Kostya's version of prores.



Another note: I've found this website (http://brucelindbloom.com/) possibly useful.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: reddeercity on April 13, 2018, 12:55:26 AM
Quote from: masc on April 12, 2018, 09:12:48 AM
@reddeercity: did you try this parameters with success? I tried them out and in current MLVApp version we also use that (set to bt709). But in my tests I can set whatever I want - the exported file looks identical. The only difference seems to be metadata inside the exported file (tested with MediaInfo).
No I haven't work with ffmpeg for a long time , I could try thou
Quote from: masc on April 12, 2018, 09:12:48 AM
   .......... in my tests I can set whatever I want - the exported file looks identical.
The only difference seems to be metadata inside the exported file (tested with MediaInfo).
That's right , you will see the differences in the scopes , remember the limitation of your computer monitor , most are BT709 Limited (16-235) so you won't
see the tones under 16 or the hi-lights above 235 in fact the video card will crush those values . You need to set & calibrate you monitor to Full Range wide gamut
In Win7 right click on the open desktop get to your color management and you get this

(https://preview.ibb.co/nq5hp7/video_card_profiles1.png) (https://ibb.co/i6KmGn)
 
The profiles I hi-lighted are wide gamut & full range even the rec.709 but it's not wide gamut , I use sRGB gamma 2.1


(https://preview.ibb.co/iOgBhS/video_card_profiles2.png) (https://ibb.co/fQD2p7)

And there the Viewing Conditions , I use D65 for sRGB and then I calibrate that profile , a have other profiles I use when I work with HDR/Wide Gamut .
You can only see what the monitor can support .
Quote from: masc on April 12, 2018, 09:12:48 AM
I found another parameter, e.g. -vf scale=in_color_matrix=bt601:out_color_matrix=bt709, this is visible in output.
Yes that right , bt601=SD color's  (standard definition) and bt709=HD color space but not limited , if you would have added color_matrix=bt709-16-235 , I think that's for 8bit prores .
These color spaces are viewable in all know monitors , and if you check them with scopes you will see the big differences -- try encoding to BT2020 , you still will not see the differences
until you start grading and pulling the hi-lights & shadows .

That's the biggest reason I had a dictated grading monitor,  https://www.asus.com/ca-en/Commercial-Monitors/PA238Q/
Quote100% sRGB  pre-calibrated with a maximum ΔE (Delta E) of less than 5.
Ensures precise reading of color input and guarantees excellent color fidelity
...... PA238Q's built-in internal 10-bit Look-up Table can produce greater depth for each RGB colors than 8-bit Look-up Table in conventional monitors.
Resulting in smooth gradation and accurate color resolution
I have it connected to either my Blackmagic UltraStudio SDI USB 3.0 thought the HDMI which has a preset calibrated NTSC rec709 color space PC/MAC
or on my real 5.1MP I use my AJA Capture card with break out box (HDMI) , there I always see the differences .
There is cheap version of what I have even blackmagic has a cheap hdmi monitoring card for around $125.00 with rec709 preset .
Sorry for the long post again , I hope that helps
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 13, 2018, 07:49:01 PM
Thanks @reddeercity, that was very informative! I tried again many settings with ffmpeg. The parameters you wrote about: I tested bt709, nothing, and bt2020 for all 3 parameters. All files look identical, also with the waveform scope in FCPX. Only the metadata was different. Then I set the parameters back to bt709, and added this matrix code (this is the new version of matrix which can be used for more than 8bit, the old version (the code was different) was 8bit only). Now I see a tiny difference on my Monitor and I also see the difference in the scope. I would say, with this matrix operation I have more space in the shadows and a better quality when lifting the mids in FCPX. And using this matrix operation brings the clip very close to what AVFoundation exports.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on April 14, 2018, 09:41:12 AM
Hmm... what matrix you're referring to?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 14, 2018, 01:47:48 PM
Quote from: bouncyball on April 14, 2018, 09:41:12 AM
Hmm... what matrix you're referring to?
-vf scale=in_color_matrix=bt601:out_color_matrix=bt709
It is also in our ffmpeg export function.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on April 15, 2018, 01:35:33 PM
Ah ok, thx.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 15, 2018, 02:10:44 PM
I
Quote from: masc on April 14, 2018, 01:47:48 PM
-vf scale=in_color_matrix=bt601:out_color_matrix=bt709
It is also in our ffmpeg export function.

Isn't ffmpeg output bt709 already as default? How to verify otherwise?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 15, 2018, 07:42:19 PM
Quote from: Danne on April 15, 2018, 02:10:44 PM
I
Isn't ffmpeg output bt709 already as default? How to verify otherwise?
From what I heard standard is bt601, but that may be wrong.
Quoteffmpeg always assumes the BT.601 colorspace when converting from RGB->YUV and from YUV->RGB.
I had clips with a very intensive red - it was set up as red in MLVApp, it was also the same red in exprted AVFoundation files, but it was orange/brown when exporting with ffmpeg. This was the point when I started searching in the net and I found that I am not alone with this. I then found to add this operation and since I tested that, the exported ffmpeg file looks identical to the MLVApp viewer (at least for me, please report, if it is not the same for you!).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 19, 2018, 11:45:40 AM
@bouncyball: could you please check, what is going on with this file and dualIso?
https://www.magiclantern.fm/forum/index.php?topic=7139.msg200188#msg200188
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 19, 2018, 12:03:01 PM
Great. a1ex pointed to a solution so let's fix it :).
Another thing. I tried exporting with native apple codec into prores444 and I notice audio isn't included. Correct? If an issue it's fast and easy to add audio to the finished file with ffmpeg lossles with acoded copy. Could this be added as a solution until audio gets added in av foundation?
I can give you the ffmpeg command later.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 19, 2018, 12:10:39 PM
Quote from: Danne on April 19, 2018, 12:03:01 PM
Great. a1ex pointed to a solution so let's fix it :).
So this is a bug in the file, or in MLVApp?

Quote from: Danne on April 19, 2018, 12:03:01 PM
Another thing. I tried exporting with native apple codec into prores444 and I notice audio isn't included. Correct? If an issue it's fast and easy to add audio to the finished file with ffmpeg lossles with acoded copy. Could this be added as a solution until audio gets added in av foundation?
I can give you the ffmpeg command later.
Yes, audio is not supported yet in our AVFoundation export. That's why we grey it out in the settings dialog. I tried it already to implement that some times but every time I failed. So I like your idea. That sounds a lot easier to realize! ;) If you have the command, that would help me! :) THX!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 19, 2018, 12:48:40 PM
Not a bug in Mlv app but in cr2hdr/mlv_dump code itself when treating 12bit dualiso files.
https://www.magiclantern.fm/forum/index.php?topic=16040.msg196034#msg196034

Last I used this command it went like this:
ffmpeg -i INPUT.mov -i INPUT.wav -map 0:0 -map 1:0 -c copy OUTPUT.mov
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 19, 2018, 01:09:56 PM
Quote from: Danne on April 19, 2018, 12:48:40 PM
Not a bug in Mlv app but in cr2hdr/mlv_dump code itself when treating 12bit dualiso files.
https://www.magiclantern.fm/forum/index.php?topic=16040.msg196034#msg196034
So bouncyball will fix it in the same way as in mlv_dump then...

Quote from: Danne on April 19, 2018, 12:48:40 PM
Last I used this command it went like this:
ffmpeg -i INPUT.mov -i INPUT.wav -map 0:0 -map 1:0 -c copy OUTPUT.mov
Great! Thx! Will add that as long as our AVFoundation does not export audio! ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 19, 2018, 01:14:19 PM
Quote from: masc on April 19, 2018, 01:09:56 PM
Great! Thx! Will add that as long as our AVFoundation does not export audio! ;)
Cool!

Quote from: masc on April 19, 2018, 01:09:56 PM
So bouncyball will fix it in the same way as in mlv_dump then...
Fingers crossed.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on April 19, 2018, 06:08:43 PM
Quote from: masc on April 19, 2018, 01:09:56 PM
So bouncyball will fix it in the same way as in mlv_dump then...
There is nothing like this ever been implemented in mlv_dump. Data needs to be scaled from existing 14bit black to real 14bit white by the method proposed by a1ex before feeding into existing unmodified dual iso processor. Now MLV App supports this. Danne will test all kind of imaginary bit depths and reports back.

Edit:

cr2hdr can be modified to scale if needed and convert to 20bit simultaneously. But I think this will be done by a1ex himself.

mlv_dump can be modified like this: if --dual-iso (already existing switch) specified, checks should be done to reveal whether source is restricted bit depth lossless raw or not and, scale data accordingly (also update white point) before saving dual iso DNG.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 19, 2018, 07:22:17 PM
Yeha! Thx @Danne again! AVFoundation export WITH AUDIO is working! Check out latest revision. I like this trick! ;)

And thx @bouncyball for the fast fix!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 19, 2018, 10:14:45 PM
Great masc :)! I used that trick when hacking some export through command line and apple compressor and could never get audio right but ffmpeg to the rescue.
@bouncyball. I would love to get that --dual-iso switch into mlv_dump so we are being able to differ all them bits also in dualiso. Tell me if you work on something and I put it through some tests.
Now, let´s see if I can remember how to compile the latest Mlv app achievements...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 19, 2018, 11:04:03 PM
Doing some tests on latest version of Mlv app. All bits uncompressed seems to work perfectly. When lossless is on 11 and 12 bit seems to have an issue with white level. Test following two files:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/11bit_lossless_dualiso.MLV
https://bitbucket.org/Dannephoto/magic-lantern/downloads/12bit_lossless_dualiso.MLV

Here are the rest of the files which works very good:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/10bit_dualiso.MLV
https://bitbucket.org/Dannephoto/magic-lantern/downloads/12bit_dualiso.MLV
https://bitbucket.org/Dannephoto/magic-lantern/downloads/14bit_dualiso.MLV
https://bitbucket.org/Dannephoto/magic-lantern/downloads/14bit_lossless_dualiso.MLV


Latest version of Mlv app:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/MLV%20App.app.zip
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 20, 2018, 08:24:27 AM
@masc
Tried adding audio with av foundation coded and in my case the mov file gets erased after conversion. Not sure what is going on.
Also suggestion to have Export audio already ticked as default and user untick when not wanting audio.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on April 20, 2018, 10:25:12 AM
@Danne

Code updated a bit to lower scaling and white level for 11/12 bit dualiso clips.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 20, 2018, 11:16:44 AM
Quote from: Danne on April 20, 2018, 08:24:27 AM
@masc
Tried adding audio with av foundation coded and in my case the mov file gets erased after conversion. Not sure what is going on.
Also suggestion to have Export audio already ticked as default and user untick when not wanting audio.
It seems your ffmpeg does not work right. Normally the workflow is this:
If you have no file, ffmpeg did not export anything. I tried your uploaded version and my version: yours does what you wrote and my version works... no idea why, I can't see an error in your package.

Export audio is enabled by default and the last setting chosen by the user will always be saved. So if it is off, you switched it off, or one time you have chosen a codec where audio export is impossible (this was AVFoundation in past only, but this setting is still saved from one version to another on your computer).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 20, 2018, 11:40:08 AM
@masc
Ok, I will check some more. Thanks for clarifying about audio switch.


@bouncyball
Tried some more with your latest update. Just to make sure. Differences between bits seems higher than should be. Is dynamic range white level affected(cut) as bits are changing? Seems there´s information missing but I could be wrong. Tested a 11bit dng in adobe camera raw and dynamic range was preserved better. Here are examples from Mlv app when opened without grading:

11bit lossless
(https://s18.postimg.cc/6v4nx4xa1/11bit_lossless.png)

12bit lossless
(https://s18.postimg.cc/hupv8q89l/12bit_lossless.png)

14bit lossless
(https://s18.postimg.cc/tjtuworih/14bit_lossless.png)

11bit darkened(check pinks)
(https://s18.postimg.cc/t72gqioo9/Screen_Shot_2018-04-20_at_11_500px.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 20, 2018, 11:44:34 AM
11bit darkened: did you enable highlight reconstruction? I downloaded your file and I can reconstruct correct highlights without pink.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 20, 2018, 11:59:34 AM
@masc
Highlight reconstruction. Wow. Works really good.

Tested with and without audio again. It seems the temp file is created and also the wav file. I think it´s something when renaming that doesn´t work and so the temp files are erased leaving me with an empty folder. With audio unticked I get a perfect prores444 mov file. Could you tell me where to put in some msleep 3 or something before files are erased so I can check what´s going on?

Some other thingy. When pressing hide button to hide Mlv app window it always comes back with show session area and show edit area unselected so I need to do s, and e to get them back.
Speaking of characters. Shouldn´t they be 's' and 'e' not 'S' and 'E'?
(https://s18.postimg.cc/7oh9px3cp/Screen_Shot_2018-04-20_at_12_scaled.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 20, 2018, 12:46:52 PM
@Danne: comment out line 1821 and 1824 of MainWindow.cpp, then no file will be deleted. //file->remove();

Haha, nice bug... thanks for reporting. That seems to be a Qt thing. Official MLVApp v0.15 hasn't the bug (uses Qt 5.7.0). If I compile the same revision with Qt 5.9.4, the bug is there. So something seems to be different in the libraries what causes this behaviour. I also found the lines where it happens, but I have no solution yet.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 20, 2018, 12:54:31 PM
Cool, you nailed down the bug. If I get the time I try and downgrading my QT.

Here´s some unscientific frames of fast fiddling with sliders in Mlv app and using dualiso files. It´s really good and intuitive. 11bit files works great too. Filmed with eos 100D 3x zoom mode 2520x1080 working with the sd_uhs.mo module from a1ex:

11bit
(https://s18.postimg.cc/u1tlqi3yx/M19-1938_frame_1_800px.png)

12bit
(https://s18.postimg.cc/mylqavj3t/M19-1937_frame_115_800px.png)

14bit
(https://s18.postimg.cc/469v7b9ux/M19-1939_frame_1_800px.png)

So, what´s next. color sliders for blue,yellow,red and so on like in acr? Would be so cool to be able to manipulate colors. Or maybe a slider for midtones?

Anyway. Thanks Ilia3101, masc, bouncyball for your masterpiece.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 20, 2018, 01:01:50 PM
Quote from: Danne on April 20, 2018, 12:54:31 PM
Cool, you nailed down the bug. If I get the time I try and downgrading my QT.
Fixed... you don't need to downgrade ;)

Quote from: Danne on April 20, 2018, 12:54:31 PM
So, what´s next. color sliders for blue,yellow,red and so on like in acr? Would be so cool to be able to manipulate colors.
When I started helping with this tool, Ilia was asking me if it might be possible to add colorwheels. Some weeks ago I created them. But I don't know if Ilia works on the processing code regarding this (I don't think so). There will be a lot to do ;)
(https://user-images.githubusercontent.com/30245296/36062299-ef35af42-0e69-11e8-9a7f-1c462917aba9.png)
You can comment it in and play around... but you won't change anything in the picture... search for ui->groupBoxColorWheels->setVisible( false );
And there are some more lines like that in the code with other planned features :P

Quote from: Danne on April 20, 2018, 12:54:31 PM
Anyway. Thanks Ilia3101, masc, bouncyball for your masterpiece.
Haha, thanks ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 20, 2018, 01:20:02 PM
Wow. Those color wheels needs in! That would really give us flexiblilty and creativity.

Tested your latest code but the mov file is still deleted unfortunately, hmm
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 20, 2018, 01:24:21 PM
Quote from: Danne on April 20, 2018, 01:20:02 PM
Wow. Those color wheels needs in! That would really give us flexiblilty and creativity.

Tested your latest code but the mov file is still deleted unfortunately, hmm
Yes, would be cool!

You tried commenting out that:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg200288#msg200288

Then please export a file without audio, rename in Finder from YourFile.mov to YourFile_temp.mov, then enable audio export and export again YourFile.mov. If that works, Qts rename fails (I don't think so, because I never delete the original file name), if not, there is a ffmpeg problem.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 20, 2018, 01:43:04 PM
Tried your suggestion and audio isn´t merged. All file is separated so it has to be merging(renaming step that fails. Probably not ffmpeg since you have it working. I also tried another version myself here, still didn´t work:
(https://s18.postimg.cc/muwi86v8p/Screen_Shot_2018-04-20_at_13.51.18.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 20, 2018, 02:49:50 PM
Is there a way to check ffmpeg output by the way? Surely this could be an issue if command breaks. Can one put ...INPUT.mov 2> checkfile in your ffmpeg code?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 20, 2018, 03:12:03 PM
Comment out line 1810. Then you'll have ffmpeg output in Qt application output.
Edit: could you try latest revision? Had a quick idea...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on April 20, 2018, 03:40:50 PM
@masc

Quote from: masc on April 20, 2018, 01:01:50 PM
When I started helping with this tool, Ilia was asking me if it might be possible to add colorwheels.
Also show the gradient tool to Danne please, it's so cool :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 20, 2018, 03:53:53 PM
Gradient tool. I was thinking that too but didn´t want to ask  :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 20, 2018, 03:56:42 PM
Quote from: bouncyball on April 20, 2018, 03:40:50 PM
@masc
Also show the gradient tool to Danne please, it's so cool :)
(https://camo.githubusercontent.com/d93f51a82078ad992c3f671c73972378f31c085e/68747470733a2f2f696d6167652e6962622e636f2f6830303259522f42696c6473636869726d666f746f5f323031375f31315f32345f756d5f31315f32365f35372e706e67)
To play with, search for ui->groupBoxLinearGradient->setVisible( false ); comment out and have fun. But also this one does nothing with your picture. But you can paint, drag, change values,...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 20, 2018, 04:01:38 PM
No time for testing gradient thingy right now unfortunately.

Hey masc! You fixed audio!! Just tested latest :)

Latest version(mac)
https://bitbucket.org/Dannephoto/magic-lantern/downloads/MLV%20App.app.zip
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on April 20, 2018, 04:03:21 PM
I don't want to sound like an idiot or something, but: I think there's a better way to put the efforts than colorwheels and gradient tools, don't you guys think? I can be wrong but I think most people don't do color grading on a software like MLVApp. It think the target public is using it mostly for simple conversion or log conversions, not for primary color grading...
For example, a color space management would be *very* useful. Lens correction through LCP profiles too (would fix the issue some other guy posted on the forum, with magenta fringe in highlights). A tone mapping operator like the "fattal method", to recover informations in highlights/shadows. So on...
Sorry if I seem rude, I can't write "gently" in english, it's not my mother language.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 20, 2018, 04:07:07 PM
Sounds like you havn´t been working with this tool tbh @50mm1200s.
More control will always be welcome imo. It also feels like a natural step to be able to do this before batch conversion.
My 50 cents...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 20, 2018, 04:13:35 PM
Quote from: 50mm1200s on April 20, 2018, 04:03:21 PM
It think the target public is using it mostly for simple conversion or log conversions, not for primary color grading...
The main idea was to build up a easy color correction and grading tool for MLV files which brings good quality, and this also was the main fun in putting so much work in it. ;) Atm I like more using MLVApp than Resolve or ACR, because I get a better quality with it (for my files and how I use it the most).
Then the other features came across, like exporting raw from raw...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on April 20, 2018, 04:27:29 PM
Quote from: Danne on April 20, 2018, 04:07:07 PM
Sounds like you havn´t been working with this tool tbh @50mm1200s.

I use it professionally every week for some time now. It works well.

Quote
More control will always be welcome imo. It also feels like a natural step to be able to do this before batch conversion.
My 50 cents...

I didn't say more controls are not welcome. I said the devs efforts should be put in more important things. That's why projects like rawtherapee have a roadmap... maybe that's a good idea for mlvapp? I don't think there's enough people working on this, but, still.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on April 20, 2018, 04:28:04 PM
@masc

Yup, first of all we do this for ourselves :) and we are glad with what it presently does.

However we're gonna appreciate the help from anyone on color management etc... ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 24, 2018, 07:58:29 AM
Hi @Ilia3101, @masc, @Bouncyball.
Since I use this application a lot more lately I was thinking of the idea to integrate and execute a shell command from within Mlv App. Since we are able to export to mov or tiff files I would like to execute a HDR script after I produced the mov/tiff files. The idea is that the script starts before "Exports are ready!" is executed.

Here is a script example that if executed beside mov files it will apply aligning through hugin, scale and export through ffmpeg, do fps interpolation if needed, drop frames etc also through ffmpeg and results are merged and ready HDR files back to mov file prefixed with HDR_. Multiprocessed. Double click following file next to an HDR mov file(or a normal mov just to test):
https://bitbucket.org/Dannephoto/magic-lantern/downloads/HDR_MOV.command

Right now all variables and values in the script are sent to either /tmp or within the script folder but you can tweak any setting in there so nothing is written in stone. There is also a tiny sub menu which will kill processing if wanted. The script will also ask for downloading any missing dependency.

As a first idea i´d like to know if the script could get chmod privileges though QT and/or and some suggestions how to execute the script. Also wonder if it´s possible to run the script from MacOS folder from inside Mlv App and then we would need both the mov folder path and the MacOS path specified. In Switch for example I just do following to get content from it from inside Switch:
. path/to/switch/HDR_MOV.command
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on April 24, 2018, 10:43:57 AM
I think this will be a bit more complicated than at a first glance, I mean Linux/Window versions.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 24, 2018, 11:27:59 AM
Yes. For now it´s an idea that is not supposed to reach mainline. A fork/branch...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 24, 2018, 01:35:11 PM
Progress  :P
            //AVFoundation
            startExportAVFoundation( m_exportQueue.first()->exportFileName() );
QProcess process;
process.startDetached("/bin/sh", QStringList()<< "/Users/dan/Desktop/test/HDRMOV/HDR_MOV.command");
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 24, 2018, 03:23:22 PM
Ok, complete noob here. This gives me the path to where ffmpeg is etc:
        {
            //AVFoundation
            startExportAVFoundation( m_exportQueue.first()->exportFileName() );
    QProcess process;
    process.startDetached("/bin/bash", QStringList()<< "HDR_MOV.command");
        }

So how do I find exports folder containing the actual mov files?  Would be great if I could have both the application path but also where the files are located so I could let the HDR_MOV.command do its thing in correct folder...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 24, 2018, 04:08:29 PM
@Danne:
Yes, the main problem is to stay cross platform. To make such features macOS only, we need many #ifdef ... that makes readability much harder.

But to answer your questions:
The path where ffmpeg is inside the app package: QCoreApplication::applicationDirPath()
The export path is: QFileInfo( m_exportQueue.first()->fileName() ).absolutePath()
You can trigger a script with:
QProcess proc;
proc.execute( commandString );
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 24, 2018, 04:20:47 PM
Thanks masc. Yes platform issues is one thing but I just want to test for myself here :). And maybe I eventually can dig in and help in qt code.

QFileInfo( m_exportQueue.first()->fileName() ).absolutePath()
Is it possible to print exports path folder into a txt file?

I use this to get the script executable rights and start it from application path:
    QProcess process;
    process.startDetached("/bin/bash", QStringList()<< "-c"
                       << "chmod u=rwx HDR_MOV.command");
    process.startDetached("/bin/bash", QStringList()<< "HDR_MOV.command");

However, the script needs to find where the folder with files is located. Can´t really see how I can get this into a txt file.

I need something like following run from inside the folder with files:
echo $PWD > path

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 24, 2018, 04:58:52 PM
Hehe, try out what you like and have fun! That can always help for future features! ;)

Write a path to a file:

QFile file(fileName);
file.open(QIODevice::WriteOnly);
file.write(yourPathString.toUtf8());
file.close();


Is that all you need? I have some problems to completely understand what you want to ask / to say... :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 24, 2018, 05:05:59 PM
Cool, will try when I get home.
My experiment is following.
I will execute my script from within Mlv App just like it's done for ffmpeg.
From inside the script I will find the path file and then cd into this folder so that my script will be executed from this folder rather than from inside Mlv App.

Preferrably the path file could be sent to /tmp folder and then my script can find it there :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 24, 2018, 06:28:21 PM
Tried your code to try and write path to file:
(https://s18.postimg.cc/nt2ckw4hl/Screen_Shot_2018-04-24_at_18.38.04.png)

Coming from the world of bash I have a hard time understanding how to fix this. Is it supposed to write the selected output path into a file? Where to put it?
I tried putting the code here:
#ifdef Q_OS_MACX
        else if( ( m_codecProfile == CODEC_PRORES422ST && m_codecOption == CODEC_PRORES_AVFOUNDATION )
              || ( m_codecProfile == CODEC_PRORES4444 && m_codecOption == CODEC_PRORES_AVFOUNDATION )
              || ( m_codecProfile == CODEC_H264 && m_codecOption == CODEC_H264_AVFOUNDATION ) )
        {
            //AVFoundation
            startExportAVFoundation( m_exportQueue.first()->exportFileName() );

QFile file(fileName);
file.open(QIODevice::WriteOnly);
file.write(yourPathString.toUtf8());
file.close();


    QProcess process;
    process.startDetached("/bin/bash", QStringList()<< "-c"
                       << "chmod u=rwx HDR_MOV.command");
    process.startDetached("/bin/bash", QStringList()<< "HDR_MOV.command");
        }
#endif

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 24, 2018, 07:25:04 PM
Not sure what I´m doing:
QString filename = "Data.txt";
QFile file(filename);
file.open(QIODevice::WriteOnly);
file.write(QFileInfo( m_exportQueue.first()->fileName() ).absolutePath().toUtf8());
file.close();

Gets me an empty file called Data.txt inside Mlv App. I was thinking this would reveal folder path but no:
file.write(QFileInfo( m_exportQueue.first()->fileName() ).absolutePath().toUtf8());
Any clues?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 24, 2018, 08:11:27 PM
Ok, closer:
    QString path = QFileInfo( m_lastSaveFileName ).absolutePath(); 
    QString filename = "/tmp/Data.txt";
    QFile file(filename);
    file.open(QIODevice::WriteOnly);
    file.write(path.toUtf8());
    file.close();

However, I need the path to where I set my exports to, the mov files. What path is that? Right now I get path to where I select my MLV files.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 24, 2018, 08:59:12 PM
Look the screenshot. You should not add the code to exportHandler(), because there is running a lot in parallel via signal/slot... so there may happen things you won't understand. Go to the end of startAVFoundation() and add the code there (before "emit...").
I could create the "/tmp/Data.txt", this file inherits "/Users/masc/Desktop" - the folder where I exported a file.

(https://image.ibb.co/m935gx/Bildschirmfoto_2018_04_24_um_20_54_40.png)

btw: what shall do
QStringList()<< "-c" << "chmod u=rwx HDR_MOV.command"
?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 24, 2018, 09:13:50 PM
Hm, trying:
    QString path = QFileInfo( m_exportQueue.first()->exportFileName() ).absolutePath(); 
    QString filename = "/tmp/Data.txt";
    QFile file1(filename);
    file1.open(QIODevice::WriteOnly);
    file1.write(path.toUtf8());
    file1.close();

Compiles but program simply closes and no txt file is created. Where do you put this snippet in MainWindow.cpp? Can´t find where to put it?


QStringList()<< "-c" << "chmod u=rwx HDR_MOV.command"
Might not be working, but if it does it should give the script root privileges.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 24, 2018, 09:19:02 PM
You should add the code in the end of function "startExportAVFoundation()", in the latest revision I am talking about line 1824 in MainWindow.cpp.

How would be the whole call in the Terminal (where is this -c)? The script is in /usr/bash ?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 24, 2018, 09:27:30 PM
With this code:
QProcess process;
process.execute( "chmod u=rwx /usr/bash/HDR_MOV.command" );

the terminal tells:
-rwxr--r--@  1 masc  staff  49007 24 Apr 21:21 HDR_MOV.command
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 24, 2018, 09:40:51 PM
Thank you @masc!! Totally working now :)
I see you also solved chmod for my script. Even better :). I now have what I need to add the script after mov conversion is done. Too tired now but will continue tomorrow and see what I can accomplish with my HDR script :)
https://bitbucket.org/Dannephoto/magic-lantern/downloads/HDR_MOV.command

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 25, 2018, 09:29:55 AM
Added my HDR_MOV.command script into a version of Mlv App here:
https://bitbucket.org/Dannephoto/mlv-app-danne/downloads/Mlv_App_HDR.app.zip

I did a lot of refinements in the command. The command lives in MacOS folder at the moment.

To be able to follow changes in code I uploaded a repository in mercurial(not familiar with git, sorry):
https://bitbucket.org/Dannephoto/mlv-app-danne/overview

Commit:
https://bitbucket.org/Dannephoto/mlv-app-danne/commits/f24be5e309c4a65b6fea20013a5db9522c793c55

To test this I suggest downloading some of the shortened HDR mlv files uploaded here:
https://bitbucket.org/Dannephoto/mlv-app-danne/downloads/

How to use it
Simply run and export your MLV files as usual. Export to mov prores. Once the files are exported the script will take on and start processing your files into HDR mov files. Beware, the script will ask you to install missing dependencies and although multiprocessing it will take a while for aligning and exporting to be done.
If you want to abort processing you can do this through a notifier window which will kill align_image and other stuff going on under the hood.

This is just for fun stuff and testing. A lot more can be done here and I have no kind of agenda here. Unfortunately only for mac at the moment.
Thanks masc for helping out!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 25, 2018, 12:58:52 PM
Not bad Danne! The only thing I am a bit sad about is that you took it to bitbucket - so it is difficult to see the difference between the two branches.

Is it possible in principle to use the same scripts on Linux, and maybe with some changes also on Windows?

I could imagine to add a combobox to the export settings - this box shows all installed scripts in this internal MacOS folder (or installation folder for the other OSes). Installation via drag and drop into MLVApp. The user can selected between "none" and the installed scripts. After export is done, the chosen script is started (as you did now).

Does that only work for movs atm, or also for TIFF, PNG, mp4,... ? How is it: the AVFoundation exported file is no AVFoundation, but ffmpeg after the script, or?!

Pro: do a lot of fancy stuff
Contra: you won't see what you get, before in MLVApp
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 25, 2018, 01:15:21 PM
Thanks for feedback masc. And I like the idea about a combo box although I don't fully grasp the installation procedure.
Porting this to linux should be pretty straightforward but windows maybe not as swift but I think all dependencies exists for windows too. If anyone would like to work on a windows solution you are very welcome :).
I will look into github and I reupload it there when I get some time.

Suggestion. If we could work on outlining a mac solution I do what I can to fix it for linux as well.
One good thing is if one use the HDR script and chooses to abort processing we could skip the terminal notifier which kills processing in bash.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 25, 2018, 02:04:37 PM
Ok masc. I uploaded to a github fork:
https://github.com/dannephoto/MLV-App
Is this correct?

I also did some git creation at bitbucket:
https://bitbucket.org/Dannephoto/mlv-app_danne
Also legit or should I bury this one?


edit: Noticed a bug. Character Ö in Köln isn´t working, making Mlv App crashing.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 25, 2018, 07:12:09 PM
That would be not too hard to build this combobox and provide it to your functionality. I can create all that, and I would pack all this script functions in a new class...

Thanks for the github repos. Now it is easy to see the difference.  8)

Thanks for reporting this äöü bug! I could fix it nearly everywhere - only for AVFoundation export it still does strange things. But I don't know this ObjectiveC classes, so I have to search for a solution. The problem is line 88 in avf_lib.m.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 25, 2018, 07:46:28 PM
Combobox seems nice :). Really like the idea to attach functions not added through scripts. Thanks for being open minded.

edit:
QuoteDoes that only work for movs atm, or also for TIFF, PNG, mp4,... ? How is it: the AVFoundation exported file is no AVFoundation, but ffmpeg after the script, or?!
I could get it to fly with tiff and mp4. Maybe png, will check.
And yes, it´s back to ffmpeg prores as the end result...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 25, 2018, 09:08:15 PM
The äöüß bug is fixed now, also for AVFoundation export. I have to say ObjectiveC is not my language... :P
When I have some time I'll implement this script-class...
Btw: your script uses only enfuse (from hugin)? Could it be an idea to add enfuse into our package in the same way as ffmpeg? Then the user does not need to install hugin (if he don't want to)... it would work out of the box.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 25, 2018, 09:31:18 PM
Uses both enfuse and hugin align_image_stack. Could be installed as package but quite big.
Exiftool is also in there :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 25, 2018, 10:19:12 PM
Added all movie file extensions in Mlv App. Will add tiff later:
https://github.com/dannephoto/MLV-App/commit/83bbb1a6fbc77f895f6067fb90efa3eac9e19b07
Following files will work:
'MOV\|mov\|mp4\|MP4\|mkv\|MKV\|avi\|AVI'

Script:
https://github.com/dannephoto/MLV-App/blob/83bbb1a6fbc77f895f6067fb90efa3eac9e19b07/platform/qt/bash_scripts/HDR_MOV.command

Is there a downloads section at github like at bitbucket? Meanwhile I upload a HDR version here:
https://bitbucket.org/Dannephoto/mlv-app-danne/downloads/MLV_App_HDR.app.zip
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 25, 2018, 10:27:24 PM
Cool!
I only know to add downloads as releases. Go to release tab and create one. Then you can add the zip with the compiled app to the release.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 26, 2018, 09:12:14 PM
Thanks masc. Not ready for any releases yet  :P.
I´m almost through making HDR work for tif files produced in Mlv App. One issue is frame rate tag. This tag seems stripped from tif files. Would you know if it´s possible to force a video frame rate tag into the tif file? Don´t want to need to use mlv_dump to drag the fps data out and then we have yet another dependency to deal with.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 27, 2018, 10:27:58 AM
I think it´s better solved by sending the fps from each MLV into the tif folder created:
        //Creating a folder with the initial filename
        QString folderName = QFileInfo( fileName ).path();
        QString shortFileName = QFileInfo( fileName ).fileName();
        folderName.append( "/" )
                .append( shortFileName.left( shortFileName.lastIndexOf( "." ) ) );

        QDir dir;
        dir.mkpath( folderName );

        //we also need to know fps from the actual MLV files since tif doesn´t reveal frames per second.
        QString fps = locale.toString( getFramerate() );
        QFile file5(folderName + "/fps");
        file5.open(QIODevice::WriteOnly);
        file5.write(fps.toUtf8());
        file5.close();

        //Now add the numbered filename
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on April 27, 2018, 01:47:27 PM
Whoa... some scripting devel! Interesting, MLV App with built is scripting language, what if we implement the LUA there :).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 27, 2018, 03:01:33 PM
Oh, LUA, I tire myself out with bash before even getting through basics about LUA unfortunately but what are you thinking here B?

Added tif support to my HDR script so all formats should work now? I can´t find png, is it in Mlv App too?:
https://github.com/dannephoto/MLV-App/commit/61139270177dabab58c52bc6d3349fd8ac3b934b

Working version:
https://bitbucket.org/Dannephoto/mlv-app-danne/downloads/MLV_App_HDR.app.zip

I realize I dont even use enfuse to merge the files but ffmpeg tblend filter together with hugin align_image_stack. I want to experiment some more with enfuse to see if it´s reliable in this workflow. Right now the align _image_stack is causing the output to flicker since enfuse is interpolating borders. This is not a problem with ffmpeg tblend The consecutive order needed to keep framerate is also problematic here when using enfuse.

I rewrote some parts quite heavily in my script and right now it will only keep the final prefixed HDR_ output file and removes the rest to save some space.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on April 27, 2018, 05:14:42 PM
We dropped 16bit PNGLib support in favor of FFMPEG/TIFF because of simplicity and lesser dependency. There is only 8 bit PNG frame saving in the menu done by the QT image lib.

Without enfuse there will be one less binary dependency. So I think it's ok ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 27, 2018, 08:12:05 PM
That is good. Tif should be enough.
So I guess porting to linux and windows is next ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 27, 2018, 09:44:10 PM
Hej Danne. I tried implementing the scripting class. Look into master branch. I tried to find all calls you did in your repos. The existing script installs automatically on compiling into the app. If you have further scripts you can drag them into the session space - that will install it into MLVApp. You can chose the script via export settings. For now macOS only. Have a try if you like ;)

(https://user-images.githubusercontent.com/30245296/39382075-aa4364ec-4a64-11e8-9f06-3278f3f424c0.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 27, 2018, 09:57:37 PM
Shit, so cool! Will try asap. Unfortunately busy right now but will find time. Cool!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 28, 2018, 08:25:57 AM
This a great addition masc! One issue so far regarding created fps file when exporting to tif folders. I have put in a comment here:
https://github.com/ilia3101/MLV-App/commit/adb966c036c03ddb78a18e066a78d76831e1b141

(https://s18.postimg.cc/6lljkklah/Screen_Shot_2018-04-28_at_08.31.52.png)

Example HDR
(https://s18.postimg.cc/449sdb93t/M27-0607_000001.png)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 28, 2018, 07:47:00 PM
Looks good @Danne! Miow. Thanks for trying out and reporting. I tried to fix that and found even more bugs  :P
Please try again! ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 28, 2018, 08:32:58 PM
Great. I´m on it :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 28, 2018, 09:05:05 PM
Great masc! All works now. I also added wav support to tif workflow in my latest script. download here if anybody wants to try it out:
https://bitbucket.org/Dannephoto/mlv-app-danne/downloads/MLV%20App.app.zip
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Teamsleepkid on April 29, 2018, 01:45:27 AM
I've been trying it... i see my folder with tiffs updating. its sticking together tiffs right? i guess i just don't know how to get a video out of it. its disappearing after the folder is done. then it says "OK" and theres a little switch box that says "kill" or "quit" how to use these three buttons? and how to get a video out of it? and thanks seems very interesting/promising. the next advancements will no doubt be software related in regards to magic lantern.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on April 29, 2018, 09:07:49 AM
@Teamsleepkid
Could you try with a short file, let´s say 10 frames? In Cut in & Cut out in Mlv App specify 10 in Out.
Why? Since processing takes very long this way you can check earlier if you are getting any output or not.

Also try the latest version here:
https://bitbucket.org/Dannephoto/mlv-app-danne/downloads/MLV%20App.app.zip

Replaced tblend ffmpeg filter with enfuse merging which works a lot better. Enfuse is already downloaded in the Hugin package so it takes no extra space. WHy I couldn´t use it before was because of flicker but with some roundtripping it now works:
Commit:
https://github.com/dannephoto/MLV-App/commit/64dbfd0965cb9f549d09ecdb3e3621be83364c67

tblend
(https://s18.postimg.cc/zbi4fpsdl/M27-0606_000000_2.png)

Enfuse
(https://s18.postimg.cc/h8p1ohot5/M27-0606_000000.png)


There is a log file coming out now but it won´t say very much at the moment. You can check if any dependency is missing from the log. Or post output here.

The terminal box in the corner is for you to be able to kill or CANCEL processing. I changed layout a bit now but CANCEL is killing the processes Closing the window is only closing the terminal box but continues processing.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: whysodifficult on April 30, 2018, 08:14:22 AM
Hi guys,
may i ask 2 questions, please?
1) Why does MLV App change colors so much? How can I see the original look?
2) Do you know that MOV H.265 is not opening in Quicktime?

This is very close to real look:

(https://thumb.ibb.co/bR5Wgx/Screen_Shot_2018_04_29_at_9_37_25_PM.png) (https://ibb.co/bR5Wgx)


And this what MLV App gives:

(https://thumb.ibb.co/jSJv8c/Screen_Shot_2018_04_29_at_11_07_53_PM.png) (https://ibb.co/jSJv8c)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on April 30, 2018, 08:59:56 PM
Quote from: whysodifficult on April 30, 2018, 08:14:22 AM
Hi guys,
may i ask 2 questions, please?
1) Why does MLV App change colors so much? How can I see the original look?
2) Do you know that MOV H.265 is not opening in Quicktime?
1. That was discussed many times: MLVApp uses 5D2 camera matrices. In other words: 5D2 clips look best here, clips from other cams (I don't know what you use) may not be 100% correct. Ilia is working on a solution for all cameras, but this is difficult. But on the other side: every program I used in past gave me a slightly different interpretation of RAW files.
2. Apple seems to have problems with H.265. VLC can open it for example. Apple AVFoundation also can't export to H.265 in many macOS.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 01, 2018, 08:02:24 AM
Hi masc.
Could you possibly write out MLV input folder path to a txt file called sent to /tmp/Data3.txt
This way I will have more control over all three paths(application, destination, source paths)
In scripting.c I suppose is where it could be put. Similar(loosely describe below  :P):
    //path to MLV source folder
    QString path = QFileInfo( m_lastSaveFileName ).absolutePath();
    QString filename4 = "/tmp/Data3.txt";
    QFile file4(filename4);
    file4.open(QIODevice::WriteOnly);

    file4.close();
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 01, 2018, 12:41:52 PM
Ok, think I fixed the source path myself.
Also added changes to HDR_MOV.command, lots of new stuff lately, safety checks and logging procedures:
https://github.com/dannephoto/MLV-App/commit/2b23894101f7cf8bb72d04832c923a7788d6b1ab

Latest version:
https://bitbucket.org/Dannephoto/mlv-app-danne/downloads/MLV%20App.app.zip


Suggestion:
If dragging .command script to the session window that if it already exists in application folder overwrite the old one with the newly dragged one. Good to be able when adding changes to the script and just short cut them into applications folder.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 01, 2018, 05:26:50 PM
Quote from: Danne on May 01, 2018, 08:02:24 AM
Hi masc.
Could you possibly write out MLV input folder path to a txt file called sent to /tmp/Data3.txt
This way I will have more control over all three paths(application, destination, source paths)
That is difficult, because each file in the session could have a different path.

Quote from: Danne on May 01, 2018, 12:41:52 PM
Suggestion:
If dragging .command script to the session window that if it already exists in application folder overwrite the old one with the newly dragged one. Good to be able when adding changes to the script and just short cut them into applications folder.
Yes, I thought it is realized this way. That does not work? It does not overwrite? I'll have a look...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 01, 2018, 05:32:27 PM
@Danne: script overwriting on import is corrected (sometimes I should better read the Qt manual). Please try out! ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 01, 2018, 05:33:09 PM
Hey Danne could you share small HDR MLV sample to test with latest stuff under linux?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 01, 2018, 05:35:30 PM
I checked your code and it should overwrite. It didn't say anything in prompt so if it works it would be nice to have some prompt opening telling us the command file was replaced.
You are right could be multiple mlv folders added, however, would it be possible to append the file /tmp/Data3.txt so that all source folders are listed? How is Mlv App working multiple source folders right now I wonder?

@bouncyball
Check here:
https://bitbucket.org/Dannephoto/mlv-app-danne/downloads/

Edit: @masc. Missed that you fixed overwriting. Will check soon...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 01, 2018, 05:40:54 PM
Quote from: Danne on May 01, 2018, 05:35:30 PM
I checked your code and it should overwrite. It didn't say anything in prompt so if it works it would be nice to have some prompt opening telling us the command file was replaced.
The Qt copy function does not overwrite. So I delete the file first now. Should work now with latest commit.

Quote from: Danne on May 01, 2018, 05:35:30 PM
You are right could be multiple mlv folders added, however, would it be possible to append the file /tmp/Data3.txt so that all source folders are listed? How is Mlv App working multiple source folders right now I wonder?
MLVApp saves all pathes of all files in the session in a variable-structure, together with all settings made in the edit-area. If you need it, we should create one txt file per clip. Where do you like to have that? Do you delete the temp files when ready, to not become a messy HDD?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 01, 2018, 05:54:37 PM
I see, every folder path is saved once selected?
Anyway, either send txt files to /tmp or if possible simply append every path to one txt file, something equivalent to:
echo path1 > /tmp/Data3.txt
echo path2 >> /tmp/Data3.txt


Will check overwrite version soon.

edit: if appending does not work and we need to collect multiple txt files it would be more handy if a folder is created and all path txt files are sent to it. Something like:
/tmp/mlvapp_paths
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 01, 2018, 06:06:48 PM
Quote from: Danne on May 01, 2018, 05:54:37 PM
I see, every folder path is saved once selected?
Yes - as long the session is opened. If you save the session, it is listed in the .masxml (here you can read most of the variables saved too).

Quote from: Danne on May 01, 2018, 05:54:37 PM
Anyway, either send txt files to /tmp or if possible simply append every path to one txt file, something equivalent to:
echo path1 > /tmp/Data3.txt
echo path2 >> /tmp/Data3.txt

Doesn't this overwrite the file for each mlv? In the end only the last path is in the file, or am I wrong? Or is every folder in a new line in this file?

Quote from: Danne on May 01, 2018, 05:54:37 PM
if appending does not work and we need to collect multiple txt files it would be more handy if a folder is created and all path txt files are sent to it. Something like:
/tmp/mlvapp_paths
Yes, we can do this - would be cleaner. But an autodelete from time to time would also be nice - what do you think?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ultimatemale on May 01, 2018, 06:08:43 PM
Hi guys everytime I opened a folder (from a full 64gb card) and drag the whole clips into MLV APP, for some reason it won't accept the LAST clip in that folder (it ckeeps saying its corrupt). Am talking about clips recorded with the usual MLV RAW build(not this new 4k RAW build)
I have tried opening just that LAST clip alone in MLV APP it still won't (its always the last clip on every full 64GB card folder).
I know its not corrupt because RAWmagic is able to open and convert these files

Anyone having this same issue?
Would you like me to upload a link for you to download and try?

I shoot on a 5D3 With old build from (wwhich work fine)



LINK
https://drive.google.com/drive/folders/1K8DNFBCgiYBCglxdZe_ZsAA1QFhHTWU_?usp=sharing

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 01, 2018, 06:15:25 PM
Quote from: ultimatemale on May 01, 2018, 06:08:43 PM
Hi guys everytime I opened a folder (from a full 64gb card) and drag the whole clips into MLV APP, for some reason it won't accept the LAST clip in that folder (it ckeeps saying its corrupt). Am talking about clips recorded with the usual MLV RAW build(not this new 4k RAW build)
I have tried opening just that LAST clip alone in MLV APP it still won't (its always the last clip on every full 64GB card folder).
I know its not corrupt because RAWmagic is able to open and convert these files
What happens, if you only open this one single file?
Edit... ah, does also not open. Then please upload this file! ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ultimatemale on May 01, 2018, 06:26:15 PM
Quote from: masc on May 01, 2018, 06:15:25 PM
What happens, if you only open this one single file?
Edit... ah, does also not open. Then please upload this file! ;)


https://drive.google.com/drive/folders/1K8DNFBCgiYBCglxdZe_ZsAA1QFhHTWU_?usp=sharing
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 01, 2018, 06:39:40 PM
Quote from: masc on May 01, 2018, 06:06:48 PM
Doesn't this overwrite the file for each mlv? In the end only the last path is in the file, or am I wrong? Or is every folder in a new line in this file?
Yes, we can do this - would be cleaner. But an autodelete from time to time would also be nice - what do you think?

Appending will collect all paths neatly placed in a list. When list is opened we will find:
path1
path2
path3
And so on. Now the script can safely check for existence and check mlv and so on.
Auto delete, that's right, could be an issue here if the lists stays in there. Hm, maybe collect separate files as you say. As long as the files exists in the session it should stay in the folder.
Hopefully this isn't too complicated. If so I will have to rearrange some deletion routines in the script.

edit: the more I think of the harder it seems. Even if deleting mlv files there can be mutiple files here that comes from different folders.
Main reason I want the source folders is to know if I can safely delete the mov or tif folders once they are created by matching mlv to the file/folder that will be deleted. Then again it would be sufficient to send onle the MLV filenames to a dedicated mlv list and then I can just grep for the file name instead.
So how can we send a MLV list to /tmp?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 01, 2018, 06:54:13 PM
Quote from: Danne on May 01, 2018, 06:39:40 PM
Appending will collect all paths neatly placed in a list. When list is opened we will find:
path1
path2
path3
And so on. Now the script can safely check for existence and check mlv and so on.
Auto delete, that's right, could be an issue here if the lists stays in there. Hm, maybe collect separate files as you say. As long as the files exists in the session it should stay in the folder.
Hopefully this isn't too complicated. If so I will have to rearrange some deletion routines in the script.
Would it be better to have all paths+filenames (one per line) in this file? So you are able to get the info which file is in which path.

If we have all files in /tmp/mlvapp_paths, then just delete the folder in the end of the script ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 01, 2018, 06:55:33 PM
Quote from: ultimatemale on May 01, 2018, 06:26:15 PM

https://drive.google.com/drive/folders/1K8DNFBCgiYBCglxdZe_ZsAA1QFhHTWU_?usp=sharing

Thx, I'll have a look. @bouncyball: could you also check what happens? File error checking was implemented by you ;) ... you're deeper in this than I am.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 01, 2018, 06:58:03 PM
Yes full mlv path in a list is ok.
Check my edited answer above. Similar idea  :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ultimatemale on May 01, 2018, 07:23:08 PM
Quote from: masc on May 01, 2018, 06:55:33 PM
Thx, I'll have a look. @bouncyball: could you also check what happens? File error checking was implemented by you ;) ... you're deeper in this than I am.
Cheers dude, awaiting your response
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 01, 2018, 08:29:24 PM
Quote from: Danne on May 01, 2018, 06:58:03 PM
Yes full mlv path in a list is ok.
Check my edited answer above. Similar idea  :P
Hej Danne, check out latest revision. I changed:
- temp files are in /tmp/mlvapp_path/... now
- temp file names are changed to "better" names
- one temp file includes a list of all original mlv filenames+pathes
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 01, 2018, 08:44:56 PM
Quote from: ultimatemale on May 01, 2018, 07:23:08 PM
Cheers dude, awaiting your response
I debugged with your file now: MLVApp is right, when it tells that it is corrupted. It includes a MLV block named "È\0"... that is not defined in the mlv definition. In past we ignored such blocks, but this was not always safe, if I remember right. I tried ignoring via a small code change and MLVApp did not crash and I could open the file. Maybe you should try another nightly build, which does not produce such errors (whyever it does, I am a noob here).
@bouncyball: is it possible to safely ignore such corrupted blocks in files, in a way we can be sure MLVApp does not crash?
--> video_mlv.c line 1450 and following...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 01, 2018, 09:00:11 PM
Hell yeah :)
app_path.txt
file_names.txt
output_folder.txt
tif_creation


I need to rewrite some parts of my script now to fit with this refinements but I really like it better.

Now a question. Is it possible to erase and add path+names from the file_names.txt file while arranging in the session window? I see myself deleting and adding files back and forth in session window but not until I hit Export and Save button will I be sure what path+names will be used in the end. This is no biggie if it doesn´t work since I will use these paths to check for matching features so if the file is still in file_names.txt it will be ignored.

Thanks again for an open mind and helping coding hands :),
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 01, 2018, 09:13:29 PM
@Danne: each time you import a masxml we check, if the files exist. If not, this mlv will not be loaded in MLVApp, and you won't get this filename into file_names.txt when exporting. So the only way to crash the app is moving the file while it is loaded into MLVApp. Until now we said, we don't want to control this... :P
You also only get the filenames chosen for export (must not be all files in the session).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ultimatemale on May 01, 2018, 09:18:59 PM
Quote from: masc on May 01, 2018, 08:44:56 PM
I debugged with your file now: MLVApp is right, when it tells that it is corrupted. It includes a MLV block named "È\0"... that is not defined in the mlv definition. In past we ignored such blocks, but this was not always safe, if I remember right. I tried ignoring via a small code change and MLVApp did not crash and I could open the file. Maybe you should try another nightly build, which does not produce such errors (whyever it does, I am a noob here).
@bouncyball: is it possible to safely ignore such corrupted blocks in files, in a way we can be sure MLVApp does not crash?
--> video_mlv.c line 1450 and following...

Thanks a lot dude

In your test would you say the new 4k Experimental builds are quit stable for recording 1080p RAW? Bcus if it is then i might as well just stick with it instead of still using the old usual Nightly build which only does 1080p.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 01, 2018, 09:33:25 PM
Quote from: ultimatemale on May 01, 2018, 09:18:59 PM
Thanks a lot dude

In your test would you say the new 4k Experimental builds are quit stable for recording 1080p RAW? Bcus if it is then i might as well just stick with it instead of still using the old usual Nightly build which only does 1080p.
Sorry, I can't tell you how safe it might be. But if I hear "experimental", I wouldn't think first it is "stable". You might have luck and it works brilliant (what often is the case), but maybe it doesn't ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ultimatemale on May 01, 2018, 09:46:55 PM
Quote from: masc on May 01, 2018, 09:33:25 PM
Sorry, I can't tell you how safe it might be. But if I hear "experimental", I wouldn't think first it is "stable". You might have luck and it works brilliant (what often is the case), but maybe it doesn't ;)

Thanks for the reply dude
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 01, 2018, 10:06:02 PM
@masc
Great :).
I'll test and implement. Talk soon again. Let's see if mr B will linux up my script as well ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 02, 2018, 08:36:39 AM
Thanks masc for path routines. Works perfectly!

Latest download:
https://bitbucket.org/Dannephoto/mlv-app-danne/downloads/MLV%20App.app.zip

It would be nice if the master branch could update my HDR_MOV-command script to the latest version here like I did in my fork:
https://github.com/dannephoto/MLV-App/blob/master/platform/qt/bash_scripts/HDR_MOV.command

source
https://github.com/dannephoto/MLV-App
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 02, 2018, 09:05:13 AM
Quote from: Danne on May 02, 2018, 08:36:39 AM
Thanks masc for path routines. Works perfectly!

Latest download:
https://bitbucket.org/Dannephoto/mlv-app-danne/downloads/MLV%20App.app.zip

It would be nice if the master branch could update my HDR_MOV-command script to the latest version here like I did in my fork:
https://github.com/dannephoto/MLV-App/blob/master/platform/qt/bash_scripts/HDR_MOV.command

source
https://github.com/dannephoto/MLV-App
Done. Thank you!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 03, 2018, 12:10:07 PM
Quote from: ultimatemale on May 01, 2018, 06:26:15 PM
https://drive.google.com/drive/folders/1K8DNFBCgiYBCglxdZe_ZsAA1QFhHTWU_?usp=sharing
Can't download: Error 404.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 04, 2018, 11:44:30 AM
@masc
Hi again. Been building another script derived from this:
https://www.magiclantern.fm/forum/index.php?topic=21089.msg193622#msg193622

Here is the script in question:

https://bitbucket.org/Dannephoto/mlv-app-danne/downloads/tif_clean.command

I can drag this script into session window and it installs fine into MacOS folder. Problem is when I select the newly installed script tif_clean.command it will instead execute HDR_MOV.command. Seems to be default. Tried restart and also removing HDR_MOV.command but not helping here unfortunately...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on May 06, 2018, 06:39:19 AM
Very low priority issue here, BUT

I tried out QTv0.8alpha on Crouton XFCE4 on my Chromebook Acer R11.  The machine isn't cut out for this kind of work but I wanted to see if I could use it for MLV processing in a pinch.

Crouton on Chromebooks is already hacky, so I didn't have high hopes, but MLV App worked as expected except on export - it only gets to 50% and instead of putting out a movie it puts out PNG frames.

Again, I doubt anyone is seriously depending on a Chromebook for this kind of work but I thought I'd report it as Linux container support will (fingers crossed) soon work natively within ChromeOS.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 07, 2018, 02:50:20 PM
Quote from: jpegmasterjesse on May 06, 2018, 06:39:19 AM
I tried out QTv0.8alpha on Crouton XFCE4 on my Chromebook Acer R11.  The machine isn't cut out for this kind of work but I wanted to see if I could use it for MLV processing in a pinch.
Why do you use v0.8 (released 227 days ago) when v0.15 (latest) is out? :) Link (https://ilia3101.github.io/MLV-App/)

Edit: Ahh.. yes because of the only linux release MLV.App.v0.8.alpha.x64.Linux.AppImage ;)

If on Crouton XFCE4 can be installed Linux version of QT 5.9 you could compile latest Git version on your chromebook.
   
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 07, 2018, 09:30:05 PM
@masc
Looks like this is executed every time even if another script is chosen:
In Scripting.cpp
    //enabling HDR processing, no questions asked. Yet.
    QProcess process;
    process.startDetached("/bin/bash", QStringList()<< "HDR_MOV.command");

Could "HDR_MOV.command" be turned into a variable?

Regards this issue:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg201009#msg201009
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on May 08, 2018, 02:33:16 AM
Quote from: bouncyball on May 07, 2018, 02:50:20 PM
Why do you use v0.8 (released 227 days ago) when v0.15 (latest) is out? :) Link (https://ilia3101.github.io/MLV-App/)

Edit: Ahh.. yes because of the only linux release MLV.App.v0.8.alpha.x64.Linux.AppImage ;)

If on Crouton XFCE4 can be installed Linux version of QT 5.9 you could compile latest Git version on your chromebook.

I'm such a noob - any chance you could point me to a tutorial that could get me started?  I've never compiled nothing :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 08, 2018, 04:00:33 PM
Try this guide (https://sternenkarten.com/tutorial-englisch/) kindly written and translated to English by @escho
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 08, 2018, 04:53:45 PM
I should build a compiler tool for Mlv App for mac.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 08, 2018, 05:38:26 PM
Tried out the white balance branch to see what could be done with color

Opened up a MLV file out of the box gives following(canon eos 100D)


Edit: I notice camera matrices for eos 100D isn´t added in camera_matrices.c? Code not used?


Official release
(https://s9.postimg.cc/k4mu8u8q7/Screen_Shot_2018-05-08_at_17.31.11.png_scaled.jpg)

White balance branch
(https://s9.postimg.cc/8fiukx7hr/Screen_Shot_2018-05-08_at_17.31.45.png_scaled.jpg)

WB set to 2000(Official release)
(https://s9.postimg.cc/no8rynj5r/Screen_Shot_2018-05-08_at_17.32.59.png_scaled.jpg)

WB set to 2000(white balance branch)
(https://s9.postimg.cc/xyb6xwgr3/Screen_Shot_2018-05-08_at_17.32.26.png_scaled.jpg)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on May 09, 2018, 04:36:47 AM
The WB branch seems stuck, right? Ilia even commited (https://github.com/ilia3101/MLV-App/commit/bc3e7525261a8e1152e12e704cb76c0cd8d4aefe#commitcomment-28591731) the Andy600 suggestion, but backed off...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 09, 2018, 09:36:31 AM
This is not the matrix issue. White balance branch more or less correctly calculates WB for 4500K-6500K range. For 5500K it's perfect :). Other temps are quite off. As I said this branch is highly experimental.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 09, 2018, 09:37:24 AM
Quote from: Danne on May 08, 2018, 04:53:45 PM
I should build a compiler tool for Mlv App for mac.
What do you mean? :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 09, 2018, 09:50:50 AM
Something like this:
https://bitbucket.org/Dannephoto/compiler/
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on May 09, 2018, 10:27:01 AM
Quote from: bouncyball on May 09, 2018, 09:36:31 AM
Other temps are quite off.

Any clue on why? What is necessary to bring it to mainline?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 09, 2018, 11:11:37 AM
Curious too what parameters manipulates color.
Could dcraw sources be of any help?

Also this:
https://www.magiclantern.fm/forum/index.php?topic=15897.msg154451#msg154451
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 09, 2018, 04:18:38 PM
Quote from: 50mm1200s on May 09, 2018, 10:27:01 AM
Any clue on why? What is necessary to bring it to mainline?
If I had any clue, I would fix it :P

It is Ilia's territory ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on May 09, 2018, 04:24:10 PM
Quote from: 50mm1200s on May 09, 2018, 04:36:47 AM
The WB branch seems stuck, right? Ilia even commited (https://github.com/ilia3101/MLV-App/commit/bc3e7525261a8e1152e12e704cb76c0cd8d4aefe#commitcomment-28591731) the Andy600 suggestion, but backed off...
An incorrect interpreatation of what andy said. That's why I "backed off". Then I noticed some other flaws.

All I need for whitebalance branch is a good multiplier generator, maybe that I can take from DCRaw. That is why the temps are "Off".

@Danne a compiler tool would be great if you did that, I get really bored during the procedure with unzipping ffmpeg, configuring project in Qt creator etc...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 09, 2018, 06:15:16 PM
@Ilia3101

Quote from: Ilia3101 on May 09, 2018, 04:24:10 PM
All I need for whitebalance branch is a good multiplier generator, maybe that I can take from DCRaw. That is why the temps are "Off".
Do you remember I've been experimenting with well known and widely used (cr2hdr, mlvfs) ufraw multiplier functions? We could try to adapt it to WhiteBalance branch. Or maybe you already took a look at it and decided that this code is not useful in this situation?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 09, 2018, 06:23:49 PM
@Bouncyball
That would be a great achievement.
@Ilia*
Gonna look into a simplifying compiling tool. Might take a while, pretty busy atm...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on May 09, 2018, 08:30:20 PM
(xenial)jessepeej@localhost:~/MLV-App/MLV-App-master/platform/qt$ qmake
(xenial)jessepeej@localhost:~/MLV-App/MLV-App-master/platform/qt$ make
/usr/lib/x86_64-linux-gnu/qt5/bin/uic MainWindow.ui -o ui_MainWindow.h
/usr/lib/x86_64-linux-gnu/qt5/bin/uic InfoDialog.ui -o ui_InfoDialog.h
/usr/lib/x86_64-linux-gnu/qt5/bin/uic StatusDialog.ui -o ui_StatusDialog.h
/usr/lib/x86_64-linux-gnu/qt5/bin/uic ExportSettingsDialog.ui -o ui_ExportSettingsDialog.h
/usr/lib/x86_64-linux-gnu/qt5/bin/uic EditSliderValueDialog.ui -o ui_EditSliderValueDialog.h
/usr/lib/x86_64-linux-gnu/qt5/bin/uic Updater/updaterUI/cupdaterdialog.ui -o ui_cupdaterdialog.h
g++ -c -m64 -pipe -O2 -Wall -W -D_REENTRANT -fPIC -DQT_DEPRECATED_WARNINGS -DSTDOUT_SILENT -DQT_NO_DEBUG -DQT_MULTIMEDIA_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtMultimedia -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -I. -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -o main.o main.cpp
In file included from Updater/updaterUI/CUpdater.h:11:0,
                 from MainWindow.h:38,
                 from main.cpp:8:
Updater/updaterUI/../cautoupdatergithub.h:52:2: warning: identifier 'nullptr' is a keyword in C++11 [-Wc++0x-compat]
  UpdateStatusListener* _listener = nullptr;
  ^
In file included from Updater/updaterUI/CUpdater.h:11:0,
                 from MainWindow.h:38,
                 from main.cpp:8:
Updater/updaterUI/../cautoupdatergithub.h:33:20: error: 'function' in namespace 'std' does not name a template type
         const std::function<bool (const QString&, const QString&)>& versionStri
                    ^
Updater/updaterUI/../cautoupdatergithub.h:33:28: error: expected ',' or '...' before '<' token
         const std::function<bool (const QString&, const QString&)>& versionStri
                            ^
In file included from Updater/updaterUI/CUpdater.h:11:0,
                 from MainWindow.h:38,
                 from main.cpp:8:
Updater/updaterUI/../cautoupdatergithub.h:35:67: warning: defaulted and deleted functions only available with -std=c++11 or -std=gnu++11
  CAutoUpdaterGithub& operator=(const CAutoUpdaterGithub& other) = delete;
                                                                   ^
Updater/updaterUI/../cautoupdatergithub.h:50:13: error: 'function' in namespace 'std' does not name a template type
  const std::function<bool (const QString&, const QString&)> _lessThanVersionStr
             ^
Updater/updaterUI/../cautoupdatergithub.h:52:36: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11
  UpdateStatusListener* _listener = nullptr;
                                    ^
Updater/updaterUI/../cautoupdatergithub.h:52:36: error: 'nullptr' was not declared in this scope
In file included from MainWindow.h:38:0,
                 from main.cpp:8:
Updater/updaterUI/CUpdater.h:28:67: warning: override controls (override/final) only available with -std=c++11 or -std=gnu++11
     void onUpdateAvailable(CAutoUpdaterGithub::ChangeLog changelog) override;
                                                                   ^
Updater/updaterUI/CUpdater.h:29:61: warning: override controls (override/final) only available with -std=c++11 or -std=gnu++11
     void onUpdateDownloadProgress(float percentageDownloaded) override {Q_UNUSE
                                                             ^
Updater/updaterUI/CUpdater.h:30:35: warning: override controls (override/final) only available with -std=c++11 or -std=gnu++11
     void onUpdateDownloadFinished() override {};
                                   ^
Updater/updaterUI/CUpdater.h:31:44: warning: override controls (override/final) only available with -std=c++11 or -std=gnu++11
     void onUpdateError(QString errorMessage) override {Q_UNUSED(errorMessage);}
                                            ^
Makefile:849: recipe for target 'main.o' failed
make: *** [main.o] Error 1



Anyone have a guess what I did wrong?   :o
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on May 09, 2018, 10:05:40 PM
I think you have to use -std=c++11 on g++ options... at least that's what the error log is saying.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on May 09, 2018, 10:16:55 PM
Quote from: 50mm1200s on May 09, 2018, 10:05:40 PM
I think you have to use -std=c++11 on g++ options... at least that's what the error log is saying.

Thanks! Way out of my depth here - g++ is a different compiler method than qmake, right? Or should I just add some specifications to the qmake or make commands?

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on May 09, 2018, 11:54:13 PM
Well, from what I know, g++ is a compiler, qmake is a makefile. The makefile links all the libraries and other code of the project and then sends to the compiler itself. The compiler will then... compile (transform to binary code). Inside the makefile you should add the compiler options, such as optimizations (-Ox in GCC, where "x" is a number from 1 to 3 or "s"), also archtechture specific parametters (x86, ARM, etc), and other stuff I really don't know.
Are you using some linux distro or Mac? Cygwin is very boring to deal with. If you're on Windows I'd suggest you see Chocolatey, a package manager that can install automatically many tools. On Mac, see Homebrew...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 10, 2018, 05:40:46 AM
Quote from: Danne on May 07, 2018, 09:30:05 PM
@masc
Looks like this is executed every time even if another script is chosen:
In Scripting.cpp
    //enabling HDR processing, no questions asked. Yet.
    QProcess process;
    process.startDetached("/bin/bash", QStringList()<< "HDR_MOV.command");

Could "HDR_MOV.command" be turned into a variable?

Regards this issue:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg201009#msg201009
Hi Danne. Sry I did not answer. I am in holiday and woll have a look when I am back.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 10, 2018, 05:42:32 AM
Quote from: Ilia3101 on May 09, 2018, 04:24:10 PM
@Danne a compiler tool would be great if you did that, I get really bored during the procedure with unzipping ffmpeg, configuring project in Qt creator etc...
Why do you not use svn? You'll just have to do this once in your life... For OSX svnX works great.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 10, 2018, 08:57:34 AM
Quote from: masc on May 10, 2018, 05:40:46 AM
Hi Danne. Sry I did not answer. I am in holiday and woll have a look when I am back.
Cool, have a great vacation :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 10, 2018, 07:12:07 PM
@jpegmasterjesse

Bouncyball directed you to my guide:
German: https://sternenkarten.com/fotos/ml/
English: https://sternenkarten.com/tutorial-englisch/
I wrote this guide for openSUSE.

I guess, you have ubuntu 16.04?

Since I change my astronomy-laptop from Windows (Ascom-drivers) to Linux (indi-drivers) atm, I just installed kubuntu 18.04. I tried to compile mlvapp with kubuntu for a quick test. I had some quirks, but finally, I succeeded. I will add this ubuntu-stuff to my guide this weekend.

Maybe, this can help you.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on May 11, 2018, 04:29:08 PM
Hello Bouncyball,

I was wondering if the following script by Danne:

https://www.magiclantern.fm/forum/index.php?topic=22076.msg201287;topicseen#msg201287

could be implemented in the next Windows version of MLVApp.  This would greatly suppress moire in cameras like the 7D, 6D and all the Rebels recording video at 1728x972 resolution with line skipping.  Now that some of these cameras can record up to 42 fps due to overclocking, this script would be extremely useful for reducing moire and further raising video quality in critical high-contrast situations. 
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 11, 2018, 08:06:56 PM
Linux-openSUSE

I played a bit with mlvapp for creating a desktop-file with a nice icon. I found a raw desktop-file in $HOME/MLV-App/MLV-App-master/platform/qt. But this desktop-file needs "*.png *.xpm *.svg *.svgz|Symbol-Dateien" as icons. I only found "MLVAPP.ico", which is not accepted. Not the biggest problem. I opend MLVAPP.ico with GIMP and exported it as png.

The second thing is the path to mlvapp. In the desktop-file, the path is mlvapp. That is fine, but only, if mlvapp is in a directory, which is described in the $PATH env-var. But mlvapp is located in (in my case) $HOME/MLV-App/MLV-App-master/platform/qt. For to run mlvapp by only clicking the desktop-file, the complete path to mlv-app is needed in the desktop-file. I changed this and have now a nice little start-symbol for mlvapp on my desktop:

https://seescho.files.wordpress.com/2018/05/mlvapp-desktop.jpg
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 12, 2018, 11:44:54 AM
@IDA_ML
Quote from: IDA_ML on May 11, 2018, 04:29:08 PM
I was wondering if the following script by Danne could be implemented in the next Windows version of MLVApp.
Despite Danne's scripts are written in bash, unfortunately, they are made very specific to mac os, hence they even do not work under Linux out of the box (without a quite rewriting). Not to mention Windows where bash could be kinda installed but with lot's of hoop jumping. Also there is linux for windows susbsystem under win10pro but it also not quite seamlessly integrated into the Windows. In short Danne is the only one who can help you if he has enough time ;)

@escho

In Ubuntu long time ago I just made shortcut of MLV App with just simple mouse drug and drop on to my desktop and also have very nice icon there. However I like running MLV App from command line in console because of some debug messages I need during development.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 12, 2018, 01:52:59 PM
For linux new application paths(three I guess) and then mlv_apps paths folder assigned to maybe home folder and then maybe it'll work.
For windows a little more work but a basic single processing for loop should get things going.
Not enough time atm but who knows about the future...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on May 12, 2018, 04:04:41 PM
Quote from: escho on May 11, 2018, 08:06:56 PMI only found "MLVAPP.ico", which is not accepted.

src/icon - there you will find icon.png and icon.blend (it's open source)


Just remembered a thing... was anyone using Cocoa app on April the 1st?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 12, 2018, 05:12:18 PM
Quote from: escho on May 11, 2018, 08:06:56 PM
Linux-openSUSE

I played a bit with mlvapp for creating a desktop-file with a nice icon. I found a raw desktop-file in $HOME/MLV-App/MLV-App-master/platform/qt. But this desktop-file needs "*.png *.xpm *.svg *.svgz|Symbol-Dateien" as icons. I only found "MLVAPP.ico", which is not accepted. Not the biggest problem. I opend MLVAPP.ico with GIMP and exported it as png.

The second thing is the path to mlvapp. In the desktop-file, the path is mlvapp. That is fine, but only, if mlvapp is in a directory, which is described in the $PATH env-var. But mlvapp is located in (in my case) $HOME/MLV-App/MLV-App-master/platform/qt. For to run mlvapp by only clicking the desktop-file, the complete path to mlv-app is needed in the desktop-file. I changed this and have now a nice little start-symbol for mlvapp on my desktop:

https://seescho.files.wordpress.com/2018/05/mlvapp-desktop.jpg

Hej escho, see MLV_App/platform/qt/RetinaIMG/MLVAPP.png as icon. Have you seen the thread on github about how to do a appimage? There were a lot of hints from someone, but I can't help much...
https://github.com/ilia3101/MLV-App/issues/17
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 12, 2018, 05:19:49 PM
Quote from: Danne on May 07, 2018, 09:30:05 PM
@masc
Looks like this is executed every time even if another script is chosen:
In Scripting.cpp
    //enabling HDR processing, no questions asked. Yet.
    QProcess process;
    process.startDetached("/bin/bash", QStringList()<< "HDR_MOV.command");

Could "HDR_MOV.command" be turned into a variable?

Regards this issue:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg201009#msg201009

Danne, could you please have try?! Greats from my holiday! ;)
(I did not test but commit something...)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 12, 2018, 05:26:30 PM
Cool @masc. Gonna check this asap(couple of hours)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 12, 2018, 09:01:43 PM
@bouncyball

Quote from: bouncyball on May 12, 2018, 11:44:54 AM

@escho

In Ubuntu long time ago I just made shortcut of MLV App with just simple mouse drug and drop on to my desktop and also have very nice icon there.

Unfortunatly, this doesn´t work in openSUSE and kubuntu 18.04 (atm?). I can start mlvapp from the desktop, but I have no MLVAPP-icon.


@Ilia3101
@masc

Quote from: Ilia3101 on May 12, 2018, 04:04:41 PM
src/icon - there you will find icon.png

Quote from: masc on May 12, 2018, 05:12:18 PM
Hej escho, see MLV_App/platform/qt/RetinaIMG/MLVAPP.png as icon.

Thanks for the paths. Didn´t see them...


@masc

Quote from: masc on May 12, 2018, 05:12:18 PM
Have you seen the thread on github about how to do a appimage? There were a lot of hints from someone, but I can't help much...
https://github.com/ilia3101/MLV-App/issues/17

I saw it, the part of the Howto. But i didn´t read the part with the appimage.

I´m sorry, but I cannot help with an appimage. That´s beyond my skills. But maybe, I can help a bit with the linux-desktop-file, you know, this one, you wanted to copy to /usr/share/applications. More tomorrrow... :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 12, 2018, 10:44:56 PM
@masc
your fix works perfectly. I can now choose between scripts :). Awesome! Will push a script soon...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 14, 2018, 04:27:14 PM
Been checking into compiling roundtrips in qt and seems if the only thing we want is to compile a static version of Mlv App we don´t need xcode or even the full qt creator package. This means we don´t need to install two humongous packages but a smaller brew qt package seems to do the trick. Following script should take a vanilla mac user from start to finish compiling latest version of Mlv-app(master branch). Please test and report how it goes.
Copy paste following into terminal:
#!/usr/bin/env bash

#start in user directory
cd ~

if [ -f /usr/local/bin/brew ] && [ -d /usr/local/Cellar/qt/5.1* ] && [ -d /Library/Developer/CommandLineTools ]
then
#might help if the script doesn´t start right away
sleep 0.5 && clear && echo "Press enter to run the script" &
fi

if ! [ -d /Library/Developer/CommandLineTools ]
then
xcode-select --install
fi

#check for dependencies
if ! [ -f /usr/local/bin/brew ]
then
/usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
fi

#check for qt versions
if ! [ -d /usr/local/Cellar/qt/5.1* ]
then
brew install qt5
brew upgrade qt5
fi

if ! [ -d ~/MLV-App-master ]
then
curl -L https://github.com/ilia3101/MLV-App/archive/master.zip -o mlvapp_master.zip && \
unzip mlvapp_master.zip -d ~/
rm ~/mlvapp_master.zip
else
echo "updating MLV-App-master source"
cd ~/MLV-App-master
git pull https://github.com/ilia3101/MLV-App
fi
if ! [ -f ~/MLV-App-master/platform/qt/FFmpeg/ffmpeg ]
then
unzip ~/MLV-App-master/platform/qt/FFmpeg/ffmpegOSX.zip -d ~/MLV-App-master/platform/qt/FFmpeg/
fi
cd ~/MLV-App-master/platform && \
rm -r MLVAPP
mkdir -p MLVAPP && \
cd MLVAPP && \
$(ls /usr/local/Cellar/qt/5* | head -1 | tr -d ':')/bin/qmake ~/MLV-App-master/platform/qt/MLVApp.pro -spec macx-clang CONFIG+=x86_64 CONFIG+=release && /usr/bin/make -j4 && $(ls /usr/local/Cellar/qt/5* | head -1 | tr -d ':')/bin/macdeployqt ~/MLV-App-master/platform/MLVAPP/MLV\ App.app && \
make clean && \
open ~/MLV-App-master/platform/MLVAPP/


edit: added command-line tools install to the script as well(still smaller than xcode...)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 14, 2018, 06:26:30 PM
Hmm great! Are you sure this last command compiles static binary? What is the size of the binary?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 14, 2018, 06:45:57 PM
62.5mb :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 14, 2018, 09:05:28 PM
@masc

A word to the desktop-files in Linux

This is the end of the MLVAPP.pro-file:

#linux-g++ {
    #Add desktop file
#    EXTRA_FILES += \
#        mlvapp.desktop
#    for(FILE,EXTRA_FILES){
#        QMAKE_POST_LINK += $$quote(cp $${FILE} $${DESTDIR/usr/share/applications/}$$escape_expand(\n\t))
#    }
#}


I guess, this was a try to install a desktop file. But this cannot work for two reasons:

First:

"/usr/share/applications" contains desktop-files, that´s true. But these deskop-files are system-wide. For doing something system-wide in Linux, you must logged in as root or use sudo. You will be asked for the root-password then, to proceed.

Second:

"$$quote(cp $${FILE} $${DESTDIR/usr/share/applications/}$$escape_expand(\n\t))"

What is DESTDIR? /usr/share/application is a valid path in Linux. The makefile, created by qmake-qt5, shows:

cp mlvapp.desktop

The destination is missing.


I for my part do not want to install mlvapp system-wide. I want it locally in my home-folder ( /home/myusername/ ). So my way for building mlvapp is:

- download the static version from ffmpeg for linux from the ffmpeg-website
- copy ffmpeg to ~/bin
- cloning mlvapp from git
- making the buildfile with qmake-qt5
- compiling with make


I wrote a little bash-script for doing this, because sometimes I´m a bit lazy :)

OK, mlvapp is compiled. All I like to have know, is a little desktop-file. Not because it´s necessary for mlvapp to start. No, I like nice little buttons and icons to press. (That´s a reason, I love to visit the "Deutsches Museum in München". Many buttons to press there...

I do not want to have this desktop-file system-wide to avoid using the root-password. Fortunately, I can create this desktop-file locally in my home-folder. OK, which file must go to what place, now?

mlvapp.desktop

Theat goes to a hidden folder in $HOME

$HOME/.local/share/applications

MLVAPP.png (in RetinaIMG)

The png-icon has a resolution of 512x512 px. So it must go to another hidden folder in my home-directory

$HOME/.local/share/icons/hicolor/512x512/apps


Another possibility should be, I guess:

$HOME/./icons/hicolor/512x512/apps

mlvapp

The bin-file should go to a place, which is describes in the $PATH envirement-variable

$HOME/bin

Did I tell you, that I´m sometimes a bit lazy. So I wrote some lines into the MLVAPP.pro-file. Now qmake-qt5 and make are doing the job for me. Now I have the mlvapp-starter in the multimedia-part of the KDE-Quickstart-menue. And I appended it to my desktop.

#linux-g++ {
    #Add desktop file
#    EXTRA_FILES += \
#        mlvapp.desktop
#    for(FILE,EXTRA_FILES){
#        QMAKE_POST_LINK += $$quote(cp $${FILE} $${DESTDIR/usr/share/applications/}$$escape_expand(\n\t))
#    }
#}

target.path = $$(HOME)/bin
desktop.path = $$(HOME)/.local/share/applications
desktop.files += mlvapp.desktop
icon512.path = $$(HOME)/.local/share/icons/hicolor/512x512/apps
icon512.files += RetinaIMG/MLVAPP.png

INSTALLS += target desktop icon512


The way to install mlvapp and a desktop-file is now:

qmake-qt5
make
make install


Note, that is only valid for Linux-openSUSE with KDE. It should run on Kubuntu as well. Ubuntu with gnome or Ubuntumate could b different. I cannot test Gnome, but I have ubuntumate. I will give ubuntumate a try next days
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on May 15, 2018, 05:45:02 AM
Quote from: Danne on May 14, 2018, 04:27:14 PM
Please test and report how it goes.

Worked perfectly over here. I did build MLV App in the past using the humongous qt IDE packages but this was way easier.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 15, 2018, 07:01:32 AM
Really cool to hear that it worked dfort. Thanks for testing.

I put the script into an automator wrap here:
https://bitbucket.org/Dannephoto/mlv-app-danne/downloads/Mlv_App_compiler.app.zip

Double click to run it. If you run it for the first time press ctrl and right click to bypass gatekeeper.

If useful and if anyone get ideas I might put in a menu and more functions etc...
Have fun compiling :)


Edit: Since Mlv App allows for executing shell scripts it would be possible to pull and compile the latest straight from Mlv App itself if one would want to  :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on May 15, 2018, 07:57:12 AM
Quote from: escho on May 14, 2018, 09:05:28 PM
I for my part do not want to install mlvapp system-wide. I want it locally in my home-folder ( /home/myusername/ ). So my way for building mlvapp is:

- download the static version from ffmpeg for linux from the ffmpeg-website
- copy ffmpeg to ~/bin
- cloning mlvapp from git
- making the buildfile with qmake-qt5
- compiling with make


Couldn't it use the package manager, instead of copying manually? It could have a script that gets the system name and then assign the correct expression to the package manager. If I remember correctly it could use:


$ uname -a | grep -E 'Debian|Arch|OpenSUSE|Ubuntu'


Depending on the output, it could automatically call the package manager. For example, Arch would use "pacman", debian will use "apt-get install". This would make it more reliable, since if you 'hardwrite' the link in the core, and the link on ffmpeg site changes, the code will not work. Also, there's some security considerations on copying something to /bin...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 15, 2018, 03:40:20 PM
@50mm1200s
Quote
Couldn't it use the package manager, instead of copying manually?

Sure, you can use a paketmanager for installing ffmpeg, if you wan´t. I described the way for openSUSE in my guides:

German: https://sternenkarten.com/fotos/ml/
English: https://sternenkarten.com/tutorial-englisch/

Search for ffmpeg...

But remember. ffmpeg shipped with the big distributions is not compiled with all codecs, mlvapp needs. The community provided unofficiell package-repositories, which contain a fully featured ffmpeg. You first must add these repositories to your package-manager to get the correct ffmpeg-version.


QuoteAlso, there's some security considerations on copying something to /bin...

I don´t copy anything to /bin... , so no security considerations ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on May 15, 2018, 05:19:41 PM
Quote from: escho on May 15, 2018, 03:40:20 PM
I don´t copy anything to /bin... , so no security considerations ;)

Oh, that's right. Just saw you're using home with a directory named /bin. Sorry.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 16, 2018, 07:17:40 PM
openSUSE:

Quote from: escho on May 14, 2018, 09:05:28 PM

Did I tell you, that I´m sometimes a bit lazy. So I wrote some lines into the MLVAPP.pro-file. Now qmake-qt5 and make are doing the job for me. Now I have the mlvapp-starter in the multimedia-part of the KDE-Quickstart-menue. And I appended it to my desktop.


target.path = $$(HOME)/bin
desktop.path = $$(HOME)/.local/share/applications
desktop.files += mlvapp.desktop
icon512.path = $$(HOME)/.local/share/icons/hicolor/512x512/apps
icon512.files += RetinaIMG/MLVAPP.png

INSTALLS += target desktop icon512


The way to install mlvapp and a desktop-file is now:

qmake-qt5
make
make install


Note, that is only valid for Linux-openSUSE with KDE. It should run on Kubuntu as well. Ubuntu with gnome or Ubuntumate could b different. I cannot test Gnome, but I have ubuntumate. I will give ubuntumate a try next days

Tried this with kubuntu 18.04 LTS.

Works for the desktop-file
Compiling need qmake instead of qmake-qt5:

qmake
make
make install
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 16, 2018, 10:19:28 PM
ffmpeg-linux-static-builds

There are no more linux-static-builds of actual ffmpeg-versions available for some time. For more info, please have a look at the ffmpeg-website.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: york824 on May 17, 2018, 05:58:15 PM
Hi everyone I'm very new to raw video shooting and I have some questions which after some searching I still can't find answers to.

When using MLV App to export MLV files to CinemaDNG, I always get half-resolution DNG files. I shoot in 1736*976 (streched from 1736*586) but only get 868*488 files. If I choose to "Export Actual Frame" then I get the full resolution DNG. Is it normal? Right now I can only make some adjustments in MLV App and export to Prores but I want to use Lightroom to do some more editing or using Rawtherapee to completely remove all the pink dots. How do I get the full-resolution DNG files?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 18, 2018, 01:46:18 PM
@escho: thx for all your research and all the information you gave! Maybe that helps me - will have a closer look when I am back at home.
The paths I wrote in the .pro file were paths inside the app package. In the Qt bin directory must be a linuxdeployqt executable. This one builds the app package for linux. And this package has a special directory tree, has the desktop file, has the icon,... on OSX that nearly works out of the box...  :P

Should we add the ffmpeg static executable for linux to the repos as well? For Win & OSX we did it... If you mean it would be good, can you upload your ffmpeg version somewhere for me?

@Danne: for your compiler script: do you also have a svn checkout and update function? For each commit only some bytes are changing, so loading all 65MB makes no sense at all.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 18, 2018, 01:47:39 PM
Quote from: york824 on May 17, 2018, 05:58:15 PM
Hi everyone I'm very new to raw video shooting and I have some questions which after some searching I still can't find answers to.

When using MLV App to export MLV files to CinemaDNG, I always get half-resolution DNG files. I shoot in 1736*976 (streched from 1736*586) but only get 868*488 files. If I choose to "Export Actual Frame" then I get the full resolution DNG. Is it normal? Right now I can only make some adjustments in MLV App and export to Prores but I want to use Lightroom to do some more editing or using Rawtherapee to completely remove all the pink dots. How do I get the full-resolution DNG files?
Could you please upload such a mlv file for debugging for us? I've never seen this... When I remember right CDNG out resolution is the same as the MLV resolution, no matter what you set up in the app.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 18, 2018, 02:02:45 PM
Quote from: masc on May 18, 2018, 01:46:18 PM
@Danne: for your compiler script: do you also have a svn checkout and update function? For each commit only some bytes are changing, so loading all 65MB makes no sense at all.

svn checkout, never heard of it  :P

My workflow here is I compile the Mlv App every time the automator app is started. Before compiling it will update repository to see if there´s any news going on.

So if I understand correctly you ask for a function which only compile if any updates occured and only fo the files updated in question?

Here´s the script atm so shouldn´t be hard to see whats going on:
#!/usr/bin/env bash

#start in user directory
cd ~

if ! [ -d /Library/Developer/CommandLineTools ]
then
xcode-select --install
fi

#check for dependencies
if ! [ -f /usr/local/bin/brew ]
then
/usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
fi

#check for qt versions
if ! [ -d /usr/local/Cellar/qt/5.1* ]
then
brew install qt5
brew upgrade qt5
fi

if ! [ -d ~/MLV-App-master ]
then
curl -L https://github.com/ilia3101/MLV-App/archive/master.zip -o mlvapp_master.zip && \
unzip mlvapp_master.zip -d ~/
rm ~/mlvapp_master.zip
else
echo "updating MLV-App-master source"
cd ~/MLV-App-master
git pull https://github.com/ilia3101/MLV-App
fi
if ! [ -f ~/MLV-App-master/platform/qt/FFmpeg/ffmpeg ]
then
unzip ~/MLV-App-master/platform/qt/FFmpeg/ffmpegOSX.zip -d ~/MLV-App-master/platform/qt/FFmpeg/
fi
cd ~/MLV-App-master/platform && \
rm -r MLVAPP
mkdir -p MLVAPP && \
cd MLVAPP && \
$(ls /usr/local/Cellar/qt/5* | head -1 | tr -d ':')/bin/qmake ~/MLV-App-master/platform/qt/MLVApp.pro -spec macx-clang CONFIG+=x86_64 CONFIG+=release && /usr/bin/make -j4 && $(ls /usr/local/Cellar/qt/5* | head -1 | tr -d ':')/bin/macdeployqt ~/MLV-App-master/platform/MLVAPP/MLV\ App.app && \
make clean && \
open ~/MLV-App-master/platform/MLVAPP/
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 18, 2018, 04:52:13 PM
@masc
Thanks for the explanation.

Yes, I think it would make sense to add the ffmpeg-static for linux to the repo. Would make thinghs easier. Unfortunately I have deleated my ffmpeg version, so I cannot upload it. But It looks like the static version will be back soon on the ffmpeg-site.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: qqqavi on May 18, 2018, 05:00:18 PM
Has anyone noticed any difference between .dng uncompressed and lossless? 
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 18, 2018, 05:22:29 PM
Static builds?
https://www.npmjs.com/package/ffmpeg-static
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 19, 2018, 05:24:35 AM
Quote from: qqqavi on May 18, 2018, 05:00:18 PM
Has anyone noticed any difference between .dng uncompressed and lossless?
Sure: uncompressed is uncompressed and lossless is lossless (compressed).

Quote from: Danne on May 18, 2018, 02:02:45 PM
svn checkout, never heard of it  :P
Try out (OSX & Linux):

svn co https://github.com/ilia3101/MLV-App.git/trunk <folderOnYourDisk>

This checks out the whole repos. After this is done you'll never have to load all again! Now do just:

svn up

This only loads the few changed bits and bytes from your last svn update/checkout to the actual revision...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: qqqavi on May 19, 2018, 03:53:51 PM
TEST:

Two .dng sequences 14bits lossless, same raw settings.
.dng from MLVRaw Viewer 1.4.3 and .dng from MLVApp Alpha


(https://thumb.ibb.co/fU2ho8/waveform.jpg) (https://ibb.co/fU2ho8)
 
In order to see the difference, I mixed the two waveforms. The red one represents the .dng from MLVRawViewer.  There is a slight visual difference between both. Doesn't seem like a big deal, however the MLVApp .dng visually has more red and blue.

In Premiere Pro CC the .dng from MLVApp needs a while to play and it's slower however .dng from MLVRaw Viewer plays smoothly.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on May 20, 2018, 05:23:02 AM
So, I did a entire production with MLV and processed with MLVApp.
Here's some usability stuff I missed and would be really helpful if implemented:

1- Do not pop ffmpeg terminal (hide it). I myself work using workspaces with tiling windows. Everytime I export clips on MLVApp the ffmpeg terminal pops while I'm doing other stuff.
2- Present export options after choosing the folder for the selected clips or do a qeue panel. For example, DNxHR will not export without having the correct FPS, so I would find it better to have the export settings pop after the selected folder...
3- Fast kill (abort) export. Always I want to abort the rendering I have to wait like 1-2 minutes. Could be faster this, don't? Idk about windows, but Mac and Linux have the "kill -9" command that kill right away the process.
4- I think MLVapp is caching all MLV when loaded. Maybe it would be better to cache just the first frame, for fast loading, since (in my case) I did all the corrections using the first frame only.
5- The paused preview could be in AMaZe automatically, instead of bilinear. Save bilinear only for playback (?)
6- Copy parameters of the selected MLV to all files in session. I think it's a small change, but would save time from selecting all images manually.
7- WB Pipe for matching gray cards (I had to export a dng and check on rawtherapee to do this). I think @bouncyball already proposed this, but I'm confirming this would be very helpful (maybe when Ilia finish the new WB branch?)
8- OpenCL is in use? Could be a checkbox on the "About" panel, just to confirm it's working or not...
9- There's no resize options for DNxHR? I missed it :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on May 20, 2018, 09:44:06 AM
6. You can use ctrl+c - ctrl+a - ctrl+v to apply changes to all clips.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 20, 2018, 12:25:08 PM
@50mm1200s

1 - Console windows are hidden for any OS, but unfortunately this does not work for Windows. If someone will come up with the solution we're gonna really appreciate this.

2, 9 - Avid codecs are implemented with those restrictions in ffmpeg (I guess this is Avid spec restrictions).

3 - This should be related to stopping running ffmpeg process (however I never experienced this. How about @Ilia, @Masc, anyone?).

4 - On loading (parsing) the clip "MLV App" only caches some information derived from the MLV, like all absolutly needed block header metadata and video and audio frame offsets for fast and random frame access. The only case when actual video frames are cached if "Menu/Playback/Debayer for Preview/AMaZE Cached" is set (checked). In this case proggie tries to cache as many Amaze debayered frames as possible according to available memory.

5 - Yeah, I think this could be done and useful.

6 - Kharak already answered that. This functionality is implemented long time ago.

7 - Simple WB color picker is on schedule, needs WhiteBalance branch to be settled.

8 - OpenCL is not used right now. Only some experiments were done by me and Ilia.

Regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on May 20, 2018, 12:55:33 PM
Quote from: Kharak on May 20, 2018, 09:44:06 AM
6. You can use ctrl+c - ctrl+a - ctrl+v to apply changes to all clips.

Oh, that's cool. Thanks Kharak.

Quote from: bouncyball on May 20, 2018, 12:25:08 PM
@50mm1200s

1 - Console windows is hidden for any OS, but unfortunately this does not work for Windows. If someone will came up with the solution we're gonna really appreciate this.

I don't know how mlvapp is calling ffmpeg, but the command "start" seems to work for Windows scripts...

Quote
2,9 - Avid codecs are implemented with those restrictions in ffmpeg. (I guess this is Avid spec restrictions)

:/

Quote
4 - On loading (parsing) the clip "MLV App" only caches some information derived from the MLV, like all absolutly needed block header metadata and video and audio frame offsets for fast and random frame access. The only case when actual video frames are cached if "Menu/Playback/Debayer for Preview/AMaZE Cached" is set (checked). In this case proggie tries to cache as many Amaze debayered frames as possible according to available memory.

Ok. Well, while I try to select a new clip it has a big latency (~10s) until I'm finally able to change settings for this file. It was a bit annoying, because I had about 40 mlv files and, even though I copied the first clip settings to all the other 39, I had to adjust the exposure manually...

Quote
7 - Simple WB color picker is on schedule, needs WhiteBalance branch to be settled.

Nice!

Quote
8 - OpenCL is not used right now. Only some experiments were done by me and Ilia.

Yeah, my impression is that the prog behind opencl I kinda complicated.


Thanks bouncyball!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on May 20, 2018, 01:25:14 PM
bouncyball summed it up perfectly, also 5 was always done in Cocoa app ;D, I don't remember exactly how it was implemented but it was quite simple.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 20, 2018, 06:12:10 PM
Quote from: 50mm1200s on May 20, 2018, 12:55:33 PM
Ok. Well, while I try to select a new clip it has a big latency (~10s) until I'm finally able to change settings for this file.
Yes, last imported MLV or double clicked one is parsed fully, others parsed only with preview mode's fast method. 10sec+ sometimes needed for big MLVs and when they are on non SSD HDDs.

If you need loading and processing the same dirs several times, you can turn on the .MAPP (MLV App map) file support (check "Menu/File/Create MAPP Files"). This works like .IDX for mlvfs or .MRX for mlrawviewer. On 1st full parse of MLV, MAPP file for this clip will be created and all subsequential access to this same clip will be a lot more faster. You can always turn this feature off and delete all *.MAPP files.

Quote from: 50mm1200s on May 20, 2018, 12:55:33 PM
It was a bit annoying, because I had about 40 mlv files and, even though I copied the first clip settings to all the other 39, I had to adjust the exposure manually...
This is weird (never experienced it) and seems like a bug... Needs checking... hey @masc could this be the case? :)

Regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 20, 2018, 07:43:18 PM
Quote from: bouncyball on May 20, 2018, 06:12:10 PM
This is weird (never experienced it) and seems like a bug... Needs checking... hey @masc could this be the case? :)
Sry, can't reproduce. (In the last two weeks I recorded 525 MLVs (550GB), so I can test MLVApp with huuuuge sessions. But copy/paste two all clips with some changes was latency free and working) ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: qqqavi on May 21, 2018, 05:54:37 PM
QuoteIn Premiere Pro CC the .dng from MLVApp needs a while to play and it's slower however .dng from MLVRaw Viewer plays smoothly.

Has anyone experienced this?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 22, 2018, 08:48:05 AM
Quote from: masc on May 20, 2018, 07:43:18 PM
I recorded 525 MLVs (550GB)
:o :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 23, 2018, 06:27:16 PM
Linux static builds for ffmpeg are back again: http://www.ffmpeg.org/download.html#build-linux
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 23, 2018, 08:07:09 PM
Quote from: escho on May 23, 2018, 06:27:16 PM
Linux static builds for ffmpeg are back again: http://www.ffmpeg.org/download.html#build-linux
Cool. Which version do you recommend? ffmpeg-release-64bit-static.tar.xz ?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 23, 2018, 08:31:27 PM
Quote from: masc on May 23, 2018, 08:07:09 PM
Cool. Which version do you recommend? ffmpeg-release-64bit-static.tar.xz ?
Yes
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 23, 2018, 09:21:26 PM
You'll find it in the repos now. Use svn if you don't want to download all the big package every time... ;)

svn co https://github.com/ilia3101/MLV-App.git/trunk <folderOnYourDisk>

This checks out the whole repos. After this is done you'll never have to load all again! Now in the project folder do just:

svn up

This only loads the few changed bits and bytes from your last svn update/checkout to the actual revision...
After having unpacked the ffmpeg, did you copy it to the application directory? Maybe we can add this to the .pro file!?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 23, 2018, 09:47:54 PM
interesting with svn up. What´s the difference from let´s say hg pull, hg update or git pull?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 23, 2018, 10:07:19 PM
Quote from: Danne on May 23, 2018, 09:47:54 PM
interesting with svn up. What´s the difference from let´s say hg pull, hg update or git pull?
That may be more or less the same, just with another versioning tool. I always used svn since many years... I saw that github allows using it as well, so I did it. And it works fine! ;) There are also apps as svnX for macOS or TortoiseSVN on Win, which offer a GUI. Very easy to use...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Petter Sand on May 24, 2018, 12:01:06 AM
Hi! I just tried to export prores 4444 on my Mac Pro (Sierra 10.13.3) it was about 30 files. Tried different settings like fix bad pixel and vertical stripes.
But the MLV app (0.15) crashes after a few seconds under "prepare to export".  The MLV files are on a compact flash card when I tri to export.
It crashes also when I just import one MLV file and then try to export. I also did restart my computer. I also tried the 0.14 version of the MLV app.
Thankful for help.

Best regards
Petter
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 24, 2018, 06:28:27 AM
@Petter Sand
Does it work if you compile a version yourself on your specific computer?
https://www.magiclantern.fm/forum/index.php?topic=20025.msg201433#msg201433
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 24, 2018, 08:05:13 AM
Quote from: Petter Sand on May 24, 2018, 12:01:06 AM
Hi! I just tried to export prores 4444 on my Mac Pro (Sierra 10.13.3) it was about 30 files. Tried different settings like fix bad pixel and vertical stripes.
But the MLV app (0.15) crashes after a few seconds under "prepare to export".  The MLV files are on a compact flash card when I tri to export.
It crashes also when I just import one MLV file and then try to export. I also did restart my computer. I also tried the 0.14 version of the MLV app.
Thankful for help.

Best regards
Petter
Could you please upload one of these MLV files? That could help debugging! Thx.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 24, 2018, 09:49:53 AM
I tried enabling dualiso on this file but it turns completely black(eosm)?
https://bitbucket.org/Dannephoto/magic-lantern/downloads/M24-0848_10frames.MLV

Filmed wth sd_uhs enabled, maybe has something to do with it?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: wety67e on May 24, 2018, 10:15:51 AM
Hi
MLV App is a great app but a i have a problem.
Why doesn't Dxo photolab read these dng Files??
Is possible hack with exiftool??

Thanks
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 24, 2018, 07:24:43 PM
Quote from: Danne on May 24, 2018, 09:49:53 AM
I tried enabling dualiso on this file but it turns completely black(eosm)?
https://bitbucket.org/Dannephoto/magic-lantern/downloads/M24-0848_10frames.MLV

Filmed wth sd_uhs enabled, maybe has something to do with it?
@bouncyball: dualiso was your child... may you have a look at it? For me all is black too (in Amaze parts of the window are pink)...

Quote from: wety67e on May 24, 2018, 10:15:51 AM
Hi
MLV App is a great app but a i have a problem.
Why doesn't Dxo photolab read these dng Files??
Is possible hack with exiftool??

Thanks
Did you try another application, Resolve, Adobe or something else? Can't help with Dxo products... Can you upload a MLV which causes this problems (or some frames of it, you can cut via MLVApp and export as MLV again)?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 24, 2018, 07:55:12 PM
New version is out now for OSX and Win32, Win64 will follow as soon as bouncyball finds time to compile and upload it:

-Shadows & Highlights is now multithreaded
-Audio for AVFoundation export (macOS only)
-Update checker (checks once a day if there is a new version out)
-Post export scripting on macOS including first two scripts (thx @dannephoto)
-DualISO: Bugfix for 12bit and less
-Bugfix for file names with ä, ö, ü, ß, ...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on May 24, 2018, 08:46:10 PM
downloaded n test the win32, working great so far. waiting for the win64
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 24, 2018, 09:10:05 PM
Quote from: masc on May 23, 2018, 09:21:26 PM

After having unpacked the ffmpeg, did you copy it to the application directory? Maybe we can add this to the .pro file!?

Yes, I extract ffmpeg*tar.xz, using ark, and copy the ffmpeg-bin-file to the bin-folder in my home-directory. But it would be fine, if I woudn´t have to do this manually.

In /bin/bash I use this syntax to extract only the bin-file of ffmpeg to $HOME:
tar -C $HOME/bin -xvJf ffmpeg*.tar.xz --strip=1 --wildcards */ffmpeg
Not sure, how to add this to the .pro file. I will play a bit this weekend and tell you my results.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Erik Krause on May 24, 2018, 10:25:59 PM
Downloaded and tested the 0.16. While it opens and processes MLVs from my EOS 5D ok, it doesn't work at all with MLVs from my son's 700D (which open fine in mlrawviewer). If I try to import these files from the menu MLV App crashes immediately, if I drag them from explorer they appear in the session list but nothing happens. This is 64bit windows 10 pro with all updates, 16 GB RAM. MLV App 0.15 64bit behaves the same. You can get a short test clip from http://erik-krause.de/43010002.zip (35MB)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 24, 2018, 10:50:33 PM
Quote from: Erik Krause on May 24, 2018, 10:25:59 PM
Downloaded and tested the 0.16. While it opens and processes MLVs from my EOS 5D ok, it doesn't work at all with MLVs from my son's 700D (which open fine in mlrawviewer). If I try to import these files from the menu MLV App crashes immediately, if I drag them from explorer they appear in the session list but nothing happens. This is 64bit windows 10 pro with all updates, 16 GB RAM. MLV App 0.15 64bit behaves the same. You can get a short test clip from http://erik-krause.de/43010002.zip (35MB)
I downloaded your file and tried to debug: the bilinear module crashes. When you try to switch first to AMaZE and load the file, it works. But something is strange with your file too: Camera name = "ERR:1 md:0x 0 ml:0" and the height is 727. It is the first time I see a odd number here - is that normal?!

Edit: bilinear algorithm works in 2-line-steps. So I had to change the abort criteria - it does not crash anymore now. You'll get it with next version... or you should compile yourself. It is checked in into the repos.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Erik Krause on May 24, 2018, 11:37:14 PM
It's different if I choose AMaZE (in Debayer for Preview, right). If I try to import from menu it crashes. If I drag the file I can see the frame count and the Clip info, but main screen and histogram stay black. Only if I first drag, then import the same file from menu I get an image after the "is already opened" warning and I can export.
The clip is from a timelaps taken with silent picture. Could be that's the cause for the strange height.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: vstrglv on May 25, 2018, 09:32:13 AM
Thank you for update. Tried to test win32 (my windows 7/64)
There is error: MLV App: MLVApp.exe-Entry Point Not Found -
The procedure entry point ANS1_const_check_infinite_end could not be located in the dynamic link library LIBEAY32.dll
But MLVApp works fine!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 25, 2018, 09:41:37 AM
Quote from: Erik Krause on May 24, 2018, 11:37:14 PM
It's different if I choose AMaZE (in Debayer for Preview, right). If I try to import from menu it crashes. If I drag the file I can see the frame count and the Clip info, but main screen and histogram stay black. Only if I first drag, then import the same file from menu I get an image after the "is already opened" warning and I can export.
The clip is from a timelaps taken with silent picture. Could be that's the cause for the strange height.
That is strange - the opening function is always the same, no matter how you import a file.

Quote from: vstrglv on May 25, 2018, 09:32:13 AM
Thank you for update. Tried to test win32 (my windows 7/64)
There is error: MLV App: MLVApp.exe-Entry Point Not Found -
The procedure entry point ANS1_const_check_infinite_end could not be located in the dynamic link library LIBEAY32.dll
But MLVApp works fine!
What do you do to get this error?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 25, 2018, 11:58:58 AM
@Erik Krause: It seems bouncyball compiled and uploaded v0.16 Win64 version already with my latest fix. So try out this one please!

@bouncyball: thank you!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Petter Sand on May 25, 2018, 12:54:21 PM
@Masc

Hi! Thanks!
Here is a link to one of the MLV-files.
https://www.dropbox.com/s/i1fvsnmiw9zxvvu/M23-1408.MLV?dl=0

I just tested on my mac pro late 2013 aswell, 10.13.4
same problem.

Recently it has worked on my both computers.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Petter Sand on May 25, 2018, 12:57:34 PM
@Danne
Hi Danne!
Thjanks for you answer.
I don´t  have the knowledge to compile a version, sorry.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 25, 2018, 01:03:39 PM
Quote from: Petter Sand on May 25, 2018, 12:54:21 PM
@Masc

Hi! Thanks!
Here is a link to one of the MLV-files.
https://www.dropbox.com/s/i1fvsnmiw9zxvvu/M23-1408.MLV?dl=0

I just tested on my mac pro late 2013 aswell, 10.13.4
same problem.

Recently it has worked on my both computers.
Thx! "Unfortunately" it works also on my Macs. Can't get it to crash...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 25, 2018, 02:01:05 PM
Quote from: Petter Sand on May 25, 2018, 12:57:34 PM
@Danne
Hi Danne!
Thjanks for you answer.
I don´t  have the knowledge to compile a version, sorry.


That is the reason I built a simple one click solution:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg201433#msg201433

Download this:
https://bitbucket.org/Dannephoto/mlv-app-danne/downloads/Mlv_App_compiler.app.zip

First time press ctrl and choose open, then follow instructions.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Petter Sand on May 25, 2018, 03:21:00 PM
@Masc
Downloaded your new version! Thanks for your efforts! It worked fine!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Petter Sand on May 25, 2018, 03:21:56 PM
@Danne
Thanks!
I just tested version 0.16 that works fine!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on May 25, 2018, 03:40:23 PM
Oh wow @Danne did it! Missed it earlier. I will test out the compiler 💚
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 25, 2018, 03:41:09 PM
Cool, let me know what could be better in there :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Erik Krause on May 25, 2018, 03:42:48 PM
Quote from: masc on May 25, 2018, 11:58:58 AM
@Erik Krause: It seems bouncyball compiled and uploaded v0.16 Win64 version already with my latest fix. So try out this one please!

Works (almost)! I can open the questionable files directly or by drag and drop. Only if I choose Pattern Noise On it crashes.

The 700D has focus pixels (in my example best visible in the last frame). However, if I use Fix Focus Dots - no matter in what combination - I can see no effect. Only if I set Chroma Smooth to 3x3 they are gone. Is this to be expected?

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 25, 2018, 03:58:33 PM
Quote from: Erik Krause on May 25, 2018, 03:42:48 PM
Works (almost)! I can open the questionable files directly or by drag and drop. Only if I choose Pattern Noise On it crashes.

The 700D has focus pixels (in my example best visible in the last frame). However, if I use Fix Focus Dots - no matter in what combination - I can see no effect. Only if I set Chroma Smooth to 3x3 they are gone. Is this to be expected?
I don't get it crashed when using "Pattern Noise On" on your clip on Win or OSX.
I think focus pixel can't work, because your camera model can't be identified - do you remember, there was this wrong camera name...
@bouncyball, am I right? You implemented it to MLV App... ;)
Edit: yes, when hardcoding "it is a 700D!!!" in the code focus pixels work - so in your clip something is wrong.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 25, 2018, 05:37:09 PM
Quote from: masc on May 25, 2018, 03:58:33 PM
I think focus pixel can't work, because your camera model can't be identified - do you remember, there was this wrong camera name...
@bouncyball, am I right? You implemented it to MLV App... ;)
Edit: yes, when hardcoding "it is a 700D!!!" in the code focus pixels work - so in your clip something is wrong.
Camera name does not matter the cameraID (model ID) is important. I don't think mlv_rec/mlv_lite will mess up the camera model ID durung MLV recording. However it's gonna be interesting to take a look at this MLV.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 25, 2018, 05:41:54 PM
@Danne

Mlv_App_compiler.app is ridiculously easy solution! You took to a higher new level the care about MAC users! :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 25, 2018, 06:08:39 PM
You're too kind B :).
Mlv app project deserves all the attention it can get imo.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Erik Krause on May 25, 2018, 06:21:52 PM
Quote from: masc on May 25, 2018, 03:58:33 PM
I don't get it crashed when using "Pattern Noise On" on your clip on Win or OSX.

It's repeatable. I import a clip and click Pattern Noise: On, after few seconds of wait cursor the windows crash dialog appears.

Quote from: masc on May 25, 2018, 03:58:33 PM
I think focus pixel can't work, because your camera model can't be identified - do you remember, there was this wrong camera name...
@bouncyball, am I right? You implemented it to MLV App... ;)
Edit: yes, when hardcoding "it is a 700D!!!" in the code focus pixels work - so in your clip something is wrong.

I tried to edit the MLV with a hex editor inserting "Canon EOS 700D" (null terminated) instead of the odd string at offset 248 and the CameraModel number at offset 280 (0x80000326) and it works! Many thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Erik Krause on May 25, 2018, 08:00:57 PM
I have a little UI whish: Would it be possible to have the sliders return to default position on double clicking the slider button?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 25, 2018, 09:22:25 PM
Quote from: Erik Krause on May 25, 2018, 08:00:57 PM
I have a little UI whish: Would it be possible to have the sliders return to default position on double clicking the slider button?
Done. Comes with the next release, or you compile yourself.

I still can activate and deactivate Pattern Noise as often as I like with your clip...  :P Sry... no idea what is going on.  :'(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Erik Krause on May 26, 2018, 02:56:45 PM
Quote from: masc on May 25, 2018, 09:22:25 PM
I still can activate and deactivate Pattern Noise as often as I like with your clip

I digged in the event log and found that ntdll.dll is involved. So I updated my graphics driver and I updated windows to the April 2018 version (1803) to no avail. sfc /scannow and dism /online /cleanup-image /restorehealth found no problems. Still interesting that it only happens with the EOS 700D MLV's. Files from my 5D2 (timelaps with 2040x1268px) work fine. It's not super important, but if I can help, tell me...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 26, 2018, 03:07:21 PM
Quote from: Danne on May 25, 2018, 06:08:39 PM
Mlv app project deserves all the attention it can get imo.
Thank you :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 27, 2018, 04:51:51 PM
Quote from: masc on May 23, 2018, 08:07:09 PM
Cool. Which version do you recommend? ffmpeg-release-64bit-static.tar.xz ?

Only now, I found some minutes to test the Linux-desktop-file (created with the .pro file). Works perfect here in openSUSE. Thanks for adding.

Great, that you added ffmpeg-static to the sources. I played a bit around in the .pro-file. With this command, I succeded in unpacking only the ffmpeg-bin out of ffmpeg-static and copying it to $HOME/bin. So you don´t need to unpack ffmpeg manually.

linux-g++ {
    target.path = $$(HOME)/bin
    desktop.path = $$(HOME)/.local/share/applications
    desktop.files += mlvapp.desktop
    icon512.path = $$(HOME)/.local/share/icons/hicolor/512x512/apps
    icon512.files += RetinaIMG/MLVAPP.png

    INSTALLS += target desktop icon512
   
    QMAKE_POST_LINK += $$quote(tar -C $$(HOME)/bin -xvJf FFmpeg/ffmpegLinux.tar.xz --strip=1 --wildcards */ffmpeg)

}


I´m not sure, that this is a correct way for doing this. It was only try and error, what I did.

edit:

This one is working, too:

QMAKE_POST_LINK += tar -C $$(HOME)/bin -xvJf FFmpeg/ffmpegLinux.tar.xz --strip=1 --wildcards */ffmpeg
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 27, 2018, 07:32:20 PM
Thx @escho! I commited your line to the .pro file into the repos!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 27, 2018, 08:43:05 PM
Quote from: masc on May 27, 2018, 07:32:20 PM
Thx @escho! I commited your line to the .pro file into the repos!

Great. Tested it. Works. :)
Than I can update my compile-guides.

To make things more easy for me, I wrote a git-clone and compile-bash-script for openSUSE. If someone is interested, I can upload it to my homepage ( https://sternenkarten.com/ )
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 27, 2018, 09:04:46 PM
I have a git question. I downloaded https://github.com/ilia3101/MLV-App to my computer locally and then I usually update this branch and compile to get the latest stuff like this:
git pull https://github.com/ilia3101/MLV-App
After running this it says all is updated but when testing the newly compiled build there are things missing such as double clicking sliders and other things from masc recently. A solution is to erase the older downloaded repo and redownload a new one from  https://github.com/ilia3101/MLV-App but this shouldn´t be necessary. Is git pull  https://github.com/ilia3101/MLV-App the way to go or what am I missing here?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 27, 2018, 09:23:36 PM
Did you try:

git pull https://github.com/ilia3101/MLV-App.git


and if this doesn´t help, here is a snippet from my ML-Compile-script. This is hg, but maybe, tjhat can help:

repo_clonen()
{
    echo "-------------------------------------------------------------------------------"
    echo "------------------------------clone -------------------------------------------"
    echo "-------------------------------------------------------------------------------"
    cd $hauptverzeichnis
    hg clone -r "$branch" "$adresse"
   
    echo "-------------------------------------------------------------------------------"
    echo "-------------------------------pull -------------------------------------------"
    echo "-------------------------------------------------------------------------------"
    cd $hauptverzeichnis/branch
    hg pull
   
    echo "-------------------------------------------------------------------------------"
    echo "------------------------------update ------------------------------------------"
    echo "-------------------------------------------------------------------------------"
    hg update
}
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 27, 2018, 09:49:57 PM
Thanks escho. With hg commands I get all updates done with other proggies I work on but not with git commands. I also tried :
git pull https://github.com/ilia3101/MLV-App.git
With the same results. Latest commits missing...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 27, 2018, 10:05:02 PM
Than go to your local clone and do only

git pull

Tested it with an older mlvapp-backup. Works for me.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 27, 2018, 10:22:11 PM
git pull gives following:
dans-MacBook-Pro:MLV-App-master dan$ git pull
fatal: No remote repository specified.  Please, specify either a URL or a
remote name from which new revisions should be fetched.


Then adding what is asked for:
dans-MacBook-Pro:MLV-App-master dan$ git pull https://github.com/ilia3101/MLV-App.git
From https://github.com/ilia3101/MLV-App
* branch            HEAD       -> FETCH_HEAD
Already up-to-date.
dans-MacBook-Pro:MLV-App-master dan$

Then compiling but latest commits not included. I have to redownload the latest https://github.com/ilia3101/MLV-App.git and then latest code works...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 27, 2018, 10:37:59 PM
How did you get MLV-App-master? This is the folder, if you download the zip-file. If you do a "git clone https://github.com/ilia3101/MLV-App.git", the resulting dir shold be MLV-App. In this folder, you can do "git pull"
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 27, 2018, 10:44:31 PM
I do a curl command:
curl -L https://github.com/ilia3101/MLV-App/archive/master.zip -o mlvapp_master.zip && \
unzip mlvapp_master.zip -d ~/
rm ~/mlvapp_master.zip

Should be the same but will try your clone command tomorrow...

Will ty this:
git clone https://github.com/ilia3101/MLV-App.git MLV-App-master
Will have to wait for the next commit to see if it will work this time  :P

Meanwhile, uploaded a new version with escho tip:
https://bitbucket.org/Dannephoto/mlv-app-danne/downloads/Mlv_App_compiler.app.zip
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on May 27, 2018, 10:50:01 PM
Still having trouble compiling, anyone mind helping me? I'm running 16.04


$ make
g++ -std=c++11 -c -m64 -pipe -O2 -Wall -W -D_REENTRANT -fPIC -DQT_DEPRECATED_WARNINGS -DSTDOUT_SILENT -DQT_NO_DEBUG -DQT_MULTIMEDIA_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtMultimedia -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -I. -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -o MainWindow.o MainWindow.cpp
MainWindow.cpp: In member function 'uint8_t MainWindow::drawZebras()':
MainWindow.cpp:2913:34: error: 'class QImage' has no member named 'pixelColor'
             QColor pixel = image.pixelColor( x, y );
                                  ^
MainWindow.cpp:2918:23: error: 'class QImage' has no member named 'setPixelColor'
                 image.setPixelColor( x, y, Qt::red );
                       ^
MainWindow.cpp:2925:23: error: 'class QImage' has no member named 'setPixelColor'
                 image.setPixelColor( x, y, Qt::blue );
                       ^
MainWindow.cpp: In constructor 'MainWindow::MainWindow(int&, char**, QWidget*)':
MainWindow.cpp:58:70: warning: ignoring return value of 'int chdir(const char*)', declared with attribute warn_unused_result [-Wunused-result]
     chdir( QCoreApplication::applicationDirPath().toLatin1().data() );
                                                                      ^
Makefile:905: recipe for target 'MainWindow.o' failed
make: *** [MainWindow.o] Error 1
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 27, 2018, 11:12:53 PM
Quote from: Danne on May 27, 2018, 10:44:31 PM
I do a curl command:
curl -L https://github.com/ilia3101/MLV-App/archive/master.zip -o mlvapp_master.zip && \
unzip mlvapp_master.zip -d ~/
rm ~/mlvapp_master.zip

Should be the same but will try your clone command tomorrow...


It´s not the same. You download a zip-file and unzip it. But you don´t initialize your local copy to work with the remote repo. If you do a "git clone...", you get all initialized, what you need. Look in the working.dir of MLV-App. There should be a hidden folder ".git".
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 27, 2018, 11:15:43 PM
Yup, you´re right. Fixed. Thanks for help.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 27, 2018, 11:23:59 PM
Quote from: jpegmasterjesse on May 27, 2018, 10:50:01 PM
Still having trouble compiling, anyone mind helping me? I'm running 16.04


I have openSUSE here and cannot reach my astrophoto-laptop (kubuntu) before next weekend. Than I can try.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on May 28, 2018, 05:29:21 AM
Quote from: jpegmasterjesse on May 27, 2018, 10:50:01 PM
Still having trouble compiling, anyone mind helping me? I'm running 16.04


$ make
g++ -std=c++11 -c -m64 -pipe -O2 -Wall -W -D_REENTRANT -fPIC -DQT_DEPRECATED_WARNINGS -DSTDOUT_SILENT -DQT_NO_DEBUG -DQT_MULTIMEDIA_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtMultimedia -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -I. -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -o MainWindow.o MainWindow.cpp
MainWindow.cpp: In member function 'uint8_t MainWindow::drawZebras()':
MainWindow.cpp:2913:34: error: 'class QImage' has no member named 'pixelColor'
             QColor pixel = image.pixelColor( x, y );
                                  ^
MainWindow.cpp:2918:23: error: 'class QImage' has no member named 'setPixelColor'
                 image.setPixelColor( x, y, Qt::red );
                       ^
MainWindow.cpp:2925:23: error: 'class QImage' has no member named 'setPixelColor'
                 image.setPixelColor( x, y, Qt::blue );
                       ^
MainWindow.cpp: In constructor 'MainWindow::MainWindow(int&, char**, QWidget*)':
MainWindow.cpp:58:70: warning: ignoring return value of 'int chdir(const char*)', declared with attribute warn_unused_result [-Wunused-result]
     chdir( QCoreApplication::applicationDirPath().toLatin1().data() );
                                                                      ^
Makefile:905: recipe for target 'MainWindow.o' failed
make: *** [MainWindow.o] Error 1


It's probably some QT issue. Assuming MLVapp is using qt-5, try to install all QT base packages (don't know if ubuntu still has apt-get, but just typing "sudo apt-get install qt-5* qmake*" would do the job).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 28, 2018, 10:28:50 AM
I put in some more stuff into Mlv_App_compiler.app:
(https://s15.postimg.cc/lc2m5mudn/Screen_Shot_2018-05-28_at_10.32.05.png_500px.jpg)

It´s now uploaded to bitbucket:
https://bitbucket.org/Dannephoto/mlv_app_compiler

Download:
https://bitbucket.org/Dannephoto/mlv_app_compiler/downloads/mlv_app_compiler.dmg

@Ilia3101
Does it makes sense to include Cocoa compiling? DOes it even work atm? Just tried but no success here.
Is there more stuff we could put in here?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 28, 2018, 10:46:18 AM
Quote from: 50mm1200s on May 28, 2018, 05:29:21 AM
It's probably some QT issue. Assuming MLVapp is using qt-5, try to install all QT base packages (don't know if ubuntu still has apt-get, but just typing "sudo apt-get install qt-5* qmake*" would do the job).
It looks like your Qt5 is too old. Which Qt5 is it? Minimum is 5.6, if I remember right.
Edit: The Qt documentation tells for void QImage::setPixelColor(int x, int y, const QColor &color) : "This function was introduced in Qt 5.6."

@Danne: at least for me an option is missing to just update the working copy to the latest revision.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 28, 2018, 10:54:01 AM
It´s updating once it starts:
if ! [ -d ~/MLV-App-master ]
then
git clone https://github.com/ilia3101/MLV-App.git MLV-App-master
cd ~/MLV-App-master
else
echo "updating MLV-App-master source"
cd ~/MLV-App-master
git pull
fi

Either it pulls the latest if the whole repo is missing or it does git pull to update. SHould this be a menu option instead and leave auto update out of the compiler?

brew qt is this version atm:
5.11.0
Too new?

This is happening when compiling Cocoa app:
3 warnings generated.
1 warning generated.
clang  -mmacosx-version-min=10.10 -O3 -Ofast -m64 -DNDEBUG main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o llrawproc.o pixelproc.o stripes.o patternnoise.o hist.o dualiso.o avf_lib.o filter.o genann.o dng.o darkframe.o camera_id.o audio_mlv.o -o "MLV App" -framework Cocoa -framework AppKit -framework Foundation -framework CoreFoundation -framework OpenGL -framework CoreMedia -framework AVFoundation -framework CoreVideo;
Undefined symbols for architecture x86_64:
  "_blur_image_threaded", referenced from:
      _applyProcessingObject in raw_processing.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [build] Error 1
cp: MLV App: No such file or directory
rm -rf "MLV App" "MLV App".app main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o llrawproc.o pixelproc.o stripes.o patternnoise.o hist.o dualiso.o avf_lib.o filter.o genann.o dng.o darkframe.o camera_id.o audio_mlv.o *.o


Also tested Cocoa app against qt 5.8, no change...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 28, 2018, 11:00:24 AM
Ah, you included it... nice! I did not say anything ;) Cool!

5.11.0 should work, but I never tried it. I had such problems with an old 5.4 or something...

In the cocoa version the multithread blur module is missing in the makefile... I implemented this some weeks ago, but did not adapt the makefile.

Edit: corrected.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 28, 2018, 11:03:53 AM
hehe, I mixed up your anwer to me and 50mm1200s :).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 28, 2018, 11:20:58 AM
Awesome masc. Cocoa compiles.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 28, 2018, 04:04:11 PM
@Danne: I wanted to try out your TIF_CLEAN script. Nothing happens... the LOG tells "exiftool: MISSING!". Doesn't the script install it?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 28, 2018, 04:33:04 PM
Good catch masc. Placed the cat command at the wrong spot. Just fixed and uploaded to master branch.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 28, 2018, 04:51:40 PM
@Danne: thx, it installed it now. But... does it do something? Can you say some words how to use it? Does it work only on TIFF sequence, or also on other files? After less than a second it tells "completed" for 50 frames... is it really so fast?!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 28, 2018, 04:59:42 PM
It´s actually painfully slow. It works like this:
#the script uses 5 files to average/enfuse into one file then moves forward to the consecutive frame. Surrounded tifs are used. E.g tif1,tif2,tifinput,tif3,tif4
#final output is a high quality prores file

Meaning it will create one image out of surrounded two files before and two after the file that is getting cleaned. It´s multiprocessing but I made do two passes so it´s still very slow.


By the way. Something strange is going on over here. When compiling I am getting this:

ERROR: no file at "/usr/local/opt/qt/lib/QtMultimedia.framework/Versions/5/QtMultimedia"
ERROR: no file at "/usr/local/opt/qt/lib/QtNetwork.framework/Versions/5/QtNetwork"
ERROR: no file at "/usr/local/opt/qt/lib/QtCore.framework/Versions/5/QtCore"
ERROR: no file at "/usr/local/opt/qt/lib/QtGui.framework/Versions/5/QtGui"
ERROR: no file at "/usr/local/opt/qt/lib/QtWidgets.framework/Versions/5/QtWidgets"


When trying to open Mlv App:
MLV App cannot be opened because of a problem.
Check with the developer to make sure MLV App works with this version of macOS. You may need to reinstall the application. Be sure to install any available updates for the application and macOS.

Some dynamic library missing:
Time Awake Since Boot: 1900 seconds

System Integrity Protection: enabled

Crashed Thread:        0

Exception Type:        EXC_CRASH (SIGABRT)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Reason:    DYLD, [0x1] Library missing

Application Specific Information:
dyld: launch, loading dependent libraries

Dyld Error Message:
  Library not loaded: /usr/local/opt/qt/lib/QtMultimedia.framework/Versions/5/QtMultimedia
  Referenced from: /Users/USER/*/MLV App.app/Contents/MacOS/MLV App
  Reason: image not found

Binary Images:
       0x104d4d000 -        0x104f98ff3 +magiclantern.MLV App (0.16 alpha - 0) <11181830-1437-3390-BE93-94B78D72FB06> /Users/USER/*/MLV App.app/Contents/MacOS/MLV App
       0x11723b000 -        0x117278267  dyld (421.2) <947FC440-80F9-32F7-A773-6FC418FE1AB7> /usr/lib/dyld
    0x7fffc91ae000 -     0x7fffc936dffb  com.apple.avfoundation (2.0 - 1187.11.13) <0D0BB4A4-F987-381B-885E-88A81F50FD50> /System/Library/Frameworks/AVFoundation.framework/Versions/A/AVFoundation
    0x7fffcc539000 -     0x7fffcc539fff  com.apple.Cocoa (6.11 - 22) <CF1AD0E9-2257-35FE-B719-760B58E405C9> /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa
    0x7fffccaaa000 -     0x7fffccf3eff7  com.apple.CoreFoundation (6.9 - 1348.28) <0F1FAA52-1C06-327E-A170-382B48B1846D> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
    0x7fffcd88d000 -     0x7fffcd93dfff  com.apple.CoreMedia (1.0 - 1907.15.15) <B5B8C128-C1C2-3585-9B43-41141B2C6332> /System/Library/Frameworks/CoreMedia.framework/Versions/A/CoreMedia
    0x7fffce205000 -     0x7fffce23afff  com.apple.CoreVideo (1.8 - 234.0) <48C31E93-87C2-31F4-97E7-9E54C1EA8E7D> /System/Library/Frameworks/CoreVideo.framework/Versions/A/CoreVideo
    0x7fffce53f000 -     0x7fffce8e6ff3  com.apple.Foundation (6.9 - 1349.25) <D820A498-2E62-367D-BC72-5845B14C06E3> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation

Click Report to see more detailed information and send a report to Apple.


Are you getting any issues?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 28, 2018, 05:03:54 PM
Okay... then I am very sure the script does nothing for me. :( It only tells "completed".

Have you tried to delete the old "MLV App.app" before compiling? Then you can use macdeployqt, which links the libs into the app package.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 28, 2018, 05:14:05 PM
Sorry to hear the script doesn´t run. Could you upload the log you think?

I opened up a can of worms just now by uninstalling and reinstalling qt via brew. All bets are off it seems, lol. Gonna take me a while...

Ok, found both issues. Will fix them asap. Stay tuned.

Edit:
Pushed a fix, should work now...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 28, 2018, 10:34:55 PM
Thx Danne... it seems that it does something now - and yes, it really seems to be very slow. Tomorrow I'll see if it has done the right thing :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 28, 2018, 10:40:00 PM
Moving subject could be problematic, otherwise it will work pretty good.
Played around some with aligning and stacking around 20 files(workflow more suitable for still image workflows) resulting in noiseless output. Good starting point for superresolution output.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 29, 2018, 01:53:11 PM
Yes, as you wrote - moving subjects are problematic... I see it :) Maybe I'll try this evening with another shoot. But: IT WORKS! Hej...
There is only one more thing: when starting MLV App from QtCreator and starting the script, the ApplicationLog (in QtCreator) tells these lines (but the script is working after this output):
rm: /tmp/TIF_CLEAN.command: No such file or directory
rm: /Users/<username>/Desktop/Test/TIFCLEAN_LOG.txt: No such file or directory
ls: *.AVI: No such file or directory
ls: *.MKV: No such file or directory
ls: *.MOV: No such file or directory
ls: *.MP4: No such file or directory
ls: *.avi: No such file or directory
ls: *.mkv: No such file or directory
ls: *.mp4: No such file or directory
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 29, 2018, 02:01:31 PM
Ok, it's my sloppy bash all file search solution. I see if I can do something more elegant here  :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 29, 2018, 02:52:27 PM
@masc
Could you test dropping this into Mlv App and tell me if it still tells the same messages?
https://bitbucket.org/Dannephoto/magic-lantern/downloads/TIF_CLEAN.command
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 29, 2018, 03:01:02 PM
It is away now. Nice.  8)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 29, 2018, 03:06:19 PM
Great. pushed it to master...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on May 30, 2018, 08:58:25 AM
New version:
https://bitbucket.org/Dannephoto/mlv_app_compiler/downloads/mlv_app_compiler.dmg

Added some more stuff to MLV_App_compiler.app, possibilty to check out other branches:
(https://s15.postimg.cc/x6reo24jv/Screen_Shot_2018-05-30_at_08.56.49.png_500px.jpg)

(https://s15.postimg.cc/3svo7vty3/Screen_Shot_2018-05-30_at_08.57.05.png_500px.jpg)

Cocoa app is now a hidden feature(recommended by Ilia3101). You still reach it if you write co and press enter in the main menu...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 30, 2018, 06:00:07 PM
 8) cool!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Seruji on May 30, 2018, 07:52:52 PM
I don't know if it's my problem, but the right side column (where you set up the RAW pic before you convert it), it's very squashed, I mean, you can not strecht it or move or modify the size, so it's almost imposible to work with it. I'm working in a 4K resolution (very common nowadays). I attach a screenshot of what I exactly see.
Thank you so much for this app and for the help!

(https://thumb.ibb.co/ifehdJ/problemresolution.png) (https://ibb.co/ifehdJ)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 31, 2018, 12:08:15 AM
The German version of the Linux-Compile-Guide is now updated and extended (openSUSE and Kubuntu): https://sternenkarten.com/fotos/ml/
English translation will follow soon

I removed the compiling with qt-creator part. I´m, planning to moove this qt-creator-stuff to a seperate guide (debugging). But this will take some time.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 31, 2018, 12:01:22 PM
@escho: hehe, so easy, isn't it?! :)

Quote from: Seruji on May 30, 2018, 07:52:52 PM
I don't know if it's my problem, but the right side column (where you set up the RAW pic before you convert it), it's very squashed, I mean, you can not strecht it or move or modify the size, so it's almost imposible to work with it. I'm working in a 4K resolution (very common nowadays).
You changed the windows font (size). Windows is very strange here because it overrides also fixed application fonts, but the GUI geometry is untouched. The font sizes in the app are already fixed. So the only way to get it working is change Windows to its default and/or using another monitor. No such problems on 4K OSX.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Seruji on May 31, 2018, 12:14:05 PM
Yes, that worked, thank you (I had it to 150%). Still is visually small, so I have to change the resolution to 1080p to be able to work.
I'm pretty new on RAW (5D MKII) and I'm quite confused on the amount of apps that exist to convert MLV. ¿Which app do you recommend to start with? I'm not a big fan of running 2+ apps before you start editing (mlv converter+after effects and finally premiere, for example).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 31, 2018, 12:40:48 PM
Nice. Good to know.
I also work with a 5D MkII and use MLVApp+FCPX or MLVFS+Resolve+FCPX. That brings all I need... but other people might love other workflows and apps.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 31, 2018, 12:46:02 PM
Quote from: masc on May 31, 2018, 12:01:22 PM
@escho: hehe, so easy, isn't it?! :)


Yes, it is  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 31, 2018, 03:01:28 PM
Hello to our Linux-users! There is a compiled Linux 64bit MLVApp AppImage for download now:
https://github.com/ilia3101/MLV-App/releases/download/QTv0.16alpha/MLV.App.v0.16.alpha.Linux.x86_64.AppImage

Please try out and report if it works (success on Ubuntu 14.04 and 18.04).

Make it executable (with chmod a+x) and doubleclick.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 31, 2018, 05:41:09 PM
@all
guide for compiling Mlv-App (english) in Linux: https://sternenkarten.com/tutorial-englisch/
This guide is updated now too.

@masc
I will try the app-image later

edit:
What about ffmpeg? Does the app-image contain ffmpeg?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on May 31, 2018, 06:07:04 PM
Quote from: Seruji on May 31, 2018, 12:14:05 PM
Yes, that worked, thank you (I had it to 150%). Still is visually small, so I have to change the resolution to 1080p to be able to work.
If you are on Windows 10 there is no need to change font size or resolution.

Right click on MLVApp.exe, choose Properties/Compatibility

(https://thumb.ibb.co/gY1nyJ/WIn10.jpg) (https://ibb.co/gY1nyJ)

Check "Override high DPI scaling behavior" and select "System (Enhanced)" in "Scaling performed by:"

Run your app and use it happily :)

Regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on May 31, 2018, 07:23:41 PM
@bouncyball: nice, didn't know this one... :)

Quote from: escho on May 31, 2018, 05:41:09 PM
What about ffmpeg? Does the app-image contain ffmpeg?
No, not yet. The tar command you provided does not work for me. It brings "FFmpeg/ffmpeg not found" or something like that. I only could include it manually to the appimage. But if I untar it is >100MB, is that right?! Or do I need only one single file from the archiv (ffmpeg, or ffmpeg_10bit)?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 31, 2018, 07:40:45 PM
You only need one single file, called ffmpeg
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on May 31, 2018, 08:14:53 PM
Quote from: escho on May 31, 2018, 05:41:09 PM
@all
guide for compiling Mlv-App (english) in Linux: https://sternenkarten.com/tutorial-englisch/
This guide is updated now too.

I was still having problems with qmake, unfortunately.  Wanted to let you know that I think "gitclone" should be "git clone" in your translated instructions.

Quote from: masc on May 31, 2018, 03:01:28 PM

Please try out and report if it works (success on Ubuntu 14.04 and 18.04).


Just tried it on Kubuntu 16.04 and it was very easy to get going.  Already processed a dual-iso video on my chromebook, very pleased. This puts chromebooks on the map for me in a real way!

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on May 31, 2018, 08:55:39 PM
Hey guys. I recently started working with James Miller's C-LOG profiles. Don't now if you guys are familiar with it but my question is what export profile should I pick in MLVapp? I got Cineon, Alexa's and the s-log. Anyone's been through this and reached a conclusion of what's best?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on May 31, 2018, 09:43:39 PM
Quote from: jpegmasterjesse on May 31, 2018, 08:14:53 PM
I was still having problems with qmake, unfortunately.  Wanted to let you know that I think "gitclone" should be "git clone" in your translated instructions.


You are right. Looks like I did a copy and past error. Fixed. ThankYou very much.

For your qmake-problems. Just for my Info. Which QT-Version do you use?

qmake --version
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on May 31, 2018, 09:52:45 PM
Quote from: Kanakori on May 31, 2018, 08:55:39 PM
Hey guys. I recently started working with James Miller's C-LOG profiles. Don't now if you guys are familiar with it but my question is what export profile should I pick in MLVapp? I got Cineon, Alexa's and the s-log. Anyone's been through this and reached a conclusion of what's best?

Below "Highlight reconstruction" box you'll have different spaces you can work with. MLVapp don't seem to support C-Log, but from what I checked, these LUT's you're using are based on SLOG3. This one is supported on MLVapp, so you just pick this one, adjust exposure/WB and export (preferably using ProRes XQ 4444 or DNxHR 444).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on May 31, 2018, 11:22:16 PM
Ok thank you! It's S-log3 though, does it matter? I've been exporting with the alexa profile.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on May 31, 2018, 11:55:43 PM
Quote from: Kanakori on May 31, 2018, 11:22:16 PM
Ok thank you! It's S-log3 though, does it matter? I've been exporting with the alexa profile.

Yes, you have to output to S-Log3, not Alexa Log-C. These LUT's you're using are constructed based on S-LOG standard, if you output Log-C and put a LUT based on S-Log3 it'll end up with wrong colors and contrast, and might generate all sorts of issues, such as bandings and chroma artifacts. Even if you're working with the correct profile, these LUT's can generate wrong colors. That's the case of ImpulZ LUT's. I really like to output Log-C on MLVapp and then apply the Vision3 emulation from ImpulZ, but it always generate magenta midtones, for some reason.
If you want color precision, as I have said in many other posts, working with ACEScct on CinemaDNG files is probably the best non-destructive workflow today (although the color matrix on some processors like Resolve don't seem to be precise, as @Andy600 pointed in other posts too)...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: domasa on June 01, 2018, 12:56:59 AM
I recorded videos in crop mode 1920 1:1 (5D mark III), exported to *.dng and deleted sources.
But result files contains vertical stripes:

(https://thumb.ibb.co/h7kvJJ/stripes.png) (https://ibb.co/h7kvJJ)


How can I fix it additionally? MLVApp can not open generated dng-files.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on June 01, 2018, 01:13:35 AM
Quote from: 50mm1200s on May 31, 2018, 11:55:43 PM
Yes, you have to output to S-Log3, not Alexa Log-C. These LUT's you're using are constructed based on S-LOG standard, if you output Log-C and put a LUT based on S-Log3 it'll end up with wrong colors and contrast, and might generate all sorts of issues, such as bandings and chroma artifacts. Even if you're working with the correct profile, these LUT's can generate wrong colors. That's the case of ImpulZ LUT's. I really like to output Log-C on MLVapp and then apply the Vision3 emulation from ImpulZ, but it always generate magenta midtones, for some reason.
If you want color precision, as I have said in many other posts, working with ACEScct on CinemaDNG files is probably the best non-destructive workflow today (although the color matrix on some processors like Resolve don't seem to be precise, as @Andy600 pointed in other posts too)...

Unfortunately I don't have data space and processing power for a CDNG workflow. I export to prores 444 and need to use proxys to edit with no breaks on premiere. I will take your advice and check S-LOG3 on the MLVAPP before exporting. I was confused because I thought James Miller's profiles were based on C-LOG and I saw everyone saying how the 5dIII was similar to the alexa so I associated the two. Thanks for taking your time. I'm still a noob in regards to codecs and color theory.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on June 01, 2018, 08:58:38 AM
@domasa
Sorry there are no plans to support DNG import in MLV App. If you on Win try mlvproducer.

@jpegmasterjesse
Is it acceptable (time wise) to work on chromebook with DUALISO??? :D
I'm glad you can run it w/o problem, thanks to @masc for taking time and adding AppImage linux version
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: jpegmasterjesse on June 01, 2018, 10:40:02 AM
@Masc - For a 5 frame, 12bit dual-iso clip it took 23 seconds from clicking "save" to convert to H.264. Not amazing but could be a lot worse. I'm running an Acer R11, Intel Celeron CPU N3160 @ 1.60GHz, 4GB Ram.

For standard conversions I'm getting about 2 frames a second.

My guess is a Pixelbook or any of the as-of-yet overpowered chromebook offerings would perform pretty damn well.

I've been playing around with Linux more in anticipation of native Linux container support in ChromeOS (codename Crostini), possible only on the Pixelbook but getting pushed out to most recent models probably within the year.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 01, 2018, 11:59:05 AM
Quote from: escho on May 31, 2018, 05:41:09 PM
What about ffmpeg? Does the app-image contain ffmpeg?
Now ffmpeg is included in the Linux AppImage (file exchanged in download area).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on June 01, 2018, 05:42:14 PM
@masc

BTW compiled MLV App performs 5-6 frames per second better than AppImage on my PC (1080p: 12fps vs 18fps).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: domasa on June 01, 2018, 07:50:06 PM
Quote from: bouncyball on June 01, 2018, 08:58:38 AM
Sorry there are no plans to support DNG import in MLV App. If you on Win try mlvproducer.

MLVProducer support only *.mlv and *.raw. Rename *.dng to *.raw does not work.
But thanks for the tip.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: domasa on June 01, 2018, 08:23:22 PM
W
Quote from: domasa on June 01, 2018, 12:56:59 AM
I recorded videos in crop mode 1920 1:1 (5D mark III), exported to *.dng and deleted sources.
But result files contains vertical stripes:

(https://thumb.ibb.co/h7kvJJ/stripes.png) (https://ibb.co/h7kvJJ)


How can I fix it additionally? MLVApp can not open generated dng-files.

However - what is best setting in MLVApp for export *.dng without stripes (5D mark III crop mode 1920 1:1)?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 01, 2018, 08:46:26 PM
@domasa
Could you zip around 50 of those dng files and send me? Will check if my tif_clean script could handle stripes.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: domasa on June 01, 2018, 09:41:10 PM
@Danne
I sent you personal message with link.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 01, 2018, 11:05:53 PM
Quote from: bouncyball on June 01, 2018, 05:42:14 PM
@masc

BTW compiled MLV App performs 5-6 frames per second better than AppImage on my PC (1080p: 12fps vs 18fps).
What Qt version do you use? For me the fastest was 5.7
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on June 02, 2018, 12:22:02 PM
QT 5.9.2
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Seruji on June 02, 2018, 06:26:20 PM
I'm a Canon 5Dmkii user, using Cinemastyle profile and RAW (MLV 2.0). Windows 10 user and I have many LUT's. ¿Should I use MLVAPP or MLV Producer? ???
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on June 02, 2018, 06:34:34 PM
I guess the answer is simple :)

Both are free so try 'em both...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 02, 2018, 07:01:18 PM
Will test the latest stuff from bouncyball tonight :). Noticed a zero byte ffmpeg image. Fooled my compiler. Should be removed from repository:
(https://s15.postimg.cc/mz06qyeyj/Screen_Shot_2018-06-02_at_19.00.19.png_300px.jpg)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 03, 2018, 10:21:58 AM
Quote from: Danne on June 02, 2018, 07:01:18 PM
Will test the latest stuff from bouncyball tonight :). Noticed a zero byte ffmpeg image. Fooled my compiler. Should be removed from repository:
(https://s15.postimg.cc/mz06qyeyj/Screen_Shot_2018-06-02_at_19.00.19.png_300px.jpg)
Yes, I included this dummy file, because AppImage Linux won't compile without. On OSX you should have the same problem in both cases: with dummy file compiling should work, but export doesn't; without dummy file compiling is impossible. For your scripts or everybody who does it manually: you should (must) unzip ffmpegOSX.zip before you compile (unfortunately I haven't found a way to do it using qmake)! ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 03, 2018, 10:44:18 AM
I see. Then I just rearrange som handling in my script. Thanks :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on June 03, 2018, 03:41:07 PM
The new Zero-Byte file "ffmpeg" in platform/qt/FFmpeg breaks unpacking with tar -C--- in Linux openSUSE. If I rename the empty file to let´s say "ffmpeg1", unpacking works like expected
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 03, 2018, 04:14:47 PM
@escho
Exactly.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 03, 2018, 04:50:13 PM
Quote from: escho on June 03, 2018, 03:41:07 PM
The new Zero-Byte file "ffmpeg" in platform/qt/FFmpeg breaks unpacking with tar -C--- in Linux openSUSE. If I rename the empty file to let´s say "ffmpeg1", unpacking works like expected
Really? Why that? The source is a different filename and the target is a in a different folder... could you explain please, why that fails?
Without the dummy file I get on OSX:
make: *** No rule to make target `/Users/masc/Documents/MLV_App/platform/qt/FFmpeg/ffmpeg', needed by `MLV App.app/Contents/MacOS/ffmpeg'.  Stop.
And on Ubuntu Linux (normal compiling) something very similar. When creating the app image the commands completely fail on compiling without dummy file.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 03, 2018, 05:04:43 PM
Extract ffmpeg zip for mac and out pops a binary named ffmpeg, same as dummy file. Conflict.
Of course, it could probably be sent straight to mlv app compiling folder instead of next to the dummy file.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on June 03, 2018, 05:06:34 PM
If I remember correct, it says something like "FFmpeg/ffmpeg not found". I have an idea, what can help, maybe. But I cannot test this here. Will try it later, when I'm back home.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on June 03, 2018, 07:13:36 PM
Unpacking "ffmpegLinux.tar.xz" manually gives a folder

ffmpeg-4.0-64bit-static


containing the these files

-rwxr-xr-x 1 edgar users 63012968 22. Apr 21:33 ffmpeg
-rwxr-xr-x 1 edgar users 64229352 22. Apr 21:54 ffmpeg-10bit
-rwxr-xr-x 1 edgar users 62914664 22. Apr 21:33 ffprobe
-rw-r--r-- 1 edgar users    35147 22. Apr 21:54 GPLv3.txt
drwxr-xr-x 2 edgar users     4096 22. Apr 21:38 manpages
-rwxr-xr-x 1 edgar users   742480 22. Apr 21:33 qt-faststart
-rw-r--r-- 1 edgar users     2857 22. Apr 21:54 readme.txt


I used a wildcard for this folder-name in the tar-command:

QMAKE_POST_LINK += tar -C $$(HOME)/bin -xvJf FFmpeg/ffmpegLinux.tar.xz --strip=1 --wildcards */ffmpeg

Unfortunately, this wildcard seems to conflict with the dummy file "platform/qt/FFmpeg/ffmpeg". Don´t ask me, why. This is the corresponding error-message:

tar: FFmpeg/ffmpeg: Nicht im Archiv gefunden.


If I call tar with the complete archiv-path, ffmpeg is found in the archiv and gets unpacked. No more error.

QMAKE_POST_LINK += tar -C $$(HOME)/bin -xvJf FFmpeg/ffmpegLinux.tar.xz --strip=1 ffmpeg-4.0-64bit-static/ffmpeg

This fixes the normal compiling for Linux openSUSE.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 03, 2018, 07:30:56 PM
Quote from: Danne on June 03, 2018, 05:04:43 PM
Extract ffmpeg zip for mac and out pops a binary named ffmpeg, same as dummy file. Conflict.
On Ubuntu it automatically overwrote the dummy file - no conflict. Is this different on OSX?

@escho: please try
QMAKE_POST_LINK += tar -C $$(HOME)/bin -xvJf ../qt/FFmpeg/ffmpegLinux.tar.xz --strip=1 --wildcards */ffmpeg $$escape_expand(\n\t)
Your command also wasn't working for me (no matter if the dummy file was existing or not), so I changed it for the app image. With the above command it was working (whyever). Does it work also for you? But I also can change the command as you told, if that helps! :) Thx!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on June 03, 2018, 07:40:57 PM
Quote from: masc on June 03, 2018, 07:30:56 PM

QMAKE_POST_LINK += tar -C $$(HOME)/bin -xvJf ../qt/FFmpeg/ffmpegLinux.tar.xz --strip=1 --wildcards */ffmpeg $$escape_expand(\n\t)


What is "$escape_expand" ?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 03, 2018, 07:48:37 PM
Ah... you can ignore that. I needed it to realize another command after this command. (I made ffmpeg executable in another command)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on June 03, 2018, 07:55:03 PM
Same error (with and without escape_expand):
tar -C /home/edgar/bin -xvJf ../qt/FFmpeg/ffmpegLinux.tar.xz --strip=1 --wildcards */ffmpeg
tar: FFmpeg/ffmpeg: Nicht im Archiv gefunden.
tar: Beende mit Fehlerstatus aufgrund vorheriger Fehler
make: *** [Makefile:408: mlvapp] Fehler 2
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 03, 2018, 08:27:04 PM
Thx for trying out @escho! Commited your command to the repos.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on June 03, 2018, 09:12:33 PM
Compiles now. Thx, masc.

Installed the brand new openSUSE 15.0 in a VM and tested mlvapp on this machine:
Works both: self compiled mlvapp and the appimage
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 03, 2018, 09:25:47 PM
Good to know, thanks again for trying out!

On OSX the problem is: the AppImage is build first (what installs ffmpeg to its place), then the QMAKE_PRE_LINK / QMAKE_POST_LINK is executed (what unzips the ffmpeg binary). Unfortunately there is no way (at least I didn't found one) to execute a command before the image is build (this could automatically unzip ffmpeg). Copying ffmpeg manually in the image via command in the end of the procedure is difficult, because I did not find a variable for the image location. :(

EDIT: jippi jeah! I got it! On OSX ffmpeg must not be unzipped manually anymore before compiling! All runs automatically when compiling now!!! :D
@Danne: your script should be easier now!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 03, 2018, 10:36:35 PM
That is great news masc. Just rearranged the compiler but will check into and refine further. Also got some dualiso files to test out. And a bunch of more stuff 8)...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on June 04, 2018, 07:32:12 PM
Just installed the App on a Win 10 machine to check out some footage.

I noticed that the Value (numbers) of the sliders are outside the window, so I cant see them. Like Dark Strenght, Saturation, tint etc.. I only see parts of the Temperature Value, because its a 4 decimal number, so I see 58... (5800).

It does not matter if the MLV App Window is Minimized or Maximized, the values stay outside the visible "window border".
V 0.16 64 bit

Edit: The native Resolution of this laptop is 1920x1080
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 04, 2018, 07:37:01 PM
@Kharak: you're the next windows victim, I guess. Bouncyball wrote how to solve that.

Quote from: bouncyball on May 31, 2018, 06:07:04 PM
If you are on Windows 10 there is no need to change font size or resolution.

Right click on MLVApp.exe, choose Properties/Compatibility

(https://thumb.ibb.co/gY1nyJ/WIn10.jpg) (https://ibb.co/gY1nyJ)

Check "Override high DPI scaling behavior" and select "System (Enhanced)" in "Scaling performed by:"

Run your app and use it happily :)

Regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 04, 2018, 07:49:52 PM
https://developer.nvidia.com/gpu-accelerated-libraries
https://developer.nvidia.com/cuda-downloads
https://docs.nvidia.com/cuda/
https://devblogs.nvidia.com/even-easier-introduction-cuda/

Maybe an useful links for GPU acceleration  :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on June 04, 2018, 08:04:36 PM
Quote from: masc on June 04, 2018, 07:37:01 PM
@Kharak: you're the next windows victim, I guess. Bouncyball wrote how to solve that.

Thanks,

Luckily I work with Win 8.1
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 04, 2018, 08:25:05 PM
Quote from: Kharak on June 04, 2018, 08:04:36 PM
Thanks,

Luckily I work with Win 8.1
Win 8.1 has the same problem when enabling system scaling (to e.g. 150%).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: fortymileswest on June 05, 2018, 03:54:21 PM
What a great little app, so useful.
Would love to see the ability to trim and crop clips in future.
Thanks for sharing
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on June 05, 2018, 04:08:53 PM
#fortymiles u can trim
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on June 05, 2018, 07:54:28 PM
Quote from: masc on June 04, 2018, 08:25:05 PM
Win 8.1 has the same problem when enabling system scaling (to e.g. 150%).

Is the scaling issue introduced in v0.16? Cause i have v0.15 on my machine and never had issues with the scaling.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 05, 2018, 10:01:40 PM
Quote from: Kharak on June 05, 2018, 07:54:28 PM
Is the scaling issue introduced in v0.16? Cause i have v0.15 on my machine and never had issues with the scaling.
I think this issue exists since the very first version, because this is more a Windows issue than a MLVApp issue.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on June 06, 2018, 08:56:18 AM
Perhaps its the Shell Exstension on win 8.1 reverting the scaling to win 95 style ;)

Texts on my machine have always been ugly. Now i know why.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Seruji on June 06, 2018, 08:26:20 PM
Question MLV APP: ¿Should I sharp (sharpen option in details section) the image before or after the image is converted into video?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 06, 2018, 09:43:23 PM
@Seruji: It is impossible to answer in general. That depends on the camera, the lens, the settings,... , your workflow,...
Try it out and see what works best for you. I mostly use it for single frame export (photo) or to rescue clips where the focus doesn't fit 100%. If your clip is very sharp you may (not will) get very ugly moiree when sharpening...
So try it out ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Seruji on June 07, 2018, 09:05:53 AM
What I'm basically doing for my 5D mk2 (Canon Firmware Version: 2.1.2 Latest Build: 2018-04-30) is:

1- Import .MLV using MLV APP
2- Use Alexa-LogC
3- Export in AppleProRes 444
4- Import video in Premiere.
5- LUT => Alexa_Default_LogC2Rec709
6- Normal Color Correction.

The results are great, but I was wondering if this is or not a recommended setup, or there is something else better than that. ???
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Teamsleepkid on June 07, 2018, 09:22:48 AM
probably be better to color the raw files and not go through the whole log to rec 709 process you'll lose all the raw info
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 13, 2018, 04:52:07 PM
Today I got some standard clips from a 7D. MLVApp is not able to reconstruct the highlights for all these 7D clips. Did anyone else had such problems with your 7D footage (or maybe also other cams)? Please report! ;)
I found a temp solution (which is not really nice but working) and I would like to test a bit around before releasing a bugfix...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 13, 2018, 06:33:59 PM
@masc

Yes highlights reconstruction doesn't work for all clips --> But in other clips it's working very well ,, not sure what is happening and what is the difference between the clips that bring this problem (white level?) .

I am on 700D.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 13, 2018, 06:53:19 PM
Quote from: theBilalFakhouri on June 13, 2018, 06:33:59 PM
Yes highlights reconstruction doesn't work for all clips --> But in other clips it's working very well ,, not sure what is happening and what is the difference between the clips that bring this problem (white level?) .

I am on 700D.
Could you please upload a short clip where it doesn't work? You only have 700D clips with this problem? I really like to figure that out!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 13, 2018, 09:20:50 PM
@masc

Of course here is the footage was shot in 12-bit lossless:
Highlights_Reconstruction.MLV (https://drive.google.com/open?id=15ZuxwU6i-hJcyOQAXwcjUr0SzNn4OQQQ)

I am only have 700D and all the clips I am talking about was shot in 700D  :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 13, 2018, 10:20:47 PM
Quote from: theBilalFakhouri on June 13, 2018, 09:20:50 PM
@masc

Of course here is the footage was shot in 12-bit lossless:
Highlights_Reconstruction.MLV (https://drive.google.com/open?id=15ZuxwU6i-hJcyOQAXwcjUr0SzNn4OQQQ)

I am only have 700D and all the clips I am talking about was shot in 700D  :D
Thank you so much! This is really extreme! In this file the upper 1/4 of the green channel needs to be reconstructed in order to get a clean sky. OMG! @Ilia: we need your help!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 13, 2018, 10:23:03 PM
Lol @masc  :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 13, 2018, 10:46:16 PM
This is how it looks in pictures:
Uncorrected:
(https://user-images.githubusercontent.com/30245296/41376582-ea42fd90-6f59-11e8-90cf-545343a3f668.png)
Corrected (with some code changes):
(https://user-images.githubusercontent.com/30245296/41376595-f2354774-6f59-11e8-9303-86316552c0ff.png)
Look how fat the green bar (sky) is in the waveform scope. In past we just tried to correct one single green value (would be a thin line in waveform scope). So I changed the code to correct a bigger range - just to test. But this works not always (e.g. green trees would become brown). So we need to think about what to do... and here we need ideas. I started a discussion thread on github for that as well. If someone has a good idea... please let us now!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: a1ex on June 13, 2018, 11:10:22 PM

Black Level                     : 2047
White Level                     : 5586
ISO                             : 100

Block: VERS
  String: 'MLV App version 0.16 alpha'


The white level value is unusual for this camera model; at 12-bit ISO 100, I'd expect 4886 in the original MLV (raw.c, get_default_white_level). This value gets rid of the pink cast in ufraw (and hopefully in all other apps that interpret the white level properly).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 14, 2018, 12:18:12 AM
@a1ex

Yes this is because I shot the footage before your commit  (https://bitbucket.org/hudson/magic-lantern/commits/89b7779c6e626d30016cdf562aa6598529357d6f) for 700D 10/12-bit lossless at ISO 100 (https://www.magiclantern.fm/forum/index.php?topic=16054.msg195395#msg195395).

Should I run white level tests (https://www.magiclantern.fm/forum/index.php?topic=16040.msg191131#msg191131) for other ISO values to avoid pink highlights for 700D ?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: a1ex on June 14, 2018, 12:34:33 AM
Quote from: theBilalFakhouri on June 14, 2018, 12:18:12 AM
Yes this is because I shot the footage before your commit  (https://bitbucket.org/hudson/magic-lantern/commits/89b7779c6e626d30016cdf562aa6598529357d6f) for 700D 10/12-bit lossless at ISO 100 (https://www.magiclantern.fm/forum/index.php?topic=16054.msg195395#msg195395).

In this case, it's not MLV App's fault; you should have mentioned that detail in the initial report. The original MLV had incorrect white level, to begin with.

QuoteShould I run white level tests (https://www.magiclantern.fm/forum/index.php?topic=16040.msg191131#msg191131) for other ISO values to avoid pink highlights for 700D ?

White level tests should be run for all models (only 100D was covered, to my knowledge). That commit was pretty much guesswork, based on your sample MLV from the linked thread; maybe I should have waited for the tests, rather than patching just that particular case. Other models may require the same workaround, possibly with different values.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 14, 2018, 01:06:29 AM
Sorry for that for all of you ,, I thought the highlights reconstruction in MLV App was to solve pink highlights in any case (like white levels problems) .

I will got into the tests as soon as I get a new battery charger instead of the current burned one (High voltage attack  :'( )
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 14, 2018, 01:09:22 PM
@theBilalFakhouri: no big deal, you gave me what I wanted - a file where highlight reconstruction does not work ;) And with some code change it could work - until now I have no good idea how to solve it generally...

@a1ex: thx for the info. So because the whitelevel is wrong, the "seach for the highest green value" has no success, have I understood that right?
But for my 7D clips I took a standard nightly build (2018Feb04)... do you have an idea why it does not work here? The metadata values are correct here? Shall I upload the file for analysis?
(https://image.ibb.co/m4y7sy/Bildschirmfoto_2018_06_14_um_12_58_15.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on June 14, 2018, 05:47:59 PM
@theBilalFakhouri highlight reconstruction is for fixing pink highlights, it just has the requirement of a correct white level.

@all sorry been inactive here, I hope to get back to doing some more processing improvements, as the app is getting a lot of love and I feel some responsibility for it. Though hard to find motivation with a broken 5D.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on June 14, 2018, 06:02:33 PM
@masc: hehe see? If white level is a root of this issue when I rescale data, and also white level, for lossless dualiso processing scaled white is also wrong, so ... bang... pink "happy" world ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 14, 2018, 06:17:43 PM
Yes... that the whitelevel is incorrect for dual iso clips, I was very sure. But why is it wrong for standard 7D clips? Bug in ML? Or is it something else?

Edit: https://www.dropbox.com/s/iy95x9zhupesa4n/M13-1329_7Dpink.MLV?dl=0
Edit2: when reading through the forum... is the white level found for 7D already?! It seems it is not found yet.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Rogan Thoerson on June 16, 2018, 07:28:38 PM
I like a lot the app. it is generally much better than the others. I still miss some features :
-The ability to save preferences like the standard file export being (dng / pro res 444 / ...)
-the ability to save and load presets for color correction
-Sometimes the "Fix Bad pixel" fails and enable RAW correction would not be perfect. on top of that if there are wrong color than the colors would also be wrong in the DNG.
-A tab to report bugs

But very good work !!! I wonder when we will be able to do it on smartphones/tablets.


(https://thumb.ibb.co/bNDNVJ/bad_pixel_off.png) (https://ibb.co/bNDNVJ)

(https://thumb.ibb.co/mRc5jd/bad_pixel_on.png) (https://ibb.co/mRc5jd)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 17, 2018, 09:46:36 AM
Quote from: Rogan Thoerson on June 16, 2018, 07:28:38 PM
I like a lot the app. it is generally much better than the others. I still miss some features :
-The ability to save preferences like the standard file export being (dng / pro res 444 / ...)
For now only the last export setting used is saved.
Quote from: Rogan Thoerson on June 16, 2018, 07:28:38 PM
-the ability to save and load presets for color correction
Is realized: edit->import/export receipt.
Quote from: Rogan Thoerson on June 16, 2018, 07:28:38 PM
-Sometimes the "Fix Bad pixel" fails and enable RAW correction would not be perfect. on top of that if there are wrong color than the colors would also be wrong in the DNG.
Is it what your pictures show? That looks very strange! Could you please upload a short MLV where that happens? (You can set cut in/out and export as MLV, so the file can easily be shortend) BTW: which OS do you use?
Quote from: Rogan Thoerson on June 16, 2018, 07:28:38 PM
-A tab to report bugs
Please use this thread or the issue tab on GitHub (is also linked in the apps about box).
Quote from: Rogan Thoerson on June 16, 2018, 07:28:38 PM
But very good work !!! I wonder when we will be able to do it on smartphones/tablets.
Thank you very much, and also thanks for the report!
In principle it should be possible to compile the app itself for android - only the file export using ffmpeg / AVFoundation can't work. But note, the user interface is 100% for desktop and not at all for smartphones. So the usebility should be more than bad ;)
I never tried it and I think some settings have to be adapted for it. If there is someone who wants to try it: have fun ;) You'll just need to install Qt for Android, open the project and look what happens 8)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: a1ex on June 17, 2018, 10:03:21 AM
Quote from: masc on June 14, 2018, 06:17:43 PM
Yes... that the whitelevel is incorrect for dual iso clips, I was very sure. But why is it wrong for standard 7D clips? Bug in ML? Or is it something else?

Edit: https://www.dropbox.com/s/iy95x9zhupesa4n/M13-1329_7Dpink.MLV?dl=0
Edit2: when reading through the forum... is the white level found for 7D already?! It seems it is not found yet.

For this particular file, clipping points are different for each channel:
- red: about 14500
- green1: about 15000
- green2: about 14300
- blue: about 14800-15000

To remove the pink cast, try 14300.

The clipping is not harsh, as on most other models.

This behavior should be checked on multiple 7Ds, at all ISOs. White level found by raw_diag cannot be trusted in this case; each file has to be analyzed manually. Maybe 14000 is good enough for all ISOs, or maybe just for ISO 100, or maybe not.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 17, 2018, 10:59:42 AM
@masc
A white level slider? Maybe even for black levels...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 18, 2018, 11:57:36 AM
@a1ex: thanks! I made a quick change in the MLVApp code to always set 14300 as whitelevel and it works for this clip. Do you have a ready to use toolor algorithm (peak with brightest color value?) for finding that?

@Danne: yes, this is what we are planning next... https://github.com/ilia3101/MLV-App/issues/90
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on June 20, 2018, 09:53:44 AM
Hi,
THANKS for a wonderful app - exactly what was needed  :D

Here are just a few things from a user perspective I wonder If you could look into:
- using Commando Z on a Mac does not work when changing settings in the menus i.e. you change something and then wants to get back to the number prior to that (and also if possible to get back to default setting by double clicking on it as in Lightroom)
- not having to double click on each clip to mark it, see the length of it and work with it - a single click must suffice
- exporting many MLV files to AVI at the same time does not work
- is it possible to show sound as two separate stereo channels?

GREAT work anyway!
yours olof  ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 20, 2018, 09:57:06 AM
How about cmd c then select all and do cmd v
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 20, 2018, 08:09:58 PM
@olofen: thanks for the feedback!
Quote from: olofen on June 20, 2018, 09:53:44 AM
- using Commando Z on a Mac does not work when changing settings in the menus i.e. you change something and then wants to get back to the number prior to that (and also if possible to get back to default setting by double clicking on it as in Lightroom)
About "Undo" on command Z I thought a lot already, because I would love to have it myself. But this is very very difficult to introduce at the actual state of the app. Now we would have to rewrite half of the GUI just for this small feature (or someone else has a better idea).

Reset to default by doubleclick on sliders is realized and comes with v0.17!

Quote from: olofen on June 20, 2018, 09:53:44 AM
- not having to double click on each clip to mark it, see the length of it and work with it - a single click must suffice
This won't be possible, because then it is no more possible to select "some" (not all) clips and export only these or apply receipts on them. I you like to switch faster between the clips, you can use J and K.

Quote from: olofen on June 20, 2018, 09:53:44 AM
- exporting many MLV files to AVI at the same time does not work
Really? Thanks for reporting! I'll have a look!

Edit: what exactly happens for you? I tried it out and it works fine...

Quote from: olofen on June 20, 2018, 09:53:44 AM
- is it possible to show sound as two separate stereo channels?
Not yet. Maybe a future feature to realize ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on June 20, 2018, 10:15:35 PM
QuoteThis won't be possible, because then it is no more possible to select "some" (not all) clips and export only these or apply receipts on them. I you like to switch faster between the clips, you can use J and K.

I got the hinge of it now - the J and the K made it and I also succeeded in exporting more than one file at a time to avi (by the way is the avi the best file to export to if you want the maximized information when importing to Photoshop?)

Edit: BUT when I export the clips to the same folder as the MLV files tha app crashes...

As for the info of the different clips like length I looked at the timewindow at the top and there was no change BUT by opening the info window I could see the difference between the clips (thanks to J and K  ;D)

All the best to your work with this incredible app. I must tell you I just stumbled across it after trying out the MLFS one and thanked my lucky star  :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 20, 2018, 10:23:52 PM
goood if it also works for you now! :)

Quote from: olofen on June 20, 2018, 10:15:35 PM
(by the way is the avi the best file to export to if you want the maximized information when importing to Photoshop?)
Photoshop is able to import avi? Hm... I think TIFF (16bit uncompressed single pictures) or DNG (if you like to use Adobe's RAW engine) could be good too.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 23, 2018, 02:49:12 PM
Hej guys,
in the last time you haven't heard so much from us, but we are working on the next version of MLVApp.

We will have two new sliders to manually correct the RAW black and white level. That works fine at the moment for none dual iso clips. For dual iso clips this is still tricky and brings effects we don't understand yet. Here we'll need some time.

Finally there will be a very first version of white balance picker! It is not very fast and works just in 100K (temperature) and 10 (tint) steps for now, but the comfort is so much better than without.

There will be LUT support for 1D and 3D cube LUTs.

But there will be a small highlight, where Danne (thanks again) and me, we are working since yesterday evening: we got a kind of moiree / aliasing filter with the help of ffmpeg. The main difference to Danne's cleaning script is, that the export has less ghosting effects on moving objects in the clip.
Especially for clips of my 5D2 + EF16-35L at f/8 or more there is so much moiree and artifacts... (I know I shouldn't film with that setting, but sometimes I do and I go crazy with the artifacts in post :P ) and most of them will be away with our new filter (flickering trees, color artifacts in water and on the boats, ...):
(https://image.ibb.co/hVnAEo/Bildschirmfoto_Unfiltered.png)
(Before)
(https://image.ibb.co/hWPOZo/Bildschirmfoto_Filtered.png)
(After)

We will have a one pass mode, a three pass mode and a three pass + unsharp mask mode. The picture above shows the three pass + unsharp mask mode.

If someone likes to try it manually (for 25fps clips):
One pass:
ffmpeg -i input.mov -c:v prores_ks -profile:v 2 -pix_fmt yuv422p10 -color_primaries bt709 -color_trc bt709 -colorspace bt709 -vf minterpolate=50,tblend=all_mode=average,framestep=2 out1pass.mov

Three pass + unsharp mask:
ffmpeg -i input.mov -vf minterpolate=50,tblend=all_mode=average,framestep=2 -f matroska - | ffmpeg -i - -vf minterpolate=50,tblend=all_mode=average,framestep=2 -f matroska - | ffmpeg -i - -c:v prores_ks -profile:v 2 -pix_fmt yuv422p10 -color_primaries bt709 -color_trc bt709 -colorspace bt709 -vf minterpolate=50,tblend=all_mode=average,framestep=2,unsharp=7:7:0.8:7:7:0 out3pass_sharpen.mov

Explanation of one pass mode: "Let's say your source is 25 fps. minterpolate, tblend and framestep are filters. The first does the oversampling. The 2nd, the blended frames, and 3rd reduces the stream back to 25 fps."
Be aware: it is very CPU hungry and will need a lot of time. As intermediate format in 3 pass mode we still use matroska here, what might not be perfect... but for now Danne and me, we are very impressed by the filter.

If you are able to compile MLVApp, you also can check out latest revision from the repos and compile yourself. Then you just have to load a MLV, select a setting in export dialog and run the export.

If someone tests it: please report your findings! Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on June 23, 2018, 03:19:50 PM
Amazing work, looking forward to it. Especially LUT support!

Is there any shortcut for fullacreen? If not, could you add it? Ctrl+F or TAB like in MLRawViewer?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 23, 2018, 03:46:20 PM
Fullscreen is realized in principle. But so far it will never be in release version. The problem is: Qt is really buggy in terms of fullscreen. You can set fullscreen and then the problems start (no keyboard entry, no possibility to get fullscreen 100% closed,...). If you like to try, search for a fullscreen comment in initGui() in MainWindow.cpp and comment in one single line, compile and then you can test fullscreen.

So better is to maximize the Window and press A S E , then it is "near to fullscreen" without problems.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on June 23, 2018, 05:12:48 PM
Quote from: masc on June 23, 2018, 02:49:12 PM

sometimes I do and I go crazy with the artifacts in post :P ) and most of them will be away with our new filter (flickering trees, color artifacts in water and on the boats, ...):


wonderful work masc and team. i really need to get rid of color artifacts of tress
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Teamsleepkid on June 24, 2018, 01:30:59 AM
the aliasing moire filter..how long does it take to do a 30 second clip? or 10 seconds? would like to know. thank you:)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: feureau on June 24, 2018, 05:00:36 AM
I keep getting this error randomly when trying to export as CinemaDNG Lossless. Not sure what's triggering it. The same MLV files export perfectly with CinemaDNG uncompressed and ProRes.

Recorded on EOSM using latest crop 4k build from the experimental branch


(https://thumb.ibb.co/mBzTZo/Capture.png) (https://ibb.co/mBzTZo)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 24, 2018, 10:13:43 AM
Quote from: Teamsleepkid on June 24, 2018, 01:30:59 AM
the aliasing moire filter..how long does it take to do a 30 second clip? or 10 seconds? would like to know. thank you:)
I think as always that depends on your CPU and resolution and... For me 1 sec of 5D2 1856x1044 needs some minutes on a MBP 2010 (Core2Duo), but this is not the Hardware to do Benchmarks ;)
Edit: 10sec -> 24min on this system with 3pass.
Edit2: 10sec -> 11min with 3pass on iMac 2011 i5 Quadcore

@feureau: what do you mean with randomly? It may happen for every clip, or does it happen only for some clips, ...? If it happens for a special clip, please upload, so we could ask the debugger for the exact reason.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 24, 2018, 10:26:03 AM
Tried finding some other wrapper than matroska for piping but nothing works better when piping filters. So far it looks real nice. Gonna test some more soon.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 24, 2018, 10:27:52 AM
Quote from: Danne on June 24, 2018, 10:26:03 AM
Tried finding some other wrapper than matroska for piping but nothing works better when piping filters. So far it looks real nice. Gonna test some more soon.
Thx Danne. Same for my testing... I tried - hm, don't know how many wrapper formats - nothing was better than matroska.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 24, 2018, 11:31:02 AM
Rawvideo will not work with filters. Tried keeping the prores codec with matroska but that seemed like it only did some passthrough to the last pass. Prores don't do piping so I guess outputting the actual file three times is an option. Tested this and still looked better with matroska so until something better comes along let's stick to what we have now :).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 24, 2018, 12:46:33 PM
Temperature picker! Works great :)
(https://s8.postimg.cc/dodifshit/Screen_Shot_2018-06-24_at_12.45.05.png)

Question. Could the picker stay in picking mode until picking the button again? Now one do one pick, has to go back to the picker button, push it test another white balance area, go back to the button etc. If it stays on we can pick until satisfied.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 24, 2018, 01:00:43 PM
Yes, that should be possible. Right now you can also press B, that may be faster than searching the button again. From the function side this is only one single line and it does what you want. But Qt has some predefined function in the graphicsview to show these hand cursors... and after each click the pipette is away... :P Where do they do that?! I have to find the place... :D

Edit: found it and commited. Done.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 24, 2018, 05:03:50 PM
aaah, yes, working. Setting white balance this fast is key for fast and more correct further processing. Very nice indeed. Thanks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 70MM13 on June 24, 2018, 07:06:38 PM
It's great to see this application's capabilities growing.
It is taking up more space in my workflow all the time!

Keep up the great work!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on June 25, 2018, 02:08:51 PM
Quote from: Danne on June 24, 2018, 12:46:33 PM
Temperature picker! Works great :)
(https://s8.postimg.cc/dodifshit/Screen_Shot_2018-06-24_at_12.45.05.png)

Question. Could the picker stay in picking mode until picking the button again? Now one do one pick, has to go back to the picker button, push it test another white balance area, go back to the button etc. If it stays on we can pick until satisfied.

Nice! This will be really useful for me. Thanks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: a1ex on June 25, 2018, 02:18:11 PM
Shameless plug: you might also find this idea (https://www.magiclantern.fm/forum/index.php?topic=9469) useful (WB picker on skin). Back then I've used a hardcoded ratio between R, G and B, from a reference photo with skin tones that looked good to me. Purists will scream, as it's too much of a hack, but I've found it handy.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 25, 2018, 03:56:49 PM
Quote from: a1ex on June 25, 2018, 02:18:11 PM
Shameless plug: you might also find this idea (https://www.magiclantern.fm/forum/index.php?topic=9469) useful (WB picker on skin). Back then I've used a hardcoded ratio between R, G and B, from a reference photo with skin tones that looked good to me. Purists will scream, as it's too much of a hack, but I've found it handy.
WTF?!?!?! :D I added your values in a quick test and it seems to work out of the box. Crazy... cool! I'll think about how adding this to the app! Thx! Hahaha... ;D

Edit: hope you like it? With the new button you can toggle between grey and skin.
(https://user-images.githubusercontent.com/30245296/41856247-e4293980-7894-11e8-9e48-6a3a27041a32.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 25, 2018, 05:35:07 PM
Nothing wrong with the creative force going on here. Not the best images but I could pick the guy for white balance. Very good addition:

Skin
(https://s15.postimg.cc/4l99yyql7/Screen_Shot_2018-06-25_at_17.33.32.png_scaled.jpg)

Grey
(https://s15.postimg.cc/q7oafz9q3/Screen_Shot_2018-06-25_at_17.33.47.png_scaled.jpg)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on June 25, 2018, 09:34:10 PM
Hey Guys I'm having a really annoying issue with MLVAapp. Some dual iso clips don't export without the horizontal stripes. Some do, some don't. I select the Dual Iso amaze option as usual and it doesn't seem to change anything.
Has anyone had this issue before and is there a work-around?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 25, 2018, 10:08:01 PM
@Kanakori: please upload one of the clips where it does not work, so we could analyze what happens. Thx. Does the viewer show it correctly? What OS are you using?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on June 25, 2018, 10:32:25 PM
Quote from: masc on June 25, 2018, 10:08:01 PM
@Kanakori: please upload one of the clips where it does not work, so we could analyze what happens. Thx. Does the viewer show it correctly? What OS are you using?

I'm using windows 10. The viewer doesn't show it correctly on these clips. With or without the dual iso option selected. I don't know what I made different, there are clips from the same shoot that work fine.
You can check one of them here. It was the shortest I could upload (my internet is slow as shit):

https://we.tl/SDQ4FvkguR

@masc
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on June 26, 2018, 01:31:43 AM
In case you guys want to test in a real gray card, here's two samples. These are precisely 17.8% reflectance material (according to the company):
https://we.tl/t45SiodapN
https://we.tl/7WNCIdIJnp

I think the idea of getting WB from skin tones is good if you don't have a gray card, but the 'correct' will always be to get a neutral balance so the colorist can work through it...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on June 26, 2018, 09:18:15 AM
Quote from: Kanakori on June 25, 2018, 09:34:10 PM
Some dual iso clips don't export without the horizontal stripes. Some do, some don't. I select the Dual Iso amaze option as usual and it doesn't seem to change anything.
It's because of the clip is not detected as dualiso by the current detecting code. It depends on the image itself. There is no better solution right now to detect this. However in the latest pull requests of g3gg0 he added full DISO block support for mlv_lite, when merged to main repo this will be accounted in MLV App.


(https://thumb.ibb.co/iFBUUo/M24_2317_frame_1.png) (https://ibb.co/iFBUUo)


(https://thumb.ibb.co/jMOJpo/M24_2317_frame_241.png) (https://ibb.co/jMOJpo)

Here are frames from your clip correctly processed.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on June 26, 2018, 09:26:48 AM
Quote from: 50mm1200s on June 26, 2018, 01:31:43 AM
In case you guys want to test in a real gray card, here's two samples. These are precisely 17.8% reflectance material (according to the company):
This second clip (first can not be downloaded) has very unusual WB out of the box (maybe some complicated mixed lighting?). I even straggled to white balance it manually.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on June 26, 2018, 11:27:35 AM
I am missing one file format...
Instead of the cumbersome but invaluable Tiff sequence with its 16 bits of colour I would like something like the Avi uncompressed (unfortunately still smaller than the original mlv file though...) but with 16 bits of colour and at least the same size as the mlv.
Is this possible to achieve?
Yours faithfully
olof thiel
sweden
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 26, 2018, 12:03:46 PM
Quote from: olofen on June 26, 2018, 11:27:35 AM
I am missing one file format...
Instead of the cumbersome but invaluable Tiff sequence with its 16 bits of colour I would like something like the Avi uncompressed (unfortunately still smaller than the original mlv file though...) but with 16 bits of colour and at least the same size as the mlv.
Is this possible to achieve?
Uncompressed avi is not 16bit atm, right. I changed the format to 16bit for a quick test: VLC tells in metadata viewer it is 16bit, but it is impossible to decode. All other player also can't play it back...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on June 26, 2018, 12:18:15 PM
QuoteUncompressed avi is not 16bit atm, right. I changed the format to 16bit for a quick test: VLC tells in metadata viewer it is 16bit, but it is impossible to decode. All other player also can't play it back...

For me working as an artist with color and changing A LOT of the content it is almost mandatory to work in 16 bit. Do you have any suggestion how to achieve this with the MLV app? Or ideas?
I work mainly in photoshop.
/olof  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 26, 2018, 12:35:33 PM
Quote from: olofen on June 26, 2018, 12:18:15 PM
For me working as an artist with color and changing A LOT of the content it is almost mandatory to work in 16 bit. Do you have any suggestion how to achieve this with the MLV app? Or ideas?
I work mainly in photoshop.
/olof  :)
If you work in Photoshop, chose cDNG, this is unprocessed (or at least lossless) and has full raw info availlable.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Ottoga on June 26, 2018, 01:08:51 PM
@Bouncyball @kanakori

QuoteIt's because of the clip is not detected as dualiso

I have a 7D mk1 and can't do dual_ISO video but I have experienced the same effect with stills when I had Dual_ISO and ETTR enabled and,

"Link to Dual_ISO" was enabled in ETTR

Occasional ETTR would override my alternate ISO and make both ISOs the same. None of the processing programs available would see the images as Dual_ISO and I would be able to see the horizontal lines in the image.

Hope this sheds some light onto what may be happening.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on June 26, 2018, 01:11:18 PM
QuoteIf you work in Photoshop, chose cDNG, this is unprocessed (or at least lossless) and has full raw info availlable.
I tried in vain with both Cinema DNG uncompressed and lossless but got the following answer (see attachment)

(https://thumb.ibb.co/c3D2h8/Ska_rmavbild_2018_06_26_kl_13_08_19.png) (https://ibb.co/c3D2h8)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 26, 2018, 01:25:02 PM
Quote from: olofen on June 26, 2018, 01:11:18 PM
I tried in vain with both Cinema DNG uncompressed and lossless but got the following answer (see attachment)

(https://thumb.ibb.co/c3D2h8/Ska_rmavbild_2018_06_26_kl_13_08_19.png) (https://ibb.co/c3D2h8)

Please upload a file which produces this error! We'll search for what is going on there...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on June 26, 2018, 04:23:47 PM
QuotePlease upload a file which produces this error! We'll search for what is going on there...
It is an 667 MB MLV file - do I send it with WeTransfer and in that case to what adress?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 26, 2018, 04:38:07 PM
Quote from: olofen on June 26, 2018, 04:23:47 PM
It is an 667 MB MLV file - do I send it with WeTransfer and in that case to what adress?
Yes, for example. You can post the link here, or you send it to me via PM.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on June 26, 2018, 04:38:29 PM
Quote from: bouncyball on June 26, 2018, 09:18:15 AM
It's because of the clip is not detected as dualiso by the current detecting code. It depends on the image itself. There is no better solution right now to detect this. However in the latest pull requests of g3gg0 he added full DISO block support for mlv_lite, when merged to main repo this will be accounted in MLV App.


(https://thumb.ibb.co/iFBUUo/M24_2317_frame_1.png) (https://ibb.co/iFBUUo)


(https://thumb.ibb.co/jMOJpo/M24_2317_frame_241.png) (https://ibb.co/jMOJpo)

Here are frames from your clip correctly processed.

regards
bb

Thanks for the reply but I didn't understand what I can do about it... Does someone have a suggestion? I need to export it in s-log3
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on June 26, 2018, 05:19:22 PM
I have a handful of clips with this problem. I'm fucked right now.
What alternatives do I have?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on June 26, 2018, 05:57:37 PM
Quote from: masc on June 26, 2018, 04:38:07 PM
Yes, for example. You can post the link here, or you send it to me via PM.

here it is https://we.tl/XjHydVtxIb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on June 26, 2018, 07:30:30 PM
@Kanakori: see PM.

@Ottoga: interesting issue, however the MLV from Kanakori is ok and real dualiso. It is just the current dualiso detector in mlv app can not handle it properly. If you force it to be dual iso, the processing is fine as I showed in previous message.

br,
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on June 26, 2018, 07:38:00 PM
Quote from: olofen on June 26, 2018, 01:11:18 PM
I tried in vain with both Cinema DNG uncompressed and lossless but got the following answer (see attachment)
Really strange...

I downloaded your MacBeth MLV and exported as DNGs w/o a problem, be it lossless or uncompressed. Both are exported fine!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on June 26, 2018, 07:58:42 PM
Quote from: bouncyball on June 26, 2018, 07:30:30 PM
@Kanakori: see PM.

@Ottoga: interesting issue, however the MLV from Kanakori is ok and real dualiso. It is just the current dualiso detector in mlv app can not handle it properly. If you force it to be dual iso, the processing is fine as I showed in previous message.

br,
bb

It worked! I owe you one! Big time. Very appreciated.
Also, the clips affected were all from the last hour of shooting. Imo it could be related to a setting I used or camera over-heating?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on June 26, 2018, 08:14:45 PM
Quote from: bouncyball on June 26, 2018, 07:38:00 PM
Really strange...

I downloaded your MacBeth MLV and exported as DNGs w/o a problem, be it lossless or uncompressed. Both are exported fine!

When exported to another harddrive it worked....
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 26, 2018, 08:15:20 PM
Quote from: bouncyball on June 26, 2018, 07:38:00 PM
Really strange...
I downloaded your MacBeth MLV and exported as DNGs w/o a problem, be it lossless or uncompressed. Both are exported fine!
@olofen: same for me. MLV exports fine without any problem - I tried uncompressed and lossless, both with both possible naming schemes. Did you move the file to another folder while it was opened in MLVApp? Or did you try to save it to a location where you don't have writing rights?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on June 26, 2018, 10:38:57 PM
@bouncyball
It seemed to work fine but I can't find the exported files anywhere.
The export is resumed, I go to the chosen directory and nothing's there...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on June 27, 2018, 03:06:13 AM
Quote from: bouncyball on June 26, 2018, 09:26:48 AM
This second clip (first can not be downloaded) has very unusual WB out of the box (maybe some complicated mixed lighting?). I even straggled to white balance it manually.

Yes, mixed sodium (yellow) light with 5500K softbox. I first use AutoWB from ML on the gray card, and then do the precise WB in post. Tint is always a problem for me. Here's the other file:
https://we.tl/x59qxrDqHl

And here's a frame without the gray card (same ambient light):
https://we.tl/vpnSuESe93
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on June 27, 2018, 08:05:30 AM
@Danne do you think this idea (https://www.magiclantern.fm/forum/index.php?topic=19315.0) could be implemented using ffmpeg (without ghosts)? You seem to be more and more into ffmpeg than most people here. Maybe @dford could implement it on MLV module?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 27, 2018, 08:25:37 AM
@50mm1200s
Had to look up the work intercalate(insert).
I have a hard time understanding the deeper insights about that concept(if there are any) but if shooting HDR I can´t seem to find any better solution then running consecutive framing technique which I implemented in the script section in MLV App. The script pretty much reflects this in my workflow Switch:
https://bitbucket.org/Dannephoto/switch/src/default/Switch.app/Contents/bash/HDR_MOV.command
Hugin align/enfuse cropping borders outputting with ffmpeg retaining original fps.
About ghosting in general. In my mind some heavy programming or maybe even some tweaking with hugin stuff might yield better results on moving subjects but thing like calculation movement inside footage is beyond my knowledge.
Putting this in mlv_lite module? I think a1ex or g3gg0 are the ones to answer this.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on June 27, 2018, 08:37:27 AM
Quote from: Danne on June 27, 2018, 08:25:37 AM
I have a hard time understanding the deeper insights about that concept(if there are any)

The idea seems to be the same as with the old HDR feature in ML, but instead of using ISO change for switching between exposures, use shutter speed.

Quote
About ghosting in general. In my mind some heavy programming or maybe even some tweaking with hugin stuff might yield better results on moving subjects but thing like calculation movement inside footage is beyond my knowledge.

I think movement calculation wouldn't be necessary, maybe a averaging technique...

Quote
Putting this in mlv_lite module? I think a1ex or g3gg0 are the ones to answer this.

Yeah, but both are already working on other projects and no one is willing to make this idea work. Wish I could program it myself, but I have no real knowledge of programming. The idea is good, though.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 27, 2018, 08:55:39 AM
Quote from: 50mm1200s on June 27, 2018, 08:37:27 AM
The idea seems to be the same as with the old HDR feature in ML, but instead of using ISO change for switching between exposures, use shutter speed.

That idea is already working. A1ex put in a feature (HDR_extended) which normally is disabled. Been there for a while but forgotten. I had it reenabled in this branch:
https://bitbucket.org/Dannephoto/magic-lantern/branch/crop_rec_4k_mlv_lite_snd_sd_uhs_HDR

What camera are you using? If you want to test this concept I could give you a build and help you with steps in menu.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on June 27, 2018, 09:42:06 AM
Quote from: Danne on June 27, 2018, 08:55:39 AM
That idea is already working. A1ex put in a feature (HDR_extended) which normally is disabled. Been there for a while but forgotten. I had it reenabled in this branch:
https://bitbucket.org/Dannephoto/magic-lantern/branch/crop_rec_4k_mlv_lite_snd_sd_uhs_HDR

What camera are you using? If you want to test this concept I could give you a build and help you with steps in menu.

Oh, really? Wow. I'm using a 50D, but I also have a 600D too. If you can build it to me, that would be awesome!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 27, 2018, 10:29:09 AM
Check these builds 50mm1200s:
50D
built from unified branch, no idea if it´s the latest branch working with 50D, if not, point me in another direction:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/magiclantern-Nightly.2018Jun27.50D109HDR_ext.zip

600D
Seems to work from my current branch: https://bitbucket.org/Dannephoto/magic-lantern/branch/crop_rec_4k_mlv_lite_snd_sd_uhs_HDR
https://bitbucket.org/Dannephoto/magic-lantern/downloads/magiclantern-Nightly.2018Jun27.600D102HDR_ext.zip

Fiddle with the HDR menu. It´s manual labour setting frame settings individually. Cool thing is you can control multiple frames to do changes to iso, shutter...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on June 27, 2018, 10:49:46 AM
Nice! I will test and post some samples this weekend.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 27, 2018, 01:16:05 PM
Quote from: Kanakori on June 26, 2018, 10:38:57 PM
@bouncyball
It seemed to work fine but I can't find the exported files anywhere.
The export is resumed, I go to the chosen directory and nothing's there...
@Kanakori: To what format and options do you export?
@bouncyball: how did you force dualIso in the code?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on June 27, 2018, 03:39:25 PM
Quote from: masc on June 27, 2018, 01:16:05 PM
@Kanakori: To what format and options do you export?
@bouncyball: how did you force dualIso in the code?
I guess he did not put mlvapp and ffmpeg binaries into same folder.
It's just a quick and temporary hackish patch to force is_dual_iso (always) = 1.

Edit: I can export that clip to whatever I want (btw it is ~60fps dual iso MLV).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 27, 2018, 03:52:20 PM
@masc
Been experimenting with boxblur and blending by dividing into streams. How would this command act running through Mlv App when it comes to smoothing aliasing?
ffmpeg -i M05-0608.mov -i M05-0608.mov -filter_complex "[1] boxblur=1 [tmp]; [0][tmp] blend=all_mode='overlay':all_opacity=0.5" -f matroska - | \
ffmpeg -i - -vf minterpolate=50,tblend=all_mode=average,framestep=2 -f matroska - | \
ffmpeg -i - -vf minterpolate=50,tblend=all_mode=average,framestep=2 -f matroska - | \
ffmpeg -i - -c:a copy -c:v prores_ks -profile:v 2 -pix_fmt yuv422p10 -color_primaries bt709 -color_trc bt709 -colorspace bt709 -vf minterpolate=50,tblend=all_mode=average,framestep=2,unsharp=7:7:0.8:7:7:0 out.mov
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 27, 2018, 04:21:10 PM
@Danne: ups... double input in the first call? Is that possible via pipe too?
For us the input from MLV App looks like this (EOS 5D Mark II with near-to-FHD):
ffmpeg -r 25 -y -f rawvideo -s 1856x1044 -pix_fmt rgb48 -i -
Is it possible to add this twice? I would expect, ffmpeg waits for 2 input pipes then... (but there is only one).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 27, 2018, 04:31:35 PM
Yes double input. One stream adds boxblur other stream blend iinto this stream then pipes further. Seems to give slightly less aliasing but wanted to see how the output would look like when running in Mlv App.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 27, 2018, 04:39:47 PM
I think we need another way to come to the 2nd stream. If I add the pipe twice very strange things happen (looks like modern art) :D ... is there a way to copy a stream before doing something with it?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 27, 2018, 04:44:47 PM
He, not sure. Seems to work from terminal. How would you do the command in Mlv App if it were two different files?
Maybe it works for a single stream, didn't try:
ffmpeg -i M05-0608.mov -filter_complex boxblur=1,blend=all_mode='overlay':all_opacity=0.5" -f matroska - | \
ffmpeg -i - -vf minterpolate=50,tblend=all_mode=average,framestep=2 -f matroska - | \
ffmpeg -i - -vf minterpolate=50,tblend=all_mode=average,framestep=2 -f matroska - | \
ffmpeg -i - -c:a copy -c:v prores_ks -profile:v 2 -pix_fmt yuv422p10 -color_primaries bt709 -color_trc bt709 -colorspace bt709 -vf minterpolate=50,tblend=all_mode=average,framestep=2,unsharp=7:7:0.8:7:7:0 out.mov
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 27, 2018, 04:52:31 PM
So far as I understood, a double stream is impossible with our solution - we would need a platform specific special solution... :P (not good)
The command in your last post crashes (ffmpeg brings error and MLV App does not like it).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 27, 2018, 05:02:04 PM
Too bad it doesn´t like modern art  :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on June 27, 2018, 06:05:14 PM
Quote from: bouncyball on June 27, 2018, 03:39:25 PM
I guess he did not put mlvapp and ffmpeg binaries into same folder.
It's just a quick and temporary hackish patch to force is_dual_iso (always) = 1.

Edit: I can export that clip to whatever I want (btw it is ~60fps dual iso MLV).

It seems to work now! You guys are the best. Thanks for the help. If anything else comes up I'll let you know.

@masc I export to prores 444
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 27, 2018, 08:32:58 PM
@Danne: is it bad to do it this way:
ffmpeg -i M05-0608.mov -filter_complex "[0:v] boxblur=1 [tmp]; [0:v][tmp] blend=all_mode='overlay':all_opacity=0.5" -f matroska - | \
ffmpeg -i - -vf minterpolate=50,tblend=all_mode=average,framestep=2 -f matroska - | \
ffmpeg -i - -vf minterpolate=50,tblend=all_mode=average,framestep=2 -f matroska - | \
ffmpeg -i - -c:a copy -c:v prores_ks -profile:v 2 -pix_fmt yuv422p10 -color_primaries bt709 -color_trc bt709 -colorspace bt709 -vf minterpolate=50,tblend=all_mode=average,framestep=2,unsharp=7:7:0.8:7:7:0 out.mov

For me that works. Looks slightly more blurred than without the blur box (so for me as expected), but a lot brighter... is it because I use the wrong stream, or is it the same in your tests?
Edit: tested again your command with ...[1]... and it looks the same for me as the above command. So the blending seems to be not right.
Edit2: color looks right, when changing overlay mode to this, but it looks very blurred, and there is a boarder:
ffmpeg -i M05-0608.mov -filter_complex "[0:v] boxblur=1 [tmp]; [0:v][tmp] overlay=50:50" -f matroska - | \
ffmpeg -i - -vf minterpolate=50,tblend=all_mode=average,framestep=2 -f matroska - | \
ffmpeg -i - -vf minterpolate=50,tblend=all_mode=average,framestep=2 -f matroska - | \
ffmpeg -i - -c:a copy -c:v prores_ks -profile:v 2 -pix_fmt yuv422p10 -color_primaries bt709 -color_trc bt709 -colorspace bt709 -vf minterpolate=50,tblend=all_mode=average,framestep=2,unsharp=7:7:0.8:7:7:0 out.mov


@Kanakori: good to know it works! Have fun! ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 27, 2018, 08:59:32 PM
Will test later. Yes, also getting brighter results. Maybe not optimal but ideas could lead to more ideas :).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 27, 2018, 09:03:14 PM
@Danne: Look this: slightly more blurred and correct color:
ffmpeg -i M05-0608.mov -filter_complex "[0:v] boxblur=1 [tmp]; [0:v][tmp] blend=all_mode='normal':all_opacity=0.5" -f matroska - | \
ffmpeg -i - -vf minterpolate=50,tblend=all_mode=average,framestep=2 -f matroska - | \
ffmpeg -i - -vf minterpolate=50,tblend=all_mode=average,framestep=2 -f matroska - | \
ffmpeg -i - -c:a copy -c:v prores_ks -profile:v 2 -pix_fmt yuv422p10 -color_primaries bt709 -color_trc bt709 -colorspace bt709 -vf minterpolate=50,tblend=all_mode=average,framestep=2,unsharp=7:7:0.8:7:7:0 out.mov

The higher the opactiy value, the sharper the result.

Edit: it is commited to the MLVApp repos, so you can try it out. To play with the values, look at line 1472 in MainWindow.cpp. I think we have to raise opacity in order to get a sharper image.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 28, 2018, 01:25:21 AM
I run it like following:
        QString pass3 = QString( "-filter_complex \"[0:v] boxblur=1:cr=4:ar=4 [tmp]; [0:v][tmp] blend=all_mode='normal':all_opacity=0.6\"
Cleans out chroma and alpha channel and adds a slight blur. It slightly less sharper than 3 pass + unsharp mask. Might be useful for hard cases.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 28, 2018, 02:32:58 AM
Found this good old wheel again.

Original
https://bitbucket.org/Dannephoto/magic-lantern/downloads/Screen%20Shot%202018-06-28%20at%2002.25.18.png_scaled.jpg
(https://s15.postimg.cc/dktnv8fkb/Screen_Shot_2018-06-28_at_02.25.18.png_scaled.jpg)

ffmpeg cleaning
https://bitbucket.org/Dannephoto/magic-lantern/downloads/Screen%20Shot%202018-06-28%20at%2002.31.28.png_scaled.jpg
(https://s15.postimg.cc/okev6ty9n/Screen_Shot_2018-06-28_at_02.31.28.png_scaled.jpg)

(https://s15.postimg.cc/w1o2lt35n/Screen_Shot_2018-06-28_at_02.36.31.png_scaled.jpg)

(https://s15.postimg.cc/sutj26azv/Screen_Shot_2018-06-28_at_02.37.00.png_scaled.jpg)


Following command:
        QString pass3 = QString( "-filter_complex \"[0:v] boxblur=2:cr=5:ar=5 [tmp]; [0:v][tmp] blend=all_mode='normal':all_opacity=0.6\" -f matroska - | %1 -i - -vf minterpolate=%2,tblend=all_mode=average,framestep=2 -f matroska - | %1 -i - -vf minterpolate=%2,tblend=all_mode=average,framestep=2 -f matroska -  | %1 -i - -vf minterpolate=%2,tblend=all_mode=average,framestep=2 -f matroska - | %1 -y -i - " ).arg( ffmpegCommand ).arg( locale.toString( getFramerate() * 2.0 ) );
        program.insert( program.indexOf( "-c:v" ), pass3 );

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on June 28, 2018, 05:38:33 AM
Ok the dual iso problem seems solved but a new one came about...

(https://i.imgur.com/kWuycqh.jpg)

How can I take that off?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on June 28, 2018, 08:17:34 AM
QuoteIf you work in Photoshop, chose cDNG, this is unprocessed (or at least lossless) and has full raw info availlable.

What is the difference between uncompressed and lossless cDNG and what would you recommend me to continue with into Photoshop where I will work with video as with my former art images?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on June 28, 2018, 08:36:35 AM
Quote from: Kanakori on June 28, 2018, 05:38:33 AM
Ok the dual iso problem seems solved but a new one came about...
How can I take that off?

Try the "Highlight Reconstruction" feature. If it doesn't work, maybe someone here could point a solution, but I would say you'll need to blow the highlights until the artifacts are gone (using curves).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 28, 2018, 09:03:52 AM
@Danne: really nice! Do you want me to add "boxblur=1:cr=4:ar=4" or better "boxblur=2:cr=5:ar=5"?

@Kanakori & 50mm1200s: Yes, this are very crushed highlights. Normally they get pink only (because the green channel clips only mostly)... here it seems all channels are clipped, so they have any color. Maybe also dualIso makes it more strange. Blown highlights are no problem in non-dual-iso, but are a huge problem in dual-iso-clips. Highlight reconstruction will work only slightly (if it works at all in this special case). So the only way is to raise light strengh. But I am not sure if that works, because the artifacts are very dark.

@olofen: from the quality side lossless and uncompressed cdng is the same, lossless is compressed without quality-loss (as the name tells). So uncompressed could be a little faster (don't needs to be uncompressed when used), lossless is smaller on your harddisk.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 28, 2018, 09:14:33 AM
Hi masc. I´d say add boxblur=2:cr=5:ar=5 since the 3xminterpolate + unsharp already does the heavy stuff. Last setting should be considered last resort so why not go "all in" here :). Let me check if  little extra unsharpen helps a bit stay tuned...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on June 28, 2018, 09:27:04 AM
Quote from: Kanakori on June 28, 2018, 05:38:33 AM
Ok the dual iso problem seems solved but a new one came about...
Try highlight reconstruction.

Actually I would never use dual iso for quality video, it sure adds dynamic range but also introduces lots of aliasing. It is very useful for stills but not very good for video.

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on June 28, 2018, 09:29:22 AM
Quote from: Danne on June 28, 2018, 02:32:58 AM
Found this good old wheel again.
This method does the trick for sure but unfortunately also wipes quite an amount of useful details.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 28, 2018, 09:30:47 AM
Yup, that´s the price to pay...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 28, 2018, 09:47:23 AM
@masc
Could the settings be following for this last resort thingy:

            moireeFilter.append( QString( "unsharp=5:5:0.6:5:5:0," ) );

        QString pass3 = QString( "-filter_complex \"[0:v] boxblur=2:cr=5:ar=5 [tmp]; [0:v][tmp] blend=all_mode='normal':all_opacity=0.6\" -f matroska - | %1 -i - -vf minterpolate=%2,tblend=all_mode=average,framestep=2 -f matroska - | %1 -i - -vf minterpolate=%2,tblend=all_mode=average,framestep=2 -f matroska - | %1 -i - -vf minterpolate=%2,tblend=all_mode=average,framestep=2 -f matroska - | %1 -i - -vf minterpolate=%2,tblend=all_mode=average,framestep=2 -f matroska - | %1 -y -i - " ).arg( ffmpegCommand ).arg( locale.toString( getFramerate() * 2.0 ) );
        program.insert( program.indexOf( "-c:v" ), pass3 );


By the way. I really dig your lut implementation....
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 28, 2018, 10:06:55 AM
Another addition. Since matroska is set to x264 codec we can preserve detailt a lot by pipe to 0 compression:
-c:v libx264 -preset ultrafast -crf 0
Above line gives far better results. Tested like below on last resort setting. The ultrafast 0 setting should be added to all aliasing processing settings though...

Note my change to opacity setting here as well(last resort setting only)

test scenario:
        QString pass3 = QString( "-filter_complex \"[0:v] boxblur=2:cr=5:ar=5 [tmp]; [0:v][tmp] blend=all_mode='normal':all_opacity=0.5\" -c:v libx264 -preset ultrafast -crf 0 -f matroska - | %1 -i - -c:v libx264 -preset ultrafast -crf 0 -vf minterpolate=%2,tblend=all_mode=average,framestep=2 -f matroska - | %1 -i - -c:v libx264 -preset ultrafast -crf 0 -vf minterpolate=%2,tblend=all_mode=average,framestep=2 -f matroska - | %1 -i - -c:v libx264 -preset ultrafast -crf 0 -vf minterpolate=%2,tblend=all_mode=average,framestep=2 -f matroska - | %1 -i - -c:v libx264 -preset ultrafast -crf 0 -vf minterpolate=%2,tblend=all_mode=average,framestep=2 -f matroska - | %1 -y -i - " ).arg( ffmpegCommand ).arg( locale.toString( getFramerate() * 2.0 ) );
        program.insert( program.indexOf( "-c:v" ), pass3 );



EDIT: this setting should be optimal for speed and detail preservation:
-c:v libx264 -preset ultrafast -crf 10
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 28, 2018, 12:05:17 PM
@Danne: I added your changings to the repos. Where is the difference between -crf 0 and 10? Both looks way sharper than before! ;) The blurbox indeed is very blurry...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 28, 2018, 12:30:56 PM
Thanks. Well, last word on the blurbox hasn't been said yet.
Crf setting 0 is lossless then comes compression. Around 17-20 shows degradation around visually none imo. Crf 10 is also faster for some reason...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 28, 2018, 12:55:58 PM
@masc
Retested and refined/pushed the "last resort" setting to this instead:
        QString pass3 = QString( "-filter_complex \"[0:v] boxblur=1:cr=5:ar=5 [tmp]; [0:v][tmp] blend=all_mode='normal':all_opacity=0.7\" -c:v
Thanks again for fixing all quirks around ffmpeg in your code.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 28, 2018, 01:13:35 PM
Quote from: Danne on June 28, 2018, 12:55:58 PM
@masc
Retested and refined/pushed the "last resort" setting to this instead:
        QString pass3 = QString( "-filter_complex \"[0:v] boxblur=1:cr=5:ar=5 [tmp]; [0:v][tmp] blend=all_mode='normal':all_opacity=0.7\" -c:v
Thanks again for fixing all quirks around ffmpeg in your code.
Looks good! Thanks for your work and your tests!  ;D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on June 28, 2018, 01:18:37 PM
I´m sure more tests are to come  8)

Original
(https://s33.postimg.cc/v7dlms1yn/Screen_Shot_2018-06-28_at_13.09.56.png)

3x minterpolate + unsharp
(https://s33.postimg.cc/v7dlmshe7/Screen_Shot_2018-06-28_at_13.08.50.png)

Boxblur, blend + x5 minterpolate + unsharp
(https://s33.postimg.cc/du3b7xtsv/Screen_Shot_2018-06-28_at_13.08.30.png)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on June 28, 2018, 05:29:06 PM
Quote from: masc on June 28, 2018, 09:03:52 AM

@Kanakori & 50mm1200s: Yes, this are very crushed highlights. Normally they get pink only (because the green channel clips only mostly)... here it seems all channels are clipped, so they have any color. Maybe also dualIso makes it more strange. Blown highlights are no problem in non-dual-iso, but are a huge problem in dual-iso-clips. Highlight reconstruction will work only slightly (if it works at all in this special case). So the only way is to raise light strengh. But I am not sure if that works, because the artifacts are very dark.


I believe I used that option... on mlvproducer that doesnt happen even with dual iso option activated, but I don't like the workflow on there and I can't get the same results. However the fact that these spots don't show up in mlvproducer might mean the problem doesn't come from the clips?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 28, 2018, 07:04:17 PM
Quote from: Kanakori on June 28, 2018, 05:29:06 PM
I believe I used that option... on mlvproducer that doesnt happen even with dual iso option activated, but I don't like the workflow on there and I can't get the same results. However the fact that these spots don't show up in mlvproducer might mean the problem doesn't come from the clips?
I can't tell you if it comes from the clip - I don't have it ;) And I never saw such artifacts on highlights in any clip. MLVProducer has a different highlight reconstruction, maybe this one is more effective against such extremly crushed highlights. I can't tell how it works, because I never saw the source code, but I know from my tests it works different ;)
Please upload some frames (cut it and export as MLV), so I could have a look what happens...

@Danne! NICE! 5x??? :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: feureau on June 29, 2018, 07:15:56 AM
MLV App keeps failing to complete batch export.

Exporting multiple clips using Export Selected Clips (Ctrl-e) when darkframe subtraction enabled will only export one file or two and will fail to load any other files.

Even selecting other vids in the session box after the warning box is closed will still fail to load vids. (giving out file not found error)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on June 29, 2018, 08:29:56 AM
Interesting...

@masc: can you reproduce this?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 29, 2018, 09:07:53 AM
@feureau: thanks for reporting, but I need more information about your system, all versions and what you do else. What resolution has the darkframe, what resolution have your clips (are these resolutions always the same?)
I can't reproduce the error you reported.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Rogan Thoerson on June 29, 2018, 10:39:37 AM
Masc sorry for the delay... I have been traveling quite much lately.
Once again thank you for the very good work.
There is maybe another thing that would be great for the app : a button for loading the video in the RAM of the computer for preview without cuts. It seems to be loaded after an export but would be nice to do it before ;)
Here is the file where i have trouble with the colors. I am using a 7D.
https://www.dropbox.com/s/qjo49weptoogjon/M30-2323.MLV?dl=0

Thank you.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 29, 2018, 11:26:34 AM
@Rogan Thoerson: thanks for sharing. I can reproduce it in v0.16, but in latest revision from our repository it works fine. So the issue seems to be fixed already. We changed a lot in terms of black and white level - there was a very tiny bug in MLVApp, but also ML for 7D is not correct here. But with latest revision you can correct the wrong levels of 7D clips (whitelevel is stored as 16200 @ ISO100 but is somewhere around 14300 on the 7D I tested and somewhere at 15500 on yours). With correct whitelevel highlight reconstruction for 7D clips also works fine.

So if you are on Mac, Danne wrote a compiler app and you could build the latest revision, or you would have to wait some days until we release v0.17.

(https://image.ibb.co/hZpCpy/Bildschirmfoto.png)

Edit: The blacklevel is also wrong: it is 2414 in this file (uncorrected) and with 2048 all is fine. Maybe here was the problem, because the RAW-Correction part was working with the wrong uncorrected blacklevel until last week. That is fixed since some days. ;)

Is it correct you filmed the clip with a 1/0sec shutter?! For me that seems wrong too.

A button for loading video to RAM is not there, but a submenu: "AMaZE Cached" can load the debayered clip into the RAM until a memory limit is reached, only processing is done when being played.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Enrico on June 29, 2018, 09:21:23 PM
Firstly I'd like to thanks the developer of this great programme, anyway I have some issues when I export raw videos in uncompressed avi becouse in premiere it doesn't play them, instead everything works with the default windows 10 video player. Any possible solusion or even suggestion in the workflow?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on June 30, 2018, 01:02:25 AM
Quote from: Enrico on June 29, 2018, 09:21:23 PM
Firstly I'd like to thanks the developer of this great programme, anyway I have some issues when I export raw videos in uncompressed avi becouse in premiere it doesn't play them, instead everything works with the default windows 10 video player. Any possible solusion or even suggestion in the workflow?

AVI uncompressed doesn't seem to be supported by Premiere Pro. You'll have to convert it to something like Cineform or Lagarith, if you want lossless, or you could export directly to ProRes 444, inside MLVApp...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on June 30, 2018, 01:26:39 AM
Quote from: masc on June 28, 2018, 07:04:17 PM
I can't tell you if it comes from the clip - I don't have it ;) And I never saw such artifacts on highlights in any clip. MLVProducer has a different highlight reconstruction, maybe this one is more effective against such extremly crushed highlights. I can't tell how it works, because I never saw the source code, but I know from my tests it works different ;)
Please upload some frames (cut it and export as MLV), so I could have a look what happens...

@Danne! NICE! 5x??? :P

Ok I can send you a clip as an example through private messaging

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Enrico on June 30, 2018, 12:03:39 PM
But converting in Cineform or Lagarith as you suggested requires an extra passage, am I right? Anyway do you think ProRess 4444 is a good codec in terms of quality?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 30, 2018, 07:42:07 PM
Quote from: Kanakori on June 30, 2018, 01:26:39 AM
Ok I can send you a clip as an example through private messaging
Thanks, I'll download and take a look!

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 30, 2018, 07:44:52 PM
Quote from: Enrico on June 30, 2018, 12:03:39 PM
But converting in Cineform or Lagarith as you suggested requires an extra passage, am I right? Anyway do you think ProRess 4444 is a good codec in terms of quality?
Cineform and Lagarith is not supported by MLVApp, so you need an extra passage, right. I like the quality of ProRes 4444, but it always depends on your workflow and what you want to get if it is enough.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 30, 2018, 08:40:49 PM
@Kanakori: download is finished for me and I watched into the MLV. For me it looks like both channels - the dark and the bright one are overexposed in the defect areas. Look here, first picture is dualIso=Off + HighlightReconstruction=On + Exposure=-3, second picture dualIso=On (highlightReconstruction don't cares, because there are no more highlights to detect after wrong dualIso rendering):
(https://image.ibb.co/mZMaSJ/Bildschirmfoto1.png)
(https://image.ibb.co/eZp6Zy/Bildschirmfoto2.png)
@Bouncyball: do you have an idea what happens in complicated dualIso rendering here? For me it looks like something in the 16bit to 20bit to 16bit is going wrong... but can't figure out where. Like very bright areas are cutted and become black (or other nice modern color).

Edit: hmmm... preview mode is working...
(https://image.ibb.co/ddQBmd/Bildschirmfoto3.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on June 30, 2018, 10:14:07 PM
@Bouncyball: I think I found it... it works nice now! I changed scale_bits_for_diso in dualiso.c. The problem is 12bit lossless seems to bring to high values and the sh** happens. I inserted two lines for limiting the shifted values and voilà... but maybe you have a better idea to correct it ;)

int scale_bits_for_diso(struct raw_info * raw_info, uint16_t * image_data, int lossless_bpp)
{
    ...
    else if(lossless_bpp < 14)
    {
        ...
        for(int i = 0; i < pixel_count; ++i)
        {
            uint32_t temp = (((uint32_t)image_data[i] - raw_info->black_level) << shift_bits) + raw_info->black_level;
            if( temp > 16383 ) temp = 16383;
            image_data[i] = temp;
        }

        return 1; // scaled for losless dualiso
    }
    ...
}


You shift by 2, that multiplies by 4. Whitelevel is 5586. 5586*4=22344 ... that is more than 14bits, so all over 16383 is cut.

@Kanakori: you can compile? Change these few lines and you can render your clips for now... ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on July 01, 2018, 12:35:14 AM
You guys are a godsend but I can't compile. I don't have that type of knowledge, I'm a simple user.  :-X
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 01, 2018, 12:45:46 AM
If on mac, double click this:
https://bitbucket.org/Dannephoto/mlv_app_compiler/src/default/

download:
https://bitbucket.org/Dannephoto/mlv_app_compiler/downloads/mlv_app_compiler.dmg
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on July 01, 2018, 01:36:48 AM
Thanks but what do I open it with?

I'm in windows btw.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 01, 2018, 10:09:27 AM
You're on Windows? Meh... hm, then we have to wait for Bouncyball, I only could compile a 32bit version for you, but don't know exactly what was changed for this force dual iso... my success here was not at 100%. I thought you know what Bouncyball changed there.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 01, 2018, 10:20:46 AM
Quote from: masc on June 30, 2018, 10:14:07 PM
You shift by 2, that multiplies by 4. Whitelevel is 5586. 5586*4=22344 ... that is more than 14bits, so all over 16383 is cut.
S..t! Right! Have to revise that scaling.

Edit: it is calculated correctly.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 01, 2018, 11:24:18 AM
@masc

No it was correct because I'm doing:

(5586-2047) * 4 + 2047 = 16203 
e.g.
(5586-2047) << 2 + 2047 = 16203

I guess some raw values in this particular case may be greater than white (5586) level and that is the cause of this issue. Should be debugged. I need the source MLV.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 01, 2018, 11:40:41 AM
Anyway if your check is working this (https://github.com/ilia3101/MLV-App/commit/82b0264eda5c856c1081ecb37dea48fe5de0d14f) should work as well.

Could you check this commit out?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 01, 2018, 12:07:13 PM
Hehe, you're better at maths! :D (and know what you did). Yes, commit works as well!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 01, 2018, 12:09:05 PM
@masc: Great! :D

@Kanakori: check PM

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 01, 2018, 12:43:58 PM
In this particular clip the highest value is 5632, whitelevel is 5586.
(5632-2047) << 2 + 2047 = 16384 ... so exactly 1 to high to work?!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 01, 2018, 12:56:05 PM
Hehe, I was right then. We could just make -1 in the formula ;) (just kidding)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Enrico on July 01, 2018, 01:29:56 PM
Quote from: 50mm1200s on June 30, 2018, 01:02:25 AM
AVI uncompressed doesn't seem to be supported by Premiere Pro. You'll have to convert it to something like Cineform or Lagarith, if you want lossless, or you could export directly to ProRes 444, inside MLVApp...
But actually After Effects exports AVI uncompressed when it imports sequences of DNG or TIFF. Maybe the issues regard the codec, I'm not very knowledged in these things.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 01, 2018, 03:24:21 PM
Quote from: Enrico on July 01, 2018, 01:29:56 PM
But actually After Effects exports AVI uncompressed when it imports sequences of DNG or TIFF. Maybe the issues regard the codec, I'm not very knowledged in these things.

Well, just because AE exports, it doesn't mean it will open on PP. There's no codec on uncompressed AVI, it's just a container (.avi) with raw data. You should just use ProRes 444 or convert it as we said already.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Enrico on July 01, 2018, 05:40:28 PM
Quote from: 50mm1200s on July 01, 2018, 03:24:21 PM
Well, just because AE exports, it doesn't mean it will open on PP. There's no codec on uncompressed AVI, it's just a container (.avi) with raw data. You should just use ProRes 444 or convert it as we said already.
Ok but Premiere actually opens uncompressed AVI from After Effects, so if there is no codec what's the problem?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 01, 2018, 07:03:14 PM
With this little app you can look into the clips and look what exactly is coded: https://mediaarea.net/
AVI uncompressed is not AVI uncompressed. ffmpeg offers more than a hand full different uncompressed AVI... we've chosen the "rawvideo" one. But I still don't understand why you've chosen AVI instead of CDNG when working with Premiere. Do you color correct in MLVApp? Then it could be useful.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on July 01, 2018, 07:56:45 PM
Quote from: bouncyball on July 01, 2018, 12:09:05 PM
@masc: Great! :D

@Kanakori: check PM

regards
bb

Thanks guys! I'm trying it out rn.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on July 01, 2018, 09:10:25 PM
Quote from: Enrico on July 01, 2018, 05:40:28 PM
Ok but Premiere actually opens uncompressed AVI from After Effects, so if there is no codec what's the problem?

The asi-container from mlvapp, is specially made for the needs of astronomical stuff.  Some astronomical software need exact this format as input.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 01, 2018, 10:13:40 PM
Danne,

I tried chroma smoothing with MLVApp applied to a 3096x1320@15fps file from the 100D to remove focus dots.  The 2x2 setting dampened the dots but did not remove them.  The 3x3 setting killed them totaly but I did not like the result.  The look is too clean, plastic and digital.  The effect is very much like noise reduction.  Is chroma smoothing supposed to work that way?  I think, focus pixel maps do a much better job.

I also tried Batch_MLV as you suggested but it did not work for me.  It just exports the audio file and puts the original MLV file into a separate folder.  No DNGs.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 01, 2018, 10:43:56 PM
Might be needing the setting relaxed set in batch_mlv. Or it´s maybe too old  :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Enrico on July 02, 2018, 01:41:11 AM
Quote from: masc on July 01, 2018, 07:03:14 PM
With this little app you can look into the clips and look what exactly is coded: https://mediaarea.net/
AVI uncompressed is not AVI uncompressed. ffmpeg offers more than a hand full different uncompressed AVI... we've chosen the "rawvideo" one. But I still don't understand why you've chosen AVI instead of CDNG when working with Premiere. Do you color correct in MLVApp? Then it could be useful.
Is it a bad idea to color correct in premiere using a regulation layer? I personally don't like using CDNG becouse requires extra passages and also after effects render really slowly on my pc (I don't know why it doesn't use my GTX 960M, I tried different tutorials, instead premiere do it and of couse is much faster). Is there any tool which convert AVI from MLVapp in the kind of AVI supported by premiere?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Enrico on July 02, 2018, 01:45:29 AM
Quote from: escho on July 01, 2018, 09:10:25 PM
The asi-container from mlvapp, is specially made for the needs of astronomical stuff.  Some astronomical software need exact this format as input.
Yes AVI from MLVapp are enormous but AVI from after effects made from DNG are even bigger. Sorry for the questions but this is my first approach to videomaking.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: wety67e on July 02, 2018, 10:56:10 AM
Utvideo is a great codec.

https://www.videohelp.com/software/Ut-Video-Codec-Suite
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 02, 2018, 11:07:17 AM
@Enrico: Uncompressed AVI is processed 8bit video. So you have to adapt whitebalance and exposure, maybe more to not loose too much information. Again: if you do that, it's no big deal. Filesize plays not the biggest role in terms of quality ;) In cDNG the 14bit RAW from the sensor is untouched. Sure that is slower in Premiere... ProRes is somewhere between: 10-/12bit processed video (depending on chosen encoder).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 02, 2018, 11:15:28 AM
Quote from: IDA_ML on July 01, 2018, 10:13:40 PM
I tried chroma smoothing with MLVApp applied to a 3096x1320@15fps file from the 100D to remove focus dots.  The 2x2 setting dampened the dots but did not remove them.  The 3x3 setting killed them totaly but I did not like the result.  The look is too clean, plastic and digital.  The effect is very much like noise reduction.  Is chroma smoothing supposed to work that way?  I think, focus pixel maps do a much better job.
Chroma smoothing and focus pixel removal are two very different things. Yes, chroma smoothing filters also focus pixels... but also a lot more (the algorithms does its job for each pixel in your picture). Focus pixel removal only removes focus pixels, so it is a lot faster and looks better for this task.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Enrico on July 02, 2018, 11:23:56 AM
Quote from: masc on July 02, 2018, 11:07:17 AM
@Enrico: Uncompressed AVI is processed 8bit video. So you have to adapt whitebalance and exposure, maybe more to not loose too much information. Again: if you do that, it's no big deal. Filesize plays not the biggest role in terms of quality ;) In cDNG the 14bit RAW from the sensor is untouched. Sure that is slower in Premiere... ProRes is somewhere between: 10-/12bit processed video (depending on chosen encoder).
I record with a 700D in 10bit but are you saying that the AVI from MLVapp is only 8 bit? I don't understand, I'm so confused  :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 02, 2018, 11:26:04 AM
Thank you for this explanation, Masc.

The reason I wanted to use chroma smoothing for removing  focus pixels is that the new focus pixel maps are not ready yet and it may take a while until they get updated.  But I wanted focus pixel free files to be able to judge the quality of the new 4K files from the 100D.  I was very surprised to see that chroma smoothing affects the overall video quality in a perceptible way - something that I did not expect.  That is why I asked.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 02, 2018, 11:30:31 AM
I think a darkframe file and cs2x2 could be a good compromise.
dfort asked for a file as well for updating maps so that is an idea as well.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 02, 2018, 11:38:36 AM
Quote from: masc on June 13, 2018, 04:52:07 PM
Today I got some standard clips from a 7D. MLVApp is not able to reconstruct the highlights for all these 7D clips. Did anyone else had such problems with your 7D footage (or maybe also other cams)? Please report! ;)
I found a temp solution (which is not really nice but working) and I would like to test a bit around before releasing a bugfix...

Masc,

I have the 100D and "Highlight reconstruction" does not seem to do anything on MLV files from that camera either.  Slightly overexopsed highlights stay pink all the time, no matter what I do.  I use the latest v.016 of MLVApp.  I hope, this issue can be fixed because Highlight reconstruction is a very important function.  Would you like me to send you some 100D footage?  If yes, please write down the command that I can use to shorten the clips here.  I cannot find it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 02, 2018, 11:45:27 AM
Quote from: Danne on July 02, 2018, 11:30:31 AM
I think a darkframe file and cs2x2 could be a good compromise.
dfort asked for a file as well for updating maps so that is an idea as well.

Danne,

I will provide to Dfort all the files that he needs to update the focus pixel maps for the 100D.  I will do that as soon as it is clear what the final RAW-video resolutions will be for that camera.  I am not sure if that is clear yet.  Porting 4k-crop recording to the Rebels is still bleeding edge and in progress, isn't it?  If you can suggest a resolution that will remain unchanged, I will shoot and provide the files for it as soon as possible.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 02, 2018, 11:58:25 AM
Probably a good idea to let it sunk in a bit. Best idea is what a1ex is planning imo https://www.magiclantern.fm/forum/index.php?topic=16054.msg203367#msg203367
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 02, 2018, 12:13:29 PM
Quote from: Enrico on July 02, 2018, 01:41:11 AM
Is there any tool which convert AVI from MLVapp in the kind of AVI supported by premiere?

ffmpeg (https://www.ffmpeg.org/) or Handbrake (https://handbrake.fr/). You can easily install ffmpeg through Chocolatey (https://chocolatey.org/) (if you work on windows) or Homebrew (https://brew.sh/) (if on mac).

Quote
I record with a 700D in 10bit but are you saying that the AVI from MLVapp is only 8 bit? I don't understand, I'm so confused

No, uncompressed AVI from MLVApp seems to be 12bit, but the chroma subsampling is 4:2:0.
ProRes and DNxHR are nearly lossless, have subsampling of 4:4:4 and are 10-bit. Just use these... please. There's no need to complicate.
If you really want a lossless workflow, MLVApp is probably not what you're looking to use. Check Resolve, in this case.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 02, 2018, 12:33:21 PM
I've added Uncompressed AVI v210 (4:2:2 10bit) to the export list. It is supported by any NLEs. You just have to compile MLV App yourself.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 02, 2018, 12:33:54 PM
Quote from: 50mm1200s on July 02, 2018, 12:13:29 PM
No, uncompressed AVI from MLVApp seems to be 12bit, but the chroma subsampling is 4:2:0.
It is not 12bits, it's 8 bit (indeed 4:2:0)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 02, 2018, 12:51:48 PM
Quote from: IDA_ML on July 02, 2018, 11:38:36 AM
Masc,

I have the 100D and "Highlight reconstruction" does not seem to do anything on MLV files from that camera either.  Slightly overexopsed highlights stay pink all the time, no matter what I do.  I use the latest v.016 of MLVApp.  I hope, this issue can be fixed because Highlight reconstruction is a very important function.  Would you like me to send you some 100D footage?  If yes, please write down the command that I can use to shorten the clips here.  I cannot find it.
Sure, I take all I can get for testing, debugging and further development! ;) THX! (I bet whitelevel in the file is wrong.) Shorten the clip via CutIn / CutOut and export as MLV.

Uncompressed AVI in v0.16 - 8bit 4:2:0
Uncompressed AVI by bouncyball - 10bit 4:2:2
ProRes ffmpeg - 10bit 4:2:2 or 4:4:4
ProRes AVFoundation - 12bit 4:2:2 or 4:4:4

@Enrico: 10bit from your sensor is different to 10bit processed video (in terms of values which are represented inside these 10bits).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: squig on July 02, 2018, 12:58:32 PM
Quote from: Enrico on July 02, 2018, 01:41:11 AM
Is it a bad idea to color correct in premiere using a regulation layer? I personally don't like using CDNG becouse requires extra passages and also after effects render really slowly on my pc (I don't know why it doesn't use my GTX 960M, I tried different tutorials, instead premiere do it and of couse is much faster). Is there any tool which convert AVI from MLVapp in the kind of AVI supported by premiere?

After Effects video frame rendering is CPU only. Use AE CS6 or CC 2014 for multiprocessor rendering, it's much slower (single processor) in CC 2015 onwards. Resolve is much faster.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 02, 2018, 02:35:02 PM
Quote from: bouncyball on July 02, 2018, 12:33:54 PM
It is not 12bits, it's 8 bit (indeed 4:2:0)

Well, exiftool is giving me wrong informations:


ExifTool Version Number         : 8.03
File Name                       : M21-1816.avi
Directory                       : .
File Size                       : 113 MB
File Modification Date/Time     : 2018:07:02 07:09:15-03:00
File Permissions                : rw-rw-rw-
File Type                       : AVI
MIME Type                       : video/avi
Frame Rate                      : 23.976
Max Data Rate                   : 4.857e+004 kB/s
Frame Count                     : 57
Stream Count                    : 1
Stream Type                     : Video
Video Codec                     : I420
Video Frame Rate                : 23.98
Video Frame Count               : 57
Quality                         : Default
Sample Size                     : Variable
Image Width                     : 1568
Image Height                    : 882
Planes                          : 1
Bit Depth                       : 12
Compression                     : I420
Image Length                    : 2074464
Pixels Per Meter X              : 0
Pixels Per Meter Y              : 0
Num Colors                      : Use BitDepth
Num Important Colors            : All
Software                        : Lavf57.82.101
Duration                        : 2.38 s
Image Size                      : 1568x882


ffprobe don't seem show the bit depth:


Metadata:
    encoder         : Lavf57.82.101
  Duration: 00:00:02.38, start: 0.000000, bitrate: 398007 kb/s
    Stream #0:0: Video: rawvideo (I420 / 0x30323449), yuv420p, 1568x882, 405004 kb/s, 23.98 fps, 23.98 tbr, 23.98 tbn, 23.98 tbc
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 70MM13 on July 02, 2018, 02:36:07 PM
14 bits lossless cdng is just PERFECT for resolve.

The filesize is respectable, with perfect quality and real-time playback, even at 3K.

Keep adding power to this app and eventually there won't be a need to use anything else except a NLE!

With each new version, I find myself able to use more clips straight from mlvapp!

Unfortunately, the complexity of grading difficult shots is still way out of range, but nothing is impossible if you work toward it!

This is a great program!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Seruji on July 02, 2018, 02:45:01 PM
Filmmakers
¿Any tip for someone who has a 5D MK2 (mlv 2.0) and wants to shoot a shortfilm in raw and then post-edit in Adobe Premiere? In terms of LUT's order..if it's more important to apply a LUT in MLVAPP or export (proRes 4444) and apply the LUT in Premiere?

¿Which LUT for general color-grading do you guys apply? MLVAPP or in a video editing software (such as Resolve, Final Cut, Premiere..). I have dozens of LUT's, but don't know when to apply them, or if there are some very common on this community.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 02, 2018, 02:46:24 PM
@50mm1200s: this is what mediainfo tells:
General
Complete name                            : /Users/masc/Desktop/M05-0608.avi
Format                                   : AVI
Format/Info                              : Audio Video Interleave
File size                                : 2.79 MiB
Duration                                 : 43 ms
Overall bit rate                         : 544 Mb/s
Writing application                      : Lavf57.71.100

Video
ID                                       : 0
Format                                   : YUV
Codec ID                                 : I420
Codec ID/Info                            : 8 bit Y plane followed by 8 bit 2x2 subsampled U and V planes.
Duration                                 : 40 ms
Bit rate                                 : 581 Mb/s
Width                                    : 1 856 pixels
Height                                   : 1 044 pixels
Display aspect ratio                     : 16:9
Frame rate                               : 25.000 FPS
Compression mode                         : Lossless
Bits/(Pixel*Frame)                       : 12.000
Stream size                              : 2.77 MiB (99%)


Quote from: 70MM13 on July 02, 2018, 02:36:07 PM
Keep adding power to this app and eventually there won't be a need to use anything else except a NLE!
With each new version, I find myself able to use more clips straight from mlvapp!
Thanks. That is our goal and what I do as well.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 02, 2018, 02:49:48 PM
Quote from: Seruji on July 02, 2018, 02:45:01 PM
Filmmakers
¿Any tip for someone who has a 5D MK2 (mlv 2.0) and wants to shoot a shortfilm in raw and then post-edit in Adobe Premiere? In terms of LUT's order..if it's more important to apply a LUT in MLVAPP or export (proRes 4444) and apply the LUT in Premiere?

¿Which LUT for general color-grading do you guys apply? MLVAPP or in a video editing software (such as Resolve, Final Cut, Premiere..). I have dozens of LUT's, but don't know when to apply them, or if there are some very common on this community.
I would add the LUT at the stage where you color correct / color grade. So if you do this in MLVApp, add it in MLVApp, if you do this in Premiere, do it in Premiere.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 02, 2018, 02:58:38 PM
@masc since we're already talking about encoding, about our discussion some time ago on color management... no improvements? I see advanced color management can't be done with ffmpeg, but at least it supports (https://ffmpeg.org/ffmpeg-filters.html#colorspace) bt2020 out of the box...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 02, 2018, 03:06:13 PM
Quote from: 50mm1200s on July 02, 2018, 02:58:38 PM
@masc since we're already talking about encoding, about our discussion some time ago on color management... no improvements? I see advanced color management can't be done with ffmpeg, but at least it supports (https://ffmpeg.org/ffmpeg-filters.html#colorspace) bt2020 out of the box...
Hmm... it supports not really... it only supports adding the metadata, but that does not mean bt2020 is inside. You'll need a matrix conversion inside the ffmpeg command. But that won't "bring" more quality, because the input & encoding is still the same. There is this colormatrix=... command - this one works in 8bit - so you'll loose more than you'll get. You also can adjust colorspace via scale filter, this one works with higher bitdepth. Atm we convert and export to bt709 in this way. Otherwise you can export with AVFoundation, if you don't like bt709, or you must color correct in another software if thats not enough - you're right.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 02, 2018, 03:13:11 PM
Quote from: Seruji on July 02, 2018, 02:45:01 PM
Filmmakers
¿Any tip for someone who has a 5D MK2 (mlv 2.0) and wants to shoot a shortfilm in raw and then post-edit in Adobe Premiere? In terms of LUT's order..if it's more important to apply a LUT in MLVAPP or export (proRes 4444) and apply the LUT in Premiere?

¿Which LUT for general color-grading do you guys apply? MLVAPP or in a video editing software (such as Resolve, Final Cut, Premiere..). I have dozens of LUT's, but don't know when to apply them, or if there are some very common on this community.

If you're going to apply a LUT, do it directly on MLVApp if possible. But, you might find MLVApp limited for color grading, since once it's encoded you can't change it (destructive workflow). So what I do is this:
- Import on MLVApp. Put the clips on Alexa Log-C. Fix exposure and WB. Export to ProRes 444
- Import on Premiere. Use Logarist (https://www.logarist.com/) to convert from LogC to Rec.709.
- Do color grading with Lumetri.

This way you have a somewhat solid color grading. I sometimes use ImpulZ LUT's (the "FPE" type, that is, the film color, but not density), but they have many issues on dark midtones (some color shift towards magenta).

You would get better results using a CinemaDNG on Resolve if you will be doing heavy color grading...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 02, 2018, 03:19:48 PM
Quote from: masc on July 02, 2018, 03:06:13 PM
Hmm... it supports not really... it only supports adding the metadata, but that does not mean bt2020 is inside. You'll need a matrix conversion inside the ffmpeg command. But that won't "bring" more quality, because the input & encoding is still the same. There is this colormatrix=... command - this one works in 8bit - so you'll loose more than you'll get. You also can adjust colorspace via scale filter, this one works with higher bitdepth. Atm we convert and export to bt709 in this way. Otherwise you can export with AVFoundation, if you don't like bt709, or you must color correct in another software if thats not enough - you're right.

Ok, I get it now. Thanks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 02, 2018, 05:32:21 PM
Hello Masc,

Here are two 2K files from the 100D shortened to 5 frames each and exported with MLVApp to MLV according to your instructions.  The export option is Fast Pass.  The focus pixels on the videos are clearly seen, also there should be slightly overexposed areas on the files for you to check Highlight reconstruction.

https://we.tl/IDENw3zZHe

The link will be active for 7 days.  Please let me know if these files work for you and if yes, I will send you also other ones at higher resolutions. 

If you could fix the focus pixel issue on the latest 4k-crop versions of the Rebels and include this FP cleaning in the next version of MLVApp, the MLV export function in combination with cleaning focus pixels and Cut-in and Cut-out, will make an extremely useful function of MLVApp to remove unwanted sections in the clips, reduce their file size and prepare clean footage for further work with an NLE as DaVinci Resolve.  That would be GOLDEN !!!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on July 02, 2018, 07:58:49 PM
@IDA_ML -- here's something you can try - no coding skills needed  ;)

Not sure if you're on Mac or Windows but I believe you mentioned that you have MLVFS working on your system. That's the first app that used the focus pixel map files and what I still use when experimenting with new resolutions. Dig into the app and look for a file named, "80000346_2592x1108.fpm" now make a copy and name it "80000346_2592x1332.fpm" and try it on your MLV files.

Long answer.

If you extract the DNG's without chroma smoothing then process a DNG frame with dcraw using the -4 -E options you can clearly see the focus pixels.

(https://farm1.staticflickr.com/920/42436818254_c9a30dde33.jpg) (https://flic.kr/p/27DZMAf)

and this is what it looks like in color:

(https://farm2.staticflickr.com/1768/42436820404_5c12170e6b.jpg) (https://flic.kr/p/27DZNej)

Looking at the sample files with mlv_dump using the -v option we find this:

Block: RAWI
  Offset: 0x00000034
  Number: 1
    Size: 180
    Time: 0.910000 ms
    Res:  2096x1180 <--- image size
    raw_info:
      api_version      0x00000001
      height           1332 <--- full raw buffer is 2592x1332
      width            2592


That's the same full raw buffer width as in zoom mode but with increased vertical resolution. Now the question is if the crop and pan metadata works the same? This is what is needed to line up the focus pixel map file--the map files cover the full raw buffer so they can be used with all of the various image size and aspect ratio options.

It works!

(https://farm1.staticflickr.com/842/42437824504_aea297d1fa.jpg) (https://flic.kr/p/27E5WHo)

Well almost. Focus pixels show up at the bottom of the frame because the focus pixel map file that is currently in MLVFS doesn't completely cover the new full raw buffer.

So all that is necessary is to extend the zoom mode focus pixel map file to cover the additional vertical resolution and we should be able to eliminate the focus pixels on this new crop_mode resolution.

[EDIT] Here are before and after images showing the MLVFS hack. You can zoom into them in flickr without having to download the file to take a close look at the focus pixels.

Before:
(https://farm2.staticflickr.com/1770/41346057530_2ffe52ef55_z.jpg) (https://flic.kr/p/25ZBmqS)

After:
(https://farm1.staticflickr.com/845/42252670525_1aa4ed9379_z.jpg) (https://flic.kr/p/27nHYTp)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 02, 2018, 09:18:47 PM
Thx @IDA_ML for the files. Highlight reconstruction works for this files. In the appartment file in the furniture window you can see a difference when toggling, in the city clip I only see that something happens in the histogram.

Thx @dfort for your explanation, but I don't get that to work. All focus pixels are still there. I tried exactly what you wrote, but MLVApp and MLVFS won't handle the focus pixels. MLVApp works with the same fpm files as MLVFS normally.

@IDA_ML: the focus pixels issue not really an issue - all is working - all we need are the focus pixel maps for these resolutions. These have to be found... if we/you have them, the MLVApp version you have now will handle it already.

@bouncyball: are we able with our algorithm for focus pixels to calculate the map somehow? Or do we need to know the pixels first?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on July 02, 2018, 10:40:42 PM
Quote from: masc on July 02, 2018, 09:18:47 PM
Thx @dfort for your explanation, but I don't get that to work. All focus pixels are still there. I tried exactly what you wrote, but MLVApp and MLVFS won't handle the focus pixels. MLVApp works with the same fpm files as MLVFS normally.

That's strange. I updated my fpm.sh bash script (https://bitbucket.org/daniel_fort/ml-focus-pixels/commits/63d27bd3dbedc14abc3e8b289d243b63c93cfe49) to handle the new resolution and it is working fine over here in MLVFS:

(https://farm2.staticflickr.com/1770/43159219721_65cf8c0cee_z.jpg) (https://flic.kr/p/28KQhnX)

Notice that the focus pixels that were on the bottom of the previous post are gone. I converted the DNG to TIFF using dcraw because that tends to show focus pixels more than other apps like DaVinci Resolve and Adobe Camera Raw.

Here is the new focus pixel map file for the 100D:

https://bitbucket.org/daniel_fort/ml-focus-pixels/src/default/focus_pixel_map_files/80000346_2592x1332.fpm
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 03, 2018, 08:16:57 AM
@dfort: thx, this works perfectly, also with MLVApp! ;)
@bouncyball: can you also update the focus pixel calcuation for such resolutions for EOS 100D, please?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 03, 2018, 09:21:21 AM
@dfort: Yay! Now it works perfectly. Thanks for a quick response on my humble request :)

@masc: Sure :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 03, 2018, 09:45:19 AM
Working perfectly @dfort
(https://s15.postimg.cc/pnh469syj/Screen_Shot_2018-07-03_at_09.47.13.png_scaled.jpg)

(https://s15.postimg.cc/s4svdj557/Screen_Shot_2018-07-03_at_09.47.21.png_scaled.jpg)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 03, 2018, 11:03:11 AM
@masc: Done! You can remove 80000346_2592x1332.fpm from repo.

Edit: "fpmutil" also updated.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 03, 2018, 11:13:43 AM
All unused focus pixel maps removed. Thx bouncyball & dfort - your work works great!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 03, 2018, 05:01:31 PM
A truly spectacular development.  Thank you, Dfort, Bouncyball, Masc and whoever may be involved.  If this developments continues at that speed, very soon our little cameras will become as powerful as Ari Alexa for RAW video. ;)

And since the interest in the focus pixel subject seems to be substantial, I have prepared more test files from the 100D that everyone interested can download from here in the next 7 days:

https://we.tl/nTSisEjsan

These include 2520x1304; 3096x1320 and 4056x2280 resolutions.  Some of them include a few overexposed areas for you to check white levels that in my opinion, do not fully work yet.  I still notice a slight pink cast when I reduce the exposure or Highlights in MLVApp.  I have also included two 4K files shot in Dual ISO 100/800 which now again becomes very relevant, interesting and important for smooth timelapse videos.  Note the absence of noise in the dark areas of these Dual ISO shots.  This is really spectacular!

Dfort, please have a look at the shot where my daughter wipes out the table after breakfast.  In my opinion, there are still focus dots on that clip.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on July 03, 2018, 07:34:43 PM
Hi,

I was wondering if there would be any way to process the older .RAW files with this app? I know the format probably is a bit outdated now...

As I'm able to process them in mlrawviewer I thought maybe it's not impossible to incorporate support in this app.
If it's out of the question, would there be any way to convert .RAW files to .mlv?

I have a bunch of old footage I'd really like to process with the workflow that this app offers.

Thank you for the continued development!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 03, 2018, 08:09:21 PM
On mac you can use "Switch". Or else compile raw2dng. Bouncyball implemented raw to mlv conversion. Works very good.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 03, 2018, 08:52:34 PM
Yeah you have to follow Danne's advice. We are not going to add .RAW support to MLV App.

Quote from: FBongcam on July 03, 2018, 07:34:43 PM
If it's out of the question, would there be any way to convert .RAW files to .mlv?
I have a bunch of old footage I'd really like to process with the workflow that this app offers.
I also had bunch of old .RAW files from 60D, that's why I decided to implement RAW to MLV converter into raw2dng utility.

Download it here (https://bitbucket.org/bouncyball/mlv-tools/downloads/) for any OS (it is command line utility, prints out help)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 03, 2018, 09:09:01 PM
Quote from: IDA_ML on July 03, 2018, 05:01:31 PM
These include 2520x1304; 3096x1320 and 4056x2280 resolutions.  Some of them include a few overexposed areas for you to check white levels that in my opinion, do not fully work yet.  I still notice a slight pink cast when I reduce the exposure or Highlights in MLVApp.  I have also included two 4K files shot in Dual ISO 100/800 which now again becomes very relevant, interesting and important for smooth timelapse videos.  Note the absence of noise in the dark areas of these Dual ISO shots.  This is really spectacular!

Dfort, please have a look at the shot where my daughter wipes out the table after breakfast.  In my opinion, there are still focus dots on that clip.

Thanks again for the clips!
Where do you see focus dots in the clip with your daughter? I can't find any... The pink highlights were gone in all shots, except for the last one. Note that I did not test with v0.16, I tested with the latest revision from the repos. For the last clip I changed dual iso highlight reconstruction in a way it works also for this clip now. For dual iso clips it is much more difficult than for standard clips. I know that my algorithm for dual iso is not perfect: if there is a bright pink in the picture which is no clipped highlight (e.g. a flower), it is filtered as well.

For the higher resolutions than 2.5k there is no focus pixel map yet there... so it has to be found again.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 03, 2018, 11:35:44 PM
Masc,

Thank you for checking out the files that I provided.  Right now, I am using the 016 version from the first page but work is still in progress.  As long as we are clear about all resolutions and center offsets, I will be more than happy to provide more test files as needed. In this way, it will be possible to refine the focus pixel maps at all resolutions.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on July 04, 2018, 04:54:14 PM
Quote from: bouncyball on July 03, 2018, 08:52:34 PM
Yeah you have to follow Danne's advice. We are not going to add .RAW support to MLV App.
I also had bunch of old .RAW files from 60D, that's why I decided to implement RAW to MLV converter into raw2dng utility.

Download it here (https://bitbucket.org/bouncyball/mlv-tools/downloads/) for any OS (it is command line utility, prints out help)

Thanks, it worked. I do however get weird artifacts on clips where the black level is wrong. When corrected with mlv_dump I don't get these.
It's like pink highlights/dots around edges etc.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 04, 2018, 04:57:30 PM
Quote from: FBongcam on July 04, 2018, 04:54:14 PM
Thanks, it worked. I do however get weird artifacts on clips where the black level is wrong. When corrected with mlv_dump I don't get these.
It's like pink highlights/dots around edges etc.
Could you provide a MLV (shortend to some frames is enough for analysing) please?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 04, 2018, 05:00:47 PM
Quote from: IDA_ML on July 03, 2018, 11:35:44 PM
Masc,
Thank you for checking out the files that I provided.  Right now, I am using the 016 version from the first page but work is still in progress.  As long as we are clear about all resolutions and center offsets, I will be more than happy to provide more test files as needed. In this way, it will be possible to refine the focus pixel maps at all resolutions.
It is always good to have newest stuff to test... thx again! v0.17 is in work for everybody and will be another step forward ;) We just have to get some little things nice atm.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on July 04, 2018, 05:34:48 PM
Quote from: masc on July 04, 2018, 04:57:30 PM
Could you provide a MLV (shortend to some frames is enough for analysing) please?

This is the mlv file converted from .raw with Switch to .mlv file. Shortened using MLV export in MLVApp.

https://www.dropbox.com/s/lafak8wh13xopmj/M01-2016.MLV?dl=0 (https://www.dropbox.com/s/lafak8wh13xopmj/M01-2016.MLV?dl=0)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 04, 2018, 06:01:27 PM
Quote from: FBongcam on July 04, 2018, 04:54:14 PM
I do however get weird artifacts on clips where the black level is wrong. When corrected with mlv_dump I don't get these.
It's like pink highlights/dots around edges etc.
Hmm... and where are those artifacts in the clip posted above? Cleanest image ever, IMHO :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on July 04, 2018, 06:25:53 PM
Quote from: bouncyball on July 04, 2018, 06:01:27 PM
Hmm... and where are those artifacts in the clip posted above? Cleanest image ever, IMHO :)


(https://thumb.ibb.co/mvjLKy/Ska_rmavbild_2018_07_04_kl_18_21_05.png) (https://ibb.co/mvjLKy)

(https://thumb.ibb.co/g8TQmd/Ska_rmavbild_2018_07_04_kl_18_21_14.png) (https://ibb.co/g8TQmd)


Do you not get these results in your preview? I get the same result when exported as well.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 04, 2018, 07:28:36 PM
Quote from: FBongcam on July 04, 2018, 06:25:53 PM

(https://thumb.ibb.co/mvjLKy/Ska_rmavbild_2018_07_04_kl_18_21_05.png) (https://ibb.co/mvjLKy)

(https://thumb.ibb.co/g8TQmd/Ska_rmavbild_2018_07_04_kl_18_21_14.png) (https://ibb.co/g8TQmd)


Do you not get these results in your preview? I get the same result when exported as well.

No, no such artifacts also for me. What version of MLVApp did you use, and on which OS?
(https://image.ibb.co/dCJNzy/Bildschirmfoto.png)

EDIT: STOP! I get the same result you have using v0.16. This version did not completely auto correct wrong black level of your file. The blacklevel of your file is over 5000... but it should be 2048. After correcting black level all is perfect (latest repos revision does it automatically).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on July 04, 2018, 08:08:13 PM
Quote from: masc on July 04, 2018, 07:28:36 PM
No, no such artifacts also for me. What version of MLVApp did you use, and on which OS?

EDIT: STOP! I get the same result you have using v0.16. This version did not completely auto correct wrong black level of your file. The blacklevel of your file is over 5000... but it should be 2048. After correcting black level all is perfect (latest repos revision does it automatically).

Yes I'm using v0.16 on mac os. Looking forward to next release then!  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 04, 2018, 08:44:06 PM
Why wait. Double click this and build your own updated version:
https://bitbucket.org/Dannephoto/mlv_app_compiler/downloads/mlv_app_compiler.dmg

https://bitbucket.org/Dannephoto/mlv_app_compiler/src
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 04, 2018, 09:14:21 PM
Quote from: Danne on July 04, 2018, 08:44:06 PM
Why wait. Double click this and build your own updated version:
https://bitbucket.org/Dannephoto/mlv_app_compiler/downloads/mlv_app_compiler.dmg

https://bitbucket.org/Dannephoto/mlv_app_compiler/src
Correct! It is so easy! @Danne: I linked it now in our github readme ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on July 04, 2018, 09:19:37 PM
Quote from: Danne on July 04, 2018, 08:44:06 PM
Why wait. Double click this and build your own updated version:
https://bitbucket.org/Dannephoto/mlv_app_compiler/downloads/mlv_app_compiler.dmg

https://bitbucket.org/Dannephoto/mlv_app_compiler/src

Quote from: masc on July 04, 2018, 09:14:21 PM
Correct! It is so easy! @Danne: I linked it now in our github readme ;)

Thanks guys!  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 04, 2018, 09:28:13 PM
Quote from: masc on July 04, 2018, 09:14:21 PM
Correct! It is so easy! @Danne: I linked it now in our github readme ;)
Awesome. Thank you :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on July 05, 2018, 01:25:16 AM
@Danne -- You asked me to do a test comparing the antialiasing feature in MLV App against a Mosaic Engineering VAF filter on my 700D. Here is my first attempt shooting one of our favorite subjects, our computer's keyboard. This is shot at 1736x976 with 3x3 sampling. That setting tends to show aliasing.

Processed through MLVFS and the DNGs converted to TIFFs using dcraw. I like doing it this way because it doesn't smooth out the problems like Adobe Camera Raw does.

Not much difference if you look at the whole shot on a computer screen.

No VAF
(https://farm1.staticflickr.com/837/28334491387_f0d5eac88f.jpg) (https://flic.kr/p/KaPF8z)

With VAF
(https://farm1.staticflickr.com/915/28334493907_5402656781.jpg) (https://flic.kr/p/KaPFT2)

If you look closely you can see a difference. Both of these were magnified 1600% in Photoshop.

No VAF
(https://farm2.staticflickr.com/1810/28334494847_9385af6504.jpg) (https://flic.kr/p/KaPGae)

With VAF
(https://farm1.staticflickr.com/847/28334495837_237a45725e.jpg) (https://flic.kr/p/KaPGsi)

I tried to pick frames that showed the D in focus. The VAF will soften the image slightly, though it is hardly noticeable if you look at the full frame. What does show up is that the edges of the shot without the VAF are some sawtooth looking edges and colored artifacts that are sometimes mistaken for focus pixels but they only appear on high contrast edges.

Now let's use these export settings so we can compare to the TIFF created in dcraw.

(https://farm1.staticflickr.com/845/28334496537_4f8da6a10d.jpg) (https://flic.kr/p/KaPGEn)

No VAF processed through MLV App with the above settings.
(https://farm1.staticflickr.com/916/28334496417_b88f18aeec.jpg) (https://flic.kr/p/KaPGCi)

Once again the original for comparison:
(https://farm2.staticflickr.com/1810/28334494847_9385af6504.jpg) (https://flic.kr/p/KaPGae)

Not exactly the best test--I should probably go outside and shoot a bicycle wheel. However, it does show marked improvement. Most import, I believe, is that the colored specks on the edges are gone.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 05, 2018, 06:56:39 AM
Nice one! Did you try the "last resort" setting as well?
If you could run it through the tiff_cleaning.command script too it would be nice to see what that looks like as well.
Thanks for sharing.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on July 05, 2018, 08:01:03 AM
Ok--here's what the "last resort" setting looks like.

(https://farm1.staticflickr.com/918/29337363138_db4114ce27.jpg) (https://flic.kr/p/LGrDXQ)

I also selected the "Post Export: TIF_CLEAN.command" so it continued processing after MLV App said it was done and when the post export was done it deleted the TIFF image files and created a Prores 422 movie file. That's a little strange. Here's what the movie look like--enlarged 1600%.

(https://farm1.staticflickr.com/920/42490404294_76f5dddb21.jpg) (https://flic.kr/p/27JJqRu)

It does look like this is a good option when you don't have VAF. I need to find something like your bicycle wheel that shows some serious aliasing issues and do further testing.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 05, 2018, 08:12:58 AM
It does look very good.
Yes, tiff only acts as intermediate in the tif cleaning script.
Thanks again for posting results.

Edit: the better option seems the ffmpeg one since it won't affect moving subjects the way tif_cleaning.command is(thus not an issue in this test). Also faster converting.

Edit 2: also note sharpening effects on the first and 2nd ffmpeg tests which are not included in the one with vaf filter
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 05, 2018, 09:34:22 AM
Quote from: masc on July 04, 2018, 07:28:36 PM
I get the same result you have using v0.16. This version did not completely auto correct wrong black level of your file. The blacklevel of your file is over 5000... but it should be 2048. After correcting black level all is perfect (latest repos revision does it automatically).
Yes right! Black Level = 5111 :o

@FBongcam: That MLV is cut and exported by "MLV App version 0.15 alpha". Can you share the original .MLV? (or .RAW)

I can't believe that "raw2dng" put 5111 black level into the header for 5D3. Not possible! (black = 2048, white = 15000, 5D3 defaults)

Edit: well, it's possible if original .RAW had this wrong black in the footer (I would look at that .RAW)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on July 05, 2018, 03:01:56 PM
Quote from: bouncyball on July 05, 2018, 09:34:22 AM
Yes right! Black Level = 5111 :o

@FBongcam: That MLV is cut and exported by "MLV App version 0.15 alpha". Can you share the original .MLV? (or .RAW)

I can't believe that "raw2dng" put 5111 black level into the header for 5D3. Not possible! (black = 2048, white = 15000, 5D3 defaults)

Edit: well, it's possible if original .RAW had this wrong black in the footer (I would look at that .RAW)

Yes this is from some of the first builds when raw was introduced. It worked out fine with the newer version of MLVApp though, that I compiled.

Edit: Would you like to have the original .raw file anyway?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 05, 2018, 04:21:57 PM
@dford would be nice a shot from a concrete wall,  with lots of detail :)

A question for the people working on this: since the algorithm seems to work by blending, wouldn't be better to denoise it first? I see some chroma noise on dford's shots that might affect the precision of the final blend...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on July 05, 2018, 05:08:45 PM
@50mm1200s - My name is Fort as in strong in French not Ford like the car. Been dealing with that all my life.  ::)

Lots of concrete where I live here in the Los Angeles area but a better subject would probably be bricks like this example a1ex uses:

(https://farm2.staticflickr.com/1789/41406120100_8d0f2ea2a5.jpg) (https://flic.kr/p/265VbWq)

Not many buildings like that in this concrete jungle.

Funny that it is a challenge to get aliasing artifacts to show up. I know that it is more pronounced on mv720 (5x3 sampling) than mv1080 (3x3 sampling) and pretty much absent on zoom mode and the other high resolution formats from the crop_rec module (1x1 sampling). Maybe shoot a worse case scenario in mv720 mode?

This is the first time I tried the VAF on the 700D. It does seem to do a very good job but it is rather expensive and not available for all ML supported cameras -- the EOSM for example. Doing it in software is a very attractive option even if it takes some extra post processing.

The two biggest issues when shooting video with DSLRs are aliasing artifacts and rolling shutter. Here's a challenge for this app, something to reduce the "Jello" effect. That should be doable, though trying to fix propellers, that's a bit more challenging.

(https://petapixel.com/assets/uploads/2015/11/propeller.jpg) (https://petapixel.com/2015/11/14/this-is-how-cameras-glitch-with-photos-of-propellers/)

Click on the image to read why this happens.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: mesebar2 on July 05, 2018, 05:37:18 PM
Dfort, I live in Venice, Italy, and we have nothing but canals (highlights) and bricks (aliasing).
I can confirm that on my EOSM mv 5x3 is almost unusable here, while crop_rec produces excellent results!

Please, let me know if you need any footage :)
You guys rock, and so does the work you do!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 05, 2018, 05:39:43 PM
Quote from: dfort on July 05, 2018, 05:08:45 PM
@50mm1200s - My name is Fort as in strong in French not Ford like the car. Been dealing with that all my life.  ::)

Oh, sorry about that.

Quote
The two biggest issues when shooting video with DSLRs are aliasing artifacts and rolling shutter. Here's a challenge for this app, something to reduce the "Jello" effect. That should be doable, though trying to fix propellers, that's a bit more challenging.

I think the VAF does a decent job on aliasing. About the shutter, this solution is neat:

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 05, 2018, 05:48:34 PM
Quote from: FBongcam on July 05, 2018, 03:01:56 PM
Edit: Would you like to have the original .raw file anyway?
Yeah would be nice to take a quick look at it.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on July 05, 2018, 05:53:09 PM
@50mm1200s - Well a global shutter like described in the video would be the best solution but there are software solutions that can clean up some of the minimal Jello effects of the rolling shutter we've got to deal with.

@mesebar2 - Upload a sample of an "unusable" shot of Venice and let's see what we can do with it. Preferably a very short (or trimmed) MLV.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: FBongcam on July 05, 2018, 06:28:44 PM
Quote from: bouncyball on July 05, 2018, 05:48:34 PM
Yeah would be nice to take a quick look at it.

Original .RAW file: https://www.dropbox.com/s/lbolcjtyexvvhg2/M01-2016.RAW?dl=0
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: mesebar2 on July 05, 2018, 06:41:07 PM
Quote from: dfort on July 05, 2018, 05:53:09 PM
@mesebar2 - Upload a sample of an "unusable" shot of Venice and let's see what we can do with it. Preferably a very short (or trimmed) MLV.

Will do. I think I have some shots I took around Feb/Mar, before I opted to use only crop_rec with the EOSM. Are those okay or have there been changes in the 3x5? In that case, I could shoot new ones later/tomorrow  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on July 05, 2018, 06:53:12 PM
@mesebar2 - Whatever you have should be fine. We're looking at fixing aliasing so it doesn't matter what version of ML you used as long as it works with MLV App.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 05, 2018, 07:05:18 PM
@FBongcam: Thank you, appreciate this.

Edit: it indeed has wrong black level in the footer :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: mesebar2 on July 05, 2018, 07:20:22 PM
Link to two examples: https://we.tl/QRiXYw8l8z
I realised I shot these back in October, time flies! I had just purchased this second-hand EosM and was exploring its potential. I believe I was recording in 3x5, but I would have to ask you guys to make sure I didn't just screw up!

Hope it helps :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 05, 2018, 08:42:55 PM
Quote from: mesebar2 on July 05, 2018, 07:20:22 PM
Link to two examples: https://we.tl/QRiXYw8l8z
I realised I shot these back in October, time flies! I had just purchased this second-hand EosM and was exploring its potential. I believe I was recording in 3x5, but I would have to ask you guys to make sure I didn't just screw up!

Hope it helps :)
Whohooo... thanks, that is indeed extreme! And here we also see the biggest enemy of my ffmpeg based idea: a tripod. Without movement in the picture that does not work very good.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on July 05, 2018, 09:35:28 PM
here i have a short mlv of color artifacts of trees. can anyone check if it can also be removed
https://drive.google.com/file/d/1dQHbwIzPQaaJkDtUXLwpNPc6CMQyuULa/view?usp=sharing
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on July 05, 2018, 09:40:34 PM
more files
https://drive.google.com/file/d/1a_Wci702kKCX9RvbiEIeyyn53HH1BEa_/view?usp=sharing
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 05, 2018, 09:48:51 PM
Quote from: andy kh on July 05, 2018, 09:35:28 PM
here i have a short mlv of color artifacts of trees. can anyone check if it can also be removed
https://drive.google.com/file/d/1dQHbwIzPQaaJkDtUXLwpNPc6CMQyuULa/view?usp=sharing
Moving trees is perfect for the ffmpeg filter:
without
(https://image.ibb.co/cxc0py/Bildschirmfoto1.png)
with (3 pass + unsharp mask)
(https://image.ibb.co/cMvLpy/Bildschirmfoto2.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on July 05, 2018, 09:53:04 PM
#masc  amazing. i have been struggling with this problem with my 70D.  not only the trees but it has gone from iron fenching
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on July 05, 2018, 10:00:40 PM
for me higher resolutoin is not priority as i can scale up using after effects but a clean good raw image is the top priority
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 05, 2018, 10:41:47 PM
Quote from: masc on July 05, 2018, 09:48:51 PM
Moving trees is perfect for the ffmpeg filter:
without
with (3 pass + unsharp mask)

Very cool. I think, though, the unsharp filter have has too big ratio. What about this (copied from @Danne post - ratio 3 instead of 5):

Quote
  moireeFilter.append( QString( "unsharp=3:3:0.6:3:3:0," ) );

Or maybe no unsharp at all?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on July 05, 2018, 10:54:05 PM
@mesebar2

The video2 file shows some extreme brick issues. Using the MLV App alias fixing tool I couldn't get any improvement. There are also some other issues with the shot that I couldn't fix so I went back to mlv_dump and ACR to see what I could do with it.

First of all, this is what mlv_dump -v reports:

    Frames Video: 170
...
    Res:  1728x584
...
      black_level      2047
      white_level      5586
...
      sampling        5x3 (read 1 line, skip 4, bin 3 columns)
...
     Camera Name:   'Canon EOS M'


You trimmed it down to 10 frames -- thanks for that!

There's an issue with pink highlights that affected the ML build you were using but that can be corrected. MLV App has a RAW White Level slider but I couldn't get rid of the pink highlights. Back to good old mlv_dump:

mlv_dump --white-fix=4931 -o video2_fixed.mlv video2.mlv

The fixed mlv still didn't look right in MLV App so back again:

mlv_dump --dng video2_fixed.mlv

It looks pretty good.

(https://farm1.staticflickr.com/845/43222090731_565b3791ec.jpg) (https://flic.kr/p/28RovJT)

Notice the moiré pattern on the bricks:

(https://farm2.staticflickr.com/1766/43222091591_0858e0a6ed.jpg) (https://flic.kr/p/28RovZH)

One of the "interesting" things I noticed when running the "Smooth aliasing" scripts is that when using the 1 pass option it created 8 TIFF files and with the 3 pass option it saved only 4 files. Ran a 3 pass option on a much longer clip and it chopped off 6 frames so it looks like you'll loose a few frames when using the "Smooth aliasing" options.

[EDIT]
@masc - So the reason we can't fix the bricks is because there is no motion? This is also an issue when trying to shoot a "super-resolution" shot. You need some movement or it won't work. I made a post about this a while back, Large image, low fps vs. Small image, high fps (https://www.magiclantern.fm/forum/index.php?topic=15306.0).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 05, 2018, 10:58:40 PM
I think minimum when using smooth aliasing option is around 10 frames by the way...
@50mm1200s
Yeah, unsharp setting could be optional. Remember it's all just a starting point atm...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: mesebar2 on July 06, 2018, 12:15:53 AM
I'm happy the clip I provided had the kind of problems you guys were looking for :)

@dfort
That was the first clip I ever recorded with the camera, and when I saw the moire on the bricks I told myself it would be best to use it in crop_rec from that moment on

Feel free to let me know if I can help in other ways, that is recording clips... Or telling you about the best places where to eat and drink in Venice ;D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 06, 2018, 08:47:40 AM
@dfort, @bouncyball
Is it possible to transcode pixel coordinates into a fpm list? Let's say you create your own "dcraw" coordinates and then needs them working with fpm lists in mlvfs etc? Maybe doable through fpm utility?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 06, 2018, 10:31:57 AM
Quote from: dfort on July 05, 2018, 10:54:05 PM
There's an issue with pink highlights that affected the ML build you were using but that can be corrected. MLV App has a RAW White Level slider but I couldn't get rid of the pink highlights.
Really? No such problem for me. Just lower White level (while RAW Correction is enabled) and enable Highlight Reconstruction. Pink highlights are gone...
(https://image.ibb.co/nORuXJ/Bildschirmfoto.png)

Quote from: dfort on July 05, 2018, 10:54:05 PM
One of the "interesting" things I noticed when running the "Smooth aliasing" scripts is that when using the 1 pass option it created 8 TIFF files and with the 3 pass option it saved only 4 files. Ran a 3 pass option on a much longer clip and it chopped off 6 frames so it looks like you'll loose a few frames when using the "Smooth aliasing" options.
Japp... but I can't tell you yet where the "lost" frames are and why they get lost. But had that issue as well. It seems each ffmpeg filter call cuts 2 frames.

Quote from: dfort on July 05, 2018, 10:54:05 PM
@masc - So the reason we can't fix the bricks is because there is no motion? This is also an issue when trying to shoot a "super-resolution" shot. You need some movement or it won't work. I made a post about this a while back, Large image, low fps vs. Small image, high fps.
My filter idea works in a similar way as a motion blur, but without really bluring. So if there is no motion, nothing will happen.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 06, 2018, 12:45:58 PM
I like to announce that v0.17 is out now:

-fixes for dual iso (processing and export)
-new highlight reconstruction for dual iso clips
-added 1D/3D LUT (.cube) support
-added sliders for RAW black and white level (& export corrected MLV / DNG)
-double click sliders for default value
-added white balance picker 🎉 (for grey and skin tone)
-added smoothing filter via ffmpeg export (cleans aliasing artifacts)
-added uncompressed AVI V210 export codec

Minimum OS:
-OSX 10.8.5 Mountain Lion
-Windows 7
-Ubuntu 14.04 LTS

https://github.com/ilia3101/MLV-App/releases/tag/QTv0.17alpha
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 06, 2018, 01:19:39 PM
Quote from: Danne on July 06, 2018, 08:47:40 AM
@dfort, @bouncyball
Is it possible to transcode pixel coordinates into a fpm list? Let's say you create your own "dcraw" coordinates and then needs them working with fpm lists in mlvfs etc? Maybe doable through fpm utility?
I don't quite understand your point

Give me sample :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 06, 2018, 02:00:20 PM
Convert these?
https://bitbucket.org/Dannephoto/magic-lantern/downloads/pixelmaps_2k_3k_4k_100D.zip
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: timbytheriver on July 06, 2018, 02:25:06 PM
Hi

Just testing:

v0.17 freezes up (App not responding / beachball) with 3-pass anti-alias when export to .mov reaches 100%  Resulting .mov file is unplayable.

v0.16 Was working fine on Export.

Mac 10.11.6
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 06, 2018, 06:40:39 PM
Quote from: Danne on July 06, 2018, 02:00:20 PM
Convert these?
Ah, what software generated this? Our previous good old mlv_dump? ;)

In this case in order to convert them we need the frame resolution, raw buffer resolution and panpos or offset x,y.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 06, 2018, 09:52:33 PM
Created in imageJ and the converted to a formatto be used with your version of mlv_dump.
Well, let'say I provide above info, could this transcoding be automated? I also assume the map files should be built from the raw buffer resolution rather than from frame resolution?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: GianlucaM83 on July 06, 2018, 10:49:39 PM
Quote from: timbytheriver on July 06, 2018, 02:25:06 PM
Hi
Just testing:
v0.17 freezes up (App not responding / beachball) with 3-pass anti-alias when export to .mov reaches 100%  Resulting .mov file is unplayable.
v0.16 Was working fine on Export.
Mac 10.11.6
Hi!
Same here but on Windows 10 x64.
If I export in Appleprores 4444 with smooth aliasing 3 pass + unsharp mask. trying to import the file into adobe premiere cc 2018 as the error message "file has no audio or video streams" keeps appearing.
No problem at all with "smooth aliasing" option turned off.
Do you have any suggestions?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 06, 2018, 11:41:33 PM
Quote from: timbytheriver on July 06, 2018, 02:25:06 PM
Hi

Just testing:

v0.17 freezes up (App not responding / beachball) with 3-pass anti-alias when export to .mov reaches 100%  Resulting .mov file is unplayable.

v0.16 Was working fine on Export.

Mac 10.11.6

Quote from: GianlucaM83 on July 06, 2018, 10:49:39 PM
Hi!
Same here but on Windows 10 x64.
If I export in Appleprores 4444 with smooth aliasing 3 pass + unsharp mask. trying to import the file into adobe premiere cc 2018 as the error message "file has no audio or video streams" keeps appearing.
No problem at all with "smooth aliasing" option turned off.
Do you have any suggestions?

3-pass anti-alias was not existant in offical v0.16. Have you been waiting until MLVApp brought "Export finished"? I guess not. When process bar is at 100%, MLVApp rendering is done and ffmpeg filter starts its 3pass work - it is not possible to measure the progress here, thats why you see the 100% a very long time. For a 10 sec clip you'll see the 100% for 5-20 minutes until it is done, depending on your hardware. If you stop export before, file is not playable.
Other suggestion: your clip was smaller than 10 frames - as posted some posts above about 10frames is minimum to get a working export with 3-pass anti-alias.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on July 07, 2018, 12:35:01 AM
Quote from: masc on July 06, 2018, 11:41:33 PM
3-pass anti-alias was not existant in offical v0.16. Have you been waiting until MLVApp brought "Export finished"? I guess not. When process bar is at 100%, MLVApp rendering is done and ffmpeg filter starts its 3pass work - it is not possible to measure the progress here,...

Yes this is true I thought in the first the App wasn't responding but after couple of minuets it finished. So what about a message telling us when reaching 100%: "Applying 3-pass anti-alias. Please wait..." or something like that .
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bakersdozen on July 07, 2018, 04:57:25 AM
Thanks for the update! LUT support is a game changer  :)
Is there anyway to bypass adding a curve at all? Ie. to be able use a LUT designed for straight out of camera raw as in Hunters LUT or EOSHD 5D3 LUT? These were primarily designed for use in resolve directly on the CDNGs. It would be awesome to be able to apply these within MlvApp without having any curve applied prior and going straight to ProRes export. Is this a possibility?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: reddeercity on July 07, 2018, 06:17:26 AM
Quote from: masc on July 06, 2018, 12:45:58 PM
I like to announce that v0.17 is out now:
.........
-added uncompressed AVI V210 export codec
why a use a very chunky AVI codec (1.5Gb/s) ?
IMO there's far better open source  AVI codec  out there ,  it's nearly impossible be to work with .
(when i use to edit video on a pc platform (before i wised up and fell in to the MAC world of video) i use to use
V210 plus others , but it was very painful . I did find a very good AVI open source codec that uses wavelet compression .
similar to QT Apple(not ffmeg) Prores 4444XQ and the old Cineform . The great thing is it can encode to 12bit as will as good old 10bit .
That always been the problem with  AVI ,  limited to either 8bit or 10bit  no 12 or 16bit  :(
the codec is called  "zoe-lossless-codec" to download codec or source code go to https://github.com/edanvoye/zoe-lossless-codec , supports 32 & 64 bit windows
looks like it's based on Huffman codec  the last commit was to add 12bit support see link Version 1.1.1 - Add packed 10 bit grayscale and 12 bit grayscale (https://github.com/edanvoye/zoe-lossless-codec/commit/6c1eb25ab1bc9c26ed99ee8a4319db5554a9087d#diff-8d01425231e39af3b8e6ab2f1f9f1f1bR406)
Anyways it's just my 2 cents worth
:)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 07, 2018, 09:24:20 AM
First of all, CONGRATULATIONS to Bouncyball, Masc and Ilia3101 for this wonderful ML tool !!!

My very first and brief impressions on the v.017:
-------------------------------------------------------
I used som 2320x1304 (16:9) footage from the 100D for the tests

1) White balance tool - a long awaited feature that works very well;
2) Highlight reconstruction does a very good job now.  Not only it removes the pink cast of blown up highlight areas but also reconstructs quite a bit of detail.  Extremely useful!
3) My favorite one is the MLV export.  Setting Cut-in and -out points, cleaning the focus dots and save as compressed MLV is extremely useful.  The resulting files open nicely in Resolve via MLVFS.

Keep testing, it's a lot of FUN !
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: GianlucaM83 on July 07, 2018, 09:30:18 AM
Quote from: masc on July 06, 2018, 11:41:33 PM
3-pass anti-alias was not existant in offical v0.16. Have you been waiting until MLVApp brought "Export finished"? I guess not. When process bar is at 100%, MLVApp rendering is done and ffmpeg filter starts its 3pass work - it is not possible to measure the progress here, thats why you see the 100% a very long time. For a 10 sec clip you'll see the 100% for 5-20 minutes until it is done, depending on your hardware. If you stop export before, file is not playable.
Other suggestion: your clip was smaller than 10 frames - as posted some posts above about 10frames is minimum to get a working export with 3-pass anti-alias.

Thanks for the clarifications.
currently I'm trying with a video that contains 659 frames
I wait until the message " export is ready" appears. this advice appears after only a few seconds that the bar has reached 100%. the duration of the complete export process is about four minutes for entire video.
maybe a record video could explain better than my bad english:
in this video there is the whole export procedure. I exported only 100 frames of not edited video, to speed up the process.
https://youtu.be/b6iqG3AXDxI (https://youtu.be/b6iqG3AXDxI)
Thx for help! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 07, 2018, 09:40:28 AM
Quote from: Danne on July 06, 2018, 09:52:33 PM
Well, let'say I provide above info, could this transcoding be automated?
Well, I think yes. I have to take a deeper look.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 07, 2018, 09:44:13 AM
Quote from: reddeercity on July 07, 2018, 06:17:26 AM
why a use a very chunky AVI codec (1.5Gb/s) ?
It was just a quick workaround to get rid of compatibility issues with NLEs. I would prefer to have cineform codec for avi.

Quote from: reddeercity on July 07, 2018, 06:17:26 AM
the codec is called  "zoe-lossless-codec" to download codec or source code go to https://github.com/edanvoye/zoe-lossless-codec , supports 32 & 64 bit windows
Interesting. Is it fast enough?

I've been using UT Video under windows with very good success.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: timbytheriver on July 07, 2018, 09:52:07 AM
Quote from: masc on July 06, 2018, 11:41:33 PM
For a 10 sec clip you'll see the 100% for 5-20 minutes until it is done, depending on your hardware. If you stop export before, file is not playable.
Thanks masc. I understand. But the app actually became non-responsive during the 100% message – and locked up. Will try another export and wait longer.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 07, 2018, 10:06:25 AM
Quote from: IDA_ML on July 07, 2018, 09:24:20 AM
3) My favorite one is the MLV export.  Setting Cut-in and -out points, cleaning the focus dots and save as compressed MLV is extremely useful.  The resulting files open nicely in Resolve via MLVFS.
I think you did not thoroughly check dots on exported compressed clip. During MLV export (compressed or uncompressed) there is none of raw processing is done, it is intended to preserve original MLV raw data as is without changes.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bakersdozen on July 07, 2018, 10:18:17 AM
Quote from: bouncyball on July 07, 2018, 10:06:25 AM
it is intended to preserve original MLV raw data as is without changes.

I was also wondering if this was the case. Any idea of my previous question, which is a similar situation?ie. Applying the raw processing just without the curve during export to ProRes or other video codec?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 07, 2018, 11:08:09 AM
Quote from: bakersdozen on July 07, 2018, 10:18:17 AM
Any idea of my previous question, which is a similar situation?
It is not the same situation. When I'm talking about RAW processing I mean altering the RAW data itself by correcting focus or bad pixels and not debayering process and after that RGB data manipulation by curves etc.

Quote from: bakersdozen on July 07, 2018, 10:18:17 AM
Applying the raw processing just without the curve?
Well, I know nothing about LUTs you mentioned and do not know what data input they require. When you say it applied to DNGs we need to know which color space it initially was after debayer. E.g. linear or most probably black magic's own log color space (BMD Film) which we currently do not support in MLV App.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bakersdozen on July 07, 2018, 11:20:02 AM
Thanks bouncyball. Further research tells me it is BMD film colorspsce and gamma.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 07, 2018, 02:46:59 PM
Quote from: bouncyball on July 07, 2018, 10:06:25 AM
I think you did not thoroughly check dots on exported compressed clip. During MLV export (compressed or uncompressed) there is none of raw processing is done, it is intended to preserve original MLV raw data as is without changes.

Well, you certainly are right.  I tested just the 2520x1304 resolution and am happy to say that I do not see any focus dots.  Probably, MLVFS killed dem prior to opening in DaVinci Resolve.  Would it be possible to have MLVApp kill the focus dots with compressed MLV export?  No further RAW processing, just the focus dots.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 07, 2018, 03:17:54 PM
Yes it is possible as any other low level raw processing during MLV export. But IMHO it is pointless, especially focus dot fixing, which is so fast that has nearly no impact on performance. With MLVFS you just have to use the appropriate .fpm, and that's all. I'm too lazy to dig into and modify MLVFS code again for automatic focus pixel fixing ;).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 07, 2018, 04:29:50 PM
Quote from: bouncyball on July 07, 2018, 03:17:54 PM
Yes it is possible as any other low level raw processing during MLV export. But IMHO it is pointless, especially focus dot fixing, which is so fast that has nearly no impact on performance. With MLVFS you just have to use the appropriate .fpm, and that's all. I'm too lazy to dig into and modify MLVFS code again for automatic focus pixel fixing ;).

As far as the focus pixels are concerned, you may be  right - we have MLVFS and it cleans them very well.  But, Dual ISO is a totally different story.  MLVFS does not convert Dual ISO files.  If that could be done in MLVApp right on the Dual ISO MLV file, along with the Cut-in and -out operation and subsequent compressed MLV export, that would be extremely useful.

I have been playing a lot with Dual ISO 100/800 at 2520x1304@18fps and processing with MLVApp v.017 and quality is fantastic!  I will upload a sample soon.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 07, 2018, 05:01:39 PM
Quote from: IDA_ML on July 07, 2018, 04:29:50 PM
But, Dual ISO is a totally different story.
I agree it IS ;) in lot of different ways, good and bad...

Quote from: IDA_ML on July 07, 2018, 04:29:50 PM
MLVFS does not convert Dual ISO files.
Ironically ( yeah this is really funny part ;) ), MLV App based on MLVFS dual iso source code! Which is on the other hand based on a1ex's cr2hdr sources with some specific adaptation to MLVFS idea.

Actually MLVFS was the first app to offer on the fly conversion of dual iso MLV to DNG. We just adapted this code for latest low bit uncompressed and lossless dual iso MLVs.

Quote from: IDA_ML on July 07, 2018, 04:29:50 PM
If that could be done in MLVApp right on the Dual ISO MLV file, along with the Cut-in and -out operation and subsequent compressed MLV export, that would be extremely useful.
Why don't you just export processed cDNGs and use them in resolve?

BTW MLV format been invented not for archiving purpose but for acquisition :) and keeping raw data intact IMHO is the most correct approach to save valuable original assets for future, better processing tools.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 07, 2018, 05:30:06 PM
Quote from: bouncyball on July 07, 2018, 05:01:39 PM
... keeping raw data intact IMHO is the most correct approach to save valuable original assets for future, better processing tools.

Absolutely!  This is the reason why I want to keep the MLV files, compressed, clean from focus dots, properly cut and Dual ISO converted.  It would be great if all this could be done in one application that is as good and advanced as MLVApp and does not require the computer to be very powerful.  Tools for processing MLV/RAW files get better and better and it is much wiser to keep the MLVs rather than some other lossy compressed format that requires complex grading.  Moreover, I am not good at grading and to me the RAW workflow in Resolve (or ACR) is the simliest and easiest.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 07, 2018, 05:47:03 PM
Quote from: IDA_ML on July 07, 2018, 05:30:06 PM
Absolutely!  This is the reason why I want to keep the MLV files, compressed, clean from focus dots, properly cut and Dual ISO converted.
I meant there also can be new, better dual iso processor or dot and stripe remover :) and if you delete vanilla MLVs there won't be the way back...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on July 07, 2018, 05:49:17 PM
Quote from: Danne on July 06, 2018, 08:47:40 AM
@dfort, @bouncyball
Is it possible to transcode pixel coordinates into a fpm list? Let's say you create your own "dcraw" coordinates and then needs them working with fpm lists in mlvfs etc? Maybe doable through fpm utility?

Lots of activity here -- trying to keep up.

The main differences between a dcraw "badpixels" file and our fpm format is that dcraw includes the "UNIX time of death" and fpm needs to have either a header or the filename must include the hex code for the camera model and either the full raw buffer size or the image size. Note that the dcraw developer has documented the "badpixels" format (https://www.cybercom.net/~dcoffin/dcraw/dcraw.1.html) but fpm is mostly undocumented.

If you add the metadata to the files you uploaded they might work without any further processing. Depending on the app you're using the trailing zeros are ignored. We just aren't interested in "UNIX time of death" for the pixels that we're fixing.

By the way, I'm all for fixing the focus pixels when creating the DNG files but prefer not to mess around with modifying the original MLV files. They should be archived the way they were saved in camera because some day we'll have better MLV processing tools and may want to go back to our camera originals.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: dfort on July 07, 2018, 06:39:53 PM
Quote from: Danne on July 06, 2018, 08:47:40 AM
Is it possible to transcode pixel coordinates into a fpm list?

Just thought of something. The dcraw "badpixels" format files are formatted to fit the final image size while fpm files usually map the full raw buffer. You should be able to write a script that takes the Crop/Pan values along with the raw buffer size that is in the MLV metadata and re-map the coordinates so they line up with the full raw buffer.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 07, 2018, 06:48:39 PM
Quote from: GianlucaM83 on July 07, 2018, 09:30:18 AM
Thanks for the clarifications.
currently I'm trying with a video that contains 659 frames
I wait until the message " export is ready" appears. this advice appears after only a few seconds that the bar has reached 100%. the duration of the complete export process is about four minutes for entire video.
maybe a record video could explain better than my bad english:
in this video there is the whole export procedure. I exported only 100 frames of not edited video, to speed up the process.
https://youtu.be/b6iqG3AXDxI (https://youtu.be/b6iqG3AXDxI)
Thx for help! :)
Hm... what is the size of the file? Can any other application play it (VLC for example)? Does it work better without aliasing filter?

Quote from: reddeercity on July 07, 2018, 06:17:26 AM
why a use a very chunky AVI codec (1.5Gb/s) ?
IMO there's far better open source  AVI codec  out there ,  it's nearly impossible be to work with .
Japp... I think the same. Someone had a wish to have that in MLVApp and it was easy to add... this guy will have a reason to use it. ;)

Quote from: reddeercity on July 07, 2018, 06:17:26 AM
the codec is called  "zoe-lossless-codec" to download codec or source code go to https://github.com/edanvoye/zoe-lossless-codec , supports 32 & 64 bit windows
Hm... that's coded for Visual Studio. Unfortunately that is not very compatible to MinGW compiler (we use), if I understood right. I think we would have to "translate" some classes to Standard C/C++. Then it would be also cross platform. But that is much work!

Quote from: bakersdozen on July 07, 2018, 10:18:17 AM
Applying the raw processing just without the curve during export to ProRes or other video codec?
We could completely switch off processing... then you'll have a dark greenish picture and you nearly can't see anything (I made some performance tests in this way)... I don't think that is a good idea to export that.
I also would like to add BMD Film color space... but I don't find some useful specs about. I would need a formula from linear to BMD Film.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 07, 2018, 07:09:49 PM
Quote from: masc on July 07, 2018, 06:48:39 PM
I also would like to add BMD Film color space... but I don't find some useful specs about. I would need a formula from linear to BMD Film.
Yup, exactly. Besides there are several flavors of BMD Film for different sensors BM uses for their cameras.

We should ask Andy600 for help ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on July 07, 2018, 08:27:54 PM
Quote from: masc on July 07, 2018, 06:48:39 PM
Someone had a wish to have that in MLVApp and it was easy to add... this guy will have a reason to use it. ;)
Yes, he will... ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 07, 2018, 08:33:53 PM
Quote from: escho on July 07, 2018, 08:27:54 PM
Yes, he will... ;)
Hehe, for you we had the 8bit rawvideo avi... do you use now 10bit V210 avi as well for your astro pictures?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on July 07, 2018, 09:42:03 PM
Quote from: masc on July 07, 2018, 08:33:53 PM
Hehe, for you we had the 8bit rawvideo avi... do you use now 10bit V210 avi as well for your astro pictures?
Oh, I thought, you talked about 8bit rawvideo. I should read more carefully  ;D
I just finished my project in porting my astrostuff from windows to openSUSE ( https://sternenkarten.com/kstars-libindi-astrometry-net-on-opensuse/ ) and only had a quick look here into the mlvapp-thread :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 07, 2018, 10:06:05 PM
As I promised, I have prepared a short 100D video that demonstrates the advantage of filming high-contrast scenes  with Dual ISO.  For this purpose, the new 2,5-crop recording mode on the Rebels and EOS-M at 18fps frame rate works very well since there is no aliasing and moire whatsoever in this mode and also in the 3 and 4K modes.  Feel free to download the video in the next 7 days from here:

https://we.tl/GhLdeiloLw

While evaluating the comparison between the Normal and Dual ISO shots, please pay attention to the noise in the darkest areas of the shots (TV-set), as well as the detail recovery at the brightest ones (the curtains).  I have to say, I am amazed at how well version 017 of MLVApp handles these very difficult shots.  Except for some flashing of a pink ribbon in the window area, (probably a glitch in the highlight recovery function), video is very clean, with no evidence of focus dots or other artefacts and I am totally satisfied with the results. Again, CONGRATULATIONS to all developers involved in this remarkable achievement!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ArcziPL on July 07, 2018, 11:31:45 PM
Hi,

each of my RAW videos recorded with 700D or M comes out in MLVApp very bleak, faint. Interesting fact: they always open with default white balance of 6000K and using the white balance picker on gray or skintone areas changes the setting to the range of 9k of 10k (and still looking crappy), despite recorded in normal dayligt, so there is definitely something wrong. I don't see any simple way to make it look right in MLVApp using the standard sliders.

Some sample MLVs downloaded from this forum do not show such problem but they were from another camera models.

My MLVs opened in Fast Cinema DNG or Adobe Camera RAW (single DNGs extracted using MLVFS) look normal.

I'm recording using mlv_lite from crop_rec_4k_mlv_snd from https://builds.magiclantern.fm/experiments.html using 5x zoom, mostly 12-bit lossless but in full frame mode it was the same. MLVApp tested 0.15, 0.16, 0.17. All are same.

Where does the problem lay?

MLVApp with default settings:
(https://s25.postimg.cc/v4w6kjosr/mlvapp_faint.jpg) (https://postimg.cc/image/v4w6kjosr/)

Fast Cinema DNG with default settings:
(https://s25.postimg.cc/glp1j4ny3/fastcinemadng_ok.jpg) (https://postimg.cc/image/glp1j4ny3/)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 07, 2018, 11:39:31 PM
@ArcziPL: when opening a MLV it is very normal if colors a bleak. WB at 6000K is also normal when you recorded in auto mode. With WB picker I had no problem for all files I got from users, also no problem for EOS M and 700D. So best would be you upload a sample file (you can shorten it before to some frames). In different programs it will look different - sure.

@IDA_ML: thanks! Looks great! Could you provide the clip with the blinking highlight? Maybe my chosen recovery-range is to small...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ArcziPL on July 08, 2018, 12:27:04 AM
Quote from: masc on July 07, 2018, 11:39:31 PM
@ArcziPL: when opening a MLV it is very normal if colors a bleak. WB at 6000K is also normal when you recorded in auto mode. With WB picker I had no problem for all files I got from users, also no problem for EOS M and 700D. So best would be you upload a sample file (you can shorten it before to some frames). In different programs it will look different - sure.
Thanks masc, this helped already. I didn't expect having to touch most of the sliders to make it look similar to what other programs usually default to. But after doing so, indeed, the results are VERY GOOD!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: feureau on July 08, 2018, 04:05:36 AM
MLV.App.v0.17.alpha.Win64.static keeps crashing when batch exporting with Dark Frame Subtraction enabled.

Steps to reproduce:

Import multiple MLVs into Session, enable DarkFrame Subtraction Ext with pre-prepared MLVs for each file, batch export all MLVs as prores.

First MLV will complete render just fine, then MLVApp will crash on second or third MLV.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 08, 2018, 08:41:53 AM
Quote from: ArcziPL on July 07, 2018, 11:31:45 PM
each of my RAW videos recorded with 700D or M comes out in MLVApp very bleak,
In current MLV App by default saturation is quite low. So crank it up and everything's gonna be fine :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 08, 2018, 08:44:56 AM
Quote from: feureau on July 08, 2018, 04:05:36 AM
First MLV will complete render just fine, then MLVApp will crash on second or third MLV.
Is it crashing if you change the order of clips?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 08, 2018, 10:01:09 AM
Quote from: feureau on July 08, 2018, 04:05:36 AM
MLV.App.v0.17.alpha.Win64.static keeps crashing when batch exporting with Dark Frame Subtraction enabled.

Steps to reproduce:

Import multiple MLVs into Session, enable DarkFrame Subtraction Ext with pre-prepared MLVs for each file, batch export all MLVs as prores.

First MLV will complete render just fine, then MLVApp will crash on second or third MLV.
Don't get it reproduced. Can do this with 20 clips and more - no crash, all works fine. Would really like to know what causes this on your PC with your clips... :(
Do you have some coding skills? I think best would be to run MLVApp via debugger on your PC. The debugger tells us in which line it crashes.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 08, 2018, 11:19:47 AM
Quote from: masc on July 08, 2018, 10:01:09 AM
Do you have some coding skills? I think best would be to run MLVApp via debugger on your PC. The debugger tells us in which line it crashes.
@masc: +1

Edit: BTW congrats! you've become a Hero Member :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 08, 2018, 11:26:03 AM
Quote from: bouncyball on July 08, 2018, 11:19:47 AM
Edit: BTW congrats! you've become a Hero Member :D
LOL... yeah... thanks. In 5 days it is one year ago, when I started programming the GUI with Ilias processing code! ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 08, 2018, 11:27:03 AM
Quote from: masc on July 07, 2018, 11:39:31 PM
@IDA_ML: thanks! Looks great! Could you provide the clip with the blinking highlight? Maybe my chosen recovery-range is to small...

Hello Masc,

Here is one of my 100D test clips that has the pink highlight glitch in the window area after processing with v.017.  All you need to do is open it in MLVApp, activate Dual ISO, make corrections to your liking and export it in H.265.  Then, you should be able to see the pink area. 

https://we.tl/EMglnJjFZO

Keep up this excellent work!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 08, 2018, 11:29:26 AM
Quote from: masc on July 08, 2018, 11:26:03 AM
LOL... yeah... thanks. In 5 days it is one year ago, when I started programming the GUI with Ilias processing code! ;)
Hm... we must celebrate "QT App" birthday then :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 08, 2018, 11:35:50 AM
Count me in  8)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 08, 2018, 12:30:01 PM
Quote from: IDA_ML on July 08, 2018, 11:27:03 AM
Hello Masc,

Here is one of my 100D test clips that has the pink highlight glitch in the window area after processing with v.017.  All you need to do is open it in MLVApp, activate Dual ISO, make corrections to your liking and export it in H.265.  Then, you should be able to see the pink area. 
Thanks @IDA_ML. This clip is perfect for debuggin... I get other effects on rendering than you... depending on how many cores of the processor are rendering (on dual core it does not blink, but real pink color areas are filtered). I think I have still have to change some things in the highlight recovery algrorithm for dual iso... that is so tricky...

@bouncyball & Danne... 8) do we need some birthday cake? 🎂 🍰 :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: feureau on July 08, 2018, 01:04:43 PM
Quote from: bouncyball on July 08, 2018, 08:44:56 AM
Is it crashing if you change the order of clips?

I tried reimporting the clips with different order but it still happens.

Quote from: masc on July 08, 2018, 10:01:09 AM
Don't get it reproduced. Can do this with 20 clips and more - no crash, all works fine. Would really like to know what causes this on your PC with your clips... :(
Do you have some coding skills? I think best would be to run MLVApp via debugger on your PC. The debugger tells us in which line it crashes.

I never used QT before so I'm not sure if I can get anything useful, but let me see if I can set it up.

Anyway, is it possible that it's caused by having the .mlv darkframes in a separate drive? (regular spinning disk HDD, not SSD)

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 08, 2018, 01:25:29 PM
Quote from: feureau on July 08, 2018, 01:04:43 PM
I tried reimporting the clips with different order but it still happens.

I never used QT before so I'm not sure if I can get anything useful, but let me see if I can set it up.

Anyway, is it possible that it's caused by having the .mlv darkframes in a separate drive? (regular spinning disk HDD, not SSD)
I can't tell how to setup a 64bit version. 32bit (MinGW) is just downloading and installing. Download repos, open .pro in QtCreator, select Debug toolchain, build, start debugging. Then do what you always do - BAMM - and the debugger should show the line.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on July 08, 2018, 02:30:31 PM
Quote from: masc on July 08, 2018, 11:26:03 AM
LOL... yeah... thanks. In 5 days it is one year ago, when I started programming the GUI with Ilias processing code! ;)
Quote from: bouncyball on July 08, 2018, 11:29:26 AM
Hm... we must celebrate "QT App" birthday then :D

thanks for the reminder :)

and wow... a year 😍

@bouncyball @masc also why do we still call it alpha? I would say it's at/past beta stability already ;) Can we soon make a 1.0 release?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 08, 2018, 04:10:24 PM
Quote from: masc on July 08, 2018, 12:30:01 PM
@bouncyball & Danne... 8) do we need some birthday cake? 🎂 🍰 :D
Yes that is perfect: biiig cake (for everybody on a party) with one candle :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 08, 2018, 04:11:24 PM
Quote from: Ilia3101 on July 08, 2018, 02:30:31 PM
@bouncyball @masc also why do we still call it alpha? I would say it's at/past beta stability already ;) Can we soon make a 1.0 release?
That is the good question! Can we? :) And call it anniversary release?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 08, 2018, 04:26:16 PM
Release it already. I want plenty cream on my cake  :P.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 08, 2018, 04:50:27 PM
@Danne: Hey maan, you are such a Creamaholic :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on July 08, 2018, 05:46:39 PM
Yes let's do an anniversary release. I hope to get a small/big processing improvement done in time.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 08, 2018, 06:04:37 PM
Quote from: Ilia3101 on July 08, 2018, 05:46:39 PM
Yes let's do an anniversary release. I hope to get a small/big processing improvement done in time.

Do you mean to say that MLVApp is going to render faster?  Right now it renders painfully slow but it does the job. Recently, I let it render about 30 GB of MLV footage on a 2 GHz Core 2 Duo laptop overnight and when I woke up on the next morning it hadn't finished yet.  So, a speed improvement would be more than welcome!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on July 08, 2018, 06:15:25 PM
Quote from: IDA_ML on July 08, 2018, 06:04:37 PM
Do you mean to say that MLVApp is going to render faster?  Right now it renders painfully slow but it does the job. Recently, I let it render about 30 GB of MLV footage on a 2 GHz Core 2 Duo laptop overnight and when I woke up on the next morning it hadn't finished yet.  So, a speed improvement would be more than welcome!

Are you using the "RAW Correction" tab? If so, which ones. Focus pixels, stripes etc... sometimes they take the longest

Sadly this improvement isn't speed, I could do openCL but it seems like there's a lot of stuff going on in processing now and getting it to work together might be a bit of a struggle (until big rewrite, if that happens ever).

I once rendered a 6 minute video with MLV App, that took 37 minutes. Yes it's quite slow, not sure what slows it down the most, encoding, processing or corrections.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 08, 2018, 08:55:22 PM
Ilia,

Yes, I use the "RAW Correction" functions a lot:  focus pixels, bad pixels and Dual ISO lately.  But I also apply highlight recovery to every overexposed clip, sometimes LUTs as well as sharpening and chroma smoothing to the footage.  The latter cleans chroma noise nicely. In addition to that I apply all usual basic corrections to the clips.  Finally, I export to ProRes and the clips are ready for assembling the final movie.  This workflow works well for me, especialy on my old laptop that does not support DaVinci Resolve and that I use all the time when traveling. I often use Filmora for the final cut and it works very well on it.   I only wish, MLVApp export was faster.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kanakori on July 09, 2018, 03:29:45 PM
Hi guys! Can someone explain what the deflicker target option is? Does it remove flicker and what are the best values to use..
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: VGT on July 09, 2018, 04:09:21 PM
Hi, guys!

Just downloaded the new version of the App: looks great, so many new features, - thanks a lot for updating the great application!
My question: I use 7D and the vertical banding noise in the shadows is driving me mad...(((
I tried to fix it with the "pattern noise" function in MLV App. It changed the view of noise a little, it became more pleasant, but the new ugly artifacts appeared, making the footage unusable.
Also tried to use dark frame subtraction, loaded the .MLV file shot with the cap on the lens - no visible changes at all.
Other options in the "RAW correction" tab don't help with banding noise either.

Question 1: Can anyone give me an advice how to fix 7D BANDING, using the App?
And  2: How should I use Dark frame subtraction correctly - where to read about it?? - should it be a still image or video and how to guess it works or not?
Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 09, 2018, 04:38:51 PM
Try around 3000-5000. @dmilligan created this first in mlvfs...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 09, 2018, 05:32:36 PM
Quote from: Kanakori on July 09, 2018, 03:29:45 PM
Hi guys! Can someone explain what the deflicker target option is? Does it remove flicker and what are the best values to use..
It works only in one case: IF you export DNGs and IF the tag which inserted into dng header correctly interpreted by the app which loads and processes DNGs.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on July 09, 2018, 10:19:38 PM
Quote from: IDA_ML on July 08, 2018, 08:55:22 PM
Yes, I use the "RAW Correction" functions a lot:  focus pixels, bad pixels and Dual ISO lately.

Some of those algorithms, especially dual ISO will just be slow, they are very complex(also good btw), and I wouldn't even go near them in code as I don't know how they work or how I could make them faster.
Unfortunately it might just be a fact of life that some are slow :(
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 09, 2018, 10:49:48 PM
Quote from: IDA_ML on July 08, 2018, 08:55:22 PM
Yes, I use the "RAW Correction" functions a lot:  focus pixels, bad pixels and Dual ISO lately.  But I also apply highlight recovery to every overexposed clip, sometimes LUTs as well as sharpening and chroma smoothing to the footage.  The latter cleans chroma noise nicely. ...  I only wish, MLVApp export was faster.

Quote from: Ilia3101 on July 09, 2018, 10:19:38 PM
Some of those algorithms, especially dual ISO will just be slow, they are very complex(also good btw), and I wouldn't even go near them in code as I don't know how they work or how I could make them faster.
Unfortunately it might just be a fact of life that some are slow :(

Yapp, unfortunately dual iso and most of the RAW Corrections are written for single core only atm and I also don't really understand how it works. For most RAW Corrections that is no big deal because they are fast. But dual iso is another story...
All the processing and debayer stuff is multithreaded already... so this part is not sooo slow - we got >20fps on i7 machines for "normal" clips. The good thing of the slower non-OpenCL SW architecture is: it works on nearly every computer instead of many other programs. First OpenCL tests were working on bouncyballs computer, but I got only crashes because I don't have such hardware :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 10, 2018, 10:15:22 AM
@VGT

Quote from: VGT on July 09, 2018, 04:09:21 PM
Question 1: Can anyone give me an advice how to fix 7D BANDING, using the App?
And  2: How should I use Dark frame subtraction correctly - where to read about it?? - should it be a still image or video and how to guess it works or not?
Answer 1: Upload sample MLV and cap on MLV somewhere and we will see what can be done. However our mileage can vary depending on footage.
Answer 2: Record MLV with cap on (~150-250frames will be enough), after that it have to be averaged. Import this MLV as usual clip (not as dark frame) into MLV App then go to export settings and select Codec MLV with option combo box set to Averaged Frame.

(https://thumb.ibb.co/djW2Bo/Screenshot_from_2018_07_10_12_22_09.png) (https://ibb.co/djW2Bo)

Export MLV. This will give you 1 frame averaged MLV which now can be loaded as dark frame in appropriate RAW correction section.

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 10, 2018, 10:59:59 AM
Hello Masc, Bouncyball and Ilia3101,

Thanks for this clarification.  I understand that Dual ISO is a processor intensive operation.  I have performed a lot of tests with shooting and MLVApp-processing Dual ISO files from the 100D and have to say, I am really amazed at the quality with this technique.  If properly exposed to the right, the dynamic range is drastically improved with almost no perceptible noise in the drarkest areas.  And most importantly, Dual ISO videos have a very natural look - way better than HDR techniques.  Here is an example from this morning shot at 2520x1304 resolution with Dual ISO 100/800, processed entirely with MLVApp v.017 and exported in H.265:

https://we.tl/eecN6HWi0O

A real achievement, CONGRATULATIONS !!!

I have a question.  Does the export format affect the render speed and if yes, would you suggest an export format with faster rendering speed?  Thanks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: VGT on July 10, 2018, 11:31:22 AM
Bouncyball, thank you very much for the explanation about the dark frame - I couldn't imagine such a workflow!!!))
That's great, I will test now, how it works with my footage more precisely! But I think, dark frame works best at high ISO, while my banding is most ugly at 100-200 ISO, but I'll try different settings and report.

I've just experimented with "PATTERN NOISE" button - it does a great job, removing vertical banding pattern of 7D, but in the areas of the frame with high contrast it causes strange artifacts.

That's how my banding noise looks originally

(https://thumb.ibb.co/jCTAxT/1.jpg) (https://ibb.co/jCTAxT)


Another example below - where banding is not so visible, but it helps to see the effect of the "PATTERN NOISE" button BEFORE-AFTER:

PATTERN NOISE - OFF

(https://thumb.ibb.co/nhMkWo/OFF.jpg) (https://ibb.co/nhMkWo)


PATTERN NOISE - ON - banding GONE, but new grey stripes appear.

(https://thumb.ibb.co/k9HQWo/ON.jpg) (https://ibb.co/k9HQWo)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 10, 2018, 12:19:16 PM
@VGT: have you tried setting "Vertical Stripes" to normal? Should work for exactly what I see in your pictures.

@IDA_ML: Oh yes, the dynamic is huge in your clip! Very nice.
Renderspeed is always the same (for the same settings chosen) because we always give the same series of uncompressed pictures via pipe to ffmpeg or to the AVFoundation class. The codec needs different time to encode this into your video file. But when dual iso is enabled, you won't recognize any difference here, because dual iso processing is so slow. On non dual iso clips ProRes 422 AVFoundation was one of the fastest codecs in my tests.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 10, 2018, 02:56:43 PM
Quote from: masc on July 10, 2018, 12:19:16 PM
@VGT: have you tried setting "Vertical Stripes" to normal? Should work for exactly what I see in your pictures.
+1 :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: VGT on July 10, 2018, 03:07:06 PM
masc,
sure I tried "Vertical Stripes" - Normal and Force - NO changes at all. It doesn't work for my kind of stripes.:)
The only setting, that kills the noise banding is "PATTERN NOISE", but it makes it's own "stripes"/
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 10, 2018, 03:36:32 PM
If banding appears in shadows darkframe subtraction helps to reduce banding.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: VGT on July 10, 2018, 04:46:26 PM
bouncyball

Did exactly as you wrote:
here is a short piece of mlv file with banding
https://drive.google.com/open?id=1OO7KM1SLF8_FMY7ztTIW-86qyk3OVsii

here is a 150 frame "dark" mlv with cap on (not averaged, just shot)
https://drive.google.com/open?id=1V_rclSwp4MCbrB54ptwjyoYhZYkQgY92

I wonder: should I increase the brightness of the dark video to see the noise visually before exporting as average dark frame or leave as it is absolutely dark?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: VGT on July 10, 2018, 04:51:16 PM
Danne,

Thanks,
I am just trying now to reduce banding with dark frame subtraction - but not very successfully... I can't see significant differences.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 10, 2018, 05:00:02 PM
@VGT: thanks for the sample.
@bouncyball: do you have an idea why vertical stripes does nothing for this clip? Could you debug? Something is very different to the 7D I hold in my hands some weeks ago: whitelevel is at 16383, on my sample it was at 15500 (at least highlight reconstruction works for whitelevel slider at full 16bit - very strange). Who knows what else is different here what maybe makes vertical stripes algorithm not working...
For me the stripes themselves are looking 100% the same as on the 7D I was playing with.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 10, 2018, 06:08:54 PM
Quote from: VGT on July 10, 2018, 04:46:26 PM
I wonder: should I increase the brightness of the dark video to see the noise visually before exporting as average dark frame or leave as it is absolutely dark?
You must leave it as is. When you exporting MLV it is not processed anyway (just averaging).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 10, 2018, 06:16:21 PM
Darkframe does not help either. This vertical pattern in the shadows somewhat familiar to me. I also had 7D several years ago.

Hint: maybe ask a1ex for help/explanation?

Edit: It indeed looks like vertical stripes. And stripes detection, if I undestand correctly, happens on upper lite part of the image. Here sky is clean. SO maybe that is the problem. a1ex is the author of this algorithm that is why I think it is better to ask him.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 10, 2018, 06:32:33 PM
@VGT
Are you on mac? Maybe you could try Switch and process with an older version of mlv_dump in there. Select (m) in main menu to get there. I think I use an older vertical stripes code in there. You could get lucky.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: VGT on July 10, 2018, 07:08:15 PM
Danne,
Yes, I am on mac... but to tell the truth, I didn't get in what "main menu" should I select (m)? In MLV App? Don't see any((
Could you, please, explain!

bouncyball,
The sky in my shots is always absolutely clean without any stripes, the vertical stripes are ONLY in the darkest shadows after I pull them out increasing the exposure in post.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 10, 2018, 07:47:56 PM
Here you go:
https://www.magiclantern.fm/forum/index.php?topic=15108.0

I think it could work. More than once this code proved successful.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: VGT on July 10, 2018, 09:06:09 PM
O, thanks, I'll try it!

Edit: oh, no, I tried it - and I changed my mind, I prefer the interface of MLV App)))) - I'd better smash my 7D against the wall :)
Thanks everyone for your attention and advice!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: feureau on July 11, 2018, 04:42:29 AM
Bugreport: If MLVApp encounters a corrupt MLV, it will crash.

If you have a bunch of MLVs in the Session and you batch export them all, when MLVApp encounters a corrupt MLV, it will spit out an error like this:
(https://thumb.ibb.co/bJ9BNT/Capture.png) (https://ibb.co/bJ9BNT)


If you click cancel, the whole thing will just crash.

Maybe allow an option to abort/retry/ignore(skip) the file?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 11, 2018, 08:09:33 AM
Quote from: feureau on July 11, 2018, 04:42:29 AM
Bugreport: If MLVApp encounters a corrupt MLV, it will crash.

If you have a bunch of MLVs in the Session and you batch export them all, when MLVApp encounters a corrupt MLV, it will spit out an error like this:
(https://thumb.ibb.co/bJ9BNT/Capture.png) (https://ibb.co/bJ9BNT)


If you click cancel, the whole thing will just crash.

Maybe allow an option to abort/retry/ignore(skip) the file?
Thanks for the report - I fixed it two days ago. There was a a little line missing in the code, so the app was running into undefined memory what crashes the app. But I will recheck what happens on export.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 11, 2018, 08:58:59 AM
Quote from: feureau on July 11, 2018, 04:42:29 AM
Bugreport: If MLVApp encounters a corrupt MLV, it will crash.
It depends on corruption type. Many cases are handled gracefully, some maybe not ;)

Quote from: feureau on July 11, 2018, 04:42:29 AM
If you have a bunch of MLVs in the Session and you batch export them all, when MLVApp encounters a corrupt MLV, it will spit out an error like this:<br
This error expected when header block name is wrong.

Quote from: feureau on July 11, 2018, 04:42:29 AM
Maybe allow an option to abort/retry/ignore(skip) the file?
Already there.

Remaining crash reason explained and fixed by masc (freeing some nonexistent mutex).

regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 70MM13 on July 11, 2018, 02:36:20 PM
It would be awesome if you guys added more demosaicing algorithms.  Here's an example of one other from rawtherapee:

https://www.magiclantern.fm/forum/index.php?topic=22483.msg203990#msg203990
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 11, 2018, 02:57:47 PM
Quote from: 70MM13 on July 11, 2018, 02:36:20 PM
It would be awesome if you guys added more demosaicing algorithms.  Here's an example of one other from rawtherapee:

https://www.magiclantern.fm/forum/index.php?topic=22483.msg203990#msg203990

And which algorithm did you use in your example? Default in rawtherapee is AMaZE.
https://rawpedia.rawtherapee.com/Demosaicing
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 70MM13 on July 11, 2018, 03:08:16 PM
Sorry, the filenames are the algorithms used.

It's RCD.

I've edited the linked post for clarity.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 11, 2018, 03:21:39 PM
Hm, okay. But is it really better? For me it looks just more blurred than AMaZE. All artifacts are still there, sometimes with more false colors.
(https://image.ibb.co/e2LEBo/Bildschirmfoto_2018_07_11_um_15_18_14.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 70MM13 on July 11, 2018, 03:26:55 PM
I find that different algorithms are beneficial for solving different problems.

Almost all the time, amaze is a great choice, but sometimes, it's great to have other options, especially when it solves a problem!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 11, 2018, 04:00:12 PM
Quote from: 70MM13 on July 11, 2018, 03:26:55 PM
Almost all the time, amaze is a great choice, but sometimes, it's great to have other options, especially when it solves a problem!
That's right but... I'd rather spend time on some other bilinear debayer variant optimized for maximum speed to play high resolution clips in real time.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 70MM13 on July 11, 2018, 04:08:59 PM
That's cool.

How long would it take to grab the existing library from rawtherapee?

It is open source.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 11, 2018, 04:56:09 PM
Quote from: 70MM13 on July 11, 2018, 04:08:59 PM
How long would it take to grab the existing library from rawtherapee?

It is open source.
It is not very compatible (C++, we are using C, so has to be adapted) and each algorithm has another undocumented interface. But I don't think that we will get faster with another algorithm. Just for testing I commented debayering out (looks very weird ;) ) but had nearly the identical speed as bilinear. On the other side: switching off processing brings factor 2.5 in terms of speed on my machine. In numbers: 8fps (normal) vs. 8 to 9fps (no debayer) vs 21fps (no processing) on a old notebook @FullHD.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on July 11, 2018, 06:12:59 PM
wow processing is slow.

Is that 21fps with no processing with no caching too?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 11, 2018, 06:40:52 PM
Quote from: masc on July 11, 2018, 04:56:09 PM
brings factor 2.5 in terms of speed on my machine.
Yeah I almost forgot about it ;)
Processing, being multi threaded, still is the main performance hog.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 11, 2018, 07:06:10 PM
Quote from: Ilia3101 on July 11, 2018, 06:12:59 PM
wow processing is slow.
Is that 21fps with no processing with no caching too?
Yes. But bilinear has almost the same speed like AMaZE cached for me.
Maybe I should analyse where exactly the time goes by on processing...

Edit: all the matrix operations cost time (white balance & exposure the most)... but no idea how to accelerate this. The concept is fine in my eyes.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on July 11, 2018, 09:26:52 PM
Quote from: masc on July 11, 2018, 07:06:10 PM
Edit: all the matrix operations cost time (white balance & exposure the most)... but no idea how to accelerate this. The concept is fine in my eyes.

I will try out integer multiplication + right shift method, maybe will be faster than look up tables.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 12, 2018, 07:47:21 PM
Quote from: Ilia3101 on July 11, 2018, 09:26:52 PM
I will try out integer multiplication + right shift method, maybe will be faster than look up tables.
Sounds good Ilia!

I added two easy debayers to MLVApp! One is monochrome (just copies RAW data to image) and another very simple & stupid colored debayer which looks worse than bilinear. Both are multithreaded and a little faster than bilinear (but not much). So just for viewing motion in a clip it might be okay...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 13, 2018, 04:49:35 AM
Since you guys are talking about demosaicing again, thought I'd share this paper (Multi-Frame Demosaicing and Super-Resolution of Color Images):
http://people.duke.edu/~sf59/TIP_Demos_Final_Color.pdf

To be fair, I don't understand the math, but the method proposed uses super-resolution as a demosaicing algorithm and reconstitures not just luma, but also chroma. From what I understood, he uses low-res versions of the image as "training" of the SR method. Here's the abstract:

Quote
In the last two decades, two related categories of problems have been studied independently in the image restoration literature: super-resolution and demosaicing. A closer look at these problems reveals the relation between them, and as conventional color digital cameras suffer from both low-spatial resolution and color-filtering, it is reasonable to address them in a unified context. In this paper, we propose a fast and robust hybrid method of super-resolution and demosaicing, based on a MAP estimation technique by minimizing a multi-term cost function. The L1 norm is used for measuring the difference between the projected estimate of the high-resolution image and each low-resolution image, removing outliers in the data and errors due to possibly inaccurate motion estimation. Bilateral regularization is used for spatially regularizing the luminance component, resulting in sharp edges and forcing interpolation along the edges and not across them. Simultaneously, Tikhonov regularization is used to smooth the
chrominance components. Finally, an additional regularization term is used to force similar edge location and orientation in different color channels. We show that the minimization of the total cost function is relatively easy and fast. Experimental results on synthetic and real data sets confirm the effectiveness of our method.

And here's the practical example (click to enlarge):

(https://pictshare.net/vbzskl0yoo.png) (https://pictshare.net/vbzskl0yoo.png)


The other paper (http://www.imagesensors.org/Past%20Workshops/2015%20Workshop/2015%20Papers/Sessions/Session_12/12-01_Goossens.pdf) shared some time ago combined sharpen inside demosaicing, this one combines SR. Maybe both ideas could be used together... humm.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 13, 2018, 05:35:10 AM
Another one. The idea of doing pre-demosaicing filtering seems to have spread these last years. This other paper presents denoising before demosaicing using machine-learning (Joint Demosaicing and Denoising via Learned Non-parametric Random Fields):
http://www.nowozin.net/sebastian/papers/khashabi2014demosaicing.pdf

The noise from CMOS or CCD generates interpolation errors (specially "read noise" and "shot noise", page 3), from what I've read on the paper. So, prior to demosaicing, they apply denoising. Below is a demonstration from the paper.  The RTF (Regression Tree Field) is their work, compared to CS (Contour Stencils), NLM (Non-Local Means), MBI (Matlab demosaic function) and the ground truth. Click to enlarge:

(https://pictshare.net/d1e8y3dek1.png) (https://pictshare.net/d1e8y3dek1.png)


And this other paper presents a sharpening/debluring (using deconvolution) before demosaicing. This work is based on the same approach on the superresolution paper shared above (using MAP framework, if I understood right):
https://hal.archives-ouvertes.fr/hal-00408220/document

Demonstration (click to enlarge):

(https://pictshare.net/2z76j5cbgj.png) (https://pictshare.net/2z76j5cbgj.png)


I wonder why no one bother to unite all these research for practical use.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 13, 2018, 05:44:41 AM
Another one, but using ANN (artificial neural network):
https://www.dcl.hpi.uni-potsdam.de/papers/papers/heinze-joint-multiframe.pdf

Demonstration compared to ACR (Adobe Camera Raw). Check the shadows and midtone noise on the car:
(https://pictshare.net/80dgkezdy8.png) (https://pictshare.net/80dgkezdy8.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 70MM13 on July 14, 2018, 01:35:22 PM
I'm between projects, so I finally got the chance to try your new colour balance functionality, and it's great!

Also, focus dots removal is finally working for me.  I use digital dolly and film exclusively at 3072*1308, so it's never worked before.

I'm so happy with it that I'm trying to reprocess one of my prior videos entirely in mlv app.  So far, it's going extremely well!

One of the shots required a tokina 11-16mm lens, famous for its purple fringing.

Any chance you could add a defringe function?  Rawtherapee does this really well. You just specify the colour, a colour range for the removal, and pixel radius.

I think a lot of users will be thankful.  Most of us have at least one lens that needs this kind of love...

Keep up the excellent work!

+1 for the incredible demosaicing suggestion
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on July 15, 2018, 07:14:47 AM
I feel like the hot pixel removal function is still not completelly up to the task. I've tested some old file with plenty of hot pixels and a few would pass even aggressive. I did a specific black frame for it on Switch but it would be nice to have a reliable correction in MLV App.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 15, 2018, 10:05:46 AM
@togg

Upload the sample please.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bakersdozen on July 15, 2018, 02:55:49 PM
Anyone else having issues with Full-res LV files from 5D3 113 (latest experimental crop build) crashing MLVApp when loading an .mlv file? I've tried both FRSP with intervalometer (output as .mlv) and RAW 14bit lossless with FPS override set at different rates from 7 down to 0.150. As soon as I select the the .mlv it crashes MLVApp.  Tried on latest (OSX) version and with the previous version giving same result. The files work as desired on MLRAWViewer, so they don't seem to be corrupt. I can't seem to find any other mentions of this in the thread, please forgive me if this is a known issue. Not sure if it has anything to do with being 5796x3870 resolution.

Here are the files, there is a FRSP (300MB) version, the RAW Version (1GB +) and the OSX crash log.

https://www.dropbox.com/s/zzd8x93zhs089ck/FRSP.MLV?dl=0
https://www.dropbox.com/s/38ylyldopa0qx9y/M15-1511.MLV?dl=0
https://www.dropbox.com/s/g8s6krnyzhbs15s/crash%20log.rtf?dl=0

Some shots have the sky blown out as I forgot my ND filter.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 15, 2018, 05:07:11 PM
I have just tested MLVApp v.017 with FRSP-MLV files from the 100D shot in the photo mode using the Silent module.  It opens and exports them fine.  There are two black lines - one on the top and another one on the left of the frame, meaning that the 100D needs some centering of the FRSP shot within the frame but this is not a problem of MLVApp.  Still, if I may post a wish for future features, that would be:

1) A crop and rotation/straightening tool - similar to the one in ACR for example;

2) Extention of the chroma separation tool with cleaning also some of the monochromatic noise.  Right now, it does a hell of a job by perfectly removing the color noise.  If one more slider could be added for the monochromatic noise, that would be fantastic! 
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 15, 2018, 10:27:53 PM
Quote from: bakersdozen on July 15, 2018, 02:55:49 PM
Anyone else having issues with Full-res LV files from 5D3 113 (latest experimental crop build) crashing MLVApp when loading an .mlv file? I've tried both FRSP with intervalometer (output as .mlv) and RAW 14bit lossless with FPS override set at different rates from 7 down to 0.150. As soon as I select the the .mlv it crashes MLVApp.  Tried on latest (OSX) version and with the previous version giving same result. The files work as desired on MLRAWViewer, so they don't seem to be corrupt. I can't seem to find any other mentions of this in the thread, please forgive me if this is a known issue. Not sure if it has anything to do with being 5796x3870 resolution.

Here are the files, there is a FRSP (300MB) version, the RAW Version (1GB +) and the OSX crash log.

https://www.dropbox.com/s/zzd8x93zhs089ck/FRSP.MLV?dl=0
https://www.dropbox.com/s/38ylyldopa0qx9y/M15-1511.MLV?dl=0
https://www.dropbox.com/s/g8s6krnyzhbs15s/crash%20log.rtf?dl=0

Some shots have the sky blown out as I forgot my ND filter.
Thx for the clips. I found the problem very fast: the problem is that these files are <1.0fps. MLVApp was not made for clips with so low fps ... at least I forgot that it might be possible ;)
I made a quickfix - that means: if the clip is <1fps, I set it to 1 fps. Otherwise it is very hard to show a correct timecode... (timecode was the crashing module). So you can compile the latest revision using Dannes compiler tool, or you wait for next release. ;)

Quote from: IDA_ML on July 15, 2018, 05:07:11 PM
1) A crop and rotation/straightening tool - similar to the one in ACR for example;
2) Extention of the chroma separation tool with cleaning also some of the monochromatic noise.  Right now, it does a hell of a job by perfectly removing the color noise.  If one more slider could be added for the monochromatic noise, that would be fantastic! 
1) You really would do this in MLVApp? I always do it in the NLE - each pixel might be good for stabilizing for example... after this I crop it if necessary.
2) That should be possible to add... let's see... but you'll get a very blurred image.

I found an implementation of LMMSE debayer with correct interface in C, so I added it to MLVApp now. Has someone used it in past in any other program? I have the problem that hard contrast lines are getting very green and cyan. Is that normal? Only highiso clips are okay... but AMaZE looks nearly always way better.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bakersdozen on July 15, 2018, 11:07:13 PM
Quote from: masc on July 15, 2018, 10:27:53 PM
Thx for the clips. I found the problem very fast: the problem is that these files are <1.0fps. MLVApp was not made for clips with so low fps ... at least I forgot that it might be possible ;)
I made a quickfix - that means: if the clip is <1fps, I set it to 1 fps. Otherwise it is very hard to show a correct timecode... (timecode was the crashing module). So you can compile the latest revision using Dannes compiler tool, or you wait for next release. ;)

Thanks MASC - legend!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 70MM13 on July 15, 2018, 11:20:38 PM
My understanding from rawtherapee is that lmmse is primarily for very high ISO shots.  I've never really found it too useful, but who knows, it might work for certain conditions...

Quote from: masc on July 15, 2018, 10:27:53 PM
Thx for the clips. I found the problem very fast: the problem is that these files are <1.0fps. MLVApp was not made for clips with so low fps ... at least I forgot that it might be possible ;)
I made a quickfix - that means: if the clip is <1fps, I set it to 1 fps. Otherwise it is very hard to show a correct timecode... (timecode was the crashing module). So you can compile the latest revision using Dannes compiler tool, or you wait for next release. ;)
1) You really would do this in MLVApp? I always do it in the NLE - each pixel might be good for stabilizing for example... after this I crop it if necessary.
2) That should be possible to add... let's see... but you'll get a very blurred image.

I found an implementation of LMMSE debayer with correct interface in C, so I added it to MLVApp now. Has someone used it in past in any other program? I have the problem that hard contrast lines are getting very green and cyan. Is that normal? Only highiso clips are okay... but AMaZE looks nearly always way better.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 15, 2018, 11:33:31 PM
Quote from: masc on July 15, 2018, 10:27:53 PM
I found an implementation of LMMSE debayer with correct interface in C, so I added it to MLVApp now. Has someone used it in past in any other program?

I have on RawTherapee...

Quote
I have the problem that hard contrast lines are getting very green and cyan. Is that normal? Only highiso clips are okay... but AMaZE looks nearly always way better.

Yep. AMaZE is always better than LMMSE. At least on RT.
The only demosaicing algorithm on RT that is better than AMaZE is IGV (https://github.com/Beep6581/RawTherapee/blob/dev/rtengine/demosaic_algos.cc) (Integrated Gaussian Vector), but only for highly noisy images. This is the code on RT:


/***
*
*   Bayer CFA Demosaicing using Integrated Gaussian Vector on Color Differences
*   Revision 1.0 - 2013/02/28
*
*   Copyright (c) 2007-2013 Luis Sanz Rodriguez
*   Using High Order Interpolation technique by Jim S, Jimmy Li, and Sharmil Randhawa
*
*   Contact info: [email protected]
*
*   This code is distributed under a GNU General Public License, version 3.
*   Visit <http://www.gnu.org/licenses/> for more information.
*
***/
// Adapted to RawTherapee by Jacques Desmis 3/2013
// SSE version by Ingo Weyrich 5/2013
#ifdef __SSE2__
#define CLIPV(a) LIMV(a,zerov,c65535v)
void RawImageSource::igv_interpolate(int winw, int winh)
{
    static const float eps = 1e-5f, epssq = 1e-5f; //mod epssq -10f =>-5f Jacques 3/2013 to prevent artifact (divide by zero)

    static const int h1 = 1, h2 = 2, h3 = 3, h5 = 5;
    const int width = winw, height = winh;
    const int v1 = 1 * width, v2 = 2 * width, v3 = 3 * width, v5 = 5 * width;
    float* rgb[2];
    float* chr[4];
    float *rgbarray, *vdif, *hdif, *chrarray;
    rgbarray    = (float (*)) malloc((width * height) * sizeof( float ) );
    rgb[0] = rgbarray;
    rgb[1] = rgbarray + (width * height) / 2;

    vdif  = (float (*)) calloc( width * height / 2, sizeof * vdif );
    hdif  = (float (*)) calloc( width * height / 2, sizeof * hdif );

    chrarray    = (float (*)) calloc( width * height, sizeof( float ) );
    chr[0] = chrarray;
    chr[1] = chrarray + (width * height) / 2;

    // mapped chr[2] and chr[3] to hdif and hdif, because these are out of use, when chr[2] and chr[3] are used
    chr[2] = hdif;
    chr[3] = vdif;

    border_interpolate2(winw, winh, 7, rawData, red, green, blue);

    if (plistener) {
        plistener->setProgressStr (Glib::ustring::compose(M("TP_RAW_DMETHOD_PROGRESSBAR"), RAWParams::BayerSensor::getMethodString(RAWParams::BayerSensor::Method::IGV)));
        plistener->setProgress (0.0);
    }

#ifdef _OPENMP
    #pragma omp parallel default(none) shared(rgb,vdif,hdif,chr)
#endif
    {
        __m128 ngv, egv, wgv, sgv, nvv, evv, wvv, svv, nwgv, negv, swgv, segv, nwvv, nevv, swvv, sevv, tempv, temp1v, temp2v, temp3v, temp4v, temp5v, temp6v, temp7v, temp8v;
        __m128 epsv = _mm_set1_ps( eps );
        __m128 epssqv = _mm_set1_ps( epssq );
        __m128 c65535v = _mm_set1_ps( 65535.f );
        __m128 c23v = _mm_set1_ps( 23.f );
        __m128 c40v = _mm_set1_ps( 40.f );
        __m128 c51v = _mm_set1_ps( 51.f );
        __m128 c32v = _mm_set1_ps( 32.f );
        __m128 c8v = _mm_set1_ps( 8.f );
        __m128 c7v = _mm_set1_ps( 7.f );
        __m128 c6v = _mm_set1_ps( 6.f );
        __m128 c10v = _mm_set1_ps( 10.f );
        __m128 c21v = _mm_set1_ps( 21.f );
        __m128 c78v = _mm_set1_ps( 78.f );
        __m128 c69v = _mm_set1_ps( 69.f );
        __m128 c3145680v = _mm_set1_ps( 3145680.f );
        __m128 onev = _mm_set1_ps ( 1.f );
        __m128 zerov = _mm_set1_ps ( 0.f );
        __m128 d725v = _mm_set1_ps ( 0.725f );
        __m128 d1375v = _mm_set1_ps ( 0.1375f );

        float *dest1, *dest2;
        float ng, eg, wg, sg, nv, ev, wv, sv, nwg, neg, swg, seg, nwv, nev, swv, sev;
#ifdef _OPENMP
        #pragma omp for
#endif

        for (int row = 0; row < height - 0; row++) {
            dest1 = rgb[FC(row, 0) & 1];
            dest2 = rgb[FC(row, 1) & 1];
            int col, indx;

            for (col = 0, indx = row * width + col; col < width - 7; col += 8, indx += 8) {
                temp1v = LVFU( rawData[row][col] );
                temp1v = CLIPV( temp1v );
                temp2v = LVFU( rawData[row][col + 4] );
                temp2v = CLIPV( temp2v );
                tempv = _mm_shuffle_ps( temp1v, temp2v, _MM_SHUFFLE( 2, 0, 2, 0 ) );
                _mm_storeu_ps( &dest1[indx >> 1], tempv );
                tempv = _mm_shuffle_ps( temp1v, temp2v, _MM_SHUFFLE( 3, 1, 3, 1 ) );
                _mm_storeu_ps( &dest2[indx >> 1], tempv );
            }

            for (; col < width; col++, indx += 2) {
                dest1[indx >> 1] = CLIP(rawData[row][col]); //rawData = RT datas
                col++;
                if(col < width)
                    dest2[indx >> 1] = CLIP(rawData[row][col]); //rawData = RT datas
            }
        }

#ifdef _OPENMP
        #pragma omp single
#endif
        {
            if (plistener) {
                plistener->setProgress (0.13);
            }
        }

#ifdef _OPENMP
        #pragma omp for
#endif

        for (int row = 5; row < height - 5; row++) {
            int col, indx, indx1;

            for (col = 5 + (FC(row, 1) & 1), indx = row * width + col, indx1 = indx >> 1; col < width - 12; col += 8, indx += 8, indx1 += 4) {
                //N,E,W,S Gradients
                ngv = (epsv + (vabsf(LVFU(rgb[1][(indx - v1) >> 1]) - LVFU(rgb[1][(indx - v3) >> 1])) + vabsf(LVFU(rgb[0][indx1]) - LVFU(rgb[0][(indx1 - v1)]))) / c65535v);
                egv = (epsv + (vabsf(LVFU(rgb[1][(indx + h1) >> 1]) - LVFU(rgb[1][(indx + h3) >> 1])) + vabsf(LVFU(rgb[0][indx1]) - LVFU(rgb[0][(indx1 + h1)]))) / c65535v);
                wgv = (epsv + (vabsf(LVFU(rgb[1][(indx - h1) >> 1]) - LVFU(rgb[1][(indx - h3) >> 1])) + vabsf(LVFU(rgb[0][indx1]) - LVFU(rgb[0][(indx1 - h1)]))) / c65535v);
                sgv = (epsv + (vabsf(LVFU(rgb[1][(indx + v1) >> 1]) - LVFU(rgb[1][(indx + v3) >> 1])) + vabsf(LVFU(rgb[0][indx1]) - LVFU(rgb[0][(indx1 + v1)]))) / c65535v);
                //N,E,W,S High Order Interpolation (Li & Randhawa)
                //N,E,W,S Hamilton Adams Interpolation
                // (48.f * 65535.f) = 3145680.f
                tempv = c40v * LVFU(rgb[0][indx1]);
                nvv = LIMV(((c23v * LVFU(rgb[1][(indx - v1) >> 1]) + c23v * LVFU(rgb[1][(indx - v3) >> 1]) + LVFU(rgb[1][(indx - v5) >> 1]) + LVFU(rgb[1][(indx + v1) >> 1]) + tempv - c32v * LVFU(rgb[0][(indx1 - v1)]) - c8v * LVFU(rgb[0][(indx1 - v2)]))) / c3145680v, zerov, onev);
                evv = LIMV(((c23v * LVFU(rgb[1][(indx + h1) >> 1]) + c23v * LVFU(rgb[1][(indx + h3) >> 1]) + LVFU(rgb[1][(indx + h5) >> 1]) + LVFU(rgb[1][(indx - h1) >> 1]) + tempv - c32v * LVFU(rgb[0][(indx1 + h1)]) - c8v * LVFU(rgb[0][(indx1 + h2)]))) / c3145680v, zerov, onev);
                wvv = LIMV(((c23v * LVFU(rgb[1][(indx - h1) >> 1]) + c23v * LVFU(rgb[1][(indx - h3) >> 1]) + LVFU(rgb[1][(indx - h5) >> 1]) + LVFU(rgb[1][(indx + h1) >> 1]) + tempv - c32v * LVFU(rgb[0][(indx1 - h1)]) - c8v * LVFU(rgb[0][(indx1 - h2)]))) / c3145680v, zerov, onev);
                svv = LIMV(((c23v * LVFU(rgb[1][(indx + v1) >> 1]) + c23v * LVFU(rgb[1][(indx + v3) >> 1]) + LVFU(rgb[1][(indx + v5) >> 1]) + LVFU(rgb[1][(indx - v1) >> 1]) + tempv - c32v * LVFU(rgb[0][(indx1 + v1)]) - c8v * LVFU(rgb[0][(indx1 + v2)]))) / c3145680v, zerov, onev);
                //Horizontal and vertical color differences
                tempv = LVFU( rgb[0][indx1] ) / c65535v;
                _mm_storeu_ps( &vdif[indx1], (sgv * nvv + ngv * svv) / (ngv + sgv) - tempv );
                _mm_storeu_ps( &hdif[indx1], (wgv * evv + egv * wvv) / (egv + wgv) - tempv );
            }

            // borders without SSE
            for (; col < width - 5; col += 2, indx += 2, indx1++) {
                //N,E,W,S Gradients
                ng = (eps + (fabsf(rgb[1][(indx - v1) >> 1] - rgb[1][(indx - v3) >> 1]) + fabsf(rgb[0][indx1] - rgb[0][(indx1 - v1)])) / 65535.f);;
                eg = (eps + (fabsf(rgb[1][(indx + h1) >> 1] - rgb[1][(indx + h3) >> 1]) + fabsf(rgb[0][indx1] - rgb[0][(indx1 + h1)])) / 65535.f);
                wg = (eps + (fabsf(rgb[1][(indx - h1) >> 1] - rgb[1][(indx - h3) >> 1]) + fabsf(rgb[0][indx1] - rgb[0][(indx1 - h1)])) / 65535.f);
                sg = (eps + (fabsf(rgb[1][(indx + v1) >> 1] - rgb[1][(indx + v3) >> 1]) + fabsf(rgb[0][indx1] - rgb[0][(indx1 + v1)])) / 65535.f);
                //N,E,W,S High Order Interpolation (Li & Randhawa)
                //N,E,W,S Hamilton Adams Interpolation
                // (48.f * 65535.f) = 3145680.f
                nv = LIM(((23.0f * rgb[1][(indx - v1) >> 1] + 23.0f * rgb[1][(indx - v3) >> 1] + rgb[1][(indx - v5) >> 1] + rgb[1][(indx + v1) >> 1] + 40.0f * rgb[0][indx1] - 32.0f * rgb[0][(indx1 - v1)] - 8.0f * rgb[0][(indx1 - v2)])) / 3145680.f, 0.0f, 1.0f);
                ev = LIM(((23.0f * rgb[1][(indx + h1) >> 1] + 23.0f * rgb[1][(indx + h3) >> 1] + rgb[1][(indx + h5) >> 1] + rgb[1][(indx - h1) >> 1] + 40.0f * rgb[0][indx1] - 32.0f * rgb[0][(indx1 + h1)] - 8.0f * rgb[0][(indx1 + h2)])) / 3145680.f, 0.0f, 1.0f);
                wv = LIM(((23.0f * rgb[1][(indx - h1) >> 1] + 23.0f * rgb[1][(indx - h3) >> 1] + rgb[1][(indx - h5) >> 1] + rgb[1][(indx + h1) >> 1] + 40.0f * rgb[0][indx1] - 32.0f * rgb[0][(indx1 - h1)] - 8.0f * rgb[0][(indx1 - h2)])) / 3145680.f, 0.0f, 1.0f);
                sv = LIM(((23.0f * rgb[1][(indx + v1) >> 1] + 23.0f * rgb[1][(indx + v3) >> 1] + rgb[1][(indx + v5) >> 1] + rgb[1][(indx - v1) >> 1] + 40.0f * rgb[0][indx1] - 32.0f * rgb[0][(indx1 + v1)] - 8.0f * rgb[0][(indx1 + v2)])) / 3145680.f, 0.0f, 1.0f);
                //Horizontal and vertical color differences
                vdif[indx1] = (sg * nv + ng * sv) / (ng + sg) - (rgb[0][indx1]) / 65535.f;
                hdif[indx1] = (wg * ev + eg * wv) / (eg + wg) - (rgb[0][indx1]) / 65535.f;
            }
        }

#ifdef _OPENMP
        #pragma omp single
#endif
        {
            if (plistener) {
                plistener->setProgress (0.26);
            }
        }
#ifdef _OPENMP
        #pragma omp for
#endif

        for (int row = 7; row < height - 7; row++) {
            int col, d, indx1;

            for (col = 7 + (FC(row, 1) & 1), indx1 = (row * width + col) >> 1, d = FC(row, col) / 2; col < width - 14; col += 8, indx1 += 4) {
                //H&V integrated gaussian vector over variance on color differences
                //Mod Jacques 3/2013
                ngv = LIMV(epssqv + c78v * SQRV(LVFU(vdif[indx1])) + c69v * (SQRV(LVFU(vdif[indx1 - v1])) + SQRV(LVFU(vdif[indx1 + v1]))) + c51v * (SQRV(LVFU(vdif[indx1 - v2])) + SQRV(LVFU(vdif[indx1 + v2]))) + c21v * (SQRV(LVFU(vdif[indx1 - v3])) + SQRV(LVFU(vdif[indx1 + v3]))) - c6v * SQRV(LVFU(vdif[indx1 - v1]) + LVFU(vdif[indx1]) + LVFU(vdif[indx1 + v1]))
                           - c10v * (SQRV(LVFU(vdif[indx1 - v2]) + LVFU(vdif[indx1 - v1]) + LVFU(vdif[indx1])) + SQRV(LVFU(vdif[indx1]) + LVFU(vdif[indx1 + v1]) + LVFU(vdif[indx1 + v2]))) - c7v * (SQRV(LVFU(vdif[indx1 - v3]) + LVFU(vdif[indx1 - v2]) + LVFU(vdif[indx1 - v1])) + SQRV(LVFU(vdif[indx1 + v1]) + LVFU(vdif[indx1 + v2]) + LVFU(vdif[indx1 + v3]))), zerov, onev);
                egv = LIMV(epssqv + c78v * SQRV(LVFU(hdif[indx1])) + c69v * (SQRV(LVFU(hdif[indx1 - h1])) + SQRV(LVFU(hdif[indx1 + h1]))) + c51v * (SQRV(LVFU(hdif[indx1 - h2])) + SQRV(LVFU(hdif[indx1 + h2]))) + c21v * (SQRV(LVFU(hdif[indx1 - h3])) + SQRV(LVFU(hdif[indx1 + h3]))) - c6v * SQRV(LVFU(hdif[indx1 - h1]) + LVFU(hdif[indx1]) + LVFU(hdif[indx1 + h1]))
                           - c10v * (SQRV(LVFU(hdif[indx1 - h2]) + LVFU(hdif[indx1 - h1]) + LVFU(hdif[indx1])) + SQRV(LVFU(hdif[indx1]) + LVFU(hdif[indx1 + h1]) + LVFU(hdif[indx1 + h2]))) - c7v * (SQRV(LVFU(hdif[indx1 - h3]) + LVFU(hdif[indx1 - h2]) + LVFU(hdif[indx1 - h1])) + SQRV(LVFU(hdif[indx1 + h1]) + LVFU(hdif[indx1 + h2]) + LVFU(hdif[indx1 + h3]))), zerov, onev);
                //Limit chrominance using H/V neighbourhood
                nvv = median(d725v * LVFU(vdif[indx1]) + d1375v * LVFU(vdif[indx1 - v1]) + d1375v * LVFU(vdif[indx1 + v1]), LVFU(vdif[indx1 - v1]), LVFU(vdif[indx1 + v1]));
                evv = median(d725v * LVFU(hdif[indx1]) + d1375v * LVFU(hdif[indx1 - h1]) + d1375v * LVFU(hdif[indx1 + h1]), LVFU(hdif[indx1 - h1]), LVFU(hdif[indx1 + h1]));
                //Chrominance estimation
                tempv = (egv * nvv + ngv * evv) / (ngv + egv);
                _mm_storeu_ps(&(chr[d][indx1]), tempv);
                //Green channel population
                temp1v = c65535v * tempv + LVFU(rgb[0][indx1]);
                _mm_storeu_ps( &(rgb[0][indx1]), temp1v );
            }

            for (; col < width - 7; col += 2, indx1++) {
                //H&V integrated gaussian vector over variance on color differences
                //Mod Jacques 3/2013
                ng = LIM(epssq + 78.0f * SQR(vdif[indx1]) + 69.0f * (SQR(vdif[indx1 - v1]) + SQR(vdif[indx1 + v1])) + 51.0f * (SQR(vdif[indx1 - v2]) + SQR(vdif[indx1 + v2])) + 21.0f * (SQR(vdif[indx1 - v3]) + SQR(vdif[indx1 + v3])) - 6.0f * SQR(vdif[indx1 - v1] + vdif[indx1] + vdif[indx1 + v1])
                         - 10.0f * (SQR(vdif[indx1 - v2] + vdif[indx1 - v1] + vdif[indx1]) + SQR(vdif[indx1] + vdif[indx1 + v1] + vdif[indx1 + v2])) - 7.0f * (SQR(vdif[indx1 - v3] + vdif[indx1 - v2] + vdif[indx1 - v1]) + SQR(vdif[indx1 + v1] + vdif[indx1 + v2] + vdif[indx1 + v3])), 0.f, 1.f);
                eg = LIM(epssq + 78.0f * SQR(hdif[indx1]) + 69.0f * (SQR(hdif[indx1 - h1]) + SQR(hdif[indx1 + h1])) + 51.0f * (SQR(hdif[indx1 - h2]) + SQR(hdif[indx1 + h2])) + 21.0f * (SQR(hdif[indx1 - h3]) + SQR(hdif[indx1 + h3])) - 6.0f * SQR(hdif[indx1 - h1] + hdif[indx1] + hdif[indx1 + h1])
                         - 10.0f * (SQR(hdif[indx1 - h2] + hdif[indx1 - h1] + hdif[indx1]) + SQR(hdif[indx1] + hdif[indx1 + h1] + hdif[indx1 + h2])) - 7.0f * (SQR(hdif[indx1 - h3] + hdif[indx1 - h2] + hdif[indx1 - h1]) + SQR(hdif[indx1 + h1] + hdif[indx1 + h2] + hdif[indx1 + h3])), 0.f, 1.f);
                //Limit chrominance using H/V neighbourhood
                nv = median(0.725f * vdif[indx1] + 0.1375f * vdif[indx1 - v1] + 0.1375f * vdif[indx1 + v1], vdif[indx1 - v1], vdif[indx1 + v1]);
                ev = median(0.725f * hdif[indx1] + 0.1375f * hdif[indx1 - h1] + 0.1375f * hdif[indx1 + h1], hdif[indx1 - h1], hdif[indx1 + h1]);
                //Chrominance estimation
                chr[d][indx1] = (eg * nv + ng * ev) / (ng + eg);
                //Green channel population
                rgb[0][indx1] = rgb[0][indx1] + 65535.f * chr[d][indx1];
            }
        }

#ifdef _OPENMP
        #pragma omp single
#endif
        {
            if (plistener) {
                plistener->setProgress (0.39);
            }
        }
#ifdef _OPENMP
        #pragma omp for
#endif

        for (int row = 7; row < height - 7; row++) {
            int col, indx, c;

            for (col = 7 + (FC(row, 1) & 1), indx = row * width + col, c = 1 - FC(row, col) / 2; col < width - 14; col += 8, indx += 8) {
                //NW,NE,SW,SE Gradients
                nwgv = onev / (epsv + vabsf(LVFU(chr[c][(indx - v1 - h1) >> 1]) - LVFU(chr[c][(indx - v3 - h3) >> 1])) + vabsf(LVFU(chr[c][(indx + v1 + h1) >> 1]) - LVFU(chr[c][(indx - v3 - h3) >> 1])));
                negv = onev / (epsv + vabsf(LVFU(chr[c][(indx - v1 + h1) >> 1]) - LVFU(chr[c][(indx - v3 + h3) >> 1])) + vabsf(LVFU(chr[c][(indx + v1 - h1) >> 1]) - LVFU(chr[c][(indx - v3 + h3) >> 1])));
                swgv = onev / (epsv + vabsf(LVFU(chr[c][(indx + v1 - h1) >> 1]) - LVFU(chr[c][(indx + v3 + h3) >> 1])) + vabsf(LVFU(chr[c][(indx - v1 + h1) >> 1]) - LVFU(chr[c][(indx + v3 - h3) >> 1])));
                segv = onev / (epsv + vabsf(LVFU(chr[c][(indx + v1 + h1) >> 1]) - LVFU(chr[c][(indx + v3 - h3) >> 1])) + vabsf(LVFU(chr[c][(indx - v1 - h1) >> 1]) - LVFU(chr[c][(indx + v3 + h3) >> 1])));
                //Limit NW,NE,SW,SE Color differences
                nwvv = median(LVFU(chr[c][(indx - v1 - h1) >> 1]), LVFU(chr[c][(indx - v3 - h1) >> 1]), LVFU(chr[c][(indx - v1 - h3) >> 1]));
                nevv = median(LVFU(chr[c][(indx - v1 + h1) >> 1]), LVFU(chr[c][(indx - v3 + h1) >> 1]), LVFU(chr[c][(indx - v1 + h3) >> 1]));
                swvv = median(LVFU(chr[c][(indx + v1 - h1) >> 1]), LVFU(chr[c][(indx + v3 - h1) >> 1]), LVFU(chr[c][(indx + v1 - h3) >> 1]));
                sevv = median(LVFU(chr[c][(indx + v1 + h1) >> 1]), LVFU(chr[c][(indx + v3 + h1) >> 1]), LVFU(chr[c][(indx + v1 + h3) >> 1]));
                //Interpolate chrominance: R@B and B@R
                tempv = (nwgv * nwvv + negv * nevv + swgv * swvv + segv * sevv) / (nwgv + negv + swgv + segv);
                _mm_storeu_ps( &(chr[c][indx >> 1]), tempv);
            }

            for (; col < width - 7; col += 2, indx += 2) {
                //NW,NE,SW,SE Gradients
                nwg = 1.0f / (eps + fabsf(chr[c][(indx - v1 - h1) >> 1] - chr[c][(indx - v3 - h3) >> 1]) + fabsf(chr[c][(indx + v1 + h1) >> 1] - chr[c][(indx - v3 - h3) >> 1]));
                neg = 1.0f / (eps + fabsf(chr[c][(indx - v1 + h1) >> 1] - chr[c][(indx - v3 + h3) >> 1]) + fabsf(chr[c][(indx + v1 - h1) >> 1] - chr[c][(indx - v3 + h3) >> 1]));
                swg = 1.0f / (eps + fabsf(chr[c][(indx + v1 - h1) >> 1] - chr[c][(indx + v3 + h3) >> 1]) + fabsf(chr[c][(indx - v1 + h1) >> 1] - chr[c][(indx + v3 - h3) >> 1]));
                seg = 1.0f / (eps + fabsf(chr[c][(indx + v1 + h1) >> 1] - chr[c][(indx + v3 - h3) >> 1]) + fabsf(chr[c][(indx - v1 - h1) >> 1] - chr[c][(indx + v3 + h3) >> 1]));
                //Limit NW,NE,SW,SE Color differences
                nwv = median(chr[c][(indx - v1 - h1) >> 1], chr[c][(indx - v3 - h1) >> 1], chr[c][(indx - v1 - h3) >> 1]);
                nev = median(chr[c][(indx - v1 + h1) >> 1], chr[c][(indx - v3 + h1) >> 1], chr[c][(indx - v1 + h3) >> 1]);
                swv = median(chr[c][(indx + v1 - h1) >> 1], chr[c][(indx + v3 - h1) >> 1], chr[c][(indx + v1 - h3) >> 1]);
                sev = median(chr[c][(indx + v1 + h1) >> 1], chr[c][(indx + v3 + h1) >> 1], chr[c][(indx + v1 + h3) >> 1]);
                //Interpolate chrominance: R@B and B@R
                chr[c][indx >> 1] = (nwg * nwv + neg * nev + swg * swv + seg * sev) / (nwg + neg + swg + seg);
            }
        }

#ifdef _OPENMP
        #pragma omp single
#endif
        {
            if (plistener) {
                plistener->setProgress (0.65);
            }
        }
#ifdef _OPENMP
        #pragma omp for
#endif

        for (int row = 7; row < height - 7; row++) {
            int col, indx;

            for (col = 7 + (FC(row, 0) & 1), indx = row * width + col; col < width - 14; col += 8, indx += 8) {
                //N,E,W,S Gradients
                ngv = onev / (epsv + vabsf(LVFU(chr[0][(indx - v1) >> 1]) - LVFU(chr[0][(indx - v3) >> 1])) + vabsf(LVFU(chr[0][(indx + v1) >> 1]) - LVFU(chr[0][(indx - v3) >> 1])));
                egv = onev / (epsv + vabsf(LVFU(chr[0][(indx + h1) >> 1]) - LVFU(chr[0][(indx + h3) >> 1])) + vabsf(LVFU(chr[0][(indx - h1) >> 1]) - LVFU(chr[0][(indx + h3) >> 1])));
                wgv = onev / (epsv + vabsf(LVFU(chr[0][(indx - h1) >> 1]) - LVFU(chr[0][(indx - h3) >> 1])) + vabsf(LVFU(chr[0][(indx + h1) >> 1]) - LVFU(chr[0][(indx - h3) >> 1])));
                sgv = onev / (epsv + vabsf(LVFU(chr[0][(indx + v1) >> 1]) - LVFU(chr[0][(indx + v3) >> 1])) + vabsf(LVFU(chr[0][(indx - v1) >> 1]) - LVFU(chr[0][(indx + v3) >> 1])));
                //Interpolate chrominance: R@G and B@G
                tempv = ((ngv * LVFU(chr[0][(indx - v1) >> 1]) + egv * LVFU(chr[0][(indx + h1) >> 1]) + wgv * LVFU(chr[0][(indx - h1) >> 1]) + sgv * LVFU(chr[0][(indx + v1) >> 1])) / (ngv + egv + wgv + sgv));
                _mm_storeu_ps( &chr[0 + 2][indx >> 1], tempv);
            }

            for (; col < width - 7; col += 2, indx += 2) {
                //N,E,W,S Gradients
                ng = 1.0f / (eps + fabsf(chr[0][(indx - v1) >> 1] - chr[0][(indx - v3) >> 1]) + fabsf(chr[0][(indx + v1) >> 1] - chr[0][(indx - v3) >> 1]));
                eg = 1.0f / (eps + fabsf(chr[0][(indx + h1) >> 1] - chr[0][(indx + h3) >> 1]) + fabsf(chr[0][(indx - h1) >> 1] - chr[0][(indx + h3) >> 1]));
                wg = 1.0f / (eps + fabsf(chr[0][(indx - h1) >> 1] - chr[0][(indx - h3) >> 1]) + fabsf(chr[0][(indx + h1) >> 1] - chr[0][(indx - h3) >> 1]));
                sg = 1.0f / (eps + fabsf(chr[0][(indx + v1) >> 1] - chr[0][(indx + v3) >> 1]) + fabsf(chr[0][(indx - v1) >> 1] - chr[0][(indx + v3) >> 1]));
                //Interpolate chrominance: R@G and B@G
                chr[0 + 2][indx >> 1] = ((ng * chr[0][(indx - v1) >> 1] + eg * chr[0][(indx + h1) >> 1] + wg * chr[0][(indx - h1) >> 1] + sg * chr[0][(indx + v1) >> 1]) / (ng + eg + wg + sg));
            }
        }

#ifdef _OPENMP
        #pragma omp single
#endif
        {
            if (plistener) {
                plistener->setProgress (0.78);
            }
        }
#ifdef _OPENMP
        #pragma omp for
#endif

        for (int row = 7; row < height - 7; row++) {
            int col, indx;

            for (col = 7 + (FC(row, 0) & 1), indx = row * width + col; col < width - 14; col += 8, indx += 8) {
                //N,E,W,S Gradients
                ngv = onev / (epsv + vabsf(LVFU(chr[1][(indx - v1) >> 1]) - LVFU(chr[1][(indx - v3) >> 1])) + vabsf(LVFU(chr[1][(indx + v1) >> 1]) - LVFU(chr[1][(indx - v3) >> 1])));
                egv = onev / (epsv + vabsf(LVFU(chr[1][(indx + h1) >> 1]) - LVFU(chr[1][(indx + h3) >> 1])) + vabsf(LVFU(chr[1][(indx - h1) >> 1]) - LVFU(chr[1][(indx + h3) >> 1])));
                wgv = onev / (epsv + vabsf(LVFU(chr[1][(indx - h1) >> 1]) - LVFU(chr[1][(indx - h3) >> 1])) + vabsf(LVFU(chr[1][(indx + h1) >> 1]) - LVFU(chr[1][(indx - h3) >> 1])));
                sgv = onev / (epsv + vabsf(LVFU(chr[1][(indx + v1) >> 1]) - LVFU(chr[1][(indx + v3) >> 1])) + vabsf(LVFU(chr[1][(indx - v1) >> 1]) - LVFU(chr[1][(indx + v3) >> 1])));
                //Interpolate chrominance: R@G and B@G
                tempv = ((ngv * LVFU(chr[1][(indx - v1) >> 1]) + egv * LVFU(chr[1][(indx + h1) >> 1]) + wgv * LVFU(chr[1][(indx - h1) >> 1]) + sgv * LVFU(chr[1][(indx + v1) >> 1])) / (ngv + egv + wgv + sgv));
                _mm_storeu_ps( &chr[1 + 2][indx >> 1], tempv);
            }

            for (; col < width - 7; col += 2, indx += 2) {
                //N,E,W,S Gradients
                ng = 1.0f / (eps + fabsf(chr[1][(indx - v1) >> 1] - chr[1][(indx - v3) >> 1]) + fabsf(chr[1][(indx + v1) >> 1] - chr[1][(indx - v3) >> 1]));
                eg = 1.0f / (eps + fabsf(chr[1][(indx + h1) >> 1] - chr[1][(indx + h3) >> 1]) + fabsf(chr[1][(indx - h1) >> 1] - chr[1][(indx + h3) >> 1]));
                wg = 1.0f / (eps + fabsf(chr[1][(indx - h1) >> 1] - chr[1][(indx - h3) >> 1]) + fabsf(chr[1][(indx + h1) >> 1] - chr[1][(indx - h3) >> 1]));
                sg = 1.0f / (eps + fabsf(chr[1][(indx + v1) >> 1] - chr[1][(indx + v3) >> 1]) + fabsf(chr[1][(indx - v1) >> 1] - chr[1][(indx + v3) >> 1]));
                //Interpolate chrominance: R@G and B@G
                chr[1 + 2][indx >> 1] = ((ng * chr[1][(indx - v1) >> 1] + eg * chr[1][(indx + h1) >> 1] + wg * chr[1][(indx - h1) >> 1] + sg * chr[1][(indx + v1) >> 1]) / (ng + eg + wg + sg));
            }
        }

#ifdef _OPENMP
        #pragma omp single
#endif
        {
            if (plistener) {
                plistener->setProgress (0.91);
            }
        }
        float *src1, *src2, *redsrc0, *redsrc1, *bluesrc0, *bluesrc1;
#ifdef _OPENMP
        #pragma omp for
#endif

        for(int row = 7; row < height - 7; row++) {
            int col, indx, fc;
            fc = FC(row, 7) & 1;
            src1 = rgb[fc];
            src2 = rgb[fc ^ 1];
            redsrc0 = chr[fc << 1];
            redsrc1 = chr[(fc ^ 1) << 1];
            bluesrc0 = chr[(fc << 1) + 1];
            bluesrc1 = chr[((fc ^ 1) << 1) + 1];

            for(col = 7, indx = row * width + col; col < width - 14; col += 8, indx += 8) {
                temp1v = LVFU( src1[indx >> 1] );
                temp2v = LVFU( src2[(indx + 1) >> 1] );
                tempv = _mm_shuffle_ps( temp1v, temp2v, _MM_SHUFFLE( 1, 0, 1, 0 ) );
                tempv = _mm_shuffle_ps( tempv, tempv, _MM_SHUFFLE( 3, 1, 2, 0 ) );
                _mm_storeu_ps( &green[row][col], CLIPV( tempv ));
                temp5v = LVFU(redsrc0[indx >> 1]);
                temp6v = LVFU(redsrc1[(indx + 1) >> 1]);
                temp3v = _mm_shuffle_ps( temp5v, temp6v, _MM_SHUFFLE( 1, 0, 1, 0 ) );
                temp3v = _mm_shuffle_ps( temp3v, temp3v, _MM_SHUFFLE( 3, 1, 2, 0 ) );
                temp3v = CLIPV( tempv - c65535v * temp3v );
                _mm_storeu_ps( &red[row][col], temp3v);
                temp7v = LVFU(bluesrc0[indx >> 1]);
                temp8v = LVFU(bluesrc1[(indx + 1) >> 1]);
                temp4v = _mm_shuffle_ps( temp7v, temp8v, _MM_SHUFFLE( 1, 0, 1, 0 ) );
                temp4v = _mm_shuffle_ps( temp4v, temp4v, _MM_SHUFFLE( 3, 1, 2, 0 ) );
                temp4v = CLIPV( tempv - c65535v * temp4v );
                _mm_storeu_ps( &blue[row][col], temp4v);

                tempv = _mm_shuffle_ps( temp1v, temp2v, _MM_SHUFFLE( 3, 2, 3, 2 ) );
                tempv = _mm_shuffle_ps( tempv, tempv, _MM_SHUFFLE( 3, 1, 2, 0 ) );
                _mm_storeu_ps( &green[row][col + 4], CLIPV( tempv ));

                temp3v = _mm_shuffle_ps( temp5v, temp6v, _MM_SHUFFLE( 3, 2, 3, 2 ) );
                temp3v = _mm_shuffle_ps( temp3v, temp3v, _MM_SHUFFLE( 3, 1, 2, 0 ) );
                temp3v = CLIPV( tempv - c65535v * temp3v );
                _mm_storeu_ps( &red[row][col + 4], temp3v);
                temp4v = _mm_shuffle_ps( temp7v, temp8v, _MM_SHUFFLE( 3, 2, 3, 2 ) );
                temp4v = _mm_shuffle_ps( temp4v, temp4v, _MM_SHUFFLE( 3, 1, 2, 0 ) );
                temp4v = CLIPV( tempv - c65535v * temp4v );
                _mm_storeu_ps( &blue[row][col + 4], temp4v);
            }

            for(; col < width - 7; col++, indx += 2) {
                red  [row][col] = CLIP(src1[indx >> 1] - 65535.f * redsrc0[indx >> 1]);
                green[row][col] = CLIP(src1[indx >> 1]);
                blue [row][col] = CLIP(src1[indx >> 1] - 65535.f * bluesrc0[indx >> 1]);
                col++;
                red  [row][col] = CLIP(src2[(indx + 1) >> 1] - 65535.f * redsrc1[(indx + 1) >> 1]);
                green[row][col] = CLIP(src2[(indx + 1) >> 1]);
                blue [row][col] = CLIP(src2[(indx + 1) >> 1] - 65535.f * bluesrc1[(indx + 1) >> 1]);
            }
        }
    }// End of parallelization

    if (plistener) {
        plistener->setProgress (1.0);
    }

    free(chrarray);
    free(rgbarray);
    free(vdif);
    free(hdif);
}
#undef CLIPV
#else
void RawImageSource::igv_interpolate(int winw, int winh)
{
    static const float eps = 1e-5f, epssq = 1e-5f; //mod epssq -10f =>-5f Jacques 3/2013 to prevent artifact (divide by zero)
    static const int h1 = 1, h2 = 2, h3 = 3, h4 = 4, h5 = 5, h6 = 6;
    const int width = winw, height = winh;
    const int v1 = 1 * width, v2 = 2 * width, v3 = 3 * width, v4 = 4 * width, v5 = 5 * width, v6 = 6 * width;
    float* rgb[3];
    float* chr[2];
    float (*rgbarray), *vdif, *hdif, (*chrarray);

    rgbarray    = (float (*)) calloc(width * height * 3, sizeof( float));
    rgb[0] = rgbarray;
    rgb[1] = rgbarray + (width * height);
    rgb[2] = rgbarray + 2 * (width * height);

    chrarray    = (float (*)) calloc(width * height * 2, sizeof( float));
    chr[0] = chrarray;
    chr[1] = chrarray + (width * height);

    vdif  = (float (*))    calloc(width * height / 2, sizeof * vdif);
    hdif  = (float (*))    calloc(width * height / 2, sizeof * hdif);

    border_interpolate2(winw, winh, 7, rawData, red, green, blue);

    if (plistener) {
        plistener->setProgressStr (Glib::ustring::compose(M("TP_RAW_DMETHOD_PROGRESSBAR"), RAWParams::BayerSensor::getMethodString(RAWParams::BayerSensor::Method::IGV)));
        plistener->setProgress (0.0);
    }

#ifdef _OPENMP
    #pragma omp parallel default(none) shared(rgb,vdif,hdif,chr)
#endif
    {

        float ng, eg, wg, sg, nv, ev, wv, sv, nwg, neg, swg, seg, nwv, nev, swv, sev;

#ifdef _OPENMP
        #pragma omp for
#endif

        for (int row = 0; row < height - 0; row++)
            for (int col = 0, indx = row * width + col; col < width - 0; col++, indx++) {
                int c = FC(row, col);
                rgb[c][indx] = CLIP(rawData[row][col]); //rawData = RT datas
            }

//  border_interpolate2(7, rgb);

#ifdef _OPENMP
        #pragma omp single
#endif
        {
            if (plistener) {
                plistener->setProgress (0.13);
            }
        }

#ifdef _OPENMP
        #pragma omp for
#endif

        for (int row = 5; row < height - 5; row++)
            for (int col = 5 + (FC(row, 1) & 1), indx = row * width + col, c = FC(row, col); col < width - 5; col += 2, indx += 2) {
                //N,E,W,S Gradients
                ng = (eps + (fabsf(rgb[1][indx - v1] - rgb[1][indx - v3]) + fabsf(rgb[c][indx] - rgb[c][indx - v2])) / 65535.f);;
                eg = (eps + (fabsf(rgb[1][indx + h1] - rgb[1][indx + h3]) + fabsf(rgb[c][indx] - rgb[c][indx + h2])) / 65535.f);
                wg = (eps + (fabsf(rgb[1][indx - h1] - rgb[1][indx - h3]) + fabsf(rgb[c][indx] - rgb[c][indx - h2])) / 65535.f);
                sg = (eps + (fabsf(rgb[1][indx + v1] - rgb[1][indx + v3]) + fabsf(rgb[c][indx] - rgb[c][indx + v2])) / 65535.f);
                //N,E,W,S High Order Interpolation (Li & Randhawa)
                //N,E,W,S Hamilton Adams Interpolation
                // (48.f * 65535.f) = 3145680.f
                nv = LIM(((23.0f * rgb[1][indx - v1] + 23.0f * rgb[1][indx - v3] + rgb[1][indx - v5] + rgb[1][indx + v1] + 40.0f * rgb[c][indx] - 32.0f * rgb[c][indx - v2] - 8.0f * rgb[c][indx - v4])) / 3145680.f, 0.0f, 1.0f);
                ev = LIM(((23.0f * rgb[1][indx + h1] + 23.0f * rgb[1][indx + h3] + rgb[1][indx + h5] + rgb[1][indx - h1] + 40.0f * rgb[c][indx] - 32.0f * rgb[c][indx + h2] - 8.0f * rgb[c][indx + h4])) / 3145680.f, 0.0f, 1.0f);
                wv = LIM(((23.0f * rgb[1][indx - h1] + 23.0f * rgb[1][indx - h3] + rgb[1][indx - h5] + rgb[1][indx + h1] + 40.0f * rgb[c][indx] - 32.0f * rgb[c][indx - h2] - 8.0f * rgb[c][indx - h4])) / 3145680.f, 0.0f, 1.0f);
                sv = LIM(((23.0f * rgb[1][indx + v1] + 23.0f * rgb[1][indx + v3] + rgb[1][indx + v5] + rgb[1][indx - v1] + 40.0f * rgb[c][indx] - 32.0f * rgb[c][indx + v2] - 8.0f * rgb[c][indx + v4])) / 3145680.f, 0.0f, 1.0f);
                //Horizontal and vertical color differences
                vdif[indx >> 1] = (sg * nv + ng * sv) / (ng + sg) - (rgb[c][indx]) / 65535.f;
                hdif[indx >> 1] = (wg * ev + eg * wv) / (eg + wg) - (rgb[c][indx]) / 65535.f;
            }

#ifdef _OPENMP
        #pragma omp single
#endif
        {
            if (plistener) {
                plistener->setProgress (0.26);
            }
        }

#ifdef _OPENMP
        #pragma omp for
#endif

        for (int row = 7; row < height - 7; row++)
            for (int col = 7 + (FC(row, 1) & 1), indx = row * width + col, c = FC(row, col), d = c / 2; col < width - 7; col += 2, indx += 2) {
                //H&V integrated gaussian vector over variance on color differences
                //Mod Jacques 3/2013
                ng = LIM(epssq + 78.0f * SQR(vdif[indx >> 1]) + 69.0f * (SQR(vdif[(indx - v2) >> 1]) + SQR(vdif[(indx + v2) >> 1])) + 51.0f * (SQR(vdif[(indx - v4) >> 1]) + SQR(vdif[(indx + v4) >> 1])) + 21.0f * (SQR(vdif[(indx - v6) >> 1]) + SQR(vdif[(indx + v6) >> 1])) - 6.0f * SQR(vdif[(indx - v2) >> 1] + vdif[indx >> 1] + vdif[(indx + v2) >> 1])
                         - 10.0f * (SQR(vdif[(indx - v4) >> 1] + vdif[(indx - v2) >> 1] + vdif[indx >> 1]) + SQR(vdif[indx >> 1] + vdif[(indx + v2) >> 1] + vdif[(indx + v4) >> 1])) - 7.0f * (SQR(vdif[(indx - v6) >> 1] + vdif[(indx - v4) >> 1] + vdif[(indx - v2) >> 1]) + SQR(vdif[(indx + v2) >> 1] + vdif[(indx + v4) >> 1] + vdif[(indx + v6) >> 1])), 0.f, 1.f);
                eg = LIM(epssq + 78.0f * SQR(hdif[indx >> 1]) + 69.0f * (SQR(hdif[(indx - h2) >> 1]) + SQR(hdif[(indx + h2) >> 1])) + 51.0f * (SQR(hdif[(indx - h4) >> 1]) + SQR(hdif[(indx + h4) >> 1])) + 21.0f * (SQR(hdif[(indx - h6) >> 1]) + SQR(hdif[(indx + h6) >> 1])) - 6.0f * SQR(hdif[(indx - h2) >> 1] + hdif[indx >> 1] + hdif[(indx + h2) >> 1])
                         - 10.0f * (SQR(hdif[(indx - h4) >> 1] + hdif[(indx - h2) >> 1] + hdif[indx >> 1]) + SQR(hdif[indx >> 1] + hdif[(indx + h2) >> 1] + hdif[(indx + h4) >> 1])) - 7.0f * (SQR(hdif[(indx - h6) >> 1] + hdif[(indx - h4) >> 1] + hdif[(indx - h2) >> 1]) + SQR(hdif[(indx + h2) >> 1] + hdif[(indx + h4) >> 1] + hdif[(indx + h6) >> 1])), 0.f, 1.f);
                //Limit chrominance using H/V neighbourhood
                nv = median(0.725f * vdif[indx >> 1] + 0.1375f * vdif[(indx - v2) >> 1] + 0.1375f * vdif[(indx + v2) >> 1], vdif[(indx - v2) >> 1], vdif[(indx + v2) >> 1]);
                ev = median(0.725f * hdif[indx >> 1] + 0.1375f * hdif[(indx - h2) >> 1] + 0.1375f * hdif[(indx + h2) >> 1], hdif[(indx - h2) >> 1], hdif[(indx + h2) >> 1]);
                //Chrominance estimation
                chr[d][indx] = (eg * nv + ng * ev) / (ng + eg);
                //Green channel population
                rgb[1][indx] = rgb[c][indx] + 65535.f * chr[d][indx];
            }

#ifdef _OPENMP
        #pragma omp single
#endif
        {
            if (plistener) {
                plistener->setProgress (0.39);
            }
        }

//  free(vdif); free(hdif);
#ifdef _OPENMP
        #pragma omp for
#endif

        for (int row = 7; row < height - 7; row += 2)
            for (int col = 7 + (FC(row, 1) & 1), indx = row * width + col, c = 1 - FC(row, col) / 2; col < width - 7; col += 2, indx += 2) {
                //NW,NE,SW,SE Gradients
                nwg = 1.0f / (eps + fabsf(chr[c][indx - v1 - h1] - chr[c][indx - v3 - h3]) + fabsf(chr[c][indx + v1 + h1] - chr[c][indx - v3 - h3]));
                neg = 1.0f / (eps + fabsf(chr[c][indx - v1 + h1] - chr[c][indx - v3 + h3]) + fabsf(chr[c][indx + v1 - h1] - chr[c][indx - v3 + h3]));
                swg = 1.0f / (eps + fabsf(chr[c][indx + v1 - h1] - chr[c][indx + v3 + h3]) + fabsf(chr[c][indx - v1 + h1] - chr[c][indx + v3 - h3]));
                seg = 1.0f / (eps + fabsf(chr[c][indx + v1 + h1] - chr[c][indx + v3 - h3]) + fabsf(chr[c][indx - v1 - h1] - chr[c][indx + v3 + h3]));
                //Limit NW,NE,SW,SE Color differences
                nwv = median(chr[c][indx - v1 - h1], chr[c][indx - v3 - h1], chr[c][indx - v1 - h3]);
                nev = median(chr[c][indx - v1 + h1], chr[c][indx - v3 + h1], chr[c][indx - v1 + h3]);
                swv = median(chr[c][indx + v1 - h1], chr[c][indx + v3 - h1], chr[c][indx + v1 - h3]);
                sev = median(chr[c][indx + v1 + h1], chr[c][indx + v3 + h1], chr[c][indx + v1 + h3]);
                //Interpolate chrominance: R@B and B@R
                chr[c][indx] = (nwg * nwv + neg * nev + swg * swv + seg * sev) / (nwg + neg + swg + seg);
            }

#ifdef _OPENMP
        #pragma omp single
#endif
        {
            if (plistener) {
                plistener->setProgress (0.52);
            }
        }
#ifdef _OPENMP
        #pragma omp for
#endif

        for (int row = 8; row < height - 7; row += 2)
            for (int col = 7 + (FC(row, 1) & 1), indx = row * width + col, c = 1 - FC(row, col) / 2; col < width - 7; col += 2, indx += 2) {
                //NW,NE,SW,SE Gradients
                nwg = 1.0f / (eps + fabsf(chr[c][indx - v1 - h1] - chr[c][indx - v3 - h3]) + fabsf(chr[c][indx + v1 + h1] - chr[c][indx - v3 - h3]));
                neg = 1.0f / (eps + fabsf(chr[c][indx - v1 + h1] - chr[c][indx - v3 + h3]) + fabsf(chr[c][indx + v1 - h1] - chr[c][indx - v3 + h3]));
                swg = 1.0f / (eps + fabsf(chr[c][indx + v1 - h1] - chr[c][indx + v3 + h3]) + fabsf(chr[c][indx - v1 + h1] - chr[c][indx + v3 - h3]));
                seg = 1.0f / (eps + fabsf(chr[c][indx + v1 + h1] - chr[c][indx + v3 - h3]) + fabsf(chr[c][indx - v1 - h1] - chr[c][indx + v3 + h3]));
                //Limit NW,NE,SW,SE Color differences
                nwv = median(chr[c][indx - v1 - h1], chr[c][indx - v3 - h1], chr[c][indx - v1 - h3]);
                nev = median(chr[c][indx - v1 + h1], chr[c][indx - v3 + h1], chr[c][indx - v1 + h3]);
                swv = median(chr[c][indx + v1 - h1], chr[c][indx + v3 - h1], chr[c][indx + v1 - h3]);
                sev = median(chr[c][indx + v1 + h1], chr[c][indx + v3 + h1], chr[c][indx + v1 + h3]);
                //Interpolate chrominance: R@B and B@R
                chr[c][indx] = (nwg * nwv + neg * nev + swg * swv + seg * sev) / (nwg + neg + swg + seg);
            }

#ifdef _OPENMP
        #pragma omp single
#endif
        {
            if (plistener) {
                plistener->setProgress (0.65);
            }
        }
#ifdef _OPENMP
        #pragma omp for
#endif

        for (int row = 7; row < height - 7; row++)
            for (int col = 7 + (FC(row, 0) & 1), indx = row * width + col; col < width - 7; col += 2, indx += 2) {
                //N,E,W,S Gradients
                ng = 1.0f / (eps + fabsf(chr[0][indx - v1] - chr[0][indx - v3]) + fabsf(chr[0][indx + v1] - chr[0][indx - v3]));
                eg = 1.0f / (eps + fabsf(chr[0][indx + h1] - chr[0][indx + h3]) + fabsf(chr[0][indx - h1] - chr[0][indx + h3]));
                wg = 1.0f / (eps + fabsf(chr[0][indx - h1] - chr[0][indx - h3]) + fabsf(chr[0][indx + h1] - chr[0][indx - h3]));
                sg = 1.0f / (eps + fabsf(chr[0][indx + v1] - chr[0][indx + v3]) + fabsf(chr[0][indx - v1] - chr[0][indx + v3]));
                //Interpolate chrominance: R@G and B@G
                chr[0][indx] = ((ng * chr[0][indx - v1] + eg * chr[0][indx + h1] + wg * chr[0][indx - h1] + sg * chr[0][indx + v1]) / (ng + eg + wg + sg));
            }

#ifdef _OPENMP
        #pragma omp single
#endif
        {
            if (plistener) {
                plistener->setProgress (0.78);
            }
        }
#ifdef _OPENMP
        #pragma omp for
#endif

        for (int row = 7; row < height - 7; row++)
            for (int col = 7 + (FC(row, 0) & 1), indx = row * width + col; col < width - 7; col += 2, indx += 2) {

                //N,E,W,S Gradients
                ng = 1.0f / (eps + fabsf(chr[1][indx - v1] - chr[1][indx - v3]) + fabsf(chr[1][indx + v1] - chr[1][indx - v3]));
                eg = 1.0f / (eps + fabsf(chr[1][indx + h1] - chr[1][indx + h3]) + fabsf(chr[1][indx - h1] - chr[1][indx + h3]));
                wg = 1.0f / (eps + fabsf(chr[1][indx - h1] - chr[1][indx - h3]) + fabsf(chr[1][indx + h1] - chr[1][indx - h3]));
                sg = 1.0f / (eps + fabsf(chr[1][indx + v1] - chr[1][indx + v3]) + fabsf(chr[1][indx - v1] - chr[1][indx + v3]));
                //Interpolate chrominance: R@G and B@G
                chr[1][indx] = ((ng * chr[1][indx - v1] + eg * chr[1][indx + h1] + wg * chr[1][indx - h1] + sg * chr[1][indx + v1]) / (ng + eg + wg + sg));
            }

#ifdef _OPENMP
        #pragma omp single
#endif
        {
            if (plistener) {
                plistener->setProgress (0.91);
            }

            //Interpolate borders
//  border_interpolate2(7, rgb);
        }
        /*
#ifdef _OPENMP
        #pragma omp for
#endif
            for (int row=0; row < height; row++)  //borders
                for (int col=0; col < width; col++) {
                    if (col==7 && row >= 7 && row < height-7)
                        col = width-7;
                    int indxc=row*width+col;
                    red  [row][col] = rgb[indxc][0];
                    green[row][col] = rgb[indxc][1];
                    blue [row][col] = rgb[indxc][2];
                }
        */

#ifdef _OPENMP
        #pragma omp for
#endif

        for(int row = 7; row < height - 7; row++)
            for(int col = 7, indx = row * width + col; col < width - 7; col++, indx++) {
                red  [row][col] = CLIP(rgb[1][indx] - 65535.f * chr[0][indx]);
                green[row][col] = CLIP(rgb[1][indx]);
                blue [row][col] = CLIP(rgb[1][indx] - 65535.f * chr[1][indx]);
            }
    }// End of parallelization

    if (plistener) {
        plistener->setProgress (1.0);
    }

    free(chrarray);
    free(rgbarray);
    free(vdif);
    free(hdif);
}
#endif
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on July 15, 2018, 11:36:03 PM
Quote from: masc on July 15, 2018, 10:27:53 PM
2) That should be possible to add... let's see... but you'll get a very blurred image.

If it blurs the image too much, it wouldn't be of much use.  It should preserve fine detail as it does in DaVinci Resolve for example.  Also, it should allow a very fine adjustment as this is the case with the blur radius slider.  This will make it possible to clean the most intrusive monochrome noise while leaving the rest in the image for a more cinematic look.  I will be looking forward to it!  Thanks, Masc.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 15, 2018, 11:56:15 PM
Quote from: IDA_ML on July 15, 2018, 11:36:03 PM
If it blurs the image too much, it wouldn't be of much use.  It should preserve fine detail as it does in DaVinci Resolve for example.  Also, it should allow a very fine adjustment as this is the case with the blur radius slider.  This will make it possible to clean the most intrusive monochrome noise while leaving the rest in the image for a more cinematic look.  I will be looking forward to it!  Thanks, Masc.

A proper denoising algo would be better, no? This (https://github.com/Khanattila/KNLMeansCL/blob/master/KNLMeansCL/NLMKernel.cpp) and this (https://github.com/npd/nl-bayes/blob/master/NLBayes.cpp) implementations are GPL licensed, maybe it could be adapted. Just an idea.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 18, 2018, 02:32:41 AM
Last release for Windows is crashing during batch export (ProRes 444), while using darkframe subtraction :(
Darkframe sample (averaged using MLVApp):
https://minfil.com/S8b8tdf3b6/50d_iso_100.MLV

ps: it renders ~3 files on the batch, then crashs.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 18, 2018, 11:19:57 AM
Quote from: 50mm1200s on July 18, 2018, 02:32:41 AM
Last release for Windows is crashing during batch export (ProRes 444), while using darkframe subtraction :(
Darkframe sample (averaged using MLVApp):
https://minfil.com/S8b8tdf3b6/50d_iso_100.MLV

ps: it renders ~3 files on the batch, then crashs.
Yeah... known problem. But I am not able to reproduce it on any of my computers. I can export as many files with darkframe as I like. Do you have Qt installed? We need someone who has this problem and who is able to debug.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 18, 2018, 03:12:59 PM
Quote from: 50mm1200s on July 18, 2018, 02:32:41 AM
ps: it renders ~3 files on the batch, then crashs.
I can not reproduce this either. Please do what masc suggests.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 18, 2018, 09:08:27 PM
Quote from: 50mm1200s on July 15, 2018, 11:56:15 PM
A proper denoising algo would be better, no? This (https://github.com/Khanattila/KNLMeansCL/blob/master/KNLMeansCL/NLMKernel.cpp) and this (https://github.com/npd/nl-bayes/blob/master/NLBayes.cpp) implementations are GPL licensed, maybe it could be adapted. Just an idea.
Yes, totally right. A denoising algo would be best. I could test this algo in MLVApp, because it was easy to adapt to what we need:
http://www.ipol.im/pub/art/2011/bcm_nlm/
It works but it is soooo slow - OMG - some minutes per frame, and only on Win & Linux multithreaded to work correctly. So no real solution for us ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 18, 2018, 10:37:33 PM
@masc @bouncyball How can I debug? I'm using the binary from github. Tried to execute from terminal, but it's quiet (no verbose info, even with --debug). The binary seems to use QT 5.9.1. I don't know how to compile on windows, just on linux, and I don't think this issue happens on linux (from what you're saying)...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 18, 2018, 10:43:17 PM
Quote from: 50mm1200s on July 18, 2018, 10:37:33 PM
@masc @bouncyball How can I debug? I'm using the binary from github. Tried to execute from terminal, but it's quiet (no verbose info, even with --debug). The binary seems to use QT 5.9.1. I don't know how to compile on windows, just on linux, and I don't think this issue happens on linux (from what you're saying)...
You need a installed Qt and the source code. You load the .pro into QtCreator, setup the debug mode, press debug, do the crash, and Qt tells you where it crashes. For me it also does not crash on Windows...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on July 18, 2018, 11:49:49 PM
MLV > CinemaDNG > TIFF  versus  MLV > TIFF directly

Do I get the same 14 bits of colour when I export files from the MLV app first as CinemaDNG and then convert them to 16 bit TIFF files as I would get if I export them directly into a TIFF stream from the MLV app?
Someone said that a TIFF stream directly from the MLV app only retains 8 to 10 bits of colour....
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 19, 2018, 12:08:00 AM
Quote from: olofen on July 18, 2018, 11:49:49 PM
MLV > CinemaDNG > TIFF  versus  MLV > TIFF directly

Do I get the same 14 bits of colour when I export files from the MLV app first as CinemaDNG and then convert them to 16 bit TIFF files as I would get if I export them directly into a TIFF stream from the MLV app?
Someone said that a TIFF stream directly from the MLV app only retains 8 to 10 bits of colour....

No you don't get the same colour. But this is no question of bitdepth. MLVApp exports 16bit TIFF.
If you export TIFF directly you export processed data. If you export cDNG, you export RAW data. The RAW data has to be processed somewhere else. I bet it won't be processed in the exact same way as MLVApp does. So the colour will be different.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on July 19, 2018, 07:08:40 AM
Quote from: masc on July 19, 2018, 12:08:00 AM
No you don't get the same colour. But this is no question of bitdepth. MLVApp exports 16bit TIFF.
If you export TIFF directly you export processed data. If you export cDNG, you export RAW data. The RAW data has to be processed somewhere else. I bet it won't be processed in the exact same way as MLVApp does. So the colour will be different.
What would you recommend - to make the adjustments in the MLV app as a Raw processor and export as processed Tiffs OR export as CinemaDNGs and process in a Raw processor like Photoshop?

I want to work with my videos in Photoshop therefore the CinemaDNGs...
Do you know any other way of getting the videos from MLV to photoshop as untouched as possible?

(I am an artist in photography for soon 40 years and now I going into film! My favourite tool since 1990 is Photoshop and I want to be able to continue with it if possible. I found out that I could import Avi´s and Tiff streams among others into it but I want to know which sort of file is the best one and got the most info to get me the maximum freedom in working with the films)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Dmytro_ua on July 19, 2018, 10:27:17 AM
Quote from: olofen on July 19, 2018, 07:08:40 AM
I want to work with my videos in Photoshop therefore the CinemaDNGs...
Do you know any other way of getting the videos from MLV to photoshop as untouched as possible?

If you're good with PS, then for video I recommend you to use After Effects as it uses Adobe Camera Raw to interpret DNG files.
I wouldn't use PS for video in any case.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 19, 2018, 10:43:23 AM
Quote from: olofen on July 19, 2018, 07:08:40 AM
...as untouched as possible...
= RAW = CinemaDNG.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 19, 2018, 11:14:45 AM
Quote from: masc on July 18, 2018, 10:43:17 PM
You need a installed Qt and the source code. You load the .pro into QtCreator, setup the debug mode, press debug, do the crash, and Qt tells you where it crashes. For me it also does not crash on Windows...

Ok, I'm trying.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 19, 2018, 11:15:13 AM
Just curious: does MLVApp autodetects white levels or use predefined values?
@a1ex explained why this would be a good idea:
https://www.magiclantern.fm/forum/index.php?topic=10111.msg98298#msg98298
https://www.magiclantern.fm/forum/index.php?topic=10111.msg98359#msg98359
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 19, 2018, 11:18:08 AM
Quote from: 50mm1200s on July 19, 2018, 11:15:13 AM
Just curious: does MLVApp autodetects white levels or use predefined values?
@a1ex explained why this would be a good idea:
https://www.magiclantern.fm/forum/index.php?topic=10111.msg98298#msg98298
https://www.magiclantern.fm/forum/index.php?topic=10111.msg98359#msg98359
MLVApp reads out the whitelevels which are saved in the MLV by the camera. These values might be wrong (I saw that @ 7D and others already), this is why we implemented RAW white level slider - so you can adjust it manually to the right value.

Quote from: 50mm1200s on July 19, 2018, 11:14:45 AM
Ok, I'm trying.
Great! Feel free to ask if you have problems with it...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 19, 2018, 11:30:40 AM
Quote from: masc on July 18, 2018, 09:08:27 PM
Yes, totally right. A denoising algo would be best. I could test this algo in MLVApp, because it was easy to adapt to what we need:
http://www.ipol.im/pub/art/2011/bcm_nlm/
It works but it is soooo slow - OMG - some minutes per frame, and only on Win & Linux multithreaded to work correctly. So no real solution for us ;)

:(
I've found this implementation of BM3D that according to the author "can be used in real-time video denoising", using CUDA:
https://github.com/JeffOwOSun/gpu-bm3d

There's also this page linking to many denoise code and papers:
https://github.com/wenbihan/reproducible-image-denoising-state-of-the-art
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 19, 2018, 12:04:53 PM
Oh, this site looks interesting... so many algorithms?! Thx! Unfortunatelly CUDA is no solution for me... that works on none of my computers... :D (what is my main reason for developping this app)

BTW: IGV demosaic is available in MLVApp now! ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 19, 2018, 02:32:43 PM
You are fast @masc.
What is IGV demosaicing doing? Hadn´t had the time to check into reading yet.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 19, 2018, 03:12:48 PM
Quote from: Danne on July 19, 2018, 02:32:43 PM
You are fast @masc.
What is IGV demosaicing doing? Hadn´t had the time to check into reading yet.
Puh... don't ask me... :D "Bayer CFA Demosaicing using Integrated Gaussian Vector on Color Differences". I found an implementation which was not to different from our AMaZE interface, adapted the code and voilà. In hard contrast scenes it looks slightly better than AMaZE, therefor it looks a bit more noisy (specially after sharpening). One disadvantage is a bad 8pix border, where the algorithm is not able to work - in this areas there is an easier border-algorithm working, which produces some artifacts (e.g. on water). Looks a bit like bilinear... but I don't really know... :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 19, 2018, 03:30:18 PM
@masc QTCreator points me to line 361 of the file amaze_demosaic.c (on debayer folder), after segfaulting. He also has two warnings (line 364 and 366) saying: "use of GNU statement expression extension". If you need more information, just point me where to find it...

Also, IGV implementation is really nice. A Danne said, you're quite fast. Nice job.

edit: this is about the darkframe subtraction issue, BTW...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 19, 2018, 03:41:39 PM
Quote from: 50mm1200s on July 19, 2018, 03:30:18 PM
@masc QTCreator points me to line 361 of the file amaze_demosaic.c (on debayer folder), after segfaulting. He also has two warnings (line 364 and 366) saying: "use of GNU statement expression extension". If you need more information, just point me where to find it...

Also, IGV implementation is really nice. A Danne said, you're quite fast. Nice job.

edit: this is about the darkframe subtraction issue, BTW...
Thx! So it crashes in this line? memset(nyquist, 0, sizeof(char)*TS*TSH); No idea what could shut up amaze algorithm... :( I am lost. And I don't understand why it only crashes on export... preview is running 100% the same code.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 19, 2018, 04:20:07 PM
Quote from: masc on July 19, 2018, 03:41:39 PM
Thx! So it crashes in this line? memset(nyquist, 0, sizeof(char)*TS*TSH);

Yep. Or so does QT tells me, don't know if it's accurate...

Quote
No idea what could shut up amaze algorithm... :( I am lost. And I don't understand why it only crashes on export... preview is running 100% the same code.

Maybe because of multiprocessing? Memory allocation is different on both cases, don't?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 19, 2018, 04:42:39 PM
Quote from: 50mm1200s on July 19, 2018, 04:20:07 PM
Maybe because of multiprocessing? Memory allocation is different on both cases, don't?
Mulitprocessing is always running. But you could try to make amaze single threaded. Go to line 33 in debayer.c and change
if (threads < 2)
to
if (1)
Could you also test, if it happens the same with any other demosaic algorithm? You can now chose between 4 types in the export settings.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on July 19, 2018, 10:41:24 PM
Quote from: masc on July 19, 2018, 10:43:23 AM
= RAW = CinemaDNG.


...but the MVL app almost look like a RAW processing app! Perhaps it gives enough of the videos as to be compared to a RAW processor?
And if so is AVI the best output to save the quality of the files? Or?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 19, 2018, 10:51:27 PM
Quote from: olofen on July 19, 2018, 10:41:24 PM
...but the MVL app almost look like a RAW processing app! Perhaps it gives enough of the videos as to be compared to a RAW processor?
And if so is AVI the best output to save the quality of the files? Or?
Sure - this was the main idea of the app. But, what do you do in Photoshop, if you color correct in MLVApp? If you like the look more than from Adobes RAW processor, use it! AVI has only 8 or 10 bits bitdepth. ProRes 4444 (AVFoundation on OSX) has 12bit. TIFF would be absolutely uncompressed and really huge.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on July 19, 2018, 11:03:40 PM
Quote from: masc on July 19, 2018, 10:51:27 PM
Sure - this was the main idea of the app. But, what do you do in Photoshop, if you color correct in MLVApp? If you like the look more than from Adobes RAW processor, use it! AVI has only 8 or 10 bits bitdepth. ProRes 4444 (AVFoundation on OSX) has 12bit. TIFF would be absolutely uncompressed and really huge.


I want to do all sorts of filtering - parts or whole with many layers and even do special constructs. all in all work with every video just like with a still photograph. The exact look from the file coming out of the MLV app is not that important BUT what is is to have as much inrformation as possible in the file to work with

I think I will try CinemaDNG with the possibility of converting to TIFF and with a proxy of perhaps ProRes4444...

Is the TIFF files from the MLV app the same as going via CinemaDNG to TIFF? If so then I can use the MLV instead of CinemaDNG....

How about ProRes RAW?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 20, 2018, 11:30:17 AM
Quote from: olofen on July 19, 2018, 11:03:40 PM
Is the TIFF files from the MLV app the same as going via CinemaDNG to TIFF? If so then I can use the MLV instead of CinemaDNG....

How about ProRes RAW?
Already answered: https://www.magiclantern.fm/forum/index.php?topic=20025.msg204317#msg204317
It won't be the same and depends on how you get a picture out of the RAW CinemaDNG.

ProRes RAW is not supported by MLV App. And if it would be supported... RAW=RAW (in terms of encoded information), where shall be the difference?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 20, 2018, 12:12:45 PM
Tiff=hardcoded white balance, the same goes for prores which also reduces color from 14 to 12 or 10bit. If you want layers on dng files run after effects or maybe lightroom.
If tiff files and photoshop works for you, just stick to that. Whatever you choose color and dynamic range information should be sufficient whatever you pick. Pay attention to white balance...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on July 20, 2018, 11:59:36 PM
Thank you very much masc and Danne  :D :D :D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 21, 2018, 12:54:09 AM
Quote from: masc on July 19, 2018, 04:42:39 PM
But you could try to make amaze single threaded.
Quote
Could you also test, if it happens the same with any other demosaic algorithm? You can now chose between 4 types in the export settings.

Using bilinear demosaicing, it segfaulted on line 411 of video_mlv.c


memcpy(outputFrame, video->rgb_raw_current_frame, frame_size);


And warnings on lines 404, 408 and 409:

"implicit conversion changes signedness: 'int' to 'unsigned int'"


On line 409 it also says:


implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int'


The same happens using one thread ("if (1)" on debayer.c), with both bilinear and AMaZE.
There's a strage warning on application output, though:


ReturnHr(338) tid(23b8) 8007000F The system could not find the specified unit.
onecoreuap\shell\windows.storage\regfldr.cpp(1239)\windows.storage.dll!7666ED09: (caller: 7666C430)


Using LMSSE and IGV, the debugger doesn't seem to be able to find the issue. It just crashs: "The program has unexpectedly finished. The process was ended forcefully". And then points me to the debug folder.

Any idea?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 21, 2018, 03:09:27 AM
Quote from: Teamsleepkid on July 21, 2018, 02:49:05 AM
prores raw would be awesome because its like raw and a proxy in the same file (you can play it back with regular hardware). if we could output to prores raw that would be cool. also if i could put my a7sii footage through and have it come out prores raw that would be cool too. no app for that yet on the market. i know the a7s footage wouldn't be raw but it would be the same file format as my eosm footage and that would be awesome. please don't consider this as a request or demand just talking trash.

You cannot convert non-raw data into raw bayer data. I think you folks need to read more about what a Raw image is, so you can understand the process.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 21, 2018, 11:05:34 AM
Quote from: 50mm1200s on July 21, 2018, 12:54:09 AM
Using bilinear demosaicing, it segfaulted on line 411 of video_mlv.c


memcpy(outputFrame, video->rgb_raw_current_frame, frame_size);


And warnings on lines 404, 408 and 409:

"implicit conversion changes signedness: 'int' to 'unsigned int'"


On line 409 it also says:


implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int'


The same happens using one thread ("if (1)" on debayer.c), with both bilinear and AMaZE.
There's a strage warning on application output, though:


ReturnHr(338) tid(23b8) 8007000F The system could not find the specified unit.
onecoreuap\shell\windows.storage\regfldr.cpp(1239)\windows.storage.dll!7666ED09: (caller: 7666C430)


Using LMSSE and IGV, the debugger doesn't seem to be able to find the issue. It just crashs: "The program has unexpectedly finished. The process was ended forcefully". And then points me to the debug folder.

Any idea?

Thank you so much for debugging @50mm1200s. But that sounds all very strange. There is another problem on Windows with caching: I did not understand the problem Windows has there... on Unix all is fine. I will create a issue task on GitHub to save all your information. So we can collect all and read it easily. Maybe an idea comes one day...
https://github.com/ilia3101/MLV-App/issues/96

For line 409 I changed one parameter type. Maybe that helps. But I really don't understand the other warnings in line 404, 408 and 409. Is that really in video_mlv.c?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on July 21, 2018, 03:14:10 PM
Quote from: masc on July 21, 2018, 11:05:34 AM
Thank you so much for debugging @50mm1200s. But that sounds all very strange. There is another problem on Windows with caching: I did not understand the problem Windows has there... on Unix all is fine. I will create a issue task on GitHub to save all your information. So we can collect all and read it easily. Maybe an idea comes one day...
https://github.com/ilia3101/MLV-App/issues/96

One of the outputs seems to be BS from the debugger:
https://social.msdn.microsoft.com/Forums/en-US/aeb5b9a7-d23a-43bb-a8c7-131b853d05de/loads-of-senseless-debug-info-show-up-in-the-qt-application-output-window-when-i-run-a-simple-test?forum=windbg

So all warnings up to now are related to memory issues. Could Valgrind (http://valgrind.org/) detect it, perhaps?

Quote
For line 409 I changed one parameter type. Maybe that helps. But I really don't understand the other warnings in line 404, 408 and 409. Is that really in video_mlv.c?

Cool, I'll see if I can test with the new parameter and confirm the video_mlv.c issue.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 21, 2018, 04:34:44 PM
@50mm1200s: did you compile with Visual Studio compiler? Normally we use MinGW (comes with Qt normally) - that should be different. But would be nice to know that it compiles with Visual Studio as well ;)

I never used valgrind... but if you know how to use it... would be very cool if you could help ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 21, 2018, 05:29:46 PM
Quote from: 50mm1200s on July 21, 2018, 03:14:10 PM
So all warnings up to now are related to memory issues. Could Valgrind (http://valgrind.org/) detect it, perhaps?
Cool, I'll see if I can test with the new parameter and confirm the video_mlv.c issue.
Now it's rolling to the right direction! Cool man! Thanx! You are one step closer to become MLV App dev :D (what we're gonna appreciate very much).

bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 21, 2018, 05:33:28 PM
Quote from: masc on July 21, 2018, 04:34:44 PM
But would be nice to know that it compiles with Visual Studio as well ;)
I tried it once but experienced fiasco. Very interesting if it's possible w/o a big PITA.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 22, 2018, 02:37:25 PM
Quote from: 50mm1200s on July 21, 2018, 12:54:09 AM
And warnings on lines 404, 408 and 409:

"implicit conversion changes signedness: 'int' to 'unsigned int'"


On line 409 it also says:


implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int'

Makes no sense :(

All vars/parameters are with correct types there. No any type conversion is done.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Seruji on July 23, 2018, 11:35:04 AM
Hi guys!
Question: ¿When do you recommend to do the sharpen? ¿Before or after the export into pro res 4444)? Then I will import the clip to Adobe Premiere and use Lumetri to apply some lut's or some other color correction.

(https://thumb.ibb.co/iJ5aPJ/sharp.png) (https://ibb.co/iJ5aPJ)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 23, 2018, 12:01:00 PM
Quote from: Seruji on July 23, 2018, 11:35:04 AM
Hi guys!
Question: ¿When do you recommend to do the sharpen? ¿Before or after the export into pro res 4444)? Then I will import the clip to Adobe Premiere and use Lumetri to apply some lut's or some other color correction.

(https://thumb.ibb.co/iJ5aPJ/sharp.png) (https://ibb.co/iJ5aPJ)

You asked this already and I answered:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg202442#msg202442
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Seruji on July 23, 2018, 12:25:02 PM
Quote from: masc on July 23, 2018, 12:01:00 PM
You asked this already and I answered:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg202442#msg202442
That's true! sorry about that, and thank you! :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on July 26, 2018, 06:32:48 PM
Hello @masc @Ilia3103 @bouncyball  and everyone :D

The main reason why I don't use MLVApp for quick color grading or exporting to compressed format like H.265 is the weird colors compared to other software (I am using 700D). Back to this problem the causes of this was the color matrix right? MLVApp uses color matrix from 5D2 which present nice colors for this camera.

What should I do for implementing the color matrix for 700D in the app ? isn't it implemented for all cameras  (https://github.com/ilia3101/MLV-App/blob/a9b95837ab8b572ba31c1bfacdb63352aaf21918/src/mlv/camera_matrices.c)? Can you give me where is color matrix has applied for 5D2 and what should I do to get 700D's color matrix in MLVApp in the code? Please :D .

I am wondering also if this difficult to apply ? and is there problems for that (Applying more than color matrix for each camera) ?
Thankss!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 26, 2018, 06:46:28 PM
Seems very hard to get cameraspecific color matrices workinf in Mlv App. I think Ilia built a custom one derived from 5D mark II camera files. I wonder if a "correction" 3D lut could help here.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on July 26, 2018, 07:12:49 PM
All camera matrixes are implemented and used in experimental WhiteBalance branch, but this branch has it's quirks and also has not updated a while. You can try your luck there :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 26, 2018, 07:22:03 PM
Quote from: theBilalFakhouri on July 26, 2018, 06:32:48 PM
Hello @masc @Ilia3103 @bouncyball  and everyone :D

The main reason why I don't use MLVApp for quick color grading or exporting to compressed format like H.265 is the weird colors compared to other software (I am using 700D). Back to this problem the causes of this was the color matrix right? MLVApp uses color matrix from 5D2 which present nice colors for this camera.

What should I do for implementing the color matrix for 700D in the app ? isn't it implemented for all cameras  (https://github.com/ilia3101/MLV-App/blob/a9b95837ab8b572ba31c1bfacdb63352aaf21918/src/mlv/camera_matrices.c)? Can you give me where is color matrix has applied for 5D2 and what should I do to get 700D's color matrix in MLVApp in the code? Please :D .

I am wondering also if this difficult to apply ? and is there problems for that (Applying more than color matrix for each camera) ?
Thankss!
The camera matrices are implemented in camera_matrices.c, but are completely commented out, because there is no defined way to apply them - see Ilias comments in the code.
WB multipliers are set from 5D2 in processing.c (defined in line 18-22).

Quote from: bouncyball on July 26, 2018, 07:12:49 PM
All camera matrixes are implemented and used in experimental WhiteBalance branch, but this branch has it's quirks and also has not updated a while. You can try your luck there :)
That was a try... but then 5D2 clips were ugly (which were perfect before). Don't know what exactly was the difference, but maybe only a small thing was wrong here - if you like you can try to debug there...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on July 26, 2018, 08:21:24 PM
Ok calm down I've heard a lot of complaints about the wrong colours.

Some things:
1. I would like to bust a myth - MLV App does not use any colour matrices at all right now, no "5D2 matrix for all cameras" things going on, that is just not true and I'm not sure how the myth started. Maybe it's because the white balance multipliers are generated by data I extracted from 5D mark II photos using exiftool, however that does not affect colour in any deep 5D mark II way, they simply specify the channel multiplication factors and that is it. I'm really surprised they even work considering it is unknown what colour space they are for.
2. That(fixing the colours) is actually the processing improvement I was talking about some time ago. I have been a bit demotivated though, as every time I start working on it it just gets fiddly or crashy or something is wrong with the colour(most often this). The extreme hotness of summer combined with that makes for a perfect giving up vibe.
3. @masc @bouncyball Is the WhiteBalance branch still mergeable? I don't know how to do it locally in git sorry(I can only ruin the whole github repository :D), could one of you try it out?
4. @masc Could you show a sample(s) of where WhiteBalance branch looks worse? I was thinking it might do. If this gets put in to the app, I will make sure to add an "MLV App classic" processing mode just to keep how it was before for those who had good results with it.
6. camera_matrices.c is obsolete version of what bouncyball's camid (https://github.com/ilia3101/MLV-App/tree/master/src/mlv/camid) does and will be removed. Thank you for the reminder.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 26, 2018, 08:38:19 PM
Thanks @Ilia!
Whitebalance branch is 11 commits ahead, 211 commits behind master. That makes it not easy to merge. I have a little fear.
If I remember right, it was working good for daylight clips, but was way to yellow for artifical light clips. The clip where I had big problems is deleted and I don't find it anymore... maybe you still have it?
https://github.com/ilia3101/MLV-App/commit/0e9025ec39407d8796534ad109a5c460c60caf9f
https://github.com/ilia3101/MLV-App/commit/6d0d21d183ce36d59ae7155194ba43b91d8ba37a

@theBilalFakhouri: do you have a 700D clip with bad colors, and a note in which SW it looks better? I never saw one... the 700D clips I have here are looking good in MLVApp.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 26, 2018, 08:51:01 PM
@Ilia3101
Here are a few examples:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg201167;topicseen#msg201167
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: theBilalFakhouri on July 27, 2018, 10:02:09 PM
Thanks for all for clarifying what's happening I will provide tomorrow some clips in different WB situations. @masc Sometimes the colors looks good but not natural as the camera showed it.

Edit: Okay wait the colors isn't that bad I will feedback tomorrow with some comparing photos.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on July 28, 2018, 11:37:32 PM
What are the minimum hardware (and software? Linux?) requirements for running the MLV app converting MLV files to H 264 files?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on July 29, 2018, 01:07:39 AM
What kind of hardware and software are you thinking of running it on??? I don't think hardware and software support has ever been a worry with MLV App.

It will run on any Linux distro as long as ffmpeg and qt5 work on it (you will have to compile yourself if you have a 32 bit). I have used it on a laptop from 2006 before.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on July 29, 2018, 01:17:15 AM
@Ilia3101
In processing.c this:
/* Measurements taken from 5D Mark II RAW photos using EXIFtool, surely Canon can't be wrong about WB mutipliers? */
static const int wb_kelvin[]   = {  2000,  2500,  3000,  3506,  4000,  4503,  5011,  5517,  6018,  6509,  7040,  7528,  8056,  8534,  9032,  9531, 10000 };
static const double wb_red[]   = { 1.134, 1.349, 1.596, 1.731, 1.806, 1.954, 2.081, 2.197, 2.291, 2.365, 2.444, 2.485, 2.528, 2.566, 2.612, 2.660, 2.702 };
static const double wb_green[] = { 1.155, 1.137, 1.112, 1.056, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000 };
static const double wb_blue[]  = { 4.587, 3.985, 3.184, 2.524, 2.103, 1.903, 1.760, 1.641, 1.542, 1.476, 1.414, 1.390, 1.363, 1.333, 1.296, 1.263, 1.229 };

How did you find these numbers? How can I find them for let´s say eos 100D?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 29, 2018, 10:02:50 AM
Quote from: olofen on July 28, 2018, 11:37:32 PM
What are the minimum hardware (and software? Linux?) requirements for running the MLV app converting MLV files to H 264 files?
MLVApp should run on any computer which is able to run Windows 7 (or newer) and OSX 10.8 (or newer). For Linux: our AppImage should run on Ubuntu 14.04 LTS or newer (maybe others too which use similar versions of packages). If you compile yourself it could run on many different distros (you just need ffmpeg and >=Qt5.6).
Hardware plays nearly no role: no GPU needed for example. So it should run also on very old computers and notebooks.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on July 29, 2018, 11:17:39 AM
Quote from: masc on July 29, 2018, 10:02:50 AM
MLVApp should run on any computer which is able to run Windows 7 (or newer) and OSX 10.8 (or newer). For Linux: our AppImage should run on Ubuntu 14.04 LTS or newer (maybe others too which use similar versions of packages). If you compile yourself it could run on many different distros (you just need ffmpeg and >=Qt5.6).
Hardware plays nearly no role: no GPU needed for example. So it should run also on very old computers and notebooks.

I am planning (if possible...) to use a small single board computer, an Odroid-xu4 https://www.amazon.com/ODROID-XU4-Single-Board-Computer-Gigabit/dp/B0163GEA64 or similar while travelling. To be able to convert the MLV files to H264 too see the actual movements in realtime of the videoclips at the place of filming. Without having to bother with a big laptop or such....

...or perhaps you have a better portable solution?!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on July 29, 2018, 12:34:24 PM
Until now we tried only x86 and x86_64 architecture. If Qt and ffmpeg runs on this Cortex, MLVApp should run as well - but I think you would be the first one trying that out. You will have to compile MLVApp on your own (but that's no big deal, if it is possible on that architecture). I travel with my old 13" MBP and a NextoDi.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on July 29, 2018, 05:01:21 PM
Quote from: Danne on July 26, 2018, 08:51:01 PM
@Ilia3101
Here are a few examples:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg201167;topicseen#msg201167

Thanks for that, looks very wrong. I also looked at WhiteBalance branch code recently and it seemed all wrong in there too :D I can't imagine what went on for me to have wrote that and thought it made sense.

Quote from: Danne on July 29, 2018, 01:17:15 AM
@Ilia3101
In processing.c this:
/* Measurements taken from 5D Mark II RAW photos using EXIFtool, surely Canon can't be wrong about WB mutipliers? */
static const int wb_kelvin[]   = {  2000,  2500,  3000,  3506,  4000,  4503,  5011,  5517,  6018,  6509,  7040,  7528,  8056,  8534,  9032,  9531, 10000 };
static const double wb_red[]   = { 1.134, 1.349, 1.596, 1.731, 1.806, 1.954, 2.081, 2.197, 2.291, 2.365, 2.444, 2.485, 2.528, 2.566, 2.612, 2.660, 2.702 };
static const double wb_green[] = { 1.155, 1.137, 1.112, 1.056, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000 };
static const double wb_blue[]  = { 4.587, 3.985, 3.184, 2.524, 2.103, 1.903, 1.760, 1.641, 1.542, 1.476, 1.414, 1.390, 1.363, 1.333, 1.296, 1.263, 1.229 };

How did you find these numbers? How can I find them for let´s say eos 100D?

Those numbers specify multiplying factors from camera white balance (which is the same kind of green for all of the ML cameras it seems) to different temperatures, it does not affect colour in a colour space ey kind of way. If you used a 100D to extract those numbers you should get the same results, the colours wouldn't improve.
I took pictures in 500k white balance increments then used exiftool to get those numbers, I don't remember what the exif tag was called.

It's nothing to do with camera colour, it's just a super unscientific way of doing white balance.

Quote from: Ilia3101 on July 26, 2018, 08:21:24 PM
the white balance multipliers are generated by data I extracted from 5D mark II photos using exiftool, however that does not affect colour in any deep 5D mark II way, they simply specify the channel multiplication factors and that is it. I'm really surprised they even work considering it is unknown what colour space they are for.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on July 29, 2018, 05:04:24 PM
@masc I've ran it on fedora too, though it needed some tiny extra package to be installed (forgot what it's called).

Quote from: masc on July 29, 2018, 12:34:24 PM
Until now we tried only x86 and x86_64 architecture. If Qt and ffmpeg runs on this Cortex, MLVApp should run as well - but I think you would be the first one trying that out. You will have to compile MLVApp on your own (but that's no big deal, if it is possible on that architecture). I travel with my old 13" MBP and a NextoDi.

I tried compiling on raspberry pi, but it seems to only have Qt 4 available by default, Qt5 would need to be manually compiled. Also getting the Qt-multimedia module is generally a pain on most distros (except the 2 that are in the compiling tutorial).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: escho on July 29, 2018, 05:33:11 PM
Quote from: Ilia3101 on July 29, 2018, 05:04:24 PM

I tried compiling on raspberry pi, but it seems to only have Qt 4 available by default, Qt5 would need to be manually compiled. Also getting the Qt-multimedia module is generally a pain on most distros (except the 2 that are in the compiling tutorial).

Depends on the OS, you,ve flashed to the rasp, I guess
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on August 02, 2018, 06:54:23 PM
Can I use the MLV app to process Dual Iso videos?
If not what to use?  (High Sierra)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 02, 2018, 08:42:27 PM
Quote from: olofen on August 02, 2018, 06:54:23 PM
Can I use the MLV app to process Dual Iso videos?
If not what to use?  (High Sierra)
Yes you can use MLVApp for dual iso. Processing is 20bit (attaching low and high iso).
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Jerchongkong on August 02, 2018, 09:05:11 PM
I cannot compile this in windows, how can I fix it?  ???
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on August 02, 2018, 11:56:30 PM
Quote from: bouncyball on July 15, 2018, 10:05:46 AM
@togg

Upload the sample please.

Here: http://www.mediafire.com/file/sd70wi2ziuxnrbh/Extreme_hot_pixel/file 

I've cutted a sample of an MLV file that has a lot of bad pixels, mostly fixed by the aggressive pass but around 5 or more still passed on. I think the detection could be improved.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on August 03, 2018, 12:45:31 AM
@masc @bouncyball sorry for the late reply. I did not gave up on the darkframe issue, just had some work to do...

Sorry if this post is too 'verbose'. I didn't know what info was relevant, so I copied most of it.
From many tests, the function "getMlvRawFrameDebayered" on video_mlv.c always shows up on all demosaicing algos, except LMMSE. Lines 411 and 435 of video_mlv.c for Bilinear, AMaZE and IGV. See below for details...

I'm using MinGW to compile, not VS.
Tested again, with the change committed (https://github.com/ilia3101/MLV-App/commit/d58fc18a3a293d511fe4b5b37e1e08ff206e235c).
With AMaZE, it segfaulted on line 1496 of amaze_demosaic.c (reproduced twice):


blue[row][col]=65535.0f*(rgbgreen[indx]-Dgrb[1][indx>>1]);


Too many warnings, most of them saying "redundant parenthesis surrouding declarator". So I copied only the ones I've found to be relevant:


MLV-App\src\debayer\amaze_demosaic.c:137: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:153: warning: implicit conversion loses floating-point precision: 'double' to 'float'
MLV-App\src\debayer\amaze_demosaic.c:331: warning: implicit conversion loses floating-point precision: 'double' to 'float'
MLV-App\src\debayer\amaze_demosaic.c:332: warning: implicit conversion loses floating-point precision: 'double' to 'float'
MLV-App\src\debayer\amaze_demosaic.c:1071: warning: implicit conversion changes signedness: 'int' to 'unsigned int'
MLV-App\src\debayer\amaze_demosaic.c:1364: warning: implicit conversion loses floating-point precision: 'double' to 'float'
MLV-App\src\debayer\amaze_demosaic.c:1364: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:1364: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:1365: warning: implicit conversion loses floating-point precision: 'double' to 'float'
MLV-App\src\debayer\amaze_demosaic.c:1365: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:1365: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:1366: warning: implicit conversion loses floating-point precision: 'double' to 'float'
MLV-App\src\debayer\amaze_demosaic.c:1366: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:1366: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:1367: warning: implicit conversion loses floating-point precision: 'double' to 'float'
MLV-App\src\debayer\amaze_demosaic.c:1367: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:1367: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:1394: warning: implicit conversion loses floating-point precision: 'double' to 'float'
MLV-App\src\debayer\amaze_demosaic.c:1394: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:1394: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:1402: warning: implicit conversion loses floating-point precision: 'double' to 'float'
MLV-App\src\debayer\amaze_demosaic.c:1402: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:1402: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:1549: warning: implicit conversion loses floating-point precision: 'double' to 'float'
MLV-App\src\debayer\amaze_demosaic.c:1549: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:1550: warning: implicit conversion loses floating-point precision: 'double' to 'float'
MLV-App\src\debayer\amaze_demosaic.c:1550: warning: implicit conversion increases floating-point precision: 'float' to 'double'
MLV-App\src\debayer\amaze_demosaic.c:1551: warning: implicit conversion loses floating-point precision: 'double' to 'float'
MLV-App\src\debayer\amaze_demosaic.c:1551: warning: implicit conversion increases floating-point precision: 'float' to 'double'


On the second and fourth attempt it segfaulted on line 361 of amaze_demosaic.c, same warnings:


memset(nyquist, 0, sizeof(char)*TS*TSH);


So I tried again, just to be sure the issue was on line 1496 and 361, but this time it segfaulted on line 432 of video_mlv.c. What the f*ck:


uint16_t * unprocessed_frame = malloc( rgb_frame_size * sizeof(uint16_t) );


Tried again, and he segfaulted on line 411 of video_mlv.c:


memcpy(outputFrame, video->rgb_raw_current_frame, frame_size)


And 435 of video_mlv.c (same as IGV, see below):


getMlvRawFrameDebayered(video, frameIndex, unprocessed_frame);


Using IGV and Bilinear for demosaicing, he crashed on line 388 of igv_demosaic.c:


chr[d][indx]=(eg*nv+ng*ev)/(ng+eg);


Also line 489 of video_mlv.c:


get_mlv_raw_frame_debayered(video, frameIndex, raw_frame, video->rgb_raw_current_frame, doesMlvAlwaysUseAmaze(video));


And line 435:


  getMlvRawFrameDebayered(video, frameIndex, unprocessed_frame);


LMMSE does not show the same issue on video_mlv.c. Instead, it crashes on line 338 of dmzhangwu.c:


OutputRed[i+dataOffset] = OutputGreen[i+dataOffset] - DiffGR[i];


Some stuff shows on malloc.h. He repeats many times this warning:


warning: macro name is reserved identifier


There's one different warning on first lines of malloc.h:


warning: unterminated '#pragma pack (push, ...)' at end of file



I'll boot Debian now and see if I can run some memory debugger...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on August 03, 2018, 02:31:26 AM
Since I was already compiling MLVApp, thought it would be nice to test the WB branch.

With picker on 18% gray card:

(https://pictshare.net/jx0p50itil.jpg)

With skin WB picker:

(https://pictshare.net/9fmusn0bur.jpg)

With WhiteBalance branch with the same settings as the 18% picker:

(https://pictshare.net/y8qiw7flqt.jpg)

With WhiteBalance branch trying to match 18% picker:

(https://pictshare.net/k8cbb5yijh.jpg)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on August 03, 2018, 03:27:03 AM
Comparison between Saturation and the new Vibrance implemented by @masc

Saturation at 75:
(https://pictshare.net/4962fkge1n.jpg)

Vibrance at 75:
(https://pictshare.net/xox0awwnwb.jpg)

Vibrance at 100:
(https://pictshare.net/g3acua8j1o.jpg)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on August 03, 2018, 04:01:47 AM
@masc, found this bug on clipped highlights while using IGV. Here's the MLV (https://minfil.com/RdBbC5f9b6/igv_bug.MLV).

(https://pictshare.net/gxi4g3vzt2.jpg)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Jerchongkong on August 03, 2018, 04:44:17 AM
Someone knows how I can compile this program in windows, what libraries are used to do it? every time I try its impossible.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on August 03, 2018, 05:18:58 AM
Differences between demosaicing on MLVApp (I will stop flooding now, sorry about that):

(https://pictshare.net/mzpqdk9o9j.gif)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 03, 2018, 09:38:03 AM
Quote from: Jerchongkong on August 02, 2018, 09:05:11 PM
I cannot compile this in windows, how can I fix it?  ???
Quote from: Jerchongkong on August 03, 2018, 04:44:17 AM
Someone knows how I can compile this program in windows, what libraries are used to do it? every time I try its impossible.
Sorry, but with this information nobody will be able to help you. First start reading the compiling instructions.

@50mm1200s:
Thanks for all your work debugging this issue. But that really sounds very very strange. For me it sounds somethings is going wrong, before, in memory.
QuoteUsing IGV and Bilinear for demosaicing, he crashed on line 388 of igv_demosaic.c:
igv_demosaic.c crashes if you use bilinear? That should be impossible.

QuoteLMMSE does not show the same issue on video_mlv.c. Instead, it crashes on line 338 of dmzhangwu.c:
dmzhangwu.c is the LMMSE debayer function - so far so good.

amaze, lmmse and igv is copied from elsewhere - we did not implement that. And if all the algos crash, there really should go something wrong before. And I don't believe there are bigger bugs inside the algos. So if that crashes I more think something "around" of our implementation is buggy... but now it becomes difficult. I still can't reproduce that on any of mine computers. I really would like to help finding!!!

QuoteSome stuff shows on malloc.h. He repeats many times this warning:...
malloc.h??? This is a standard library...

I downloaded your file and can't get the IGV bug visible. What else did you do to have that? I just loaded the file and set to IGV.
Edit: I get something similar when loading (a wrong) darkframe and clicking wildly on any RAW Corrections... but the behavior is undefined, visible only at IGV.
Edit2: Something in the IGV debayer is strange: if I disable the debayer WB correction, the artifacts are gone. But if you load any high contrast clip it looks like sh**. Something is clipping, but I am not really able to debug the sources of IGV... sry.

Thanks for all the nice pictures... compairing the demosaic algos is very interesting, but the result is different for different clips.

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 03, 2018, 09:51:04 AM
Quote from: togg on August 02, 2018, 11:56:30 PM
Here: http://www.mediafire.com/file/sd70wi2ziuxnrbh/Extreme_hot_pixel/file 

I've cutted a sample of an MLV file that has a lot of bad pixels, mostly fixed by the aggressive pass but around 5 or more still passed on. I think the detection could be improved.
Hm... I don't see bad pixels when option is enabled. I only see a lot of noise, because I have to adjust exposure in positive direction. Bad pixels would be the same in every image... this ones are filtered not bad, or what exactly do you mean?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on August 03, 2018, 04:42:03 PM
Quote from: masc on August 03, 2018, 09:51:04 AM
Hm... I don't see bad pixels when option is enabled. I only see a lot of noise, because I have to adjust exposure in positive direction. Bad pixels would be the same in every image... this ones are filtered not bad, or what exactly do you mean?

I had missed the "force" option, with it enabled they're almost all disappeared. To be sure I should check on a longer file and on dng export. Anyway way better than only "on", my bad!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on August 03, 2018, 06:21:32 PM
Quote from: masc on August 03, 2018, 09:38:03 AM
For me it sounds somethings is going wrong, before, in memory.

Yes, it's probably something with the memory and, since it don't happen on unix-like systems, it should be some windows-only expression or something.

Quote
igv_demosaic.c crashes if you use bilinear? That should be impossible.

No, that was a typo, thanks. I meant, bilinear crashs on 435 of video_mlv.c, the same with AMaZE and IGV. Reproduced this at least 6 times, just to be sure.

Quote
I really would like to help finding!!!

What can I do? The Valgrind idea could help finding...

Quote
malloc.h??? This is a standard library...

Yeah, but QTcreator shows it as something related to the crash. As you said, this is something with memory alocation.

Quote
I downloaded your file and can't get the IGV bug visible. What else did you do to have that? I just loaded the file and set to IGV.
Edit: I get something similar when loading (a wrong) darkframe and clicking wildly on any RAW Corrections... but the behavior is undefined, visible only at IGV.
Edit2: Something in the IGV debayer is strange: if I disable the debayer WB correction, the artifacts are gone. But if you load any high contrast clip it looks like sh**. Something is clipping, but I am not really able to debug the sources of IGV... sry.

The IGV bug happens on lastest "master". Just opened the MLV and change to IGV demosaicing.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 03, 2018, 06:46:32 PM
Quote from: togg on August 03, 2018, 04:42:03 PM
I had missed the "force" option, with it enabled they're almost all disappeared. To be sure I should check on a longer file and on dng export. Anyway way better than only "on", my bad!
"Force" option forces searching of bad pixels for each frame, that is why it is more reliable for dynamic bad pixels, but takes lot more time.
You had to try also "aggressive" mode with "on" it removes more, even false alarmed, pixels.

Edit: I tested "On" + "Aggr" (aggressive) with your clip and it removed all unwanted stuff easily.
Edit2: well maybe some small cyan colored ones left unremoved...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 03, 2018, 07:31:38 PM
Quote from: 50mm1200s on August 03, 2018, 06:21:32 PM
What can I do? The Valgrind idea could help finding...
The IGV bug happens on lastest "master". Just opened the MLV and change to IGV demosaicing.

Valgrind is a good idea. If you know how to use?! I tried inside QtCreator (has Valgrind support after manual installation), but in this field I am a noob... and got nothing to work :D

Latest master, opened, IGV:
(https://image.ibb.co/iyxPqe/Bildschirmfoto_2018_08_03_um_19_28_03.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 03, 2018, 11:05:46 PM
Cool debayering previewer. Did not know it was there. Checked with zoom function and all was working fine here.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on August 04, 2018, 09:42:59 AM
just a notice on the timeline-percentage counting down while processing MLV files: it is sticky!!! meaning when changing to another program in mac High Sierra it does not go away - it is permanent whatever other program you decide to work with (intentional?)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 04, 2018, 01:58:29 PM
Mlv App compiler now supports openmp(faster action):
https://bitbucket.org/Dannephoto/mlv_app_compiler/commits/512f6dbb819270b9b6eec857ccc1c3f31bf696c7

If compiler already downloaded it should ask you for updating of the scripts within 24hours or else download link is at the first post in this thread. Thanks to @masc for pointing out.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 04, 2018, 07:44:01 PM
Quote from: Danne on August 04, 2018, 01:58:29 PM
Mlv App compiler now supports openmp(faster action):
https://bitbucket.org/Dannephoto/mlv_app_compiler/commits/512f6dbb819270b9b6eec857ccc1c3f31bf696c7

If compiler already downloaded it should ask you for updating of the scripts within 24hours or else download link is at the first post in this thread. Thanks to @masc for pointing out.
Note that openmp version is still buggy!!! That is why next version is not yet released. But this next official version will have openmp! First tests on my old 2010 MacBook bring 30-40% more speed, when using "AMaZE cached" also up to 60% more speed than in last version. But here and there it is still tricky in the code...

Quote from: olofen on August 04, 2018, 09:42:59 AM
just a notice on the timeline-percentage counting down while processing MLV files: it is sticky!!! meaning when changing to another program in mac High Sierra it does not go away - it is permanent whatever other program you decide to work with (intentional?)
Yes it is intentional. Otherwise MLVApp would look like not responding and this little percentage window would be somewhere in background. You can move it where you want, if it is in front of another window. If you now what window flag has to be set, that this window is always in front of the main window, but behind any other app window, let me know!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on August 04, 2018, 11:39:30 PM
Quote from: masc on August 04, 2018, 07:44:01 PM
Note that openmp version is still buggy!!! That is why next version is not yet released. But this next official version will have openmp! First tests on my old 2010 MacBook bring 30-40% more speed, when using "AMaZE cached" also up to 60% more speed than in last version. But here and there it is still tricky in the code...

This might be useful: TaskSanitizer (https://github.com/hassansalehe/TaskSanitizer)

Quote
TaskSanitizer implements a method to detect determinacy races in OpenMP tasks. It relies on open-source tools and is mostly written in C++. It launches through a custom Bash script called tasksan which contains all necessary command-line arguments to compile and instrument a C/C++ OpenMP program. Moreover, it depends on LLVM/Clang compiler infrastructure and contains a compiler pass which instruments the program undertest to identify all necessary features, such as memory accesses, and injects race detection runtime into the produced binary of the program. Race detection warnings are displayed on the standard output while the instrumented binary executes. TaskSanitizer also relies on LLVM's OpenMP runtime (https://github.com/llvm-mirror/openmp) which contains runtime interface for performance and correctness tools (OMPT). OMPT signals events for various OpenMP events -- such as creation of a task, task scheduling, etc. -- and TaskSanitizer implements necessary callbacks for these events for tacking and categorizing program events of each task in the program.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 05, 2018, 08:15:33 AM
Because of the experimental nature of openmp, problems compiling on older macOS and so on I keep the alternative to compile two ways in Mlv_app_compiler.app:
(https://s8.postimg.cc/sb81k3u6d/Screen_Shot_2018-08-05_at_08.17.58.png_500px.jpg)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 05, 2018, 01:12:00 PM
Quote from: masc on August 04, 2018, 07:44:01 PM
But this next official version will have openmp! First tests on my old 2010 MacBook bring 30-40% more speed, when using "AMaZE cached" also up to 60% more speed than in last version. But here and there it is still tricky in the code...

Wow, this is very good news!  If you guys manage to increase speed, this is going to be a real breakthrough in RAW video post processing.  Keeping my thumbs pressed for you!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 07, 2018, 11:59:30 AM
Guys the MLV App Linux AppImage (https://ilia3101.github.io/MLV-App/) is downloads champion again...

I guess some AI Bot, with ML supported Canon camera, really felt in love with it ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 07, 2018, 12:55:44 PM
Quote from: bouncyball on August 07, 2018, 11:59:30 AM
Guys the MLV App Linux AppImage (https://ilia3101.github.io/MLV-App/) is downloads champion again...

This is because you guys did a hell of a job with MLVApp!  If something is so good and also free, the good word about it spreads very quckly and everybody wants to have it.   Congratulations to everyone involved in this remarkable development!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on August 07, 2018, 04:36:18 PM
Quote from: bouncyball on August 03, 2018, 06:46:32 PM
"Force" option forces searching of bad pixels for each frame, that is why it is more reliable for dynamic bad pixels, but takes lot more time.
You had to try also "aggressive" mode with "on" it removes more, even false alarmed, pixels.

Edit: I tested "On" + "Aggr" (aggressive) with your clip and it removed all unwanted stuff easily.
Edit2: well maybe some small cyan colored ones left unremoved...

Yes, that's exactly it. Aggressive gets a lot of false allarmed one and On miss a fews. In the end I decided to change the camera completelly so it is less of an issue now, I just wanted to give the worst possible file a shot.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 07, 2018, 05:19:21 PM
Quote from: togg on August 07, 2018, 04:36:18 PM
I just wanted to give the worst possible file a shot.
I bet you've chosen the right one :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on August 09, 2018, 01:01:50 PM
Hello, I can't access to the latest version. There is nothing when I click to the link...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 09, 2018, 02:25:48 PM
Quote from: 12georgiadis on August 09, 2018, 01:01:50 PM
Hello, I can't access to the latest version. There is nothing when I click to the link...
Which link do you use? Both working here...
https://github.com/ilia3101/MLV-App/releases
https://ilia3101.github.io/MLV-App/
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on August 11, 2018, 12:45:29 PM
Quote from: masc on August 09, 2018, 02:25:48 PM
Which link do you use? Both working here...
https://github.com/ilia3101/MLV-App/releases
https://ilia3101.github.io/MLV-App/
thx it works now, I see the DL again
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: JackDaniel412 on August 13, 2018, 07:08:55 PM
Hello everybody! Trying the latest version, when i use darkframe subtraction randomly crash during export. About one clip over 4/5 randomly.


(https://thumb.ibb.co/ew6jT9/MLVApp_Crash_01.jpg) (https://ibb.co/ew6jT9)

(https://thumb.ibb.co/j4yyo9/MLVApp_Crash_02.jpg) (https://ibb.co/j4yyo9)


Someone can help me?

Thank's
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on August 13, 2018, 07:41:10 PM
Question : which solution is used for anti-aliasing ? Is it something related to optical flow ? Because it's warping a lot. Or is it the same solution used by Danne ?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 13, 2018, 10:11:02 PM
Quote from: JackDaniel412 on August 13, 2018, 07:08:55 PM
Hello everybody! Trying the latest version, when i use darkframe subtraction randomly crash during export. About one clip over 4/5 randomly.
Someone can help me?
It is a known "Windows only" bug, which is not yet solved. None of the devs was able to reproduce it yet. https://github.com/ilia3101/MLV-App/issues/96
If it occurs on your system, you can try to debug. That could really help. 50mm1200s also tried that and gave many information...

Quote from: 12georgiadis on August 13, 2018, 07:41:10 PM
Question : which solution is used for anti-aliasing ? Is it something related to optical flow ? Because it's warping a lot. Or is it the same solution used by Danne ?
Smooth aliasing filter works with optical flow and works best for scenes with only a little movement. Dannes script solution works with enfuse and works best for clips without movement.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 13, 2018, 10:23:10 PM
Actually slight movement is wanted but to much subjects moving around will cause blurr/ghosting. From my tests I think the anti aliasing solution in mlv app is more reliable to work with. I didn't test too much though so feel free to experiment.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Mefist on August 14, 2018, 03:14:39 AM
Not work Transformation (((
video 5D Mark III 50fps 1920x648 aspect ratio 1.67

I set the settings:
Widht Stretch 1.0x
Height Stretch 1.67x
RAW correction - Off

converts anyway with color and narrow frame

File Export:
(https://i102.fastpic.ru/big/2018/0814/88/03c1808bf1c9e06a9e214ccc6c9acf88.png)

what to do?
(https://i99.fastpic.ru/thumb/2018/0814/dd/c522031f9ded3978a383a996182ba3dd.jpeg) (https://fastpic.ru/view/99/2018/0814/c522031f9ded3978a383a996182ba3dd.png.html)
(https://i99.fastpic.ru/thumb/2018/0814/fe/302148161958bea2b13a99cee4fa1dfe.jpeg) (https://fastpic.ru/view/99/2018/0814/302148161958bea2b13a99cee4fa1dfe.png.html)
(https://i99.fastpic.ru/thumb/2018/0814/de/_11cb70e94cf15c691aee3772791d42de.jpeg) (https://fastpic.ru/view/99/2018/0814/_11cb70e94cf15c691aee3772791d42de.jpg.html)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 14, 2018, 08:00:09 AM
Quote from: Mefist on August 14, 2018, 03:14:39 AM
Not work Transformation (((
video 5D Mark III 50fps 1920x648 aspect ratio 1.67

I set the settings:
Widht Stretch 1.0x
Height Stretch 1.67x
RAW correction - Off

converts anyway with color and narrow frame

what to do?
You forgot to write how you export. I bet not using ffmpeg. Stretching is a ffmpeg only option.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 14, 2018, 09:55:48 AM
@masc

IMHO stretching should be restricted for any, non ffmpeg, exports in the gui.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 14, 2018, 10:16:33 AM
Quote from: bouncyball on August 14, 2018, 09:55:48 AM
@masc

IMHO stretching should be restricted for any, non ffmpeg, exports in the gui.
But this would mean we disable nearly the whole GUI if MLV or CDNG is chosen in export menu... I am not sure if I like this idea...

With this darkframe crash some light comes in the dark for me... on Windows only, memory allocation does not work as expected. See issue #96 on our github repos.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 50mm1200s on August 14, 2018, 12:50:23 PM
Quote from: masc on August 14, 2018, 10:16:33 AM
With this darkframe crash some light comes in the dark for me... on Windows only, memory allocation does not work as expected. See issue #96 on our github repos.

Ha! Told you it was malloc() :P
If you need to test some patch, I will be here.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 14, 2018, 01:03:22 PM
Quote from: 50mm1200s on August 14, 2018, 12:50:23 PM
Ha! Told you it was malloc() :P
If you need to test some patch, I will be here.
Hehe... thanks! But what can we do, if a standard function like malloc works not as expected... and on one single OS only?!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Mefist on August 14, 2018, 01:27:52 PM
Quote from: masc on August 14, 2018, 08:00:09 AM
You forgot to write how you export. I bet not using ffmpeg. Stretching is a ffmpeg only option.

File Export:
CinemaDNG Uncompressed
(https://i102.fastpic.ru/big/2018/0814/88/03c1808bf1c9e06a9e214ccc6c9acf88.png)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 14, 2018, 01:29:24 PM
Quote from: Mefist on August 14, 2018, 01:27:52 PM
File Export:
CinemaDNG Uncompressed
CDNG is RAW, so no processing is done at all! Only RAW Correction changes the output for CDNG.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Mefist on August 14, 2018, 01:34:44 PM
how then to fix CDNG?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 14, 2018, 01:42:59 PM
The cdng probably contains the stretched info (default scale tag) but question is why your chosen nle doesn't read that tag when you export. Acr will read this tag, dcraw too but resolve, premiere pro doesn't...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Mefist on August 14, 2018, 01:51:00 PM
Camera Raw and Lihtroom show correctly size

but changes the color ((((but this option is disabled when exporting

(https://i103.fastpic.ru/big/2018/0814/3d/8eddefdd5e0263b7802ff20305d9f13d.png)
(https://i99.fastpic.ru/thumb/2018/0814/17/0308e4cba566f84b3adfca399ad63e17.jpeg) (https://fastpic.ru/view/99/2018/0814/0308e4cba566f84b3adfca399ad63e17.png.html)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 14, 2018, 02:03:15 PM
Quote from: masc on August 14, 2018, 10:16:33 AM
But this would mean we disable nearly the whole GUI if MLV or CDNG is chosen in export menu... I am not sure if I like this idea...
LOL
I mean in the export dialog (which is already done, my bad) ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 14, 2018, 02:04:21 PM
Lightroom=acr.
Are you expoting through lightroom? Then there's where your issue lies. Try export through after effects.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Mefist on August 14, 2018, 02:34:28 PM
I opened the first CDNG in the lightroom to watch it

to fix 1920x648 can only be stretched to 1920x1080 in DiVinci?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 14, 2018, 03:02:04 PM
1.67x628≈1049
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: olofen on August 18, 2018, 09:52:59 PM
Quote from: masc on August 02, 2018, 08:42:27 PM
Yes you can use MLVApp for dual iso. Processing is 20bit (attaching low and high iso).

SUPERGREAT :D
What ISO is best to use? And - is it of equal result to make adjustments in the MLV app as doing it later as exported CinemaDNG uncompressed in Photoshop?
20bit!!! Any other camera on the market that can do this...?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on August 24, 2018, 04:18:33 AM
Am I the only one who is seeing an offset in the audio sync exports with dng? It is like minus 1.5 frames.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 24, 2018, 07:56:01 AM
Quote from: togg on August 24, 2018, 04:18:33 AM
Am I the only one who is seeing an offset in the audio sync exports with dng? It is like minus 1.5 frames.
I don't know your files, but audio channel is always synced by timecode to video channel in MLVApp. Sample MLV would be nice.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 24, 2018, 08:34:02 AM
 @togg
Could you upload mlv_dump metadata so we can check audio offset numbers? It should be possible to match dng and wav with timecode metadata in post also with dng+wav
mlv_dump -v input.MLV
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 24, 2018, 08:56:56 AM
@togg

I prefer to take a look at the original MLV, please upload it somewhere.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on August 24, 2018, 08:21:22 PM
Mmm ok if you're not seeing that I'll try to upload a MLV, thanks. It will take some time tough I've switched to other hard drive at the moment.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 25, 2018, 08:13:38 PM
Quote from: togg on August 24, 2018, 08:21:22 PM
Mmm ok if you're not seeing that I'll try to upload a MLV, thanks. It will take some time tough I've switched to other hard drive at the moment.
@togg: I remember, nearly a year ago I recorded a sync test when we started implementing audio. I had one clip where audio was 1fps earlier than video. But: that means when syncing it correctly, there is no audio for the first frame - or we would have to cut away the first frame. There is only a very little more audio than video in a MLV. We decided to sync it by using the timecode (therefor we had to cut a very very little in front and in the rear of the audio channel, if I remember right, or only in the rear?!). Nobody really knows, on which position the audio is more correct than using the timecode... here a screenshot from my clip, it is the same with yours?
(https://image.ibb.co/hNTatU/Bildschirmfoto_2018_08_25_um_20_11_46.png)
@bouncyball: you remember the little book sync test?!  ;D
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 25, 2018, 08:31:16 PM
Longer audio file were problematic with wav embedding in resolve.
Audio offset sync like in mlv app is the best way. How to do this with dng+audio? Probably with time code in wav or dng file. Without a problematic test file hard to do anything.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 25, 2018, 08:39:40 PM
Quote from: masc on August 25, 2018, 08:13:38 PM
@bouncyball: you remember the little book sync test?!  ;D
Yup :D (I have saved it here for the history)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 25, 2018, 08:50:47 PM
Quote from: Danne on August 25, 2018, 08:31:16 PM
Audio offset sync like in mlv app is the best way. How to do this with dng+audio?
The sync made by taking in consideration of starting time from the beginning of recording of both 1st video and 1st audio frames. No matter which starts earlier or later, the code calculates positive or negative offset and does sync accordingly, also it aligns the end of the clip and writes needed offset value to the WAV's enhanced header part (needed by resolve) in case, when clip cutting feature is used by MLV App. And this concerns all exports including cDNG + WAV.

I have another idea. Latest crop_rec_4k_mlv_snd branch has experimental audio setting (when mlv_audio.mo is loaded).
ML Menu/Movie/RAW video/Sound recording/Audio delay
Try to set it to 0 (by default it is 1)

regards
bb

Edit: Despite all of these, still, it would be nicer to take a look at the sample MLV.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 70MM13 on August 27, 2018, 03:59:09 PM
I'm really enjoying working with mlvapp, and getting great results from the tests I'm doing.

Something strange I've found, however...

When I export as 16 bit tiff, I'm getting fewer colours than "save an actual frame" as an 8 bit PNG.

On the order of 110,000 vs 98,000.

I'd expect the opposite!

Looking at the tiff file, it says it's 48 bit, so there's a bit of a mystery here...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 27, 2018, 04:08:30 PM
@70mm13: very interesting. How do you count the colours? The frames are exported in very different ways:
- 8bit: internally convert 16 to 8 bits, use Qt library to save 8bit PNG
- 16bit: directly stream the (processed) rawdata (internally 16bit) to ffmpeg which saves the 16bit TIFF
So if your values are right, there should be a problem with ffmpeg (or our ffmpeg call).
BTW: only 100.000 colours? (3x)8bit has already 16.000.000!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on August 27, 2018, 08:05:28 PM
Hey guys!

MLV App release v1.0 is out (https://github.com/ilia3101/MLV-App/releases/tag/QTv1.0)

Look at change log. Masc (alone) w/o our help has done enormous job implementing all of these new features. A bit more than one year passed from the birth of MLV App so we called it Anniversary Relese :D. Enjoy!

And do not forget about feedback/bug report ;) (we are so appreciate it)

best regards
bb
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 27, 2018, 08:07:17 PM
Awesomeness. Even works on mountain lion. Really good work!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on August 28, 2018, 12:30:10 AM
Thank you so much masc and bouncyball!!!!!!!!!!!!
Thanks danne too!!! and everyone else who uses and helkps!!!!

Happy birthday MLV App 💛
(https://user-images.githubusercontent.com/23642861/43786055-a8edb62e-9a5f-11e8-9154-8d0209068331.png)

Download v1.0, the best version yet (https://ilia3101.github.io/MLV-App/)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on August 28, 2018, 04:09:43 AM
Oh well, congrats! I'll try to come back to those files with a clap showing and audio to test sync in the new version.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 70MM13 on August 28, 2018, 04:46:03 AM
I use faststone image viewer to count the colours.  Ctrl-shift-T

Yes, the example values I gave are fairly low, but the scene I'm working on is extremely low light!

Congratulations on the new version!  Keep up the amazing work!

I hope you can solve my mystery!

Quote from: masc on August 27, 2018, 04:08:30 PM
@70mm13: very interesting. How do you count the colours? The frames are exported in very different ways:
- 8bit: internally convert 16 to 8 bits, use Qt library to save 8bit PNG
- 16bit: directly stream the (processed) rawdata (internally 16bit) to ffmpeg which saves the 16bit TIFF
So if your values are right, there should be a problem with ffmpeg (or our ffmpeg call).
BTW: only 100.000 colours? (3x)8bit has already 16.000.000!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: andy kh on August 28, 2018, 05:14:30 AM
Congrats and Happy BirthdayMLVApp. tested on windows 10 64bit. so far so good. keep up the good work
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bakersdozen on August 28, 2018, 07:30:57 AM
Awesome work and happy birthday! Many Happy returns to come I hope  :)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: GianlucaM83 on August 28, 2018, 09:37:23 AM
Happy birthday to mlv app!  :)
A big thanks to everyone for the work you do every day, making magic lantern bigger and bigger and affordable for everyone.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: IDA_ML on August 28, 2018, 09:40:14 AM
Happy birthday and congratulations to all developers of this absolutely amazing software !!!

I have a small birthday present for you which you can download from here in the next 7 days:

https://we.tl/t-x0xkLPb2mD

This video (shot on the 100D and the EF-s 18-55/IS STM at 18 fps and 2320x1304 resolution) was entirely processed on MLVApp v. 017.  After correction, the clips were exported into ProRes422LT and the final mount and adding music was accomplished with Filmora.  All this was performed on my 11-year old laptop with Core 2 Duo processor and  4GB of RAM.  I would have never thought that such a massive video processing work could have been accomplished on such a weak laptop.  And guess what - all processing went pretty smoothly.  I imported all clips into MLVApp, applied the corrections to one clip and copied them to the other ones, did some fine tuning on every one of them, started the export and went to bed.  In the morning, when I woke up, all files were ready, waiting for me.   And since ProRes is an editable format, all clips played well in Filmora too.  I decided to scale the final video down to FHD to keep the file size reasonably small.  Sorry to those with high-res monitors.

Thank you so much, guys and keep up this excellent work!

Sincerely yours,
IDA_ML.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 28, 2018, 01:03:00 PM
Happy first birthday MLVApp and thank you all for your nice words and support! I hope you like all the new features and I hope they work for you too.

@IDA_ML: nice! And I use it nearly the same - mostly on a very old laptop. With v1.0 performance is improved, so it should work even better - on old and newer systems.

@70MM13: hm, I tried it my self and these numbers are strange. I get only slightly higher number of colours for 16bit than for 8bit for my test clip. BUT: I rendered another 16bit TIFF with Photoshop (looked nearly the same then) and it had even less colours... I am not sure if these numbers are correct.
Another test with FastStone Viewer: 14bit CR2 had 76k colours, same picture as 8bit jpg had 82k.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 70MM13 on August 28, 2018, 10:04:35 PM
It makes sense...  I can't see any degradation on the 16 bit tiff, so perhaps faststone is just incorrect.

Maybe there's another way to get a clearer answer...  Perhaps gimp has a similar colour count function.

PS: gimp has a colour count function, and according to it, everything is fine!

Test image was approximately 94,000 colours in the 8 bit PNG export, and 101,000 in 16 bit tiff.

In case anyone is interested in the function, it's under colours/info/colourcube analysis

Thanks for the help!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on August 30, 2018, 01:39:47 AM
@masc : incredible update ! you seem to have read my #114 post on fast cinemadng forum about the MLV conformation. I'm currently testing it with proxys from MLV app. For now, MLVs are detected and well imported from an FCPXML with ProRes proxy edit in MLV app !
Later, I'll try to export these Mlv into APR444 and conform on Resolve with the same Fcpxml, to see if it replaces ProRes proxy with 444 and keep the edit correctly

edit : working with mlv from eosm
1) exported proxy from mlv app
2)imported in fcpx
3) exported fcpxml
4)importe in mlv app and use fpcxml assistant, pointing to mlv = OK
5) exported pre-corrected MLV to ProRes 444 = ok
6) import fcpxml resolve = ok to point to prores 444 keeping the editing

fail : form this timeline, export to fcpxml and reimport to mlv app = not working

what version s of fcpxml are compatible in mlv app ?

Thanks,

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 30, 2018, 08:10:20 AM
@12georgiadis
Yes I read that, but it was implemented before... nice to hear it mostly works. I can't tell you what version of fcpxml is compatible - I have no spec and reverse engineered. I think your problem is, that Resolve renames the clips. Somewhere in the settings you can setup the clip names to real names. Maybe check this and it should work again. All MLVApps assistant needs is a coorect clip name. In the fcpxml I just search for e.g. <clip name="M04-1441"so I know I have to search for M04_1441.MLV in the folder you set in the assistant. If Resolve builds clip names of e.g. M04-1441_0000001-0000054 my assistant is lost atm. ;)

Edit: I see, Resolve is exactly doing what I expected plus I found another small bug. Will do a fix for all that...
Edit2: Done. All versions of fcpxml from Resolve opened fine now.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on August 30, 2018, 03:17:38 PM
Quote from: masc on August 30, 2018, 08:10:20 AM
@12georgiadis
Yes I read that, but it was implemented before... nice to hear it mostly works. I can't tell you what version of fcpxml is compatible - I have no spec and reverse engineered. I think your problem is, that Resolve renames the clips. Somewhere in the settings you can setup the clip names to real names. Maybe check this and it should work again. All MLVApps assistant needs is a coorect clip name. In the fcpxml I just search for e.g. <clip name="M04-1441"so I know I have to search for M04_1441.MLV in the folder you set in the assistant. If Resolve builds clip names of e.g. M04-1441_0000001-0000054 my assistant is lost atm. ;)

Edit: I see, Resolve is exactly doing what I expected plus I found another small bug. Will do a fix for all that...
Edit2: Done. All versions of fcpxml from Resolve opened fine now.

Thanks Masc, I didn't know it was already implemented, I'm even more happy that someone else found this idea helpful !
OK, I'm going to test your new version.
I'll also test with a 5DmkIII h264 proxy + mlv recording footage.
What is cool is that resolve can maybe convert xml v5 from premiere pro cc / fcp7 & AAF from avid to Fcpxml, so you wouldn't have to implement these type of files. We have to test it too but if it works it can help for all kind of NLE !
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 30, 2018, 03:37:30 PM
@12georgiadis: you can compile it? It is just commited to the repos. Cool, would be nice to know if it works fine with 5D3 proxys!
Hehe, yes, I went crazy with my own little projects: ~500 MLVs and only 50-100 of them were used in a project and have to be corrected/graded. Selecting these files manually was very time consuming and borring.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on August 30, 2018, 05:11:04 PM
Quote from: masc on August 30, 2018, 03:37:30 PM
@12georgiadis: you can compile it? It is just commited to the repos. Cool, would be nice to know if it works fine with 5D3 proxys!
Hehe, yes, I went crazy with my own little projects: ~500 MLVs and only 50-100 of them were used in a project and have to be corrected/graded. Selecting these files manually was very time consuming and borring.
No, don't know how to compile... but if you have a tuto link, I can try. Same here 30 hour of footage and 1 hour at the end, I didn't want to find all clips manually =D By the way, I saw some new debayering algorithms. What is the best between IGV, LMMSE and Amaze ? Does MLV app works on CPU usage ? Or some the playback is GPU ?
Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 30, 2018, 07:26:29 PM
Just use mlv app compiler in the first post...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 30, 2018, 07:33:09 PM
Compiling instructions can be found here: https://github.com/ilia3101/MLV-App
You are on Windows? You just need a Qt5.6 or newer installation with MinGW, then download sources from github and follow the instructions. If you are on OSX, try Dannes compiler app, which leads you through...

Mostly AMaZE is the best demosaic algorithm. For some clips IGV or LMMSE may look a little better, specially if AMaZE brings some false color artifacts.

MLVApp still runs 100% on CPU, that is why it runs on nearly every computer from the last 10 years or older, no matter which OS (Win/Linux/OSX), what CPU or what GPU (if there is any at all). Since the last version we support much better multithreading, what made rendering up to double speed to before.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on August 30, 2018, 09:44:01 PM
Quote from: Danne on August 30, 2018, 07:26:29 PM
Just use mlv app compiler in the first post...
Ok danne, I'm gonna try it ! Super cool that you made it more easier


Envoyé de mon iPhone en utilisant Tapatalk
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on August 30, 2018, 09:48:33 PM
Quote from: masc on August 30, 2018, 07:33:09 PM
Compiling instructions can be found here: https://github.com/ilia3101/MLV-App
You are on Windows? You just need a Qt5.6 or newer installation with MinGW, then download sources from github and follow the instructions. If you are on OSX, try Dannes compiler app, which leads you through...

Mostly AMaZE is the best demosaic algorithm. For some clips IGV or LMMSE may look a little better, specially if AMaZE brings some false color artifacts.

MLVApp still runs 100% on CPU, that is why it runs on nearly every computer from the last 10 years or older, no matter which OS (Win/Linux/OSX), what CPU or what GPU (if there is any at all). Since the last version we support much better multithreading, what made rendering up to double speed to before.
Thank you masc for all informations !
I'm on Mac so will try danne's app compiler !
Ok for amaze but do you think lmmse or igv can help to reduce aliasing ?
Ok for cpu, i understand and totally agree with this choice to keep things universal. And superb for multi threading !


Envoyé de mon iPhone en utilisant Tapatalk
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 30, 2018, 09:57:50 PM
Quote from: 12georgiadis on August 30, 2018, 09:48:33 PM
Ok for amaze but do you think lmmse or igv can help to reduce aliasing ?
No. ;) I have sometimes some colored artifacts in trees - these are a bit less with IGV... but therefor on clean surfaces you'll find a kind of structures.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on August 30, 2018, 10:01:58 PM
@masc, @danne, is there a function that cut black frame on h264 + reset tc to zero to sync it with MLV ?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on August 30, 2018, 10:04:33 PM
Quote from: 12georgiadis on August 30, 2018, 10:01:58 PM
@masc, @danne, is there a function that cut black frame on h264 + reset tc to zero to sync it with MLV ?
No, importing h264 is not supported at all. I don't know if Danne is able to write a scipt for that...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Danne on August 30, 2018, 10:32:38 PM
Should be doable. Only need some time  :P
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on August 30, 2018, 10:34:54 PM
@danne, @masc : you guys rock !
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 12georgiadis on August 30, 2018, 10:36:01 PM
Quote from: masc on August 30, 2018, 09:57:50 PM
No. ;) I have sometimes some colored artifacts in trees - these are a bit less with IGV... but therefor on clean surfaces you'll find a kind of structures.
ok, good to know
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: RobinF on September 01, 2018, 05:05:54 PM
Quick question, what is your usual workflow when stretching squeezed raw files?
All my files are squeezed because  I shot in 1920 with 50 fps so 1920 x 482. Am using premiere pro, I seem to only be able to stretch them when they are already in my timeline and manually stretching the height until it fits my final sequence setting witch is 1920 x 816.

This already is not too comfortable working copying and pasting the height when importing clips into the timeline let alone previewing them in your source monitor when they are still squeezed.

Now I know Mlv APP does stretch them in some way, only that some programs don't recognise the data included to a raw sequence and that Premiere Pro doesn't. Lightroom and After Effects seem to automatically read the data and stretches the footage to 1920 x 816.

Is there another, faster and more ergonomic way to do this is my question? Stretching the height of the footage before editing in premiere pro?


Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 01, 2018, 08:01:36 PM
Quote from: RobinF on September 01, 2018, 05:05:54 PM
Now I know Mlv APP does stretch them in some way, only that some programs don't recognise the data included to a raw sequence and that Premiere Pro doesn't. Lightroom and After Effects seem to automatically read the data and stretches the footage to 1920 x 816.

Is there another, faster and more ergonomic way to do this is my question? Stretching the height of the footage before editing in premiere pro?
This happens only if you are using cDNG. You could also color correct in MLVApp and export in ProRes or another format. Or you stretch manually in Premiere, what means 100% the same, because stretching in cDNG is just metadata, no "real" stretching inside the cDNG.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 70MM13 on September 02, 2018, 07:28:37 PM
I'm amazed at the results obtainable with mlvapp's elegant and uncluttered controls!

One thing that would come in really handy is being able to store and retrieve receipts quickly from ram with keyboard shortcuts, similar to resolve's "memories".  They use the number keys, plus alt to store or Ctrl to load.

Something like this would be excellent for powerful workflow on grading clips.

Also, any chance of high colour depth jpeg 2000 MOV export?  It is a very nice format in resolve, and maybe it would work well with mlvapp!

Mlvapp is an awesome program!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 02, 2018, 09:16:05 PM
Thanks @70MM13. You mean having multiple "slots" for receipts, than just one (as it is now)? That is no bad idea and should work somehow. I'll think about how to integrate that.
JPEG2000 as mov... hm... now I got only as sequence, right?! MotionJPEG is also something different?! (Don't know exactly these codecs, sry.) If ffmpeg can do that (maybe you found a call somewhere?), MLVApp could do that in future too! ;)

Edit: found somewhere ffmpeg -y -t 1 -i OUT2.mov -vcodec j2k -pix_fmt yuv422p -an -strict experimental testj2k.mov ... I'll try that out one day...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 02, 2018, 09:34:12 PM
No matter how many bits I want, ffmpeg gives 8bit. Here what we could get (5D2 example):
General
Complete name                            : /Users/masc/Desktop/M15-1953.mov
Format                                   : MPEG-4
Format profile                           : QuickTime
Codec ID                                 : qt   0000.02 (qt  )
File size                                : 6.18 MiB
Duration                                 : 342 ms
Overall bit rate mode                    : Variable
Overall bit rate                         : 152 Mb/s
Writing application                      : Lavf57.71.100

Video
ID                                       : 1
Format                                   : JPEG 2000
Format profile                           : No restrictions
Codec ID                                 : mjp2
Duration                                 : 320 ms
Bit rate mode                            : Variable
Bit rate                                 : 160 Mb/s
Width                                    : 1 856 pixels
Height                                   : 1 044 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Constant
Frame rate                               : 25.000 FPS
Chroma subsampling                       : 4:4:4
Bit depth                                : 8 bits
Scan type                                : Progressive
Bits/(Pixel*Frame)                       : 3.310
Stream size                              : 6.12 MiB (99%)
Language                                 : English
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: 70MM13 on September 02, 2018, 11:03:08 PM
No worries on the jpeg 2000...  It was just hopeful thinking.

Multiple slots for receipts would be far more important!!!

Thanks!
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: swinxx on September 04, 2018, 03:52:55 PM
WOOOHHOOOO.. i was long away from MLV and my CAM.. Now making some testshots and found THIS APP!!!! THIS IS AWESOME!!! THANK YOU SOOOO MUCH FOR YOU EFFORT.. THANK YOU MAGIC LANTERN AND THE DEVELOPER(S) OF THIS AMAZIN GEM! THIS IS IT! WWOOOHHHOOOOOO
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: EOS M dude 1 on September 04, 2018, 09:41:29 PM
It would be fantastic if MLV app had an option that combines the movie clips together when converting so it will be one whole file not many seperated.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 05, 2018, 11:37:34 PM
Quote from: swinxx on September 04, 2018, 03:52:55 PM
WOOOHHOOOO.. i was long away from MLV and my CAM.. Now making some testshots and found THIS APP!!!! THIS IS AWESOME!!! THANK YOU SOOOO MUCH FOR YOU EFFORT.. THANK YOU MAGIC LANTERN AND THE DEVELOPER(S) OF THIS AMAZIN GEM! THIS IS IT! WWOOOHHHOOOOOO
:)

The kind of reaction I was expecting to get from myself while intially creating it, except I was the one making it, so reacting to my own creation would have been weird.

So that is perfect thank you :D
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: reddeercity on September 06, 2018, 06:27:03 AM
@Ilia3101 , have seen this yet ? https://www.magiclantern.fm/forum/index.php?topic=11205.msg205674#msg205674 development discussion here (https://www.magiclantern.fm/forum/index.php?topic=19336.msg205614#msg205614)  8)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: RobinF on September 07, 2018, 02:47:45 PM
Quote from: masc on September 01, 2018, 08:01:36 PM
This happens only if you are using cDNG. You could also color correct in MLVApp and export in ProRes or another format. Or you stretch manually in Premiere, what means 100% the same, because stretching in cDNG is just metadata, no "real" stretching inside the cDNG.

There has to be a better way than color correcting in the mlv app? What's the point shooting in raw when you have to color grade prores in davinchi or basic grade raw in the mlv app?
Okay you have the ability to get a prores file from your dslr wich normally isn't possible but then again you could also use a external recorder to record in prores.

It's not impossible this way but really inconvenient watching compressed footage and manually stretching them, someone has to have the ultimate workflow for this right?

Thanks!

Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on September 07, 2018, 04:32:52 PM
Quote from: EOS M dude 1 on September 04, 2018, 09:41:29 PM
It would be fantastic if MLV app had an option that combines the movie clips together when converting so it will be one whole file not many seperated.
Why not using a NLE? For MLVApp this would only work if all clips had the same resolution - to check all this would make it complicated and would also limit the resulting functionality.

Quote from: RobinF on September 07, 2018, 02:47:45 PM
There has to be a better way than color correcting in the mlv app? What's the point shooting in raw when you have to color grade prores in davinchi or basic grade raw in the mlv app?
Okay you have the ability to get a prores file from your dslr wich normally isn't possible but then again you could also use a external recorder to record in prores.

It's not impossible this way but really inconvenient watching compressed footage and manually stretching them, someone has to have the ultimate workflow for this right?
Sry... I don't get what you are writing about. First you had the problem that Premiere is not able to read the stretching metadata in cdng. Now you want to grade prores files in Resolve (Resolve is able to read stretching metadata in cdng)... ?!?!?! And please define "better" in terms of color correcting. MLVApp should already be better than Premiere (not ACR) in this area, Resolve is much better but works fine with cdng. When using premiere you could correct and grade in MLVApp and cut the prores files in Premiere. Or you just use proxies made by MLVApp, cut it in Premiere and grade the cdng in Resolve, or ... or ... or ...
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: allemyr on September 07, 2018, 05:08:16 PM
Quote from: RobinF on September 07, 2018, 02:47:45 PM
There has to be a better way than color correcting in the mlv app? What's the point shooting in raw when you have to color grade prores in davinchi or basic grade raw in the mlv app?
Okay you have the ability to get a prores file from your dslr wich normally isn't possible but then again you could also use a external recorder to record in prores.

It's not impossible this way but really inconvenient watching compressed footage and manually stretching them, someone has to have the ultimate workflow for this right?

Thanks!

Well you have to choose the workflow that works best for yourself. You can't blame others for using and develop the software they want to use.

If you want to try it and are a Windows user, you might try raw2cdng by Chmee and import directly to Resolve 15. Thats the process I've changed towards over the years, and find convinient. You don't have to use it just a tip/advice but it takes time to learn atleast for me over the years. But the fun thing about it is that my 5D3 feels more and more modern the more Black Magic develops Resolve.

But you shouldn't bash here at them in a MLV app that they are developing themself.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ilia3101 on September 07, 2018, 08:38:39 PM
Quote from: RobinF on September 07, 2018, 02:47:45 PM
There has to be a better way than color correcting in the mlv app? What's the point shooting in raw when you have to color grade prores in davinchi or basic grade raw in the mlv app?

Yeah MLV aAPP is just useless for colour isn\'t it


Edit: Lol sorry for the passive aggressive reply. But my point is that MLV App is perfectly capable of producing a cinematic image out of a good shot, and in my opinion this video is a better result than many people get with davinci resolve etc. It just takes effort and practice to get nice images, not the best software. The main thing for good looking images is having smooth highlights, in my opinion and MLV App can do that pretty perfectly. And you can add a lut in MLV App if you like that style of colour. And I admit MLV App is still not colour accurate, also the that video is not very detailed (it's more about colour).

Quote from: RobinF on September 07, 2018, 02:47:45 PM
Okay you have the ability to get a prores file from your dslr wich normally isn't possible but then again you could also use a external recorder to record in prores.

An external recorder will still give you cr4p 8 bit colour depth the prores doen't help.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 07, 2018, 10:23:56 PM
I'm sure there are plenty of people like myself with great appreciation for mlvapp!

Yes, resolve can do more for very poor footage, but it's a different beast altogether.

Mlvapp is GREAT.  I have no problems getting fantastic results with it!

Keep up the amazing work!

Many thanks!
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 08, 2018, 06:26:13 AM
Quote from: 70MM13 on September 07, 2018, 10:23:56 PM
I'm sure there are plenty of people like myself with great appreciation for mlvapp!

I am one of these people.  Since most of the time I use older computers which do not support Resolve at all, my only alternatives are MLVApp and MLVProducer.  They both work very well for me.  I use Producer when I need fast export times.  It works pretty fast with the ProResFast444 option.  In all other cases I use MLVApp since it really provides excellent results in post processing.  I want the developers of these two pieces of software to know how much I appreciate their expert work and how grateful I am for all their enormous efforts.  Keep up the good work, guys and enjoy the appreciation of the ML community!
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: zalbnrum on September 14, 2018, 02:10:16 PM
I just read that BMD gave out source and all for their new Black Magic Raw codec and is available to developers.

Link: https://www.4kshooters.net/2018/09/14/ibc-2018-blackmagic-design-introduces-a-brand-new-blackmagic-raw-codec/ (https://www.4kshooters.net/2018/09/14/ibc-2018-blackmagic-design-introduces-a-brand-new-blackmagic-raw-codec/)

Do you think it is possible to implement it in your already more than awesome MLV APP?

As I understood one of the main differences is that you get one file instead of separate cDNG frames in folders, which are harder to move around disks and harder to read so you get slower previews because of data bottleneck there.

MASC and other developers of MLV APP thank you for this amazing tool.

Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Andy600 on September 14, 2018, 02:34:43 PM
Quote from: RÁTNEEK on September 14, 2018, 02:10:16 PM
I just read that BMD gave out source and all for their new Black Magic Raw codec and is available to developers.

Link: https://www.4kshooters.net/2018/09/14/ibc-2018-blackmagic-design-introduces-a-brand-new-blackmagic-raw-codec/ (https://www.4kshooters.net/2018/09/14/ibc-2018-blackmagic-design-introduces-a-brand-new-blackmagic-raw-codec/)

Do you think it is possible to implement it in your already more than awesome MLV APP?

As I understood one of the main differences is that you get one file instead of separate cDNG frames in folders, which are harder to move around disks and harder to read so you get slower previews because of data bottleneck there.

MASC and other developers of MLV APP thank you for this amazing tool.


BMD Raw is not an interchange or container format.

It is only recordable in the camera (and probably in new external BMD RAW recorders).

Like ARRI Raw, ProRes Raw etc there is no BMD Raw output codec other than when trimming original BMD Raw files. You can't render to BMD Raw from Resolve.

I suspect this has come about as a way to reduce licensing costs when incorporating ProRes. They simply get rid of the Apple codecs altogether. Smart move but could backfire if other NLE vendors don't support it. I wonder what this will do for official ProRes support in Resolve in future as BMD Raw is a direct rival to ProRes Raw.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 14, 2018, 03:59:30 PM
MLV App causing this scan lines in the Sun when processing Dual ISO files. Any way to avoid it?
(https://image.ibb.co/hxfuZp/Sun_Scan_Lines.png) (https://imgbb.com/)

Download MLV Sample (https://drive.google.com/open?id=12kYlSuO6eub_GTlDfAH4GeoPgEbcUkJ_)
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 14, 2018, 08:03:37 PM
Quote from: RÁTNEEK on September 14, 2018, 02:10:16 PM
I just read that BMD gave out source and all for their new Black Magic Raw codec and is available to developers.

Link: https://www.4kshooters.net/2018/09/14/ibc-2018-blackmagic-design-introduces-a-brand-new-blackmagic-raw-codec/ (https://www.4kshooters.net/2018/09/14/ibc-2018-blackmagic-design-introduces-a-brand-new-blackmagic-raw-codec/)

Do you think it is possible to implement it in your already more than awesome MLV APP?
Thanks for posting. I'll study the sdk, then I'll know, if it will be possible ;)

Edit: The SDK is decoder only. So unfortunately there is no way to support it as encoder.

Quote from: theBilalFakhouri on September 14, 2018, 03:59:30 PM
MLV App causing this scan lines in the Sun when processing Dual ISO files. Any way to avoid it?
Filming directly into the sun often causes problems, also without dual iso (brings a black dot in the middle of the sun). I think the only way is to avoid to film into the sun, or tracking the sun in post and attaching e.g. a bright circle on it (possible using Resolve).
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: zalbnrum on September 14, 2018, 08:49:50 PM
Masc and Andy600 thanks for your replies.

Off topic: I checked included footage on BMD and what the new .braw does is amazing, regarding what I experienced before with cDNGs from their cameras both in terms of size, file handling and pushing in post. They did a great job once again on the software part of their product line...
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 15, 2018, 08:48:33 PM
@70MM13: jp2000 export in mov container is added to MLVApp. You can compile it or wait for next release. You can then choose between the options .jp2 sequence and .mov when codec JPG2000 is selected.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 15, 2018, 11:34:02 PM
WOW!!!!
Thank you so much!
You rock.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: escho on September 16, 2018, 10:32:55 AM
Could you add "Zoom fit" and "Zoom 100%" as symbols to the gui, please? I did a quick collage with GIMP, so you can see, what I mean:
https://seescho.files.wordpress.com/2018/09/mlv.jpg
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 16, 2018, 04:27:22 PM
Quote from: escho on September 16, 2018, 10:32:55 AM
Could you add "Zoom fit" and "Zoom 100%" as symbols to the gui, please? I did a quick collage with GIMP, so you can see, what I mean:
https://seescho.files.wordpress.com/2018/09/mlv.jpg
That would just be drag&drop in QtCreater for these 2 actions. But would you really use that at this position? Isn't the rightclick menu better (jumps to the position where you clicked when zooming in) or typing "F"?
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: escho on September 16, 2018, 05:17:45 PM
I didn´t reaize, that it can be done with right click. That´s fine for me. Thank you for the hint.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 18, 2018, 11:06:34 PM
Hello @masc

Can you please add the following values for stretching the height:
0.33 (0.333 more accurate value) for 1x3 Binning and 3.00 for 3x1 Binning. Or maybe making these stretching values changeable with a double click?

Thanks!
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 19, 2018, 09:55:40 AM
Quote from: theBilalFakhouri on September 18, 2018, 11:06:34 PM
Can you please add the following values for stretching the height:
0.33 (0.333 more accurate value) for 1x3 Binning and 3.00 for 3x1 Binning. Or maybe making these stretching values changeable with a double click?
Sure, that should be possible. Is there a way to read out the ratio from the MLV yet? For 5x3 it was possible and we could set it automatically. What sould be the expected values, if they are set? 3 and 1, 1 and 3?
Here our auto detection code:
/* Get image aspect ratio according to RAWC block info, calculating from binnin + skipping values.
   Returns aspect ratio or 0 in case if RAWC block is not present in MLV file */
float getMlvAspectRatio(mlvObject_t * video)
{
    if(video->RAWC.blockType[0])
    {
        int sampling_x = video->RAWC.binning_x + video->RAWC.skipping_x;
        int sampling_y = video->RAWC.binning_y + video->RAWC.skipping_y;

        if( sampling_x == 0 ) return 0;
        return ( (float)sampling_y / (float)sampling_x );
    }
    return 0;
}

Edit: I need some sample MLV for testing - 1 or 2 frames with each possible factor are enough.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 19, 2018, 10:23:05 AM
Hmm... Are 1x3 and 3x1 binning modes still supported in latest crop_rec.mo?
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 19, 2018, 12:51:09 PM
I added the new factors to the repository on github. I don't know if autodetection works - I have no test clips. Please upload some short clips (some frames are enough) and/or test! Thx!
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 19, 2018, 01:31:44 PM
Thanks @masc!

Sorry for the delay here it the two files: Download (https://drive.google.com/open?id=13IYCshkhT28jm9oxCtmLd8xJ5Py9-_TJ)

@bouncyball
In the new method of crop_rec now we have it (1x3 and 3x1 binning) essentially (https://www.magiclantern.fm/forum/index.php?topic=19300.msg206040#msg206040) in crop_rec.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: togg on September 19, 2018, 01:32:47 PM
Quote from: masc on August 25, 2018, 08:13:38 PM
@togg: I remember, nearly a year ago I recorded a sync test when we started implementing audio. I had one clip where audio was 1fps earlier than video. But: that means when syncing it correctly, there is no audio for the first frame - or we would have to cut away the first frame. There is only a very little more audio than video in a MLV. We decided to sync it by using the timecode (therefor we had to cut a very very little in front and in the rear of the audio channel, if I remember right, or only in the rear?!). Nobody really knows, on which position the audio is more correct than using the timecode... here a screenshot from my clip, it is the same with yours?
(https://image.ibb.co/hNTatU/Bildschirmfoto_2018_08_25_um_20_11_46.png)
@bouncyball: you remember the little book sync test?!  ;D


Here I am again. I've cutted an MLV and tested it, as you can see the audio is offsync by minus 1.5 / 2 frames. I feel like it is a stable offset, it is not drammatic but for me slow things down especially if you're in a shooting situation where you doesn't have a clap, you have to know the issue beforehand to not make a mistake. 2 frames out of sync is a lot.

http://www.mediafire.com/file/ypy6y33172cmwu1/M02-0435.MLV/file


Also I've tried the new version! I'm happy that multithread was implemented but for now I can't see any speed improvement in export, maybe even 1mb slower, which is kind of weird. it stays to 18MB/s on write, I've tested it with multiple read and write locations. I'm using a 2012 rmbp with an i7 and dedicated gpu.

Also, a super important thing for me would be to have the option stick when closing and opening the app. I'm thinking about the vertical stripes correction and hot pixel correction.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 19, 2018, 04:23:11 PM
Quote from: theBilalFakhouri on September 19, 2018, 01:31:44 PM
Sorry for the delay here it the two files: Download (https://drive.google.com/open?id=13IYCshkhT28jm9oxCtmLd8xJ5Py9-_TJ)
Thx! Auto detection works! Nice! ;D

@bouncyball: focus pixel map has again to be adapted...

@togg: thx! I will download and analyse your clip later.
The speed point: v1.0 has many new parameters, so it might not feel faster, because they have to be calculated as well (if you use them). The new multithreading affects mostly RAW Corrections (e.g. try out chroma smooth 5x5). If only preview is faster: maybe you chose a faster debayer for preview than for export. Or do you export cdng? Then you won't feel much - exept RAW Corrections are enabled.
Quote from: togg on September 19, 2018, 01:32:47 PM
Also, a super important thing for me would be to have the option stick when closing and opening the app. I'm thinking about the vertical stripes correction and hot pixel correction.
Could you please explain - I don't understand that point. All options are saved into the session and should be the same after opening again. Just use Open and Save.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 19, 2018, 05:09:44 PM
Quote from: masc on September 19, 2018, 04:23:11 PM
Thx! Auto detection works! Nice! ;D
YES it works! :)

Quote from: masc on September 19, 2018, 04:23:11 PM
@bouncyball: focus pixel map has again to be adapted...
Yes dots are all over there... (hi @dfort ;))

Quote from: masc on September 19, 2018, 04:23:11 PM
@togg: thx! I will download and analyse your clip later.
Here (http://bouncyball.myweb.ge/mlvapp/?dir=&download=Audio_issues_M02-0435.mov) is the @togg's clip rendered to h264 mov.
Do you really think it is out of sync?
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 19, 2018, 06:14:14 PM
I have been experimenting quite a lot with processing Dual ISO footage on the MLV App V1.0 lately and have to say that it does an excellent job with converting, correcting and saving such files to ProRes.  I love the new sliders and the denoise function!  Rendering speed  is also faster compared to version 0.17.  Fantastic software, providing stunning results!  Thank you so much, guys!
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on September 19, 2018, 08:40:59 PM
Quote from: bouncyball on September 19, 2018, 05:09:44 PM
Here (http://bouncyball.myweb.ge/mlvapp/?dir=&download=Audio_issues_M02-0435.mov) is the @togg's clip rendered to h264 mov.
Do you really think it is out of sync?

Yes, check in in any NLE. It is out of sync by 2 frames. It is not that noticable with a slate but for lips it become more obvious, anyway if you check in in an NLE you can see where the audio spike is and where the slate hit, audio is - 2 frames.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on September 19, 2018, 08:41:56 PM
Quote from: IDA_ML on September 19, 2018, 06:14:14 PM
I have been experimenting quite a lot with processing Dual ISO footage on the MLV App V1.0 lately and have to say that it does an excellent job with converting, correcting and saving such files to ProRes.  I love the new sliders and the denoise function!  Rendering speed  is also faster compared to version 0.17.  Fantastic software, providing stunning results!  Thank you so much, guys!

I was wondering, does dualiso export is only to compressed format? Or can you export dualiso to dngs?
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 19, 2018, 08:54:22 PM
Haven't tried that yet but it should work.  Why don't you try it by yourself?  I am away from my camera now.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on September 19, 2018, 08:56:41 PM
Quote from: masc on September 19, 2018, 04:23:11 PM
@togg: thx! I will download and analyse your clip later.
The speed point: v1.0 has many new parameters, so it might not feel faster, because they have to be calculated as well (if you use them). The new multithreading affects mostly RAW Corrections (e.g. try out chroma smooth 5x5). If only preview is faster: maybe you chose a faster debayer for preview than for export. Or do you export cdng? Then you won't feel much - exept RAW Corrections are enabled.Could you please explain - I don't understand that point. All options are saved into the session and should be the same after opening again. Just use Open and Save.

Ook so now I see. I do indeed use dng export, so as far as I understand for me multithread is more of an issue than anything, since it doesn't speed up export but use vastly more resources, ence heating the laptop for more hours etc I'll probably keep v0.17 running for longer export.

Yes, I can see now how options work with the session. Maybe what I think would be more usefull is the ability to set default settings for any new session, I never save one. I've tried to create a dummy session to reuse but it doesn't allow it to be empty, and if it can't find the old files it will revert to default. This is a problem because from time to time you can forget to reset things like vertical stripes etc.

Quote from: IDA_ML on September 19, 2018, 08:54:22 PM
Haven't tried that yet but it should work.  Why don't you try it by yourself?  I am away from my camera now.


I'm away from mine too, I'll get back to it in one week and test it :)
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 19, 2018, 09:16:12 PM
Quote from: togg on September 19, 2018, 08:56:41 PM
Ook so now I see. I do indeed use dng export, so as far as I understand for me multithread is more of an issue than anything, since it doesn't speed up export but use vastly more resources, ence heating the laptop for more hours etc I'll probably keep v0.17 running for longer export.
Multithreading also speeds up export, also for dng, depending on the settings you did.

Quote from: togg on September 19, 2018, 08:56:41 PM
Yes, I can see now how options work with the session. Maybe what I think would be more usefull is the ability to set default settings for any new session, I never save one. I've tried to create a dummy session to reuse but it doesn't allow it to be empty, and if it can't find the old files it will revert to default. This is a problem because from time to time you can forget to reset things like vertical stripes etc.
Ok. Therefor you can save your standard receipts (Export Receipt) and load them (Import Receipt) onto every clip you wish. Or you load it just on one, Ctrl+C, Ctrl+A, Ctrl+V. Now your standard settings are on every clip.

For the sync: yes, I also see 1 to 1.5 frames difference. So this is the same like in my clip. I am not sure from where the problem comes. If we sync it in MLV App manually, the first video frame would be deleted or the first frame would have no audio. What we see seems to be like that in the MLV file.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on September 19, 2018, 10:30:41 PM
Quote from: masc on September 19, 2018, 09:16:12 PM
Multithreading also speeds up export, also for dng, depending on the settings you did.
Ok. Therefor you can save your standard receipts (Export Receipt) and load them (Import Receipt) onto every clip you wish. Or you load it just on one, Ctrl+C, Ctrl+A, Ctrl+V. Now your standard settings are on every clip.

For the sync: yes, I also see 1 to 1.5 frames difference. So this is the same like in my clip. I am not sure from where the problem comes. If we sync it in MLV App manually, the first video frame would be deleted or the first frame would have no audio. What we see seems to be like that in the MLV file.

Yes, clearly a module issue. I don't know if it is fixed or what in MLV lite, but imho the cleaner solution would be to delete the first 2(ish) frames all together.

Curious to know what other people results are with exported dngs, someone is exporting with only vertical stripe and bad pixel corrections applied?
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on September 19, 2018, 11:01:28 PM
Later versions of mlv_lite has adressed audio sync issues know to sometimes cause issues with mlv_rec. Bouncyball, like I do in Switch, I believe, is syncing audio by checking offset metadata in the mlv file. Did you record the unsyced audio with mlv_rec or mlv_lite? If yes then you know what to do.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on September 19, 2018, 11:08:00 PM
Quote from: Danne on September 19, 2018, 11:01:28 PM
Later versions of mlv_lite has adressed audio sync issues know to sometimes cause issues with mlv_rec. Bouncyball, like I do in Switch, I believe, is syncing audio by checking offset metadata in the mlv file. Did you record the unsyced audio with mlv_rec or mlv_lite? If yes then you know what to do.

Yea, mlv_rec. In a week I'll have my camera back and test mlv_lite, do you feel it is a stable as mlv_rec?
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on September 19, 2018, 11:19:16 PM
More stable when it comes to sound. g3gg0 incorporated mlv_snd to mlv_lite and a1ex adressed sync issues to some sort of minimum. That together with offset syncing with post processong apps should make it more or less syncproof.
Check out this branch with sound:
crop_rec_4k_mlv_snd
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on September 20, 2018, 12:45:49 AM
Quote from: Danne on September 19, 2018, 11:19:16 PM
More stable when it comes to sound. g3gg0 incorporated mlv_snd to mlv_lite and a1ex adressed sync issues to some sort of minimum. That together with offset syncing with post processong apps should make it more or less syncproof.
Check out this branch with sound:
crop_rec_4k_mlv_snd

Ok nice! I'll do it very soon! I'll also have fun with higher fps and lossless compression. A lot of things to test before next project.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 20, 2018, 09:34:15 AM
Quote from: togg on September 19, 2018, 08:40:59 PM
Yes, check in in any NLE. It is out of sync by 2 frames.
Got it.

Hint: Latest crop_rec_4k_mlv_snd branch has experimental audio setting (when mlv_audio.mo is loaded).
Go to:

ML Menu/Movie/RAW video/Sound recording/Audio delay

And try to experiment with that value (by default it is 1)

Quote from: Danne on September 19, 2018, 11:01:28 PM
Later versions of mlv_lite has adressed audio sync issues know to sometimes cause issues with mlv_rec. Bouncyball, like I do in Switch, I believe, is syncing audio by checking offset metadata in the mlv file.
Sync is performed according to the 1st video and audio frame timestamp difference in the MLV. For the sync base 1st video frame timestamp is taken, audio can have earlier or later timestamp so positive or negative offset is calculated and used for cutting audio start or adding some silence at the beginnig, also audio start aligned to 2 audio sample boundary to prevent stereo channel swapping, the end size of the audio matched to the video length (for current FPS) and aligned to the size of audio block multiples (usually 4KB for 16bit/48khz) specific to current sample rate and bit depth (PCM audio WAV specification). That block size will be written into WAV header. The things get more complicated when MLV cutting is done but AFAIK algorithm we used worked good in any case tested.

Regards
BB
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 20, 2018, 11:34:57 AM
Quote from: IDA_ML on September 19, 2018, 06:14:14 PM
I love the new sliders and the denoise function!
Thanks IDA_ML for all your nice words. Just one question: you tried out denoise and it was working for you? What OS did you use? Bouncyball tried it on Linux and it did nothing for him - that was the main problem, why it is only in the repos, but not in v1.0. For me it was working on all 3 OS.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on September 20, 2018, 11:59:35 AM
Quote from: bouncyball on September 20, 2018, 09:34:15 AM
Got it.

Hint: Latest crop_rec_4k_mlv_snd branch has experimental audio setting (when mlv_audio.mo is loaded).
Go to:

ML Menu/Movie/RAW video/Sound recording/Audio delay

And try to experiment with that value (by default it is 1)
Sync is performed according to the 1st video and audio frame timestamp difference in the MLV. For the sync base 1st video frame timestamp is taken, audio can have earlier or later timestamp so positive or negative offset is calculated and used for cutting audio start or adding some silence at the beginnig, also audio start aligned to 2 audio sample boundary to prevent stereo channel swapping, the end size of the audio matched to the video length (for current FPS) and aligned to the size of audio block multiples (usually 4KB for 16bit/48khz) specific to current sample rate and bit depth (PCM audio WAV specification). That block size will be written into WAV header. The things get more complicated when MLV cutting is done but AFAIK algorithm we used worked good in any case tested.

Regards
BB

Perfect then, I'll be able to fine tune it until it works.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 20, 2018, 01:08:40 PM
Quote from: masc on September 20, 2018, 11:34:57 AM
Bouncyball tried it on Linux and it did nothing for him
I have to apologize. Tested today and it indeed works with latest version. Blurs the image trying to eliminate luma grain not chroma noise (which in turn can be got rid of by chroma blur option).
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 20, 2018, 01:13:13 PM
Quote from: bouncyball on September 20, 2018, 01:08:40 PM
I have to apologize. Tested today and it indeed works with latest version. Blurs the image trying to eliminate luma grain not chroma noise (which in turn can be got rid of by chroma blur option).
Okay, thx, good to know. Yes, it is a very very simple median denoise filter. It blurs the noise, but edges only a little. For a little noise it might be enough, for ISO >1600 it isn't. But it is way faster than the other better algorithm I tried out ( 2min per frame?! ;D )...
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 20, 2018, 01:15:44 PM
Quote from: masc on September 20, 2018, 01:13:13 PM
But it is way faster than the other better algorithm I tried out ( 2min per frame?! ;D )...
;D
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: zalbnrum on September 20, 2018, 09:38:56 PM
@masc

Hope I won't sound stupid again; is there a reason, that Cineform RAW is not included as an option of export? And those are unified files, not separate frames as in cDNG's? Lossles 1:4 > 1:10 cempressed 12bit RAW? I found there used to be Cineform RAW converter in early days of ML RAW (2014ish).

If it is so I think it would be really useful to implement that, if possible.

Thank you.

Link: https://gopro.github.io/cineform-sdk/ (https://gopro.github.io/cineform-sdk/)
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 21, 2018, 12:42:54 PM
Quote from: masc on September 20, 2018, 11:34:57 AM
Thanks IDA_ML for all your nice words. Just one question: you tried out denoise and it was working for you? What OS did you use? Bouncyball tried it on Linux and it did nothing for him - that was the main problem, why it is only in the repos, but not in v1.0. For me it was working on all 3 OS.

Masc,

I tried it on Win7x64 on my very old laptop and it works.  Denoising just takes longer.  I also use it in combination with the Chroma separation function at a Blur radius setting of 6 or 7.  This totally kills the color noise while preserving fine detail but it takes even longer to render.  Overall, I like the results from these too combinations very much.  In my opinion, this is a very powerful software. 
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Enrico on September 21, 2018, 05:28:36 PM
Hi everyone, I've just a question, where could I find a well explained tutorial about the workflow of raw dual iso clips? I use to work with MLV App but I think this time i will need something more
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 21, 2018, 08:00:27 PM
The only difference in the workflow is clicking the button dual iso. As far as I know there is no tutorial.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on September 22, 2018, 01:04:23 AM
I forgot to ask, regarding MLV lossless compression in the test branch that I'm going to test in a few days. It basically means that dng export will match the size if I use it right? They use the same compression? How about the stability? Is there any downside, even in post, if you capture compressed mlv? I'm only interested in 14bit.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2018, 07:24:30 AM
Quote from: togg on September 22, 2018, 01:04:23 AM
Is there any downside, even in post, if you capture compressed mlv? I'm only interested in 14bit.
Believe me, there are only benefits :D
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 22, 2018, 09:16:02 AM
The only downside should be: it is slightly slower in playback and rendering, because it has to be uncompressed.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on September 22, 2018, 09:28:03 AM
There is also the possibility to uncompress the 14bit files if you want that...
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on September 22, 2018, 12:09:55 PM
Quote from: bouncyball on September 22, 2018, 07:24:30 AM
Believe me, there are only benefits :D

perfect!

Quote from: masc on September 22, 2018, 09:16:02 AM
The only downside should be: it is slightly slower in playback and rendering, because it has to be uncompressed.

That could be an issue, I'm already bothered by the fact that every time that you want to play a new clip, especially if it is a long one, you have to wait such a longtime. It doesn't work very well for dailies.

Quote from: Danne on September 22, 2018, 09:28:03 AM
There is also the possibility to uncompress the 14bit files if you want that...

mmm I would probably avoid an extra step like this, since I always need to export dng for resolve.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 22, 2018, 02:37:43 PM
Why not to add Bilinear Cached preview for Real-time or mostly Real-Time ? :D
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 22, 2018, 02:41:00 PM
Quote from: theBilalFakhouri on September 22, 2018, 02:37:43 PM
Why not to add Bilinear Cached preview for Real-time or mostly Real-Time ? :D
Because it wouldn't make it faster... bilinear reaches the same speed like AMaZE cached - at least on my very old Core2Duo, and newer systems should be even faster.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 22, 2018, 03:47:13 PM
Yeah cached bilinear would be same speed as cached amaze. The debayered frames would be saved in memory in both cases, so the algorithm used for debayering stops being a factor.

What kind of frame rates is everyone getting with 1.0?
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2018, 04:31:26 PM
@togg

Quote from: togg on September 22, 2018, 12:09:55 PM
That could be an issue, I'm already bothered by the fact that every time that you want to play a new clip, especially if it is a long one, you have to wait such a longtime. It doesn't work very well for dailies.
Does not matter how long clip is, decompressing is done per frame and on the fly. It is barely noticeable even in MLVFS.

Edit: You just have to try it yourself and all questions will go away :D
Edit2: Nobody's willing to use uncompressed MLVs any more b/c of the data rate reduction and higher resolution recording possibility.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 22, 2018, 05:17:57 PM
Quote from: Ilia3101 on September 22, 2018, 03:47:13 PM
What kind of frame rates is everyone getting with 1.0?

All clips 1856x1044 from 5D2:

iMac 2011 i5:
Uncompressed MLV 20fps, Compressed MLV 12fps

MacBookPro 2010 Core2Duo:
Uncompressed MLV 8fps, Compressed MLV 6fps
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2018, 05:44:48 PM
Right...

Clip 1920x1080 compressed - 19fps
Same clip uncompressed - 28fps
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 22, 2018, 05:52:55 PM
It is noticeable when playing back trying to achieve max possible speed but maters less during exporting.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on September 22, 2018, 07:05:26 PM
Quote from: masc on September 22, 2018, 02:41:00 PM
Because it wouldn't make it faster... bilinear reaches the same speed like AMaZE cached - at least on my very old Core2Duo, and newer systems should be even faster.

How did MlRawViewer achieved real time playback? But even there that were pretty huge loading times, I don't even know why do we have loading times honestly, is it because of mlv structure?

Quote from: bouncyball on September 22, 2018, 04:31:26 PM
@togg
Does not matter how long clip is, decompressing is done per frame and on the fly. It is barely noticeable even in MLVFS.

Edit: You just have to try it yourself and all questions will go away :D
Edit2: Nobody's willing to use uncompressed MLVs any more b/c of the data rate reduction and higher resolution recording possibility.

waaaait, this is not my experience at all. I have loading times at the beginning of each mlv.

regarding uncompressed/compressed I guess I'm catchin up late because of the forum/development organization. Right now is very very hard to find relevant info and recapitulative topics. I mean even the fragmentation of nightly/experimental isn't helping.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: flostro on September 22, 2018, 07:18:31 PM
MlRawViewer has OpenGL acceleration, I have realtime playback on an 10 year old laptop.
The old .raw format had no loading time at all, since .mlv it does some indexing of the file first, that takes a little time.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on September 22, 2018, 07:48:05 PM
Quote from: flostro on September 22, 2018, 07:18:31 PM
The old .raw format had no loading time at all, since .mlv it does some indexing of the file first, that takes a little time.

Any chance of bypassing this? It is the worst.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: flostro on September 22, 2018, 08:13:11 PM
I don't know a way to bypass it or if its possible, But .raw didn't have audio or metadata so no indexing was needed.
And now I use mlv_app because it supports compressed raw and is actively beeing developed but i dont get realtime playback anymore
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 22, 2018, 08:14:52 PM
MlRawViewer uses OpenCL acceleration. That makes it fast, but on old computers with simple graphics it does not work at all.
Bypass the indexing starting from second load: enable Mapp-Files from File menu.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 22, 2018, 09:13:46 PM
For Real-time playback solution you can use Fast CinemaDNG Processor (https://www.magiclantern.fm/forum/index.php?topic=19021.0) it support MLV files directly in any bit-depth lossless or not and you can export it to different formats as well.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on September 22, 2018, 10:05:53 PM
Quote from: flostro on September 22, 2018, 08:13:11 PM
I don't know a way to bypass it or if its possible, But .raw didn't have audio or metadata so no indexing was needed.
And now I use mlv_app because it supports compressed raw and is actively beeing developed but i dont get realtime playback anymore

Indexing is needed in order to get metadata? Maybe it would be possible to have video playing without audio while the audio loads.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: flostro on September 23, 2018, 12:24:20 AM
Don't know about mlv_app, MlRawViewer generates .mrx files when you first open a .mlv file

"Commit  23d3c2f  Index Expo/Wbal/Lens metadata for every MLV frame"
"Commit  65d5e57  Persist MLV index data MLV's should now only need to be indexed one time. The index is saved into the MRX file, and reloaded/used next time the set is opened. "
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 23, 2018, 08:16:48 AM
Again: MLV App generates MAPP files for indexing, if you enable it from File menu. Enabled, there is nearly no latency loading a clip after the first time.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 23, 2018, 10:34:35 AM
Yes MAPP file does what MRX does for mlrawviewer. There are differences though.

Similarities:
Both contain Video frame index (absolute offsets to all video frames start in MLV)

Differences:
MAPP also includes audio frame index and all needed block header copies. Hence there is no need to open and scan MLV file second time at all.
Audio index simplifies audio data access when this data is to be loaded. WAV file is not saved separately.
All edits from gui saved to recipes and sessions.

MRX I believe does not include audio frame index because the WAV file is saved separately.
MRX includes all WB and color correction changes.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 23, 2018, 11:01:47 AM
So when MAPP is active and MLV does not contain audio, the second loading is lightning fast.

If audio present, loading is slower though. Because it loaded separately and waveform is generated to be shown at the bottom of the window (separate WAV saving would help a bit I think).

The delays are very noticeable mostly on spinning drives and far less on SSDs.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 23, 2018, 11:09:20 AM
BTW try MLV loading in fastcinemadng. It takes even longer than in mlv app. Well... the playback is superb though ;)
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: megapolis on September 23, 2018, 02:52:01 PM
Fast CinemaDNG takes it longer because we also need to allocate GPU memory and this is not fast procedure.

By the way, why wouldn't you add that index to MLV format? Everything is in your hands - just add to MLV specification such a feature at the end of file or you could allocate some space at the header to store offsets for each frame.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Enrico on September 23, 2018, 07:20:48 PM
Quote from: masc on September 21, 2018, 08:00:27 PM
The only difference in the workflow is clicking the button dual iso. As far as I know there is no tutorial.
I tried but it continues to flicker what am I supposed to do in Davinci?
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 23, 2018, 07:44:46 PM
Quote from: Enrico on September 23, 2018, 07:20:48 PM
I tried but it continues to flicker what am I supposed to do in Davinci?
Normally nothing flickers. So you should upload your clip (or at least a part of it), and we could analyse what happens.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on September 23, 2018, 09:02:54 PM
forget fast cdng as it is not for everyone. we need nvidia 6*** series to use fast cdng. it is totally useless for others who dont have nvidia 6 series
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: megapolis on September 23, 2018, 09:15:31 PM
Quoteforget fast cdng as it is not for everyone. we need nvidia 6*** series to use fast cdng. it is totally useless for others who dont have nvidia 6 series
Not everyone needs smooth video output. Realtime cdng processing and denoising are not right things either. That's true.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Enrico on September 23, 2018, 10:06:24 PM
Quote from: masc on September 23, 2018, 07:44:46 PM
Normally nothing flickers. So you should upload your clip (or at least a part of it), and we could analyse what happens.
Here I put a short clip https://mega.nz/#!4j5VlDDQ
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 23, 2018, 11:12:10 PM
@bouncyball Maybe MAPP should be done automatically? Like in MLRawViewer. As you've put so much work in to it. I guess the files could be annoying, but the quickness I personally like. Depends what everyone thinks about having loads of files like it was with MLRawViewer. And what about invisible mapp files? I know masc probably doesn't like that idea ;)

Quote from: megapolis on September 23, 2018, 02:52:01 PM
By the way, why wouldn't you add that index to MLV format? Everything is in your hands - just add to MLV specification such a feature at the end of file or you could allocate some space at the header to store offsets for each frame.
Interesting idea. We could add an "MAPP" block couldn't we @bouncyball? Maybe put it straight after the first MLVI block. I am a little uncomfortable about modifying files though.

Quote from: andy kh on September 23, 2018, 09:02:54 PM
forget fast cdng as it is not for everyone. we need nvidia 6*** series to use fast cdng. it is totally useless for others who dont have nvidia 6 series
MLV App is for the many not the few. I am happy that people with old hardware find it useful. What's the oldest thing it could run on I wonder...
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 24, 2018, 09:03:40 AM
Quote from: Ilia3101 on September 23, 2018, 11:12:10 PM
@bouncyball Maybe MAPP should be done automatically? Like in MLRawViewer. As you've put so much work in to it. I guess the files could be annoying, but the quickness I personally like. Depends what everyone thinks about having loads of files like it was with MLRawViewer. And what about invisible mapp files? I know masc probably doesn't like that idea ;)
I love that it is switchable... for big projects I enable it (loading time is shorter), else I disable it (to not mess my disks).
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2018, 11:17:30 AM
@megapolis

Quote from: megapolis on September 23, 2018, 02:52:01 PM
By the way, why wouldn't you add that index to MLV format? Everything is in your hands - just add to MLV specification such a feature at the end of file or you could allocate some space at the header to store offsets for each frame.
Well... that's not that pretty. File footer idea is not ideal. Adding allocated space like new header block is not good as well because this will require rewriting whole MLV and somehow calculate space required but this is impossible because very often video frame count in main header is wrong. Some metadata file like IDX, MRX, MAPP is better, you never touch original MLVs and can delete metadata files whenever you need.

Doing this in camera on the fly during recording not possible for sure.

In short, indexing is needed not only for fast access to frames but also for getting correct frame count and sort them all by timestamp (frames can be shuffled in mlv file).

BTW as I understand lossless decoding in fastcinemadgn is realized on CPU not GPU? You mentioned somewhere that you reworked the lossless decoding and it is way faster now. Am I correct?
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2018, 11:25:30 AM
@Ilia3101

Quote from: Ilia3101 on September 23, 2018, 11:12:10 PM
@bouncyball Maybe MAPP should be done automatically? Like in MLRawViewer. As you've put so much work in to it. I guess the files could be annoying, but the quickness I personally like.
It is done automatically when checked in the menu (MAPP is generated once only when MLV is fully loaded though). Loading takes in consideration existing MAPP anyway, whether this feature is active in the menu or not.

Quote from: Ilia3101 on September 23, 2018, 11:12:10 PM
I am a little uncomfortable about modifying files though
Exactly :D
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: megapolis on September 24, 2018, 02:46:39 PM
@bouncyball
QuoteBTW as I understand lossless decoding in fastcinemadgn is realized on CPU not GPU? You mentioned somewhere that you reworked the lossless decoding and it is way faster now. Am I correct?
Yes, this is correct, we do decoding on CPU. We've implemented our own algorithm to accelerate Lossless JPEG decoder on CPU. You can see more info and decoding benchmarks at https://www.fastcinemadng.com/info/jpeg/lossless-jpeg-decoder.html (https://www.fastcinemadng.com/info/jpeg/lossless-jpeg-decoder.html)
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on September 24, 2018, 06:11:48 PM
@megapolis
I have an idea. Why not help the community out with some of your cpu code so we could speed up previewing in Mlv App?
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: megapolis on September 24, 2018, 06:33:30 PM
@Danne
QuoteI have an idea. Why not help the community out with some of your cpu code so we could speed up previewing in Mlv App?
Sorry, this decoder is not open source. Soon we are going to release open source application PGM2DNG to convert raw PGM images to DNG. I will publish the link to github as soon as it's ready.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 24, 2018, 07:14:26 PM
Yup, unfortunately fastvideo libs are not free.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Enrico on September 24, 2018, 09:29:05 PM
Quote from: Enrico on September 23, 2018, 10:06:24 PM
Here I put a short clip https://mega.nz/#!4j5VlDDQ
Please have a look :( I really need help
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 24, 2018, 09:50:47 PM
Quote from: Enrico on September 24, 2018, 09:29:05 PM
Please have a look :( I really need help
There is a crypto key needed?! Can't download... sry.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Enrico on September 25, 2018, 11:23:06 AM
Quote from: masc on September 24, 2018, 09:50:47 PM
There is a crypto key needed?! Can't download... sry.
sorry this is the key !3Vt1gbqOxR66ezSP04I0Rtr2LygegBXYGM2ujmrGC28
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on September 25, 2018, 12:04:30 PM
You have filmed in HDR not dualiso. You could use the included
script in the export settings to merge the two exposures and export to prores format(mac only):
(https://i.postimg.cc/K8ttwbFW/Screen_Shot_2018-09-25_at_12.09.40.png_300px.jpg)

(https://i.postimg.cc/grFnHww2/M10-1829_000002.tiff_300px.jpg)
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 25, 2018, 10:37:24 PM
Here's a sample frame from a test shoot for an upcoming video I'm working on.

It is straight from mlvapp, showing that you can indeed do excellent grading with mlvapp.

I'm using the ISO experiments with my 5D3, dropping ISO 200 to 109.  No dual ISO used.  The foreground is full shadow, and the background is all full sun.  Beautiful dynamic range.

Mlvapp rocks!
(https://thumb.ibb.co/mhbUSU/kodak_2393_mlvapp.jpg) (https://ibb.co/mhbUSU)
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 26, 2018, 09:02:49 AM
@70MM13

8) Cool!
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ch_d on September 26, 2018, 11:14:43 AM
Hello.
I am new to MLV App and would like to know what is your best setting for the 5DM2.

Is it necessary to use: Raw Corrections like: Pattern Noise or Chroma Smooth?

Please share your experiences.

Thank you
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 26, 2018, 02:05:51 PM
Quote from: bouncyball on September 26, 2018, 09:02:49 AM
@70MM13

8) Cool!

It's nothing short of amazing, what we can do with these old cameras thanks to the efforts of the magic lantern community.

It just keeps getting better!

Exciting times.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 26, 2018, 02:16:54 PM
Quote from: ch_d on September 26, 2018, 11:14:43 AM
Hello.
I am new to MLV App and would like to know what is your best setting for the 5DM2.
Is it necessary to use: Raw Corrections like: Pattern Noise or Chroma Smooth?
There is no best setting. And there is no best setting for a special camera. Just use the settings your clip really needs. This may be different settings for each clip.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Enrico on September 26, 2018, 08:16:15 PM
Quote from: Danne on September 25, 2018, 12:04:30 PM
You have filmed in HDR not dualiso. You could use the included
script in the export settings to merge the two exposures and export to prores format(mac only):
(https://i.postimg.cc/K8ttwbFW/Screen_Shot_2018-09-25_at_12.09.40.png_300px.jpg)

(https://i.postimg.cc/grFnHww2/M10-1829_000002.tiff_300px.jpg)
Ok thanks but I don't have a mac, what could I do with windows?
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 27, 2018, 08:54:40 AM
You have to ask @Danne :D

He is a real HDR expert!
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on September 27, 2018, 09:05:00 AM
Buy mac ;)
Kidding. But regarding the windows issue a cmd or powershell based script could work since all tools are available. Who should do it? Preferrably someone more experienced since I only done very few hours of cmd/powershell scripting.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Enrico on September 27, 2018, 09:32:09 AM
Quote from: Danne on September 27, 2018, 09:05:00 AM
Buy mac ;)
Kidding. But regarding the windows issue a cmd or powershell based script could work since all tools are available. Who should do it? Preferrably someone more experienced since I only done very few hours of cmd/powershell scripting.
Ok I'll try running a virtual machine with OSX but, why is the source code of MLV app different from mac to windows?
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on September 27, 2018, 09:53:22 AM
Script engine executes, well, scripts and it´s a post processing step outside the Mlv app environment. The idea behind this is to be able to expand and include ideas that otherwise would require heavy, timely c-based coding. Now we can make use of mac, linux, win based script engines too.

This was a cool feature added by the way(masc?):
(https://i.postimg.cc/kM8MvFyM/Sk_rmavbild_2018-09-27_kl._09.48.34.png_300px.jpg)
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 27, 2018, 12:09:12 PM
Quote from: Enrico on September 27, 2018, 09:32:09 AM
Ok I'll try running a virtual machine with OSX but, why is the source code of MLV app different from mac to windows?
Nearly all of MLVApp is cross plattform, except some single features - AVFoundation and Post-Script is OSX only atm. Post-Script could work on Windows as well, but someone has to be found implementing that.

Quote from: Danne on September 27, 2018, 09:53:22 AM
This was a cool feature added by the way(masc?):
(https://i.postimg.cc/kM8MvFyM/Sk_rmavbild_2018-09-27_kl._09.48.34.png_300px.jpg)
Hehe, yes I did that - nealy identical to LR. I had the wish for a long time, now I was annoyed so much, that I got the idea how to implement. :D

I also started to write a kind of simple user manual. You can find it on the github wiki page. In next version it is also hardcoded into the app, under Help->Help.
https://github.com/ilia3101/MLV-App/wiki
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 27, 2018, 02:15:59 PM
Quote from: Danne on September 27, 2018, 09:53:22 AM
This was a cool feature added by the way(masc?):
Yeah! Great stuff :D
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 27, 2018, 07:01:22 PM
BUG REPORT

It is time for a bug report, guys.  When experimenting with Dual ISO MLV files, (inspired by Bilal's miracles), I noticed the following bugs:

1) If I apply the MLV export option to Dual ISO files to convert them into normal MLV files (without the Dual ISO stripes), no conversion occurs on export.  The stripes are still on the exported MLV file.  This happens with both - the Fast pass and the Compressed option and also when Preview is activated on the Dual ISO panel. I did not notice any difference between the two export options (Fast pass and Compressed).

In my opinion, this is a very important fix since Dual ISO MLV to MLV export is pretty fast and could be used for archiving Dual ISO files in normal format that can then easily be opened with DaVinci Resolve using MLVFS.  It would also greatly enhance the overall workflow, since one could Cut-in and Cut-out unwanted portions from the clip to save disk space.  If also some basic corrections could be applied to the Dual ISO clip prior to MLV export, that would be golden!  I noticed that MLVApp applies such corrections to the MLV file but just fails to convert it to a regular MLV.

2) Processing Dual ISO files with the Dual ISO or Preview option activated on the RAW correction panel, provides an excellent and very clean on-screen preview and allows me to do all corrections to the clip that I want.  However, when I try to export it in some of the other export formats, different from MLV, e.g. the Prores 422LT, the following happens:  The first few seconds of the exported file are normally  exported and then MLVApp fails to convert the rest of the clip - the Dual ISO stripes appear again on the remaining unconverted footage.  This happens randomly and that is why I did not notice this bug earlier when I was playing with short Dual ISO files.  Today, I tried to work with longer Dual ISO clips - 20 to 40 sec. each and it converted sometimes just the first 2 to 3 sec. and sometimes conversion stopped after the 10-th, even the 20-th second leaving the rest unconverted.  This behavior is observed with Dual ISO footage from the 100D and a 5DMk3 that I had borrowed for a short while.  Unfortunately, files are huge and it is very difficult to choose a short one for upload in which conversion fails after the first one or two seconds.  So, please try to reproduce the bug with Dual ISO clips from whatever camera you have.  I recorded my test clips at 14-bit lossless using crop-recording on both cameras.

I hope, the above behavior can be reproduced also by other users, so please report your findings here.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 27, 2018, 07:31:42 PM
Thanks IDU_ML,

1) That's no bug - it is as expected. Dual ISO MLV to MLV export does not exist. MLV export is completely untouched RAW data, even RAW Correction is not applied. But could be an enhancement for the future... (@bb, is that theoretically possible?!) ... but then it would not be so fast.

2) Do you run the official MLVApp release, or did you compile yourself? 2nd was buggy for a while using openMP, and exactly this happened very often. In the last revisions bouncyball made some other changes on dual iso for more stability. Have you tried this? @bb: could you explain what you improved?
Unfortunately my 5D2 is not able to record dualiso MLV (or is it?!).

Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on September 27, 2018, 09:30:52 PM
Quote from: IDA_ML on September 27, 2018, 07:01:22 PM
BUG REPORT
Unfortunately, files are huge and it is very difficult to choose a short one for upload in which conversion fails after the first one or two seconds.

Shorten a troublesome MLV file to let´s say 5 seconds and upload? You can cut the MLV in Mlv app.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 27, 2018, 11:04:54 PM
Quote from: masc on September 27, 2018, 07:31:42 PM
Thanks IDU_ML,

1) That's no bug - it is as expected. Dual ISO MLV to MLV export does not exist. MLV export is completely untouched RAW data, even RAW Correction is not applied. But could be an enhancement for the future... (@bb, is that theoretically possible?!) ... but then it would not be so fast.

2) Do you run the official MLVApp release, or did you compile yourself? 2nd was buggy for a while using openMP, and exactly this happened very often. In the last revisions bouncyball made some other changes on dual iso for more stability. Have you tried this? @bb: could you explain what you improved?
Unfortunately my 5D2 is not able to record dualiso MLV (or is it?!).


Thanks, Masc for tis clarification.

1) Do I understand properly that MLV to MLV export is just for applying the Cut-in and Cut-out function?  This makes a lot of sense, of course.  However, if MLVApp could be used to convert Dual ISO MLV clips to normal ones (somewhat dark but with enrmous dynamic range), along with the Cut-in and -out function preserved, that would be extremely practical and helpful, especially keeping in mind the excellent quality of Dual ISO MLV video.

2) I use the official version of MLVApp1.0 linked on the first page of this thread.  I will  see if I can shoot a Dual ISO file with the bug in the beginning so that it is uploadable after shortening as Danne suggested.  My idea was to provide also the original Dual ISO file for comparison.

Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: reddeercity on September 28, 2018, 08:16:21 AM
Quote from: masc on September 27, 2018, 07:31:42 PM
Thanks IDU_ML,
Unfortunately my 5D2 is not able to record dualiso MLV (or is it?!).
5D2212_Video_dual_iso.zip (https://bitbucket.org/reddeercity/magic-lantern_10-12bit/downloads/5D2212_Video_dual_iso.zip)

It's uses to be only for Photo mode on 5d2 but for some reasons it no longer included (maybe is broken on D4) but waza57 back in 2016
figured out how to code it to work on the 5D2 , start reading here on the Video - dual iso for 5D2 (https://www.magiclantern.fm/forum/index.php?topic=16854.msg164124#msg164124) thread .
Limitations : No fasts pans or very quick movements , this will cause a liveview freeze & will need a battery pull to un-freeze , it is safe to use beyond that .
best setting are 100/800 ISO (100 iso base & 800 iso revovery) this give around 14 stops (100 ISO = 11.75 stops default) ,
You can try different combinations , keep in mind anything over 800 iso will be noisy
Here a sample dual ISO frame from my 5D2,  I shot back in 2016 as a test I thing I tried it at 200/800 ISO
M19-2200_1_2016-03-19_0001_C0000_000023.dng (https://bitbucket.org/reddeercity/magic-lantern_10-12bit/downloads/M19-2200_1_2016-03-19_0001_C0000_000023.dng) I mainly use MLVProducer & or BarracudaGUI for cr2hdr dual iso raw post-processing (Windows XP/7/8) (https://www.magiclantern.fm/forum/index.php?topic=9102.msg85862#msg85862) or MLVFS .
I haven't tested it on the latest builds like 10-12bit or mlv_lite  but it work fine with plain vanilla builds 14bit , you may have to use a older build .
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 28, 2018, 09:17:35 AM
Hey guys!

Quote from: masc on September 27, 2018, 07:31:42 PM
(@bb, is that theoretically possible?!) ... but then it would not be so fast.
Yes theoretically it is possible but I don't wanna even think about it ;), and yes it will be as slow as dual iso processing can get, e.g very slow :D

Quote from: masc on September 27, 2018, 07:31:42 PM
In the last revisions bouncyball made some other changes on dual iso for more stability. Have you tried this? @bb: could you explain what you improved?
Yes sure. In earlier versions there was a "feature" (not so good as it turned out): detecting dual iso validity for every frame, it is built into dual iso code itself.

You know why? b/c dual iso's been invented and implemented by a1ex with still photography in mind.

In marginal cases (very bright/black, overexposed/underexposed) the detection fails and therefore forcing dual iso processing fails too. Now this behavior changed and only very extreme cases are affected where dual iso processing can not be done by the actual code.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 28, 2018, 09:25:26 AM
Quote from: IDA_ML on September 27, 2018, 11:04:54 PM
1) Do I understand properly that MLV to MLV export is just for applying the Cut-in and Cut-out function? 
Yes that's correct.

Quote from: IDA_ML on September 27, 2018, 11:04:54 PM
However, if MLVApp could be used to convert Dual ISO MLV clips to normal ones (somewhat dark but with enrmous dynamic range), along with the Cut-in and -out function preserved, that would be extremely practical and helpful, especially keeping in mind the excellent quality of Dual ISO MLV video.
Export DNGs instead. Keep original MLVs. It's possible there will be more advanced (quality wise) and quick dual iso processing code written by someone in the future.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 28, 2018, 11:46:02 AM
@IDA_ML

Quote from: IDA_ML on September 27, 2018, 07:01:22 PM
the following happens:  The first few seconds of the exported file are normally  exported and then MLVApp fails to convert the rest of the clip - the Dual ISO stripes appear again on the remaining unconverted footage.  This happens randomly and that is why I did not notice this bug earlier when I was playing with short Dual ISO files.
It was reproduced long time ago and it turned out the reason was the fact that in very bright conditions dual iso exposures could not be matched.

Now I fixed that behavior here (https://github.com/ilia3101/MLV-App/commit/892b6cfbfe0c04643dea0b4ce7058d7bbce601d0)

Please compile latest version and share your findings.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 28, 2018, 11:53:35 AM
Quote from: bouncyball on September 28, 2018, 09:17:35 AM
In marginal cases (very bright/black, overexposed/underexposed) the detection fails and therefore forcing dual iso processing fails too. Now this behavior changed and only very extreme cases are affected where dual iso processing can not be done by the actual code.

I noticed that this instability is time variant.  The same Dual ISO file failed to convert several times yesterday at different elapsed intervals from the beginning (from 3 sec. to 20 sec.).  This morning, I tried the conversion again, using the same file and exactly the same MLVApp settings and it converted fine - all 40 sec. of the clip.  Trying a second conversion with the same settings a few minutes later and conversion failed again after 2 sec.  These experiments I performed on a normally exposed Dual ISO 100/800 flle shot at 3072x1728 resolution at 14-bit lossless without any extreme under or overexposure.  I set the export conversion to ProRes422LT (my favorite).

But anyway, I am very happy that even just once, the above file converted fine in its full length.  So, there is hope that the instability issue might be successfully resolved, hopefully !!!  By the way, Bouncyball, the above 40 sec. clip (about 6 GB MLV) took between 22 and 32 minutes to convert on an i7 3,8 GHz PC dependent on the settings applied.  If with the Dual ISO ON option only exposure, shadows, darks and lights are applied, it takes about 22 min.  If you activate all options you can think of, it takes 32 min.  CPU operates 100% load during conversion and chip temperature varies between 95 and 100 deg. C.  Not bad, hey!  Just like DaVinci Resolve but slower  :-))).  Video quality at the above Dual ISO resolution is stunning though - well worth the effort.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 28, 2018, 11:58:42 AM
Quote from: bouncyball on September 28, 2018, 11:46:02 AM
@IDA_ML
It was reproduced long time ago and it turned out the reason was the fact that in very bright conditions dual iso exposures could not be matched.

Now I fixed that behavior here (https://github.com/ilia3101/MLV-App/commit/892b6cfbfe0c04643dea0b4ce7058d7bbce601d0)

Please compile latest version and share your findings.

Unfortunately, I do not have any compiling skills at all.  But if you provide a compiled experimental version and post a link here, I will be more than happy to test and provide feedback.  Other people can test too.  Would you like to do that, Bouncyball?
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 28, 2018, 12:55:25 PM
Here is the latest WINx64 build (http://bouncyball.myweb.ge/mlvapp/?dir=&download=MLVApp.exe)

1. Fixed dual iso issue
2. More speedup to dual iso
3. Reworked audio loading
3. Now creates MAPP v2 files
    This speeds up second loading dramatically, no matter MLV with audio or not
    @mask said for 9.5GB file loading time decreased from 32sec to 2 sec 8)
4. Lots of cool additions and fixes from @mask :D (more than he wrote down there)
5. Some scripting fixes from Danne (not related to windows build though)

You can see commits here (https://github.com/ilia3101/MLV-App/commits/master).
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 28, 2018, 12:58:01 PM
Quote from: bouncyball on September 28, 2018, 12:55:25 PM
Here is the latest WINx64 build (http://bouncyball.myweb.ge/mlvapp/?dir=&download=MLVApp.exe)

1. Fixed dual iso issue
2. More speedup to dual iso
3. Reworked audio loading
3. Now creates MAPP v2 files
    This speeds up second loading dramatically, no matter MLV with audio or not
    @mask said for 9.5GB file loading time decreased from 32sec to 2 sec 8)
4. Copy mask
5. PNG 16bit export (@70MM13) & jp2000 export in .mov container
6. Linear Gradient
7. Very simple 2D median denoiser
8. Help Dialog
9. New vertical stretch factors 0.333 and 3.0
...
@bouncyball, Ilia and Danne... if I count all the new stuff here... time for v1.1? (See also discussion on github.)

@reddeercity: thanks. I'll go reading this weekend!  8)
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on September 28, 2018, 02:44:47 PM
Quote from: masc on September 28, 2018, 12:58:01 PM
@bouncyball, Ilia and Danne... if I count all the new stuff here... time for v1.1? (See also discussion on github.)
Absolutely.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: benoit on September 28, 2018, 02:47:04 PM
Yeah for v1.1 ! great release, more stable on dual iso !  Thanks
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 28, 2018, 02:58:20 PM
Wow, you guys are moving really fast!  Thanks a lot, Bouncyball, Masc, Ilia, Danne  and everyone else involved.  I will test Dual ISO as soon as I can and will provide feedback.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 28, 2018, 05:09:05 PM
Yes now Dual ISO is perfect now I had before some issues like some randomly unprocessed frames or process few frames in the beginning then skipping the rest.

Thanks for fixes also for new stretch values this is big time saver!
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 28, 2018, 05:29:57 PM
@theBilalFakhouri

Thanks for feedback, I have not tested the windows build myself :D
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 28, 2018, 05:34:57 PM
Hey guys in post processing section of the forum this tread leads by replies and pages :). By views mlrawviewer thread is the leader.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 28, 2018, 07:46:22 PM
@bouncyball

Thanks for you too! :D and for @masc and @Ilia3101 for this really great App!

Can we make Time-Lapse export mode?

I shot MLV video @ 6 FPS and I don't want to render and process all the frames which are 6895 and size of 29.5 GB then speed it up in editing software I want to export 1 Frame after every 25 Frames for example or 1 Frame after 50 Frames this is changeable choice depending on the Time-Lapse speed you want but you got the Idea.

Is this doable?

Thanks :D
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 29, 2018, 12:51:52 PM
Quote from: theBilalFakhouri on September 28, 2018, 07:46:22 PM
Can we make Time-Lapse export mode?

I shot MLV video @ 6 FPS and I don't want to render and process all the frames which are 6895 and size of 29.5 GB then speed it up in editing software I want to export 1 Frame after every 25 Frames for example or 1 Frame after 50 Frames this is changeable choice depending on the Time-Lapse speed you want but you got the Idea.

Is this doable?
I did a quick check and it seems doable, if we want it for export only. For playback the change would be huge. We only have to think about, how to bring it into export settings, that everyone is able to understand what it does. ;) Maybe: "Timelapse frame skip [xx frames]+-" or something (that makes me not really happy, better ideas?)...
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: a1ex on September 29, 2018, 02:45:04 PM
If you already captured all this data, it's best to keep it, i.e. rather than exporting one frame out of 25, I believe it's better to average all of them in a way that minimizes temporal aliasing.

Somewhat like this: http://tessive.com/the-time-filter

I have yet to experiment with this, but any of these should give much better results than keeping just one frame out of 25:
- 180-degree averaging (i.e. average half of the frames in each group)
- use variable weights when averaging, such as a Gaussian bell curve

e.g.

- 180-degree averaging: weights = [  0 0 0 0 0 0 1 1 1 1 1 1 1 1 1 1 1 1 1 0 0 0 0 0 0 ] / 13  # i.e. average 13 frames out of 25
- "Gaussian" weighting (just an example): [ 0.001 0.002 0.004 0.008 0.014 0.023 0.034 0.047 0.061 0.075 0.087 0.095 0.098 0.095 0.087 0.075 0.061 0.047 0.034 0.023 0.014 0.008 0.004 0.002 0.001 ]

(https://a1ex.magiclantern.fm/bleeding-edge/frame-avg/frameavg.png)

To get the above "Gaussian" weights in octave:

w0 = [  0 0 0 0 0 0 0 0 0 0 1 1 1 1 1 0 0 0 0 0 0 0 0 0 0 ] / 5;
w1 = conv(w0,w0)(25-12:25+12);
w2 = conv(w1,w1)(25-12:25+12);
w3 = conv(w2,w2)(25-12:25+12);
printf("%.3f ", w3);


Of course, the processing time will be much higher.

I hope to be able to perform this kind averaging on the camera's image processor at some point...
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: zalbnrum on September 29, 2018, 02:50:55 PM
I have experinced a problem in 1.1.; if selecting "none"  in reciept mask setup, it does not save it, and if you select only one clip, there is no "paste reciept" when right clicking it. Maybe it's just me, but could somebody please check? Using windows x64 version from Reply #2033

In 1.0 I just unchecked "enable raw correction", copied reciept and pasted to other mlv's on the left pane.

Othervise it is much more stable with dual ISO and so on. Congrats!
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on September 29, 2018, 04:27:06 PM
Quote from: bouncyball on September 28, 2018, 05:34:57 PM
Hey guys in post processing section of the forum this tread leads by replies and pages :). By views mlrawviewer thread is the leader.

Niiice :)


Got back to my camera. I've tried mlv lite with sound a little bit and reported a few bugs in the crop rec topic, curious to know if you get the same experience.
Lossless files are great and it is also nice that it has a audio delay option.


Coming back to MLV App.

1) I can confirm that dng export in v1.0 is a inch slower than v0.17 with simple raw corrections enabled (vertical stripes), surelly not faster. And using way more resources

2) Preview run at 7 fps on a rmbp from 2012, 2.3 i7 and GT650 1GB.

3) Couldn't test indexing times througly because I only took small videos.


Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 29, 2018, 09:04:57 PM
@a1ex: very interesting! Will think about it! :)

Quote from: RÁTNEEK on September 29, 2018, 02:50:55 PM
I have experinced a problem in 1.1.; if selecting "none"  in reciept mask setup, it does not save it, and if you select only one clip, there is no "paste reciept" when right clicking it. Maybe it's just me, but could somebody please check? Using windows x64 version from Reply #2033

In 1.0 I just unchecked "enable raw correction", copied reciept and pasted to other mlv's on the left pane.

Othervise it is much more stable with dual ISO and so on. Congrats!
Sry, don't understand: if you select "none" you just copy nothing and paste nothing. What should be saved?
If only one clip is selected, there is no paste receipt in rightclick menu - right. This is because if only one clip is selected the paste always goes to the viewers clip - not to the one selected in the session view.

Quote from: togg on September 29, 2018, 04:27:06 PM
Coming back to MLV App.
1) I can confirm that dng export in v1.0 is a inch slower than v0.17 with simple raw corrections enabled (vertical stripes), surelly not faster. And using way more resources
I can't say at all. In my test on a MBP 2010 Core2Duo, same raw corrections as you told: v0.17 14sec for my testclip, same in v.1.0 8sec. More ressources: yes, it is multithreaded.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on September 29, 2018, 09:31:35 PM
That is so weird. How about other people? Are you getting better speed? I'll try to test it again tomorrow.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: zalbnrum on September 29, 2018, 09:33:24 PM
@masc: I just want to uncheck "enable raw correction". Exporting to cdng. In 1.0 I put multiple mlv's in "session", unchecked at the selected one, clicked "copy the reciept to clipboard", selected other mlv's in "session" and right clicked "paste reciept" and that was it.

In 1.1. when I click "copy the reciept to clipboard" the new "receipt mask setup" opens, if I uncheck all = select "none" at the left bottom, and click "OK" nothing is saved to clipboard, as I understand, cause there is when right clicking other mlv's no "paste reciept" option.

I hope I wrote it clearly enough, not a native ENG speaker. Thank you.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on September 29, 2018, 09:48:16 PM
Quote from: zalbnrum on September 29, 2018, 09:33:24 PM
@masc: I just want to uncheck "enable raw correction". Exporting to cdng. In 1.0 I put multiple mlv's in "session", unchecked at the selected one, clicked "copy the reciept to clipboard", selected other mlv's in "session" and right clicked "paste reciept" and that was it.

In 1.1. when I click "copy the reciept to clipboard" the new "receipt mask setup" opens, if I uncheck all = select "none" at the left bottom, and click "OK" nothing is saved to clipboard, as I understand, cause there is when right clicking other mlv's no "paste reciept" option.

I hope I wrote it clearly enough, not a native ENG speaker. Thank you.
In <=v1.0 without the copy mask you always copied "All->Ok", but without this dialog. If you have different settings on each clip in the session, and in the end you just want to uncheck raw corrections:
in <=v1.0: you have to select each clip and uncheck it manually
in >v1.0: you uncheck it once, copy with "None, check only raw corrections, Ok" and paste to all clips. Now all other settings still exists, but the raw correction is always disabled.
If you just import the clips (=standard setup) and you want just to uncheck raw corrections on all clips: uncheck it once, copy with "All, Ok", and paste to all clips.

The rightclick -> paste has nothing to do with copy mask setup. It has to do with pasting in general. If you have 2 clips, 2nd is active and you paste: you'll paste on 2nd clip. Now you just click (don't activate) 1st clip, paste: you again paste on 2nd. -> if one clip is selected, you always paste on active one. That is why rightclick paste isn't there. It would nearly never do, what the user would expect.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: zalbnrum on September 29, 2018, 09:52:43 PM
Thank you for your answer.

In between tried it and got it. In "receipt mask setup" you check which settings are copied and which aren't from selected clip and not the other way around. Stupid me. Sorry for spam.
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 30, 2018, 06:28:23 PM
What an excellent idea!

This would be amazing for interesting effects!

Quote from: a1ex on September 29, 2018, 02:45:04 PM
If you already captured all this data, it's best to keep it, i.e. rather than exporting one frame out of 25, I believe it's better to average all of them in a way that minimizes temporal aliasing.

Somewhat like this: http://tessive.com/the-time-filter

I have yet to experiment with this, but any of these should give much better results than keeping just one frame out of 25:
- 180-degree averaging (i.e. average half of the frames in each group)
- use variable weights when averaging, such as a Gaussian bell curve

e.g.

- 180-degree averaging: weights = [  0 0 0 0 0 0 1 1 1 1 1 1 1 1 1 1 1 1 1 0 0 0 0 0 0 ] / 13  # i.e. average 13 frames out of 25
- "Gaussian" weighting (just an example): [ 0.001 0.002 0.004 0.008 0.014 0.023 0.034 0.047 0.061 0.075 0.087 0.095 0.098 0.095 0.087 0.075 0.061 0.047 0.034 0.023 0.014 0.008 0.004 0.002 0.001 ]

(https://a1ex.magiclantern.fm/bleeding-edge/frame-avg/frameavg.png)

To get the above "Gaussian" weights in octave:

w0 = [  0 0 0 0 0 0 0 0 0 0 1 1 1 1 1 0 0 0 0 0 0 0 0 0 0 ] / 5;
w1 = conv(w0,w0)(25-12:25+12);
w2 = conv(w1,w1)(25-12:25+12);
w3 = conv(w2,w2)(25-12:25+12);
printf("%.3f ", w3);


Of course, the processing time will be much higher.

I hope to be able to perform this kind averaging on the camera's image processor at some point...
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 01, 2018, 08:49:36 PM
And finally here is v1.1: https://github.com/ilia3101/MLV-App/releases/tag/QTv1.1

New in v1.1:
- Fixed dual iso issue
- More speedup to dual iso
- Reworked audio loading
- Now creates MAPP v2 files (this speeds up second+ loading dramatically)
- Some scripting fixes from @Danne (OSX only)
- Copy mask
- Added PNG 16bit export
- Added jp2000 export in .mov container
- Improvements on IGV demosaic
- Linear gradient, with Exposure and Contrast sliders
- Simple 2D median denoiser
- Help dialog, as a first simple version of a user manual
- New vertical stretch factors 0.333 and 3.0
- Even more fixes...

(https://user-images.githubusercontent.com/30245296/46308556-42329400-c5ba-11e8-8101-1feef23ee706.png)

Minimum OS (unchanged):
- OSX 10.8.5 Mountain Lion
- Windows 7
- Ubuntu 14.04 LTS
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 01, 2018, 11:30:49 PM
Wow
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: reddeercity on October 02, 2018, 05:38:39 AM
Is there any support for External Grading monitor or output to a secondary calibrated monitor ?
Without it it's just a guessing game even with scopes , not knowing if the color or exposure is right , etc. ...
That's what keeps me from using this app plus a few other little annoying things
like can't resize the side panels no drop & drag on the main viewing window ,

Too much on the right side panel , Exposure & White balance should be with the "Raw Adjustment"
too many Debaying/postprocessing options there should not be in RAW adjustments
(maybe hidden dropdown menu, not all cam need this) , maybe in it's own separate window .
Plus I thing the color correction & raw adjustments panel should be on the bottom of the main viewing window
instead of the right side of the window this would give the most view area without loosen access to the grading tools .

It was bit confusing trying to quickly correct a file & export flat "CLog" like grade.
One more quick thought , maybe have different window configuration , e.g. color grading , postprocessing , raw adjustments
this would only bring up tools for certain operation and keep the workspace clean & uncluttered 
Just my own opinion , take it with a gain of salt .
Edit: on Windows 7pro , checked out the 64bit windows version
Title: Re: MLV App V1.0 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on October 02, 2018, 09:12:57 AM
Quote from: masc on September 29, 2018, 12:51:52 PM
I did a quick check and it seems doable, if we want it for export only. For playback the change would be huge. We only have to think about, how to bring it into export settings, that everyone is able to understand what it does. ;) Maybe: "Timelapse frame skip [xx frames]+-" or something (that makes me not really happy, better ideas?)...

Maybe a better idea to create a new tab (On/Off) like RAW Correction and name it "Time-Lapse"  under these settings or ideas:

"Leave 1 frame every xx frames" or "Skip xx frames every 1 frame" and under this setting make a time-lapse duration calculator to make the users know how many seconds will be the video in the end at current skipping frames setting.

"Averaging" (Check box). And other settings related to it .. as a1ex idea .

If the Time-Lapse was shot @ 23.976 FPS we can make a setting to leave first few seconds as normal video then speed it up like the Vlog. In general speed up Time-Lapse over time.

This what I am thinking right now if there are more settings to Time-Lapse to play with or it's good to be here.. Share your Ideas Human Beings  :D

Of course maybe this isn't that easy to do ,, but These are an Ideas to say or to talk about :D
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 02, 2018, 09:17:41 AM
@reddeercity

Thanks for feedback

Quote from: reddeercity on October 02, 2018, 05:38:39 AM
Is there any support for External Grading monitor or output to a secondary calibrated monitor ?
Nope, but it's nice feature to have.

Quote from: reddeercity on October 02, 2018, 05:38:39 AM
Exposure & White balance should be with the "Raw Adjustment"
Can't agree. I think it is in right place.

Quote from: reddeercity on October 02, 2018, 05:38:39 AM
too many Debaying/postprocessing options there should not be in RAW adjustments
Can you be more specific. which one?

1st versions of the raw correction section had the drop down list boxes not radio buttons. Ilia did that button stuff in cocoa version and it looked so nice that we desided to do the same in QT. Now I think earlier version was more compact and maybe more easily perceptible. But anyway @masc put so much effort into those radio buttons ;) (they are not natively supported in QT) That I could not say just: hello, let's go back to the original one :D

Quote from: reddeercity on October 02, 2018, 05:38:39 AM
Plus I thing the color correction & raw adjustments panel should be on the bottom of the main viewing window
instead of the right side of the window this would give the most view area without loosen access to the grading tools .
This is the lightroom's style of right panel which is a bit overloaded but I used to it now. Besides you've got two simple hotkeys for panel hiding/showing. "S" for session panel and "E" for edit panel. And you can manipulate with them as quickly as it gets.

Quote from: reddeercity on October 02, 2018, 05:38:39 AM
It was bit confusing trying to quickly correct a file & export flat "CLog" like grade.
You mean there are many options grayed out and can't be altered?

regards
bb
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 02, 2018, 09:18:26 AM
Thanks @reddeercity for your message!
Quote from: reddeercity on October 02, 2018, 05:38:39 AM
Is there any support for External Grading monitor or output to a secondary calibrated monitor ?
Not yet, but I could imagine creating a second window which you can drag wherever you want - if that helps.
Quote from: reddeercity on October 02, 2018, 05:38:39 AM
Without it it's just a guessing game even with scopes , not knowing if the color or exposure is right , etc. ...
For now, you only could drag the program itself on your calibrated monitor.
Quote from: reddeercity on October 02, 2018, 05:38:39 AM
That's what keeps me from using this app plus a few other little annoying things
like can't resize the side panels no drop & drag on the main viewing window ,
Drag & Drop for importing files on main viewing area? That could also be added, that would not be to difficult.
Quote from: reddeercity on October 02, 2018, 05:38:39 AM
Too much on the right side panel , Exposure & White balance should be with the "Raw Adjustment"
Disagree: Exposure and WB is done after debayering, so not on RAW data.
Quote from: reddeercity on October 02, 2018, 05:38:39 AM
too many Debaying/postprocessing options there should not be in RAW adjustments
All what you find in RAW correction is done before debayering - so on RAW data. If you find it there, it isn't done in post.
Quote from: reddeercity on October 02, 2018, 05:38:39 AM
(maybe hidden dropdown menu, not all cam need this) , maybe in it's own separate window .
Plus I thing the color correction & raw adjustments panel should be on the bottom of the main viewing window
instead of the right side of the window this would give the most view area without loosen access to the grading tools .
This is surely a question of taste. We decided to make it in a way like Adobe did with Lightroom - which I always loved when working on photos and where I always was very sad that there is no tool for video like that. In general our concept was and is: right: edit, bottom: audio, left: session. To get maximum viewing area just type A+S+E. Type it again and you're back ;)
Quote from: reddeercity on October 02, 2018, 05:38:39 AM

It was bit confusing trying to quickly correct a file & export flat "CLog" like grade.
One more quick thought , maybe have different window configuration , e.g. color grading , postprocessing , raw adjustments
this would only bring up tools for certain operation and keep the workspace clean & uncluttered 
Hm - that would be another concept, where we discussed about nearly a year ago. These days we decided for colapseable groups. So you can always hide what you don't need and see what you need - with just a few simple clicks. Your idea is not bad, but a complete redesign of the main SW modules would be the result.
Quote from: reddeercity on October 02, 2018, 05:38:39 AM
Just my own opinion , take it with a gain of salt .
Edit: on Windows 7pro , checked out the 64bit windows version
No problem - thank you! These messages are very important for us! ;)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 02, 2018, 09:26:51 AM
@masc: Haha I always liked that our thoughts always matched before any words ;)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 02, 2018, 08:25:42 PM
Quote from: bouncyball on October 02, 2018, 09:26:51 AM
@masc: Haha I always liked that our thoughts always matched before any words ;)
LOL.

@reddeercity: dropping MLVs on viewer area was not straight forward but works now... :)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 02, 2018, 10:17:58 PM
Drag and drop into main window. Very cool.
I also like the lightroom resemblance with the sliders. Easy to follow.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: clanlee on October 03, 2018, 01:43:05 AM
Thank you to the developers for all their great work on this application.

Would it be possible to see more than just one of Histogram, Waveform, Vector scope and Parade?  Would it be possible to adjust the size to make it larger?

Thank you.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: reddeercity on October 03, 2018, 07:38:24 AM
Quote from: masc on October 02, 2018, 08:25:42 PM
LOL.
@reddeercity: dropping MLVs on viewer area was not straight forward but works now... :)
Great ,
Thanks for the detail explanation , Will unfortunately I don't like the Light Room feel , I never used and never will .
If I need to do post work on a cr2 etc. ... I use UFRaw .
I come from a Video production & News broadcasting back ground , etc. ... I uses to programs like
Autodesk Smoke for Mac , Avid Media Composer , Blackmagic Resolve , FCP & FCPX , Apple Color , Apple Motion etc...
So I look for quick easy workflow (Smoke is still my favorite  , love working with DPX files  :-*)
To me it feels like a photo app doing video , I do understand that you like the interface as is and that fine
I was just trying to help improve this app , in my opinion this has great potential but it's in it infancy (no disrespect intended)
But before I go , I do hope you guys consider making resizable windows at the very least .
My 2cent
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on October 03, 2018, 09:12:29 AM
I have been playing around for several hours with version 1.1 and I love it!  Especially DualISO processing working fine now, is an enormous step forward keeping in mind the DualISO capabilities of our cameras in the high-resolution crop modes providing stunning quality aliasing free video with excellent fine detail and enormous dynamic range - really beatiful results that I have never seen from any other prosumer camera, even from the latest extremely expensive models from SONY shooting at 4K.  They are only comparable with those from professional cinema cameras like Arri Alexa. 

I have been using Lightroom a lot in the past, processing thousands of DNGs for hours and days to make a short film (just a few minutes long) but I had lots of problems with it.  The nastiest one was that it would randomly fail to record a processed DNG frame from the video sequence causing hick-ups in the video.  I had to find the skipped frame, fish its DNG out and process it separately with exactly the same settings, then put it back in place. It was a pain and that happenend on all the versions starting from 5.4 all the way up to 6.0 CC.  I was wasting so much time in this process that I finally gave up.  I would just make a copy of the frame next to the missing one and place it in the gap, renaming it accordingly.  This would not eliminate the hick-up but would make it less obvious.

Now, that I started using MLVApp on a regular basis, I thought - My God, what a relief!  I just let MLVApp run overnight and when I wake up in the morning, the room is pleasantly warm (yeah, it runs at 100% CPU power !!!) but I have all my files processed and converted to ProRes422, ready for mounting, cutting and finishing the movie. 

Fantastic work, guys!  Keep going!
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: whysodifficult on October 04, 2018, 10:10:39 PM
Hello,

Please, can someone please tell me why MLV App changes the colors drastically when i open MLV in it? I twisted all knobs and couldn't match the original colors. I updated to version 1.1. The same.

The first screenshot is the real colors and that's how MlRAW Viewer 1.5. sees them (correctly) and the second one is MLVApp:

(https://thumb.ibb.co/bU6nZK/Screen_Shot_2018_10_04_at_12_23_24_PM.png) (https://ibb.co/bU6nZK)

(https://thumb.ibb.co/kVzVoe/Screen_Shot_2018_10_04_at_12_24_00_PM.png) (https://ibb.co/kVzVoe)


Thank you!
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 04, 2018, 10:20:05 PM
Quote from: whysodifficult on October 04, 2018, 10:10:39 PM
Hello,

Please, can someone please tell me why MLV App changes the colors drastically when i open MLV in it? I twisted all knobs and couldn't match the original colors. I updated to version 1.1. The same.

The first screenshot is the real colors and that's how MlRAW Viewer 1.5. sees them (correctly) and the second one is MLVApp:

Thank you!

Please define "real color" and "original color". How do you want to know what is "real"?! And without a sample MLV nobody will be able to help you (some frames are enough, you can shorten the clip). Each processing software will give you different colors.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 04, 2018, 10:23:15 PM
Quote from: clanlee on October 03, 2018, 01:43:05 AM
Would it be possible to see more than just one of Histogram, Waveform, Vector scope and Parade?  Would it be possible to adjust the size to make it larger?
Each scope needs some time to calculate. Showing 2 scopes, means double calculation time. Resizing the scopes is possible in principle - but also here, we did some tricks to accelerate the calculation. Making it larger will drop framerate dramatically again. In histogram each 2nd point is interpolated already now - so it won't get more precise.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: whysodifficult on October 04, 2018, 11:22:42 PM
masc,
thank you for reply,
obviously real means how it looks in life.
This is how Colorcast-2, Footage see it and also a photo - all are about the same and about matching how i see the place in life with my own eyes: In Colorcast and Footage I changed exposure and a bit saturation to match colors to real ones. Maybe i should switch some parameter in MLVapp, but adjusting say saturation doesn;t help, leaving green color as was.


(https://thumb.ibb.co/ibkv4K/Screen_Shot_2018_10_04_at_2_16_02_PM.png) (https://ibb.co/ibkv4K)

(https://thumb.ibb.co/bBUNjK/Screen_Shot_2018_10_04_at_2_16_10_PM.png) (https://ibb.co/bBUNjK)

(https://thumb.ibb.co/gGReWz/Screen_Shot_2018_10_04_at_2_18_14_PM.png) (https://ibb.co/gGReWz)


In fact, they are all different, yes, but not THAT much different as MLVapp, and in them i can adjust colors. How can i do it in MLVapp?

This is MLV, i don't know how to shorten MLV, so i picked the shortest one - 110 mb

https://drive.google.com/file/d/1wb1kdXkshjXmZvJn3zhIw7M7GPLtjMhP/view?usp=sharing
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: whysodifficult on October 04, 2018, 11:58:36 PM
Just a thought, not for MLVapp, just general for MLVs, maybe someone sometime will do something similar:

You open MLV in app, choose the frame, click, it makes one DNG of this frame and automatically opens it in Lightroom, after making all adjustments the app somehow copies all them from Lightroom into itself and applies to all the video, then you can export to any format. Would be ideal for me...))

I came from photo and just can't handle or even understand editing in video apps, say, Resolve or Premiere, there's too small window of the video in them, and too complicated knobs, also slower than lightroom as i recall.

I can easily adjust what i need precisely in Lightroom on whole screen. Also presets. I tried to make LUTs of them, but they look much worse and imprecise in video apps than original presets in Lightroom.

But i can't process all videos through Lightroom, because it's difficult and slow to export MLV to DNGs, import them all in Lightroom, synching them, exporting, importing in App, exporting as video. Too much hassle. But all these apps that deal with MLVs unfortunately not so strong as Lightroom in adjustments.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 05, 2018, 12:40:46 AM
Speaking of color. Checking processing.c there is this for the 5D mark II:
/* Measurements taken from 5D Mark II RAW photos using EXIFtool, surely Canon can't be wrong about WB mutipliers? */
static const int wb_kelvin[]   = {  2000,  2500,  3000,  3506,  4000,  4503,  5011,  5517,  6018,  6509,  7040,  7528,  8056,  8534,  9032,  9531, 10000 };
static const double wb_red[]   = { 1.134, 1.349, 1.596, 1.731, 1.806, 1.954, 2.081, 2.197, 2.291, 2.365, 2.444, 2.485, 2.528, 2.566, 2.612, 2.660, 2.702 };
static const double wb_green[] = { 1.155, 1.137, 1.112, 1.056, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000 };
static const double wb_blue[]  = { 4.587, 3.985, 3.184, 2.524, 2.103, 1.903, 1.760, 1.641, 1.542, 1.476, 1.414, 1.390, 1.363, 1.333, 1.296, 1.263, 1.229 };


How are these figures calculated? There should be a set for all cams right?
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 05, 2018, 08:48:15 AM
Quote from: masc on October 04, 2018, 10:20:05 PM
Please define "real color" and "original color". How do you want to know what is "real"?! And without a sample MLV nobody will be able to help you (some frames are enough, you can shorten the clip). Each processing software will give you different colors.
Unfortunatelly @whysodifficult is right. I'm having this issue very often with 5D3 clips. That's because of the pale reds and blues, sometimes even greens. The bad thing is that nothing helps: WB+tint, saturation, vibrance. Color just wrong and that's it.

Without calibration or color correction it's gonna stay the way it is.

I mean I can really get very good results out of mlvapp (in opposite to mlvp, sorry) but it never matches the real vivid reds or blues in the scene at least for 5D3. In the WhiteBalance branch of mlvapp the color matching is the best, but as we all know, this branch has other issues and also lags quite behind of master.

regards
bb
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 05, 2018, 09:07:24 AM
Quote from: Danne on October 05, 2018, 12:40:46 AM
Speaking of color. Checking processing.c there is this for the 5D mark II:
/* Measurements taken from 5D Mark II RAW photos using EXIFtool, surely Canon can't be wrong about WB mutipliers? */
static const int wb_kelvin[]   = {  2000,  2500,  3000,  3506,  4000,  4503,  5011,  5517,  6018,  6509,  7040,  7528,  8056,  8534,  9032,  9531, 10000 };
static const double wb_red[]   = { 1.134, 1.349, 1.596, 1.731, 1.806, 1.954, 2.081, 2.197, 2.291, 2.365, 2.444, 2.485, 2.528, 2.566, 2.612, 2.660, 2.702 };
static const double wb_green[] = { 1.155, 1.137, 1.112, 1.056, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000, 1.000 };
static const double wb_blue[]  = { 4.587, 3.985, 3.184, 2.524, 2.103, 1.903, 1.760, 1.641, 1.542, 1.476, 1.414, 1.390, 1.363, 1.333, 1.296, 1.263, 1.229 };


How are these figures calculated? There should be a set for all cams right?
Ilia answered this question here:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg204676#msg204676
And as I understood: no, these numbers are for all cameras.

Quote from: whysodifficult on October 04, 2018, 11:58:36 PM
Just a thought, not for MLVapp, just general for MLVs, maybe someone sometime will do something similar:

You open MLV in app, choose the frame, click, it makes one DNG of this frame and automatically opens it in Lightroom, after making all adjustments the app somehow copies all them from Lightroom into itself and applies to all the video, then you can export to any format. Would be ideal for me...))
You could ask Adobe to do so. Their RAW engine is not open source and nobody knows what they are doing.

Quote from: whysodifficult on October 04, 2018, 11:58:36 PM
... in video apps, say, Resolve or Premiere, there's too small window of the video in them, and too complicated knobs,...
Thank you. This is exactly what I think.

Quote from: whysodifficult on October 04, 2018, 11:58:36 PM
I can easily adjust what i need precisely in Lightroom on whole screen. Also presets. I tried to make LUTs of them, but they look much worse and imprecise in video apps than original presets in Lightroom.
This is surely a color space problem. The colors could be interpreted differently.

Quote from: whysodifficult on October 04, 2018, 11:22:42 PM
obviously real means how it looks in life.
This is how Colorcast-2, Footage see it and also a photo - all are about the same and about matching how i see the place in life with my own eyes: In Colorcast and Footage I changed exposure and a bit saturation to match colors to real ones. Maybe i should switch some parameter in MLVapp, but adjusting say saturation doesn;t help, leaving green color as was.

In fact, they are all different, yes, but not THAT much different as MLVapp, and in them i can adjust colors. How can i do it in MLVapp?

This is MLV, i don't know how to shorten MLV, so i picked the shortest one - 110 mb
You can shorten a MLV by clicking on CutIn & CutOut in MLVApp and export it as MLV.

Colorcast and Footage brings the same color - yes. They both use Apple RAW engine. MLVApp is different, Resolve is different, Lightroom is different,  MLVProcuder is different,...
In MLVApp you can adjust the colors e.g. with a LUT (*.cube), if the sliders are not enough. Then it should bring more or less the same as other programs, because the algorithm behind the LUT is mostly identical.

It is not way off... a little different yes:
(https://image.ibb.co/mZ8Yrz/Bildschirmfoto_2018_10_05_um_08_52_05.png)
Edit: WOAH... again a colorspace problem: the pictures look completely different in my photoprogram as here in the browser. (especially the sky)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 05, 2018, 09:32:04 AM
Here is my example, it is pure color space and calibration issue (look at the red color):

mlvapp <- wrong

(https://thumb.ibb.co/bx8KEK/mlvapp.png) (https://ibb.co/bx8KEK)


darktable <- correct

(https://thumb.ibb.co/cft88e/darktable.png) (https://ibb.co/cft88e)


Edit: second pic a bit oversaturated, but anyway color is different.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Boscom on October 05, 2018, 10:02:29 AM
I'm using MLV App on 5D2 footage and it works great. Thanks for all the hard work you guys have put into it and continue to do so.

Is there anyway of improving the highlight recovery? There tends to halo's around certain highlights when the slider is reduced.. It looks to me as if the highlight range is a little broad ?

Lightroom's highlight recovery works better on the exported DNG's.
Sorry about the rubbish image, but it shows what the issue is. Left, no highlight adjustment, Right  -100%


(https://thumb.ibb.co/mbBWuK/frame_1.png) (https://ibb.co/mbBWuK)

Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 05, 2018, 10:24:49 AM
Quote from: Boscom on October 05, 2018, 10:02:29 AM
Is there anyway of improving the highlight recovery? There tends to halo's around certain highlights when the slider is reduced.. It looks to me as if the highlight range is a little broad ?

Lightroom's highlight recovery works better on the exported DNG's.
Sorry about the rubbish image, but it shows what the issue is. Left, no highlight adjustment, Right  -100%

(https://thumb.ibb.co/mbBWuK/frame_1.png) (https://ibb.co/mbBWuK)

Try it the other way: Exposure -1..-2 and Lighten up to 50 or something. Then drag Light Strength until the highlights are not clipped. With that I mostly get perfect results. (btw: highlight recovery is something different: recover clipped data in green channel)
Nobody knows what Adobe really does - it isn't open source and mostly there is no description about. We developped our own algoritms which more or less do something similar. Everybody is welcome to play around with the code and improve it.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: wety67e on October 05, 2018, 10:35:27 AM
MLV App is a great app... :D

Please add support for Adobe color profile dcp.
Rawtherapy, irident support dcp profile

Thanks

Sorry for my bad English
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 05, 2018, 11:06:02 AM
Quote from: wety67e on October 05, 2018, 10:35:27 AM
MLV App is a great app... :D

Please add support for Adobe color profile dcp.
Rawtherapy, irident support dcp profile

Thanks

Sorry for my bad English
DCP = DNG camera profile. We are working on MLV files. Input should be DNG, generated by Adobe Tools (in order to get correct output).
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: wety67e on October 05, 2018, 11:09:06 AM
Thanks  :o
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 05, 2018, 12:35:15 PM
Thanks masc for your link to my repost  :P.
I have deepest respect for Ilia3101 work getting colors as good as they are atm. With that said It´s almost a shame that we don´t seem to match color perfectly for all cams. Reading posts from mostly Andy600 it seems there can be more here to get a perfect color match. How? I have no idea but looking into processing.c it seems most calculations is derived from that code?
Unlike some other at this forum I look at Mlv App as a very mature project and mostly bug free thanks to nitpick work from mostly masc atm but color output seems to be the very heart of it all, right?
So, is there energy and time to finalize this most vital piece of the puzzle getting color matrices and color space correctly or should we start doing 3D calibration luts?
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: masc on October 05, 2018, 01:43:56 PM
Quote from: Ilia3101 on July 26, 2018, 08:21:24 PM
Ok calm down I've heard a lot of complaints about the wrong colours.

Some things:
1. I would like to bust a myth - MLV App does not use any colour matrices at all right now, no "5D2 matrix for all cameras" things going on, that is just not true and I'm not sure how the myth started. Maybe it's because the white balance multipliers are generated by data I extracted from 5D mark II photos using exiftool, however that does not affect colour in any deep 5D mark II way, they simply specify the channel multiplication factors and that is it. I'm really surprised they even work considering it is unknown what colour space they are for.
2. That(fixing the colours) is actually the processing improvement I was talking about some time ago. I have been a bit demotivated though, as every time I start working on it it just gets fiddly or crashy or something is wrong with the colour(most often this). The extreme hotness of summer combined with that makes for a perfect giving up vibe.
...
Here another post from Ilia for this topic. I do what I can; but with this topic I absolutely don't know what to do ;) Only one thing is sure: it is not easy.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: bouncyball on October 05, 2018, 02:11:15 PM
Quote from: masc on October 05, 2018, 01:43:56 PM
I do what I can; but with this topic I absolutely don't know what to do ;) Only one thing is sure: it is not easy.
+1 :D
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 05, 2018, 03:07:03 PM
@Ilia: can you describe how you got these values out of the RAWs exif? Did you calculate it with the values, e.g. Color Temp Daylight = 5200, WB RGGB Level Daylight = 2052 1024 1024 1572. So this brings the factors: 5200K: 2.0039, 1.0, 1.5351. (CR2 from a 700D). But also in a 5D2 CR2 I get slightly different values than yours. I made a quick test with some values from 700D CR2s around this and got slightly other colors with that (use only between 3200 and 6000K!)...
static const int wb_kelvin[]   = {     3200,     5200,     6000 };
static const double wb_red[]   = { 1.762695, 2.003906, 2.146484 };
static const double wb_green[] = { 1.000000, 1.000000, 1.000000 };
static const double wb_blue[]  = { 2.316406, 1.535156, 1.410156 };

(https://image.ibb.co/nnxEie/Bildschirmfoto_2018_10_05_um_15_38_19.png)
@everybody: try reading these values, adapting the code and try with your own cameras... maybe it gets better, maybe not... no idea what I am doing  :P
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 05, 2018, 06:34:10 PM
Quote from: masc on October 05, 2018, 03:07:03 PM
@everybody: try reading these values, adapting the code and try with your own cameras... maybe it gets better, maybe not... no idea what I am doing  :P
haha, I know the feeling. What is the code in mlrawviewer doing? Seems color space crappola is kind of working in that one? Yeah, I know, WHy am I asking and not checking for myself  :P
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 05, 2018, 07:47:28 PM
I played a bit around with the values I got from the 700D CR2. Okay - I need other WB settings now - but then, the pictures look 100% identical I think. Tested mostly with my 5D2 clips and some others I got here in the forum. It seems Ilia is right - if it is this, what he meant.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 05, 2018, 08:16:51 PM
Quote from: Danne on October 05, 2018, 06:34:10 PM
haha, I know the feeling. What is the code in mlrawviewer doing? Seems color space crappola is kind of working in that one? Yeah, I know, WHy am I asking and not checking for myself  :P
Have you found something? I haven't. :(

Edit: found the default in MlRaw.py line 298 balance = (2.0,1.0,1.5) # Reasonable default
With this numbers MlRawViewer = MLVApp. BUT I did not find which Kelvin this shall correspond to... cares MlRawViewer at all about it!?

Edit2 here it is...  :D from Viewer.py
elif k==self.KEY_ONE or k==self.KEY_KPONE:
            if m==0:
                self.changeWhiteBalance(2.0, 1.0, 2.0, "WhiteFluro")  # ~WhiteFluro
            elif m==1:
                self.deleteLut1D()
        elif k==self.KEY_TWO or k==self.KEY_KPTWO:
            self.changeWhiteBalance(2.0, 1.0, 1.5, "Daylight")    # ~Daylight
        elif k==self.KEY_THREE or k==self.KEY_KPTHREE:
            if m==0:
                self.changeWhiteBalance(2.5, 1.0, 1.5, "Cloudy ")     # ~Cloudy
            elif m==1:
                self.deleteLut3D()

        elif k==self.KEY_FOUR or k==self.KEY_KPFOUR:
            self.changeWhiteBalance(self.setting_rgb[0]*0.99, self.setting_rgb[1], self.setting_rgb[2], "red-")
        elif k==self.KEY_SEVEN or k==self.KEY_KPSEVEN:
            self.changeWhiteBalance(self.setting_rgb[0]*(1.0/0.99), self.setting_rgb[1], self.setting_rgb[2], "red+")
        elif k==self.KEY_SIX or k==self.KEY_KPSIX:
            self.changeWhiteBalance(self.setting_rgb[0], self.setting_rgb[1], self.setting_rgb[2]*0.99, "blue-")
        elif k==self.KEY_NINE or k==self.KEY_KPNINE:
            self.changeWhiteBalance(self.setting_rgb[0], self.setting_rgb[1], self.setting_rgb[2]*(1.0/0.99), "blue+")

        # Green control is now done by modifying R/B/brightness together
        elif k==self.KEY_FIVE or k==self.KEY_KPFIVE:
            self.changeWhiteBalance(self.setting_rgb[0]*(1.0/0.99), self.setting_rgb[1], self.setting_rgb[2]*(1.0/0.99), "green-")
            self.scaleBrightness(0.99)
        elif k==self.KEY_EIGHT or k==self.KEY_KPEIGHT:
            self.changeWhiteBalance(self.setting_rgb[0]*0.99, self.setting_rgb[1], self.setting_rgb[2]*0.99, "green+")
            self.scaleBrightness(1.0/0.99)


So MlRawViewer does not care about Temperature and Tint values. They just change the single channels. This may not be bad, it is very simple, but very different from what we try to do.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 05, 2018, 09:35:05 PM
Okay, funny. I implemented the WB strategy from MlRawViewer to MLVApp for testing - that was not difficult... and you know what? The colors are the same as before :P (with different settings on the sliders). All red tones from non5D2 or 5D2 footage are identical for example. Maybe it has more to do with colorspace and not with whitebalance?! If someone else want to try out (not nice, but working):
/* Set white balance by kelvin + tint value */
void processingSetWhiteBalance(processingObject_t * processing, double WBKelvin, double WBTint)
{
    processing->kelvin = WBKelvin;

    /* Avoid changing tint if just changing kelvin */
    if (WBTint != processing->wb_tint)
    {
        /* Non-linear tint makes control finer in the middle */
        int is_negative = (WBTint < 0.0);
        if (is_negative) WBTint = -WBTint;
        WBTint /= 10.0;
        WBTint = pow(WBTint, 1.75) * 10.0;
        if (is_negative) WBTint = -WBTint;

        processing->wb_tint = WBTint;
    }
   
    /* Kalkulate channel (yes in cone space... soon) multipliers */
    //get_kelvin_multipliers_rgb(WBKelvin, processing->wb_multipliers);

    /* Do tint (green and red channel seem to be main ones) */
    //processing->wb_multipliers[2] += (WBTint / 19.0);
    //processing->wb_multipliers[0] += (WBTint / 19.0);

    processing->wb_multipliers[0] = 2.0 + (WBKelvin-6000)/5000.0;
    processing->wb_multipliers[1] = 1.0;
    processing->wb_multipliers[2] = 1.5 + WBTint/10.0;

    /* Make all channel multipliers be >= 1 */
    /*double lowest = MIN( MIN( processing->wb_multipliers[0],
                              processing->wb_multipliers[1] ),
                              processing->wb_multipliers[2] );

    for (int i = 0; i < 3; ++i) processing->wb_multipliers[i] /= lowest;*/

    /* White balance is part of the matrix */
    processing_update_matrices(processing);
    if( processing->gradient_enable != 0 ) processing_update_matrices_gradient(processing);
}
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 05, 2018, 10:59:52 PM
Quote from: masc on October 05, 2018, 09:35:05 PM
Maybe it has more to do with colorspace and not with whitebalance?!
👍

All this colour stuff is nothing to do with white balance (well, it is a bit, but not just white balance)

I would need to implement colour matrices, like I did in the WhiteBalance branch (yes, it's called white balance because I also implemented more scientific white balance algorithm but no big deal)

The biggest problem with implementing this matrix stuff is the fact that all processing is integers. I have really struggled every time I've tried this to avoid floating point while keeping highlight reconstruction working. Using float in the most core part of processing would make it slow at its fastest.

MLRawViewer does have proper colour matrices - it uses floating point too. It's fast because it uses fancy OpenGL vertex fragment shaders, but seems they might not work with older opengl hardware(?)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 06, 2018, 08:44:54 AM
Well, just did a revisit to white balance branch and wow, we get colors back! When I was testing this branch the first time I had issues with indoor lighting but testing file below we get amazing output:

Master branch(setting "Standard")
(https://i.postimg.cc/d1xjS0n6/Screen_Shot_2018-10-06_at_08.32.54.png_500px.jpg)

White balance branch(setting "Standard" tweaked white balance and added some exposure)
(https://i.postimg.cc/bdXHpF72/Screen_Shot_2018-10-06_at_08.33.02.png_500px.jpg)

You can get into the white balance branch in Mlv_app_compiler.app by the way. Select (b) to get into branches in main menu then:
Select 4
(https://i.postimg.cc/jSBXX2gh/Screen_Shot_2018-10-06_at_08.37.13.png_300px.jpg)

Hit c for compiling
(https://i.postimg.cc/2j1sjLpz/Screen_Shot_2018-10-06_at_08.33.19.png_300px.jpg)

Or download a compiled white balance version here for testing(mac):
https://bitbucket.org/Dannephoto/magic-lantern/downloads/MLV%20App_WB.app.zip

Test MLV file:
https://drive.google.com/file/d/1wb1kdXkshjXmZvJn3zhIw7M7GPLtjMhP/view


Now here´s proof Ilia3101 more or less already solved the issues. @masc. How about trying to implement and test this into master branch?

@Ilia3101. Are matrices included now in white balance branch or is the code in processing.c doing something else before even adding the matrices? Checking the test file seems we are getting more proper color. Even without matrices I think we still get better results here.

EDIT: Testing more files and yes this version is problematic. Highlights gets pinkish so a lot of testing/refining of code needed.(Maybe it´s my test file, probably filmed with 10bit mode or so) Would love to see the code in master.


EDIT 2:
A few more examples(eos 100D):
Test file here:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/M06-0931_short.MLV
Master branch:
(https://i.postimg.cc/zGvPz3PC/Screen_Shot_2018-10-06_at_09.41.33.png_500px.jpg)

White balance branch(oh, lovely colors):
(https://i.postimg.cc/vHQNK0rS/Screen_Shot_2018-10-06_at_09.40.42.png_500px.jpg)

White balance branch highlight issue(maybe solved already in master branch)
(https://i.postimg.cc/fTBrQY5W/Screen_Shot_2018-10-06_at_09.40.57.png_500px.jpg)

Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 06, 2018, 10:40:13 AM
@Danne

Liked that branch color huh? :)
I was like: wow! this is it! when 1st tried that code.

Yes it has not only highlight issue but wb issues with other than daylight kelvin.

The half of the job is really done there by Ilia. Multiplier deriving needs some changes to support other temperatures correctly.

Well, Ilia knows better what's really needed to be changed.

Edit: Here (https://github.com/ilia3101/MLV-App/commit/c22488966b96a0b38fb38c66238210f3b3c98a44#commitcomment-28025223) is related discussion.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 06, 2018, 05:49:28 PM
Oh, quite the thread. By the way. Your modification of Ilias3101 code looks really nice.
Color science is a mess!
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 06, 2018, 07:04:36 PM
Yes it looked not bad (color wise) but had it's quirks. I think it is better to finish Ilia's version. I like it very much.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on October 07, 2018, 08:45:08 AM
Very important discussion on the tricky color science problem!  Magic Lantern seems to boost science and become an academic effort.  I hope, this discussion will initiate new progress and improvements on color in this amazing product and we will see a new build including them soon! 
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Levas on October 07, 2018, 02:13:12 PM
This software is getting better and better.
I'm wondering, is it possible to add the option of importing dng sequence (extracted from MLV's) instead of a MLV file ?
I have made the choice to keep only dng sequences as backup and throw away the original mlv's  :P

Another question, it's about the color stuff, does anyone of you know if there is any difference in the two green channels in Canon camera's ?
Just curious if Canon uses two different greens in the bayer filter.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 07, 2018, 04:22:56 PM
Quote from: Danne on October 06, 2018, 08:44:54 AM
Now here´s proof Ilia3101 more or less already solved the issues. @masc. How about trying to implement and test this into master branch?

EDIT: Testing more files and yes this version is problematic. Highlights gets pinkish so a lot of testing/refining of code needed.(Maybe it´s my test file, probably filmed with 10bit mode or so) Would love to see the code in master.
We did many test, sometimes the result was better, sometimes the result was very bad (<3500K). That's why this branch did not come into master yet. Now, a long time later (in terms of our development) the code has changed a lot and merging will not be very easy. On the other side Ilia wanted to try some other things on WB (if I remember right).
It would be very cool, to be able to toggle between the two different processing vesions. But I think this will just remain a wish... (double development effort in future).

Our old highlight revovery concept won't work at all with the new WB branch, if I understood right. So here we will have to develop something new... if someone knows how to do... your welcome.

Quote from: Levas on October 07, 2018, 02:13:12 PM
I'm wondering, is it possible to add the option of importing dng sequence (extracted from MLV's) instead of a MLV file ?
I have made the choice to keep only dng sequences as backup and throw away the original mlv's  :P
Unfortunately no. That means ... yes, but we would have to rewrite nearly everything.
Quote from: Levas on October 07, 2018, 02:13:12 PM
Another question, it's about the color stuff, does anyone of you know if there is any difference in the two green channels in Canon camera's ?
Just curious if Canon uses two different greens in the bayer filter.
I don't think so. All our debayers use both green pixels, but with different methods. The pictures should look very different or wrong, if these channels were different (in terms of green).
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Levas on October 07, 2018, 06:05:29 PM
Quote from: masc on October 07, 2018, 04:22:56 PM
Unfortunately no. That means ... yes, but we would have to rewrite nearly everything.

Too bad, but no problem.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 07, 2018, 06:28:08 PM
I would not want to merge that branch. Rewriting it is not that hard. I have some ideas for how it could be done with 16 bit ints and look up tables.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 07, 2018, 07:33:18 PM
Quote from: Ilia3101 on October 07, 2018, 06:28:08 PM
I would not want to merge that branch. Rewriting it is not that hard. I have some ideas for how it could be done with 16 bit ints and look up tables.
Sounds good! Take care: all your functions are there twice now (2nd slightly changed only) because of gradient calculation. But if we touch it, we have to change both. :)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Enrico on October 08, 2018, 08:29:59 PM
Hello everyone, is there something I can use to deal with a 10bit HDR mlv file on windows? I use to export uncompressed DNG from MLVApp and import the sequences in Davinci what could I do? :'(
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 08, 2018, 08:49:20 PM
Quote from: Enrico on October 08, 2018, 08:29:59 PM
Hello everyone, is there something I can use to deal with a 10bit HDR mlv file on windows? I use to export uncompressed DNG from MLVApp and import the sequences in Davinci what could I do? :'(
Puh... on windows there is no solution yet. What could work, but is some work for you: select every 2nd dng and put it into another folder. I am not sure if Resolve can handle 1,3,5,7,... and 2,4,6,8... sequence numbers or if you get an error. If it works, you should have two sequences and can try to blend it somehow in Resolve.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Enrico on October 08, 2018, 10:13:27 PM
Quote from: masc on October 08, 2018, 08:49:20 PM
Puh... on windows there is no solution yet. What could work, but is some work for you: select every 2nd dng and put it into another folder. I am not sure if Resolve can handle 1,3,5,7,... and 2,4,6,8... sequence numbers or if you get an error. If it works, you should have two sequences and can try to blend it somehow in Resolve.
Hmm I'm still learning to use Davinci, but is there a clean tutorial for MacOs? Becouse I could use my friend's macbook or even a virtual machine.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 09, 2018, 08:15:29 AM
Quote from: Enrico on October 08, 2018, 10:13:27 PM
Hmm I'm still learning to use Davinci, but is there a clean tutorial for MacOs? Becouse I could use my friend's macbook or even a virtual machine.
For what exactly do you need a tutorial? For Resolve or for MLVApp? In MLVApp on OSX, just select HDR script in export settings and that's all - one step.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 09, 2018, 08:30:05 AM
Quote from: masc on October 09, 2018, 08:15:29 AM
For what exactly do you need a tutorial? For Resolve or for MLVApp? In MLVApp on OSX, just select HDR script in export settings and that's all - one step.

I wonder how the script will react to downloading dependencies in a virtual machine.

Steps are easy as masc says.

If you run the script for the first time it will ask for downloading dependencies so just say yes to all of those questions.

1 - Import the mlv file and go to export settings and select the script HDR_MOV.command
(https://i.postimg.cc/1tCV4GYQ/Screen_Shot_2018-10-09_at_08.33.18.png_500px.jpg)


2 - Do your color correction etc and go to the export tab and send out your clip. When the file is ready the script will start creating the HDR file. End result will be a MOV file.
(https://i.postimg.cc/RhW6tWjn/Screen_Shot_2018-10-09_at_08.33.34.png_500px.jpg)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 09, 2018, 08:56:52 AM
Quote from: Levas on October 07, 2018, 02:13:12 PM
I'm wondering, is it possible to add the option of importing dng sequence (extracted from MLV's) instead of a MLV file ?
Then it needs brand new importer and player. Besides there are plenty apps doing DNG import. We decided mlvapp to be dedicated MLV only solution.

Quote from: Levas on October 07, 2018, 02:13:12 PM
Just curious if Canon uses two different greens in the bayer filter.
Yes there are 2 different greens. They differ a bit in each RGGB. As far as I can tell from my experience Canon does not force exact same values for rGGb.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 09, 2018, 10:00:46 AM
Quote from: bouncyball on October 09, 2018, 08:56:52 AM
Then it needs brand new importer and player. Besides there are plenty apps doing DNG import. We decided mlvapp to be dedicated MLV only solution.
Actually, I wouldn´t mind dng player functionality in Mlv App. Maybe not highest priority of course  :P
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 09, 2018, 10:29:09 AM
Quote from: bouncyball on October 09, 2018, 08:56:52 AM
Yes there are 2 different greens. They differ a bit in each RGGB. As far as I can tell from my experience Canon does not force exact same values for rGGb.
Really? But then we would need a special debayer algorithm, or at least a adapted one - don't we?! All debayers I know "calculate the green to be green"...?!
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 09, 2018, 04:17:33 PM
Quote from: masc on October 09, 2018, 10:29:09 AM
Really?
As I've seen these methods either pick just one green or, better, average both green values.

Edit: Usually difference between 2 greens is tiny. Could be the green filter manufacturing or just sensor property in this particular place or maybe some voltage fluctuation somewhere :) but diff is there.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 09, 2018, 04:20:02 PM
Quote from: Danne on October 09, 2018, 10:00:46 AM
Maybe not highest priority of course  :P
Definitely :P
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Levas on October 09, 2018, 04:46:01 PM
I remember asking years ago if MLV_dump could rewrap a dng sequence back to a MLV file, the answer was the same as here, that would take a lot of time and code writing to be possible.
Just curious, to me as a noob on how (raw) files are organized, what is the difference between MLV and a DNG sequence ?
I would expect that a MLV file is a header with some exif info and then an enormous part of 14 bit raw data(and audio mixed in).
The 14 bit raw data part, isn't that the same written down/organized in a dng ?

I'm still fine with my mlv_dump -> dng -> RawTherapee workflow by the way.
No need to implement any of this, especially if it is too much time consuming.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 09, 2018, 06:22:01 PM
Quote from: Levas on October 09, 2018, 04:46:01 PM
I remember asking years ago if MLV_dump could rewrap a dng sequence back to a MLV file, the answer was the same as here, that would take a lot of time and code writing to be possible.
Actually g3gg0's been doing this ages ago during early development (legacy RAW->DNG, DNG->legacy RAW, not MLV thought).

Quote from: Levas on October 09, 2018, 04:46:01 PM
I would expect that a MLV file is a header with some exif info and then an enormous part of 14 bit raw data(and audio mixed in).
Well not exactly. The structure of MLV is a bit more complex than this.

Quote from: Levas on October 09, 2018, 04:46:01 PM
The 14 bit raw data part, isn't that the same written down/organized in a dng ?
14bit raw data is same in DNG but endianness is changed to BIG (higher and lower bytes of the 16bit word is swapped). According to DNG spec 8 and 16 bit raw data can be little endian but other bit depth raw data have to be big endian. Hence when we are loading raw data frame from MLV (it is usually 10/12/14bit little endian) we change data endianness before saving it to DNG after quite large header with lots of dng tags.

Besides all original metadata from MLV is lost and we have to recompile it from dng header tags (not so nice part of this conversion). Some minor metadata, I believe, can not be recovered fully.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Enrico on October 09, 2018, 07:00:32 PM
Quote from: Danne on October 09, 2018, 08:30:05 AM
I wonder how the script will react to downloading dependencies in a virtual machine.

Steps are easy as masc says.

If you run the script for the first time it will ask for downloading dependencies so just say yes to all of those questions.

1 - Import the mlv file and go to export settings and select the script HDR_MOV.command
(https://i.postimg.cc/1tCV4GYQ/Screen_Shot_2018-10-09_at_08.33.18.png_500px.jpg)


2 - Do your color correction etc and go to the export tab and send out your clip. When the file is ready the script will start creating the HDR file. End result will be a MOV file.
(https://i.postimg.cc/RhW6tWjn/Screen_Shot_2018-10-09_at_08.33.34.png_500px.jpg)
Ok I tried with your same settings, I downloaded and installed all the components but after the exportation from MLVApp this is what happen
(https://thumb.ibb.co/m6zYZU/IMG_5033.jpg) (https://ibb.co/m6zYZU)
 any suggestion?
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 09, 2018, 08:09:43 PM
Well, that notifier can be used if you want to cancel processing. It also means the script is running, hopefully working. If it's working you should see files being processed inside a folder. Do you?
Also be patient. This workflow can take a while.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Enrico on October 09, 2018, 09:00:56 PM
Quote from: Danne on October 09, 2018, 08:09:43 PM
Well, that notifier can be used if you want to cancel processing. If it's working you should see files being processed inside a folder. Do you?
Also be patient. This workflow van take a while.
Okok it worked, I'm just not enough patient, thank you for your time. On the other hand which are the difficulties in implementing this script in windows?
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 09, 2018, 09:03:58 PM
Quote from: Enrico on October 09, 2018, 09:00:56 PM
On the other hand which are the difficulties in implementing this script in windows?
Windows is different to Unix. And until now we haven't found a dev who is willing to port it to windows.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 09, 2018, 10:05:45 PM
Windows is annoying
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Enrico on October 11, 2018, 03:56:06 PM
Quote from: Ilia3101 on October 09, 2018, 10:05:45 PM
Windows is annoying
I know bro but a macbook pro costs like a used car, however it'll be my next computer :'(
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Levas on October 11, 2018, 05:22:45 PM
Quote from: Enrico on October 11, 2018, 03:56:06 PM
macbook pro costs like a used car
Great comment and true  :P
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 11, 2018, 05:57:04 PM
Quote from: Levas on October 11, 2018, 05:22:45 PM
Great comment and true  :P
I got harmed twice then:
1st - when I bought brand new macbook pro 2017
2nd - when my daughter expropriated it 5 mins after I came home with my beloved purchase

:o
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 11, 2018, 06:56:28 PM
Linux is a good solution as it works pretty similar to macOS. Only thing I miss about macOS is the .app format for programs and translucency blur in the UI. Literally that's it ;)

I guess lack of Adobe software could be an issue for some.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on October 12, 2018, 03:05:22 PM
Hello hard workers!

A small problem when enabling Dual ISO:

I have a clip with wrong white level Let's say it's 16200 and the correct one is 3005. After correcting white level directly in MLVApp (Setting it to 3005) then Applying Dual ISO everything goes wrong I think Dual ISO doesn't recognize the new White level it's applying the process in old white level which is wrong and makes everything wrong.

Okay what about correcting White Level in MLVApp (Setting it to 3005) then exporting it as MLV file then import it again and Applying Dual ISO .. Now everything is working right :P , Here is the two files before and after correcting white level same clip:
Download (https://drive.google.com/open?id=1mggZGeKkyyD5bVn5NvvuVAVQh3tbPSoH)

How did I get this file?
Using Analog gain for making 10-Bit lossless working in higher resolution. I can get better recording times now in 1x3 Binning and other high resolution. And there are no vertical stripes when making the values the same in 8882 to 8888 ADTG registers (a1ex we should use them :D)

Thanks! :D
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: reddeercity on October 13, 2018, 02:27:38 AM
@ theBilalFakhouri just ran it thought mlvproducer it look ok with dual iso enabled at 16200 white level
so your saying that white needs to be @ 3005 ? I see it's has compression , reads normal .

(https://image.ibb.co/nuoTr9/Uncorrected-Whit-Level-00003-small.png) (https://imgbb.com/)
I pushed the hi-lights a little too much , got a little pinkish , WB corrects it
here a frame  Uncorrected_Whit_Level_00003.tif]


(https://bitbucket.org/reddeercity/magic-lantern_10-12bit/downloads/Uncorrected%20Whit%20Level_00003.tif)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 13, 2018, 06:16:46 PM
@theBilalFakhouri

You always try to make my life "easyer" ;)

The latest version has fix for this. Link (https://github.com/ilia3101/MLV-App/commit/93346c8d7bcef71fbfeb1007eba3ebc04e1b3508).

(https://thumb.ibb.co/gb63b9/Uncorrected-Whit-Level-frame-1.png) (https://ibb.co/gb63b9)


Notice how good it looks in comparison to previous posted picture :P
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 13, 2018, 07:28:14 PM
Good work bouncyball.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on October 13, 2018, 07:38:58 PM
@reddeercity
Maybe it's different in MLVApp :P , the pinkish highlight because of uncorrected white level yes.

@bouncyball
Thanks for fixing! I have tested it it's working nicely :D

Anyone have read this suggestion? :
https://www.magiclantern.fm/forum/index.php?topic=20025.msg206744#msg206744

I still have that clip  (https://www.magiclantern.fm/forum/index.php?topic=20025.msg206648#msg206648)for testing :P
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 13, 2018, 07:46:21 PM
@theBilalFakhouri: yes... we created an enhancement issue on our github page, to not forget it. :)

The problem with MLVProducer is, that all image data is cut (->thrown away) after exposure correction was calculated/rendered. So all later functions which lower the contrast (->bring more DR, like contrast slider itself, dualiso, most image profiles...) will bring artifacts and show what you see there. Saw that, when I studied the MLVProducers code, when I implemented our contrast slider. With my very first secret version I had the same problems and searched (and found) another solution ;)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 13, 2018, 09:20:24 PM
I might finish WhiteBalance re implementation today. No fast integer lut stuff, just a basic version for now. Highlights will work.

I'll also make it enable-able and disable-able
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 13, 2018, 10:03:08 PM
@Ilia3101

Yay!!! :D
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 14, 2018, 12:41:04 AM
Quote from: Ilia3101 on October 13, 2018, 09:20:24 PM
I might finish WhiteBalance re implementation today.
Most welcome and deeply appreciated.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on October 14, 2018, 10:25:37 AM
Nice work @Ilia3101!

I saw today enhanced pull request for RawTherapee for Shadows/Highlight module it might maybe very useful for enhancing Shadows and Highlight in MLVApp too, see:

Shadows/Highlights off
(https://user-images.githubusercontent.com/5844619/46429254-3ffd4080-c746-11e8-8116-d9dc48f44e99.png)

Shadows/Highlights old (It have similar looking when using the Highlight/Shadows sliders in MLVApp)
(https://user-images.githubusercontent.com/5844619/46429262-4390c780-c746-11e8-9075-7c39286b33ef.png)

Shadows/Highlights new
(https://user-images.githubusercontent.com/5844619/46429274-4986a880-c746-11e8-9e43-2f840e04de9f.png)

Here the link of pull request:
https://github.com/Beep6581/RawTherapee/pull/4849
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 14, 2018, 11:21:24 AM
@theBilalFakhouri

For my taste:
1st picture still looks more natural and pleasing.
2nd one very HDRish!
3rd a bit HDRish with good shadows but needs more contrast
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on October 14, 2018, 12:30:14 PM
@bouncyball

You are right, the photos aren't mine it's only for showing the new and old shadows and highlights. There is a lot of enhancement it can be used for different cases without the High contrast edges and etc.. . See more examples in the pull request link there is a demo video also.

Here is a example from me using MLVApp:

Normal Dual ISO:
(https://preview.ibb.co/iUFgW9/Original.png) (https://ibb.co/b2iqPU)

Pushed 2.5 Stops:
(https://preview.ibb.co/hJGMW9/Pushed-2-5.png) (https://ibb.co/gmgoB9)

Highlights recovery:
(https://preview.ibb.co/bA7aPU/Restoring-Highlight.png) (https://ibb.co/gZB24U)

Some shadows also:
(https://preview.ibb.co/mSYMyp/Some-Shadows.png) (https://ibb.co/fQu5PU)

Now same things but with Adobe:
(https://preview.ibb.co/kinmW9/Adobe.jpg) (https://ibb.co/m8eN4U)

Don't look at the colors

MLVApp BW
(https://preview.ibb.co/fHW24U/MLVApp-BW.jpg) (https://ibb.co/jtZ0r9)

Adobe BW
(https://preview.ibb.co/cNf6W9/Adobe-BW.png) (https://ibb.co/kxvvPU)

Look at the high contrast in the edges it doesn't look natural (not good) and look at Adobe it's more smoother and natural, Of course I am not asking for Adobe quality,, But it seems now RawTherapee has enhanced these Highlights and Shadows recovery and it looks more closer to Adobe and natural also (Sorry for saying natural too much :P).
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 14, 2018, 01:21:43 PM
For filters like shadows/highlights you need the source image and a blur image. For the blur image you can literally just blur it, which leads to ugly edges, or you can do some really fancy filter that preserves edges. Most of the fancy filters are slow. Here's a good one: http://www.cse.cuhk.edu.hk/~leojia/projects/L0smoothing/ - this would probably give Adobe like results.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 14, 2018, 02:11:58 PM
@theBilalFakhouri: you'll get better results, if you set Exposure to the negative and Lighten to the positive. If that is not enough, push Contrast to the negative too. Edges will be way better! ;) Shadows and Highlights should be used as last resort, then results get better.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 14, 2018, 03:39:41 PM
Quote from: masc on October 14, 2018, 02:11:58 PM
Shadows and Highlights should be used as last resort, then results get better.
Right! In mlv app Dark/Light Strength/Range is so powerful that I barely touch highlights and shadows at all. BTW highlights alter a bit broader range than it should. Shadows are fine.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on October 14, 2018, 04:23:47 PM
Quote from: masc on October 14, 2018, 02:11:58 PM
@theBilalFakhouri: you'll get better results, if you set Exposure to the negative and Lighten to the positive. If that is not enough, push Contrast to the negative too. Edges will be way better! ;) Shadows and Highlights should be used as last resort, then results get better.

Yes now it's seems better:
(https://preview.ibb.co/dm8ryp/Lighten-Contrast-Dark-Strength-s.jpg) (https://ibb.co/eKiPJp)

But also it have a different look than Shadows/Highlights method but I think now it's more *natural* to my eye like in the real world. It is good to have two nice options ;D
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 16, 2018, 05:57:39 PM
Both dock areas are now resizeable - if you can compiled it, especially Windows Users: please test!
(https://user-images.githubusercontent.com/30245296/46939713-55883980-d067-11e8-9984-68f223ccc028.png)
(Screenshot at 2560x1440 at 150% scaling)

And there is now also a matrix icon mode in session list:
(https://user-images.githubusercontent.com/30245296/47029638-50f97900-d16c-11e8-96ee-77bef1cca4c5.png)
Hope you like it ;)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on October 17, 2018, 05:43:08 PM
In Windows it's working nicely! Thanks for that! :D
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 18, 2018, 08:32:12 PM
Question. Could exposure tab go further towards brightness? I set whitelevel to around 6000 on this mlv file and it seems dualiso exposure could go further. Maybe the exposure slider could be expanded when dualiso is set to on?
MLV file:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/short_M18-1960.MLV

Sorry about the crappy clip. Was using nd filter of real cheap quality.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on October 18, 2018, 08:46:51 PM
Is this doable?

Quote from: theBilalFakhouri on October 15, 2018, 08:23:01 PM
...Now 1x3 files is cleaned perfectly even with Dual ISO files. The only small problem we have already knew it is the "height" value in "raw_info" or should I say the offsets. Using mlv_dump -v in 1736x2214 MLV file: (EDIT: of course the resolution was dropped in crop_rec not in mlv_lite, if it was from mlv_lite it will be no offsets)

Block: RAWI
...
    Res:  1736x2214
    raw_info:
...
      height           2244
      width            1808


By changing the 1x3 focus map name from 80000326_1808x3508.fpm to 80000326_1808x2244.fpm now the focus pixels will be cleaned nicely in 1736x2214 files. I have tried it in MLVApp by dropping the focus pixels map in the MLVApp.exe directory.

I think we should a trick for that like using the full focus pixels map (The original one) and makes MLVApp checking the height in raw_info and make a calculation for the offsets depending on MLV files info --> Hello @masc @bouncyball @Ilia3101 is this possible ? :D

Same thing with 1x1 Binning but I think this will affect the "width" value too.

Here are MLV files in 1736x2214 Normal and with Dual ISO: Download (https://drive.google.com/open?id=1oSjehj-ejF3--E3hTMXkhYGw3_5SODwa) (The internet speed is bad, will upload ASAP Edit: Uploaded).
...
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 18, 2018, 09:11:40 PM
Quote from: Danne on October 18, 2018, 08:32:12 PM
Question. Could exposure tab go further towards brightness? I set whitelevel to around 6000 on this mlv file and it seems dualiso exposure could go further. Maybe the exposure slider could be expanded when dualiso is set to on?
No problem in principle. Try it out:
https://www.dropbox.com/s/4mpcad6qd9l3lo9/MainWindow.ui?dl=0
You just need to change the minimum and maximum value of the exposure slider (EV * 100).
The problem is, the precision becomes very bad, especially around 0EV it feels not good... :(

Edit: what is the correct white level? For more than ~4400 AMaZE, LMMSE and IGV do strange things in the light of your lamp...
(https://image.ibb.co/n2xLi0/Bildschirmfoto-2018-10-18-um-21-16-12.png)

@theBilalFakhouri: Bouncyball should be able to answer this question - I have no idea about that correction part... :D
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 18, 2018, 10:02:37 PM
I'll try to find time to test @masc.
I think white level should be around 3000 but I tried getting some extra range. Wishful thinking  :P
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 19, 2018, 09:11:28 AM
Quote from: theBilalFakhouri on October 18, 2018, 08:46:51 PM
I think we should a trick for that like using the full focus pixels map (The original one) and makes MLVApp checking the height in raw_info and make a calculation for the offsets depending on MLV files info --> Hello @masc @bouncyball @Ilia3101 is this possible ? :D
How it works now:
Code checks camera model ID in IDNT block header, from "RAWI.raw_info" struct it gets raw buffer height/width, gets bining/skipping values from RAWC block header and crop/pan values from current VIDF block header. All this information is sufficient to pick the right focus pixel pattern type and generate map on the fly in memory (no .fpm map file needed).

If ".fpm" maps are found in the mlvapp dir then some parts of procedure explained above skipped and after FPM name parsing, the resolution checked against MLV raw buffer resolution (also if FPM has a header it accounted) and appropriate map is loaded.

Now... everything is possible but I'm waiting for @dfort to update his focus pixel generating bash script. After that I'm gonna port it to mlvapp/mlv_dump.

regards
bb
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on October 19, 2018, 01:56:42 PM
@bouncyball

Wow great thing here I didn't know some of these stuff.Thanks for explaining!
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 19, 2018, 03:58:25 PM
Quote from: theBilalFakhouri on October 19, 2018, 01:56:42 PM
Wow great thing here I didn't know some of these stuff.Thanks for explaining!
U R Welcome :)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 19, 2018, 10:20:40 PM
I was using the new build with the gallery view on the left.
It's a great feature to have.  Now I was thinking about space and it seems that for my setup and monitor I would love to have the gallery view on the bottom of the app.
Would this be something possible without too much work?

As another option, not removing the old one

Thanks


(https://thumb.ibb.co/bJbuT0/galleryleft.png) (https://ibb.co/bJbuT0)


(https://thumb.ibb.co/ki5cgL/gallerydownview.jpg) (https://ibb.co/ki5cgL)


It's a bit like in Lightroom


(https://thumb.ibb.co/mpv4T0/adobe-lightroom-cc-classic-cc-announcement-release.jpg) (https://ibb.co/mpv4T0)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 19, 2018, 10:44:02 PM
Not exactly the same, but I could offer this with only a few lines of code:
(https://image.ibb.co/i60Do0/Bildschirmfoto-2018-10-19-um-22-42-49.png)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 19, 2018, 10:49:49 PM
Wow super!  that would be really useful!

:)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: whitelight on October 19, 2018, 10:52:45 PM
Quote from: masc on October 19, 2018, 10:44:02 PM
Not exactly the same, but I could offer this with only a few lines of code:
(https://image.ibb.co/i60Do0/Bildschirmfoto-2018-10-19-um-22-42-49.png)

Looks really great to me. Thanks
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 19, 2018, 11:13:03 PM
Yay... got also this:
(https://image.ibb.co/jBU4d0/Bildschirmfoto-2018-10-19-um-23-11-38.png)
So we see more sliders from edit area.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 19, 2018, 11:15:14 PM
Even better!
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 19, 2018, 11:33:56 PM
You can check out and compile... it is on github repo.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 19, 2018, 11:41:04 PM

(https://thumb.ibb.co/fsPqkf/Screen-Shot-2018-10-19-at-23-37-56.png) (https://ibb.co/fsPqkf)


Thanks its perfect!

Just one thing it does not remember my last used mode when I restart the app. Thats just details, very happy with this !

one thing I just noticed the scrolling is very slow when I scroll inside the session view on the bottom ( with the mouse scroll wheel )
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 20, 2018, 08:55:32 AM
Cool stuff. Will test later.
+1 for Lars suggestion remembering last set up, paths to mlv files etc after closin Mlv app.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 20, 2018, 09:52:06 AM
Quote from: Lars Steenhoff on October 19, 2018, 11:41:04 PM
Just one thing it does not remember my last used mode when I restart the app. Thats just details, very happy with this !
Quote from: Danne on October 20, 2018, 08:55:32 AM
+1 for Lars suggestion remembering last set up, paths to mlv files etc after closin Mlv app.
?! All that is implemented and is working for me. Could you explain what you do? Note: when opening last official MLVApp version saving the positions and opening then latest github revision it won't work, because latest official version does not know changeable docks. Just try that with the latest compiled version only. Last mlv paths are saved since a year maybe.

Quote from: Lars Steenhoff on October 19, 2018, 11:41:04 PM
one thing I just noticed the scrolling is very slow when I scroll inside the session view on the bottom ( with the mouse scroll wheel )
Yes... I noticed this too. But it happens not always. No idea what this is... will search when I have some time.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 20, 2018, 10:26:00 AM
Yes the window position is restored, at restart I just noticed it.

But would it not be nice if the session with all the mlv's is auto saved on exit and restored on exit too?
So you can basically exit the app and come back to where you were.

Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 20, 2018, 11:57:10 AM
Ah okay, so you don't mean the preview mode (that was what I understood), you mean the session itself. Hm... concept is, that the user saves and opens the session. This means 1st time 2 clicks + typing a filename, 2nd...nth time 1 click and 3 clicks on opening. I am really no fan of Apples and Adobes autosave, because nobody really knows what happens, and cleaning the mess is a lot of research and work.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 20, 2018, 11:58:45 AM
I was more thinking about Lightroom style.

Where you define the session once and after it autoloads and autosaves to this file.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 20, 2018, 12:00:36 PM
Quote from: Lars Steenhoff on October 20, 2018, 11:58:45 AM
I was more thinking about Lightroom style.

Where you define the session once and after it autoloads and autosaves to this file.
Yes, lightroom style. When I think of it, the only thing missing in this regard is autosaving MLV paths on reopening.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 20, 2018, 01:13:13 PM
Quote from: Danne on October 20, 2018, 12:00:36 PM
Yes, lightroom style. When I think of it, the only thing missing in this regard is autosaving MLV paths on reopening.
Sry, don't understand. If you click on open session, you are automatically leaded to the last path where you opened a MLV file. But this is not what you mean?!
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 20, 2018, 01:25:14 PM
Don't know for Danne, but for me its like this:

I would like to have an option check box in the menu:


Currently when I load a session the default path is not where I saved the session, which is where I expect it to be.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 20, 2018, 01:48:47 PM
Ok, clearance. Open up also mlv files which were present in mlv app when closing the app. When reopening all mlv files will reappear automatically as before closing. Right now I have to open up and reload the mlv files.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 20, 2018, 04:36:31 PM
Something not related:

It will be useful for me to have an option like this:
Show in Finder

That opens a finder window with the current mlv selected there.

(https://raw.githubusercontent.com/larssteenhoff/MLV-App/82c0229b7a7c8ac3b97f301517c9c80f80567d84/platform/qt/IMG/show.png)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: dfort on October 20, 2018, 10:47:52 PM
Quote from: bouncyball on October 19, 2018, 09:11:28 AM
...I'm waiting for @dfort to update his focus pixel generating bash script...

Right, I've been thinking about how to cover all of these new crop_rec resolutions. Maybe we only need to know the width of the full raw buffer along with the sampling (1x1, 1x3, 3x3, 5x3) and allow for the maximum possible height at that sampling?

I also allowed for some crop/pan metadata slippage that was happening on a few of the experimental builds but it looks like that might have been resolved so some of the maps can probably be simplified.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 20, 2018, 10:52:38 PM
I now added:
- different "last filename" for session, darkframe and imported mlv (until now all was saved in one variable)
-> when opening(/saving) one of them, you are leaded to the last directory (now different for MLV/Session/Darkframe)
-> exporting will lead always to the folder where the MLV is
- remember dialog on app close event
- reveal in finder / explorer (works just for one file and only on Win/OSX. I don't know how to do in Linux and how to do with more than one file).
-> someone should test that on Windows. I only have OSX here...
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 20, 2018, 11:15:57 PM
Thanks for implementing these!

I tested it and here his my feedback:

Review in finder works perfect

(http://www.larssteenhoff.com/forum_pics/sv.png)

In the dialog I would perhaps add here one more button, Save and Quit
And change Quit to Quit without saving

The red close button does not work on the popup. ( it should also cancel the dialog )

I would still find it easier if there was an auto save session on quit. 

And the auto loading of the last session on opening up the app.

Nice progress!
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 20, 2018, 11:29:14 PM
Now that we have "Reveal in finder" working I'm wondering if its possible to also implement Play in MlRawViewer ( Open in External app )

the command would be the same as double clicking the file in the finder when you have MlRawViewer.app associated as the default .mlv app.

My use case is to use MlRawViewer.app launched directly from MLVApp for quick playback with audio to see the shots and then to fine-tune and export MLV app.

It could be triggered by a hotkey and with right click on the file and selecting Play in MlRawViewer
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 21, 2018, 12:25:33 AM
(http://larssteenhoff.com/forum_pics/close.png)

Ok I managed to make the menu, I just don't know how to save from the button yet. ( just trying to get a grip of how the app works )
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 21, 2018, 01:38:59 AM
I ok learned how to save the session from a button  :)
And I made it simpler with only two choices. mostly because I did not now how to code the third choice.

(http://www.larssteenhoff.com/forum_pics/saveand.png)

//App shall close -> hammer method, we shot on the main class... for making the app close and killing everything in background
void MainWindow::closeEvent(QCloseEvent *event)
{
    ui->actionPlay->setChecked( false );
    on_actionPlay_triggered( false );

    if( !QMessageBox::warning( this, APPNAME, tr( "Do you really like to quit MLVApp? Don't forget to save the session!" ),
                                tr( "Save and quit" ), tr( "Quit without saving" ) ) )
    {
                if( m_sessionFileName.count() == 0 ) on_actionSaveAsSession_triggered();
            else saveSession( m_sessionFileName );
       
        qApp->quit();
        return;
    }

    qApp->quit();
    event->accept();
}
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 21, 2018, 12:07:51 PM
@Lars Steenhoff: I am not sure if it is that easy. Maybe that will be it for 10% of the cases... the MainWindow class is very (if not much to) complex, and little changings like that mostly double complexity in many cases. It may work when session was saved before. But what if not? What if a session was saved, user created a new one and quits? What if "Save and quit", but abort save file dialog? etc. ...

The red button - ups... forgot that one, will have look later. Edit: Funny... pressing red button: nothing happens for me on OSX 10.9.5 :-D

Open an external app is much easier than "remote control" Finder or Explorer. If you just need this, that is easily added. I only have to think about how to select the application. I think we need a new dialog for that somehow.

Autosave is a very dangerous thing. If we only save on close event, nothing is saved if app crashes. If we save after each mouse click, I say "good night". :-D
Until now I hated every application what does autosaving (LR, FCPX,... ), because it never worked as I expected and only makes work even harder for both - developer and user. That is why I more like manually open and save.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on October 21, 2018, 12:54:45 PM
Quote from: Lars Steenhoff on October 20, 2018, 11:29:14 PM
.. Play in MlRawViewer ( Open in External app )

+1 also if it can be done for FastCinemaDNG Processor. Maybe make a choice to select what the external player we want to view MLV files something like that.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 21, 2018, 01:30:22 PM
@masc

Yes after thinking about it auto save is not really needed.

About the save button I made in the dialog, it checks if the session was saved before and if it was it just saves over it. If it was not saved before it triggers the "save as" function

And yes a cancel button would be good to have also in the dialog, I just did not know how to code that.

Same for auto load last session, I dont know how to code that yet.

As for external app, yes a Dialog window where you set the external app path is needed for that.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 21, 2018, 07:19:48 PM
Now added also a saving on exit function to the messagebox on close event.
"Open with external application" is working for OSX, and on Windows maybe (but is still hidden because I am not sure - untested stuff).

Instead of an session autoload I am thinking of a "Recent session" filemenu under "File"... would that help?
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 21, 2018, 07:27:40 PM
Super to see again the nice work! Recent would help a bit,  but I can just click on the open icon and it also show me the recent session now so thats kind of redundant.

Still I would prefer auto load for myself, but I know your not a fan of it   8)


I just tested the "open in external app" function and for some reason it only works with lossless compressed mlv's but not with uncompressed mlv's.  No idea why this is happening, because when I click the same uncompressed file in the finder it opens in mlv.

I just tested the "open in external app" function and for some reason it only works with mlv's that are on my local SDD and it does not open files on my external HDD

And it would be great of the open in external app can have its own keyboard shortcut. so I can just press a button and it will open n the external app.

Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 21, 2018, 07:56:39 PM
Quote from: Lars Steenhoff on October 21, 2018, 07:27:40 PM
Super to see again the nice work! Recent would help a bit,  but I can just click on the open icon and it also show me the recent session now so thats kind of redundant.
...yes, depending on where you save them. I could be like that:
(https://image.ibb.co/bW0SJ0/Bildschirmfoto.png)

Quote from: Lars Steenhoff on October 21, 2018, 07:27:40 PM
I just tested the "open in external app" function and for some reason it only works with mlv's that are on my local SDD and it does not open files on my external HDD

And it would be great of the open in external app can have its own keyboard shortcut. so I can just press a button and it will open n the external app.
Hm... is there some space in the path name? I did not test if this is allowed with current implementation and could be the problem. With the shortcut I'll see what I can do...

EDIT: I added a shortcut to the newest session under "Recent sessions" (CMD+R) and with this shortcut it opens your last session. That helps?
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 21, 2018, 08:59:19 PM
Yes the external path has a space in it. that explains it.

Recent sessions list is also nice looking!
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 21, 2018, 09:03:23 PM
By the way in that same menu there is the "Export Actual Frame" option.  This one creates a .png
Can you make one more option "Export Actual frame to .DNG"  ?

Many times I just want to open the current frame in photoshop as a .dng, and right now its a long process. 
I need to set the input and output range and then export to DNG sequence with only one frame.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 21, 2018, 09:35:23 PM
Here are the new shortcuts:
(https://image.ibb.co/fxiybL/Bildschirmfoto-2018-10-21-um-21-27-23.png)
Type CMD+R and you have opened your last session.

Single DNG export is surely possible. But this function was thought different: first we had just png export via Qt - extremely easy, but just 8bit. Then we got ffmpeg and cDNG - very hard to implement (in comparison) but very good quality. It was nearly no code overhead to leave the old easy function. Adding cDNG for single frames will let the code explode again... :-D
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 21, 2018, 10:12:27 PM
Can't you use the same code as normal cinema dng export?

Just with a time range of only the current frame?
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 21, 2018, 10:30:35 PM
Just tested the latest version, have to say it's really nice!

I love that I can quickly have a realtime preview in MLrawviewer, with a quick shortcut, works really well.
also really happy that I can locate my clips now by reveal in finder.

CMD + R to load the last session is fast, and getting a warning when quitting with the option to save is so useful,
Before I many times forgot to save and lost my whole session.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 21, 2018, 10:40:09 PM
+1 to above written.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on October 21, 2018, 11:11:52 PM
I just wanted to chime in to say I'm also very happy with how mlvapp is developing!

I had just finished the final grade of a video I filmed a few months ago in resolve, and I still felt it could be better, so I tried again in mlvapp, and I'm totally happy with the results.

If you can trust your eyes while grading, you can do almost anything with mlvapp.  There are definitely "better" tools out there but that doesn't mean you can't get just as good results from this great program!

Keep it going!

Thanks for all your efforts!
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 22, 2018, 09:28:05 AM
Quote from: masc on October 21, 2018, 12:07:51 PM
Until now I hated every application what does autosaving (LR, FCPX,... ), because it never worked as I expected and only makes work even harder for both - developer and user. That is why I more like manually open and save.
+1 for sure! :D
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on October 22, 2018, 12:40:34 PM
Quote from: Lars Steenhoff on October 21, 2018, 10:30:35 PM
I love that I can quickly have a realtime preview in MLrawviewer, with a quick shortcut, works really well.

Does it support the new crop_rec modules from experimental page?
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 22, 2018, 12:43:39 PM
@Dmytro_ua

https://bitbucket.org/hwdbk/mlrawviewer/downloads/

This one does
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 22, 2018, 12:52:11 PM
Quote from: Lars Steenhoff on October 22, 2018, 12:43:39 PM
@Dmytro_ua

https://bitbucket.org/hwdbk/mlrawviewer/downloads/

This one does
This one does not run at all for me - crash on startup, on all my Macs.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 22, 2018, 12:57:22 PM
Quote from: Lars Steenhoff on October 21, 2018, 10:12:27 PM
Can't you use the same code as normal cinema dng export?

Just with a time range of only the current frame?
In part yes... but there will be some hundreds of additional lines anyway, if we do it a nice way. If we go this step, we have already now to think about the guy who wishes single BMP export tomorrow... if you know what I mean. I think it would end in a 2nd export chain with 2 or 3 different channels, extra dialogs, setting-registry (invisible to user) and so on...
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 22, 2018, 12:57:58 PM
Quote from: 70MM13 on October 21, 2018, 11:11:52 PM
I had just finished the final grade of a video I filmed a few months ago in resolve, and I still felt it could be better, so I tried again in mlvapp, and I'm totally happy with the results.

If you can trust your eyes while grading, you can do almost anything with mlvapp.  There are definitely "better" tools out there but that doesn't mean you can't get just as good results from this great program!
:D
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 22, 2018, 01:02:37 PM
I don't see how BMB is different enough from PNG.  ( both are debayered )

DNG on the other hand is the image raw file just in a container that photoshop understands. I'm using photoshop to test out grades with the new profiles option in camera raw.

yea I can understand  your way of thinking about how to inplement it properly.
It would nice to have the option to set the output format for still image.

How about if export still image takes the same setting as the video export setting?
So for example if the video setting is set to DNG it makes the dng,
but if its set to proress or any other compressed format is makes a PNG.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 22, 2018, 01:18:14 PM
No just ignore what i said, the proper way is the best way  8)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on October 22, 2018, 03:22:47 PM
Quote from: Lars Steenhoff on October 22, 2018, 12:43:39 PM
https://bitbucket.org/hwdbk/mlrawviewer/downloads/

This one does

I'm on a PC. Still hope for mlrawviewer reincarnation
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 23, 2018, 12:39:52 PM
I have one enhancement proposal.

Now that we will have export current frame to DNG.  ( I compiled the latest from git, great work by the way )
It takes a few steps to get a current frame DNG to photoshop.

1. click on export current frame ( or use shortcut )
2. click on the compression type
3. click on where to save the file ( currently does not remember the last path but saves it on the current mlv location )
4. go to the finder to that location
5 double click to open in photoshop


How about if I could use a shortcut and it opens the current frame in the external application.  ( same kind of functionality as open mlv in external app )
I could for example press CMD + E and it would open the current frame directly in the external app. ( in my case photoshop )

So the end result would be only one step

1 press shortcut key and it opens in the external app.   one alternate method could be right click on the image editor window and have an option there open in external app.

With these enhancement quality of life in the app would go up as less clicking leads to a smooth workflow.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 23, 2018, 12:46:55 PM
And how comes the picture data into the external app, without saving?
2. setting is saved, so should mostly not be neccessairy
3. is still in work...
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 23, 2018, 01:03:51 PM
It would save it first yes true, and then open it in external app. ( save location would be in a set path by the user )
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 23, 2018, 01:08:56 PM
1. click on export current frame ( or use shortcut )
2. click on the compression type
3. type saving location
4. select application to open wtih
5. press "export&open" button
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 23, 2018, 01:18:49 PM
 8). yes the first time, after one time it would know where to save the file in what type of compression and what program to open with  :)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on October 23, 2018, 03:12:02 PM
I also have an enhancement proposal. 

An "UNDO" (Ctrl-Z) action to undo the last setting on a clip and also previous settings with several clicks would be very welcome.  Same also with "REDO" to get them back.  Another button (a circle with an arrow) to restore the initial state of the clip before any settings were applied, would be helpful too.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 23, 2018, 03:51:45 PM
@IDA_ML.

Do you know that reset receipt is there in the menu, this one does your last request, just without a button.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 23, 2018, 03:53:46 PM
Unfortunately Undo & Redo of each action you do needs a completely different software architecture of the whole parameter holding part. I don't want to say it is impossible... but it would mean implementing the whole thing new from scratch.
For initial state just use Ctrl+Alt+R.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on October 23, 2018, 06:13:06 PM
Ctrl+Alt+R works nicely.  I was not aware of that.  Thanks a lot, Masc and Lars.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 23, 2018, 07:41:19 PM
Quote from: Lars Steenhoff on October 23, 2018, 01:18:49 PM
8). yes the first time, after one time it would know where to save the file in what type of compression and what program to open with  :)
Definitely, the laziness and desire of a human has no end :P
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 23, 2018, 07:48:10 PM
I'm using for myself a monochrome icon set,
If anyone want to try it out let me know how it works for you.
It works best with a black osx menu bar.

Dark mode OSX mlv app:
http:/larssteenhoff.com/mlvapp/MLVApp.zip (http://http:/larssteenhoff.com/mlvapp/MLVApp.zip)

Fork
https://github.com/larssteenhoff/MLV-App
Icons come from https://github.com/FortAwesome/Font-Awesome

(http://www.larssteenhoff.com/forum_pics/monochome_dark_mode_mlvapp.png)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 23, 2018, 08:28:14 PM
What hawk is it?
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 23, 2018, 08:29:24 PM
A fake one from China

Sharp shinned hawk
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 23, 2018, 08:45:56 PM
Great capture.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: djcagle on October 24, 2018, 02:09:05 PM
Can someone upload the most updated installer zip to Google Drive or some file sharing service. The official site for MLV App's download rate is super slow.

Much appreciated!
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 24, 2018, 02:27:55 PM
New script included called PROXY_CLEANER.command(mac users only)
The script is dedicated to those MOV files which can be recorded simultaneously while recording MLV. So called proxy files. The script will clean the beginning of each file since these proxy files will contain a short start with black frames. The script will only apply cleaning of corresponding MOV if it finds a matching MLV and only if it was selected from within MLV app. It will also skip processing if the file itself doesn´t contain any starting black frames. It will execute after MLV processing to dng files has ended. When all is done the original MOV files will be placed in A_ORIGINALS folder while the new files will be stashed next to your MLV files.
This workflow doesn´t pay attention to the ending of the proxy file. Seems to work anyway so if this is a problem let me know. The solution in that case is to set end point according to amount of dng files processed from the corresponding MLV.
The script will run in parallell(max 4 processes) to speed up processing.

Script base here:
https://github.com/ilia3101/MLV-App/commit/42f67d6efcb843d189dacc5ee46539734b80a4db#diff-4fe43f1dfed9a11f5730174f514ce3f7

Find your script here
(https://i.postimg.cc/FFVHK6kx/Screen-Shot-2018-10-24-at-13-24-32-png-500px.png)

Include MLV and MOV files in the same folder
(https://i.postimg.cc/ZKYKvLrz/Screen-Shot-2018-10-24-at-13-25-07-png-500px.png)

Indication of script running.
(https://i.postimg.cc/0Qp2DWWP/Screen-Shot-2018-10-24-at-13-25-33-png-500px-tif-300px.png)

End result
(https://i.postimg.cc/hvsD3JRY/Screen-Shot-2018-10-24-at-13-26-23-png-500px.png)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 24, 2018, 02:33:47 PM
Wow thats super nice to have!
I was just thinking about it a few days ago, I think at some point it would be good to have an indicator inside mlvapp that shows if a .mlv has a corresponding .mov file in the directory.

A bit like how lightroom shows a raw+jpg as a single file. Or just a little text under the thumbnail indicating the proxy availability.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 24, 2018, 03:27:11 PM
Very nice @Danne! :)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 24, 2018, 04:25:41 PM
Very exciting things going on here. I like the new interface changes.

Been taking a break from code stuff. Trying to be a user.

Quote from: 70MM13 on October 21, 2018, 11:11:52 PM
I had just finished the final grade of a video I filmed a few months ago in resolve, and I still felt it could be better, so I tried again in mlvapp, and I'm totally happy with the results.

If you can trust your eyes while grading, you can do almost anything with mlvapp.  There are definitely "better" tools out there but that doesn't mean you can't get just as good results from this great program!
Exactly what I've been thinking as I've been using MLV App intensely in the last few days. Very basic, but incredible results if you get it right.

Top Secret tip: use a little bit of the film "FJ" filter to add depth and contrast when the shot is a bit flat in contrast but highly saturated in colour.

Quote from: djcagle on October 24, 2018, 02:09:05 PM
Can someone upload the most updated installer zip to Google Drive or some file sharing service. The official site for MLV App's download rate is super slow.

Much appreciated!

Good idea.
@bouncymasc Maybe we should do 1.2, the fixed stripe correction is pretty major, and new interface things.

@Lars Wow I thought that was a real bird. Very nice.

Also about the icons, I agree that the current ones are a bit old fashioned and inconsistent (struggling to figure out what I mean by inconsistent), however the colour in them is helpful for usability as they're easy to distinguish. I like yours too, but they are a bit big, I think they might look better if they were a bit smaller, leaving more space between them.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 24, 2018, 04:33:26 PM
Okay @ilia... lets start release discussion on github again! ;)

@djcagle: ultra slow for users is ultra fast for developpers. If it is to slow for you, you can compile your personal version at each time you wish.

@Lars: with these icons... the reason why we don't use white icons is, that they are only visible on a darktheme OS. If there is no darktheme, your icons are invisible -> that is not usable.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 24, 2018, 04:40:47 PM
Quote from: masc on October 24, 2018, 04:33:26 PM

@Lars: with these icons... the reason why we don't use white icons is, that they are only visible on a darktheme OS. If there is no darktheme, your icons are invisible -> that is not usable.

Yes I know thats why I was saying its what I use personally, I like them because they fit my os style.
But for me it's not important to change any of the icons in the main app, I just wanted to share so perhaps some others who use osx dark mode can benefit from them.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 24, 2018, 04:42:09 PM
if it's not hard, maybe we would make it switchable? (the icon theme)

Also release discussion lets start that
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on October 24, 2018, 07:03:13 PM
Quote from: Ilia3101 on October 24, 2018, 04:25:41 PM
@bouncymasc Maybe we should do 1.2, the fixed stripe correction is pretty major, and new interface things.




Wait I've lost something I think :) what happened with stripe correction?
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 12georgiadis on October 24, 2018, 07:30:15 PM
@Danne, it's a super cool integration ! I'm sure a lot of people would use more the Proxy workflow with MLV app !
I'll test it When I return form Mexico. One suggestion : we could also have the option to clean proxy files without exporting DNG in MLV app. Then, after the editing, we use the import XML function to get the edited MLV and export in DNG/APR444 log-c for grading in Resolve

What do you think ?
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 24, 2018, 08:13:16 PM
I think Switch is a good alternative here. Why. Simply because these scripts are all based upon MLV files and it all takes place after all other processes are done in Mlv App. However if you want a workaround you could find this place in the script:
#split into 4 chunks
   split -l $(( $( wc -l < /tmp/mlvapp_path/file_names.txt ) / 4 + 1 )) /tmp/mlvapp_path/file_names.txt /tmp/PROXYFILES
   rm /tmp/PROXYFILES


And then you put in this above those lines:
cd "$(cat /tmp/mlvapp_path/output_folder.txt)"
ls *.MLV > /tmp/mlvapp_path/file_names.txt


The new part should look like this:
cd "$(cat /tmp/mlvapp_path/output_folder.txt)"
ls *.MLV > /tmp/mlvapp_path/file_names.txt

#split into 4 chunks
   split -l $(( $( wc -l < /tmp/mlvapp_path/file_names.txt ) / 4 + 1 )) /tmp/mlvapp_path/file_names.txt /tmp/PROXYFILES
   rm /tmp/PROXYFILES


Now you can select only one MLV from within Mlv App and by simply exporting one dng(or more for that matter) it will activate the script then go through all MOV and MLV files in that folder regardless if you processed the other MLV files or not.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 24, 2018, 09:31:28 PM
Quote from: togg on October 24, 2018, 07:03:13 PM
Wait I've lost something I think :) what happened with stripe correction?

It was very broken before, if the footage was not 14 bit and had intense stripes it would create a grid like pattern - all discussed here: https://github.com/ilia3101/MLV-App/issues/112
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 24, 2018, 10:57:41 PM
1.2 is gonna be an incredible release
(https://image.ibb.co/jHcHAq/Screenshot-from-2018-10-24-21-51-32.png)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 12georgiadis on October 24, 2018, 11:40:23 PM
Quote from: Danne on October 24, 2018, 08:13:16 PM
I think Switch is a good alternative here. Why. Simply because these scripts are all based upon MLV files and it all takes place after all other processes are done in Mlv App. However if you want a workaround you could find this place in the script:
#split into 4 chunks
   split -l $(( $( wc -l < /tmp/mlvapp_path/file_names.txt ) / 4 + 1 )) /tmp/mlvapp_path/file_names.txt /tmp/PROXYFILES
   rm /tmp/PROXYFILES


And then you put in this above those lines:
cd "$(cat /tmp/mlvapp_path/output_folder.txt)"
ls *.MLV > /tmp/mlvapp_path/file_names.txt


The new part should look like this:
cd "$(cat /tmp/mlvapp_path/output_folder.txt)"
ls *.MLV > /tmp/mlvapp_path/file_names.txt

#split into 4 chunks
   split -l $(( $( wc -l < /tmp/mlvapp_path/file_names.txt ) / 4 + 1 )) /tmp/mlvapp_path/file_names.txt /tmp/PROXYFILES
   rm /tmp/PROXYFILES


Now you can select only one MLV from within Mlv App and by simply exporting one dng(or more for that matter) it will activate the script then go through all MOV and MLV files in that folder regardless if you processed the other MLV files or not.
Superb Danne ! I'll try the 1 MLV selection method
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on October 25, 2018, 03:15:25 AM
One thing that would be very helpful for me (apart from receipt slots!!!) is scale control for the video scopes.  It would be great to be able to crank it way up to see true cutoff of highlights and shadows when necessary.

At least, I think so ;)
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on October 25, 2018, 09:14:21 AM
And please don't forget the focus pixel maps!
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 25, 2018, 12:14:36 PM
Quote from: 70MM13 on October 25, 2018, 03:15:25 AM
One thing that would be very helpful for me (apart from receipt slots!!!) is scale control for the video scopes.  It would be great to be able to crank it way up to see true cutoff of highlights and shadows when necessary.
Would be nice... but: what you see is 1:1 from the calculation algorithm. That means: there is not more information. Making it larger would make it just  unsharp. Or we interpolate (histogram) between the points, or we adapt the scanning lines (waveform) what drops framerate significantly.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on October 25, 2018, 01:22:53 PM
Hello @masc

Can you add rotation option in Transformation tab it would be helpful when shooting in portrait mode "vertical mode" here an example footage: Download  (https://drive.google.com/open?id=11-rGIdLOkmLBidHa352PMODiqOShQjXy) .
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 25, 2018, 08:23:50 PM
Quote from: theBilalFakhouri on October 25, 2018, 01:22:53 PM
Can you add rotation option in Transformation tab it would be helpful when shooting in portrait mode "vertical mode"
Puh... that's also a feature, which needs a big part of the app to be rewritten. Mirroring would be easy, 180° too, but 180° we have already. Problem is, that the viewer area must be identical to MLVs resolution in our implementation. This is why e.g. cropping is a problem too. With stretching we did a trick, but already this brought many problems nobody sees (hopefully), at least if you export via FFMPEG or cDNG.
In any NLE it is very easy to rotate... that is no option? And you really use portrait mode for filming?
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on October 25, 2018, 10:13:51 PM
Usually I don't use portrait mode only today I have used it, but maybe in future also. Not a big thing to me but it good to have something like that for preview. Thanks for helping!
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Kharak on October 26, 2018, 01:22:16 PM
Downloaded 1.1

Wondering about the Zoom Fit mode. After Amaze Cached is idling I get 16-17 fps, if I press F to zoom in, I get 20-21 fps but if I zoom out to fill the screen exactly as much as Zoom Fit mode does, it still stays at 20-21 fps, but as soon as I press F again it drops to 16-17 fps even though the size of the screen is exactly the same. Is there some kind of quality difference between Fullscreen and Zoomed in ?
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 26, 2018, 01:26:37 PM
One is 100% pixels and the other is interpolated from this 100% to a higher magnification, My guess this extra interpolation step takes up processor cycles.
( and when you zoom the window to match you don't know if its a 100% pixel match even when it looks close )

I would love to see an GPU accelerated playback at some point, I did see there is an open CL branch but I did not try that one yet.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 26, 2018, 01:26:43 PM
Quote from: Kharak on October 26, 2018, 01:22:16 PM
Wondering about the Zoom Fit mode. After Amaze Cached is idling I get 16-17 fps, if I press F to zoom in, I get 20-21 fps but if I zoom out to fill the screen exactly as much as Zoom Fit mode does, it still stays at 20-21 fps, but as soon as I press F again it drops to 16-17 fps even though the size of the screen is exactly the same. Is there some kind of quality difference between Fullscreen and Zoomed in ?
Yes, exactly, it is. Fit & Zoom mode use different scaling algorithms from Qt. But what OS are you using? For me there is not really a difference... maybe 0.5fps...
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 26, 2018, 01:28:43 PM
Quote from: Lars Steenhoff on October 26, 2018, 01:26:37 PM
I would love to see an GPU accelerated playback at some point, I did see there is an open CL branch but I did not try that one yet.
It uses just an OpenCL debayer, which is in the and not faster as an CPU based one, because memory copy actions need longer than the calculation using the CPU.
Don't wait for all (or at least any) processing is done on OpenCL. It won't happen. Or someone is willing to do it for us.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 26, 2018, 02:01:36 PM
https://photography.tutsplus.com/tutorials/unlocking-the-power-of-lightroom-color-labels--cms-21876

What about some colours labels, this would make filtering files easy.
For example I could label all the files that I have finished grading green.

and the ability to filter by label
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Kharak on October 26, 2018, 02:13:06 PM
Quote from: masc on October 26, 2018, 01:26:43 PM
Yes, exactly, it is. Fit & Zoom mode use different scaling algorithms from Qt. But what OS are you using? For me there is not really a difference... maybe 0.5fps...

Win 8.1
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 26, 2018, 02:25:03 PM
Quote from: Kharak on October 26, 2018, 02:13:06 PM
Win 8.1
Strange... here on my Win8.1 framerate is the same between these modes.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Kharak on October 26, 2018, 02:39:59 PM
Quote from: masc on October 26, 2018, 02:25:03 PM
Strange... here on my Win8.1 framerate is the same between these modes.

Maybe it comes down to what GPU one has?
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 26, 2018, 03:04:33 PM
Quote from: Kharak on October 26, 2018, 02:39:59 PM
Maybe it comes down to what GPU one has?
MLVApp don't uses the GPU at all.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Kharak on October 26, 2018, 05:23:26 PM
What kind of drive are your MLV's stored on?

There is a huge performance difference in MLV app when the MLV's are played from SSD or CF card, if your MLV's are on a HDD that might be the bottleneck and the reason why you dont see a huge difference.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 26, 2018, 07:50:40 PM
Quote from: Kharak on October 26, 2018, 05:23:26 PM
What kind of drive are your MLV's stored on?

There is a huge performance difference in MLV app when the MLV's are played from SSD or CF card, if your MLV's are on a HDD that might be the bottleneck and the reason why you dont see a huge difference.
The test file was on a SSD.
Title: Re: MLV App - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 26, 2018, 09:19:45 PM
Quote from: Kharak on October 26, 2018, 01:22:16 PM
Downloaded 1.1

Wondering about the Zoom Fit mode. After Amaze Cached is idling I get 16-17 fps, if I press F to zoom in, I get 20-21 fps but if I zoom out to fill the screen exactly as much as Zoom Fit mode does, it still stays at 20-21 fps, but as soon as I press F again it drops to 16-17 fps even though the size of the screen is exactly the same. Is there some kind of quality difference between Fullscreen and Zoomed in ?

Cocoa version had a really fast OpenGL view, I think if I ever implemented playback and frame counter it could have got up to 24fps (with amaze cached). That's the impression I got when I would scrub through the video. If you have a mac with a GPU try out the last release of Cocoa app (https://github.com/ilia3101/MLV-App/releases/tag/v0.22-pre-alpha-a-lot-better-edition) ever (but don't use it for anything, it's almost a year old old and glitchy). The processing is easily fast enough in most cases (if not using highlights shadows clarity etc). No OpenCL needed to be honest. I think we just need to find a fast way to output to the screen.

Again I could be wrong, but that's the impression I have. No measurements were made.

I mentioned OpenGL and GPU, that is only for outputting the image to screen, not processing.

Also download 1.2 now (https://ilia3101.github.io/MLV-App/) ;)
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 27, 2018, 09:31:51 AM
Great to see the energy and the ever growing Mlv App still getting more and more features and refinements.
I have another enhancement suggestion to an existing enhancement:
(https://i.postimg.cc/nzJYShgx/Screen-Shot-2018-10-27-at-08-20-28-png-scaled.png)

I think we could make working with Mlv App projects work even faster  here by adding some stuff to an already great enhancement.

1 - Selecting 'Quit without saving' could still actually save the project that is worked upon silently into let´s say /tmp/ folder on mac for instance. It could be statically called 'autosaved.masxml' or 'last_project.masxml' or similar. The important step here is automation. The user won´t even pay attention to creating or open the actual masxml file. This tmp file will be replaced every time the user quits without saving. This means that when reopening Mlv App open the last autosaved project worked upon as default with mlv paths and changes, the whole works. This is imo the 99% workflow used aroud Mlv App.

2 - When user select 'Quit and save' we manually name the masxml file and in this case the autosaved masxml file will be deleted and the user will now have a clean slate when opening Mlv App and can select the manually saves masxml file.

In regard to these ideas reworking the names could be following:
Cancel button stays the same.
The 'Quit without saving'  will be named 'Save and quit' (last project is autosaved to static /tmp folder with static name)
The 'Save and quit' button would instead be 'Save to masxml' and will let user create the masxml file manually
Like so:
Cancel  Save and quit  Save to masxml
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: vstrglv on October 27, 2018, 12:12:04 PM
Thanks for upgrade!
Installed V1.2
There is a problem with DUAL-ISO MLV file with Danne's magiclantern_crop_rec_4k_mlv_snd_1x3_10bit.zip
V1.2 Dual iso - OFF
(https://farm2.staticflickr.com/1962/45528545212_16cc6861d6_b.jpg)
V1.2 Dual iso - ON
(https://farm2.staticflickr.com/1974/44854201324_be8bb09ef7_b.jpg)
V1.1 Dual iso - OFF
(https://farm2.staticflickr.com/1975/45528545442_933695e52c_b.jpg)
V1.1 Dual iso - ON
(https://farm2.staticflickr.com/1945/45528545612_abfd31a85f_b.jpg)
And is it possible to remove confirmation window on exit?
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 27, 2018, 12:15:01 PM
Yes it possible to disable save question on exit.
Second row from the bottom

(http://www.larssteenhoff.com/mlvapp/saveexit.png)
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: vstrglv on October 27, 2018, 12:27:11 PM
Thanks!
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: vstrglv on October 27, 2018, 01:36:01 PM
But there is no this issue for :
V1.1 DI-OFF
(https://farm2.staticflickr.com/1916/30638981287_c59333a719_b.jpg)
V1.1 DI-ON
(https://farm2.staticflickr.com/1952/43762631930_84c54f9165_b.jpg)
V1.2 DI-OFF
(https://farm2.staticflickr.com/1920/43762631380_6e73dcd961_b.jpg)
V1.2 DI-ON
(https://farm2.staticflickr.com/1932/30638981037_04762e881a_b.jpg)
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: vstrglv on October 27, 2018, 03:10:23 PM
Another test:
(http://farm2.staticflickr.com/1918/44856311094_8d534fd456_b.jpg)
Th same settings. The difference is in brigthness.
(http://farm2.staticflickr.com/1970/45581168351_e1f2decdb8_b.jpg)
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 27, 2018, 06:10:51 PM
Quote from: Lars Steenhoff on October 27, 2018, 12:15:01 PM
Yes it possible to disable save question on exit.
Second row from the bottom

(http://www.larssteenhoff.com/mlvapp/saveexit.png)
Do you have implemented another Fullscreen mode or did you just enable our buggy one and moved it to another menu?
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 27, 2018, 08:03:15 PM
I just compiled without any changes to the menu, are you sure it not there always?
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 27, 2018, 08:44:07 PM
Really?! What OSX do you use? Our Fullscreen function is hidden, but if you enable it, it is under Playback and is just called Fullscreen.
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 27, 2018, 09:19:04 PM
Quote from: masc on October 27, 2018, 08:44:07 PM
Really?! What OSX do you use? Our Fullscreen function is hidden, but if you enable it, it is under Playback and is just called Fullscreen.
I was also amased :)
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 27, 2018, 09:20:28 PM
@vstrglv


Thank you for feedback. Could you upload sample MLV?
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on October 27, 2018, 09:36:45 PM
He put up a sample here:
https://www.magiclantern.fm/forum/index.php?topic=22818.msg207662#msg207662
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on October 29, 2018, 12:20:27 PM
The Enter full screen menu item is the same as pressing on the green button, I'm using high Sierra.
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 29, 2018, 02:31:48 PM
Quote from: Lars Steenhoff on October 29, 2018, 12:20:27 PM
The Enter full screen menu item is the same as pressing on the green button, I'm using high Sierra.
Okay, thanks. Saw that the first time... in El Capitan and lower, Linux and Windows this does not exist.
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: whysodifficult on October 30, 2018, 07:57:27 AM
Thank you so much for responding to my question about the color, that i asked some time ago! I'm sorry i didn't respond earlier. Happy to see you, guys, have moved forward in finding a better way to process the color!

Here what i see:

MlRAWViewer 1.5 as a kind of a rough reference point of real colors (with increased exposure):

(https://thumb.ibb.co/kDoOCf/Screen-Shot-2018-10-29-at-11-17-15-PM.png) (https://ibb.co/kDoOCf)


MLV App WB that Danne provided here earlier after i wrote my post:

Original (warm and dark):
(https://thumb.ibb.co/jVRJCf/Screen-Shot-2018-10-29-at-11-29-27-PM.png) (https://ibb.co/jVRJCf)


Roughly tweaked to match MlRAWViewer 1.5:

(https://thumb.ibb.co/bw6ksf/Screen-Shot-2018-10-29-at-11-16-54-PM.png) (https://ibb.co/bw6ksf)


MLV App 1.1 that i had problem with before i wrote here for a help:

Original:

(https://thumb.ibb.co/enkaQ0/Screen-Shot-2018-10-29-at-11-40-12-PM.png) (https://ibb.co/enkaQ0)


Tweaked (but couldn't match the green):

(https://thumb.ibb.co/eTtek0/Screen-Shot-2018-10-29-at-11-39-18-PM.png) (https://ibb.co/eTtek0)


MLV App 1.2 from fresh post above:

Original (strange colors):
(https://thumb.ibb.co/fEyLQ0/Screen-Shot-2018-10-29-at-10-59-30-PM.png) (https://ibb.co/fEyLQ0)


Tweaked roughly:

(https://thumb.ibb.co/fKNTdL/Screen-Shot-2018-10-29-at-11-48-07-PM.png) (https://ibb.co/fKNTdL)


Result: MLVApp WB and MLV App 1.2 with tweaking match the reference. WB version was more natural to tweak.

It's only greens and blue. Gotta test different colors next time   ??? facepalm....

WB version (i understand it wasn't even a version, just to try) doesn't export cDNGs.

1.2 export cDNG from what i tweaked, but it looks different:
Screenshot from Lightroom (not touched):

(https://thumb.ibb.co/jeEmhf/Screen-Shot-2018-10-30-at-12-16-58-AM.png) (https://ibb.co/jeEmhf)

Shifting Temp and Tint brings it back to life.
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on October 30, 2018, 08:06:14 AM
Quote from: whysodifficult on October 30, 2018, 07:57:27 AM
Result: MLVApp WB and MLV App 1.2 with tweaking match the reference. WB version was more natural to tweak.
Nice to hear that you get the colors now you like. But since many many versions, absolutely nothing was changed regarding white balance processing in the official releases.
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: whysodifficult on October 30, 2018, 08:25:09 AM
Thank you, masc! Indeed. I need also to try reds and yellows.
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on November 13, 2018, 05:31:34 PM
1.3 out :)
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 13, 2018, 05:38:37 PM
Yes, v1.3 is out.
- Added camera matrix calculation for scientific white balance 🎉  (BIG THANK to Ilia! This is great!)
- Added compatibility mode to get still the old white balance results, if necessary
- Dual iso section improvement in edit pane (finally added 'DISO' block header full support)
- More dual iso information in information dialog
- Added session files to drop event
- Added debayer selection per clip instead as global export parameter
- Added auto debayer switch for viewer and playback
- Added a 2nd darktheme

Problems:
- for low white balance temperature (<4000) highlights might get cyan --> uncheck "use camera matrix" to get old processing results
- no caching in this version
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on November 13, 2018, 07:45:04 PM
Yeah everyone who's ever complained about weird colours try it out now.
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ibrahim on November 13, 2018, 10:24:06 PM
Is the conversion of MLV to cDNG in 16-bit in this app, just as it is in MLV Producer and raw2cdng?
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ArcziPL on November 13, 2018, 10:49:33 PM
Quote from: masc on November 13, 2018, 05:38:37 PM
- Added camera matrix calculation for scientific white balance 🎉  (BIG THANK to Ilia! This is great!)
I like it a lot! Thank you guys!
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on November 13, 2018, 10:51:48 PM
Quote from: masc on November 13, 2018, 05:38:37 PM
- Added camera matrix calculation for scientific white balance 🎉  (BIG THANK to Ilia! This is great!)

It is very scientific, we even simulate the entire spectrum of a blackbody emitter to get the white colour for different temperatures.
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 14, 2018, 08:04:45 AM
Quote from: ibrahim on November 13, 2018, 10:24:06 PM
Is the conversion of MLV to cDNG in 16-bit in this app, just as it is in MLV Producer and raw2cdng?
The conversion to cDNG is 16bit and uses the same library like MLV Producer (and maybe raw2cdng - don't know this good enough), what not means the output is identical, because e.g. the RAW Corrections are realized differently. 16bit also does not mean that 10..14bit footage becomes better. Full 16bit is useful for dualiso.
Title: Re: MLV App 1.2 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 14, 2018, 08:22:24 AM
Quote from: ibrahim on November 13, 2018, 10:24:06 PM
Is the conversion of MLV to cDNG in 16-bit in this app, just as it is in MLV Producer and raw2cdng?
Nope. Proggies mentioned above have absolutely nothing in common with mlvapp code.
And right MLV Producer and raw2cdng convert raw data to 16bits. In contrary mlvapp just unpacks any bitdepth raw data to 16bit word buffer and all consequential processing is done on it. During processing, if required in some cases, low bitdepth to 14bit convertion may happen. After processing all raw data is packed back to initial bit depth.

Quote from: masc on November 14, 2018, 08:04:45 AM
The conversion to cDNG is 16bit and uses the same library like MLV Producer (and maybe raw2cdng - don't know this good enough), what not means the output is identical, because e.g. the RAW Corrections are realized differently. 16bit also does not mean that 10..14bit footage becomes better. Full 16bit is useful for dualiso.
The DNGs created by mlvapp are 16bits for dual iso export only. All other raw data exported as DNG always match the input bit depth of the original MLV (10,12,14bits for uncompressed and 14bits for any sort of lossless).

MLV App DNG export is based on MLVFS 'dng.c' lib (credits to its author David Milligan - @dmilligan) and is heavily modified by me, and it is not used in either MLVP or raw2cdng.

regards
bb
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ibrahim on November 14, 2018, 08:24:28 AM
Thanks bouncyball. What settings do both of you recommend to convert MLV to cDNG to preserve the highest quality possible?

The same question goes for dual iso footage.

I ask this because since this app has much more features that the other two apps.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 14, 2018, 08:38:21 AM
@ibrahim

Well actually exporting raw from raw (MLV -> DNG) is absolutely lossless and identical quality.

There are 2 options thought:
1. Just pass through all untouched raw data from MLV to DNG
    It's very fast but has downside. All original flaws of the raw image, e.g vertical stripes, bad pixels, focus pixels (only for affected cameras) etc are there also untouched
    and unprocessed.
2. Do raw processing and get rid of all original raw flaws. It's slower but also maintains highest quality no matter what e.g. exported either as uncompressed or lossless DNGs.

regards
bb
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ibrahim on November 14, 2018, 08:48:11 AM
So if I want to process a dual iso footage in MLVapp what settings do I need to apply if I don't want to color grade in this app but only remove the flaws?
I want to color correct/grade the uncompressed cinemaDNG in AE or davinci instead.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on November 14, 2018, 08:51:02 AM
@Ibrahim
Just hit export dng, lossless, uncompressed, whatever. If the dng files looks ok you don´t need to mess with settings. Defaults are ok. ACR and resolve can chew all bits.

Thanks Ilia3101, masc and bouncyball for great progress and refienments. Dualiso, colors etc. High end stuff.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 14, 2018, 08:55:22 AM
Yes (thanks to @Danne) no special recipe is needed. Turn on dual iso with "AMaZE" and "Alias Map" on and export dngs (sometimes dual iso lossless dngs can not be created and error shows up, so your best bet is uncompressed ones). That's all :)

Note: do not use "CinemaDNG Fast Pass" it will completely bypass dual iso processing.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ibrahim on November 14, 2018, 09:39:03 AM
Quote from: bouncyball on November 14, 2018, 08:55:22 AM
Yes (thanks to @Danne) no special recipe is needed. Turn on dual iso with "AMaZE" and "Alias Map" on and export dngs (sometimes dual iso lossless dngs can not be created and error shows up, so your best bet is uncompressed ones). That's all :)

Note: do not use "CinemaDNG Fast Pass" it will completely bypass dual iso processing.

Thanks man. Great stuff you guys are creating.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on November 14, 2018, 11:02:28 AM
A big big Thanks to all developers of this amazing product!  MLVApp keeps getting better and better.  I just tested the DualISO function in version 1.3 and my first impression is that it handles those files very well.

One thing that should be kept in mind with Dual ISO files is that you may get weird green casts in the darkest areas of your Dual ISO footage after applying the Dual ISO function in the RAW menu.  These can be completely cured by carefully adjusting the White level slider to a lower value.  The same applies also to some pink casts in the highlights.

A few more hints on part of the developers on how to handle DualISO files for preserving highest quality would be very welcome.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 14, 2018, 11:40:46 AM
Quote from: IDA_ML on November 14, 2018, 11:02:28 AM
One thing that should be kept in mind with Dual ISO files is that you may get weird green casts in the darkest areas of your Dual ISO footage after applying the Dual ISO function in the RAW menu.  These can be completely cured by carefully adjusting the White level slider to a lower value.  The same applies also to some pink casts in the highlights.
ore hints on part of the developers on how to handle DualISO files for preserving highest quality would be very welcome.
Exactly :) and this is the one of the main reasons why those sliders are there.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 14, 2018, 11:41:47 AM
Quote from: IDA_ML on November 14, 2018, 11:02:28 AM
One thing that should be kept in mind with Dual ISO files is that you may get weird green casts in the darkest areas of your Dual ISO footage after applying the Dual ISO function in the RAW menu.  These can be completely cured by carefully adjusting the White level slider to a lower value.  The same applies also to some pink casts in the highlights.

A few more hints on part of the developers on how to handle DualISO files for preserving highest quality would be very welcome.
Normally you should only press DualIso On button and that's it. Could you upload a shortend MLV which has this problem? The dualiso algorithm should calculate optimal black and white level, if I understood right (@bb?).
Thanks again for your dualiso files with the clipped highlights. One of these files helped me a lot to implement a new algorithm in v1.3 to reconstruct highlights better in dualiso files (you could also test that again, it is hopefully better than before).
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 14, 2018, 12:08:18 PM
Quote from: masc on November 14, 2018, 11:41:47 AM
...if I understood right (@bb?).
Yeah, but for some rare clips it happens (black level is not optimal).

I think everyone should understand that just point and shoot method is not right thing for obtaining usable dual iso footage with good DR. For some situations dual iso not a friend but enemy.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on November 14, 2018, 04:05:22 PM
Thanks to all! This is becoming a real contender. Would it be possible to implement a LUT intensity slider sometime?  8)
Thanks again.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on November 14, 2018, 06:30:52 PM
Quote from: masc on November 14, 2018, 11:41:47 AM
Could you upload a shortend MLV which has this problem?

Sure Masc, here you go:

https://we.tl/t-cmlIdl2Gxv

This is a 400/3200 Dual ISO file from the 5D3.  When you press the DualISO button, you will see the green cast in the shadows.

By the way, I have noticed a small but very annoying bug on my laptop.  The RAW white level slider is slightly too long and the white dot goes outside the right edge of the workspace which makes it impossible to move it.  It could be due to a Win7x64 scaling issue, (I use 150% desktop magnification to see the icons properly), but I cannot use MLVApp on that laptop for this reason.  On other computer screens everything is fine.  I was wondering if you might be able to make the Edit area on the right of the workspace slightly narrower or move it a bit to the left so that I can see and move the white dot on that slider.  If not, could you make the slider itself a little shorter?  Thank you in advance.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on November 14, 2018, 06:38:55 PM
Quote from: timbytheriver on November 14, 2018, 04:05:22 PM
Would it be possible to implement a LUT intensity slider sometime?  8)
Thanks again.

It would be great if it can b implemented
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 14, 2018, 06:52:12 PM
Quote from: IDA_ML on November 14, 2018, 06:30:52 PM
Sure Masc, here you go:
https://we.tl/t-cmlIdl2Gxv
Thanks!

Quote from: IDA_ML on November 14, 2018, 06:30:52 PM
...(I use 150% desktop magnification to see the icons properly)...
Windows desktop magnification is the problem, which can't be 100% fixed, because it is partially unsupported by Qt and very different and more complicated to other OS. But I implemented a handle in the separator between viewer and edit area: drag it and it should get better. Does it?
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on November 14, 2018, 06:57:21 PM
I'll give it a try when I get back home.  Thanks.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 14, 2018, 07:23:33 PM
Quote from: timbytheriver on November 14, 2018, 04:05:22 PM
Thanks to all! This is becoming a real contender. Would it be possible to implement a LUT intensity slider sometime?  8)
Thanks again.
Quote from: andy kh on November 14, 2018, 06:38:55 PM
It would be great if it can b implemented
Done.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 14, 2018, 07:54:15 PM
This MLV looks OK if white level is set to 5000-ish. No black level adjustment required.

Edit: I bet it is recorded by latest bleeding edge build with support of 1x3 crop and lowered gain registers, with very dark output and incorrect white level.
Edit2: look at the walls in shade and the unrecoverable lightness outside. What is the purpose of using dual iso if highlights are gone and in shadows there are lots of dancing ugly color noise dots?
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: mesebar2 on November 14, 2018, 08:46:12 PM
Are you guys kidding me? You are updating and improving MLV App at an incredible speed!
This new version looks amazing so far, and the quality of the colors is breathtaking!
Thank you so much for your work!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on November 14, 2018, 10:29:58 PM
Quote from: bouncyball on November 14, 2018, 07:54:15 PM
This MLV looks OK if white level is set to 5000-ish. No black level adjustment required.

Edit: I bet it is recorded by latest bleeding edge build with support of 1x3 crop and lowered gain registers, with very dark output and incorrect white level.
Edit2: look at the walls in shade and the unrecoverable lightness outside. What is the purpose of using dual iso if highlights are gone and in shadows there are lots of dancing ugly color noise dots?

Yes, that's right, it was recorded with that latest 1x3 build.  In fact, the processed file does not look all that bad at all.  If you adjust the white level precisely, play with the darks and lights a bit and add some saturation, you will even see some blue sky.  Note that the settings were extreme - 400/3200.  Without Dual ISO, the result would have been much worse in both: the highlights and the shadows.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 15, 2018, 10:04:04 AM
Quote from: IDA_ML on November 14, 2018, 10:29:58 PM
Note that the settings were extreme - 400/3200.  Without Dual ISO, the result would have been much worse in both: the highlights and the shadows.
Well, I doubt it :P, but anyway... have a nice test drive!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on November 15, 2018, 10:17:27 AM
Quote from: masc on November 14, 2018, 07:23:33 PM
Done.

Can you do it a bit quicker next time?  ;D ;) :) :) :) Thanks a million!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on November 15, 2018, 10:38:31 AM
I'm using the compiler script for the first time but I get error:

let´s clean repo first(make clean)!
make: *** No rule to make target `clean'.  Stop.
rm -rf "MLV App" "MLV App".app main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o llrawproc.o pixelproc.o stripes.o patternnoise.o hist.o dualiso.o avf_lib.o filter.o genann.o blur_threaded.o dng.o darkframe.o camera_id.o audio_mlv.o *.o
ls: /usr/local/Cellar/qt/5*: No such file or directory
/Volumes/mlv_app_compiler/Mlv_App_compiler.app/Contents/main.command: line 230: /bin/qmake: No such file or directory

Any ideas? Thanks.


Got it working – sorry! :)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on November 15, 2018, 10:50:47 AM
Could you try this from menu:
(U)   update dependecies(if compiling fails)

I spelled dependencies wrong I see. now. Get back if it works or not.
What os are you on by the way?

Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on November 15, 2018, 10:56:35 AM
Quote from: Danne on November 15, 2018, 10:50:47 AM
Could you try this from menu:
(U)   update dependecies(if compiling fails)

I spelled dependencies wrong I see. now. Get back if it works or not.
What os are you on by the way?

Thanks @Danne that fixed it!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on November 15, 2018, 11:22:06 AM
Did you upgrade to mojave? Had an issue were things had to be reinstalled so that´s the reason for a dedicated update dependencies button.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on November 15, 2018, 12:13:47 PM
Quote from: bouncyball on November 15, 2018, 10:04:04 AM
Well, I doubt it :P, but anyway... have a nice test drive!

Bouncyball,

Here is another shortened MLV of the same scene but shot at a much more relaxed setting - Dual ISO 200/1600:

https://we.tl/t-pO2Io6Ywpy

Quite obviously, at this setting, the camera has a higher dynamic range and the final result looks much better:


(https://thumb.ibb.co/ddEbkL/5-D3-24-IS-1x3-DI-100-1600.png) (https://ibb.co/ddEbkL)


I regret that I did not take another shot at Dual ISO 100/800.  The result would have been even better !!!

After struggling a lot with high-dynamic range (HDR) scenes in the past, I really think that Dual ISO, especially in its bleeding edge 1x3 development, is your best friend for shooting such scenes.  Yes, its usage is a little tricky - it requires a very careful exposure to the right (ETTR) without blowing up the highlights.  But, once you get is right, the results are really gorgeous.  I cannot be convincing enough if you don't test it by yourself.  Please do and you will see how amazing it is.   This is the reason why I am so grateful to all of you for the fact that MLVApp can now handle such complex files so successfully.

Masc,

I tested your handle on my laptop and it works just fine.  I can now access the sliders without problems.  Thanks a lot for this useful hint.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on November 15, 2018, 12:31:18 PM
yea, 100-800 or 100-1600(or 3200) will increase dynamic range. On the HDR theme do try a1ex 48fps setting in crop_rec. (True hd 1920x1080p 48 fps that is). Then you can merge the mlv files in Mlv app in post.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on November 15, 2018, 02:15:13 PM
I have a question to the MLVApp developers.  Very often we shoot Normal and Dual ISO files that get saved on the same card.  To apply recipes and automate batch processing for the Dual ISO files, it is better to separate them manually in a different folder and process them separately.  This takes  a lot of time since all files have to be opened in MLVApp first, the file names of the Dual ISO ones have to be written down manually and then they have to be sorted out in Explorer.  So my question is:

Is it possible to implement automatic recognition of Dual ISO files and apply the Dual ISO function to them on the fly?  This would be very helpful since it will save time.  If these files are also marked with small pop-up message like "DualISO 100/800 12 bit file" somewhere on the working area, that would be helpful too since the user will know that he/she is working on a Dual ISO file.   
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 15, 2018, 02:45:04 PM
Quote from: IDA_ML on November 15, 2018, 02:15:13 PM
I have a question to the MLVApp developers.  Very often we shoot Normal and Dual ISO files that get saved on the same card.  To apply recipes and automate batch processing for the Dual ISO files, it is better to separate them manually in a different folder and process them separately.  This takes  a lot of time since all files have to be opened in MLVApp first, the file names of the Dual ISO ones have to be written down manually and then they have to be sorted out in Explorer.  So my question is:

Is it possible to implement automatic recognition of Dual ISO files and apply the Dual ISO function to them on the fly?  This would be very helpful since it will save time.  If these files are also marked with small pop-up message like "DualISO 100/800 12 bit file" somewhere on the working area, that would be helpful too since the user will know that he/she is working on a Dual ISO file.
I have something in mind, but the idea is not easy to implement...
What you can do already now (at least with newest dual iso development MLVs having the DISO metadata):
- load all your MLVs to MLVApp
- open Information dialog
- select first clip
- if it is dualiso (you see it in ISO cell), press K, else press Delete
- repeat for all clips
- save session
Or do the opposite for the non-dualiso files.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on November 15, 2018, 03:19:48 PM
Quote from: Danne on November 15, 2018, 11:22:06 AM
Did you upgrade to mojave? Had an issue were things had to be reinstalled so that´s the reason for a dedicated update dependencies button.

@Danne Nope! I'm still on trusty old El Capitan 10.11  :P
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on November 15, 2018, 04:20:33 PM
Quote from: masc on November 15, 2018, 02:45:04 PM
What you can do already now (at least with newest dual iso development MLVs having the DISO metadata):
- if it is dualiso (you see it in ISO cell), press K, else press Delete
Having metadata could very well automate dualiso enabling.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 15, 2018, 04:26:18 PM
Quote from: Danne on November 15, 2018, 04:20:33 PM
Having metadata could very well automate dualiso enabling.
It does already... if metadata isn't there, dualiso is disabled. If it is there, you just have to decide between PreView and On.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on November 15, 2018, 04:33:08 PM
I drag a dualiso file into my browser but dualiso is not enable over here:
(https://i.postimg.cc/x8DhJXhJ/Screenshot-2018-11-15-at-16-31-57-png-800px.png)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 15, 2018, 04:36:33 PM
Yes, that is as it should be. It is not disabled. For non DISO files you would have to FORCE dualiso (there comes another button), so it is switched off by standard. This also brings less problems when copying receipts...
Enabling by default slows down the app. You'll see when opening a session where it is enabled.

It looks like that for non dual iso.
(https://image.ibb.co/nmwCAL/Bildschirmfoto-2018-11-15-um-16-37-23.png)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on November 15, 2018, 04:42:07 PM
Understood.
So older(no metadata) dualiso files will still work if force button is used? Forget the question, reread your answer  :P
By the copied and applied a dualiso recipe and it also added dualiso to non dualiso files.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on November 15, 2018, 04:50:57 PM
Here is a test file shot with Danne's 17 fps 12-bit preset and upscaled to the 2560x1440 resolution of my screen:

https://we.tl/t-TsrJoxQEwY

I shot it with the 24/2,8 IS lens for maximum fine detail and t Dual ISO 100/800.  It looks very well on my screen.  Processing and upscaling was done entirely in MLVApp v.1.3

Masc,
Your sorting suggestion suits me just fine.  I will give it a try.  Thanks for the hint.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 15, 2018, 04:53:55 PM
Quote from: IDA_ML on November 15, 2018, 12:13:47 PM
Yes, its usage is a little tricky - it requires a very careful exposure to the right (ETTR) without blowing up the highlights.  But, once you get is right, the results are really gorgeous.
I never said dual iso is not good ;). a1ex did incredible job on it! And I'm using it for still shooting since the invention. But for motion pictures diso processing generates lot of aliasing for my taste, and that is where future 1x3 crop might be handy...

I just said it needs specific approach but did not want to go into deep explanation. I'm glad you got there by yourself! Now this IS a good approach to dual iso shooting. Never go above 1600 recovery ISO it is almost makes no sense.

I took a look at your latest MLV and it looks a LOT more groovy.

regards
bb
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 15, 2018, 05:19:01 PM
Quote from: Danne on November 15, 2018, 04:42:07 PM
So older(no metadata) dualiso files will still work if force button is used?
Yup, it's a new feature in v1.3 :).
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on November 16, 2018, 02:23:21 PM
Is cached playback coming back at some point?
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 16, 2018, 02:35:01 PM
Quote from: Lars Steenhoff on November 16, 2018, 02:23:21 PM
Is cached playback coming back at some point?
Yes, hopefully. But with the new autoswitch (between viewer and player debayer) we need a second memory buffer for such fun... and this is not that easy. See https://github.com/ilia3101/MLV-App/issues/121
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on November 16, 2018, 07:02:09 PM
I hope it'll come back with next version. I don't think it will be too hard. Will get done when I have the energy to do it, probably soon.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ricardopt on November 18, 2018, 02:03:01 AM
Hi everyone.

when doing a batch conversion using version 1.3 all the converted clips have only 8 seconds exactly, also is there a way of aplying a "recipe" to a whole lot of files at the same time? i tried importing a "recipe" with all clips selected but it doesnt work, only works individually.

thanks for all the work done in improving this app.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: reddeercity on November 18, 2018, 04:48:11 AM
@Ilia3101 I'm wondering if you could explain or show me in your code how the image is display in the viewer ?
I'm trying to figure out if it's a "TS" stream (Transport Stream , e.g. mpeg2 etc. ... ) or something else .
The reason is I've being reading/studying the Blackmagic Desktop Video API , It's written in C++
and has samples project in Window, OSX & Linux . Of course I'm mainly interested in Windows side of things.
I'm just looking at the possibility for play back to a blackmagic USB3.0/PCIe device .

Why you may ask ? basically the output from the bm device is calibrated to standard ntsc/pal either bt601, rec709, sRGB (full range) color space
depending on the resolution (SD , HD) and computer monitor have there own color space .

Anyhow , to me that's the only thing missing with this app , scopes get you close but your eye's are the best judge , as long as you can trust the color are correct.
 
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 18, 2018, 10:35:45 AM
Quote from: ricardopt on November 18, 2018, 02:03:01 AM
Hi everyone.

when doing a batch conversion using version 1.3 all the converted clips have only 8 seconds exactly, also is there a way of aplying a "recipe" to a whole lot of files at the same time? i tried importing a "recipe" with all clips selected but it doesnt work, only works individually.

thanks for all the work done in improving this app.
If the exported clips are only 8 seconds, the MLVs will be only 8 seconds or you limited it by "cut out" to 8 seconds. Can't reproduce it otherwise. But maybe you can give some more information of what you do exactly - there are hundreds of possibitles...

Import receipt works for 1 single clip. Copy/Paste works for all selected cilps.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 18, 2018, 10:49:23 AM
Quote from: reddeercity on November 18, 2018, 04:48:11 AM
@Ilia3101 I'm wondering if you could explain or show me in your code how the image is display in the viewer ?
I'm trying to figure out if it's a "TS" stream (Transport Stream , e.g. mpeg2 etc. ... ) or something else .
The reason is I've being reading/studying the Blackmagic Desktop Video API , It's written in C++
and has samples project in Window, OSX & Linux . Of course I'm mainly interested in Windows side of things.
I'm just looking at the possibility for play back to a blackmagic USB3.0/PCIe device .

Why you may ask ? basically the output from the bm device is calibrated to standard ntsc/pal either bt601, rec709, sRGB (full range) color space
depending on the resolution (SD , HD) and computer monitor have there own color space .

Anyhow , to me that's the only thing missing with this app , scopes get you close but your eye's are the best judge , as long as you can trust the color are correct.
I can try to explain. There is no stream. All what happens is implemented and developed by our own - just using some Qt libraries at the very end. I'll try to describe it an easy way. If you like to get more information, let me know.
- In the Qt part, an event tells "it is time to show a new frame"
- in dependency to real time we calculate which frame should be shown
- the frame number is sent to another (render)thread -> App can be controlled by user, rendering is in background
- the render thread starts Ilias functions: from MLV read out... debayering (mostly multithreaded)... processing (multithreaded)
- in the end there is a uint16 buffer holding the wanted picture data
- picture data comes back to Qt via signal/slot (and in parallel this is also the point, when 1st step is done next time)
- picture is leaded to a QGraphicsView scene layer (which should use OpenGL, makes dragging and zooming very fast)
- when exporting, the same picture data is leaded to ffmpeg via pipe, or to AVFoundation library.

Is it possible to send picture data to this blackmagic API and it is shown on the device?
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on November 18, 2018, 11:15:19 PM
Quote from: reddeercity on November 18, 2018, 04:48:11 AM
@Ilia3101 I'm wondering if you could explain or show me in your code how the image is display in the viewer ?
I'm trying to figure out if it's a "TS" stream (Transport Stream , e.g. mpeg2 etc. ... ) or something else .
The reason is I've being reading/studying the Blackmagic Desktop Video API , It's written in C++
and has samples project in Window, OSX & Linux . Of course I'm mainly interested in Windows side of things.
I'm just looking at the possibility for play back to a blackmagic USB3.0/PCIe device .

Why you may ask ? basically the output from the bm device is calibrated to standard ntsc/pal either bt601, rec709, sRGB (full range) color space
depending on the resolution (SD , HD) and computer monitor have there own color space .

Anyhow , to me that's the only thing missing with this app , scopes get you close but your eye's are the best judge , as long as you can trust the color are correct.


The MLV App code outputs the image as a simple array/buffer/bitmap (however you say it, nothing complicated or compressed like a stream), so if the BlackMagic SDK allows you to upload image data directly it might be easy. The current output colour space of MLV App is sRGB, it will hopefully gain some wider gamut ability soon.

Is this blackmagic thing a monitor or what? I am quite confused by your description. Can you not just output from the computer to it like a monitor to run windows and MLV App directly on it? or is it only accessible through an api?
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: reddeercity on November 19, 2018, 05:16:58 AM
Thanks you both @Ilia3101 & @masc , I got a working understanding of your app  .
I kind of thought there was some frame buffer stuff , that what I was looking for .

The Blackmagic device (https://www.bhphotovideo.com/c/product/766050-REG/Blackmagic_Design_BDLKULSASDI_UltraStudio_SDI.html)  (Capture & Preview Play back) is for dedicated preview in Legal Color Space , along with your preview window in the app at the same time .
Mainly used for Color Grading (exported HDMI signal & or SDI to Grading Monitor) & capturing compressed & uncompressed Camera stream data (which I'm not concerned about)
I'm looking for just preview when Grading , As I can only speak for myself I have a Pro Art Asus 1080p 10bit Grading Monitor (99% color accuracy in rec709 or sRGB)
I use with the BM Ultra Studio HDMI/SDI USB 3.0 device (Which is not produce any more) In FCPX & Resolve .
But there is other newer devices (Thunder bolt , USB 3.0) plus PICe cards DeckLink Mini Monitor (https://www.blackmagicdesign.com/ca/products/decklink) cards


So as I mention before , computer video & monitors is in total different color space even if you choose sRGB in you computer icc profile ,
It's different then broadcast/legal space profile , they run on a smpte video standard .

I hope I cleared thinks up @ Ilia3101
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: reddeercity on November 19, 2018, 05:28:28 AM
Quote from: masc on November 18, 2018, 10:49:23 AM
Is it possible to send picture data to this blackmagic API and it is shown on the device?
Yes , but in a smpte video standard profile and be simultaneously stream thought multi connection e.g. HDMI & SDI (https://en.wikipedia.org/wiki/Serial_digital_interface) (serial digital interface)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Kharak on November 21, 2018, 01:48:07 PM
Finally got to try 1.3. This is a huge update! The colours are superb now, also WB Temperature seems to be handled right now!

Managed to grade some beautiful shots with MLV App on a laptop that has no GPU. Really nice! Keep up the good work
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: domasa on November 22, 2018, 12:58:02 AM
Thx for great app!

My feature request list:
- visualize Cut In/Out position on playback timeline
- Create Virtual Copy (like in Lightroom)

;)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on November 23, 2018, 10:07:25 AM
@domasa I like the idea of multiple versions of one file a lot. Instead of saying "file already in session" would be nice if "add another copy?" What do you think @masc? Also would be nice if they got grouped together.

@reddeercity An easy way to get a true preview in MLV app right now is to have an apple computer with a calibrated, decent quality monitor (and that calibration profile set in macOS of course), MLV App will be colour managed correctly as macOS knows the window is in sRGB and will convert it to screen colour space before displaying it. (just a suggestion for seeing your colour accurately)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on November 25, 2018, 01:00:28 PM
Curve tool! Awesome!
(https://i.postimg.cc/76wCScDF/Screenshot-2018-11-25-at-12-57-15-png-scaled.png)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on November 25, 2018, 01:28:58 PM
Wow, excellent!

The only big thing that's missing for me now is receipt slots.

Essential for my working style.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 25, 2018, 02:15:00 PM
Quote from: domasa on November 22, 2018, 12:58:02 AM
My feature request list:
- visualize Cut In/Out position on playback timeline
- Create Virtual Copy (like in Lightroom)
For visualizing cut in and out, I would need a special graphics element, which I don't have. And I had no luck so far to create this one.

Quote from: Ilia3101 on November 23, 2018, 10:07:25 AM
@domasa I like the idea of multiple versions of one file a lot. Instead of saying "file already in session" would be nice if "add another copy?" What do you think @masc? Also would be nice if they got grouped together.
Virtual copy could be realized somehow, but will bring a couple of problems. In past I this was no fun for me, why I decided to forbid it with the message "file already in session".

Quote from: 70MM13 on November 25, 2018, 01:28:58 PM
The only big thing that's missing for me now is receipt slots.
Sry... I know and thought a lot about it already... but I still have no good idea for this.

Quote from: Danne on November 25, 2018, 01:00:28 PM
Curve tool! Awesome!
Yes... since some hours first version of curves tool is added. But there are still bugs in the code... (some problems with cubic splines, and selection and dragging problems on apple retina displays).
(https://user-images.githubusercontent.com/30245296/48971029-f1b54100-f014-11e8-8678-4e266371eab5.png)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on November 25, 2018, 06:44:33 PM
curve tool is very nice

can you make an option to show them as 3 seprate curves?
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 25, 2018, 08:03:42 PM
Quote from: Lars Steenhoff on November 25, 2018, 06:44:33 PM
can you make an option to show them as 3 seprate curves?
you mean 4 curves in 4 diagrams?
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on November 25, 2018, 08:10:55 PM
Quote from: masc on November 25, 2018, 08:03:42 PM
you mean 4 curves in 4 diagrams?
Nice!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on November 25, 2018, 08:44:46 PM
yes thats what I mean
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 25, 2018, 09:17:09 PM
Quote from: Lars Steenhoff on November 25, 2018, 08:44:46 PM
yes thats what I mean
Haha... hm... sure it is possible. But the most of the time I needed, to get it working as it is now, was getting all 4 diagrams into one. :-D Better to start another new class for this than patching the existing one.
But why would you prefer 4 diagrams? All the apps I know combine the curves...
First I would like to get the stupid 1D cubic spline functions working correctly. If someone is good in math or knows a good free and easy C library for that, please let me know.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on November 25, 2018, 09:53:04 PM
Maybe something useful here:
https://patchwork.ffmpeg.org/patch/10104/
https://pypi.org/project/openlut/
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 25, 2018, 10:05:16 PM
Quote from: Danne on November 25, 2018, 09:53:04 PM
Maybe something useful here:
https://patchwork.ffmpeg.org/patch/10104/
https://pypi.org/project/openlut/
Thanks Danne, but it is no LUT. The processing is very simple, and the diagram needs a cubic spline function in background.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ErickTim on November 26, 2018, 07:48:45 AM
When the "use camera matrix" is checked and I use the saturation slider to reduce the saturation, I noticed that the image breaks. Mostly noticeable in the reds. This does not happen when not using camera matrix option. Is this expected? Here is an example image. Look at the red car.
(https://i.ibb.co/qgkq2NS/Untitled.png) (https://ibb.co/qgkq2NS)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on November 26, 2018, 09:56:31 AM
@ErickTim
Seems you are on windows? I am experimenting with a version with a somewhat altered colorspace so if you could upload a short sample MLV of the file I could check if it is fixed over here.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on November 26, 2018, 10:22:12 AM
I see that is a very saturated car, hopefully will get fixed in next version. It is because we use sRGB gamut internally for processing, it will be a wider one in next release (ACES)

Also I would love to have that MLV to test, it would be wonderful if you could send it.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: domasa on November 26, 2018, 10:26:21 AM
Quoteyou mean 4 curves in 4 diagrams?
For me is better one diagram with option show/hide curve.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on November 26, 2018, 11:11:42 AM
Quote from: domasa on November 26, 2018, 10:26:21 AM
For me is better one diagram with option show/hide curve.
Agree that master curve is where one go first. The separated color curves are there to color correct(more control) but of course optional.

Wtf. The separated curves are already there @Lars Steenhoff!
(https://i.postimg.cc/rwNf2Kb0/Screenshot-2018-11-26-at-11-17-55-png-500px.png)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on November 26, 2018, 11:22:53 AM
Quote from: Danne on November 26, 2018, 11:11:42 AM
Agree that master curve is where one go first. The separated color curves are there to color correct(more control) but of course optional.

Wtf. The separated curves are already there @Lars Steenhoff!
Yes... but Lars asked to have 4 separate diagrams.
When I find time I'll also fix them for retina screens... dragging is not possible atm as expected. On non retina it works fine.
Edit: fixed.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on November 26, 2018, 11:27:30 AM
The reason why I like them separate windows is that I can color correct faster that way, I don't need to click r g b separate and can make quick adjustments between the curves.

It what the old resolve interface had.  until they took it out to accomodate for laptop users, because if you put them together is saves space.   But if you use a large monitor it faster workflow to have them in their own window.

In final cut pro they also have their own seperate window now.

And in color finale it uses them separate.

I know some people prefer them on top, so im not saying one or the other, but to have both options.


(https://i.ibb.co/6RK5jjs/ED511593-3350-4-EE6-88-A5-29-E0-C33-F2-ED8.jpg) (https://ibb.co/6RK5jjs)


Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on November 26, 2018, 11:56:59 AM
I see. I thought size and functionality worked perfectly as is so thumbs up!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 26, 2018, 08:44:04 PM
Quote from: Lars Steenhoff on November 26, 2018, 11:27:30 AM
The reason why I like them separate windows is that I can color correct faster that way, I don't need to click r g b separate and can make quick adjustments between the curves.
This can be circumvented by keyboard shortcuts. e.g. 1,2,3,4 or similar. I don't see real advantage of occupying x4 more space for it.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on November 26, 2018, 10:47:26 PM
All I can say is personally I like it better seperate. its just more clear wich one color curve is doing what. when they overlap its more messy to visually see each curve as a separate adjustment. and its faster when using a mouse only, ( keyboard shortcuts do help but still.. )
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: scotophorus on December 01, 2018, 09:59:59 PM
The last update regarding the camera matrix colors is HUUUGE!

I've been getting some oversatured colors with this update, as some of you identified to be related with the internal srgb gamut. If i can do anything to help id be happy to. I'm so tired of using resolve (which atleast works fast), or after effects, I can't wait for this app to properly work, thank you very much to all who contibuted.

Quick question: I have a lot of older exported prores log-c .mov's that i created with mlvapp, how can i apply the camera matrix post convertion? I know probably some color information is lost due to the srgb gamut, but i'm sure a simple lut, rgb mixer values or rgb curves can help match the color of older mlvapp processed files with proper matrix calibrated files. As i understand the camera embeds the sensor color calibration values in the dng, cr2 or mlv files but i could be wrong.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on December 01, 2018, 10:05:19 PM
The sRGB gamut is a new thing, those old files actually have full sensor colour gamut, so no colour info is lost. You have camera gamut + log curve, not perfect as the colour gamut does not technically match the gamut that normally comes with Log-C. But you have lost nothing with the old app.

Full sensor gamut sounds good right? Well it's not great, because every sensor is slightly different so it doesn't match when you have multiple camera models, and sensor gamut is quite different from normal colour gamuts such as sRGB and AdobeRGB, so the hues are slightly inaccurate. This inaccuracy problem is fixed with the new update.

Once MLV App has ACES gamut in internal processing we will have both accuracy and there will not be any problems with the saturated colours going weird, it will also be possible to have many output colour space choices.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on December 01, 2018, 10:43:49 PM
Ah you want to match to the new MLV App colours?

I think a lut could be made for that. What camera do you use?
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: scotophorus on December 02, 2018, 06:17:49 PM
Quote from: Ilia3101 on December 01, 2018, 10:05:19 PM
no colour info is lost

Quote from: Ilia3101 on December 01, 2018, 10:05:19 PMOnce MLV App has ACES gamut in internal processing we will have both accuracy and there will not be any problems with the saturated colours going weird, it will also be possible to have many output colour space choices.

Niiiiiiiiiiiiiiice! you are a hero Ilia3101. Thank you for the quick answer

Quote from: Ilia3101 on December 01, 2018, 10:43:49 PM
Ah you want to match to the new MLV App colours?

I think a lut could be made for that. What camera do you use?

Yes, i have a canon 7d.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: JADURCA on December 04, 2018, 03:16:21 AM
Hi everyone! I just filmed today a few short clips using magiclantern-crop_rec_4k.2018Jul22.5D3113 version witch Crop mode 1080p45/1040p48 3x3 activated. Clips have red vertical lines. Can I fix them using MLV App? Here is an example if anyone like to see... https://www.dropbox.com/s/8vllphqmixs4uv8/M03-1721.MLV?dl=0
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on December 04, 2018, 07:25:36 AM
I´m pretty sure the issue is related to the generic registers in crop_rec.c:
https://www.magiclantern.fm/forum/index.php?topic=22818.msg207853#msg207853

It should be fixed in this build:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/crop_rec_4k_mlv_snd_isogain_1x3_5D3113_presets.zip

Above build is also working with 1920x1080 48fps(camera set to (PAL and canon mv720p 60fps):
https://www.magiclantern.fm/forum/index.php?topic=19300.msg208151#msg208151

Changes in here:
https://bitbucket.org/Dannephoto/magic-lantern/src/crop_rec_4k_mlv_snd_isogain_1x3_presets/modules/crop_rec/crop_rec.c#lines-1712

Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: JADURCA on December 04, 2018, 04:26:40 PM
Thanks @Danne for the info! Downloaded it would be testing it! Forgot to mention for the record, that I used NTSC and 720p 60 All-i in the Canon menu. So more info is available for you guys.

Can this corrupted clips be repaired so we can use them as an intro for a seminar video? We filmed like 5 clips of no more than 10 seconds with this issue. Hope it is possible to clean them.

Thanks!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: JADURCA on December 07, 2018, 02:56:39 PM

Tried to clean it using Pattern Noise option, almost did the job. Don't know if there is another option or technique. Check image below. Can someone help me?


(https://i.ibb.co/VvTKM1F/Screenshot-2018-12-07-09-34-35.png) (https://ibb.co/VvTKM1F)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on December 07, 2018, 07:33:54 PM
maybe enable vertical stripes as well?

I really dont know how you can fix this 100%.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: JADURCA on December 07, 2018, 07:38:29 PM
Thanks @Ilia3101! Tried that one too and nothing happened.

If you or someone want to take a look or experiment, here is the MLV file https://www.dropbox.com/s/8vllphqmixs4uv8/M03-1721.MLV?dl=0
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Levas on December 07, 2018, 07:58:01 PM
You should record a dark frame clip and try to extract that, I think that's an option available in MLVapp.
For recording a dark frame clip you can't use lossless compression, if I'm not mistaken, so if you used 14 bit lossless for the normal clip, you should use 14 bit uncompressed for the dark frame.
So for dark frame clip, use 14 bit uncompressed and then use the same ISO setting, same shutter time setting and same resolution setting as the normal clip.
Now put the lens cap on the lens and close down the diafragma to maximum, probably f22 (to eliminate all surrounding light).
Record a MLV clip and use this MLV for dark frame substraction in MLV app.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 08, 2018, 05:18:43 PM
Some new stuff to test for you: I tried to implement something similar but more flexible like we have in Lightroom - these HSL elements. In LR you have a couple of sliders, in MLVApp we have free diagrams now to paint curves in. I am not sure if my processing algorithm is correct (it just looks (mostly) similar to what LR does). For Hue vs. Luminance LR does somehow blur the edited areas - I don't blur it in MLVApp.
(https://user-images.githubusercontent.com/30245296/49667149-7b73fe00-fa5a-11e8-9a2b-102c68f2df21.png)
For now you'll have to compile MLVApp with these features on your own. If we don't find too awful bugs, we could make a release with that soon. Noisy or moiree areas look not so well... I have no idea how to improve that.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: JADURCA on December 08, 2018, 08:11:56 PM
Quote from: Levas on December 07, 2018, 07:58:01 PM
You should record a dark frame clip and try to extract that, I think that's an option available in MLVapp.
For recording a dark frame clip you can't use lossless compression, if I'm not mistaken, so if you used 14 bit lossless for the normal clip, you should use 14 bit uncompressed for the dark frame.
So for dark frame clip, use 14 bit uncompressed and then use the same ISO setting, same shutter time setting and same resolution setting as the normal clip.
Now put the lens cap on the lens and close down the diafragma to maximum, probably f22 (to eliminate all surrounding light).
Record a MLV clip and use this MLV for dark frame substraction in MLV app.

Just tried it Levas, every step as you suggested! Did not clean the red lines. Thanks for the suggestion!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on December 08, 2018, 08:22:52 PM
The footage is clearly corrupted. Better to reshoot and watch out for it not to happen again.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on December 09, 2018, 08:56:21 AM
Lovely work masc!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Kharak on December 09, 2018, 02:16:10 PM
mlv app is the open source brother of davinci resolve

Just missing the editor ;)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: JADURCA on December 09, 2018, 07:01:33 PM
Quote from: Danne on December 08, 2018, 08:22:52 PM
The footage is clearly corrupted. Better to reshoot and watch out for it not to happen again.

Ok Danne! Corrupted clips can not be fixed. Thanks for letting me know, although we cannot re shoot again, we can edit it in a creative way like looking trough an Old Analog TV, a damage analog fx should dissimulate corruption. It's a very short intro so we would be ok! Thanks everyone!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: a1ex on December 09, 2018, 07:47:35 PM
Since this bug is actually my fault, here's a quick attempt to fix the sample clip. Notice the first few frames are pretty much black, so we can use them as dark frames:


mlv_dump M03-1721.MLV -f 10 -o darkframes.mlv
mlv_dump darkframes.mlv -a -o dark.mlv
mlv_dump dark.mlv --no-stripes --dng # just to double-check the dark frame
mlv_dump M03-1721.MLV -s dark.mlv -o corrected.mlv


It's not perfect, but I hope the other correction tools will have something easier to work with. At least, pattern noise fix on the corrected MLV is not *that* bad.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on December 09, 2018, 09:23:16 PM
Original:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/M03-1721b_000236.tif
Darkframe average:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/M03-1721_000237.tif
Averaged:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/M03-1721_000237.tiff

Download to script:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/averaging_idea.command
(more info below)


Original:
(https://i.postimg.cc/m2TRYjmS/Screenshot-2018-12-09-at-21-25-11-png-scaled.png)

Darkframe averaged according to a1ex suggestion and got rid of a lot of the stripes:
(https://i.postimg.cc/q7MmJhM0/Screenshot-2018-12-09-at-21-08-51-png-scaled.png)

Crop
(https://i.postimg.cc/RhsSYnFF/Screenshot-2018-12-09-at-21-13-42-png-scaled.png)



However, more can be done:
Further averaged with enfuse and hugin align_image
(https://i.postimg.cc/Z5L7zFmV/Screenshot-2018-12-09-at-21-08-59-png-scaled.png)


Final result:
Cropped, enfuse and hugin align_image
(https://i.postimg.cc/prXVkBP4/Screenshot-2018-12-09-at-21-14-50-png-scaled.png)


So what I did was adding some averaging and aligning with enfuse and hugin align_image through a script workflow:
Download to script:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/averaging_idea.command


Workflow:
1 - Do the darkframe averaging according to a1ex tip above
2 - Export the new MLV through MLV app into tif files
3 - Add the averaging_idea.command script into the folder with tif files and double click it. Make sure it has chmod rights
(https://i.postimg.cc/P5H37VgC/Screenshot-2018-12-09-at-21-09-38-png-500px.png)
4 - The script will output all kinds of tif files but in the end it will replace the original tif files with files ending with .tiff. The originals are placed in a separate folder called tif_tmp


The important part of the script:
#works on tif files
while grep -E "tif" <<< $(find . -maxdepth 1 -iname '*.tif')
do
/Applications/Hugin/Hugin.app/Contents/MacOS/align_image_stack -a aligned.tif \
$(find -s . -maxdepth 1 -name '*.tif' | head -n 5)
/Applications/Hugin/tools_mac/enfuse --exposure-optimum=0.5 --exposure-width=0.5 $(find . -maxdepth 1 -iname 'aligned.*tif') -o $(find -s . -maxdepth 1 -iname '*.tif' | awk 'FNR == 1' | cut -d "." -f2 | tr -d "/").tiff
rm aligned.*tif
mkdir -p tif_tmp
mv $(find -s . -maxdepth 1 -name '*.tif' | awk 'FNR == 1') tif_tmp
done


Most probably more can be done also maybe through ffmpeg but this is a good start.



Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: JADURCA on December 09, 2018, 09:56:58 PM
a1ex and Danne, looks amazing! Thanks for your time and effort! I'm doing it right away! Not an experiment person with script, I would learn.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on December 10, 2018, 01:23:12 AM
Used MLV App in a 3 day project this week. (screenshots taken from MLV App : https://imgur.com/a/joPJGqc )
I can't say it was easy but I'm impressed for all the progress! For me though, even if I like new features and such, there're things that should come first. I came up with a little list, in order of importance more or less.

1) Automatically skip frames / fix could not save error.
I'm not sure what is going on here, I've tried with different hard drives, my computer *should* not be the problem, but this problem came up with over night conversion: https://i.imgur.com/MRKBDbx.png  It was a big big problem since the pop up completelly stopped the conversion to dng. Also it doesn't seem that any frame was actually corrupted, this happened on various spots and then I came back and exported the "problematic" frame without any issue. Are other pass tried if a frame fail to save? Or is it like done once and if it doesn't work it is over? There should be an option to not stop and just export a log with problematic frames.

2) MAPP batch creation.
I couldn't find this, for me it seems obvious that the point of a MAPP file is to make "end of the day" playback easy, it should be possible to batch the creation of the files so that you can progress through clips without stopping.

3) Playback is 5 fps for me. I have an i7 2.3 2012 and dedicated GPU, I'm not sure if this is to be expected, good to remember that MlRawViewer has real time!

4) The software still has a general feeling of "beeing stuck" when performing complex actions, there're many instances where it happens. This is a problem for daily use, it is nerve breaking.

5) Multhithread kicking in when not needed. This need further experimentation, I remember you saying that multithread kicks in only when raw corrections are applayed but I don't think that is true. And even so raw correction where possible at the same speed even before multithread. I'm curious to know what other people experience is on this. For me it is a real problem since that much power consumption for years/conversion nights will damage the internal of macbooks :/

6) FPS export speed should be displayed on the export window, it is a very usefull feature to test/monitor/report stuff.

7) Hidable (in the dock) export window. A small feature that I'm not sure if it is easy to implement or not.

8) Highlight recovery. I've putted this on the end since at the moment I'm still thinking of using Davinci Resolve from dng export. But I'm amazed at the improvements in color rendition. The ease of use in switching between different linear to gamma elaboration is remarquable. The tonemapped default one is very good, good skin colours. Curious to know where did you take the curve (gamma as well?) data from for this.
Anyways Highlight recovery is not even near as good as other options, and I would say this is fairly important if you want to export and use ProRess directly from MLV App. HEre there is a comparison, I've changed the gamma scheme on Resolve to make the difference pop up even more. The highlight reconstruction option in MLV App makes no difference. https://imgur.com/a/0CGFw4p




Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 10, 2018, 09:29:13 AM
Thanks for your report, togg.
1) Maybe bouncyball can tell something about that...

2) MAPPs are batch created when exporting files (e.g. if you export proxy for all files first) or for single file (non batch) if you just open it.

3) MLVApp don't uses any GPU. That is why it works on nearly every computer, instead of most other software. If you use it on a non-retina display it should be ~1.5x faster. If you need faster preview, export the clip or use MlRawViewer. Compairing to MlRawViewer is not really fair, because of the lack of many many functions. Resolve on my systems has the same speed (more or less) and heats the GPU additionally.
For FHD on a MBP 2013 i5 2.4GHz I get 13fps, on a MBP 2010 Core2Duo 2.4GHz 7fps, on a iMac 2011 i5 21.5" 23fps.

4) ?! = 3)?

5)
QuoteMulthithread kicking in when not needed.
I don't think so. Multithreading is no fun, so we implemented it only where it is needed.
QuoteAnd even so raw correction where possible at the same speed even before multithread.
And that's also not true. We benchmarked it often enough I think.
Complete processing pipeline, most debayers and a part of RAW corrections use multithreading, as well as ffmpeg.

6) Really? For what reason is that useful? Use the fps label from playback. The pipeline is identical, only the output is viewer vs. ffmpeg/AVFoundation.

7) I did not find any possiblity to realize that. We can chose between:
   a) Window is not at OS foreground, but will be lost after first click somewhere in your OS
   b) What we have
   Maybe someone knows programming with Qt and can help...
Edit: yay... I finally found another solution after searching for it the 1000th time.

Highlights: Have you tried: exposure -2, lighten +50, highlight recovery on? For me, this mostly looks better than Resolve.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 10, 2018, 06:22:41 PM
Hi guys,

@togg

1) I really need that MLV to reproduce this error. I wrote this error handling and sadly never could reproduce this exact error in real life :P so I'm really interested to play with it. BTW are you trying to save losslessly compressed DNGs?

2) Yeah... MAPP is created when MLV fully read not just opened to generate preview thumb. After loading the MLV just once, accessing next time(s) to this exact clip is very fast. Actually batch saving of the MAPPs, as a separate action in the menu, is doable. Maybe we'll think about it with @masc.

3) Yeah we do not use GPU. Reason: if we do so we have to implement all processing pipeline (not only debayer) also on GPU, it's tough! Look at "fastcinemadng" it uses expensive external library which does lots of stuff on GPU in pure Nvidia's CUDA. Also look at the evolution of the MLRawViewer. I mean compare 1st commit to the last one and you will see how it grew from just one opengl shader to 6 or 7 including basic processing and minimalistic but cool GUI :)

regards
bb
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: megapolis on December 10, 2018, 07:38:26 PM
@bouncyball
I need to do some clarification here. In Fast CinemaDNG we are using our own CUDA library for image processing, that we've implemented by themselves. Yes, this is quite complicated, but we think it's worth doing.
P.S. Sorry for intrusion. MLVApp is very good application, we have no doubts about that.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 11, 2018, 08:16:49 AM
@megapolis

Thanks for the clarification :) I like your cool app and it works smoothly on my GTX1080. I just miss the Linux version.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on December 11, 2018, 08:48:44 AM
And I miss the Mac version ( I know cuda needs nvida, but recent macs can have those cards with external gpu)

The same for MLVapp I would love to see and gpu accellerated version, or a new version that uses caching for smooth playback on the second loop.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 11, 2018, 09:37:32 AM
Quote from: Lars Steenhoff on December 11, 2018, 08:48:44 AM
The same for MLVapp I would love to see and gpu accellerated version...
You shouldn't wait for that. Start implementing it and help us. Until now nobody was willing to do that for us and we don't know writing GPU code. It is very different... and has to be learned.

Quote from: Lars Steenhoff on December 11, 2018, 08:48:44 AM
... or a new version that uses caching for smooth playback on the second loop.
We'll see what we can do here. But it has not highest priority. Implementing this was very painful in the past (never worked fine on Windows) and it will become ~100% more complex to how it was before in terms of cache organization. Current status can be found on github issue page.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on December 11, 2018, 02:08:54 PM
Quote from: masc on December 10, 2018, 09:29:13 AM
Thanks for your report, togg.
1) Maybe bouncyball can tell something about that...

2) MAPPs are batch created when exporting files (e.g. if you export proxy for all files first) or for single file (non batch) if you just open it.

3) MLVApp don't uses any GPU. That is why it works on nearly every computer, instead of most other software. If you use it on a non-retina display it should be ~1.5x faster. If you need faster preview, export the clip or use MlRawViewer. Compairing to MlRawViewer is not really fair, because of the lack of many many functions. Resolve on my systems has the same speed (more or less) and heats the GPU additionally.
For FHD on a MBP 2013 i5 2.4GHz I get 13fps, on a MBP 2010 Core2Duo 2.4GHz 7fps, on a iMac 2011 i5 21.5" 23fps.

4) ?! = 3)?

5)  I don't think so. Multithreading is no fun, so we implemented it only where it is needed. And that's also not true. We benchmarked it often enough I think.
Complete processing pipeline, most debayers and a part of RAW corrections use multithreading, as well as ffmpeg.

6) Really? For what reason is that useful? Use the fps label from playback. The pipeline is identical, only the output is viewer vs. ffmpeg/AVFoundation.

7) I did not find any possiblity to realize that. We can chose between:
   a) Window is not at OS foreground, but will be lost after first click somewhere in your OS
   b) What we have
   Maybe someone knows programming with Qt and can help...
Edit: yay... I finally found another solution after searching for it the 1000th time.

Highlights: Have you tried: exposure -2, lighten +50, highlight recovery on? For me, this mostly looks better than Resolve.


Quote from: bouncyball on December 10, 2018, 06:22:41 PM
Hi guys,

@togg

1) I really need that MLV to reproduce this error. I wrote this error handling and sadly never could reproduce this exact error in real life :P so I'm really interested to play with it. BTW are you trying to save losslessly compressed DNGs?

2) Yeah... MAPP is created when MLV fully read not just opened to generate preview thumb. After loading the MLV just once, accessing next time(s) to this exact clip is very fast. Actually batch saving of the MAPPs, as a separate action in the menu, is doable. Maybe we'll think about it with @masc.

3) Yeah we do not use GPU. Reason: if we do so we have to implement all processing pipeline (not only debayer) also on GPU, it's tough! Look at "fastcinemadng" it uses expensive external library which does lots of stuff on GPU in pure Nvidia's CUDA. Also look at the evolution of the MLRawViewer. I mean compare 1st commit to the last one and you will see how it grew from just one opengl shader to 6 or 7 including basic processing and minimalistic but cool GUI :)

regards
bb


1) I wish I could provide that MLV, problem is it is very big. I'm not even sure I could reproduce this every time, it happened multiple times in random spots, I couldn't test preciselly. Yes I'm trying to save to losslessly compressed DNG from 14bit compressed MLV. Also note that I'm talking about a 250GB total export batch, around 10 takes total.
But I do feel like it's important we get around this, since the conversion time is so big having one of this failures during night conversion and having some CF cards not ready for next day is quite catastrophic.
Is MLV App trying multiple times if a frame give out errors? Could this be related to drive I/O errors? Weird though, since hard drives were still connected.

2) Exactly. I really feel that batch saving MAPP is important, having to wait for take to load and click at the end of a shooting day is impossible. Better to launch a batch, eat something, and come back in 4 minutes.
Also the opening with MAPP file is still a little bit long I'd say, 1 second and something? But I guess it can't be brought down easely.

3) Got this. At the end of it I understand the difficulty of bringing real time playback, it doesn't matter that much and sadly there're not enough users to justify that much writing of code, I'll still have MlRawViewer on the dock.
But I've noticed something I don't fully understand. FPS change from 4 to 8 if I resize the window. 10 if I check "open in low resolution". Is this due to retina, @masc? Also my numbers seem pretty low compared to yours, what could be the problem beside retina?

7) Nice! For me the omni present export window isn't the biggest deal but makes the software a little bit too intrusive and "clunky".


8) I've tried your method for Highlight reconstruction. I must admit that playing that much with sliders scare me a bit. Interesting tough. I have the feeling the whole highlight reconstruction is a very complex deal, even Resolve can't handle it well and you have to play with white balance on raw panel to avoid artifacts. For me it is a badly needed feature though, I didn't measure it but it is at least one stop more of exposure.

I've uploaded 2 small MLV files yo play with that you can use to see where and how MLVApp still fails.

http://www.mediafire.com/file/v2cu6bzenxg9rft/M07-1108.MLV/file


http://www.mediafire.com/file/4l9ibbg7tvp0g1g/M07-1108-2.MLV/file


Thanks for all the help!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 11, 2018, 02:55:30 PM
@togg: I played with your MLVs and get this out of it:
(https://i.ibb.co/QMBhd42/Bildschirmfoto-2018-12-11-um-14-46-45.png)
(https://i.ibb.co/n7ZBFLH/Bildschirmfoto-2018-12-11-um-14-46-36.png)
See the sliders. I had to adjust the RAW white level to get a correct sky. Indeed, highlight processing is very complicated. It just works, if the white level is set correctly. The value read out from the MLV might be wrong, what leads to strange colors in overexposed areas.

For framerate: the more (screen)pixels the software has to calculate, the longer it needs. So if the window is small, it will be faster. Retina or other highres screens are very bad, because more pixels (4x @ retina) have to be calculated. OSX does this in background without the need of further code, so we can't do much here.
Maybe the screen is the difference between your numbers and mine: my screens are mostly around FHD, the old MBP has 1280x800.
Another speed brake is "lossless". Not using it can bring up to 2x more speed, because decoding is not needed.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 11, 2018, 04:30:47 PM
@togg

Quote from: togg on December 11, 2018, 02:08:54 PM
Yes I'm trying to save to losslessly compressed DNG from 14bit compressed MLV. Also note that I'm talking about a 250GB total export batch, around 10 takes total.
Is MLV App trying multiple times if a frame give out errors? Could this be related to drive I/O errors? Weird though, since hard drives were still connected.
Lossless compressor fails sometimes (and there is nothing I can do about it). The encoder spits out error and it means the data can not be encoded efficiently (e.g. compressed data is even larger then original ;))
And yes this error also occurs due to I/O issues.
Please try to export uncompressed DNGs (it is working every time) and report back.

Quote from: togg on December 11, 2018, 02:08:54 PM
Also the opening with MAPP file is still a little bit long I'd say, 1 second and something? But I guess it can't be brought down easely.
Well... if the clip is long enough and includes audio then yes (w/o audio almost no time needed).
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 11, 2018, 04:35:08 PM
BTW I've added MLV decompression option to mlvapp recently. So you can easily uncompress any MLV and play it even with good old unmodified MLRawViewer. I can play 3K+ MLVs in real time w/o issues.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 11, 2018, 04:53:47 PM
Even better with mlvapp's HSL correction and gradient tool ;)

(https://i.ibb.co/DCWBnJ8/M07-1108-2-frame-5.png) (https://ibb.co/DCWBnJ8)

I guess left side of the sky is really unrecoverable.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on December 12, 2018, 01:19:37 AM
Quote from: masc on December 11, 2018, 02:55:30 PM
@togg: I played with your MLVs and get this out of it:
(https://i.ibb.co/QMBhd42/Bildschirmfoto-2018-12-11-um-14-46-45.png)
(https://i.ibb.co/n7ZBFLH/Bildschirmfoto-2018-12-11-um-14-46-36.png)
See the sliders. I had to adjust the RAW white level to get a correct sky. Indeed, highlight processing is very complicated. It just works, if the white level is set correctly. The value read out from the MLV might be wrong, what leads to strange colors in overexposed areas.

For framerate: the more (screen)pixels the software has to calculate, the longer it needs. So if the window is small, it will be faster. Retina or other highres screens are very bad, because more pixels (4x @ retina) have to be calculated. OSX does this in background without the need of further code, so we can't do much here.
Maybe the screen is the difference between your numbers and mine: my screens are mostly around FHD, the old MBP has 1280x800.
Another speed brake is "lossless". Not using it can bring up to 2x more speed, because decoding is not needed.

Very interesting, so the white level slider is what Resolve is missing. Still a lot of slider though, kind of scary to start a grade from that much movement, but I'm starting to see this as needed. Still strange that for the highlight recovery button to kick in you have to lower the exposure and in some way affect the whole image. some more informations can be seen on resolve: https://i.imgur.com/jhUgocW.png

Damn, that's why they put a open in lower resolution in the first place, I think I'll use it. There's not that much text on screen.

I'll test uncompressed speeds again when possible! Thanks.

Quote from: bouncyball on December 11, 2018, 04:30:47 PM
@togg
Lossless compressor fails sometimes (and there is nothing I can do about it). The encoder spits out error and it means the data can not be encoded efficiently (e.g. compressed data is even larger then original ;))
And yes this error also occurs due to I/O issues.
Please try to export uncompressed DNGs (it is working every time) and report back.

Thing is those clips/frames didn't actually have any problem. I came back to it a second time and they exported fine. This is why I was wondering if the software could keep trying if it fails once, in both cases of I/O or compression issues.

Fantastic for the uncompression, always usefull to have!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 12, 2018, 08:03:32 AM
Quote from: togg on December 12, 2018, 01:19:37 AM
Still strange that for the highlight recovery button to kick in you have to lower the exposure and in some way affect the whole image.
Highlight reconstruction in MLVApp does only reconstruct highlights and does not affect some brightness as in Resolve. That means, areas where the green channel was clipped (99% of damaged highlights) the green channel is recovered from red and blue. Clipped green with lowered exposure leads to pink highlights.
OFF:
(https://i.ibb.co/xjGBJ6G/M07-1108-frame-1a.png)

ON:
(https://i.ibb.co/W02rXKM/M07-1108-frame-1b.png)

Quote from: togg on December 12, 2018, 01:19:37 AM
some more informations can be seen on resolve: https://i.imgur.com/jhUgocW.png
Hm... slightly more contrast, but wrong colors (cyan to magenta in the upper right).

Quote from: togg on December 12, 2018, 01:19:37 AM
Damn, that's why they put a open in lower resolution in the first place, I think I'll use it. There's not that much text on screen.
Where do you find this? Is the App somehow opened in LowRes then? If it is just the simulated resolution in OSX: this doesn't make it any better, because rendered area (in cm) on screen is more or less the same.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on December 12, 2018, 10:03:35 AM
Quote from: masc on December 12, 2018, 08:03:32 AM
Where do you find this? Is the App somehow opened in LowRes then? If it is just the simulated resolution in OSX: this doesn't make it any better, because rendered area (in cm) on screen is more or less the same.


it is the option that you have in the Finder info for the software and yes it is working, I've tested it only with small files but I'm almost sure of it.

OK got the whole process of highlight, interesting. I guess that affecting the whole image is a good solution to avoid artifacts on edges, also writing a super powerfull highlight reconstruction button would maybe take time.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 12, 2018, 11:57:15 AM
Quote from: togg on December 12, 2018, 10:03:35 AM
it is the option that you have in the Finder info for the software and yes it is working, I've tested it only with small files but I'm almost sure of it.
GREAT! Never saw this one! That indeed works! :D
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on December 12, 2018, 05:18:16 PM
Is it possible to make an option for the edit area to be in a window/info box/whatever nomenclature as a floating window?

This would be great for multiple monitors!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on December 13, 2018, 12:25:35 PM
Quote from: masc on December 12, 2018, 11:57:15 AM
GREAT! Never saw this one! That indeed works! :D

Yes, for me it goes from 5 fps to 7-8.
I couldn't find the option to decompress MLV, is it already in?
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 13, 2018, 01:26:35 PM
Quote from: togg on December 13, 2018, 12:25:35 PM
Yes, for me it goes from 5 fps to 7-8.
I couldn't find the option to decompress MLV, is it already in?
For this you'll have to compile yourself, or wait for next release...

@70MM13: there are many many dependencies between all panels in the frame... relatively easy would be adding a 2nd window, which shows the viewer a 2nd time. But this again costs some fps...
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on December 13, 2018, 07:37:46 PM
If it's not too much trouble to add the option, it would be great!

Having a fullscreen viewer is great for critical grading. FPS is irrelevant when working with a still frame, and if one needs every ounce of playback speed, just disable the extra window...

PS: I'm happier with mlvapp than resolve for great results and much better control system!

Thanks for such a great app that just keeps getting better!

PPS: is there a way to define the output filenames when doing an bunch of clips, such as naming each clip in the editor?  I don't see any obvious way to do it...

Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 13, 2018, 08:45:07 PM
Quote from: 70MM13 on December 13, 2018, 07:37:46 PM
Having a fullscreen viewer is great for critical grading.
Fullscreen is not possible - unfortunately Qt is very buggy here. I implemented it a year ago using the Qt fullscreen functions. But it is hidden since that because it works really bad. It was bug free on OSX single monitor systems. On some other systems all input devices get blocked in fullscreen and you just can shut up the app... if you have more than one monitor, it was even more strange. That's why also another extra window would not be fullscreen. The closest you can get is pressing "A S E" and maximizing the app.
And here again: if there is someone who can help me with such Qt problems: please contact me!

Quote from: 70MM13 on December 13, 2018, 07:37:46 PM
PPS: is there a way to define the output filenames when doing an bunch of clips, such as naming each clip in the editor?  I don't see any obvious way to do it...
Nope. Renaming is only possible if you export one clip.

Quote from: 70MM13 on December 13, 2018, 07:37:46 PM
PS: I'm happier with mlvapp than resolve for great results and much better control system!
:D thank you. We do our very best...
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on December 13, 2018, 09:27:57 PM
Since I always shoot in 2.35:1, I call it "fullscreen" to get rid of the boxes on left and right ;)

So, having the edit area in a floating window on another screen is just perfect for me!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 14, 2018, 10:04:27 AM
Quote from: 70MM13 on December 13, 2018, 09:27:57 PM
So, having the edit area in a floating window on another screen is just perfect for me!
I made the edit area floatable and moveable now. But I have no idea, what bugs this brings. So please - who is able to compile - test it carefully.

(https://user-images.githubusercontent.com/30245296/49996101-5584b700-ff8e-11e8-969e-6945b2a1a651.png)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on December 14, 2018, 03:18:13 PM
Yes works really well!

Thanks


(https://i.ibb.co/znKDXFq/Screen-Shot-2018-12-14-at-15-16-55.png) (https://ibb.co/znKDXFq)



(https://i.ibb.co/X5Nbz7q/Screen-Shot-2018-12-14-at-15-19-06.png) (https://ibb.co/X5Nbz7q)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on December 14, 2018, 03:30:50 PM
I feel the wish to reposition the order of the items in the "edit menu".
Is there a way to make those positions customisable, and restored when restarting the app?
and a way to enable disable not often used items

(https://icdn3.digitaltrends.com/image/lr-classic-customize-develop-694x834.jpg)


https://www.digitaltrends.com/photography/adobe-lightroom-classic-reorganize-ui-december-update/
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on December 14, 2018, 05:54:18 PM
The hability to change the default start is something I feel could be usefull as well. So that if you have a standard process you are not at risk of forgetting it on one of the exports
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 14, 2018, 07:26:00 PM
@Lars: you found the ability to minimize the edit groups? Why completely hiding them? The current order is mostly identical to the processing pipeline, so why changing the UI? It would not change the processing, and you would not get what would be expected when changing the order.

@togg: sry, I don't understand. Default start? Standard process? Could you please explain more precisely?
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on December 14, 2018, 08:54:34 PM
I have to check but does the minimize state get restored on restart?

That would be good,

for reorder, I mostly use just a few funtions all the time and other almost never, I would put the most used on top.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on December 14, 2018, 08:56:45 PM
Quote from: masc on December 14, 2018, 07:26:00 PM

@togg: sry, I don't understand. Default start? Standard process? Could you please explain more precisely?

I mean the ability to select a state that will be restored at restart. Like preferences but for the raw corrections. Without passing from a saved project.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 14, 2018, 09:11:59 PM
Quote from: Lars Steenhoff on December 14, 2018, 08:54:34 PM
I have to check but does the minimize state get restored on restart?
Yes it does.

Quote from: togg on December 14, 2018, 08:56:45 PM
I mean the ability to select a state that will be restored at restart. Like preferences but for the raw corrections. Without passing from a saved project.
Preferences for parameters can be exported and imported as receipt.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on December 14, 2018, 09:58:15 PM
The floating edit window is excellent!

It's great to be able to enlarge the edit window on the second monitor, making it more enjoyable to work...

Thanks!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on December 14, 2018, 11:36:47 PM
Wow masc. That was something else. Is there anything you can´t do dude  8)?
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on December 15, 2018, 04:06:08 PM
Here's an annoyance that is hopefully easy to resolve (pun intended):

Whenever I'm doing any I/O operations, the destination always defaults to the same incorrect location.  It's a real problem for me because I'm constantly saving and loading receipts (while I await the much-needed receipt slots!), and it totally breaks down the workflow to have to navigate to someplace other than the CF card to do this.

Can mlvapp remember where you saved last, and default to that until you choose another location?  It would make things a lot smoother, especially when using keyboard shortcuts.

Thanks!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 15, 2018, 07:23:42 PM
Quote from: Danne on December 14, 2018, 11:36:47 PM
Wow masc. That was something else. Is there anything you can´t do dude  8)?
LOL... thanks... but yes, there is enough I can't do... hehe. For example I don't get the histogram bigger without loosing one quarter of playback speed :(

Quote from: 70MM13 on December 15, 2018, 04:06:08 PM
Whenever I'm doing any I/O operations, the destination always defaults to the same incorrect location.  It's a real problem for me because I'm constantly saving and loading receipts (while I await the much-needed receipt slots!), and it totally breaks down the workflow to have to navigate to someplace other than the CF card to do this.

Can mlvapp remember where you saved last, and default to that until you choose another location?  It would make things a lot smoother, especially when using keyboard shortcuts.
Please describe exactly what you are doing! I save sooo many many destinations for soooo many functions in MLVApp since many versions... so this sounds really strange and I don't know exactly what you mean. ;) I never have to navigate in any function I tested, if using the same folder again. So I think you are a bug victim :D
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on December 16, 2018, 02:34:28 AM
With the help of Masc, I found the cause of the I/O path problem I was experiencing.

It was a ramdisk I use...  I wasn't naming the virtual drive.  Adding any name solved the issue.

Thanks for the help, Masc!
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 21, 2018, 01:24:15 PM
Our little christmas present for you all: v1.4 is out.
+ Added gradation curves for Y, R, G & B
+ Added diagram elements for Hue vs. Hue, Hue vs. Saturation and Hue vs. Luminance
+ MLV uncompress export
+ Select between different rescaling algorithms on ffmpeg export
+ Added LUT strength slider
+ Some bug fixes and some minor changes
https://github.com/ilia3101/MLV-App/releases/tag/QTv1.4

(https://user-images.githubusercontent.com/30245296/50310781-66a85900-04a3-11e9-85b9-9256c837d1d6.png)

(https://user-images.githubusercontent.com/30245296/50355759-06232580-0550-11e9-9cda-57e26c5bd016.png)
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on December 21, 2018, 01:47:54 PM
huge! Thanks!! Will test asap.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on December 21, 2018, 06:01:07 PM
Seriously, guys, this app is getting pretty amazing!
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: domo94 on December 21, 2018, 06:16:32 PM
WOOHOO!

I'm loving this app so much more now!
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: BMSmile on December 21, 2018, 08:53:51 PM
Very cool and fast app!
It would be cool (for proxy usage) to have feature "Use prefix unique filenames" like in Davinci resolve format, because when you shoot reportage and swap memory card, sometimes files get same names because of shooting time. This feature will help alot
My workflow is: MLV App -> (proxy from source) -> Premiere Pro -> (edit) -> Davinci Resolve -> (grade source files) -> (render) -> (replace proxy with graded footage)

(https://i.ibb.co/b3SWJqd/image.png) (https://ibb.co/b3SWJqd)
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 21, 2018, 09:29:53 PM
@BMSmile: why not manually renaming your files before working with them? So you won't have any problem.
-> There wouldn't be a problem with your workflow. Premiere, Resolve, all could handle that.
-> You export all proxies to one directory, but you have the MLVs in several folders? If you throw all MLVs into one folder, you'll see what files to rename.
------
-> MLVApp won't import a file twice.
-> If renaming feature works just a little different to Resolve, your workflow would still not work, even if MLVApp had this feature
-> MLVApp can't relink when importing FCPXML project (that means only one of the files will be relinked) (for workflow: MLVApp (proxy from MLV) -> Cut in any App and export fcpxml file of project -> MLVApp (only grade used files using fcpxml import function) -> Replace proxy with graded clips in App where you cut before)

So we would break our own features just to make other programs work... hm... don't like it too much.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: goldenchild9to5 on December 22, 2018, 05:09:11 AM
@masc Thank you.. best MLV App  8) will give it a run in the morning.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on December 22, 2018, 01:25:18 PM
With uncompressed mlv and low res app opening I've got 10 fps, from 8.
I wonder if there's a way to have the crisp text and only low res for the viewer.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 22, 2018, 01:37:25 PM
Quote from: togg on December 22, 2018, 01:25:18 PM
I wonder if there's a way to have the crisp text and only low res for the viewer.
You mean retina support for the GUI, but not for the viewer? That would be possible with some rework of the viewer code.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on December 22, 2018, 04:30:22 PM
Frankly, guys, MLVApp has changed my life!  I have gotten so used to it, that now I cannot live without it any more.  For me, MLVApp, with subsequent processing with Resolve results in the easiest and fasters workflow.  It has been a lot of joy to watch how this amazing software develops and is getting better and better.  Thank you so much to all of you involved. 
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on December 22, 2018, 09:45:02 PM
Quote from: masc on December 22, 2018, 01:37:25 PM
You mean retina support for the GUI, but not for the viewer? That would be possible with some rework of the viewer code.

Yes exactly. Then again it only gives a small number of frames but it is noticeable
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: FBongcam on December 25, 2018, 01:34:00 PM
Awesome updates in 1.4, thank you!

I noticed that you're able to have the edit panel floating, would there be a possibility to have the individual panels behave the same instead? Like "Processing", "Details" and "HSL". It would allow for more customization and better utilization of monitors with higher resolution.

Sorry if it's already been mentioned.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on December 25, 2018, 01:46:24 PM
Great update!

Can you add a Zoom 200% option in the viewer?

I like to see the footage closer when I'm making adjustments to noise reduction settings.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 25, 2018, 04:40:13 PM
Quote from: Lars Steenhoff on December 25, 2018, 01:46:24 PM
Can you add a Zoom 200% option in the viewer?
You can zoom in/out with mouse scroll wheel. There is no problem beyond the 100% zoom until one pixel covers whole screen :).
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: omananda on December 26, 2018, 07:45:02 PM
OMG - This is so cool! Thank you.

Omananda
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 27, 2018, 08:22:58 PM
Quote from: FBongcam on December 25, 2018, 01:34:00 PM
Awesome updates in 1.4, thank you!

I noticed that you're able to have the edit panel floating, would there be a possibility to have the individual panels behave the same instead? Like "Processing", "Details" and "HSL". It would allow for more customization and better utilization of monitors with higher resolution.

Sorry if it's already been mentioned.
That would work ONLY on very large monitors with high resolution. Because this would forbid scrolling. Each group has a different height, so tabbing these groups makes no (real) sense as well. You have that problem with MLVProducer: on large monitors it is very nice to use (@ >=FHD), on a notebook it is nearly impossible to use it (at least laptops like my 13" @ 1280x800).
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 27, 2018, 08:23:45 PM
Quote from: Lars Steenhoff on December 25, 2018, 01:46:24 PM
Can you add a Zoom 200% option in the viewer?
Quote from: bouncyball on December 25, 2018, 04:40:13 PM
You can zoom in/out with mouse scroll wheel. There is no problem beyond the 100% zoom until one pixel covers whole screen :).
All is said... :D
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on December 27, 2018, 09:31:54 PM
Does not work when zoom to fit is enabled, thats why I guess I never used it.  8)

Could you make also keyboard shortcuts work with zooming?

Mac "CMD +" and "CMD -"

PC "Control +" and "Control -"

I use a Wacom tablet and don't have a scroll wheel there.

And use increments like 100% 200% 300%.    ;)
Title: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on December 28, 2018, 06:12:11 AM
This is all fantastic and indeed what a remarkable update, Fellas. I am feeling this one big time. Happy Holidays and I mean it is incredible how much it has grown in so little time!

Loving the gradation curves, HSL, Linear Gradient as well as the Dual-ISO features (big improvement tho not yet perfect especially with the highlight recovery) and noise reduction seems to help a bit (tend to use 3x3 at no more than +20 when necessary) along w other amazing features.  [emoji41]

Heck I can fit the entire single pixel on the monitor via Zoom. So quickly right after you press 'F' and bam on the scroll wheel you roll into it within seconds!   [emoji14]

To my surprise (or was this to be expected?) that it seems DarkFraming wouldn't work with Lossless files according to version 1.4...

Loving how @Danne & @dfort have contributed along with you all amazing developers on getting this app up to speed even before Adobe's eyes!

*edit*

I had decided to run DarkFraming Avg process through the good ole' Switch app w these Lossless 12-bit files (Thanks @Danne!) and sure enough the averaged MLV's seems to cause MLV App 1.4 to crash as soon as you drop the file into the app. I'm currently running 10.14.1 if that matters, ha.

Here are some short samples shot in 2400x1320 in 30p while in ISO 6400 for those that are curious...

Pre-DFAvg 12-bit lossless
https://bitbucket.org/DeafEyeJedi/magic-lantern/downloads/M26-2217_samples.zip
https://bitbucket.org/DeafEyeJedi/magic-lantern/downloads/M26-2218_samples.zip
https://bitbucket.org/DeafEyeJedi/magic-lantern/downloads/M26-2221_samples.zip

Post-DFAvg 12-bit lossless
https://bitbucket.org/DeafEyeJedi/magic-lantern/downloads/a_M26-2217_samples.zip
https://bitbucket.org/DeafEyeJedi/magic-lantern/downloads/a_M26-2218_samples.zip
https://bitbucket.org/DeafEyeJedi/magic-lantern/downloads/a_M26-2221_samples.zip
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 28, 2018, 03:32:33 PM
@DeafEyeJedi: thanks for your tests! Could you please upload a sample which leads MLVApp to crash?
Title: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on December 28, 2018, 06:10:18 PM
Quote from: masc on December 28, 2018, 03:32:33 PM
@DeafEyeJedi: thanks for your tests! Could you please upload a sample which leads MLVApp to crash?

Please download one of the three short Post-DF avg sample files from up above.

I also tried locating a log crash report to no avail. Any hints?
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 28, 2018, 10:33:13 PM
Quote from: DeafEyeJedi on December 28, 2018, 06:10:18 PM
Please download one of the three short Post-DF avg sample files from up above.

I also tried locating a log crash report to no avail. Any hints?
I loaded them and I can import them without any problem, as clip and as darkframe. Unfortunately there is no log (only the crash report from OSX with some information about which function crashed) - but if the app crashes, there is mostly a invalid memory problem somewhere...
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on December 29, 2018, 12:41:37 AM
Interesting. Thanks for checking.

Are you running the latest OS X?
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on December 29, 2018, 01:22:34 AM
tried all three Post-DF files on latest mac os 10.14.3 with mlv app 1.4, no crashes
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on December 29, 2018, 09:56:02 AM
I just updated this MBP to 10.14.2 and yet MLV App still crashes when dropping in averaged MLV's.

Here's one of the many logs from OS X Crash Reports...

Process:               MLV App [1316]
Path:                  /Users/USER/Desktop/MLV App.app/Contents/MacOS/MLV App
Identifier:            magiclantern.MLV App
Version:               1.4 (0)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           MLV App [1316]
User ID:               501

Date/Time:             2018-12-29 00:49:56.398 -0800
OS Version:            Mac OS X 10.14.2 (18C54)
Report Version:        12
Anonymous UUID:        C1BB4923-174B-6264-610F-5E9F00942E67


Time Awake Since Boot: 900 seconds

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_ARITHMETIC (SIGFPE)
Exception Codes:       EXC_I386_DIV (divide by zero)
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Floating point exception: 8
Termination Reason:    Namespace SIGNAL, Code 0x8
Terminating Process:   exc handler [1316]

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   magiclantern.MLV App          0x00000001085a49d8 readMlvAudioData + 552
1   magiclantern.MLV App          0x00000001085645fe openMlvClip + 4366
2   magiclantern.MLV App          0x00000001085634d3 initMlvObjectWithClip + 211
3   magiclantern.MLV App          0x000000010851d773 MainWindow::openMlv(QString) + 275
4   magiclantern.MLV App          0x0000000108515947 MainWindow::showFileInEditor(int) + 167
5   magiclantern.MLV App          0x000000010851b08c MainWindow::openMlvSet(QStringList) + 1244
6   magiclantern.MLV App          0x000000010851a557 MainWindow::dropEvent(QDropEvent*) + 1895
7   org.qt-project.QtWidgets      0x000000010cb04054 QWidget::event(QEvent*) + 2596
8   org.qt-project.QtWidgets      0x000000010cc150dc QMainWindow::event(QEvent*) + 1660
9   magiclantern.MLV App          0x0000000108519b72 MainWindow::event(QEvent*) + 1282
10  org.qt-project.QtWidgets      0x000000010cac3edd QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269
11  org.qt-project.QtWidgets      0x000000010cac64d3 QApplication::notify(QObject*, QEvent*) + 5059
12  org.qt-project.QtCore          0x000000010c176aa4 QCoreApplication::notifyInternal2(QObject*, QEvent*) + 164
13  org.qt-project.QtWidgets      0x000000010cb25eb5 0x10cab2000 + 474805
14  org.qt-project.QtWidgets      0x000000010cb23876 0x10cab2000 + 465014
15  org.qt-project.QtWidgets      0x000000010cac3edd QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269
16  org.qt-project.QtWidgets      0x000000010cac6822 QApplication::notify(QObject*, QEvent*) + 5906
17  org.qt-project.QtCore          0x000000010c176aa4 QCoreApplication::notifyInternal2(QObject*, QEvent*) + 164
18  org.qt-project.QtGui          0x000000010c587300 QGuiApplicationPrivate::processDrop(QWindow*, QMimeData const*, QPoint const&, QFlags<Qt::DropAction>) + 96
19  org.qt-project.QtGui          0x000000010c56c403 QWindowSystemInterface::handleDrop(QWindow*, QMimeData const*, QPoint const&, QFlags<Qt::DropAction>) + 211
20  libqcocoa.dylib                0x000000010eedb32d 0x10eeb8000 + 144173
21  com.apple.AppKit              0x00007fff4da9037d NSCoreDragReceiveMessageProc + 733
22  com.apple.HIServices          0x00007fff4e97d02c CallReceiveMessageCollectionWithMessage + 103
23  com.apple.HIServices          0x00007fff4e976a88 DoMultipartDropMessage + 113
24  com.apple.HIServices          0x00007fff4e97686b DoDropMessage + 40
25  com.apple.HIServices          0x00007fff4e97abff CoreDragMessageHandler + 841
26  com.apple.CoreFoundation      0x00007fff5029ab8e __CFMessagePortPerform + 514
27  com.apple.CoreFoundation      0x00007fff501d6adf __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ + 41
28  com.apple.CoreFoundation      0x00007fff501d6a3d __CFRunLoopDoSource1 + 527
29  com.apple.CoreFoundation      0x00007fff501beb22 __CFRunLoopRun + 2585
30  com.apple.CoreFoundation      0x00007fff501bdeb6 CFRunLoopRunSpecific + 467
31  com.apple.HIToolbox            0x00007fff4f447ab5 RunCurrentEventLoopInMode + 293
32  com.apple.HIToolbox            0x00007fff4f4477eb ReceiveNextEventCommon + 618
33  com.apple.HIToolbox            0x00007fff4f447568 _BlockUntilNextEventMatchingListInModeWithFilter + 64
34  com.apple.AppKit              0x00007fff4d702363 _DPSNextEvent + 997
35  com.apple.AppKit              0x00007fff4d701102 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1362
36  com.apple.AppKit              0x00007fff4d6fb165 -[NSApplication run] + 699
37  libqcocoa.dylib                0x000000010eede53f 0x10eeb8000 + 156991
38  org.qt-project.QtCore          0x000000010c172eb1 QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) + 401
39  org.qt-project.QtCore          0x000000010c177115 QCoreApplication::exec() + 341
40  magiclantern.MLV App          0x00000001084f995b main + 107
41  libdyld.dylib                  0x00007fff7d494ed9 start + 1

Thread 1:
0   libsystem_pthread.dylib        0x00007fff7d6873f8 start_wqthread + 0
1   ???                            0x0000000054485244 0 + 1414025796

Thread 2:
0   libsystem_pthread.dylib        0x00007fff7d6873f8 start_wqthread + 0
1   ???                            0x0000000054485244 0 + 1414025796

Thread 3:
0   libsystem_pthread.dylib        0x00007fff7d6873f8 start_wqthread + 0
1   ???                            0x0000000054485244 0 + 1414025796

Thread 4:: RenderFrameThread
0   libsystem_kernel.dylib        0x00007fff7d5d1eae __semwait_signal + 10
1   libsystem_c.dylib              0x00007fff7d55c830 nanosleep + 199
2   org.qt-project.QtCore          0x000000010c068c2b 0x10bf91000 + 883755
3   magiclantern.MLV App          0x000000010859ef32 RenderFrameThread::run() + 50
4   org.qt-project.QtCore          0x000000010bfbab3a 0x10bf91000 + 170810
5   libsystem_pthread.dylib        0x00007fff7d688305 _pthread_body + 126
6   libsystem_pthread.dylib        0x00007fff7d68b26f _pthread_start + 70
7   libsystem_pthread.dylib        0x00007fff7d687415 thread_start + 13

Thread 5:
0   libsystem_kernel.dylib        0x00007fff7d5d17de __psynch_cvwait + 10
1   libsystem_pthread.dylib        0x00007fff7d68b593 _pthread_cond_wait + 724
2   libomp.dylib                  0x000000010bd2b48d __kmp_suspend_64 + 221
3   libomp.dylib                  0x000000010bd15f1f 0x10bcd9000 + 249631
4   libomp.dylib                  0x000000010bd13b21 0x10bcd9000 + 240417
5   libomp.dylib                  0x000000010bd15932 __kmp_fork_barrier(int, int) + 466
6   libomp.dylib                  0x000000010bcfaded __kmp_launch_thread + 605
7   libomp.dylib                  0x000000010bd2a42c 0x10bcd9000 + 332844
8   libsystem_pthread.dylib        0x00007fff7d688305 _pthread_body + 126
9   libsystem_pthread.dylib        0x00007fff7d68b26f _pthread_start + 70
10  libsystem_pthread.dylib        0x00007fff7d687415 thread_start + 13

Thread 6:
0   libsystem_kernel.dylib        0x00007fff7d5d17de __psynch_cvwait + 10
1   libsystem_pthread.dylib        0x00007fff7d68b593 _pthread_cond_wait + 724
2   libomp.dylib                  0x000000010bd2b48d __kmp_suspend_64 + 221
3   libomp.dylib                  0x000000010bd15f1f 0x10bcd9000 + 249631
4   libomp.dylib                  0x000000010bd13b21 0x10bcd9000 + 240417
5   libomp.dylib                  0x000000010bd15932 __kmp_fork_barrier(int, int) + 466
6   libomp.dylib                  0x000000010bcfaded __kmp_launch_thread + 605
7   libomp.dylib                  0x000000010bd2a42c 0x10bcd9000 + 332844
8   libsystem_pthread.dylib        0x00007fff7d688305 _pthread_body + 126
9   libsystem_pthread.dylib        0x00007fff7d68b26f _pthread_start + 70
10  libsystem_pthread.dylib        0x00007fff7d687415 thread_start + 13

Thread 7:
0   libsystem_kernel.dylib        0x00007fff7d5d17de __psynch_cvwait + 10
1   libsystem_pthread.dylib        0x00007fff7d68b593 _pthread_cond_wait + 724
2   libomp.dylib                  0x000000010bd2b48d __kmp_suspend_64 + 221
3   libomp.dylib                  0x000000010bd15f1f 0x10bcd9000 + 249631
4   libomp.dylib                  0x000000010bd13b21 0x10bcd9000 + 240417
5   libomp.dylib                  0x000000010bd15932 __kmp_fork_barrier(int, int) + 466
6   libomp.dylib                  0x000000010bcfaded __kmp_launch_thread + 605
7   libomp.dylib                  0x000000010bd2a42c 0x10bcd9000 + 332844
8   libsystem_pthread.dylib        0x00007fff7d688305 _pthread_body + 126
9   libsystem_pthread.dylib        0x00007fff7d68b26f _pthread_start + 70
10  libsystem_pthread.dylib        0x00007fff7d687415 thread_start + 13

Thread 8:
0   libsystem_kernel.dylib        0x00007fff7d5d17de __psynch_cvwait + 10
1   libsystem_pthread.dylib        0x00007fff7d68b593 _pthread_cond_wait + 724
2   libomp.dylib                  0x000000010bd2b48d __kmp_suspend_64 + 221
3   libomp.dylib                  0x000000010bd15f1f 0x10bcd9000 + 249631
4   libomp.dylib                  0x000000010bd13b21 0x10bcd9000 + 240417
5   libomp.dylib                  0x000000010bd15932 __kmp_fork_barrier(int, int) + 466
6   libomp.dylib                  0x000000010bcfaded __kmp_launch_thread + 605
7   libomp.dylib                  0x000000010bd2a42c 0x10bcd9000 + 332844
8   libsystem_pthread.dylib        0x00007fff7d688305 _pthread_body + 126
9   libsystem_pthread.dylib        0x00007fff7d68b26f _pthread_start + 70
10  libsystem_pthread.dylib        0x00007fff7d687415 thread_start + 13

Thread 9:
0   libsystem_kernel.dylib        0x00007fff7d5d17de __psynch_cvwait + 10
1   libsystem_pthread.dylib        0x00007fff7d68b593 _pthread_cond_wait + 724
2   libomp.dylib                  0x000000010bd2b48d __kmp_suspend_64 + 221
3   libomp.dylib                  0x000000010bd15f1f 0x10bcd9000 + 249631
4   libomp.dylib                  0x000000010bd13b21 0x10bcd9000 + 240417
5   libomp.dylib                  0x000000010bd15932 __kmp_fork_barrier(int, int) + 466
6   libomp.dylib                  0x000000010bcfaded __kmp_launch_thread + 605
7   libomp.dylib                  0x000000010bd2a42c 0x10bcd9000 + 332844
8   libsystem_pthread.dylib        0x00007fff7d688305 _pthread_body + 126
9   libsystem_pthread.dylib        0x00007fff7d68b26f _pthread_start + 70
10  libsystem_pthread.dylib        0x00007fff7d687415 thread_start + 13

Thread 10:
0   libsystem_kernel.dylib        0x00007fff7d5d17de __psynch_cvwait + 10
1   libsystem_pthread.dylib        0x00007fff7d68b593 _pthread_cond_wait + 724
2   libomp.dylib                  0x000000010bd2b48d __kmp_suspend_64 + 221
3   libomp.dylib                  0x000000010bd15f1f 0x10bcd9000 + 249631
4   libomp.dylib                  0x000000010bd13b21 0x10bcd9000 + 240417
5   libomp.dylib                  0x000000010bd15932 __kmp_fork_barrier(int, int) + 466
6   libomp.dylib                  0x000000010bcfaded __kmp_launch_thread + 605
7   libomp.dylib                  0x000000010bd2a42c 0x10bcd9000 + 332844
8   libsystem_pthread.dylib        0x00007fff7d688305 _pthread_body + 126
9   libsystem_pthread.dylib        0x00007fff7d68b26f _pthread_start + 70
10  libsystem_pthread.dylib        0x00007fff7d687415 thread_start + 13

Thread 11:
0   libsystem_kernel.dylib        0x00007fff7d5d17de __psynch_cvwait + 10
1   libsystem_pthread.dylib        0x00007fff7d68b593 _pthread_cond_wait + 724
2   libomp.dylib                  0x000000010bd2b48d __kmp_suspend_64 + 221
3   libomp.dylib                  0x000000010bd15f1f 0x10bcd9000 + 249631
4   libomp.dylib                  0x000000010bd13b21 0x10bcd9000 + 240417
5   libomp.dylib                  0x000000010bd15932 __kmp_fork_barrier(int, int) + 466
6   libomp.dylib                  0x000000010bcfaded __kmp_launch_thread + 605
7   libomp.dylib                  0x000000010bd2a42c 0x10bcd9000 + 332844
8   libsystem_pthread.dylib        0x00007fff7d688305 _pthread_body + 126
9   libsystem_pthread.dylib        0x00007fff7d68b26f _pthread_start + 70
10  libsystem_pthread.dylib        0x00007fff7d687415 thread_start + 13

Thread 12:: com.apple.NSEventThread
0   libsystem_kernel.dylib        0x00007fff7d5ce17a mach_msg_trap + 10
1   libsystem_kernel.dylib        0x00007fff7d5ce6d0 mach_msg + 60
2   com.apple.CoreFoundation      0x00007fff501bf238 __CFRunLoopServiceMachPort + 336
3   com.apple.CoreFoundation      0x00007fff501be786 __CFRunLoopRun + 1661
4   com.apple.CoreFoundation      0x00007fff501bdeb6 CFRunLoopRunSpecific + 467
5   com.apple.AppKit              0x00007fff4d70af89 _NSEventThread + 160
6   libsystem_pthread.dylib        0x00007fff7d688305 _pthread_body + 126
7   libsystem_pthread.dylib        0x00007fff7d68b26f _pthread_start + 70
8   libsystem_pthread.dylib        0x00007fff7d687415 thread_start + 13

Thread 0 crashed with X86 Thread State (64-bit):
  rax: 0x0000000000000000  rbx: 0x0000000000000000  rcx: 0x0000000000000000  rdx: 0x0000000000000000
  rdi: 0x0000600002e68200  rsi: 0x0000000000000000  rbp: 0x00007ffee7708b50  rsp: 0x00007ffee7708b10
   r8: 0x00000000000130a8   r9: 0x0000000000000000  r10: 0x00007fffafff8838  r11: 0x00007fffafff8830
  r12: 0x000000000049d400  r13: 0x000000000000007e  r14: 0x00007ff3dd05d400  r15: 0x00007ff3dd05d400
  rip: 0x00000001085a49d8  rfl: 0x0000000000010246  cr2: 0x00000001085a47b0
 
Logical CPU:     0
Error Code:      0x00000000
Trap Number:     0


Binary Images:
       0x1084f3000 -        0x108a55ff7 +magiclantern.MLV App (1.4 - 0) <F9E00000-DBB3-3144-BC05-9340E002DAD6> /Users/USER/Desktop/MLV App.app/Contents/MacOS/MLV App
       0x10bcd9000 -        0x10bd3eff7 +libomp.dylib (0) <A17F4A5F-2EE2-3B28-83ED-14227926BF89> /Users/USER/Desktop/MLV App.app/Contents/Frameworks/libomp.dylib
       0x10bd69000 -        0x10bdfafe7 +org.qt-project.QtMultimedia (5.7 - 5.7.0) <E9B4404B-21EB-36E4-B06B-99F9794B8A18> /Users/USER/Desktop/MLV App.app/Contents/Frameworks/QtMultimedia.framework/Versions/5/QtMultimedia
       0x10be49000 -        0x10bf4dff7 +org.qt-project.QtNetwork (5.7 - 5.7.0) <B40B02F2-BD1A-3593-831A-6E9C83FA1D61> /Users/USER/Desktop/MLV App.app/Contents/Frameworks/QtNetwork.framework/Versions/5/QtNetwork
       0x10bf91000 -        0x10c4a5ff7 +org.qt-project.QtCore (5.7 - 5.7.0) <5F2F454C-CEE8-3E59-A3B7-94F51F5B9F96> /Users/USER/Desktop/MLV App.app/Contents/Frameworks/QtCore.framework/Versions/5/QtCore
       0x10c55a000 -        0x10c9baff7 +org.qt-project.QtGui (5.7 - 5.7.0) <A41CBDE5-2955-3A57-BAE9-69001B210588> /Users/USER/Desktop/MLV App.app/Contents/Frameworks/QtGui.framework/Versions/5/QtGui
       0x10cab2000 -        0x10cfabff7 +org.qt-project.QtWidgets (5.7 - 5.7.0) <9029D91F-7F7E-3DE0-BD66-FC91DD8112C3> /Users/USER/Desktop/MLV App.app/Contents/Frameworks/QtWidgets.framework/Versions/5/QtWidgets
       0x10d10a000 -        0x10d18fffb +libc++.1.dylib (0) <47AB4341-8348-35D4-BE60-A36F3AB105A8> /Users/USER/Desktop/MLV App.app/Contents/Frameworks/libc++.1.dylib
       0x10d1d2000 -        0x10d1f3fff +libc++abi.1.dylib (0) <5BE55EB1-9F4B-3D57-9F50-737AB2BC61CB> /Users/USER/Desktop/MLV App.app/Contents/Frameworks/libc++abi.1.dylib
       0x10eeb8000 -        0x10f029fff +libqcocoa.dylib (0) <24BD273C-5A40-3322-89BE-D5AC9640FF31> /Users/USER/Desktop/MLV App.app/Contents/PlugIns/platforms/libqcocoa.dylib
       0x10f06d000 -        0x10f0d4ff7 +org.qt-project.QtDBus (5.7 - 5.7.0) <A3B1C34A-7EBC-36D6-B053-9CEE4A3D14CE> /Users/USER/Desktop/MLV App.app/Contents/Frameworks/QtDBus.framework/Versions/5/QtDBus
       0x10f0ec000 -        0x10f11fff7 +org.qt-project.QtPrintSupport (5.7 - 5.7.0) <67BB0DB0-88B2-3802-92D5-7B326C90AFB0> /Users/USER/Desktop/MLV App.app/Contents/Frameworks/QtPrintSupport.framework/Versions/5/QtPrintSupport
       0x111bd9000 -        0x111be3ff7 +libqdds.dylib (0) <C030C6EC-3611-3A8D-894F-071C96FB3031> /Users/USER/Desktop/MLV App.app/Contents/PlugIns/imageformats/libqdds.dylib
       0x111be8000 -        0x111befff7 +libqgif.dylib (0) <551D6575-9920-346E-BE76-3A835199CC08> /Users/USER/Desktop/MLV App.app/Contents/PlugIns/imageformats/libqgif.dylib
       0x111bf3000 -        0x111bfbfff +libqicns.dylib (0) <72F60B35-25FC-3478-A86D-6CC786A508C2> /Users/USER/Desktop/MLV App.app/Contents/PlugIns/imageformats/libqicns.dylib
       0x111c00000 -        0x111c06fff +libqico.dylib (0) <159201A7-AB7A-3174-A3F7-E3954A138C8F> /Users/USER/Desktop/MLV App.app/Contents/PlugIns/imageformats/libqico.dylib
       0x111c0b000 -        0x111c4afff +libqjpeg.dylib (0) <38A4D43B-CDF7-3867-95B6-C51AFCAFB512> /Users/USER/Desktop/MLV App.app/Contents/PlugIns/imageformats/libqjpeg.dylib
       0x111c50000 -        0x111c56fff +libqmacjp2.dylib (0) <B2099559-AF1B-3680-B8FC-D0B08141A8ED> /Users/USER/Desktop/MLV App.app/Contents/PlugIns/imageformats/libqmacjp2.dylib
       0x111c5a000 -        0x111c5eff7 +libqtga.dylib (0) <576CF0ED-6C64-32C7-99BB-6468A1080D9F> /Users/USER/Desktop/MLV App.app/Contents/PlugIns/imageformats/libqtga.dylib
       0x111c62000 -        0x111cc6fff +libqtiff.dylib (0) <F086BC43-2567-3B23-B0FA-D458999803BB> /Users/USER/Desktop/MLV App.app/Contents/PlugIns/imageformats/libqtiff.dylib
       0x111cce000 -        0x111cd2ff7 +libqwbmp.dylib (0) <9F5B0F44-0AF1-300C-88D2-7C2EE2C8F309> /Users/USER/Desktop/MLV App.app/Contents/PlugIns/imageformats/libqwbmp.dylib
       0x111cd6000 -        0x111d50fff +libqwebp.dylib (0) <E401A034-2209-3102-BA10-9E7F67BEA588> /Users/USER/Desktop/MLV App.app/Contents/PlugIns/imageformats/libqwebp.dylib
       0x111f69000 -        0x111f6c047  libobjc-trampolines.dylib (750.1) <1F602C29-B6EE-34B1-BB43-93A592C1F0BC> /usr/lib/libobjc-trampolines.dylib
       0x111fc2000 -        0x112040a67  dyld (640.2) <289AB27E-F09F-3384-A14A-100431139559> /usr/lib/dyld
    0x7fff45e24000 -     0x7fff4619dfff  com.apple.RawCamera.bundle (8.11.0 - 1031.1.3) <15BB3751-9084-381A-8D25-5C60695C292A> /System/Library/CoreServices/RawCamera.bundle/Contents/MacOS/RawCamera
    0x7fff48147000 -     0x7fff481c1fff  com.apple.driver.AppleIntelHD4000GraphicsMTLDriver (12.4.7.1 - 12.0.4) <7D1538A5-DACF-30AA-833B-498FA4BA84C8> /System/Library/Extensions/AppleIntelHD4000GraphicsMTLDriver.bundle/Contents/MacOS/AppleIntelHD4000GraphicsMTLDriver
    0x7fff4bd41000 -     0x7fff4bee7ff7  com.apple.GeForceMTLDriver (12.0.21 - 12.0.0) <22B02636-5B33-3E9E-AC00-D7B4F3DF4481> /System/Library/Extensions/GeForceMTLDriver.bundle/Contents/MacOS/GeForceMTLDriver
    0x7fff4bee8000 -     0x7fff4beecfff  com.apple.agl (3.3.2 - AGL-3.3.2) <1BA0EF39-F658-316F-B6CD-CE4FD1B925D6> /System/Library/Frameworks/AGL.framework/Versions/A/AGL
    0x7fff4beed000 -     0x7fff4c0dbfff  com.apple.avfoundation (2.0 - 1544.5) <BC32B996-F411-3CA0-B9FB-8CEBA2DD356D> /System/Library/Frameworks/AVFoundation.framework/Versions/A/AVFoundation
    0x7fff4c0dc000 -     0x7fff4c1abfff  com.apple.audio.AVFAudio (1.0 - ???) <9C4C64BB-E751-3BB3-B4D0-233ADD48A029> /System/Library/Frameworks/AVFoundation.framework/Versions/A/Frameworks/AVFAudio.framework/Versions/A/AVFAudio
    0x7fff4c2b9000 -     0x7fff4c2b9fff  com.apple.Accelerate (1.11 - Accelerate 1.11) <FC9BE0AB-2371-3ACB-9FD8-A1D439CC4C49> /System/Library/Frameworks/Accelerate.framework/Versions/A/Accelerate
    0x7fff4c2ba000 -     0x7fff4c2d0ff7  libCGInterfaces.dylib (506.19.1) <9E0F6B86-9E59-3EA9-A586-3A3BA7F2F08A> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/Libraries/libCGInterfaces.dylib
    0x7fff4c2d1000 -     0x7fff4cbc5fcf  com.apple.vImage (8.1 - ???) <D6FBBB13-4760-3811-AF3E-F2B6626B70F6> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/vImage
    0x7fff4cbc6000 -     0x7fff4cd71fcf  libBLAS.dylib (1243.200.4) <432DB967-86BB-3645-8838-CE91CBF51CFA> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
    0x7fff4cd72000 -     0x7fff4cdb7fff  libBNNS.dylib (38.200.5) <FE0872E1-B992-369F-BD01-2EABBDD318F1> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBNNS.dylib
    0x7fff4cdb8000 -     0x7fff4d171fff  libLAPACK.dylib (1243.200.4) <670B40E4-AE2F-3311-8ACC-E355F9A36769> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLAPACK.dylib
    0x7fff4d172000 -     0x7fff4d187ffb  libLinearAlgebra.dylib (1243.200.4) <4F53BB84-19EB-3B37-ADD7-553077851007> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLinearAlgebra.dylib
    0x7fff4d188000 -     0x7fff4d18dff3  libQuadrature.dylib (3.200.2) <4FBCAC0A-81A4-3C53-8458-27F3569C809D> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libQuadrature.dylib
    0x7fff4d18e000 -     0x7fff4d20bffb  libSparse.dylib (79.200.5) <2D650C50-E87E-3F24-9BFA-C8EB6DE1A6E9> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libSparse.dylib
    0x7fff4d20c000 -     0x7fff4d21effb  libSparseBLAS.dylib (1243.200.4) <16E0C963-955E-3197-9EE0-256A61DB9D57> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libSparseBLAS.dylib
    0x7fff4d21f000 -     0x7fff4d3bdfdb  libvDSP.dylib (671.220.1) <95AA3236-5D63-35AF-9305-FDC361365110> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvDSP.dylib
    0x7fff4d3be000 -     0x7fff4d535ff3  libvMisc.dylib (671.220.1) <6F0164E4-3812-3F1D-AEBC-AF3AFF207FB6> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvMisc.dylib
    0x7fff4d536000 -     0x7fff4d536fff  com.apple.Accelerate.vecLib (3.11 - vecLib 3.11) <0AB4E69A-8159-3BA5-984D-002B5ACB175C> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/vecLib
    0x7fff4d6e7000 -     0x7fff4e508ffb  com.apple.AppKit (6.9 - 1671.20.108) <0C441020-D10E-3CE0-B320-527E50EADBEC> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
    0x7fff4e55a000 -     0x7fff4e55afff  com.apple.ApplicationServices (50.1 - 50.1) <50496459-FFDD-3A78-8D3D-A252BD9B9DA2> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices
    0x7fff4e55b000 -     0x7fff4e5c6ff7  com.apple.ApplicationServices.ATS (377 - 453.11) <4080F8BE-F2A2-3707-8754-436FBDB1DAF1> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS
    0x7fff4e65f000 -     0x7fff4e77efff  libFontParser.dylib (228.6) <BBCBEE2C-5B55-3278-B81D-22D72466753E> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/Resources/libFontParser.dylib
    0x7fff4e77f000 -     0x7fff4e7cafff  libFontRegistry.dylib (228.12) <1CC4D486-74F8-3459-BBA1-F68A36C5CAF8> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/Resources/libFontRegistry.dylib
    0x7fff4e829000 -     0x7fff4e85cff7  libTrueTypeScaler.dylib (228.6) <760BF895-3D7A-36E2-B97C-6775C3615A1D> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/Resources/libTrueTypeScaler.dylib
    0x7fff4e8c6000 -     0x7fff4e8caff3  com.apple.ColorSyncLegacy (4.13.0 - 1) <4B1238CC-9B77-3AA5-8329-EE3C736F07EA> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy
    0x7fff4e967000 -     0x7fff4e9b9ff3  com.apple.HIServices (1.22 - 627.14.2) <1F851BF9-AD29-3558-9EA5-AAD9BAAAC823> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices
    0x7fff4e9ba000 -     0x7fff4e9c8ff3  com.apple.LangAnalysis (1.7.0 - 1.7.0) <5654723A-7B3B-391F-B9F7-0DE4D5940185> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis
    0x7fff4e9c9000 -     0x7fff4ea15fff  com.apple.print.framework.PrintCore (14.2 - 503.8) <F1246C9A-2216-3390-8DF1-89304F47CE5D> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore
    0x7fff4ea16000 -     0x7fff4ea51ff7  com.apple.QD (3.12 - 407.2) <F6B648DA-DA39-3EB4-B593-1B7E316661CD> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD
    0x7fff4ea52000 -     0x7fff4ea5eff7  com.apple.speech.synthesis.framework (8.1.0 - 8.1.0) <CF19C8B6-AAD5-3DCF-ABD0-3BABB44D119C> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis
    0x7fff4ea5f000 -     0x7fff4ecfcfff  com.apple.audio.toolbox.AudioToolbox (1.14 - 1.14) <5D484151-F269-3D98-B507-0544A6B950AC> /System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox
    0x7fff4ecfe000 -     0x7fff4ecfefff  com.apple.audio.units.AudioUnit (1.14 - 1.14) <91100E0A-C14D-3E6C-B095-0C4109AC6694> /System/Library/Frameworks/AudioUnit.framework/Versions/A/AudioUnit
    0x7fff4f062000 -     0x7fff4f423fff  com.apple.CFNetwork (976 - 976) <10F464AD-6687-3012-A2AA-0453629CA968> /System/Library/Frameworks/CFNetwork.framework/Versions/A/CFNetwork
    0x7fff4f438000 -     0x7fff4f438fff  com.apple.Carbon (158 - 158) <D6170F31-7A8A-3D4F-91DA-E11CF33E62B4> /System/Library/Frameworks/Carbon.framework/Versions/A/Carbon
    0x7fff4f439000 -     0x7fff4f43cffb  com.apple.CommonPanels (1.2.6 - 98) <775C94BE-EC00-315F-96E0-F0C1CD6EE3F4> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels
    0x7fff4f43d000 -     0x7fff4f744ff7  com.apple.HIToolbox (2.1.1 - 917.3) <B2FEF0F3-CBA0-3FD9-93FC-E3A13DCB8C49> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox
    0x7fff4f745000 -     0x7fff4f748ffb  com.apple.help (1.3.8 - 66) <0C6CC127-A860-30D2-8434-6CC3CAFFB030> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help
    0x7fff4f749000 -     0x7fff4f74eff7  com.apple.ImageCapture (9.0 - 1530.1) <72ABBF32-531B-3B04-926D-E14B8D9003A8> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture
    0x7fff4f74f000 -     0x7fff4f7e3ff3  com.apple.ink.framework (10.9 - 225) <344AACCC-E997-3498-8B1D-2EFD3A889205> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink
    0x7fff4f7e4000 -     0x7fff4f7fefff  com.apple.openscripting (1.7 - 179) <A57FC4DB-4C51-3ABB-842F-9578991043E3> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting
    0x7fff4f81f000 -     0x7fff4f820fff  com.apple.print.framework.Print (14.2 - 267.4) <618D290C-2EA0-3959-A2A8-FB7B61DA92DD> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print
    0x7fff4f821000 -     0x7fff4f823ff7  com.apple.securityhi (9.0 - 55006) <2FE1EB07-F717-3E89-9662-8BA7C17C6AEC> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI
    0x7fff4f824000 -     0x7fff4f82aff7  com.apple.speech.recognition.framework (6.0.3 - 6.0.3) <F7E95C56-19E8-30A1-9594-84D4DD89F6D4> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition
    0x7fff4f953000 -     0x7fff4f953fff  com.apple.Cocoa (6.11 - 23) <D0BED932-C061-33E9-9F59-ECE0BA9F7EEB> /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa
    0x7fff4f961000 -     0x7fff4fa2dfff  com.apple.ColorSync (4.13.0 - 3340) <2F45EB01-0C51-3D25-9836-18F99222E1C7> /System/Library/Frameworks/ColorSync.framework/Versions/A/ColorSync
    0x7fff4fbc8000 -     0x7fff4fc58fff  com.apple.audio.CoreAudio (4.3.0 - 4.3.0) <1E7EF105-B843-370D-884E-0A43E1A5800B> /System/Library/Frameworks/CoreAudio.framework/Versions/A/CoreAudio
    0x7fff4fcbe000 -     0x7fff4fce9ff7  com.apple.CoreBluetooth (1.0 - 1) <F041753E-7709-3FA4-ADA3-6B37296D92FB> /System/Library/Frameworks/CoreBluetooth.framework/Versions/A/CoreBluetooth
    0x7fff4fcea000 -     0x7fff50098fff  com.apple.CoreData (120 - 866.1) <FD7900C2-5A00-3560-9F37-6EED4DDFE873> /System/Library/Frameworks/CoreData.framework/Versions/A/CoreData
    0x7fff50099000 -     0x7fff50182ff7  com.apple.CoreDisplay (101.3 - 106.2) <EE0D334B-8B71-3A70-9F90-677171D6762F> /System/Library/Frameworks/CoreDisplay.framework/Versions/A/CoreDisplay
    0x7fff50183000 -     0x7fff505d1ff7  com.apple.CoreFoundation (6.9 - 1561) <11315B67-F976-35E3-92E0-67DCD59B4DB4> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
    0x7fff505d3000 -     0x7fff50c7dff7  com.apple.CoreGraphics (2.0 - 1249.2) <0693AE89-63FC-3AC2-8550-1D9FB612C77E> /System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics
    0x7fff50c7f000 -     0x7fff50fa8fff  com.apple.CoreImage (14.2.0 - 720.0.130) <8C8BC619-7084-3F58-BBFC-4A97BD330787> /System/Library/Frameworks/CoreImage.framework/Versions/A/CoreImage
    0x7fff512f9000 -     0x7fff513faff7  com.apple.CoreMedia (1.0 - 2284.9) <4662B44E-F463-3FC8-A643-2195FF10A3E4> /System/Library/Frameworks/CoreMedia.framework/Versions/A/CoreMedia
    0x7fff513fb000 -     0x7fff5145dfff  com.apple.CoreMediaIO (900.0 - 5025) <7200894C-68E6-396A-90F1-389BB32EAC86> /System/Library/Frameworks/CoreMediaIO.framework/Versions/A/CoreMediaIO
    0x7fff5145e000 -     0x7fff5145efff  com.apple.CoreServices (941 - 941) <950D3EAF-C98E-3BCB-8FD9-43EEA0E48988> /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices
    0x7fff5145f000 -     0x7fff514ddffb  com.apple.AE (771 - 771) <4B009524-699E-3891-98DD-E3B6BB433C8F> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE
    0x7fff514de000 -     0x7fff517b6ff7  com.apple.CoreServices.CarbonCore (1178.16 - 1178.16) <17FC2B9E-EB6C-3768-A2D0-6E086F2563D9> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore
    0x7fff517b7000 -     0x7fff51801ff7  com.apple.DictionaryServices (1.2 - 284.16.3) <1DAC9153-FB5A-3798-8797-CBFEFF227F71> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices
    0x7fff51802000 -     0x7fff5180affb  com.apple.CoreServices.FSEvents (1239.200.12 - 1239.200.12) <8E1507EA-F0A8-3845-B32D-4FBC1381E89C> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents
    0x7fff5180b000 -     0x7fff519d6fff  com.apple.LaunchServices (941 - 941) <98B7E20E-5D0A-3A71-A019-346A145A1A5E> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices
    0x7fff519d7000 -     0x7fff51a79fff  com.apple.Metadata (10.7.0 - 1191.53) <E4C1B7AB-677B-32B2-918C-CD445A0D0D91> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata
    0x7fff51a7a000 -     0x7fff51ac5ff7  com.apple.CoreServices.OSServices (941 - 941) <DFA21754-BFE4-367C-9303-739F5D3E9DDE> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices
    0x7fff51ac6000 -     0x7fff51b34ff7  com.apple.SearchKit (1.4.0 - 1.4.0) <CEC29BB5-D28E-3424-84FE-70756E521F3B> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit
    0x7fff51b35000 -     0x7fff51b59ffb  com.apple.coreservices.SharedFileList (71.27 - 71.27) <6389B59D-DDAC-3C97-A982-137B9B1FB734> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList
    0x7fff51ea1000 -     0x7fff52006ffb  com.apple.CoreText (352.0 - 584.26) <5F61037C-825D-37A4-9091-0047413CC213> /System/Library/Frameworks/CoreText.framework/Versions/A/CoreText
    0x7fff52007000 -     0x7fff52044fff  com.apple.CoreVideo (1.8 - 0.0) <34EC73F1-F0ED-32F5-B96E-7683B1F9A7A2> /System/Library/Frameworks/CoreVideo.framework/Versions/A/CoreVideo
    0x7fff52045000 -     0x7fff520dbffb  com.apple.framework.CoreWLAN (13.0 - 1370.8) <32426190-3455-3049-8C09-0EC04D9C1279> /System/Library/Frameworks/CoreWLAN.framework/Versions/A/CoreWLAN
    0x7fff52358000 -     0x7fff5235dfff  com.apple.DiskArbitration (2.7 - 2.7) <97707A79-30E7-3D99-AA20-B992B0900BC4> /System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration
    0x7fff52526000 -     0x7fff528f4fff  com.apple.Foundation (6.9 - 1561) <27FD022F-F0E3-3053-BADA-DF9BF856CA85> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
    0x7fff52965000 -     0x7fff52995ff3  com.apple.GSS (4.0 - 2.0) <86D07291-5DFC-30C2-9A18-5FCEDB0BE621> /System/Library/Frameworks/GSS.framework/Versions/A/GSS
    0x7fff52aaf000 -     0x7fff52bb9ff3  com.apple.Bluetooth (6.0.9 - 6.0.9f2) <CD9FA230-8BBB-307C-8FFF-86B1B7078D05> /System/Library/Frameworks/IOBluetooth.framework/Versions/A/IOBluetooth
    0x7fff52c1b000 -     0x7fff52cadff7  com.apple.framework.IOKit (2.0.2 - 1483.230.1) <AAAF13D1-80E5-3079-98C1-FA3C3FC47B40> /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit
    0x7fff52caf000 -     0x7fff52cb9ff7  com.apple.IOSurface (255.1 - 255.1) <58826B1A-38E8-3C76-8FFC-76C9282DA893> /System/Library/Frameworks/IOSurface.framework/Versions/A/IOSurface
    0x7fff52d10000 -     0x7fff52eb1ff7  com.apple.ImageIO.framework (3.3.0 - 1822.1) <1451559D-4224-3F53-A976-16CF186DDE80> /System/Library/Frameworks/ImageIO.framework/Versions/A/ImageIO
    0x7fff52eb2000 -     0x7fff52eb6ffb  libGIF.dylib (1822.1) <9084A1A9-0AB3-314E-B76F-6642EAFD367A> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libGIF.dylib
    0x7fff52eb7000 -     0x7fff52f9cff7  libJP2.dylib (1822.1) <8138A169-983C-3ACF-B05C-81317D8A3792> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libJP2.dylib
    0x7fff52f9d000 -     0x7fff52fc2ffb  libJPEG.dylib (1822.1) <54E1BA95-B7C7-3078-921D-909B8EB33A84> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libJPEG.dylib
    0x7fff53296000 -     0x7fff532bcff3  libPng.dylib (1822.1) <5AFB0813-562F-3DB9-A4AD-A6FCABA63A2D> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib
    0x7fff532bd000 -     0x7fff532bfff7  libRadiance.dylib (1822.1) <8CAA370A-A46C-3EA1-8338-F42AD183C19C> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libRadiance.dylib
    0x7fff532c0000 -     0x7fff5330dffb  libTIFF.dylib (1822.1) <4748924B-8F25-30A9-95BF-0A106E908B36> /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libTIFF.dylib
    0x7fff543b7000 -     0x7fff543d0fff  com.apple.Kerberos (3.0 - 1) <5D1B0593-3C0E-32D5-AAE5-ABC22A98B639> /System/Library/Frameworks/Kerberos.framework/Versions/A/Kerberos
    0x7fff5468e000 -     0x7fff54698fff  com.apple.MediaAccessibility (1.0 - 114.4) <C0584BAA-27BC-30F4-8B0C-5043559995AA> /System/Library/Frameworks/MediaAccessibility.framework/Versions/A/MediaAccessibility
    0x7fff54752000 -     0x7fff54df0fff  com.apple.MediaToolbox (1.0 - 2284.9) <AD1C6882-F6FC-3114-9517-CCF9402A30B1> /System/Library/Frameworks/MediaToolbox.framework/Versions/A/MediaToolbox
    0x7fff54df2000 -     0x7fff54e85fff  com.apple.Metal (158.5 - 158.5) <219312CC-0DE5-3E8D-9F62-393D0C35B0FD> /System/Library/Frameworks/Metal.framework/Versions/A/Metal
    0x7fff54ea2000 -     0x7fff54ec2ff7  com.apple.MetalPerformanceShaders.MPSCore (1.0 - 1) <18281B14-0C6A-38F8-AB80-2D4BB0743C88> /System/Library/Frameworks/MetalPerformanceShaders.framework/Frameworks/MPSCore.framework/Versions/A/MPSCore
    0x7fff54ec3000 -     0x7fff54f41ff7  com.apple.MetalPerformanceShaders.MPSImage (1.0 - 1) <BEAF764B-362B-3C45-86F5-2AFBA5FA0F47> /System/Library/Frameworks/MetalPerformanceShaders.framework/Frameworks/MPSImage.framework/Versions/A/MPSImage
    0x7fff54f42000 -     0x7fff54f6afff  com.apple.MetalPerformanceShaders.MPSMatrix (1.0 - 1) <116D6C1A-2FD7-3743-95A0-CDDA3D459529> /System/Library/Frameworks/MetalPerformanceShaders.framework/Frameworks/MPSMatrix.framework/Versions/A/MPSMatrix
    0x7fff54f6b000 -     0x7fff5509dff7  com.apple.MetalPerformanceShaders.MPSNeuralNetwork (1.0 - 1) <88E80BEE-3D2B-328B-80D4-F4717BDB2E9F> /System/Library/Frameworks/MetalPerformanceShaders.framework/Frameworks/MPSNeuralNetwork.framework/Versions/A/MPSNeuralNetwork
    0x7fff5509e000 -     0x7fff550b9ff7  com.apple.MetalPerformanceShaders.MPSRayIntersector (1.0 - 1) <E0E652B0-1624-3435-AD60-83A9C4B59852> /System/Library/Frameworks/MetalPerformanceShaders.framework/Frameworks/MPSRayIntersector.framework/Versions/A/MPSRayIntersector
    0x7fff550ba000 -     0x7fff550baff7  com.apple.MetalPerformanceShaders.MetalPerformanceShaders (1.0 - 1) <1BBA8BC8-49C6-3C9B-B985-7CE4373E3553> /System/Library/Frameworks/MetalPerformanceShaders.framework/Versions/A/MetalPerformanceShaders
    0x7fff562b7000 -     0x7fff562c3ffb  com.apple.NetFS (6.0 - 4.0) <918DF6CD-2DB0-36A8-B869-5EF637A06C0D> /System/Library/Frameworks/NetFS.framework/Versions/A/NetFS
    0x7fff58d83000 -     0x7fff58ddbfff  com.apple.opencl (2.15.1 - 2.15.1) <E628D178-3846-373A-9482-CF680BD1E240> /System/Library/Frameworks/OpenCL.framework/Versions/A/OpenCL
    0x7fff58ddc000 -     0x7fff58df8ff7  com.apple.CFOpenDirectory (10.14 - 207.200.4) <2CB1F122-2FA0-347C-8454-9CE0FA150832> /System/Library/Frameworks/OpenDirectory.framework/Versions/A/Frameworks/CFOpenDirectory.framework/Versions/A/CFOpenDirectory
    0x7fff58df9000 -     0x7fff58e05ffb  com.apple.OpenDirectory (10.14 - 207.200.4) <A3FB0F0C-57F4-3F89-A4B1-63DA1F7C9E8E> /System/Library/Frameworks/OpenDirectory.framework/Versions/A/OpenDirectory
    0x7fff59768000 -     0x7fff5976afff  libCVMSPluginSupport.dylib (17.3.1) <4D6061EC-CFCD-3C0E-90E4-51644DC5F76A> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libCVMSPluginSupport.dylib
    0x7fff5976b000 -     0x7fff59770ff3  libCoreFSCache.dylib (163.20) <566DB80E-F1D6-3AEC-AF06-08955507AFEE> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libCoreFSCache.dylib
    0x7fff59771000 -     0x7fff59775fff  libCoreVMClient.dylib (163.20) <B9A89373-BDCD-3003-9A82-6D73B930A122> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libCoreVMClient.dylib
    0x7fff59776000 -     0x7fff5977effb  libGFXShared.dylib (17.3.1) <902F535E-E411-3C3B-B980-0A7DB40EA5B7> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGFXShared.dylib
    0x7fff5977f000 -     0x7fff5978afff  libGL.dylib (17.3.1) <87F8CCDB-2D7D-3B01-AA6F-6C7A4B1CA11E> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib
    0x7fff5978b000 -     0x7fff597c5fef  libGLImage.dylib (17.3.1) <B5464F1A-B936-3BEE-97CF-3806AD1A9E68> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLImage.dylib
    0x7fff59939000 -     0x7fff59976fff  libGLU.dylib (17.3.1) <C46D4335-4CE2-3FFB-930D-E48D7A3B5B4F> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib
    0x7fff5a326000 -     0x7fff5a335ff3  com.apple.opengl (17.3.1 - 17.3.1) <78BDC7C4-87AD-33CA-BFAC-A9CC5F605B5D> /System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL
    0x7fff5b191000 -     0x7fff5b3eafff  com.apple.QuartzCore (1.11 - 695.4) <6692906D-9EF7-3EA0-96D3-3766567AE7F2> /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore
    0x7fff5bc3e000 -     0x7fff5bf66fff  com.apple.security (7.0 - 58286.230.21) <5ADE179E-87D5-3B90-9172-D183D4665037> /System/Library/Frameworks/Security.framework/Versions/A/Security
    0x7fff5bf67000 -     0x7fff5bff6fff  com.apple.securityfoundation (6.0 - 55185.200.14) <A57F481C-73B9-33C4-9093-9A06DBBFEDE5> /System/Library/Frameworks/SecurityFoundation.framework/Versions/A/SecurityFoundation
    0x7fff5c028000 -     0x7fff5c02cff3  com.apple.xpc.ServiceManagement (1.0 - 1) <16FA4DAF-A0BE-34C0-B5F1-5C30BE3DCD2D> /System/Library/Frameworks/ServiceManagement.framework/Versions/A/ServiceManagement
    0x7fff5c3e9000 -     0x7fff5c459ff3  com.apple.SystemConfiguration (1.17 - 1.17) <A8FD596E-C858-397F-836C-978038B97AC0> /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration
    0x7fff5c6ba000 -     0x7fff5ca1cfff  com.apple.VideoToolbox (1.0 - 2284.9) <695514F0-08C8-3065-B9A2-DA3B43E6682F> /System/Library/Frameworks/VideoToolbox.framework/Versions/A/VideoToolbox
    0x7fff5f6c4000 -     0x7fff5f769ff7  com.apple.APFS (1.0 - 1) <5CA4B73F-3F5D-3289-9145-520FFDFD6813> /System/Library/PrivateFrameworks/APFS.framework/Versions/A/APFS
    0x7fff601b3000 -     0x7fff601b4ff3  com.apple.AggregateDictionary (1.0 - 1) <EBA6443E-6CF0-34F6-B77A-3FCEC57F8F80> /System/Library/PrivateFrameworks/AggregateDictionary.framework/Versions/A/AggregateDictionary
    0x7fff607b1000 -     0x7fff607ddff7  com.apple.framework.Apple80211 (13.0 - 1376.2) <A71EADCB-7582-3D1B-9122-356F03E11594> /System/Library/PrivateFrameworks/Apple80211.framework/Versions/A/Apple80211
    0x7fff60ab9000 -     0x7fff60ac8fcf  com.apple.AppleFSCompression (96.200.3 - 1.0) <78D538DD-1D24-34FC-AFB3-10411494870D> /System/Library/PrivateFrameworks/AppleFSCompression.framework/Versions/A/AppleFSCompression
    0x7fff60bc6000 -     0x7fff60bd1fff  com.apple.AppleIDAuthSupport (1.0 - 1) <E41452B2-3AFB-3493-BB82-0CE6D04DF424> /System/Library/PrivateFrameworks/AppleIDAuthSupport.framework/Versions/A/AppleIDAuthSupport
    0x7fff60c12000 -     0x7fff60c5bff3  com.apple.AppleJPEG (1.0 - 1) <EC4C49F1-C060-3C0F-910F-3620985D4F12> /System/Library/PrivateFrameworks/AppleJPEG.framework/Versions/A/AppleJPEG
    0x7fff60eae000 -     0x7fff60ed6ff7  com.apple.applesauce (1.0 - ???) <58654BC0-9243-39D1-BC43-B7F2E37A3A44> /System/Library/PrivateFrameworks/AppleSauce.framework/Versions/A/AppleSauce
    0x7fff60fa1000 -     0x7fff60ff1fff  com.apple.AppleVAFramework (5.0.44 - 5.0.44) <0338350C-F366-3C0D-B7C1-6E8FFAB92E98> /System/Library/PrivateFrameworks/AppleVA.framework/Versions/A/AppleVA
    0x7fff6103c000 -     0x7fff61052ffb  com.apple.AssertionServices (1.0 - 1) <3F767D20-FE14-35CF-A089-E0445375ECFB> /System/Library/PrivateFrameworks/AssertionServices.framework/Versions/A/AssertionServices
    0x7fff6138e000 -     0x7fff61631ff7  com.apple.AuthKit (1.0 - 1) <4FF8DA76-2250-39B9-B6A9-0E584C8B988F> /System/Library/PrivateFrameworks/AuthKit.framework/Versions/A/AuthKit
    0x7fff61802000 -     0x7fff6180bff3  com.apple.coreservices.BackgroundTaskManagement (1.0 - 57.1) <05CF66F0-9650-3F75-9857-F8D186043866> /System/Library/PrivateFrameworks/BackgroundTaskManagement.framework/Versions/A/BackgroundTaskManagement
    0x7fff6180c000 -     0x7fff618aefff  com.apple.backup.framework (1.10.2 - ???) <7C865F13-12F9-3E38-A4A3-31516EA869B2> /System/Library/PrivateFrameworks/Backup.framework/Versions/A/Backup
    0x7fff618af000 -     0x7fff61920ffb  com.apple.BaseBoard (360.24 - 360.24) <04AF4372-C5D3-3F0A-A688-68D888D6D138> /System/Library/PrivateFrameworks/BaseBoard.framework/Versions/A/BaseBoard
    0x7fff634d4000 -     0x7fff634ddfff  com.apple.CommonAuth (4.0 - 2.0) <090893E5-BB65-39DA-A174-EAB2C7191EFE> /System/Library/PrivateFrameworks/CommonAuth.framework/Versions/A/CommonAuth
    0x7fff6399b000 -     0x7fff63d72fef  com.apple.CoreAUC (273.0.0 - 273.0.0) <FE2B4D86-2C83-3FE2-A427-54DA2170E980> /System/Library/PrivateFrameworks/CoreAUC.framework/Versions/A/CoreAUC
    0x7fff63d73000 -     0x7fff63da4fff  com.apple.CoreAVCHD (6.0.0 - 6000.4.1) <B15A24E4-2A92-3FD7-8F20-C372E4115FA7> /System/Library/PrivateFrameworks/CoreAVCHD.framework/Versions/A/CoreAVCHD
    0x7fff641ed000 -     0x7fff64201fff  com.apple.CoreEmoji (1.0 - 69.19.8) <26BC0F82-08C1-3EBD-9299-D3CC5091C467> /System/Library/PrivateFrameworks/CoreEmoji.framework/Versions/A/CoreEmoji
    0x7fff647d7000 -     0x7fff64849ff7  com.apple.CoreNLP (1.0 - 130.15.22) <D0A3E880-CDEA-360A-9838-220D76BAECC6> /System/Library/PrivateFrameworks/CoreNLP.framework/Versions/A/CoreNLP
    0x7fff64b12000 -     0x7fff64b1affb  com.apple.CorePhoneNumbers (1.0 - 1) <2D9AF545-ED3C-3EC1-887F-86922652EC57> /System/Library/PrivateFrameworks/CorePhoneNumbers.framework/Versions/A/CorePhoneNumbers
    0x7fff64ca9000 -     0x7fff64cdafff  com.apple.CoreServicesInternal (357 - 357) <789E57F4-5A14-3220-93DF-1D4FEE315431> /System/Library/PrivateFrameworks/CoreServicesInternal.framework/Versions/A/CoreServicesInternal
    0x7fff650af000 -     0x7fff6513dff7  com.apple.CoreSymbolication (10.1 - 64460.6) <133D09A5-39F7-301D-B019-B6685B80A2CB> /System/Library/PrivateFrameworks/CoreSymbolication.framework/Versions/A/CoreSymbolication
    0x7fff651cd000 -     0x7fff652f9fff  com.apple.coreui (2.1 - 498.46) <5EFE2CDC-897C-3A6B-A60B-4E0FB1D1ECA9> /System/Library/PrivateFrameworks/CoreUI.framework/Versions/A/CoreUI
    0x7fff652fa000 -     0x7fff6547ffff  com.apple.CoreUtils (5.7.4 - 574.17) <DEF9C8A6-DDF1-37F4-A7F0-7DFAA95E8451> /System/Library/PrivateFrameworks/CoreUtils.framework/Versions/A/CoreUtils
    0x7fff654d6000 -     0x7fff65539ffb  com.apple.framework.CoreWiFi (13.0 - 1370.8) <818F8915-BA51-3145-9C40-C9B8D7BE2DBD> /System/Library/PrivateFrameworks/CoreWiFi.framework/Versions/A/CoreWiFi
    0x7fff6553a000 -     0x7fff6554bffb  com.apple.CrashReporterSupport (10.13 - 938.23) <D8D105F5-B6FB-3E91-A116-7CD92171E5C5> /System/Library/PrivateFrameworks/CrashReporterSupport.framework/Versions/A/CrashReporterSupport
    0x7fff655ce000 -     0x7fff655ddff3  com.apple.framework.DFRFoundation (1.0 - 211) <B72944ED-E4E8-3479-B832-8D50C4E30386> /System/Library/PrivateFrameworks/DFRFoundation.framework/Versions/A/DFRFoundation
    0x7fff655de000 -     0x7fff655e2ff7  com.apple.DSExternalDisplay (3.1 - 380) <76449D22-BA27-3FB1-AD25-A290936E6DEA> /System/Library/PrivateFrameworks/DSExternalDisplay.framework/Versions/A/DSExternalDisplay
    0x7fff65665000 -     0x7fff656dcffb  com.apple.datadetectorscore (7.0 - 590.24) <3A49EC90-2081-3031-8CAE-3A6D5F7BFA1E> /System/Library/PrivateFrameworks/DataDetectorsCore.framework/Versions/A/DataDetectorsCore
    0x7fff6572a000 -     0x7fff6576bfff  com.apple.DebugSymbols (185 - 185) <64F5F9D6-401D-388B-82AD-A48B56413556> /System/Library/PrivateFrameworks/DebugSymbols.framework/Versions/A/DebugSymbols
    0x7fff6576c000 -     0x7fff658c5ff7  com.apple.desktopservices (1.13.1 - ???) <AD61A660-0218-327E-8963-A1A170EC2C20> /System/Library/PrivateFrameworks/DesktopServicesPriv.framework/Versions/A/DesktopServicesPriv
    0x7fff66907000 -     0x7fff66d2ffff  com.apple.vision.FaceCore (3.3.4 - 3.3.4) <41218EB7-19C9-3813-A793-B0623387CADF> /System/Library/PrivateFrameworks/FaceCore.framework/Versions/A/FaceCore
    0x7fff6a651000 -     0x7fff6a652fff  libmetal_timestamp.dylib (902.2.2) <55E0B1F2-94F0-3A77-9DB3-152F44848DA5> /System/Library/PrivateFrameworks/GPUCompiler.framework/Versions/3902/Libraries/libmetal_timestamp.dylib
    0x7fff6bcfc000 -     0x7fff6bd01ff7  com.apple.GPUWrangler (3.28.4 - 3.28.4) <14D6FE7D-38D7-3F6C-9BCE-A228D6697A08> /System/Library/PrivateFrameworks/GPUWrangler.framework/Versions/A/GPUWrangler
    0x7fff6cb6b000 -     0x7fff6cb7afff  com.apple.GraphVisualizer (1.0 - 5) <CAFE626E-9738-3C14-88AA-B6A9182F2C39> /System/Library/PrivateFrameworks/GraphVisualizer.framework/Versions/A/GraphVisualizer
    0x7fff6cccb000 -     0x7fff6cd40fff  com.apple.Heimdal (4.0 - 2.0) <D99FF31F-6310-3D80-8AE3-64934385AC11> /System/Library/PrivateFrameworks/Heimdal.framework/Versions/A/Heimdal
    0x7fff6e130000 -     0x7fff6e137ffb  com.apple.IOAccelerator (404.2.2 - 404.2.2) <7421825E-13D4-3C74-932D-34E8A605C281> /System/Library/PrivateFrameworks/IOAccelerator.framework/Versions/A/IOAccelerator
    0x7fff6e13b000 -     0x7fff6e154fff  com.apple.IOPresentment (1.0 - 42.6) <87D19032-52DB-34A5-A554-23B3464EFC82> /System/Library/PrivateFrameworks/IOPresentment.framework/Versions/A/IOPresentment
    0x7fff6e569000 -     0x7fff6e598ff7  com.apple.IconServices (379 - 379) <694E17A6-471B-3C57-92D6-ECC4295FB859> /System/Library/PrivateFrameworks/IconServices.framework/Versions/A/IconServices
    0x7fff6e6c4000 -     0x7fff6e6c8fff  com.apple.InternationalSupport (1.0 - 10.15.6) <D319CB1C-5339-30EB-93EA-3CFB328BEC9A> /System/Library/PrivateFrameworks/InternationalSupport.framework/Versions/A/InternationalSupport
    0x7fff6e838000 -     0x7fff6e84bfff  com.apple.security.KeychainCircle.KeychainCircle (1.0 - 1) <02ECB210-513F-3BDE-8150-A828E901FA02> /System/Library/PrivateFrameworks/KeychainCircle.framework/Versions/A/KeychainCircle
    0x7fff6e866000 -     0x7fff6e95dfff  com.apple.LanguageModeling (1.0 - 159.15.15) <34609F31-4DA1-3881-8947-85BEA7AFC938> /System/Library/PrivateFrameworks/LanguageModeling.framework/Versions/A/LanguageModeling
    0x7fff6e95e000 -     0x7fff6e99fff7  com.apple.Lexicon-framework (1.0 - 33.15.10) <07E008F3-E823-333B-8B41-A46024AB0561> /System/Library/PrivateFrameworks/Lexicon.framework/Versions/A/Lexicon
    0x7fff6e9a6000 -     0x7fff6e9acff7  com.apple.LinguisticData (1.0 - 238.23.4) <37948616-56E6-3758-BEFE-28586FF99E12> /System/Library/PrivateFrameworks/LinguisticData.framework/Versions/A/LinguisticData
    0x7fff6f20b000 -     0x7fff6f20efff  com.apple.Mangrove (1.0 - 25) <8DF73279-BCEB-38CE-AE83-571C1B3FF45B> /System/Library/PrivateFrameworks/Mangrove.framework/Versions/A/Mangrove
    0x7fff6f709000 -     0x7fff6f731ffb  com.apple.spotlight.metadata.utilities (1.0 - 1191.53) <09C6DCF6-F87D-3D03-8BD5-FD1DCF90949F> /System/Library/PrivateFrameworks/MetadataUtilities.framework/Versions/A/MetadataUtilities
    0x7fff6f732000 -     0x7fff6f7c4fff  com.apple.gpusw.MetalTools (1.0 - 1) <B77258A5-909F-37F7-8F1A-2085F7916DD4> /System/Library/PrivateFrameworks/MetalTools.framework/Versions/A/MetalTools
    0x7fff6f7d9000 -     0x7fff6f7f2fff  com.apple.MobileAssets (1.0 - 437.230.2) <73BF5743-F050-3393-AECE-298ADF3960F4> /System/Library/PrivateFrameworks/MobileAsset.framework/Versions/A/MobileAsset
    0x7fff6f96f000 -     0x7fff6f98aff3  com.apple.MobileKeyBag (2.0 - 1.0) <26347762-AF60-3412-A951-33BF85244D84> /System/Library/PrivateFrameworks/MobileKeyBag.framework/Versions/A/MobileKeyBag
    0x7fff6fa18000 -     0x7fff6fa42ff7  com.apple.MultitouchSupport.framework (2410.5 - 2410.5) <3A712911-F672-3BB3-B62B-A2A7BADF3578> /System/Library/PrivateFrameworks/MultitouchSupport.framework/Versions/A/MultitouchSupport
    0x7fff6fcb5000 -     0x7fff6fcbffff  com.apple.NetAuth (6.2 - 6.2) <E191D736-A442-31BA-B823-EE75DC316D22> /System/Library/PrivateFrameworks/NetAuth.framework/Versions/A/NetAuth
    0x7fff7058c000 -     0x7fff705e2fff  com.apple.OTSVG (1.0 - ???) <F020144A-D840-390D-A87F-29E8095C78AF> /System/Library/PrivateFrameworks/OTSVG.framework/Versions/A/OTSVG
    0x7fff7174d000 -     0x7fff7175cff3  com.apple.PerformanceAnalysis (1.217 - 217) <AA34989F-7E01-303E-8134-5BB37CE82DDF> /System/Library/PrivateFrameworks/PerformanceAnalysis.framework/Versions/A/PerformanceAnalysis
    0x7fff7371b000 -     0x7fff73739ff7  com.apple.ProtocolBuffer (1 - 263.1) <D70A1E3D-D2F7-3765-861C-173F5BBC848B> /System/Library/PrivateFrameworks/ProtocolBuffer.framework/Versions/A/ProtocolBuffer
    0x7fff738e8000 -     0x7fff73940f0f  com.apple.ROCKit (24 - 24) <FA6B086A-1841-3A5E-800B-CE7A52C3DAF1> /System/Library/PrivateFrameworks/ROCKit.framework/Versions/A/ROCKit
    0x7fff73a41000 -     0x7fff73a4dff3  com.apple.xpc.RemoteServiceDiscovery (1.0 - 1336.220.5) <096B06A9-2C3F-3515-8241-5292B0658984> /System/Library/PrivateFrameworks/RemoteServiceDiscovery.framework/Versions/A/RemoteServiceDiscovery
    0x7fff73a60000 -     0x7fff73a83ffb  com.apple.RemoteViewServices (2.0 - 128) <55D89BC9-0613-3910-B63E-9A146D35D91A> /System/Library/PrivateFrameworks/RemoteViewServices.framework/Versions/A/RemoteViewServices
    0x7fff73a84000 -     0x7fff73a98fff  com.apple.xpc.RemoteXPC (1.0 - 1336.220.5) <208540F3-3FEC-32EE-B010-B73CE4A3609A> /System/Library/PrivateFrameworks/RemoteXPC.framework/Versions/A/RemoteXPC
    0x7fff753f8000 -     0x7fff75516fff  com.apple.Sharing (1214.18 - 1214.18) <E6302F6F-2940-3DDB-ADA7-EE123DD6D027> /System/Library/PrivateFrameworks/Sharing.framework/Versions/A/Sharing
    0x7fff762d0000 -     0x7fff76582ff3  com.apple.SkyLight (1.600.0 - 337.5) <52BC8AB1-3518-3E4C-B1B1-0A8A8067574F> /System/Library/PrivateFrameworks/SkyLight.framework/Versions/A/SkyLight
    0x7fff76d53000 -     0x7fff76d60fff  com.apple.SpeechRecognitionCore (5.0.21 - 5.0.21) <FABB97BC-9555-33FE-B6C5-606CC403CE16> /System/Library/PrivateFrameworks/SpeechRecognitionCore.framework/Versions/A/SpeechRecognitionCore
    0x7fff77445000 -     0x7fff77484ff3  com.apple.StreamingZip (1.0 - 1) <251128E7-C343-3799-A31B-8B10CEC69F19> /System/Library/PrivateFrameworks/StreamingZip.framework/Versions/A/StreamingZip
    0x7fff77bc1000 -     0x7fff77c4eff7  com.apple.Symbolication (10.1 - 64460.8) <7DDC5C90-947F-34FF-864D-5ED3C2B746A9> /System/Library/PrivateFrameworks/Symbolication.framework/Versions/A/Symbolication
    0x7fff78157000 -     0x7fff78164ffb  com.apple.TCC (1.0 - 1) <81F88B91-49C1-36E7-8A39-C4BD654EE942> /System/Library/PrivateFrameworks/TCC.framework/Versions/A/TCC
    0x7fff783d7000 -     0x7fff7849eff7  com.apple.TextureIO (3.8.4 - 3.8.1) <83CDF659-E5B3-381F-BDA1-FF0BFA17B5EE> /System/Library/PrivateFrameworks/TextureIO.framework/Versions/A/TextureIO
    0x7fff7855f000 -     0x7fff78719fff  com.apple.UIFoundation (1.0 - 551) <65A80450-7A24-3366-B521-4D02C4DB5094> /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation
    0x7fff79408000 -     0x7fff794f1ff7  com.apple.ViewBridge (401.1 - 401.1) <E76BC854-5B08-3FFF-AA2C-9679754FCAF0> /System/Library/PrivateFrameworks/ViewBridge.framework/Versions/A/ViewBridge
    0x7fff79d17000 -     0x7fff79d1afff  com.apple.dt.XCTTargetBootstrap (1.0 - 1) <5F779D77-4AB1-3CCD-9AAF-101EC7E4905B> /System/Library/PrivateFrameworks/XCTTargetBootstrap.framework/Versions/A/XCTTargetBootstrap
    0x7fff7a14b000 -     0x7fff7a14dff3  com.apple.loginsupport (1.0 - 1) <67BC49D6-320F-33ED-912E-16E5A342F385> /System/Library/PrivateFrameworks/login.framework/Versions/A/Frameworks/loginsupport.framework/Versions/A/loginsupport
    0x7fff7a408000 -     0x7fff7a440fff  libCRFSuite.dylib (41.15.4) <92752A96-D1CF-3CA1-837A-1E075AE4C642> /usr/lib/libCRFSuite.dylib
    0x7fff7a443000 -     0x7fff7a44eff7  libChineseTokenizer.dylib (28.15.3) <55572692-4918-3C54-AD35-726E03EC47D5> /usr/lib/libChineseTokenizer.dylib
    0x7fff7a4df000 -     0x7fff7a4e0ff7  libDiagnosticMessagesClient.dylib (107) <15210AC0-61F9-3F9D-A159-A009F62EB537> /usr/lib/libDiagnosticMessagesClient.dylib
    0x7fff7a517000 -     0x7fff7a6daff7  libFosl_dynamic.dylib (18.3.2) <D67B74E9-EB95-38BC-995C-5F4CC044C3F7> /usr/lib/libFosl_dynamic.dylib
    0x7fff7a730000 -     0x7fff7a74fff7  libMobileGestalt.dylib (645.220.9) <C2C55511-993B-34D2-9040-902BFDA38141> /usr/lib/libMobileGestalt.dylib
    0x7fff7a750000 -     0x7fff7a750fff  libOpenScriptingUtil.dylib (179) <441A2E60-5D5C-3567-9B00-AA22E6EE5358> /usr/lib/libOpenScriptingUtil.dylib
    0x7fff7a891000 -     0x7fff7a892ffb  libSystem.B.dylib (1252.200.5) <25F4A1F5-6551-312F-B397-C8D45ACC530A> /usr/lib/libSystem.B.dylib
    0x7fff7a91c000 -     0x7fff7a91dfff  libThaiTokenizer.dylib (2.15.1) <F09EB0BB-1E8A-3391-BEF5-7D91F0715A62> /usr/lib/libThaiTokenizer.dylib
    0x7fff7a930000 -     0x7fff7a946ffb  libapple_nghttp2.dylib (1.24.1) <71C126C5-D869-3E67-9778-058FA7F3CA74> /usr/lib/libapple_nghttp2.dylib
    0x7fff7a947000 -     0x7fff7a970ffb  libarchive.2.dylib (54.200.3) <32B8634D-E465-3F6D-B254-A20D44504508> /usr/lib/libarchive.2.dylib
    0x7fff7a971000 -     0x7fff7aa70ff7  libate.dylib (1.13.8) <6FF4C626-689E-3464-B2C5-C01F3C084219> /usr/lib/libate.dylib
    0x7fff7aa74000 -     0x7fff7aa74ff3  libauto.dylib (187) <003DEF68-0C59-3AFB-A7B7-A1B5ED301AF2> /usr/lib/libauto.dylib
    0x7fff7ab4b000 -     0x7fff7ab5bff3  libbsm.0.dylib (39.200.18) <58A9ACEC-BF46-3A4E-86F5-3DD9AD7095B4> /usr/lib/libbsm.0.dylib
    0x7fff7ab5c000 -     0x7fff7ab6afff  libbz2.1.0.dylib (38.200.3) <4DEC3797-087F-3C8D-815B-48E895813251> /usr/lib/libbz2.1.0.dylib
    0x7fff7ab6b000 -     0x7fff7abc2ff7  libc++.1.dylib (400.9.4) <B260AC33-EB9A-30C6-8746-D011B3B02B08> /usr/lib/libc++.1.dylib
    0x7fff7abc3000 -     0x7fff7abd8fff  libc++abi.dylib (400.17) <446F4748-8A89-3D2E-AE1C-27EEBE93A8AB> /usr/lib/libc++abi.dylib
    0x7fff7abd9000 -     0x7fff7abd9ff3  libcharset.1.dylib (51.200.6) <43F7E100-F5D1-36AB-A26E-CF94196A19C0> /usr/lib/libcharset.1.dylib
    0x7fff7abda000 -     0x7fff7abeaffb  libcmph.dylib (6.15.1) <CEDA6538-C071-3B5A-948E-DF61E2878983> /usr/lib/libcmph.dylib
    0x7fff7abeb000 -     0x7fff7ac03fdb  libcompression.dylib (52.200.13) <6298529A-0120-3360-891C-84436972EA8D> /usr/lib/libcompression.dylib
    0x7fff7aeae000 -     0x7fff7aec4fff  libcoretls.dylib (155.220.1) <1229F9EA-C070-3D03-9DC6-F548C59F9FD5> /usr/lib/libcoretls.dylib
    0x7fff7aec5000 -     0x7fff7aec6ff3  libcoretls_cfhelpers.dylib (155.220.1) <33661841-3C3B-3608-86AC-C88D1CD6FE98> /usr/lib/libcoretls_cfhelpers.dylib
    0x7fff7b53d000 -     0x7fff7b594ffb  libcups.2.dylib (462.10) <29B6D106-A5F2-321D-8916-90F595545D88> /usr/lib/libcups.2.dylib
    0x7fff7b6cc000 -     0x7fff7b6ccfff  libenergytrace.dylib (17.200.1) <F5BA8134-16F9-31CD-90E1-D1EBEBADA4AE> /usr/lib/libenergytrace.dylib
    0x7fff7b6fe000 -     0x7fff7b703ff7  libgermantok.dylib (17.15.2) <9381B152-5CFD-3D23-A5A7-4D64EE55B85E> /usr/lib/libgermantok.dylib
    0x7fff7b704000 -     0x7fff7b709ff7  libheimdal-asn1.dylib (520.220.2) <D851A47D-E162-35F8-B8D4-6ABEA7FFDAD7> /usr/lib/libheimdal-asn1.dylib
    0x7fff7b735000 -     0x7fff7b826ff7  libiconv.2.dylib (51.200.6) <9FB95807-7C62-32B7-A19F-946D7FB7CCA6> /usr/lib/libiconv.2.dylib
    0x7fff7b827000 -     0x7fff7ba8affb  libicucore.A.dylib (62109.0.1) <FEB89BD3-79C4-3208-A754-7E6BC4D38548> /usr/lib/libicucore.A.dylib
    0x7fff7bad7000 -     0x7fff7bad8fff  liblangid.dylib (128.15.1) <663D0A24-7260-31D1-9BFE-74D67B6F72F6> /usr/lib/liblangid.dylib
    0x7fff7bad9000 -     0x7fff7baf1fff  liblzma.5.dylib (10.200.3) <9A52A949-0CB1-39B6-9244-D079FB609559> /usr/lib/liblzma.5.dylib
    0x7fff7bb09000 -     0x7fff7bbb9fff  libmecab.1.0.0.dylib (779.24.1) <590BC39C-2A3E-368B-9499-C808B84C4955> /usr/lib/libmecab.1.0.0.dylib
    0x7fff7bbba000 -     0x7fff7bdf7ff7  libmecabra.dylib (779.24.1) <22BFD5A8-EA42-3DC3-8910-F27DCFB1B631> /usr/lib/libmecabra.dylib
    0x7fff7bfcf000 -     0x7fff7c327ffb  libnetwork.dylib (1229.230.4) <B76F8990-85CD-382D-BDF4-58C4AD4CE6C4> /usr/lib/libnetwork.dylib
    0x7fff7c3b8000 -     0x7fff7cb41fd7  libobjc.A.dylib (750.1) <4D6C889C-60F4-3028-9B13-DD3DFE6A2A44> /usr/lib/libobjc.A.dylib
    0x7fff7cb54000 -     0x7fff7cb58ffb  libpam.2.dylib (22.200.1) <85253002-89F2-3872-9C8A-1801303A2EBB> /usr/lib/libpam.2.dylib
    0x7fff7cb5b000 -     0x7fff7cb91ff7  libpcap.A.dylib (79.200.4) <6D25197A-2F7C-3147-A45A-F6F13E55909F> /usr/lib/libpcap.A.dylib
    0x7fff7ccab000 -     0x7fff7ccc3ffb  libresolv.9.dylib (65.200.2) <A1A77B4E-1AF0-3039-9945-D05440494E00> /usr/lib/libresolv.9.dylib
    0x7fff7cd15000 -     0x7fff7cd16ff7  libspindump.dylib (267.1) <9DEA015B-410E-3D6E-A3EE-54E046092EA9> /usr/lib/libspindump.dylib
    0x7fff7cd17000 -     0x7fff7cee3ff7  libsqlite3.dylib (274.20) <42C5E16B-AA3C-3C6A-BD35-6AD3EE525DB8> /usr/lib/libsqlite3.dylib
    0x7fff7d170000 -     0x7fff7d173ffb  libutil.dylib (51.200.4) <10C5E165-0939-363A-9D13-7076F3B513EC> /usr/lib/libutil.dylib
    0x7fff7d174000 -     0x7fff7d181fff  libxar.1.dylib (404) <16E875B3-CF89-3059-87BB-36D301B32E7B> /usr/lib/libxar.1.dylib
    0x7fff7d186000 -     0x7fff7d269fff  libxml2.2.dylib (32.8) <3E7875AC-3195-3800-AC48-8AA3B7BE51E4> /usr/lib/libxml2.2.dylib
    0x7fff7d26a000 -     0x7fff7d292ff3  libxslt.1.dylib (16.1) <D6EBFEBB-F88E-398F-B1B5-66F413C2CD32> /usr/lib/libxslt.1.dylib
    0x7fff7d293000 -     0x7fff7d2a5ffb  libz.1.dylib (70.200.4) <15F7B40A-424C-33BB-BF2C-7E8195128B78> /usr/lib/libz.1.dylib
    0x7fff7d316000 -     0x7fff7d31aff3  libcache.dylib (81) <704331AC-E43D-343A-8C24-39201142AF27> /usr/lib/system/libcache.dylib
    0x7fff7d31b000 -     0x7fff7d325ff3  libcommonCrypto.dylib (60118.220.1) <9C865644-EE9A-3662-AB77-7C8A5E561784> /usr/lib/system/libcommonCrypto.dylib
    0x7fff7d326000 -     0x7fff7d32dfff  libcompiler_rt.dylib (63.4) <817772E3-E836-3FFD-A39B-BDCD1C357221> /usr/lib/system/libcompiler_rt.dylib
    0x7fff7d32e000 -     0x7fff7d337ff3  libcopyfile.dylib (146.200.3) <5C5C4F35-DAB7-3CF1-940F-F47192AB8289> /usr/lib/system/libcopyfile.dylib
    0x7fff7d338000 -     0x7fff7d3bcfdf  libcorecrypto.dylib (602.230.1) <C78D1A87-5543-3561-BEB4-3B480BA94ECB> /usr/lib/system/libcorecrypto.dylib
    0x7fff7d443000 -     0x7fff7d47dff7  libdispatch.dylib (1008.220.2) <2FDB1401-5119-3DF0-91F5-F4E105F00CD7> /usr/lib/system/libdispatch.dylib
    0x7fff7d47e000 -     0x7fff7d4adff3  libdyld.dylib (640.2) <376E3F3A-6942-3B0E-AD5E-4B97E8255CF5> /usr/lib/system/libdyld.dylib
    0x7fff7d4ae000 -     0x7fff7d4aeffb  libkeymgr.dylib (30) <A4EFD9A4-2EF3-3E18-B325-F527E3821939> /usr/lib/system/libkeymgr.dylib
    0x7fff7d4af000 -     0x7fff7d4bbff7  libkxld.dylib (4903.231.4) <7275D7AD-54CE-30BF-9459-18EA77E28ACC> /usr/lib/system/libkxld.dylib
    0x7fff7d4bc000 -     0x7fff7d4bcff7  liblaunch.dylib (1336.220.5) <8563299C-2493-3DBD-8E88-3FC673DB47DD> /usr/lib/system/liblaunch.dylib
    0x7fff7d4bd000 -     0x7fff7d4c2fff  libmacho.dylib (921) <6ADB99F3-D142-3A0A-B3CE-031354766ACC> /usr/lib/system/libmacho.dylib
    0x7fff7d4c3000 -     0x7fff7d4c5ffb  libquarantine.dylib (86.220.1) <58524FD7-63C5-38E0-9D90-845A79551C14> /usr/lib/system/libquarantine.dylib
    0x7fff7d4c6000 -     0x7fff7d4c7ff3  libremovefile.dylib (45.200.2) <BA53CA8A-9974-3A43-9265-B110B1AE470F> /usr/lib/system/libremovefile.dylib
    0x7fff7d4c8000 -     0x7fff7d4dfff3  libsystem_asl.dylib (356.200.4) <33C62769-1242-3BC1-9459-13CBCDECC7FE> /usr/lib/system/libsystem_asl.dylib
    0x7fff7d4e0000 -     0x7fff7d4e0fff  libsystem_blocks.dylib (73) <152EDADF-7D94-35F2-89B7-E66DCD945BBA> /usr/lib/system/libsystem_blocks.dylib
    0x7fff7d4e1000 -     0x7fff7d569fff  libsystem_c.dylib (1272.200.26) <D6C701A2-9F17-308D-B6AC-9E17EF31B7DF> /usr/lib/system/libsystem_c.dylib
    0x7fff7d56a000 -     0x7fff7d56dff7  libsystem_configuration.dylib (963.200.27) <94898525-ECC8-3CC9-B312-CBEAAC305E32> /usr/lib/system/libsystem_configuration.dylib
    0x7fff7d56e000 -     0x7fff7d571ff7  libsystem_coreservices.dylib (66) <10818C17-70E1-328E-A3E3-C3EB81AEC590> /usr/lib/system/libsystem_coreservices.dylib
    0x7fff7d572000 -     0x7fff7d578ffb  libsystem_darwin.dylib (1272.200.26) <07468CF7-982F-37C4-83D0-D5E602A683AA> /usr/lib/system/libsystem_darwin.dylib
    0x7fff7d579000 -     0x7fff7d57fff7  libsystem_dnssd.dylib (878.230.2) <FF9D5025-F060-334B-B6D8-C5D0BB6A55E3> /usr/lib/system/libsystem_dnssd.dylib
    0x7fff7d580000 -     0x7fff7d5ccff3  libsystem_info.dylib (517.200.9) <54B65F21-2E93-3579-9B72-6637A03245D9> /usr/lib/system/libsystem_info.dylib
    0x7fff7d5cd000 -     0x7fff7d5f5ff7  libsystem_kernel.dylib (4903.231.4) <ABDAABCA-C22A-3960-AA4E-E91A9FF34929> /usr/lib/system/libsystem_kernel.dylib
    0x7fff7d5f6000 -     0x7fff7d641ff7  libsystem_m.dylib (3158.200.7) <AF25F8E8-194C-314F-A2D3-A424853EE796> /usr/lib/system/libsystem_m.dylib
    0x7fff7d642000 -     0x7fff7d666ff7  libsystem_malloc.dylib (166.220.1) <4777DC06-F9C6-356E-82AB-86A1C6D62F3A> /usr/lib/system/libsystem_malloc.dylib
    0x7fff7d667000 -     0x7fff7d672ff3  libsystem_networkextension.dylib (767.220.1) <74818C3D-9B68-3823-A737-6A4B782618F2> /usr/lib/system/libsystem_networkextension.dylib
    0x7fff7d673000 -     0x7fff7d67afff  libsystem_notify.dylib (172.200.21) <65B3061D-41D7-3485-B217-A861E05AD50B> /usr/lib/system/libsystem_notify.dylib
    0x7fff7d67b000 -     0x7fff7d684fef  libsystem_platform.dylib (177.200.16) <83DED753-51EC-3B8C-A98D-883A5184086B> /usr/lib/system/libsystem_platform.dylib
    0x7fff7d685000 -     0x7fff7d68ffff  libsystem_pthread.dylib (330.230.1) <BA382BFC-6A17-3940-B417-D090EF2AF4F4> /usr/lib/system/libsystem_pthread.dylib
    0x7fff7d690000 -     0x7fff7d693ff7  libsystem_sandbox.dylib (851.230.3) <4D0CB1CA-160C-3C29-BE5D-131D68D43B1B> /usr/lib/system/libsystem_sandbox.dylib
    0x7fff7d694000 -     0x7fff7d696ff3  libsystem_secinit.dylib (30.220.1) <5964B6D2-19D4-3CF9-BDBC-4EB1D42348F1> /usr/lib/system/libsystem_secinit.dylib
    0x7fff7d697000 -     0x7fff7d69eff7  libsystem_symptoms.dylib (820.237.2) <487E1794-4C6E-3B1B-9C55-95B1A5FF9B90> /usr/lib/system/libsystem_symptoms.dylib
    0x7fff7d69f000 -     0x7fff7d6b4ff7  libsystem_trace.dylib (906.220.1) <4D4BA88A-FA32-379D-8860-33838723B35F> /usr/lib/system/libsystem_trace.dylib
    0x7fff7d6b6000 -     0x7fff7d6bbffb  libunwind.dylib (35.4) <EF1A77FD-A86B-39F5-ABEA-6100AB23583A> /usr/lib/system/libunwind.dylib
    0x7fff7d6bc000 -     0x7fff7d6ecfff  libxpc.dylib (1336.220.5) <DC50F33E-C47D-3256-BFE0-F8E9B5AEBE17> /usr/lib/system/libxpc.dylib

External Modification Summary:
  Calls made by other processes targeting this process:
    task_for_pid: 1
    thread_create: 0
    thread_set_state: 0
  Calls made by this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by all processes on this machine:
    task_for_pid: 496
    thread_create: 0
    thread_set_state: 0

VM Region Summary:
ReadOnly portion of Libraries: Total=422.6M resident=0K(0%) swapped_out_or_unallocated=422.6M(100%)
Writable regions: Total=921.6M written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=921.6M(100%)

                                VIRTUAL   REGION
REGION TYPE                        SIZE    COUNT (non-coalesced)
===========                     =======  =======
ATS (font support)                32.3M        6
ATS (font support) (reserved)        8K        3         reserved VM address space (unallocated)
Accelerate framework               128K        2
Activity Tracing                   256K        2
CG backing stores                 6036K        5
CG image                           120K        6
CoreAnimation                       44K        5
CoreGraphics                         8K        2
CoreImage                            8K        3
CoreUI image data                  324K        7
CoreUI image file                  404K        6
Foundation                           4K        2
Kernel Alloc Once                    8K        2
MALLOC                           409.2M       40
MALLOC guard page                   32K        7
MALLOC_NANO (reserved)           384.0M        2         reserved VM address space (unallocated)
Memory Tag 242                      12K        2
STACK GUARD                       56.0M       14
Stack                             38.6M       14
VM_ALLOCATE                        112K       13
__DATA                            78.1M      280
__FONT_DATA                          4K        2
__LINKEDIT                       219.9M       26
__TEXT                           202.7M      279
__UNICODE                          564K        2
mapped file                       58.7M       20
shared memory                     2696K       14
===========                     =======  =======
TOTAL                              1.5G      739
TOTAL, minus reserved VM space     1.1G      739

Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 29, 2018, 10:03:57 AM
Thanks @DeafEyeJedi! Here is what happens:
Quote from: DeafEyeJedi on December 29, 2018, 09:56:02 AM
...
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   magiclantern.MLV App          0x00000001085a49d8 readMlvAudioData + 552
1   magiclantern.MLV App          0x00000001085645fe openMlvClip + 4366
2   magiclantern.MLV App          0x00000001085634d3 initMlvObjectWithClip + 211
3   magiclantern.MLV App          0x000000010851d773 MainWindow::openMlv(QString) + 275
4   magiclantern.MLV App          0x0000000108515947 MainWindow::showFileInEditor(int) + 167
5   magiclantern.MLV App          0x000000010851b08c MainWindow::openMlvSet(QStringList) + 1244
6   magiclantern.MLV App          0x000000010851a557 MainWindow::dropEvent(QDropEvent*) + 1895
...

So there is something wrong with audio data in your clip (at least MLVApp seems to have a problem with it). Strange... my computer tells there is no audio in your clips. So I really can't explain why it crashes on your machine, but not on ours.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on December 29, 2018, 10:25:49 AM
Thanks for pointing this out @masc! At first I thought it was due to having both regular MLV and DF Avg MLV at the same time while previewing through MLV App (to see how much it clears up the magenta noise) as I could swear that I have in the past with no issues. But now it has to do with Audio data in my clips?



It's the same audio from the original MLV file that played perfectly fine until I ran through the DF Avg process via Switch and boom there you guys are able to load them on your end with no issues. I'll see if I can reproduce this so called bug on my end. Better luck next time!  :)
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 29, 2018, 10:29:15 AM
Very strange: my computer tells, there is no audio in these clips:
(https://i.ibb.co/PZvtwM4/Bildschirmfoto-2018-12-29-um-10-27-47.png)
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on December 29, 2018, 10:44:56 AM
Actually wait a minute... I just decided to try the Small Samples that I shared with you guys. They were trimmed by using Switch (Thanks @Danne) and now it shows up on MLV App with no crashes and indeed there aren't any audio in that these files.

I had assumed it would be included. Sorry for not double checking at first but still I gotta figure this out... if I play the original created DF MLV's it will crash but not the trimmed samples. What gives?  :P
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 29, 2018, 11:32:01 AM
Quote from: DeafEyeJedi on December 29, 2018, 10:44:56 AM
Actually wait a minute... I just decided to try the Small Samples that I shared with you guys. They were trimmed by using Switch (Thanks @Danne) and now it shows up on MLV App with no crashes and indeed there aren't any audio in that these files.

I had assumed it would be included. Sorry for not double checking at first but still I gotta figure this out... if I play the original created DF MLV's it will crash but not the trimmed samples. What gives?  :P
For me that sounds like there happens something strange with Switch when creating darkframe MLVs... maybe metadata still tells there is audio, but it isn't, or something like that. If you create darkframe MLVs in MLVApp... happens the same?
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 29, 2018, 05:10:56 PM
Quote from: masc on December 29, 2018, 11:32:01 AM
For me that sounds like there happens something strange with Switch when creating darkframe MLVs... maybe metadata still tells there is audio, but it isn't, or something like that. If you create darkframe MLVs in MLVApp... happens the same?
Exactly that could be the root of this issue.

@DeafEyeJedi: Hey man! Give me the unmodified file which crashes mlvapp. I'll take a closer look.

BTW guys, if you got the error message "Can not use lossless MLV as a dark frame" this does not mean you can not use dark frames for lossless footage. This means that properly averaged dark frame (the one frame MLV) can not be lossless. Both mlvapp and mlv_dump (I believe) exporting dark frame MLV not compressed. I regret I did not introduce new dark frame file format for mlvapp, I just did it for the compatibility sake with mlv_dump.

Anyway MLV recorded as a dark frame source to be averaged to one frame DARKFRAME can be either lossless or uncompressed. Also the source which this dark frame was created for can be either lossless or uncompressed, so there is none of restriction applied.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: fspinna93 on December 30, 2018, 03:49:56 PM
Just starting to use this app and it's soooo good, great work guys! It simplifies the workflow a lot... I've a dumb question: is it possible to load camera raw profile like cinelog-c?
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on December 31, 2018, 03:39:33 PM
Quote from: fspinna93 on December 30, 2018, 03:49:56 PM
Just starting to use this app and it's soooo good, great work guys! It simplifies the workflow a lot... I've a dumb question: is it possible to load camera raw profile like cinelog-c?
You can chose between Alexa Log, Cineon Log and Sony S-Log3. Cinelog-C is not included, because we had no source or information how it is defined.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: dfort on December 31, 2018, 04:18:53 PM
Quote from: masc on December 31, 2018, 03:39:33 PM
...Cinelog-C is not included, because we had no source or information how it is defined.

Have you asked @Andy600 for some help with this?
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: fspinna93 on January 02, 2019, 12:17:17 AM
Quote from: masc on December 31, 2018, 03:39:33 PM
You can chose between Alexa Log, Cineon Log and Sony S-Log3. Cinelog-C is not included, because we had no source or information how it is defined.

Alright, thanks!
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 02, 2019, 03:05:54 PM
Am I still the only one who is missing a batch MAPP creation for all loaded .mlv ? :P I want to know if the others would find it usefull as well!
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on January 02, 2019, 10:16:39 PM
Quote from: bouncyball on December 29, 2018, 05:10:56 PM
@DeafEyeJedi: Hey man! Give me the unmodified file which crashes mlvapp. I'll take a closer look.

Absolutely. Here you go, @bouncyball! -- (255 MB) https://bitbucket.org/DeafEyeJedi/magic-lantern/downloads/M26-2323.MLV

Unless you meant for this 'unmodified' as in pre-DF or non-trimmed?  ;D

Quote from: bouncyball on December 29, 2018, 05:10:56 PM
...Anyway MLV recorded as a dark frame source to be averaged to one frame DARKFRAME can be either lossless or uncompressed. Also the source which this dark frame was created for can be either lossless or uncompressed, so there is none of restriction applied.

Ah, Thanks for the friendly reminder. Perhaps I could/should have recorded all DF files in 14-bit uncompressed MLV's and STILL be able to apply these files in conjunction with 12-bit lossless MLV's, correct?
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on January 03, 2019, 12:32:24 PM
Hm, I can not reproduce the crash with uploaded file, sorry... it loads and plays flawlessly.

Quote from: DeafEyeJedi on January 02, 2019, 10:16:39 PM
Perhaps I could/should have recorded all DF files in 14-bit uncompressed MLV's and STILL be able to apply these files in conjunction with 12-bit lossless MLV's, correct?
I believe the best is to record DF clip with the exact same settings. However it can be recorded with different bit depth as far as video mode/resolution is matched. Compressed/uncompressed does not matter.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on January 03, 2019, 04:33:24 PM
Thanks for checking. Maybe I should do another test then.

You mean you converted the unmodified MLV into Averaged MLV and yet still playbacks flawlessly?

If so, mind if I ask how exactly did you do DF avg for this?
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 03, 2019, 09:05:21 PM
Quote from: dfort on December 31, 2018, 04:18:53 PM
Have you asked @Andy600 for some help with this?

I know the cinelog website has xy cooridnates of the RGB primaries, and a few values on the log curve, but I am not sure how to get a matrix or curve function from that info. @Andy600 if you could inform me about the curve and matrix from XYZ I would appreciate it! (or tell me how to do it from info on the website ;)).

Edit: I am an idiot, I just looked on the page and it literally says "It is a hybrid of Alexa Wide Gamut RGB primaries (D65 white) and Cineon Log transfer"
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on January 04, 2019, 12:36:40 PM
@DeafEyeJedi

Quote from: DeafEyeJedi on January 03, 2019, 04:33:24 PM
If so, mind if I ask how exactly did you do DF avg for this?
Sure.

1. Load M26-2323.MLV source clip into mlvapp then go to export settings and select Codec "MLV" with option (lower dropbox) "Averaged Frame". Export result somewhere (with changed name. E.g M26-2323_DF.MLV or something). Just temporarily Import this averaged MLV as a _regular_ clip to check whether it crashes app or not.
2. Use this averaged MLV as a dark frame in RAW Correction "Darkframe Subtraction" section (load it with yellow folder button).

One more thing. Could you share your already averaged MLV. I mean made by switch (hence w/mlv_dump) which crashes mlvapp?

That's all :)
bb
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ibrahim on January 04, 2019, 07:51:15 PM
Hi, to process dual ISO footage what should the camera matrix be set at?
I use 5d3.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 04, 2019, 09:44:08 PM
Quote from: ibrahim on January 04, 2019, 07:51:15 PM
Hi, to process dual ISO footage what should the camera matrix be set at?
I use 5d3.
There is no "should". Do it in a way it looks good for you ;)
Camera Matrix is a color calibration. At temperatures >4000K it is mostly better to check it. Below ~4000K we have some problems with it and you may get some strange colors here and there, so uncheck it.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 04, 2019, 11:35:17 PM
Just keep it on as it gives correct colours, but disable if it causes problems.
Title: Re: MLV App 1.3 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ibrahim on January 05, 2019, 12:53:54 AM
Quote from: Danne on November 14, 2018, 08:51:02 AM
@Ibrahim
Just hit export dng, lossless, uncompressed, whatever. If the dng files looks ok you don´t need to mess with settings. Defaults are ok. ACR and resolve can chew all bits.

Thanks Ilia3101, masc and bouncyball for great progress and refienments. Dualiso, colors etc. High end stuff.

After processing my dual iso/raw footage to arri log-c cDNG uncompressed I intend to import them AE. During the import ACR will be used. Which leads to the question, how much more accurate is MLVapp than ACR? Or rather what's destructive with ACR?

Will any destruction also occur with resolve?
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 05, 2019, 05:10:02 PM
came back to work  8)

1) On the gradiation curves would it be possible to have the right click assigned to delete a point? It is a standard feature on most of the curves I've seen in different apps.

2) Would it be possible to have the same option for naming scheme that we have on the dng export with the ProRes export? Particularly usefull for a number of reasons. On my case I had done the proxy with Resolve but since now the colours looks very good out right out of the MLV App I would like to do the master from it, and replace them for my NLE.

Proxy file has this name (dng-resolve-nle) : M12-1211_1_2017-06-12_0001_C0000

ProRes export can only have this name : M12-1211
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 05, 2019, 07:11:32 PM
I did a fast colour comparison:


In order : tonemapped MLV App, Rec709 gamma Resolve, Srgb gamma Resolve, Srgb gamma Resolve fast correction.
I feel like I can bring srgb close to the tonemapped but I kind of loose skintones. Of course the tonemapped logic has a kind of backed filmic gamma into it but usually it is what I'm looking for and anyway it is usefull to have it from start, since canon magic lantern's camera don't have that much dinamic range it helps to create a pleasing image immage even if you underexposed a little.

(https://i.imgur.com/TSrFFzc.jpg)

(https://i.imgur.com/GncaPtn.jpg)

(https://i.imgur.com/hIpsIJu.jpg)

(https://i.imgur.com/O2x32fh.jpg)
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 05, 2019, 07:41:28 PM
I will have to explain mlv app profiles. Coming in ~1 hour
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 05, 2019, 07:57:13 PM
Quote from: togg on January 05, 2019, 05:10:02 PM
1) On the gradiation curves would it be possible to have the right click assigned to delete a point? It is a standard feature on most of the curves I've seen in different apps.

2) Would it be possible to have the same option for naming scheme that we have on the dng export with the ProRes export? Particularly usefull for a number of reasons. On my case I had done the proxy with Resolve but since now the colours looks very good out right out of the MLV App I would like to do the master from it, and replace them for my NLE.
1) use double click as with all other parameters in the app
2) I have to think about how to do that, but sounds not impossible ;)
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 05, 2019, 08:02:45 PM
Quote from: masc on January 05, 2019, 07:57:13 PM
1) use double click as with all other parameters in the app
2) I have to think about how to do that, but sounds not impossible ;)

1) got it!
2) OK, thanks :) In the meantime I'll probably use NameChanger, a very usefull software in case you don't know it.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 05, 2019, 10:26:13 PM
Quote from: ibrahim on January 05, 2019, 12:53:54 AM
After processing my dual iso/raw footage to arri log-c cDNG uncompressed I intend to import them AE.

When you export to DNG no processing is applied as DNG is for bayer raw data, only thing MLV App can do to DNG is raw corrections like stripe removal.

Quote from: ibrahim on January 05, 2019, 12:53:54 AM
During the import ACR will be used. Which leads to the question, how much more accurate is MLVapp than ACR?

For processing raw video, they MLV App and ACR should both be colour accurate. Adobe can obviously do more as it has more money so obviously ACR is gonna be better in a lot of ways.

Quote from: ibrahim on January 05, 2019, 12:53:54 AM
Or rather what's destructive with ACR?

Will any destruction also occur with resolve?

I don't know exactly what you mean by destructive here.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 05, 2019, 10:40:00 PM
Now the processing profile explanation. They are currently a bit confusing and not consistent in terms of what type of thing they are. It really should be separated in to processing profile and output colour space.

But here's an explanation of what they currently are:

Standard - allows any creative processing to be done (contrast, saturation, curves and stuff like that), output in rec.709 colour space.
Tonemapped - Same as standard but applies a tonemapping curve so that highlights never ever clip (this limited by the camera unfortunately) - also output in rec709 space
sRGB - Does not allow any creative processing to be done (contrast, saturation, curves...), only exposure (linear) and white balance (white point adaptation) so the end result is a perfectly accurate output in the sRGB colour space
rec709 - same as sRGB, perfectly accurate, but this time the output is in rec709 colour space (basically the same thing)
linear - uses rec709/sRGB gamut, but no gamma curve. Not sure what the use is but I think @escho uses it. (?)
log profiles - Exact output, no creative processing, same as the previous two, except the output is in a log colour space which does allow processing

sRGB and rec709 are not very useful imo as they neither retain information for further grading like log does, nor does the image look nice because they lack a tonemapping curve.

This whole system will be reworked and more logical soon along with some very good improvements. I really want to get it done but I am busy in January sadly :(

Also @masc I noticed an issue, the curves and clarity adjustment do not get disabled in log and srgb/rec709 profiles which they should.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: escho on January 05, 2019, 10:56:57 PM
Quote from: Ilia3101 on January 05, 2019, 10:40:00 PM

linear - uses rec709/sRGB gamut, but no gamma curve. Not sure what the use is but I think @escho uses it. (?)


Yes, I used it. But I managed to get nice results with standard easier. So, if nobody needs linear, it can be removed
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 05, 2019, 11:12:25 PM
Quote from: escho on January 05, 2019, 10:56:57 PM
Yes, I used it. But I managed to get nice results with standard easier. So, if nobody needs linear, it can be removed

Even though it's not useful now, the capability will be kept. After the processing improvements that are coming, linear output will be required if we want things like ACES support or HDR.

Quote from: togg on January 05, 2019, 07:11:32 PM
I did a fast colour comparison:


In order : tonemapped MLV App, Rec709 gamma Resolve, Srgb gamma Resolve, Srgb gamma Resolve fast correction.

Oh lol I originally misread that - I thought you said MLV App rec709 and MLV App sRGB profiles. That is what lead me to explain the profiles. Oh well hopefully it's useful for some people.

@togg Actually would be interesting if you compared MLV App's sRGB and rec709 profiles to Davinci's.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 05, 2019, 11:51:33 PM
Quote from: Ilia3101 on January 05, 2019, 10:40:00 PM
Now the processing profile explanation. They are currently a bit confusing and not consistent in terms of what type of thing they are. It really should be separated in to processing profile and output colour space.

But here's an explanation of what they currently are:

Standard - allows any creative processing to be done (contrast, saturation, curves and stuff like that), output in rec.709 colour space.
Tonemapped - Same as standard but applies a tonemapping curve so that highlights never ever clip (this limited by the camera unfortunately) - also output in rec709 space
sRGB - Does not allow any creative processing to be done (contrast, saturation, curves...), only exposure (linear) and white balance (white point adaptation) so the end result is a perfectly accurate output in the sRGB colour space
rec709 - same as sRGB, perfectly accurate, but this time the output is in rec709 colour space (basically the same thing)
linear - uses rec709/sRGB gamut, but no gamma curve. Not sure what the use is but I think @escho uses it. (?)
log profiles - Exact output, no creative processing, same as the previous two, except the output is in a log colour space which does allow processing

sRGB and rec709 are not very useful imo as they neither retain information for further grading like log does, nor does the image look nice because they lack a tonemapping curve.

This whole system will be reworked and more logical soon along with some very good improvements. I really want to get it done but I am busy in January sadly :(

Also @masc I noticed an issue, the curves and clarity adjustment do not get disabled in log and srgb/rec709 profiles which they should.



mmm, I'd be curious to know what kind of tonemapping the standard/tonemapping/film mode are doing VS rec709/srgb. The results are so differents than I'm kinf of scary to commit my workflow to those ProRes files.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 05, 2019, 11:57:08 PM
Quote from: Ilia3101 on January 05, 2019, 11:12:25 PM
@togg Actually would be interesting if you compared MLV App's sRGB and rec709 profiles to Davinci's.


will do! Thing is they'll probably differ because gamma is a huge mess, rec709 doesn't even define it.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 06, 2019, 12:40:26 AM
Quote from: togg on January 05, 2019, 11:57:08 PM
will do! Thing is they'll probably differ because gamma is a huge mess, rec709 doesn't even define it.

Thank you for testing.

Also what do you mean it doesn't define gamma? I didn't create the Rec709 profile, but isn't this the gamma function: https://en.wikipedia.org/wiki/Rec._709#Transfer_characteristics (well "transfer function")
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 06, 2019, 12:58:00 AM
Quote from: togg on January 05, 2019, 11:51:33 PM
mmm, I'd be curious to know what kind of tonemapping the standard/tonemapping/film mode are doing VS rec709/srgb. The results are so differents than I'm kinf of scary to commit my workflow to those ProRes files.

Ah, I did forget to mention, the standard/tonemapped/film use an extra curve that lightens the image as it looked far better than without it.

This is how the processing you are interested in works:
1. linear image (infinite range of values, with help from clever int16 tricks)
2. tonemapping function to roll clipped values off to 1.0 smoothly ("film" tonemapping function (https://github.com/ilia3101/MLV-App/blob/master/src/processing/processing.c#L44) and "tonemapped" tonemapping function (https://github.com/ilia3101/MLV-App/blob/master/src/processing/processing.c#L40), standard/rec709/sRGB do not do this stage, therefore has harsh clipping)
3. lighten curve (same in one tonemapped, standard, film)
4. final colour space conversion (where gamma happens)

In rec.709 and sRGB, creative adjustments are disabled and there is no step 2 and 3, which gives the closest to exact sRGB/rec709 colour values but that it no real use for creativity/film making, and neither is it any use for measuring colours as a camera sensor is just not that accurate. Same applies to the log profiles, although they do not have fully correct colour spaces yet.

The order of this will stay the same once the big upgrade has been done, but the individual stages should be more customisable. It does look completely different in code and hopefully that will be clearer as well (right now some of these stages are combined in some ways for both speed and because they were not initially planned).
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 06, 2019, 02:09:08 AM
Quote from: Ilia3101 on January 06, 2019, 12:40:26 AM
Thank you for testing.

Also what do you mean it doesn't define gamma? I didn't create the Rec709 profile, but isn't this the gamma function: https://en.wikipedia.org/wiki/Rec._709#Transfer_characteristics (well "transfer function")

oh yes yes, you're right, it's the display gamma that isn't specified. I also got confused because now even in davinci you can decouple the colour space from the encoding gamma.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 06, 2019, 02:17:08 AM
I'm having another nasty bug on a batch export of around 400gb (MLV compression).

"Could not read VIDF image data from:  /Volumes/DNG/etc etc/RAW/M30-1357.MLV"

It stopped the export completelly, I aborted it and launched the file by itself, it exported fine, then restarted the batch export and got the same error, exported the one fine, started again the batch a third time and now it seem to be proceding...


Quote from: Ilia3101 on January 06, 2019, 12:58:00 AM
Ah, I did forget to mention, the standard/tonemapped/film use an extra curve that lightens the image as it looked far better than without it.

This is how the processing you are interested in works:
1. linear image (infinite range of values, with help from clever int16 tricks)
2. tonemapping function to roll clipped values off to 1.0 smoothly ("film" tonemapping function (https://github.com/ilia3101/MLV-App/blob/master/src/processing/processing.c#L44) and "tonemapped" tonemapping function (https://github.com/ilia3101/MLV-App/blob/master/src/processing/processing.c#L40), standard/rec709/sRGB do not do this stage, therefore has harsh clipping)
3. lighten curve (same in one tonemapped, standard, film)
4. final colour space conversion (where gamma happens)

In rec.709 and sRGB, creative adjustments are disabled and there is no step 2 and 3, which gives the closest to exact sRGB/rec709 colour values but that it no real use for creativity/film making, and neither is it any use for measuring colours as a camera sensor is just not that accurate. Same applies to the log profiles, although they do not have fully correct colour spaces yet.

The order of this will stay the same once the big upgrade has been done, but the individual stages should be more customisable. It does look completely different in code and hopefully that will be clearer as well (right now some of these stages are combined in some ways for both speed and because they were not initially planned).

Ok perfect, it is more clear now. I was having the impression that I was able to replicate the lighten curve (3) with a simple curve in Resolve. I wasn't wrong! I do agree that it looks better, it maybe isn't a good idea to start a professional grade from it, I would use the dngs, but still. And I also still think that colours are not exactly the same, like you said I have to do a rec709 vs rec709 comparison with davinci.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 06, 2019, 02:38:37 AM
Quote from: togg on January 06, 2019, 02:17:08 AM
lighten curve ... I do agree that it looks better, it maybe isn't a good idea to start a professional grade from it, I would use the dngs, but still.

If you mean to grade in Davinci, then I completely agree with you. Definitely go with the DNGs. After the big processing upgrade though, the log options will be truly accurate.

The lighten curve and tonemapped profiles exist mainly for doing the grade in MLV App. This works for me, I think MLV App is great, but maybe not the most advanced for all kinds of crazy colour corrections like resolve people do...

Quote from: togg on January 06, 2019, 02:17:08 AM
And I also still think that colours are not exactly the same, like you said I have to do a rec709 vs rec709 comparison with davinci.

Very likely that there is difference between MLV App and Resolve. Most raw software does something creative to make the colours more pleasing in their view, so there's definitely going to be differences.

Also I think in your example the white balance was cooler in the resolve shot.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 06, 2019, 03:18:34 AM
Yes yes I wasn't really carefull with the WB. I'll test tomorrow if I manage to get those batch export right!

Also I've noticed that at the beginning of a batch all the MAPP files are created. It shouldn't be hard to extrapolate this as a feature, right?


@Ilia3101 If you plan to use MLV App to do a final colour maybe it would be even more usefull to have SAT VS LUMA and SAT VS SAT sliders, as in Resolve. For me it is one of the most important way to correct the digital feeling of the image.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 06, 2019, 04:30:26 AM
OK so this is getting complex so bare with me with all the different issues :P

1) as expected rec709 in resolve (as selected on the raw panel) and in MLV App looks completelly different. The one in Resolve is way darker : https://imgur.com/a/RkNOEY0

2) After your explanation Ilia I've discovered that I can select Linear for the gamma in the raw panel, select a linear to rec709 in the 3d out table (or as a last node), do a curve in one of the nodes and get almost exactly what we get with tonemapped/standard/film. This is to be expected since I've basically replicated your workflow but it is mindblowing to me than starting from a linear gamma can give such good and easy to manover results. I had heard so many times from colorist "put your rec709 conversion at the end of the pipeline" but never really got those easy results with other options. I was always selecting bmdfilm/gamma to start with etc I'm in shock! thanks.

3) I've isolated the bug "Could not read VIDF image data from:  /Volumes/DNG/etc etc/RAW/M30-1357.MLV" . Actually it never went I way, I had thought to have manage to export the problematic clip (from mlv to compressed mlv) but I was mislead by the fact than when you click once a video in the left panel it actually doesn't do anything, you have to duble click to select. Shouldn't this be changed?
Anyway the error present itself in files that seems to have a black frame at the end, thing is than when exporting to lossless dng everything goes fine. I'll try to upload the mlv to test.



edit: And now I understand why we had to do that very convoluted thing in order to use highlight recovery!! It is because the lighten curve in standard/film/tonemapping is actually crushing the image so in order to get that dinamic range back you have to do all that procedure. We were fighting the curve, now I get it. :)
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on January 06, 2019, 10:22:19 AM
@togg

Quote from: togg on January 06, 2019, 03:18:34 AM
Also I've noticed that at the beginning of a batch all the MAPP files are created. It shouldn't be hard to extrapolate this as a feature, right?
Nope, they aren't. They created when each clip is loading.

E.g. when batch processing:
1st clip loaded, if MAPP not present it created, clip is processed, finished with this clip (closed)
2nd clip loaded, if MAPP not present it created, clip is processed, finished with this clip (closed)
and so on...

Quote from: togg on January 06, 2019, 03:18:34 AM
Anyway the error present itself in files that seems to have a black frame at the end, thing is than when exporting to lossless dng everything goes fine. I'll try to upload the mlv to test.
Yes, upload that clip somewhere please.

bb
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 06, 2019, 03:14:04 PM
Quote from: togg on January 06, 2019, 03:18:34 AM
Also I've noticed that at the beginning of a batch all the MAPP files are created. It shouldn't be hard to extrapolate this as a feature, right?
MAPP files are only created when clips are loaded. In export they are loaded in the beginning to get the frame count - ETA calculation needs this.

Quote from: togg on January 06, 2019, 04:30:26 AM
... Actually it never went I way, I had thought to have manage to export the problematic clip (from mlv to compressed mlv) but I was mislead by the fact than when you click once a video in the left panel it actually doesn't do anything, you have to duble click to select. Shouldn't this be changed? ...
No, otherwise it won't be possible to export more than one and less than all clips at once. Selection would be broken.

Quote from: togg on January 06, 2019, 04:30:26 AM
edit: And now I understand why we had to do that very convoluted thing in order to use highlight recovery!! It is because the lighten curve in standard/film/tonemapping is actually crushing the image so in order to get that dinamic range back you have to do all that procedure. We were fighting the curve, now I get it. :)
The highlight is crushed before (-> when recording in the camera). But in relation to slider settings it is visible or not.

Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 06, 2019, 03:34:37 PM
Quote from: bouncyball on January 06, 2019, 10:22:19 AM
@togg
Nope, they aren't. They created when each clip is loading.

Quote from: masc on January 06, 2019, 03:14:04 PM
MAPP files are only created when clips are loaded. In export they are loaded in the beginning to get the frame count - ETA calculation needs this.

Then is it possible to extrapolate this feature as a batch MAPP creation ?
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 06, 2019, 05:09:44 PM
Quote from: togg on January 06, 2019, 04:30:26 AM
1) as expected rec709 in resolve (as selected on the raw panel) and in MLV App looks completelly different. The one in Resolve is way darker : https://imgur.com/a/RkNOEY0

This should be down to the fact that 0 exposure in MLV App is actually +1.2 stops, did this because all traditional raw converters like lightroom seem to do this to enhance the feeling of recoverable highlights (I think it even matches the in camera preview image more).

If you set exposure down to -1.2 (approximately) it should look much closer than current result, maybe even almost identical. Way different doesn't need to be expected.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 06, 2019, 05:21:40 PM
Quote from: bouncyball on January 06, 2019, 10:22:19 AM
Yes, upload that clip somewhere please.

bb

Here it is, uncompressed MLV causing the error ""Could not read VIDF image data from:  /Volumes/DNG/etc etc/RAW/M30-1357.MLV" when exporting to compressed MLV.

https://www.mediafire.com/file/grs8chz690p7q1p/M30-1357.MLV/file

But even more important I've found on my library a problematic MLV (uncompressed) that causes that terrible error of a few pages ago "could not export frame" etc etc. Only this time it is consistent, it isn't for sure a IO error and there's no way to actually export those frames. I can't even cut the MLV, it crashes if I try to do so. It is 1.4 GB, I'll see where I can load it.

Quote from: Ilia3101 on January 06, 2019, 05:09:44 PM
This should be down to the fact that 0 exposure in MLV App is actually +1.2 stops, did this because all traditional raw converters like lightroom seem to do this to enhance the feeling of recoverable highlights.

If you set exposure down to -1.2 (approximately) it should look much closer than current result, maybe even almost identical. Way different doesn't need to be expected.

Ooh, I see. I guess that most non pro app are noticing the general way of underexposure on digital images (caused by a multitude of reasons) and give this boost.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 06, 2019, 06:29:03 PM
An update from my workflow.

I went for a Master export (ProRes 444) from Resolve with bmd gamma, -3 sat, highlight recovery. I have to do this since my roundtrip from fcpx doesn't work. Using MLV App exclusevelly for dng extraction.

Then I'm using a bmd to cinema camera v2 rec709 conversion as a last node on the ProRes files in davinci. Works extremelly well!
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 06, 2019, 07:40:12 PM
Quote from: togg on January 06, 2019, 03:34:37 PM
Then is it possible to extrapolate this feature as a batch MAPP creation ?
Sure: export all clips to any format. Press abort as soon as ETA displays a time. Ready. Now you've only created MAPP files.

For your clip: last frame seems to be corrupted. If you look at last frame, all is black - no picture. If you export without last frame it works perfectly. How data looks exactly in this clip I have to take a look...

Edit: VIDF blocksize and all other variables = 0 ... no data for last frame available?!
(https://i.ibb.co/PT0HTwc/Bildschirmfoto-2019-01-06-um-19-52-11.png)
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 06, 2019, 08:33:42 PM
Quote from: masc on January 06, 2019, 07:40:12 PM
Sure: export all clips to any format. Press abort as soon as ETA displays a time. Ready. Now you've only created MAPP files.

I'll do that :) Still not very user friendly for one of the most important features to view daily at the end of a shooting day!

Quote from: masc on January 06, 2019, 07:40:12 PM
For your clip: last frame seems to be corrupted. If you look at last frame, all is black - no picture. If you export without last frame it works perfectly. How data looks exactly in this clip I have to take a look...

Edit: VIDF blocksize and all other variables = 0 ... no data for last frame available?!
(https://i.ibb.co/PT0HTwc/Bildschirmfoto-2019-01-06-um-19-52-11.png)

This is a big issue though. I have multiple MLV files that have one last empty frame. I can't check all of them and change out point etc just to do a batch export. The software should be able to notice one last black frame at the end, skip it, and move on.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 06, 2019, 08:49:27 PM
Quote from: togg on January 06, 2019, 08:33:42 PM
I'll do that :) Still not very user friendly for one of the most important features to view daily at the end of a shooting day!

This is a big issue though. I have multiple MLV files that have one last empty frame. I can't check all of them and change out point etc just to do a batch export. The software should be able to notice one last black frame at the end, skip it, and move on.
One of the most important features?! ... we are talking about a processing app (main feature).

MLVApp is correct here, telling you that you're file is corrupted. A corrupted frame can be everywhere in a clip, not only at the end. Automating such issues(behavior with corrupted files) and doing something nobody really knows is no solution in my eyes. A round trip also can't work error free when doing "something". You better should try another magic lantern build and test if you produce less corrupted clips/frames with your camera, or correcting your corrupted clips manually. That's the only solution to really get what you want.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 06, 2019, 09:39:19 PM
New most important feature added: MAPP batch creation.  :P
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 06, 2019, 10:04:55 PM
Quote from: masc on January 06, 2019, 08:49:27 PM
One of the most important features?! ... we are talking about a processing app (main feature).

MLVApp is correct here, telling you that you're file is corrupted. A corrupted frame can be everywhere in a clip, not only at the end. Automating such issues(behavior with corrupted files) and doing something nobody really knows is no solution in my eyes. A round trip also can't work error free when doing "something". You better should try another magic lantern build and test if you produce less corrupted clips/frames with your camera, or correcting your corrupted clips manually. That's the only solution to really get what you want.

Wait, maybing I'm doing things differently than any other, no prob then, really :P But how are you viewing your file before conversion? Are you doing it or you wait for the ProRes to come out (ideal, I agree)?

This is a standard shooting day for me, both documentary and fiction wise.

I shoot doring they day then I come back home and need to view the footage again to understand if everything went well, either catching a moment or see if the actress found her line in one of the 4 takes etc etc I need to cycle between takes on those moments, it is important to have like an uninterrupted viewing. Or maybe you are still using mlrviewer for that? Point is, as you said, MLV App needs the MAPP files even for processing! So basically MAPP files are needed for everything! You can't even touch the files without the associate MAPP file, now that I think of it they should almost be created on import. From my perspective it would be the most userfriendly and logical thing, but then again I'm not aware of other people setup, it's not like I'm judging it, I'm curious to know when people *don't* need MAPP files. Maybe the frame previewed on the left is enough for people to understand what to export and what not?


For how to deal with errors I disagree with you. Yes I've changed build a few months ago, went the compressed route which is more stable, but I still feel Magic Lantern outputs a lot of corrupted frames and such. It was always the case and probably will always be. I had a fairly recent build on the project of that file, still there're multiple instances where a black frame is present at the end. Reviewing every single files to be sure that your batch export will not get stuck during the night it's not really feasible imho. It would be wonderfull if Magic Lantern wasn't so proned to corruption but it is, at least if you shoot thousand of GBs of footage.


edit: I've a doubt, which camera don't suffer from vertical stripes? Is it camera dependent or build, resolution or something other? I was wondering why it is off by default in MLV App, I am under the impression that it is a standard problem for Canon sensors.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 06, 2019, 10:21:29 PM
Quote from: togg on January 06, 2019, 10:04:55 PM
But how are you viewing your file before conversion? Are you doing it or you wait for the ProRes to come out (ideal, I agree)?

Yes, exactly. First I render proxy of all files (MLVApp). Then I cut (NLE). Then I only correct the used files (import via fcpxml import feature) (MLVApp) and relink in NLE.

Quote from: togg on January 06, 2019, 10:04:55 PM
Point is, as you said, MLV App needs the MAPP files even for processing!

No, it doesn't. MLVApp creates MAPP files if option is enabled and a clip is loaded. This happens on export for all files in a session if all files were marked. For processing it isn't needed at all.

Quote from: togg on January 06, 2019, 10:04:55 PM
So basically MAPP files are needed for everything!

No, MAPP files are only needed for faster loading of large files. No other feature.

Quote from: togg on January 06, 2019, 10:04:55 PM
You can't even touch the files without the associate MAPP file, now that I think of it they should almost be created on import.

?! Sure you can. I nearly always have MAPP disabled and still can use all features of MLVApp. I only enable it if I have clips >5min or if clips are on old slow HDDs for faster loading. If the clips are smaller or I work on SSD I feel no difference.

Quote from: togg on January 06, 2019, 10:04:55 PM
For how to deal with errors I disagree with you. Yes I've changed build a few months ago, went the compressed route which is more stable, but I still feel Magic Lantern outputs a lot of corrupted frames and such. It was always the case and probably will always be.

That is sad. I don't remember having a corrupted frame over 5 years using ML on my 5D2.

You now can compile latest commit version with batch MAPP creation feature. Maybe someone else is happy about it...
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 06, 2019, 10:38:30 PM
Quote from: masc on January 06, 2019, 10:21:29 PM
No, MAPP files are only needed for faster loading of large files. No other feature.

You're right, sorry I got confused, but when MAPP file are not created it means that MLV App is indexing and storing the info in the background right?I mean an indexing is needed, either wrote on a MAPP file or invisible. This is why I feel that it would be more logical to have it done on import. But for me the batch MAPP (hacked with the export thing or as a feature) will be enough :P It is mostly a concern for new users.

Got it for your workflow, problem for me is that the export of a day of shooting takes multiple hours, so basically I have to let it run during the night. Which would be similar to film processing workflows where dailies where watched on next morning :)
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 06, 2019, 10:48:24 PM
Quote from: togg on January 06, 2019, 10:38:30 PM
You're right, sorry I got confused, but when MAPP file are not created it means that MLV App is indexing and storing the info in the background right?I mean an indexing is needed, either wrote on a MAPP file or invisible. This is why I feel that it would be more logical to have it done on import. But for me the batch MAPP (hacked with the export thing or as a feature) will be enough :P It is mostly a concern for new users.

Got it for your workflow, problem for me is that the export of a day of shooting takes multiple hours, so basically I have to let it run during the night. Which would be similar to film processing workflows where dailies where watched on next morning :)
Indexes will - no matter what you do - be loaded into RAM, with or without MAPP file. Without MAPP file indexes have to be searched in MLV, with MAPP file they can be read out from MAPP file. You mustn't be worry about "export hack" anymore... feature is now there ;)

If you need to watch your clips immediately in realtime, you should do this with MlRawViewer. This is why there is the "Open in external application" feature. If you just like to check if the focus or exposure is correct, you should be able to do that in MLVApp without export.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 06, 2019, 11:08:38 PM
OK perfet then! Thanks ^^

(I was trying to ditch mlrawviewer since it is so outdated and unreliable with audio etc.)
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on January 07, 2019, 01:33:05 PM
Quote from: togg on January 06, 2019, 10:38:30 PM
This is why I feel that it would be more logical to have it done on import.
One more clarification: It is done exactly on import.

Now what does it mean. When one MLV is to be loaded it needs indexing, e.g. find all video and audio frame offsets to sort by time and easily access post loading. Indexing is pricey operation because it needs the MLV to be checked frame by frame (block header by block header) from the beginning to the end! The MAPP is the all of the found info sorted and written into separate file followed by audio data at the end if such exists. Second time when same MLV is imported MAPP presence is checked and if exists all info loaded from it not the huge MLV. This saves a lot of time on slower HDDs (even SSDs if file is big enough).

So what we do is when selected clips are more than one, all but the last clip are read in just preview mode (MLV searching stops after 1st video frame found) to generate only thumbnail. The last imported MLV in the session list is the default selected one and it will be read wholly.

hope this helped
bb

@masc: during export for ETA calculation do you really read all MLVs twice?!
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 07, 2019, 03:01:19 PM
Quote from: bouncyball on January 07, 2019, 01:33:05 PM
@masc: during export for ETA calculation do you really read all MLVs twice?!
Yes, I read it once for ETA calcluation (read the frame count) in the beginning and then a second time to render all frames. I have no better idea how to get frame count of all MLVs.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on January 07, 2019, 07:03:12 PM
Quote from: masc on January 07, 2019, 03:01:19 PM
I have no better idea how to get frame count of all MLVs.
Yeah that's right. Even if you will only read start of the file and get frame count from MLV header block (it can be a bit off +-15frames for older MLVs recorded by mlv_rec.mo) the value represents frame amount of the current chunk only :(

For getting the total amount of session frames I do not have other solution either...
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on January 11, 2019, 12:20:58 PM
Here´s a dualiso attempt coming from eosm and it´s 1x3 mode setting. Recorded in:
10bit,
sd_uhs,
24 fps,
dualiso 100/1600,
1600x2040(2.35:1)


mlv sample:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/1x3_dualiso_eosm_M11-1209.MLV

(https://i.postimg.cc/28RwbFXb/Screenshot-2019-01-11-at-12-12-16-png-scaled.png)

(https://i.postimg.cc/MK7YyMhs/Screenshot-2019-01-11-at-12-11-53-png-scaled.png)



Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 11, 2019, 12:31:08 PM
Wow! That looks awesome! How long are you able to record with the EOS M using these settings?
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on January 11, 2019, 12:38:51 PM
I tested a few seconds but seemed continuous. If not lowering res a bit will be without interrupts.
I ran framing preview on so turning that off should be even better.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 16, 2019, 06:58:06 PM
Are we sure vertical stripe removal actually work? I'm consolidating the doubt that it doesn't, I have to test it more but looking at my clips doesn't seems like the parameter is kickin in, should check hot pixel as well mmm
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 16, 2019, 07:25:26 PM
I have the stripiest camera in the world and I can confirm it works.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 16, 2019, 08:15:26 PM
And I have the 2nd stripiest camera here... works fine.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on January 16, 2019, 10:12:36 PM
i've gotta say, it never works for me either.  i stopped trying long ago.

it introduces strange lines and generally looks bad.  i put it down to not being intended for the stripes i get from the gain reduction hacking i do...

or maybe it doesn't work properly with the 5d3?

or maybe just mine  :P
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 16, 2019, 10:38:54 PM
I have a 5D3 as well, will test.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 16, 2019, 11:05:40 PM
Quote from: 70MM13 on January 16, 2019, 10:12:36 PM
i've gotta say, it never works for me either.  i stopped trying long ago.

Probably was still broken when you stopped.

Some time ago it had a problem where it only worked for 14 bit footage, but that is now fixed. Try it. If it does not work send us a file.

Same for you @togg, sample file would be great
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 17, 2019, 08:09:46 AM
I have testclips from many camera's and they are working all - except one single file doesn't, but another file from same camera type works well. Not working files help us to debug and analyze.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on January 17, 2019, 10:51:55 AM
Yup, give us assets to chew on :)
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on January 18, 2019, 04:05:06 PM
Can we make visual markers for in and out points in the timeline?

That way its easy to see the range of in and out cuts
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on January 18, 2019, 04:28:03 PM
Quote from: Lars Steenhoff on January 18, 2019, 04:05:06 PM
Can we make visual markers for in and out points in the timeline?

That way its easy to see the range of in and out cuts
+1
If we can also adjust the range from these markers it will be great too.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 18, 2019, 07:32:56 PM
Quote from: Lars Steenhoff on January 18, 2019, 04:05:06 PM
Can we make visual markers for in and out points in the timeline?

That way its easy to see the range of in and out cuts
I wanted to do this since a long time. But there is no standard element which allows to do so. Atm we use already a modified QSlider element, because the Qt standard element don't allows all we want to do with the element. I don't want to say it is impossible to implement that... but have a look into the QtDoc what QSlider is able to do already - and we need around 3x the functionality. It will lead to implementing a very complex GUI element ourself, with all neccessary user and api events. So if someone is motivated in doing so, feel free to help.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on January 18, 2019, 08:24:34 PM
This is what I could find, don't know if its helps because I don't have experience yet with qt

https://www.qtcentre.org/threads/64192-Timebar-Widget-What-is-the-best-approach-to-implement-this-in-Qt
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 18, 2019, 08:45:16 PM
Quote from: Lars Steenhoff on January 18, 2019, 08:24:34 PM
This is what I could find, don't know if its helps because I don't have experience yet with qt

https://www.qtcentre.org/threads/64192-Timebar-Widget-What-is-the-best-approach-to-implement-this-in-Qt
Hm, what they write is more or less how I created the diagram widgets. But these ones I could style different to the sliders and user input is way easier than for this timeline widget. To make it look good, you would have to clone the style somehow, have to reimplement QSlider functionality, the modified functionality plus adding the additional functions for the markers. In the end all has to work together.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on January 18, 2019, 09:53:18 PM
I'm not of much help with code, but perhaps a mock-up would help.
I made it like the same slider as before but with two points, don't know if thats possible in QT

Default is all range and range sliders at the edges of the timeline.

(http://www.larssteenhoff.com/forum_pics/timemarkers)

With arrow over current selected timeframe
(http://www.larssteenhoff.com/forum_pics/timemarkers2)
(http://www.larssteenhoff.com/forum_pics/timemarkersallrange)

I made a timeline indicator icon you can use:

http://www.larssteenhoff.com/forum_pics/timline_indicator.png
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on January 19, 2019, 03:43:47 PM
ok, i finally got a chance to try the stripes fix again, and you're right, it's fixed now.

meaning it doesn't make the footage worse.

but it doesn't do anything at all for my footage, which is better than ruining it!  :P

as i conjectured above, it's probably because the stripes from the reduced gain hack are very different.  it doesn't matter because these stripes are buried so deep in the shadows that i'll never see them.

but i can confirm the tool no longer has any negative side effects here!

PS: while everyone's asking for new features, here's one from me:

can we have additional curves in series, when needed?  in resolve this is a beautiful benefit of using nodes.  just add another node and you have a new curve to make fine adjustments without disturbing the first curve.

if this can be done, it would be a tremendous increase in the grading capability of mlvapp.  maybe add some kind of keyboard shortcut to switch between the curves, such as ALT-1, ALT-2, etc...?

mlvapp will soon be unbeatable!

thanks for all your hard work!
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 19, 2019, 03:50:17 PM
Quote from: 70MM13 on January 19, 2019, 03:43:47 PM
nodes

coming soon
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on January 19, 2019, 04:04:28 PM
i love you guys!
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 20, 2019, 01:35:00 PM
I've uploaded two samples, if you bring the exposure of the dng up in resolve with a simple curve you'll see the vertical stripes inside the black shadow casted on his neck and in the sky.
I've tried 3 exports: no vertical stripes correction / normal / forced. The dng output (lossless) is identical in the three cases. I didn't test the hotpixels yet but I'm afraid it could be the same.

https://www.mediafire.com/file/r2h5j8ml51fed6t/M02-0127.MLV/file

https://www.mediafire.com/file/1x5cc0qfdrkq3ay/M06-0445.MLV/file
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 20, 2019, 03:06:04 PM
Quote from: togg on January 20, 2019, 01:35:00 PM
I've uploaded two samples, if you bring the exposure of the dng up in resolve with a simple curve you'll see the vertical stripes inside the black shadow casted on his neck and in the sky.
I've tried 3 exports: no vertical stripes correction / normal / forced. The dng output (lossless) is identical in the three cases. I didn't test the hotpixels yet but I'm afraid it could be the same.

https://www.mediafire.com/file/r2h5j8ml51fed6t/M02-0127.MLV/file

https://www.mediafire.com/file/1x5cc0qfdrkq3ay/M06-0445.MLV/file

That looks like fixed pattern noise, try a dark frame. The stripes look uneven, unlike magic lantern defined "vertical stripes", which are most noticeable in highlight areas and repeat every 8 pixels.

Could be wrong that was first impression. See what bouncyball thinks.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 20, 2019, 03:46:45 PM
Ooh! I have to learn how to use darkframes then. Any tutorial?
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ibrahim on January 20, 2019, 04:04:43 PM
Hi guys,

I have a x5 1:1 3.5K footage in 12 bit lossless that I want to export in this app. Which export setting is the most recommended while using apple prores 4444 in win10?
I am referring to which debayer and smooth aliasing options I should use.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 20, 2019, 04:25:06 PM
@togg: for me this also does not look like vertical stripes as it is defined. Darkframe could solve it, or at least make it a little better.
1. Record with identical settings and identical equipment a clip with lens cap mounted. Some seconds are enough.
2. Import MLV into MLVApp.
3. Export this file as MLV, Averaged Frame.
---- Now you have your darkframe.
4. Import your clip.
5. Go to RAW Corrections, press darkframe folder icon and select your darkframe.
---- Look, if it becomes a little better.

@ibrahim: there is no best setting for all clips. This is why all these options exist. Mostly AMaZE is best, but not always. Try out the other debayer algorithms for all clips, if you like (you should do in the edit pane, because if one clips looks good with IGV, the next could be look aweful with it. In export settings, you could override this setting, but I recommend using "Receipt Configuration" - this is what you set in edit pane.)
Smooth aliasing is for clips with a slight movement which have bad moiree / aliasing artifacts. Note: if you use it, it is slow - you'll need a lot of rendering time!
Let your eyes decide which setting is best for each clip.

Quote from: Ilia3101 on January 19, 2019, 03:50:17 PM
coming soon
;D
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 20, 2019, 07:06:17 PM
Thanks masc! I'll do it next time, sounds usefull. Does processing time take a big hit?
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 20, 2019, 07:17:14 PM
Processing time should not raise much. It is just a subtraction for each pixel... so nothing difficult ;)
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 23, 2019, 10:00:32 PM
I added another demosaicing algorithm to MLVApp: AHD. The base seems to be the same as used in ACR, because the produced moiree and interference picture is mostly identical. So... if you are in love with ACR debayer artifacts, try it out! :D

Another news: some data conversion before and after debayering is now changed for AMaZE, IGV and LMMSE. This mostly brings even more quality to the debayered result than before. This is very useful for 1x3 clips, because many many artifacts are completely gone now!
As far as I know, only our LMMSE implementation has some little problems with some clips - I get some colored dots randomly all over the picture for (mostly) lossless <14bit clips... If someone has an idea what could be wrong there, please let me know!
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on January 23, 2019, 10:11:33 PM
Awesome, will test tomorrow.
Lmmse dots. I got them as well when experimenting before. All I did was reducing a place around white balance but it was clearly very sensitive to small changes. Sorry I can't be more clear on this.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on January 23, 2019, 11:22:57 PM
any improvements to demosaicing are most welcome!

Masc, I have a clip that NO demosaicing algorithm on any program has ever worked properly on.  I'll dig it up and send you a frame from it just to have as a reference...
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: megapolis on January 25, 2019, 06:05:21 AM
Could you please send that frame for me as well?
Thanks.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: canneloni on January 25, 2019, 02:53:16 PM
Is there an option to set a default folder for darkframes and MLV App automaticly selects the right darkframe for the clip, similar to how mlv_dump does?
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 25, 2019, 04:42:27 PM
Quote from: canneloni on January 25, 2019, 02:53:16 PM
Is there an option to set a default folder for darkframes and MLV App automaticly selects the right darkframe for the clip, similar to how mlv_dump does?
No.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: rakkham on January 27, 2019, 03:13:29 PM
Hi everyone.

Thanks a lot for this AMAZING app, truly.

Only concern while playing with it is the scaling factor on linux. Any idea how to force a x2 scaling factor on ubuntu ? (looking small on my 4K screen).
Thanks a lot !!!
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 27, 2019, 07:39:44 PM
Use this command or add it to desktop file:
QT_SCALE_FACTOR=2 ./mlvapp

You can use fractional values like 1.5, but they make the video display pixely, so 1 or 2 is best.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 27, 2019, 09:47:00 PM
Quote from: Ilia3101 on January 27, 2019, 07:39:44 PM
Use this command or add it to desktop file:
QT_SCALE_FACTOR=2 ./mlvapp

You can use fractional values like 1.5, but they make the video display pixely, so 1 or 2 is best.
Cool! Does this transfrom each pixel to 2x2 pixels (4x the same) or does it render "sharper" like on retina displays on OSX?
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 27, 2019, 10:30:16 PM
It actually renders properly, looks very very nice:

(https://i.ibb.co/DQsJCh5/Screenshot-from-2019-01-27-21-27-34.png)

though 2x is too big  for my screen so I use at 1x
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on January 28, 2019, 08:16:46 AM
Quote from: Ilia3101 on January 27, 2019, 07:39:44 PM
QT_SCALE_FACTOR=2 ./mlvapp
Huh! I loved it! Makes it look like on retina display (which is actually IS 2x2 real pix -> 1 gui pix), very crisp! :D
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 31, 2019, 09:02:07 AM
v1.5 is out:
- Optimized demosaicing results for AMaZE and IGV
- Changed 0.33x vertical resizing from downscaling to upscaling
- Added AHD demosaicing algorithm
- Added "Create all MAPP files" action for all clips in session
- Added uncompressed avi with pix-fmt bgr24
- Some bug fixes and some minor changes
Have fun!
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 31, 2019, 09:30:04 AM
first download is mine! thanks :)
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Cipolippo on January 31, 2019, 12:47:36 PM
Thanks  thanks..Please add support for dcp profile...  :-*
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 31, 2019, 12:56:06 PM
Quote from: Cipolippo on January 31, 2019, 12:47:36 PM
Thanks  thanks..Please add support for dcp profile...  :-*
DCP = DNG camera profile. We are working on MLV files. Input should be DNG, generated by Adobe Tools (in order to get correct output). Support is not possible.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on January 31, 2019, 01:30:12 PM
excellent update!
the enhancements and additions to the demosaicing are very nice.

someone mentioned running multiple instances to speed up rendering jobs.  would it be possible to add some kind of (automated?) job control to do this, perhaps with a simple option to choose how many to spawn, unless it is possible to autodetect the number of threads available on all platforms?

the results i'm getting with the linear setup are so good that i now prefer mlvapp to resolve!

need...faster...rendering...

;)
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 31, 2019, 01:37:11 PM
Quote from: 70MM13 on January 31, 2019, 01:30:12 PM
excellent update!
the enhancements and additions to the demosaicing are very nice.

someone mentioned running multiple instances to speed up rendering jobs.  would it be possible to add some kind of (automated?) job control to do this, perhaps with a simple option to choose how many to spawn, unless it is possible to autodetect the number of threads available on all platforms?

the results i'm getting with the linear setup are so good that i now prefer mlvapp to resolve!

need...faster...rendering...

;)
The easy solution you wrote here. Create multiple instances of the app and export with them.
The harder solution is writing a new MLVApp - or at least rewrite a big part of it. And this might only help on systems with many processors. On my 2 Core or 4 Core I already have 100% activity when exporting.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on January 31, 2019, 01:43:50 PM
sorry, i guess i didn't clearly state that i was thinking about a job control utility, as in a separate applet that would call x number of mlvapps to do a batch render.

someone wrote something like this for blender long ago...
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 31, 2019, 01:57:10 PM
I understand what you mean. Someone had this idea already a year ago here in the forum. But here it would really mean a very big redesign. And all we did until now regarding multithreading could be deleted again.
Title: Re: MLV App 1.4 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on January 31, 2019, 02:16:32 PM
ok then, how about this?

a function to automagically generate x number of partial sessions from the one currently loaded to facilitate doing multiple instances manually.

it can be tedious to do this by hand, especially with a long shot list.

it is not a hassle if you are only doing 2 incarnations, in fact it is nice and easy.  just load the same session and choose the first or second half of the list.  but what if you are doing 8? 16? 32? (thread ripper users)

just thinking out loud.

even doing 2 by hand cuts the time in half, but that threadripper user would be sad to be using 2 out of 32 :P
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on January 31, 2019, 02:46:56 PM
Curious to see some debayer comparison if someone wants to do it!

For me one of the feature still missing is an automatically skip problematic frames. Yesterday I had another episode like that that stopped the export, a black frame at the end of one clip when the camera stopped because of a full CF. I had forgot about it and MLV stopped during export. Would be nice to have an option to have this skipped automatically, could be very usefull imho.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on January 31, 2019, 04:57:46 PM
Quote from: togg on January 31, 2019, 02:46:56 PM
Curious to see some debayer comparison if someone wants to do it!
In our wiki there is a comparison. And there are many many comparisons out in the net. But note that for each clip the result might be very different! There is no "best debayer". It depends on situation.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 31, 2019, 08:42:44 PM
Quote from: masc on January 31, 2019, 04:57:46 PM
There is no "best debayer"

But generally AMaZE...
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on February 01, 2019, 08:01:15 AM
Quote from: masc on January 31, 2019, 01:37:11 PM
The easy solution you wrote here. Create multiple instances of the app and export with them.

Incidentally this may not be ideal but I've made two extra (three was too much for my 2012 MBP 2.6 GHz i7 16GB to handle) copies of MLV Apps on the desktop and can 'multithread' by running all three at once. Just beware of your machine singing its praises!  :D

Quote from: togg on January 31, 2019, 02:46:56 PM
...one of the feature still missing is an automatically skip problematic frames.....Would be nice to have an option to have this skipped automatically, could be very usefull imho.

+10

Basically my recent experience w 1.4 went from an ETA of 96 hours countdown for 1.1 TB worth of MLV's to a mere 9 days and still counting... Waking up in the mornings every now and then seeing MLV App had crashed overnight or at least until to the next day if not second. This app is still so fkin' good that I want to keep it going regardless of this gruesome dreadful time consuming never-ending roundtrips of horror.  :P

I know, I know... technically speaking this isn't up to par for paid gigs (just yet) but hey I forced myself to go 100% on MLV App just for this small project of mine. Very happy with the grade and noise reduction is indeed quite impressive. Even for footage shot in ISO 6400 without using DF Avg. No need for Neat.  8)

Still haven't wrapped my head around the DF feature within MLV App yet. Will get to that point once I am done with this project and thank you all for your continuous support!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on February 01, 2019, 09:11:05 AM
Quote...one of the feature still missing is an automatically skip problematic frames.....Would be nice to have an option to have this skipped automatically, could be very usefull imho.

Is the problems happens due to mlv_dump code it should be possible to insert the "relaxed" mode skipping files right bouncyball?
If in ffmpeg the syntax could be changed to pass on missing files I believe.
Who knows where the issue lays?

Wildcard pass in ffmpeg?
ffmpeg -f image2 -i %*.jpg out.mov /*example*/
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 01, 2019, 10:29:18 AM
Quote from: DeafEyeJedi on February 01, 2019, 08:01:15 AM
Incidentally this may not be ideal but I've made two extra (three was too much for my 2012 MBP 2.6 GHz i7 16GB to handle) copies of MLV Apps on the desktop and can 'multithread' by running all three at once. Just beware of your machine singing its praises!  :D
This is exactly the reason why I won't do it. Multiprocessing of inner processing is fighting against all other programs running at the same time.

Quote from: DeafEyeJedi on February 01, 2019, 08:01:15 AM
Basically my recent experience w 1.4 went from an ETA of 96 hours countdown for 1.1 TB worth of MLV's to a mere 9 days and still counting...
OMG! What crazy features are you using at the same time (dualiso?)?! The longest rendering time for 500GB was ~10hours for me (on my 8 years old i5)! :D


The problem aborting at corrupted frames was discussed many times here already. Mostly a corrupted file can't be handled for roundtrips, audio does not fit to video, linking does not work, etc. ... these are only some of the reasons why bouncyball and I decided to aborted export for corrupted clips. If just the last frame is currupted, this might be a a special case - but even than it leads very often to linking issues when working with Resolve or FCPX.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on February 01, 2019, 10:57:32 AM
How about inserting a black frame for every detected corrupted frame?
General question. Is a corrupted frame in one MLV file aborting the whole batch process in MLV app? If not I could live without the export of corrupted files although cool if it would work with black frames.

On a side note. I tried multi rendering on dual iso files since those are really slow to process. Flickering occured so had to run processing with only one copy of Mlv App to get comsistent results. Strange. They shouldn´t interfere with each other?
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on February 01, 2019, 11:14:42 AM
There are 18 core macs out there, are you sure you want to limit to just one core?
Seems like a missing performance oppertunity.

Probably I don't understand how it works
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 01, 2019, 11:53:17 AM
Quote from: masc on February 01, 2019, 10:29:18 AM
The problem aborting at corrupted frames was discussed many times here already. Mostly a corrupted file can't be handled for roundtrips, audio does not fit to video, linking does not work, etc. ... these are only some of the reasons why bouncyball and I decided to aborted export for corrupted clips. If just the last frame is currupted, this might be a a special case - but even than it leads very often to linking issues when working with Resolve or FCPX.

For some reason I have never had a corrupted file in MLV App, so I don't have experience, but maybe export should only abort for that one clip that is corrupted.

Maybe put a warning somewhere...

(Our what danne said too)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 01, 2019, 12:05:23 PM
In my opinion, the best way to handle corrupt frames would be to have the algorithm detect corrupt frame number N and replace it with another frame which is interpolated between frames N-1 and N+1.  In that way, the transition would barely be noticeable and sound would not be affected.  Would that be possible to implement or am I dreaming too much?  What do you think, Masc?
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on February 01, 2019, 12:30:40 PM
Quote from: Danne on February 01, 2019, 10:57:32 AM
How about inserting a black frame for every detected corrupted frame?
General question. Is a corrupted frame in one MLV file aborting the whole batch process in MLV app? If not I could live without the export of corrupted files although cool if it would work with black frames.


That is exactly it. It stops the whole batch process, needs a manual interaction. And yes black frames would be the perfect solution, especially because with magic lantern mlv one black frame at the end happens very often for a multitude of reasons.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on February 01, 2019, 12:49:33 PM
Quote from: Danne on February 01, 2019, 10:57:32 AM
How about inserting a black frame for every detected corrupted frame?
General question. Is a corrupted frame in one MLV file aborting the whole batch process in MLV app? If not I could live without the export of corrupted files although cool if it would work with black frames.

On a side note. I tried multi rendering on dual iso files since those are really slow to process. Flickering occured so had to run processing with only one copy of Mlv App to get comsistent results. Strange. They shouldn´t interfere with each other?

This needs to be addressed sooner than later!  I'm just getting into dual iso and that's where we NEED to improve rendering speed.  I suppose we can work around it with VMs, but that's getting a little extreme, no?

Maybe it's time to set up a good old fashioned render farm.  If mlvapp won't take advantage of multi cores, a farm could be made with a bunch of "obsolete" machines, but then some kind of job control will definitely be needed!

I just had a thought:  can mlvapp run in a sandbox?  that might solve Danne's discovery.  also, Danne, were you using different drives for the different instances?  That might be a stretch, but again, I'm just thinking out loud...  I'd test it but i'm in the middle of a job so I can't check until tomorrow.  I will definitely try then...
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 01, 2019, 01:29:24 PM
Hoaa... what's going on here?! :D

I don't think that one MLVApp copy interacts with any other copy. If this happens, it could be a problem of the operating system or a defect HDD. So I don't believe in that. If so, please tell me how to reproduce. But those app copies work 100% independant (if you work on different clips at the same time).

In the last year we worked a lot to get nearly all calculations in MLVApp multithreaded. Maybe it is not optimal here and there how these jobs work together (that means I am sure it isn't), but this is hard to make better. Some single calculations like dualiso are single threaded, because we had still no luck.
Deciding to do a farm means deleting all we did in the past year - making MLVApp singlethreaded again. Otherwise a farm makes no sense. If that is faster?! Maybe. Maybe not. I don't know. And I can't try out. On a dualcore there can be just one export at a time (one thread processing in MLVApp + one thread for ffmpeg), on a quadcore 2, etc....

If MLVApp detects a corrupted frame on export, it asks to abort the export of this clip ot of this batch. It does not crash somehow or does something strange. I would again suggest to try another ML build for your camera. I can't remember having seen a corrupted clip from my cameras since I use them, in a way the export would stop. The export only stops, if the header tells "there is data", but there isn't. Most of other corruptions are bypassed.
Until now we had to build up corrupted clips our self by switch some bytes in good clips. It is always better to fight against the reason and not against the effects.

Edit: for ffmpeg export black frames should already be generated. For cDNG the described messagebox is coming with the buttons "Skip frame, Abort current export, Abort batch export". For MLV export the described messagebox is coming with the buttons "Abort current export, Abort batch export". Until now we don't "generate" frames.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on February 01, 2019, 01:54:36 PM
Retested dual iso, seems to be working with multiple copies of Mlv App. Not sure what was going on before. Was a while since I tested this. My mac book pro almost lifted from the table(fans blowing :-*).
Anyway. I always found multiprocessing faster when exporting through ffmpeg but of course architecture could be a mess to build for this.
Still not clear to me how corruption in mlv files are handled(aborting the whole batch or not) but I think it´s not unthinkable to foresee at least one or two files that will stop the batch party if one has filmed bigger amounts of mlv files. Are we certain Mlv App finds each corrupted file prior to export or could this happen also randomly while exporting?

Edit:
One shit ass idea is to select a group of MLV files in the first Mlv App and right click on this group. The user could here get the question if one wants to open up thos e files in another copy of Mlv App, hehe. Then actual working Mlv App copy itself and move the selected files. Oh man, it´s friday...
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 01, 2019, 02:14:17 PM
Quote from: Danne on February 01, 2019, 01:54:36 PM
Edit:
One shit ass idea is to select a group of MLV files in the first Mlv App and right click on this group. The user could here get the question if one wants to open up thos e files in another copy of Mlv App, hehe. Then actual working Mlv App copy itself and move the selected files. Oh man, it´s friday...

Hahaha... yes. In german this has the name "verschlimm-bessern" (make it worse-better)
* Just a little joke, I know you all want to help. *
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on February 01, 2019, 02:19:34 PM
hehe, anyway. Anamorphic modes on eosm recorded in dual iso as always comes out very, very nice. Bouncyball did some really good job here with getting the dual iso files working with all bits. One should start using the cam more often  :P
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 01, 2019, 03:31:47 PM
Hello everyone!

Quote from: Danne on February 01, 2019, 09:11:05 AM
Is the problems happens due to mlv_dump code it should be possible to insert the "relaxed" mode skipping files right bouncyball?
The mlvapp import has nothing in common with mlv_dump code at all :)

Let me make clear some "corrupted frame" aspects here.
1. mlvapp importer reads bytes from MLV but on that stage does not analyze any frame data itself for corruption.
2. errors come from the fact that _MLV_ itself is corrupted, e.g. specs are violated, header block missing or block size is not matched to the value written in the header etc etc ...
3. error is passed to higher (QT) part of the application, where the proggie (on error) spits out the message box with error and where some actions could be performed (skip, cancel etc).
So it is all about MLV corruption, not the particular frame, hence substitution with black frames is not applicable.

BTW mlvapp has built in brute force method (I've implemented long time ago) if the block header could not be found on common/expected address offset, proggie searches the block name until the end of file. I have one corrupted MLV like this and mlvapp loads it fine, slower though.

Now what can we do: introduce somewhere checking option allowing, on error, stop processing of current MLV (leave all files produced intact) and proceed to the next one without user intervnention. This will finish whole batch despite corrupted MLVs.

Quote from: masc on February 01, 2019, 10:29:18 AM
The problem aborting at corrupted frames was discussed many times here already. Mostly a corrupted file can't be handled for roundtrips, audio does not fit to video, linking does not work, etc. ... these are only some of the reasons why bouncyball and I decided to aborted export for corrupted clips. If just the last frame is currupted, this might be a a special case - but even than it leads very often to linking issues when working with Resolve or FCPX.
I guess only problem here will be with linking as masc described above. But if one let the option (I described above) checked, he/she already agreed that this could happen.

Regards
bb
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 01, 2019, 03:43:38 PM
Quote from: masc on February 01, 2019, 01:29:24 PM
I don't think that one MLVApp copy interacts with any other copy. If this happens, it could be a problem of the operating system or a defect HDD. So I don't believe in that. If so, please tell me how to reproduce. But those app copies work 100% independant (if you work on different clips at the same time).

+1

Should even be independent even if working on the same clip
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on February 01, 2019, 03:45:59 PM
Quote from: bouncyball on February 01, 2019, 03:31:47 PM
Now what can we do: introduce somewhere checking option allowing, on error, stop processing of current MLV (leave all files produced intact) and proceed to the next one without user intervnention. This will finish whole batch despite corrupted MLVs.
I guess only problem here will be with linking as masc described above. But if one let the option (I described above) checked, he/she already agreed that this could happen.
Now we´re talkin´ 8)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on February 01, 2019, 03:54:58 PM
it's awesome to see all you heavyweights in discussion...

Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 01, 2019, 04:02:15 PM
Quote from: Danne on February 01, 2019, 03:45:59 PM
Now we´re talkin´ 8)
;D

Yes, and one more thing, the real single frame corruption can be detected only when decoding wrong lossless raw data by LJ decoder (it spits error that data can not be decompressed). If raw is uncompressed we can not detect corruption until we look at the image on the screen :D
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: mothaibaphoto on February 01, 2019, 04:08:12 PM
Hi, guys, thank you for your great app!!!
Just downloaded 1.5 (win64) and tried black frame subtraction.
1. 1.5 version crashes constantly after processing 502-504 frames on any file (longer than 504 frames).
If process without black frame it not crashes.
2. 1.4 processes that files well, but... just only one and than i need to terminate the app with task manager.
If i try to select another file after processing one, or add several files to batch - it warns
"Could not open file (path to black frame MLV)" then it warns
"Could not open file (path to MLV to process)".
The only way to close this window is to terminate the app.
If process without black frame, it is possible to select any number of files to process
or add to batch and process too.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 01, 2019, 04:11:02 PM
Quote from: Ilia3101 on February 01, 2019, 03:43:38 PM
+1
Should even be independent even if working on the same clip
Haha :) flickering would happen only if we will implement processing of EVEN and ODD frames in mlvapp. Then one instance of mlvapp should process the odd frames with different settings than second instance even frames ;D
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on February 01, 2019, 04:14:24 PM
OK, I am may asking for too much, but since everyone's all here...  8)

The shot I am currently grading couldn't be done in mlvapp (yet?) because the bright red LED is shining right at the camera, and when grading, it just gets too strong and blows out.

In resolve, I was able to avoid the problem by using a "power zone" (selection mask) to isolate it, first by colour, and also by a circle selection tool to make sure nothing else is touched.  I did this on the first node, and then graded with the second node, without changing the led...

Would this be too much to ask?

see image, selecting the colour of the led for the mask


(https://i.ibb.co/J3Rn1Rh/selection-adjust.jpg) (https://ibb.co/J3Rn1Rh)
 
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 01, 2019, 04:18:30 PM
I guess @masc should answer that MASK question ;)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on February 01, 2019, 04:21:04 PM
LOL that's an awesome answer!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 01, 2019, 04:25:46 PM
Quote from: mothaibaphoto on February 01, 2019, 04:08:12 PM
1. 1.5 version crashes constantly after processing 502-504 frames on any file (longer than 504 frames).
If process without black frame it not crashes.
Very odd problem indeed. I have to reproduce this somehow...

Edit: which OS?
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: mothaibaphoto on February 01, 2019, 04:36:22 PM
Quote from: bouncyball on February 01, 2019, 04:25:46 PM
Edit: which OS?

Quote from: mothaibaphoto on February 01, 2019, 04:08:12 PM
...
Just downloaded 1.5 (win64) and tried black frame subtraction.
...
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 01, 2019, 04:38:41 PM
Ah, OK, thanx :).
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 01, 2019, 05:13:19 PM
Quote from: Danne on February 01, 2019, 02:19:34 PM
...One should start using the cam more often  :P
Hehe... oh yes... 95% is implementing this app, 5% is using this app. But hey... in winter it's dark if I could use my cam...

Quote from: 70MM13 on February 01, 2019, 04:14:24 PM
...
The shot I am currently grading couldn't be done in mlvapp (yet?) because the bright red LED is shining right at the camera, and when grading, it just gets too strong and blows out.
...
see image, selecting the colour of the led for the mask


(https://i.ibb.co/J3Rn1Rh/selection-adjust.jpg) (https://ibb.co/J3Rn1Rh)
 
Hm... indeed an interesting task. When I see your picture I first think about the Hue vs. Luma diagram and I would try to darken red tones. Have you tried that? Only because only the LED is red.
Masking is in principle not too complicated - I got that working with the linear gradient function. But this more or less doubled the code needed for those parameters. And the code became somewhat hard to understand - I think Ilia hates me for that ;)
The next question is: in what way we select which areas in the picture? I really like the way it is realized in Resolve. But implementing a 2nd Resolve? I think just using Resolve is easier. It is a great software, if such features are needed!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on February 01, 2019, 05:26:03 PM
It may be possible to do with your idea once nodes are an option...  it would probably require some very precise work in a few stages (nodes) to keep it controlled while increasing the overall gain.

I agree that it may be that resolve is required to do such things, but I thought it would be worth asking anyways.

I really mean it when I say that I now prefer mlvapp (except for these difficult situations)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 01, 2019, 05:30:54 PM
@bouncyball: also tried using darkframe and also got a crash on first try. Somewhere about 200 frames were okay, than OSX told me this:
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        0x00007fff91479866 __pthread_kill + 10
1   libsystem_pthread.dylib        0x00007fff8e24735c pthread_kill + 92
2   libsystem_c.dylib              0x00007fff8e9c4b26 abort + 125
3   libsystem_malloc.dylib        0x00007fff9981207f free + 411
4   magiclantern.MLV App          0x0000000108ec0e29 load_all_chunks + 345
5   magiclantern.MLV App          0x0000000108ebe22a openMlvClip + 106
6   magiclantern.MLV App          0x0000000108efef8a df_load_ext + 218
7   magiclantern.MLV App          0x0000000108ec3af5 applyLLRawProcObject + 53
8   magiclantern.MLV App          0x0000000108ebd8df getMlvRawFrameFloat + 127
9   magiclantern.MLV App          0x0000000108ebd430 get_mlv_raw_frame_debayered + 48
10  magiclantern.MLV App          0x0000000108ebde15 getMlvRawFrameDebayered + 197
11  magiclantern.MLV App          0x0000000108ebdee0 getMlvProcessedFrame16 + 80
12  magiclantern.MLV App          0x0000000108e839af MainWindow::startExportPipe(QString) + 22943
13  magiclantern.MLV App          0x0000000108e9dc56 MainWindow::exportHandler() + 2198

Looks like there is a problem with darkframe loading. Should use debugger next. Clip is really large... (4.5K).
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 01, 2019, 05:49:07 PM
Quote from: masc on February 01, 2019, 05:30:54 PM
@bouncyball: also tried using darkframe and also got a crash on first try.
Yeah... something is wrong and it's wrong from the beginning. I have to try to nail this with valgrind.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 01, 2019, 06:07:14 PM
Hello guys,

I played a little with version 1.5 and I love it!  What a valuable piece of software!  Congratulations to everyone involved.

Recently, I managed to borrow a 5D3 and shot a few test files to check the latest MLVApp.  Here is a file of a high-contrast scene shot in the 1x3 mode at Dual ISO 100/800. 

https://we.tl/t-z6hpWfLjDk

The noise suppression in the darkest areas is generally very good but these magenta fringing artifacts along the straight lines of the laundry stand and the painting on the right are killing me.   Could you guys please have a look?  Thanks.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 01, 2019, 06:08:47 PM
Something in load_all_chunks seems to be wrong using "free". But what? Code looks not wrong. Using debugger the app exports in slow-motion and does not crash. LOL. As usual.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 01, 2019, 06:20:21 PM
Quote from: IDA_ML on February 01, 2019, 06:07:14 PM
Hello guys,

I played a little with version 1.5 and I love it!  What a valuable piece of software!  Congratulations to everyone involved.

Recently, I managed to borrow a 5D3 and shot a few test files to check the latest MLVApp.  Here is a file of a high-contrast scene shot in the 1x3 mode at Dual ISO 100/800. 

https://we.tl/t-z6hpWfLjDk

The noise suppression in the darkest areas is generally very good but these magenta fringing artifacts along the straight lines of the laundry stand and the painting on the right are killing me.   Could you guys please have a look?  Thanks.
Looks like moiree. Using IGV it becomes a little better. But near the painting on the right I don't see something?!
(https://i.ibb.co/x6wxL5X/Bildschirmfoto-2019-02-01-um-18-18-33.png)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 01, 2019, 06:46:15 PM
Masc,

Thanks for testing.

The left bright edge of the painting is pink here when i open it in MLVApp.  It could be just the preview but I am not sure.  It is strange that the artifacts do not appear on the edges of highest contrast but on moderate-contrast ones like on the laundry stand.  And yes, there is a little aliasing but this is normal for the 1x3 reading method.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 01, 2019, 07:06:27 PM
I have just exported a frame using the IGV algorithm.  Here is the result:


(https://i.ibb.co/Gx324YK/5-D3-1x3-1920x3240-DI-100-800-10bit-LL-Artifact.jpg) (https://ibb.co/Gx324YK)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 01, 2019, 07:17:36 PM
Ah... I know. For dual iso clips you should disable Bad Pixel Fix. Because of all the lines the algorithm will often fail. This is without Bad Pixel Fix:
(https://i.ibb.co/FKWGGHw/Bildschirmfoto-2019-02-01-um-19-15-19.png)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 01, 2019, 07:23:36 PM
There is no reason to enable bad pixel fix almost ever, especially if it's dual ISO. No one has noticed my red pixel yet.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 01, 2019, 07:23:48 PM
Quote from: masc on February 01, 2019, 06:08:47 PM
Using debugger the app exports in slow-motion and does not crash. LOL. As usual.
Yup :)

Open all chunks also called when darkframe mlv is loaded (no need for DF but that's how the basic MLV loading function works, which is reused there) so maybe there is hiding something...
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 01, 2019, 07:25:51 PM
Quote from: Ilia3101 on February 01, 2019, 07:23:36 PM
There is no reason to enable bad pixel fix almost ever, especially if it's dual ISO. No one has noticed my red pixel yet.
Right... ;) Except for some cameras like I had in the past (60D) with maybe 50 bad/hot pixels in every frame.

@masc: let's change it to off by default.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: mothaibaphoto on February 01, 2019, 07:34:12 PM
Quote from: bouncyball on February 01, 2019, 07:25:51 PM
@masc: let's change it to off by default.
It would be much better to implement user-defined default settings.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on February 01, 2019, 07:34:41 PM
Quote from: bouncyball on February 01, 2019, 07:25:51 PM
@masc: let's change it to off by default.
Amen.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 01, 2019, 07:49:51 PM
Quote from: bouncyball on February 01, 2019, 07:25:51 PM
@masc: let's change it to off by default.
Done.
Title: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on February 01, 2019, 08:18:10 PM
Quote from: masc on February 01, 2019, 01:29:24 PM
Hoaa... what's going on here?! :D
My baaaaaaad... tehehe!  :-X

Quote from: masc on February 01, 2019, 10:29:18 AM
This is exactly the reason why I won't do it. Multiprocessing of inner processing is fighting against all other programs running at the same time.

Great call @masc!

Quote from: masc on February 01, 2019, 10:29:18 AMOMG! What crazy features are you using at the same time (dualiso?)?! The longest rendering time for 500GB was ~10hours for me (on my 8 years old i5)! :D

Really? That's really surprising... faster than my somewhat few years younger than yours? Only shot less than 10% in Dual-ISO for this little project.

Here are the features I used...

(https://farm5.staticflickr.com/4821/39986732103_4fbfaf8fb2.jpg) (https://flic.kr/p/23Vuskz)(https://farm5.staticflickr.com/4882/46037237405_134ef5fc8f.jpg) (https://flic.kr/p/2d99SLv)(https://farm8.staticflickr.com/7886/33075779318_614889a2c2.jpg) (https://flic.kr/p/SoN1Rd)

Quote from: masc on February 01, 2019, 10:29:18 AMThe problem aborting at corrupted frames was discussed many times here already. Mostly a corrupted file can't be handled for roundtrips, audio does not fit to video, linking does not work, etc. ... these are only some of the reasons why bouncyball and I decided to aborted export for corrupted clips. If just the last frame is currupted, this might be a a special case - but even than it leads very often to linking issues when working with Resolve or FCPX.

This makes perfect sense actually. Because even when I do restart it again and files spits out even with corrupted frames so this may rule out the reason why MLV App crashes during batch exporting? Frustrating but it is what it is and I've accepted the justifications.

Quote from: Danne on February 01, 2019, 09:11:05 AM
Is the problems happens due to mlv_dump code it should be possible to insert the "relaxed" mode skipping files right bouncyball?
If in ffmpeg the syntax could be changed to pass on missing files I believe.
Who knows where the issue lays?

Wildcard pass in ffmpeg?
ffmpeg -f image2 -i %*.jpg out.mov /*example*/

Excellent thinking. This smells like the good old days of Switch, MLP, cr2hdr... love you @Danne!

Quote from: bouncyball on February 01, 2019, 03:31:47 PM
The mlvapp import has nothing in common with mlv_dump code at all :)

Haha that was a bold statement. :)

Quote from: Danne on February 01, 2019, 09:11:05 AM
Let me make clear some "corrupted frame" aspects here.
1. mlvapp importer reads bytes from MLV but on that stage does not analyze any frame data itself for corruption.
2. errors come from the fact that _MLV_ itself is corrupted, e.g. specs are violated, header block missing or block size is not matched to the value written in the header etc etc ...
3. error is passed to higher (QT) part of the application, where the proggie (on error) spits out the message box with error and where some actions could be performed (skip, cancel etc).
So it is all about MLV corruption, not the particular frame, hence substitution with black frames is not applicable.

Thanks for the thorough explanation, BB and this also reminds me to ask does this have anything to do with shooting in Lossless 12-bit while we're at it? I'm only asking because it's happened again this morning... it looks like this.


(https://farm5.staticflickr.com/4902/46898688892_7523d28e36.jpg) (https://flic.kr/p/2esh3hm)

I first thought it had to do with the file name chaging as I shot with three 5D3's and had multiple same MLV number files which then I had to change to prevent overwrite. This was all done before even touching MLV App so I highly doubt this is the issue.

Could it be related to certain large MLV files? like over 7K frames and whatnot? Again after each crash I just simply erase the last corrupted file and redo which then spits out OK.

Quote from: Danne on February 01, 2019, 09:11:05 AM
BTW mlvapp has built in brute force method (I've implemented long time ago) if the block header could not be found on common/expected address offset, proggie searches the block name until the end of file. I have one corrupted MLV like this and mlvapp loads it fine, slower though.

Good to know. Thanks!

Quote from: Danne on February 01, 2019, 09:11:05 AM
Now what can we do: introduce somewhere checking option allowing, on error, stop processing of current MLV (leave all files produced intact) and proceed to the next one without user intervnention. This will finish whole batch despite corrupted MLVs.
I guess only problem here will be with linking as masc described above. But if one let the option (I described above) checked, he/she already agreed that this could happen.

Hmmm.... that's not a bad idea after all. That's like agreeing to take the risk. As we should. Ha!

Quote from: Danne on February 01, 2019, 03:45:59 PM
Now we´re talkin´ 8)
8)

Quote from: bouncyball on February 01, 2019, 04:02:15 PM
;D

Yes, and one more thing, the real single frame corruption can be detected only when decoding wrong lossless raw data by LJ decoder (it spits error that data can not be decompressed). If raw is uncompressed we can not detect corruption until we look at the image on the screen :D

So it does have to do with the fact that I shot everything on this project in 12-bit lossless? I didn't even know I had corrupted frames with files (especially coming from a 5D3) but I was using an experimental build obviously to get the bleeding edge. hehe.

Quote from: bouncyball on February 01, 2019, 04:11:02 PM
Haha :) flickering would happen only if we will implement processing of EVEN and ODD frames in mlvapp. Then one instance of mlvapp should process the odd frames with different settings than second instance even frames ;D
:)

Quote from: Danne on February 01, 2019, 02:19:34 PM
hehe, anyway. Anamorphic modes on eosm recorded in dual iso as always comes out very, very nice. Bouncyball did some really good job here with getting the dual iso files working with all bits. One should start using the cam more often  :P

Speaking of Dual-ISO coming from EOSM while in Anamorphic mode... this was shot in 24p ISO 100/1600 @ 10mm 2.8 in 1504x640 and where'd all the aliasing go?

(https://farm8.staticflickr.com/7802/39986451243_f2d5b508ca.jpg) (https://flic.kr/p/23Vt1Ra)

Quote from: masc on February 01, 2019, 07:49:51 PM
Done.

While this could be nice but I do use Bad Pixel Fix whenever I have a dead/hot pixel coming from one of my older KomputerBay CF cards.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 01, 2019, 08:37:07 PM
Quote from: DeafEyeJedi on February 01, 2019, 08:18:10 PM
Here are the features I used...

(https://farm5.staticflickr.com/4821/39986732103_4fbfaf8fb2.jpg) (https://flic.kr/p/23Vuskz)(https://farm5.staticflickr.com/4882/46037237405_134ef5fc8f.jpg) (https://flic.kr/p/2d99SLv)(https://farm8.staticflickr.com/7886/33075779318_614889a2c2.jpg) (https://flic.kr/p/SoN1Rd)
Okay. Denoiser and highlights slider need some CPU power. But not soo much. Using lossless files slows down processing too.

Quote from: DeafEyeJedi on February 01, 2019, 08:18:10 PM
While this could be nice but I do use Bad Pixel Fix whenever I have a dead/hot pixel coming from one of my older KomputerBay CF cards.
I don't think this is possible. Bad (dead/hot) pixels should always come from your sensor (or do I missunderstand?!).
Bad Pixel Fix can still be activated. ;)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 01, 2019, 08:42:53 PM
Quote from: DeafEyeJedi on February 01, 2019, 08:18:10 PM
this also reminds me to ask does this have anything to do with shooting in Lossless 12-bit while we're at it?
.....
Again after each crash I just simply erase the last corrupted file and redo which then spits out OK.
Well, as you understand it is hard to understand the exact reason because of the random nature of the issue you are experiencing. Unfortunately I can not reproduce it :(.

Could be 12bit lossless as well. Sometimes this kind of footage is a bit tricky to handle due to lower white level and ugly scaling requirement for proper dual iso processing.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 01, 2019, 08:46:20 PM
Quote from: masc on February 01, 2019, 08:37:07 PM
Bad (dead/hot) pixels should always come from your sensor (or do I missunderstand?!).
It is truth.

For MLVs taken from bad flash card the image artifacts will be far more severe. Could even be fatal for this particular MLV :).
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on February 01, 2019, 09:52:02 PM
wow deafeyejedi, that image looks absolutely stunning!

what lens did you use?  i have a couple of friends that are interested in the eos m, and this might make a big difference...
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on February 02, 2019, 12:28:41 AM
Quote from: masc on February 01, 2019, 07:49:51 PM
Done.


oh noooo, Canon cameras are so prone to bad pixels!! that default option is a life saver!!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 02, 2019, 01:32:42 AM
Thanks a lot, Masc, for finding this easy fix.  I turned Bad Pixels off and the ugly pink artifacts are gone now completely!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 02, 2019, 10:04:35 AM
Quote from: togg on February 02, 2019, 12:28:41 AM
oh noooo, Canon cameras are so prone to bad pixels!! that default option is a life saver!!
No worries... option is still there! You can enable it whenever you need it.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on February 02, 2019, 12:46:23 PM
Retested exports and seems ffmpeg runs fine exporting single files. Cpu working hard. Multiprocessing might not be needed as badly after all.
Also, the hsl features are super useful for correcting color.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on February 02, 2019, 05:33:57 PM
When opening a session with missing files ( they are mixed internal and external drive and external not plugged in )
There is a popup for each file, It would save me some time if there is only one popup telling me that there are missing files and when I want to see them it gives me a list.

Right now I have to click many times ok button for every time I open a session like that.
Title: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on February 02, 2019, 05:40:30 PM
Speaking of retesting exports... After these wonderful collaborations from all you fellow ML'ers in the past 24-48 hours, I've decided to disable the 'Bad Pixel Fix' and voila it all seems to be running better than ever.

Woke up this morning and it is in fact still rendering after overnight and all day yesterday. Seriously what gives?  :o

(https://farm5.staticflickr.com/4849/46960161911_478ed6b2bf.jpg) (https://flic.kr/p/2exH74Z)

Just 10 more minutes to go and then I'll have to have a go with testing the latest EOSM gems that was awoken from the Great @Danne. Same also goes for Master @dfort's project on the eagerly EOSM2 that needs some porting love testings.

Quote from: Lars Steenhoff on February 02, 2019, 05:33:57 PM
...Right now I have to click many times ok button for every time I open a session like that.

Had this similar phenomenon happened to me. I just simply force to quit, while all is connected go ahead and reopen MLV App then load the Session file that you had saved for this project of yours which should do the trick.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 02, 2019, 05:48:44 PM
Quote from: Lars Steenhoff on February 02, 2019, 05:33:57 PM
When opening a session with missing files ( they are mixed internal and external drive and external not plugged in )
There is a popup for each file, It would save me some time if there is only one popup telling me that there are missing files and when I want to see them it gives me a list.

Right now I have to click many times ok button for every time I open a session like that.
How are you able to open such sessions? Do you open session with HDDs connected, then disconnect your HDDs to export the files on the HDD? This should be the only possibility, because MLVApp sorts out all MLVs which are not accessible when opening a session.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on February 02, 2019, 05:52:14 PM
 



I just openend the last session without the drive attached.

yes it sorts it but it shows a pop up for every missing file, ideally I need only one popup at the end of the opening of the session
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 02, 2019, 05:59:28 PM
Ah okay... so we don't talk about the export. We talk about the opening process. Right... you wrote that.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on February 02, 2019, 06:01:43 PM
 :) true

It's not a major issue, I can just hold enter, but its seems a bit excessive all the popups
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 02, 2019, 06:13:59 PM
I know what you mean, but it is hard to realize with current concept. Messagebox comes up when MLV open function does not find the file. But this function does not know how many files will be imported. The function which knows it, has no information about if it failed... :D Surely it is solvable...
Edit: I see a possiblity... just wait a bit...
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 02, 2019, 07:04:19 PM
Please try out if it works for you. There should be 2 buttons now: Skip (does the same as before) and Abort (aborts the opening process).
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on February 02, 2019, 07:19:37 PM
Nice fix @masc and is this something I'll have to compile?

If so, it's time to go back to @Danne's scripting magic with setting up an environment on my MBP.

It's prolly already built but may need to update in order to have it run properly.  :)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on February 02, 2019, 07:32:56 PM
Get Danne's mlvapp compiler

https://bitbucket.org/Dannephoto/mlv_app_compiler/downloads/mlv_app_compiler.dmg
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 02, 2019, 07:33:15 PM
Yes, you'll have to compile... I think that's not enough for v1.6 :D
Danne made a nice compiler app. It is linked on our github page.

Btw: cheers... today was the 20.000th offical download!  8)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 02, 2019, 09:01:40 PM
Quote from: masc on February 02, 2019, 07:33:15 PM
Yes, you'll have to compile... I think that's not enough for v1.6 :D
Danne made a nice compiler app. It is linked on our github page.
Nightly builds ???

Quote from: masc on February 02, 2019, 07:33:15 PM
Btw: cheers... today was the 20.000th offical download!  8)
Woww
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on February 02, 2019, 09:05:29 PM
if you guys start doing nightly builds, you'll soon have your 20 millionth download ;)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Rx3210 on February 03, 2019, 05:36:38 PM
Greeting Author,
I am new to this. I installed the app on my Linux mint successfully. I imported the mlv file and played it but it was lagging. now if I want to export it to any file format as in mov or mp4 what is the correct export setting that solves the lag?

Cordially,
Rami
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 03, 2019, 06:05:31 PM
Quote from: Rx3210 on February 03, 2019, 05:36:38 PM
Greeting Author,
I am new to this. I installed the app on my Linux mint successfully. I imported the mlv file and played it but it was lagging. now if I want to export it to any file format as in mov or mp4 what is the correct export setting that solves the lag?

Cordially,
Rami
What do you mean with lagging? On most machines you won't get realtime preview in the viewer. Export to what you need.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 03, 2019, 08:11:10 PM
Quote from: Rx3210 on February 03, 2019, 05:36:38 PM
Greeting Author,
I am new to this. I installed the app on my Linux mint successfully. I imported the mlv file and played it but it was lagging. now if I want to export it to any file format as in mov or mp4 what is the correct export setting that solves the lag?

Cordially,
Rami

Export and see. Ask a harder question next time.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on February 05, 2019, 01:51:00 PM
i just finished regrading a video i did last year with mlvapp, but this time with linear gamma, and it looks stunning!

doing it made me wish for precise control for the curve points.  possible to use arrow keys (maybe with some way to select them first without moving them, like maybe shift-click?)

1 single pixel movement makes a very big difference in linear mode.  this would be really helpful for sure!

i'll post the video soon.

PS: i think vegas would prefer 8 bit PNG.  possible to have both options?
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 05, 2019, 03:43:39 PM
Quote from: 70MM13 on February 05, 2019, 01:51:00 PM
...doing it made me wish for precise control for the curve points.  possible to use arrow keys (maybe with some way to select them first without moving them, like maybe shift-click?)

1 single pixel movement makes a very big difference in linear mode.  this would be really helpful for sure!
...
PS: i think vegas would prefer 8 bit PNG.  possible to have both options?
Have you tried stretching edit dock horizontally? The wider it gets, the more precise the curves tool should be.
For 8bit PNG I'll have a look later today.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 05, 2019, 07:26:34 PM
Quote from: 70MM13 on February 05, 2019, 01:51:00 PM
i think vegas would prefer 8 bit PNG.  possible to have both options?
Done.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on February 05, 2019, 09:28:17 PM
excellent, thanks!

yup, i use the dock on a separate monitor at maximum size.  it's workable, but the precision required for nonlinear grading would make "nudging" points very desirable :)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on February 07, 2019, 10:58:42 PM
How difficult would it be to make MLV app read DNG files?   
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 07, 2019, 11:17:41 PM
Very hard currently, everything in MLV App is built around MLV and it's metadata.

One mad idea: if we make the methods of mlvObject_t replaceable (put function pointers inside), we could create some code that emulates the methods and acts like an MLV, but really is reading DNGs.

This would be amazingly fun, but a lot of work, so no DNG in MLV App I think. That is for DNG App :D
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on February 09, 2019, 01:40:16 PM
here's a new extreme test i did with danne's fantastic dual iso build, along with linear grading in mlvapp, producing unbelievable results!

it works very well to test demosaicing also, as the ultimate test.  nothing works on it perfectly (yet!) ;)

look with 100% zoom at the light bulb...

the dynamic range in this shot is beyond what i thought possible with the 5d3.  that crazy bulb is the only light source in a black scene, and the lens on it magnifies the intensity but it doesn't put out much illumination, so you've basically got a large shockingly bright point source in a dark scene.

included is the receipt for the linear grade i did in mlvapp.

PS: i found a workaround for my difficulties in grading with the curve in linear mode, and it's so simple!  drop the DPI way down on my gaming mouse while adjusting the curve.  the button was right under my finger the whole time! :P

https://drive.google.com/open?id=17XpfbCAVHScMf9FEPNDttZj66gAS0s1b


(https://i.ibb.co/7thTSkd/led-bulb-test.jpg) (https://ibb.co/7thTSkd)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: reddeercity on February 10, 2019, 08:32:34 AM
Can I request the width stretch of 3.0x please , working on a new pinning mode on the 5d2 (still need some work yet)
in 3xcrop_mode(5x zoom) I found how to configure for Tall mode for horizontal stretch  (1376x2098 @ 23.98) = 4128x2098 @ 23.98
this is so much better , can't see any aliasing or moiré pattern "0" , changed the pinning mode in 3xcrop to the same as 1:1 FHD
so full width view ( well almost 4128 of 5632)

(https://i.ibb.co/g3qfdwv/RAW-046-4152x2099-small.png) (https://imgbb.com/)

RAW-046_4152x2099.png (https://bitbucket.org/reddeercity/magic-lantern_10-12bit/downloads/RAW-046_4152x2099.png)
Original DNG 1376x2098 RAW-046.DNG (https://bitbucket.org/reddeercity/magic-lantern_10-12bit/downloads/RAW-046.DNG)

Here a small sample 354Mb mlv (https://drive.google.com/file/d/1jrPXSKIN0WQQCwPQDeDiGPvTAAN-a3oG/view?usp=sharing)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on February 10, 2019, 08:40:10 AM
Post code and registrys changed please.
Seems to me you got the 1x3 binning working.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 10, 2019, 11:10:36 AM
Quote from: reddeercity on February 10, 2019, 08:32:34 AM
Can I request the width stretch of 3.0x please , working on a new pinning mode on the 5d2 (still need some work yet)
in 3xcrop_mode(5x zoom) I found how to configure for Tall mode for horizontal stretch  (1376x2098 @ 23.98) = 4128x2098 @ 23.98
this is so much better , can't see any aliasing or moiré pattern "0" , changed the pinning mode in 3xcrop to the same as 1:1 FHD
so full width view ( well almost 4128 of 5632)
This are great news, reddeercity! I would be so thankful to try that out on my 5D2 as well - I tried getting your 2.5K setup to work yesterday evening using ADTG module (but unfortunately without success, camera crashed, each time at another register when changing the values).  :'(

But now back to your request: 3.0x horizontal stretch is there since v1.5. If the file has the right metadata the setup works automatically. If not, you have to setup height stretch factor to 0.33x. MLVApp always upsamples since v1.5, so a height stretch factor of 0.33x is realized as width stretch factor of 3.0x. In older versions you can do this manually for ffmpeg export by entering your desired output resolution (frame is stretched once only on export, so no quality loss). Maybe we should add a information label somewhere, which shows the resolution after stretching.
Title: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on February 10, 2019, 05:07:42 PM
Quote from: Danne on February 10, 2019, 08:40:10 AM
Post code and registrys changed please.
Seems to me you got the 1x3 binning working.

Agreed. No reason why you couldn't. Please as it could help give us clues/hints for other cams.

Quote from: masc on February 10, 2019, 11:10:36 AM
This are great news, reddeercity! I would be so thankful to try that out on my 5D2 as well - I tried getting your 2.5K setup to work yesterday evening using ADTG module (but unfortunately without success, camera crashed, each time at another register when changing the values).  :'(

That's a real bummer. Once I get ahold of my buddy whom owns a 5D2, will let you know and we'll have a run at 'em!

On a separate topic, after some fiddling w MLV App some more overnight... I find myself keep wishing if we had a feature that would allow us to see 'Before/After' similar to how we can do in ACR when pressing 'P' back 'n forth to see the differences in results of grade. It would only apply to the ones that have been modified. I may be spoiled by Adobe though.

Seems like this would be possible on your end but just won't be able to use the letter 'P' since it's already occupied for to show Parade from within this app. I know we can have a similar way to achieve this by unchecking the box for Enable RAW Correction. But it completely disables to entire correction rather than a particular piece that needs to be fine-tuned.

Meanwhile, I'm currently compiling MLV App Masters via mlv_app_compiler (Thanks @Danne!). Will let you know once it's up and ready for me to try out the latest 'n greatest.  :)

*EDIT*

Done. Compiled w ease. Now I can see the Bad Pixel Fix is enabled 'OFF' upon opening it. Same goes for the 8-bit PNG Sequences per @70MM13's request. This feels really good.

(https://i.ibb.co/W5gG34S/Screen-Shot-2019-02-10-at-9-05-03-AM.png) (https://ibb.co/tK8QhTy)

Finally, I can check this one off and try to catch up w the rest of my To-Do list re: ML. Actually @dfort's next as I'll need to get some work done for his EOSM2 porting project.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 10, 2019, 09:34:55 PM
@DeafEyeJedi: yes... you got it! :)

This before/after feature was requested already some time ago. You can have it right now (okay, not so simple like in LR) by Ctrl+C; Ctrl+Alt+R and to come back Ctrl+V. Yes I know... a little stupid to do so, but works.
In the end, implementing the feature would have more or less the same speed (sometimes a little slow, depending on the used parameters). Resetting all parameters might not always be a good idea: debayer, transformation, etc. ... so this would be a reduced parameter set to be reset, I think. Maybe group boxes Processing, Details, HSL, Toning, Lin. Gradient, Filter & LUT.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on February 10, 2019, 09:37:13 PM
It would be much easier to just press a compare button  8)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on February 10, 2019, 09:41:08 PM
and even better to have receipt slots!

just had to get that in there  :P

just sayin'  8)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on February 10, 2019, 09:42:00 PM
True!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 10, 2019, 09:59:41 PM
Quote from: 70MM13 on February 10, 2019, 09:41:08 PM
and even better to have receipt slots!
Technically this is not too hard to implement. But I still have no good idea how to present this to the user and how to integrate it into the UI. I like to have it:
- easy to use
- best: no preview loading times for the elements
- good integration into GUI
I tried out some solutions, but I did not like it at all, so I deleted all this again. And both, Resolve and LR, are not really good here too. So I don't know where to steal the idea... LOL
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on February 10, 2019, 10:02:33 PM
Quote from: masc on February 10, 2019, 09:34:55 PM
This before/after feature was requested already some time ago. You can have it right now (okay, not so simple like in LR) by Ctrl+C; Ctrl+Alt+R and to come back Ctrl+V. Yes I know... a little stupid to do so, but works.
Good to know. Fine for now. Thx!

Quote from: masc on February 10, 2019, 09:34:55 PM
In the end, implementing the feature would have more or less the same speed (sometimes a little slow, depending on the used parameters). Resetting all parameters might not always be a good idea: debayer, transformation, etc. ... so this would be a reduced parameter set to be reset, I think. Maybe group boxes Processing, Details, HSL, Toning, Lin. Gradient, Filter & LUT.

Group Boxes would be great for that matter.  8)

Quote from: 70MM13 on February 10, 2019, 09:41:08 PM
and even better to have receipt slots!

just had to get that in there  :P

just sayin'  8)

Haha. That's a good one, actually!

Quote from: masc on February 10, 2019, 09:59:41 PM
Technically this is not too hard to implement. But I still have no good idea how to present this to the user and how to integrate it into the UI. I like to have it:
- easy to use
- best: no preview loading times for the elements
- good integration into GUI
I tried out some solutions, but I did not like it at all, so I deleted all this again. And both, Resolve and LR, are not really good here too. So I don't know where to steal the idea... LOL

LoL... Let's do one step at a time. Less is more. We'll eventually get this one figured out one way or another.  ;)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on February 10, 2019, 10:31:15 PM
Quote from: masc on February 10, 2019, 09:59:41 PM
Technically this is not too hard to implement. But I still have no good idea how to present this to the user and how to integrate it into the UI. I like to have it:
- easy to use
- best: no preview loading times for the elements
- good integration into GUI
I tried out some solutions, but I did not like it at all, so I deleted all this again. And both, Resolve and LR, are not really good here too. So I don't know where to steal the idea... LOL

whatever you decide on, the user will get used to...

i didn't like the way resolve does it, but soon i developed muscle memory for it and then it was completely natural, and now i wouldn't ask for anything different.  we get used to anything eventually ;)

do what you think is best and we will love it!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: darthivm on February 11, 2019, 04:52:54 PM
Thanks for this great App!

I was wondering if there is any opencl implementation for graphicscards, so the video would be rendered faster.

Thanks for your reply!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 11, 2019, 05:30:19 PM
All implementation in MLVApp is CPU based. This is why it runs on a wide range of computers. Until now we have no OpenCL code. If somebody likes to help with that, let us know!
Title: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on February 12, 2019, 05:06:58 AM
Excuse for my ignorance but was this to be expected w 10-bit lossless? I think I read it somewhere someone mentioning this very similar trick.

Fiddling w White Levels (Tonemapped enabled) on these files seems to help w the pink highlights when trying to retain them.

Surprised to see this much details in HL recovery especially from an EOSM. Fun stuff!

Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on February 12, 2019, 05:59:24 AM
the excellent highlight capabilities of mlvapp are almost always better for me than with resolve.

it really is amazing what this program can do...
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 12, 2019, 07:04:04 AM
DeafEyeJedi,

In your video, the highlights (HL) are not blown up.  They still retain full detail and allow you to process them as you like.  Very often though, HL get overexposed and this is inavoidable (e. g. a window in an indoor scene).  Moreover, the overexposed areas are very hard to see on the small screen during filming.  If that happens, there is nothing you can do.  The overexposed HL stay pink, no matter what you do. 

A similar situation occurs when filming at 9 bits lossless, (excellent for longer recording times at higher croped resolutions) and you underexpose the shadows.  Once that happens, the underexposed shadows are red braunish and this really looks ugly.  And, unfortunately, there is no way to fix them - make them look black.

The perfect solution would be, if MLVApp automatically recognizes blown up HL and underexpoeed shadows and turns them into whites and blacks, respectively.  I don't know if that would be possible though.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on February 12, 2019, 07:21:02 AM
@deafeyejedi
Seems I have to fine tune 10bit white levels on the eosm. The tests procedure from here shouldn´t hurt as well:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg211251#msg211251
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 12, 2019, 08:03:20 AM
Quote from: DeafEyeJedi on February 12, 2019, 05:06:58 AM
Excuse for my ignorance but was this to be expected w 10-bit lossless? I think I read it somewhere someone mentioning this very similar trick.

Fiddling w White Levels (Tonemapped enabled) on these files seems to help w the pink highlights when trying to retain them.

Surprised to see this much details in HL recovery especially from an EOSM. Fun stuff!
Yes, this is expected and the way you should go, if overexposed highlights stay pink by standard.

@IDA_ML: you really still have clips, where no way helps with pink highlights? Could you please upload some frames for me? For me the way DeafEyeJedi shows always works.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on February 12, 2019, 08:11:15 AM
I tend to bring back highlight by lowering exposure and applying the Highlight Reconstruction. Then pushing back black and shadows with the curve tool and so on. Nicer edges. And of course correcting white level to around 2900 as pointed out by deafeye...
Title: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on February 12, 2019, 08:12:44 AM
Quote from: IDA_ML on February 12, 2019, 07:04:04 AM
In your video, the highlights (HL) are not blown up.  They still retain full detail and allow you to process them as you like.  Very often though, HL get overexposed and this is inavoidable (e. g. a window in an indoor scene).  Moreover, the overexposed areas are very hard to see on the small screen during filming.  If that happens, there is nothing you can do.  The overexposed HL stay pink, no matter what you do.

That's true and I'm well aware. Just didn't know that it was due to the White Level issues because I could swear to myself that I tend to use ETTR respectfully without going too extreme. Or at least I try to stay within the boundaries.

Quote from: IDA_ML on February 12, 2019, 07:04:04 AM
A similar situation occurs when filming at 9 bits lossless, (excellent for longer recording times at higher croped resolutions) and you underexpose the shadows.  Once that happens, the underexposed shadows are red braunish and this really looks ugly.  And, unfortunately, there is no way to fix them - make them look black.

Tried 9-bit once and never went back. Sorry. Ha.  :P

Quote from: IDA_ML on February 12, 2019, 07:04:04 AM
The perfect solution would be, if MLVApp automatically recognizes blown up HL and underexpoeed shadows and turns them into whites and blacks, respectively.  I don't know if that would be possible though.

Well if that's the protocol then we could eventually figure a way out. But if it's better to drive a stick shift than an automatic vehicle then so be it.

It was just nice to be able to play with Black/White Levels with ease. More or less like a user preference, perhaps? 8)

Quote from: Danne on February 12, 2019, 07:21:02 AM
@deafeyejedi
Seems I have to fine tune 10bit white levels on the eosm. The tests procedure from here shouldn´t hurt as well:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg211251#msg211251

If that's the case then I guess that's where I'll have to take a deep dive some time this week if not this weekend. Just took a peak and seems like there's another link within a link to go through in order to complete the test properly.

Should be doable though. Thanks fo the tips, @Danne!  :)

Quote from: masc on February 12, 2019, 08:03:20 AM
Yes, this is expected and the way you should go, if overexposed highlights stay pink by standard.

Thanks for confirming @masc and now I feel better.

Here's another great example of HL fix even after shooting in ETTR and pull down 2 stops in MLV App (-2.00 exposure) along w few grades there and there.



For those who are curious here's a sample file -- https://bitbucket.org/DeafEyeJedi/magic-lantern/downloads/EOSM-4.5K-10-bit-Lossless-ETTR-Sample.MLV
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 12, 2019, 08:52:49 AM
Quote from: Danne on February 12, 2019, 08:11:15 AM
I tend to bring back highlight by lowering exposure and applying the Highlight Reconstruction. Then pushing back black and shadows with the curve tool and so on. Nicer edges. And of course correcting white level to around 2900 as pointed out by deafeye...
Yapp. Exposure=-2 and Lighten=50 is a better starting point than Exposure=0 and Highlights=-50, because edges will look way better. Or use curve tool. White level for 10bit EOS-M footage is somewhere 2600 and 2900, different in many clips - whyever.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on February 12, 2019, 09:28:07 AM
Could be iso correlations. Solving this by adding correct white level already in cam would be nice. An evening in front of a light bulb and working those tests pointed to from a1ex with raw_diag should do the trick.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 12, 2019, 09:54:45 AM
Quote from: masc on February 12, 2019, 08:03:20 AM
@IDA_ML: you really still have clips, where no way helps with pink highlights? Could you please upload some frames for me? For me the way DeafEyeJedi shows always works.

I am at work now and don't have my 100D with me.  I will take a few shots tomorrow and will upload them for you.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on February 12, 2019, 10:55:40 AM
White level fix for eosm:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg211913#msg211913
Thanks @deafeyejedi and @masc @a1ex
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 12, 2019, 04:44:50 PM
Masc,
     I went through some of my earlier 100D files and, as you requested, here is one of them that is quite hard to fix:

https://we.tl/t-jN6cR1CUjb

Yes, I agree, in this file there is a quite severe overexposure of the highlights.  Following your instructions and setting White level to 2600, I was indeed able to remove the pink cast from the blown up areas but got other ugly artifacts in those areas - see for example the green leaves of the rose where the pink cast becomes yellowish.  And yes, I agree that there is always a price to pay for blown up highlights but I love the way version 1.5 handles them.  Do you think, something similar could be done to the underexposed shadows in files shot at 9 bits lossless?
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 12, 2019, 07:00:31 PM
Thanks IDA_ML. Hmm... our algorithm works best for colorless tones, or if green channel should be in between blue and red with a similar curve. Reconstructing a "real green" if it is not there and if it is also not partially in the other two channels leads to problems. Maybe there are more intelligent algorithms out there... no idea. I have a similar problem with orange tones which get yellow/grey.
(https://i.ibb.co/L0Fxwdb/Bildschirmfoto-2019-02-12-um-19-24-09.png)
The upper right half of the image was pink. But the original color is like the lower left half.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 12, 2019, 07:51:11 PM
Could anyone with the latest version camera raw compare MLV App's AMaZE debayering to this new Adobe thing? https://petapixel.com/2019/02/12/adobe-enhance-details-increases-raw-photo-resolution-by-up-to-30/

See which one's more detailed...
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 12, 2019, 08:28:12 PM
Thanks, Masc, for this clarification.  After struggling a lot with blown up highlights, I came to the conclusion that one should do their best to avoid them. ETTR is a great tool for that but it does not help much with camera movement where very bright objects may enter the scene and ruin it.  To compensate for situations like this, I usually apply ETTR to the scene that I plan to shoot and then dial back the exposure by 0,5 to 1,0 stops.  If nothing else helps then exposing for the highlights and then using Dual ISO is the last resort.  Most of the time, this works best, especially in the high-resolution croped modes.  And I am really very happy that MLVApp handles Dual ISO files so well.  Simply fantastic!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 12, 2019, 08:30:15 PM
Quote from: IDA_ML on February 12, 2019, 07:04:04 AM
Very often though, HL get overexposed and this is inavoidable (e. g. a window in an indoor scene).  Moreover, the overexposed areas are very hard to see on the small screen during filming.  If that happens, there is nothing you can do.  The overexposed HL stay pink, no matter what you do. 

Try lowering white level. For the kind of highlights you describe that does remove pink colour,  but of course does not bring back detail in the blown out window.

Quote from: IDA_ML on February 12, 2019, 07:04:04 AM
In your video, the highlights (HL) are not blown up.  They still retain full detail and allow you to process them as you like.

Depends what you consider blown up. They certainly don't retain full detail, the green channel was fully destroyed in that case, but red and blue were preserved.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on February 12, 2019, 10:25:41 PM
There has been a discussion in the background which regards color and how it´s affected when using the camera matrix setting(default). Mostly it works wonders but when mixing kelvin temps warm/cold there´s sometimes issues. I came up with a temporary fix by altering the xyz_rgb matrix. It´s totally unscientific but for now it will be sufficient at least for me. Masc already put it in as an option in Mlv App so compile and just run it if footage comes out similar to this:

The option is here:
(https://i.postimg.cc/xdy8Js8b/Screenshot-2019-02-12-at-22-15-47-png-300px.png)

Original import
(https://i.postimg.cc/4dW3wmzf/Screenshot-2019-02-12-at-22-13-43-png-800px.png)

Use Camera Matrix + processing(blueish highlights)
(https://i.postimg.cc/HLCjLGYg/Screenshot-2019-02-12-at-22-15-22-png-800px.png)

UncolorscienceFix + processing
(https://i.postimg.cc/pTWTDD5c/Screenshot-2019-02-12-at-22-15-30-png-800px.png)

The fix:
/* Danne temp fix version */
static const double xyz_to_rgb_danne[] = {
     3.2404542, -1.5371385, -0.4985314,
    -0.9692660,  1.8760108,  0.0415560,
     0.0030,  -0.0536,  0.9834
};

/* Danne temp fix XYZ to Cone space (LMS) */
static const double ciecam02_danne[] = {
    3.2404542, -1.5371385, -0.4985314,
   -0.7036,  1.8760108,  0.0415560,
    0.0030,  0.0536,  0.9834
};
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 12, 2019, 11:36:23 PM
Good work, Danne!  Looks like another significant improvement of MLVApp.

The truth is born in discussions ...
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on February 13, 2019, 08:14:32 AM
Quote from: IDA_ML on February 12, 2019, 11:36:23 PM
Good work, Danne!  Looks like another significant improvement of MLVApp.

Agreed. This is just fantastic to see!

Quote from: IDA_ML on February 12, 2019, 11:36:23 PM
The truth is born in discussions ...

Amen!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 14, 2019, 09:56:37 AM
https://vimeo.com/317080446

I shot a straightforward over/under exposure test using MLV App 1.5 to make basic corrections to visually 'return' to N (Normal) exposure. Shot on 5D MkII (10 bit).

I used two methods to compare which suppressed [shadow] noise more effectively:
Method 1) Using the Exposure slider to compensate +/-
Method 2) Using the Exposure slider to adjust down, then compensating using the Lighten slider to push back up.

You decide...  :P

Hope this is useful for someone!

#5D MkII #MLV App 1.5 #Over/Under Exposure

Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 14, 2019, 06:27:25 PM
@masc Finally tried the HSL adjustments: they're amazing!!! There is the ability to fine tune it, unlike rawtherapee's HSL adjustments where moving the mouse one pixel changes the hue by 180 degrees already. What we have in MLV App is a usable interface with controls that are not horrible, very rare in open source image editing. Thanks for all the great features you have added recently.

@timbytheriver
Exposure slider is linear and simulates more intense light. The lightness slider is more of a curve and brings dark tones up more than light ones. Use them however you think gives a nicer looking result... and never underexpose :D
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 14, 2019, 06:54:50 PM

Quote from: Ilia3101 on February 14, 2019, 06:27:25 PM
and never underexpose :D

Absolutely! +1.5 is the way to go. Thanks for the info about the sliders – I didn't know that. :)

Tim
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 14, 2019, 07:05:36 PM
Quote from: Ilia3101 on February 14, 2019, 06:27:25 PM
@masc Finally tried the HSL adjustments: they're amazing!!! There is the ability to fine tune it, unlike rawtherapee's HSL adjustments where moving the mouse one pixel changes the hue by 180 degrees already. What we have in MLV App is a usable interface with controls that are not horrible, very rare in open source image editing. Thanks for all the great features you have added recently.
Glad you like it, as it is initially your project. ;)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 15, 2019, 10:11:31 AM
@Ilia3101 @masc

Would it be possible to add a False Colour overlay option to MLV App – or is this voodoo?  :o

Thanks!

Tim
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 15, 2019, 10:22:28 AM
Quote from: timbytheriver on February 15, 2019, 10:11:31 AM
Would it be possible to add a False Colour overlay option to MLV App – or is this voodoo?  :o
What exactly do you mean with that?
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 15, 2019, 10:25:02 AM
https://timeinpixels.com/false-color-plugin/

It maps various exposures visually – like an overlay in hi-end monitors! :)

There is way you can do it in Photoshop detailed by user 'crifida' in the comment section of this article: https://wanderingdp.com/cinematography/cinematography-school-lighting-ratios-101/
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 15, 2019, 06:49:48 PM
False colour is literally some if statements for brightness of a pixel. But what's the use?
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 15, 2019, 08:48:39 PM
For on-set monitoring it shows the relationship between where certain values are 'placed'. Very useful for 'seeing' lighting ratios. E.g. Key to Fill, where skin tone values are. The various false colour values can be adjusted to suit the cinematographer. In a post production workflow you can still use the false colour to assess the relative brightness levels of subjects.

This explains it better than me:  https://wanderingdp.com/cinematography/cinematography-school-lighting-ratios-101/
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 15, 2019, 08:58:10 PM
@timbytheriver:
do you know this page?
https://cameramanben.github.io/LUTCalc/LUTCalc/index.html

Here you can create a false color LUT as you like to have it. Generate it, load it into MLVApp's LUT slot and see what happens. Should do the trick! ;)

(https://i.ibb.co/cx8bmY2/Bildschirmfoto-2019-02-15-um-20-56-39.png)
(https://i.ibb.co/wWddDTC/Bildschirmfoto-2019-02-15-um-22-30-44.png)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 16, 2019, 09:14:48 AM
@masc Many Thanks! That looks a very clever way of doing it! :)

What camera and gamma settings did you use in the first box?

Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 16, 2019, 09:20:03 AM
I used general, rec709, sRGB. No idea if that is correct, but the LUT is the last step in processing, so camera type doesn't matter. The viewer should be sRGB and we export to rec709. That's why I've chosen this setup. But again: that might be wrong.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 16, 2019, 12:06:50 PM
Great, thanks! I will do some experiments.

Is this looking correct?
(https://i.ibb.co/Q6zM6rr/calc.png) (https://ibb.co/Q6zM6rr)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 16, 2019, 12:50:03 PM
Hm... completely different from what I did yesterday, but maybe more correct. I now tried this, and it looks plausible so far. Maybe Ilia can look at this!
(https://i.ibb.co/wSVfX59/Bildschirmfoto-2019-02-16-um-12-47-46.png)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 16, 2019, 01:04:14 PM
Can't seem to get any clipped areas to show Yellow or Red – even if I push them off the scale.

Are you saying I should be in sRGB instead of Tonemapped for the working space in MLV App?
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 16, 2019, 01:15:03 PM
No, what you set before doesn't matter. The viewer itself is always sRGB. So if you push it you should see something. I get it orange here in highlights.
(https://i.ibb.co/gvYdfPW/Bildschirmfoto-2019-02-16-um-13-13-56.png)

https://www.dropbox.com/s/7k33mkf3hk3kj4r/FalseColor_sRGB_LUT.cube?dl=0
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 16, 2019, 02:28:43 PM
Thanks masc. Highlight false colour seems to be working when I use your LUT! Maybe I did something wrong...  :o

Cheers!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 16, 2019, 02:36:34 PM
Tone mapped is sRGB, it just doesn't clip to 255 easily. You could use the sRGB profile if you want more clipping 🤕

And for the lut generator, I think sRGB is what you should use as the viewer is assumed to be sRGB.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 16, 2019, 02:50:03 PM
Thanks @Ilia3101 :)

@masc Could you post a complete screenshot of your LUT calc settings please? Whenever I generate a LUT the highlight clippings (orange and red) still don't show! Only your LUT works...

Many thanks!

Tim

Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 16, 2019, 05:04:00 PM
(https://i.ibb.co/MVsBy7r/Bildschirmfoto-2019-02-16-um-17-02-42.png)

Have you checked the orange checkbox?
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 16, 2019, 05:07:32 PM
I missed that. Doh! :P Thank you! It works now. :)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: tigs on February 20, 2019, 02:49:36 AM
Is there a way to play the cinemaDNG files/folders? I have been using the original mlrawviewer 1.4.3 to play the cinemaDNG files (folders) from the blackmagic pocket camera without any issue. I just drag-and-drop the folder over the mlrawviewer, and it will start to play. I would love to be able to do the same with this app.

thanks
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on February 20, 2019, 01:01:26 PM
Quote from: tigs on February 20, 2019, 02:49:36 AM
Is there a way to play the cinemaDNG files/folders? I have been using the original mlrawviewer 1.4.3 to play the cinemaDNG files (folders) from the blackmagic pocket camera without any issue. I just drag-and-drop the folder over the mlrawviewer, and it will start to play. I would love to be able to do the same with this app.

thanks

Nope, was asked multiple times and it is very complex to realize. Not worth it, there're alternatives.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: olofen on February 20, 2019, 04:50:31 PM
Hi,
I just used DualPixel for the first time
Unfortunately I did not get the result I wanted...
I use a mk III and compared two exposures - one with and one without Dual Iso
Dual Iso was set to +2 EV
In MLV app 1.5 I clicked on force on The Dual Iso file and then set it to on
Then I processed the two files (that looked identical in MLV...) to two H264 movies, opened them in Photoshop and compared
BUT I cannot see any difference in the shadows!!!
What did I do wrong?
/ olof ☹️
Title: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on February 20, 2019, 05:16:37 PM
Maybe share some trimmed samples of your original MLV shot in Dual-ISO for us to see and test with @olofen?
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: olofen on February 20, 2019, 05:51:13 PM
Quote from: DeafEyeJedi on February 20, 2019, 05:16:37 PM
Maybe share some trimmed samples of your original MLV shot in Dual-ISO for us to see and test with @olofen?

Here you are DeaEyeJedi, really hope you can see something: https://we.tl/t-B4Mp6v3JEj

Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 20, 2019, 06:10:19 PM
Quote from: olofen on February 20, 2019, 04:50:31 PM
Hi,
I just used DualPixel for the first time
Unfortunately I did not get the result I wanted...
I use a mk III and compared two exposures - one with and one without Dual Iso
Dual Iso was set to +2 EV
In MLV app 1.5 I clicked on force on The Dual Iso file and then set it to on
Then I processed the two files (that looked identical in MLV...) to two H264 movies, opened them in Photoshop and compared
BUT I cannot see any difference in the shadows!!!
What did I do wrong?
/ olof ☹️
How did you process the two files? If you just enable dual iso, and do nothing more and export to h264, you will loose all data you got before. If you use e.g. the lighten slider = 75 (pushing shadows) you will see a huge difference. I set sharpen to 100 to make the effect more visible.

Without dual iso:
(https://i.ibb.co/y0qyCS2/Bildschirmfoto-2019-02-20-um-18-03-48.png)

With dual iso:
(https://i.ibb.co/ZYdY2BZ/Bildschirmfoto-2019-02-20-um-18-03-54.png)

See the noise in the shadow left and below the tree.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: olofen on February 20, 2019, 07:05:22 PM
Great Masc  ;D ;D

...and I who just thought I had to switch on the Dual ISO button!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on February 20, 2019, 07:16:54 PM
Quote from: olofen on February 20, 2019, 07:05:22 PM
...and I who just thought I had to switch on the Dual ISO button!
In general... yes... and then the fun begins! Without correcting some parameters dual iso files should look 100% identical. But then you can push things much harder until you see artifacts.
Title: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on February 20, 2019, 07:23:21 PM
Excellent pointers @masc and here's what you can do with your files @olofen via MLV App...



Obviously the Dual-ISO shadows are cleaner with the color noise. Must been hella cold out there and yet I could use some snow.  ;)

Also noticed your Dual-ISO file didn't give MLV App the correct metadata (should be ISO 100/**** & not just 100) so which build did you use to shoot this w 5D3.123?
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: tigs on February 20, 2019, 09:33:19 PM
Quote from: togg on February 20, 2019, 01:01:26 PM
Nope, was asked multiple times and it is very complex to realize. Not worth it, there're alternatives.

Thanks for answering. I tried to search the forum for a few days, I could not find any answers. Decided to ask here.

I am aware of mlrawreview and fast cinemaDNG process, which is a demo. Are there any other cDNG players? I like the mlraw viewer a lot, and quite satisfied with. I am just a fraid some day it will become obsolete.

Thanks
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: olofen on February 20, 2019, 09:36:20 PM
Thank you DeafEyeJedi (sorry for misspelling before...),
About the build - it is the Nightly.2018Jul03.5D3123

PS not that cold - a couple of centigrades above!!!
/ olof 😀
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on February 23, 2019, 12:06:30 AM
Quote from: tigs on February 20, 2019, 09:33:19 PM
Thanks for answering. I tried to search the forum for a few days, I could not find any answers. Decided to ask here.

I am aware of mlrawreview and fast cinemaDNG process, which is a demo. Are there any other cDNG players? I like the mlraw viewer a lot, and quite satisfied with. I am just a fraid some day it will become obsolete.

Thanks

Davinci Resolve is the best. If your computer can afford it!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: megapolis on February 24, 2019, 06:03:37 PM
@tigs
QuoteI am aware of mlrawreview and fast cinemaDNG process, which is a demo.
Fast CinemaDNG is fully functional player for DNG, CinemaDNG, Blackmagic RAW DNG 3:1 and 4:1, MLV. Trial period is 6 months and you can always download and reinstall the latest version of the player. There are no restrictions for the player.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 25, 2019, 08:16:19 AM
Quote from: megapolis on February 24, 2019, 06:03:37 PM
... There are no restrictions for the player.
Except it absolutely requires powerful NVIDIA(only) card and... ;) there is no long awaited Linux version yet.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: megapolis on February 25, 2019, 05:14:46 PM
@bouncyball
It's not straightforward to port complicated solution from Windows to Linux. We need to port not only GUI, but also full GPU image processing SDK. We are working on that, sorry for the delay.
We do need NVIDIA GPU to offer high performance solution.
Soon we will release new SDK with less requirements for GPU memory, so any NVIDIA GPU will be fine.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 26, 2019, 09:16:45 AM
Quote from: megapolis on February 25, 2019, 05:14:46 PM
Soon we will release new SDK with less requirements for GPU memory, so any NVIDIA GPU will be fine.
Cool.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: AF-OFF on March 04, 2019, 01:07:07 AM
Playing back some clips from 50d (magiclantern-raw_video_10bit_12bit.2018Oct10.50D109) and eosM (crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Feb28.EOSM202) in this great software, I noticed huge playback speed differences. the 50d clips played back at 14-24 fps, while eosM played similar (res bitdepth) footage at 6-8 fps. in both cases all cpu's were at 100% .
how come? has anyone noticed something similar?
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 04, 2019, 08:03:03 AM
Without knowing your footage, I think the difference will be lossless vs. uncompressed. Lossless compressed clips have to be decompressed. This needs some time. You could export your EOS M clips as uncompressed MLV and test again. I bet it runs at the same speed then.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: AF-OFF on March 04, 2019, 05:20:40 PM
Quote from: masc on March 04, 2019, 08:03:03 AM
Without knowing your footage, I think the difference will be lossless vs. uncompressed. Lossless compressed clips have to be decompressed. This needs some time. You could export your EOS M clips as uncompressed MLV and test again. I bet it runs at the same speed then.
Thank's masc for the tip!
did a recording with 14bpp uncompressed (with Danne's march04 build) .
at res of 1984x1322 average 7fps,
50d 1984x1078 14bpp uncompressed plays back at 12-18 fps

all cpus at max on playback with either footage


Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on March 04, 2019, 05:32:47 PM
Different resolutions? Do same res and upload the mlv files if they differ.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: AF-OFF on March 04, 2019, 05:46:03 PM
uploaded short versions of both clips here :
https://we.tl/t-gFgEmBbZas

I apologize for not doing a strait forward test resolution wise in the first place.
Will do again ASAP... have to leave now.

Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 04, 2019, 08:26:59 PM
@AF_OFF: Downloaded your files.
50D: 1568x1046 = 1.6MPix
M: 1984x1322 = 2.6MPix
The higher the resolution, the slower the playback.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: AF-OFF on March 05, 2019, 12:44:37 AM
did a quick test and you are right Danne & masc !
the playback speed is identical. I found a 2.35:1 for both, which was (limited through 50ds 1548x672  14bit . On eosM I used Dannes 1080p mcm preset .the playback jumps at this res between 12-24 fps for 24fps footage.Sorry , I was sleeping not to see the obvious, how much the resolution matters, with mlv. so much data clouding every pixel. increase the pixel count, the total data rises dramatically.
mlv app did make a big change in my workflow. simplified and clarified
thanks a lot to all and masc building that supreme bridge to the ML raw_video feature





Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on March 07, 2019, 12:07:08 PM
I got an Idea which I think will be very useful , If I shot a Dual ISO video and I don't want to process it I want only The base ISO in the footage; I don't need the second ISO and process it then make the Two ISOs in single High Dynamic Range RAW dng like it does in MLV App and takes a lot of time, so In this case I shot in Dual ISO for back up only (If the high dynamic range needed) maybe it's not necessary to use and merge the second ISO at all only I want to extract the Base ISO footage and its will look like a footage without Dual ISO (Ignore quality loss and aliasing because mostly we will shoot in 1x3 mode).

So is this possible?
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on March 07, 2019, 12:22:26 PM
Isn't dualiso two isos in one image file? Extracting only one iso would still get only a half res image?
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on March 07, 2019, 12:41:55 PM
Yes, by merging the two ISOs only the midtone will Have the full details but in Shadows and Highlights the quality will be the half because it's completely blown out in the second ISO and we will get them back in the Base ISO , and the same thing in the Shadows completely black in Base ISO and we will restore it in the Second ISO unlike the area in-between Shadows and Highlights in the Base and second ISOs there are some details by merging them it will restore the most of not all the details, that's why I have understood . .

But in 1x3 Mode we have more Pixels we can extract The Base ISO only and downscaled it to act like 3x3 then we will get back the details But Up scaling instead of down scaling you will lose the half quality of course and you can restore some of it by merging the two ISOs so extracting the Base ISO is only useful for Down sampling.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on March 07, 2019, 12:53:33 PM
I see. Missed the part about anamorphic(1×3 pixel binning).
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 09, 2019, 11:25:19 AM
No idea how we could "extract" only one of the isos in dual iso clips. What happens with the unused lines? Skipping won't work (-> black lines). So do I copy the 1st two lines to line 3&4 and so on? I think this would look not very nice.

Btw: for everybody who is able to compile: MLVApp can export HDR footage now. You won't see what you get in the viewer, but ffmpeg export will blend it, if this new option is chosen.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on March 09, 2019, 11:36:20 AM
Very cool feature. Works with tblend average filter through ffmpeg. Auto differs from non HDR files too so mixing files is no problem. Practically no speed difference exporting hdr or non hdr files. Suggest to use 48 fps or above 30 fps to reduce possible ghosting.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Starclassic on March 09, 2019, 05:43:58 PM

I'm trying to get Cinelog output for MLV App? I tried BMDFilm then use conversion lut "BMD_to_Cinelog" but got an error message saying file too long or wrong header. Any work around? I love Cinelog and would like to use it in MLV App for faster turn around projects.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 09, 2019, 05:46:58 PM
Quote from: Starclassic on March 09, 2019, 05:43:58 PM
I'm trying to get Cinelog output for MLV App? I tried BMDFilm then use conversion lut "BMD_to_Cinelog" but got an error message saying file too long or wrong header. Any work around? I love Cinelog and would like to use it in MLV App for faster turn around projects.
Cinelog is commercial and I don't have it. So I am not able to see what you are doing. What kind of LUT is that? Is it a .cube 3D LUT? As I understood cinelog is more than just a LUT. Could you open that in a browser and see if it is correct to the specification?
If MLVApp tells "File with invalid header or file is too long.", this means that the LUT is not correct: there are more values included than the header of the file told before, or no value at all is included.
Title: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on March 09, 2019, 05:47:59 PM
Quote from: masc on March 09, 2019, 11:25:19 AM
Btw: for everybody who is able to compile: MLVApp can export HDR footage now. You won't see what you get in the viewer, but ffmpeg export will blend it, if this new option is chosen.

Yes! Will compile the latest MLV App and definitely have a go w the HDR features... Thanks so much to @Danne & @masc!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on March 09, 2019, 06:51:39 PM
yeah, jedi master...  i can't wait to see what you come up with!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on March 09, 2019, 10:38:02 PM
Quote from: masc on March 09, 2019, 11:25:19 AM
No idea how we could "extract" only one of the isos in dual iso clips. What happens with the unused lines? Skipping won't work (-> black lines). So do I copy the 1st two lines to line 3&4 and so on? I think this would look not very nice.

How Dual ISO processing works?

As I know it averages the two first lines and the two third lines to generate the missing two second lines in the Base ISO lines and make one whole image for the Base ISO, then the the same thing happens with the two second lines and two fourth lines to generate the missing lines for the Second ISO and also build a whole image with the Second ISO . . After filling the Missing lines for Base and Second ISOs now the two generated images for base ISO and Second ISO will merge together?

If I am wrong please someone tell us how the processing works .

Okay can we averge the two first lines and the two third lines to fill the in-between these lines instead of just copying it? It look the same process how Twixtor plug-in in After Effects works when doing *fake* Slow Motion it creates frames by blending frame A and frame B then it put the generated frame in-between these A and B frames . . But in our case we have pixels lines  :D
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Starclassic on March 11, 2019, 09:32:25 PM
Quote from: masc on March 09, 2019, 05:46:58 PM
Cinelog is commercial and I don't have it. So I am not able to see what you are doing. What kind of LUT is that? Is it a .cube 3D LUT? As I understood cinelog is more than just a LUT. Could you open that in a browser and see if it is correct to the specification?
If MLVApp tells "File with invalid header or file is too long.", this means that the LUT is not correct: there are more values included than the header of the file told before, or no value at all is included.

It is a .cube 3D LUT intended to convert BMD Film to Cinelog. It's intended use is for Davinci. I'll upload images later.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 11, 2019, 10:31:06 PM
Quote from: Starclassic on March 11, 2019, 09:32:25 PM
It is a .cube 3D LUT intended to convert BMD Film to Cinelog. It's intended use is for Davinci. I'll upload images later.
The intended program should not matter. There is a spec from Adobe for cube files. This spec should be implemented. If the header of the cube does not fit to the attached data, MLVApp brings the error. You could count the exact number of lines of data and compare to the number inside the header. I bet it doesn't fit.

This is the corresponding code I am talking about:

...
        else if( sscanf(line, "LUT_3D_SIZE%*[ \t]%hu%*[^\n]", &lut->dimension) == 1) //LUT is 3D
        {
            lut_size = (uint32_t)lut->dimension * (uint32_t)lut->dimension * (uint32_t)lut->dimension * 3;
            lut->is3d = 1;
            lut->cube = malloc( lut_size * sizeof( float ) );
            continue;
        }
        else if( sscanf(line, "%f%*[ \t]%f%*[ \t]%f%*[^\n]", &r, &g, &b ) == 3) //Read data
        {
            if(!lut_size || i >= lut_size) //File with invalid header or file is too long
            {
                sprintf(error_message, "File with invalid header or file is too long.");
                unload_lut( lut );
                fclose( fp );
                return -1;
            }
            lut->cube[i+0] = r;
            lut->cube[i+1] = g;
            lut->cube[i+2] = b;
            i+=3;
        }
...
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Andy600 on March 11, 2019, 10:43:21 PM
It's not a normal 3D cube lut. It's a hybrid format specific to Resolve and can't be parsed in other apps. It also doesn't conform to the Adobe .cube lut specification although it is based, in part, on it.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 11, 2019, 10:47:03 PM
Thanks Andy600. Then I need this hybrid format spec, or MLVApp has no chance in reading such files ;) ...and even then... somehow this has to be processed?!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Andy600 on March 11, 2019, 11:14:56 PM
There is no published spec that I know of but it's basically a high precision 1D lut concatenated with a high precision 3D lut. It's quite rare.

This specific lut will only work in BMD Film colorspace and unlike other shaper+3D luts it samples an additional transform in unbound linear space but maintains linear greyscale in the 3D part. It's pretty complex to create and ordinarily this type of colorspace transform would require an additional 1D lut after the linear matrix transform to get from linear to log space. Cinelog (Resolve) does it all in one lut but at the expense of limiting the colorspace (as all luts do), albeit to a space far larger than any real-world colors exist in (similar to ACES). You don't lose anything but technically speaking it does impose a limit because it's a lut.

As I've mentioned before it would probably be better to implement a proper CMS (ACES, OCIO etc) into MLVApp as it would be more efficient and infinitely expandable. Lut color transforms, especially ones like this are quite heavy in terms of file size and would require several GBs of luts to cover transforms to/from most typical colorspaces.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on March 11, 2019, 11:29:32 PM
Andy600, we missed you and colorspace discussions 8). Ilia3101 been working on aces transform for a while. Seems hard.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on March 13, 2019, 12:09:04 PM

(https://i.ibb.co/Z2MgfBs/aliasing.jpg) (https://ibb.co/Z2MgfBs)


Hi! This grab is from a 1080p/45fps clip on 5D31.2.3 in MLVapp 1.5 using AMaZe debayer. Lens is Canon L 16-35mm 2.8.

The aliasing/fringing around the leaves looks bad to me! Oddly enough, LMMSE debayer seems to make it worse!

Is this normal for a 5D3? Any ideas on how to treat this in MLVapp? Looks more like my old 5D2!

Many thanks.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 13, 2019, 12:50:49 PM
Quote from: timbytheriver on March 13, 2019, 12:09:04 PM

(https://i.ibb.co/Z2MgfBs/aliasing.jpg) (https://ibb.co/Z2MgfBs)


Hi! This grab is from a 1080p/45fps clip on 5D31.2.3 in MLVapp 1.5 using AMaZe debayer. Lens is Canon L 16-35mm 2.8.

The aliasing/fringing around the leaves looks bad to me! Oddly enough, LMMSE debayer seems to make it worse!

Is this normal for a 5D3? Any ideas on how to treat this in MLVapp? Looks more like my old 5D2!

Many thanks.
For me it just looks extremely overexposed (window is completely white). This causes artifacts at details. Bringing details out of overexposed areas is a hard job for all debayers.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on March 13, 2019, 01:32:05 PM
Thanks @masc Good catch, but the exposure appears to be just on the edge!


(https://i.ibb.co/qxPBhCV/smoothing.jpg) (https://ibb.co/qxPBhCV)


Forgot about Chroma smoothing; here with value=6 applied. Much better now! :)

I love MLV App!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on March 15, 2019, 11:33:36 PM
Quote from: Andy600 on March 11, 2019, 11:14:56 PM
...as mentioned before it would probably be better to implement a proper CMS (ACES, OCIO etc) into MLVApp as it would be more efficient and infinitely expandable.

+1  8)

Quote from: Danne on March 11, 2019, 11:29:32 PM
Andy600, we missed you and colorspace discussions 8).

Big time!

Quote from: Danne on March 11, 2019, 11:29:32 PM
Ilia3101 been working on aces transform for a while. Seems hard.

Hopefully @Andy600 could bring us hints, if any.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Jonit on March 16, 2019, 08:01:11 PM
I've been watching some of my old vids and was thinking how good that footage looked even in early days. I've been shooting with 600D back then and I was processing in MLRawViever. I loved that convertor so much. It gave me awesome results and especially I loved the C-Log look. I've been using it as a final output without any aditional grading or color correction. But MLRawViever is no longer being maintained (unfortunately :( ) so it doesn't support newer 10-12bit and lossless compressions. Also it didn't have black point repair capability (which I greatly appreciate in MLVApp) and it also had a problem with overexposed footage where it would put color stripes over that area.

So I thought that I may try to "recreate" that C-Log look in MLVApp and I think, I've got pretty close, but I noticed one thing in that process and that is that video files produced by MLRawViewer have much less aliassing in them. Like the debayer algorithm is doing much better job there. Which is strange as both programs were set to AMaZE.

Do any of you guys have any idea why?
The difference is quite staggering in the final output.


(https://i.ibb.co/5xPvB4G/Aliassing-APP-difference.png) (https://ibb.co/5xPvB4G)

(there is even more difference in another clips)


(https://i.ibb.co/4tBXZnq/MLRaw-Viewer.png)    (https://ibb.co/4tBXZnq)(https://i.ibb.co/phbqgXs/MLVApp.png) (https://ibb.co/phbqgXs)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 16, 2019, 10:12:16 PM
RAW data has to be preprocessed to be able to debayer correctly. Maybe this is solved in different ways (sure it is). Don't find in the MlRawViewer's code how it is done there... was searching for hours, also in past already.
The AMaZE code is different too, but I exchanged it for test with the MlRawViewers code, and the result (also aliasing artifacts) was identical in my test pics.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on March 16, 2019, 10:46:16 PM
@Jonit This is due to how white balancing is done before debayering, MLRawViewer seems to do it better for that shot. Could you see if MLV App 1.4 is different or better please? there was a small change made between the two in debayer white balance, that improved things, but sometimes didn't.  I want to add an option for debayer white balance, hopefully that will fix your issue.

Also I'm shocked how close the two look... but they're both wrong, as they use sRGB ;)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on March 16, 2019, 10:49:44 PM
Quote from: Danne on March 11, 2019, 11:29:32 PM
Andy600, we missed you and colorspace discussions 8). Ilia3101 been working on aces transform for a while. Seems hard.

Idk if what I'm doing is an 'aces transform' - the main goal is just to use a bigger gamut for processing. I am also considering ProPhoto RGB, it seems like the primaries on that colour space may be more close to our perception of 'red' 'green' and 'blue' so it would be better for RGB curves and things like that.

Those discussions were fun but I was so clueless back then :D
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Jonit on March 16, 2019, 11:11:36 PM
Quote from: Ilia3101 on March 16, 2019, 10:46:16 PM
@Jonit This is due to how white balancing is done before debayering, MLRawViewer seems to do it better for that shot. Could you see if MLV App 1.4 is different or better please? there was a small change made between the two in debayer white balance, that improved things, but sometimes didn't.  I want to add an option for debayer white balance, hopefully that will fix your issue.

Here is the output from MLVApp 1.4. Looks the same to me.

(https://i.ibb.co/vqHLnjf/MLVApp-1-4-aliassing.png) (https://ibb.co/vqHLnjf)


Quote from: Ilia3101 on March 16, 2019, 10:46:16 PM
Also I'm shocked how close the two look...
Took me about an hour to fiddle with the sliders and curves to match it relatively close to that MLVRawViewer C-Log  :D.

Quote from: Ilia3101 on March 16, 2019, 10:46:16 PM
but they're both wrong, as they use sRGB ;)
Can you please elaborate a bit on this statement? I'm not very knowledgeable in that area so would be cool to understand a bit more :). Thanks!
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on March 16, 2019, 11:36:39 PM
Ok then this issue will need some more work. Maybe wait until I add a white balance slider.

Quote from: Jonit on March 16, 2019, 11:11:36 PM
Took me about an hour to fiddle with the sliders and curves to match it relatively close to that MLVRawViewer C-Log  :D.
Ah right...

Quote from: Jonit on March 16, 2019, 11:11:36 PM
Can you please elaborate a bit on this statement? I'm not very knowledgeable in that area so would be cool to understand a bit more :). Thanks!

Well, MLV App's C-Log doesn't use the C-Log gamut yet, it only matches the C-Log log curve. Proper log profiles are coming with the colour space improvements mentioned earlier.

My assumption was based on how similar they look... so it's possible that only MLV App is wrong, or both are wrong in different ways. Maybe @andy600 about if MLRV does log colour right?

I don't know if this is too much ask, but could you make a direct comparison of MLV App and MLRawViewer in C log and rec709? I just want to see how different they look... also see if unchecking use camera matrix in MLV App brings them closer or anything.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on March 16, 2019, 11:58:18 PM
Quote from: Ilia3101 on March 16, 2019, 11:36:39 PM
Ok then this issue will need some more work. Maybe wait until I add a white balance slider.

Whoohoo!

Quote from: Ilia3101 on March 16, 2019, 11:36:39 PM
Well, MLV App's C-Log doesn't use the C-Log gamut yet, it only matches the C-Log log curve. Proper log profiles are coming with the colour space improvements mentioned earlier.

Good to know.

Quote from: Ilia3101 on March 16, 2019, 11:36:39 PM
... also see if unchecking use camera matrix in MLV App brings them closer or anything.

Great call @Ilia3101! (if needed I tend to use 'Uncolorscience Fix' by @Danne in the compiled versions)

Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Jonit on March 17, 2019, 07:19:07 PM
Quote from: Ilia3101 on March 16, 2019, 11:36:39 PM
I don't know if this is too much ask, but could you make a direct comparison of MLV App and MLRawViewer in C log and rec709? I just want to see how different they look... also see if unchecking use camera matrix in MLV App brings them closer or anything.

There is no CLog profile in MLVApp (at least I don't see any), so I used Log-C instead.
There are different whitebalances between the two apps (MLVApp - I didn't touch anything, MLRawViewer - I pressed WB presset number "3" (the default one was way off)).


(https://i.ibb.co/vczJtGP/Profiles-difference.png) (https://ibb.co/vczJtGP)


Here are the original PNG frames: https://mega.nz/#!jJ1iGSZZ!Im80SRBNw6XewT3x0_y3pIsOdv_ZAcq1-sNkZ8MzZuQ

Quote from: Ilia3101 on March 16, 2019, 11:36:39 PM
Proper log profiles are coming with the colour space improvements mentioned earlier.
Yay!!  :P :)
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: lostfeliz on March 19, 2019, 04:01:55 AM
Anyone having an issue where my exports cut off after 29 seconds? I've been using Resolve for years. Wanted to switch to MLV App, but having this problem.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on March 19, 2019, 07:50:48 AM
At least tell your settings used or even better. Export all your settings into file and upload it here. Tell us your computer specs.
http://www.catb.org/esr/faqs/smart-questions.html#beprecise
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on March 19, 2019, 09:40:59 AM
@Jonit thanks for the comparisons!

I will try and grt MLRV set up to do my own tests. I wonder how much closer they would or would not be with adjusted balance/exposure
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 19, 2019, 01:35:19 PM
Quote from: lostfeliz on March 19, 2019, 04:01:55 AM
Anyone having an issue where my exports cut off after 29 seconds? I've been using Resolve for years. Wanted to switch to MLV App, but having this problem.
Nope. Can convert hundreds of GB all over the day without crash here. More information needed, to be able to reproduce.
Title: Re: MLV App 1.5 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 20, 2019, 07:31:45 PM
MLVApp v1.6 is out. Changes:

- Added HDR blending for ffmpeg export
- Added vignette filter (neg. strength) / correction (pos. strength)
- Added "Uncolorscience Fix" matrix for better colors in thungsten scenes
- Added toning filter
- Changed behaviour of sliders, when log curve selected - activate all processing elements with "Allow Creative Adjustments" checkbox, or uncheck for correct color
- Added 8bit PNG sequence export
- Added "Skip all" for files that can't be found on MLV import
- Added final resolution label in transformation group box
- Added 3 new cinematic color filters
- Added recursive bilateral filter, with luminance, chroma and range control (use it as denoiser)
- Some bug fixes and some minor changes

Have fun.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on March 21, 2019, 11:59:47 AM
@masc Prezzies!  Thank you! :D

How do I achieve HDR blending? can't find that option in mac version.

Sorry – found it!!

Tim
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on March 21, 2019, 12:34:20 PM
This is Great Developers! MLVApp is getting better and better and it will be nice if you can enhance Shadows/Highlights functions; it is causing contrasty edges and this not too good, Could you apply some of Box Blur for these edges?

I don't know how to do it as programmer, But I had the same thing when merging two videos in different Exposures manually in After Effects.

First Expoure for Highlights
Second Expoure for Shadows or Meditone
Here is what I am doing to merge it together in After Effects timeline:

1-Highlights Expoure clip
2-Highlights Expoure clip (second copy)
3-Mediton/Shadows Exposure

First one:
I make a matte for Highlights clip by lifting the Highlights up to make it completely white and darkening the shadows to make it completely black then Applying tint to get rid of the remaining colors then applying fast blur and box blur to soften the matte which cuasing also nice edges between Highlights and Shadows clip.

Second one: (Second copy of Highlights)
Change it to Luma Matte without doing anything.

Third one:
The Shadows/Mediton , I don't play with it also.

The point is how we can smooth the edges as programmer in MLVApp and how the things work there?

Okay also, I inspired after I got the nice results of manual video Exposures merging (I didn't find any tutorial about that unfortunately) to try to Process Dual ISO clips in similar way of course not the RAW , the H.264 ones . . It's a lot easier to do it like not a programmer  :P .
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on March 21, 2019, 03:56:16 PM
Thanks for all the efforts in this project. MLVApp is amazing. I use it in every production to convert MLV to ProRes in Log-C.

@Ilia3101
A higher color space is the only thing holding me from using MLVApp exclusively to process MLV files.
It would be great if you actually achieve that. Is there any specific problem you can't solve?
I started reading some stuff and found this camera spectral sensitivity for 5DMKII (https://github.com/ampas/rawtoaces/blob/master/data/camera/canon_eos_5d_mark_ii_380_780_5.json). Maybe this could be used to create an IDT? It would not be precise for other cameras than 5DMKII, but could be just precise enough. The ODT's can be found here (https://github.com/ampas/aces-dev/tree/master/transforms/ctl/odt).

I was thinking something like this:

(https://pictshare.net/ofxgfr.png)

High bit-depth output is important too, as on some companies (like Netflix) it's mandatory now to send HDR (meaning 10-bit Rec.2020).

@masc
Do you think it would be possible to implement a filter like Black ProMist? The idea is something like: gaussian blur on shadows and then change the blending mode, where gaussian intensity controls the amount of diffusion and opacity controls the overall intensity. Of course, it wouldn't be the same as the filter itself, but it would be close enough to "hide" crispy edges that digital cameras produces. I simulate that on photoshop this way:

(https://pictshare.net/z517nu.png)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 21, 2019, 07:53:51 PM
@theBilalFakhouri:
Shadows/Highlights is working with a boxblur at the moment. We render a blurred copy of the picture and use it to modify the original picture. Maybe we could get better results with a fancy different blur algorithm... in past Ilia showed an example - but I forgot which exactly. Main problem in past was render time for such algorithms.

@Luther:
Right now you can simulate something very close to this effect: set contrast to 100 and clarity to -100. This should give what you are showing - just with boxblur instead of gaussian blur. ;)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 21, 2019, 08:32:03 PM
@theBilalFakhouri:
when thinking about what I wrote in last post... last week I added "a fancy blur algorithm" - a recursive biliteral filter. You can test it in Details section as denoiser. When using the same algorithm for highlights, shadows and clarity, I am really impressed by my first tests. No more ugly edges. Have a look: (left=boxblur, right=RBF)
(https://i.ibb.co/yhcxGrB/M23-1205-frame-1.png)
Little side note: RBF is faster than boxblur. :D
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on March 21, 2019, 08:48:26 PM
Quote from: masc on March 21, 2019, 08:32:03 PM
@theBilalFakhouri:
when thinking about what I wrote in last post... last week I added "a fancy blur algorithm" - a recursive biliteral filter. You can test it in Details section as denoiser. When using the same algorithm for highlights, shadows and clarity, I am really impressed by my first tests. No more ugly edges. Have a look: (left=boxblur, right=RBF)
(https://i.ibb.co/yhcxGrB/M23-1205-frame-1.png)
Little side note: RBF is faster than boxblur. :D

That's amazing and creative :D Goodbye ACR .
Thanks for this Big improvement!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 21, 2019, 08:52:04 PM
Playing around with this... and I have to say, it is not golden yet... RBF sometimes creates a kind of vertical stripes on some edges:
(https://i.ibb.co/Csx9rQy/M28-1804-frame-1a.png)
Very ugly... :P

But it should show how much shadows/highlights/clarity depend on a good edge-preserving blur algorithm.

Edit: playing around with RBF parameters can minimize those artifacts.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: dariSSight on March 22, 2019, 01:41:09 AM
Quote from: Luther on March 21, 2019, 03:56:16 PM
Thanks for all the efforts in this project. MLVApp is amazing. I use it in every production to convert MLV to ProRes in Log-C.

@Ilia3101
A higher color space is the only thing holding me from using MLVApp exclusively to process MLV files.
It would be great if you actually achieve that. Is there any specific problem you can't solve?
I started reading some stuff and found this camera spectral sensitivity for 5DMKII (http://"https://github.com/ampas/rawtoaces/blob/master/data/camera/canon_eos_5d_mark_ii_380_780_5.json"). Maybe this could be used to create an IDT? It would not be precise for other cameras than 5DMKII, but could be just precise enough. The ODT's can be found here (http://"https://github.com/ampas/aces-dev/tree/master/transforms/ctl/odt").

I was thinking something like this:

(https://pictshare.net/ofxgfr.png)

High bit-depth output is important too, as on some companies (like Netflix) it's mandatory now to send HDR (meaning 10-bit Rec.2020).

@masc
Do you think it would be possible to implement a filter like Black ProMist? The idea is something like: gaussian blur on shadows and then change the blending mode, where gaussian intensity controls the amount of diffusion and opacity controls the overall intensity. Of course, it wouldn't be the same as the filter itself, but it would be close enough to "hide" crispy edges that digital cameras produces. I simulate that on photoshop this way:

(https://pictshare.net/z517nu.png)

Luther I am a proud ML Canon 5D Mark II User, I use MLVFS to convert MLV files to Temp DNG, Use AfterEffect to edit DNG in Adobe Camera Raw, then AfterEffect Render DNG to ProRes 4444XQ. I would like to know what do you think is the best log profile to use and What is your Workflow.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on March 22, 2019, 06:59:44 AM
Did some hdr blending(48fps HDR on my eosm). Hdr iso settings can be found under Crop mode sub menu since HDR mode is broken on this model otherwise when it comes to raw recording. Export render time is about the same as any other file thanks to averaging filter instead of enfusing, aligning etc.

(https://i.postimg.cc/QxRqDdWV/Screenshot-2019-03-22-at-07-04-52-png-scaled.png)

Also exported with H265(7 sec clip). The file size 897kb! Very high quality.
https://bitbucket.org/Dannephoto/magic-lantern/downloads/h265.mov

High iso
(https://i.postimg.cc/Vkpp3wzF/M21-1922-000000-tif-800px.png)

Low iso
(https://i.postimg.cc/FRQqHxdd/M21-1922-000001-tif-800px.png)

final result:
(https://i.postimg.cc/PrNDPnkZ/M21-1922-000001-tif-800px.png)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on March 22, 2019, 08:22:49 AM
Quote from: masc on March 21, 2019, 08:52:04 PM
... Have a look: (left=boxblur, right=RBF)

Edit: playing around with RBF parameters can minimize those artifacts.
This is amazing!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: dariSSight on March 22, 2019, 12:45:09 PM
Quote from: Danne on March 22, 2019, 06:59:44 AM
Did some hdr blending(48fps HDR on my eosm). Hdr iso settings can be found under Crop mode sub menu since HDR mode is broken on this model otherwise when it comes to raw recording. Export render time is about the same as any other file thanks to averaging filter instead of enfusing, aligning etc.

(https://i.postimg.cc/QxRqDdWV/Screenshot-2019-03-22-at-07-04-52-png-scaled.png)

Also exported with H265(7 sec clip). The file size 897kb! Very high quality.
https://bitbucket.org/Dannephoto/magic-lantern/downloads/h265.mov

High iso
(https://i.postimg.cc/Vkpp3wzF/M21-1922-000000-tif-800px.png)

Low iso
(https://i.postimg.cc/FRQqHxdd/M21-1922-000001-tif-800px.png)

final result:
(https://i.postimg.cc/PrNDPnkZ/M21-1922-000001-tif-800px.png)

Is that Dual ISO, and please can you share your workflow and setting of camera also?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 22, 2019, 02:22:02 PM
This is not DualIso, it is HDR. Workflow is described in the post you quoted (first picture).
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on March 22, 2019, 04:29:52 PM
@masc I know the HDR blending is done on export, but I can't see how to adjust the relative exposures of the two ISO frames in MLV App? I can't apply two different settings to individual frames can I?

Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on March 22, 2019, 04:41:18 PM
You set corrections to the movie file the same as any other file. The problem here is previewing since it will flicker until it´s exported through HDR blending option. No blended preview capability yet. I usually correct the higher iso and do color corrections fixes. Export a short test file and if ok I send the whole file through rendering. Higher frame rate recommended to avoid ghosting(no aligning or deghosting is applied).
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on March 22, 2019, 04:58:27 PM
@Danne

Got it. Thanks! Almost a rival for dual_iso ...  Maybe there should be a dual_iso_hdr.mo mixture! ;)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on March 22, 2019, 05:06:33 PM
What you guys are doing with MLVApp is absolutely insane!  These new denoiser filters are highly desirable and seem very promising.  Masc, I was wondering if you may be able to suggest a suitable workflow for noise cleaning that provide optimum results with high-ISO footage.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 22, 2019, 08:03:27 PM
Quote from: timbytheriver on March 22, 2019, 04:29:52 PM
@masc I know the HDR blending is done on export, but I can't see how to adjust the relative exposures of the two ISO frames in MLV App?
This is the main reason why we did not add it in past - "you won't see what you'll get". You'll have to do it as Danne proposed.

Quote from: IDA_ML on March 22, 2019, 05:06:33 PM
Masc, I was wondering if you may be able to suggest a suitable workflow for noise cleaning that provide optimum results with high-ISO footage.
Thanks, IDA_ML. I found that algorithm by accident and was very surprised. The workflow was mostly different for all test clips I played with. There is no general receipt, special clips need special settings. But mostly my workflow is like that:
- RBF chroma 70..100
- RBF luma 0..50
- then play with radius...
- maybe lower RBF luma if it becomes too smooth
- maybe try to get a little more sharpness, by sharpen 10..30 (more will just show what moiree is... as always) :P
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on March 22, 2019, 11:07:24 PM
Quote from: masc on March 21, 2019, 07:53:51 PM
@Luther:
Right now you can simulate something very close to this effect: set contrast to 100 and clarity to -100. This should give what you are showing - just with boxblur instead of gaussian blur. ;)

Tested it. Works very closely to what I was describing. Thanks!

Quote from: dariSSight on March 22, 2019, 01:41:09 AM
Luther I am a proud ML Canon 5D Mark II User, I use MLVFS to convert MLV files to Temp DNG, Use AfterEffect to edit DNG in Adobe Camera Raw, then AfterEffect Render DNG to ProRes 4444XQ. I would like to know what do you think is the best log profile to use and What is your Workflow.

@dariSSight I use Log-C from MLVApp. My workflow using MLV is: always get the best image first on camera (I normally ETTR to +1.5 stop) > Import on MLVApp > Exposure Correction (watch the histogram!) > WB Correction (using a 18% gray card you can just use the picker) > Change to Log-C > Export to ProRes 444.
Import on Premiere. Color grading using Lumetri curves and Filmconvert or Logarist (to simply transform to Rec.709). Denoise with NeatVideo and Sharpen with Samurai (from Digital Anarchy).

This is not the best workflow, though. For big productions the best would be to convert MLV to CinemaDNG, then use Resolve configure to use ACEScct.
If MLVApp adds ACES support and output to 10-bit Rec.2020 ProRes, I would easily just swith to do everything directly on MLVApp and use Premiere just to finish the video.

Quote from: Danne on March 22, 2019, 06:59:44 AM
Did some hdr blending(48fps HDR on my eosm). Hdr iso settings can be found under Crop mode sub menu since HDR mode is broken on this model otherwise when it comes to raw recording. Export render time is about the same as any other file thanks to averaging filter instead of enfusing, aligning etc.

That's very interesting @Danne. Would be possible to blend the raw data and export to MLV? So you could import and have the full preview. Probably not, right, because the merge uses ffmpeg tblend?
Another question: the averaging filter will work if you use a slower shutter speed (more than 1/96, for 48fps) or will generate ghosts?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Erkett on March 23, 2019, 07:41:27 AM
Hi there! :)
I have a question.
I will export my mlv-files to CDNG thru MLVapp with no camera matrix cuz I will have more space in Colorgrading later with colors and contrast.
But when I open my files i Davinci the camera matrix option is applied... Why is it so? Can I do something different?  :)

Best!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on March 23, 2019, 12:47:10 PM
Quote from: masc on March 22, 2019, 08:03:27 PM
This is the main reason why we did not add it in past - "you won't see what you'll get". You'll have to do it as Danne proposed.

@masc Thanks. It's fine for now! ;) MLV App kicks ass!  :P
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 23, 2019, 03:07:28 PM
Quote from: Erkett on March 23, 2019, 07:41:27 AM
I will export my mlv-files to CDNG thru MLVapp with no camera matrix cuz I will have more space in Colorgrading later with colors and contrast.
But when I open my files i Davinci the camera matrix option is applied... Why is it so? Can I do something different?  :)
cDNG = RAW. This means none of the settings in the Edit area is applied to your exported clip - except RAW Corrections. You can enable or disable CameraMatrix - it won't have any effect on the exported footage, when using cDNG. I can't tell what Davinci does exactly with the RAW data.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on March 23, 2019, 10:22:42 PM
Quote from: masc on March 22, 2019, 08:03:27 PM
I found that algorithm by accident and was very surprised. The workflow was mostly different for all test clips I played with. There is no general receipt, special clips need special settings. But mostly my workflow is like that:
- RBF chroma 70..100
- RBF luma 0..50
- then play with radius...
- maybe lower RBF luma if it becomes too smooth
- maybe try to get a little more sharpness, by sharpen 10..30 (more will just show what moiree is... as always) :P

Thanks a lot, Masc.  Denoising is a very important and useful feature and I really am glad that you guys brought it this far with version 1.6.  I think, serious testing is a must if we wish to get the most out of it in terms of naturally looking results.  So, I would like to encourage everyone to share his experience with these new filters here.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: jpegmasterjesse on March 23, 2019, 10:37:51 PM
I wonder if we can accomplish something similar to what Neat video does using a process similar to dark frame subtraction? If the user can identify an area of pure noise, could that be tiled and extracted from the base image?

For the hell of it, I shot a low light raw clip on my 5d2 at iso 6400. After white balancing in MLV App and denoising in neat it actually looked great. I know this might be apples and oranges, but I really wasn't able to get something comparable in MLVApp yet.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 24, 2019, 11:53:52 AM
We could add whatever you like. But remember: we always need the code of such algorithms. No code, no feature. Densoisers consists of a lot of math. At least for me it would be hard (if not impossible) to write a own better algorithm.

Out there in the internet I found some other, maybe still better looking free algorithms... but very hard to compile, very hard to include, and very very very slow. This was the reason why I did not include it to MLVApp.

If you own Neat, use it, because it is a very good software.

@IDA_ML:
are you able to compile MLVApp yourself? There is another hidden parameter in code (which I fixed after some tests). Maybe you also like to play with this one (it is just changing a number) ;) Maybe my parameter-set is not optimal.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on March 24, 2019, 12:24:58 PM
Unfortunately not, but I will keep testing the filters as they are.  I am convinced that useable results are quite feasible!  Great job, Masc!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on March 24, 2019, 01:34:51 PM
rawtherapee has a wavelet denoiser that is quite powerful, and photivo has a very good denoiser also.
they don't use the same principle as neat video, but they are very good and maybe one of them can be added without too much difficulty?
it might be worth a look.
when i think about denoisers it reminds me of those "denoisaicing" algorithms that look so incredible.  i wonder if anyone is using them yet in any open source projects?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 24, 2019, 06:44:24 PM
What demosaicing algorithms do you mean? The most powerful should be still AMaZE and for footage with much moiree or noise IGV.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on March 24, 2019, 07:17:44 PM
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5492375/
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on March 25, 2019, 11:37:10 PM
Quote from: masc on March 24, 2019, 06:44:24 PM
What demosaicing algorithms do you mean? The most powerful should be still AMaZE and for footage with much moiree or noise IGV.

There's some already implemented. See:
https://github.com/cchen156/Learning-to-See-in-the-Dark
https://github.com/cig-skoltech/deep_demosaick

Other research:
https://groups.csail.mit.edu/graphics/demosaicnet/data/demosaic.pdf
www.nowozin.net/sebastian/papers/khashabi2014demosaicing.pdf
https://www.researchgate.net/publication/323165044_Joint_Demosaicing_and_Denoising_with_Perceptual_Optimization_on_a_Generative_Adversarial_Network
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on March 26, 2019, 09:02:09 AM
Hmm...

Hey Danne I think you will be interested in deep_demosaick to use it in Switch :)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on March 26, 2019, 09:30:55 AM
I thought both first links was pretty spectacular. Not very straight forward how to get this boat floating but maybe could get something going after some tinkering.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on March 26, 2019, 10:10:17 AM
Quote from: Luther on March 25, 2019, 11:37:10 PM
There's some already implemented. See:
https://github.com/cchen156/Learning-to-See-in-the-Dark

Is this research mean: how to turn your camera into sony a7s?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 26, 2019, 10:15:02 AM
Hm... none of them is usable in MLVApp without reinventing the world. Our application is C, C++, Objective C, and code should be at least one of them. Or maybe somelike likes to translate python to C.

I tried out some other debayers yesterday:
- Counter Stencils (https://www.ipol.im/pub/art/2012/g-dwcs/)
- SSD (https://www.ipol.im/pub/art/2011/bcms-ssdd/)
- AICC (https://www.ipol.im/pub/art/2015/145/)

All are working, but are very slow (we count minutes per image).
- Counter Stencils looked comperable to bilinear (whyever not better, it did 250 iterations, 337sec per image)
- SSD looked close to LMMSE + some more artifacts, therefor slower
- AICC looked close to AMaZE, a little different here and there, but not better, @4 threads around 86sec per image
All tests were made at 1856x1044.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on March 26, 2019, 12:06:14 PM
Quote from: masc on March 26, 2019, 10:15:02 AM
Hm... none of them is usable in MLVApp without reinventing the world.

:(

The processing would take hours without CUDA support. Yeah, not really feasible. But neural networks open a new world of possibilities for image processing. First time I read this stuff I couldn't believe it was true. Down below there's some impressive debluring algorithms [1][2][3][4], moire reduction [5] and super-resolution [6][7].

If someone here is looking to upgrade the demosaicing in MLVApp, I think it would be best to look what the high-end industry is using right now.
I'm not an expert, but most people recording with Panavision DXL2/mini or ALEXA LF seem to use Colorfront Transkoder (http://colorfront.com/?page=SOFTWARE&spage=Transkoder) or Codex Production Suite (https://codex.online/). ARRI recommends their own algorithm, called "ADA-5", that can be tested using their freeware software (https://www.arri.com/en/learn-help/learn-help-camera-system/tools/arriraw-converter) (sample footage from ALEXA here (https://www.arri.com/en/learn-help/learn-help-camera-system/downloads/camera-sample-footage)). This ADA-5 is now a standard called "RDD 31:2014" (https://ieeexplore.ieee.org/document/7289691) (couldn't access the paper myself).



[1] http://openaccess.thecvf.com/content_ECCV_2018/papers/Jiangxin_Dong_Learning_Data_Terms_ECCV_2018_paper.pdf
[2] https://github.com/jacquelinelala/GFN
[3] https://github.com/jiangsutx/SRN-Deblur
[4] https://arxiv.org/abs/1808.00605
[5] https://arxiv.org/abs/1805.02996
[6] https://github.com/jiangsutx/SPMC_VideoSR
[7] https://github.com/xinntao/ESRGAN
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 26, 2019, 12:25:52 PM
I don't think MLVApp will get any CUDA support - at least as long as I develop for it... I have no such hardware and no idea how to program it. :P

I don't think ARRI has the same problems we have. E.g. AMaZE is superb, if it gets good RAW data. We still have the problem of line skipping what produces the artifacts we all don't like. At 1x1 recording, our algorithms should be more than okay.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: amp829 on March 26, 2019, 02:28:18 PM
 Can somebody tell me about the export settings to get the best result for a playback video ,  because even though i am choosing some settings , as H265 / mpeg amaze / etc . the result is only a few mb from a GB size mlv file and there is obvious too much loss of quality and information that makes think that i am doing something wrong ...
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ArcziPL on March 26, 2019, 02:36:19 PM
Quote from: amp829 on March 26, 2019, 02:28:18 PM
Can somebody tell me about the export settings to get the best result for a playback video ,  because even though i am choosing some settings , as H265 / mpeg amaze / etc . the result is only a few mb from a GB size mlv file and there is obvious too much loss of quality and information that makes think that i am doing something wrong ...
Use a ProRes format for output.

@masc: is there an option to adjust bitrate for h264/h265 export? Or can it be added? Or maybe a custom command-line option to ffmpeg; shall be more than enough.

Just used v1.6 few days ago for a new video. Amazing work! I like the new features a lot.

BTW: Could you please describe what is the order of applying the operations on the image? I guess it's not top-to-bottom like organized in the right  panel, as this would rather be sub-optimal.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on March 26, 2019, 02:58:08 PM
In MLVApp v1.6 h264/265 is set to "24". In latest commit it is set to maximum quality, what a "normal PC" is able to decode and playback.

See help / wiki to see which features are realized in which order. Maybe some small newer things are missing... please ask if so.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: amp829 on March 26, 2019, 08:27:39 PM
you are right i used the options proves and the quality is much better
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 01, 2019, 01:00:37 PM
Great App, i have a question, i have canon M and app detects raw white level as 3817 but correct one is 3490 ,is there any way to change this so it will be correct on every clip ? So i dont have to do it manually all the time.
I have pink highlights if white level is incorrect.
Or is my thinking wrong and theres some other way to deal with pink highlights?
---
It looks like different clips have different white level anway
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on April 01, 2019, 01:52:45 PM
What are your settings in cam when getting white level 3490? What eos m build are you using? Could you upload a sample mlv?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 01, 2019, 03:09:36 PM
Im using very latest build  crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Mar29.EOSM202
After more investigation i think i was wrong and just didnt had ticked reconstruct highlights, so all is fine now besides the fact that im a noob in ML RAW.
:D

Or not, i found other clip, reset all settings for correction , just ticked reconstruction and highlights down, theres pink, until i go raw white level to 3490
Ill upload the clip, IMO it has something to do with highlights being clipped, when theyre not clipped then default value of 3817 is fine.
IT would be supercool if app would detect clipped highlights and use 3490 if thats the case.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 01, 2019, 03:28:40 PM
Heres the file
https://drive.google.com/open?id=1TNF4tVdaNMKJoAijhbYi1ftfrOGrh_d7
3817
(http://picplus.ru/img/1904/01/59a12437.jpg)
3490
(http://picplus.ru/img/1904/01/f35477f0.jpg)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on April 01, 2019, 04:02:09 PM
If using crop rec in this branch  crop_rec_4k_mlv_snd_isogain_1x3_presets always go with bitdepth reduction from with Crop mode sub menu. In RAW video keep it at 14bitlossless. More info here:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg208959#msg208959

EDIT: Seems you might have been running some RAW video setting. Anyway. To get most out of your eosm I recommend enabling cro rec module and run the presets in there.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 01, 2019, 04:55:17 PM
Per session you can enter white level once, then press Ctrl+C, select Whitelevel only, Ctrl+A, Ctrl+V.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 01, 2019, 06:26:43 PM
Thanks a lot !
I also was wondering about blacks and darks noise....
It seems like black areas of the image are noisy even at ISO100, probably becaise constrast is flattened out compared to what we see in camera ( i was able to see in raw what was totally black in neutral pic style).Canon's contrast settings for pic styles hide noise in the dark.
So.. this got me thinking, if its possible to reconstruct highlights, is it also possible to reconstruct darks ? Green channel is lost in highlights and introduces magenta , if my thinking is right.
In darks there is green noise prevalent so maybe similar reconstruction to darks would help to at least smooth out the noise a bit ?
Or am i totally wrong and theres other cause of noise ?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 01, 2019, 06:37:41 PM
We don't reconstruct noise, we reconstruct blown out areas. 2 channels need to be correct for this. I can't remember having seen this for darks.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 01, 2019, 06:50:16 PM
Would having chroma blur only for dark areas help ? Is it currentlyu for entire image , darks,mids and highs ?
Also do we have control over h.264 compression ? I could use more detail when exporting.Theres huge detail gap between mjpeg and h264/265 export
Im using LMMSE  which produces sharpest image but im getting artifacts(red dots ) when theres a lot of bright areas in the middle of image
(http://picplus.ru/img/1904/01/25022f77.jpg)
Are these focus dots leftovers ? Thats what i think , maybe removal isnt working in the sam way when LMMSE is active
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 01, 2019, 08:29:33 PM
Quote from: 2blackbar on April 01, 2019, 06:50:16 PM
Would having chroma blur only for dark areas help ? Is it currentlyu for entire image , darks,mids and highs ?
It is currently for the entire image. Are you able to compile the app? as @masc has added really really good denoising that you could try, it can do what chroma blur does without ruining colour at edges.

Quote from: 2blackbar on April 01, 2019, 06:50:16 PM
Also do we have control over h.264 compression ? I could use more detail when exporting.Theres huge detail gap between mjpeg and h264/265 export

I think some progress may have been made with this since last release.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 01, 2019, 08:32:50 PM
And sorry everyone there wasn't an April fool joke. it's coming a few days late. Github contains some spoilers (it's real funny)

Quote from: Luther on March 21, 2019, 03:56:16 PM
Thanks for all the efforts in this project. MLVApp is amazing. I use it in every production to convert MLV to ProRes in Log-C.

@Ilia3101
A higher color space is the only thing holding me from using MLVApp exclusively to process MLV files.
It would be great if you actually achieve that. Is there any specific problem you can't solve?

We already convert to sRGB correctly, other colour spaces like ACES are just need a different matrix. But thanks for all the interesting links you sent. You may be pleased in a few days ;) ;) ;) ;)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 01, 2019, 09:05:11 PM
Quote from: 2blackbar on April 01, 2019, 06:50:16 PM
Would having chroma blur only for dark areas help ? Is it currentlyu for entire image , darks,mids and highs ?
Not sure if the helps. I tried that in past and it did just nothing. Because the noise you see isn't dark. The background/area around is dark.

Quote from: 2blackbar on April 01, 2019, 06:50:16 PM
Also do we have control over h.264 compression ? I could use more detail when exporting.Theres huge detail gap between mjpeg and h264/265 export
In v1.6 In latest commit you have maximum quality - at least maximum a "normal" PC can playback. On the other side: If you need high quality don't use h264/h265.

Quote from: 2blackbar on April 01, 2019, 06:50:16 PM
Im using LMMSE  which produces sharpest image but im getting artifacts(red dots ) when theres a lot of bright areas in the middle of image
...
Are these focus dots leftovers ? Thats what i think , maybe removal isnt working in the sam way when LMMSE is active
Nope, these aren't focus dots. The dots are flickering all over the picture on playback - focus dots are static. We still get such problems with LMMSE and don't know why. You are invited to debug, if you can. I was searching for some days already, Ilia as well. We found nothing.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 01, 2019, 10:10:59 PM
I did some coding but for games mostly, im not as smart as You guys and this app is already amazing with the tools it has.
Im able to hide noise with "shadows" slider under "highlights" it looks natural and i dont have to blur chroma which creates that color fringe/glow around person thats affected by it, if there would be a way to contain chroma blur to its original area and not expand...
What do You suggest as final export format from MLVApp ? Most export formats in it are uncompressed / lossless for exporting to edit in other video editors later, id like exported video from MLV App to be final output.
Would it be possible on day to export all clips one after another as one video? ( merge them on export ) i direct stream copy them all after export from MLV App
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 02, 2019, 08:09:09 PM
Quote from: 2blackbar on April 01, 2019, 10:10:59 PM
...and i dont have to blur chroma which creates that color fringe/glow around person thats affected by it, if there would be a way to contain chroma blur to its original area and not expand...
Already done. Try out "RBF denoise chroma". (If I understood right.)
Quote from: 2blackbar on April 01, 2019, 10:10:59 PM
What do You suggest as final export format from MLVApp ? Most export formats in it are uncompressed / lossless for exporting to edit in other video editors later, id like exported video from MLV App to be final output.
As final output e.g. h264/h265 is fine.
Quote from: 2blackbar on April 01, 2019, 10:10:59 PM
Would it be possible on day to export all clips one after another as one video? ( merge them on export ) i direct stream copy them all after export from MLV App
I don't think it will be possible in future. Because a session supports clips of any aspect ratio and of any resolution - mixing won't work at all. We would have to resize, crop, etc. ... but MLVApp is not supposed to be a NLE. At least for now. And there are very good programs out there you can use for free.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 02, 2019, 08:56:08 PM
Yeah , good to know, i have one more question ,when we adjust white level in RAW to get rid of pink highlights then entire image is lifted, wouldnt it be better if only highlights would be stretched/lifted leaving mids where they were ? I see i have a bit more noise in darks visible after i correct my white levels.
Or some other method where darks and mids  will stay intact and only highlights will be corrected.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 02, 2019, 09:03:05 PM
White level correction is a RAW correction, not a processing step. Black and White level are the min and max parameter values of (usable) RAW signal. Corrections can be done with curves and other parameters.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 02, 2019, 09:17:59 PM
So its not possible to correct white level in RAW so entire image wont be brighter ? i think most people are using this to remove pinks problem when footage is overexposed.
What i found out is that white level can be quite random with overexposed footage.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 02, 2019, 10:10:10 PM
Normally, the correct whitelevel will be set in camera (by the ML software), this is why Danne was asking some posts before. The slider is only there to adjust if the camera failed doing it correctly.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on April 02, 2019, 10:44:17 PM
As said before. Use Crop mode sub menu bitdepth control. Leave  RAW video to 14bitlossless.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 02, 2019, 11:10:35 PM
Im just testing 4.5k RAW and almost pissing myself from hapiness , i dont know how You did it Danne but im amazed. :o
Im using 11 bits to save space, is it wrong ? Sorry to derail masc ! Im a bit overexcited with this, Raw has so much more colours, image is beatiful.Rich cyans and magentas, even better than real life.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on April 02, 2019, 11:25:11 PM
Yes, anamorphic is somehting else. True cinematic feel.
Well, 11bit lossless won´t work with anamorphic but 10bit from here will:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg208959#msg208959
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on April 03, 2019, 06:41:52 AM
Quote from: Ilia3101 on April 01, 2019, 08:32:50 PM
You may be pleased in a few days ;) ;) ;) ;)

:o Can't wait for it.


    { /* GAMUT_Rec2020 */
         1.72466, -0.36222, -0.25442,
        -0.66941,  1.62275,  0.01240,
         0.01826, -0.04444,  0.94329
    },
    { /* GAMUT_ACES_AP0 */
        1.0498110175, 0.0000000000, -0.0000974845,
        -0.4959030231, 1.3733130458, 0.0982400361,
        0.0000000000, 0.0000000000, 0.9912520182


Hope I'm not spoiling the surprise. But, according to Walter Arrighetti (https://acescentral.com/t/review-on-aces-colour-spaces/171), AP0 is mostly used for archival of footage, while AP1 is the one used for color grading (normally ACEScct).
Looking foward to version 1.7!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Galterius on April 03, 2019, 05:06:02 PM
Hey there, I am new to the magic lantern sphere. I have a 5d mark ii, and I just filmed some 3k raw 10bit video. I imported them into the mlv app v1.6, but then when I export them (with the right settings), they appear only in my quick access menu in my win10 explorer, they weight 0 byte, and I can't read them, with vlc, or in Premiere Pro... i will try on my mac, but this is very weird... (I tried prores 4444, h265, h264, but nothing works, sadly)
Thanks !
EDIT : I downloaded the 1.5 version and it works !!!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 03, 2019, 07:53:13 PM
After editing over 50 clips today i have one small suggestion about menu placement, theres "shadows" and "highlights" sliders and they are far down , i use them quite a bit especially hightlihts and i use white level in raw ... so i have to scroll a lot of times.
What if shadows and highlights sliders would be moved up in side menu to be with exposure and contrast , just right below them ?
I think i makes sense a lot, tools for adjusting brightness should be close  to each other to speed up workflow.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 03, 2019, 08:11:26 PM
Quote from: Luther on April 03, 2019, 06:41:52 AM
:o Can't wait for it.


    { /* GAMUT_Rec2020 */
         1.72466, -0.36222, -0.25442,
        -0.66941,  1.62275,  0.01240,
         0.01826, -0.04444,  0.94329
    },
    { /* GAMUT_ACES_AP0 */
        1.0498110175, 0.0000000000, -0.0000974845,
        -0.4959030231, 1.3733130458, 0.0982400361,
        0.0000000000, 0.0000000000, 0.9912520182


Hope I'm not spoiling the surprise. But, according to Walter Arrighetti (https://acescentral.com/t/review-on-aces-colour-spaces/171), AP0 is mostly used for archival of footage, while AP1 is the one used for color grading (normally ACEScct).
Looking foward to version 1.7!

Spoiling is fine. (https://github.com/ilia3101/MLV-App/issues/158)

And thanks, I have heard about AP1 before from Andy600, but he said the AP0 gamut would also be good for internal processing as it is very wide. I would add the AP1 gamut too if it weren't so difficult to find the matrix online. Maybe you know where it is ;)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on April 03, 2019, 09:02:19 PM
Checked dcraw sources? Aces in there last time I looked.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 03, 2019, 10:10:23 PM
Unclear which ACES gamut :/
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on April 03, 2019, 11:32:58 PM
Quote from: Ilia3101 on April 03, 2019, 08:11:26 PM
I would add the AP1 gamut too if it weren't so difficult to find the matrix online. Maybe you know where it is ;)

Not sure if this will help (I'm not a coder), but I've found this CTL (https://github.com/ampas/aces-dev/blob/master/transforms/ctl/csc/ACEScct/ACEScsc.ACES_to_ACEScct.ctl) that can transform from AP0 to ACEScct. About CTL here (https://github.com/ampas/CTL).
Also, these are the primaries (it seems... found on github (https://github.com/ampas/aces-dev/blob/master/transforms/ctl/lib/ACESlib.Utilities_Color.ctl) and on the document S-2016-001)


const Chromaticities AP1 = // Working space and rendering primaries for ACES 1.0
{
  { 0.713,    0.293},
  { 0.165,    0.830},
  { 0.128,    0.044},
  { 0.32168,  0.33767}
};


And the white point:


{
  { 0.32168,  0.33767}
};
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 04, 2019, 12:45:52 AM
Thanks a lot. I will see if I can find a way to convert that to a matrix.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 04, 2019, 08:37:14 AM
@Galterius: you can export with v1.5, but not with v1.6? That would be strange - realization of export is identical.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on April 04, 2019, 02:28:38 PM
Quote from: Ilia3101 on April 04, 2019, 12:45:52 AM
Thanks a lot. I will see if I can find a way to convert that to a matrix.

@Ilia3101 I'm not sure what I'm doing, but might be something: got a ICC profile from Rawtherapee (https://github.com/Beep6581/RawTherapee/blob/dev/rtdata/iccprofiles/output/RTv2_ACES-AP1.icc) and then, using the tool iccgamut from Argyllcms (http://argyllcms.com/doc/iccgamut.html) converted to gamut values. Result here: https://we.tl/t-pE3mjmuh55

edit: the "code" tag doesn't work because the file is too big, so I had to upload it.

ps: If you contact Beep6581 on github he could have the correct matrix.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 04, 2019, 05:02:18 PM
Whats the current bitrate for h265 ? i think is higher than 264, could we get something to adjust it when exporting? Its a shame to export and lose details when we have such great color correcting tools and compressing twice will reduce details even further.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 04, 2019, 08:32:44 PM
<= v1.6:
- "-crf 24" for both
> 1.6:
- high h.264: "-crf 14"
- high h.265: "-crf 18"
- medium h.264: "-crf 24"
- meduim h.256: "-crf 24"
If you don't want to loose detail, h264 and h265 are not the right codecs for you.

Same question was asked last week last time... in this thread.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 04, 2019, 09:04:48 PM
But there arent other final output codecs in MLVapp that would compress nicely while preserving detail. h.265 is not bad but compression values set in MLVapp are too high to preserve detail that shows up for example in ancient MJPEG and h.265 files are quite small which is great to save space but not great to save detail in footage.Thats why im asking if it would be possible to adjust this in the future.
So in 1.7 that will change according to your info ? I tried to install qt and mingw but i dont have enough disk space at tbe moment being flooded with raw files from excitement.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 04, 2019, 09:10:01 PM
Why not using e.g. ProRes4444 if detail is important? Or ProRes422, a little smaller and still very good.
Current revision has 2 ffmpeg settings for h.264 and h.265, one medium and one high quality option.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 04, 2019, 09:55:35 PM
Its for final output to share later, prores proxy the lowest q one gives me  30 mb for 10 seconds , while h265 gives me 3.9 mb, thats a major difference, but i would like to have something like 8mb h265 for 10 seconds.Its cause i dont want to to export prores and then export again as final edit in other software, just prefere to correct in MLVapp and its done, ill direct stream merge the files in avidemux, so having greater control over quality of export with h.265 would be very useful, other programs dont have such good color correction tools but major factor is encoding twice which takes time and disk space.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: wety67e on April 05, 2019, 11:16:36 AM
Hi...i have a problem with mlv app and Dxo...  :D

My 100d Dng are not compatible with Dxo optics pro but in this thread i found this dng which is ok, it is opened without problems.

https://www.magiclantern.fm/forum/index.php?topic=11899.25

https://drive.google.com/file/d/0B9z8Y0rg-pu8M0RyWFU5T3hCYkU/view


How is it possible?
Thanks...
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 05, 2019, 01:06:50 PM
I have no idea what Dxo does... I don't own it. Have you tried uncompressed / lossless / other options? Have you tried opening the dngs with other programs? Do you have a sample from your 100d? Have you tried with other MLV->DNG converters?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Cipolippo on April 05, 2019, 01:36:34 PM
I use dxo.

Dxo support only 14bit dng...no 10-12  :D
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 06, 2019, 08:33:12 PM
One more feature suggestion - overwrite files yes/no.
Because i export all files at once after working on them, not one by one and sometimes i exported 15 files or so but i dont want to figure out which files already are exported so option to not overwrite already existing files would be super helpful with 200 mvl files to export when trying to hunt 20 files already exported .
Another feature is to list mlv files alphabetically or by numbers so its easy to go throught them all.
Also heads up for other guys who would like to preserve details in h265 export, just dont resize it up to 1920 because it will decrase amount of details with current compression values.Original res 1736x730 looks much better than 1920x816 upscale export.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 06, 2019, 09:44:22 PM
Quote from: 2blackbar on April 06, 2019, 08:33:12 PM
Original res 1736x730 looks much better than 1920x816 upscale export.
This depends on upscaling algorithm. At one point you have to up- or downscale, because I found no screen having 1736x730 until today. Using lanczos will give very good quality, instead of e.g. bilinear or blcubic (most players support).
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 06, 2019, 10:46:55 PM
Yeah lanczos is totally fine its not about that , its about these megabytes or precious data will be spent on details from 1736 instead of blurred background of 1920, compression only gives out so much kilobytes per frame to work with  i can clearly see footage wihout upscale being sharper and making resolution even higher will decrease detail even more.Its logical.
So ill be exporting in original resolution from now on, i feel current h265 and h264 compression is a bit too high, its too much and files are really very small.
Id love to have total freedom over amount of compression when exporting h264 /265.Eporting 200 files took a couple hours , half of the day, so im totally not up to doing it twice(prores then edit in sony vegas to h264).I even tried export in h264 after stabilizing and edits and total file with all takes came out actually bigger than first exports with all takes from MLVApp together and second export with stabilized footage lost a lot of detail because of double compression, i dont want to go that route.Cant export to prores cause i already hit full HDD message.
Fell in love with RAW and filming everyday, what can you do  :)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on April 06, 2019, 10:50:36 PM
Search for h265 in source code. Set quality to 12 or something. Compile. Chances are it won't even be able to play the but quality will be higher. Eill you see any difference? Not sure.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 06, 2019, 10:53:38 PM
Cant download qt and mingw , i really hit hard with HDD being full of raw data :-X
Whats the minimum size of both qt and mingw on disk to be able to compile ? During install ive seen gigabytes and i lost hope.
Currenlty 10 seconds of h265 in 1920x816 is 3.90 MB, this is too low to contain good detail, i feel 7mb would be enough
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: swinxx on April 07, 2019, 10:14:11 AM
Hello,
this is just an amazing app. THANK YOU FOR THIS!.. this is the missing link between MY CAM - MAGIC LANTERN  and - USABILITY!!
I wonder if it is possilbe to set more than 1 CUT INs AND CUT OUTs. Cause i have a long shot and need to extract multipe scenes from this ONE SHOT File.

Best wishes, and KEEP ON KEEPING ON. sw
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: swinxx on April 07, 2019, 10:48:45 AM
And another perhaps handy feature would be a visible control of IN and OUT Points in the bottom area.. (in the ruler)
Best wishes!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on April 07, 2019, 12:12:10 PM
And also adjusting the loudness of the sound track would come handy.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on April 07, 2019, 12:43:48 PM
Is there a way to show cropmarks (black bars) but still export full frame?
I shoot 16:9 with 2.35:1 cropmarks. It would be nice to see this layout in MLVApp
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on April 07, 2019, 05:00:33 PM
Quote from: Dmytro_ua on April 07, 2019, 12:43:48 PM
Is there a way to show cropmarks (black bars) but still export full frame?
I shoot 16:9 with 2.35:1 cropmarks. It would be nice to see this layout in MLVApp

+1
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 08, 2019, 05:29:40 AM
Help does anyone know where I can find an exceptionally cheap 5D mark 2 in America??? I broke my 5D with an accidental smash on a rock, so now I'm stuck with a Sony RX100 taking boring pics :(

I'm at Moab Utah, small place so unlikely anyone is from here, but I'll be at Las Vegas in a couple of days.

I would really happy if someone knows where I can find a terrible condition, super cheap, maybe even partially broken 5D mark 2 (as long as it has enough functionality left to shoot raw video)

Or if anyone has one to sell.

Thanks!!!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on April 09, 2019, 08:05:41 AM
don't you have some websites for local used products in the US? If you go to Vegas I'm sure you'll find another one for cheap!! Best of luck anyway, equipment breaking is so traumatazing, grrr.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on April 09, 2019, 12:32:49 PM
there's a pawn shop on every corner... you might have a hard time choosing!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: JADURCA on April 12, 2019, 03:40:09 AM
Wich one looks better? Same footage, each one processed using MLV App with Cineon and 100% sharpen at ProRes 444 and the other CinemaDNG uncompressed with Vertical Stripes in Normal. Cineon one color graduated with Sony Vegas Pro and the other with Adobe Photoshop RAW.

https://www.dropbox.com/s/6rpfgvc3dulsr11/ProRes%20444Cineon%2B100%25sharpness%20in%20MLV%20vs.%20AdobePhotoshop%20RAW.mp4?dl=0
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on April 12, 2019, 08:21:11 AM
You could upload two screenshots for comparison straight to a forum post. Easier to check.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: togg on April 12, 2019, 12:04:53 PM
I prefer the second one for colour but contrast is too high, anyway everything depends on the indended mood and scene flow, every colour can be good in general :)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: JADURCA on April 12, 2019, 03:38:35 PM
@Danne

Here!

(https://i.ibb.co/X3XD4fy/ML-Forum.png) (https://ibb.co/xfhYsKm)
<a target='_blank' href='https://freeonlinedice.com/'>craps 6 and 8 strategy</a>



The rocks on the one below, looks brighter because for me it was easier to grade with Shadow Adobe PS RAW slider. Maybe using the same equivalent slider withing ML App I can achieve the same result. If it looks kind of noisy is because I filmed 1080p 1:1 for an 200mm equivalent from a 24-70mm Sigma Art.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: JADURCA on April 13, 2019, 06:53:43 PM
It come to my attention, why I have to sharpen the image 100% withing MLV App so it looks the same quality in sharpness as a RAW processed sequence image using CinemaDNG uncompressed with Adobe Photoshop RAW? It is because when MLV App process a ProRes (we used ProRes 444) format the footage loses sharpness as it's being proceeded as an video format and not image sequence? Or there is another reason for this?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: dfort on April 13, 2019, 09:45:46 PM
Thought I'd bring up a few issues regarding focus pixels to the MLV App developers.

2blackbar uploaded some sample files that included a shot of a baby that was impossible to remove the focus pixels without giving the baby a case of the measles. Check out the discussion starting here (https://www.magiclantern.fm/forum/index.php?topic=16054.msg214686#msg214686) and you'll see what I mean. What worked best was dcraw. Better than any of the MLV apps I tried. Maybe there's something in the dcraw code that you could use to improve focus pixel interpolation? Note that dcraw also has a "median" filter that is like chroma smoothing on steroids.

Another issue came up with a new 100D crop_rec setting that needed a new focus pixel map file. This is a 1x3 sampling setting which we keep touting as the best setting for using Dual ISO on video. The focus pixel map file works fine on regular footage but it has a problem with Dual ISO. Both interpolation methods gave similar results:

MLV App Dual ISO
(https://live.staticflickr.com/7847/33722825258_f641b02a17.jpg) (https://flic.kr/p/TnYi4G)

However, it is working fine in MLVFS:

MLVFS Dual ISO
(https://live.staticflickr.com/7849/32657477617_e9937cca62.jpg) (https://flic.kr/p/RKQ7jV)

Not sure why this is happening but since the source code to these applications is freely available maybe the developers can look into it?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on April 13, 2019, 10:32:05 PM
Dfort is raising an important issue about cleaning focus pixels in the new 1x3 anamorphic mode.  It allows the EOS-M, 700D and 100D to work well with Dual ISO providing very clean shadows with negligible loss of quality.  It would be very helpful if MLVApp could clean the focus pixels in Dual ISO files shot in the 1x3 anamorphic crop mode.  For those who wish to try here are a few 1x3 samples shot on the 100D with and without Dual ISO:

https://we.tl/t-BOpvPBHvfy

Unfortunately, Chroma smoothing does not work with Dual ISO 1x3 files.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: dfort on April 14, 2019, 01:29:54 AM
Came up with another issue today. When exporting 1x3 Anamorphic setting files in cdng format they open up in the "correct" aspect ratio in Adobe Camera Raw but DaVinci Resolve shows the squeezed aspect ratio.

(https://live.staticflickr.com/7825/33725206498_6d5e6be486.jpg) (https://flic.kr/p/TobuVy)

When exporting cdng there is no option to resize:

(https://live.staticflickr.com/7889/46876973364_b2e3c641cc.jpg) (https://flic.kr/p/2eqmK1G)

However, MLV App recognizes the 1x3 sampling and automagically transforms the image and I'm guessing saves those settings in the metadata of the dng files.

(https://live.staticflickr.com/7868/46876973164_97672823d9.jpg) (https://flic.kr/p/2eqmJXf)

Tried it with the latest Resolve version 16 beta and they still haven't resolved that issue.  :P

Ok--so what's the chances of Blackmagic fixing this? Probably low because they came out with their own raw format (https://www.blackmagicdesign.com/products/blackmagicraw). Using BRAW was discussed before on the forum (https://www.magiclantern.fm/forum/index.php?topic=22903.0) and the lack of an encoder in the SDK is a show stopper for that format.

Anyway, just thought I'd mention this in case anyone is thinking of shooting their next feature on an EOSM/100D/700D using the 5K Anamorphic setting, processing in MLV App and grading cdng files in Resolve. Sorry but you will need to resize your files in Resolve.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on April 14, 2019, 07:08:39 AM
I'm pretty sure you can change aspect ratio in resolve. I did it for mv720 footage years ago.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on April 14, 2019, 08:26:23 AM
Dfort,

You probably did it the wrong way in Resolve.  In the Sizing window, just type 3 for the "Width" and 1 for the "Height" setting.  Resolve works with Non-DualISO 1x3 footage, converted with MLVFS, like a charm with your latest focus pixel map. 

For DualISO footage, I am afraid, MLVApp is your only option.  I use MLVApp to convert it to ProRes and then grade in Resolve.  Slow but works, with a few focus pixels left.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on April 14, 2019, 11:25:20 AM
i did a recent video in this mode on my 5d3 and i did indeed grade it in resolve.

once i loaded the cdng files into resolve i set the project size to the desired resolution and then under "input scaling" i selected "stretch frame to all corners"

voila!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 14, 2019, 12:49:20 PM
MLVApp saves the aspect ratio parameters into the cdng files. Somehow Resolve is not able to use it. Other applications do it. But there are possibilities to manually stretch it, as posted above.

@dfort: about the focus pixel issue: do you have some short test files for us? Did you manually install your map files to the right place? (next to executable)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on April 14, 2019, 01:26:12 PM
Bouncyball did the "dcraw" style pixel by modifying raw2dng code once. That should work too. Let's wake up mr B!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on April 14, 2019, 04:20:22 PM
Quote from: masc on April 14, 2019, 12:49:20 PM

@dfort: about the focus pixel issue: do you have some short test files for us?

Masc,
I posted a download link to such test samples on the previous page - two normal and two DualISO 1-frame MLVs.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 14, 2019, 04:53:06 PM
@IDA_ML: what's the problem with these clips? Here all focuspixel disappear when installing dforts maps. On some edges some single points stay there maybe... but not sure if any algorithm can interpolate such difficult points. But I would say 99% of the pixels are gone.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on April 14, 2019, 07:41:33 PM
Masc,
From Dfort's post  #2797 it is clearly seen that in DualISO files MLVApp does not clean the focus pixels completely.  They are clearly seen over the mountain area of the frame as pink dots.  In normal Non-DualISO files, these pixels are gone completely. 
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 14, 2019, 08:21:36 PM
@IDA_ML: When I tried today, non of those pixels were visible for the dual iso file on the mountain area. They are only visible if you don't install dforts maps.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: dfort on April 14, 2019, 10:12:32 PM
Really? Ok--it is either me doing it wrong or maybe you have a newer version? It worked fine for the regular file but not on the Dual ISO file.

Quote from: IDA_ML on April 14, 2019, 08:26:23 AM
You probably did it the wrong way in Resolve.  In the Sizing window, just type 3 for the "Width" and 1 for the "Height" setting.

The issue I brought up was that Resolve isn't reading the metadata in the cdng files. Sure, you can resize it but that's an extra step that shouldn't be necessary.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on April 14, 2019, 10:25:55 PM
Well, skipping cdng tags is nothing new. Even adobe skips this tag in premiere.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on April 15, 2019, 12:17:21 AM
Masc,

I checked everything again and it turned out, I hadnt copied the latest map into the MLVApp directory proprly.  My fault, I appologize for that.

Dfort,

I am using Resolve 15.  Just checked.  It opens and desqueezes a 1x3 Dual ISO files properly in the way I explained above.  Not of much use though since Resolve does not convert Dual ISO files.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: dfort on April 15, 2019, 08:40:09 AM
Well this is getting confusing. One day it doesn't work, next day using the same file and focus pixel map file -- it works:

(https://live.staticflickr.com/65535/47611685601_b834d5446e.jpg) (https://flic.kr/p/2fxhkn4)

What is also weird was that I was getting corrupted exported dng files then I launched MLV App this morning but after relaunching the app later in the day it worked fine.

Quote from: IDA_ML on April 15, 2019, 12:17:21 AM
I am using Resolve 15.  Just checked.  It opens and desqueezes a 1x3 Dual ISO files properly in the way I explained above.

I'm on Resolve studio 16 public beta. Yeah, I know--show off. I got a complimentary dongle from Blackmagic because I was testing out their products on a consulting gig.

Is this your explanation?

Quote from: IDA_ML on April 14, 2019, 08:26:23 AM
In the Sizing window, just type 3 for the "Width" and 1 for the "Height" setting.

Where is the Sizing window you are talking about? Please show us.

What I did find is that a clip can be resized in the timeline using the Transform option but simply typing in 3 for the width (x) and 3 for the height (y) doesn't work because it extends outside of the frame. Seems like it is more complicated than that. I just did this freehand until it looked about right. Obviously there is a better way but it requires doing some math:

(https://live.staticflickr.com/65535/47612229181_23c2761a1f.jpg) (https://flic.kr/p/2fxk7X8)

Quote from: IDA_ML on April 15, 2019, 12:17:21 AM
Not of much use though since Resolve does not convert Dual ISO files.

What workflow are you using? You need to convert Dual ISO in MLV App before exporting the cdng files.

Quote from: Danne on April 14, 2019, 10:25:55 PM
Well, skipping cdng tags is nothing new. Even adobe skips this tag in premiere.

True. Looks like the only way to get the right aspect ratio in Premiere is to do a dynamic link from After Effects. Either that or use a motion effect the same way as transform in Resolve.

By the way, both Resolve and Premiere has the option of changing the pixel aspect ratio but they are fixed options and none of them work with 1x3 sampling:

(https://live.staticflickr.com/65535/47559340102_dd2f1dd8cb.jpg) (https://flic.kr/p/2fsE3Ss)

In Resolve you can apparently resize on import but I couldn't get it to work with cdng files:

(https://live.staticflickr.com/65535/40645851523_bda4e53ddc.jpg) (https://flic.kr/p/24VJBzv)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on April 15, 2019, 09:01:16 AM
You could file a ticket to reolve about the cdng tag. Maybe they can get it to work. Even dcraw swallows this tag.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on April 15, 2019, 10:10:47 AM
Dfort,

Here you go:

(https://i.ibb.co/61p5dVY/Sizing-Window.png) (https://ibb.co/61p5dVY)


Note that I have changed the Width setting in the red rechtangle from 1 to 3.  It's a mouse click away.  Don't worry about this additional step.   You can also automatically apply it to all 1x3 clips.

It would be much more interesting to get the guys at BM to implement DualISO conversion in the next version of Resolve just as our MLVApp developers did.  But, I am dreaming again ...

As far as my workflow is concerned, if I need to grade Dual ISO files in Resolve, I convert them and desqueeze them in MLVApp, export to ProRes, open them in Resolve and continue with grading there.  Works great, even on my 7 year old laptop.  Maybe, one day we will have GPU processing in MLVApp and this will speed up the process significantly. 
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: dfort on April 15, 2019, 06:54:37 PM
Thanks--That screen shot says it all. The sizing option you're referring to is in the color view. That's not exactly intuitive. Here it is on my system:

(https://live.staticflickr.com/65535/47614435801_ae0bae3464.jpg) (https://flic.kr/p/2fxwqUi)

Maybe I should read the 2,739 page manual that came with Resolve before commenting on it again.

Quote from: IDA_ML on April 15, 2019, 10:10:47 AM
It would be much more interesting to get the guys at BM to implement DualISO conversion in the next version of Resolve just as our MLVApp developers did.

Why? You need to convert the MLV files to another format and Resolve works fine with DNG files. Converting Dual ISO in MLV App and MLVFS is done before exporting to DNG. This is in the RAW Correction settings:

(https://live.staticflickr.com/65535/46699078885_4b350f5501.jpg) (https://flic.kr/p/2e9CZbv)

Message to the MLV App developers: I believe there is a way to automatically check if an MLV is Dual ISO. It might slow down importing the files but it would be a nice feature.

In any case, there's the option to export in uncompressed, lossless or lossy (fast pass) DNG format. These DNG files will have the focus pixels removed, converted Dual ISO and whatever else you want to do in MLV App saved in the output file.

(https://live.staticflickr.com/65535/40648087373_03c428ebe6.jpg) (https://flic.kr/p/24VW5dD)

Now for the part that isn't making sense to me when working with DNG files. We can do all sorts of image manipulating in MLV App which is great when exporting any other file format but if you export to DNG these settings don't show up in other applications. Open a DNG file exported from MLV App in Adobe Camera Raw (ACR) and except for the aspect ratio setting we've been discussing, it looks like an un-manipulated file. Play with the settings in ACR and next time you open that DNG file in ACR you'll see that those settings were saved. Open the same file in Resolve and you're back to square one. What would be great is if the different software developers would use the metadata saved in DNG files so that whatever grade or image manipulation you made in one app will display properly on another app. That would also keep us from having to dig through menus, settings, adjust nodes, etc. just to apply a setting that is already set in the DNG file.

Sorry for the rant. I know we have no control over other applications, especially closed source commercial apps but isn't there some sort of a standard that is supposed to be followed when working with DNG files? Seems like nobody is following these standards, not even Adobe and they invented DNG.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 15, 2019, 08:51:58 PM
Quote from: IDA_ML on April 15, 2019, 10:10:47 AM
It would be much more interesting to get the guys at BM to implement DualISO conversion in the next version of Resolve just as our MLVApp developers did.  But, I am dreaming again ...
I don't think they will ever do, as long as no blackmagic camera is able to record dualiso. Or are they able to record such files?

Quote from: dfort on April 15, 2019, 06:54:37 PM
Message to the MLV App developers: I believe there is a way to automatically check if an MLV is Dual ISO. It might slow down importing the files but it would be a nice feature.
We already use the auto check and only enable dualiso GUI elements if the current clip is dualiso. We decided not to enable dualiso itself automatically, because of speed reasons.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: IDA_ML on April 16, 2019, 09:29:05 AM
Quote from: masc on April 15, 2019, 08:51:58 PM
I don't think they will ever do, as long as no blackmagic camera is able to record dualiso. Or are they able to record such files?

Masc,

This was just a dream.  I am perfectly happy with how MLVApp handles DualISO files, especially now that Dfort's latest focus pixel maps work with such files so well too.  Yes, rendering is pretty slow but for my amateur videos, it's perfectly OK.  I don't have a problem leaving the PC render DualISO MLVs all night long and when I wake up in the morning, they are ready and waiting for me to edit, grade and mount my final video in Resolve. 

As far as Blackmagic are concerned, in my opinion, if they add direct MLV processing as a standard to Resolve, their sales will increase dramatically.  Thousands of people worldwide use ML on a regular basis, so ML is changing the world.  I agree, MLVFS is very fast and easy to use as it is, I use it all the time.  But many people don't like that hassle and would prefer Resolve to open and work with MLV files directly.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on April 17, 2019, 12:32:01 AM
vid.stab seems to work very nicely @masc ! I was watching the demos and... damn.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 17, 2019, 01:17:56 PM
Quote from: Luther on April 17, 2019, 12:32:01 AM
vid.stab seems to work very nicely @masc ! I was watching the demos and... damn.
Yes, it works nicely. If someone likes to try it out: vid.stab for Win&OSX version is commited for testing, Linux is on the way in the next days. Works for FFmpeg export only!
(https://user-images.githubusercontent.com/30245296/56236081-08723800-6089-11e9-965d-f5eedcd7bf24.png)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: scrax on April 17, 2019, 03:24:32 PM
After this post (https://www.magiclantern.fm/forum/index.php?topic=7139.msg215279#msg215279) I was thinking about MLVapp when saying there are better app for converting MLV, RAW and dual_iso MOV.

What came to my mind is if MLVapp is scriptable?

Since I have not a lot of interest in video making I will like to have some sort of auto conversion for MLV files, so to have a file that can be used without any color correction or editing, just a full batch auto conversion without any user input.

So far my workflow is:
card inserted "Image Capture App" recognizes ML card and start MLTools to move all the files on card to my working folder and convert what that need it.
The working folder is monitored by LR autoimport and ML card get erased from imported files and unmounted when finished. 

My 600D can't do a lot of RAW video but I think I can use batch conversion for Timelapses with silent pic.

EDIT: I feel silly now that understood how to make it:


rm *.avi;
mlv_dump --dng M17-1342.MLV;
ufraw-batch --out-type=jpg *.dng;
rm *.dng;
ffmpeg -i M17-1342_%6d.jpg -vcodec mjpeg -qscale 1 video.avi;
rm *.jpg
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 18, 2019, 09:16:33 PM
Vidstab (video stabilizer) is now commited for Win&Linux&OSX. Especially Linux made some problems. I hope I could solve it... please have a try if you can and report issues! ;)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 19, 2019, 08:36:05 AM
Quote from: JADURCA on April 12, 2019, 03:38:35 PM
@Danne

Here!

(https://i.ibb.co/X3XD4fy/ML-Forum.png) (https://ibb.co/xfhYsKm)
<a target='_blank' href='https://freeonlinedice.com/'>craps 6 and 8 strategy</a>



The rocks on the one below, looks brighter because for me it was easier to grade with Shadow Adobe PS RAW slider. Maybe using the same equivalent slider withing ML App I can achieve the same result. If it looks kind of noisy is because I filmed 1080p 1:1 for an 200mm equivalent from a 24-70mm Sigma Art.

Thanks for the comparison.

What MLV App does is the same as Adobe camera raw, it processes raw images, except straight from MLV instead of through DNG.

So a fairer comparison would be one of these:

1. Convert to LOG in MLV app and to LOG in ACR (can use andy600's log product), then grade both versions in Vegas, then compare
2. Grade in MLV App and in ACR, then compare

But out of the comparison I like both results. The rocks are nice and contrasty in Adobe, but I think MLVApp version is more warm and "cinematic" (my fav word).
Title: Re: Making a New MLV Processing App! - Mostly for Mac (Right Now)
Post by: ilia3101 on April 19, 2019, 08:39:32 AM
Quote from: scrax on April 17, 2019, 03:24:32 PM
What came to my mind is if MLVapp is scriptable?

Would be if I'd kept this promise...

Quote from: Ilia3101 on July 08, 2017, 11:58:43 PM
Would be great to see it used with your scripts! I'll add a command line version that will work similar to mlv_dump, which would be useful for integrating with scripts (and would work on Windows and Linux!)

😢
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: JADURCA on April 19, 2019, 07:08:24 PM
Quote from: Ilia3101 on April 19, 2019, 08:36:05 AM
Thanks for the comparison.

What MLV App does is the same as Adobe camera raw, it processes raw images, except straight from MLV instead of through DNG.

So a fairer comparison would be one of these:

1. Convert to LOG in MLV app and to LOG in ACR (can use andy600's log product), then grade both versions in Vegas, then compare
2. Grade in MLV App and in ACR, then compare

But out of the comparison I like both results. The rocks are nice and contrasty in Adobe, but I think MLVApp version is more warm and "cinematic" (my fav word).

Thanks for replying! So, grading both LOG would be more of a fair comparison regarding sharpness?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 20, 2019, 12:19:03 AM
Great work masc ! Can someone compile for us win build to try ?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: whitelight on April 21, 2019, 01:01:39 AM
Hi everybody, just asking if after playing a clip it would be possible to make it restart by directly pressing "Play clip", without having to press "Jump to first frame". That would be a useful feature. By the way, thanks for this wonderful app!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 21, 2019, 10:10:46 AM
You could use this loop button (https://i.ibb.co/J5XyBKB/Bildschirmfoto-2019-04-21-um-10-06-48.png) and stop and start wherever you like.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 21, 2019, 01:43:33 PM
Hey masc its me again, i did some experiments using anamorphic mode on canon M, it resizes from  1488x1900 to 4464x1900 in MLVApp using probably lanczos or bicubic ? You know best, im guessing.
So i did test with b-spline resize and managed to get less staircase artifacts/aliasing with it than default method in MLVApp , do You think it would be possible to have b-spline as an option to upscale raw  frames in the future? Maybe theres even better algorithm, im still checking different ones but this one beats lanczos3,bicubic,bell,triangle or mitchell when it comes to interpolating 75degree staircase artifacts.
(http://picplus.ru/img/1904/21/305539dd.gif)
tests:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg215467#msg215467
IMO chroma separation sharpening after this b-spline should work much better and get rid of lot of aliasing.Would be nice as an option but not as the only choice cause theres a bit less perceived detail with it.
Original photo,bspline,mlvapp
(http://picplus.ru/img/1904/21/2b192400.gif)
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on April 21, 2019, 03:50:44 PM
Quote from: 2blackbar on April 21, 2019, 01:43:33 PM
but this one beats lanczos3,bicubic,bell,triangle or mitchell when it comes to interpolating 75degree staircase artifacts.

I think ffmpeg has Spline64 on it. Might be easier to implement and has a good quality...
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 21, 2019, 06:16:01 PM
@Luther & 2blackbar: the viewer of MLVApp does not show what you'll get when exporting. I think on playback it is linear interpolation or nearest neighbor (fast), else it is bicubic (or something similar Qt offers by standard when resizing a picture) You can choose between "fast" and "nice" in code.
The frame is sent as is (without resizing) to ffmpeg and ffmpeg does the resizing - with the algorithm you choose in export settings: bilinear, bicubic, sinc or lanczos. If you need some spline and ffmpeg offers this, it is simple to add. (there were many algorithms, not sure which exactly)

Edit: these are the algorithms supported by ffmpeg:

'fast_bilinear'
    Select fast bilinear scaling algorithm.
'bilinear'
    Select bilinear scaling algorithm.
'bicubic'
    Select bicubic scaling algorithm.
'experimental'
    Select experimental scaling algorithm.
'neighbor'
    Select nearest neighbor rescaling algorithm.
'area'
    Select averaging area rescaling algorithm.
'bicublin'
    Select bicubic scaling algorithm for the luma component, bilinear for chroma components.
'gauss'
    Select Gaussian rescaling algorithm.
'sinc'
    Select sinc rescaling algorithm.
'lanczos'
    Select Lanczos rescaling algorithm.
'spline'
    Select natural bicubic spline rescaling algorithm.
'print_info'
    Enable printing/debug logging.
'accurate_rnd'
    Enable accurate rounding.
'full_chroma_int'
    Enable full chroma interpolation.
'full_chroma_inp'
    Select full chroma input.
'bitexact'
    Enable bitexact output.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 21, 2019, 07:26:11 PM
I added bicubic spline rescaling via ffmpeg to repos.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 21, 2019, 08:16:19 PM
supercool !
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lucky Luke on April 21, 2019, 11:02:23 PM
Hello community.
Searching for help. On my old Windows 7 system I was successfully converting Canon 5d3 RAW to any format in MLV App. Just built a new Ryzen 2700x system on Windows 10. Everything fast and great exporting line is fast traveling to the right, but no file is exported..?. Nothing will be written on the Harddisk. Did I missed some thing already described here in forum?
Somebody had the same problem?
Thank U in advance with greetings from Austria.

Archie
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 21, 2019, 11:53:23 PM
Will it be possible to drag and drop dng files ? Silent pics for eample? Im so used to mlvapp that i export single frames cause theyre coming out nice and other software does not have camera tonemapped preview and other useful stuff.
Or at least can someone recommend simple app that could pack a bunch of dng files into mlv? Or they must share the same resolution?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Lucky Luke on April 21, 2019, 11:53:58 PM
Just solve it...downloaded and put the program to another folder...everything is great!

Springgreetings from Austria
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: whitelight on April 22, 2019, 12:36:52 AM
Quote from: masc on April 21, 2019, 10:10:46 AM
You could use this loop button (https://i.ibb.co/J5XyBKB/Bildschirmfoto-2019-04-21-um-10-06-48.png) and stop and start wherever you like.

Thank you masc, I didn't notice that could be useful in my case!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on April 22, 2019, 09:22:32 AM
Quote from: 2blackbar on April 21, 2019, 11:53:23 PM
Or at least can someone recommend simple app that could pack a bunch of dng files into mlv?
Nope, there is none (theoretically this could be done but nobdy did it yet, except some g3gg0's experimental code in ML main repo)

We decided that MLVApp's not gonna support DNG input natively. Use MLV output for silent pics (record MLV raw video) and do not delete converted MLVs.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 22, 2019, 09:47:43 AM
Quote from: Lucky Luke on April 21, 2019, 11:02:23 PM
Everything fast and great exporting line is fast traveling to the right, but no file is exported..?. Nothing will be written on the Harddisk.
Quote from: Lucky Luke on April 21, 2019, 11:53:58 PM
Just solve it...downloaded and put the program to another folder...everything is great!
Sounds like ffmpeg was missing...
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 22, 2019, 10:03:03 AM
Quote from: 2blackbar on April 21, 2019, 11:53:23 PM
Will it be possible to drag and drop dng files ? Silent pics for eample? Im so used to mlvapp that i export single frames cause theyre coming out nice and other software does not have camera tonemapped preview and other useful stuff.
Or at least can someone recommend simple app that could pack a bunch of dng files into mlv? Or they must share the same resolution?
As bouncyball already wrote, DNG import will not be possible so easy. The internal realization is written for MLV only atm and must be rewritten just for this feature. If you find a way of packing DNGs into MLV, all DNG files MUST have the same resolution and settings, otherwise you'll get crashes only. Frame geometry and memory allocation is adapted always using metadata found in the first frame of a clip atm (and normaly it does not change).
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 22, 2019, 07:26:15 PM
Yeah we can do mlv silent pics so theres no use of coding dng support, was just wondering if it was straightforward to add if it already kinda supports dngs that it has to unpack from mlv.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 22, 2019, 09:08:22 PM
Quote from: 2blackbar on April 22, 2019, 07:26:15 PM
... if it already kinda supports dngs that it has to unpack from mlv.
There is no dng in a mlv. Completely different. There is "just RAW data inside" in both formats. But even that is organized in different ways.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: aulden on April 29, 2019, 11:20:55 AM
Hi, im having issues with bad pixels with MLVFS. The "fix bad pixels" in MLVapp works WONDERS and eliminates all the dynamic dancing bad pixels.

So i am wondering if there is anyway workflow like MLVFS but within the MLVapp where one does not need to export. So it just "fake exports" to a virtual drive where i then can access the DNGs with Davinci?


(https://i.ibb.co/x53xDsZ/Screenshot-2019-04-29-at-07-43-10.png) (https://ibb.co/x53xDsZ)

(https://i.ibb.co/WPvPBd3/Screenshot-2019-04-29-at-07-46-40.png) (https://ibb.co/WPvPBd3)


My workflow now, due to the dancing bad pixels, is:

MLVapp fix bad pixels and focus pixels -----> Export CDNG ------> Davinci Resolve

Which works fine but the Export CDNG step takes allot of time and space :( Maybe there is an option within MLVFS im missing? The "bad pixel fix" in MLVFS only fixes the bad pixels in the first frame. Is there an option to execute bad pixel fix in all frames maybe?

Can someone please point me in the right direction. Thanks!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: limey on April 29, 2019, 07:03:42 PM
Testing a 3.5k crop mode shot that might 7 seconds long. The export via MLVAPP is roughly 15minutes. Is that normal?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 29, 2019, 10:25:49 PM
Quote from: limey on April 29, 2019, 07:03:42 PM
Testing a 3.5k crop mode shot that might 7 seconds long. The export via MLVAPP is roughly 15minutes. Is that normal?
Depending on your system, the used MLVApp version and your settings, maybe yes. But without knowing your settings and your specs, nobody will be able to answer...
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on April 30, 2019, 08:12:40 AM
@aulden: what I don't understand with your MLV: even if I disable RAW correction, I don't see those pixels in MLVApp. Or do you see them with RAW corrections OFF?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: nikki on May 01, 2019, 05:06:27 PM
How does motion look at 23.976 FPS?
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 01, 2019, 06:02:54 PM
Quote from: nikki on May 01, 2019, 05:06:27 PM
How does motion look at 23.976 FPS?
filmic
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Kharak on May 08, 2019, 04:39:09 PM
New version out, trying it out now!

Very nice!
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on May 08, 2019, 05:00:46 PM
No ACES :(
Anyhow, nice job this release, the new shadow/highlight seems cool.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 08, 2019, 07:58:46 PM
Yes, v1.7 is out now. Main changes:
- Added a simple grain generator
- Improved algorithm and quality for Shadows / Highlights / Clarity
- Added High/Medium option to H.264 & H.265 export
- Added ffmpeg vid.stab video stabilizer for ffmpeg export
- Added bicubic spline resizing algorithm to ffmpeg export
- Drop focus pixel map files into app to install (except Linux AppImage)
- IGV debayer is now multithreaded
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 08, 2019, 08:08:23 PM
 
Quote from: Luther on May 08, 2019, 05:00:46 PM
No ACES :(
Right, sorry. There is a development branch in the repos, if you like you can try it out. It is named "Better Processing". This one has ACES processing. Unfortunatelly we still have some problems with it - sometimes the output looks way better, but sometimes it looks very strange. That's why it is not merged to main branch yet.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 08, 2019, 08:31:19 PM
BetterProcessing is not just an ACES branch, you can choose output and processing colour gamuts from many, one of which is ACES.

Sorry having a bit of a break. I have to. I will definitely be back to finish at some point in June.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on May 08, 2019, 09:58:44 PM
Love the changes, You guys are great ! :D
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Kharak on May 09, 2019, 07:55:05 PM
Hey,

Is there a way in mlv app to see or extract all Metadata from a MLV ? Clip Information has most of it, but wondering if there is a way to see all metadata.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on May 09, 2019, 09:06:29 PM
@Kharak

What you exactly need. Details please ;) we can not dump all mlv structure here, as you know there is a dedicated tool called mlv_dump for this.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Kharak on May 09, 2019, 09:19:11 PM
Well right now I am looking for a user friendly way to find my camera serial number. 

Guess i am asking for a built in exiftool ;)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 09, 2019, 09:24:09 PM
Mlv_dump -v Input.mlv

Or just run one of your files in darkframes folder of batch_mlv.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Kharak on May 09, 2019, 09:50:26 PM
Quote from: Danne on May 09, 2019, 09:24:09 PM
Mlv_dump -v Input.mlv

Or just run one of your files in darkframes folder of batch_mlv.

Thanks, I did that.

Was just looking in to MLV App to see what it could do. :)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 09, 2019, 10:05:24 PM
I am very sorry to say that it seems I have found a bug with the new vid.stab stabilizer: I might have tested to much with h264 (here it works fine), but when I export e.g. ProRes422 or 4444 I get empty files - no idea why yet. Strange things happen with ffmpeg, I don't understand it yet.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 09, 2019, 10:34:21 PM
Hm... some more testing... that happens only for my EOS M clips - 5D2 is fine with ProRes422 output + vid.stab.  :-[

Edit: what the hell is doing ffmpeg?! Sometimes it works, sometimes it crashes. Same command, same input, same parameters.  :o
@Danne: do you have the same problems with your script stabilizer version?
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 09, 2019, 10:49:37 PM
Don´t be sorry. Interesting bug. Any idea what it might be? How is the vidstab setting applied? I only ran the script with mov files in Switch but always working:
ffmpeg -i input.mov -vf vidstabdetect=shakiness=10:accuracy=10:result=transform_vectors.trf -f null -
ffmpeg -i input.mov -c:a copy -c:v prores_ks -profile:v 2 -pix_fmt yuv422p10 -color_primaries bt709 -color_trc bt709 -colorspace bt709 -vf vidstabtransform=input=transform_vectors.trf:smoothing=10,unsharp=5:5:0.8:3:3:0.4 output.mov


Could you point me to code? Maybe the the trf file is erased too early or something? Only guessing...
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 09, 2019, 10:52:15 PM
Thanks for your commands. Will try it the weekend again. I like bugs most, which occur only sometimes... :P
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on May 10, 2019, 09:24:59 AM
Quote from: Kharak on May 09, 2019, 09:19:11 PM
Well right now I am looking for a user friendly way to find my camera serial number. 
Well serial info could be useful if several same model cameras are used on shoot.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 10, 2019, 01:40:20 PM
vid stab dont work at all after export ready i could not find any video in the folder if i check enable vid stab
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 10, 2019, 06:33:22 PM
Quote from: andy kh on May 10, 2019, 01:40:20 PM
vid stab dont work at all after export ready i could not find any video in the folder if i check enable vid stab
You are on Windows? I commited a fix today for Windows versions... don't know why this single character was missing, because I tested on Windows successfully before. And because of this single missing character in ffmpeg command Windows users get... nothing. :P Sry.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 10, 2019, 06:41:39 PM
Quote from: masc on May 10, 2019, 06:33:22 PM
You are on Windows?
yes im on wondows10
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 10, 2019, 09:49:47 PM
Still don't understand the problem.
--> Would be cool, if some mac users could try it out and post what configuration (Camera, Resolution, Export codec...) combined with vid.stab enabled works or not. 99% of my clips work, e.g. EOS M MCM rewire at 16:9 creates empty files for ProRes. ffmpeg stopps working when starting final output. All other files I tried here work just fine.  ::)
Windows users must compile latest commit to be able to test. But on windows ffmpeg seems to play even more Diva.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 10, 2019, 10:17:14 PM
Could you upload a non working file? Could try my script.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 10, 2019, 10:57:21 PM
The more I test, the less I can tell you what's the problem. Now it feels each file may crash or not, with same settings, 100% random. That really sucks.
Exporting 5x exactly the same will lead min. 1x to crash, if vid.stab is enabled. Here a 5D2 file.
https://www.dropbox.com/s/b8wo39wwdbboqkb/M05-0608.MLV?dl=0
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on May 11, 2019, 03:34:10 AM
Quote from: Ilia3101 on May 08, 2019, 08:31:19 PM
Sorry having a bit of a break. I have to. I will definitely be back to finish at some point in June.

No problem @Ilia3101, hope you're well!
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Erkett on May 12, 2019, 01:35:10 PM
I wonder if it possible to add a manually bad pixel function because the auto function will sometimes add some artifacts.
The bad pixel fixer thinks that the small amount of sky light thru the leaves is bad pixel but it is the sky.

This will often be on the first frame or that frame that you turned on the pixel fixer.
The color dots will be gone if you move the camera but sometimes when the camera is pretty still it will be the over the whole movie...

So please ad an manual bad pixel fixer cuz I only have one hot pixel on high iso on the my 5DIII.
I have attached a picture bellow:

(https://i.ibb.co/bLGFBBz/badpixel.png) (https://ibb.co/bLGFBBz)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: domasa on May 12, 2019, 03:16:04 PM
Quotemanually bad pixel function
will be greate!
I use PixelPatcher ( http://www.playtool.com/pages/pixelpatcher/pixelpatcher.html (http://www.playtool.com/pages/pixelpatcher/pixelpatcher.html) )
in Davinci Resolve. But I don't know how fix pixel before stabilization :-(
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on May 12, 2019, 06:30:27 PM
Quote from: Erkett on May 12, 2019, 01:35:10 PM
So please ad an manual bad pixel fixer cuz I only have one hot pixel on high iso on the my 5DIII.
I always wanted to have that feature myself. Pick point(s) in the frame by mouse cursor and save it as custom map to use it right away (with current MLV) or with any other clip recorded with the same camera (should be doable after relative adaptation to raw buffer resolution).

This must be implemented on raw correction level to be useful with DNG export as well. I'm gonna think about it...

Edit: @Danne has implemented something like this for switch some while back. He is using some proggie for pixel selection... don't remember the name.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 12, 2019, 06:45:14 PM
Quote from: bouncyball on May 12, 2019, 06:30:27 PM
I always wanted to have that feature myself. Pick point(s) in the frame by mouse cursor and save it as custom map to use it right away (with current MLV) or with any other clip recorded with the same camera (should be doable with raw buffer resolution relative adaptation).

This must be implemented on raw correction level to be useful with DNG export as well. I'm gonna think about it...

Edit: @Danne has implemented something like this for switch some while back. He is using some proggie for pixel selection... don't remember the name.
+1

Actually used imagej for getting coordinates into a pixel list:
https://imagej.nih.gov/ij/download.html

List is passed on into some directory and the mlv_dump checks the coordinates and apply the pixel fix. Code from raw2dng if I don´t fail to remember). Anyway. Bouncyball made this possible. Would be great with a picker in Mlv app. 
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on May 12, 2019, 06:48:07 PM
Quote from: Danne on May 12, 2019, 06:45:14 PM
Actually used imagej for getting coordinates into a pixel list:
... Code from raw2dng if I don´t fail to remember).
Yeah! That's right :)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 12, 2019, 07:18:42 PM
Quote from: Danne on May 09, 2019, 10:49:37 PM
Don´t be sorry. Interesting bug. Any idea what it might be? How is the vidstab setting applied? I only ran the script with mov files in Switch but always working:
ffmpeg -i input.mov -vf vidstabdetect=shakiness=10:accuracy=10:result=transform_vectors.trf -f null -
ffmpeg -i input.mov -c:a copy -c:v prores_ks -profile:v 2 -pix_fmt yuv422p10 -color_primaries bt709 -color_trc bt709 -colorspace bt709 -vf vidstabtransform=input=transform_vectors.trf:smoothing=10,unsharp=5:5:0.8:3:3:0.4 output.mov


Could you point me to code? Maybe the the trf file is erased too early or something? Only guessing...
@Danne: have you tested this with a ProRes mov or a RGB-avi file? Did that work? I think, even if MLVApp does export a ProRes with vid.stab enabled, there is no staibilizer applied, while exporting h264 it works fine. I remember I had similar issus in analysis pass: it only works with h264, so I implemented the pipe to pipe thing. Maybe here we have the same problem, but pipe to pipe means quality loss (not good).

@Bouncyball: Picker is no problem... functionality is there, we just need another icon -> easy exercise. But we need some buttons for adding/deleting pixels, for loading/saving a pixelmap. We should think about another widget.  :o
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 12, 2019, 07:37:58 PM
Will check a file for vidstab later.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 12, 2019, 07:58:14 PM
Check wav(audio) routines. When enabling Export Audio files comes out. Without it files are blank(checked prore422 and prores444).
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 12, 2019, 08:07:48 PM
Quote from: Danne on May 12, 2019, 07:58:14 PM
Check wav(audio) routines. When enabling Export Audio files comes out. Without it files are blank(checked prore422 and prores444).
Thanks Danne. But exported now without audio... empty file, ffmpeg crashed and pulled MLVApp down. :( Somehow vid.stab doesn't like RAW to ProRes...
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 12, 2019, 08:12:22 PM
Yes, but enable audio and then export. Working? At least your 5D2 file was working.
https://www.magiclantern.fm/forum/index.php?topic=20025.msg216212#msg216212

EDIT: Tested some other file. WIth audio enabled it seems to work but don´t think vidstab is applied.
Also seems to crash on the second file. Well. Problematic.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on May 13, 2019, 02:12:09 PM
Quote from: masc on May 12, 2019, 07:18:42 PM
Picker is no problem... functionality is there, we just need another icon -> easy exercise. But we need some buttons for adding/deleting pixels, for loading/saving a pixelmap. We should think about another widget.  :o
Cool! I'm gonna open the new issue on github then :)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 15, 2019, 08:53:34 PM
For all guys who know how to compile MLVApp:
I had success in adding the chromatic abberation correction from RawTherapee into MLVApp. This means, an older version of it. The older version has a code interface very close to what we need, while the current version is so compilacted, that I had no success in just compiling. What you get are two new sliders to correct red and blue CA's. Moving the red one to around 0.7-1.0 fixed most CA's in my test clips. Especially for all EOS M guys with Viltrox Speedbooster, this is a great addition, because the booster produces so many CA's. Here an example - not perfect, but better than without.
(https://user-images.githubusercontent.com/30245296/57767369-769e2f00-7709-11e9-99a5-4e5aeba606f2.png)
(https://user-images.githubusercontent.com/30245296/57767386-81f15a80-7709-11e9-838b-265761472b73.png)
(https://user-images.githubusercontent.com/30245296/57692804-fcf23c80-7647-11e9-9048-7f04b6d3105c.png)
(https://user-images.githubusercontent.com/30245296/57692811-0085c380-7648-11e9-9830-15b07cbcf8a4.png)
Would be nice if someone else could test this...

Same for our vid.stab problem. Would be nice if someone could test and report what works and what doesn't.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 70MM13 on May 15, 2019, 10:37:32 PM
while you are on the subject of rawtherapee, may i make a suggestion?

the dynamic range compression function is really superb, and it's in the older version (at least, older as in from a year ago? is that old enough?) but there's only one issue:  it doesn't maintain consistency in changing lighting conditions.  I don't know if that is something you can fix, but I guess the first question is will it compile?

just a thought... it is a really great tool for stills and would be incredible if you can make it work for video!
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 16, 2019, 09:14:47 PM
RawTherapee... you never can say for sure if any of those modules are compaible with our software. In general it isn't at all out of the box. The first time I found some CA correction code from RT was in february, now I got the code adapted to be able to compile and use it. I was very happy got this to work, without knowing how it works and what it does. There is no documentation (or I haven't found it).
In the current official MLVApp version DR compression is done behind profile combobox. I don't expect it even to be a little similar.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on May 17, 2019, 04:33:00 AM
Quote from: masc on May 15, 2019, 08:53:34 PM
I had success in adding the chromatic abberation correction from RawTherapee into MLVApp.

Nice! Do you think it would be possible load profiles automatically using lensfun (https://github.com/lensfun/lensfun/tree/master/data/db) (based on metadata)? Also, this lensfun software seems really cool, might be of some help in MLVApp.

Quote from: masc on May 16, 2019, 09:14:47 PM
In the current official MLVApp version DR compression is done behind profile combobox. I don't expect it even to be a little similar.

The "DR Compression" in RT is actually a tonemapping operator. Specifically the Fattal method:
http://www.cs.huji.ac.il/~danix/hdr/hdrc.pdf

It is a bit different than what MLVApp does in profiles. The way I see it is: where the profile is used to "comply" with a standard (e.g, Log-C) in a linear way, the tonemapping tries to compress or lift the illumination dynamically.

I'll see if I can test the vid.stab and the CA next week. Also would like to test the ACES branch :)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 17, 2019, 08:57:28 AM
highlight recovery/reconstruction dont work in 10bits lossless and 12bit lossless atless in 70D. it works only in 14bit lossless

10bit lossless

(https://i.ibb.co/jMkMYVW/10bit-lossless-overexpose.png) (https://ibb.co/jMkMYVW)


12bit lossless

(https://i.ibb.co/jTnynrq/12bit-lossless.png) (https://ibb.co/jTnynrq)


14bit lossless

(https://i.ibb.co/jLpJR3Q/14bit-lossless-overexpose.png) (https://ibb.co/jLpJR3Q)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 17, 2019, 09:00:08 AM
Please upload mlv samples.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 17, 2019, 09:15:30 AM
10bit lossless https://ufile.io/io5nnqba

12bit lossless  https://ufile.io/nsiobnhu

14bit lossless https://ufile.io/i0c31svn
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 17, 2019, 09:20:32 AM
THanks. Heavily overexposed highlights, wouldn´t expect any info left in those areas. Do you mean the problem only occurs on the 70D?
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 17, 2019, 09:30:14 AM
Quote from: Danne on May 17, 2019, 09:20:32 AM
THanks. Heavily overexposed highlights, wouldn´t expect any info left in those areas. Do you mean the problem only occurs on the 70D?

this was made just for testing purpose and show you. i dont get the pink highlight  after pulling all the way down the exposure if its shot in 14bit. problem occurs only in 10bit and 12 bit lossless getting pink highlight
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 17, 2019, 09:39:52 AM
Quote from: Danne on May 17, 2019, 09:20:32 AM
TDo you mean the problem only occurs on the 70D?

its occurs on 70D but not sure about other camera. i always get pink highlight when i pull down the exposer or highlight if the footage is in 10bit or 12bit lossless
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 17, 2019, 09:46:35 AM
Try following
1 - Select Highlight Reconstruction then pull highlights slider all the way down. All is pink.
2 - Go to White Level slider under RAW Correction tab and pull it down until you find white level sweet spot(I set it to 3493). Once there you can pull down exposure etc how much you want.

10bit:
(https://i.postimg.cc/yxtNtFmJ/Screenshot-2019-05-17-at-09-41-58-png-500px.png)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 17, 2019, 10:05:18 AM
yeah it works. i never use to touch the raw white level as it works without touching it in 14bit lossless
thanks danne
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 17, 2019, 10:12:09 AM
It's a bit odd. I have the same problems. Maybe white level should be set according to this clipping point instead in cam. Maybe we loose details in other places if so, not sure what to do :)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 17, 2019, 11:09:07 AM
Quote from: Luther on May 17, 2019, 04:33:00 AM
Do you think it would be possible load profiles automatically using lensfun (https://github.com/lensfun/lensfun/tree/master/data/db) (based on metadata)? Also, this lensfun software seems really cool, might be of some help in MLVApp.
Yes, lensfun is really nice - but very huge. And I did not found out, how to use it. But what I found out: have a look here (http://lensfun.sourceforge.net/lenslist/), you can see that it won't correct CA's for most lenses. And I am not sure if it would when using a Speedbooster on a EOS M (which produces a lot of CA's in another way than the lens would without).

Quote from: Luther on May 17, 2019, 04:33:00 AM
The "DR Compression" in RT is actually a tonemapping operator. Specifically the Fattal method:
http://www.cs.huji.ac.il/~danix/hdr/hdrc.pdf
It is a bit different than what MLVApp does in profiles. The way I see it is: where the profile is used to "comply" with a standard (e.g, Log-C) in a linear way, the tonemapping tries to compress or lift the illumination dynamically.
I'll see if I can test the vid.stab and the CA next week. Also would like to test the ACES branch :)
Fattal is in theory not far away from Reinhard Tonemapping. And this you can choose in Profiles comboxbox. In ACES branch we separated gamuts and tonemapping. But in current master branch it is still mixed.

@andy kh: this is a known issue with all ML cameras. It happens not always, but if it happens you just should lower RAW white level. We also wrote this in the manual https://github.com/ilia3101/MLV-App/wiki#highlight-reconstruction

Quote from: Danne on May 17, 2019, 10:12:09 AM
Maybe white level should be set according to this clipping point instead in cam.
I already tried this, but without success. No idea what happens with less than 14bits in camera. The identified value was mostly way to high and the pink was still there. Looked as if the clipping point was different for each pixel and each frame :P
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 17, 2019, 06:09:22 PM
in mlvproducer it seems to work the same for all the bits
anyway thanks guys atleast we can adjust the raw white balance and recover
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 17, 2019, 07:15:36 PM
That's right, MLVProducer does a perfect job in removing pink highlights. Seems to be a different method. Unfortunately I haven't understood how it is done - nearly no comments in code :(
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 17, 2019, 11:30:33 PM
Quote from: Luther on May 17, 2019, 04:33:00 AM
It is a bit different than what MLVApp does in profiles. The way I see it is: where the profile is used to "comply" with a standard (e.g, Log-C) in a linear way, the tonemapping tries to compress or lift the illumination dynamically.

""Complying" with a standard" isn't the intention of profiles. The original intent of the profiles was to give different looks. Back in the day, MLV APp only had standard and tonemapped, to give different looks. These profiles were never supposed to control anything like output colour spaces/logs or stuff like that. It was always planned to be separate but that's not how it turned out. Anyway, the BetterProcessing branch has separate controls for these things.

Also fattal tonemapping looks really creepy.


@masc Really incredible work with the chromatic aberrations!
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 18, 2019, 03:46:14 PM
Thanks Ilia.

For getting something very close to Fattal Tonemapping, do the following:
- Highlights: -100
- Shadows: 100
- Contrast: -100
- Clarity: 100
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: timbytheriver on May 18, 2019, 06:07:39 PM
Re ACES. Good, clear article here. https://www.lightillusion.com/aces_overview.html

I thought this quote was of note:

"The first point to be made is that compared to other workflows ACES will not improve the final image quality, or enable improved/better colours, or provided any other image related benefit. It is not a 'magic bullet' that somehow guarantees better end results."

I know there's a lot of noise surrounding ACES at present, so this was news to me. :)

Quick version: Have lots of different cameras, and linear VFX stuff to match on one timeline? ACES might help. If not, it probably will be the wrong choice.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 20, 2019, 12:59:37 PM
is it possible to add some presets in the resize export
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 20, 2019, 03:30:17 PM
(https://user-images.githubusercontent.com/30245296/58024672-0893a680-7b13-11e9-98c4-53e5d57b5ef0.png)
Like that?
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 20, 2019, 03:41:28 PM
Quote from: masc on May 20, 2019, 03:30:17 PM
Like that?

yes exactly this feature wil be very usefull
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 20, 2019, 04:06:16 PM
If you are able to compile... it is commited. Please test and report results. It is more complex than it looks like - no idea what else could go wrong :D
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 20, 2019, 04:11:13 PM
sorry i cant compile
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 20, 2019, 04:11:17 PM
Quote from: masc on May 20, 2019, 03:30:17 PM
(https://user-images.githubusercontent.com/30245296/58024672-0893a680-7b13-11e9-98c4-53e5d57b5ef0.png)
Like that?
Good stuff.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on May 23, 2019, 06:27:13 PM
Sorry for the late reply.

Quote from: masc on May 17, 2019, 11:09:07 AM
Yes, lensfun is really nice - but very huge.

I wouldn't call 5MB huge in this day and age where a web browser is three times bigger than an entire operating system.

Quote
But what I found out: have a look here (http://lensfun.sourceforge.net/lenslist/), you can see that it won't correct CA's for most lenses.

Humm. That seem to be true.

Quote
And I am not sure if it would when using a Speedbooster on a EOS M (which produces a lot of CA's in another way than the lens would without).

In case of other lenses/adapters you could profile yourself with adobe lens profile:
http://rawpedia.rawtherapee.com/How_to_get_LCP_and_DCP_profiles

But, I don't think this is compatible with the XML from lensfun.

Quote from: Ilia3101 on May 17, 2019, 11:30:33 PM
""Complying" with a standard" isn't the intention of profiles. The original intent of the profiles was to give different looks. Back in the day, MLV APp only had standard and tonemapped, to give different looks. These profiles were never supposed to control anything like output colour spaces/logs or stuff like that. It was always planned to be separate but that's not how it turned out. Anyway, the BetterProcessing branch has separate controls for these things.

Understood.

Quote
Also fattal tonemapping looks really creepy.

Looking at the research linked, yes. But, it can be used in different intensities. It was adapted to Rawtherapee exactly for that. Read the discussion here, it is very interesting, might even give some insights for new MLVApp features:
https://github.com/Beep6581/RawTherapee/issues/3061
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on May 23, 2019, 06:43:41 PM
Quote from: timbytheriver on May 18, 2019, 06:07:39 PM
"The first point to be made is that compared to other workflows ACES will not improve the final image quality, or enable improved/better colours, or provided any other image related benefit. It is not a 'magic bullet' that somehow guarantees better end results."

This is not true. He is probably comparing ACES with ALEXA Wide Gamut. From that perspective, indeed, ACES would not offer much advantage, as with comparing with ProPhoto.
Now when comparing with sRGB/Rec.709, and that is the case of MLVApp, ACES do offer big advantages in many aspects. For example, when I tried to record a show with many colored light, MLVApp gives out of gamut and muddy colors, while on Rawtherapee (using an extracted DNG and configured to use ACES) it is smooth. Also, if you try some drastic color changes MLVApp can give color artifacts, where with ACES this would probably happen less often.
Adapting ACES to MLVApp would also enable to export in Rec.2020 and that's the industry standard now.
Some examples here:
https://webkit.org/blog-files/color-gamut/

Couldn't test the wide gamut branch yet, but when I do I'll post some examples here.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 23, 2019, 07:14:06 PM
Quote from: Luther on May 23, 2019, 06:27:13 PM
I wouldn't call 5MB huge in this day and age where a web browser is three times bigger than an entire operating system.
The MB don't care at all. Lines of code, dependencies and coding interface cares... and this is more than huge from what I saw. (At least I didn't got how to handle it.)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on May 23, 2019, 08:12:23 PM
Quote from: masc on May 23, 2019, 07:14:06 PM
The MB don't care at all. Lines of code, dependencies and coding interface cares... and this is more than huge from what I saw. (At least I didn't got how to handle it.)

Well, it's meant to be an all-in-one solution, I think. The only dependency would be Glib (only on windows?).
I don't think there is a simpler open implementation. I've found the OpenFX LensDistortion (https://github.com/NatronGitHub/openfx-misc/tree/master/Distortion), works on Natron but, even though I'm not a programmer, I can notice it is more complex than lensfun.
Maybe leave this feature to another time.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 23, 2019, 08:38:02 PM
Hm... maybe it is easier to insert a openfx interface - then one could load such plugins. But I have no idea how openfx works ;)
The good thing on CA_correct_RT (from RawTherapee) is, it is just one single C function with some easy parameters (after my modification) and no dependencies at all. 8)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on May 24, 2019, 07:37:48 PM
Quote from: masc on May 23, 2019, 08:38:02 PM
But I have no idea how openfx works ;)

Seems to be really complex. Don't know why, but might be because it was designed for compositing and VFX, not for simple filters. The good thing is that it seems to be a standard now. Nuke and Resolve (http://openeffects.org/) are associated.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on May 24, 2019, 07:38:13 PM
Finally, got to test the BetterProcessing branch.
Testing with 14-bit 50D MLV's, on a 99% Rec.709 monitor.
Some notes I did while testing:

- No processing gamut is working, except for Rec.709 and XYZ.
- XYZ to Rec.709 seems to be working nicely. Still, not precise, but might be the camera matrix(?).
- Comparing with Rec.709 > Rec.709, the XYZ > Rec.709 shifts towards red and slightly cyan on shadows. Because of the shift, reds get easily clipped (skin tones, mostly). Intense reds are a bit brighter than it should. Reds also gets hue shifted a bit towards magenta.
- Is already better than the original processing. Less color artifacts when doing heavy processing. More color separation (in especial the 'sub-tones' of red, differentiation between red, oranges and magenta).
- Other functionalities seem to be affected (using XYZ > Rec.709): curve in the Red channel is very sensitive and HSL is not precise.

Using Rec.2020 output:
- XYZ to Rec.2020 doesn't seem right. Can't say for sure, though, as I don't have a Rec.2020 monitor
- AdobeRGB to Rec.2020 seems alright (even though this wouldn't make much sense, as Rec.2020 is bigger than AdobeRGB).

Old bug, but I think Ilia already knows:
- While using camera matrix, bellow 3600K give odd colors. It seems the blue channel gets pulled and the reds gets fucked up

I'll post some samples some other time. I don't have a colorchecker, but a Pantone palette might work as a unscientific experiment.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andrew_dotdot on May 24, 2019, 08:50:21 PM
I was daydreaming about my favourite ML raw processing app one afternoon and it struck me that it would be pretty useful if MLV App could burn in time code and the source file name for making small files for offline editing. I started using a program "EditReady" to convert my h.265 files (that program reminds me a lot of MLV App) and began to really like burning in that data. Has this ever been considered for ML App?

(https://i.imgur.com/0BNoWuT.png)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on May 25, 2019, 02:09:35 AM
@masc Are you able to compile master? I think this commit broke it:
https://github.com/ilia3101/MLV-App/commit/88e803d1033640953edd284de4bccdae88645c63

frame_caching.o: In function `get_mlv_raw_frame_debayered'
undefined reference to `wb_convert'
undefined reference to `CA_correct_RT'
undefined reference to `wb_undo
error: ld returned 1 exit status
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Rewind on May 25, 2019, 11:19:37 AM
In order to avoid double posting, may I ask the developer to take a look at this post (https://www.magiclantern.fm/forum/index.php?topic=16054.msg216988#msg216988)?

Basically, I have a couple of suggestions regarding the treatment of focus pixels. The idea is to make resulting video more usable by affecting only areas where those focus pixels are, and not the whole frame area, and to introduce an optional alternative interpolation algorithm, which works better in most situations.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 26, 2019, 03:35:27 PM
Quote from: Luther on May 23, 2019, 06:43:41 PM
This is not true. He is probably comparing ACES with ALEXA Wide Gamut. From that perspective, indeed, ACES would not offer much advantage, as with comparing with ProPhoto.
Now when comparing with sRGB/Rec.709, and that is the case of MLVApp, ACES do offer big advantages in many aspects.
...
Adapting ACES to MLVApp would also enable to export in Rec.2020 and that's the industry standard now.

All of the colour gamuts you mention are available in BetterProcessing.

Quote from: Luther on May 23, 2019, 06:43:41 PM
For example, when I tried to record a show with many colored light, MLVApp gives out of gamut and muddy colors, while on Rawtherapee (using an extracted DNG and configured to use ACES) it is smooth.

If it is possible could you give me a sample (s)? As I need to have good samples to see how it looks when I'm fixing the BetterProcessing branch. I don't have many good examples myself (and no working camera to create them right now). I know BetterProcessing colours are quite fucked right now. It needs improvement, I would never release in the current state.

Also...

I still have some questions about colour things (if andy600 is still around or any other experts)...

The camera matrices, do they give output with absolute colour, D65 is equal to D65? or is it something like D65 is at D50, I seem to remember andy600 mentioning that and it has been a thought in the back of my mind ever since. (I am so confused about this!!!!!!!!!!!)

Another thing.... Let's say processing will use multiple gamuts for different stages (it will, three to be exact) - some of these gamuts may have a D50 white point, some D65, and some approximately D60. When converting between these gamuts inside of processing, should the white point be adapted (relative transform) or should it use an absolute transform? I am thinking relative would be better, as it avoids white shift in some adjustments like saturation.

And: Does anyone have links to info of how perceptual gamut transforms work? (implementation, not just an explanation of how it looks)



Also thanks to everyone posting helpful things on here.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 26, 2019, 04:07:38 PM
in mlvApp when i resize lets say i shoot in 1920 by 818 which is 2.35:1 and export in dnxHD format in 1080p the the height is stretch which is not the same case with resolve or premiere pro
so upcaling or resizing not possible in mlvapp
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on May 26, 2019, 08:33:34 PM
Quote from: Ilia3101 on May 26, 2019, 03:35:27 PM
If it is possible could you give me a sample (s)?

Here you go:

(https://pictshare.net/6f6nip.jpg) (https://pictshare.net/6f6nip.jpg)

Download the MLV (90MB) here:
https://drive.google.com/open?id=1zksn3AZAZc8d0bX8V8cxHcMIlj5Y9ln4

Download PNG's with all gamut test from BetterProcessing:
https://drive.google.com/open?id=1B9Pfij9pjymNsXWCDFhhCQxbiqCB_Atd


As I said, this is not very scientific. The MLV was recorded using 50D, with WB at 5500K in direct sun light. I'm using a old Nikkor lens, so it should be a bit warmer because of the lens coat. Also, the pantone palette is quite old and the paper started to get a bit yellow. Anyway, should be enough to do some tests. I can assure you the rawtherapee is very accurate to what I see in real life.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 26, 2019, 09:08:39 PM
Quote from: Luther on May 25, 2019, 02:09:35 AM
@masc Are you able to compile master? I think this commit broke it:
https://github.com/ilia3101/MLV-App/commit/88e803d1033640953edd284de4bccdae88645c63

frame_caching.o: In function `get_mlv_raw_frame_debayered'
undefined reference to `wb_convert'
undefined reference to `CA_correct_RT'
undefined reference to `wb_undo
error: ld returned 1 exit status
Yes, I can compile here on OSX. What OS do you use? (If it is not OSX I am sorry... I am in holiday and no Win/Linux in the near.)

Quote from: andy kh on May 26, 2019, 04:07:38 PM
in mlvApp when i resize lets say i shoot in 1920 by 818 which is 2.35:1 and export in dnxHD format in 1080p the the height is stretch which is not the same case with resolve or premiere pro
so upcaling or resizing not possible in mlvapp
dnxhd is extremely limited in options. If I remember right 2.35:1 was not possible at all. Maybe better use another codec.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 26, 2019, 09:18:04 PM
Quote from: masc on May 26, 2019, 09:08:39 PM
dnxhd is extremely limited in options. If I remember right 2.35:1 was not possible at all. Maybe better use another codec.

resizing to full hd or 2.5k or 4k is not possible in any codec if i shoot in 2.35:1 as the height of the video get stretch. i have been using the resizing option in premiere pro and resolve for many years but no problem
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 26, 2019, 09:24:13 PM
Quote from: andy kh on May 26, 2019, 09:18:04 PM
resizing to full hd or 2.5k or 4k is not possible in any codec if i shoot in 2.35:1 as the height of the video get stretch. i have been using the resizing option in premiere pro and resolve for many years but no problem

Please provide the resize settings you set in premiere and exact codec used. Describe how this differs from Mlv App. As masc says dnxhd is very picky with resizing but I sense you are mixing info here.
As always. A small sample mlv file will never hurt anyone.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 26, 2019, 09:38:35 PM
https://ibb.co/wwvs6Z4

here is the setting in premiere pro
its 1920 by 1080. it works in any codec both in premiere pro and resolve
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 26, 2019, 10:27:01 PM
So footage is 1920x818 and you export to 1920x1080 with a black border? That´s it? Try match sequence setting. Pretty sure it won´t export dnxhd.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 26, 2019, 11:46:52 PM
don't use dnxhd (unless you really need it)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 27, 2019, 02:40:25 AM
Quote from: Danne on May 26, 2019, 10:27:01 PM
So footage is 1920x818 and you export to 1920x1080 with a black border?

i get black border because i think premiere pro is intelligent. it knows the aspect ratio of my video and  maintain the height with balck border without strecthing my video height regardless of the codec or height i set
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 27, 2019, 02:56:42 AM
Quote from: Danne on May 26, 2019, 10:27:01 PM
Try match sequence setting. Pretty sure it won´t export dnxhd.

dnxhd comes with presets. there is no option to change to match sequence settings. what im poiting out here is that i can export using any presets wihout stretching the height in resolve/premiere pro
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 27, 2019, 07:03:21 AM
Quote from: andy kh on May 27, 2019, 02:40:25 AM
i get black border because i think premiere pro is intelligent. it knows the aspect ratio of my video and  maintain the height with balck border without strecthing my video height regardless of the codec or height i set
FFmpeg is very versatile. It can do almost whatever with your footage. And pad output is considered basic. But it might be a cool thing to add in Mlv App. Here are two links:
https://ffmpeg.org/ffmpeg-filters.html#pad

https://superuser.com/questions/991371/ffmpeg-scale-and-pad
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: reddeercity on May 28, 2019, 07:23:47 AM
@masc , I had a problem with 50D clipping hi-lights & turning them pink , I was testing UHD(3744x1080)
I shorten one of the mlv to 50 frames (240MB) on my Google drive if you would like to have a look at it 
https://drive.google.com/file/d/1ioIJamgPBxKIxg88Gl97Zm3ZfOlwE0qf/view?usp=sharing
I had no problem with Adobe A.E. to bring back the hi-lights , here the post of the video from A.E.
https://www.magiclantern.fm/forum/index.php?topic=19336.msg217051#msg217051
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 28, 2019, 07:34:04 AM
Known issue for cameras other than  for 5d mark III. Decrease the white level in raw correction
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: reddeercity on May 28, 2019, 07:41:07 AM
Quote from: andy kh on May 28, 2019, 07:34:04 AM
Known issue for cameras other than  for 5d mark III. Decrease the white level in raw correction
Ok , Just tried that and no , it clips even more .
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on May 28, 2019, 08:07:23 AM
In this case it´s enought to pull down exposure and go from there. Reminder. Mlv App is not acr for good and worse:
(https://i.postimg.cc/ZKXJTgdd/Screenshot-2019-05-28-at-08-04-01-png-scaled.png)

Interesting, it´s not possible to increase white level in this mlv? Meant to be?


EDIT:
some fast color correction:
(https://i.postimg.cc/zG1XC6G1/Screenshot-2019-05-28-at-08-13-44-png-scaled.png)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 28, 2019, 09:50:17 AM
Quote from: andy kh on May 28, 2019, 07:34:04 AM
Known issue for cameras other than  for 5d mark III.
Huuu?! This has nothing to do with 5D3. Can and will happen with any camera, also with 5D3.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 28, 2019, 10:27:59 AM
Quote from: masc on May 28, 2019, 09:50:17 AM
Huuu?! This has nothing to do with 5D3. Can and will happen with any camera, also with 5D3.

my bad. bad in explaining. i mean to say there is no need to adjust the raw white level  for the 5D mark III. i can confirm this as i own a 5D now. i can now shoot in any bit and need not touch the raw white level like i had to do for 70D if i shoot in 10/12 bits
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 28, 2019, 02:31:58 PM
Reddeercity has pointed out a real issue, highlight reconstruction does not help where these flowers are clipped, luckily the flower is pink anyway so the pink clipped parts blend in. Took some time for me to notice this. Highlight reconstruction only works well for neutral colours, I have tried to fix this before and failed. I think I know how it's just difficult to make it work.

Tried to match(/exceed) ACR:

(https://i.ibb.co/1vmMtDt/50-D-3744x1080-50-frames-M26-2103-frame-1-2.png)


@Luther thank you!
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on May 28, 2019, 03:46:50 PM
Interesting is that when you switch to something else than "use camera matrix" then pink /cyan highlights disappear(turns ok and pink is turned into proper bright/ white tone).
When you use standard instead of tonemapped or film - pink/cyan frame turns ok.
So it is possible to do and MLVApp already does this properly but not in tonemapped and not when using camera matrix, maybe merging two methods( camera matrix and uncolorscience) would give proper results for highlights while preserving amazing colours of camera matrix method.
Last image with white/pink lines is the border where pink turns cyan, you cant get white but sometimes cyan line next to pink colour will cancel each other which looks like white, when you go with slider down even more then eventually cyan takes over , when you go up then magenta/pink takes over that area.
(http://picplus.ru/img/1905/28/5d36aadd.jpg)
So why dont I use something else than "use camera matrix" you ask ? Because i love the colours on it that look like CMYK film.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 28, 2019, 03:56:53 PM
Nah it's all the same method. (Unfortunately :()

Using camera matrix creates more accurate colours, but it also happens to saturate many colours including pink, so the pink highlights are more noticeable.

Standard curve clips off many stops of dynamic range, so it may cut out the pink highlights, but they are still there, just not visible as they may be clipped to white. I don't like the clipped look from standard so I rarely use it.


The horrible saturated colourful highlights you demonstrate will be gone in the BetterProcessing branch once it's completed.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on May 28, 2019, 04:05:18 PM
So maybe something like another correction for pure white would be useful , cause pink/cyan should be white, they fight over this area.
Also standard is as saturated as film/tonemapped and looks quite similar but its pink/magenta treatment is much better than tonemapped/film.
I use highlights slider turned all th way down with standard and it preserves all highlights even better than tonemapped/film( makes them bit darker) but i dig the contrast(highlights rolloff) in tonemapped/film more than standard.
Tonemapped vs standard and highlights restored on both
(http://picplus.ru/img/1905/28/a4bd4d32.jpg)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 28, 2019, 04:12:15 PM
"a correction for pure white", I could do that: a separate white balance setting for highlight reconstruction. This would fix any pink/cyan highlights, but it's another slider to adjust each time. So I want to make this automated.

But if anyone reallly wants it it could be a temporary solution.


Also you comparison shows standard looking better than tonemapped, which is interesting, but see how they compare when you pull the exposure down a few stops.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on May 28, 2019, 04:20:42 PM
I posted another one while you answered, tonemapped vs standard.Standard has diffrent highlihts rollof and contrast than tonemapped, but i prefere tonnemapped/film (both are very similar) at this moment, its a matter of taste maybe.Just looks more like film.
Without highlights slider moving down standard does have highlights more blownoff than tonemapped like you described but testing them with highlights brought back produce similar results, darker/more contrasty on standard.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 28, 2019, 04:25:02 PM
Thanks. Well it is interesting that standard preserves highlights better. Not sure why, nothing about it means it should. Probably something to do with perception.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on May 28, 2019, 04:34:38 PM
I agree its perceptional, Id say technically its similar but contrast in standard makes the highlights darker a bit.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on May 28, 2019, 04:45:27 PM
de
Quote from: Ilia3101 on May 28, 2019, 04:12:15 PM
"a correction for pure white", I could do that: a separate white balance setting for highlight reconstruction. This would fix any pink/cyan highlights, but it's another slider to adjust each time. So I want to make this automated.

But if anyone reallly wants it it could be a temporary solution.

Definitely WANT  :D It would save a lot of shots, or somethng to switch on which would force #FF00FF or #00FFFF to pure white or slightly gray , or change saturation to 0 from these two particular colour tones.
Fixing bad pixel has detection for red pixel so maybe fixig cyan/magenta could have similar, theres no magenta or cyan that saturated in real life.
It is dirty solution but so is "highlight reconstruction" , which IMO should be always on.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on May 28, 2019, 10:16:38 PM
Quote from: masc on May 26, 2019, 09:08:39 PM
Yes, I can compile here on OSX. What OS do you use? (If it is not OSX I am sorry... I am in holiday and no Win/Linux in the near.)

On Windows 10. QT 5.9.1. QTCreator 4.7.0. Using MinGW to compile.
Errors:


C:\MLV-App\src\debayer\wb_conversion.h:14: error: unknown type name 'uint16_t'
void wb_undo( uint16_t *debayeredFrame, int width, int height, int blacklevel );
               ^



In file included from ..\..\src\processing\rbfilter\rbf_wrapper.cpp:8:0:
..\..\src\processing\rbfilter\rbf.h: In function 'void _recursive_bf(uint16_t*, float, float, int, int, int, float*)':
..\..\src\processing\rbfilter\rbf.h:148:18: warning: value computed is not used [-Wunused-value]
         *--temp_x; *temp_x = 0.5f*((*temp_x) + (*--in_x));
                  ^
..\..\src\processing\rbfilter\rbf.h:149:18: warning: value computed is not used [-Wunused-value]
         *--temp_x; *temp_x = 0.5f*((*temp_x) + (*--in_x));
                  ^
..\..\src\processing\rbfilter\rbf.h:150:18: warning: value computed is not used [-Wunused-value]
         *--temp_x; *temp_x = 0.5f*((*temp_x) + (*--in_x));
                  ^
..\..\src\processing\rbfilter\rbf.h:156:25: warning: value computed is not used [-Wunused-value]
         *--temp_factor_x; *temp_factor_x = 0.5f*((*temp_factor_x) + 1);
                         ^
..\..\src\processing\rbfilter\rbf.h:175:22: warning: value computed is not used [-Wunused-value]
             *--temp_x; *temp_x = 0.5f*((*temp_x) + ycr);
                      ^
..\..\src\processing\rbfilter\rbf.h:176:22: warning: value computed is not used [-Wunused-value]
             *--temp_x; *temp_x = 0.5f*((*temp_x) + ycg);
                      ^
..\..\src\processing\rbfilter\rbf.h:177:22: warning: value computed is not used [-Wunused-value]
             *--temp_x; *temp_x = 0.5f*((*temp_x) + ycb);
                      ^
..\..\src\processing\rbfilter\rbf.h:182:29: warning: value computed is not used [-Wunused-value]
             *--temp_factor_x;
                             ^
..\..\src\processing\rbfilter\rbf.h:271:24: warning: value computed is not used [-Wunused-value]
                 *out_++;
                        ^
..\..\src\processing\rbfilter\rbf.h:273:23: warning: value computed is not used [-Wunused-value]
             *factor_++;
                       ^




In file included from ..\..\src\debayer\wb_conversion.c:8:0:
..\..\src\debayer\wb_conversion.h:14:15: error: unknown type name 'uint16_t'
void wb_undo( uint16_t *debayeredFrame, int width, int height, int blacklevel );
               ^
..\..\src\debayer\wb_conversion.c: In function 'wb_convert':
..\..\src\debayer\wb_conversion.c:27:60: warning: unused parameter 'blacklevel' [-Wunused-parameter]
void wb_convert(float *rawData, int width, int height, int blacklevel)
                                                            ^
..\..\src\debayer\wb_conversion.c: In function 'wb_undo':
..\..\src\debayer\wb_conversion.c:58:67: warning: unused parameter 'blacklevel' [-Wunused-parameter]
void wb_undo(uint16_t *debayeredFrame, int width, int height, int blacklevel)
                                                                   ^
Makefile.Debug:8960: recipe for target 'debug/wb_conversion.o' failed
mingw32-make[1]: *** [debug/wb_conversion.o] Error 1
mingw32-make[1]: *** Waiting for unfinished jobs....
..\..\src\processing\rbfilter\RBFilterPlain.cpp: In member function 'void CRBFilterPlain::filter(uint16_t*, uint16_t*, float, float, int, int, int)':
..\..\src\processing\rbfilter\RBFilterPlain.cpp:266:29: warning: unused variable 'src_prev' [-Wunused-variable]
             const uint16_t* src_prev = src_color;
                             ^
mingw32-make[1]: Leaving directory 'C:/Users/Pichau/mlvapp/MLV-App/platform/build-MLVApp-Desktop_Qt_5_9_1_MinGW_32bit-Debug'
Makefile:36: recipe for target 'debug' failed
mingw32-make: *** [debug] Error 2
20:13:44: The process "C:\Qt\Tools\mingw530_32\bin\mingw32-make.exe" exited with code 2.
Error while building/deploying project MLVApp (kit: Desktop Qt 5.9.1 MinGW 32bit)
When executing step "Make"
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on May 28, 2019, 10:27:10 PM
Quote from: Ilia3101 on May 26, 2019, 03:35:27 PM
The camera matrices, do they give output with absolute colour, D65 is equal to D65? or is it something like D65 is at D50, I seem to remember andy600 mentioning that and it has been a thought in the back of my mind ever since. (I am so confused about this!!!!!!!!!!!)

Another thing.... Let's say processing will use multiple gamuts for different stages (it will, three to be exact) - some of these gamuts may have a D50 white point, some D65, and some approximately D60. When converting between these gamuts inside of processing, should the white point be adapted (relative transform) or should it use an absolute transform? I am thinking relative would be better, as it avoids white shift in some adjustments like saturation.

And: Does anyone have links to info of how perceptual gamut transforms work? (implementation, not just an explanation of how it looks)

I have no idea about those questions Ilia. In my mind I always thought that color conversion is something complicated and often not precise, so the simplest solution should always be the best one.
I noticed you seem to be using XYZ and then converting to other space, right? For example, I see you got the ACES matrix from here (https://github.com/ampas/aces-dev/blob/master/transforms/ctl/README-MATRIX.md) (XYZ-to-AP0). Wouldn't be better to just use right away the intended color space?
Might be a good idea to request help on ACES Central (https://acescentral.com/). They might have the answers about your white point questions.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 28, 2019, 10:43:28 PM
Quote from: Luther on May 28, 2019, 10:16:38 PM
On Windows 10. QT 5.9.1. QTCreator 4.7.0. Using MinGW to compile.
Errors:
...
Sounds like the compiler on windows is too stupid to use the given includes. #include "stdlib.h" or #include "stdint.h"  is missing in the file. No exact idea here and can't try.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on May 28, 2019, 11:03:33 PM
Quote from: masc on May 28, 2019, 10:43:28 PM
Sounds like the compiler on windows is too stupid to use the given includes. #include "stdlib.h" or #include "stdint.h"  is missing in the file. No exact idea here and can't try.

Yep, that's it. Including stdint.h to wb_conversion.h makes it work.
Patch:


*** wb_conversion.h.orig Tue May 28 21:02:42 2019
--- wb_conversion.h Tue May 28 20:58:55 2019
***************
*** 10,15 ****
--- 10,17 ----
 
 
  #include "stdlib.h"
+ #include "stdint.h"
+
 
  void wb_convert(float *rawData, int width, int height, int blacklevel );
  void wb_undo( uint16_t *debayeredFrame, int width, int height, int blacklevel );


Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 28, 2019, 11:11:41 PM
Whyever this is needed. Through the include chain this should be included more than once already - and unix hasn't this problem. But commited it now, so hopefully this makes no more problems for everybody on windows. Thank you for trying out.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: reddeercity on May 29, 2019, 04:58:05 AM
Here the dng from A.E. with correction M26-2103_000000.dng (https://bitbucket.org/reddeercity/magic-lantern_10-12bit/downloads/M26-2103_000000.dng) , below is the ExifTool info with tonemap from adobe , maybe useful to help figure out the issue .
ExifTool Version Number         : 10.45
File Name                       : M26-2103_000000.dng
File Size                       : 4.8 MB
File Type                       : DNG
File Type Extension             : dng
Image Width                     : 3744
Image Height                    : 1080
Bits Per Sample                 : 10
XMP Toolkit                     : Adobe XMP Core 5.3-c007 1.136881, 2010/06/10-1
8:11:35
Creator Tool                    : MLV App
Lens                            : EF24-70mm f/2.8L USM
Approximate Focus Distance      : 54
Document ID                     : 580971C0A7FFD28D0CF11913E78136B1
Original Document ID            : 580971C0A7FFD28D0CF11913E78136B1
Instance ID                     : xmp.iid:103FF4F6DC80E9118557F6C2F85389A2
Format                          : image/dng
Raw File Name                   : M26-2103_000000.dng
Version                         : 7.0
Process Version                 : 6.7
White Balance                   : Custom
Color Temperature               : 4950
Tint                            : 0
Exposure                        : 0.00
Shadows                         : 5
Brightness                      : +50
Contrast                        : +25
Saturation                      : +5
Sharpness                       : 51
Luminance Smoothing             : 24
Color Noise Reduction           : 37
Vignette Amount                 : 0
Shadow Tint                     : -16
Red Hue                         : -14
Red Saturation                  : +18
Green Hue                       : +2
Green Saturation                : -12
Blue Hue                        : +3
Blue Saturation                 : -3
Fill Light                      : 0
Vibrance                        : -8
Highlight Recovery              : 0
Clarity                         : 0
Defringe                        : 1
Hue Adjustment Red              : -8
Hue Adjustment Orange           : 0
Hue Adjustment Yellow           : +29
Hue Adjustment Green            : +7
Hue Adjustment Aqua             : +8
Hue Adjustment Blue             : +1
Hue Adjustment Purple           : +32
Hue Adjustment Magenta          : +3
Saturation Adjustment Red       : -5
Saturation Adjustment Orange    : 0
Saturation Adjustment Yellow    : +26
Saturation Adjustment Green     : +3
Saturation Adjustment Aqua      : 0
Saturation Adjustment Blue      : +19
Saturation Adjustment Purple    : +48
Saturation Adjustment Magenta   : +28
Luminance Adjustment Red        : -45
Luminance Adjustment Orange     : +7
Luminance Adjustment Yellow     : +16
Luminance Adjustment Green      : -7
Luminance Adjustment Aqua       : +8
Luminance Adjustment Blue       : +12
Luminance Adjustment Purple     : 0
Luminance Adjustment Magenta    : +33
Split Toning Shadow Hue         : 44
Split Toning Shadow Saturation  : 5
Split Toning Highlight Hue      : 27
Split Toning Highlight Saturation: 10
Split Toning Balance            : 0
Parametric Shadows              : -16
Parametric Darks                : -16
Parametric Lights               : -18
Parametric Highlights           : +34
Parametric Shadow Split         : 10
Parametric Midtone Split        : 39
Parametric Highlight Split      : 70
Sharpen Radius                  : +1.0
Sharpen Detail                  : 25
Sharpen Edge Masking            : 0
Post Crop Vignette Amount       : 0
Grain Amount                    : 0
Luminance Noise Reduction Detail: 33
Color Noise Reduction Detail    : 43
Luminance Noise Reduction Contrast: 35
Lens Profile Enable             : 1
Lens Manual Distortion Amount   : 0
Perspective Vertical            : 0
Perspective Horizontal          : 0
Perspective Rotate              : 0.0
Perspective Scale               : 100
Auto Lateral CA                 : 1
Exposure 2012                   : -1.15
Contrast 2012                   : -20
Highlights 2012                 : 0
Shadows 2012                    : 0
Whites 2012                     : 0
Blacks 2012                     : 0
Clarity 2012                    : +20
Convert To Grayscale            : False
Tone Curve Name                 : Medium Contrast
Tone Curve Name 2012            : Linear
Camera Profile                  : Adobe Standard
Camera Profile Digest           : 4E39CA4544970CFCDA0480DEF985A334
Lens Profile Setup              : LensDefaults
Lens Profile Name               : Adobe (Canon EF 24-70mm f/2.8 L USM)
Lens Profile Filename           : Canon EOS-1Ds Mark III (Canon EF 24-70mm f2.8
L USM) - RAW.lcp
Lens Profile Digest             : 6DC973F8007CD1B1219A7C2170B93681
Lens Profile Distortion Scale   : 100
Lens Profile Chromatic Aberration Scale: 100
Lens Profile Vignetting Scale   : 100
Has Settings                    : True
Has Crop                        : False
Already Applied                 : False
History Action                  : saved
History Instance ID             : xmp.iid:103FF4F6DC80E9118557F6C2F85389A2
History When                    : 2019:05:27 18:10:13-06:00
History Software Agent          : Adobe Photoshop Camera Raw 7.0 (Windows)
History Changed                 : /metadata
Tone Curve                      : 0, 0, 32, 22, 64, 56, 128, 128, 192, 196, 255,
255
Tone Curve Red                  : 0, 0, 255, 255
Tone Curve Green                : 0, 0, 255, 255
Tone Curve Blue                 : 0, 0, 255, 255
Tone Curve PV2012               : 0, 0, 255, 255
Tone Curve PV2012 Red           : 0, 0, 255, 255
Tone Curve PV2012 Green         : 0, 0, 255, 255
Tone Curve PV2012 Blue          : 0, 0, 255, 255
CFA Repeat Pattern Dim          : 2 2
CFA Pattern 2                   : 0 1 1 2
Exposure Time                   : 1/48
F Number                        : 8.0
ISO                             : 800
Sensitivity Type                : ISO Speed
Exif Version                    : 0230
Shutter Speed Value             : 1/45
Aperture Value                  : 8.0
Subject Distance                : 54 m
Focal Length                    : 24.0 mm
Focal Plane X Resolution        : 5315.436242
Focal Plane Y Resolution        : 5315.436242
Focal Plane Resolution Unit     : inches
Lens Model                      : EF24-70mm f/2.8L USM
DNG Version                     : 1.4.0.0
Unique Camera Model             : Canon EOS 50D
Black Level                     : 112
White Level                     : 1013
Default Scale                   : 1 1
Default Crop Origin             : 0 0
Default Crop Size               : 3744 1080
Color Matrix 1                  : 0.5852 -0.0578 -0.0041 -0.4691 1.1696 0.3427 -
0.0886 0.2323 0.6879
Color Matrix 2                  : 0.492 0.0616 -0.0593 -0.6493 1.3964 0.2784 -0.
1774 0.3178 0.7005
As Shot Neutral                 : 0.4767212258 1 0.7424952295
Baseline Exposure               : 0
Camera Serial Number            : 190DA874
Calibration Illuminant 1        : Standard Light A
Calibration Illuminant 2        : D65
Active Area                     : 0 0 1080 3744
Forward Matrix 1                : 0.8716 -0.0692 0.1618 0.3408 0.8077 -0.1486 -0
.0013 -0.6583 1.4847
Forward Matrix 2                : 0.9485 -0.115 0.1308 0.4313 0.7807 -0.212 0.02
93 -0.2826 1.0785
Time Codes                      : 00:00:00.00
Frame Rate                      : 23.976
Reel Name                       : I:/50D_Reg's_in_3xcrop/5-26-2019/M26-2103
Baseline Exposure Offset        : 0
Aperture                        : 8.0
CFA Pattern                     : [Red,Green][Green,Blue]
Image Size                      : 3744x1080
Megapixels                      : 4.0
Shutter Speed                   : 1/48
Focal Length                    : 24.0 mm
Light Value                     : 8.6
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: andy kh on May 29, 2019, 05:42:51 PM
 it is very importand to see the waveform/rgb parade etc while color grading.i find the waveform window very small. is it possible to increase the size of it or give and option for floating or something like that
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 30, 2019, 02:04:50 PM
@Luther i just noticed this post. I always miss things.

Quote from: Luther on May 28, 2019, 10:27:10 PM
I have no idea about those questions Ilia. In my mind I always thought that color conversion is something complicated and often not precise, so the simplest solution should always be the best one.

Colour conversion in RGB is precise from one space to another (just a matrix transform). But converting from camera sensor data to any actual colour space is not precise for sure.

Quote from: Luther on May 28, 2019, 10:27:10 PM
I noticed you seem to be using XYZ and then converting to other space, right? For example, I see you got the ACES matrix from here (https://github.com/ampas/aces-dev/blob/master/transforms/ctl/README-MATRIX.md) (XYZ-to-AP0). Wouldn't be better to just use right away the intended color space?

Well the actual image doesn't go in to XYZ space (unless you choose it as gamut for processing), XYZ is just used as a middle point in calculations for generating the matrices. It is normal to do that I think, as most colour spaces' matrices are defined from/to XYZ. Could use any space as a reference point for calculations, but it would need different matrices.

And thanks for the link, I don't remember where I got the matrix 😂

Quote from: Luther on May 28, 2019, 10:27:10 PM
Might be a good idea to request help on ACES Central (https://acescentral.com/). They might have the answers about your white point questions.

Ah yes good idea



@andy kh I agree it would be nice if the waveform expanded with the sidebar, but I think masc didn't like it getting pixelated (I think I remember this from some discussion in 2017 :) ).
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 30, 2019, 08:01:50 PM
Quote from: andy kh on May 29, 2019, 05:42:51 PM
it is very importand to see the waveform/rgb parade etc while color grading.i find the waveform window very small. is it possible to increase the size of it or give and option for floating or something like that
Quote from: Ilia3101 on May 30, 2019, 02:04:50 PM
@andy kh I agree it would be nice if the waveform expanded with the sidebar, but I think masc didn't like it getting pixelated (I think I remember this from some discussion in 2017 :) ).
Correct, Ilia. In general: no problem to make waveform / rgb parade larger... if +5sec per image is fast enough... until now I did not like this at all, because nobody could work with this - that is why this does not exist ;) Or we could just stretch it - but then you could count pixels and won't have more information.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 30, 2019, 08:40:18 PM
I just want it to scale the histogram/waveform image, I don't mind if it goes a little blurry or pipxelated. No need to render it at higher resolution if it's slower. (my opinion)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on May 30, 2019, 09:21:39 PM
Quote from: Ilia3101 on May 30, 2019, 08:40:18 PM
... I don't mind if it goes a little blurry or pipxelated. ...
It will get very blurry and ugly.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 30, 2019, 09:48:54 PM
On a hidpi linux 13 inch it looks like this:

(https://i.ibb.co/2vNYYWj/deafultmlvapp.png)

I can barely see it. I have 1.5x font scaling + sidebar stretched.

Mockup with nearest interpolation:

(https://i.ibb.co/wSTGJqf/Scaledmlvapp.png)

Ugly but I prefer it even that way.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on May 30, 2019, 11:48:53 PM
The pixelated version is more usable
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 14, 2019, 09:47:43 AM
This week I found a bug related to focus pixel fix feature and got it fixed now.
-> if "Create Mapp Files" was enabled or/and a Mapp file was already created, "fix focus pixels" did not work always.
-> Workaround: disable "Create Mapp Files" and delete Mapp files, load MLV again
-> If you are able to compile MLVApp, using Mapp files + fix focus pixels works now. Or just wait for next offical release.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on June 14, 2019, 10:25:32 AM
Nice!
Question. Aborting export stops processing and erases ongoing file. I would prefer if the file was stopped and then kept for previewing purposes.
I sidestep working is to force quit Mlv App instead of aborting which seems to send a kill ffmpeg signal and the file will be stopped but viewable.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 14, 2019, 10:35:32 AM
Quote from: Danne on June 14, 2019, 10:25:32 AM
Nice!
Question. Aborting export stops processing and erases ongoing file. I would prefer if the file was stopped and then kept for previewing purposes.
I sidestep working is to force quit Mlv App instead of aborting which seems to send a kill ffmpeg signal and the file will be stopped but viewable.
Can be changed easily. Maybe I create a checkbox in menu for that. For now, see MainWindow.cpp line 2349 in current revision - comment it out and you're done.

Edit: I'll just deactivate this and then all 4 different export pipes do the same.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 14, 2019, 08:40:21 PM
Short infos:
Deleting for aborted export files is now disabled.
And bouncyball found the ideal solution for the "focus pixel fix + mapp" problem. Thx!
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on June 14, 2019, 09:20:46 PM
Nice. Will check later. Is the file viewable too after aborting? Header data is applied when sending kill signal on mac but otherwise not.

EDIT: Tested, working. Great!
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 17, 2019, 08:43:19 PM
Quote from: Ilia3101 on May 30, 2019, 09:48:54 PM
...
Ugly but I prefer it even that way.
Hm... I don't like ugly. So I tried to double the precision for waveform monitor. And resizing transformation is set to "smooth". Looks not so bad I think, but needs a bit more time for processing - at least if the scope is bigger or if set to waveform / rgb-parade.
(https://user-images.githubusercontent.com/30245296/59627905-a2b13380-913f-11e9-8b34-b9466d903d53.png)
(https://user-images.githubusercontent.com/30245296/59627937-b2c91300-913f-11e9-8897-f1957fd2bfd4.png)
(https://user-images.githubusercontent.com/30245296/59627941-b8265d80-913f-11e9-82ff-a3411f93ce8f.png)
Hope you like it and can live with that. The change was bigger than expected. ;)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 18, 2019, 01:04:01 AM
Great work @masc !
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: reddeercity on June 18, 2019, 07:14:14 AM
Checking the export from mlv -> dng with 3x1 4k (4064x590) 5D2 , just notice when exported the frame display is
the correct un-squeezed resolution (4064x1770) but the metadata says 4064x590 with  exiftool , which of course
has a smaller data size . Nice going , good job ! Used mlv_rec , I thought this only work with mlv_lite .
So I looked closer at the metadata and notice
MLV App is writing 

Camera Model Name               : Canon EOS 5D Mark II
Subfile Type                    : Full-resolution Image
Image Width                     : 4064
Image Height                    : 590
Bits Per Sample                 : 10
Compression                     : Uncompressed
Black Level                     : 112
White Level                     : 1013
Default Scale                   : 1 3

and I see "Default Scale : 1 3"
so I check a crop_rec 2784x1160 from my 5D2 and it's says
Default Scale                   : 1 1
Which has a bigger data size .
Anyways imports in to Adobe After Effect with out any problems , and displays the correct resolution frame size (4064x1770)
:D
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on June 18, 2019, 10:26:46 PM
I got a question. Is it possible for Mlv App while exporting file to also show the preview window of the file being exported? Right now it´s the first file being exported that is what we are seeing until all files have been exported. Maybe there´s a not to difficult way of instead having the first frame of the actual file being exported showing? Of course this is a nitpicking feature but still nice.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 18, 2019, 10:48:08 PM
This should be possible. I just disabled preview for maximum export speed.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on June 18, 2019, 10:55:17 PM
I see. Maybe enable preview after each export, let the first frame appear, then disable while exporting until next file and so on?
Prolonging this idea, a moving preview window following export frames like in after effects as optional would be nice too ;)  8) :P
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: marcelolippi on June 19, 2019, 08:48:48 AM
Guys, working with 4.5k 2.35: 1 aspect with the eosm Danne build, I can apply the mask of focus points of dfort or only with the formats rewired, mcm, 16: 9 etc.? Help me, maybe I don't understand, thanks

Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 19, 2019, 09:22:29 AM
There are focus pixel maps (from dfort) for all those presets. Just download maps, drop maps on app and switch focus pixel fix on. With some luck, the maps you need are already installed in MLVApp and you just have to open the MLVs (see last posts from zeek).
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ricardopt on June 19, 2019, 10:25:36 AM
Hi everyone!

Sort of a newbie question... i've been using mlvapp and normally i choose a "color preset" and do some fine tuning after, is there a way to bypass the "colour presets" (standart/tonemapped, film etc) and export in a kind of "raw" format? English is not my native language so im hoping im getting all the wording correctly.

Thanks
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 19, 2019, 10:41:37 AM
Quote from: ricardopt on June 19, 2019, 10:25:36 AM
... i've been using mlvapp and normally i choose a "color preset" and do some fine tuning after, is there a way to bypass the "colour presets" (standart/tonemapped, film etc) and export in a kind of "raw" format?
This is no preset, this is the processing profile. You can bypass it by setting to "Linear", but I am sure you won't like it. At the point of using the profiles, it is too late for getting RAW, because debayering has been done already. If you like to export RAW, you can choose DNG export codec and all processing is disabled (except RAW Corrections).
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on June 19, 2019, 10:52:05 AM
For true raw you need dng. Or else white balance is burnt in and other things. Closest signal to raw I think is to export some log like cineon and try to get as neutral white balance as possible. Then again, color handling, tonemapping and other stuff also added from Mlv App might not match the following NLE you are importing files to. If closer source accuracy is important then go for dng.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 19, 2019, 10:58:01 AM
Quote from: Danne on June 19, 2019, 10:52:05 AM
If closer source accuracy is important then go for dng.
... and do all corrections manually in your NLE/other grading tool (e.g. rebuild a correct camera matrix,...).
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on June 19, 2019, 11:09:34 AM
Color matrices are read in NLE like resolve isn´t it? Not forward matrices but the other one I think...
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 19, 2019, 11:15:45 AM
Quote from: Danne on June 19, 2019, 11:09:34 AM
Color matrices are read in NLE like resolve isn´t it? Not forward matrices but the other one I think...
Are you sure? I am not sure if blackmagic corrects inoffical files from Canon camera's. The only way I know is to add a LUT - but the only MLRaw LUT I know is for EOS 5D Mark III, and this one produces slightly different looks for other EOS camera's.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on June 19, 2019, 11:20:07 AM
I think it needs to, or colors will look like russian roulette  :-*
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ricardopt on June 19, 2019, 12:33:37 PM
Hi Masc and Danne, thanks for the input, mlvapp has a lut option, my question was because of it, do i need to set to linear and then import the lut? On premiere/resolve the user brings the footage to the NLE and then uses the lut and export.

with mlvapp i still need to choose a processing profile, and then the lut or is it best to set to linear and bypass the processing profile?
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 19, 2019, 12:48:39 PM
As in any NLE / grading tool you have to convert your footage to the right input profile, the LUT needs to work correctly. To know what is "right", see documentation of the LUT (might be a log profile, BMD Film, linear, ...).
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ricardopt on June 19, 2019, 01:06:13 PM
Thanks for the info/enlightenment/help Masc.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 19, 2019, 05:06:33 PM
Quote from: Danne on June 18, 2019, 10:55:17 PM
I see. Maybe enable preview after each export, let the first frame appear, then disable while exporting until next file and so on?
Prolonging this idea, a moving preview window following export frames like in after effects as optional would be nice too ;)  8) :P
See MainWindow.cpp line 205. Comment it out and it will show the first frame for the current clip in export with some extra processing time.
Moving preview window is difficult, because viewer and export are two independant processing pipelines, one at 8bit going to the viewer and scopes, one at 16bit going to ffmpeg/AVFoundation output. So atm we would have to process each frame twice with a small change @ half speed. And this would only work for AVFoundation and ffmpeg output.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: aulden on June 20, 2019, 12:09:35 AM
Would it be possible to add a feature which could virtually export the processed MLV files as DNG sequences, like MLVFS does?
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 20, 2019, 07:55:50 AM
Quote from: aulden on June 20, 2019, 12:09:35 AM
Would it be possible to add a feature which could virtually export the processed MLV files as DNG sequences, like MLVFS does?
I don't think it is possible, to a couple of reasons. It might be possible when 100% adding MLVFS into MLVApp... but why one should do that? This would just rise complexity and build many bugs on both sides. So we should just use MLVFS as it is.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on June 20, 2019, 04:36:02 PM
Quote from: masc on June 17, 2019, 08:43:19 PM
Hm... I don't like ugly. So I tried to double the precision for waveform monitor. And resizing transformation is set to "smooth". Looks not so bad I think, but needs a bit more time for processing - at least if the scope is bigger or if set to waveform / rgb-parade.
(https://user-images.githubusercontent.com/30245296/59627905-a2b13380-913f-11e9-8b34-b9466d903d53.png)
(https://user-images.githubusercontent.com/30245296/59627937-b2c91300-913f-11e9-8897-f1957fd2bfd4.png)
(https://user-images.githubusercontent.com/30245296/59627941-b8265d80-913f-11e9-82ff-a3411f93ce8f.png)
Hope you like it and can live with that. The change was bigger than expected. ;)

Thanks for this!!! Looks really really good
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: escho on June 22, 2019, 07:04:23 PM
Hallo
it´s some time ago, I worked with mlvapp the last time. Today, I cloned the sourcecode from github and tried to compile it. But it failed. Looks like some things have changed in the last few months. I will search for the error later and report.
In the meantime:
"platform/qt/FFmpeg" contains a zero bit file called ffmpeg. This file make problems, using tar and wildcards on Linux. What is this file for? Is it necessary or could you delete it from the sources?
Edgar
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 22, 2019, 07:38:35 PM
Hi escho,
nice to hear from you! ;) I compiled the latest revision on OSX and Windows without problems, but did not try Linux. In the .pro there are 2 linux versions available. You must comment in / out the one which fits for you (one is for appimage, one for normal use). The empty ffmpeg file is also just for linux, because if the file does not exist, the compiler fails - this was strange, but with this file it worked fine for me. (had something to do with Qt on Linux, which verifies if all files to install after compilation are there, before unpacking them, or something like this)
You should comment in after line 297 and comment out after line 310. I always need the empty file for the line 310+ commented in... maybe that's the problem? (Try to delete it, please.)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: escho on June 22, 2019, 08:43:24 PM
Hallo masc

I would love to be more often in here, but I´m not the master of my time atm. But I can see a light at the end of the tunnel. "Technische Rufbereitschaft" till monday morning. And then: vacation. One week Berchdesgaden, two weeks working on my observatory: https://sternenkarten.com/2019/06/08/neues-von-der-sternwarte-fundamentloch-fur-die-betonsaule/ :)

I compile for normal use, not for the appimage. Yes, I see in the code for the appimage, that you make this empty file executable and use it other way too. No clue, why this is necessary. I don´t know linuxdeployqt...

I can only speak for openSUSE Tumbleweed:

Line 307 in the .pro file forces the unpacking of the Linux-Version of ffmpeg, which is shipped with mlvapp. But the linux-Version is newer than the version from my last compiling some months ago. But this line is specified for unpacking the  "old" ffmpeg-version. So I changed the line to cover updates of ffmpeg in the future:

QMAKE_POST_LINK += tar -C $$(HOME)/bin -xvJf $$_PRO_FILE_PWD_/FFmpeg/ffmpegLinux.tar.xz --strip-components=1 --wildcards */ffmpeg

The differece is the wildcard in the archive. Looks similar to the tar-line, which is used for the appimage.

But, unpacking ffmpeg does not run on my system, if this empty ffmpeg-file exists. If I delete it, all is fine and ffmpeg goes to ~/bin.
I wrote a little script for cloning and compiling mlvapp. So I will change my script and let it delete this ffmpeg-file before compiling. So, no problem for me.

Could you change Line 307 to the new version, please?

I found another hickup, which make ploblems on compiling. I will tell later about it. Now the "Rufbereitschafts-Handy" said: ring, ring. I must go to work...

Edgar
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 23, 2019, 10:22:54 AM
Thank you, escho!
I commited your change, hope it works (can't try here). Strange, that you have to delete the file to make it work, and for building the appimage it has to be there to make it work. No idea, if we could automate this any better. You run your script before loading the .pro into Qt?
Looks interesting with the work for your observatory! :)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: escho on June 23, 2019, 01:27:23 PM
Thanks for commiting, masc. The ffmpeg-stuff works now here.

My script looks like this, now:

#!/bin/bash

# Installationsscript für mlvapp
# Für Linux openSUSE Tumbleweed
#

# Start des Scriptes im Terminal mit sh...
#
# sh mlvapp-clone.sh
#
# Nicht als root ausführen
#
# ********** Benutzung auf eigene Gefahr *****************

set -e #exit on error

if [ $HOME = "/root" ]
then
    echo
    echo "********************************************"
    echo "***    Script nicht als root starten!    ***"
    echo "***              Abbruch                 ***"
    echo "********************************************"
    echo
    exit
fi

################################# preparation ###################################

# --- Hauptverzeichnis ---

mkdir -p ~/mlvapp-project

################################# dependencies ###################################

echo
echo
echo "##################### Abhängigkeiten auflösen bzw. updaten ##########################"
echo
echo

# --- compile-envirement ---

sudo zypper --non-interactive install \
libqt5-creator \
libqt5-qtmultimedia-devel

echo
echo

# ------------ git --------

sudo zypper --non-interactive install \
git

echo
echo

############################### clone from github ##################################

echo
echo
echo "######################## mlvapp code clonen ##########################"
echo
echo

cd ~/mlvapp-project
git clone https://github.com/ilia3101/MLV-App.git MLV-App-master

echo
echo

############################ delete zero-byte ffmpeg ###############################

echo
echo
echo "##################### zero byte fffmpeg löschen ##########################"
echo
echo

rm ~/mlvapp-project/MLV-App-master/platform/qt/FFmpeg/ffmpeg

############################### compile and install ################################

echo
echo
echo "########################### stash-file erzeugen ############################"
echo
echo

cd ~/mlvapp-project/MLV-App-master/platform/qt
qmake-qt5

echo
echo

echo
echo
echo "############################## Kompilieren #################################"
echo
echo

exit

make

echo
echo
echo "############################## Installieren ################################"
echo
echo

echo
echo

make install

################################# end ################################################

echo
echo
echo "################################## Fertig ###################################"
echo
echo

exit


I found a problem in igv_demosaic.c,  which prevents me from compiling. I will do some tests later and report then.

Edgar
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 23, 2019, 02:42:00 PM
Your script is very interesting! So downloading, compiling, etc. is done with these few lines! Cool. Could be interesting for others too. Maybe we should link your post on the first post, @Ilia!?

A while ago I changed some lines in igv_demosaic... but it compiled on all three platforms here. What doesn't like the compiler? Has it to do with OMP?
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: escho on June 23, 2019, 03:15:34 PM
Be careful with the script. It works only on openSUSE. In Ubuntu, the filenames are different, so it will not work there without some changes.

I will upload the script to my "Sternenkarten-site" later ( https://sternenkarten.com/ ). It´s easier for me, to hold the script up to date there. If you want to link, please link to to the file on my website. Give me some minutes ...

Yes, the compile-error is related to the parallel-stuff. But I guess, I found a solution for this problem. Will do some test and report then ...
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 23, 2019, 03:18:43 PM
Sure, take your time! ;)

Do you have openMP (OMP) installed?
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: escho on June 23, 2019, 03:36:44 PM
The script is online: https://sternenkarten.com/2019/06/23/script-for-cloning-and-compiling-mlvapp/  :)

And yes, I have installed openmp
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: escho on June 23, 2019, 04:00:30 PM
As I mentioned above, mlvapp does not compile here in openSUSE Tumbleweed. The reason is the pasallel-stuff in "igv_demosaic.c".

I loaded the project into qt-creator. There, the fault is easier visible. here a screenshot:

https://seescho.files.wordpress.com/2019/06/mlvapp-parallel-1.jpg

As you can see, the compiler complaine, that there are some variables, that are not specified in the parallel-part. They are these variables:

width
height
v1
v2
v3
v4
v5
v6


I followed this article on the web:

https://bisqwit.iki.fi/story/howto/openmp/#DefaultClause

and changed line 267 in "igv_demosaic.c" to

#pragma omp parallel shared(rgb,vdif,hdif,chr,tilex,tiley,rawData,red,green,blue)

And now, I can compile and run mlvapp

Edgar
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 23, 2019, 06:43:23 PM
Thanks for analysing and for your solution, @escho! So it seems openSuse has another compiler than Ubuntu... I had no problem with that before. Also funny, that your compiler brings so many warnings - my compiler brings not a single one. Maybe it is just configured differently.
Looks like the "default(none)" is not needed. In the code I found, it was included but commented out. I just commented in the parallel stuff and changed some "for" loops and it worked. So I stopped thinking about further ;)
I now added your change to the repos! Thanks again!
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: escho on June 23, 2019, 07:13:11 PM
Thanks @masc. Works like a charm now.

I just found another little inconstistency. But this must wait, till I`m back from my vacation :)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 23, 2019, 08:12:29 PM
Quote from: escho on June 23, 2019, 07:13:11 PM
I just found another little inconstistency. But this must wait, till I`m back from my vacation :)
Have a nice holiday! Don't forget to write about this inconstistency... ;)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on June 27, 2019, 11:10:36 AM
Almost 500 downloads of the mlv_app_compiler tool for mac so I thought I reset and upload a new version  :P. Ongoing builds will however ask for update every 24 hours so no need for redownload if you already have a version downloaded. Download link in first post anyway.

Commit:

https://bitbucket.org/Dannephoto/mlv_app_compiler/commits/c264e90bd37a4e1545c856a0b3e301e04e54debe

This version will ask for downloading and updating of pixel map files continuously developed by dfort since only a few of them are included otherwise:
https://bitbucket.org/daniel_fort/ml-focus-pixels/src/default/

This question when selecting "c" or "op":
(https://i.postimg.cc/bv8DTjQw/Screenshot-2019-06-27-at-10-56-51-png-scaled.png)

If all went successfully this:
(https://i.postimg.cc/pTLmwYcN/Screenshot-2019-06-27-at-10-56-01-png-scaled.png)

Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 27, 2019, 11:53:48 AM
Great! ;)
I like the idea of autoupdating pixel maps. Will have a look if I can do this platform independant too.
Title: Re: MLV App 1.6 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Jip-Hop on June 30, 2019, 05:34:18 PM
Quote from: masc on April 22, 2019, 10:03:03 AM
As bouncyball already wrote, DNG import will not be possible so easy. The internal realization is written for MLV only atm and must be rewritten just for this feature. If you find a way of packing DNGs into MLV, all DNG files MUST have the same resolution and settings, otherwise you'll get crashes only. Frame geometry and memory allocation is adapted always using metadata found in the first frame of a clip atm (and normaly it does not change).

From DNG back to MLV-App would be a useful addition in my opinion. I export my MLVs to DNG to work with in DaVinci resolve. At this point it takes up twice the storage space if I decide to keep also the MLV files. That's why I started with MLVFS, but that didn't work so well for me. So I delete the MLVs after the export. But this way I lose the ability to open them back up in MLV-App. If I later find something wrong, e.g. Focus Pixels, I can no longer fix them in MLV-App.

If MLV-App exports the MLV specific metadata to a file, together with the DNG files, then nothing is lost when the DNG's are imported into MLV-App again. But apparently it's complex to translate DNG back to MLV file format... I imagine it would be the exact same as export to DNG but in reverse :P
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 30, 2019, 06:59:00 PM
Exporting a MLV is no problem, but importing a non-MLV file into MLVApp is. Someone "just" has to write the lower level modules new from scratch.
Until this is done, I recommend Ilia's hot tip from first post:
Quote from: Ilia3101 on July 08, 2017, 10:19:19 PM
...

  • If you want to process DNGs, use DNGApp.com (http://dngapp.com)
     
...
;D ::) :P
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Jip-Hop on June 30, 2019, 08:59:54 PM
Thanks! That's what I expected. Will have to be sure before I delete my MLV files for now then. Does DNGApp still exist? The link doesn't work for me: http://DNGApp.com (http://dngapp.com).
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on June 30, 2019, 09:04:10 PM
Quote from: Jip-Hop on June 30, 2019, 08:59:54 PM
Does DNGApp still exist? The link doesn't work for me: http://DNGApp.com (http://dngapp.com).
;) This was the joke...
Quote from: Jip-Hop on June 30, 2019, 08:59:54 PM
Will have to be sure before I delete my MLV files for now then.
This is indeed the best option.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Jip-Hop on July 01, 2019, 12:33:40 AM
Quote from: masc on June 30, 2019, 09:04:10 PM
;) This was the joke...

You got me there! :D
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Jip-Hop on July 01, 2019, 03:55:01 PM
I'm unable to export my MLV file to CinemaDNG Lossless with Chroma Smooth 3x enabled.
I get the following error: "Could not save: some dng frame number. How would you like to proceed? Skip Frame. Abort current export. Abort batch export."
Some frames get exported fine, even some MLV files from todays recording processed fully.
But most of them fail.

When I disable Chroma Smooth 3x I can export without any issues.

I've got Fix Focus Dots enabled, but would like to enable chroma smooth as well because it cleans some of the aliasing.

Heres the link to an example MLV file: https://www.dropbox.com/s/3mfepggxbw473bd/M01-0912%20short.MLV?dl=0 (https://www.dropbox.com/s/3mfepggxbw473bd/M01-0912%20short.MLV?dl=0).

I'm on macOS Mojave with the latest MLV App version 1.7 and freshly downloaded focus dots maps.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on July 01, 2019, 08:23:38 PM
Thanks for reporting. The description was good, I could reproduce immediately with your file. I run the program with my debugger and now I see, that this error message is produced by the lj92 library. This library compresses the data.
This is the function which returns with the error code:

int lj92_encode(...)
    ...
    // Scan through data to gather frequencies of ssss prefixes
    ret = frequencyScan(self);
    if (ret != LJ92_ERROR_NONE) {
        free(self->encoded);
        free(self);
        return ret;
    }

I don't know what exactly this function does... there is nearly no comment inside. @bouncyball: do you have any idea?

For now you could just export your clip uncompressed.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Jip-Hop on July 01, 2019, 08:49:51 PM
Thanks! Glad to hear the report was useful. I can confirm on my end that exporting uncompressed works in this case. So I'll do that instead. Hope it gets fixed in the future because I like RAW but I also like to save space ˆˆ
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on July 02, 2019, 06:06:50 AM
Is it the right time to get rename option in MLVApp session for MLVs ? And export it with the new given name for each MLV , this is gonna be life & time saver!
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: domo94 on July 02, 2019, 04:02:16 PM
Is there a way we can set up and automated import feature where it applies a specific setting to your footage immediately upon import?

I usually just throw on Cineon Log, fix hot pixels / bad pixels, and change debayering.
Then export in 4444 or 422 depending on the project.

It would be nice to just import, and preset, then export.
Would make my life 10x easier.

Also, this app crashes at times when loading or viewing footage.

MLV 14 bit RAW is hefty. I don't think 1.5 crashed as much.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on July 02, 2019, 04:23:47 PM
You can build your own preset. Check the tabs for export receipt.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: domo94 on July 02, 2019, 04:51:05 PM
@Danne
I'm not sure it works the way I would personally like it to.

I'm talking about upon import, the settings are applied.
What I do is set up 1 clip, fix pixels, find LOG, then copy, paste onto all the clips.

It can be a little slow and choppy because of the MLV App performance.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on July 02, 2019, 05:01:12 PM
Only slowdown is indexing. That's how the formats was designed. Other than that I don't see any different importing a receipt from what you just wrote...
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on July 02, 2019, 10:18:12 PM
On a sidenote. How is mlrawviewer indexing frames. It's blazing fast even on an old macbook air...
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: domo94 on July 02, 2019, 11:46:17 PM
Importing a receipt isn't automatic, though.

I'm not familiar with this function and it's asking me to open a .marxml file.
Would I have to do this EVERY TIME I upload files?

Idk, my program tends to crash.
White balance selection is terribly slow.
Import takes time, that's a given considering the huge file sizes. I get a 'not responding' prompt every time I import MLV files.

Is the indexing happening WHEN I IMPORT MLVs?
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on July 03, 2019, 06:09:58 AM
Yes, and if you create mapp files for all mlv files it will be indexed and ready next time you open. But they need to be indexed at least once to create mapp file so put it over night if having huge files.

Well exporting/importing a recipe file is not that hard. There's also a short cut section of your latest project worked upon.

@bouncyball
These indexing files. Why are they needed? Or could they be created like dummies? Isn't there enough info in header/footer to just build indexing without chewing each and every frame? Amount of frames are there in header metadata already right? Maybe that is what mlrawviewer does since dng amounts sometimes varies...
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on July 03, 2019, 08:13:21 AM
Quote from: domo94 on July 02, 2019, 04:02:16 PM
Is there a way we can set up and automated import feature where it applies a specific setting to your footage immediately upon import?
No.
Quote from: domo94 on July 02, 2019, 04:02:16 PM
I usually just throw on Cineon Log, fix hot pixels / bad pixels, and change debayering.
Then export in 4444 or 422 depending on the project.
You can set it once, copy, select all, paste.
Quote from: domo94 on July 02, 2019, 04:02:16 PM
It would be nice to just import, and preset, then export.
Would make my life 10x easier.
Don't agree.
Quote from: domo94 on July 02, 2019, 04:02:16 PM
Also, this app crashes at times when loading or viewing footage.
MLV 14 bit RAW is hefty. I don't think 1.5 crashed as much.
Really? Please try to figure out how you get it crashed. I played a lot in the last week with 450GB, 500 MLV files 14bit uncompressed and/or lossless - without any crash.

Quote from: domo94 on July 02, 2019, 04:51:05 PM
What I do is set up 1 clip, fix pixels, find LOG, then copy, paste onto all the clips.

It can be a little slow and choppy because of the MLV App performance.
What are you doing? Pasting on 500 clips is done in under a second on a 9 years old laptop.

Quote from: domo94 on July 02, 2019, 11:46:17 PM
Importing a receipt isn't automatic, though.
Correct. It is 3 mouse clicks.
Quote from: domo94 on July 02, 2019, 11:46:17 PM
I'm not familiar with this function and it's asking me to open a .marxml file.
Right. It is the .marxml you exported once a lifetime before.
Quote from: domo94 on July 02, 2019, 11:46:17 PM
Would I have to do this EVERY TIME I upload files?
You have to do it once for a session before you export.
Quote from: domo94 on July 02, 2019, 11:46:17 PM
Idk, my program tends to crash.
Please try to reproduce and tell us how you get it crashed.
Quote from: domo94 on July 02, 2019, 11:46:17 PM
White balance selection is terribly slow.
0.5 sec on a 9 years old laptop, yes. Until now we don't have a better solution. Waiting for help since a long time here...
Quote from: domo94 on July 02, 2019, 11:46:17 PM
Is the indexing happening WHEN I IMPORT MLVs?
Indexing happens when loading a file from the session into the viewer, if "Create MAPP" is enabled and no MAPP is available.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Jip-Hop on July 03, 2019, 09:36:00 AM
I was crashing MLV App yesterday a lot when trying to export MLVs which stopped recording due to card full. Had to ignore the last portion (maybe 60 frames, don't remember exactly). Apart from that seems to be quite stable for me.

One thing which is a bit inconvenient though is that sometimes MLV App will halt batch export if it can't process a certain frame. It will give you three choices (skip the frame, cancel the batch export and another one).

Would be great if there's an option to just continue always, and warn about issues afterwards. Like when copying in Windows where it will ask you to overwrite each individual file, or with one click overwrite all. Or somehow put these problematic ones at the end of the queue. So that I can answer all the pop-ups, which halt export, at once. Otherwise I have to monitor the export constantly and can't leave the computer.

Still a really hot app though!
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Danne on July 03, 2019, 09:41:12 AM
Quote from: masc on July 03, 2019, 08:13:21 AM
Indexing happens when loading a file from the session into the viewer, if "Create MAPP" is enabled and no MAPP is available.
So there´s three options here?
1 - Import MLV files without Create MAPP enabled? How is it disabled?
2 - Create MAPP enabled? Or do you mean it´s enabled when pushing this option?
3 - Push Create MAPP or push Create All Mapp Files Now?

Importing a big MLV file will take longer than a short MLV file so I´m curious what is indexed upon import if MAPP file options isn´t selected? Is it waiting for the last frame to get indexed? In this case it would be useful to have an option to fast import by reading header data instead. Reworking these routines will have a significant speed increase in workflow.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: domo94 on July 03, 2019, 09:56:06 AM
@Masc
OH!
I understand. It's a global paste, so to speak, that would apply to all footage. Oh that's kind of nice, works fine. 3 mouse clicks is just fine.

As for the crashing, I'm not sure, I'll try to reproduce some stuff.

Usually I get mega slow-downs when I import footage and then when I double click on a shot in order to preview, the longer the shot is, the longer it takes to load.

Actually, I realized where I'm confusing everybody. The IMPORT is quick, my mistake. The action to drag, drop, and then letting MLV App import the footage unto the queue is a .5 second process.
I guess I am generalizing it together with the computer's ability to actually playback and load a clip in the view monitor.

I am understanding this better now.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on July 03, 2019, 10:32:59 AM
Quote from: Jip-Hop on July 03, 2019, 09:36:00 AM
I was crashing MLV App yesterday a lot when trying to export MLVs which stopped recording due to card full. Had to ignore the last portion (maybe 60 frames, don't remember exactly). Apart from that seems to be quite stable for me.
Could you please upload this file(s) / clip? We would need such files for debugging.
Quote from: Jip-Hop on July 03, 2019, 09:36:00 AM
One thing which is a bit inconvenient though is that sometimes MLV App will halt batch export if it can't process a certain frame. It will give you three choices (skip the frame, cancel the batch export and another one).

Would be great if there's an option to just continue always, and warn about issues afterwards. Like when copying in Windows where it will ask you to overwrite each individual file, or with one click overwrite all. Or somehow put these problematic ones at the end of the queue. So that I can answer all the pop-ups, which halt export, at once. Otherwise I have to monitor the export constantly and can't leave the computer.
Ok, thanks. We can think about that.

@Danne:
- if a MAPP is available, it is always used. The clip is imported qucikly.
- if no MAPP is available and "Create MAPP" is disabled, the clip is imported without indexing and with full read out. This can take some time in dependency to the size of the clip.
- if no MAPP is available and "Create MAPP" is enabled, indexing is done with full read out. This can take some time in dependency to the size of the clip.

MAPP files consist of the following packages:
file
rawi
rawc
idnt
expo
lens
elns
rtci
wbal
styl
wavi
diso
dark

Quote from: domo94 on July 03, 2019, 09:56:06 AM
Usually I get mega slow-downs when I import footage and then when I double click on a shot in order to preview, the longer the shot is, the longer it takes to load.
This just happens, if no MAPP is available (hopefully).
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on July 03, 2019, 12:05:40 PM
Hi guys!

@Danne

Quote from: Danne on July 03, 2019, 06:09:58 AM
These indexing files. Why are they needed? Or could they be created like dummies? Isn't there enough info in header/footer to just build indexing without chewing each and every frame? Amount of frames are there in header metadata already right? Maybe that is what mlrawviewer does since dng amounts sometimes varies...
I'll try to shortly explain what indexing is:

It is done not just for counting frames.

1. For speeding up reading MLV we _MUST_ find and save into index file (MAPP, MRX, IDX, etc) the physical offsets to the raw data for every video frame in current MLV. Knowing exact offset to the raw data needed (during plaing or moving frame slider) we can access it in the file _instantly_ w/o searching VIDF header over and over again. Example: if needed frame No 507, we get by function offset_to(507) and read frame size amount of bytes into the buffer. Basta :)

2. Sometimes frames are written in MLV file with wrong order. Example: 1,2,5,3,4,7,8,6,10,9. So they must be ordered correctly according to their timestamp. Before recording the index to MAPP they are sorted with ascending order.

If we are not saving MAPP at all, the indexing is still done in memoy for every MLV over and over again (if mlv is big enough, this takes lot of time). It is just very convenient to save all gathered data to file for getting lately with just one burst read and put to memory. That is what saves a lot of time on slower HDDs and even on SSDs for big files.

One more thing, the frame amount read from MLV header sometimes differ from actual number. So calculating frames according to this value is inaccurate and unreliable.

br,
bb
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on July 03, 2019, 12:22:02 PM
And I think indexing in mlrawviewer is done in the background in a separate thread. File is playing with some hickups though, before indexing is fully done.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ZEEK on July 03, 2019, 01:28:31 PM
@Ilia3101
Hey, I was wondering if the codec option "10 Bit Uncompressed" could be re-incorporated into MLV App? I used to use this export codec back in the days with the Canon 6D ML RAW. It was very fine indeed! I downloaded the old MLV Apps to see if I could find it again, however it's not there! Thanks in advance.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on July 03, 2019, 01:42:23 PM
Quote from: ZEEK on July 03, 2019, 01:28:31 PM
@Ilia3101
Hey, I was wondering if the codec option "10 Bit Uncompressed" could be re-incorporated into MLV App? I used to use this export codec back in the days with the Canon 6D ML RAW. It was very fine indeed! I downloaded the old MLV Apps to see if I could find it again, however it's not there! Thanks in advance.
What codec format is that? And which version had it (any idea)? There shouldn't be lost any codec...

Edit: what about "Uncompressed AVI -> V210 10bit"?
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ZEEK on July 03, 2019, 02:09:04 PM
Quote from: masc on July 03, 2019, 01:42:23 PM
What codec format is that? And which version had it (any idea)? There shouldn't be lost any codec...

Edit: what about "Uncompressed AVI -> V210 10bit"?

It just said 'Uncompressed 10 Bit' as an option towards to bottom of the list from memory. It wasn't Uncompressed AVI. I may have to look back and look at the earliest ones of MLV App. I definitely remember it being there back in the day.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Jip-Hop on July 03, 2019, 04:47:43 PM
Here's the MLV file which makes MLV App crash when exporting to CinemaDNG Fast Pass, DaVinci Resolve Naming Scheme.

https://www.dropbox.com/s/m0xqknynoie10zk/M01-1136.MLV?dl=0 (https://www.dropbox.com/s/m0xqknynoie10zk/M01-1136.MLV?dl=0)

Unfortunately had to upload the whole (big) file, as I couldn't make it shorter.
Exporting a shortened MLV didn't crash the app but gave this error:

"Could not read VIDF image data from: M01-1136.MLV."

So probably that error isn't handled correctly when exporting to CinemaDNG?

Remember this was the recording which filled up the card, so probably ML couldn't cleanly end the file.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on July 03, 2019, 06:43:46 PM
Thank you, Jip-Hop. I'll download and analyze. Yes, here we need the full file to get the error. I am very excited why it crashes the app. We have so many error paths in the app, but it seems minimum one is missing ;)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on July 03, 2019, 07:54:26 PM
@Jip-Hop:
unfortunately I can't reproduce the crash here (OSX 10.9). It exports fine without any error, as cdng, fastpass, as you described. What are your system specs? Did you set other options? The last dng picture is corrupted (half pink).
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on July 04, 2019, 12:04:02 PM
@Jip-Hop:

I can not reproduce the crash either. Last frame is indeed corrupted and can not be exported as compressed .DNG, uncompressed/fast shows artifacts.

Otherwise exporting as compressed/uncompressed/fast with both naming schemes is perfectly fine here (Linux Ubuntu 16.04)

Edit: some amount of last frames playing silent.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Jip-Hop on July 04, 2019, 03:33:50 PM
Well that's strange. Don't think we're going to find what's causing this.
I could reproduce it consistently with that file yesterday and the day before.
But not anymore today... Forgot exactly what settings I used, but I could export it fine now a couple of times.

However, I also ran into a couple of crashes but differently this time.
If I open MLV App, then add that file, change Chroma Smooth to 5x5 and export in DNG Fast Pass with DaVinci Resolve naming it crashed MLV App instantly.
Even before progress bar shows.

Was hoping this crash would happen consistently, but to my surprise repeating the process I got a couple of successful exports too.

I'm on the latest MacOS 10.14.5 by the way.

Sorry to bother with this!
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on July 04, 2019, 04:19:23 PM
What you could also do next time it crashes: OSX brings a crashreport. You can enlarge and copy the text of it. Paste it here... so we know the source code function where to search for the bug.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Jip-Hop on July 04, 2019, 05:20:05 PM
Here's a crash report. As you'll notice from the hardware specs it's a Hackintosh. But don't think that will be the cause of the crash.
https://www.dropbox.com/s/vc08qkrhjldu74e/crash%20report.txt?dl=0 (https://www.dropbox.com/s/vc08qkrhjldu74e/crash%20report.txt?dl=0)
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: bouncyball on July 04, 2019, 05:30:52 PM
Quote from: Jip-Hop on July 04, 2019, 03:33:50 PM
If I open MLV App, then add that file, change Chroma Smooth to 5x5 and export in DNG Fast Pass with DaVinci Resolve naming it crashed MLV App instantly.
Even before progress bar shows.
When export is set to "Fast Pass" all raw corrections are skipped anyway, so CS 5x5 has none of impact on export as none of impact has naming scheme either.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on July 04, 2019, 05:37:14 PM
Thank you. The report tells that the app crashed in the function which prepares the export... very strange. No idea what could go wrong in there. I would need the crash on my computer when the debugger is active to see the line and all variable values.

Edit: did it show the file dialog before crashing?
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Jip-Hop on July 04, 2019, 06:02:29 PM
Yes I think it crashed right after the file dialog. It's about to overwrite an earlier export of the same file. If that matters.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on July 06, 2019, 07:02:39 PM
Just wanted to inform that MLVApp does not prevent windows to go into sleep mode , so when i leave PC overnight to render all clips, PC will turn itself off after a couple of clips and go into sleep mode because of no activity, i think rendering is some sort of activity but in my case it still goes to sleep..
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: masc on July 06, 2019, 10:14:19 PM
Quote from: 2blackbar on July 06, 2019, 07:02:39 PM
Just wanted to inform that MLVApp does not prevent windows to go into sleep mode...
Unfortunately this is out of scope of the Qt libraries. Maybe it is possible to implement it 3 times for 3 OS. Someone knows how to do this? No idea about Windows or Linux... in OSX it is only a few clicks to switch off sleep mode in system panel.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on July 06, 2019, 10:57:03 PM
It's just a few clicks away in Windows, too. And there are several tools for Windows just to prevent sleep/hibernation while running: Don't sleep, Caffeine, No more sleep, ...

Or something like this batch (source: stackoverflow)
@echo off
powercfg.exe -x -monitor-timeout-ac 0
powercfg.exe -x -monitor-timeout-dc 0
powercfg.exe -x -disk-timeout-ac 0
powercfg.exe -x -disk-timeout-dc 0
powercfg.exe -x -standby-timeout-ac 0
powercfg.exe -x -standby-timeout-dc 0
powercfg.exe -x -hibernate-timeout-ac 0
powercfg.exe -x -hibernate-timeout-dc 0
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: 2blackbar on July 06, 2019, 11:38:46 PM
So disabling sleep mode is the only solution ? Its easy to do this but then after rendering cpu will stay on.MLVApp gives estimate time to finish rendering so thats helpful.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on July 07, 2019, 12:09:51 AM
I described two solutions: Disabling sleep/hibernate by batch and tools triggering some event to reset sleep timer. And it's up to masc to implement some kind of system event inside MLV App as a third solution (or not).
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 07, 2019, 01:17:38 AM
Just seems like simple function calls on windows: https://stackoverflow.com/questions/34836406/how-to-prevent-windows-from-going-to-sleep-when-my-c-application-is-running/34836464#34836464
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: KirbyLikes525 on July 10, 2019, 06:47:40 PM
Quote from: 2blackbar on July 06, 2019, 07:02:39 PM
Just wanted to inform that MLVApp does not prevent windows to go into sleep mode , so when i leave PC overnight to render all clips, PC will turn itself off after a couple of clips and go into sleep mode because of no activity, i think rendering is some sort of activity but in my case it still goes to sleep..

Had the same issue on my iMac. Disabling 'power save', not sleep mode, did the trick. Mac still goes to sleep but renders always finish. So maybe try a different option.
Title: Re: MLV App 1.7 - All in one MLV Video Processing App [Windows, Mac and Linux]
Post by: Luther on July 11, 2019, 01:49:31 AM
@Ilia3101 Do you have plans to return on the BetterProcessing branch? Let me know if I could help.
Title: Re: MLV App 1.7 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 12, 2019, 03:20:44 PM
i do
Title: Re: MLV App 1.7 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ngemu on July 13, 2019, 04:42:01 AM
Sorry this is probably answered already but I can't seem to find the issue.

I have some MLV files but upon playing them in MLVapp, the video does not play continuously and just jumps back and forth between 2 frames.

Is this an MLVapp issue or did I mess up my settings in magic lantern.

Title: Re: MLV App 1.7 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on July 13, 2019, 07:57:15 AM
You need to share more info. Best if you upload the mlv file and we can inspect that instead.
Title: Re: MLV App 1.7 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 13, 2019, 10:52:14 AM
This looks indeed very strange. Also would like to get this MLV for analysis.
Title: Re: MLV App 1.7 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: escho on July 13, 2019, 05:49:44 PM
@masc
1111 posts, congratulations  ;)
https://seescho.files.wordpress.com/2019/07/posts.jpg
Title: Re: MLV App 1.7 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 13, 2019, 07:31:18 PM
Quote from: ngemu on July 13, 2019, 04:42:01 AM
Sorry this is probably answered already but I can't seem to find the issue.

I have some MLV files but upon playing them in MLVapp, the video does not play continuously and just jumps back and forth between 2 frames.

Is this an MLVapp issue or did I mess up my settings in magic lantern.



This looks very similar to what my 5D produced in the early days of 10/12 bit raw video, so it could be a camera glitch by the looks of it. Try playing the clip in MLRawViewer or converting it to DNGs in mlv dump to check if it is an MLV App issue.
Title: Re: MLV App 1.7 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 15, 2019, 02:53:46 PM
Quote from: escho on July 13, 2019, 05:49:44 PM
@masc
1111 posts, congratulations  ;)
https://seescho.files.wordpress.com/2019/07/posts.jpg
Hehe, thank you ;)
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: ngemu on July 16, 2019, 06:19:59 PM
Quote from: Ilia3101 on September 07, 2018, 08:38:39 PM
Yeah MLV aAPP is just useless for colour isn\'t it


Edit: Lol sorry for the passive aggressive reply. But my point is that MLV App is perfectly capable of producing a cinematic image out of a good shot, and in my opinion this video is a better result than many people get with davinci resolve etc. It just takes effort and practice to get nice images, not the best software. The main thing for good looking images is having smooth highlights, in my opinion and MLV App can do that pretty perfectly. And you can add a lut in MLV App if you like that style of colour. And I admit MLV App is still not colour accurate, also the that video is not very detailed (it's more about colour).

An external recorder will still give you cr4p 8 bit colour depth the prores doen't help.

Would love if you could make a tutorial. This is absolutely beautiful. I've been playing around with mlvapp but cant seem to get my footage to look anywhere close.
Title: Re: MLV App 1.7 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jonkjon on July 16, 2019, 08:54:09 PM
Attempting to compile with latest changes for EOSM2 and getting lots of errors from QT on windows 10 pro using QT Creator 4.9.1 based on 5.12.3 and MinGW 7.3.0 64 bit....here is a brief list:

release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x4c5): undefined reference to `min'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x4e2): undefined reference to `min'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x3e8e): undefined reference to `min'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x3e9a): undefined reference to `max'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x3f05): undefined reference to `min'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x3f11): undefined reference to `max'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x3f63): undefined reference to `min'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x3f6f): undefined reference to `max'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x3fba): undefined reference to `min'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x3fc6): undefined reference to `max'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x42fb): undefined reference to `min'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x4307): undefined reference to `max'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x431f): undefined reference to `min'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x432b): undefined reference to `max'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x4f4a): undefined reference to `min'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x4f56): undefined reference to `max'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x4fec): undefined reference to `min'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x4ff8): undefined reference to `max'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x5440): undefined reference to `min'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x544c): undefined reference to `max'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x5469): undefined reference to `min'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x5475): undefined reference to `max'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x5489): undefined reference to `min'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x5495): undefined reference to `max'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x54ac): undefined reference to `min'
release/amaze_demosaic.o:amaze_demosaic.c:(.text+0x54b8): undefined reference to `max'
release/patternnoise.o:patternnoise.c:(.text+0x39f): undefined reference to `min'
release/patternnoise.o:patternnoise.c:(.text+0x3a9): undefined reference to `max'
release/patternnoise.o:patternnoise.c:(.text+0x433): undefined reference to `min'
release/patternnoise.o:patternnoise.c:(.text+0x43c): undefined reference to `max'
release/patternnoise.o:patternnoise.c:(.text+0x75a): undefined reference to `max'
release/patternnoise.o:patternnoise.c:(.text+0x1116): undefined reference to `min'
release/patternnoise.o:patternnoise.c:(.text+0x1161): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x644): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x64f): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x6bf): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x6ca): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x73a): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x745): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x7d9): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x7e4): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0xa56): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0xa6b): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0xacd): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0xad9): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0xd18): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0xd23): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0xee6): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0xef1): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0xf58): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0xf68): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0xf86): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0xf92): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x115f): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x1170): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x11cb): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x11dc): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x1224): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x1235): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x1283): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x1294): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x142b): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x1437): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x145b): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x146c): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x1491): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x14a2): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x14bb): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x14c7): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x168e): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x169f): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x16fa): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x170b): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x1753): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x1764): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x17b2): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x17c3): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x195a): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x1966): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x198b): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x199c): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x19c1): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x19d2): undefined reference to `max'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x19eb): undefined reference to `min'
release/igv_demosaic.o:igv_demosaic.c:(.text+0x19f7): undefined reference to `max'
collect2.exe: error: ld returned 1 exit status
mingw32-make[1]: *** [Makefile.Release:418: release/MLVApp.exe] Error 1
mingw32-make: *** [Makefile:38: release] Error 2
mingw32-make[1]: Leaving directory 'C:/Users/jonkj/Downloads/MLV-App-master/platform/build-MLVApp-Desktop_Qt_5_13_0_MinGW_64_bit-Release'
14:46:33: The process "C:\Qt\Qt5.13.0\Tools\mingw730_64\bin\mingw32-make.exe" exited with code 2.
Error while building/deploying project MLVApp (kit: Desktop Qt 5.13.0 MinGW 64-bit)
When executing step "Make"
14:46:33: Elapsed time: 00:54.


Thanks for any help...

--Jon
Title: Re: MLV App 1.7 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 16, 2019, 09:03:50 PM
Ah okay... you use 64bit MinGW. I never tried that. And bouncyball cross compiled the windows 64bit version using Linux. I always compiled with 32bit MinGW version, because it was the only compiler until last Qt version, if I remember right.

In these files (the compiler tells) you'll find some defines "#ifdef/ifndef WIN32". I bet this is the problem. We should find a define for 32bit and 64bit at the same time. No idea if Q_OS_WIN would do the jub (it would in c++ part, but not sure if also in C part of the app).

Edit: puh... the problem starts already in project file MLVApp.pro ... Windows version is defined with "win32" there. I really wonder how this works with Win64 crosscompiler on Linux.
Title: Re: MLV App 1.7 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 17, 2019, 10:27:08 AM
@ngemu Shoot your shots in golden hour light and the colours will look similar to that video. also don't overdo processing, I didn't do much more than saturation white balance and contrast.

@jonkjon@masc all the errors just look like min max function does not exist while being linked. You could try fixing that by adding your own min and max functions to any of the mlv app source files. It's a hack but why not try.

ALso since when does amaze use  a MIN fumtiom instead of the macro !?!??
Title: Re: MLV App 1.7 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 17, 2019, 12:08:30 PM
Did a quick change for the MIN MAX problem. I can compile here with MinGW64 now. Please check out and try to compile again (@jonkjon).

Edit: Qt >=5.12 has a bug, where icons in menus are wrong. And font-sizes in docks are wrong too. So... here we can't do anything. Wait until Qt fixes and live with it as is, or use an older version of Qt. In Qt 5.9.2 I did not see any GUI bugs, but there is no offical 64bit build.
Menu icon bug will be fixed in Qt 5.12.5 and 5.13.1, Qt plans 27. august 2019 and 15. august 2019. (https://bugreports.qt.io/browse/QTBUG-74655)
Title: Re: MLV App 1.7 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jonkjon on July 17, 2019, 07:10:13 PM
Quote from: masc on July 17, 2019, 12:08:30 PM
Did a quick change for the MIN MAX problem. I can compile here with MinGW64 now. Please check out and try to compile again (@jonkjon).

Edit: Qt >=5.12 has a bug, where icons in menus are wrong. And font-sizes in docks are wrong too. So... here we can't do anything. Wait until Qt fixes and live with it as is, or use an older version of Qt. In Qt 5.9.2 I did not see any GUI bugs, but there is no offical 64bit build.
Menu icon bug will be fixed in Qt 5.12.5 and 5.13.1, Qt plans 27. august 2019 and 15. august 2019. (https://bugreports.qt.io/browse/QTBUG-74655)

Thanks....compiled just now and it is working. There were some warnings but nothing that stopped the compile. Thanks again.....

--Jon
Title: Re: MLV App 1.7 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 17, 2019, 07:58:36 PM
Thanks for the feedback. Nice to hear it works. I also could fix the size of the dock label font now.
Title: Re: MLV App 1.7 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 20, 2019, 02:48:00 PM
MLVApp v1.8 is out now! New in v1.8:
- Added vignette shape slider
- Added chromatic abberation correction
- Added export preset list (to save your own presets)
- Added a third interpolation method for focus and bad pixels (thanks to Rewind)
- Added more support for EOS M2 (focus pixel fix and camera matrix)
- Faster WB picker
- Scopes are resizeable now
- Some bug fixes and some minor changes
https://github.com/ilia3101/MLV-App/releases/tag/QTv1.8
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jimiz on July 20, 2019, 02:55:23 PM
THANKS MASC !!!!   
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 20, 2019, 10:52:14 PM
Wasn't just me. Thanks also to Ilia, Bouncyball, Escho, Rewind, Danne, and many more...
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: andy kh on July 21, 2019, 07:01:09 AM
fastastic. the white balance picker works great and the scopes looks amazing and easier to work with now
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: KirbyLikes525 on July 21, 2019, 07:33:26 PM
I've stuck with 1.3 because of reasons after trying later versions but the resizable scopes has my interest!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 21, 2019, 07:45:33 PM
could you tell us why you were staying at 1.3? did something get worse or break?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Stousen on July 21, 2019, 09:31:00 PM
Love this app! :-*

But is there anyway to regulate what frames that should be exported?
Lets say I have som unstable frames in the beginning of a recording, would be great to trim that away to save export time:)
//Chris
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 21, 2019, 09:32:47 PM
Quote from: Stousen on July 21, 2019, 09:31:00 PM
Love this app! :-*
But is there anyway to regulate what frames that should be exported?
Lets say I have som unstable frames in the beginning of a recording, would be great to trim that away to save export time:)
Thank you. Yes, there is a way to trim: use CutIn / CutOut (2nd box in edit panel). After doing this, only the trimmed part is exported.
Title: Re: Making a New MLV Processing App! [Windows, Mac and Linux]
Post by: Kharak on July 21, 2019, 11:24:46 PM
Quote from: ngemu on July 16, 2019, 06:19:59 PM
Would love if you could make a tutorial. This is absolutely beautiful. I've been playing around with mlvapp but cant seem to get my footage to look anywhere close.

I don't use MLV App to grade my projects, but on my travel laptop I always use MLV app to play with colours of my footage to see what I got.

I don't remember who told me this trick, think illia or masc, but this helped me get past the "stale" look.

Basically you wanna use the Exposure slider to win back your highlights, by decreasing the slider -0.5 to -1.5 and then use Light Strenght and dark strenght to expose your shots, ofcourse together with the Range Sliders, but Dark Range I always have max and after pulling exposure the footage usually does not need any increase in Dark strenght. Lighten also helps brighten your midtones, but more often than so, too much Lighten will wash out your contrast. Then play with saturation. Ofcourse the Camera Matrix tick box changed the entire "colour science" for the better aswell, so leave that on.

And always manually WB your shots.

I look forward to 1.8 :)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on July 22, 2019, 10:42:30 AM
Hi,
Is there a way to compare before and after editing? Smth like bypass editing to show the original shot?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 22, 2019, 10:58:44 AM
Quote from: Dmytro_ua on July 22, 2019, 10:42:30 AM
Hi,
Is there a way to compare before and after editing? Smth like bypass editing to show the original shot?
Hm... what is "the original shot"? The original shot is B/W and bayered. I think you don't want to see this. The settings when importing a clip are some default parameter (which we defined) but has nothing to do with "original" something. This is why there is no option for that. Anyway... if you want to see the difference between importing and final, you can use the shortcuts: Ctrl+C (activate all checkboxes), Ctrl+Alt+R for the default, and then again Ctrl+V for the final.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Stousen on July 22, 2019, 04:46:51 PM
Quote from: masc on July 21, 2019, 09:32:47 PM
Thank you. Yes, there is a way to trim: use CutIn / CutOut (2nd box in edit panel). After doing this, only the trimmed part is exported.

Ahh, the app just got even better :)! Great, thanks!

//Chris
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on July 22, 2019, 09:09:12 PM
Quote from: masc on July 22, 2019, 10:58:44 AM
what is "the original shot"?

It's like in ACR. Sometimes you do a subtle correction and it's nice to see before/after. In Adobe Camera Raw it is a "P" key.

Quote from: masc on July 22, 2019, 10:58:44 AM
you can use the shortcuts: Ctrl+C (activate all checkboxes), Ctrl+Alt+R for the default, and then again Ctrl+V for the final.

Not a one key, but can do the trick. Thanks, will try ;)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: histor on July 22, 2019, 11:06:27 PM
Is there anything of interest for reconstructing skipped lines?
Bayer Interpolation with Skip Mode (http://crisp.massey.ac.nz/pdfs/2015_IMVIP_67.pdf)
Are we stretching debayered data in the MLV App for now?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 23, 2019, 12:54:43 AM
Well it would be nice, but that document seems to show a different kind of skipping to what canon DSLRs do
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: histor on July 23, 2019, 11:09:52 AM
Quote from: Ilia3101 on July 23, 2019, 12:54:43 AM
...but that document seems to show a different kind of skipping to what canon DSLRs do
Yes. Plus we have different skipping modes, plus the pattern changes depending of the offset (in crop modes). But the variants aren't innumerable.
The task in paper was much easier. We have shifting/alternating pattern. Weights will change, as the block needs to be non-square. The idea is that we know (well, guess) so much about the type of line skipping but it's not used in processing. Current dabayering algorithms are not intended to be used on squeezed images. And all that "pattern mess". Aren't they?
I had a fantasy about such interpolation on the pre-debayer stage. So that we might fill in the missing pixels with a "simple" shifting block algorithm (like in the paper - rough but fast) and then feed it to the common dabayering processor. We can even output interpolated DNG for use in other software.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Stousen on July 23, 2019, 12:54:58 PM
Hey Guys,

Has anyone tried to compare superscale in resolve with scaling in mlv app?
Anyone can get me through the basics of what the differences there might be and is it worth the extra time in workflow with scaling in resolve?

Thanks!

//Chris
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on July 23, 2019, 08:15:53 PM
Hi guys, Ive been away a long time and have an Ursa Mini Pro as my main cam now but just ordered a trusty old 5d mk iii in the hope it will make a nice B cam! So this app looks very promising but I notice it has no inbuilt preset looks? LUTS. What are you guys using to take into resolve and match with other cameras?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 23, 2019, 08:24:11 PM
Quote from: DavidP on July 23, 2019, 08:15:53 PM
So this app looks very promising but I notice it has no inbuilt preset looks? LUTS. What are you guys using to take into resolve and match with other cameras?
You can load any 1D or 3D .cube LUT into MLVApp. You can export as cDNG, or you can export as ProRes with BMDFilm profile.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on July 23, 2019, 08:31:28 PM
Quote from: masc on July 23, 2019, 08:24:11 PM
You can load any 1D or 3D .cube LUT into MLVApp. You can export as cDNG, or you can export as ProRes with BMDFilm profile.

Thanks for the answer. The thing is though, what LUT will work for this hack we have ourselves here? I'm wanting to match the camera to my Ursa so I'm hoping to transform to a specific look that will be recognized in Resolve and can be transformed to match. If I export with a bmdfilm profile that will then transform magic lantern raw to bmdfilm or its a generic to bmdfilm lut? The fact its not camera-specific seems a bit broad also!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on July 23, 2019, 08:36:57 PM
Ffmpeg could export a hald clut which could apply all necessary color and white balance and contrast settings coming from Mlv app.. It should be possible to generate a lut from this to work with in resolve for instance. It would requore some work to get it matched but probably worth the effort.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on July 23, 2019, 08:41:38 PM
So we can't say automatically save to prores as canon log or slog for example in a way I can then use the Resolve Transform tool to convert that to match my Ursa? I remember this feature used to be on some older software.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 23, 2019, 09:03:04 PM
Quote from: DavidP on July 23, 2019, 08:15:53 PMSo this app looks very promising but I notice it has no inbuilt preset looks? LUTS. What are you guys using to take into resolve and match with other cameras?

In what way does it not have these inbuilt preset looks:
(https://i.ibb.co/tByYsCs/Screenshot-from-2019-07-23-20-00-31.png)

Quote from: DavidP on July 23, 2019, 08:31:28 PM
The fact its not camera-specific seems a bit broad also!

We are not using any generic LUT, we implemented actual transfer functions in the specifications of these formats. MLV App transforms each camera to the same colour space internally, and the rest of the processing follows on from there. Currently the main issue with MLV App is that it uses rec709 primaries for all profiles, the BetterProcessing branch, once merged, will fix this and you will get completely accurate profiles such as BMDFilm, ArriLog, with correct gamut and all.

You can compile BetterProcessing, it should already be correct for the log profiles (though I will check). We could compile it for you as well if you need.

EDIT: BMDFilm is a rather propeitary standard and there is no public info about the colour primaries, so I recommend using Arri Log to match colours, if you can get your blackmagic footage in to that as well.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 23, 2019, 09:26:14 PM
Quote from: histor on July 22, 2019, 11:06:27 PM
Is there anything of interest for reconstructing skipped lines?
Bayer Interpolation with Skip Mode (http://crisp.massey.ac.nz/pdfs/2015_IMVIP_67.pdf)
Are we stretching debayered data in the MLV App for now?
Sounds interesting. But as Ilia said, the skipping is different. For now we stretch the debayered picture in post. The example pictures in this paper look more or less like our bilinear demosaic results... so not sure if it is able to bring better results. But thanks for posting such ideas!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on July 23, 2019, 11:24:46 PM
Quote from: Ilia3101 on July 23, 2019, 09:03:04 PM
In what way does it not have these inbuilt preset looks:
(https://i.ibb.co/tByYsCs/Screenshot-from-2019-07-23-20-00-31.png)
EDIT: BMDFilm is a rather propeitary standard and there is no public info about the colour primaries, so I recommend using Arri Log to match colours, if you can get your blackmagic footage in to that as well.
I always tend to fall into this thread whenever I try to understand bmd log:
http://www.bmcuser.com/showthread.php?15819-BMD-film-log-specs

From iaremrsir:
"Let me rephrase. There is no gamut encoding to be undone. Some background: white balance is normally achieved by using the color matrices to convert to XYZ then to some defined RGB gamut. This is not the case with BMD Film. It performs white balance in the sensor's space. This is also the reason why BMD Film is so much more desaturated than every other wide gamut besides ACES. Maybe it'd be easier to show you the math of it? If you wanted to convert to CIE XYZ you'd have to use the matrices in the camera's metadata and interpolate a matrix for the specific white balance you wanted.

I do agree that BMD needs to define a gamut to make life easier for VFX folks and for programmers like myself so that programs could more easily support the cameras."
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 23, 2019, 11:32:04 PM
So BMDFilm is just in the blackmagic camera's native sensor gamut? That means for each camera it is a different colour space  >:( :( ::)

... Actually the same is true for arri alexa log, but at least with alexa cameras they all have the same sensor (or the same sensor stacked 3x), so "alexa widegamut RGB" is always the same thing for all cameras, however with blackmagic all sensors are different so they won't have matching colour ugh
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on July 24, 2019, 02:13:24 AM
Thrilled to see a new version :)) I'll have to see what those matrix/uncolorscience bring.

Small question. i remember a discussion a few months ago about what exactly MLVApp does when selecting each profile, since the results look so different in standard Rec709 inside Resolve. It was something like +1 exposure by default, etc etc etc
I'm talking mainly about the standard "standard" profile. Someone knows exactly what does it do?


Quote from: DavidP on July 23, 2019, 08:15:53 PM
Hi guys, Ive been away a long time and have an Ursa Mini Pro as my main cam now but just ordered a trusty old 5d mk iii in the hope it will make a nice B cam! So this app looks very promising but I notice it has no inbuilt preset looks? LUTS. What are you guys using to take into resolve and match with other cameras?

Just bring the dngs to Resolve, use bmd films as an input lut on the raw options panel in the preferences and BMCC v2 rec709 as an output lut on the color preference panel (depending your grading setup). You don't have to do anything more in mlvapp than exporting the dng.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on July 24, 2019, 03:03:10 AM
Ok so I did a fast test. You can find my MLV here if you want to play around: http://www.mediafire.com/file/r2h5j8ml51fed6t/M02-0127.MLV/file



Playing a little bit on Resolve this is what I'm doing to match the standard profile and the uncolourscience fix with some WB adjustment on MLV APP. Still needs highlights to be pushed/lowered to match but whatever.

- bmd film input on raw panel to BMCC v2 rec709 as output lut
- VERY different WB settings.
+2 exposure on raw panel
-20 saturation on raw panel   (testing on other images brought this to -10 sat)
+20 contrast on raw panel


Also I now understand that I'm clueless about the matrix/camera thing. I choosed the fix one but which one does what?


Resolve:

https://i.imgur.com/fQEVMZE.png

MLVApp

https://i.imgur.com/7vrstfe.png

https://i.imgur.com/HzvP6tR.png


Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on July 24, 2019, 05:54:23 AM
Wow thanks guys! Excited to try this when my camera arrives! I look forward to proving the other ursa guys wrong who think this is a bad idea! I'll give it a go compiling myself after some more reading after my work.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 24, 2019, 07:17:30 PM
Quote from: togg on July 24, 2019, 03:03:10 AM
Also I now understand that I'm clueless about the matrix/camera thing. I choosed the fix one but which one does what?

an explanation:

Don't use camera matrix: camera's native RGB channels are interpreted as rec709 primaries, and white balance is done in those colour channels - I do not recommend this mode for accuracy, also different cameras will not match.
Use camera matrix: camera colours are converted to MLV App's processing gamut accurately using camera specific matrix, and white balance is done in LMS colour space (where the R, G and B channels imitate eye colour cells), which should preserve colour constancy better.
Uncolourscience fix: Same as use camera matrix, except the white balance is not done in LMS gamut, instead it is one that @Danne came up with by tweaking matrix values, it helps reduce blue clipping at lower colour temperatures (2000-3000K), but should not be used if there aren't any clipping problems, as it can and will affect colour quality or accuracy. This mode will be removed when BetterProcessing branch is complete (it should fix the clipping issues).
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: katrikura on July 24, 2019, 07:25:34 PM
Hello: I congratulate all those who work in an undisturbed way, to offer us this application. I would like to know how I can export a specific amount of frames in mlv.app in windows? I do not want to export the entire video. Thank you.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on July 24, 2019, 07:36:34 PM
Quote from: Ilia3101 on July 24, 2019, 07:17:30 PM
an explanation:

Don't use camera matrix: camera's native RGB channels are interpreted as rec709 primaries, and white balance is done in those colour channels - I do not recommend this mode for accuracy, also different cameras will not match.
Use camera matrix: camera colours are converted to MLV App's processing gamut accurately using camera specific matrix, and white balance is done in LMS colour space (where the R, G and B channels imitate eye colour cells), which should preserve colour constancy better.
Uncolourscience fix: Same as use camera matrix, except the white balance is not done in LMS gamut, instead it is one that @Danne came up with by tweaking matrix values, it helps reduce blue clipping at lower colour temperatures (2000-3000K), but should not be used if there aren't any clipping problems, as it can and will affect colour quality or accuracy. This mode will be removed when BetterProcessing branch is complete (it should fix the clipping issues).

Ok got it, pretty complex stuff. Don't use camera matrix sounds really fucked up! Shouldn't it be removed ? Can't wait for the BetterProcessing stuff.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 24, 2019, 07:37:40 PM
@katrikura
Quote from: masc on July 21, 2019, 09:32:47 PM
Yes, there is a way to trim: use CutIn / CutOut (2nd box in edit panel). After doing this, only the trimmed part is exported.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 24, 2019, 07:45:13 PM
Quote from: togg on July 24, 2019, 07:36:34 PM
Ok got it, pretty complex stuff. Don't use camera matrix sounds really fucked up! Shouldn't it be removed ? Can't wait for the BetterProcessing stuff.

It will kind of be removed in BetterProcessing. But using it now may be a decent combination with one of the log curves, as it will preserve the camera's whole gamut and that is good for LOG grading if you know all that stuff. Arri Alexa Log-C colour space also use the Alexa sensor's native gamut, so it is a similar idea, same with BMDFilm from blackmagic.

But if you want to grade in MLV App and export a final result, then better to have camera matrix on, that way you get a similar colour experience to a photography raw converter.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 24, 2019, 08:11:31 PM
Nice explanation @Ilia. I added it to the MLVApp Wiki.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on July 25, 2019, 05:57:04 PM
Just playing about exporting as dngs and importing as blackmagic design then using the cinema 2.5k to rec lut as suggested and it indeed looks very similar to the color I expect from my ursa! I look forward to the better processing addon mind for when im camera matching. Is this something planned for the near future? If so I may wait rather than trying to compile myself and breaking something!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on July 25, 2019, 06:11:59 PM
Update... correcting WB in MLV app, selecting arri log c and using camera matrix then saving as prores 444 hq seemed to work better! What an awesome piece of software guys, come along way since the years since I last used it! I'll do some comparisons vs the UMP cam in the next couple weeks when I get time.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 25, 2019, 07:06:43 PM
Quote from: DavidP on July 25, 2019, 06:11:59 PM
...correcting WB in MLV app, selecting arri log c and using camera matrix then saving as prores 444 hq seemed to work better! ...
That's the way to do, if you want to grade as ProRes in another software.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 25, 2019, 07:11:23 PM
Quote from: DavidP on July 25, 2019, 06:11:59 PM
Update... correcting WB in MLV app, selecting arri log c and using camera matrix then saving as prores 444 hq seemed to work better! What an awesome piece of software guys, come along way since the years since I last used it! I'll do some comparisons vs the UMP cam in the next couple weeks when I get time.

Glad to hear it is working well.

Quote from: DavidP on July 25, 2019, 05:57:04 PM
Is this something planned for the near future? If so I may wait rather than trying to compile myself and breaking something!

I'd say about a month, hopefully less, but if it is working well for you for now, it may not be worth the effort of compiling. Though it won't break anything if you do try :)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on July 27, 2019, 04:47:34 AM
Cool! I'm happy to do some controlled lighting tests to see how well it matches with the ursa mini pro and a7sii before and after the update if its helpful.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ricardopt on July 28, 2019, 11:15:38 PM
Hi everyone.

Any chance of disabling the cmd window "poping up" when it changes from one conversion to another (batch), the conversion im doing at the moment will take about 3 hours, i tought about watching something on netflix etc etc while it converts the videos but the cmd windon keeps popping up.

Thanks
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 28, 2019, 11:22:04 PM
Could you put MLV App on a different virtual desktop in windows? (https://www.howtogeek.com/197625/how-to-use-virtual-desktops-in-windows-10/)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Ottoga on July 29, 2019, 03:56:06 AM
@Ilia3101
QuoteCould you put MLV App on a different virtual desktop in windows?

Yes, it works fine.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 29, 2019, 07:53:09 AM
Quote from: ricardopt on July 28, 2019, 11:15:38 PM
Any chance of disabling the cmd window "poping up" when it changes from one conversion to another (batch), the conversion im doing at the moment will take about 3 hours, i tought about watching something on netflix etc etc while it converts the videos but the cmd windon keeps popping up.
It pops up on Windows only, because of Windows. On any other OS it won't pop up.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on July 29, 2019, 11:26:35 PM
Compiled latest version. Something is very fishy:
(https://i.postimg.cc/sg0xySnV/Ska-rmavbild-2019-07-29-kl-23-21-19-png-scaled.png)

(https://i.postimg.cc/vZmTpXtq/Ska-rmavbild-2019-07-29-kl-23-21-10-png-scaled.png)

Not an issue with previous build. Compared an same frame looks alright. Didn´t have tie to check latest updates.

Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 29, 2019, 11:33:26 PM
yes i'm about to reverrt that change i did  (or you can revert it as you have access that may be quicker, as im just busy working on this further, trying out more ideas)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on July 29, 2019, 11:51:03 PM
Aha, Suspected some work in progress. Keep on...
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MalcomZ on July 30, 2019, 12:34:09 AM
Hi! Very much impressed with the abilities of MLVAPP. Great work, it really helps!

I have some questions, if you dont mind.

1) Is there any chance that we will see real time playback of mlv files in future updates? This feature will dramatically increase footage sorting time.
2) Is there any way to get rid of black window during render procedure? And maybe minimize main program window? They interfere with other programs.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 30, 2019, 07:57:39 AM
Quote from: MalcomZ on July 30, 2019, 12:34:09 AM
1) Is there any chance that we will see real time playback of mlv files in future updates? This feature will dramatically increase footage sorting time.
2) Is there any way to get rid of black window during render procedure? And maybe minimize main program window? They interfere with other programs.
Thank you.
1) I don't think so. But you can export proxies for realtime preview and for cutting the project.
2) See only a few posts above yours: this is a Windows-only issue, but we can't change Windows. Just try another OS and you won't have this issue. Minimizing main program Windows also does not work for Windows? Huuu...why that?! No problem on Linux and OSX.
Edit: ah I see... the Dialog is in focus only. Hm... I think we have no chance here. It was different before, but different in a worse way.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Ottoga on July 30, 2019, 10:11:39 AM
Quote2) Is there any way to get rid of black window during render procedure? And maybe minimize main program window? They interfere with other programs.

Assuming that you are on the current Windows 10, Try running it in its own desktop. All associated processes should be self contained within that desktop instance and not interfere your main desktop processes.

Window key / Tab Key to create an additional desktop.

Switch to and run the app in the new desktop. I would expect that when running a time consuming processes like a batch export or importing a lot of files: that those process will run fine in the background if you switch back to your main desktop to do other activities.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MalcomZ on July 31, 2019, 02:03:13 AM
Quote from: masc on July 30, 2019, 07:57:39 AM
Thank you.
1) I don't think so. But you can export proxies for realtime preview and for cutting the project.
Ok, i understand. The reason i asked about it its the MLViewer software. As far as i remember, that program was able to play 14bit MLV files in realtime. It was very useful in quick footage preview and helps me to quickly choose the right shot. But  it does not work with 10 or 12bit files.

Quote from: Ottoga on July 30, 2019, 10:11:39 AM

Window key / Tab Key to create an additional desktop.

Switch to and run the app in the new desktop. I would expect that when running a time consuming processes like a batch export or importing a lot of files: that those process will run fine in the background if you switch back to your main desktop to do other activities.

Tnhx! Never heard about this feature, but unfortunately it does not help to solve the problem. Black DOS window easily jumps from one desktop to another and pulls focus to itself.   :(    So when you need to render a lot of clips and it tooks a lot of hours you need to switch active window every 3-5 minutes in order to continue you current activity. This is a bit annoying.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 31, 2019, 10:09:18 AM
MlRawViewer was realized in a different way and did not do so much processing as MLVApp does. If it is able to load such files, it can directly be called from MLVApp for realtime preview. With default parameters MLVApp will reach about 18-20fps playback speed for FHD clips on a i5 Quadcore 2.5GHz - so close to realtime.

To avoid the DOS box, change to another OS, e.g. Linux is fine and will also have less crashes, because memory management is better.
On the other side... all people are crying MLVApp is so slow while the computer is getting hot... why do you make it still slower and heat it even more by playing something else while processing?! Processing and export is a "nice task" for overnight.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ZEEK on July 31, 2019, 12:13:33 PM
Quote from: masc on July 31, 2019, 10:09:18 AM
why do you make it still slower and heat it even more by playing something else while processing?! Processing and export is a "nice task" for overnight.

Overnight is a good idea. Except if your computer/laptop has a loud fan ;)
A good idea could be to get an SSD Hard Drive (E.g. Samsung EVO 850/860/960). Export in 4K is quite quick on my old Macbook PRO 2012 which only costs $300 and upgrade ram from 8GB to 16GB FOR $80-100. Playback is pretty good in MLV App, though sometimes crashes when you pause. SSD is definitely a good idea.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yourboylloyd on July 31, 2019, 02:34:46 PM
Hey Quick Question. Is there any way to 'Undo' in MLV APP?

Like I adjusted a shadows slider but I want to undo the adjustment
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: andy kh on July 31, 2019, 02:48:58 PM
Quote from: yourboylloyd on July 31, 2019, 02:34:46 PM
Hey Quick Question. Is there any way to 'Undo' in MLV APP?

Like I adjusted a shadows slider but I want to undo the adjustment

Double click the shadows slider
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 31, 2019, 03:12:36 PM
@ZEEK: if you can reproduce such crashes, please tell howto. I just can fix bugs I can catch with the debugger (and even than it is hard :) )

@yourboylloyd: there is no undo/redo. There is just the doubleclick-on-slider-handle-feature for default value.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ricardopt on July 31, 2019, 03:15:09 PM
Quote from: Ilia3101 on July 28, 2019, 11:22:04 PM
Could you put MLV App on a different virtual desktop in windows? (https://www.howtogeek.com/197625/how-to-use-virtual-desktops-in-windows-10/)

Hi, the cmd still pops up on a different desktop, i just have to get used to the idea of not using the pc as long as mlvapp is running, hoping a "cleaner" solution comes in future versions.
Thanks
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 31, 2019, 03:24:12 PM
Quote from: ricardopt on July 31, 2019, 03:15:09 PM
...hoping a "cleaner" solution comes in future versions.
Not impossible... but has to be delivered from Microsoft with a better Windows. A "pipe" (the interface to communicate with ffmpeg) is a standard C interface. Only Windows brings a cmd box without any function, which nobody needs.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: KirbyLikes525 on July 31, 2019, 05:04:02 PM
Quote from: Ilia3101 on July 21, 2019, 07:45:33 PM
could you tell us why you were staying at 1.3? did something get worse or break?

Really silly reason but I wanted to keep the 'Use Camera Matrix' as a checkbox and not a dropdown because my muscle memory is with the checkbox as I typically process 80 - 100 clips at a time once or sometimes twice a week so it adds up. It's truly a case of 'it's not you, it's me'. If there's a version in between 1.3 and 1.X that still has the checkbox then I just missed it as I simply rolled back to 1.3
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on July 31, 2019, 05:52:52 PM
Quote from: masc on July 31, 2019, 03:24:12 PM
Not impossible... but has to be delivered from Microsoft with a better Windows. A "pipe" (the interface to communicate with ffmpeg) is a standard C interface. Only Windows brings a cmd box without any function, which nobody needs.

i really don't know what i'm talking about, but i just saw this and an idea came to mind:

can you somehow globally disable CMD, at least while you are doing these tasks?  maybe some of you recall "tweakUI", maybe it had some ability to do this, or perhaps it could inspire the way to do it?

just a crazy idea, maybe it will help?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 31, 2019, 06:19:16 PM
Quote from: KirbyLikes525 on July 31, 2019, 05:04:02 PM
I wanted to keep the 'Use Camera Matrix' as a checkbox and not a dropdown because my muscle memory is with the checkbox as I typically process 80 - 100 clips at a time once or sometimes twice a week so it adds up.
Why not do it just once, Ctrl+C, configure as in screenshot, Ctrl+A, Ctrl+V... and no matter how many clips you have, the camera matrix option of all clips is configured like the clip you edited.
(https://i.ibb.co/3pTrp9n/Bildschirmfoto-2019-07-31-um-18-12-58.png)

@70MM13: thanks for you idea... I tried so much, I even tested another much more complicated implementation for Windows only... but I didn't got it better, nothing was working for me. Maybe I just did it wrong, but now we have a 99,9% identical implementation for 3 different platforms, 2 work perfectly, one works but is ugly.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on July 31, 2019, 06:31:44 PM
i was actually thinking it might be something the user can do, system-wide...

but again, i don't know ;)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on July 31, 2019, 06:42:38 PM
one of the options in tweakUI is "prevent applications from stealing focus".

maybe it would help?

it's #4 on this list:

https://www.techrepublic.com/blog/10-things/10-cool-things-you-can-do-with-tweakui/
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: KirbyLikes525 on July 31, 2019, 06:58:06 PM
Quote from: masc on July 31, 2019, 06:19:16 PM
Why not do it just once, Ctrl+C, configure as in screenshot, Ctrl+A, Ctrl+V... and no matter how many clips you have, the camera matrix option of all clips is configured like the clip you edited.
(https://i.ibb.co/3pTrp9n/Bildschirmfoto-2019-07-31-um-18-12-58.png)

Many, many thanks!!!!!!!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: histor on July 31, 2019, 08:37:37 PM
So much discussions about the black window...
Here are two more programs to hide cmd window - https://ffmpeg.zeranoe.com/forum/viewtopic.php?t=4744#p13619 (https://ffmpeg.zeranoe.com/forum/viewtopic.php?t=4744#p13619)

And a C++ sample  here. (https://superuser.com/questions/62525/run-a-batch-file-in-a-completely-hidden-way/1220668#1220668)

Script languages like Autoit/Autohotkey also run hidden processes without a problem.

Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 31, 2019, 09:06:41 PM
Running a program without cmd is no problem. We got this already... The problem is building a pipe without the cmd window. This is normally done with popen(...), when using stdlib. This works very easy and identically on each OS - only stupid Windows brings the box. Therefor on Windows you can implement it somehow much more difficult using "CreateProcess" WIN32API (as Windows-only solution). But with this I had no luck to get the picture data from MLVApp to ffmpeg.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ricardopt on August 01, 2019, 02:23:41 AM
Im a total newbie when talking about coding, sorry if i offend anyone with my suggestion but would it be possible in windows to use the cmd window but minimized, i know its not perfect or even possible but instead of opening windows in the middle of teh screen it would open them but automatically minimized, is that possible?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 01, 2019, 07:56:04 AM
This would indeed be the easiest solution, but popen() does not allow to send flags to cmd.exe, so it is not possible this way. It would be the way to go with the more complicated WIN32API.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iliush on August 02, 2019, 02:03:45 PM
When exporting dng from MLV App 1.8, in After effects, the focus dots are prezent...
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 02, 2019, 02:18:55 PM
@iliush: Then you have not fixed them before exporting...
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iliush on August 02, 2019, 02:51:27 PM
The fix focus dots button is on, and the preview in MLV App is clean., is another way for fixing them?
I forget...windows 10
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 02, 2019, 03:01:58 PM
Please describe your problem as detailed as possible. I can't guess all. You also forgot to tell what export codec and option you've chosen (there are more than one possiblity for dng). But I guess you've chosen DNG fast pass, what means "without any correction".
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iliush on August 02, 2019, 04:19:05 PM
@masc: this is my last setup
https://drive.google.com/folderview?id=1-D-InJlhuQZjQDOpf0h03lGtZmhGIgvJ
I want a clean raw, without focus dots, for working in Adobe camera raw from after effects.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 02, 2019, 04:41:32 PM
So I sum up:
- you have a EOS 100D
- you use MLVApp 1.8 on Win10
- you have installed focus pixel maps from dfort (!?) (it seems you've done because viewer is clean, but I don't know. Do you see a difference when disabling focus pixel fix?)
- you enabled focus pixel fix
- you export as DNG lossless
- you import to AE and the dots are back again
So far so good. I think I need a short MLV sample to analyse the problem. Some single frames are enough.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: allemyr on August 02, 2019, 07:43:23 PM
Hi, thanks for a great application! Can i record RAW files aswell or is it MLV only with this app?

Thanks in advance!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 02, 2019, 07:50:54 PM
Quote from: allemyr on August 02, 2019, 07:43:23 PM
Can i record RAW files aswell or is it MLV only with this app?
MLVApp is for MLV only.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yourboylloyd on August 03, 2019, 07:21:49 AM
Quote from: masc on August 02, 2019, 07:50:54 PM
MLVApp is for MLV only.

I have a question about this since you bought it up. Is there a way to convert DNG+WAV's to an actual MLV file? Like if I'm using my black magic camera to capture raw, could I somehow have it so that I can edit both my Canon and BMPCC4K footage in MLVapp?

Not really sure if it will speed up my workflow or not. I was just curious if it's possible to turn any video sequence into MLV? And possibly even mock the metadata (manual lens info and what not).
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 03, 2019, 09:56:56 AM
No, there is no way to convert dng to mlv. Was discussed very often already.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iliush on August 03, 2019, 10:07:36 AM
@masc
-I haven't installed the dfort focus map until now ☺️, thanks for tutorial
- yes, enabling/disabling the focus fix in MLV App make the difference, (MLV App come preinstaled with a few focus maps)
   I do some experiments with the dfort maps and without, the results are the same... Just enabling the focus with the 2-nd option (in both situations) , make a better result, but far from perfect.
The good news for me is that exporting prores 4444 (i tried just this) from MLV make the perfect job, so this will be the way.
- this is the shortest clip:
https://drive.google.com/file/d/1gwIXMrW23VFdKhIDNMtDFMmV-VVlxnwu/view?usp=drivesdk
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MagicPhotoEvents on August 03, 2019, 10:17:44 AM
Hello,

I am on Ubuntu Xenial.

I have compiled and installed the MLVapp using the dedicated how to.

The MLVapp launch but it crash when I import a MLV video file (580Mb)

Could you help me to solve it please ?

Regards,


Olivier
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 03, 2019, 10:33:02 AM
Thanks for clip.
I imported it to MLVApp. I did not install a additional focus pixel map. With activating the fix (done automatically) the focus dots go away - I would say all, at least I don't see any. Then I exported as CinemaDNG uncompressed and as lossless (2 exports) and opened in Lightroom (should be the same engine like AE). Here I can't see any focus pixels as well.
(https://i.ibb.co/1vnCvdK/Bildschirmfoto-2019-08-03-um-10-29-44.png)
When I export as CinemaDNG Fast Pass, the dots are visible in Lightroom, as expected.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on August 03, 2019, 11:36:33 AM
I tried MLVApp 1.8 on Windows 10.
When I drop the highlights I get them pink.

Where in AfterFX/Photoshop this doesnt happen.

(If I use any Cinematic Filter, the pink disappears)
Any clue ?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 03, 2019, 01:13:01 PM
Quote from: yourboylloyd on August 03, 2019, 07:21:49 AM
I have a question about this since you bought it up. Is there a way to convert DNG+WAV's to an actual MLV file? Like if I'm using my black magic camera to capture raw, could I somehow have it so that I can edit both my Canon and BMPCC4K footage in MLVapp?

Not really sure if it will speed up my workflow or not. I was just curious if it's possible to turn any video sequence into MLV? And possibly even mock the metadata (manual lens info and what not).

could try

Quote from: Quentin on August 03, 2019, 11:36:33 AM
I tried MLVApp 1.8 on Windows 10.
When I drop the highlights I get them pink.

Where in AfterFX/Photoshop this doesnt happen.

(If I use any Cinematic Filter, the pink disappears)
Any clue ?

try lowering white level value in  raw settings, and enable highlight reconstruction
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 03, 2019, 03:59:49 PM
Quote from: Quentin on August 03, 2019, 11:36:33 AM
When I drop the highlights I get them pink.
...
(If I use any Cinematic Filter, the pink disappears)
Any clue ?
Your highlights are overexposed. Enable "highlight reconstruction". If it doesn't help yet, lower RAW white level. Cinematic filters often raise contrast, so highlights will be pushed into invisible range.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on August 05, 2019, 04:43:19 PM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 05, 2019, 06:25:17 PM
I think I can tell you what's wrong: you recorded using a 3 deg shutter! You used 29.978fps combined with a shutter of 1/3448sec ( = less than 300 µs!). This exposure is waaaay to short! Ideal would be 1/60sec. If this extremely short shutter varies only a very little bit, you get another brightness (300µs +-300µs would be double brightness vs. completely black), while at 1/60=16ms+-300µs wouldn't make a visible difference. Always use a ND filter to get longer exposures, and also try to use the "best" (smallest) ISO (you used 400, here 100 would be no problem at all).
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on August 05, 2019, 11:05:12 PM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 06, 2019, 09:00:24 AM
I never had this problem, so I can't tell how to get success with that. BUT: in older MLVApp versions (I think < v1.0) we had (under RAW Corrections) an option "Deflicker target". It accepts values from 0 to 9999, if I remember right. We don't know how to use it (that is why it is not there today), we just added the existing code to the app. Maybe we did not have the "correct" test footage for it. You could try with that. If that works... there is a hidden feature in the current MLVApp version: deflicker target is still there, it is just invisible (and untested, no idea if it really works). You can access it with the receipt and session files. These files are XML based. Search for the entry:
<deflickerTarget>0</deflickerTarget>
and change the number. Reload the file and have a look if something changes. As written... no idea if that helps... but maybe you have a try.

Edit: tried with some values... MLVApp accepts them (you'll see when exporting the receipt brings the values) but I don't see any effect on the footage - but I don't know what value has which effect. Maybe my input is just wrong.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 06, 2019, 09:25:56 AM
It could work. I tested this with mlvfs set to around 5000, can't remember exactly. Tested to even out hdr files so that was a pretty strong contrasty test file. No idea how above file will work. Maybe @dmilligan (author) still around?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on August 06, 2019, 04:11:54 PM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 06, 2019, 04:27:07 PM
The feature is on when the value is not 0 (as far as I know). The GUI won't show anything when manipulating the XML value. It works 100% in background. If you are interested, you could study the code... if you understand it, please explain and we will make the GUI elements visible again ;)
https://github.com/ilia3101/MLV-App/blob/master/src/mlv/llrawproc/llrawproc.c
Search for "deflicker". Code comment says "this is DNG feature only". When searching a bit through the code, I see this function writes some raw metadata (RAWI.raw_info.exposure_bias), which is only used on DNG export. So maybe try that... (this would explain why we don't see anything in GUI)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on August 06, 2019, 05:29:05 PM
Hey guys!

Deflicker option was intended for DNG export only. Uses DNG tag feature for exposure compensation for each frame (absolutely needs the DNG processing app to be aware of this tag, ACR does).

bb
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on August 06, 2019, 05:31:52 PM
In MLVFS this should work as Danne said.

Edit: not sure about success of this particular case though.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 06, 2019, 06:52:49 PM
Tested the deflicker algo in mlvfs applied through program "Switch" boy, long time since I used that one. Damn you Mlv app! ;). Anyway. Flicker seems too subtle here so it wasn´t removed.
So, next up I tweaked Switch to use tblend filter which usually neglects this filter if not a HDR file in Switch and the result was much better. Check file here:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/M24-1055.mov

Then I tested running the tblend filter on the above file once more and result seems almost perfect:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/M24-1055b.mov

So, a script with a double pass run of tblend averaging should be a good compromise. Of course averaging frames has its downsides so pick your poison wisely ;).

Sidenote: aah, how nicely dcraw handles highlights in this case(-H 2 I think).
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 06, 2019, 07:25:38 PM
Actually, there´s a deflicker solution in Mlv App. Set export options "Smooth aliasing" to 3 pass. Works really nice too:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/M24-1055c.mov
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 06, 2019, 08:15:38 PM
Not bad, not bad. The flicker is gone at the cost of some ghosting.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on August 06, 2019, 11:18:44 PM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 06, 2019, 11:38:39 PM
Quote from: Danne on August 06, 2019, 09:25:56 AM
It could work. I tested this with mlvfs set to around 5000, can't remember exactly. Tested to even out hdr files so that was a pretty strong contrasty test file. No idea how above file will work. Maybe @dmilligan (author) still around?
dmilligan

Quote from: Veerle on August 06, 2019, 11:18:44 PM
But, perhaps deflicker is not what's needed. Really liking the look of Danne's version b (double pass run of tblend). Is there a way this could be implemented in the app? Smooth aliasing is quite good too, but, like masc said, creates some ghosting.

Or alternatively, (similar to mentioned before) create an in app feature that runs a script calculating the exposure difference between frames, then set the desired target expo amount until pleased. I'm sure one of you geniuses could figure this out...

But ok... I don't desperately need this/a perfect fix right now, I can probably work around it. But I do think it'll be a neat feature to add to the app.
Ghosting is present in both solutions. Smooth aliasing is probably the better one.
Deflicker programs exists for timelapse use. Google around maybe you´ll find something useful.

Solving your issue is easy. Record with normal shutter speeds, use nd filter etc. There´s a reason why shutters are slow for filming.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on August 07, 2019, 12:16:05 AM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 07, 2019, 12:42:01 AM
Quote from: Veerle on August 07, 2019, 12:16:05 AM
This leads me to another question though (though perhaps not entirely the right topic):
Even though Canon's native video has many faults (which is why we use Magic Lantern), it does manage to prevent/ fix certain problems in-camera. There is no black sun, light flickering or much aliasing, color fringing or chromatic aberration no matter what settings you use. Makes me wonder, how do they do it...?
Whole basket of misconceptions right there...

Check out search button or google raw video/magic lantern and you´ll probably find a lot of answers right away.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on August 07, 2019, 05:17:51 AM
How do you manage Dual Tone ?
I mean, how to tint shadows and highlights with color ?
With HSV ?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 07, 2019, 07:51:48 AM
Quote from: Veerle on August 07, 2019, 12:16:05 AM
Even though Canon's native video has many faults (which is why we use Magic Lantern), it does manage to prevent/ fix certain problems in-camera. There is no black sun, light flickering or much aliasing, color fringing or chromatic aberration no matter what settings you use. Makes me wonder, how do they do it...?
Really? Do you have a different EOS M than I have? I get also in H.264 a black sun, much more aliasing than in RAW, CA's are still there, etc. ...

Quote from: Quentin on August 07, 2019, 05:17:51 AM
How do you manage Dual Tone ?
I mean, how to tint shadows and highlights with color ?
With HSV ?
I don't know what you mean with dual tone. But if you like to setup colors in dependency to brightness you could use the gradation curve tool.
(https://i.ibb.co/ckjV78b/Bildschirmfoto-2019-08-07-um-07-50-15.png)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on August 07, 2019, 08:55:08 AM
In native Adobe Camera RAW Filter, you can tint highlights with a color, you can tint shadows with a color and adjust the balance between the two.
If you double click on any adjustment it goes to default value.
Its more practical than Curves adjustment and very easy to change your mind, rathen than changing curves.
Personal taste here.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 07, 2019, 10:11:40 AM
We don't have this in MLVApp. We just have an overall tint filter, which works more or less like a optical color filter in front of a lens.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on August 07, 2019, 02:19:47 PM
Thanks for your reply. I am already excited with this App. :)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ricardopt on August 07, 2019, 07:11:44 PM
Does it look better Veerle?

https://send.firefox.com/download/8351fe8fd3965527/#C0QzA59yvEAmM4srNBu1iw
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 07, 2019, 07:37:28 PM
Cool @ricardopt
Please share your workflow.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ricardopt on August 07, 2019, 07:56:16 PM
Hi Danne, nothing new, it's a widely known solution,

1- load your video on your NLE (hitfilm, shotcut, openshot, davinci resolve etc etc)
2- duplicate your video
3- set opacity to 100% on first video
4- set opacity to 50% on the second (duplicated) video
5- offset both videos by 1 frame (video one starts at 00.00 and video 2 (duplicated) starts at 00:01)

change opacity level on step 4 to your liking, opacity might be called "transparency" on other video editors.

In the end we can sharpen thevideo a little and do some tweaking to get rid of some of the blur.

Hope it helps.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 07, 2019, 08:24:31 PM
Hehe, very nice!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on August 07, 2019, 11:49:09 PM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 08, 2019, 10:58:11 AM
Quote from: Veerle on August 07, 2019, 11:49:09 PM
Yeah, nope. No answers. Perhaps my query is wrong... Care to enlighten me or drop a link?
There's not one link to cover all the basics.  My tip is you deepen your understanding both around camera setup basics when filming and also the difference between raw and h264. Both your camera manual and the search field in here are two helping friends.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on August 08, 2019, 03:15:07 PM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 08, 2019, 03:17:25 PM
Quote from: Veerle on August 08, 2019, 03:15:07 PM
... far less moire...
LOL... sorry... no. Theoretically impossible and practically too. Might be correct if you forget to debayer, or use the simplest and worst algorithms, else: no. But if H264 is better for you, I would not recommend to use RAW (not worth the effort then).

EOSM:
H264 readout 3x5 (heavy moiree + stretched + compression artifacts)
RAW readout 3x3 (some moiree), 1x3 (no moiree), 1x1 (no moiree)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 08, 2019, 03:22:14 PM
Posted in wrong thread oops.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on August 09, 2019, 03:08:36 AM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: a1ex on August 09, 2019, 08:49:06 AM
Quote from: masc on August 08, 2019, 03:17:25 PM
EOSM:
H264 readout 3x5 (heavy moiree + stretched + compression artifacts)
RAW readout 3x3 (some moiree), 1x3 (no moiree), 1x1 (no moiree)

FWIW, H.264 on EOS M (vanilla Canon firmware) is 3x3 with column binning and line skipping, unless you record at 720p50/60.

Quote from: Veerle on August 08, 2019, 03:15:07 PM
Canons native video has no black sun, flickering and far less moire...
[....]
There is even a difference between h264 with ML and h264 without (native)...

Black sun can be caused by incorrect CMOS settings. I did not check Danne's configuration, so I don't know what tweaks he applies to H.264, if any; it's just a guess. You could do the following tests:

- disable crop_rec (in the Movie menu)
- do not load crop_rec.mo at all (this module tweaks the image readout process)
- try some build from the download page (main or experimental); I don't expect this issue to be present there.

Moire: I'm unable to reproduce the issue (mlv_dump + ufraw (https://a1ex.magiclantern.fm/bleeding-edge/raw/aliasing/veerle/M07-1948_000007.ufraw) + crop + resize to 450px, no focus pixel correction), so it must be from postprocessing. In both cases (H.264 and MLV), the readout was 3x3 with column binning / line skipping, so the aliasing should be pretty much the same.

(https://a1ex.magiclantern.fm/bleeding-edge/raw/aliasing/veerle/M07-1948_000007_450.jpg)

Flicker: known issue (https://www.magiclantern.fm/forum/index.php?topic=19300.msg207714#msg207714).
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 09, 2019, 09:04:08 AM
Quote from: a1ex on August 09, 2019, 08:49:06 AM
Black sun can be caused by incorrect CMOS settings. I did not check Danne's configuration, so I don't know what tweaks he applies to H.264...
Interesting. I apply this to all presets in crop_rec. Could it be the culprit?:
        /* all presets */
        if (is_EOSM)
        {
            /* hot/cold pixels. Usually 0x2. 0x34 to be tested */
            cmos_new[4] = 0x34;
        }


Here is a build with above tweak disabled. If possible please test if better:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_2019Aug07.EOSM2_black_sun_fix.zip

By the way. Is that flicker fix good to go, I could put in crop_rec.c? THere´s talk of a bug?

EDIT: tried the flicker fix but still flickers...
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 09, 2019, 09:40:30 AM
Tested another thing regarding flicker in with high speed shutter. When in mcm rewired mode and 24 fps in canon menu increasing shutter to around 2500 and faster, test 1/4000 flicker is very evident. If I then set 25 fps in canon menu flicker is gone. Solution for flicker free 24 fps seems to be to select 25 fps in canon menu then change reg 6014 so we get 24 fps. What makes?

Testfiles:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/canon25fpsnoflicker.MLV
https://bitbucket.org/Dannephoto/magic-lantern/downloads/canon24fpsflicker.MLV

EDIT: hehe, looking through adtg_gui I see the variying 6014 reg when canon menu is set to 24 fps. When set to 25 fps it´s only one value.


EDIT 2:
Issue fixed regarding flickering shutter for mcm rewired mode:
Commit:
https://bitbucket.org/Dannephoto/magic-lantern/commits/172284f6166b84f6996c089eb4b7b291fcb6a1b0

Build on top here:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg208959#msg208959

Black sun thingy still needs attention...
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 09, 2019, 10:51:48 AM
Quote from: a1ex on August 09, 2019, 08:49:06 AM
FWIW, H.264 on EOS M (vanilla Canon firmware) is 3x3 with column binning and line skipping, unless you record at 720p50/60.
Are you sure? In my tests moiree looked more or less identical between 3x5 readout (1736*6?? (16:9) horizontally stretched by 1.67) in MLV and standard H264(1080p). For e.g. the 5D2 I agree with what you wrote. Standard H264(1080p) on EOSM looks way worse than e.g. on 7D, but sensor has the same resolution.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 09, 2019, 11:07:07 AM
@Veerle: and where is your moiree? Can't see any... (pic=100% zoom in). And would be enough to get 1..5 frames of a scene to not load gigabytes over hours... you can easily shorten the clips with some simple clicks.
(https://i.ibb.co/M1nsMs8/Bildschirmfoto-2019-08-09-um-11-04-52.png)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: a1ex on August 09, 2019, 11:14:44 AM
Quote from: masc on August 09, 2019, 10:51:48 AM
Are you sure? In my tests moiree looked more or less identical between 3x5 readout (1736*6?? (16:9) horizontally stretched by 1.67) in MLV and standard H264(1080p). For e.g. the 5D2 I agree with what you wrote. Standard H264(1080p) on EOSM looks way worse than e.g. on 7D, but sensor has the same resolution.

Yes, I'm sure. EOS M uses 3x5 readout in standby, at 30 fps, regardless of settings in Canon menu (this is unusual about it). However, when recording H.264 at 1080p, it switches to 3x3, where it behaves like all other ML-enabled Canons other than 5D3 (i.e. column binning and line skipping).

Now, how bad the aliasing actually looks like, depends on both how strong the high-frequency details are (how sharp the focus actually is), and - to a lesser extent - on the image processing pipeline (which may be different on different camera models; currently it's a black box to me).

Feel free to do a controlled test and prove me wrong. You will need a static scene with lots of aliasing (e.g. a resolution chart or any kind of fine print), same lens, same aperture, same focus point (triple-check this one!), same exposure, same picture style settings... you know the story. You could also capture a LiveView frame in x5 and in 1080p without moving the camera (e.g. by tweaking this script (https://www.magiclantern.fm/forum/index.php?topic=9741.msg212214#msg212214)); from that pair of images, I can identify the pixel binning pattern (but I don't expect any surprises here).
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 09, 2019, 11:20:04 AM
Yes I know the story. I hope I remember at the day when I don't know what to do else... :P I think better to trust you until then :D Thanks for clarifying, a1ex!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 09, 2019, 12:11:58 PM
Both issues fixed. It was the cmos4 change that was causing it. Well, will be more cold pixels on higher iso but for now it could be taken care of in post:
cmos 4:
(https://i.postimg.cc/pTwcSLyf/Ska-rmavbild-2019-08-09-kl-11-59-52-png-scaled.png)

cmos 4 default:
(https://i.postimg.cc/9X9n7ZNJ/Ska-rmavbild-2019-08-09-kl-11-59-58-png-scaled.png)

Build posted here:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg219657#msg219657

Thanks Veerle for reports. And thanks a1ex!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 09, 2019, 12:51:16 PM
Thanks Danne. Is it possible to change that also in main build? All ML cams I have and get do the black sun since ages (5D2, 7D, EOSM, and saw it on others too). What has it to do exactly with cold pixels?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 09, 2019, 12:57:32 PM
Cmos 4 is probably something else on digic IV. I can't say what will help for other cams but I just left it alone so it runs on default now. It's maybe used on digic iv so then maybe defaulting it will help your issue too.
Regarding pixels. I reduced amount of cold pixels tweaking cmos 4 but as you see it now turns out it would affect highlight handling.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on August 09, 2019, 04:24:20 PM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 09, 2019, 08:37:32 PM
Ah right. Focus pixel fix creates interpolation artifacts on this fine structure, no matter which of the 3 interpolation methods is used. So if someone is good in writing interpolation algorithms... we'll find a place for method 4 ;)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 10, 2019, 12:24:36 PM
For everybody who knows how to compile MLVApp:
new feature! We can now mask the sharpener with a new masking slider. 0=no mask, 100=full mask. The mask detects edges, so only edges will be sharpened, but slight noise or fine structures won't be sharpend. Such a mask can look like this:
(https://user-images.githubusercontent.com/30245296/62734606-b1beae80-ba29-11e9-9b43-c93a55fcb46e.png)

And there is another new feature: AVFoundation export can be resized now. This is not really fast, but from quality side this looks not bad.

If you're able to test, please let me know if it works for you, or if you get problems with it.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 10, 2019, 01:12:09 PM
Quote from: masc on August 09, 2019, 08:37:32 PM
Ah right. Focus pixel fix creates interpolation artifacts on this fine structure, no matter which of the 3 interpolation methods is used. So if someone is good in writing interpolation algorithms... we'll find a place for method 4 ;)
Hm, this is problematic as it will probably affect overall fine texture in recordings?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 10, 2019, 01:42:53 PM
If you like to interpolate a wrong pixel with the help of surrounding pixels, and these pixels are a fine structure, you always will have it hard. Best would be to find the function in camera which eliminates the focus pixels. No idea how Canon realizes this.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 10, 2019, 03:19:45 PM
Yes, but how is chroma smooth working? Curious how they differ here.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Kharak on August 10, 2019, 04:35:05 PM
How do cr2 files from cameras with focus pixels look? where the pixels have been removed in camera, are there any artifacts in fine details?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 10, 2019, 05:03:18 PM
Quote from: Kharak on August 10, 2019, 04:35:05 PM
How do cr2 files from cameras with focus pixels look?
I never saw a cr2 with foucs pixels, so I think that does not exist.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Kharak on August 10, 2019, 06:35:21 PM
You read it wrong.

"From cameras that have focus pixels" i am very aware that you dont see the focus pixels in the cr2. I was asking if there are any artifacts in cr2 image, there where the focus pixels have been removed.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 10, 2019, 06:39:56 PM
Quote from: masc on August 10, 2019, 05:03:18 PM
I never saw a cr2 with foucs pixels, so I think that does not exist.
Check this @masc :) reply #572
https://www.magiclantern.fm/forum/index.php?topic=16054.msg207726#msg207726

Reg 8900 can reveal focus pixels in a cr2 file. Some vodooing is hiding those but seems blackboxed what. Maybe some behind the scene averaging?
Also seems different streams affects focus pixels showing or not or lesser pronounced.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on August 10, 2019, 11:25:23 PM
Hello @masc

Can we have Aspect Ratio option in exporting settings ? or as example I shot 1736x976 16:9 MLV video , in exporting settings I adjust resizing to 1920x816 to have in the end 2.35:1 Aspect Ratio but it's not working in that way it compress the height and give 16:9 video needs to be un-stretched to have the correct 16:9 same as 5x3 mode , instead of compressing the height or Binning the pixels vertically; it will be great if it works by cropping the top and bottom parts . .

So can we have it ?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 10, 2019, 11:54:11 PM
Ffmpeg can do "padding" the way described.
https://superuser.com/questions/991371/ffmpeg-scale-and-pad

Maybe options to import into different ratios could be useful like in premiere. Preselect 2.39:1 for instance?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 11, 2019, 09:40:04 AM
@theBilalFakhouri: if I understand right, you don't want to resize. You want to crop and then resize? Cropping is not realized in MLVApp, because in every NLE this is easier and better than we could ever do it (where to crop, automated moving crop, etc.). So we just rescale (and don't crop). There are presets under "Transformation", where you can auto resize 3x5, 1x3, 3x1,... and real anamorphic footage. If that is not enough, you can use export settings and stretch with that.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on August 11, 2019, 12:25:59 PM
Hi guys, quick unscientific test. Turned out saving as bmfilm and don't use camera matrix matches the most close to my ursa. Only adjusted wb and exposure once I'd imported to resolve and used the 4.6k to extended video lut.

Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on August 11, 2019, 02:01:36 PM
It's actually a lot softer than I had imagined... Bit of a shame. Ok for web viewing but jees, expected a more detailed image.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 11, 2019, 02:09:40 PM
Impressive how well it matches... and yes looks a bit softer than I would expect, but not massively. Try a shot of something object using a non wide lens (50mm+) with some bokeh in the background, it will look sharp trust me, I always remember those kind of shots looking 100000000x times better than wide shots on my 5D2.

Also how about trying the "3.5K" / crop modes?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on August 11, 2019, 02:20:36 PM
Yes im sure for tight shots it's fine. Actually though I really hoped to use the 5d for wides as it's full frame but I see that's not really an option. Maybe as a b cam for interviews, talking head shots... but unfortunately i think I may actually have to get a pocket cam to be the b cam as this isn't really sharp enough. P.s I only got 12 second record time with the crop mode. It was a bit more detailed but not worth it for the big crop in.


EDIT:

I added some sharpness to the 5d and you can see for yourselves... not too bad!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: flostro on August 11, 2019, 02:34:38 PM
Any chance of MLV App supporting legacy .raw files? It would be great to convert old uncompressed .raw files to compressed MLV to save some space.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 11, 2019, 02:37:43 PM
With Switch it's possible to convert raw to mlv. Fully automated:
https://www.magiclantern.fm/forum/index.php?topic=15108.0
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: flostro on August 11, 2019, 02:46:04 PM
But it doesn't work with Windows if I understand correctly.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 11, 2019, 04:12:29 PM
No, you´d need to borrow a mac for the conversion but then it´s done and ready.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: andy kh on August 11, 2019, 06:13:53 PM
Quote from: theBilalFakhouri on August 10, 2019, 11:25:23 PM
Hello @masc

Can we have Aspect Ratio option in exporting settings ? or as example I shot 1736x976 16:9 MLV video , in exporting settings I adjust resizing to 1920x816 to have in the end 2.35:1 Aspect Ratio but it's not working in that way it compress the height and give 16:9 video needs to be un-stretched to have the correct 16:9 same as 5x3 mode , instead of compressing the height or Binning the pixels vertically; it will be great if it works by cropping the top and bottom parts . .

So can we have it ?

already requestd ths feature by me some months back but no possitive reply so far
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 12, 2019, 03:34:48 AM
Quote from: DavidP on August 11, 2019, 02:20:36 PM
Yes im sure for tight shots it's fine. Actually though I really hoped to use the 5d for wides as it's full frame but I see that's not really an option.
I can understand your disappointment, but there is an interesting "anamorphic" full sensor (no crop) mode that you might be interested in trying: https://www.youtube.com/watch?v=7GMRgAuH5uQ

It uses full width, but height is downscaled same way as normal 1080p video. I am very interested to see how detailed it looks if you try it out.

I'm not sure how to enable this option, but Danne knows about it.

Quote from: DavidP on August 11, 2019, 02:20:36 PM
EDIT:

I added some sharpness to the 5d and you can see for yourselves... not too bad!

A surprising improvement!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: flostro on August 12, 2019, 07:25:43 PM
In the process of sorting my old MLVs I found a dangerous function in MLV App.
If you want to convert your uncompressed MLVs to compressed MLV and select the source folder as destination, it will destroy the MLV file you are trying to convert. Maybe there should be a warning or the file will just be named [filename]_1 or something.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ngemu on August 13, 2019, 04:25:31 AM
I was wondering if you could implement a way to permanently delete the origional mlv file from the session bar.  It would save a lot of time rather than having to navigate back to the sd card folder, finding the clip, and then deleting.


Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 13, 2019, 07:55:42 AM
@flostro: Yapp, this is known and true. Will think about howto implement such a warning.

@ngemu: Permanently delete could be implemented... but only without trash. So might also be dangerous, that's why I haven't done that yet.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 13, 2019, 08:18:01 AM
Quote from: masc on August 13, 2019, 07:55:42 AM
@flostro: Yapp, this is known and true. Will think about howto implement such a warning.

@ngemu: Permanently delete could be implemented... but only without trash. So might also be dangerous, that's why I haven't done that yet.
+1 for deletion routine. An idea. Is it not too hard to maybe flag rejected MLV files? They could be removed to a trash folder if it´s not possible to move directly to trash. It would speed up work by a lot imo.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 13, 2019, 01:24:43 PM
Maahh... best would indeed be using the recycle bin. For OSX I have a solution (simple as always). For Windows and Linux I'll see what I can do... unfortunately no platform independant solution exists.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 13, 2019, 01:41:15 PM
Quote from: masc on August 13, 2019, 01:24:43 PM
Maahh... best would indeed be using the recycle bin. For OSX I have a solution (simple as always). For Windows and Linux I'll see what I can do... unfortunately no platform independant solution exists.
Awesome!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 13, 2019, 02:52:01 PM
linux recyfle bin is .local/share/Trash/files
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 13, 2019, 03:22:04 PM
Quote from: Ilia3101 on August 13, 2019, 02:52:01 PM
linux recyfle bin is .local/share/Trash/files
Mostly, yes. As I read, unfortunately not always. But thanks! ;) Additionally some delete info file has to be written on Linux. :P
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 13, 2019, 09:14:32 PM
Quote from: flostro on August 12, 2019, 07:25:43 PM
In the process of sorting my old MLVs I found a dangerous function in MLV App.
If you want to convert your uncompressed MLVs to compressed MLV and select the source folder as destination, it will destroy the MLV file you are trying to convert. Maybe there should be a warning or the file will just be named [filename]_1 or something.
I added a pre-export check, and the user can decide if files will be overwritten or not. Should work for any file type, not only MLV.
(https://user-images.githubusercontent.com/30245296/62970141-181f4480-be0f-11e9-80ab-3a1a57587ce8.png)

Edit: won't work for DNG, TIFF and PNG sequences... but this should not be dangerous in any way...
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: flostro on August 13, 2019, 09:24:53 PM
Great!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on August 14, 2019, 07:12:33 PM
Any chance to add an Auto button for basic adjustments ?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 14, 2019, 07:42:47 PM
What means "basic adjustments"? I bet this definition is different for each user. For me it is different for each clip... If you like to use "your basic adjustments", you could export a receipt, and import it to all your clips (via Ctrl+A you have it with just a few clicks).
Default parameters are a basic adjustment as well... :)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on August 14, 2019, 08:14:30 PM
I mean for level histogram edges, highlights, shadows.
I dunno what is feasible.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 14, 2019, 08:59:47 PM
You mean something like the Photohop functions "Auto Color", "Auto Contrast", etc. ?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on August 15, 2019, 02:48:09 PM
Anything that may shorten the time
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 15, 2019, 03:39:24 PM
@masc
What an awesome feature:
(https://i.postimg.cc/QCrdd5qC/Ska-rmavbild-2019-08-15-kl-15-35-54-png-500px.png)

Also erase belonging mapp file automatically and this feature is then perfect...
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 15, 2019, 04:00:37 PM
Thanks, Danne. Works on OSX and Linux for now... Windows has to be done. That means I have some code but don't know yet if it works ;) Good hint with the MAPP file! :)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 15, 2019, 04:19:35 PM
@Danne: you like to try out? MAPP file is deleted too now. The best is the sound on OSX, when deleting multiple files...  muahaha. :P
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 15, 2019, 04:34:45 PM
Great stuff. All files sent to trash. Perfect!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on August 15, 2019, 05:40:58 PM
Is there any update yet that will give better color accuracy? Today I tested skintones and honestly it's all over the place :( Can't get them to match my Ursa unfortunately. Sure it's possible with a lot of playing but not in a realistic and reproducible scenario.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 15, 2019, 05:51:35 PM
Could you upload examples from another nle that you manage to match better? Also describe in what way colors are wrong? I am curious that's all.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 15, 2019, 11:11:49 PM
Interested to see. Also if you coul provide one or two MLV files for testing I would be very happy. There will be more progress on the colour very soon. I have decided to scrap BetterProcessing branch and do things more incrementally. Slow and steady (but not that slow).

Improvements cuming very soon.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Naviddabest on August 16, 2019, 03:34:35 AM
Hi guys. I just wanted to ask if there is a way to convert mlv raw to a format that has hdr video or like uses the rec2020 colour space
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 16, 2019, 03:11:48 PM
What kind of HDR video type do you want? hybrid log gamma? I can add that if you want. Gamut selection is coming (Rec2020 will be there).
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on August 16, 2019, 07:59:14 PM
How about these Ilia?

I included a colour chart shot on my ursa and another shot on the 5d mk iii. Both under the same Aputure 300d light with no modifiers so should be close to 5500k. p.s the Magic lantern raw is saved as uncompressed dng but I saved the Ursa footage as Blackmagicraw 5:1

https://drive.google.com/drive/folders/1660I8zaLNm5BmSPwpKI9lr6c3emW5RnY?usp=sharing

I still can't match them exactly :( The issue is telling resolve what colour gammut the mk iii has.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 16, 2019, 08:54:02 PM
Thank you!

Quote from: DavidP on August 16, 2019, 07:59:14 PM
I still can't match them exactly :( The issue is telling resolve what colour gammut the mk iii has.

About telling resolve what gamut mkiii has... is that when you are importing it as DNG in to resolve?

MLV App is getting a few upgrades soon, I will try my best to find info about and add blackmagic sensor gamuts as options, so you can simulate prores from the blackmagic almost 1:1 in terms of colour.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on August 16, 2019, 09:35:14 PM
No problem, anything else I can do just let me know! I also have an a7sii if its any help.

So yes when I import as a prores file with any combo of settings to Resolve I can obviously choose rec709 or Blackmagic Design but I doubt its really accurate? When I then use Resolves colour transform tool it's not even close to matching skintones from those settings. Maybe if there was a way to have prores render it as accurate 5d mk iii to rec709 or bmfilm conversion? I did also try just importing the dngs and no cigar. I can actually match it with lots of qualifying nodes but would be great if we could get an accurate prores export so Resolves transform tool could get accurate base colour for conversions :)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on August 16, 2019, 09:48:26 PM
Just to show it is possible: https://vimeo.com/354281535/c5cfe9c5cd

Graded to match but it is via individual color adjustments.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on August 16, 2019, 10:05:44 PM
Quote from: DavidP on August 16, 2019, 09:48:26 PM
Just to show it is possible

The first one looks much better. In the second one I don't like the transition between the main skin color and a green tint on the right side.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 17, 2019, 12:22:35 AM
Quote from: DavidP on August 16, 2019, 09:48:26 PM
Just to show it is possible:
...
Graded to match but it is via individual color adjustments.

Thanks for that, both look very nice. I think the second one does have a very little tinge of green in some areas of her face though (as Dymotro pointed out).

Was the BlackMagic image shot in ProRes or raw? And the 5D image, ProRes or DNG from MLV App?

Quote from: DavidP on August 16, 2019, 09:35:14 PM
I did also try just importing the dngs and no cigar. I can actually match it with lots of qualifying nodes

Hmmm sounds like Davinci resolve may not be using the colour matrices embedded in the DNG files. Though I don't have much knowledge about this area of Resolve.

Quote from: DavidP on August 16, 2019, 09:35:14 PM
Maybe if there was a way to have prores render it as accurate 5d mk iii to rec709 or bmfilm conversion?... would be great if we could get an accurate prores export so Resolves transform tool could get accurate base colour for conversions :)

This will come true very soon, I found a matrix for BMDFilm on the bmcuser forum, it is not official so not sure if it will be perfect, but should be much closer than current MLV App options. Will have this ready as an option in MLV App soon, as well as a few other gamuts.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidP on August 17, 2019, 06:13:11 AM
The green tint in the highlights is likely caused by the sun bouncing off the grass and trees to the right, then she's in a dark area.

That was dng and I manually graded. I've tried all the automatic settings to get something uniform I can easily produce but as noted earlier it doesn't work.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Naviddabest on August 17, 2019, 09:46:58 PM
Quote from: Ilia3101 on August 16, 2019, 03:11:48 PM
What kind of HDR video type do you want? hybrid log gamma? I can add that if you want. Gamut selection is coming (Rec2020 will be there).

Any kind, hdr10 maybe was just wondering if it was there. Thanks for the reply.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 17, 2019, 10:29:46 PM
Quote from: Naviddabest on August 17, 2019, 09:46:58 PM
Any kind, hdr10 maybe was just wondering if it was there. Thanks for the reply.

Okay, I looked it up, HDR10 uses the Rec2020 colour gamut and Hybrig Log Gamma transfer function. I will add HLG as an option too. It'll be possible to get HDR10 output by selecting Rec2020 and HLG - not sure how you deal with that footage later on though, somehow you'll need to make other software interpret it as HDR

Quote from: DavidP on August 17, 2019, 06:13:11 AM
The green tint in the highlights is likely caused by the sun bouncing off the grass and trees to the right, then she's in a dark area.

Ah I see. BTW do you use mac or windows? I may want to send you a test build earlier than release, for you to test if the improved BMDfilm matches better.


UPDATE: I have done most of the work of allowing selectable gamut and transfer function, see commits (https://github.com/ilia3101/MLV-App/commits/ImprovedProcessinf). We just need to do the interface and then some more refinement. Should have a release ready soon.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 18, 2019, 02:18:46 AM
A small gift to the Linux users here... MLV Stitcher

Use case: Shoot in crop mode on a tripod, move the crop window around to capture a larger area of the sensor in a few separate shots, then combine those separate shots using this little app to create a new, higher resolution MLV!

Based on MLV App code, it can import multiple MLVs, move them around, crop them, and stitch them together. Has feathering for smooth transitions, exposure adjustment and difference blending to make aligning easier.

I will not continue as there is too few real life use cases. I also used Gtkmm for the interface, painful to use crap.

Download : https://drive.google.com/file/d/19aNCQh9xdWPPA2_P2pz_GWRFNw8zc4N_/view?usp=sharing

Source code found at https://github.com/ilia3101/MLV-App/tree/master/platform/mlv_blender

(https://user-images.githubusercontent.com/23642861/63218581-d0bdee80-c155-11e9-9db2-32c7aa7bf8a9.png)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 18, 2019, 08:52:10 AM
Cool! Mac users would love this ;). Hopefully linux users find it useful and could maybe post some examples.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ngemu on August 18, 2019, 10:52:03 AM
when apply luts, selecting log type, and white balancing, does it matter what order I do these in on mlvap?

From my testing, it seems like whatever I select, everything comes out the same.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Asderq on August 18, 2019, 03:09:24 PM
Hello? guys.
Maybe someone can help me. I'v found some kind of hot pixels. "Fix bad pixeles" didn't help.
This is 0,5 speed of 1920*1080 11-8 bit raw from 5dmIII with magiclantern-crop_rec_4k.2018Jul22.5D3113 firmware.


Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 18, 2019, 04:47:38 PM
You are correct, processing internally always happens in the same order.

Quote from: Danne on August 18, 2019, 08:52:10 AM
Cool! Mac users would love this ;). Hopefully linux users find it useful and could maybe post some examples.

Anyone is welcome to have a go at compiling it, you'll need Gtkmm library, maybe homebrew will let you install it.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jpegmasterjesse on August 22, 2019, 10:04:43 PM
Some recent notes on my experience with MLV App lately.

-Would love if, when a clip ends, spacebar would restart the video by default.

-When using MLV App to preview/delete footage, it's a bit of a chore. You can't delete a video if it's open in the file browser. You have to delete it from MLVApp and then remember the title and delete it in explorer. If it's possible to delete the actual file via MLV App that'd be ideal.

-Re-sorting videos based on name/date/ect would be nice.

-Maybe a render-queue would be nice? Since you can't work/queue up additional videos while rendering, there's a video of memory and juggling involved once you've finished working on your videos. A star rating or color label system could help with this too.

-This is a long weird one. I recently acquired a fun little tool that magic lantern users might be interested in. It's called a tourbox, and it's essentially just a handful of buttons, knobs, and dials that currently is well-integrated with Photoshop but can work with any software using keyboard commands. Right now I can't really use it in MLV App because there aren't any keyboard commands to assign. If MLV App had something like Mlrawviewer had with changing color bance (4 and 6 changed blue value, 5 and 7 changed red value, ect), that could be a nice efficiency. Or more simply, if there was a "next slider" command and highlighting each slider allowed for alteration with keyboard commands (like up or down arrow), you can go down the list and use your dials to change values.

As always thanks for the wonderful App.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 22, 2019, 10:27:06 PM
Thanks for your feedback @jpegmasterjesse!

Quote from: jpegmasterjesse on August 22, 2019, 10:04:43 PM
-Would love if, when a clip ends, spacebar would restart the video by default.
Okay. Could be done somehow, I think.
Edit: done. But the clip needs to be longer than 1..2 sec, because switching the debayer algorithm to playback setting + jumping to first frame needs time, so you'll never see the first frames. It still works better using X button.
Quote from: jpegmasterjesse on August 22, 2019, 10:04:43 PM
-When using MLV App to preview/delete footage, it's a bit of a chore. You can't delete a video if it's open in the file browser. You have to delete it from MLVApp and then remember the title and delete it in explorer. If it's possible to delete the actual file via MLV App that'd be ideal.
Already done.
(https://i.postimg.cc/QCrdd5qC/Ska-rmavbild-2019-08-15-kl-15-35-54-png-500px.png)
Quote from: jpegmasterjesse on August 22, 2019, 10:04:43 PM
-Re-sorting videos based on name/date/ect would be nice.
Puh. Could be possible, but will be a hard job because of internal realization. We just see the infos from the current clip and just filenames from other clips. So there is nothing to sort but the filename - and this would work exactly one time and never again.
Quote from: jpegmasterjesse on August 22, 2019, 10:04:43 PM
-Maybe a render-queue would be nice? Since you can't work/queue up additional videos while rendering, there's a video of memory and juggling involved once you've finished working on your videos.
Unfortunately 100% impossible with current concept. We would have to rewrite the whole GUI. And even then rendering speed and export speed would drop by 50%, because we then have two tasks at the same time. So this would be extremely slow.
Quote from: jpegmasterjesse on August 22, 2019, 10:04:43 PM
A star rating or color label system could help with this too.
Yeah... myself, I would like to have that, but don't know yet how to realize it... not impossible, but I want to have it in a nice way, and we have to think on a couple of existing presentation features.
Quote from: jpegmasterjesse on August 22, 2019, 10:04:43 PM
-This is a long weird one. I recently acquired a fun little tool that magic lantern users might be interested in. It's called a tourbox, and it's essentially just a handful of buttons, knobs, and dials that currently is well-integrated with Photoshop but can work with any software using keyboard commands. Right now I can't really use it in MLV App because there aren't any keyboard commands to assign. If MLV App had something like Mlrawviewer had with changing color bance (4 and 6 changed blue value, 5 and 7 changed red value, ect), that could be a nice efficiency. Or more simply, if there was a "next slider" command and highlighting each slider allowed for alteration with keyboard commands (like up or down arrow), you can go down the list and use your dials to change values.
On Windows this should be possible with Tab and Arrow left/right, isn't it? I thought this is Qt standard functionality (at least on Windows). Edit: works.
You can't connect e.g. a mouse on this box? This thing has enough CPU power to render frames?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 23, 2019, 01:49:59 PM
Quote from: masc on August 10, 2019, 12:24:36 PM
And there is another new feature: AVFoundation export can be resized now. This is not really fast, but from quality side this looks not bad.
If you're able to test, please let me know if it works for you, or if you get problems with it.
A note for our hardworking beta testers: I got this resizing algorithm multithreaded. On a dualcore processor (tested with i5, 4 threads) rendering time (for resizing) dropped around by half. Would be nice if you could test it and tell me if it works for you too (or not).
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jpegmasterjesse on August 23, 2019, 04:18:38 PM
Quote from: masc on August 22, 2019, 10:27:06 PM

Unfortunately 100% impossible with current concept. We would have to rewrite the whole GUI. And even then rendering speed and export speed would drop by 50%, because we then have two tasks at the same time. So this would be extremely slow.

Just to be clear I wasn't thinking this would mean the app is operable during rendering. The problem I'm trying to solve is that, when working through a lot of videos, i will often think "this one is good to go" and also not want to stop editing. By the time I've mads it through all the clips, it's difficult to just grab everything you feel is "done" for a large export. So yeah, even just like an X you could tag next to the file name to help with selection would be great.

The tourbox is just a peripheral. It's a little frivolous but has led to some real efficiencies. In premiere i use a dial to jog frame by frame which I really enjoy. I'll mess around with mapping it and try to find a good preset for mlvapp.

Thanks Masc!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: The Story Board on August 23, 2019, 06:08:46 PM
First of all, just amazing software. Long time user, first time writer. I've loved the 5d with ML for years now, but your software is just manna from heaven for those of us on Mac. And for free? just crazy.

My co-workers and I have been shooting documentary footage with 5dm3+ML and a C300, and MLV App has been so useful for this project. I just have a couple relatively simple questions. (At least, I think they are simple?)

My co-workers and I have been shooting documentary footage with 5dm3+ML and a C300.

First, are there settings you recommend using in MLV App to get as close to C300 C-log3 as possible? It makes matching so much easier in the NLE.

Second, since we have been shooting SO MUCH ML Raw, I'd love to know what settings to turn on or off to make the conversion process from MLV to QT as fast as possible - essentially, I want to make unprocessed proxies as fast as possible. I use MLV App to do fine color tuning once I have my offline edit finished, but I don't need the highest quality conversion for the first steps, and I am often leaving transcodes overnight for 150-200 MLV files, and finding them still unfinished in the next morning.

So what settings would you recommend for speed of transcode, as opposed to the best quality?

Again, LOVE the software. The look I get out of the 5d is just stunning. Thank you!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 23, 2019, 08:27:25 PM
Currently you just can delete unwanted clips from session. You could also render all clips without any settings as proxy, cut with that, export a fcpxml which you import again in MLVApp. Then MLVApp only shows the used clips. FCPX and Resolve are able to export projects as fcpxml files, maybe even more programs.

If you just want to toggle through clips:
J - previous clip
K - next clip
, - previous frame
. - next frame
X - first frame
...
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on August 24, 2019, 11:45:17 PM
Nice to see you working again on gamuts @Ilia3101 !  :)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 25, 2019, 12:39:16 AM
@Luther Nice to hear from you again! This attempt is going much better, way more simple. Should be able to do a release quite soon.

Also thanks again for all the links you have sent since whenever you started. I looked back at that RawToAces github link you sent ages ago with the camera spectral data, and it is literal gold, what can be done with it is amazing. I really hope I can find such data for more cameras. In MLV App 2.0 (or whatever), we'll definitely have super accurate spectral colour correction ;)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on August 26, 2019, 02:13:53 AM
Quote from: Ilia3101 on August 25, 2019, 12:39:16 AM
@Luther Nice to hear from you again! This attempt is going much better, way more simple. Should be able to do a release quite soon.

Also thanks again for all the links you have sent since whenever you started. I looked back at that RawToAces github link you sent ages ago with the camera spectral data, and it is literal gold, what can be done with it is amazing. I really hope I can find such data for more cameras. In MLV App 2.0 (or whatever), we'll definitely have super accurate spectral colour correction ;)

You're welcome! I think the gamut feature will be great for MLVApp. Thanks for all the work on this awesome software!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 27, 2019, 06:41:49 AM
Small bug: When deleting a file from disk in mlv app the next file will not have in and out points refreshed so mlv app remembers the ins and outs from the deleted file.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 27, 2019, 08:16:27 AM
Oh no... :( hmmm. But I can't reproduce here. Could you tell me howto? I understood you have 2 files in session, and you give both any In and Out frame number. You activate the first clip, delete it and then your (now only) second clip has the In & Out from deleted first clip, right? This is what I did now, but all is as expected this way. Maybe you do it differently. Thanks for posting this!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 27, 2019, 11:05:20 AM
I´m not using the in and out points. Instead when I delete a file when it automatically goes to the next file it stills shows the frames from the deleted clip in the in and out section. Not refreshed.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 27, 2019, 11:12:10 AM
 ::) Still don't get it.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 27, 2019, 11:53:06 AM
My mistake. I didn´t double click the file I was on so Cut in & Cut out section wasn´t refreshed. Question. Could refresh happen when simply selecting a file or do we need to double tap?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 27, 2019, 12:09:26 PM
Okay. Puh. (In & Out has stolen some of my nervs in past. It is more complex than it looks like.)  ;D
Simple selecting is needed for - yes - selection... e.g. if you like to export 1st and 3rd clip, you would click on 1st, CTRL/CMD click on 3rd. That is why doubleclicking on a clip is for activating it.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on August 27, 2019, 04:27:15 PM
Quote from: masc on August 27, 2019, 12:09:26 PM
Okay. Puh. (In & Out has stolen some of my nervs in past. It is more complex than it looks like.)  ;D
;D
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: KirbyLikes525 on August 27, 2019, 08:21:14 PM
@Ilia3101, continued from the 3k thread (https://www.magiclantern.fm/forum/index.php?topic=19336.msg219904#msg219904)

Quote from: Ilia3101 on August 18, 2019, 01:43:40 AM
Hmm why does it cut off, what do you mean?

The frame capture of the comment below is 3016x1080, not the full 3968x1800 which I'm only pointing out because cDNG export gave me that exact same frame, 3016x1080, and NOT the full 3968x1800 which I only got via ProRes export without resizing to do so. So for post processing purposes, MLV App did not render the full resolution of the 4k mlv file as cDNG. The HEVC portion of my comment didn't have anything to do with the resolution.

Quote from: histor on July 26, 2019, 11:50:44 AM
Fantastic resolution! 3968x1800. Unfortunately the top right corner stays dead.
Frame difference, exaggerated
(https://i.ibb.co/XXpgsJW/2019-07-26-12-45-00.png) (https://ibb.co/0qZSMJn)
So, what was the trick? Was it fair? :)

Actual frame size:
https://imgur.com/uTBvWxk (https://imgur.com/uTBvWxk)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 27, 2019, 08:55:10 PM
Ah yes, thansks for putting it here. I think the LJ92 compression library had an issue where it stops working after a certain width (well I had this issue recently), so maybe bouncyball limited max export resolution to that, but maybe that is not the case. I removed the if statement causing that issue. It may also be caused by the metadata in that MLV being weird.

@bouncyball can you take a look at the MLV file? https://drive.google.com/file/d/17DyCmp6m20Ge0DGGr1JJOeFfnhAYanLo/view?usp=sharing

I'm not sure whats going on.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 27, 2019, 08:56:02 PM
Quote from: KirbyLikes525 on August 27, 2019, 08:21:14 PM
cDNG export gave me that exact same frame, 3016x1080, and NOT the full 3968x1800 which I only got via ProRes export without resizing to do so

Was that compressed, uncompressed or fast pass?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: KirbyLikes525 on August 27, 2019, 09:21:46 PM
Quote from: Ilia3101 on August 27, 2019, 08:56:02 PM
Was that compressed, uncompressed or fast pass?

Uncompressed
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 27, 2019, 10:27:25 PM
Quote from: KirbyLikes525 on August 27, 2019, 09:21:46 PM
Uncompressed

Hmm ok, must be something wrong with the metadata in the MLV. It was an experiment I did with https://www.magiclantern.fm/forum/index.php?topic=20025.msg219905#msg219905

I guess the MLV writing in that is not done right somehow :/

The real resolution is definitely 3968x1800 though.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: KirbyLikes525 on August 28, 2019, 02:05:25 AM
Wow, the logistics of getting one shot must be that more difficult with the stitching. How does that work with the subject moving? There was a gentle breeze in the shot and I was none the wiser to the stitching.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: extremelypoorfilmaker on August 28, 2019, 05:22:22 AM
following the thread :)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 28, 2019, 08:14:05 AM
Quote from: KirbyLikes525 on August 27, 2019, 08:21:14 PM
The frame capture of the comment below is 3016x1080, not the full 3968x1800 which I'm only pointing out because cDNG export gave me that exact same frame, 3016x1080, and NOT the full 3968x1800 which I only got via ProRes export without resizing to do so.
It also depends on the app used for importing the DNG. I use two different photo viewers, Xee and Lyn. Xee shows the wrong resolution (3016x1080) while Lyn shows the correct resolution (3968x1800) for exactly the same DNG file.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: KirbyLikes525 on August 28, 2019, 03:15:49 PM
Quote from: masc on August 28, 2019, 08:14:05 AM
It also depends on the app used for importing the DNG. I use two different photo viewers, Xee and Lyn. Xee shows the wrong resolution (3016x1080) while Lyn shows the correct resolution (3968x1800) for exactly the same DNG file.

Importing cDNG into Premiere and viewing in Adobe Camera Raw was 3016x1080 (wrong resolution)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 28, 2019, 04:28:08 PM
Importing to darktable brings correct resolution, importing to RawTherapee brings wrong resolution.  :P What ever the reason is... it is "funny".
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 28, 2019, 05:44:10 PM
Does any colour expert know if the Adobe matrices we all use in open source software are actually neutral? (by neutral I mean accurate as possible, smallest possible error). Or do they have a slight look to them?

Adobe may not want to give everyone best possible matrices maybe ? But then, just a matrix is not the ultimate solution anyway ::)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on August 29, 2019, 12:49:35 AM
Quote from: Ilia3101 on August 28, 2019, 05:44:10 PM
Does any colour expert know if the Adobe matrices we all use in open source software are actually neutral?

Not sure Ilia. @Andy600 have previously linked (https://www.magiclantern.fm/forum/index.php?topic=20677.msg192358#msg192358) to this research (http://web.archive.org/web/20190209021303/http://www.gujinwei.org/research/camspec/db.html) about camera spectral data. And here (http://web.archive.org/web/20190209025902/http://www.gujinwei.org/research/camspec/camspec_database.txt) is the actual matrices. Maybe if you put those on MLVApp and compare with the Adobe matrices you can see how close they are?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 29, 2019, 12:22:03 PM
Quote from: Luther on August 29, 2019, 12:49:35 AM
Not sure Ilia. @Andy600 have previously linked (https://www.magiclantern.fm/forum/index.php?topic=20677.msg192358#msg192358) to this research (http://web.archive.org/web/20190209021303/http://www.gujinwei.org/research/camspec/db.html) about camera spectral data. And here (http://web.archive.org/web/20190209025902/http://www.gujinwei.org/research/camspec/camspec_database.txt) is the actual matrices. Maybe if you put those on MLVApp and compare with the Adobe matrices you can see how close they are?

Wow that is a great thread. I don't know how you find all that good stuff. And turns out he's involved with rawtoaces

I have found that spectral data myself recently, but it's normalised so each channel peaks at 1.0, don't know how to deal with that.

From what andy600 says there, adobe matrices are probably very good and what I said was just a conspiracy theory.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jpegmasterjesse on August 29, 2019, 11:17:37 PM
Latest Reddeercity builds won't allow for audio export for Prores or H264 MLV example: https://drive.google.com/open?id=1vUTPgjQDzBTYYLxnagHAPi3Sb0GGeXtr
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 30, 2019, 10:30:24 AM
Downloaded your clip. Exported. Audio is included. What are your settings? Did you enable audio export?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jpegmasterjesse on August 31, 2019, 06:49:22 AM
The box was greyed out - I'll try to reproduce and let you know.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 31, 2019, 08:00:51 AM
You changed video speed using framerate override before. That's why audio can't ne exported in the same clip.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ngemu on September 01, 2019, 08:16:06 AM
would love to see in the next version a way to load multiple luts so they can be easily "scrolled through" without having to manually open the folder option each time.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 01, 2019, 09:51:14 AM
That would be cool. Just fill up like twenty lut lots into a list or so.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on September 01, 2019, 11:48:53 AM
LUTS With thumbnails of the current frame.

Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 01, 2019, 12:14:06 PM
LOL... hope you guys have some hours time to process previews...  :P
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on September 01, 2019, 12:15:13 PM
just 10 LUTs would not take hours
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 01, 2019, 12:32:13 PM
But really limiting to 10? I bet nobody would understand.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 01, 2019, 12:46:32 PM
Dynamic list? Only keep the path to selected lut files that still exists. If removed, slot become available. Limit. Idk, there could be like 50 if graphics isn't hurt.
Thumbnails, I'm fine with scrolling thru with arrow buttons one by one if possible.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 01, 2019, 06:36:07 PM
Quote from: Danne on September 01, 2019, 12:46:32 PM
Dynamic list? Only keep the path to selected lut files that still exists. If removed, slot become available.

Ah, good catch. Meaning it should be possible. Been using MLV App Compiler as of late. Such a gem!  8)

Quote from: Danne on September 01, 2019, 12:46:32 PM
Limit. Idk, there could be like 50 if graphics isn't hurt.
Thumbnails, I'm fine with scrolling thru with arrow buttons one by one if possible.

Great call actually!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 01, 2019, 06:47:44 PM
Quote from: masc on August 23, 2019, 01:49:59 PM
A note for our hardworking beta testers: I got this resizing algorithm multithreaded. On a dualcore processor (tested with i5, 4 threads) rendering time (for resizing) dropped around by half. Would be nice if you could test it and tell me if it works for you too (or not).

On it. Has anyone else notice an improvement as well or not?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on September 02, 2019, 10:37:53 PM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 03, 2019, 08:11:14 AM
Quote from: Veerle on September 02, 2019, 10:37:53 PM
I don't think this has been mentioned before, but there's a tiny bug in 1.8 regarding the export presets: they don't 'save'. Each time the app is restarted the export presets are gone...
Also: the minus button doesn't seem to do anything.
Really? What brings you to the point it does not work? Could you please describe how you try to use it? You should setup setting, press "+" (=save), rename. Selecting loads the setting. "-" deletes selected setting. Works here on 5 computers and 3 OS's.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on September 03, 2019, 09:44:04 AM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 03, 2019, 10:05:43 AM
Really strange. Works here on iMac 2011 (10.11), MBP 2013 (10.13) and MBP 2010 (10.9). Make sure to use it in the order I wrote.
There is no in-app update feature. There is just an in-app update reminder/check. You always must redownload and install manually. There is no other way.
It just would not save anything, if you always start the app from the DMG image (because it is read only). As soon as the app is installed into /Applications/ or into another folder on internal disk it should work.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on September 03, 2019, 10:37:53 AM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 03, 2019, 10:41:50 AM
Could you please record a screen video of what you are doing and of what's happening?

The app just checks for updates and leads you to the download webpage on GitHub. All other steps have to be done manually by the user.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on September 03, 2019, 11:00:58 AM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 03, 2019, 11:15:06 AM
Thank you. That is... "funny". :(
I now did exactly the same steps like you here on my MBP: no single item in the list got lost when closing the window or when closing and restarting the app. No idea how to reproduce that here.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on September 03, 2019, 11:29:55 AM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 03, 2019, 11:58:24 AM
The presets get stored into /Users/<your login name>/Library/Preferences/com.magiclantern-mlvapp.MLVApp.plist
There is a parameter which stores these dialog settings (binary format, storing is Qt realized (QSettings class)).
        <key>ExportPresets</key>
<data>
        ...
</data>


But if you delete the file, the presets are still there (at least here they are). So it seems OSX keeps them in RAM. Maybe delete + clear trash + reboot helps. When adding new presets I can see in the file how this data field grows.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 03, 2019, 06:34:56 PM
I did a huge upgrade yesterday , an AMD Ryzen 3900x CPU ,  MLVApp uses only 30% Overall when exporting  (All threads are used) , a MLV file 1736x976 @ 23.976 FPS 1:15 minute long took 3:36 minutes to export with AMAZE debayer and High H.264 preset , I am expecting about 1:20 Minute exporting time when the CPU load is 90% , if it was 100% Load --> a bit More than real-time AMAZE debayering and exporting .

I tried also previewing MLV file in MLVApp 1.0 (I can select AMAZE for preview , please get it back :D) Same clip above I got 16 FPS and with cached mode it's real-time AMAZE Wiiith 17GB of RAM Uses :D , Also AMAZE playback only uses 30% CPU , a clip ( shot on 1736x738 @23.976 FPS) has almost real-time AMAZE preview @ 20 FPS .

Of course the clips above were Lossless , but With uncompressed file (1736x976 @ 23.976 FPS 10.7 Seconds long) took 11:38 to process :D , 21 FPS playback with AMAZE (It was using 38% CPU)

So why it's limited to 30% , on i5-4210U it always was 100% :P
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 03, 2019, 06:59:31 PM
Quote from: theBilalFakhouri on September 03, 2019, 06:34:56 PM
So why it's limited to 30% , on i5-4210U it always was 100% :P
I doubt 100%, because it is impossible, if you have more than one core. Parts of the processing pipeline are single threaded, others are multithreaded (chosen debayer is a very small part of it). What you see is an average value. Exporting is always slower than previewing, because encoding needs some power too. This is realized (if ffmpeg export) by ffmpeg. So you should sum the %s of ffmpeg+MLVApp.

If you use shadows, highlights, clarity, RBF denoiser or dual iso: this is all single threaded. So if you don't use this, you'll get "higher" CPU usage.

Quote from: theBilalFakhouri on September 03, 2019, 06:34:56 PM
I tried also previewing MLV file in MLVApp 1.0 (I can select AMAZE for preview , please get it back :D)
We can do so... never thought this makes sense, because on my machines I get 0.1 .. 2fps with it  ;D
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Veerle on September 03, 2019, 10:13:27 PM
.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Francois_lune on September 03, 2019, 10:29:02 PM
Hi there,

I am new here. I digitize old Super 8 in Raw format and started to use MLV App to process the files, the software is fantastic, congratulations for this work !

Something even more fantastic would be to have an option to invert the picture "Left/Right". (Super 8  need to be inverted "Upside Down" and "Left-Right" if captured without projection). A crop option would be great as well.

I am not sure this is the right place for requests, please let me know if there is dedicated place for it that I didn't found



Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 03, 2019, 10:30:08 PM
Quote from: Veerle on September 03, 2019, 10:13:27 PM
I removed the app, deleted the plist file and cleared my RAM (using sudo purge), which did clear my presets, but unfortunately it did not fix the problem..
Sorry... tapping in the very dark here. Can't reproduce this with one single of all the computers I have access to. But I would need to reproduce it, because only then I can debug. I would need a debugger and some time on your machine  :P  what ever the difference with your system is.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 04, 2019, 07:32:27 AM
Hello all,

With this post, I would like to make a suggestion for a new feature which, if implemented in MLVApp, could be a life savior for all those users that sooner or later may end up with corrupt .MLV files that fail to open due to the "Header missing" issue.  It seems to happen quite often.

Recently, I filmed a wedding on the 5DMkIII using the Lexar Pro x1066 CF card.  Format was 10-bit LL,1360x2296 anamorphic with sound.  After the wedding, I transferred the files from the card to my laptop using a card reader and found that just a few of them would open fine in MLVApp 1.8, the remaining 68 files would fail to open due to file corruption - "Header missing" message.  MLVFS would produce an empty folder with the same name as the corrupt file itself.  A second attempt to reload the files from the card ended up with a message "Card cannot be accessed" and a prompt to format the card.  Obviously, the card was corrupt.  All I could do was ask A1ex for help and he suggested that I should use an application he wrote, called mlv_dump_bruteforce.exe, that attempts to skip invalid headers:

https://a1ex.magiclantern.fm/bleeding-edge/mlv-recover/mlv_dump_bruteforce.exe

Usage:

mlv_dump_bruteforce.exe M16-1437_Corrupt.MLV -o M16-1437_Recovered.MLV

where in this case M16-1437_Corrupt was the name of the MLV file missing its header.  This worked for me quite nicely and I was able to open the corrupt files one by one in MLVFS.  Later on, A1ex suggested the following command line:

----------------------------------------------------------------
%F in (*.MLV) do mlv_dump_bruteforce.exe %F -o R-%F
----------------------------------------------------------------

that, after placing mlv_dump_bruteforce.exe in the directory with the corrupt files, fixed all of them in a fast batch process.  Using MLVFS and DaVinci Resolve, I could work with the recovered files as usual.  This really saved my life!  Thank you so much, A1ex! Unfortunately, MLVApp still fails to open them after recovery.

So, my suggestion to the MLVApp developers is, if possible, to implement mlv_dump_bruteforce into the next version of the software.  If there are corrupt MLV files in the working directory, MLVApp should recognize them and suggest to batch recover them with the above command line.  Then it should open them and allow corrections and processing as usual. I am sure, many users that experience the same problem as described above will greatly appreciate that.

Please let me know if this is doable.  If yes, I can upload one of my corrupt files, so you can see if you can get MLVApp to recover and work with it.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on September 04, 2019, 08:33:45 AM
Quote from: IDA_ML on September 04, 2019, 07:32:27 AM
----------------------------------------------------------------
%F in (*.MLV) do mlv_dump_bruteforce.exe %F -o R-%F
----------------------------------------------------------------

For %F in (*.MLV) do mlv_dump_bruteforce.exe %F -o R-%F
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 04, 2019, 08:54:11 AM
Quote from: IDA_ML on September 04, 2019, 07:32:27 AM
Please let me know if this is doable.  If yes, I can upload one of my corrupt files, so you can see if you can get MLVApp to recover and work with it.

Should be doable. Indeed, this should be a high priority. Thanks for sharing your story @IDA_ML!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 04, 2019, 09:05:49 AM
mlv_dump_bruteforce is a program (if I understood right) and not MLVApp. So we need the information (better: code) what this program does. Then we can see if it is possible to integrate this code into MLVApp. For using a commandline it is way easier to write a batch file.

How does MLVApp fail to open those recovered files? Crash? Or messagebox? If it brings a messagebox, this will have reasons.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 04, 2019, 09:30:30 AM
Masc,

When trying to open a corrupt MLV file with MLVApp, I get the message:

"File header is missing, invalid MLV"

A1ex sent to me this link that reveals the basic idea.  I don't understand anything of it but it may be helpful to you:

https://www.magiclantern.fm/forum/index.php?topic=22822.msg206290#msg206290

Maybe, he could ellaborate more on that.

@Waler Schulz

Thanks for correcting the error in the command line code.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 04, 2019, 09:44:13 AM
Quote from: IDA_ML on September 04, 2019, 09:30:30 AM
When trying to open a corrupt MLV file with MLVApp, I get the message:
"File header is missing, invalid MLV"
Really? For the recovered file you get this? Then the recovery can't be 100% correct.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 04, 2019, 09:55:41 AM
No, I get the above message when I try to open a corrupt file.  When I do the same with a bruteforce recovered file, MLVApp crashes with the message:

"MLVApp has stopped working"

MLVFS works fine with recovered files though.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 04, 2019, 10:12:15 AM
Masc,

I have just uploaded one of my corrupt files for you to see what is going on:

https://we.tl/t-S8XJnBt4bQ
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 04, 2019, 10:28:56 AM
Quote from: IDA_ML on September 04, 2019, 09:55:41 AM
When I do the same with a bruteforce recovered file, MLVApp crashes with the message:
"MLVApp has stopped working"
This file would also be very interesting. MLVApp should never crash. So I would like to do some research here.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 04, 2019, 11:48:03 PM
Quote from: masc on September 04, 2019, 10:28:56 AM
MLVApp should never crash.

I will admit this made me chuckle :)
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on September 05, 2019, 11:43:19 AM
Is there a plan to add gamma curves for correcting or subsitute already exists ? I tinkered with luminosity but its a bit different
https://en.wikipedia.org/wiki/Gamma_correction
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 05, 2019, 11:49:27 AM
Quote from: 2blackbar on September 05, 2019, 11:43:19 AM
Is there a plan to add gamma curves for correcting or subsitute already exists ?
It already exists in the branches for better/improved processing. When it is finished completely it will be merged into master branch.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 06, 2019, 05:13:51 PM
Quote from: masc on September 05, 2019, 11:49:27 AM
When it is finished completely it will be merged into master branch.

Fantastic to hear!  :D
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on September 07, 2019, 06:00:06 PM
Great , is there a reason why were locked out of correcting a lot of sliders when changing to srgb or rec709 from tonemapped which is default ? When i enable correcting by ticking "allow creative adjustments" then footage becomes a lot darker.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 07, 2019, 06:20:08 PM
Quote from: 2blackbar on September 07, 2019, 06:00:06 PM
Great , is there a reason why were locked out of correcting a lot of sliders when changing to srgb or rec709 from tonemapped which is default ? When i enable correcting by ticking "allow creative adjustments" then footage becomes a lot darker.
Yes, there is a reason. Using curves or other adjustments won't bring correctly converted footage. But it would be needed, if you e.g. apply LUTs in your NLE. So it is disabled by default. You can enable it ("Allow creative adjustments") and see what the curves (which are normally enabled for other profiles) do with your footage. Use dark/light strength/range and lighten to adjust your footage as you like.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on September 07, 2019, 10:21:05 PM
From what i see if i enable creative adjustment and move dark strength to 0 then footage will be fine and not so dark anymore so maybe theres no need to lock eveyrhing when in BMD , just force dark strength to 0 and enable everything else.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 07, 2019, 10:42:44 PM
set dark strnegth to zero and u wont have any darkness issue, then adjust it to your liking

Quote from: masc on September 07, 2019, 06:20:08 PM
Yes, there is a reason. Using curves or other adjustments won't bring correctly converted footage. But it would be needed, if you e.g. apply LUTs in your NLE. So it is disabled by default. You can enable it ("Allow creative adjustments") and see what the curves (which are normally enabled for other profiles) do with your footage. Use dark/light strength/range and lighten to adjust your footage as you like.

I guess it is pretty rare for anyone to actually want completely accurate rec709 or sRGB footage, only with LOG spaces do people want that. Even cameras when shot in their own "rec709" modes tend to have a special curve for better highlight roll-off, and slight colour tweaks to the manufacturer's preference, so it's not truly rec709 standard. I think rec709 mode in MLV App is not that useful. Normal tonemapped mode is still rec709, just with a lighter gamma and tonemapped curve, but once you've adjusted it and made it right, it is still interpreted as rec709 by all other video software, so all MLV App output is basically rec709 footage unless you use a LOG profile.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on September 08, 2019, 06:26:03 PM
Also HSL would be nice with one more : Saturation vs. Luminance
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 08, 2019, 07:56:07 PM
Interesting @2blackbar. Thanks. You mean Luminance vs. Saturation (small difference in text, big difference in results)  ;D Always wanted to see what you can do with this, because I remember it was already asked a time ago.
Should be doable.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on September 08, 2019, 08:05:31 PM
Yeah Youre right, also this guy has a lot of interesting stuff to say about color correcting and grading in his videos, i tend to correct most of the time because i already love how tonemapped in MLVApp looks like.
Does tonemapped have gamma curve that makes it look more like film than standard or r709 ? Id like to take control of that curve myself thats why i asked about it.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 08, 2019, 08:16:25 PM
Quote from: 2blackbar on September 08, 2019, 08:05:31 PM
Does tonemapped have gamma curve that makes it look more like film than standard or r709 ? Id like to take control of that curve myself thats why i asked about it.
It has a gamma curve, yes. Some minutes ago the branch was merged to master, where you can adjust gamma as you like. For now: to be compiled.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on September 08, 2019, 08:43:59 PM
Fantastic, its getting better and better
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on September 09, 2019, 02:44:14 AM
Quote from: masc on September 08, 2019, 08:16:25 PM
It has a gamma curve, yes. Some minutes ago the branch was merged to master, where you can adjust gamma as you like. For now: to be compiled.

Hoah! I'll compile this week and do some tests!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 09, 2019, 01:26:17 PM
Very nice addition with the gamut stuff and the processing presets. Seems to work very good too.
Probably a reason for not being able to alter the set up once applied but is it possible to change curves etc and still have the starting point for example reinhardt/rec709? Right now I can allow adjustments when selecting Allow creative adjustments but this takes me to a whole new view? Gamma is changed etc. Would be nice to modify exactly from starting point.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 09, 2019, 03:58:22 PM
Quote from: Danne on September 09, 2019, 01:26:17 PMRight now I can allow adjustments when selecting Allow creative adjustments but this takes me to a whole new view? Gamma is changed etc.

It's because of the default dark strength value of 20, just set it to zero. There is no new view, no changed gamma, there's nothing going on that you can't control in MLV App (unless its a bug).

I agree that that switching moment is confusing in some profiles, I noticed yesterday. Feels a bit like rawtherapee ux. I am very strongly considering changing the default settings in MLV App, maybe having 0 dark strength by default.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 09, 2019, 04:06:45 PM
Quote from: masc on September 08, 2019, 08:16:25 PM
It has a gamma curve, yes. Some minutes ago the branch was merged to master, where you can adjust gamma as you like. For now: to be compiled.

Nice News!

Please get back AMAZE debayer for playback before releasing the next version , and Thanks !
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 09, 2019, 04:27:22 PM
Quote from: Ilia3101 on September 09, 2019, 03:58:22 PM
I agree that that switching moment is confusing in some profiles, I noticed yesterday. Feels a bit like rawtherapee ux. I am very strongly considering changing the default settings in MLV App, maybe having 0 dark strength by default.
Take your time. This feature must have taken a long time. Respect.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 09, 2019, 04:33:30 PM
Quote from: Ilia3101 on September 09, 2019, 03:58:22 PM
I am very strongly considering changing the default settings in MLV App, maybe having 0 dark strength by default.
But this would mean that importing footage would show "uglier results" by default.

Quote from: theBilalFakhouri on September 09, 2019, 04:06:45 PM
Please get back AMAZE debayer for playback before releasing the next version , and Thanks !
Adding only AMaZE makes no sense... if we add more debayers for playback, we should add all. To be done...
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 09, 2019, 04:44:16 PM
Decided I should write an explanation of the upcoming MLV App profile update, so that people can use it properly and understand what's going on inside. Instead of simply selecting a profile, you will be able to individually set "Tonemapping function", "Gamma" and "Gamut".

Here's the explanation of what each new option does, in the order they affect the image:


Basically: gamut is your gamut, and tonemapping function + gamma combined are your transfer function. And after that is done, all other MLV App settings are applied to the image.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 09, 2019, 04:45:43 PM
Quote from: masc on September 09, 2019, 04:33:30 PM
But this would mean that importing footage would show "uglier results" by default.

Could compensate by changing the default gamma to a lower value. We will need to think about it and consider what looks best. Another option is to add a button, maybe to the profile section, that resets all of the creative adjustments not to defaults, but actual zero. Accompanied by an explanation of why you may want to use this button.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 09, 2019, 04:50:10 PM
@DavidP you may wanna try the new BMDFilm profile in the new update, see if it matches your ursa better. It should do.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on September 09, 2019, 07:43:20 PM
Current default settings for film and tonemapped are the best looking IMO and id like them to stay unchanged somewhere as an option even if default look of the footage will change .
I wanted gamma to experiment and make the footage even more like film.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 09, 2019, 08:03:13 PM
Those presets will be available forever. And if I do change the defaults, I will make sure to keep it on that level of quality.

Quote from: 2blackbar on September 09, 2019, 07:43:20 PM
I wanted gamma to experiment and make the footage even more like film.

My explanation of the new settings a couple of posts up will help with such experiments.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 09, 2019, 09:07:30 PM
Quote from: theBilalFakhouri on September 09, 2019, 04:06:45 PM
Please get back AMAZE debayer for playback before releasing the next version , and Thanks !
Quote from: masc on September 09, 2019, 04:33:30 PM
Adding only AMaZE makes no sense... if we add more debayers for playback, we should add all. To be done...
Done. Additionally I added a option to prevent MLVApp from switching between viewer-debayer and playback-debayer.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on September 09, 2019, 09:53:24 PM
So, I compiled the master branch to test the gamuts. Some notes I took while testing:
- Sony S has warm tones desaturated and shifted towards yellow
- AdobeRGB gets visible chromatic noise with saturated blues
- XYZ is completely off. Now that other gamuts are implemented, is XYZ still relevant?
- ProPhoto has separation issues between the green-blue spectrum. It shifts the WB towards blue. The matrix is D55 instead of D65, maybe?
- Alexa WG seems good
- ACES seems good too, but has a WB shift towards yellow. Has the most smooth chromatic separation, but is very desaturated.

While testing the gamuts, I also noticed other stuff.
Is the denoising made before or after the sharpening? Denoising should always be before sharpening, but I'm not sure MLVApp is doing that, is it?
Also, some ideas from Rawtherapee that lack on MLVApp:
- "Flexible" curves (or "centripetal Catmull–Rom spline curve") are really useful:
http://rawpedia.rawtherapee.com/Exposure#Flexible
- Perceptual curve:
http://rawpedia.rawtherapee.com/Exposure#Perceptual
- Lab adjustments. For example, CC Curve cannot be replicated with MLVApp's HSL:
http://rawpedia.rawtherapee.com/Lab_Adjustments#CC_Curve


Overall, the new gamut offers much better colors. You can clearly see the results in saturated tones. Thanks for all the work @Ilia3101 ! And @masc too for the interface adjustments :)

Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 09, 2019, 09:58:02 PM
Quote from: Luther on September 09, 2019, 09:53:24 PM
So, I compiled the master branch to test the gamuts. Some notes I took while testing:
- Sony S has warm tones desaturated and shifted towards yellow
- AdobeRGB gets visible chromatic noise with saturated blues
- XYZ is completely off. Now that other gamuts are implemented, is XYZ still relevant?
- ProPhoto has separation issues between the green-blue spectrum. It shifts the WB towards blue. The matrix is D55 instead of D65, maybe?
- Alexa WG seems good
- ACES seems good too, but has a WB shift towards yellow. Has the most smooth chromatic separation, but is very desaturated.
Nice testing. How are you verifying/comparing correct gamuts?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on September 09, 2019, 10:39:48 PM
Quote from: Danne on September 09, 2019, 09:58:02 PM
Nice testing. How are you verifying/comparing correct gamuts?

Not very scientific, Danne. I'm using a MLV footage of a pantone (taken with 50D). My display is 99% sRGB, but I'm not sure it is accurate. Here's the pantone footage in case you want to test too:
https://we.tl/t-gA4ixpCkHx
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 09, 2019, 10:44:46 PM
I see. Thanks. Too tired here atm but might check into it another day.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: escho on September 09, 2019, 10:52:20 PM
Compiled master with openSUSE Tumbleweed. No problems.

Did a short test with a video of the International Space Station. I get better details than before out of the box :)

Debayer for playback: Does not change anything on playback. Example: If I chose none (monocrome), the playback video stays colored.

Over all: MLVApp becomes better and better. Great work ...
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 09, 2019, 11:02:31 PM
@Luther
It converts camera image to the gamut you select (accurately and correctly), and keeps it in that gamut, so the colours will of course change, as your display does not change it's gamut. All of this is because I have not added an extra conversion at the end of processing, to convert it back in to rec709 or whatever. If I had added this, it would show colours consistently when switching gamuts, but I'll add that later, in a way that keeps the code clean..., more work than it seems.

(BTW the rest of this post is not at all aimed at you Luther, it is just a rant about videotapers and their colour managment approach)

Video people have a certain approach to colour management (took me a long time to understand), and I am following that approach, which is "it's ok to interpret and display in image as a different colour space than it actually is", however they are generally unaware that that's what they do.

If you were to set Alexa Wide Gamut and Alexa Log curve in MLV App, you will get the same colour that comes out of an Alexa, as it is in the alexa colour space. This footage, now in a log colour space is not accurately displayed on any display, you must transform it first to get the colours it represents.

And this whole transforming log thing is what most video people don't seem to know about, or disregard. They think that log is "flat" and that's why it's good, which is not the correct explanation, log is good because it can store the dynamic range very efficiently, it is not a "flat look", it is math. Log spaces tend to have a wide gamut to not clip any chroma values, adding to the percieved "flat look" idea. With log, you will only be able to get the true colour values by doing a transformation to the colour space you actually need, very often rec709, and the best way to do this is, is mathematically... IDTs can be used to transform log, there are also LUTS that do it, and I know resolve and Nuke have plenty of tools to help. Meanwhile video people who are not aware of any of this, just grade the log image straight away, displaying it as rec709 and fudging with curves and tweaking until it looks right (not a good aproach imo).

But it's an approach that works, so I have decided it is valid because it is so widely used. And for video people that do know how to transform colour with IDTs and such, they will be ok too, as they will know what to do with the output.

However for people like me (and I guess luther), who want to actually grade in MLV App with a wider gamut only for the internal processing, outputting results in sRGB/rec709 just as before, this update is not everything.


also @Luther am I right in thinking you want the same as me? A wide gamut internally so that colours do not clip?


And yes, the matrix for prophoto is D50, that's why it's blue, prophoto has D50 it's white point for some reason. Maybe I should adapt it to D65 as all others. The only true solution to this RGB crap is spectral colour processing (probably not coming to MLV App until a full rewrite).


Edit: if any video experts would like to correct me on anything please do. I want to know what I'm getting wrong.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on September 09, 2019, 11:49:48 PM
Quote from: Ilia3101 on September 09, 2019, 11:02:31 PM
also @Luther am I right in thinking you want the same as me? A wide gamut internally so that colours do not clip?
You're exactly right. I agree with everything you said.
Ideally, the preview should be Rec.709 or Rec.2020 (with some box to choose between the two). The raw data is initially converted to the right gamut (such as ACES AP0 or AP1) and then the processing (curves, saturation, luts) goes in between the two convertions (ACES AP1 > Curves > Rec.2020, for example).

Quote
but I'll add that later, in a way that keeps the code clean..., more work than it seems.
We know. I find frustrating how little information there is about these color conversions too.

Quote
Maybe I should adapt it to D65 as all others.
A easier solution would be to just decrease the WB slider :P
Not elegant, but might work.

Quote
The only true solution to this RGB crap is spectral colour processing (probably not coming to MLV App until a full rewrite).
Or try to port OpenColorIO. I have no idea how would that work though.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 10, 2019, 10:51:59 AM
Quote from: Luther on September 09, 2019, 09:53:24 PM
Is the denoising made before or after the sharpening? Denoising should always be before sharpening, but I'm not sure MLVApp is doing that, is it?
Nope. I know that this would be better, but it is not possible with current realization. So better to not sharpen at all, or afterwards in NLE, if that is somehow important ;)

Quote from: Luther on September 09, 2019, 11:49:48 PM
Or try to port OpenColorIO. I have no idea how would that work though.
OpenColorIO has sooo many dependencies. Nearly none of the dependencies is currently needed. So this is really hard work to bring that to life (infrastructure only). And then the fun starts to understand what this lib does and how it works.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on September 10, 2019, 03:52:09 PM
Denoise before sharpening would require 2 passes , one to store denoised frame...
Anyway does anyone know how to get rid of that wavyflag effect when stabilizing in MLVApp ? Its like a sublte wobble of footage, like if every corner was stretched /warped a bit to stabilize it, it doesnt look good, any way to disable it so it only rotates the fotage and zooms in/out ?
I see vidstab does it, there are other stabilisators that work better with rolling shutter

Deshaker in vdub was great and i used it a lot, is it possible to merge it ?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 10, 2019, 04:09:24 PM
Quote from: 2blackbar on September 10, 2019, 03:52:09 PM
Denoise before sharpening would require 2 passes , one to store denoised frame...
That is not really the problem. The problem is, that nearly the complete processing pipeline is multithreaded, but the denoiser works only single threaded. There is a extra pipeline, just for denoising. That's why this is done in the very end of all. If we want to make it better, we need a 3rd processing pipeline... :P

Quote from: 2blackbar on September 10, 2019, 03:52:09 PM
Anyway does anyone know how to get rid of that wavyflag effect when stabilizing in MLVApp ? Its like a sublte wobble of footage, like if every corner was stretched /warped a bit to stabilize it, it doesnt look good, any way to disable it so it only rotates the fotage and zooms in/out ?
No idea what a wavyflag is. But corner-stretching and a "wobble" is the way those stabilizers work. You have the parameters in the MLVApp GUI. Search for "ffmpeg vid.stab" with google to find information what parameter has which effect.

Quote from: 2blackbar on September 10, 2019, 03:52:09 PM
Deshaker in vdub was great and i used it a lot, is it possible to merge it ?
I think no. It is done for MS Visual C++. This is mostly not compatible to what we do. But I don't find any source code.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on September 10, 2019, 09:22:35 PM
I wanted to use Your workflow with proxies and xml file but im using sony vegas, i can export 2 types of xml files , for  finalcut 7 and finalcut x but none of the xml files work in mlvapp, they show nothing.I linked the files, maybe their structure is different from xml files youre using ?
https://drive.google.com/open?id=1eSuMRESPofDNt1sCp-QWGU6Bnu-rQOD1
https://drive.google.com/open?id=1RkR_tpsloK8JUXllV1kCkqLwX0l0aSL8
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 10, 2019, 09:42:37 PM
Thanks for the files! Never had a Vegas-fcpxml file before. Indeed they are a bit different than FCPX-fcpxml files: the start-element of the clips is named differently. I wrote a quick fix. If you are able to compile, you could try it out now. Here, your fcpxml works now.
I did not paid attention to the old xml format yet.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on September 11, 2019, 12:04:53 AM
Great! I have to wait for monthly build but im super happy that you managed to make it work
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jpegmasterjesse on September 12, 2019, 12:37:05 AM
Quote from: masc on August 22, 2019, 10:27:06 PM
Thanks for your feedback @jpegmasterjesse!
Already done.
(https://i.postimg.cc/QCrdd5qC/Ska-rmavbild-2019-08-15-kl-15-35-54-png-500px.png)

Just realized, masc, that I don't actually see those options in windows. In fact, on the latest release the clips just disappear from the sidebar (not deleted in explorer).

And RE: Tabbing through all the sliders, it is possible and feels great, except there is no way to know which slider you are currently tabbed to.

Also, would it be possible to change the increments the values change in? Could Shift+LeftArrow make it move in increments of 10, for example?

Thanks for all your wonderful work.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on September 12, 2019, 03:02:29 AM
Quote from: masc on September 10, 2019, 10:51:59 AM
Nope. I know that this would be better, but it is not possible with current realization.

Got it.
I've found the perceptual curve implementation (https://github.com/Beep6581/RawTherapee/blob/dev/rtengine/curves.cc) in rawtherapee:

// this is a generic cubic spline implementation, to clean up we could probably use something already existing elsewhere
void PerceptualToneCurve::cubic_spline(const float x[], const float y[], const int len, const float out_x[], float out_y[], const int out_len)
{
    int i, j;

    float **A = (float **)malloc(2 * len * sizeof(*A));
    float *As = (float *)calloc(1, 2 * len * 2 * len * sizeof(*As));
    float *b = (float *)calloc(1, 2 * len * sizeof(*b));
    float *c = (float *)calloc(1, 2 * len * sizeof(*c));
    float *d = (float *)calloc(1, 2 * len * sizeof(*d));

    for (i = 0; i < 2 * len; i++) {
        A[i] = &As[2 * len * i];
    }

    for (i = len - 1; i > 0; i--) {
        b[i] = (y[i] - y[i - 1]) / (x[i] - x[i - 1]);
        d[i - 1] = x[i] - x[i - 1];
    }

    for (i = 1; i < len - 1; i++) {
        A[i][i] = 2 * (d[i - 1] + d[i]);

        if (i > 1) {
            A[i][i - 1] = d[i - 1];
            A[i - 1][i] = d[i - 1];
        }

        A[i][len - 1] = 6 * (b[i + 1] - b[i]);
    }

    for(i = 1; i < len - 2; i++) {
        float v = A[i + 1][i] / A[i][i];

        for(j = 1; j <= len - 1; j++) {
            A[i + 1][j] -= v * A[i][j];
        }
    }

    for(i = len - 2; i > 0; i--) {
        float acc = 0;

        for(j = i; j <= len - 2; j++) {
            acc += A[i][j] * c[j];
        }

        c[i] = (A[i][len - 1] - acc) / A[i][i];
    }

    for (i = 0; i < out_len; i++) {
        float x_out = out_x[i];
        float y_out = 0;

        for (j = 0; j < len - 1; j++) {
            if (x[j] <= x_out && x_out <= x[j + 1]) {
                float v = x_out - x[j];
                y_out = y[j] +
                        ((y[j + 1] - y[j]) / d[j] - (2 * d[j] * c[j] + c[j + 1] * d[j]) / 6) * v +
                        (c[j] * 0.5) * v * v +
                        ((c[j + 1] - c[j]) / (6 * d[j])) * v * v * v;
            }
        }

        out_y[i] = y_out;
    }

    free(A);
    free(As);
    free(b);
    free(c);
    free(d);
}

// generic function for finding minimum of f(x) in the a-b range using the interval halving method
float PerceptualToneCurve::find_minimum_interval_halving(float (*func)(float x, void *arg), void *arg, float a, float b, float tol, int nmax)
{
    float L = b - a;
    float x = (a + b) * 0.5;

    for (int i = 0; i < nmax; i++) {
        float f_x = func(x, arg);

        if ((b - a) * 0.5 < tol) {
            return x;
        }

        float x1 = a + L / 4;
        float f_x1 = func(x1, arg);

        if (f_x1 < f_x) {
            b = x;
            x = x1;
        } else {
            float x2 = b - L / 4;
            float f_x2 = func(x2, arg);

            if (f_x2 < f_x) {
                a = x;
                x = x2;
            } else {
                a = x1;
                b = x2;
            }
        }

        L = b - a;
    }

    return x;
}

struct find_tc_slope_fun_arg {
    const ToneCurve * tc;
};

float PerceptualToneCurve::find_tc_slope_fun(float k, void *arg)
{
    struct find_tc_slope_fun_arg *a = (struct find_tc_slope_fun_arg *)arg;
    float areasum = 0;
    const int steps = 10;

    for (int i = 0; i < steps; i++) {
        float x = 0.1 + ((float)i / (steps - 1)) * 0.5; // testing (sRGB) range [0.1 - 0.6], ie ignore highligths and dark shadows
        float y = CurveFactory::gamma2(a->tc->lutToneCurve[CurveFactory::igamma2(x) * 65535] / 65535.0);
        float y1 = k * x;

        if (y1 > 1) {
            y1 = 1;
        }

        areasum += (y - y1) * (y - y1); // square is a rough approx of (twice) the area, but it's fine for our purposes
    }

    return areasum;
}

float PerceptualToneCurve::get_curve_val(float x, float range[2], float lut[], size_t lut_size)
{
    float xm = (x - range[0]) / (range[1] - range[0]) * (lut_size - 1);

    if (xm <= 0) {
        return lut[0];
    }

    int idx = (int)xm;

    if (idx >= static_cast<int>(lut_size) - 1) {
        return lut[lut_size - 1];
    }

    float d = xm - (float)idx; // [0 .. 1]
    return (1.0 - d) * lut[idx] + d * lut[idx + 1];
}

// calculate a single value that represents the contrast of the tone curve
float PerceptualToneCurve::calculateToneCurveContrastValue() const
{

    // find linear y = k*x the best approximates the curve, which is the linear scaling/exposure component that does not contribute any contrast

    // Note: the analysis is made on the gamma encoded curve, as the LUT is linear we make backwards gamma to
    struct find_tc_slope_fun_arg arg = { this };
    float k = find_minimum_interval_halving(find_tc_slope_fun, &arg, 0.1, 5.0, 0.01, 20); // normally found in 8 iterations
    //fprintf(stderr, "average slope: %f\n", k);

    float maxslope = 0;
    {
        // look at midtone slope
        const float xd = 0.07;
        const float tx0[] = { 0.30, 0.35, 0.40, 0.45 }; // we only look in the midtone range

        for (size_t i = 0; i < sizeof(tx0) / sizeof(tx0[0]); i++) {
            float x0 = tx0[i] - xd;
            float y0 = CurveFactory::gamma2(lutToneCurve[CurveFactory::igamma2(x0) * 65535.f] / 65535.f) - k * x0;
            float x1 = tx0[i] + xd;
            float y1 = CurveFactory::gamma2(lutToneCurve[CurveFactory::igamma2(x1) * 65535.f] / 65535.f) - k * x1;
            float slope = 1.0 + (y1 - y0) / (x1 - x0);

            if (slope > maxslope) {
                maxslope = slope;
            }
        }

        // look at slope at (light) shadows and (dark) highlights
        float e_maxslope = 0;
        {
            const float tx[] = { 0.20, 0.25, 0.50, 0.55 }; // we only look in the midtone range

            for (size_t i = 0; i < sizeof(tx) / sizeof(tx[0]); i++) {
                float x0 = tx[i] - xd;
                float y0 = CurveFactory::gamma2(lutToneCurve[CurveFactory::igamma2(x0) * 65535.f] / 65535.f) - k * x0;
                float x1 = tx[i] + xd;
                float y1 = CurveFactory::gamma2(lutToneCurve[CurveFactory::igamma2(x1) * 65535.f] / 65535.f) - k * x1;
                float slope = 1.0 + (y1 - y0) / (x1 - x0);

                if (slope > e_maxslope) {
                    e_maxslope = slope;
                }
            }
        }
        //fprintf(stderr, "%.3f %.3f\n", maxslope, e_maxslope);
        // midtone slope is more important for contrast, but weigh in some slope from brights and darks too.
        maxslope = maxslope * 0.7 + e_maxslope * 0.3;
    }
    return maxslope;
}

void PerceptualToneCurve::BatchApply(const size_t start, const size_t end, float *rc, float *gc, float *bc, const PerceptualToneCurveState &state) const
{
    const AdobeToneCurve& adobeTC = static_cast<const AdobeToneCurve&>((const ToneCurve&) * this);

    for (size_t i = start; i < end; ++i) {
        const bool oog_r = OOG(rc[i]);
        const bool oog_g = OOG(gc[i]);
        const bool oog_b = OOG(bc[i]);

        if (oog_r && oog_g && oog_b) {
            continue;
        }
       
        float r = CLIP(rc[i]);
        float g = CLIP(gc[i]);
        float b = CLIP(bc[i]);

        if (!state.isProphoto) {
            // convert to prophoto space to make sure the same result is had regardless of working color space
            float newr = state.Working2Prophoto[0][0] * r + state.Working2Prophoto[0][1] * g + state.Working2Prophoto[0][2] * b;
            float newg = state.Working2Prophoto[1][0] * r + state.Working2Prophoto[1][1] * g + state.Working2Prophoto[1][2] * b;
            float newb = state.Working2Prophoto[2][0] * r + state.Working2Prophoto[2][1] * g + state.Working2Prophoto[2][2] * b;
            r = newr;
            g = newg;
            b = newb;
        }

        float ar = r;
        float ag = g;
        float ab = b;
        adobeTC.Apply(ar, ag, ab);

        if (ar >= 65535.f && ag >= 65535.f && ab >= 65535.f) {
            // clip fast path, will also avoid strange colours of clipped highlights
            //rc[i] = gc[i] = bc[i] = 65535.f;
            if (!oog_r) rc[i] = 65535.f;
            if (!oog_g) gc[i] = 65535.f;
            if (!oog_b) bc[i] = 65535.f;
            continue;
        }

        if (ar <= 0.f && ag <= 0.f && ab <= 0.f) {
            //rc[i] = gc[i] = bc[i] = 0;
            if (!oog_r) rc[i] = 0.f;
            if (!oog_g) gc[i] = 0.f;
            if (!oog_b) bc[i] = 0.f;
            continue;
        }

        // ProPhoto constants for luminance, that is xyz_prophoto[1][]
        constexpr float Yr = 0.2880402f;
        constexpr float Yg = 0.7118741f;
        constexpr float Yb = 0.0000857f;

        // we use the Adobe (RGB-HSV hue-stabilized) curve to decide luminance, which generally leads to a less contrasty result
        // compared to a pure luminance curve. We do this to be more compatible with the most popular curves.
        const float oldLuminance = r * Yr + g * Yg + b * Yb;
        const float newLuminance = ar * Yr + ag * Yg + ab * Yb;
        const float Lcoef = newLuminance / oldLuminance;
        r = LIM<float>(r * Lcoef, 0.f, 65535.f);
        g = LIM<float>(g * Lcoef, 0.f, 65535.f);
        b = LIM<float>(b * Lcoef, 0.f, 65535.f);

        // move to JCh so we can modulate chroma based on the global contrast-related chroma scaling factor
        float x, y, z;
        Color::Prophotoxyz(r, g, b, x, y, z);

        float J, C, h;
        Ciecam02::xyz2jch_ciecam02float( J, C, h,
                                         aw, fl,
                                         x * 0.0015259022f,  y * 0.0015259022f,  z * 0.0015259022f,
                                         xw, yw,  zw,
                                         c,  nc, pow1, nbb, ncb, cz, d);


        if (!isfinite(J) || !isfinite(C) || !isfinite(h)) {
            // this can happen for dark noise colours or colours outside human gamut. Then we just return the curve's result.
            if (!state.isProphoto) {
                float newr = state.Prophoto2Working[0][0] * r + state.Prophoto2Working[0][1] * g + state.Prophoto2Working[0][2] * b;
                float newg = state.Prophoto2Working[1][0] * r + state.Prophoto2Working[1][1] * g + state.Prophoto2Working[1][2] * b;
                float newb = state.Prophoto2Working[2][0] * r + state.Prophoto2Working[2][1] * g + state.Prophoto2Working[2][2] * b;
                r = newr;
                g = newg;
                b = newb;
            }
            if (!oog_r) rc[i] = r;
            if (!oog_g) gc[i] = g;
            if (!oog_b) bc[i] = b;

            continue;
        }

        float cmul = state.cmul_contrast; // chroma scaling factor

        // depending on color, the chroma scaling factor can be fine-tuned below

        {
            // decrease chroma scaling slightly of extremely saturated colors
            float saturated_scale_factor = 0.95f;
            constexpr float lolim = 35.f; // lower limit, below this chroma all colors will keep original chroma scaling factor
            constexpr float hilim = 60.f; // high limit, above this chroma the chroma scaling factor is multiplied with the saturated scale factor value above

            if (C < lolim) {
                // chroma is low enough, don't scale
                saturated_scale_factor = 1.f;
            } else if (C < hilim) {
                // S-curve transition between low and high limit
                float cx = (C - lolim) / (hilim - lolim); // x = [0..1], 0 at lolim, 1 at hilim

                if (cx < 0.5f) {
                    cx = 2.f * SQR(cx);
                } else {
                    cx = 1.f - 2.f * SQR(1.f - cx);
                }

                saturated_scale_factor = (1.f - cx) + saturated_scale_factor * cx;
            } else {
                // do nothing, high saturation color, keep scale factor
            }

            cmul *= saturated_scale_factor;
        }

        {
            // increase chroma scaling slightly of shadows
            float nL = Color::gamma2curve[newLuminance]; // apply gamma so we make comparison and transition with a more perceptual lightness scale
            float dark_scale_factor = 1.20f;
            //float dark_scale_factor = 1.0 + state.debug.p2 / 100.0f;
            constexpr float lolim = 0.15f;
            constexpr float hilim = 0.50f;

            if (nL < lolim) {
                // do nothing, keep scale factor
            } else if (nL < hilim) {
                // S-curve transition
                float cx = (nL - lolim) / (hilim - lolim); // x = [0..1], 0 at lolim, 1 at hilim

                if (cx < 0.5f) {
                    cx = 2.f * SQR(cx);
                } else {
                    cx = 1.f - 2.f * SQR(1 - cx);
                }

                dark_scale_factor = dark_scale_factor * (1.0f - cx) + cx;
            } else {
                dark_scale_factor = 1.f;
            }

            cmul *= dark_scale_factor;
        }

        {
            // to avoid strange CIECAM02 chroma errors on close-to-shadow-clipping colors we reduce chroma scaling towards 1.0 for black colors
            float dark_scale_factor = 1.f / cmul;
            constexpr float lolim = 4.f;
            constexpr float hilim = 7.f;

            if (J < lolim) {
                // do nothing, keep scale factor
            } else if (J < hilim) {
                // S-curve transition
                float cx = (J - lolim) / (hilim - lolim);

                if (cx < 0.5f) {
                    cx = 2.f * SQR(cx);
                } else {
                    cx = 1.f - 2.f * SQR(1 - cx);
                }

                dark_scale_factor = dark_scale_factor * (1.f - cx) + cx;
            } else {
                dark_scale_factor = 1.f;
            }

            cmul *= dark_scale_factor;
        }

        C *= cmul;

        Ciecam02::jch2xyz_ciecam02float( x, y, z,
                                         J, C, h,
                                         xw, yw,  zw,
                                         c, nc, pow1, nbb, ncb, fl, cz, d, aw );

        if (!isfinite(x) || !isfinite(y) || !isfinite(z)) {
            // can happen for colours on the rim of being outside gamut, that worked without chroma scaling but not with. Then we return only the curve's result.
            if (!state.isProphoto) {
                float newr = state.Prophoto2Working[0][0] * r + state.Prophoto2Working[0][1] * g + state.Prophoto2Working[0][2] * b;
                float newg = state.Prophoto2Working[1][0] * r + state.Prophoto2Working[1][1] * g + state.Prophoto2Working[1][2] * b;
                float newb = state.Prophoto2Working[2][0] * r + state.Prophoto2Working[2][1] * g + state.Prophoto2Working[2][2] * b;
                r = newr;
                g = newg;
                b = newb;
            }

            if (!oog_r) rc[i] = r;
            if (!oog_g) gc[i] = g;
            if (!oog_b) bc[i] = b;

            continue;
        }

        Color::xyz2Prophoto(x, y, z, r, g, b);
        r *= 655.35f;
        g *= 655.35f;
        b *= 655.35f;
        r = LIM<float>(r, 0.f, 65535.f);
        g = LIM<float>(g, 0.f, 65535.f);
        b = LIM<float>(b, 0.f, 65535.f);

        {
            // limit saturation increase in rgb space to avoid severe clipping and flattening in extreme highlights

            // we use the RGB-HSV hue-stable "Adobe" curve as reference. For S-curve contrast it increases
            // saturation greatly, but desaturates extreme highlights and thus provide a smooth transition to
            // the white point. However the desaturation effect is quite strong so we make a weighting
            const float as = Color::rgb2s(ar, ag, ab);
            const float s = Color::rgb2s(r, g, b);

            const float sat_scale = as <= 0.f ? 1.f : s / as; // saturation scale compared to Adobe curve
            float keep = 0.2f;
            constexpr float lolim = 1.00f; // only mix in the Adobe curve if we have increased saturation compared to it
            constexpr float hilim = 1.20f;

            if (sat_scale < lolim) {
                // saturation is low enough, don't desaturate
                keep = 1.f;
            } else if (sat_scale < hilim) {
                // S-curve transition
                float cx = (sat_scale - lolim) / (hilim - lolim); // x = [0..1], 0 at lolim, 1 at hilim

                if (cx < 0.5f) {
                    cx = 2.f * SQR(cx);
                } else {
                    cx = 1.f - 2.f * SQR(1 - cx);
                }

                keep = (1.f - cx) + keep * cx;
            } else {
                // do nothing, very high increase, keep minimum amount
            }

            if (keep < 1.f) {
                // mix in some of the Adobe curve result
                r = intp(keep, r, ar);
                g = intp(keep, g, ag);
                b = intp(keep, b, ab);
            }
        }

        if (!state.isProphoto) {
            float newr = state.Prophoto2Working[0][0] * r + state.Prophoto2Working[0][1] * g + state.Prophoto2Working[0][2] * b;
            float newg = state.Prophoto2Working[1][0] * r + state.Prophoto2Working[1][1] * g + state.Prophoto2Working[1][2] * b;
            float newb = state.Prophoto2Working[2][0] * r + state.Prophoto2Working[2][1] * g + state.Prophoto2Working[2][2] * b;
            r = newr;
            g = newg;
            b = newb;
        }
        if (!oog_r) rc[i] = r;
        if (!oog_g) gc[i] = g;
        if (!oog_b) bc[i] = b;
    }
}
float PerceptualToneCurve::cf_range[2];
float PerceptualToneCurve::cf[1000];
float PerceptualToneCurve::f, PerceptualToneCurve::c, PerceptualToneCurve::nc, PerceptualToneCurve::yb, PerceptualToneCurve::la, PerceptualToneCurve::xw, PerceptualToneCurve::yw, PerceptualToneCurve::zw;
float PerceptualToneCurve::n, PerceptualToneCurve::d, PerceptualToneCurve::nbb, PerceptualToneCurve::ncb, PerceptualToneCurve::cz, PerceptualToneCurve::aw, PerceptualToneCurve::wh, PerceptualToneCurve::pfl, PerceptualToneCurve::fl, PerceptualToneCurve::pow1;

void PerceptualToneCurve::init()
{

    // init ciecam02 state, used for chroma scalings
    xw = 96.42f;
    yw = 100.0f;
    zw = 82.49f;
    yb = 20;
    la = 20;
    f  = 1.00f;
    c  = 0.69f;
    nc = 1.00f;

    Ciecam02::initcam1float(yb, 1.f, f, la, xw, yw, zw, n, d, nbb, ncb,
                            cz, aw, wh, pfl, fl, c);
    pow1 = pow_F( 1.64f - pow_F( 0.29f, n ), 0.73f );

    {
        // init contrast-value-to-chroma-scaling conversion curve

        // contrast value in the left column, chroma scaling in the right. Handles for a spline.
        // Put the columns in a file (without commas) and you can plot the spline with gnuplot: "plot 'curve.txt' smooth csplines"
        // A spline can easily get overshoot issues so if you fine-tune the values here make sure that the resulting spline is smooth afterwards, by
        // plotting it for example.
        const float p[] = {
            0.60, 0.70, // lowest contrast
            0.70, 0.80,
            0.90, 0.94,
            0.99, 1.00,
            1.00, 1.00, // 1.0 (linear curve) to 1.0, no scaling
            1.07, 1.00,
            1.08, 1.00,
            1.11, 1.02,
            1.20, 1.08,
            1.30, 1.12,
            1.80, 1.20,
            2.00, 1.22  // highest contrast
        };

        const size_t in_len = sizeof(p) / sizeof(p[0]) / 2;
        float in_x[in_len];
        float in_y[in_len];

        for (size_t i = 0; i < in_len; i++) {
            in_x[i] = p[2 * i + 0];
            in_y[i] = p[2 * i + 1];
        }

        const size_t out_len = sizeof(cf) / sizeof(cf[0]);
        float out_x[out_len];

        for (size_t i = 0; i < out_len; i++) {
            out_x[i] = in_x[0] + (in_x[in_len - 1] - in_x[0]) * (float)i / (out_len - 1);
        }

        cubic_spline(in_x, in_y, in_len, out_x, cf, out_len);
        cf_range[0] = in_x[0];
        cf_range[1] = in_x[in_len - 1];
    }
}

void PerceptualToneCurve::initApplyState(PerceptualToneCurveState & state, Glib::ustring workingSpace) const
{

    // Get the curve's contrast value, and convert to a chroma scaling
    const float contrast_value = calculateToneCurveContrastValue();
    state.cmul_contrast = get_curve_val(contrast_value, cf_range, cf, sizeof(cf) / sizeof(cf[0]));
    //fprintf(stderr, "contrast value: %f => chroma scaling %f\n", contrast_value, state.cmul_contrast);



And also the Catmull curve. There's this standalone implementation (https://github.com/ejmahler/SplineLibrary/blob/master/spline_library/splines/cubic_hermite_spline.h) and the one from rawtherapee (https://github.com/Beep6581/RawTherapee/blob/dev/rtengine/diagonalcurves.cc):


/*****************************************************************************
* Catmull Rom Spline
* (https://en.wikipedia.org/wiki/Centripetal_Catmull%E2%80%93Rom_spline)
*****************************************************************************/

namespace {

inline double pow2(double x)
{
    return x*x;
}


inline double catmull_rom_tj(double ti,
                             double xi, double yi,
                             double xj, double yj)
{
    // see https://github.com/Beep6581/RawTherapee/pull/4701#issuecomment-414054187
    static constexpr double alpha = 0.375;
    return pow(sqrt(pow2(xj-xi) + pow2(yj-yi)), alpha) + ti;
}


inline void catmull_rom_spline(int n_points,
                               double p0_x, double p0_y,
                               double p1_x, double p1_y,
                               double p2_x, double p2_y,
                               double p3_x, double p3_y,
                               std::vector<double> &res_x,
                               std::vector<double> &res_y)
{
    res_x.reserve(n_points);
    res_y.reserve(n_points);

    double t0 = 0;
    double t1 = catmull_rom_tj(t0, p0_x, p0_y, p1_x, p1_y);
    double t2 = catmull_rom_tj(t1, p1_x, p1_y, p2_x, p2_y);
    double t3 = catmull_rom_tj(t2, p2_x, p2_y, p3_x, p3_y);

    double space = (t2-t1) / n_points;

    res_x.push_back(p1_x);
    res_y.push_back(p1_y);

    // special case, a segment at 0 or 1 is computed exactly
    if (p1_y == p2_y && (p1_y == 0 || p1_y == 1)) {
        for (int i = 1; i < n_points-1; ++i) {
            double t = p1_x + space * i;
            if (t >= p2_x) {
                break;
            }
            res_x.push_back(t);
            res_y.push_back(p1_y);
        }
    } else {
        for (int i = 1; i < n_points-1; ++i) {
            double t = t1 + space * i;
       
            double c = (t1 - t)/(t1 - t0);
            double d = (t - t0)/(t1 - t0);
            double A1_x = c * p0_x + d * p1_x;
            double A1_y = c * p0_y + d * p1_y;

            c = (t2 - t)/(t2 - t1);
            d = (t - t1)/(t2 - t1);
            double A2_x = c * p1_x + d * p2_x;
            double A2_y = c * p1_y + d * p2_y;

            c = (t3 - t)/(t3 - t2);
            d = (t - t2)/(t3 - t2);
            double A3_x = c * p2_x + d * p3_x;
            double A3_y = c * p2_y + d * p3_y;

            c = (t2 - t)/(t2 - t0);
            d = (t - t0)/(t2 - t0);
            double B1_x = c * A1_x + d * A2_x;
            double B1_y = c * A1_y + d * A2_y;

            c = (t3 - t)/(t3 - t1);
            d = (t - t1)/(t3 - t1);
            double B2_x = c * A2_x + d * A3_x;
            double B2_y = c * A2_y + d * A3_y;       

            c = (t2 - t)/(t2 - t1);
            d = (t - t1)/(t2 - t1);
            double C_x = c * B1_x + d * B2_x;
            double C_y = c * B1_y + d * B2_y;

            res_x.push_back(C_x);
            res_y.push_back(C_y);
        }
    }

    res_x.push_back(p2_x);
    res_y.push_back(p2_y);
}


inline void catmull_rom_reflect(double px, double py, double cx, double cy,
                                double &rx, double &ry)
{
#if 0
    double dx = px - cx;
    double dy = py - cy;
    rx = cx - dx;
    ry = cy - dy;
#else
    // see https://github.com/Beep6581/RawTherapee/pull/4701#issuecomment-414054187
    static constexpr double epsilon = 1e-5;
    double dx = px - cx;
    double dy = py - cy;
    rx = cx - dx * 0.01;
    ry = dx > epsilon ? (dy / dx) * (rx - cx) + cy : cy;
#endif   
}


void catmull_rom_chain(int n_points, int n_cp, double *x, double *y,
                       std::vector<double> &res_x, std::vector<double> &res_y)
{
    double x_first, y_first;
    double x_last, y_last;
    catmull_rom_reflect(x[1], y[1], x[0], y[0], x_first, y_first);
    catmull_rom_reflect(x[n_cp-2], y[n_cp-2], x[n_cp-1], y[n_cp-1], x_last, y_last);

    int segments = n_cp - 1;

    res_x.reserve(n_points);
    res_y.reserve(n_points);

    for (int i = 0; i < segments; ++i) {
        int n = max(int(n_points * (x[i+1] - x[i]) + 0.5), 2);
        catmull_rom_spline(
            n, i == 0 ? x_first : x[i-1], i == 0 ? y_first : y[i-1],
            x[i], y[i], x[i+1], y[i+1],
            i == segments-1 ? x_last : x[i+2],
            i == segments-1 ? y_last : y[i+2],
            res_x, res_y);
    }
}

} // namespace


void DiagonalCurve::catmull_rom_set()
{
    int n_points = max(ppn * 65, 65000);
    poly_x.clear();
    poly_y.clear();
    catmull_rom_chain(n_points, N, x, y, poly_x, poly_y);
}

/*****************************************************************************/


I've also found the L*a*b adjustments, but it's way too complex to even try to implement on MLVApp (relies on some rtengine code).
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 12, 2019, 11:22:33 AM
Quote from: jpegmasterjesse on September 12, 2019, 12:37:05 AM
Just realized, masc, that I don't actually see those options in windows. In fact, on the latest release the clips just disappear from the sidebar (not deleted in explorer).
Which revision did you compile?
Quote from: jpegmasterjesse on September 12, 2019, 12:37:05 AM
And RE: Tabbing through all the sliders, it is possible and feels great, except there is no way to know which slider you are currently tabbed to.
I agree. But I think I can't really help here. You just could compile with system theme instead of dark theme (you have to comment out 1..2 line(s) for that). If I remember right, Windows native elements show a dotted line around active elements. But the app is really ugly then...  :P
Quote from: jpegmasterjesse on September 12, 2019, 12:37:05 AM
Also, would it be possible to change the increments the values change in? Could Shift+LeftArrow make it move in increments of 10, for example?
This should work using "pg up / pg down" buttons.


@Luther: What exactly is this? You quoted my post from the post with the topic order sharpening/denoising. How is it related? Looks like it has to do with profiles somehow...
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on September 12, 2019, 12:01:57 PM
Quote from: masc on September 12, 2019, 11:22:33 AM
@Luther: What exactly is this? You quoted my post from the post with the topic order sharpening/denoising. How is it related? Looks like it has to do with profiles somehow...

Ah, sorry @masc. It was about the suggestions I gave in the post that you replied ("flexible" and perceptual curves to MLVApp). I think these are very useful, but I've only seem this on rawtherapee. Would be great if the RT code could be adapted to MLVApp. So I linked above part of this code.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 12, 2019, 12:54:27 PM
I compiled latest MLVApp from source today it's amazing thanks @masc @Ilia3101 , but noticed slower preview with same file (1736x976 11-bit lossless 23.976 FPS ) , using Bilinear debayer I got 21FPS in MLVApp 1.8 from download page and only 16FPS from the compiled version with the latest changes , using AMAZE I got 5FPS with latest changes version and 16FPS from MLVApp 1.0 , can someone confirm that slower speed ? or the problem in my compiled version maybe ?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 12, 2019, 01:13:16 PM
Are you running openmp? Mac or windows?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 12, 2019, 01:15:46 PM
Wow 16FPS amaze was possible in 1.0 really? And as of which version has it slowed down most significantly?

i would like to bring that back if possible. whats ur pc specs
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 12, 2019, 01:30:49 PM
Quote from: Danne on September 12, 2019, 01:13:16 PM
Are you running openmp? Mac or windows?
I am on Windows , How to run openmp ? I did a clean install of qt version 5.9.8 yesterday with MinGW 32 bit compiler then I opened MLVApp.pro and Pressed play button to start compiling , is there something else should I do ?

Quote from: Ilia3101 on September 12, 2019, 01:15:46 PM
Wow 16FPS amaze was possible in 1.0 really?

i would like to bring that back if possible. whats ur pc specs
Yes it's amazing :D

Quote from: theBilalFakhouri on September 03, 2019, 06:34:56 PM
I did a huge upgrade yesterday , an AMD Ryzen 3900x CPU ...

Full specs:
AMD Ryzen 3900x
Asus ROG x570 Gaming-F
64GB of RAM DDR4 3000MHz
RTX 2080 SUPER
1 TB NMVe SSD M.2
4 TB HDD


Quote from: theBilalFakhouri on September 03, 2019, 06:34:56 PM
...  MLVApp uses only 30% Overall when exporting  (All threads are used) , a MLV file 1736x976 @ 23.976 FPS 1:15 minute long took 3:36 minutes to export with AMAZE debayer and High H.264 preset , I am expecting about 1:20 Minute exporting time when the CPU load is 90% , if it was 100% Load --> a bit More than real-time AMAZE debayering and exporting .

I tried also previewing MLV file in MLVApp 1.0 (I can select AMAZE for preview , please get it back :D) Same clip above I got 16 FPS and with cached mode it's real-time AMAZE Wiiith 17GB of RAM Uses :D , Also AMAZE playback only uses 30% CPU , a clip ( shot on 1736x738 @23.976 FPS) has almost real-time AMAZE preview @ 20 FPS .

Of course the clips above were Lossless , but With uncompressed file (1736x976 @ 23.976 FPS 10.7 Seconds long) took 11.38 Seconds to process :D , 21 FPS playback with AMAZE (It was using 38% CPU)

So why it's limited to 30% , on i5-4210U it always was 100% :P
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 12, 2019, 01:38:16 PM
Quote from: Ilia3101 on September 12, 2019, 01:15:46 PM
i would like to bring that back if possible.
Quote from: masc on September 09, 2019, 09:07:30 PM
Done. Additionally I added a option to prevent MLVApp from switching between viewer-debayer and playback-debayer.

@masc did it already - Thanks @masc

Quote from: Ilia3101 on September 12, 2019, 01:15:46 PM
And as of which version has it slowed down most significantly?

I compiled MLVApp today with latest changes , it was slow overall for playback (That's what I tested) , I think MLVApp 1.8 from download page also have same playback speed as MLVApp 1.0 with AMAZE debayer  but we couldn't select AMAZE as Playback since MLVApp 1.1 or 1.2
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 12, 2019, 01:44:40 PM
@bilal thanks.

Maybe the new scaling has something to do with speed? @masc
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 12, 2019, 02:21:48 PM
Quote from: Ilia3101 on September 12, 2019, 01:44:40 PM
Maybe the new scaling has something to do with speed? @masc
If it is used (e.g. clip has to be stretched), yes, if not, then not - depends on the opened file. But you can switch it off from Playback menu.
Here I get between v1.1 and latest revision: 15 vs 13 fps (bilinear) and 4 vs 3 fps (AMaZE), for a 1856x1044 file on a i5 dual core OSX. I get the same numbers for same versions and clip on i7 running Windows. But I think that is okay, if you see how much more functions need to be calculated in latest revision vs. 1.1.

Quote from: theBilalFakhouri on September 12, 2019, 01:30:49 PM
I am on Windows , How to run openmp ?
MinGW should bring automatically openMP on Windows.

Did you run "AMaZE cached" in v1.0?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 12, 2019, 03:18:44 PM
I think speed improvement will be one of next things on my list.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 12, 2019, 04:00:57 PM
Quote from: masc on September 12, 2019, 02:21:48 PM
If it is used, yes, if not, then not - depends on the opened file.

If you mean "Better resizer for Viewer" It doesn't affect the performance for me in both cases (ON/OFF) .

Quote from: masc on September 12, 2019, 02:21:48 PM
Did you run AMaZE cached in v1.0?

I got real-time Playback when AMaZE cached selected , and 16FPS when using AMaZE only .



Forget about AMaZE right now and MLVApp 1.0 ,

Using Bilinear debayer:
1- MLVApp 1.8 from download page gives 21 FPS playback
2- a compiled version of MLVApp 1.8 with latest changes "Master branch" gives only 16 FPS , Same settings same file same everything  (The new changes made it slower ? ) , could try to playback a file and see is there a difference in playback speed between MLVApp 1.8 from download page and a compiled version with the latest changes ?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 12, 2019, 04:25:42 PM
From v1.8 to current revision I don't see any speed difference here, at least with default settings.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 12, 2019, 04:51:55 PM
Okay now it's working as it should work :D maybe the problem was when compiling , Bilinear is giving now 21 FPS with latest changes , but AMaZE is only giving 6 FPS playback , in MLVApp 1.0 it's 16 FPS with no cached version used.

Anyway I will wait for the new release to do more tests.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 12, 2019, 08:30:44 PM
I agree with all of your test result, because it is more or less the same I see here on my iMac2011... but 16fps for AMaZE (uncached) - I never saw this, no matter what version or computer or OS. And I can't imagine how AMaZE can be so fast, because the realization did not change.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 12, 2019, 08:40:42 PM
Trying to delete mlv files from the session bar and keep getting this:
(https://i.postimg.cc/Bbxbky2k/Ska-rmavbild-2019-09-12-kl-20-36-54-png-scaled.png)

(https://i.postimg.cc/50Q6qjyx/Ska-rmavbild-2019-09-12-kl-20-36-46-png-scaled.png)


EDIT: Think it´s because of character "ö". Could you check for å,ä,ö?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 12, 2019, 09:14:30 PM
Thanks Danne. Reproduced. Will have a look.

Edit: fixed.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MagicPhotoEvents on September 13, 2019, 09:00:45 AM
Hello,

I have installed MLVApp on my Ubuntu 18.04 computer:
Linux version 4.15.0-58-generic (buildd@lcy01-amd64-013) (gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1)) #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019

The MLVApp launch then I choose the "Import MLV" command from the "File" submenu.

When I have choose the mlv video file and I clic on the "Open" bouton of the dialog, I have the error:
(mlvapp:7147): Gtk-WARNING **: 08:53:36.023: Theme file for DMZ-Black has no directories
Gtk-Message: 08:53:36.149: GtkDialog mapped without a transient parent. This is discouraged.
Instruction non permise (core dumped)

Can somebody help me please ?

Thank's for your help

Olivier
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 13, 2019, 09:46:05 AM
Quote from: masc on September 12, 2019, 09:14:30 PM
Thanks Danne. Reproduced. Will have a look.

Edit: fixed.
Great!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 13, 2019, 10:53:56 AM
More Tests:
I used MLVApp 1.0 & 1.8 versions from download page:

Same Clip , Same settings , Exporting to Apple Prores 444 , 30 Seconds Clip , 23.976 FPS , 1736x976 , 14-bit Lossless

MLVApp 1.0 :
Bilinear Exporting took 28 Seconds
AMaZE Exporting took 42 Seconds  (was Using 60% CPU)

MLVApp 1.8:
Bilinear Exporting took 36 Seconds
AMaZE Exporting took 1:23 Minutes (was Using 34% CPU)

**Dual ISO , 6 Seconds Clip , 1736x868 , 14-bit Lossless , 23.976 FPS , Exporting to Apple Prores 444:
MLVApp 1.0 : AMaZE Exporting took 31 Seconds     (was Using 46% CPU)
MLVApp 1.8 : AMaZE Exporting took 1:28 Minutes   (was Using 9% CPU)
It's okay for Dual ISO I remember some problems happened when we were using openmp for Dual ISO and after then bouncyball disabled it from source. **

If your system was always 100% CPU in both MLVApp versions I don't think you will see a difference , you need a faster CPU than MLVApp needs for these versions , we should look back at what made MLVApp slower :( (Color Matrices doesn't affect the performance)

I will try the other versions of MLVApp to find out what the exact version the slow appeared . .

Edit:
MLVApp 1.4 Okay not affected
MLVApp 1.6 Okay not affected
MLVApp 1.7 Okay not affected : Same 30 Seconds clip above : AMaZE Exporting took 42 Seconds (was Using 60% CPU) :D

The slow speed happened in the last release only which is 1.8 (bad commit affected the speed ? ) , switching back to 1.7 for the speed :P (I think MLVApp 1.7 will give 16 FPS AMaZE playback in my case , @masc I will shot a video MLVApp showing 16 FPS AMaZE without caching).
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 13, 2019, 11:09:25 AM
Quote from: theBilalFakhouri on September 13, 2019, 10:53:56 AM
Same Clip , Same settings , Exporting to Apple Prores 444 , 30 Seconds Clip , 23.976 FPS , 1736x976 , 14-bit Lossless
Could be related to apple prores. Did you test ffmpeg kostya or similar? There were a few updates around scaling and export(multithreading?) concerning apple prores specifically.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 13, 2019, 11:20:10 AM
Can you share your settings (receipt)? If you e.g. used Clarity / Highlights / Shadows I know what is going on (but this came in 1.7) ;) AMaZE is so a little part in the overall system, it won't depend on just this. AMaZE itself always uses 100%. So if you see low values here, another processing part is pulling it down. This only can be a single-threaded algorithm.

Quote@masc I will shot a video MLVApp showing 16 FPS AMaZE without caching)
If you rechecked, no need for it ;) I trust you...
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 13, 2019, 11:21:43 AM
Quote from: Danne on September 13, 2019, 11:09:25 AM
Could be related to apple prores. Did you test ffmpeg kostya or similar? There were a few updates around scaling and export(multithreading?) concerning apple prores specifically.

I don't think it's related , I used ffmpeg kostya in all cases for Prores 444 , using ffmpeg Anatolyi gives the same results . .

Tried to exporting to H.264 High preset .mov same 30 seconds clip:
MLVApp 1.7 : took 43 Seconds 50% CPU
MLVApp 1.8 : took 1:22 Minuets 28% CPU
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 13, 2019, 11:30:47 AM
@MagicPhotoEvents: looks like a linux theme problem. Have you modded your Ubuntu somehow? Never seen this, but
(mlvapp:7147): Gtk-WARNING **: 08:53:36.023: Theme file for DMZ-Black has no directories
Gtk-Message: 08:53:36.149: GtkDialog mapped without a transient parent. This is discouraged.

makes me think so. Does the official release (AppImage) create the same error?
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 13, 2019, 12:09:17 PM
Quote from: masc on September 13, 2019, 11:20:10 AM
Can you share your settings (receipt)? If you e.g. used Clarity / Highlights / Shadows I know what is going on (but this came in 1.7) ;) AMaZE is so a little part in the overall system, it won't depend on just this. AMaZE itself always uses 100%. So if you see low values here, another processing part is pulling it down. This only can be a single-threaded algorithm.

https://www.youtube.com/watch?v=LNQM9S1mUwE

From the description:
"
MLVApp 1.8 Export started at 1:02 and Ended in 2:25
It took 1 Minute and 23 Seconds

MLVApp 1.7 Export started at 3:34 and Ended in 4:17
it took 43 Seconds
"

Quote from: masc on September 13, 2019, 11:20:10 AM
If you rechecked, no need for it ;) I trust you...

Thanks , I have Teamviewer if you want :P
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 13, 2019, 01:20:10 PM
Thank you, theBilalFakhouri. So you just used default settings. If (with same settings) bilinear brings 100% CPU usage and AMaZE does not, you're right: it can only be something related to debayer algorithms.
And I think I found it. The only thing changed between 1.7 and 1.8 in terms of debayer was wb-conversion for AMaZE, IGV, AHD and LMMSE. These algorithms became slow while others stayed fast. When watching these two wb-conversion functions, there is an openMP call per function. I exchanged it and got 100% CPU usage instead of 51% on Windows on an i7. I'll do some more tests later and will commit then. Having just 2 or 4 threads the difference is close to 0, while having 8 threads (and surely more) it gets visible.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 13, 2019, 01:29:13 PM
Quote from: masc on September 13, 2019, 01:20:10 PM
So you just used default settings.

Oh yess that's what I was trying to tell with "Same settings" , I will wait for your next commit , Thanks!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 13, 2019, 01:48:50 PM
Quote from: masc on September 13, 2019, 01:20:10 PM
If (with same settings) bilinear brings 100% CPU usage and AMaZE does not, you're right: it can only be something related to debayer algorithms.

Yeah Bilinear Exporting gives 37 Seconds in both versions and with 90% CPU usage in my system .
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 13, 2019, 09:51:47 PM
You can try out now. Commited.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 13, 2019, 10:16:57 PM
Quote from: masc on September 13, 2019, 09:51:47 PM
You can try out now. Commited.

It's Working great , Now I can get 14 FPS AMaZE playback , and the clip took 45 Seconds for exporting , Awesome , Reinhard 3/5 is really nice too , it should be as default setting , great work!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: rev787 on September 15, 2019, 08:20:55 AM
When using Fix Focus Dots with dual iso, there's slight color shift, eventually causing flicker. I'm on 1.8. Shall I use chroma smooth instead of fix focus dots when dealing with dual iso files?
sample mlv: https://mega.nz/#!tt4zgKwQ!yfkUgUorBx_ueCxnXy1G28VaLQ75UMj0di3s4JFYaGQ (https://mega.nz/#!tt4zgKwQ!yfkUgUorBx_ueCxnXy1G28VaLQ75UMj0di3s4JFYaGQ)
EOS M 2.5k, Sep 13 build. The first frame has stronger color shift.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 15, 2019, 09:56:39 AM
Yepp... have seen this color shift since a very long time. One of the reasons why I mostly don't like to use chroma smooth. If someone knows how this algorithm works... maybe there is some small bug or it is the way it has to look - I have no idea. All I found: when using chroma smooth, set RAW black level +1 or -1 to default value and the shift disappears.
For topic focus pixels: better using a correct map instead of blurring the whole picture with chroma smooth. Chroma smooth is kind of "last resort" if nothing else helps.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 17, 2019, 08:44:02 PM
Quote from: masc on September 15, 2019, 09:56:39 AM
Yepp... have seen this color shift since a very long time. One of the reasons why I mostly don't like to use chroma smooth. If someone knows how this algorithm works... maybe there is some small bug or it is the way it has to look

Agreed. It's been a while that we have seen one without the flickering. I just tried this the other day (http://vimeo.com/360117205/settingsthis%20the%20other%20day) and can confirm the mild flickering. No deal breaker though as long as you don't push them too hard in post.

Quote from: masc on September 15, 2019, 09:56:39 AM
- I have no idea. All I found: when using chroma smooth, set RAW black level +1 or -1 to default value and the shift disappears.

Ah, good to know. I will definitely try this trick out. Thanks for sharing!


Quote from: masc on September 15, 2019, 09:56:39 AM
For topic focus pixels: better using a correct map instead of blurring the whole picture with chroma smooth. Chroma smooth is kind of "last resort" if nothing else helps.

Absolutely. Avoid CS whenever possible unless needed. As we should.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 17, 2019, 09:03:41 PM
Hehe, your wife is a goid dancer deafeyejedi :).
Cs 3x3. Nothing wrong with sharpness there. Slight color shift though towards green.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 17, 2019, 09:30:35 PM
Quote from: Danne on September 17, 2019, 09:03:41 PM
Cs 3x3. Nothing wrong with sharpness there. Slight color shift though towards green.
Sharpness is little less, especially with 1080p footage. For the green color shift try out RAW black level... +-1 fixes this - whyever.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 17, 2019, 09:58:09 PM
Hm, I think the reduced bitdepth is causing it to become greener. 14bit seems handling this issue better.
Changing black level don´t really work over here.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 18, 2019, 11:37:58 AM
How MLVApp exporting works is by processing frame 1 then frame 2 then frame 3 . . . to the last frame , can we export multiple frames in the same time (in this case every core or maybe thread will work on one frame)  to speed up the process a lot more ? a.k.a Multiprocessing,

Yesterday I was looking for solutions to speed Up After Effects rendering (After Effects isn't getting benefits from all cores and threads it's only use one core heavily and all the other cores are very close to idle ) , the solution was a tool and script called Render Boss the way how it works is by exporting multiple frames in the same time into a (e.g. png sequence) , every frame uses a core , if core 1 is working on exporting frame 1 , the core 2 will skip frame 1 and will work on frame 2 . . etc , we can't export .mov directly in this way , first of all we should export as sequence to know which frame is exporting now and skip it and work on another frame on another core , then if we want single video we take these sequence and process it to a .mov file .

Let's say I have MLV clip with 1000 Frames:
Now I can test this in MLVApp , it's like opening MLVApp multiple times (Let's say 2 MLVApps are running) and splitting the chosen MLV file to 2 copies , every copy have 500 Frames (I used cut In & Cut Out) first MLV now have the first 500 Frames from the original one , second MLV have the frames from 501 to 1000 and so on . .

Results:
Exporting original 1000 Frames MLV file in one running MLVApp took 1 Minute               (CPU was 59%)
Exporting splitted 500 Frames for each MLV file running into 2 MLVApp took 43 Seconds (CPU was 97%)
I was exporting to Prores 444 (FFmpeg encoding was working) , Not really bad and maybe there is a room for getting better results if that was originally in single MLVApp (or if encode these frames after processing all of it).

Processing Dual ISO in my system takes 5% CPU exporting to CinemaDNG (1280x1920 clip) , I can run 20 MLVApps to get 100% CPU (I tried 6 MLVApps and it was 30% CPU , 6 times faster) , so it will be x20 Faster Dual ISO if it was 20 MLVApps are running . Same for Shadows/Highlights it was uses 15% in single MLVApp (without ffmpeg encoding) , with Multiprocessing it will be x5 to x6 faster on my system.

It's very big deal !

Try it on your system if the CPU wasn't 100% when exporting , you don't have to split MLV file , just set cut In & Cut Out points (the first MLVApp set it from frame 1 to 250 , the second MLVApp set it from frame 251 to frame 500 and so on depending on your MLV clip then start exporting for each MLVApp with same settings).
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 18, 2019, 12:08:18 PM
This idea is so old as MLVApp itself. One of the very first versions was working this way. Then we decided to render a frame with multiple threads - as far as possible. Both strategies will fight against each other in terms of CPU power, and will partially lock themselfs when being called from one app. This is why the "multiple frames at one time" strategy was removed. There were many thoughts behind that. I can't and won't write down all that again. You'll find it here in the thread and on github (about 1.5 years ago).

The advantage of the current strategy is fast(er) playback. The disadvantage is, that if a algorithm (part of processing pipeline) can only be rendered single threaded, you'll waste your power. We know that. The current Dual-ISO algorithm is just single threaded. If someone likes, you're welcome to implement a multi-threaded version of it. When we tried in past, we failed.

If it helps having multiple instances of MLVApp, this is by far the easiest way to minimize the rendering time. All other solution would mean to re-implement processing and piping nealry from scratch.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 18, 2019, 12:53:20 PM
Quote from: theBilalFakhouri on September 18, 2019, 11:37:58 AM
Yesterday I was looking for solutions to speed Up After Effects rendering (After Effects isn't getting benefits from all cores and threads it's only use one core heavily and all the other cores are very close to idle ) , the solution was a tool and script called Render Boss the way how it works is by exporting multiple frames in the same time into a (e.g. png sequence) , every frame uses a core , if core 1 is working on exporting frame 1 , the core 2 will skip frame 1 and will work on frame 2 . . etc , we can't export .mov directly in this way , first of all we should export as sequence to know which frame is exporting now and skip it and work on another frame on another core , then if we want single video we take these sequence and process it to a .mov file .
aerender is included with after effects and it´s quite interesting that you can build more efficient workflows with this than running from gui. But I guess architecture in ae isn´t flexible enough to work more efficiently. In mac based Switch I do multiprocessing(four exports) in parallell going through aerender working with a base ae project template. This make exports worth the time in ae whereas the one by one export from gui way to slow.
Off topic  :P
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 18, 2019, 03:38:58 PM
@masc

So my ideas were stolen before I thought about it for the last 1.5 years ago :P

Isn't it easier to run second MLVApp in Background and make communication between the Main MLVApp and the Background copies (Instead of doing it manually in my case , I mean split the work between MLVApps copies from XX frame to XX frame) ? for good Multiprocessing and Multithreading at the same time without re-coding algorithms , Or you just want good algorithms for these things for not complicate the things more ? Not sure I am not a coder.

Another Question about only single threaded stages in the pipeline , These single threaded stages must be single threaded ? or more knowledge required to get it working multithreaded properly ? . .
Thanks

Quote from: Danne link=topic=200quote author=Danne link=topic=20025.msg220704#msg220704 date=1568804000]
In mac based Switch I do multiprocessing(four exports) in parallell going through aerender working with a base ae project template. This make exports worth the time in ae whereas the one by one export from gui way to slow.

Aha , Cool things :D I will take a look about aerender

Quote from: Danne on September 18, 2019, 12:53:20 PM
Off topic  :P
We should stop talking here :P
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 18, 2019, 04:26:54 PM
Quote from: theBilalFakhouri on September 18, 2019, 03:38:58 PM
Isn't it easier to run second MLVApp in Background and make communication between the Main MLVApp and the Background copies (Instead of doing it manually in my case , I mean split the work between MLVApps copies from XX frame to XX frame) ? for good Multiprocessing and Multithreading at the same time without re-coding algorithms , Or you just want good algorithms for these things for not complicate the things more ? Not sure I am not a coder.
This is more or less what we did in past. Not with MLVApp copies, but with copies of pipelines. Partially you must allow access only to one single pipeline to certain memory spaces (e.g. file reading, parameter settings,...), so you'll have to lock and unlock some sections, this makes the game very difficult. Hard to explain in an easy way for non-SW-developpers. It is way easier if the user runs multiple instances of a program manually.

Quote from: theBilalFakhouri on September 18, 2019, 03:38:58 PM
Another Question about only single threaded stages in the pipeline , These single threaded stages must be single threaded ? or more knowledge required to get it working multithreaded properly ? . .
These are algorithms implemented for being single threaded. Examples are Dual-ISO, Recursive Bilateral Filter "RBF" (for highlights, shadows, clarity and denoiser). Maybe it is possible to get it multithreaded somehow - but not with our existing code. So someone should understand how that has to work and write a own multithreaded implementation.

Edit: especially for the RBF filter it would bring a lot of speed. I found this algorithm here: https://github.com/Fig1024/OP_RBF There are ways for getting it faster (see diagrams). Problem: the algorithm is for RGB24 (3x8bit) by standard. With some effort I managed to get it to RGB48 (3x16bit) with some changes in the code. But this luck I just had for the simplest "standard/original implementation", not for the SSE and AVX versions. And - really - I have no idea at all how that works.
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 18, 2019, 06:28:01 PM
Quite frankly, I've tried running MLV Apps (in multiple copies) in the past and utilize them all to try to save the extra 20-30+ minutes or so. CPU was definitely up there.

But man, I could literally cook fried eggs on the Mac while it was singing its' praises.  It should be an user's choice rather than MLV App's default. :o

Quote from: Danne on September 18, 2019, 12:53:20 PM
..In mac based Switch I do multiprocessing(four exports) in parallel going through aerender working with a base ae project template. This makes exports worth the time in ae whereas the one by one export from gui way to slow
Off topic  :P

Ah, thee good ole' days of Switch. Such fond memories and yet I still use it for Dual-ISO CR2's, DF averaging on MLV's (I still can't figure out how to use the DF feature on this app) :-\

Anyway, I've just compiled v1.9 on my OSX. I will give this one a test run. Thanks, @Ilia3101 & @masc for the updates as usual!
Title: Re: MLV App 1.8 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 18, 2019, 08:51:02 PM
For all users who were waiting for so long... v1.9 is out:
- Processing upgrade: tonemapping function, gamut and gamma can now be set individually
- Log profiles now have correct gamuts, in addition to the curve. Can match your Alexa very accurately.
- Added multithreaded AVIR rescaling for AVFoundation export, single frame PNG export and viewer
- Added sharpen mask slider (sharpen just edges)
- Added "move to trash" for MLV clips + MAPP files in session
- Added a dialog which shows all installed and the currently used focus pixel map(s)
- Added a new tonemap function "Reinhard 3/5"
- Space button on last frame starts playback from beginning
- Some bug fixes and some minor changes
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 18, 2019, 09:49:22 PM
yay!

Link: https://github.com/ilia3101/MLV-App/releases/tag/QTv1.9
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ZEEK on September 18, 2019, 11:23:12 PM
Thank you guys heaps! Appreciate the work put into this 👌
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 18, 2019, 11:59:00 PM
Sound playback isn't working in MLVApp 1.9 unfortunately on Windows (I tried both 32 & 64 bit) , maybe there is a problem with compiling
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on September 19, 2019, 07:53:24 AM
Awesome work!
I feel that I own a film laboratory :D
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 19, 2019, 08:08:31 AM
Thanks guys.

Quote from: theBilalFakhouri on September 18, 2019, 11:59:00 PM
Sound playback isn't working in MLVApp 1.9 unfortunately on Windows (I tried both 32 & 64 bit) , maybe there is a problem with compiling
Sound works fine over here on both Win versions. Have you enabled output? We changed absolutely nothing for sound playback, toolchain for Win32 version is also identical to v1.8.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jimiz on September 19, 2019, 11:12:20 AM
win7 (64) 
with 1.9 x32 work good
with 1.9 x64  any MLV import, no video compare..and crash program... (long last 1.8 was all ok)

Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 19, 2019, 11:21:01 AM
Quote from: jimiz on September 19, 2019, 11:12:20 AM
win7 (64) 
with 1.9 x64  any MLV import, no video compare..and crash program... (long last 1.8 was all ok)
Could you uplaod a short MLV sample? Can't get any crash here. What do you mean with "video compare"?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jimiz on September 19, 2019, 11:56:15 AM
with ANY   MLV...also what you found here in this topic ....
program start and seem working, you select on menu Import mlv....and 2 seconds later program crash and close.
no video" compare":   in this 2 seconds no video appears  !!!

same MLV with 32bit version,  work with any problem.

the 1.8 and earlier (x64) works!
I'v see that this time with the 1.9 there are a lot of new files inside program DIR ... meaby i need something extra on my WIN7 be installed?  drivers and video they are all up to date



Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Cipolippo on September 19, 2019, 12:23:04 PM
win10 (64) 
Mlv app 1.9 (64bit) Crash  ??? ;)

Mlv app 1.9 (32bit) works
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 19, 2019, 12:52:35 PM
Sorry guys. Can't reproduce. All works fine here with Win64 version. No idea where to search. No additional lib or driver is required. Just Windows.
Before we had a "static" version, which included all those files in the exe. This somehow doesn't work anymore. So we had to find a new toolchain for 64bit, which links dynamic now. So you have all the dll files now.

Quote from: Cipolippo on September 19, 2019, 12:23:04 PM
win10 (64) 
Mlv app 1.9 (64bit) Crash  ??? ;)

Mlv app 1.9 (32bit) works
And how do you get it crashed? The same way as jimiz? Some more info would be helpful.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 19, 2019, 02:45:35 PM
Quote from: masc on September 19, 2019, 08:08:31 AM
Thanks guys.
Sound works fine over here on both Win versions. Have you enabled output? We changed absolutely nothing for sound playback, toolchain for Win32 version is also identical to v1.8.

I tried both on the desktop and the laptop it's not working :-\ , both machines are on Windows 10 v1903 (redstone 6) , what Windows are you running ?

Audio output is enabled , drop frame playback is enabled , the issue isn't in the settings but something else , previous versions are working fine , when I compiled latest changes using qt creator on my system the audio is working fine (it's not a bug in the code yes I know) I guess the problem in the new compiling way :(

The 64-bit version Crash on some systems is a second clue maybe :P (for Compiling issues) , but it's not crashing on my systems , exporting is fine and the audio is there in exported files , also I can see the waveform in the time line.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 19, 2019, 02:53:35 PM
@theBilalFakhouri: what Qt version have you installed? I have Qt 5.13.1 with MinGW 7.3.0 on WinPro 8.1.

But as written: for the Win32 version really nothing changed in terms of audio playback at all.

Would be great if someone who has a crashing MLVApp could install Qt and use the debugger - just for telling me in which line and file the crash happens. No need for coding skills.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 19, 2019, 03:08:32 PM
Quote from: masc on September 19, 2019, 02:53:35 PM
@theBilalFakhouri: what Qt version have you installed? I have Qt 5.13.1 with MinGW 7.3.0 on WinPro 8.1.
Qt 5.9.8 , MinGW 5.3.0

Quote from: masc on September 19, 2019, 02:53:35 PM
But as written: for the Win32 version really nothing changed in terms of audio playback at all.
That's right , I have never downloaded 32-bit version before , so I just downloaded it MLVApp 1.8 32-bit and also the sound playback isn't working on Windows 10 Pro v1903 , I don't have other Windows to try it . .

How you guys compile MLVApp? I read about it after installing qt , opening MLVApp.pro then press Build and Run , but the output here isn't same as released versions , also I can't run my compiled MLVApp without qt creator , could you explain your steps @masc @bouncyball for compiling ?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jimiz on September 19, 2019, 05:16:57 PM
Quote from: masc on September 19, 2019, 12:52:35 PM
Sorry guys. Can't reproduce. All works fine here with Win64 version. No idea where to search. No additional lib or driver is required. Just Windows.
Before we had a "static" version, which included all those files in the exe. This somehow doesn't work anymore. So we had to find a new toolchain for 64bit, which links dynamic now. So you have all the dll files now.
And how do you get it crashed? The same way as jimiz? Some more info would be helpful.

I try on a second pc....always WINDOW7  64 bit      same result       , 1.6 1.7 1.8 (64) work fine with any MLV....   last 1.9 (64) crash...when still load any MLV file.!   

sorry but true. I also can't not give more info...because no error message appare... program crash and swith off.


Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 19, 2019, 06:45:21 PM
Hey guys!

I don't experience any crashes with dynamic build either but, I've managed to compile usual static win64 build for 1.9, give it a try and report back. Here is a link (https://github.com/ilia3101/MLV-App/releases/download/QTv1.9/MLV.App.v1.9.Win64.static.zip).

BR
BB
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: sveinpetter on September 19, 2019, 06:56:00 PM
Win10 64bit
Tested both 64bit versions. No problem so far.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 19, 2019, 07:12:36 PM
Quote from: bouncyball on September 19, 2019, 06:45:21 PM
I've managed to compile usual static win64 build for 1.9, give it a try and report back. Here is a link (https://github.com/ilia3101/MLV-App/releases/download/QTv1.9/MLV.App.v1.9.Win64.static.zip).

(https://i.ibb.co/Hg4NFJ6/Dark-Blue-Moon-Emoji-2-00000.png) (https://imgbb.com/)

The audio playback is working now :D
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on September 19, 2019, 07:17:12 PM
Win10 x64 (1903) - At the first App load I tried to import MLV and while browsing in folders the App froze for a second and crashed/closed. But in two seconds it loaded again by itself. After that I couldn't reproduce the crash and now MLV files load without problems.
But I do NOT have audio at my output although I see the visual audio lane in the timeline.

p.s. The audio works fine in Static version
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 19, 2019, 07:28:09 PM
Quote from: theBilalFakhouri on September 19, 2019, 03:08:32 PM
Qt 5.9.8 , MinGW 5.3.0
...
How you guys compile MLVApp? I read about it after installing qt , opening MLVApp.pro then press Build and Run , but the output here isn't same as released versions , also I can't run my compiled MLVApp without qt creator , could you explain your steps @masc @bouncyball for compiling ?
So you compiled a 32bit version. Out of the box the app just works in QtCreator. This is correct. If you like to run the app standalone, you have to "deploy". This means you'll have to search through the Qt folder and find the needed dlls.
https://doc.qt.io/qt-5/windows-deployment.html
Newer versions do the deployment with a tool, for older versions you have to do it 100% manually. Maybe you find another webpage with more information about this. I did manually in past, but it is so long time ago... forgot where I found the information howto. Just search for "deployment".
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jimiz on September 19, 2019, 10:54:12 PM
Quote from: bouncyball on September 19, 2019, 06:45:21 PM
Hey guys!

I don't experience any crashes with dynamic build either but, I've managed to compile usual static win64 build for 1.9, give it a try and report back. Here is a link (https://github.com/ilia3101/MLV-App/releases/download/QTv1.9/MLV.App.v1.9.Win64.static.zip).

BR
BB

same problem...
I'v reistalled the dirvers video..  but no change...x64 crash on any MLV import... (only this 1.9)      32x work fine..

but I have win7 (64) not 10....
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: liquidether on September 20, 2019, 04:36:07 AM
Thanks so much for making this tool. I love it!

I've noticed that in the latest release (1.9) on my lowly 2015 MacBook 12" that memory is consumed rapidly when using the new sharpen "masking" tool. Memory usage has always hovered around 250MB but I came back to only a few files processed (successfully), a frozen batch job, a very sluggish Mac and Activity Viewer showing MLV App using over 20GB of RAM (mostly swap, of course).

Thinking perhaps my copy of MLV App was corrupt I downloaded it again, deleted all of its preference files but get the same result. Repeatable by setting "sharpen" to any value above 0 followed by "masking" to any value above 0. Default settings otherwise. Export file format does not make a difference (tested with ProRes and H.264). MLV App does not release that consumed memory after processing the files either, it hangs on to it until it is quit.

Otherwise 1.9 is just as stable as 1.8 on my machine. Thank you for all of your hard work!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ngemu on September 20, 2019, 08:41:12 AM
Can someone explain the tonemapping and processing gamut option in 1.9? Before on 1.8, I just applied the rec709 --> allow for creative adjustments --> increase / decrease dark strengths and the images came out pretty nice.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 20, 2019, 09:54:39 AM
@liquidether: thanks for the report. I will do some research. These are the points I always ask for testers... ;)
Edit: found and fixed for the future.

@ngemu: it was explained in detail last week or so in this thread. I added the information to MLVApp Wiki.
https://github.com/ilia3101/MLV-App/wiki#44-profile
If you just select a preset you'll have the same as in v1.8.

Quote from: jimiz on September 19, 2019, 10:54:12 PM
same problem...
I'v reistalled the dirvers video..  but no change...x64 crash on any MLV import... (only this 1.9)      32x work fine..

but I have win7 (64) not 10....
On a system like this someone should install a debugger and tell what's happening. No crash on all my systems, so I can't help at all.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jimiz on September 20, 2019, 11:28:10 AM
no problem , I wait version 1.10  ..meaby work again.
I can't  understand what can be the problem...I try to put ffmpeg.exe from 1.8  inside dir 1.9...but the problem is on MLVApp.exe
something  change in this code  , different from 1.8  and crash app on my 2 pc... (but only x64) meaby this can say something...or ?!
meaby a location of memory...meaby a dll on my sistem not "good" anymore for this app ?! meaby QTime or another codec to install again  before use the new 1.9 ?!?  difficult to say...

but 1.8 x64 work... yes, and thanks......better of nothing! ;)

Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 20, 2019, 11:45:23 AM
@jimiz: thanks for testing... but these things won't be the problem. ffmpeg is identical. Your drivers are identical (for 1.8 and 1.9). Code of MLVApp is identical between win32 & win64. The only thing what's different now is the compiler and the Qt dlls for the new win64 build. And the only way to find the reason will be installing Qt (which includes a debugger), start MLVApp from Qt with debugger, let MLVApp crash, and then look where it happens (debugger shows the position in code). With this information we maybe (and hopefully) could solve it... But it will only be possible to solve on a system, where the crash happens.

v1.10 will only be better, if we find the reason. Without a fix, I bet it will crash the same way.

Found an old Win7Pro laptop... no crash with win64 1.9 versions.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jimiz on September 20, 2019, 12:05:22 PM
QT you mind the trial , this one? https://www.qt.io/download

Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 20, 2019, 12:10:16 PM
The link is correct, but not trail. Use the open source version. When installing, you'll need 5.13.1 for Windows with MinGW7.3.0 and QtCreator (then you'll get a Win64 build). All other options won't be needed (if I remember right). If something is missing, it is always possible to install it later.
With that you'll be able to compile the same version you can download from our download page.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Stousen on September 21, 2019, 10:29:25 AM
Hi,

Awesome news. I thought of one thing that I would personally love, since shooting some anamorphic right now, and that is perhaps a way of doing cropmarks inside of MLVapp? So that you actually could see what will show in different aspect ratios?
Any ideas?

Cheers
//Chris
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 21, 2019, 02:01:48 PM
You can use the transformation tab. There is a horizontal stretch function.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 22, 2019, 10:13:33 AM
Perhaps this has already been requested (even I may have) but any chance we could please add a hot key that would enable 'Command + Delete' in order to delete certain highlighted MLV's without relying on the mouse pointer individually one by one? It's rather time consuming this way imo though correct me if I'm wrong. :)

Also am I the only one who's experiencing random misplaced 'Receipt Mask Setup' for Copy/Paste whenever I'm in FULL mode (entire screen filled with MLV App) more often than so upon pressing 'Command + C' it would end up in a different screen? This was on v1.9 running OS X 10.14.6 if that matters. Reproducible on both Mac Mini & MacBook Pro.

Basically, where I would be forced to get out of FULL screen mode just to get the RMS window become visible within the app again. Call me crazy!  :o
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 22, 2019, 10:15:52 AM
Select mlv files push fn + delete button for fast action.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 22, 2019, 10:20:03 AM
BOOM. Thank you. That was fast!  8)

Even though it would be nice to be able to use this fast action with just one hand rather than both. Ha.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 22, 2019, 05:59:07 PM
Quote from: DeafEyeJedi on September 22, 2019, 10:13:33 AM
Also am I the only one who's experiencing random misplaced 'Receipt Mask Setup' for Copy/Paste whenever I'm in FULL mode (entire screen filled with MLV App) more often than so upon pressing 'Command + C' it would end up in a different screen? This was on v1.9 running OS X 10.14.6 if that matters. Reproducible on both Mac Mini & MacBook Pro.

Basically, where I would be forced to get out of FULL screen mode just to get the RMS window become visible within the app again. Call me crazy!  :o
Hm... have just 10.9.5 here on holiday, but even after 20x CMD+C in fullscreen mode, the mask window is always centered on my screen. Do you have multiple screens? Can't try this here...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 23, 2019, 09:30:58 PM
Latest mlv app version is the best. Even anamorphic thumbnails comes out correct now:

Eos m anamorphic rewired 5208x2996
(https://i.postimg.cc/pdJbBJS6/Screenshot-2019-09-23-at-21-26-24.png)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 24, 2019, 04:54:30 AM
Did some more tests. A few repeated questions questions
Tweaking exposusre signal, white level and highligh reconstruction and then adding:
cineon log
alexa wide gamut

Ok, this isn´t exactly mr color science working here but still it resembles the compressed log signal and alexa color gamut. Naturally now I´d like to add either some lut to this or start working straight into mlv app adding a curve, color etc but these tools are all greyed out? Does it has to be like this? So then I add the Allow Creative Adjustments. Complete new signal is added. Control is lost. See image below.
(https://i.postimg.cc/x8gWnN4W/Screenshot-2019-09-24-at-04-27-57-png-500px.png)

Allow Creative Adjustments added. Why is the whole signal changed into something rec709ish? Could starting point when enabling still be the exact same signal as before Allow Creative Adjustment was enabled? Or why are adjustments sliders disabled in the first place?
(https://i.postimg.cc/cCdVpBXR/Screenshot-2019-09-24-at-04-28-10-png-500px.png)

The alternate route seems to be to build a quick and dirty log signal straight in mlv app. Here´s an example of reinhard and alexa wide gamut and sliders tweaked for dynamic range:
(https://i.postimg.cc/W43Kw4tn/Screenshot-2019-09-24-at-04-45-22-png-scaled.png)


Since we´re in full control and all sliders are still all open for tweaking we can still tweak and build upon the log signal.
(https://i.postimg.cc/QdSw77NC/Screenshot-2019-09-24-at-04-46-57-png-scaled.png)

I´m no color scientist so take all this with a grain of salt and use examples for further discussion perhaps.
I am really impressed how easy it is to dig out highlights and how the toolbox grown for getting creative solutions for almost any issue now.

Here´s the log to rec709 recipe if anyone want to test it. White level and transformation are left untouched:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/log_rec709.marxml
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 24, 2019, 05:08:55 AM
it shouldn't get 'lost' if dark strength is kept at 0, see if it helps
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 24, 2019, 05:17:25 AM
Working! Need to compensate for the dark strenght set to 0(exposure to 0 and gamma pulled down) but control is now there. Great! Might be an idea to zeroe dark strength when a log is selected and maybe lower gamma accordingly? Not sure how it could be done without interfering with other workflows.

EDIT: Hm, we need dark strenght when adding back black so zeroing this maybe not the best idea. However hard to know that this is the culprit when enabling Allow Creative Adjustments.

cineon log with and without Allow Creative Adjustments added:
(https://i.postimg.cc/rsmvyCt5/Screenshot-2019-09-24-at-05-12-20-png-scaled.png)

Addding back s-curve etc:
(https://i.postimg.cc/1tMkZY49/Screenshot-2019-09-24-at-05-12-46-png-scaled.png)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on September 24, 2019, 06:27:48 AM
Danne, try a Log-C to Rec.709 LUT from Arri:
https://www.arri.com/en/learn-help/learn-help-camera-system/tools/lut-generator

Might be easier than doing a S-curve...
edit: you're clipping your shadows. This was already discussed on rawtherapee github (https://github.com/Beep6581/RawTherapee/pull/4701#issuecomment-413687215).
But I agree with you:
QuoteMight be an idea to zeroe dark strength when a log is selected and maybe lower gamma accordingly?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 24, 2019, 06:53:25 AM
Quote from: Luther on September 24, 2019, 06:27:48 AM
Might be easier than doing a S-curve...
edit: you're clipping...
Of course I clipped. It was quick and dirty demo ;).
I use ben turleys online lut calculator. So easy, and includes all I could ever think of :).
At least last time I tested...
Thanks for linking by the way.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on September 24, 2019, 07:48:31 PM
Quote from: Luther on September 24, 2019, 06:27:48 AM
...try a Log-C to Rec.709 LUT from Arri:
https://www.arri.com/en/learn-help/learn-help-camera-system/tools/lut-generator

Thanks for acknowledging this. However, does it matter which file type we can export the 3D LUT format as?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on September 25, 2019, 04:46:13 AM
Quote from: DeafEyeJedi on September 24, 2019, 07:48:31 PM
Thanks for acknowledging this. However, does it matter which file type we can export the 3D LUT format as?

No difference, it will only generate platform specific formats (3dmesh, clut, .vf, .cube, etc). MLVApp only supports .cube format, so you can choose either "Adobe" or "DaVinci Resolve" (both will have the same result)...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on September 25, 2019, 07:14:57 AM
Nice find @masc and @Danne:
Quote
Piccante is a header-only C++11 open-source (MPL license v2.0) imaging library, specifically designed for High Dynamic Range (HDR) processing. Piccante is modular; this means new filters, algorithms, etc. can be added in a straightforward way to its core. Piccante is easy to use and to integrate in existing projects; to use Piccante you just need to include "piccante.hpp" in your project.
http://vcg.isti.cnr.it/piccante/index.php

Might be a better/faster solution than using ffmpeg blending...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 25, 2019, 09:00:47 AM
I think hardly faster but might have a more suitable blending algorithm. The main issue with ghosting/aligning still persists though. A fast aligning added here would be nice.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Stousen on September 25, 2019, 07:10:32 PM
Quote from: masc on September 21, 2019, 02:01:48 PM
You can use the transformation tab. There is a horizontal stretch function.

Yes! But can I Crop an image in mlvapp?? For example, with 2x stretch I get 2:77:1 aspect ratio, want to crop it down to 2:39:1?

//Chris
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 25, 2019, 07:41:17 PM
Nope. MLVApp can HQ stretch but not crop. But all NLEs are able to crop.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Stousen on September 25, 2019, 08:56:33 PM
Quote from: masc on September 25, 2019, 07:41:17 PM
Nope. MLVApp can HQ stretch but not crop. But all NLEs are able to crop.

Ah, I see!
Thanks!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on September 26, 2019, 09:19:40 AM
@Ilia3101 I think the Rec.709 matrix is wrong. According to the ACES github (https://github.com/ampas/aces-dev/blob/master/transforms/ctl/README-MATRIX.md), the XYZ>Rec.709 matrix is this:
Quote
R_out =  3.2409699419 * R_in + -1.5373831776 * G_in + -0.4986107603 * B_in;
G_out = -0.9692436363 * R_in +  1.8759675015 * G_in +  0.0415550574 * B_in;
B_out =  0.0556300797 * R_in + -0.2039769589 * G_in +  1.0569715142 * B_in;
But on MLVAPP processing.c (https://github.com/ilia3101/MLV-App/blob/master/src/processing/processing.c) it is:
Quote
/* GAMUT_Rec709 */
         3.2404542, -1.5371385, -0.4985314,
        -0.9692660,  1.8760108,  0.0415560,
         0.0556434, -0.2040259,  1.0572252
Not sure which one is correct.

Also, I have a request. Can you add AP1 to the Gamuts? This seems to be the matrix:
Quote
R_out =  1.6410233797 * R_in + -0.3248032942 * G_in + -0.2364246952 * B_in;
G_out = -0.6636628587 * R_in +  1.6153315917 * G_in +  0.0167563477 * B_in;
B_out =  0.0117218943 * R_in + -0.0082844420 * G_in +  0.9883948585 * B_in;
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 26, 2019, 10:10:01 AM
Nice digging. Did you test these numbers and compiled, compared?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on September 26, 2019, 11:23:07 AM
Quote from: Danne on September 26, 2019, 10:10:01 AM
Nice digging. Did you test these numbers and compiled, compared?

Tested now. Doesn't seem to have any difference at all ¯\_(ツ)_/¯
Where did you got the original matrix @Ilia3101 ?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: anandkamal on September 26, 2019, 04:45:27 PM
Thanks for the wonderful software. Just curious to know if there will be an option for importing cdng files in the future versions :)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 26, 2019, 06:52:00 PM
Here is a short video that I filmed on the 5DMkIII using the amazing EF 85/F1.4 L IS USM lens:
https://vimeo.com/362342398
I wanted to test the stabilization and get an impression of the tone transitions and bokeh, so I filmed hand held at F1.4.  And since I did not have a VND filter at that time, I just waited until it got almost dark in the evening, so 1/50-th of a sec. shutter speed gave me the right exposure with the lens wide open.    I used the latest 5DMkIII experimental build found in Danne's repository and set the crop mode to 1360x2296 anamorphic mode at 10-bits lossless and 24 fps which allows continuous recording.   

MLV processing was done entirely in MLVApp 1.8, (unfortunately, I was unable to get version 1.9 working on any of the three Win7x64 desktops that I tried, the static version did not work either causing a crash upon opening a MLV file).  In version 1.8, I first applied the Alexa Log-C profile to all clips and activated the "Allow creative adjustments" option.  Then I made just a few very basic adjustments to get proper brightness and contrast (Exposure, Lighten, Curves) without clipping brightest and darkest areas, added some sharpness, set Chroma separation to 6 and that was it.  Then I exported the clips into ProRes 422LT, edited the video and added the music in DaVinci Resolve 15 Lite and exported the final video in the resolution of my screen (2560x1440) using the MPEG4 codec.  This keeps the file fairly small (only 262 MB).  I don't know if that is the optimum workflow in terms of image quality but comparing the video quality after upload to Vimeo with the original, I do not see any loss of quality.  So, I think, uploading in 4k, as usually people do to avoid quality degradation in YouTube, was not necessary here.   Please let me know what you guys think.  Also, your suggestions for a better workflow will be highly appreciated.

Personally, I think that MLVApp does a hell of a job with processing, grading and converting MLV files - the above workflow is simple and easy to use.  The developers of this amazing software have given us a very powerful RAW-video processing tool.  Thank you so much!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: HHH456 on September 27, 2019, 10:43:44 PM
Hi, thanks for all the hard work into ML and the MLV app.

I was wondering if technically there's any quality difference in adding (for example) the Alexa c-log LUT to the mlv app export vs. adding (for example) a flat LUT later in editor?
(Also, the same concept except upscaling in MLV vs. in editor?)

If I edit a multi-clip project with a fixed mlv app look, I've committed to that base look whereas the LUT could be removed or changed in editor.
Thanks for any info.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on September 28, 2019, 08:36:08 AM
Quote from: HHH456 on September 27, 2019, 10:43:44 PM
flat LUT later in editor?
This will probably create banding (https://en.wikipedia.org/wiki/Colour_banding) issues. Always apply Log-C first and then do other processing.

Quote
(Also, the same concept except upscaling in MLV vs. in editor?)
It depends on your editor's interpolation algorithm. MLVApp has some pretty good ones, like Lanczos. I suggest you do that on MLVApp too, as Premiere Pro only has bilinear/bicubic interpolation (which is worse than Lanczos).
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 28, 2019, 09:43:10 AM
Quote from: HHH456 on September 27, 2019, 10:43:44 PM
I was wondering if technically there's any quality difference in adding (for example) the Alexa c-log LUT to the mlv app export vs. adding (for example) a flat LUT later in editor?
(Also, the same concept except upscaling in MLV vs. in editor?)
Quote from: Luther on September 28, 2019, 08:36:08 AM
This will probably create banding (https://en.wikipedia.org/wiki/Colour_banding) issues. Always apply Log-C first and then do other processing.
It depends on your editor's interpolation algorithm. MLVApp has some pretty good ones, like Lanczos. I suggest you do that on MLVApp too, as Premiere Pro only has bilinear/bicubic interpolation (which is worse than Lanczos).

Correct. You'll easier get banding in your editor, because your editor has just 8..12bit footage (depends on codec) while MLVApp has the full 16bit working range (you import less, but after WB and other features used bitdepth will get bigger).
Lanczos, Sinc and AVIR should bring better results than bilinear/bicubic which is offered by most editors.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on September 28, 2019, 10:45:21 AM
Quote from: masc on September 28, 2019, 09:43:10 AM
Lanczos, Sinc and AVIR should bring better results than bilinear/bicubic which is offered by most editors.

What about Davinci?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on September 28, 2019, 02:03:12 PM
Quote from: Dmytro_ua on September 28, 2019, 10:45:21 AM
What about Davinci?
DaVinci has a super-resolution algorithm. Better quality than Lanczos.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: HHH456 on September 28, 2019, 04:22:28 PM
Quote from: Luther on September 28, 2019, 08:36:08 AM
This will probably create banding (https://en.wikipedia.org/wiki/Colour_banding) issues. Always apply Log-C first and then do other processing.
It depends on your editor's interpolation algorithm. MLVApp has some pretty good ones, like Lanczos. I suggest you do that on MLVApp too, as Premiere Pro only has bilinear/bicubic interpolation (which is worse than Lanczos).

Thanks for your advice, will do.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 28, 2019, 06:23:44 PM
Quote from: Dmytro_ua on September 28, 2019, 10:45:21 AM
What about Davinci?
Quote from: Luther on September 28, 2019, 02:03:12 PM
DaVinci has a super-resolution algorithm. Better quality than Lanczos.
But I would only use it with DNG, otherwise you just super-scale your compression artifacts.  ;D
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on September 28, 2019, 09:18:15 PM
Quote from: masc on September 28, 2019, 06:23:44 PM
But I would only use it with DNG, otherwise you just super-scale your compression artifacts.  ;D
Only true for lossy codecs. ProRes is technically lossy, but there's no visual artifacts, so I think it's fine too.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 29, 2019, 12:27:39 PM
Quote from: Luther on September 26, 2019, 09:19:40 AM
@Ilia3101 I think the Rec.709 matrix is wrong. According to the ACES github (https://github.com/ampas/aces-dev/blob/master/transforms/ctl/README-MATRIX.md), the XYZ>Rec.709 matrix is this:But on MLVAPP processing.c (https://github.com/ilia3101/MLV-App/blob/master/src/processing/processing.c) it is:Not sure which one is correct.

Also, I have a request. Can you add AP1 to the Gamuts? This seems to be the matrix:

Hm, looks like ours is less decimal places, not a problem, but two of the bottom numbers are actually different. Strange. I got it off Wikipedia, I'll try to find the original rec709 specs and see what it is.

And sure, will add AP1
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: visionbyeric on October 05, 2019, 07:12:33 AM
Hello, The MLV App is best ML Raw app for my work flow. Unfortunately I downloaded the newest version 1.9 and soon as I import a MLV file, it crashes. Version 1.8 runs flawlessly. I'm running Windows 10 64 1903.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 08, 2019, 06:12:21 PM
Quote from: visionbyeric on October 05, 2019, 07:12:33 AM
... the newest version 1.9 and soon as I import a MLV file, it crashes. Version 1.8 runs flawlessly. I'm running Windows 10 64 1903.
We still need someone with a Win-PC where MLVApp crashes, who installs Qt+Debugger and who tells us the crashing line of code. Without that information we are not able to fix this. On all my computers this crash does not happen, so I don't know what is going on there.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on October 08, 2019, 11:25:00 PM
I cannot reproduce the crash here on Windows 10. Neither the slowness reported by others.
This happens in any MLV file @visionbyeric ? Or only with MLV file with sound? If you can, send me a file (I don't record audio in MLV).
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 11, 2019, 08:45:21 PM
For everybody who is able to compile MLVApp: please test latest revision. I removed all ffmpeg rescale functions and therefor added AVIR rescaling for ffmpeg export. It would be important, if you could test this and post issues. It was a big change and the scaling was linked into many parts of the export. I just hope I haven't forgotten something... ;) There are hundreds of possible export setting combinations.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 12, 2019, 06:42:59 AM
Quote from: masc on October 11, 2019, 08:45:21 PM
For everybody who is able to compile MLVApp: please test latest revision. I removed all ffmpeg rescale functions and therefor added AVIR rescaling for ffmpeg export. It would be important, if you could test this and post issues. It was a big change and the scaling was linked into many parts of the export. I just hope I haven't forgotten something... ;) There are hundreds of possible export setting combinations.

Okie dokie. Just updated to Catalina. Will compile and give it a ride.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: visionbyeric on October 12, 2019, 09:45:53 PM
I will try and set up Qt+Debugger and see what I can find.

Thank You
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 13, 2019, 12:02:04 AM
Quote from: visionbyeric on October 12, 2019, 09:45:53 PM
I will try and set up Qt+Debugger and see what I can find.
Thumbs up! This would be fantastic!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 13, 2019, 12:18:58 AM
Quote from: DeafEyeJedi on October 12, 2019, 06:42:59 AM
Okie dokie. Just updated to Catalina. Will compile and give it a ride.
Great. Did not try on Catalina yet. Hopefully it works!
Title: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 13, 2019, 08:26:17 AM
Compiled and running flawlessly on Catalina so far. Question though how do I confirm that it is actually exporting w the new algorithm re: AVIR? :)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 13, 2019, 10:09:01 AM
Quote from: DeafEyeJedi on October 13, 2019, 08:26:17 AM
Compiled and running flawlessly on Catalina so far. Question though how do I confirm that it is actually exporting w the new algorithm re: AVIR? :)
Good to know, thanks.
If you get resized clips when exporting with AVFoundation or ffmpeg with latest revision, you used AVIR. From now on it is the only algorithm...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: escho on October 13, 2019, 12:52:43 PM
Quote from: masc on October 11, 2019, 08:45:21 PM
For everybody who is able to compile MLVApp: please test latest revision...

Doesn´t compile here on openSUSE Tumbleweed, not shure why. Creating the stash-file works, compiling not. I will have a look at it later, what´s going on.
Edgar
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 13, 2019, 01:05:20 PM
Quote from: DeafEyeJedi on October 13, 2019, 08:26:17 AM
Compiled and running flawlessly on Catalina so far. Question though how do I confirm that it is actually exporting w the new algorithm re: AVIR? :)

Same! (on mojave and ubuntu)

Quote from: escho on October 13, 2019, 12:52:43 PM
Doesn´t compile here on openSUSE Tumbleweed, not shure why. Creating the stash-file works, compiling not. I will have a look at it later, what´s going on.
Edgar

Compiles fine for me on Ubuntu with "qmake; make -j4"
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: escho on October 13, 2019, 01:33:27 PM
Quote from: Ilia3101 on October 13, 2019, 01:05:20 PM
Compiles fine for me on Ubuntu with "qmake; make -j4"

I found the error.
I use a little bash-script for cloning, compiling and installing MLV App. I used the wrong copy of this script, which had an "exit" before the "make" (for debugging reasons).

Compiling with the correct script worked without problems. Exporting to uncompressed avi with resizing worked too :)

It looks like the default for resizing is 1920x1080px. Maybe, it´s better to have the native resolution of the MLV as default.  ( I often use uncommon aspect-ratios for my astronomy stuff)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 13, 2019, 03:13:27 PM
Quote from: escho on October 13, 2019, 01:33:27 PM
It looks like the default for resizing is 1920x1080px. Maybe, it´s better to have the native resolution of the MLV as default.  ( I often use uncommon aspect-ratios for my astronomy stuff)
Default is "no rescaling" -> so native resolution. You have to uncheck "resize" in export settings for that. Does that work for you?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: escho on October 13, 2019, 05:04:10 PM
Quote from: masc on October 13, 2019, 03:13:27 PM
Default is "no rescaling" -> so native resolution. You have to uncheck "resize" in export settings for that. Does that work for you?

Played a bit with it:  :)

"No resizing" is the default and this works fine. And "resizing" works fine as well.

The reason for my confusion was these two points

1. The displayed resolution has no default. It´s always the latest choosen resizing resolution (maybe from days before). Reset receips does not change anything here.
If I import a MLV into a new session, I would expect to see the native resolution of the MLV in the resizing fields as a starting point.

2. Locking the aspect ratio for the resizing fields is a great feature. The height-field is grayed out then and the resulted resolution is calculated from the width-field.
That works fine, but the height-field isn´t updated with the calculated height.

That´s just for info
Edgar
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 13, 2019, 05:45:42 PM
Quote from: escho on October 13, 2019, 05:04:10 PM
1. The displayed resolution has no default. It´s always the latest choosen resizing resolution (maybe from days before). Reset receips does not change anything here.
If I import a MLV into a new session, I would expect to see the native resolution of the MLV in the resizing fields as a starting point.

2. Locking the aspect ratio for the resizing fields is a great feature. The height-field is grayed out then and the resulted resolution is calculated from the width-field.
That works fine, but the height-field isn´t updated with the calculated height.
Thanks for testing and reporting.
These two points have a reason: the MLVs you import might have the same resolution (as I expect you use it)... but nobody can garantue that. That is why it has to be universal for projects with clips of different resolutions. And in such a project... which resolution is the one to set into this dialog window?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on October 15, 2019, 01:56:22 AM
@masc Tested on Windows 10. Couldn't try all possible "permutations", but I've tested on all codecs. It's working flawlessly, even for 4x resize.
Some notes I took while testing:
- FFmpeg Anatolyi doesn't work (can't be selected)
- Is the "CLancIR class" (Lanczos) difficult to implement? According to the AVIR github, "LANCIR offers up to 200% faster image resizing". Might be useful for some people that need faster conversion.
- The avir.h seems to linearize sRGB gamma... doesn't it conflict with other color conversions?
- Stretch transformation is using AVIR? I've tested and it's working too.
- Why use bt601 in:
resizeFilter = QString( "-vf %1scale=in_color_matrix=bt601:out_color_matrix=bt709%2%3 " )
Instead of bt2020?
resizeFilter = QString( "-vf %1scale=in_color_matrix=bt2020:out_color_matrix=bt709%2%3 " )
This way you're going from a bigger to smaller space, which is the "correct". I've tested and there's a small change in chroma noise from what I could notice...

While testing AVIR, I also changed the AP0 matrix to the AP1 in processing.c:

1.6410233797, -0.3248032942, -0.2364246952
-0.6636628587, 1.6153315917, 0.0167563477
0.0117218943, -0.0082844420, 0.9883948585


This gave me the best color results so far. Please test it too...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on October 15, 2019, 02:51:21 PM
Everything's working fine on windows 10 except when the Resize box isn't ticked in the Export Settings.
On an anamorphic 5k shot, if this box isn't ticked I got a shorter video which is a 3x3 mosaic of the shot.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: a1ex on October 15, 2019, 05:37:26 PM
Small bug (?) report.

While trying to identify the root cause of these artifacts (https://www.magiclantern.fm/forum/index.php?topic=24553.0), I've noticed I'm unable to identify ML version used for the original recording. The sample clip shared there appears to be exported from MLV App, and this is the only VERS block I could find:


Block: VERS
  Offset: 0x0000023c
  Number: 8
    Size: 40
    Time: 18446744073709552.000000 ms
  String: 'MLV App version 1.9'


Normally, mlv_rec/mlv_lite are saving extended version info (multiple VERS blocks) about ML core version, alongside with info about modules loaded, including the version of each module.

Based on this, I'd say the preferred way to handle VERS blocks while transcoding is to add the app-specific block on top of existing ones.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 15, 2019, 08:26:42 PM
Thank you for testing Luther!
Quote from: Luther on October 15, 2019, 01:56:22 AM
- FFmpeg Anatolyi doesn't work (can't be selected)
This should only be the case for ProRes4444. Anatolyi does not offer this kind of export. Did you had this for other codecs?
Quote from: Luther on October 15, 2019, 01:56:22 AM
- Is the "CLancIR class" (Lanczos) difficult to implement? According to the AVIR github, "LANCIR offers up to 200% faster image resizing". Might be useful for some people that need faster conversion.
In principle it should be the same interface as for AVIR. But they write it is 8bit only. So we would loose a lot of information. And they write that it is not thread safe. No idea what that means exactly... but if multithreading doesn't work with it, 200% on single core will just be ~50%  on quad core.
Quote from: Luther on October 15, 2019, 01:56:22 AM
- The avir.h seems to linearize sRGB gamma... doesn't it conflict with other color conversions?
I think that input color space = output color space. At least I don't see any difference in color.
Quote from: Luther on October 15, 2019, 01:56:22 AM
- Stretch transformation is using AVIR? I've tested and it's working too.
Yes. Fine. But another user reported a bug on github about that. When resize=off but stretching=on (e.g. anamorphic footage) and using ffmpeg, we exported a 3x3 matrix of the clip. Should be fixed now.
Quote from: Luther on October 15, 2019, 01:56:22 AM
- Why use bt601 in:
resizeFilter = QString( "-vf %1scale=in_color_matrix=bt601:out_color_matrix=bt709%2%3 " )
Instead of bt2020?
resizeFilter = QString( "-vf %1scale=in_color_matrix=bt2020:out_color_matrix=bt709%2%3 " )
This way you're going from a bigger to smaller space, which is the "correct". I've tested and there's a small change in chroma noise from what I could notice...
ffmpeg interprets all input as bt601. This part of the code tells ffmpeg, that we rendered bt709. You clearly see the difference in color when commenting this part. As the code is, the colors you'll get in your exported clip will be as you saw them in the viewer.
Quote from: Luther on October 15, 2019, 01:56:22 AM
While testing AVIR, I also changed the AP0 matrix to the AP1 in processing.c:

1.6410233797, -0.3248032942, -0.2364246952
-0.6636628587, 1.6153315917, 0.0167563477
0.0117218943, -0.0082844420, 0.9883948585

This gave me the best color results so far. Please test it too...
Cool. Should be easy to add another option with this matrix.


@a1ex: puh... no idea about, sry. This part was implemented by bouncyball, if I remember right. I'll create an issue on github to not forget about. From what I see in the code, we really just save what you posted.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on October 15, 2019, 10:36:40 PM
I bought better quality monitor and i see that id like to get more control over h.264 and 265 compression besides medium high and low quality, will it ever be possible to have a number so we could input our values for export quality ? Some shots i need more and some less, but gap between high and medium h264 is quite big, 50 seconds is 31mb for medium and 300mb for high.100mb for high quality h265, but id like about 60mb.
I asked this before , is there a way to export with our own h264 quality maybe with some command line ?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on October 15, 2019, 11:51:45 PM
Quote from: masc on October 15, 2019, 08:26:42 PM
This should only be the case for ProRes4444. Anatolyi does not offer this kind of export. Did you had this for other codecs?
That's right, my fault.
Quote
In principle it should be the same interface as for AVIR. But they write it is 8bit only. So we would loose a lot of information. And they write that it is not thread safe. No idea what that means exactly... but if multithreading doesn't work with it, 200% on single core will just be ~50%  on quad core.
I think they mean that it might have racing conditions (https://en.wikipedia.org/wiki/Race_condition). Don't think it affects the performance, but it might be buggy.
Quote
I think that input color space = output color space. At least I don't see any difference in color.
Yes, not sure why they do this (from avir.h):

/**
* Function approximately linearizes the sRGB gamma value.
*
* @param s sRGB gamma value, in the range 0 to 1.
* @return Linearized sRGB gamma value, approximated.
*/

template< class T >
inline T convertSRGB2Lin( const T s )
{
const T a = (T) 0.055;

if( s <= (T) 0.04045 )
{
return( s / (T) 12.92 );
}

return( pow24_sRGB(( s + a ) / ( (T) 1 + a )));
}

/**
* Function approximately de-linearizes the linear gamma value.
*
* @param s Linear gamma value, in the range 0 to 1.
* @return sRGB gamma value, approximated.
*/

template< class T >
inline T convertLin2SRGB( const T s )
{
const T a = (T) 0.055;

if( s <= (T) 0.0031308 )
{
return( (T) 12.92 * s );
}

return(( (T) 1 + a ) * pow24i_sRGB( s ) - a );
}


Quote
Yes. Fine. But another user reported a bug on github about that. When resize=off but stretching=on (e.g. anamorphic footage) and using ffmpeg, we exported a 3x3 matrix of the clip. Should be fixed now.

Tested now, it's working (with your last commit).

Quote
ffmpeg interprets all input as bt601. This part of the code tells ffmpeg, that we rendered bt709. You clearly see the difference in color when commenting this part. As the code is, the colors you'll get in your exported clip will be as you saw them in the viewer.
Got it.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on October 15, 2019, 11:58:51 PM
Quote from: 2blackbar on October 15, 2019, 10:36:40 PM
I bought better quality monitor and i see that id like to get more control over h.264 and 265 compression besides medium high and low quality, will it ever be possible to have a number so we could input our values for export quality ? Some shots i need more and some less, but gap between high and medium h264 is quite big, 50 seconds is 31mb for medium and 300mb for high.100mb for high quality h265, but id like about 60mb.
I asked this before , is there a way to export with our own h264 quality maybe with some command line ?

Would be nice to be able to choose the --crf value and -preset option. +1
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 16, 2019, 03:00:41 AM
Quote from: Luther on October 15, 2019, 11:58:51 PM
Would be nice to be able to choose the --crf value and -preset option. +1

+1
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 16, 2019, 08:23:08 AM
Quote from: 2blackbar on October 15, 2019, 10:36:40 PM
I asked this before , is there a way to export with our own h264 quality maybe with some command line ?
Quote from: Luther on October 15, 2019, 11:58:51 PM
Would be nice to be able to choose the --crf value and -preset option. +1
Quote from: DeafEyeJedi on October 16, 2019, 03:00:41 AM
+1

-1
Commandline is no good idea. One single wrong or unexpected symbol brings the whole thing to crash. If you like other options, you could change the numbers in source code and compile. This is the simplest, fastest and safest way to get what you want.
Changing parameter elements dynamically in dependency to codec is extremely overkill IMO.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 16, 2019, 08:28:41 AM
Agree about overkill. Search for libx264 -preset or libx265 -preset in source code and start experimenting changing bitrate, compiling.
Title: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 16, 2019, 05:38:04 PM
Ah, good to know. Thanks for clarifying @masc & @Danne!

Either way it seems perfect as is for H264 exports especially for online viewing purpose.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on October 17, 2019, 12:20:29 AM
Quote from: masc on October 16, 2019, 08:23:08 AM
-1
Commandline is no good idea. One single wrong or unexpected symbol brings the whole thing to crash. If you like other options, you could change the numbers in source code and compile. This is the simplest, fastest and safest way to get what you want.
Changing parameter elements dynamically in dependency to codec is extremely overkill IMO.

And who said anything about command line imput? I agree that parsing can go wrong, but the first suggestion I agreed was to add a Qt box to select some common options in h.264. No parsing issues, it's just hardcoded. Particularly the CRF value (from ~18 to ~34) and the Preset option (from 'fast' to 'slow') would be useful. Also, for h.264, ffmpeg has NVENC, which speeds up the encoding using GPU...

I don't even use H.264 while on MLVApp, I export in ProRes. But, these options would be nice for people that want faster exporting times or just a highly-compressed preview of some scene (a "daily", as some people call it).
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 17, 2019, 01:03:39 PM
Quote from: Luther on October 17, 2019, 12:20:29 AM
And who said anything about command line imput?
-->
Quote from: 2blackbar on October 15, 2019, 10:36:40 PM
I asked this before , is there a way to export with our own h264 quality maybe with some command line ?
---------------
Quote from: Luther on October 17, 2019, 12:20:29 AM
...but the first suggestion I agreed was to add a Qt box to select some common options in h.264. No parsing issues, it's just hardcoded. ...
No, it is not hardcoded. It is dynamic, because it must only be visible for H.264 & H.265.
-->
Quote from: masc on October 16, 2019, 08:23:08 AM
Changing parameter elements dynamically in dependency to codec is extremely overkill IMO.

So I suggested:
Quote from: masc on October 16, 2019, 08:23:08 AM
If you like other options, you could change the numbers in source code and compile.
---------------
Quote from: Luther on October 17, 2019, 12:20:29 AM
Also, for h.264, ffmpeg has NVENC, which speeds up the encoding using GPU...
Yapp, that is right. But you need to compile a special ffmpeg version in order to use it. And I can't test or try, because I don't own a supported GPU. If someone else likes to try out: please post results. If we can detect those supported graphic cards somehow, and if we can setup our GUI dynamically with that, it should be easy to add this option.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on October 17, 2019, 02:36:19 PM
MLV-App's ffmpeg binary for Windows is already compiled with --enable-nvenc. I own an nVidia card and I could install some distros real quick if further testing is needed.
As for Luther's suggestion, he's probably thinking of a simple slider for Constant Quality RF. No parsing required.
I don't care about any of those features personally because there's no way to edit in MLV-App efficiently, so Prores it is.

Anyway, ffmpeg -h encoder=h264_nvenc and ffmpeg -h encoder=hevc_nvenc gives me those outputs on Windows. I omitted the whole AVOptions part but here's the whole output https://pastebin.com/n13ueWaE

PS C:\Users\Windows\Desktop\MLV.App.v1.9.Win64.static> .\ffmpeg.exe -h encoder=h264_nvenc
ffmpeg version N-93580-g036b4b0f85 Copyright (c) 2000-2019 the FFmpeg developers
  built with gcc 8.3.1 (GCC) 20190414
  configuration: --enable-gpl --enable-version3 --enable-sdl2 --enable-fontconfig --enable-gnutls --enable-iconv --enable-libass --enable-libdav1d --enable-libbluray --enable-libfreetype --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-libopus --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libtheora --enable-libtwolame --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxml2 --enable-libzimg --enable-lzma --enable-zlib --enable-gmp --enable-libvidstab --enable-libvorbis --enable-libvo-amrwbenc --enable-libmysofa --enable-libspeex --enable-libxvid --enable-libaom --enable-libmfx --enable-amf --enable-ffnvcodec --enable-cuvid --enable-d3d11va --enable-nvenc --enable-nvdec --enable-dxva2 --enable-avisynth --enable-libopenmpt
Encoder h264_nvenc [NVIDIA NVENC H.264 encoder]:
    General capabilities: delay hardware
    Threading capabilities: none
    Supported pixel formats: yuv420p nv12 p010le yuv444p p016le yuv444p16le bgr0 rgb0 cuda d3d11

PS C:\Users\Windows\Desktop\MLV.App.v1.9.Win64.static> .\ffmpeg.exe -h encoder=hevc_nvenc
ffmpeg version N-93580-g036b4b0f85 Copyright (c) 2000-2019 the FFmpeg developers
  built with gcc 8.3.1 (GCC) 20190414
  configuration: --enable-gpl --enable-version3 --enable-sdl2 --enable-fontconfig --enable-gnutls --enable-iconv --enable-libass --enable-libdav1d --enable-libbluray --enable-libfreetype --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-libopus --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libtheora --enable-libtwolame --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxml2 --enable-libzimg --enable-lzma --enable-zlib --enable-gmp --enable-libvidstab --enable-libvorbis --enable-libvo-amrwbenc --enable-libmysofa --enable-libspeex --enable-libxvid --enable-libaom --enable-libmfx --enable-amf --enable-ffnvcodec --enable-cuvid --enable-d3d11va --enable-nvenc --enable-nvdec --enable-dxva2 --enable-avisynth --enable-libopenmpt
Encoder hevc_nvenc [NVIDIA NVENC hevc encoder]:
    General capabilities: delay hardware
    Threading capabilities: none
    Supported pixel formats: yuv420p nv12 p010le yuv444p p016le yuv444p16le bgr0 rgb0 cuda d3d11


Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 17, 2019, 08:17:55 PM
Quote from: cmh on October 17, 2019, 02:36:19 PM
MLV-App's ffmpeg binary for Windows is already compiled with --enable-nvenc. I own an nVidia card and I could install some distros real quick if further testing is needed.
Oh really? Funny. I loaded the versions for all OS from the same page and the OSX version tells "Codec 'h264_nvenc' is not recognized by FFmpeg."
This is a MLVApp standard call for ffmpeg x264 encoding:

"/Users/masc/Documents/MLV_App/platform/build-MLVApp-Desktop_Qt_5_7_0_clangOMP_64bit-Release/MLV App.app/Contents/MacOS/ffmpeg" -loglevel 0 -r 23.98 -y -f rawvideo -s 4464x1900 -pix_fmt rgb48 -i - -i "/Users/masc/Desktop/M22-1233short.wav" -c:a aac -c:v libx264 -preset medium -crf 14 -pix_fmt yuv420p -color_primaries bt709 -color_trc bt709 -colorspace bt709 -vf scale=in_color_matrix=bt601:out_color_matrix=bt709 "/Users/masc/Desktop/M22-1233short.mp4"

Adapt ffmpeg path, wav and output path to your system; and exchange "-i -" to an imput video file "-i input.mov" or something. Could you try encoding with h264_nvenc and tell me what you need to change in order to make it work? I could try to make it work for MLVApp on Windows.  Do you know if there is any ffmpeg call, where ffmpeg tells, if it is able to use this codec? (when using this codec without supported GPU will lead to errors, so this needs to be catched somehow)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on October 17, 2019, 11:05:29 PM
I did some tests on a GTX1060, h264_nvenc and h264_cuvid are capped at 4k apparently.

I tried the whole command line but -f rawvideo doesn't work, even with libx264 (or the right size or -profile high444p -pixel_format yuv444p).
M17-2143.mov: corrupt input packet in stream 0
[rawvideo @ 0647e740] Invalid buffer size, packet size 47686523 < expected frame_size 48382272
Error while decoding stream #0:0: Invalid argument

M17-2143.mov, 4392x1836

- h264_cuvid: fails
.\ffmpeg.exe -hwaccel cuvid -c:v h264_cuvid -i 'M17-2143.mov' 'test.mp4'
[h264_cuvid @ 06bd0080] Video width 4392 not within range from 48 to 4096
Stream mapping:
  Stream #0:0 -> #0:0 (h264 (h264_cuvid) -> h264 (libx264))
Error while opening decoder for input stream #0:0 : Invalid argument

- h264_nvenc: fails
.\ffmpeg.exe -i 'M17-2143.mov' -c:v h264_nvenc -preset default 'test.mp4'
[h264_nvenc @ 06f60080] No NVENC capable devices found
Error initializing output stream 0:0 -- Error while opening encoder for output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width or height
Fails

- hevc_nvenc: pass
.\ffmpeg.exe -i 'M17-2143.mov' -c:v hevc_nvenc -preset default 'test.mp4'

Peppa_Pig-Patata-Parc.mp4, 1025x576

- h264_cuvid: pass
.\ffmpeg.exe -vsync 0 -hwaccel cuvid -c:v h264_cuvid -i 'Peppa_Pig-Patata-Parc.mp4' -c:a copy -c:v h264_nvenc -b:v 5M 'test.mp4'

- h264_nvenc: pass
.\ffmpeg.exe -i '.\Peppa_Pig-Patata-Parc.mp4' -c:v h264_nvenc -preset default 'test.mp4'

- hevc_nvenc: too lazy to test but it should work.

I'll test some more hevc_nvenc tomorrow.

Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on October 17, 2019, 11:10:38 PM
It's on Windows 10 btw and here's some nVidia's doc
https://developer.nvidia.com/video-encode-decode-gpu-support-matrix
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on October 18, 2019, 04:05:11 AM
Quote from: cmh on October 17, 2019, 02:36:19 PM
As for Luther's suggestion, he's probably thinking of a simple slider for Constant Quality RF. No parsing required.
Yes, like HandBrake does.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on October 18, 2019, 02:01:15 PM
Handbrake won't encode huge resolutions with nvenc h.264 either btw.

I can't test the GPU based scalers with h264_nvenc encoding because the ffmpeg binary is not compiled with --enable-libnpp and I can't use -filter_complex nvresize=1:s= wihtout ffmpeg compiled with the flag --enable-nvresize. I can't find a solution for resizing. Other than that there's a problem with the pixel formats for some reason "Option pixel_format not found".

-c:v libx265 replaced by -vcodec hevc_nvenc         
-f rawvideo -s 4392x1826 replaced by -filter_complex nvresize=1:s=4392x1826
-pix_fmt rgb48 replaced by any other supported pixel formats: yuv420p nv12 p010le yuv444p p016le yuv444p16le bgr0 rgb0 cuda d3d11 (I tried yuv420p, yuv444p and rgb0).
-crf replaced by -cq but the quality is different between -crf 18 and -cq 18, need further testing
resizeFilter need futher testing too, I just skipped it.

If someone else wanted to try, take a look at ManWindow.cpp, line 2127.

nvenc is nice to have for fast transcoding but I think it's too limited for this particular usage. For a quick export/preview, I think Huff YUV 10 bits is pretty fast (I haven't tried tbh) otherwise there's cdng.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on October 18, 2019, 06:52:11 PM
Apparently nvresize is an unmaintained hack and is not compatible with the current ffmpeg version. There's the scale_npp filter but it's only available with libnpp (NVIDIA Performance Primitives) which require a recompilation to include thi particular nVidia CUDA SDK's proprietary libs (this is why it isn't included in the first place). This would enable resizing and fix the pîxel format errors.
https://github.com/m-ab-s/media-autobuild_suite for recompiling ffmpeg on windows with libnpp
https://docs.nvidia.com/cuda/eula/index.html
I'm not willing to dig futher.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 18, 2019, 07:51:06 PM
Thanks so much @cmh, that's all very interesting. I saved your messages into our github future feature issue #78, to not forget it.
The limited resolution is not nice, but also no problem. So we have to limit the output before giving the stream to ffmpeg, when such codecs are selected. We don't need any resizing support from ffmpeg anymore, because we do it 100% with AVIR now (better quality). Using nVidia SDK might be also a little overkill for such a feature... it is just H.26x, so it will mostly be used as kind of preview.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on October 19, 2019, 02:10:47 AM
Quote from: cmh on October 18, 2019, 02:01:15 PM
Handbrake won't encode huge resolutions with nvenc h.264 either btw.
I was talking about CRF values.
Quote
-crf replaced by -cq but the quality is different between -crf 18 and -cq 18, need further testing
-qp also works for me. Normally the value ~23 works well for 1080p.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on October 19, 2019, 10:23:18 AM
QuoteI was talking about CRF values.
Right, we were talking about a gui implementation of that particular feature, I got you. I was just pointing something related to Handbrake, I should have rephrased it.

Quote-qp also works for me. Normally the value ~23 works well for 1080p.
So there's those options to check for quality comparison to match libx264 and libx265 crf values of 18 and 24 (those of MLV-App's by default).
                         :
-rc                <int>        E..V..... Override the preset rate-control (from -1 to INT_MAX) (default -1)
     constqp                      E..V..... Constant QP mode
     vbr                          E..V..... Variable bitrate mode
     cbr                          E..V..... Constant bitrate mode
     cbr_ld_hq                    E..V..... Constant bitrate low delay high quality mode
     cbr_hq                       E..V..... Constant bitrate high quality mode
     vbr_hq                       E..V..... Variable bitrate high quality mode
-cq                <float>      E..V..... Set target quality level (0 to 51, 0 means automatic) for constant quality mode in VBR rate control (from 0 to 51) (default 0)
-qp                <int>        E..V..... Constant quantization parameter rate control method (from -1 to 51) (default -1)

I was reading this https://www.pixeltools.com/rate_control_paper.html

"[...]the quantization parameter QP can only influence the detail of information carried in the transformed residuals. QP has no direct effect on the bitrates associated with overhead, prediction data, or motion vectors. The Mean Average Difference (or MAD) of the prediction error is used for this purpose. [...] Small values of QP more accurately approximate the block's spatial frequency spectrum, but at the cost of more bits. In H.264, each unit increase of QP lengthens the step size by 12% and reduces the bitrate by roughly 12%."

and this https://slhck.info/video/2017/03/01/rate-control.html

"The Quantization Parameter controls the amount of compression for every Macroblock in a frame. Large values mean that there will be higher quantization, more compression, and lower quality. Lower values mean the opposite. [...] Unless you know what you're doing and you explicitly want this, do not use this mode! Setting a fixed QP means that the resulting bitrate will be varying strongly depending on each scene's complexity, and it will result in rather inefficient encodes for your input video. You may waste space and you have no control of the actual bitrate."

Correct me if I'm wrong, -cq is a constant quality value while -qp and -rc constqp are constant quantization parameters.
As for a starting point for comparison there's those values.

"[...] In H.264 and H.265, CRF ranges from 0 to 51 (like the QP). 23 is a good default for x264, and 28 is the default for x265. 18 (or 24 for x265) should be visually transparent; anything lower will probably just waste file size. Values of ±6 will result in about half or twice the original bitrate. For VP9, the CRF can be from 0 to 63. Recommended values are from 15–35."

Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on October 19, 2019, 10:35:17 AM
https://slhck.info/video/2017/02/24/crf-guide.html
The CRF versus Constant QP part is pretty interresting too.
The author equates CRF to constant quality.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on October 19, 2019, 07:55:23 PM
I did some testing, results are there https://github.com/ilia3101/MLV-App/issues/78#issuecomment-544179865
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 20, 2019, 01:11:53 PM
Quote from: Luther on October 15, 2019, 01:56:22 AM
...I also changed the AP0 matrix to the AP1 in processing.c:

1.6410233797, -0.3248032942, -0.2364246952
-0.6636628587, 1.6153315917, 0.0167563477
0.0117218943, -0.0082844420, 0.9883948585

This gave me the best color results so far. Please test it too...
I added ACES AP1 as additional processing gamut to our repository. Thank you.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on October 20, 2019, 01:48:38 PM
Quote from: masc on October 20, 2019, 01:11:53 PM
I added ACES AP1 as additional processing gamut to our repository. Thank you.
Nice, thanks @masc!
Title: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 20, 2019, 07:09:10 PM
Nice request @Luther. Thanks @masc for the quick add-on. Sorry for the off-topic but I'm trying to get compiling to work on this mad oldie.

However, keep in mind this is not a priority since this is just a 3rd back up to my so called lab. Running El Captain on this miserable 2007 15" MBP which is still running pretty strong for it's age.

This is probably to be expected but after installing QT 5.6.0 to make my compiling environment work on this which seems to not allow for 10.11 according to the prompt message via Command Line in Terminal. Samples below.

(https://live.staticflickr.com/65535/48930019633_c58715d0f1.jpg) (https://flic.kr/p/2hxM99a) (https://live.staticflickr.com/65535/48930746272_203fc01269.jpg) (https://flic.kr/p/2hxQS9q)

As we know when reading the instructions via Mlv_App_compiler it states that it be can be used for OS X running 10.10 & onward when selecting 'op' via Command Line. What gives?

I've also ran through the script install 'U' three times in the last 24 hours to be sure it wasn't an user error. Even though it still could very well be.  ::)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 20, 2019, 08:24:48 PM
@DeafEyeJedi: I am working on a MBP 13" 2010 with OSX Mavericks (10.9.5). I use Qt 5.6.0 on it and it works like a charme. I installed Qt manually with a download from the Qt page, installed command line tools from OSX and installed a openMP-compiler with brew.
https://download.qt.io/archive/qt/5.6/5.6.0/
Install the compilers first to make sure Qt finds them on first start.
The official download should also run on your MacBook (does it?). Have it running here on Mavericks and El Capitan. I've just no luck on Snow Leopard, on my older MacBook White 2008.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ozcancelik on October 20, 2019, 11:40:05 PM
First of all, thank you for your effort.

I have a issue. I have two separate laptops. One is Macbook Pro and one is Hp gaming notebook. On both computers, when you export the same file in the Windows environment with the same settings, the slower macbook pro(bootcamp windows) export faster. On macbook pro  it takes 5 minutes, HP Notebook takes 11 minutes. Also Hp Notebook has faster CPU and also has GPU.

When I check task manager, the only difference between them is CPU usage. The Macbook Pro uses 100% CPU when exporting and Hp uses 40-50% CPU. Why is this problem caused?

Thank you.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 21, 2019, 11:31:57 AM
Without knowing any real facts about your two computers, I suppose some settings to be different, e.g. in receipt. If the CPU is not used at (close to) 100%, you rendered dualISO, or used Highlights/Shadows/Clarity/RBF Denoiser. These algorithms are single threaded. So if the MacBook has 100%, it could have only one or two cores, or the settings used there don't use the points mentioned. The GPU don't cares, because it is not used.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on October 21, 2019, 11:52:54 AM
Slightly off topic ...
I wonder how hard is to include Photo Color Editing within the MLVApp.
The color processing looks superior than native Adobe's.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 21, 2019, 12:58:39 PM
Ilia3101 is working on a solution:
https://www.magiclantern.fm/forum/index.php?topic=24386.msg221470;topicseen#msg221470
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 21, 2019, 04:15:55 PM
Quote from: Quentin on October 21, 2019, 11:52:54 AM
I wonder how hard is to include Photo Color Editing within the MLVApp.
You can already do this... but it is still a bit tricky. As Danne wrote: Ilia is starting the development needed for that. You can already load and compile "libMLV" (with a small example app) and transcode many RAW photo formats to MLV (Ilia even converted a Nikon file). This file can then be loaded into MLVApp, processed and exported as JPEG or PNG. I tried it with a CR2 from my 5D2 and it was working.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 21, 2019, 06:04:11 PM
Oh wow. It´s working. And fast too. It wrapped my CR2 into mlv and opens up beautifully in mv app. Super!!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 21, 2019, 06:26:31 PM
Nice. I wrapped a dual iso cr2 into MLV iso 100/1600. ENabled force dualiso and voila!
(https://i.postimg.cc/HL0c0ZBS/Screenshot-2019-10-21-at-18-21-53-png-scaled.png)

(https://i.postimg.cc/43RH9kb7/Screenshot-2019-10-21-at-18-23-42-png-scaled.png)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ozcancelik on October 21, 2019, 10:00:06 PM
Quote from: masc on October 21, 2019, 11:31:57 AM
Without knowing any real facts about your two computers, I suppose some settings to be different, e.g. in receipt. If the CPU is not used at (close to) 100%, you rendered dualISO, or used Highlights/Shadows/Clarity/RBF Denoiser. These algorithms are single threaded. So if the MacBook has 100%, it could have only one or two cores, or the settings used there don't use the points mentioned. The GPU don't cares, because it is not used.

Thank you for information.

Just recorded a new video. Tried export without no configuration. All same didnt touch just export. No Dual ISO. Still use 30% CPU. Maybe it's not about MLVApp but just MLVApp uses 30% CPU. Media Encoder or others have no problem. My CPU is Intel Core i7-8750H 6 cores, 12 threads 2.2 GHz. Maybe you can give me and idea how can I test. Or where is the problem. My fastest notebook works like calculator on MLVApp. Very dramatic for me  :)


Export Settings
(https://i.ibb.co/b1mkBxB/scr-02.png)

CPU Info(Sorry for language)
(https://i.ibb.co/gmcQPnv/scr01.png)



Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 21, 2019, 10:06:58 PM
Tried here on Windows: just imported a MLV, exported to ProRes4444. i7, 4 cores, 8 threads, 3.64GHz, full 100% CPU usage. No idea what your computer does...
Is your files lossless or uncompressed? Lossless decoding is also single-threaded. But this small part should not drop overall usage to 30%. To what codec and option do you export?

Edit: thanks for update. Set smooth aliasing to Off and try again.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ozcancelik on October 21, 2019, 10:12:24 PM
Quote from: masc on October 21, 2019, 10:06:58 PM
Tried here on Windows: just imported a MLV, exported to ProRes4444. i7, 4 cores, 8 threads, 3.64GHz, full 100% CPU usage. No idea what your computer does...
Is your files lossless or uncompressed? Lossless decoding is also single-threaded. But this small part should not drop overall usage to 30%. To what codec and option do you export?

Edit: thanks for update. Set smooth aliasing to Off and try again.

Worked! THANKS. Now it takes 2 minutes to full export. I never touched that pass on other computers.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 21, 2019, 10:21:54 PM
Nice. And another thing: I recommend in export settings to leave debayer at "receipt configuration". Otherwise you might not get what you see in the viewer. In edit settings (receipt) you can choose a different debayer algorithm for each clip in the session, and you are able to choose the best for the currently shown footage. In export settings you can override this for all clips with this little combobox.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 22, 2019, 04:16:15 PM
Quote from: Quentin on October 21, 2019, 11:52:54 AM
Slightly off topic ...
I wonder how hard is to include Photo Color Editing within the MLVApp.
The color processing looks superior than native Adobe's.
Quote from: masc on October 21, 2019, 04:15:55 PM
You can already do this... but it is still a bit tricky. As Danne wrote: Ilia is starting the development needed for that. You can already load and compile "libMLV" (with a small example app) and transcode many RAW photo formats to MLV (Ilia even converted a Nikon file). This file can then be loaded into MLVApp, processed and exported as JPEG or PNG. I tried it with a CR2 from my 5D2 and it was working.
Quote from: Danne on October 21, 2019, 06:04:11 PM
Oh wow. It´s working. And fast too. It wrapped my CR2 into mlv and opens up beautifully in mv app. Super!!

I will compile and upload raw2mlv (https://github.com/ilia3101/LibMLV/blob/master/raw2mlv/raw2mlv.c) for Mac and Linux later today so people can test it. If anyone can do this earlier feel free ;)

Also if someone could look in to windows, see if it compiles on there with mingw, that would be amazing (though I will get to that myself in some time). LibRaw can be downloaded as a compiled bianry for windows, so shouldn't be too hard.

Thank you @Quentin glad to hear you get good colour in MLV App!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 22, 2019, 04:34:00 PM
Quote from: Ilia3101 on October 22, 2019, 04:16:15 PM
I will compile and upload raw2mlv (https://github.com/ilia3101/LibMLV/blob/master/raw2mlv/raw2mlv.c) for Mac and Linux later today so people can test it. If anyone can do this earlier feel free ;)

Would like to help, but there is no MinGW version of LibRAW for download. And I can't get it compiled myself... found no docs howto and I get only errors. On OSX and Linux it is simple as usual.
Edit: got libraw compiled for MinGW now, but I don't get it linked into your project.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on October 22, 2019, 07:49:58 PM
Would love to be able to use canon raw fullres files in mlvapp
masc is it possible to unlock curves so we could set curve like that bold white line i painted ? Right now we can use it like thin one only( with 2 points only).Bold one would let us to adjust white and black levels.I also tried to do it by adding additional point to top and bottom corner( so theres 4) then move that but it becomes S curve not linear.
(http://picplus.ru/img/1910/22/4f129a0a.jpg)
This is what i get with 4 points (s curve instead of linear)
(http://picplus.ru/img/1910/22/089b3ebd.jpg)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on October 22, 2019, 08:34:14 PM
I got raw2mlv.exe compiled and tried some files (a .dng, a .cr2 and a .nef) but the mlv gererated are 0 kb.

I installed minGW, downloaded LibMLV-master
I downloaded, unzipped LibRaw-0.19.5-Win32 renamed it LibRaw and moved it in raw2mlv
I Installed Visual Studio 2013

In minGW prompt:
Windows@ALPHA ~/sources/LibMLV-master/raw2mlv
$ gcc -c -O3 ../LibMLV/MLVFrameUtils.c
$ gcc -c -O3 ../LibMLV/MLVWriter.c
$ gcc -c -O3 raw2mlv.c
$ gcc *.o libraw.lib -o raw2mlv

Once raw2mlv.exe compiled tried different options:
.\raw2mlv.exe .\RAW_CANON_EOS_1DX.CR2 -o test.mlv
.\raw2mlv.exe .\_DSC0217.dng -o test.mlv
.\raw2mlv.exe .\_DSC1537.NEF -o test.mlv
.\raw2mlv.exe .\RAW_CANON_EOS_1DX.CR2 .\RAW_CANON_EOS_1DX.CR2 .\RAW_CANON_EOS_1DX.CR2 -o test.mlv --bitdepth 12 -f 24000 1001

I also tried compiling raw2mlv with different gcc options
$ gcc *.o libraw.lib -o raw2mlv -lm -lgomp -lstdc++
$ gcc *.o libraw.lib -o raw2mlv -lm -lstdc++
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 22, 2019, 08:45:24 PM
You downloaded the Visual Studio binary of LibRAW? Visual Studio is mostly not compatible with minGW. So you have to compile LibRAW with minGW first.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on October 22, 2019, 09:23:05 PM
How do you eliminate Purple Color Fringing when some thin lines against bright sky (pine leaves) have purple edges.
Highlight reconstruction didnt solve the problem.
Native Adobe RAW allows special treatment in such cases where user selects the color range and sensitivity.
Thanks in advance for any help.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 22, 2019, 09:37:40 PM
Quote from: Quentin on October 22, 2019, 09:23:05 PM
How do you eliminate Purple Color Fringing when some thin lines against bright sky (pine leaves) have purple edges.
Highlight reconstruction didnt solve the problem.
Native Adobe RAW allows special treatment in such cases where user selects the color range and sensitivity.
Thanks in advance for any help.
Have you tried HSL elements? You could try to desaturate pink tones.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on October 22, 2019, 09:58:26 PM
If a kid wears pink, it will become gray, i tried that.Best bet for me was to use 12bit on canon m, then i set raw white level properly until pink disappears when i set highlight reconstruction on and highlight to -50, usually i have to lower raw white level from 6000 to 5138.
With 14 bit it didnt want to work.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on October 22, 2019, 10:16:25 PM
I will try that.
In the past, I could easily use Highlight Reconstruction and worked perfectly.
In this case due to thin lines, pink stays there.
I will try to use HSL elements.
In the worst scenario I will use old fashioned Adobe, to see if it gives more flexibility.
Thanks for your constructive input. I will let you know of my conclusions.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 22, 2019, 10:21:20 PM
Quote from: Quentin on October 22, 2019, 10:16:25 PM
In the past, I could easily use Highlight Reconstruction and worked perfectly.
If that worked, it was just luck. Highlight reconstruction interpolates the clipped green channel from blue and red channel. From what I understood, your problem is a kind of lens problem... purple fringing or something like that. So if the green is clipped the same way as in overexposed areas, it might work, else it won't.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on October 22, 2019, 10:30:26 PM
Quote from: masc on October 22, 2019, 08:45:24 PM
You downloaded the Visual Studio binary of LibRAW? Visual Studio is mostly not compatible with minGW. So you have to compile LibRAW with minGW first.
You are right. Well, since I'm lazy, I'll just try with msys2 and report if it's working.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on October 22, 2019, 11:19:03 PM
Quote from: masc on October 22, 2019, 10:21:20 PM
If that worked, it was just luck. Highlight reconstruction interpolates the clipped green channel from blue and red channel. From what I understood, your problem is a kind of lens problem... purple fringing or something like that. So if the green is clipped the same way as in overexposed areas, it might work, else it won't.

It worked. I carefully dragged the purple saturation down while restoring the neighboring color to flat line.
Together with Highlight reduction and Reconstruction, I got pretty satisfactory results compared to previous attempt.
I love this tool  ;)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 26, 2019, 09:24:03 PM
Here´s a workflow if on MacOS Catalina(Catastrophy if you ask me ;)) that utilizes Mlv app to open up CR2 to MLV converted files working with raw2mlv inside Switch(Thanks to Ilia3101):
https://www.magiclantern.fm/forum/index.php?topic=15108.msg221738#msg221738
Title: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on October 27, 2019, 01:06:09 AM
Fantastic work, @Danne! I'm diggin' this progress regardless of how Catastrophy it feels (https://www.magiclantern.fm/forum/index.php?topic=15108.msg221740#msg221740this%20progress%20regardless%20of%20how%20Catastrophy%20it%20feels). Thank YOU!  8)

However, it has caught my attention that if you export the final process image as CinemaDNG it's a corrupted file.

But if exported as a TIFF or PNG which then works fine. Is this to be expected when exporting Photo Files?  :o

(https://live.staticflickr.com/65535/48964859696_be544b7f45.jpg) (https://flic.kr/p/2hARGSU)
(https://live.staticflickr.com/65535/48964278748_34e532f450.jpg) (https://flic.kr/p/2hANJby)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: koopg on October 27, 2019, 01:32:54 PM
great app first of all.

recently I have bought a spider color checker.
it comes with a software that can export color profile for you cam + lens after taking a raw picture of a color plate.
this could be achieved using a  stand alone software or a plug in for lightroom.

is there a possible way to use this color profile under MLV app ?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on October 27, 2019, 04:20:05 PM
masc is there any equivalent in MLVApp that behaves similar to L*a*b adjustments in rawtherapee panel ?

When i move lightness slider down then im gettin nice saturation in shadows instead of regular desaturation when you lower brigtness, i couldnt find that in MLVApp:

(http://picplus.ru/img/1910/27/1904986a.jpg)

rregular exposure adjustment, dark areas become dull and deaturated:
(http://picplus.ru/img/1910/27/466de0ce.jpg)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 27, 2019, 04:54:59 PM
Quote from: 2blackbar on October 27, 2019, 04:20:05 PM
masc is there any equivalent in MLVApp that behaves similar to L*a*b adjustments in rawtherapee panel ?

When i move lightness slider down then im gettin nice saturation in shadows instead of regular desaturation when you lower brigtness, i couldnt find that in MLVApp:
L*a*b does not exist in MLVApp. The only thing I thought about when reading your post was the HSL element "hue vs. luminance", dragging the whole line down. But that looks different.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on October 27, 2019, 05:47:14 PM
Yes i tried that, it looks different , somewhat similar but there are some white artifacts when you go too low, in rawtherapee its fine all the way down.
Does it require some different algorithm ? It looks like the way they lower exposure in movies.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 27, 2019, 05:58:23 PM
Quote from: 2blackbar on October 27, 2019, 05:47:14 PM
Does it require some different algorithm ?
Yes, this would be a new development.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on October 28, 2019, 01:53:27 AM
Maybe if You would be interested with it in the future, here is virtualdub gradation curves filter sourcecode, it has lab color profile and other ones so its easier to lookup the math behind them:
http://members.chello.at/nagiller/vdub/downloads.html
(http://members.chello.at/nagiller/vdub/filters.jpg)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on October 28, 2019, 05:13:06 AM
Quote from: koopg on October 27, 2019, 01:32:54 PM
great app first of all.

recently I have bought a spider color checker.
it comes with a software that can export color profile for you cam + lens after taking a raw picture of a color plate.
this could be achieved using a  stand alone software or a plug in for lightroom.

is there a possible way to use this color profile under MLV app ?

It creates a DCP file @koopg? Currently there's no way to input DCP files in MLVApp. Are you using this to get correct white balance? Try a simple 18% gray card... MLVApp has a WB picker.

Quote from: masc on October 27, 2019, 05:58:23 PM
Yes, this would be a new development.

I requested this before here (https://www.magiclantern.fm/forum/index.php?topic=20025.msg220459#msg220459) and here (https://www.magiclantern.fm/forum/index.php?topic=20025.msg220499#msg220499), but upon some reading of the RT code, the Lab feature requires many core functions. Might be really difficult to adapt it to mlvapp.
@2blackbar The feature CIECAM02 in advanced tab can be a better way to bring correct saturation to shadows. Instead of using a "film-like" curve, try to increase "Brightness + Colorfulness (QM)" in CIECAM first. From my tests, this method of correcting exposure adapts shadow/highlight saturation very well already. Sometimes it's not even necessary to use Lab adjustments...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 29, 2019, 10:16:11 PM
I tried to get a RGB2LAB and LAB2RGB conversion running... the results were not satisfying in any way. Maybe the code I found was not good enough. Who knows.
@Luther: in what application do I find this "advanced tab"? RawTherapee?

If anyone is interested and has not seen it yet: I made a tutorial about a possible workflow between MLVApp and FCPX (Resolve and Vegas should work the same way, but I did not try). It is the workflow I always use and which works fine for me, even in bigger (400GB+ of MLVs) projects. Make sure having subtitles enabled.
https://www.youtube.com/watch?v=dxWJImABSW0
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on October 30, 2019, 12:31:57 AM
Quote from: masc on October 29, 2019, 10:16:11 PM
@Luther: in what application do I find this "advanced tab"? RawTherapee?

Yes:

(https://pictshare.net/boyvpd.png)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 01, 2019, 02:07:54 PM
Found some code for a new feature, tested and added it to MLVApp. Then I modded it a bit to make it even more powerful. It is a CA correction, which works with RGB data. It searches at contrast edges for wrong colors and corrects them. The good thing: this also works for color moiree! This means we now can filter most of the ugly color artifacts in 3x3 lineskipping modes! See here:
Original:
(https://i.ibb.co/NFqFH2d/Bildschirmfoto-2019-11-01-um-14-00-15.png)
Filtered:
(https://i.ibb.co/vQWQ5cD/Bildschirmfoto-2019-11-01-um-14-00-22.png)
Would be cool if you could check out, compile and report your findings!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 01, 2019, 02:09:27 PM
Holy cow  :o...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 01, 2019, 02:35:50 PM
Holy Moly @masc! Had to jump out of bed and compile...  :o

(https://i.ibb.co/Xx0cxFf/Screen-Shot-2019-11-01-at-6-58-10-AM.png)

It's like asking myself... am I still dreaming? That's how good this is!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on November 01, 2019, 03:14:19 PM
Blimey. Play-time!  :D

I made clean, compiled and got no command-line errors but the final compiled app on 10.14.4 has a white line through it, and I get the message 'You can't open the application "MLV App" because it may be damaged or incomplete.'

Any ideas?

Errors:

Undefined symbols for architecture x86_64:
  "_CACorrection", referenced from:
      _applyProcessingObject in raw_processing.o
ld: symbol(s) not found for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [MLV App.app/Contents/MacOS/MLV App] Error 1

Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 01, 2019, 03:21:45 PM
Actually I can second this error @timbytheriver as well!

This very system (10.14.6) compiled just fine few days ago...

I've also tried running 'U' via MLV_App_Compiler which didn't help either.

What gives? Apple can be full of surprises...  :o

(https://i.ibb.co/Syz8Vg1/Screen-Shot-2019-11-01-at-7-24-06-AM.png)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 01, 2019, 03:35:57 PM
So you both can't compile? Hm... strange. Looks like a linker problem. Did you run qmake? I guess you cleaned all before compiling?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on November 01, 2019, 03:37:54 PM
Is qmake the option (op) in the compile app?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 01, 2019, 03:40:34 PM
No idea, I never used the compiler app. QMake is located in the Qt bin folder and has to be run with the file MLVApp/platform/MLVApp.pro. With that Makefile is created / updated. If you have QtCreator, all this works automatically when pressing build button.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 01, 2019, 03:41:04 PM
I usually prefer to run 'op' than 'c' via MLV_App_Compiler just because I feel dandy and more confidence!  :P

Perhaps I should take this issue over to @Danne's MLV_App_Compiler then?

Sorry I had thought this was definitely related to this... who knows? I'll be up either way...  :-X


Thanks @Danne for confirming!  :)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 01, 2019, 03:41:49 PM
Confirm compiling broken due to CACorrection update:
framework QtCore -framework DiskArbitration -framework IOKit -framework OpenGL -framework AGL   
Undefined symbols for architecture x86_64:
  "_CACorrection", referenced from:
      _applyProcessingObject in raw_processing.o
ld: symbol(s) not found for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [MLV App.app/Contents/MacOS/MLV App] Error 1
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 01, 2019, 03:46:45 PM
 ???  ::)  :-[ Höööööö... here it compiles fine. All the includes are there and the ColorAberrationCorrection.o object is also created. This one has the reference which your compilers call "undefined". You find it in "MLV_App/platform/build-MLVApp-Desktop_Qt_x_y_z_....._64bit-Release/.obj/". Don't understand this.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 01, 2019, 03:51:24 PM
Added a "extern" for the reference. Could you try again? (Don't expect any difference, but maybe we've luck.)

Edit: and another one. Is this the only error, or do you see something more?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: whitelight on November 01, 2019, 03:53:21 PM
Quote from: masc on November 01, 2019, 02:07:54 PM
Found some code for a new feature, tested and added it to MLVApp. Then I modded it a bit to make it even more powerful. It is a CA correction, which works with RGB data. It searches at contrast edges for wrong colors and corrects them. The good thing: this also works for color moiree! This means we now can filter most of the ugly color artifacts in 3x3 lineskipping modes! See here:
Original:
(https://i.ibb.co/NFqFH2d/Bildschirmfoto-2019-11-01-um-14-00-15.png)
Filtered:
(https://i.ibb.co/vQWQ5cD/Bildschirmfoto-2019-11-01-um-14-00-22.png)
Would be cool if you could check out, compile and report your findings!

AWESOME! I am looking forward to seeing this implemented
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on November 01, 2019, 04:00:39 PM
Same failure:


Undefined symbols for architecture x86_64:
  "_CACorrection", referenced from:
      _applyProcessingObject in raw_processing.o
ld: symbol(s) not found for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [MLV App.app/Contents/MacOS/MLV App] Error 1





Quite a lot of 'Warnings' earlier on in the command line also...

../../src/processing/rbfilter/rbf.h:148:9: warning: expression result unused [-Wunused-value]
        *--temp_x; *temp_x = 0.5f*((*temp_x) + (*--in_x));
et al.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 01, 2019, 04:01:09 PM
Quote from: masc on November 01, 2019, 03:51:24 PM
Added a "extern" for the reference. Could you try again? (Don't expect any difference, but maybe we've luck.)

Edit: and another one. Is this the only error, or do you see something more?
Only error.
Add extern? Where? In code, compiler?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 01, 2019, 04:02:08 PM
I added it. Have you updated your working copy?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on November 01, 2019, 04:05:30 PM
If I try to make-clean I get:

make: make: *** No rule to make target `clean'.  Stop.
rm -rf "MLV App" "MLV App".app main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o llrawproc.o pixelproc.o stripes.o patternnoise.o hist.o dualiso.o avf_lib.o filter.o genann.o blur_threaded.o dng.o darkframe.o camera_id.o audio_mlv.o *.o
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 01, 2019, 04:27:37 PM
Quote from: timbytheriver on November 01, 2019, 04:05:30 PM
If I try to make-clean I get:

make: make: *** No rule to make target `clean'.  Stop.
rm -rf "MLV App" "MLV App".app main.o video_mlv.o debayer.o amaze_demosaic.o raw_processing.o main_methods.o useful_methods.o background_thread.o matrix.o camera_matrices.o frame_caching.o lj92.o session_methods.o delegate.o mlv_view.o llrawproc.o pixelproc.o stripes.o patternnoise.o hist.o dualiso.o avf_lib.o filter.o genann.o blur_threaded.o dng.o darkframe.o camera_id.o audio_mlv.o *.o

Hm, ColorAberrationCorrection.o is missing. But why it is not included in your makefile? QMake would include it (as it does here). Could you check date and time of your Makefile? And if ColorAberrationCorrection.o can be found inside?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on November 01, 2019, 04:32:43 PM
my Makefile inside MLv_app_master folder is dated today 14.58

can only find ColorAberrationCorrection.h in there – no .o
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 01, 2019, 04:37:33 PM
Here a part of what my qmake creates:


####### Output directory

OBJECTS_DIR   = .obj/

####### Files

SOURCES       = ../qt/main.cpp \
../qt/MainWindow.cpp \
../../src/debayer/amaze_demosaic.c \
../../src/debayer/debayer.c \
...
../qt/OverwriteListDialog.cpp \
../qt/PixelMapListDialog.cpp \
../../src/processing/cafilter/ColorAberrationCorrection.c \
../cocoa/avf_lib/avf_lib.m .rcc/qrc_ressources.cpp \
.rcc/qrc_darkstyle.cpp \
.moc/moc_MainWindow.cpp \
.moc/moc_InfoDialog.cpp \
...
OBJECTS       = .obj/main.o \
.obj/MainWindow.o \
.obj/amaze_demosaic.o \
.obj/debayer.o \
...
.obj/OverwriteListDialog.o \
.obj/PixelMapListDialog.o \
.obj/ColorAberrationCorrection.o \
.obj/avf_lib.o \
.obj/qrc_ressources.o \
.obj/qrc_darkstyle.o \
...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 01, 2019, 04:40:42 PM
F***... I got it. I forgot to commit the project file. Sorry guys. Now I am 99.9% sure it works for you!  :P
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on November 01, 2019, 04:50:47 PM
Not fixed here. Same error.


Undefined symbols for architecture x86_64:
  "_CACorrection", referenced from:
      _applyProcessingObject in raw_processing.o
ld: symbol(s) not found for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [MLV App.app/Contents/MacOS/MLV App] Error 1



Makefile:
(https://i.ibb.co/YPGLbV7/Screenshot-2019-11-01-at-15-45-32.png) (https://ibb.co/YPGLbV7)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on November 01, 2019, 05:02:04 PM
Anything here: https://stackoverflow.com/questions/18408531/xcode-build-failure-undefined-symbols-for-architecture-x86-64 ?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 01, 2019, 05:53:20 PM
Quote from: masc on November 01, 2019, 04:40:42 PM
F***... I got it. I forgot to commit the project file. Sorry guys. Now I am 99.9% sure it works for you!  :P

Make that 100% -- genius work and thanks for the quick fix @masc!  8)

(https://i.ibb.co/qJbh831/Screen-Shot-2019-11-01-at-9-50-16-AM.png)

EDIT:

For those who are curious how powerful this new CA Correction addition can be...

https://vimeo.com/370356039

Thanks to @reddeercity for the sample file from 5D2

Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on November 01, 2019, 06:07:09 PM
@masc  Make that 101%! All good now. Many thanks!   :D

*digging out old 5D2 footage of brick walls and roof tiles *  ;D
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: escho on November 01, 2019, 09:53:21 PM
Can´t compile here in openSUSE:

https://seescho.files.wordpress.com/2019/11/screenshot_20191101_214048.jpg

Including stdint.h into src/processing/cafilter/ColorAberrationCorrection.h fixes the problem

Edgar
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 01, 2019, 10:08:21 PM
Thanks Edgar! Always the same problem. These types are known on OSX when including stdlib.h, on other platforms we need stdint.h as well. That's why I forget that every time! I commited that into the repos! Thank you.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: escho on November 01, 2019, 10:33:21 PM
Works. ThankYou!
Edgar
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on November 01, 2019, 10:47:58 PM
Looks amazing.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 01, 2019, 11:02:14 PM
I also added #include <stdint.h> to src\processing\cafilter\ColorAberrationCorrection.c and src\processing\cafilter\ColorAberrationCorrection.h otherwise it wouldn't compile on Windows.

I tried it very quick with amaze and it's definitly the best solution so far. This is a huge improvement in terms of details over IGV. I should probably test with a color chart, check the skin tones and also the noise level on high iso too because it might dual-purpose as a quick denoiser.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on November 02, 2019, 07:00:31 AM
Compiled on Windows 10. Works well. Test taken with 50D (@reddeercity new "4k" build):

Without "CA Desaturate" (click for full-res):
(https://pictshare.net/mf4xid.jpg) (https://pictshare.net/mf4xid.jpg)

With "CA Desaturate":
(https://pictshare.net/w9mwqt.jpg) (https://pictshare.net/w9mwqt.jpg)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 02, 2019, 12:26:34 PM
@Luther: did you increase CA radius? Maybe it even becomes better...

Quote from: cmh on November 01, 2019, 11:02:14 PM
... and also the noise level on high iso too because it might dual-purpose as a quick denoiser.
Yes, sometimes it reduces color noise a bit. Therefor luma noise seems to become a little "harder".
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on November 02, 2019, 01:11:35 PM
Quote from: masc on November 02, 2019, 12:26:34 PM
@Luther: did you increase CA radius? Maybe it even becomes better...
I did, but then it starts to desaturate other tones of red and the shades start to blend together. I've also noticed some color shift while using it. Not too bad, but you can notice even on the example posted above (leafs on the left shift green tones to yellow).
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 02, 2019, 01:35:03 PM
Ah okay, so you tried. Yes, you have to take care with your pictures details! I got the best results for threshold 70..95 and radius 1..5.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 05, 2019, 02:05:09 AM
CA correction is doing wonders. A few edge cases:
(https://i.postimg.cc/ncWRFhyH/Screenshot-2019-11-05-at-01-56-26-png-scaled.png)

CA Desaturate Threshold 100
(https://i.postimg.cc/bNrVftFC/Screenshot-2019-11-05-at-01-56-35-png-scaled.png)

(https://i.postimg.cc/3xDLdHh2/Screenshot-2019-11-05-at-01-55-50-png-scaled.png)

CA Desaturate Threshold 100
(https://i.postimg.cc/XvSs5DNm/Screenshot-2019-11-05-at-01-56-02-png-scaled.png)

I skip fix focus pixels and use chroma smooth 3x3 instead here since the neighbouring pixel cloning inherits some new artifacts in this case. Footage from eosm and mcm rewired mode.
Good job masc.
Title: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 05, 2019, 04:30:11 AM
These are wonderful examples @Danne and I def agree that @masc got this one down so brilliantly well w CA Desat!

Quote from: Danne on November 05, 2019, 02:05:09 AM
I skip fix focus pixels and use chroma smooth 3x3 instead here since the neighbouring pixel cloning inherits some new artifacts in this case re: eosm MCM Rewired


Great call actually!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 05, 2019, 08:05:35 AM
Thanks for the nice words. But I just changed some minor lines and the interface of the implementation I found, to adapt it for MLVApp. The implementation itself was done by someone else, according to this paper:
http://cspl.postech.ac.kr/paper/international%20Journal/2010%20Removing%20chromatic%20aberration%20by%20digital%20image%20processing.pdf
@Danne: the tests are great!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on November 05, 2019, 03:31:20 PM
@Danne wow it's actaully getting rid of those things :o

This might even save reddeercity's 4K modes :D
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 05, 2019, 03:57:41 PM
Quote from: Ilia3101 on November 05, 2019, 03:31:20 PM
@Danne wow it's actaully getting rid of those things :o

This might even save reddeercity's 4K modes :D
Complete badass code. HOw did you get it in there @masc?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 05, 2019, 04:14:32 PM
Quote from: Danne on November 05, 2019, 03:57:41 PM
Complete badass code. HOw did you get it in there @masc?
Quote from: Ilia3101 on November 05, 2019, 03:31:20 PM
@Danne wow it's actaully getting rid of those things :o

This might even save reddeercity's 4K modes :D
The code was already great. The main problem was, it was using openCV and was made for 8bit color. So I changed it to 16bit and implemented the openCV functions by myself (just some standard matrix operations). What the main code base does... no idea... I did not understand and I don't plan to understand. Most important: it seems to do what we need!  :P
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 05, 2019, 05:02:33 PM
Quote from: Ilia3101 on November 05, 2019, 03:31:20 PM
This might even save reddeercity's 4K modes :D

Haha exactly what I had thought too... ;)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: rmp on November 07, 2019, 01:15:11 PM
How does one get mesc's CA addon to work in linux?

My weapon of choice as a begginer in filmaking and the Magic Lantern ecosystem is the 1100d, and, as you can imagine, getting some usable raw video out of this camera has been a (delightful) challenge by itself.

I've been searching this thread for other matters of the raw workflow, but got hung up on the magical CA slidders. How can a linux novice get them in mlv app?

Thank you for any clarifications.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 08, 2019, 07:15:34 AM
Unlike deafeyejedi´s reports I managed to export a dng file after conversion from CR2 to MLV with Ilia3101 raw2mlv conversion tool just fine. Here´s a CR2 dualiso wrapped into mlv then processed and exported to dng in Mlv App:
(https://i.postimg.cc/qBtXB3Dh/Ska-rmavbild-2019-11-08-kl-07-06-18-png-scaled.png)

One feature not in Switch yet is that raw2mlv will cat and output multiple files into one big mlv file if chained up in command line. In practice this means we can collect all dualiso CR2 files into one big mlv, import it into Mlv App and then export every dualiso file indivually into dng files. Works, just tested.
Title: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 08, 2019, 11:51:50 PM
Quote from: Danne on November 08, 2019, 07:15:34 AM
Unlike deafeyejedi´s reports I managed to export a dng file after conversion from CR2 to MLV with Ilia3101 raw2mlv conversion tool just fine.

WoW. I am puzzled. What were your settings from export within MLV_App to get this valid DNG file to work in Adobe?

Though I dig that Dual-ISO shot of your sexy cat!  8)

BTW, while I am golden on the MBP 13" running MoJave, I am still having issues getting MLV_App_Compiler to work on Catalina via MBP 15".

Please enter your selection number below and press enter:
U

Updating!
xcode-select: error: command line tools are already installed, use "Software Update" to install updates
curl: (35) LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to raw.githubusercontent.com:443
Warning: qt 5.13.1 is already installed and up-to-date
To reinstall 5.13.1, run `brew reinstall qt`
Error: qt5 5.13.1 already installed
fatal: not a git repository (or any of the parent directories): .git


EDIT:

I just randomly decided to delete the MLV_App_Compiler and redownload again from the direct link on OP.

Now it's acting normal with the new updates showing but then I still have this one line of unable to access error on top...

(https://pictshare.net/53c4a3.png)

DeafEyeJedi@Apples-Macintosh-10 ~ % /Users/appleuser/Desktop/Mlv_App_compiler.app/Contents/main.command ; exit;
updating MLV-App-master source
fatal: unable to access 'https://github.com/ilia3101/MLV-App.git/': LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to github.com:443


Just tried to run 'OP' (same results w 'U') and it just skips through with the same error lines of codes below:

Would you like to also add updated focus pixels maps(eosm/100D)? Internet connection needed!
(Y/N)?
y
let´s clean repo first(make clean)!
/Users/appleuser/Desktop/Mlv_App_compiler.app/Contents/main.command: line 276: cd: /Users/appleuser/MLV-App-master/platform/qt/: No such file or directory
make: *** No rule to make target `clean'.  Stop.
/Users/appleuser/Desktop/Mlv_App_compiler.app/Contents/main.command: line 278: cd: /Users/appleuser/MLV-App-master/platform/cocoa/: No such file or directory
make: *** No rule to make target `clean'.  Stop.
Cannot find file: /Users/appleuser/MLV-App-master/platform/qt/MLVApp.pro.


I'm probably bugging you guys to the point where it may seem like a bit irrational on my part. I apologize if that's the case here.

But should I be fiddling around w the source code on my end to fix this within Line 276 & 278 accordingly?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on November 09, 2019, 05:47:47 AM
Quote from: Danne on November 08, 2019, 07:15:34 AM
Unlike deafeyejedi´s reports I managed to export a dng file after conversion from CR2 to MLV with Ilia3101 raw2mlv conversion tool just fine. Here´s a CR2 dualiso wrapped into mlv then processed and exported to dng in Mlv App:

Unfortunately not everybody has knowledge about coding and compiling.
These teasers are provoking me, however I am unable to acclimate  :(
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 09, 2019, 07:15:07 AM
Quote from: Quentin on November 09, 2019, 05:47:47 AM
Unfortunately not everybody has knowledge about coding and compiling.
These teasers are provoking me, however I am unable to acclimate  :(
Anybody can learn but in this case there's already a drag/drop program doing the work so you can stop whining actually and search for that program instead.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on November 09, 2019, 01:32:45 PM
Quote from: Danne on November 09, 2019, 07:15:07 AM
Anybody can learn but in this case there's already a drag/drop program doing the work so you can stop whining actually and search for that program instead.

Any Windows version ?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 09, 2019, 03:40:28 PM
If you can't find it probably not.
What you can do is asking for someone to compile a binary for you at the raw2mlv thread. Maybe you get lucky...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 10, 2019, 12:35:07 PM
Quote from: Danne on November 09, 2019, 03:40:28 PM
What you can do is asking for someone to compile a binary for you at the raw2mlv thread. Maybe you get lucky...
For raw2mlv I had no success yet in getting it compiled on Windows. Problem was the linking between libraw and raw2mlv (somehow it will be possible...).
But you can play with it on Linux or OSX for now.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 10, 2019, 03:48:17 PM
Playing around with an automator app integrating raw2mlv conversion with drag n´drop features:
https://www.magiclantern.fm/forum/index.php?topic=24631.msg222250#msg222250
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on November 11, 2019, 05:00:37 PM
I've noticed that when opening any of my 5D3 files in MLVApp [recently], the black point is always crushed – whatever the state of exposure (over/under).

I always have to raise the toe of the curve just a fraction to clear the 'blue' clipping overlay. I've not really thought twice about it until now, but long term I wonder if it may be something in the camera I need to adjust. Any ideas?

Thanks!


EDIT Ignore this post. Brain fart... ::) Sorry for troubling!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 11, 2019, 05:10:45 PM
More info and a mlv file with clear visuals of what's going on?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 11, 2019, 10:22:03 PM
Sorry to be the party pooper but has anyone running on Catalina OS X able to confirm that it is possible compile from @Danne's MLV_App_compiler or not yet?

xcode-select: error: command line tools are already installed, use "Software Update" to install updates
curl: (35) LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to raw.githubusercontent.com:443
Warning: qt 5.13.1 is already installed and up-to-date
To reinstall 5.13.1, run `brew reinstall qt`
Error: qt5 5.13.1 already installed
fatal: not a git repository (or any of the parent directories): .git


I am still fiddling around trying to get this to work on MBP 15" running 10.15.1 and updated command line tools to 11.2 which didn't seem to help resolve this either.  :-X
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 11, 2019, 10:39:10 PM
I compile on catalina but I already had the dependencies installed from before. When you read this:
fatal: not a git repository (or any of the parent directories): .git
Means you are not in a git repository. Probably Mlv App code hasn´t been downloaded for some reason. So if you can´t solve why yourself you´ll need some teamviewer session probably to break down what´s happening.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 11, 2019, 10:47:26 PM
Thanks for the follow-up @Danne. That's great to know that you've updated to Catalina. Pretty surprising though. Ha.  ;D

That's what strange about this because before I had updated to Catalina which was compiling just fine w all dependencies from before.

I don't mind doing a teamviewer session if you (or anyone) that has time to make this happen. Shouldn't take too long. No rush though!

Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 11, 2019, 11:11:28 PM
Did this?
chsh -s /bin/sh


If you do this in terminal:
open ~/MLV-App-master
What happens?

You could try and erase
MLV-App-master folder from your USER section and the just rerun Mlv_app_compiler.app again. It should redownload a fresh repository.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 12, 2019, 12:08:44 AM
Quote from: Danne on November 11, 2019, 11:11:28 PM
Did this?
chsh -s /bin/sh

Yep. Just tried again and it asked for my password. Inserted. Seems already done.

Quote from: Danne on November 11, 2019, 11:11:28 PM
If you do this in terminal:
open ~/MLV-App-master
What happens?

Prompted me with this: The file /Users/appleuser/MLV-App-master does not exist.

Quote from: Danne on November 11, 2019, 11:11:28 PM
You could try and erase
MLV-App-master folder from your USER section and the just rerun Mlv_app_compiler.app again. It should redownload a fresh repository.

Though I had done this over the weekend to no avail. Will try this again now that I've re-ran the -s /bin/sh code above.

EDIT:

I just deleted the MLV_App_master folder from the USER section. Re-ran the MLV_App_compiler.app again to no avail.

It just seems like it's not linked or is missing a certain folder?

I also created a new folder under USER w the same name as the one that was just deleted but doesn't seem to do anything either?

Because re-running the compiler.app doesn't seem to re-create a new repository. I'm gonna restart this MBP atm.  :o
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 12, 2019, 05:22:24 AM
Quote from: DeafEyeJedi on November 12, 2019, 12:08:44 AM
I just deleted the MLV_App_master folder from the USER section. Re-ran the MLV_App_compiler.app again to no avail.
Where exactly was the MLV_App_master folder before you erased it? Full link please

Quote from: DeafEyeJedi on November 12, 2019, 12:08:44 AM
Prompted me with this: The file /Users/appleuser/MLV-App-master does not exist.
This means MLV-App-master has been downloaded to some other place or not at all for some reason. Let´s investigate.

Test following:
git clone https://github.com/ilia3101/MLV-App.git MLV-App-master
Where exactly is MLV-App-master being downloaded when runing above command? Full link please.

Last test. In Mlv_App_compiler.app go inside by Show Package Contents by right clicking the app and open up the main.command inside Contents folder file with a text editor. Replace following line:
git clone https://github.com/ilia3101/MLV-App.git MLV-App-master
with:
git clone https://github.com/ilia3101/MLV-App.git ~/MLV-App-master
Now run Mlv_App_compiler.app again
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 12, 2019, 07:13:08 AM
Quote from: Danne on November 12, 2019, 05:22:24 AM
Where exactly was the MLV_App_master folder before you erased it? Full link please

It was next to where all the other repositories are as usual.

Quote from: Danne on November 12, 2019, 05:22:24 AM
This means MLV-App-master has been downloaded to some other place or not at all for some reason. Let´s investigate.

Makes sense. In it for the quick ride!

Quote from: Danne on November 12, 2019, 05:22:24 AM
Test following:
git clone https://github.com/ilia3101/MLV-App.git MLV-App-master
Where exactly is MLV-App-master being downloaded when runing above command? Full link please.

Downloaded. Took about 20 seconds or so. Nice.

Apples-Macintosh-10:~ DeafEyeJedi$ git clone https://github.com/ilia3101/MLV-App.git MLV-App-master
Cloning into 'MLV-App-master'...
remote: Enumerating objects: 29, done.
remote: Counting objects: 100% (29/29), done.
remote: Compressing objects: 100% (26/26), done.
remote: Total 12710 (delta 11), reused 16 (delta 3), pack-reused 12681
Receiving objects: 100% (12710/12710), 178.26 MiB | 11.47 MiB/s, done.
Resolving deltas: 100% (9497/9497), done.


Back to where it was or at least should be. Thanks for this!

(https://pictshare.net/mz2x7n.png)

Quote from: Danne on November 12, 2019, 05:22:24 AM
Last test. In Mlv_App_compiler.app go inside by Show Package Contents by right clicking the app and open up the main.command inside Contents folder file with a text editor. Replace following line:
git clone https://github.com/ilia3101/MLV-App.git MLV-App-master
with:
git clone https://github.com/ilia3101/MLV-App.git ~/MLV-App-master
Now run Mlv_App_compiler.app again

Done. Wow. That was it. Now this is getting warmer.  8)

I went ahead and ran 'U' just to be sure it was all up to date before hitting 'OP' via MLV_App_compiler.app and I'm getting this...

fatal: could not read Username for 'https://github.com': terminal prompts disabled
Error: homebrew/homebrew-dupes does not exist! Run 'brew untap homebrew/homebrew-dupes'
Failed during: /usr/local/bin/brew update --force
Warning: qt 5.13.2 is already installed and up-to-date
To reinstall 5.13.2, run `brew reinstall qt`
Error: qt5 5.13.2 already installed
fatal: not a git repository (or any of the parent directories): .git


Spat out an .dmg worth about 9.4 MB though w grey slated icon on top (meaning it's unusable).

(https://pictshare.net/89neau.png)

Seems I'm slightly a bit cooler here now. I'll stand by and try to reread the command lines while I'm at it.

*EDIT*

PM sent. Appreciated @Danne!

*EDIT_II*

I decided to run 'c' (instead of the usual 'op' which then compiled just fine) not sure what could be the culprit.

(https://pictshare.net/hmk3x5.png)

Obviously I'd prefer to run 'op' for the faster export rendering times.

:o


Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 12, 2019, 07:23:37 AM
You have to look in terminal where things go wrong after hitting op. Instead of flooding this thread just pm me the terminal output.

Got this from deafeyejedi:
/usr/local/opt/llvm@7/bin/clang++ -pipe -stdlib=libc++ -fopenmp -ObjC++ -O2 -std=gnu++1y  -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -mmacosx-version-min=10.8 -Wall -W -dM -E -o .moc/moc_predefs.h /usr/local/Cellar/qt/5.13.2/mkspecs/features/data/dummy.cpp
/usr/local/opt/llvm@7/bin/clang++ -c -pipe -stdlib=libc++ -fopenmp -ObjC++ -O2 -std=gnu++1y  -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -mmacosx-version-min=10.8 -Wall -W -fPIC -DQT_DEPRECATED_WARNINGS -DSTDOUT_SILENT -DQT_NO_DEBUG -DQT_MULTIMEDIA_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I../qt -I. -I-I/usr/local/opt/llvm@7/include -I/usr/local/Cellar/qt/5.13.2/lib/QtMultimedia.framework/Headers -I/usr/local/Cellar/qt/5.13.2/lib/QtWidgets.framework/Headers -I/usr/local/Cellar/qt/5.13.2/lib/QtGui.framework/Headers -I/usr/local/Cellar/qt/5.13.2/lib/QtNetwork.framework/Headers -I/usr/local/Cellar/qt/5.13.2/lib/QtCore.framework/Headers -I.moc -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/OpenGL.framework/Headers -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AGL.framework/Headers -I.ui -I/usr/local/Cellar/qt/5.13.2/mkspecs/macx-clang -F/usr/local/Cellar/qt/5.13.2/lib -o .obj/qrc_ressources.o .rcc/qrc_ressources.cpp
/usr/local/opt/llvm@7/bin/clang++ -c -pipe -stdlib=libc++ -fopenmp -ObjC++ -O2 -std=gnu++1y  -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -mmacosx-version-min=10.8 -Wall -W -fPIC -DQT_DEPRECATED_WARNINGS -DSTDOUT_SILENT -DQT_NO_DEBUG -DQT_MULTIMEDIA_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I../qt -I. -I-I/usr/local/opt/llvm@7/include -I/usr/local/Cellar/qt/5.13.2/lib/QtMultimedia.framework/Headers -I/usr/local/Cellar/qt/5.13.2/lib/QtWidgets.framework/Headers -I/usr/local/Cellar/qt/5.13.2/lib/QtGui.framework/Headers -I/usr/local/Cellar/qt/5.13.2/lib/QtNetwork.framework/Headers -I/usr/local/Cellar/qt/5.13.2/lib/QtCore.framework/Headers -I.moc -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/OpenGL.framework/Headers -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AGL.framework/Headers -I.ui -I/usr/local/Cellar/qt/5.13.2/mkspecs/macx-clang -F/usr/local/Cellar/qt/5.13.2/lib -o .obj/qrc_darkstyle.o .rcc/qrc_darkstyle.cpp
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:12:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKitErrors.h:10:1: error:
      expected '('
API_UNAVAILABLE_BEGIN(ios)
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:104:40: note:
      expanded from macro 'API_UNAVAILABLE_BEGIN'
    #define API_UNAVAILABLE_BEGIN(...) _Pragma("clang attribute push") __API_UNAVAILABLE_BEG...
                                       ^
<scratch space>:92:22: note: expanded from here
clang attribute push
                     ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:12:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKitErrors.h:10:1: error:
      expected 'push' or 'pop' after '#pragma clang attribute'
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:104:273: note:
      expanded from macro 'API_UNAVAILABLE_BEGIN'
  ...__API_UNAVAILABLE_BEGIN4, __API_UNAVAILABLE_BEGIN3, __API_UNAVAILABLE_BEGIN2, __API_UNAVAILA...
                                                                                   ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphicsContext.h:9:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphics.h:12:1: error:
      expected '('
API_UNAVAILABLE_BEGIN(ios)
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:104:40: note:
      expanded from macro 'API_UNAVAILABLE_BEGIN'
    #define API_UNAVAILABLE_BEGIN(...) _Pragma("clang attribute push") __API_UNAVAILABLE_BEG...
                                       ^
<scratch space>:108:22: note: expanded from here
clang attribute push
                     ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphicsContext.h:9:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphics.h:12:1: error:
      expected 'push' or 'pop' after '#pragma clang attribute'
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:104:273: note:
      expanded from macro 'API_UNAVAILABLE_BEGIN'
  ...__API_UNAVAILABLE_BEGIN4, __API_UNAVAILABLE_BEGIN3, __API_UNAVAILABLE_BEGIN2, __API_UNAVAILA...
                                                                                   ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:12:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKitErrors.h:53:1: error:
      '#pragma clang attribute pop' with no matching '#pragma clang attribute push'
API_UNAVAILABLE_END
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:105:33: note:
      expanded from macro 'API_UNAVAILABLE_END'
    #define API_UNAVAILABLE_END _Pragma("clang attribute pop")
                                ^
<scratch space>:104:8: note: expanded from here
clang attribute pop
       ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:13:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphicsContext.h:17:1: error:
      expected '('
API_UNAVAILABLE_BEGIN(ios)
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:104:40: note:
      expanded from macro 'API_UNAVAILABLE_BEGIN'
    #define API_UNAVAILABLE_BEGIN(...) _Pragma("clang attribute push") __API_UNAVAILABLE_BEG...
                                       ^
<scratch space>:72:22: note: expanded from here
clang attribute push
                     ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:13:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphicsContext.h:17:1: error:
      expected 'push' or 'pop' after '#pragma clang attribute'
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:104:273: note:
      expanded from macro 'API_UNAVAILABLE_BEGIN'
  ...__API_UNAVAILABLE_BEGIN4, __API_UNAVAILABLE_BEGIN3, __API_UNAVAILABLE_BEGIN2, __API_UNAVAILA...
                                                                                   ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphicsContext.h:9:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphics.h:266:1: error:
      '#pragma clang attribute pop' with no matching '#pragma clang attribute push'
API_UNAVAILABLE_END
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:105:33: note:
      expanded from macro 'API_UNAVAILABLE_END'
    #define API_UNAVAILABLE_END _Pragma("clang attribute pop")
                                ^
<scratch space>:66:8: note: expanded from here
clang attribute pop
       ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:13:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphicsContext.h:115:1: error:
      '#pragma clang attribute pop' with no matching '#pragma clang attribute push'
API_UNAVAILABLE_END
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:105:33: note:
      expanded from macro 'API_UNAVAILABLE_END'
    #define API_UNAVAILABLE_END _Pragma("clang attribute pop")
                                ^
<scratch space>:87:8: note: expanded from here
clang attribute pop
       ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:14:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibility.h:9:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSErrors.h:13:1: error:
      expected '('
API_UNAVAILABLE_BEGIN(ios)
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:104:40: note:
      expanded from macro 'API_UNAVAILABLE_BEGIN'
    #define API_UNAVAILABLE_BEGIN(...) _Pragma("clang attribute push") __API_UNAVAILABLE_BEG...
                                       ^
<scratch space>:93:22: note: expanded from here
clang attribute push
                     ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:14:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibility.h:9:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSErrors.h:13:1: error:
      expected 'push' or 'pop' after '#pragma clang attribute'
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:104:273: note:
      expanded from macro 'API_UNAVAILABLE_BEGIN'
  ...__API_UNAVAILABLE_BEGIN4, __API_UNAVAILABLE_BEGIN3, __API_UNAVAILABLE_BEGIN2, __API_UNAVAILA...
                                                                                   ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:14:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibility.h:12:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibilityConstants.h:11:1: error:
      expected '('
API_UNAVAILABLE_BEGIN(ios)
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:104:40: note:
      expanded from macro 'API_UNAVAILABLE_BEGIN'
    #define API_UNAVAILABLE_BEGIN(...) _Pragma("clang attribute push") __API_UNAVAILABLE_BEG...
                                       ^
<scratch space>:106:22: note: expanded from here
clang attribute push
                     ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:14:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibility.h:12:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibilityConstants.h:11:1: error:
      expected 'push' or 'pop' after '#pragma clang attribute'
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:104:273: note:
      expanded from macro 'API_UNAVAILABLE_BEGIN'
  ...__API_UNAVAILABLE_BEGIN4, __API_UNAVAILABLE_BEGIN3, __API_UNAVAILABLE_BEGIN2, __API_UNAVAILA...
                                                                                   ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:14:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibility.h:9:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSErrors.h:54:1: error:
      '#pragma clang attribute pop' with no matching '#pragma clang attribute push'
API_UNAVAILABLE_END
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:105:33: note:
      expanded from macro 'API_UNAVAILABLE_END'
    #define API_UNAVAILABLE_END _Pragma("clang attribute pop")
                                ^
<scratch space>:100:8: note: expanded from here
clang attribute pop
       ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:14:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibility.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibilityProtocols.h:10:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibilityCustomAction.h:11:1: error:
      expected '('
API_UNAVAILABLE_BEGIN(ios)
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:104:40: note:
      expanded from macro 'API_UNAVAILABLE_BEGIN'
    #define API_UNAVAILABLE_BEGIN(...) _Pragma("clang attribute push") __API_UNAVAILABLE_BEG...
                                       ^
<scratch space>:98:22: note: expanded from here
clang attribute push
                     ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:14:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibility.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibilityProtocols.h:10:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibilityCustomAction.h:11:1: error:
      expected 'push' or 'pop' after '#pragma clang attribute'
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:104:273: note:
      expanded from macro 'API_UNAVAILABLE_BEGIN'
  ...__API_UNAVAILABLE_BEGIN4, __API_UNAVAILABLE_BEGIN3, __API_UNAVAILABLE_BEGIN2, __API_UNAVAILA...
                                                                                   ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:14:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibility.h:12:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibilityConstants.h:593:1: error:
      '#pragma clang attribute pop' with no matching '#pragma clang attribute push'
API_UNAVAILABLE_END
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:105:33: note:
      expanded from macro 'API_UNAVAILABLE_END'
    #define API_UNAVAILABLE_END _Pragma("clang attribute pop")
                                ^
<scratch space>:92:8: note: expanded from here
clang attribute pop
       ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:14:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibility.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibilityProtocols.h:10:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibilityCustomAction.h:45:1: error:
      '#pragma clang attribute pop' with no matching '#pragma clang attribute push'
API_UNAVAILABLE_END
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:105:33: note:
      expanded from macro 'API_UNAVAILABLE_END'
    #define API_UNAVAILABLE_END _Pragma("clang attribute pop")
                                ^
<scratch space>:105:8: note: expanded from here
clang attribute pop
       ^
In file included from ../cocoa/avf_lib/avf_lib.m:1:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:14:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibility.h:13:
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAccessibilityProtocols.h:15:1: error:
      expected '('
API_UNAVAILABLE_BEGIN(ios)
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/os/availability.h:104:40: note:
      expanded from macro 'API_UNAVAILABLE_BEGIN'
    #define API_UNAVAILABLE_BEGIN(...) _Pragma("clang attribute push") __API_UNAVAILABLE_BEG...
                                       ^
<scratch space>:111:22: note: expanded from here
clang attribute push
                     ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [.obj/avf_lib.o] Error 1
make: *** Waiting for unfinished jobs....
1 warning generated.


scroll upwards to check terminal outcome.

----------------
MLV App compiler(thanks to Ilia3101,masc,bouncyball)
----------------

current branch: master

(c)   compile MLV App
(op)  compile MLV App with openmp(macOS 10.10 and onwards)
(b)   check out branches
(U)   update dependencies(if compiling fails)
(m)   make clean

(q)   quit this compiler

Please enter your selection number below and press enter:


Suggest to uninstall command line tools and reinstall it again...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on November 12, 2019, 04:59:08 PM
Quote from: rmp on November 07, 2019, 01:15:11 PM
How does one get mesc's CA addon to work in linux?

My weapon of choice as a begginer in filmaking and the Magic Lantern ecosystem is the 1100d, and, as you can imagine, getting some usable raw video out of this camera has been a (delightful) challenge by itself.

I've been searching this thread for other matters of the raw workflow, but got hung up on the magical CA slidders. How can a linux novice get them in mlv app?

Thank you for any clarifications.

Someone able to help this guy? His/her post got lost (somehow) during confirmation period.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 12, 2019, 05:11:24 PM
Quote from: Walter Schulz on November 12, 2019, 04:59:08 PM
Someone able to help this guy? His/her post got lost (somehow) during confirmation period.
Oh, thanks Walter, I really haven't read this question.

Quote from: rmp on November 07, 2019, 01:15:11 PM
How does one get mesc's CA addon to work in linux?

My weapon of choice as a begginer in filmaking and the Magic Lantern ecosystem is the 1100d, and, as you can imagine, getting some usable raw video out of this camera has been a (delightful) challenge by itself.

I've been searching this thread for other matters of the raw workflow, but got hung up on the magical CA slidders. How can a linux novice get them in mlv app?

Thank you for any clarifications.

What version do you use? Latest official or latest self-compiled revision? Or do you ask how to compile? Don't really understand your question.

-> For the CA sliders in v1.9: drag them to the left or right and watch carefully what happens. I got best results (wideangle shots with CAs) between 0.5 and 1.0 for "Correction Red". "Correction Blue" did not help me... but who knows, maybe there are shots where this slider helps as well.
-> For latest self-compiled revision: the CA threshold slider has to be setup to the most possible left value where CAs disappear. This should happen mostly between 85..95, but might be different from clip to clip. Radius slider can be used for large CAs. Here values between 1..5 are mostly best.
-> For compiling, see the first post in the thread and you'll find links to instructions for compiling.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 12, 2019, 05:17:12 PM
Well there's the official github page, the instructions are pretty straightforward
https://github.com/ilia3101/MLV-App
but if he can't compile it himself, I think he'd better wait for a bit since they're discussing about a release.
https://github.com/ilia3101/MLV-App/issues/188
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 14, 2019, 10:35:48 PM
Some news for MLVApp. See here: https://www.magiclantern.fm/forum/index.php?topic=24631.msg222424#msg222424
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 14, 2019, 10:43:15 PM
Quote from: masc on November 14, 2019, 10:35:48 PM
Some news for MLVApp. See here: https://www.magiclantern.fm/forum/index.php?topic=24631.msg222424#msg222424
Cool! Thumbs up.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 15, 2019, 10:29:43 PM
MLV App with mlv2raw for Windows 64-bit for testing.
This is not a release.

Changelog:

2019-11-16
Static build of MLV App
Github: Added supported extensions for raw2mlv (Sony raw included)
Added a missing dll to raw2mlv

2019-11-15
Github: Added single frame jpg export.
Github: Added raw2mlv transcoding dialog.


(https://imgur.com/C4RhBI1.jpg)
(https://imgur.com/lBEEDB3.jpg)

Download:
https://github.com/cmhamiche/mlvapp_win/raw/master/MLVApp.v1.9_static_Win64_raw2mlv.zip

Credit goes to this people:
https://github.com/ilia3101/MLV-App/graphs/contributors

Note:
Quote from: mascall frames MUST have the same resolution (just a note if they don't have, when creating a MLV before with different pictures).
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yokashin on November 15, 2019, 10:45:22 PM
Thank You all!
For applications and new functions.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on November 16, 2019, 04:56:10 AM
Awesome. Thank you
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: andy kh on November 16, 2019, 10:56:28 AM
fantastic job tested on win10 works great
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 16, 2019, 05:24:14 PM
New build at https://www.magiclantern.fm/forum/index.php?topic=20025.msg222468#msg222468
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on November 16, 2019, 05:40:42 PM
@cmh and others pushing this along

Many thanks: just downloaded and I'm up and running.

Of course, I've got to understand the interface, but just did a transcode input test with four random images and it worked :-)

My 'only' need at the moment is to then 'merge' those images via a mean or median statistic. But I can see how to do that at the moment  :-[

Once again: thanks for this tool.

Cheers

Garry
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 16, 2019, 05:48:41 PM
@garry23: you can't select between mean or median. It is just mathematically averaged ( (a+b)/2 ).
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on November 16, 2019, 05:51:52 PM
@masc

Sorry I should have been clearer.

Having transcoded, say, 4 cr2s into MLV App, ie I see four 'frames', how do I now simply export these four images into a single tiff, say, either with mean or median statistics?

Cheers

Garry
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 16, 2019, 05:55:59 PM
The only way to get an averaged frame is to export a MLV file with this settings:
(https://i.ibb.co/NjyX1PQ/Bildschirmfoto-2019-11-16-um-17-54-43.png)
Then reimport this MLV and export e.g. as TIFF or DNG or...

Short example with a ~200 frames MLV:
(https://i.ibb.co/StRj9fN/Bildschirmfoto-2019-11-16-um-17-58-51.png)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on November 16, 2019, 06:14:30 PM
@masc

Many thanks for the insight.

I'll play around and see what I get  ;)

Hopefully I won't need to ask for help again...or too often  ;D

Cheers

Garry
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on November 16, 2019, 06:22:16 PM
Ok I'm inpatient and an idiot!!!!

All I get when I export is a load of individual frames.

I don't get a single mlv of the averaged images: which is what I thought I would get.

As I say, I'm stupid and I don't do video  :o

Cheers

Garry
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 16, 2019, 06:22:50 PM
@garry23
Quote from: mascall frames MUST have the same resolution (just a note if they don't have, when creating a MLV before with different pictures).

I thought that it should be mentioned.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on November 16, 2019, 06:30:46 PM
@cmh

Yes understood and they are, ie I'm just taking three random cr2s without any post processing and transcoding into the App.

I see the three images.

Select the averaged setting and mlv.

But then what to create the averaged effect I'm after.

Sorry for being stupid.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 16, 2019, 06:51:02 PM
Upload your three cr2 files or mlv sequence here.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 16, 2019, 06:52:24 PM
Quote from: garry23 on November 16, 2019, 06:30:46 PM
@cmh
But then what to create the averaged effect I'm after.

I'll make a quick video just for you. Give me a sec...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 16, 2019, 06:52:46 PM
@garry23:
- import your MLV with individual frames
- setup the export settings: "MLV" and "Averaged Frame"
- export (File -> Export Selected Clips) (ah... and select it before in the session viewer)
- import the exported file
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 16, 2019, 07:26:06 PM
@garry23, here it is:

Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 16, 2019, 07:26:28 PM
Nice that you included mlv_dump averaging. Just ran anamorphic full sensor readout(eosm) at iso 1600 and full range shutter and averaged 45 frames(not using raw2mlv in this example):
crop(one frame)
(https://i.postimg.cc/RZjcNbGT/Screenshot-2019-11-16-at-19-21-26-png-scaled.png)

crop(averaged frames)
(https://i.postimg.cc/ydKcTgMg/Screenshot-2019-11-16-at-19-21-34-png-scaled.png)


Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on November 16, 2019, 10:28:11 PM
@cmh

Quote@garry23, here it is:

Many thanks for taking the trouble to show me where I was going wrong.

Looking forward to doing some experimenting.

Cheers

Garry
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 16, 2019, 10:42:34 PM
You're welcome.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 16, 2019, 11:20:55 PM
That´s cool, dcraw version. Tested it @cmh(where did your links go?)?

Here´s another averaging example 114 frames iso 1600 full sensor readout(Mr Hannes got a new friend):
(https://i.postimg.cc/pVzmYTTH/Screenshot-2019-11-16-at-23-09-40-png-scaled.png)

(https://i.postimg.cc/8CY7wfM1/Screenshot-2019-11-16-at-23-09-33-png-scaled.png)

(https://i.postimg.cc/JnykW5MD/Screenshot-2019-11-16-at-23-10-00-png-scaled.png)

Cropped and averaged
(https://i.postimg.cc/s2xBp4B6/Screenshot-2019-11-16-at-23-10-07-png-scaled.png)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 16, 2019, 11:48:18 PM
Also. Asked masc about adding tblend averaging(ffmpeg) straight from mlv and it´s in. FFmpeg averaging is handling different exposures way better than mlv_dump averaging. So compile and then choose TIFF as codec, then averaging and the whole mlv will be baked into one tiff file. Really cool.
EDIT: Seems the tiff averagin only averages the first two files. Needs some more investigating.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 17, 2019, 12:01:19 PM
Quote from: Danne on November 16, 2019, 11:20:55 PM
That´s cool, dcraw version. Tested it @cmh(where did your links go?)?

I thought that it was off topic and decided to remove them since it concerns another software, another camera brand and another raw format.
The hardware pixel shift feature in and of itself is gimmicky but the point was that on RawTherapee's side, the creation of a mask to remove motion artifacts is a simple but briliant idea.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 17, 2019, 01:25:50 PM
Hello guys!

I can admit I can see tremendous progress(es) all around :D

br
bb
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 17, 2019, 10:12:14 PM
ffmpeg tmix filter added to average a bunch of frames:
https://ffmpeg.org/ffmpeg-filters.html#tmix
Maximum 128 to be exact. masc implemented this today.

What differs from mlv_dump averaging? Try exposure shifts like in the example and you´re in for some nice pink clipping but this is not the case with the tmix filter. Well, probably different methods but still. Good to have both.

So select codec "TIFF" than average:
(https://i.postimg.cc/wMjn8xwC/Screenshot-2019-11-17-at-22-05-51-png-scaled.png)

Here are my files(cr2 wrapped into one mlv. Courtesy Ilia3101 raw2mlv):
(https://i.postimg.cc/bNQ1c0tj/gitarr-000000-tif-500px.png)

(https://i.postimg.cc/hPFV5Zhr/gitarr-000001-tif-500px.png)

(https://i.postimg.cc/zG8KJLCH/gitarr-000002-tif-500px.png)

(https://i.postimg.cc/kGSK5KYK/gitarr-000003-tif-500px.png)

(https://i.postimg.cc/NMSRYpDQ/gitarr-000004-tif-500px.png)

After averaging above frames out comes a 100mb tif file:
(https://i.postimg.cc/1zMHxGbz/gitarrlog.jpg)

Slight curve added in photoshop:
(https://i.postimg.cc/kM2kcGtS/gitarr.jpg)

Great stuff!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 17, 2019, 10:28:17 PM
Great example, Danne! Thanks for your idea to integrate that!

I hope it also works on Linux and Windows. Can't try here.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 19, 2019, 03:45:16 PM
Works fine on Windows, I'll try on Fedora later.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on November 19, 2019, 08:51:28 PM
That is super cool
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 19, 2019, 09:04:52 PM
It's working on Linux too:

(https://i.imgur.com/paLzO8N.png)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 19, 2019, 09:21:06 PM
Nice!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 19, 2019, 10:12:41 PM
Great. Thanks for testing!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on November 20, 2019, 03:24:58 AM
wOW this thing is like magic, just shot 5 seconds raw on ISO3200 , imported MLV and exported as MLV average frame, reimported that new MLV and was blown away - 0 noise and its super easy , thanks guys ! This can also be done with fullres silent pics.
(https://i111.fastpic.ru/big/2019/1120/a0/ed80cf86ff00999fb621bb7697fbbaa0.gif)
From what i see about 100 frames is enough
What will happen if ill use one photo cloned multiple times and average? Will it do anything to it?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on November 20, 2019, 06:04:02 AM
Quote from: 2blackbar on November 20, 2019, 03:24:58 AM
What will happen if ill use one photo cloned multiple times and average? Will it do anything to it?
Won't have any effect. See:
https://en.wikipedia.org/wiki/Signal_averaging

I've been using HDRMerge for some time on photography, it does the same noise averaging, but while also doing HDR merge. Highly recommend to everyone that likes landscape photography.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 20, 2019, 07:45:58 AM
So glad to see this great old averaging trick (Thanks @Danne) being brought into this already remarkable app. This is all scary good stuff!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on November 20, 2019, 01:05:22 PM
Is there any way to add more grading tools?
For example, I need to lower saturation in darker areas  (Luminance vs Sat) Not sure, if the name is correct

And smth similar to 3 color wheels for Darks, Mids and Highlights. For example, if I change WB to look ok in the mids, sometimes I get greenish highlights or/and pinkish shadows. It would be nice to have such a possibility.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 20, 2019, 06:25:17 PM
Quote from: Dmytro_ua on November 20, 2019, 01:05:22 PM
Is there any way to add more grading tools?

Sure. We can add whatever we like.

Quote from: Dmytro_ua on November 20, 2019, 01:05:22 PM
For example, I need to lower saturation in darker areas  (Luminance vs Sat) Not sure, if the name is correct

Already implemented.
(https://user-images.githubusercontent.com/30245296/69261801-8cae1000-0bc2-11ea-98d9-d28c3e4e4423.png)

Quote from: Dmytro_ua on November 20, 2019, 01:05:22 PM
And smth similar to 3 color wheels for Darks, Mids and Highlights. For example, if I change WB to look ok in the mids, sometimes I get greenish highlights or/and pinkish shadows. It would be nice to have such a possibility.
If you have an algorithm or at least the maths for that, we could complete this feature. The GUI part exists since nearly two years.
(https://user-images.githubusercontent.com/30245296/36062299-ef35af42-0e69-11e8-9a7f-1c462917aba9.png)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mike2000 on November 20, 2019, 07:17:59 PM
I'm using the app, but I am not able to get the right ratio. I should get 1280x544 stretching by 1.67x but the heigh is wrong, I'm using a canon1100d 2:35:1, 1280x326.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 20, 2019, 07:58:32 PM
I did a quick search and found this http://filmicworlds.com/blog/minimal-color-grading-tools/
I don't even know if this is an "accurate" implementation but if you feel like experimenting, here's the source code https://github.com/johnhable/fw-public
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 20, 2019, 08:14:49 PM
@cmh: thanks, haven't seen this before. Looks good. With that someone has just to write a C wrapper (our processing is C, but with a wrapper it is compatible).
Then we need some conversions from vector space to RGB and other direction. :)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on November 20, 2019, 08:30:01 PM
I don't think there's any hope for accuracy once you start using colour wheels
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 20, 2019, 08:36:19 PM
Quote from: Ilia3101 on November 20, 2019, 08:30:01 PM
I don't think there's any hope for accuracy once you start using colour wheels
Yes, that's always what I thought in Resolve - so I nearly never used the wheels for projects.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 20, 2019, 08:42:14 PM
It's nice to hear, I didn't know you had the controls ready.
Edit: Are you guys working in L*a*b* color space ?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 20, 2019, 08:58:02 PM
Quote from: Ilia3101 on November 20, 2019, 08:30:01 PM
I don't think there's any hope for accuracy once you start using colour wheels

Quote from: masc on November 20, 2019, 08:36:19 PM
Yes, that's always what I thought in Resolve - so I nearly never used the wheels for projects.

I'm with you guys on that thought. Ha.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on November 20, 2019, 10:09:32 PM
Quote from: Ilia3101 on November 20, 2019, 08:30:01 PM
I don't think there's any hope for accuracy once you start using colour wheels
Quote from: masc on November 20, 2019, 08:36:19 PM
Yes, that's always what I thought in Resolve - so I nearly never used the wheels for projects.
Quote from: DeafEyeJedi on November 20, 2019, 08:58:02 PM
I'm with you guys on that thought. Ha.

What do you mean by wrong accuracy?
Can you make a color grading not changing colors, saturation, etc.? If you change anything it's already "inaccurate".
For example, how can you achieve very annoying but still very popular Hollywood filmic look with cold shadows and warm highlights without color wheels? Blue shadows, orange highlights.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 20, 2019, 10:18:21 PM
Quote from: Dmytro_ua on November 20, 2019, 10:09:32 PM
For example, how can you achieve very annoying but still very popular Hollywood filmic look with cold shadows and warm highlights without color wheels? Blue shadows, orange highlights.
E.g. Gradation Curve.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 20, 2019, 10:33:23 PM
Personally, I meant the maths behind that particular piece of code. At the end of the day, a colorist is making an artistic choice not an "accurate" choice so to speak.
Now how do you implement that wheel and still get granularity, ease of use vs accuracy compared to let's say, typing numbers in a combobox, to take an extreme example.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 20, 2019, 11:37:57 PM
Quote from: cmh on November 20, 2019, 08:42:14 PM
Edit: Are you guys working in L*a*b* color space ?
Found the answer in mlv_blender, xyz to rgb.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on November 20, 2019, 11:47:48 PM
I'm not against adding colour wheels, I tried to do it before. But definitely never liked any effects they create.

Quote from: Dmytro_ua on November 20, 2019, 10:09:32 PM
Can you make a color grading not changing colors, saturation, etc.? If you change anything it's already "inaccurate".

There's many things that you can change and it's still accurate, I even think you must change stuff to increase accuracy, as monitors have very little dynamic range compared to real life, and you are trying to recreate the way it really looks, but within that very limited range of brightness. I think curves/contrast are necessary, and a little saturation can be as well.

Another example - white balance. Temperatures other than 6504K on the slider makes colours not be their true values... but it only increases accuracy. The intention of white balance is to match the scene's "white" to the "white" of your surroundings (meaning your monitor's white), which is the white colour your eyes are adapted to. It lets you see the differences between colours correctly.

Quote from: cmh on November 20, 2019, 11:37:57 PM
Found the answer in mlv_blender, xyz to rgb.

Every camera/mlv has an XYZ to (camera)RGB matrix which we must use to convert camera native RGB to any other colour space. Notice it's XYZ to RGB, so it must annoyingly be inverted first, then we can convert from XYZ to some standard RGB space like sRGB or rec2020... You can choose this in processing profile settings.

Also a L*a*b stage could be added for any processing effects that need it.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 21, 2019, 12:41:16 AM
Right, makes sense. From sensor's bayer channels, then get stored as XYZ then a transform matrix + secret sauce (aka color science) to any space. Thanks.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on November 21, 2019, 07:24:39 AM
Just a thought.

QuoteAnother example - white balance. Temperatures other than 6504K on the slider makes colours not be their true values...

Don't forget some users may be shooting with an IR converted camera, so colour correction, eg WB, will need extreme shifts and channel swapping.

As a say, just a thought, if one is trying to make this App a killer App  ;)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 21, 2019, 08:05:41 AM
Quote from: masc on November 20, 2019, 08:36:19 PM
Yes, that's always what I thought in Resolve - so I nearly never used the wheels for projects.
Davinci resolve key feature  :P

Not like I am missing creative tools in Mlv App but of course more ways of manipulating color channels are most welcome. I also have a hard time using DR color wheels but I am also a very lazy grader  :P.
Most funny part about DR is that they never put in a white balance picker. I mean, info is all there(rgb) when hovering image but one needs to fiddle with rgb sliders, hovering back and forth.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 21, 2019, 10:36:04 AM
I don't know when they added it but there's a wb picker just below the wheels, next to an 'auto' button.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on November 21, 2019, 11:19:48 AM
Quote from: cmh on November 21, 2019, 10:36:04 AM
I don't know when they added it but there's a wb picker just below the wheels, next to an 'auto' button.

It is there. But I assume it's not RAW

(https://cdn.fstoppers.com/styles/full/s3/media/2017/08/05/how-to-set-white-balance-in-davinci-resolve.jpg)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 21, 2019, 11:22:26 AM
Cool. Will test.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 21, 2019, 11:53:13 AM
Compared to raw sliders, it's pretty bad tbh, like all nodes stuff. Reminds me of how bad I need a color checker.
edit: it's wonky but you can use that wb picker and substract it's value to raw wb. It's not ideal.
If the footage is noisy, I apply a blur before using the picker. (I don't do much color grading tho).
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on November 21, 2019, 12:09:41 PM
Quote from: garry23 on November 21, 2019, 07:24:39 AM
Just a thought.

Don't forget some users may be shooting with an IR converted camera, so colour correction, eg WB, will need extreme shifts and channel swapping.

As a say, just a thought, if one is trying to make this App a killer App  ;)

True, maybe we could have an option where one can enter a custom matrix, which can do both channel swapping and any kind of extreme WB.

Or maybe a raw channel gain option, would be simpler.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mike2000 on November 21, 2019, 02:21:05 PM
Quote from: Mike2000 on November 20, 2019, 07:17:59 PM
I'm using the app, but I am not able to get the right ratio. I should get 1280x544 stretching by 1.67x but the heigh is wrong, I'm using a canon1100d 2:35:1, 1280x326.

I'm searching since two weeks to get some info about that, I searched in the forum but I didn't find anything similar to my problem. I tried again other settings but it doesn't work. Could someone help me? Thanks  :)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on November 21, 2019, 03:15:51 PM
Me too. I don't like 3-way wheels. Everything that can be done in wheels can also be done using curves.
IMO, other things should be priority, such as enhancing the denoiser or adding deconvolution...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 21, 2019, 09:53:41 PM
Quote from: Luther on November 21, 2019, 03:15:51 PM
Me too. I don't like 3-way wheels. Everything that can be done in wheels can also be done using curves.

+1

Quote from: Luther on November 21, 2019, 03:15:51 PM
IMO, other things should be a priority, such as enhancing the denoiser or adding deconvolution...

Agreed.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on November 24, 2019, 06:23:11 PM
Quote from: cmh on November 16, 2019, 05:24:14 PM
New build at https://www.magiclantern.fm/forum/index.php?topic=20025.msg222468#msg222468

Any chance to provide a portrait rotation for stills processing ?
I dont know if the orientation is embedded into the still.
Thanks
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 24, 2019, 06:30:12 PM
Quote from: Mike2000 on November 20, 2019, 07:17:59 PM
I'm using the app, but I am not able to get the right ratio. I should get 1280x544 stretching by 1.67x but the heigh is wrong, I'm using a canon1100d 2:35:1, 1280x326.
Quote from: Mike2000 on November 21, 2019, 02:21:05 PM
I'm searching since two weeks to get some info about that, I searched in the forum but I didn't find anything similar to my problem. I tried again other settings but it doesn't work. Could someone help me? Thanks  :)
Depending on how your camera records, it reads (row,column) 1x1, 3x3 or 5x3. 1x1 and 3x3 don't need stretching, 5x3 needs 1.67x stretching. Maybe you could share a short MLV and we can have a look.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 24, 2019, 06:32:00 PM
Quote from: Quentin on November 24, 2019, 06:23:11 PM
Any chance to provide a portrait rotation for stills processing ?
I dont know if the orientation is embedded into the still.
Thanks
This easy feature is not so easy to implement at this stage of development. We will have to think a lot how to do that without changing too much.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: platu on November 24, 2019, 06:53:53 PM
My workflow involves using MLV App and exporting to Davinci Resolve Studio (using Cinema DNG Fastpass - DaVinci Resolve Naming Scheme.  I know you can see the aperture used in MLV App, but I delete the original MLV files after exporting to Davinci Resolve in order to save drive space.  Unless I'm missing this, is there a way to include the aperture used in the cndg metadata?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 24, 2019, 07:26:17 PM
Quote from: platu on November 24, 2019, 06:53:53 PM
My workflow involves using MLV App and exporting to Davinci Resolve Studio (using Cinema DNG Fastpass - DaVinci Resolve Naming Scheme.  I know you can see the aperture used in MLV App, but I delete the original MLV files after exporting to Davinci Resolve in order to save drive space.  Unless I'm missing this, is there a way to include the aperture used in the cndg metadata?
Aperture is saved into cdng.
(https://i.ibb.co/pZp67xR/Bildschirmfoto-2019-11-24-um-19-25-10.png)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on November 24, 2019, 09:27:41 PM
Hope someone can help.

When I bring an mlv into the app, how do I delete individual frames.

I can step through the mlv, but can't work out how to delete the frame I'm looking at.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 24, 2019, 09:51:20 PM
Quote from: garry23 on November 24, 2019, 09:27:41 PM
When I bring an mlv into the app, how do I delete individual frames.
This is not possible. You can set a cut in and a cut out, then export. But deleting a picture from the middle is not possible.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on November 24, 2019, 09:58:49 PM
@masc

Glad it wasn't me  ;)

The reason I'm asking is that sometimes you get a corrupt frame and for the averaging use case, you wouldn't want that frame to be included.

Would it be too difficult to add such a feature?

BTW I'm currently doing a two step process to arrive at an averaged tiff, ie average the mlv and save it, import the averaged, single frame, mlv and then export as a tiff.

Is there a 'better' way?

Cheers

Garry
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 24, 2019, 10:04:27 PM
There is already a discussion going on. But work hasn't been started.
https://github.com/ilia3101/MLV-App/issues/171
Deleting the frame is a bad idea for video, because audio gets out of sync. For the new photo features it maybe makes more sense...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 25, 2019, 12:08:03 AM
Quote from: garry23 on November 24, 2019, 09:58:49 PM
BTW I'm currently doing a two step process to arrive at an averaged tiff, ie average the mlv and save it, import the averaged, single frame, mlv and then export as a tiff.

Is there a 'better' way?
Select tiff as codec. Under codec select averaged. Export. Done.
If too hard to follow this description check the workflow described averaging iso files coming from the eosm(read a posts a few days ago in the eosm thread).
Or you can search the word tmix and I am certain you'll find out...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on November 25, 2019, 01:22:39 AM
I would suggest something else to fix dropped frames - duplicate feature, which would make a virtual duplicate of the file (the same mlv but different export settings used) This way if frame 22 is pink, you can export first mlv from 0 to 21 then duplicated mlv from 23 to the end, skipping pink frame, of course woud be great if mlvapp could when exporting merge two into one file, or just add numbre to make different name for seciod file .
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on November 25, 2019, 07:57:00 AM
@Danne

As usual thanks for the heads up:

QuoteSelect tiff as codec. Under codec select averaged. Export. Done.

Found the EOSM Post and downloaded the new version of MLV App

QuoteNew version:
https://www.magiclantern.fm/forum/index.php?topic=9741.msg208959#msg208959

- iso averaging helper(more like iso bracket but still...)

But, no TIFF, just TIFF sequence, and the drop down box underneath it is not active. No average option.

Very confused.

Cheers

Garry
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 25, 2019, 08:04:00 AM
Oh, you need to wait for a release or ask for someone to compile a version for you.
Cheers
/D
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on November 25, 2019, 08:20:02 AM
@Danne

Ok, thanks.

I'll wait.

Cheers

Garry
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: platu on November 25, 2019, 04:31:14 PM
Quote from: masc on November 24, 2019, 07:26:17 PM
Aperture is saved into cdng.

That's very helpful, thank you.  I guess what I meant to say is if there was a way to view the aperture from within Davinci Resolve?  Other major EXIF fields show up there (ISO, Focal Length, etc).  It's just aperture that doesn't show, at least for my camera (5D Mark III).
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 25, 2019, 04:40:39 PM
Quote from: platu on November 25, 2019, 04:31:14 PM
That's very helpful, thank you.  I guess what I meant to say is if there was a way to view the aperture from within Davinci Resolve?  Other major EXIF fields show up there (ISO, Focal Length, etc).  It's just aperture that doesn't show, at least for my camera (5D Mark III).
Hm... sry, can't help with Resolve and can't fix Resolve. I can't find that either in their table.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: platu on November 25, 2019, 05:51:46 PM
Quote from: masc on November 25, 2019, 04:40:39 PM
Hm... sry, can't help with Resolve and can't fix Resolve. I can't find that either in their table.

OK... thank you anyway.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mike2000 on November 25, 2019, 05:54:12 PM
Quote from: masc on November 24, 2019, 06:30:12 PM
Depending on how your camera records, it reads (row,column) 1x1, 3x3 or 5x3. 1x1 and 3x3 don't need stretching, 5x3 needs 1.67x stretching. Maybe you could share a short MLV and we can have a look.

Hello, we are talking about this in another post, I don't want to start a new one so I give you the link:
https://www.magiclantern.fm/forum/index.php?topic=1009.1525

Thanks!  :)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 25, 2019, 07:59:00 PM
A new MLVApp version has been released.

New in v1.10:
- Added another CA correction (and color moiree) filter
- Removed ffmpeg rescaling
- Added AVIR rescaling for ffmpeg export
- Added ACES AP1 processing gamut
- Added luminance vs. saturation tool
- Improved quality for HSL tools
- Added TIFF averaged frame export
- Added single frame JPG export
- Some bug fixes and some minor changes

Minimum OS:
- OSX 10.8.5 Mountain Lion
- Windows 7
- Ubuntu 14.04 LTS

Download at https://mlv.app/
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on November 25, 2019, 08:22:25 PM
@masc

Many, many thanks  :)

Just downloaded and tested against my simple needs, ie averaged TIFF.

One question I have is: is there a reason to limit the averaging to 128.

If this is the case, I will need to split out an MLV if it has captured more images and blend then separately together.

At a 1 fps capture, this means I'm limited to a 2min exposure equivalent, ie some 120s.

If it was possible to increase this 128 limit, I would welcome this.

Cheers

Garry
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 25, 2019, 08:31:29 PM
It is not according to tmix filter ffmpeg spec. Think it's mentioned here as well.
Feel free to create a workaround maybe by pipes or modifying ffmpeg source code.
Yeah, I know you are not a videographer and not a coder ;).
But maybe a learner..

...............................
Check this bible:
http://www.astro-electronic.de/FFmpeg_Book.pdf

...............................
Some code:
https://patchwork.ffmpeg.org/patch/8626/
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on November 25, 2019, 08:35:37 PM
Another ouch  ;)

I was only trying to help by providing user feedback.

I truly respect and welcome this development, but will now wait patiently as others develop it according to their needs.

Cheers

Garry
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 25, 2019, 08:41:14 PM
Be sure to keep yourself informed. Most of what´s been asked is already to be found, a little search here or even outside this forum sometimes makes wonders. Or keep asking. Maybe good for keeping things alive, who am I to judge...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Stousen on November 25, 2019, 09:42:08 PM
Quote from: masc on November 25, 2019, 07:59:00 PM
A new MLVApp version has been released.

New in v1.10:
- Added another CA correction (and color moiree) filter
- Removed ffmpeg rescaling
- Added AVIR rescaling for ffmpeg export
- Added ACES AP1 processing gamut
- Added luminance vs. saturation tool
- Improved quality for HSL tools
- Added TIFF averaged frame export
- Added single frame JPG export
- Some bug fixes and some minor changes

Minimum OS:
- OSX 10.8.5 Mountain Lion
- Windows 7
- Ubuntu 14.04 LTS

Download at https://mlv.app/

'NNNNNNNice!!!! :D
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 25, 2019, 09:44:51 PM
Quote from: a1ex on October 15, 2019, 05:37:26 PM
Small bug (?) report.

While trying to identify the root cause of these artifacts (https://www.magiclantern.fm/forum/index.php?topic=24553.0), I've noticed I'm unable to identify ML version used for the original recording. The sample clip shared there appears to be exported from MLV App, and this is the only VERS block I could find:


Block: VERS
  Offset: 0x0000023c
  Number: 8
    Size: 40
    Time: 18446744073709552.000000 ms
  String: 'MLV App version 1.9'


Normally, mlv_rec/mlv_lite are saving extended version info (multiple VERS blocks) about ML core version, alongside with info about modules loaded, including the version of each module.

Based on this, I'd say the preferred way to handle VERS blocks while transcoding is to add the app-specific block on top of existing ones.
@a1ex: Bouncyball was working on a fix for this problem and you could try if it works. It is not yet in the release, but the source is commited to the repos - are you able to compile?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on November 25, 2019, 09:52:20 PM
Quote from: masc on November 25, 2019, 07:59:00 PM
A new MLVApp version has been released.
Great!
Title: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 26, 2019, 12:31:00 AM
When we export JPEG's (JPEG200) it seems to spit out one photo per folder. Is this to be expected?

It would be nice if we can export all the photos into a single folder as opposed to one for each folder.

(https://pictshare.net/mvq8hn.png)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 26, 2019, 08:59:14 AM
Quote from: DeafEyeJedi on November 26, 2019, 12:31:00 AM
When we export JPEG's (JPEG200) it seems to spit out one photo per folder. Is this to be expected?
Not sure about answer, but it looks ridiculous :P
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 26, 2019, 09:06:57 AM
Quote from: masc on November 24, 2019, 10:04:27 PM
There is already a discussion going on. But work hasn't been started.
https://github.com/ilia3101/MLV-App/issues/171
Deleting the frame is a bad idea for video, because audio gets out of sync. For the new photo features it maybe makes more sense...
I've got a simple proposition. Let's assume we are searching for bad/pink frames and there are a FEW of them not many. So we can just manually mark them in the mlvapp as such (bad) frames, save this info to some array and use it during export, skipping or duplicating before/after frame or whatever.

There should be a possibility to auto detect frames like this though, with some % accuracy.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 26, 2019, 10:34:51 AM
Quote from: bouncyball on November 26, 2019, 09:06:57 AM
I've got a simple proposition. Let's assume we are searching for bad/pink frames and there are a FEW of them not many. So we can just manually mark them in the mlvapp as such (bad) frames, save this info to some array and use it during export, skipping or duplicating before/after frame or whatever.

There should be a possibility to auto detect frames like this though, with some % accuracy.
+10
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on November 26, 2019, 11:00:34 AM
Quote from: bouncyball on November 26, 2019, 09:06:57 AM
Let's assume we are searching for bad/pink frames and there are a FEW of them not many.

4 years ago I've had a 20 days project on 3 TB HDD which got damaged on the last day (full of footage). I didn't get a lot of experience those days, so it was the only copy.
After a month of recovery information in a local company I've got all my footage with a lot of bad frames. I had to manually cut all these frames in Premiere.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: histor on November 26, 2019, 11:15:33 AM
There is some open source project with Optical Flow - slowmovideo.granjow.net (http://slowmovideo.granjow.net). Interpolating missing frames may be implementable here too...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 26, 2019, 01:08:04 PM
Quote from: DeafEyeJedi on November 26, 2019, 12:31:00 AM
When we export JPEG's (JPEG200) it seems to spit out one photo per folder. Is this to be expected?

It would be nice if we can export all the photos into a single folder as opposed to one for each folder.

This is to be expected. MLVApp is a video tool. Normally a video has many frames and the frames of one clip are sorted into a folder.

@bouncyball: if I remember right, we discussed this in past... that's the way to go.

@histor: optical flow is not always usable, because it just works for debayered picture data: e.g. exporting cdng is RAW and would not be possible then.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 26, 2019, 01:23:46 PM
Quote from: masc on November 26, 2019, 01:08:04 PM
@histor: optical flow is not always usable, because it just works for debayered picture data: e.g. exporting cdng is RAW and would not be possible then.
Curious how Davinci resolve implements optical flow. Do you know @masc?
https://www.youtube.com/watch?v=gdevOduygro
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Stousen on November 26, 2019, 02:01:57 PM
One thing i thought of when fixing bad pixels yesterday. Is that i could be a nice feature to be able to mask the fix pixel command. So when u are certain of a specific pixel that you want to fix, u dont have to fix the whole frame affecting the whole image, with calculations that could be faulty, on for example reflections in metal etc.
Is
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on November 26, 2019, 02:27:09 PM
Quote from: Danne on November 26, 2019, 01:23:46 PM
Curious how Davinci resolve implements optical flow. Do you know @masc?

As masc said, on "debayered picture data"

But I have suggested a while ago, we can try to interpret bayer as 4 channel image, which would allow optical flow on bayer raw. Haven't tried it of course, but that's what they do for neural networks.


Also who noticed the new url?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 28, 2019, 06:02:00 PM
Quote from: masc on November 26, 2019, 01:08:04 PM
This is to be expected. MLVApp is a video tool. Normally a video has many frames and the frames of one clip are sorted into a folder.
Yes. In case when all MLVs are 1 frame (raw2mlv converted) files. I thought DeafEye was talking about regular MLV exporting to jpeg2000 :D
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 28, 2019, 06:08:28 PM
Quote from: Ilia3101 on November 26, 2019, 02:27:09 PM
Also who noticed the new url?
New URL rocks :)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 28, 2019, 08:17:37 PM
Quote from: Ilia3101 on November 26, 2019, 02:27:09 PM
so who noticed the new url?
GREAT!
Quote from: bouncyball on November 28, 2019, 06:08:28 PM
New URL rocks :)
+10
Title: MLVApp 1.10 Crashing on Windows 10 64 Work-Around
Post by: visionbyeric on November 28, 2019, 08:35:05 PM
I thought I would let anyone else having the issue with MLVApp1.10 crashing on Windows 10 64, that I've been using the MLVApp 1.10 Win32 version on my Windows 10 64 PC and its been working flawlessly so far.

I really enjoy this program and appreciate everyone's work!
Thanks
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 28, 2019, 08:43:07 PM
Quote from: masc on November 28, 2019, 08:17:37 PM
GREAT!+10
What url?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 28, 2019, 08:45:41 PM
Quote from: Danne on November 28, 2019, 08:43:07 PM
What url?
https://mlv.app/
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on November 28, 2019, 09:39:01 PM
 
Quote from: masc on November 28, 2019, 08:45:41 PM
https://mlv.app/
:D
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on November 28, 2019, 10:20:15 PM
Love the simplicity of the new url.. oh so sexy!
Title: Re: MLVApp 1.10 Crashing on Windows 10 64 Work-Around
Post by: bouncyball on November 29, 2019, 10:11:46 AM
Quote from: visionbyeric on November 28, 2019, 08:35:05 PM
I thought I would let anyone else having the issue with MLVApp1.10 crashing on Windows 10 64
Could you be more specific about crashes?
At least:
1. can not be started, crashes imeadiately
2. runs but with random crashes
3. runs but crashes during export
etc...

P.S. Windows 64bit users please report back your experience.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on November 29, 2019, 05:37:41 PM
I fired up a fresh install of windows in a vm and tested 1.10 64 bit static real quick. Importing, moving some sliders, exporting and it didn't crash.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: andy kh on November 29, 2019, 06:07:48 PM
No crash on my win 10 64bits so far
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yokashin on November 29, 2019, 07:05:28 PM
Everything works fine on windows 10 x64.

Thank you very much for the new version!
Greetings to creators and helpers.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on November 29, 2019, 08:37:11 PM
Quote from: bouncyball on November 29, 2019, 10:11:46 AM
P.S. Windows 64bit users please report back your experience.

No crashes here , Windows 10 x64 1903 , it works fine
Title: MLVApp 1.10 Crashing on Windows 10 64 Work-Around
Post by: visionbyeric on November 30, 2019, 01:09:45 AM
I finally got a chance to record what is happening
Usually as soon as I import a MLV file it will crash, as shown in the video below. The last Win64 Version i could user was 1.08



I tried using 1.10 Win32 version and to my surprise, works just fine, not sure if there will be any issues using the Win32 version on a Win64 PC?



Thank You,
Eric
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yokashin on November 30, 2019, 08:42:39 AM
As we are already with error messages ...
It was while on vacation that I encountered something like this:
(https://i.ibb.co/6wMPWTc/Clipboard01.jpg)
I kept the movies on an external disk together with photos in the "zdjęcia" catalog (in Polish).
After returning from vacation, I discovered why all the files did not open :)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 30, 2019, 09:43:29 AM
@yokashin:
thanks for reporting. Opening files from "zdjęcia" folder is a Windows only issue. Works fine here on Mac. Maybe I can debug this when I am back on a Windows PC.

@visionbyeric:
Also thanks for reporting: I remember (it was a very long time ago) we had such issues sometimes - also on Windows only. In past, Windows did not want to give us some kB of RAM memory, even when there were GBs of free memory left. Whyever. It will be hard to debug this, because this only happens sometimes on some single Windows PCs. On exactly these PCs someone must run a debugger and have a look for the line of code, which crashes the app. But even then I can't guaranty that we are able to fix this.
Did the 1.9 64bit (non static) version run? If not, you could try to install Qt with MinGW64 compiler + Debugger, compile the code, run via debugger and tell us where it crashes. No coding skills needed.
There is no issue running the 32bit version on a 64bit system. It just is not the optimum, so you'll loose one or two frames per second in maximum render speed.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on November 30, 2019, 01:09:31 PM
Yes @masc's right. Please try 1.9 non static 64 build and report back.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: visionbyeric on November 30, 2019, 11:50:23 PM


I installed Qt Creator 4.10.2 (Community), I don't know what to do next. I don't know how to compile and debug it. If someone is wants to tell me what I need to do, I'm willing to compile and debug it.

Thanks,

Eric
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on December 01, 2019, 01:25:49 AM
you mean you want to compile windows version ?
Its easy just download qt 13.2, thats the one i have, and open mlvapp.pro in it, then set it up so its using mingw, it will probably do it on its own afair.
Its preconfigured for you.
ITs about 7GB of data.
Mi pomogl uzytkownik cmh ale w sumie samo sie wszystko poustawialo tylko rzy instalacji qt trzeba zaznaczyc mingw
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on December 01, 2019, 01:42:41 AM
Quote from: 2blackbar on December 01, 2019, 01:25:49 AM
you mean you want to compile windows version ?

See reply 3705. I think he's following imstructions given there.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 01, 2019, 09:35:10 AM
Quote from: visionbyeric on November 30, 2019, 11:50:23 PM
I installed Qt Creator 4.10.2 (Community), I don't know what to do next. I don't know how to compile and debug it. If someone is wants to tell me what I need to do, I'm willing to compile and debug it.
Quote from: 2blackbar on December 01, 2019, 01:25:49 AM
Its easy just download qt 13.2, ...
Did you install also the framework or only Creator? You'll need (only) Creator+MinGW64+Qt5.13.2(this one I tried and it works fine over here for MLVApp).
To compile:
- Download source archive here: https://github.com/ilia3101/MLV-App
- Unzip, and open MLVApp/platform/qt/MLVApp.pro
- Creator will ask howto configure... make sure a MinGW64 toolchain is checked (at least with Debug and Release)
- at the left bottom there is a "computer" icon: choose "Debug"
- at the left bottom there is a green "play" icon: press it, now it compiles, when successfully finished MLVApp starts automatically
For debugging:
- press the green "play" button with the bug insteady of the button without bug
The debug version will be way slower then the release version, but you're able to get the line of code where the app crashes.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: domasa on December 01, 2019, 12:37:03 PM
I have problem with import file. How can I fix it?
(https://i.ibb.co/f010myV/invalid.png)
MLV Error
Invalid blockSize '0', corrupted file:  V:\video\M21-1645.MLV


Thanks for the help!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 01, 2019, 01:07:06 PM
Quote from: domasa on December 01, 2019, 12:37:03 PM
I have problem with import file. How can I fix it?
MLV Error
Invalid blockSize '0', corrupted file:  V:\video\M21-1645.MLV

Your file contains data, but no header. So MLVApp has no information what to do with all the data. Some months ago someone had the same problem and there was a (modified?) mlv_dump way to insert some header info...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on December 01, 2019, 06:13:36 PM
I installed everything you mentioned.
Just opened mlvapp to do changes to h264 compression ( gave it 13 instgead of 14)then compiled release , thanks !
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: domasa on December 01, 2019, 10:38:17 PM
Quote from: domasa on December 01, 2019, 12:37:03 PM
MLV Error
Invalid blockSize '0', corrupted file:  V:\video\M21-1645.MLV

I fixed it with mlvfs.exe (version "May 6 2017").
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 02, 2019, 06:49:07 AM
Quote from: domasa on December 01, 2019, 10:38:17 PM
I fixed it with mlvfs.exe (version "May 6 2017").
Strange. Give me that MLV to debug this issue please.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: a1ex on December 02, 2019, 10:29:10 AM
Quote from: masc on November 25, 2019, 09:44:51 PM
@a1ex: Bouncyball was working on a fix for this problem and you could try if it works. It is not yet in the release, but the source is commited to the repos - are you able to compile?

Yes. The fix appears to work; here's a sample file, exported twice:


Block: VERS
  Offset: 0x0000023c
  Number: 8
    Size: 119
    Time: 18446744073709552.000000 ms
  String: 'exported by MLV App version 1.10 on 10:08:23 Dec  2 2019; export mode: MLV_FAST_PASS (audio: OFF) '
Block: VERS
  Offset: 0x000002b3
  Number: 9
    Size: 119
    Time: 18446744073709552.000000 ms
  String: 'exported by MLV App version 1.10 on 10:07:33 Dec  2 2019; export mode: MLV_FAST_PASS (audio: OFF) '
Block: VERS
  Offset: 0x0000032a
  Number: 10
    Size: 40
    Time: 18446744073709552.000000 ms
  String: 'MLV App version 1.9'


I had some trouble figuring out how to select a part of the MLV file for export, but eventually found the Cut In & Cut Out dialog on the right side :)

Thumbs up for now :)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: domasa on December 02, 2019, 03:30:30 PM
Quote from: bouncyball on December 02, 2019, 06:49:07 AM
Strange. Give me that MLV to debug this issue please.
Just MLV? All files are 15 GB...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 02, 2019, 07:06:44 PM
Quote from: domasa on December 02, 2019, 03:30:30 PM
Just MLV? All files are 15 GB...
Yes, that exact MLV which causes this error. Do not cut it, I need the original.

Edit: if you meant one clip is .MLV and subsequent .M01 ... .Mxx = 15GB, then eh... yup, I need whole clip ;)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on December 03, 2019, 11:53:39 AM
@bouncyball glad you are going to investigate this. Can't wait to find out what causes that error so I can also know to avoid it in libMLV.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on December 03, 2019, 09:07:12 PM
Hey, I saw the github issue about a new logo. How about a homage to the horse in motion (https://en.wikipedia.org/wiki/The_Horse_in_Motion)? There's some nice icons here (https://www.flaticon.com/packs/horses), as inspiration.
I don't like much the idea of using magick references... it was overused by many already (imagemagick, g'mic, etc), IMO.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Kharak on December 04, 2019, 08:50:23 AM
Hi,

I just noticed on 1st post it says "if you want to process DNG's, use dngapp.com" the link is broken. I never heard of Dng app? Is it a joke?

If it is a joke, then jokes on you cause now i can process dng's in MLV App  :-*

Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on December 04, 2019, 06:53:00 PM
Yes its a joke, and you just made it seem so much funnier :D :-* :-* :-*
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on December 04, 2019, 08:52:36 PM
Quote from: Luther on December 03, 2019, 09:07:12 PM
Hey, I saw the github issue about a new logo. How about a homage to the horse in motion (https://en.wikipedia.org/wiki/The_Horse_in_Motion)? There's some nice icons here (https://www.flaticon.com/packs/horses), as inspiration.
I don't like much the idea of using magick references... it was overused by many already (imagemagick, g'mic, etc), IMO.

My thoughts:

- You have a good point about the 'magic' thing

- I want the colour scheme to be based on mostly Red, Green and Blue (because bayer filter has those colours)

- I don't want it to look like an iPhone app (MLV App's name containing 'App' is not enough to justify that)

- I like reflections and 3D-ness, I also the icons in macOS

I would like a new icon.

My original logo is not amazing. It does not relate to MLV or video or image processing in any way, but I think it looks quite nice. And because it is made in Blender you can do stuff like this:

(https://user-images.githubusercontent.com/23642861/43786055-a8edb62e-9a5f-11e8-9154-8d0209068331.png)

(from 1.0 release)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on December 05, 2019, 12:55:11 AM
Quote from: Ilia3101 on December 04, 2019, 08:52:36 PM
- I don't want it to look like an iPhone app (MLV App's name containing 'App' is not enough to justify that)
I agree 100%.
Quote
- I like reflections and 3D-ness, I also the icons in macOS
I like it too, but for logos 3D is not very practical, because it must be something simple enough to be readly recognized. Also, it must be in vector (.SVG), in case you want to apply to other resolutions (print in some tshirt, stickers, etc).
Quote
My original logo is not amazing.
I actually like it. Maybe you guys could keep it simple and just stay with the original logo, but redraw on inkscape and try to simplify the design...
Title: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on December 05, 2019, 05:50:15 AM
Quote from: Luther on December 05, 2019, 12:55:11 AM
...Maybe you guys could keep it simple and just stay with the original logo, but redraw on inkscape and try to simplify the design...

I wholeheartedly agree w this since it's already feasible and globally recognized by now! :)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on December 05, 2019, 06:24:21 AM
The impact of logo redesign/makeover may be widely overestimated.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 05, 2019, 08:23:52 AM
Quote from: Walter Schulz on December 05, 2019, 06:24:21 AM
The impact of logo redesign/makeover may be widely overestimated.
+1
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ozcancelik on December 05, 2019, 08:29:42 AM
Hi Ilia,

I made icon/logo that you wont like i guess :)  Because it's not 3d, it's modern like. But thats how it looks. Mac OS users can use dark mode, so i made grayish color for light/dark modes. Also I use my Windows dark mode.

(https://i.ibb.co/cT2HbSJ/icon.jpg) (https://ibb.co/ThPSKxc)
(https://i.ibb.co/BGsx7cY/logo.jpg) (https://ibb.co/m0zwYbP)

(https://i.ibb.co/wYDx0y0/light-mode.png) (https://ibb.co/6N6fnYn)
(https://i.ibb.co/cFJ7ydK/dark-mode.png) (https://ibb.co/Phxfr8s)





Quote from: Ilia3101 on December 04, 2019, 08:52:36 PM
My thoughts:

- You have a good point about the 'magic' thing

- I want the colour scheme to be based on mostly Red, Green and Blue (because bayer filter has those colours)

- I don't want it to look like an iPhone app (MLV App's name containing 'App' is not enough to justify that)

- I like reflections and 3D-ness, I also the icons in macOS

I would like a new icon.

My original logo is not amazing. It does not relate to MLV or video or image processing in any way, but I think it looks quite nice. And because it is made in Blender you can do stuff like this:

(https://user-images.githubusercontent.com/23642861/43786055-a8edb62e-9a5f-11e8-9154-8d0209068331.png)

(from 1.0 release)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 05, 2019, 08:33:37 AM
The original logo is not bad as logo, but it looks not so good in system tray or status bar (win/linux) even in dock on MacOS. It is very complex and not suitable for small resolution at all.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 05, 2019, 08:36:21 AM
@ozcancelik

I like white ones.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ozcancelik on December 05, 2019, 08:49:52 AM
Quote from: bouncyball on December 05, 2019, 08:36:21 AM
@ozcancelik

I like white ones.
Actually all same. Just background changes for OS dark/light theme simulate. Icon should look similar both dark and light modes so mostly I used gray color. So which white one? :)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 05, 2019, 08:56:32 AM
Quote from: bouncyball on December 05, 2019, 08:36:21 AM
@ozcancelik

I like white ones.
Maybe something like this(shameless mockup, not centered etc)?
(https://i.postimg.cc/sDStNm2q/ok.jpg)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ozcancelik on December 05, 2019, 09:18:16 AM
Quote from: Danne on December 05, 2019, 08:56:32 AM
Maybe something like this(shameless mockup, not centered etc)?
(https://i.postimg.cc/sDStNm2q/ok.jpg)

It can be logo but for icon I think  only extension ".MLV" can be text. Also my idea was "RGB with Sliders". Thats what MLV Apps mostly doing.

(https://i.ibb.co/6RDwX4m/only-text-with-rgb.jpg) (https://imgbb.com/)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 05, 2019, 10:00:51 AM
I like the bottom one.
Why are we changing logo by the way :D? Didn´t follow too closely here...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 05, 2019, 10:18:52 AM
Slider in this logo was good. Splitting colors above it. I liked it.

There is no need (even not recommended) to have whole application name in logo.

Or this should be done entirely as a letters logo. And this is another story because it must be as clean and visible as possible.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Kharak on December 05, 2019, 12:21:18 PM
Rule Nr. 1 when creating logo: It has to be round.

Look at the logos on your desktop, look at the successful/most recognizable Programs/apps. See any similarities?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 05, 2019, 12:52:58 PM
Quote from: Kharak on December 05, 2019, 12:21:18 PM
Rule Nr. 1 when creating logo: It has to be round.
Really? Here 50% is a rectangle on my desktop (e.g all Adobe products, Qt, MS Office, Keil, Finder, TeamViewer,..).

The last shown proposal was the best I've seen since the discussion started. But I also like the slider splitting the colors. Text would be nice for the about box, for the app icon we don't need it. For files the ".MLV" and the sheet around would be okay IMO.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ozcancelik on December 05, 2019, 01:11:46 PM
Quote from: Kharak on December 05, 2019, 12:21:18 PM
Rule Nr. 1 when creating logo: It has to be round.

Look at the logos on your desktop, look at the successful/most recognizable Programs/apps. See any similarities?

I think, there is nothing to say "should be" on logos.  It should be just catchy and maybe explain what it does.

Quote from: masc on December 05, 2019, 12:52:58 PM
Really? Here 50% is a rectangle on my desktop (e.g all Adobe products, Qt, MS Office, Keil, Finder, TeamViewer,..).

The last shown proposal was the best I've seen since the discussion started. But I also like the slider splitting the colors. Text would be nice for the about box, for the app icon we don't need it. For files the ".MLV" and the sheet around would be okay IMO.


App icon on Windows taskbar (Just RGB Shown and little slider, maybe borders can be removed)
(https://i.ibb.co/0Djdds2/taskbar.png) (https://ibb.co/HFDkkh4)

File extension icon small
(https://i.ibb.co/KzGFV0k/small-list.png) (https://imgbb.com/)

File extension icon medium
(https://i.ibb.co/4KC0Fkp/big-list.png) (https://imgbb.com/)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Kharak on December 05, 2019, 04:10:29 PM
Sorry for coming off too literal. There are no rules, I was lying.

But more or less all new designs or be it re-designs of logos feature a roundness today, it is the zeitgeist of logos. Just like back in the 90's everything had to be squiggly lines and fonts.

http://thumbnails-visually.netdna-ssl.com/evolution-of-brand-logos_52ce76df453e7_w1500.jpg

https://mivvy.co.uk/wp-content/uploads/2019/01/Google-Logo-evolution-1.jpg

http://www.templates4all.com/wp-content/uploads/2012/08/Corporate-Branding-1024x855.png

https://1000logos.net/wp-content/uploads/2018/08/Xbox-Logo-history.jpg

Unless the companies have an established identity in the Logo with Square or hard edged lines or it is a corporation wishing to emit power and wealth, the main features of logo redesigns is towards rounded and simplified designs.

That does not mean you HAVE to do it too, but it might help to come off as a Sodosopa brand, if you wanna attract the cool kids on the block.

I like the designs from ozcancelik, it has roundness and edges, showing the duality of art and technology infused in the MLV App project.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 05, 2019, 05:00:50 PM
Quote from: masc on December 05, 2019, 12:52:58 PM
The last shown proposal was the best I've seen since the discussion started. But I also like the slider splitting the colors. Text would be nice for the about box, for the app icon we don't need it. For files the ".MLV" and the sheet around would be okay IMO.
Exactly

@ozcancelik
Yes in taskbar the border is really unnecessary

@Ilia3101
What do you think? RGB is there, could be 4 channel bayer RGGB though :P
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on December 05, 2019, 05:18:06 PM
Quote from: bouncyball on December 05, 2019, 05:00:50 PM
@Ilia3101
What do you think? RGB is there, could be 4 channel bayer RGGB though :P

Ah, that's a valid point. :)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Snobe on December 05, 2019, 06:17:41 PM
I've recently also created few icons designs for the MLV App, but I've added them to Github. As the conversation is ongoing here, I thought I will share them here too.
Maybe someone will like to use them already.

Btw. I like the design with the RGB colors posted earlier, nice job. I would only change the font.

Here are the designs:
(https://user-images.githubusercontent.com/30800496/69759787-39f4cb00-1163-11ea-86ff-5dac3507619f.png)

(https://user-images.githubusercontent.com/30800496/69760045-cdc69700-1163-11ea-99bf-b67713e2eceb.png)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Kharak on December 06, 2019, 10:28:36 AM
Is this worth implementing, considering the spirit of openness? It gets the same compression ratio as HEVC, but is Royalty-Free where HEVC is Royalty Bearing.

Supports up to 12 bit 4:4:4

https://en.wikipedia.org/wiki/AV1

To be honest I never heard of this format until just now, I accidentally fell over it reading stuff on Wiki.

Alas, it might add it self to the issue of all the "standardized" codecs out there, so before there were 15 standard codecs, now we have 16...

EDIT: I was reading more on that Wiki page and it seems it is already supported by ffmpeg.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 06, 2019, 11:10:49 AM
Quote from: Kharak on December 06, 2019, 10:28:36 AM
Is this worth implementing, considering the spirit of openness? It gets the same compression ratio as HEVC, but is Royalty-Free where HEVC is Royalty Bearing.

Supports up to 12 bit 4:4:4

https://en.wikipedia.org/wiki/AV1

To be honest I never heard of this format until just now, I accidentally fell over it reading stuff on Wiki.

Alas, it might add it self to the issue of all the "standardized" codecs out there, so before there were 15 standard codecs, now we have 16...

EDIT: I was reading more on that Wiki page and it seems it is already supported by ffmpeg.
No problem to add... but it is kind of unusable: 200 frames in FHD -> 1 hour, while in H264 it needs a minute.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Kharak on December 06, 2019, 11:28:50 AM
Well then dont bother implementing.. That is slow..

Can I assume the reason for it being slow compared to h264/h265, being because most GFX cards today have HEVC encode/decoding chips ? Effectively making HEVC the standard?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 06, 2019, 11:36:38 AM
No idea... just exchanged the H264 command with this one (very close from ffmpeg side) and tried to make a test export... aborted now because time became longer and longer.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on December 06, 2019, 03:31:22 PM
Quote from: Kharak on December 06, 2019, 10:28:36 AM
It gets the same compression ratio as HEVC
Not really. AV1 has much better compression ratio than HEVC. This codec will be the new standard in some years. Google is supporting it, there's even a youtube playlist (https://www.youtube.com/playlist?list=PLyqf6gJt7KuHBmeVzZteZUlNUQAVLwrZS) with some videos compressed with it.
Quote from: Kharak on December 06, 2019, 11:28:50 AM
Can I assume the reason for it being slow compared to h264/h265, being because most GFX cards today have HEVC encode/decoding chips ? Effectively making HEVC the standard?
It is still in development. The code needs to be optimized yet. But, yes, one of the reasons is that CPUs/GPUs don't have specific instructions optimized for it and also that it requires more processing 'steps' compared to H.264.
Just had this same discussion yesterday here: https://www.magiclantern.fm/forum/index.php?topic=24685.msg223139;topicseen#msg223139
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: AF-OFF on December 08, 2019, 07:46:06 PM
I have much fun with MLVapp and thus thanks to all devs and others for it!

Since Masc introduced the export-preset in the export settings menu, I sometimes have tried it again (at least when new version came out) but it never worked for me. I'm on Yosemite, Catalina and High Sierra - everywhere the same. I can make one preset, but it disappers on next program start.
(this seems to not be the case with v1.10, it remembers then the presets, but all are the same setting, usually the one I did first, i.e. prores 4444. If I activate another one, like tiff, it has the same prores 444 setting applied)
I really tried some possible ways to get it. What I am doing wrong? Does some of you guys use it on mac without problems? let me know please.

Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 08, 2019, 07:52:57 PM
Hm... this feature did not change since it is there. So if you have a problem in 1.9, you MUST have it in 1.10 as well.
You have to use it this way:
1. make your settings in the window
2. press "+"
If you do it the other way, you'll just get the first setting as you described.
I use it on 5 different Macs with different OSX and it works on all.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: AF-OFF on December 08, 2019, 08:07:57 PM
Quote from: masc on December 08, 2019, 07:52:57 PM

1. make your settings in the window
2. press "+"


Many thanks Masc, now it's working!
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on December 10, 2019, 12:24:43 PM
Quote from: ozcancelik on December 05, 2019, 09:18:16 AM
It can be logo but for icon I think  only extension ".MLV" can be text. Also my idea was "RGB with Sliders". Thats what MLV Apps mostly doing.

(https://i.ibb.co/6RDwX4m/only-text-with-rgb.jpg) (https://imgbb.com/)


I love all of this. Congrats
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 10, 2019, 08:03:18 PM
Yes, I also like that one... just the slider could be there aditionally, like here:
Quote(https://i.ibb.co/RHQmhk2/icon.jpg)

Bouncyball helped to prepare MLVApp to be able to use document icons on Windows and I prepared it for OSX. On Windows we have some last little problems with registering...
Is there also a way for Linux? (Here I have absolutely no idea how it works.)
We prepared it for three different document icons: .MLV, .MASXML and .MARXML.
@Ilia: it is your app... how do you like these icons here?
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 11, 2019, 01:44:18 PM
All Linux flavors have such a large desktop managers + file managers range that I suspect this task gonna be mission impossible. We could just provide separate icon files for Linux and user can do with them whatever he wants.

Edit: I'm Linux user btw :P (Ubuntu Linux mostly)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 11, 2019, 01:50:32 PM
Quote from: masc on December 10, 2019, 08:03:18 PM
Yes, I also like that one... just the slider could be there aditionally, like here:
I think app icon should be pure "3color + slider" without any ".MLV", application name etc...
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 11, 2019, 03:32:45 PM
Quote from: bouncyball on December 11, 2019, 01:50:32 PM
I think app icon should be pure "3color + slider" without any ".MLV", application name etc...
That's what I meant.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 11, 2019, 05:47:43 PM
Cool :)
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on December 12, 2019, 06:05:04 PM
I said some time ago, somewhere, to someone (I think @Luther) that MLV App's tint slider is not very good because it is done in final colour gamut -  I was mistaken. It is actually done at the very start, on camera RGB channels. So it is fine, rawtherapee even does all white balance that way, so doing a little part is not harmful. Also I did spend about an hour messing with the white balance function, so this could change soon.


As for the icon. I am thinking, soon will have an answer,.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 13, 2019, 01:28:02 PM
Quote from: Ilia3101 on December 12, 2019, 06:05:04 PM
Also I did spend about an hour messing with the white balance function, so this could change soon.
As for the icon. I am thinking, soon will have an answer,.
Eagerly awaiting for changes! :D
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on December 14, 2019, 03:24:02 PM
Keeping an eye on developments here, as, although I'm only a stills photographer, I am looking to use MLV App for long exposure processing.

On that topic, I wonder if those developing the App have considered eliminating the TIFF average limit, ie it's currently 128 frames - if possible.

Cheers

Garry
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 14, 2019, 03:30:16 PM
It's not. You have to modify ffmpeg code for all I know.
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on December 14, 2019, 03:55:57 PM
Oh bugger!!!
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on December 15, 2019, 03:31:28 AM
I'm doing some light tests with my 5D3 and grabbing the stills with MLV App :) :)


(https://i.imgur.com/hVs4MvL.png)

(https://i.imgur.com/BfimlkW.png)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on December 15, 2019, 04:48:32 AM
Yeah You can use many full res raw dng files from other cameras as well, not only canons sooo..
This joke can be edited :
If you want to process DNGs, use DNGApp.com
to this :
If you want to process DNGs from cameras that shoot RAW, use Transcode and Import from MLVApp menu
:D

Now with help of Ilia3101 and cmh i succesfully imported dngs from pixel2xl and sigma fp stills and video frame to mlvapp
Title: Re: MLV App 1.9 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yokashin on December 19, 2019, 07:35:09 PM
Quote from: masc on November 30, 2019, 09:43:29 AM
@yokashin:
thanks for reporting. Opening files from "zdjęcia" folder is a Windows only issue. Works fine here on Mac. Maybe I can debug this when I am back on a Windows PC.

Today I discovered a similar funny problem :) In the morning I set up the conversion of several files - task for 4 hours. Before leaving for work, I checked if everything is ok. After returning, I discovered that the target directory is empty :) Files were to be saved in the directory with the Polish letter "Ż". I conducted the test and in fact the application does not even create .mov and .wav files when starting the task. In the application window, everything goes correctly -% and task progress in subsequent files. There are no visible messages about any errors.

MLV.App.v1.10.Win64.static working on Windows 10 64bit
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 19, 2019, 08:14:31 PM
@yokashin: hm, I was debugging this and found the function where the problem happens. No problem with all the german letters like äöüß, but with your polish letters. I tried out all alternatives Qt offers for such letter conversion - but without success. No idea how we could solve it. So for now I can just recommend to not use such letters, sorry. The problem exists only on Windows. On Linux or OSX it also works with those letters.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yokashin on December 19, 2019, 08:21:46 PM
Quote from: masc on December 19, 2019, 08:14:31 PM
@yokashin: hm, I was debugging this and found the function where the problem happens. No problem with all the german letters like äöüß, but with your polish letters. I tried out all alternatives Qt offers for such letter conversion - but without success. No idea how we could solve it. So for now I can just recommend to not use such letters, sorry. The problem exists only on Windows. On Linux or OSX it also works with those letters.
I understand. Now I know what to do to prevent this problem. Regards!
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 19, 2019, 08:29:24 PM
Quote from: yokashin on December 19, 2019, 08:21:46 PM
I understand. Now I know what to do to prevent this problem. Regards!
Not really... or?! Sorry.
Problem is to convert QString to char*, where we use for Windows fileName.toLatin1().data(), in order to get the filenames from the GUI part to the C processing part. The conversion is done with toLatin1().data() for Windows, and with toUtf8().data() on Unix (which does not work at all for Windows). If someone has a better idea, please let me know.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yokashin on December 19, 2019, 08:40:14 PM
What I meant more was that I should not use Polish characters in directory names. It is possible that I spoke wrongly. Excuse me.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 19, 2019, 08:43:42 PM
Yes I understood... but the sounding was a little sarcastic, hehe (this is what I hear the whole day at work).  ;D
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on December 21, 2019, 06:21:11 AM
@masc, I think that's because Windows uses UTF-16 instead of UTF-8. They have this function called "WideCharToMultiByte" to convert properly:
https://docs.microsoft.com/pt-br/windows/win32/api/stringapiset/nf-stringapiset-widechartomultibyte?redirectedfrom=MSDN
https://stackoverflow.com/questions/215963/how-do-you-properly-use-widechartomultibyte/215973#215973

Dunno if this will solve the problem, I don't have knowledge in programming...
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 21, 2019, 10:20:02 AM
Thanks Luther. Yes, that looks like to be the reason why. The processing code uses platform independant standard C libraries, which use char* to describe the filename. char is 8bit. If Windows (only) uses 16 bit now, we will never ever be able to convert that via 8bit variables. The only way to solve should be to rewrite all file operations in processing code (just) for windows :P (very uncool).
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on December 21, 2019, 11:42:00 AM
Quote from: masc on December 21, 2019, 10:20:02 AM
The processing code uses platform independant standard C libraries, which use char* to describe the filename. char is 8bit.
How about using wstring (const wchar_t)? I've read some people (https://stackoverflow.com/questions/11853208/char-to-const-wchar-t-conversion) recommending while I was searching for solutions...
Quote
(just) for windows :P (very uncool).
Microsoft, as always. If we had an alternative to Premiere Pro in free unix-like systems I would never use windows again.

edit - this guy explains well:
https://stackoverflow.com/questions/402283/stdwstring-vs-stdstring/402918#402918
Quote
Applications using char are said "multibyte" (because each glyph is composed of one or more chars), while applications using wchar_t are said "widechar" (because each glyph is composed of one or two wchar_t. See MultiByteToWideChar and WideCharToMultiByte Win32 conversion API for more info.

Thus, if you work on Windows, you badly want to use wchar_t (unless you use a framework hiding that, like GTK+ or QT...). The fact is that behind the scenes, Windows works with wchar_t strings, so even historical applications will have their char strings converted in wchar_t when using API like SetWindowText() (low level API function to set the label on a Win32 GUI).
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 22, 2019, 11:09:47 AM
Thanks again, Luther. Hm... but this means having all filename and file interaction standard C code twice inside the processing part of the app. That is very bad to debug and to support.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on December 22, 2019, 12:10:01 PM
On macOS and linux file name handling is just UTF8 (compatible with char *) so no problems here?

Quote from: masc on December 22, 2019, 11:09:47 AM
Hm... but this means having all filename and file interaction standard C code twice inside the processing part of the app.

I think it would only require using a special wchar_t version of fopen on windows, everything else can stay the same. Glad libMLV won't be opening files directly :D


Sorry been inactive for a bit. Mourning the loss of my hard drive with a lot of recent raw videos. Fuck hard drives.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 22, 2019, 12:52:36 PM
Quote from: Ilia3101 on December 22, 2019, 12:10:01 PM
On macOS and linux file name handling is just UTF8 (compatible with char *) so no problems here?

I think it would only require using a special wchar_t version of fopen on windows, everything else can stay the same. Glad libMLV won't be opening files directly :D


Sorry been inactive for a bit. Mourning the loss of my hard drive with a lot of recent raw videos. Fuck hard drives.
Oh no... that is sad loosing the videos...

Yes, no problem on Linux and OSX. It is a Windows only problem. We have to change more than just fopen: there are some functions, which have the filename as char* parameter. This needs also #ifdef's.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on December 22, 2019, 07:20:02 PM
I recommend Blu-Ray M discs portable writer to store Your data on bluray 25GB M-Discs , theyre one of the most reliable archival method with strong laser and data burned physically that lasts about 1000 years which sounds corny but ill take it, ive seen some tests results, other methods are more expensive like LTO tape to archive hard drives.I mean LTO is not THAT expensive, just a bit more expensive, I might switch to it in near future.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on December 24, 2019, 12:23:43 AM
Does anyone know good data recovery companies in the UK? I am scared of getting a shitty one, seems there is a lot of scams.

Quote from: 2blackbar on December 22, 2019, 07:20:02 PM
I recommend Blu-Ray M discs portable writer to store Your data on bluray 25GB M-Discs , theyre one of the most reliable archival method with strong laser and data burned physically that lasts about 1000 years which sounds corny but ill take it, ive seen some tests results, other methods are more expensive like LTO tape to archive hard drives.I mean LTO is not THAT expensive, just a bit more expensive, I might switch to it in near future.

I always heard that blu ray is propreitary technology full of DRM. Does that apply to these discs in any way? I mainly need it to work with Linux. 1000 years sounds wonderful. I need to store my files at least that long.

Also I'm going to invest in a 4TB SSD and boycott hard drives.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on December 24, 2019, 05:46:22 PM
My two cents. If you don't plan on accessing the data anytime soon, as 2blackbar suggested, LTO tape drive is the cheapest and safest solution.
Even tho a lot have been done concerning data integrity with overprovisioning, I wouldn't trust SSDs for archival. Flash charges dissipate and data recovery might be problematic because of proprietary firmwares, controllers, etc.

I'm cheap, I'd go for like 4 SAS hard drive in raid 10. I would mix brands (at least not the same batch) and go for slower 7200rpm drives.
I'd get the best PSU available for my budget (platinum/titanium like, anything more than 90% efficient at 100% load).
I'd get a reliable, brand new, consumer grade motherboard, a cheapo cpu, few gb of ram and an SAS HBA card which is quiet expensive and not always linux friendly (google-fu required).
Everything on a DIY clean and well ventilated cabinet install debian and barely touch it.
I think SAS drives are generally 10% more expensive but they are more resistant to vibrations. It's server grade, MTBF of SAS drives are 1.2 to 1.6 million hours of use at 45 °C and their SATA counterpart only 700,000 hours to 1.2 million hours of use at 25 °C.

For recovery, Ontrack seems to be a serious international company.
https://www.ontrack.com/uk/services/data-recovery/hard-drive-recovery/

edit:
There's also cloud solutions, you can encrypt everything if needed.
LTO tape is cheap if it's several TB per months of archival otherwise it's not worth it. You can find fast LTO7 SAS drives (at least 300 Mbps) for something around £2,000 on ebay. A new 15 TB RW cartridge (30/45 TB of deduped/compressed storage) is around £60 .
If you take the hard drive route, there's also a raid backup open source software called SnapRAID.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on December 25, 2019, 09:47:23 AM
Merry Christmas everyone!

CMH,

Why not cheaper, much simpler and environment friendly?  I make backup copies of my data on two external USB mechanical hard drives that I keep in my desk.  If one of them dies, I still have the other.  As long as they are not hooked up to my PC at the same time, the probability that they die simultaneously is close to zero.  Moreover, they spin and consume power only when hooked up - a few times in a month for a few minutes to an hour.  I am even considering making a third copy for storage in my office at work for the event of fire, earthquake, flooding, etc.  A great advantage of this type of storage is portability.  If one of the drives is a small and lightweight 2,5 inch external HDD, I can carry it in my bag whenever and whereever I want and I always have a working copy of my data with me. 

I have been using this approach for more than 20 years now and it has always worked for me.  I still have my very first external HDDs with USB2 that I keep my scanned photos from the film era on.  These drives still work like a charm.  SATA and USB technologies are not very likely to be replaced with something else in the near future and even if this happens, I still have enough time to transfer my data onto a new technology system.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on December 25, 2019, 10:02:01 AM
This might answer Your question Ilia3101:
http://www.microscopy-uk.org.uk/mag/indexmag.html?http://www.microscopy-uk.org.uk/mag/artsep16/mol-mdisc-review.html

There are more M-Disc tests online , I store them with cotton napkins between every disc , its shaped like circle with hole in the middle , so discs wont scratch when stored and handled and i keep them away from sun.
Different opinions:
https://club.myce.com/t/stress-testing-m-disc-bd-r-vs-regular-quality-bd-r/312981/10
Some guys think its a marketing thing but i did store my olda data from 2005 on regular dvds recorded back then and most of them lasted to this day.Out of 10 ,just one failed and i had 3 or 4 hard disk failures in the meantime, i dont trust HDD at all.
https://www.reddit.com/r/DataHoarder/comments/7sgiz8/anyone_try_m_disc_yet/
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yokashin on December 25, 2019, 10:10:03 AM
Quote from: IDA_ML on December 25, 2019, 09:47:23 AM
Merry Christmas everyone!

CMH,

Why not cheaper, much simpler and environment friendly?  I make backup copies of my data on two external USB mechanical hard drives that I keep in my desk.  If one of them dies, I still have the other.  As long as they are not hooked up to my PC at the same time, the probability that they die simultaneously is close to zero.  Moreover, they spin and consume power only when hooked up - a few times in a month for a few minutes to an hour.  I am even considering making a third copy for storage in my office at work for the event of fire, earthquake, flooding, etc.  A great advantage of this type of storage is portability.  If one of the drives is a small and lightweight 2,5 inch external HDD, I can carry it in my bag whenever and whereever I want and I always have a working copy of my data with me. 

I have been using this approach for more than 20 years now and it has always worked for me.  I still have my very first external HDDs with USB2 that I keep my scanned photos from the film era on.  These drives still work like a charm.  SATA and USB technologies are not very likely to be replaced with something else in the near future and even if this happens, I still have enough time to transfer my data onto a new technology system.

I do the same with a copy of the data.

I use two 3.5 inch 4gb hdd discs for photos and video materials. When I have free time I copy new material from the first to the second disk. Disks are not permanently attached to computer. I've been doing this since I started taking a lot of pictures of my daughter.

I wish You a Merry Christmas!
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on December 26, 2019, 11:40:12 AM
Happy Holidays!

@IDA_ML

It really depends on the scale and how serious you are about it.
I imagine a scenario like backing up 15 years of MLV of a daily shooter, twice and keep a copy in another place, safe and far away and keep doing that for at least a decade.
Your solution is prefectly fine in most cases but if my life depended on it I wouldn't push my luck with mechanical consumer grade drives that are meant to be unplugged a lot and transported often.
Keeping a physical copy on another location is a great idea tho. Cloud backup solutions are great for that.
The initial cost is relatively steep but tape really is the best thing, we are of talking of 30 terabytes of compressed data for 60 bucks.
As for the environement, a small home lab isn't the best solution but I'd argue that with the power saving features and a good power supply, in the long run it will probably waste less energy than let's say a smart tv.
If it's a concern, picking a low power SoC like an Intel N4200 that has a 6W TDP for exemple would be ideal (and it doesn't have to serve only one purpose).
What's great about that solution is restricted physical access that's why I'd suggest a locked room/cabinet, a downside is maintenance, some people don't have time for that.

TLDR: What I meant to say is that your solution is prefectly fine for dumping data before archiving (you could stack usb drives on shelves and barely touch them, some people do that but meh).
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on December 26, 2019, 03:31:11 PM
Quote from: cmh on December 26, 2019, 11:40:12 AM
... if my life depended on it I wouldn't push my luck with mechanical consumer grade drives that are meant to be unplugged a lot and transported often.

And this is something that I do not quite understand.  The drives do not get physically unplugged at all and do have all kinds of protection - shock, overvoltage, EMI, etc., some are even seated in splash proof enclosures.  What gets unplugged is the connecting USB cable.  There is not much that can go wrong here - Ok, the contacts may get dirty or worn out, the USB connectors may get broken and in the worst case, the controller may die.  But in that case you just open the enclosure, take the drive out, (it just has a simple SATA and power supply connector on it), then you plug in the drive whereever you like and continue using it.  Yes, it's a mechanical spinning construction but, as I said, 99,99% of its entire life span it does not operate but just gets stored in your desk.  And for the very unlikely event that it dies, you still have the second backup drive.  They are quite cheap these days. All it requires is some disciplin to not use both backup drives at the same time but just one at a time to exclude the chance that they both die simultaneously.

I am not argueing and am very grateful to you for sharing your thoughts with us on this matter of crucial importance, especially now that we all generate tons of MLV files that are quite heavy and archiving the originals is a must, keeping in mind that MLVApp gets better and better over time.  I am just trying to understand the advantages of your archiving solution.  Sofar, the only real advantage that I see is the RAID10 which is more convenient to use for that purpose and will also save you more time due to faster transfer speeds.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on December 26, 2019, 08:11:56 PM
You are making a point, it doesn't make sense for most people to invest in enterprise grade hardware if your HDD aren't spinning, more so if you consider this annual failure rate report.
https://www.backblaze.com/blog/hard-drive-stats-q2-2019/

You are not wrong, but as I said "if my life depended on it" like if my job depended on those backups or if I had to spend a lot of money on some projects.
If those drives are dropped, if someone is trying to plug them without my consent, if it gets wet, etc.
Tape and NAS are not perfect and way less convenient but mitigates some of these issues depending of the solution. In most cases IP67 USB disks are fine for dumping and archival. Some people are dedicating a bunch of external drives to a project, backup properly, check file integrity, put the backup in a safe place and I'm perfectly fine with it. If it's comparable to the cost of the gear or cheaper, I'd consider a failproof solution. Like an insurance, you might never need one or it might save you.

The NAS solution is getting expensive real quick too. It depends on the workflow really. If you need to label projects and span that across multiple drives, it's a bit of a pain.

edit: I'm not an expert, I won't take offense if we disagree and I'd just assume that you might be more experienced than me.  :)
edit 2: decided to cut down the excess verbiage and edited the whole paragraph about cost, my maths was totally wrong LTO tape is way too expensive below 90 TB (so like really big projects).
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on December 26, 2019, 11:47:40 PM
Yes, you are right - for hobby photo- and videographers like me, it does not make much sense to keep archives on drives that spin all the time.  A cheap and simple solution similar to the one that I described works quite well.  All the rest is a matter of workflow, organization and, as you said, it all depends on how serious you are about it.   

As far as SSDs are concerned, they are fantastic for everyday work but I wouldn't use them for archiving purposes.  The reason is that they die all of a sudden and when they are dead, there is nothing you can do about your data.  Mechanical HDDs usually die slowly and warn you when they are about to die, giving you the chance to still backup your data before they are completely dead.

A final word about M-disks.  After I retire, I plan to archive everything I would like to leave behind after my death on M-disks.  This includes my PhD thesis, papers, publications, patents, reports of projects that I have worked on professionally, as well as my hobby photo and video work.  The greatest problem here will be how to decide what is worth archiving and what not.  Other than that, I like the idea that M-discs last for 1000 years.  This means that in 1000 years people will still know how much we enjoyed ML and MLVApp.  :)

Thank you again for your detailed write up, CMH.  Greatly appreciated!
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Ottoga on December 27, 2019, 01:17:51 AM
I've been using a DLINK NAS for many years now. Capacity is 4 TBs in raid 5 configuration. it's always on and set up to spin down the drives when not in use and to perform a health check of each drive monthly. The individual drives are hot swappable in the event of failure and will automatically rebuild the data on the replacement HD. And, because you can never have too many backups, all my important data/images etc are backed up to external USB HDDs.

Effectively back-up solutions are so cheap nowadays that there really isn't any excuse to lose your data anymore.


Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on December 29, 2019, 12:57:21 PM
Wonder why the two developments do not go hand in hand, since the image processing is a plugin to the base core program.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 29, 2019, 01:50:43 PM
Quote from: Quentin on December 29, 2019, 12:57:21 PM
Wonder why the two developments do not go hand in hand, since the image processing is a plugin to the base core program.
Developments of what!?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on December 29, 2019, 02:07:13 PM
Of MVLApp together with image processing.
Latest MLVApp doesnt not include it.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 29, 2019, 06:35:39 PM
Processing is included all the time in MLVApp... without you would not be able to view or export one single frame.
If you mean raw2mlv: this is a separate program which can be used by MLVApp. Those two apps are very different and MLVApp can use raw2mlv as a kind of plugin. MLVApp uses raw2mlv just for converting any RAW to MLV, nothing more. Processing is 100% in MLVApp. There is no need to include the code of raw2mlv a second time into MLVApp, because the devs would have the work twice.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: SMS on December 30, 2019, 07:41:02 AM
I can confirm that MLV app 1.9, 1.10 is crashing when I select import MLV under windows 7 64 bit. 1.8 is working.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 30, 2019, 05:21:54 PM
Quote from: SMS on December 30, 2019, 07:41:02 AM
I can confirm that MLV app 1.9, 1.10 is crashing when I select import MLV under windows 7 64 bit. 1.8 is working.
Would be nice if you install the development envionment, compile and start the app with debugger. None of the devs can reproduce, so the error will persist, if nobody tells where the error happens (with the help of the debugger).
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ZEEK on December 31, 2019, 01:19:19 AM
Quote from: masc on December 29, 2019, 06:35:39 PM
MLVApp uses raw2mlv just for converting any RAW to MLV.
Cool to know! Does that include Blackmagic RAW?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 31, 2019, 10:37:53 AM
Quote from: ZEEK on December 31, 2019, 01:19:19 AM
Does that include Blackmagic RAW?
No, because Blackmagic RAW is no (real) RAW. BRAW is already debayered and partially processed. Same for Canon SRAW and MRAW. There is no solution yet.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ZEEK on December 31, 2019, 12:25:49 PM
Gotchya! Wow, I wonder how they got away with actually calling it RAW. Anyway, thanks for the awesome work you guys do with MLV App. It has really, really improved over time thanks to the team/developers like yourself. As a further possibility for MLV App, perhaps a Rec 709 Luma Waveform to adjust exposure more accurately..just a suggestion. Cheers and a Happy New Year! :)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on December 31, 2019, 01:15:44 PM
I can also confirm that MLVApp is now so mature and powerful that I am absolutely certain that this is the best RAW processing tool that is available worldwide, at least to my knowledge.  I have been using it not only for video but also for photo (with raw2mlv) lately and I get better results compared to ACR on a regular basis.  Moreover, there are two functions that are of crucial importance to my workflow and are not available in ACR:

1)  Dual ISO that I use quite a lot for landscape work and
2)  Skin tone white balance that solves the natural skin tone problem on a mouse click.

My workflow is now entirely based on MLVApp and all this I owe to the genious work and skills of our developers.  Thank you, guys and keep up this fantastic work also in the New Year and the years to come.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on December 31, 2019, 03:18:16 PM
@IDA_ML

Like you, and others I suspect, I am also seeing the benefits of MLVApp, in my case for long exposure photography simulation.

I haven't yet tried raw2mlv. Do you know of there is a Win PC version for download? I don't compile, so I would need an executable.

Cheers

Garry
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on December 31, 2019, 07:09:45 PM
Hey Garry,

I downloaded mine from post #3595 on page 144 of this thread.  You just unzip the archive into the MLVApp directory and you are ready to go using the Transcode and Import option of the File menu.  It will transcode your CR2 files into single-frame MLVs that you can process in MLVApp as any MLV file and then export your frame as Tiff or Jpeg.  That's all.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on December 31, 2019, 07:16:19 PM
@IDA_ML

Got it!

No I don't !!

I've got version 10 and I don't seem to have Transcode, 'just' MLV inport.

>:(

Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on January 01, 2020, 04:39:38 PM
Garry,

Please watch carefully!  In MLVApp v. 1.10, the "Transcode and Import" option is the 9-th from top in the File menu.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on January 01, 2020, 04:55:24 PM
Here is my version 10 File screen

(https://pictshare.net/g7w8zt.jpg)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on January 01, 2020, 05:11:23 PM
Try downloading the latest version again. 
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on January 01, 2020, 05:13:22 PM
@IDA_ML

I will, but the app clearly says it is version 10  ;)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on January 01, 2020, 05:21:36 PM
Just downloaded the latest version from the first post.

I see the same File screen  ;)

That is no transcode.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on January 01, 2020, 05:30:42 PM
I have the option on my file menu and it works fine on my Win7x64 OS.  Maybe Masc can help you further.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on January 01, 2020, 05:39:58 PM
Strange.

I'm on a win 10 64 laptop, xps15. But not a win7  ;)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 01, 2020, 05:48:10 PM
Happy new year everyone!

Thanks for the very useful advice on archiving @2blackbar @cmh @IDA_ML @yokashin @Ottoga. It was so nice to read. I think I'll get a big SSD just for copying stuff until it gets close to full. And then I will use the M DISCs for more permanent storage, after reading about it I realise they are amazing. I don't like the idea of tape with the stretching. Cloud is also an interesting thing I've never really considered.

Quote from: IDA_ML on January 01, 2020, 04:39:38 PM
Please watch carefully!  In MLVApp v. 1.10, the "Transcode and Import" option is the 9-th from top in the File menu.
Can we rename it to "Transcode and Import non-MLV Raw" so it is more noticable?

Quote from: ZEEK on December 31, 2019, 12:25:49 PM
Gotchya! Wow, I wonder how they got away with actually calling it RAW. Anyway, thanks for the awesome work you guys do with MLV App. It has really, really improved over time thanks to the team/developers like yourself. As a further possibility for MLV App, perhaps a Rec 709 Luma Waveform to adjust exposure more accurately..just a suggestion. Cheers and a Happy New Year! :)

Blackmagic say it's partially debayered, but megapolis (fastcinemadng guy on this forum) found a way to decode it, finding that it's not really partially debayered. It's probably a way of speaking to avoid being sued by rEd. Eventually a open source way to decode it will be created (I hope).

Quote from: IDA_ML on December 31, 2019, 01:15:44 PM
I can also confirm that MLVApp is now so mature and powerful that I am absolutely certain that this is the best RAW processing tool that is available worldwide, at least to my knowledge.  I have been using it not only for video but also for photo (with raw2mlv) lately and I get better results compared to ACR on a regular basis.  Moreover, there are two functions that are of crucial importance to my workflow and are not available in ACR:

1)  Dual ISO that I use quite a lot for landscape work and
2)  Skin tone white balance that solves the natural skin tone problem on a mouse click.

My workflow is now entirely based on MLVApp and all this I owe to the genious work and skills of our developers.  Thank you, guys and keep up this fantastic work also in the New Year and the years to come.

Thank you IDA_ML this is really nice to hear. I agree in some ways. But we still need to sort out camera colour conversion, it's too basic right now.

I have been analyzing the processing a bit more. The whole colour gamut converted with MLV App processing (Y=0.15, Y=0.5, Y=1.0):
(https://i.postimg.cc/gc6Rhvfr/Screenshot-at-2020-01-01-16-16-02.png) (https://i.postimg.cc/MGMPjcxw/Screenshot-at-2020-01-01-16-25-57.png) (https://i.postimg.cc/zvBRVhZS/Screenshot-at-2020-01-01-16-26-29.png)
They are all supposed to be very even and smooth, but they are not, especially in the blue/violet region. Once it looks smooth, MLV App will be perfect (at least for colours).

And who recognises that light blue colour on the third one ;D
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on January 01, 2020, 06:23:03 PM
QuoteCan we rename it to "Transcode and Import non-MLV Raw" so it is more noticable?

Just finding it irrespective of what it's called would be good  :) ;)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 01, 2020, 06:32:37 PM
I have another idea. Skip the "transcode" text altogether. Instead allow mlv app to open up supported raw files just like any mlv. But. When selecting files to be opened let there be a question before proceeding if opening as single or a sequenced file.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on January 01, 2020, 06:44:04 PM
@IDA_ML

QuoteHey Garry,

I downloaded mine from post #3595 on page 144 of this thread. 

Error 404 when I try  :(
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 01, 2020, 07:09:36 PM
Quote from: garry23 on January 01, 2020, 05:21:36 PM
Just downloaded the latest version from the first post.

I see the same File screen  ;)

That is no transcode.
Quote from: garry23 on January 01, 2020, 05:39:58 PM
Strange.

I'm on a win 10 64 laptop, xps15. But not a win7  ;)

Not at all strange. It is disabled for the official build, because it is in very early alpha stage.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 01, 2020, 07:13:53 PM
Quote from: Danne on January 01, 2020, 06:32:37 PM
I have another idea. Skip the "transcode" text altogether. Instead allow mlv app to open up supported raw files just like any mlv. But. When selecting files to be opened let there be a question before proceeding if opening as single or a sequenced file.
Hm... for files this could work, but what for dng folders? We can open files or folders, but not both in one dialog.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on January 01, 2020, 07:25:55 PM
Quote
Not at all strange. It is disabled for the official build, because it is in very early alpha stage.

Thank goodness for that...I thought I was going mad!!!!  :D
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 01, 2020, 07:34:39 PM
Quote from: masc on January 01, 2020, 07:13:53 PM
Hm... for files this could work, but what for dng folders? We can open files or folders, but not both in one dialog.
Folders. Nice, didn't know. For stills then? And keep the transcode option only folders?
I mean, the feeling you would get opening a cr2 file without the intermediate step  :)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 01, 2020, 07:56:51 PM
Quote from: Danne on January 01, 2020, 07:34:39 PM
Folders. Nice, didn't know. For stills then? And keep the transcode option only folders?
I mean, the feeling you would get opening a cr2 file without the intermediate step  :)
Folders for clips, files for stills. Right now it is realized with two buttons in the import dialog, bringing a file or filder dialog.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 01, 2020, 08:16:27 PM
Yup, I know about the files. Didn´t test the folder action ;)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 01, 2020, 08:39:24 PM
Quote from: Ilia3101 on January 01, 2020, 05:48:10 PM
I have been analyzing the processing a bit more. The whole colour gamut converted with MLV App processing (Y=0.15, Y=0.5, Y=1.0):
(https://i.postimg.cc/gc6Rhvfr/Screenshot-at-2020-01-01-16-16-02.png) (https://i.postimg.cc/MGMPjcxw/Screenshot-at-2020-01-01-16-25-57.png) (https://i.postimg.cc/zvBRVhZS/Screenshot-at-2020-01-01-16-26-29.png)
They are all supposed to be very even and smooth, but they are not, especially in the blue/violet region. Once it looks smooth, MLV App will be perfect (at least for colours).

And who recognises that light blue colour on the third one ;D
What exactly does this mean? Bright blue/violet will bring slightly strange colors? Or does this show our problem with cyan tones at WB <4000K?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 01, 2020, 09:37:07 PM
Quote from: masc on January 01, 2020, 08:39:24 PM
What exactly does this mean? Bright blue/violet will bring slightly strange colors? Or does this show our problem with cyan tones at WB <4000K?

I think it shows both problems.

On the last picture, the intense cyan tones are appearing, very close to neutral cool white tones. We need to desaturate colours with high luminance, and blue/violet shades always need to be desaturated. Doing those things will fix all problems.

This all needs to be done around the same stage as matrix and tonemapping. It will be difficult to do, but it is the next big MLV App improvement.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 01, 2020, 10:04:59 PM
Sounds great... but do you have already any idea how to realize that?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 01, 2020, 10:23:49 PM
It will need to use the xyY colour model, as it has no limits, that's about all I know so far. This also has the potential to make MLV App really slow, so it needs to be done carefully, maybe with some 2d lookup tables in xy space. I have a nice .c file where I am experimenting with ways to do it. I will share it soon, it's just a bit messy right now. :)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 01, 2020, 10:32:16 PM
 ;D Okay, I am very excited about...
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 01, 2020, 10:37:18 PM
Quote from: masc on January 01, 2020, 10:32:16 PM
;D Okay, I am very excited about...
+10
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on January 02, 2020, 10:09:28 AM
Quote from: Danne on January 01, 2020, 10:37:18 PM
+10

+1000 and Prosperous New Year everyone. Great read on the Hardrives & M-discs stuff. ;D
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on January 02, 2020, 01:26:14 PM
Hi guys! I love this program! I've probably been using it for a year now. BUT..

Starting with version 1.9, the program crashes when I try to open an MLV file.
So I'm still using version 1.8.

I must say right away that I have semi-working drivers for a video card. This is a rather old laptop and it simply does not have working drivers for modern OS.
But version 1.8 works. Maybe you can somehow fix newer versions for compatibility, etc.?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Giovanni89 on January 02, 2020, 02:24:44 PM
Hi everyone. I'm following this discussion with great interest. Please apologize my English, I'm still learning. So please feel free to correct me anytime. I have two answer about this wonderful app:

1) I always used the "regular" and bloody slow workflow with camera raw ecc. but when I switched to mlv app I immediately noticed that everything appear less "definite" and "clear". As if there is a thin veneer on every single frame. Do you know why?

2) is there any chance, also in the future, to use this application on the iPad? It would be perfect for me.
Thanks
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: daggoo on January 02, 2020, 03:55:51 PM
Thank you very much for develop MLV producer, many scenes of my documentary were impossible without 3.5X.

Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 02, 2020, 04:16:13 PM
Quote from: daggoo on January 02, 2020, 03:55:51 PM
...for develop MLV producer...
Wrong thread, here is MLVApp.
Quote from: daggoo on January 02, 2020, 03:55:51 PM
... were impossible without 3.5X.
What is that?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 02, 2020, 05:43:50 PM
Does anyone have a raw video or photo with blue/violet light that clips in an ugly way when you process it with MLV App or any other software? If you do, I would like to see the file. Any camera make/model will do, preferably large sensor tho.

something that looks like one of these:
https://www.youtube.com/watch?v=1hFBnAGahFM
https://www.youtube.com/watch?v=szxmH09mhsQ
https://www.youtube.com/watch?v=4QYBglZy4jk
https://www.youtube.com/watch?v=ntLlU6U2-zM

And if you have clipping colours other than blue/violet, that would be useful to see as well.

Thank y9ouu!!!
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 02, 2020, 06:06:30 PM
Here is one file:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/M04-1011.MLV

Set wb to 2400 and get this nice blue tones:
(https://i.postimg.cc/d3Phvmh5/Screenshot-2020-01-02-at-18-01-47-png-300px.png)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on January 02, 2020, 06:23:39 PM
Here, 5D2, the lamp is actually completely blue.

https://www.dropbox.com/s/lfkkfeu2wxm3azw/M02-2157.MLV?dl=0
https://www.dropbox.com/s/rjenibg1glmhi04/M02-2158.MLV?dl=0

Interestingly, clipped highlights can still be somehow fixed on the first video using reconstruction.. But certainly not on the second video..
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 02, 2020, 06:28:02 PM
Oh yes cyan is useful too, thanks for finding that one again.

Still looking for blue/violet samples, especially with blue and violet at the same time ;)

Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 02, 2020, 07:54:37 PM
https://www.dropbox.com/s/ik4uif1ir0lbxng/M02-1950short.MLV?dl=0

If you need the same with any other setting, or recorded with the 5D2, let me know... (this is 5K ana. rewire @ EOSM). The blue LEDs bring so ugly nice artifacts... ;)

MLVApp:
(https://i.ibb.co/6XNDtGs/M02-1950-frame-2.jpg)

Edit: ACR: (also not really better)
(https://i.ibb.co/rQ4W6jW/M02-1950short-frame-1-l1.jpg)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 02, 2020, 08:58:38 PM
Very nice clip!!! It even has some violet going on in the foreground! Thank you
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on January 02, 2020, 11:40:14 PM
Here is two samples , let me know if you need more :D

1
ACR 3200K
(https://i.imgur.com/QfzzPp1.jpg)

MLVApp 3200K
(https://i.imgur.com/beVY9xi.jpg)

2
ACR 3200K
(https://i.imgur.com/P2pwZl1.jpg)

MLVApp 3200K
(https://i.imgur.com/hD0cvOy.jpg)

MLV: Download (https://drive.google.com/open?id=1_CZO_VZecW5CQOrv5426NS4kP9kNf4LF) Link .
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 03, 2020, 01:24:46 AM
Omg I lovve you! Great samplels plus I really wanted an ACR comparison. Great to see where we are both at. Soon MLV App will be destroying camera raw in this comparison.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 03, 2020, 01:39:07 AM
Quote from: Giovanni89 on January 02, 2020, 02:24:44 PM
Hi everyone. I'm following this discussion with great interest. Please apologize my English, I'm still learning. So please feel free to correct me anytime. I have two answer about this wonderful app:

1) I always used the "regular" and bloody slow workflow with camera raw ecc. but when I switched to mlv app I immediately noticed that everything appear less "definite" and "clear". As if there is a thin veneer on every single frame. Do you know why?

1. In the profile section, try the "Reinhard 3/5" tonemapping function, you might not like the very smooth default tonemapping, which gives very cinematic highlight rolloff but is kinda flat looking.

If that does not work play with the dark strength and light strength sliders, adjusting the curves or using contrast slider. Or set gamma in profile section to some lower value like 2.6.

Quote from: Giovanni89 on January 02, 2020, 02:24:44 PM
2) is there any chance, also in the future, to use this application on the iPad? It would be perfect for me.
Thanks

If Qt compiles on iPad, but then iPad has no real file system so that is probably quite difficult to adapt for. Something more realistic is getting it working on Android tablets.

Pretty much no, sadly. Unless an iOS expert steps in.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 03, 2020, 11:11:14 AM
If any windows users are having issues, try the 32 bit build as well.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on January 03, 2020, 03:22:19 PM
Yes, I want to say thank you to Ilia3101, my problem has been solved.
This is very important guys. If starting from version 1.8, the program crashes when loading a mlv file, try the 32-bit version.

Now I just have to learn all the new features :)

Thanks to all who contributed to the creation of this program, for this wonderful app!

(https://i.ibb.co/Wn70BTW/mlvapp.jpg)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 03, 2020, 09:30:56 PM
Quote from: Giovanni89 on January 02, 2020, 02:24:44 PM
2) is there any chance, also in the future, to use this application on the iPad? It would be perfect for me.
I don't think so. With Qt we should be able to compile for iPad, yes. I just don't know if the standard C processing code can also be compiled. Is there a ffmpeg for iPad? (I guess not.) And Apple wants to be paid that we develop apps for them (we need to pay for a dev license). We can't sell the software with GPL license.
On the other side, we know how slow MLVApp can be on PC or Mac. An iPad is way slower, so I think it is not really worth it.

On Android we would not have the license problem. But the CPU power problem is the same. With reduced functionality it might be good (as a kind of viewer). But as processing app you'll need a lot of time...
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on January 03, 2020, 09:38:20 PM
If you pay apple for a dev licence this does not men the app has to be payed as well.

There are many free apps on the App Store.

And the latest iPad is faster than most laptops.

But the other issues are still there, ffmpeg etc.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 03, 2020, 09:49:22 PM
Quote from: Lars Steenhoff on January 03, 2020, 09:38:20 PM
If you pay apple for a dev licence this does not men the app has to be payed as well.
Yes sure... so you mean to pay apple with magic lantern donations? But we also have to pay for a place in the AppStore, right?

Quote from: Lars Steenhoff on January 03, 2020, 09:38:20 PM
And the latest iPad is faster than most laptops.
How can this be compared? App on iPad vs. emulated iPad-App on Windows? Sure... iPad wins since the first day. The processor has a very different architecture, so this should be hard because of the lack of corresponding applications.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on January 03, 2020, 09:52:27 PM
I have a apple dev licence, but that's the least difficult part ...

https://browser.geekbench.com/ios-benchmarks/

https://browser.geekbench.com/processor-benchmarks


When compared to intel cpu the race is close ( in single core )
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 03, 2020, 09:59:00 PM
I think the app also would run much more in single-thread mode, because there won't be OpenMP for iPad / Android. Or?! Edit: for Android it seems to exist.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on January 04, 2020, 03:11:26 AM
You can't compare geekbench scores for iOS to desktop CPUs, it's not the same.  Apple would like you to believe that, but it's a lie.  My desktop draws around 100W if I have the CPU at 100%, and I can add more than that again for the GPU, which MLV App uses too.  If your phone used 250W it would instantly burst into flames.  Phone SOC draws about 5W?  Image processing on a phone or tablet is going to be slooooooow.  Might still be good for some limited tasks.  Does not seem worth the hard porting effort to me.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on January 04, 2020, 07:00:09 AM
More samples here Ilia (shot with 50D), they might be useful because they also have skin tones in it. If there's anything else we could help in enhancing color processing on mlvapp, let us know:
https://we.tl/t-46aTP9T3wj
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 04, 2020, 01:02:01 PM
Quote from: names_are_hard on January 04, 2020, 03:11:26 AM
You can't compare geekbench scores for iOS to desktop CPUs, it's not the same.  Apple would like you to believe that, but it's a lie.  My desktop draws around 100W if I have the CPU at 100%, and I can add more than that again for the GPU, which MLV App uses too.  If your phone used 250W it would instantly burst into flames.  Phone SOC draws about 5W?  Image processing on a phone or tablet is going to be slooooooow.  Might still be good for some limited tasks.  Does not seem worth the hard porting effort to me.
That's what I think too. Little correction: MLVApp don't uses GPU (apart from some OpenGL for viewer dragging and zooming).
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Lars Steenhoff on January 04, 2020, 04:41:43 PM
I think you will be surprised how fast the mobile cpu/gpu have become recently

its good enough to edit 4k footage with effects on top

https://luma-touch.com/lumafusion-for-ios-2/

And I use lightroom mobile to edit dng stills, I tested and even cdng works in lightroom mobile.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 04, 2020, 04:58:32 PM
Mobile devices have special chips for decoding and processing video (and for doing all kinds of things), plus GPUs are always powerful these days, even in phones, an OpenGL fragment shader could do most of what MLV App does in real time. You just have to program stuff differently to make it fast on an iPad compared to a intel cpu, which would be a lot of stuff to re make in mlv app.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on January 04, 2020, 07:18:15 PM
Id love to have some app on pxel that has tonemapping exactly like You did it in MLVApp.When i shoot RAW on pixel i always conver in MLVApp because of tonemapping.
Is there a new version in repo with some color fixes for cyan and magenta ?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on January 04, 2020, 07:38:37 PM
I'm not surprised that phones are "fast", they're amazing for what they can do.  But they're optimised for efficiency not speed and they're not anywhere near as fast as desktop chips.  Desktop can do easily 10x a phone, without considering GPU (100x or more vs phone),and it can sustain that for hours, a phone will have to thermal throttle relatively quickly (1 minute?).  And that's the last I'll say about it in this thread as it's a massive derail.  Happy to benchmark / discuss etc in a separate thread!
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 04, 2020, 08:12:24 PM
Quote from: 2blackbar on January 04, 2020, 07:18:15 PM
Id love to have some app on pxel that has tonemapping exactly like You did it in MLVApp.When i shoot RAW on pixel i always conver in MLVApp because of tonemapping.
Is there a new version in repo with some color fixes for cyan and magenta ?
Not yet.

Quote from: names_are_hard on January 04, 2020, 07:38:37 PM
I'm not surprised that phones are "fast", they're amazing for what they can do.  But they're optimised for efficiency not speed and they're not anywhere near as fast as desktop chips.  Desktop can do easily 10x a phone, without considering GPU (100x or more vs phone),and it can sustain that for hours, a phone will have to thermal throttle relatively quickly (1 minute?).  And that's the last I'll say about it in this thread as it's a massive derail.  Happy to benchmark / discuss etc in a separate thread!
Yes, if we ran MLV App's processing on a phone it would be realllly slow. But I'm sure it would be possible to write a processing engine that runs fast on a phone. And not like MLV App runs fast on Intels anyway so who cares :D

Also @Luther your examples might be my favourite, they show the problem in context. I don't need any more footage now. Thanks everyone. I have loads now.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gambler on January 08, 2020, 06:51:50 PM
Quote from: Ilia3101 on January 03, 2020, 01:24:46 AM
Omg I lovve you! Great samplels plus I really wanted an ACR comparison. Great to see where we are both at. Soon MLV App will be destroying camera raw in this comparison.

Hello! do you mean about this?

I want to ask about, am I do something wrong? This is light from RGB LED Strip.  Sorry for my english...

(https://c.radikal.ru/c26/2001/2c/be5e94aa00c1.jpg)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 08, 2020, 09:41:40 PM
Quote from: gambler on January 08, 2020, 06:51:50 PM
Hello! do you mean about this?

I want to ask about, am I do something wrong? This is light from RGB LED Strip.  Sorry for my english...
HSL elements make such artifacts even worse (because of further color transformations).
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 08, 2020, 11:25:48 PM
Quote from: gambler on January 08, 2020, 06:51:50 PM
Hello! do you mean about this?

I want to ask about, am I do something wrong? This is light from RGB LED Strip.  Sorry for my english...

(https://c.radikal.ru/c26/2001/2c/be5e94aa00c1.jpg)

Could you send the raw file? I want to see how it looks without those Hue adjustments...

And does anyone know why adobe looks so much cleaner in terms of noise sometimes? It's frustrating.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on January 09, 2020, 01:20:12 AM
IMO its contrast and gamma in tonemapped algo that makes dark parts brighter and reveals the noise, default rec.709 from dngs when i preview dng files inside MLV containers looks darker in shadows and more contrasty but i dont like it , i prefere tonemapped and when theres noise i just darken shadows in MLVApp.Also rec.709 Looks very similar to tonemapped, im not sure if its typical rec.709.
We can do comparisons with frames opened in something like adobe raw and mlvapp to see if its cleaner because dark areas are... darker and hide noise better.
MLVApp:
(https://funkyimg.com/i/31ccs.jpg)
UFRaw:
(https://funkyimg.com/i/31ccA.jpg)
Same frame, no adjusting , just opened.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on January 09, 2020, 02:42:01 AM
Quote from: Ilia3101 on January 08, 2020, 11:25:48 PM
And does anyone know why adobe looks so much cleaner in terms of noise sometimes? It's frustrating.
I get the opposite effect. Can you post an example? AdobeRGB gives chroma noise in saturated cyan/blue for me. The three usable gamuts on MLVApp for me are sRGB, LogC and AP1.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gambler on January 09, 2020, 04:36:28 AM
Quote from: Ilia3101 on January 08, 2020, 11:25:48 PM
Could you send the raw file? I want to see how it looks without those Hue adjustments...

And does anyone know why adobe looks so much cleaner in terms of noise sometimes? It's frustrating.

sure, here is https://fex.net/ru/s/tlxfbsy
previous file is very big to send, I shot new one shorter
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on January 09, 2020, 08:44:05 AM
the expansion of the whole preset section is very good. Nice to see tonemapping, gamut, and (display?) gamma all separeted like this.

So the reinhrd function is something like this ? http://filmicworlds.com/blog/filmic-tonemapping-operators/ Can someone recap the other operations than the app is doing for the preview? I remember something like +2 exposure? Kind of what I had manage to match in Resolve.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on January 09, 2020, 10:52:43 AM
Sooo!

I came back to this. By following a couple of juan melara tutorial on youtubes and using is film lut I changed my post production process again!

No more 3d export lut in the preferences. I've moved into the color transform nodes.

I made 3 powergrades at the moment, the general idea is to put your wb in the raw panel, bmd film, +2 exposure (not needed if you expose correctly MAYBE) then first node a color transform to bmd to alexa log c just because it's more cool, then your corrections node, then another color transform where you bring it into rec709, apply the tonemapping options there, and then if you want add SOME of the nodes (not the contrast curve one) of the kodak poower grade that melare recreated.

One of the 3 is only the color transform and some clean contrast, another the color transform and some lifted contrast, a third the color transform and the extra kodak nodes that make film saturation and stuff.

Try them out!

https://www.mediafire.com/file/ojcqpc76pax6brz/MLV_dngs_color_transform_power_grades_for_davinci_resolve.zip/file
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 09, 2020, 01:26:50 PM
Quote from: gambler on January 09, 2020, 04:36:28 AM
sure, here is https://fex.net/ru/s/tlxfbsy
previous file is very big to send, I shot new one shorter

Thank you. You can also shorten clips in MLV App.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 09, 2020, 03:49:58 PM
Improvement...
(https://i.postimg.cc/Y90Znych/Screenshot-2020-01-09-at-14-48-55.png)

Nicer highlights than Adobe...
(https://c.radikal.ru/c26/2001/2c/be5e94aa00c1.jpg)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 09, 2020, 03:54:56 PM
Quote from: Luther on January 09, 2020, 02:42:01 AM
I get the opposite effect. Can you post an example? AdobeRGB gives chroma noise in saturated cyan/blue for me. The three usable gamuts on MLVApp for me are sRGB, LogC and AP1.

No I meant does anyone know why Adobe image processing looks so much cleaner, it just shows nice grain instead of noise, while MLV App and other raw converters show blotchy colour ugliness.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 09, 2020, 08:31:22 PM
Quote from: Ilia3101 on January 09, 2020, 03:54:56 PM
No I meant does anyone know why Adobe image processing looks so much cleaner, it just shows nice grain instead of noise, while MLV App and other raw converters show blotchy colour ugliness.
At least in LR5 Adobe uses a chroma denoiser for this. This is the default. At 0 it looks also worse. (Farbe = Chroma/Colors)
(https://user-images.githubusercontent.com/30245296/72098468-ced01400-331e-11ea-9fff-bebc369fbfa9.png)
So if you increase RBF Denoise Chroma in MLVApp, it looks nearly the same. MLVApp just gets very slow with this single threaded RBF filters...
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 09, 2020, 09:19:19 PM
But even without denoising, compating adobe with other software, Adobe has almost monochromatic noise, other software shows colorful noise. And at high ISO adobe noise does go a bit purple, but still not much colour variarion in the noise. Could you show me an example of colour noise in Lightroom compared with mlv app? (without enabling denoising in either)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 09, 2020, 09:41:14 PM
I would say LR looks even worse when I set chroma denoise to 0. For LR6 and later, I bet Adobe implemented an chroma denoise offset of 25... becaues LR5=25 looks like LR6=0.
(https://i.ibb.co/5M1jh43/Bildschirmfoto-2020-01-09-um-21-37-35.png)
(EOS 5D2 @ ISO3200, a bit underexposed frame)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on January 09, 2020, 09:54:20 PM
In my ACR denoise is set to 0 in default mode.

Here is some horrible example in a dark church with 3200 iso:

MLV App by default:
(https://bitbucket.org/Dmytro_Kn/ml/downloads/MLVApp_default.jpg)

MLV App zoomed dark area:
(https://bitbucket.org/Dmytro_Kn/ml/downloads/MLVApp_zoomed.jpg)

ACR default:
(https://bitbucket.org/Dmytro_Kn/ml/downloads/ACR_Default.jpg)

ACR Zoomed:
(https://bitbucket.org/Dmytro_Kn/ml/downloads/ACR_Default_Zoomed.jpg)

ACR +1 exposure:
(https://bitbucket.org/Dmytro_Kn/ml/downloads/MLVApp_1_exposure.jpg)

ACR +1 exposure Zoomed:
(https://bitbucket.org/Dmytro_Kn/ml/downloads/MLVApp_1_exposure_zoomed.jpg)


DNG file 1 frame:
https://bitbucket.org/Dmytro_Kn/ml/downloads/M24-1501_frame_1.dng
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 09, 2020, 10:00:09 PM
Quote from: Dmytro_ua on January 09, 2020, 09:54:20 PM
In my ACR denoise is set to 0 in default mode.
Then you have probably a newer version... as I said: LR5 Denoise=25 looks the same like LR6+ Denoise=0.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 09, 2020, 10:14:25 PM
Here your DNG, screenshot from LR5 at a similar (not identical) looking white balance. Noise, noise, noise...
(https://i.ibb.co/6gWFcJD/Bildschirmfoto-2020-01-09-um-22-12-03.png)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 09, 2020, 10:18:35 PM
Quote from: masc on January 09, 2020, 09:41:14 PM
I would say LR looks even worse when I set chroma denoise to 0. For LR6 and later, I bet Adobe implemented an chroma denoise offset of 25... becaues LR5=25 looks like LR6=0.
(https://i.ibb.co/5M1jh43/Bildschirmfoto-2020-01-09-um-21-37-35.png)
(EOS 5D2 @ ISO3200, a bit underexposed frame)

So I am wrong. Good to see that Adobe is not magic.

I just don't have it, so I never have a clue how things really compare :)

Quote from: masc on January 09, 2020, 10:00:09 PM
Then you have probably a newer version... as I said: LR5 Denoise=25 looks the same like LR6+ Denoise=0.

Interesting.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on January 10, 2020, 06:53:37 AM
In MLVApp, I use Chroma separation and set the Chroma blur radius to 6 or 7.  If the shot was not taken at some extreme ISOs or the darks were not too underexposed, this reduces these ugly color blotches almost to zero and I end up with monochromatic noise.  Then I just push the RBF denoise luminance  slider to the right to smooth out the monochrome noise a little, so its not so intrusive.  And that's basically it.  In most cases, this provides a satisfactory result.  You cannot do much more than that to clean the noise of a noisy shot.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 10, 2020, 11:36:28 AM
Quote from: IDA_ML on January 10, 2020, 06:53:37 AM
In MLVApp, I use Chroma separation and set the Chroma blur radius to 6 or 7.  If the shot was not taken at some extreme ISOs or the darks were not too underexposed, this reduces these ugly color blotches almost to zero and I end up with monochromatic noise.  Then I just push the RBF denoise luminance  slider to the right to smooth out the monochrome noise a little, so its not so intrusive.  And that's basically it.  In most cases, this provides a satisfactory result.  You cannot do much more than that to clean the noise of a noisy shot.

RBF chroma denoise is much better then chroma blur though! Have you tried it? I find it much better. But most of the time I don't do any chroma noise reduction, don't like smeared colours.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on January 10, 2020, 11:49:04 AM
Quote from: Ilia3101 on January 10, 2020, 11:36:28 AM
RBF chroma denoise is much better then chroma blur though! Have you tried it? I find it much better. But most of the time I don't do any chroma noise reduction, don't like smeared colours.
Yup, sometimes chroma blur is good at the same time with RBF to further clean the chroma noise but very small amount of blurring have to be applied to not smear/wash colors out.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on January 10, 2020, 04:04:46 PM
Quote from: masc on January 09, 2020, 10:00:09 PM
Then you have probably a newer version... as I said: LR5 Denoise=25 looks the same like LR6+ Denoise=0.

Camera Raw 11.2
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on January 10, 2020, 04:37:14 PM
Quote from: Ilia3101 on January 10, 2020, 11:36:28 AM
RBF chroma denoise is much better then chroma blur though! Have you tried it? I find it much better. But most of the time I don't do any chroma noise reduction, don't like smeared colours.

Yes, I tried different options including the RBF chroma denoise and combinations between chroma blur and denoise but did not like the result.  I prefer to kill the color noise first and then try to reduce the monochromatic one to an acceptable level without too much softness or smearing.  This works best for me, especially in shots with underexposed and noisy shadows.  In my experience, RBF chroma blur does not introduce softness or smearing of the finest detail and works quite well with wide angle videography, especially in combination with some sharpness, (typically 85-90).   
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 10, 2020, 04:46:31 PM
Quote from: Dmytro_ua on January 10, 2020, 04:04:46 PM
Camera Raw 11.2
Camera Raw 8.7.1 here for LR5
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on January 11, 2020, 04:22:51 PM
Quote from: Ilia3101 on January 09, 2020, 03:54:56 PM
No I meant does anyone know why Adobe image processing looks so much cleaner, it just shows nice grain instead of noise, while MLV App and other raw converters show blotchy colour ugliness.
Oh, I see. I guess it's either because of default chroma denoise or some trickery with the demosaicing (it uses AMAZE, IIRC, but the implementation might be doing something different). They also probably have better color processing and hot/cold pixel removal, which might affect the looks of the noise.
I think using Rawtherapee as a comparison together with ACR would also be useful, since the code is open and RT is very a stable and complete software.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 11, 2020, 05:59:03 PM
Quote from: Luther on January 11, 2020, 04:22:51 PM
I guess it's either because of default chroma denoise or some trickery with the demosaicing (it uses AMAZE, IIRC, but the implementation might be doing something different).
Somewhere I read in the net that ACR uses a modified AHD demosaic. And this seems to be true, if you choose AHD in MLVApp you get nearly identical artifacts as in ACR. AMaZE looks very (in details) different.

Quote from: Luther on January 11, 2020, 04:22:51 PM
They also probably have better color processing and hot/cold pixel removal, which might affect the looks of the noise.
The noise removal is indeed very nice, and fast compared to MLVApp. For the bad pixel removal, I am not very satisfied in ACR... here I like more our new bad pixel picker function, because it does exactly what the user wants instead of some auto algorithm.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 11, 2020, 08:09:14 PM
Quote from: masc on January 11, 2020, 05:59:03 PM
Somewhere I read in the net that ACR uses a modified AHD demosaic. And this seems to be true, if you choose AHD in MLVApp you get nearly identical artifacts as in ACR. AMaZE looks very (in details) different.

I heard before that AHD is "industry standard" or something, so it's likely. But adobe have been making improvements to their debayer recently, so it's probably a lot better in the newest versions (would like to see a nice comparison of MLV App, latest resolve and latest adobe on a moire shot)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on January 12, 2020, 01:55:44 PM
Hi! Would it be possible to add a clip text-labelling feature? To be able to add a short text note in the clip window to identify clips would add super-shine to MLVApp! :P
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: koopg on January 18, 2020, 12:19:50 PM
Quote from: Luther on October 28, 2019, 05:13:06 AM
It creates a DCP file @koopg? Currently there's no way to input DCP files in MLVApp. Are you using this to get correct white balance? Try a simple 18% gray card... MLVApp has a WB picker.

I requested this before here (https://www.magiclantern.fm/forum/index.php?topic=20025.msg220459#msg220459) and here (https://www.magiclantern.fm/forum/index.php?topic=20025.msg220499#msg220499), but upon some reading of the RT code, the Lab feature requires many core functions. Might be really difficult to adapt it to mlvapp.
@2blackbar The feature CIECAM02 in advanced tab can be a better way to bring correct saturation to shadows. Instead of using a "film-like" curve, try to increase "Brightness + Colorfulness (QM)" in CIECAM first. From my tests, this method of correcting exposure adapts shadow/highlight saturation very well already. Sometimes it's not even necessary to use Lab adjustments...
Not just white balance
Its making all colors acuurate.
You are going to have true colors
So i can batch have all clips true color
Ready to be grade evenly

Sent from my SM-N975F using Tapatalk

Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on January 22, 2020, 11:44:04 PM
Any chance for DNxHD not scaling the frame size in 1920x1080 ?
Or when smaller, compose on Black ?

I am shooting at 1920x804 at 50FPS.
MLVApp/DHxHD scales the frame size to 1920x1080.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 23, 2020, 09:33:42 AM
It isn't MLVApp, limiting DNxHD to 1920x1080, it is the codec itself. https://en.wikipedia.org/wiki/List_of_Avid_DNxHD_resolutions
It is better choosing another codec, when you have other aspect ratio than 16:9.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on January 23, 2020, 01:07:11 PM
Masc,

I would like to report a bug that I have been experiencing for quite a while with the latest versions of MLVApp, including version 1.10.  When I open a session of say 20 MLV files and after corrections to everyone of them I start exporting them, they all get normally rendered but a few of them do not get normally saved.  In 3 to 5 out of 20 files just the first few frames get saved and the file is just a few MB of size, accordingly.  I tested the ProRes422LT export option but it seems to happen with other export formats too.  There is no rule here - part of the files in a random order get just saved in that way, regardless of the camera that the files were generated with (5D3, EOS-M, 100D).  Therefore, I have to run rendering those shortened files again which is quite a waste of time and pretty annoying.    I tested this on 4 different computers - 2 PCs and 2 laptops and I get this same behavior on all 4 of them. 

Could you please take a look with some of your files?  Thanks.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on January 23, 2020, 01:10:59 PM
Quote from: timbytheriver on January 12, 2020, 01:55:44 PM
Hi! Would it be possible to add a clip text-labelling feature? To be able to add a short text note in the clip window to identify clips would add super-shine to MLVApp! :P

Maybe.

Quote from: masc on January 23, 2020, 09:33:42 AM
It isn't MLVApp, limiting DNxHD to 1920x1080, it is the codec itself. https://en.wikipedia.org/wiki/List_of_Avid_DNxHD_resolutions
It is better choosing another codec, when you have other aspect ratio than 16:9.

Yes but Quentin is requesting black bars I think
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 23, 2020, 01:28:49 PM
@IDA_ML: I think this is just possible, if ffmpeg stops working. I have never seen this, and I render really a lot. You are on Windows? Did you close the terminal box by accident?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on January 23, 2020, 02:06:41 PM
Yes, I am on Windows 7.  I don't know what you mean by "terminal box".  Is this the black box that opens when every new file starts rendering?  No, I don't close this box, just minimize it.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 23, 2020, 04:17:33 PM
Exactly this box. If you would close it, you close the tunnel to ffmpeg.

Edit: converted now 14GB MLVs, 20files to 1.7GB ProRes LT on Win8.1 without any issue.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on January 23, 2020, 07:12:49 PM
I'll give it a try again without touching (minimizing) the terminal window.  Thanks.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: flostro on January 23, 2020, 07:26:14 PM
Quote from: ilia3101 on January 23, 2020, 01:10:59 PM
... Quentin is requesting black bars I think

In MLRawviewer I used ffmpeg to pad Video that wasn't 16/9 to get DNxHD with black bars

-vf pad=1920:1080:0:(1080-ih)/2

it only works correctly with footage that is 1920 pixels wide, because that was all I needed.
Combined with scaling it could be modified to work with all frame sizes and aspect ratios.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DavidSamish on February 03, 2020, 07:01:23 AM
I've just started using the MLV App and it seems to work, although I am not sure about the best settings/formats for rendering.
My biggest problem is there is no audio track.
I have the mlv_lite, mlv_rec, and mlv_snd modules activated on my D5 Mk1III, with ML Nightly.2018Jul03.5D3123.
I just activated MLV Sound. Was that it? I've got to experiment more...
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 03, 2020, 08:55:35 AM
If MLVApp don't shows a sound track, there is no sound track recorded.

If there would be a best setting/format for rendering, there would just be one. You need to set this up to your needs and for how you use it in your project and with your software.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 03, 2020, 09:00:54 AM
Quote from: masc on January 23, 2020, 04:17:33 PM
Exactly this box. If you would close it, you close the tunnel to ffmpeg.

Yes, I checked that.  It is best if you leave that box untouched.  Then it works.  Thanks a lot, Masc!
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on February 06, 2020, 09:22:36 AM
Hey @Ilia3101, nice progress on the last commits about the raw wb, blue desaturation and changing reinhard to float. Couldn't test yet (might be able next week), but I'm trying to keep track on those change :)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 06, 2020, 07:39:56 PM
Its not just blue desaturation, it gently desaturates all out of gamut colours with reinhard kind of function (instead of just bringing it to the edge of the gamut). Unfortunately it desaturates green grass a bit right now, need to fix that. Also has some occasional new artifacts (😢

Low light shots are likely to be improved tho
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on February 08, 2020, 12:40:55 PM
Small tip i found, If You want to use "allow creative adjustments" when you have c-log and lut in use ( cause normally adjustments are locked out until you tick creative adjustments)then set dark range to 0, this way it looks fine again.
This helped me to use highlight reconstruction when lut is in use and recover some detail, when creative adjustments are locked out then you cant recover highlights.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 08, 2020, 06:11:55 PM
oh highlight reconstruction is disabled? it shoudlnt be. its just a correction
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 08, 2020, 06:51:01 PM
@2blackbar: could you please write which option you click in which order? Tried to reproduce, but "Highlight Reconstruction" is always available.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on February 08, 2020, 10:03:01 PM
When i switch from tonemapped to alexa log-c, then all adjustments above are disabled besides exposure.
Sorry i didnt explain it more clearly.
So when you allow cretive adjustments while using log-c and some kind of lut then image gets darker and overall bad looking, just go to dark range and set it to 0
What i mean is, when You use alexa log-c in preset instead of tonemapped default then yes you can tick highlights reconstruction but it does not work until you enable creative adjustments
(https://funkyimg.com/i/326qb.gif)
So... im thinking, if it works that way then maybe instead of diabling adjustments for clarity , vibrance etc. when using alexa log-c it would be better to just lock dark range at 0 when log-c is chosen and all is good ? We could still use sliders for clarity vibrance and all that
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 09, 2020, 03:33:01 PM
If your bright tones are outside the visible range, you won't see highlight reconstruction. Highlight reconstruction corrects pink highlight to somewhat more natural color, but won't change exposure. What you mean is having "Highlights" working. But for this "math", you'll need to have "Creative adjustments" active.
(https://user-images.githubusercontent.com/30245296/74104161-585b4780-4b52-11ea-8658-864fd1e85c99.jpg)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on February 09, 2020, 05:36:43 PM
Yes and when you enable creative adjustments then image gets crushed until you set dark range o 0, so i suggested setting dark range to 0 automatically when creative adjustment is enabled when log-c is chosen
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 09, 2020, 06:10:31 PM
HIGHLIGHT RECONSTRUCTION AND HIGHLIGHTS SLIDER ARE DIFFERENT THIGNS >:(
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on February 10, 2020, 06:39:52 PM
Yeah.But i recover with slider at 50, more than that looks artificial.At 0 most of the time doesnt work.
But my main focus was dark range affecting image , disabling it to 0 will fix that.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: scotophorus on February 10, 2020, 08:00:45 PM
I've had some trouble with highlighs as well, i recorded a video showing it.
Also it would be great if we could embed the metadata from the mlv to the prores file, so the date and time for instance of the exported mov could be the same as from the day we shot the video.

Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 10, 2020, 08:24:44 PM
@scotophorus:
the main problem with your clip is a overexposed sky. Note, that overexposed areas can't 100% be recovered. The problem with the color comes exactly with that. One (the green) channel is overexposed, while 2 channels are okay, what results in pink. Now the challenge is to reproduce the correct color without the green channel  ( =2/3 of the information ).
The best you can do: make sure to not overexpose important areas in your picture. Use e.g. the ML histogram which does a great job.
Unfortunately I don't know any way to embed any metadata into a prores file. Is this possible at all? I have never seen this. Let me know if someone knows how to do!
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Lucjan on February 11, 2020, 05:40:53 PM
Hello everyone!

I have problem with the dual Iso processing. I have dual Iso Raw I can import the file but don't know wot to do next. Always I receive blinking exported file or black and green mess.
MLV App 1.10
file from - Canon 5D mk2 - 1280x960 Iso 100/800 - Raw 2
I am confused it is quite simply program.  :(
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 11, 2020, 08:49:48 PM
@scotophorus

That highlight reconstruction issue will be fixed. I need to think about how though. I almost have ideas.

For now:
Move the tint slider around. You will be able to make the recostructed areas match the rest of the shot... Then you can correct the resulting tint with the green curve ;)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 11, 2020, 09:15:08 PM
Quote from: Lucjan on February 11, 2020, 05:40:53 PM
Hello everyone!

I have problem with the dual Iso processing. I have dual Iso Raw I can import the file but don't know wot to do next. Always I receive blinking exported file or black and green mess.
MLV App 1.10
file from - Canon 5D mk2 - 1280x960 Iso 100/800 - Raw 2
I am confused it is quite simply program.  :(
Have you activated dual iso in RAW Corrections tab?
Please upload a short clip for analysis.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Lucjan on February 11, 2020, 10:29:34 PM
Thank you for the quick reply.

In "Enable RAW Correction" "Dual iso" I do "Force" then Off, On, Preview

MLV file -110 and 20 frames of my test film and dark frame:
https://drive.google.com/drive/folders/1PkKXz0XYTQzWVOlBAofcqSNr6uEt8rLJ?usp=sharing

Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 12, 2020, 02:16:22 PM
That's not Dual ISO, that's HDR video. I know no cure for that.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 12, 2020, 02:34:14 PM
Quote from: ilia3101 on February 12, 2020, 02:16:22 PM
That's not Dual ISO, that's HDR video.
Haha... that was my first idea when I heard 5D2 and DualIso.

@Lucjan
If you are on OSX, you can choose a post export "HDR_MOV.command" script in the export settings of MLVApp. On other OS you'll have to search your own solution.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Lucjan on February 12, 2020, 04:02:52 PM
OK.
So I know now that it was my misunderstanding of the settings of my Camera. I have my solution to that HDR files, separate high and lo iso frames - speed up 2x move one frame and speed up 2x then keying (color luma whatever, mask) and combine that to clips after all doubling frames so the speed is 1x. I end up with film 15 FPS but the dynamic range is high. I will do some experiments with HDR with RAW but the workflow will be a bit more complicated. I'm going to film welding process better then now.

My goal is something like these
https://youtu.be/bwX-NjQHW4c?t=59
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on February 12, 2020, 10:49:16 PM
Probably stupid question, if I select BMD film etc and export prores, then export dngs, then bring both of them into Resolve and select BMD film for the dngs the two recordings looks slightly different. Nothing else should be changed.
Anybody is having the same experience ?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 12, 2020, 10:53:25 PM
Because to be honest BMDFilm is a bullshit concept. For each Blackmagic camera it seems to have a different gamut and a different curve. I found a matrix on some blackmagic forum, and the log curve may have been added by masc. Both are definitely wrong.

What gamut and curve does BMDFilm have for non Blackmagic cameras in Resolve? Who knows...

TLDR: I do not recommend it, use a better defined log profile like Arri Log C
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 13, 2020, 10:38:21 AM
Quote from: ilia3101 on February 12, 2020, 10:53:25 PM
Because to be honest BMDFilm is a bullshit concept. For each Blackmagic camera it seems to have a different gamut and a different curve. I found a matrix on some blackmagic forum, and the log curve may have been added by masc. Both are definitely wrong.

What gamut and curve does BMDFilm have for non Blackmagic cameras in Resolve? Who knows...
Yes, I added that. That time I tested just with clips of my 5D2 and it looked extremely close to Resolve. So I could get the same look, I had before in Resolve, in MLVApp. But I can't garantuee it works the same for other cams, because Resolve is a blackbox for me.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: rjakiel73 on February 13, 2020, 08:06:23 PM
Running Windows 10 Home with latest MS patches, etc... MLV 1.10 works perfectly EXCEPT for one thing.  I cannot export audio.  The option is greyed out in the Export Settings.  Any help would be appreciated.

EDIT:  Brain fart.  OK fixed.  When framerate override in checked it becomes unavailable.  Now I know.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on February 13, 2020, 10:54:00 PM
Quote from: ilia3101 on February 12, 2020, 10:53:25 PM
Because to be honest BMDFilm is a bullshit concept. For each Blackmagic camera it seems to have a different gamut and a different curve. I found a matrix on some blackmagic forum, and the log curve may have been added by masc. Both are definitely wrong.

What gamut and curve does BMDFilm have for non Blackmagic cameras in Resolve? Who knows...

TLDR: I do not recommend it, use a better defined log profile like Arri Log C

Yes you're right, there're so many flavour of it that I should not compare the two implementations. I was just wondering about it specifically because that's how you have to process dngs inside resolve if you want to follow this path : https://www.youtube.com/watch?v=8qJ7i9b28Lo


Anyway no big deal :)  I was just curious!
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on February 15, 2020, 06:30:04 AM
@masc @Ilia3101 @bouncyball
Did you guys see this new feature on Rawtherapee? This is doing 'magic' with some of my photos:
https://github.com/Beep6581/RawTherapee/issues/5412

Might be too dificult to adapt the code to MLVApp, but something like that for video would be awesome. Maybe some day.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 15, 2020, 06:46:11 PM
Thanks Luther. Looks very interesting. Code is hidden here (https://github.com/Beep6581/RawTherapee/blob/40018b1e9ad9e0db306ffac6e6c7ceaac97927f6/rtengine/capturesharpening.cc).
Looks not impossible to port, but it is a lot of work. And if I see all the funny for-loops, it won't be very fast. But I like the results...
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: [email protected] on February 16, 2020, 12:39:29 PM
Hi Guys ... I'm 'new' to both Magic Lantern and MLV App. Congrats to all for your amazing work ...
I've done some testing with the M/L 10/12-bit 'RAW' release on a 70D and created uncompressed files via the MLV App with 'good' results - until ....
my 3rd test which was a few seconds of a 'kitchen scene' and here that I discovered (after 'converting' via MLV App as usual) an unexpected result.
There was a 'cooking stove' in the back-ground with 6 identical circular gas controllers (all horizonally in line), and which, once the footage was converted, manifested a horizontal 'blur' on these dials on *some* frames, as though the encoder was confused as to which dial was which and trying to somehow compensate.

After further testing, (and one by one removing ALL *settings* that I'd used), it came down to the ●Smooth Aliasing● on the Export Setting. When selected, (and in ANY mode of selection), it will evoke the aforementioned problem of random (horizontal) blurring of the 6 identical circular gas controls, as though one dial was being 'confused' with the adjacent dial.

If I knew how to post an image of this anomoly I would (maybe someone could). I'm hoping it's not just me - ie: 'operator error', but I've really been rather methodical with my approach and feel that this may well be a legitimate problem. Thanking you for your precious time ....

~ Steve ~
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: [email protected] on February 16, 2020, 04:10:38 PM

Images of the issue found here:

1st pic - Frame capture of a 'normal' unaffected frame
2nd pic - Frame capture of a 'blurred' frame where the intermittant/cyclic problem occurs:

https://www.dropbox.com/s/29z8ujzsd03v4jz/02%20Normal.png?dl=0
https://www.dropbox.com/s/96ticexdxu7f9n1/02%20Blurred.png?dl=0

Note that the merging/blurring is random and sudden during footage replay.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 16, 2020, 04:15:10 PM
Smooth aliasing has had many victims in the past.

It is not good for moving shots, and your issue seems to be a new one.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 16, 2020, 04:18:50 PM
Quote from: togg on February 13, 2020, 10:54:00 PM
Yes you're right, there're so many flavour of it that I should not compare the two implementations. I was just wondering about it specifically because that's how you have to process dngs inside resolve if you want to follow this path :

Anyway no big deal :)  I was just curious!

I think I have seen that video before. The point is not to use simple LUTs for converting log footage to rec709 then grading it... but instead use a colour space transform node so nothing gets lost or clipped (do I remember right?). That path is definitely possible with any colour space in Davinci resolve, not only for bmdfilm.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: andrew_dotdot on February 17, 2020, 09:44:23 PM
@sonic Re: ML on a 70D vs. Aliasing...

I sold my 70D (which I loved many things about) because the aliasing/moire/stairstepping was so pronounced. Hoodie zippers. Roof shingles. Fences. Water. You name it. : ((( 

Here's a film I made on the 70D. (720p 25 raw, which I could record continuously - yay!) ML was stable and I love a lot of how it looks, but the opening seconds really show off a zipper alias party. There were so many good shots that turned out to be unusable due to moire. : (((((



I have a feeling that if you feel you need to use the anti-aliasing feature, you're not going to be a happy camper. I tried everything, but it was still yuck.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: [email protected] on February 20, 2020, 02:14:18 PM
@ ilia3101 - thankyou - I'm just discovering things as I go ....

@ andrew_dotdot  Hey Andrew! .... thanks so much for your video, I really enjoyed it ! - It's so nice to see such intimate views of creative skills at work, most enjoyable. These are the 'hands-on' arts and crafts that are sadly *missing* from my life - my own doing of course - since I'm a movie making addict - lol.

But yes - I see exactly what you mean about the aliasing and moire - thanks for that ...... You know, though such shots might be 'objectionable', but there's a low percentage overerall. I'm wondering whether it would be possible to make 'changes' during the shoot like 'removing' such zipped clothing (hit and miss, I know), OR to somehow deal with these shots in post production by slightly blurring the affected region - granted, this would be easier on a 'static shot'.

Andrew, my 'problem' is I'm heavily invested in the 70D's. I have a mix of both APS-C and vintage Full Frame lenses all bought for this model. (I've actually got 3 x 70D bodies, all purchased second hand, and all in really good shape with low shutter counts). So I'm not sure I could make the change to other gear - it's taken me several years getting to where I'm at ...... This is a real dilemma .... Having 'tasted' Magic Lantern's visual quality, I don't think I could go back to filming compressed/lossy formats.

I've been experimenting with different horizontal resolutions between 1600 and 1832 pixels but the 'moire' always seems to be there on *certain shots*. Anyway, I guess it's a matter of how much I'm going to let this be a road block - (which it somewhat is) - since I like 'perfect shots' as much as most of us do .......

Thanks again for your kind assistance - I'll *keep on trying* - maybe there's an answer somewhere .....
- Steve -
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 20, 2020, 02:23:54 PM
Quote from: [email protected] on February 20, 2020, 02:14:18 PM
But yes - I see exactly what you mean about the aliasing and moire - thanks for that ...... You know, though such shots might be 'objectionable', but there's a low percentage overerall. I'm wondering whether it would be possible to make 'changes' during the shoot like 'removing' such zipped clothing (hit and miss, I know), OR to somehow deal with these shots in post production by slightly blurring the affected region - granted, this would be easier on a 'static shot'.
The best idea should be using other lenses and maybe better settings: with a very fast lens wide open @ 180° shutter it becomes very hard to produce and to find moiree. Color moiree can be filtered by MLVApp, but luma moiree can't (atm). And what debayer algorithm was selected for this video? Looks like "bilinear" or "simple"...
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 20, 2020, 03:05:53 PM
Quote from: [email protected] on February 20, 2020, 02:14:18 PM
I've been experimenting with different horizontal resolutions between 1600 and 1832 pixels but the 'moire' always seems to be there on *certain shots*. Anyway, I guess it's a matter of how much I'm going to let this be a road block - (which it somewhat is) - since I like 'perfect shots' as much as most of us do .......
Always use the highest resolution you can - using a lower resolution simply crops the full image down.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: [email protected] on February 21, 2020, 08:37:02 AM
@ masc My 'fastest' lens is the Sigma 18-35mm at f:1.8, but these M/L tests I've been doing (indoors) have been on a Tokina 11-16mm f:2.8 lens. As you mentioned, I've used 1/50 sec as my shutter speed, because of shooting at 24fps. (I *think* M/L gives me 1/48sec?). I'm not sure what filter Andrew used for his video, but I've been doing tests with 'AMaZE' which I'm finding really nice. - It may not be the sharpest, but I think overall it looks the most natural.
Oh - and when you say "Color moiree can be filtered by MLVApp" - which setting are you referring to? (please) .....

@ilia3101 ..... "Always use the highest resolution you can - using a lower resolution simply crops the full image down."
Ah ... that makes sense - I was wondering why the M/L 'calculator' kept increasing the 'crop factor' readout when I was clicking down through the frame sizes. Thanks!
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 21, 2020, 10:28:54 AM
Please note that if you film at high resolution but watch the video on a lower resolution screen, aliasing becomes much more obvious.  What I do to avoid this is always downscale the video to the resolution of the screen that I will be watching the video on.

If however, you film in one of 3:3 modes, say 1736x976 and your screen resolution is 1920x1080, upscaling the video to the screen resolution only makes aliasing worse.   
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 21, 2020, 10:31:52 AM
Did you use such lenses wide open? Closing the aperture also brings moiree. What you show in you video looks very unusual for AMaZE.
Use CA Desaturate / Radius in MLVApp. https://github.com/ilia3101/MLV-App/wiki#ca-desaturate--radius Works for CAs and color moiree.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: [email protected] on February 21, 2020, 01:02:58 PM
@IDA_ML ....
Ah ... OK - that may explain things too. My Display is 1920 x 1080. For quality, I've been upscaling the 70D shots to 3K for adding CGI later (which tends to be 'sharp'). Then I'll finalize at 1920 x 817 and/or 3840 x 1634. Since I'm 'monitoring' at 1920 x 1080 it's not ideal. (Can't afford a proper broadcast monitor). Even so, I *feel* that it's more of a 'moire' issue than aliasing. Maybe they're linked? - don't know. - Thanks for your thoughts!

@masc ....
Yes, I used the f:2.8 (Tokina) 'wide open'. Thanks though, it's good to know wide-open is best. That'll work well with my plans. I've recently purchased ND filters, and intending to shoot everything at max aperture - love that shallow depth of field.  (btw - the only vision I've put on this forum so far are (links) to a kitchen stove showing a motion problem, so when you refer to what you see in a 'video', I'm wondering if maybe you're thinking of Andrews video upload?)  Wow - I'd not tried that Chromatic Abberation control. That's absolute magic! I'd seen it there but thought nah - the lenses didn't need CA correction. Amazing, and it works *really* well on 14 bit test shots - (was getting magenta & green fringing on edges) - This setting's totally removed them. Thank you!
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: [email protected] on February 22, 2020, 05:40:58 PM

I'm confused - can or does MLV App export ProRes 4444 video at 12bit color depth?  I simply need 12 bit video files exported directly from MLV App for importing into Vegas Pro 16. I don't want to use proxies or any file linking. Whatever I try, it ends up being 8 bit once inside of Vegas even though I've selected 32-bit floating point video levels in the Vegas Project Properties.

MLV App  >  Export 12bit Video  >  import into Vegas 16

Thanks ......
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 22, 2020, 05:56:40 PM
(https://i.postimg.cc/prgMzs2C/Screenshot-2020-02-22-at-17-49-33-png-500px.png)
Should give highest resolution export files.
Do note that exporting to a log signal from raw. i.e cineon, alexa log etc is more important than bitdepth 10/12. No use exporting to rec709 with cut display referred signal(1.0) if you want to work with most maximum dynamic range/color space in preferred nle.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 22, 2020, 06:52:24 PM
Exporting with the ffmpeg options will bring 10bit ProRes, exporting with AVFoundation will bring 12bit (OSX only). 8bit ProRes can't be exported by MLVApp.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: reddeercity on February 23, 2020, 05:43:18 AM
I found open source GPU NVIDIA Cuda acceleration for video apps
QuoteSet of Python bindings to C++ libraries which provides full HW acceleration for video decoding, encoding and GPU-accelerated color space and pixel format conversions
https://github.com/NVIDIA/VideoProcessingFramework

https://github.com/NVIDIA/VideoProcessingFramework/commit/29e07b227817d1d323054e84a80a52bda4d61bdc
support for FFMpeg

Is this useful ? since you guys use ffmpeg 

Edit: Here a open source GPU accelerated video and image processing  for mac
https://github.com/BradLarson/GPUImage2
Hope this can help
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: [email protected] on February 23, 2020, 07:54:05 AM
I'm using Windows, so I don't have the *AVFoundation option* for ProRes 4444 (only ffmpeg). Yes, I'm using Alexa Log.

Checking the ProRes4444 clip's 'Properties' INSIDE of Vegas, it shows 2560 x 1090 x 32 ? - which seems to imply it's 8bit + alpha?  When trying to use 'MediaInfo' to check it - I can't see any color depth reporting. All I'm trying to achieve is 12bit throughput without proxies. (wysiwyg).

Then I tried 16bit PNG sequences from MLVApp WHICH DO show in Vegas as 2560 x 1090 x 48, but even then I'm trapped.
● Rendering to almost all Vegas Codecs will result in 8 bit exports (even from these 16bit PNGs from MLVApp). (my flow is FX > render > re-import > add FX > render > reimport).
● If I *stay* PNG all the way, they double their size (Vegas turns them into 2560 x 1090 x64).
● If I export the MLVApp's PNG's from Vegas as Uncmpressed instead - it takes me back to 8 bit.
● If I export the MLVApp's PNG's from Vegas as Grass Valley Lossless, I'm also back to 8 bit.
● If I export the MLVApp's PNG's from Vegas as 'SonyYUV 10-bit YUV' - I finally get at least 10bits BUT it's YUV, and Vegas uses RGB internally so that's a needless YUV to RGB conversion every time I add FX.

I simply want to go from M/L 12bit DSLR through to a 12bit final edit in Vegas - and I'm not understanding - please, why am I having so much difficulty?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 23, 2020, 08:28:47 AM
Your issues seems related to sony vegas not mlv app. I recommend export to dng files and use resolve instead to maintain 12bit raw quality pipe.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 23, 2020, 09:50:23 AM
@[email protected]:
No idea what Vegas does. 16bit PNG has 3x16bit, ffmpeg ProRes4444 has 4x10bit, no matter what Vegas tells. Maybe Vegas interprets it with such low bitdepth, but then this is (as Danne wrote) an Vegas issue.
What's the point you like to have such high bitdepth after grading? Debayered and WB-burned-in footage have "other" (values behind its) 12bit than 12bit RAW. If you like to keep all RAW information for you NLE, you should use DNG. But then you'll need a good RAW processing engine. And ProRes is also YUV.

@reddeercity: thanks for showing such projects, this is always very interesting to see, what (and how) other guys do. With CUDA the main problem is: I have no hardware to run such code. :( With OpenCL we would have a little chance, but what we found until now (e.g. bilinear demosaic) needed longer for copying buffers between RAM and GPU than MLVApp processes the entire picture. So it seems just to be better to have the entire pipeline on GPU - but this would be a 100% new version of our app then.
Very interesting was, that they got the ffmpeg libs used from their app. We tried that when we started with ffmpeg - without success. That's why we have this pipe solution now, which is indeed not very nice on Windows (cmd window).
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: [email protected] on February 23, 2020, 10:40:51 AM
Yeah thanks guys - so for a 12 bit approach (using Vegas) I'll go with PNG (or TIFF) exported out from MLVApp (accepting the larger file sizes) --- OR --- I'll go 10bit uncompressed out from MLV, then go with Sony 10bit YUV. It performs very well as an intermediate. -Just did a 25 generation A/B *comparative test* with Sony YUV across 25 forced recompressions - it looks fine - I'm happy ....
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 23, 2020, 06:21:06 PM
(https://i.postimg.cc/VkdHM5tK/Eyes.png) (https://i.postimg.cc/cJt2q64v/Canon-EOS-5-D-Mark-II.png) (https://i.postimg.cc/sDfLjTgd/Canon-EOS-5-D-Mark-III.png) (https://i.postimg.cc/YqXshQv4/Nikon-D810.png) (https://i.postimg.cc/D06YQX5M/Sony-A7.png)

Plotted using Adobe matrices and spectral measurements from AMPAS https://acescentral.com/t/results-from-an-idt-evaluation/2229

The white dots are srgb/rec709 primaries
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: escho on February 23, 2020, 09:10:43 PM
I have some CR2 files from my EOS600D and wanted to convert these files into one MLV-file. That worked fine, but the orientation changes. That means: Source CR2s are recorded upright, but the resulting MLV has landscape-format. I cannot find an option in mlvapp to keep the orientation.

The same happens, if convert the CR2s directly with raw2dng. The resulting MLV is turned 90°.

Any ideas, what Iḿ doing wrong?

(mlvapp sourcecode downloaded and dcompiled just 2 hours ago)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 23, 2020, 09:22:41 PM
@escho: 90° rotation is not possible (yet).

@Ilia: looks like I should keep my 5D2 :)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 23, 2020, 10:21:18 PM
Raw files are not rotated, it's all metadata, and MLV does not have rotation metadata. So I would need to add rotation to raw2mlv. Might do it, have been making LibMLV progress a little bit.

@masc Yeahh! 5D2 looks best. I'm starting to think there may be some truth to 'Canon colours' :) (I have no real experience with Nikon/sony though)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: escho on February 23, 2020, 11:12:32 PM
@ilia:
Yes, just had a short look into the exif-data and the source files.  It's not possible atm. Thankyou for the hint with the exifs.

My workaround:
Import and transcode the CR2s into mlvapp, as they are, than exporting the MLV to (for example) mp4. The resulting mp4 goes another time through ffmpeg for changing the orientation of the video:

ffmpeg -i input.mp4 -c copy -metadata:s:v:0 rotate=90 Verpuppung.mp4

The result can be seen here in my starmaps-site:
https://sternenkarten.com/2020/02/23/verpuppung/
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 24, 2020, 11:47:48 AM
@ilia3101

Thanks for sharing that info. Very interesting. Has anyone tried loading the 5D .ctl files (acting as IDTs) from the linked post into Resolve?

I am putting them into the LUT folder as described here http://colorizer.net/index.php?op=aces but Resolve isn't 'seeing' them at all.

PS This is the dropbox link that has all the sensor data files in: https://www.dropbox.com/sh/xepdrlu8qtubhhl/AADR_QuBf5Sn2WO7lp5MDNGOa?dl=0
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 24, 2020, 03:20:19 PM
**Update**

As I understand it, the .CTL data needs to be converted to .DCTL for Davinci Resolve to recognise it and treat it as an ACES IDT function.

Can anyone assist with translating the language of the .CTL file from the ACES links here:


// Canon_5D_Mk_III - 3200K
// Generated on August 05,2019 10:40:40 AM

import "utilities";

const float B[][] = { {0.883020, -0.083165, 0.200145},
  {-0.008164, 1.114861, -0.106697},
  {0.048320, -0.441363, 1.393044} };

const float b[] = {1.589617, 1.000000, 2.151074};
const float min_b = min(b[0], min(b[1], b[2]));
const float e_max = 1.000000;
const float k = 1.000000;

void main (
input varying float rIn,
input varying float gIn,
input varying float bIn,
input varying float aIn,
output varying float rOut,
output varying float gOut,
output varying float bOut,
output varying float aOut )
{
float Rraw = clip((b[0] * rIn) / (min_b * e_max));
float Graw = clip((b[1] * gIn) / (min_b * e_max));
float Braw = clip((b[2] * bIn) / (min_b * e_max));

rOut = k * (B[0][0] * Rraw + B[0][1] * Graw + B[0][2] * Braw);
gOut = k * (B[1][0] * Rraw + B[1][1] * Graw + B[1][2] * Braw);
bOut = k * (B[2][0] * Rraw + B[2][1] * Graw + B[2][2] * Braw);
aOut = 1.0;

}



to .DCTL as described in this guide: https://drive.google.com/open?id=15AB3eZ9m78pT03nJNY8SO3t1IqnF23lt

It's waaaaay over my head!  :o

PS This may be off-topic – or not, as it might be useful in MLVApp also?

Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 24, 2020, 06:49:22 PM
It is multiplying the raw channels by some gains (the array called b), clipping them (seems like this could clip reconstructed highlights if resolve does that???), then multiplies by their own matrix (called B). I don't see why they had to make it two steps, gains + matrix, could be one. I also don't understand why they clip the channels.

Just a really complicated way of applying a matrix. I can't imagine their matrix is 1000x better than Adobe's that will be in your DNGs anyway.

It's not too off topic. It's all relevant imo.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 24, 2020, 06:59:02 PM
I believe this CTL data is based on the spectral sensitivity analysis of the cameras (5D2 and 3) carried out in testing.

I thought it would be great to see how it performs in Resolve, but it needs to be in DCTL form, so it needs translating from CTL.

Apparently this is a straightforward job! Just not for me! ;)

Anyone fancy a go?

Maybe MLVApp can use these transforms also?

Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 24, 2020, 09:24:01 PM
We could try their matrices in MLV App.. pretty easy, anyone could put it in the code and compile it.

Took this https://github.com/baldavenger/DCTLs/blob/master/Technical%20Transforms/AWG_to_Rec709.dctl and put in the matrix from the CTL you showed...

see if it works:

__DEVICE__ float3 transform(int p_Width, int p_Height, int p_X, int p_Y, float p_R, float p_G, float p_B)
{
const float r = (p_R*1.589617f * 0.883020f) + (p_G * -0.083165f) + (p_B*2.151074f * 0.200145f);
const float g = (p_R*1.589617f * -0.008164f) + (p_G * 1.114861f) + (p_B*2.151074f * -0.106697f);
const float b = (p_R*1.589617f * 0.048320f) + (p_G *-0.441363f) + (p_B*2.151074f * 1.393044f);

return make_float3(r, g, b);
}
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 24, 2020, 10:23:15 PM
Isn´t dctl lut transforms in resolve?(since you´re linking to baldavenger stuff)
https://www.magiclantern.fm/forum/index.php?topic=15801.msg169036#msg169036
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 25, 2020, 09:10:08 AM
didn't even realise it was baldavenger, I just googled "davinci dctl example" or something

and no this isnt a lut (sorry if i misunderstood what youre saying)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 25, 2020, 10:24:31 AM
@ilia3101

Thanks! I don't know how to add that matrix to MLVApp, but I've made a .DCTL from it which Resolve now recognises. But the transform is not correct yet:

(https://i.ibb.co/VH5GQRs/grab.jpg) (https://ibb.co/jVsYWmS)

Does it maybe require some extra code from the CTL, like:

void main (
input varying float rIn,
input varying float gIn,
input varying float bIn,
        etc...


?


Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 25, 2020, 11:19:13 AM
The code structure seems different, so no we don't need to add that. But I am not sure why the colours are so wrong. The input to that IDT needs to be in camera raw space.

maybe davinci does channel gains already, so try this:

__DEVICE__ float3 transform(int p_Width, int p_Height, int p_X, int p_Y, float p_R, float p_G, float p_B)
{
const float r = (p_R * 0.883020f) + (p_G * -0.083165f) + (p_B * 0.200145f);
const float g = (p_R * -0.008164f) + (p_G * 1.114861f) + (p_B * -0.106697f);
const float b = (p_R * 0.048320f) + (p_G *-0.441363f) + (p_B * 1.393044f);

return make_float3(r, g, b);
}
[/s]


Ok how about this: https://acescentral.com/t/aces-idt-dctl-generator/2566
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 25, 2020, 12:02:12 PM
@ ilia3101 Yay! It works. Awesome work. Thank you! :)

(https://i.ibb.co/2yFZjdb/grab2.jpg) (https://ibb.co/0cnsfrw)

That was a 3200K CTL

There's also a 5500K one:


// Canon_5D_Mk_III - 5500K
// Generated on July 15,2019  9:55:47 AM

import "utilities";

const float B[][] = { {0.852627, -0.013844, 0.161217},
  {0.028905, 1.168449, -0.197354},
  {0.057001, -0.365605, 1.308605} };

const float b[] = {2.293205, 1.000000, 1.453861};
const float min_b = min(b[0], min(b[1], b[2]));
const float e_max = 1.000000;
const float k = 1.000000;

void main (
input varying float rIn,
input varying float gIn,
input varying float bIn,
input varying float aIn,
output varying float rOut,
output varying float gOut,
output varying float bOut,
output varying float aOut )
{
float Rraw = clip((b[0] * rIn) / (min_b * e_max));
float Graw = clip((b[1] * gIn) / (min_b * e_max));
float Braw = clip((b[2] * bIn) / (min_b * e_max));

rOut = k * (B[0][0] * Rraw + B[0][1] * Graw + B[0][2] * Braw);
gOut = k * (B[1][0] * Rraw + B[1][1] * Graw + B[1][2] * Braw);
bOut = k * (B[2][0] * Rraw + B[2][1] * Graw + B[2][2] * Braw);
aOut = 1.0;

}



Which I translate as this in DCTL language (Is this correct @ilia3101 ?) It certainly looks correct in Davinci... :P



__DEVICE__ float3 transform(int p_Width, int p_Height, int p_X, int p_Y, float p_R, float p_G, float p_B)
{
const float r = (p_R * 0.852627f) + (p_G * -0.013844f) + (p_B * 0.161217f);
const float g = (p_R * 0.028905f) + (p_G * 1.168449f) + (p_B * -0.197354f);
const float b = (p_R * 0.057001f) + (p_G * -0.365605f) + (p_B * 1.308605f);

return make_float3(r, g, b);
}



Here are the resulting DCTL/IDT files if anyone wants to test: https://bitbucket.org/rivertim/magic-lantern-danneclone/downloads/
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 25, 2020, 12:11:48 PM
Quote
Ok how about this: https://acescentral.com/t/aces-idt-dctl-generator/2566

Oh My God! That looks ****in awesome! Thanks for the great find @ilia3101 And it's only 4hours old. Syncronicity at work. :)

Playtime. :)

PS Hope all this will work with MLVApp also! :P
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 25, 2020, 01:49:25 PM
your translation looks about right (given that mine was right :D)

I really don't know anything about davinci resolve ctl so I can't promise anything. Maybe compare it to aces conversion without it.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on February 25, 2020, 02:22:22 PM
Closer examination show a bias towards purple with these DCTLs. Continuing this discussion on the DaVinci Resolve and ML Raw thread here: https://www.magiclantern.fm/forum/index.php?topic=15801.msg225208#msg225208
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on February 25, 2020, 03:51:25 PM
Quote from: ilia3101 on February 23, 2020, 06:21:06 PM
(https://i.postimg.cc/VkdHM5tK/Eyes.png) (https://i.postimg.cc/cJt2q64v/Canon-EOS-5-D-Mark-II.png) (https://i.postimg.cc/sDfLjTgd/Canon-EOS-5-D-Mark-III.png) (https://i.postimg.cc/YqXshQv4/Nikon-D810.png) (https://i.postimg.cc/D06YQX5M/Sony-A7.png)

Very nice. On closer evaluation, I think MKIII has better approximation instead of MKII. The most essential tone (R9 - Red (https://en.wikipedia.org/wiki/Color_rendering_index#Special_value:_R9)) is out of gamut in MKII, and this tone is crucial for skin tones.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 26, 2020, 08:22:32 PM
I don't think thats the correct way to look at those pictures. Nothing is out of gamut, the gamut is just reproduced wrongly, especially at the edges (as the pictures show very well). The R9 colour (whatever that is), may by itself be wrong, but skin colour is probably about right on all of these cameras.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on February 26, 2020, 08:36:18 PM
Quote from: ilia3101 on February 26, 2020, 08:22:32 PM
the gamut is just reproduced wrongly
Well, can't that be considered "out of gamut"?
Quotebut skin colour is probably about right on all of these cameras.
Well, these informations have been interpolated for each pixel (mean value between RGGB)? Because the value for Red sensitivity is what actually matter for skin tones, and using the graph above it seems that MKII falls out of the ideal...
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 26, 2020, 09:05:07 PM
Quote from: Luther on February 26, 2020, 08:36:18 PM
Well, can't that be considered "out of gamut"?

I don't know. It will still see the colour, but will reproduce it far too desaturated (wrong).

Is it out of gamut if it is reproduced oversaturated? Like green is on the sony A7?

I once read somewhere that input devices like a camera don't have a gamut, and I still like to think that way.

Quote from: Luther on February 26, 2020, 08:36:18 PM
Well, these informations have been interpolated for each pixel (mean value between RGGB)? Because the value for Red sensitivity is what actually matter for skin tones, and using the graph above it seems that MKII falls out of the ideal...

If you find me some spectral data for reflectance of skin I can calculate how it will look on all of these cameras ;)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on February 26, 2020, 09:53:19 PM
Quote from: ilia3101 on February 26, 2020, 09:05:07 PM
Is it out of gamut if it is reproduced oversaturated?
My undestanding is that "out of gamut" is when a device can't reproduce/capture a particular range of tones (wavelenghts). From the plot above, the reference point for Red would mean the 'ideal' amount of tones... so MKII falls behind it.
I'm not really a color specialist though, so everything I say about this topic is probably innacurate in some way or another.
Quote
I once read somewhere that input devices like a camera don't have a gamut, and I still like to think that way.
It's just a bunch of photodiodes, but when you try to classify that signal inside a gamut for real world usage, this is when things get complicated. This is also why (IIRC) some color spaces have "imaginary colors (https://en.wikipedia.org/wiki/Imaginary_colors#Imaginary_colors)".
Quote
If you find me some spectral data for reflectance of skin I can calculate how it will look on all of these cameras ;)
Good point. But the low Red sensitivity will affect these tones on MKII. I'm not sure if non-saturated reds would have a big difference, though.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 26, 2020, 10:45:41 PM
Quote from: Luther on February 26, 2020, 09:53:19 PM
My undestanding is that "out of gamut" is when a device can't reproduce/capture a particular range of tones (wavelenghts). From the plot above, the reference point for Red would mean the 'ideal' amount of tones... so MKII falls behind it.

I don't know. I am not making conclusions from these diagrams because I don't know what to conclude.

Quote from: Luther on February 26, 2020, 09:53:19 PM
I'm not really a color specialist though, so everything I say about this topic is probably innacurate in some way or another.

Same

Quote from: Luther on February 26, 2020, 09:53:19 PM
But the low Red sensitivity will affect these tones on MKII. I'm not sure if non-saturated reds would have a big difference, though.

Non-saturated reds will probably look similar to normal. Cameras seem to reproduce less saturated colours decently, but not saturated ones with spiky spectrums.


Also I used the Adobe daylight matrices, I will see how different these gamuts look with the matrices included in the aces dropbox.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 27, 2020, 12:23:50 AM



Eyes5D Mark II5D Mark IIISony A7Nikon D810
(https://i.postimg.cc/sDPhY05g/Eyes.png)(https://i.postimg.cc/nLWjV8f0/5D2.png)(https://i.postimg.cc/HLn8CYRr/5D3.png)(https://i.postimg.cc/Dw2bBdcd/A7.png)(https://i.postimg.cc/RZXJ86sr/D810.png)

The Canons here have more accurate green colours.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 03, 2020, 09:52:50 AM
MLV App does not recognize *.raw files from 5D3 recorded several years ago. Is it possible to convert *.raw to *.mlv?
Thanks in advance.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 03, 2020, 10:58:49 AM
Quote from: vstrglv on March 03, 2020, 09:52:50 AM
MLV App does not recognize *.raw files from 5D3 recorded several years ago. Is it possible to convert *.raw to *.mlv?
Thanks in advance.
I just know about this workaround: Convert using an old tool RAW to DNG. Then use Ilia's tool RAW2MLV and convert the DNGs to a single MLV file.

Maybe Switch has also an option for such a conversion.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 03, 2020, 11:05:28 AM
Thanks. It's rather complicated. But may be I'll try.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on March 03, 2020, 11:48:52 AM
Open up your raw files with Switch. It will ask if you want to convert to mLV file. Thanks to bouncyball for his conversion tool.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 03, 2020, 12:55:22 PM
I am on Windows...
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on March 03, 2020, 05:44:53 PM
Doesn't mlv dump do it?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on March 03, 2020, 08:38:13 PM
Bouncyball version of raw2dng only.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on March 04, 2020, 04:24:17 PM
Yeah.... good old times ;)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on March 04, 2020, 04:28:34 PM
Quote from: bouncyball on March 04, 2020, 04:24:17 PM
Yeah.... good old times ;)
hehe, totally. Maybe could be integrated into Ilia3101 raw2mlv tool...
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 05, 2020, 11:27:30 AM
Quote from: Danne on March 03, 2020, 11:48:52 AM
Open up your raw files with Switch. It will ask if you want to convert to mLV file. Thanks to bouncyball for his conversion tool.
I am on WIN10.  SWITCH_LINUX has been installed on Ubuntu-18.04.4 on VirtualBox-6.1.4-136177-Win. If I drop *.raw file on SWITCH, there is a message "Select your input folder". After selection there are several options, but there is no "you want to convert to mLV file".
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on March 05, 2020, 12:42:49 PM
Strange. What does it say? Print screens? You can post additional info in the Switch thread.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 05, 2020, 01:07:39 PM
(https://live.staticflickr.com/65535/49621843281_ded4cf3df8_m.jpg) after selected input folder with *.raw files
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on March 05, 2020, 01:50:35 PM
@Danne

I think it is better to do it using new libmlv from Ilia. I guess raw2mlv uses it anyway.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on March 05, 2020, 03:44:37 PM
Quote from: vstrglv on March 05, 2020, 01:07:39 PM
(https://live.staticflickr.com/65535/49621843281_ded4cf3df8_m.jpg) after selected input folder with *.raw files
Switch thread please.
I can´t recall if raw2dng version from bouncyball was fully implemented in linux version. If not I suggest you just find raw2dng and convert files with it. Good luck.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on March 05, 2020, 09:46:43 PM
I'd love to have a tool for converting .RAW to MLV based on LibMLV. How is the .RAW format structured?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on March 05, 2020, 10:05:31 PM
Should be a lot like mlv_lite:
https://bitbucket.org/Dannephoto/magic-lantern_jip-hop/src/unified/modules/lv_rec/raw2dng.c
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 06, 2020, 12:08:19 PM
Link https://github.com/cmhamiche/mlvapp_win/raw/master/MLVApp.v1.9_static_Win64_raw2mlv.zip is dead. Please reload.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 06, 2020, 12:12:05 PM
Find official versions at mlv.app !
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 06, 2020, 01:01:15 PM
Official versions do not work with *.dng files.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on March 06, 2020, 07:06:11 PM
Quote from: vstrglv on March 06, 2020, 01:01:15 PM
Official versions do not work with *.dng files.
What do you mean?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on March 06, 2020, 08:07:25 PM
thres no transcode dng to mlv in them
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on March 07, 2020, 09:50:40 AM
Here's a version dating from last november
https://github.com/ilia3101/LibMLV/releases/tag/raw2mlv-0.1
Put the content of the zip in your MLVApp folder.

If you need a recent version you'll have to compile it from this source:
https://github.com/ilia3101/LibMLV

raw2mlv topic:
https://www.magiclantern.fm/forum/index.php?topic=24631.100
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 07, 2020, 12:11:27 PM
Quote from: cmh on March 07, 2020, 09:50:40 AM
Here's a version dating from last november
https://github.com/ilia3101/LibMLV/releases/tag/raw2mlv-0.1
Put the content of the zip in your MLVApp folder.
I put content (raw2mlv.exe+libraw.dll) +vcruntime140_1.dll to MLVApp folder v.1.10. If i drop *.dng file to MLVApp.exe, MLVApp opens, but there is no *.dng file in it.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 07, 2020, 12:13:51 PM
Quote from: cmh on March 07, 2020, 09:50:40 AM
Here's a version dating from last november
https://github.com/ilia3101/LibMLV/releases/tag/raw2mlv-0.1
Put the content of the zip in your MLVApp folder.
I put content (raw2mlv.exe+libraw.dll) +vcruntime140_1.dll to MLVApp folder v.1.10. If i drop *.dng file to MLVApp.exe, MLVApp opens, but there is no *.dng file in it.
Sorry, do not know how to delete message.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 07, 2020, 12:44:35 PM
Quote from: vstrglv on March 07, 2020, 12:13:51 PM
I put content (raw2mlv.exe+libraw.dll) +vcruntime140_1.dll to MLVApp folder v.1.10. If i drop *.dng file to MLVApp.exe, MLVApp opens, but there is no *.dng file in it.
Maybe MLVApp opens if you told Windows to do so. There is no file association between MLVApp and DNG (and probably will never be). raw2mlv is used as a plugin. So you must use the corresponding dialog in MLVApp to open your DNG.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: [email protected] on March 07, 2020, 03:45:08 PM
Hi Guys ... I'm seeking advice please - (from MLV App experts who've piped DNGs into DaVinci). Here's my procedure:
● I'm shooting 12bit lossless RAW on the Canon 70D with the 'CineStyle' profile for flat image
● The RAW files are imported into 'MLV App' then the export 'Codec' set to 'CinemaDNG Lossless' for outputting the DNGs
● The DNGs are then imported into DaVinci Resolve where I'm trying to do a LOG grade before outputting as Rec 709 (all new to me)

Given that the *Camera/CineStyle/MLVApp* combination is presumedly outputting a LOG image?, can anyone advise on the correct INPUT settings. ie: do I set Resolve's:
▪Color Space▪ to 'Rec.709'  or  'P3 D60'  or  'Blackmagic Design'   (the only 3 options)
▪Gamma▪ to 'Rec 709'  or  'sRGB'  (2 of the 'main' options)
Using a 'Color Checker' to balance shots also requires 'Source Gamma', 'Target Gamma' & 'Target Color Space' to be chosen, each with multiple options. MLV App's multiple settings of 'Tonemapping' and 'Processing Gamut', don't (I assume), come into the mix when exporting DNGs.

In any case, there's still many 'combinations of settings' overall and I've been chasing my tail for days researching and trying get the scenes to look right. I'm sure I'm missing the obvious - what is the receiving software *expecting* from MLV App's output? - And if anyone's sucessfully graded scenes in LOG using MLVapp > DR?, could you advise on settings? Thanking you.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on March 07, 2020, 06:07:10 PM
Quote from: [email protected] on March 07, 2020, 03:45:08 PM
● I'm shooting 12bit lossless RAW on the Canon 70D with the 'CineStyle' profile for flat image

If you shoot RAW - camera profiles doesn't affect the footage.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 07, 2020, 08:33:58 PM
Quote from: masc on March 07, 2020, 12:44:35 PM
Maybe MLVApp opens if you told Windows to do so. There is no file association between MLVApp and DNG (and probably will never be). raw2mlv is used as a plugin. So you must use the corresponding dialog in MLVApp to open your DNG.
No way. It is possible to convert only separate *.dng file to separate *.mlv file (File\Transcode and Import)
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 07, 2020, 09:32:07 PM
Quote from: vstrglv on March 07, 2020, 08:33:58 PM
No way. It is possible to convert only separate *.dng file to separate *.mlv file (File\Transcode and Import)
Correct. But not by doubleclicking a DNG, or dropping it onto the app.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: [email protected] on March 08, 2020, 02:58:34 AM
@ Dmytro_ua  "If you shoot RAW - camera profiles doesn't affect the footage".
Thanks - I followed up after your comment, finding that *any and all* changes to camera profiles alters only camera 'display' and sensor recorded data is unaffected (so only 'ISO' alters RAW recordings). So that means the 70D is outputting Rec709 in the *default* sRGB color space. ● No it isn't - my bad - see explanation by 'masc' below●. With *MLV App* making NO changes whatsoever (other than conversion to DNG), then DaVinci Resolve must be receiving Rec 709 sRGB. Is my logic correct?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 08, 2020, 10:03:29 AM
DNG/MLV is RAW. RAW is a set (width*height) of sensor A/D values. It is your task to process it into your wanted/needed color space. When exporting any other format you get the color space you setup.
As long you record RAW, your camera outputs A/D values (which have to be processed into a color space).
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: [email protected] on March 08, 2020, 12:52:18 PM
Ahh - of course. So MLVApp spits out the DNG's (* RAW* digital values), and I instruct Resolve to process those values into my chosen color space like 'Rec709' or 'Blackmagic Design'. I see, yes I was incorrectly thinking I needed to *match* (in Resolve) mlvapp's 'output files', but I see now, they don't possess 'color space' at that stage. Thanks masc for the clarification. :)

PS: - Just found an article entitled "Good project settings for Resolve" here: https://www.magiclantern.fm/forum/index.php?topic=17324.0 which goes into 'Color Space', - of particular interest is Post #7 by Andy600
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 11, 2020, 08:20:35 PM
Please explain an issue.
I have tried 4 different coders in MLVApp v.1.10:
1. ProRes 4444
2.ProRes 422HQ
3.DNxHD 10bit
4.H-264
Profile Preset - Rec.709
Exposure - 1.4
Temperature -4800
Tint -30
All another settings - default.
When these files are played in MPV all look very similar. Screen shorts look very similar in Adobe PS too.
Imported to Adobe Premiere Pro v.14.02 DNxHD 10bit and H-264 look very similar on timeline and very similar to MPV window, but ProRes 4444 and ProRes 422HQ are a little lighter in green channel. After exporting frames from APP to PS I can not see any difference between all 4 screen shorts from MPV and DNxHD 10bit and H-264 frames from APP. But ProRes 4444 and ProRes 422HQ frame shorts from APP are a little lighter in green channel too, like in APP timeline.
What's the matter?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on March 11, 2020, 08:25:31 PM
What you see is one thing. When you start to grade exports you should notice info missing in weaker codecs.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 12, 2020, 06:56:46 AM
The main issue for me is the difference of two screen images:
in  MLVApp and in MLVApp>Prores>APP.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on March 12, 2020, 07:34:36 AM
MLVApp>Prores>APP?

Could you upload comparison images and ways to reproduce the uploaded example?
Prores export has its own complex output syntax in mlv app so maybe test different ffmpeg configurations to see if one could match even better if that is the case.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 12, 2020, 08:50:57 AM
1.(https://live.staticflickr.com/65535/49651132927_d00b636f83_m.jpg)
https://live.staticflickr.com/65535/49651132927_d00b636f83_b.jpg
ProRes4444,_screenshort from mpv player
2.(https://live.staticflickr.com/65535/49650320083_b7fcb615b2_m.jpg)
https://live.staticflickr.com/65535/49650320083_b7fcb615b2_b.jpg
DNxHD_10bit, screenshort from mpv player
3.(https://live.staticflickr.com/65535/49650318658_8672de8baa_m.jpg)
https://live.staticflickr.com/65535/49650318658_8672de8baa_b.jpg
ProRes4444,_screenshort from APP timeline
4.(https://live.staticflickr.com/65535/49651131647_1e0f4ff712_m.jpg)
https://live.staticflickr.com/65535/49651131647_1e0f4ff712_b.jpg
DNxHD_10bit, screenshort from APP timeline
ProRes4444 and DNxHD_10bit converted in MLVApp 1.10 from the same mlv file.
1,2,4 look very similar to MLVApp window, but 3 looks a little lighter in green.
I am on Windows 10.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 12, 2020, 09:03:19 AM
Quote from: vstrglv on March 12, 2020, 06:56:46 AM
The main issue for me is the difference of two screen images:
in  MLVApp and in MLVApp>Prores>APP.
MLVApp uses the identical encoder program (ffmpeg), picture data and color matrix settings for all these codecs. So if there is a difference, I would search the issue inside ffmpeg or your "APP".
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 12, 2020, 09:08:31 AM
The same issue in Adobe After Effect.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 12, 2020, 10:49:35 AM
Quote from: vstrglv on March 12, 2020, 09:08:31 AM
The same issue in Adobe After Effect.
->
Quote from: masc on March 12, 2020, 09:03:19 AM
So if there is a difference, I would search the issue inside ffmpeg or your "APP".
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 12, 2020, 11:37:13 AM
It is an issue of APP 2020. I have tested it on APP 2019 - no issue.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on March 12, 2020, 09:45:43 PM
There's no difference in green channel. The image has overall less contrast in your ProRes example, hence why it looks less saturated. Did you check your gamma settings? Make sure they are the same...
Btw, what is "APP"?
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on March 12, 2020, 11:26:22 PM
Adobe Premiere Pro v.14.02 (2020). Gamma settings are the same in MLVApp. I tried gamma 1.0 and gamma 0.85
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Kharak on March 13, 2020, 11:41:51 AM
APP haha that's a new one.
Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 01, 2020, 09:41:56 PM
April 1st is not over yet... at least here in Europe. So here comes some new ML stuff: MLVApp v1.11:

- Better processing for highlights (reduced blue / violet clipping)
- Added raw2mlv with user interface
- Added bad pixel fix via pixel map and bad pixel picker
- Changed to floating point RAW black level adjustment
- Added post export script for averaging a clip to a single frame (OSX only)
- Added option for loading clips with a default receipt
- Added current clip indicator in session list
- Added clip marking feature
- Changed copy/paste/import/export receipt behaviour
- Some bug fixes and some minor changes

Minimum OS:
- OSX 10.8.5 Mountain Lion
- Windows 7
- Ubuntu 14.04 LTS

https://mlv.app/

Win64 version will be released a little later...

For one of the new features I recorded a small tutorial: Bad Pixel Maps

https://www.youtube.com/watch?v=Xwd2DFGjMx0
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on April 02, 2020, 12:00:20 AM
Happy April 1st to everyone and please, PLEASE keep your distance and ML is by far the safest community we can all be in without any hesitation.  ;)

Thanks @masc for the much-needed updates especially with the better HL processing and the much-hyped copy/paste/import/export changes.

I will test this one out and report my findings when I can. Again, please disinfect to protect and try not to be too brave against this HOGshit!  :o
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ZEEK on April 02, 2020, 01:50:10 AM
Awesome stuff guys. Glad to see the new update and can't wait to test it out. Thanks for all your work with this awesome app, it's amazing! 8)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on April 02, 2020, 03:27:35 AM
Oh wow 0_0 This update is amazing, so many good things and the map for bad pixels is like a old dream finally streamlinked!! Thanks a lot. So badly needed.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on April 02, 2020, 04:21:41 AM
Hello MLVApp team,

Thank you so much for your remarkable work on MLVApp and these amazing new improvements.  Your continued efforts in making this software better and better are greatly appreciated by the community, so keep up the good work!

RAW2MLV has been doing a great job for me in the 1.10 version and I have always been very satisfied with the results.  Eager to see how it works on this new version, I tested it briefly.  It transcodes and imports the CR2 files just fine but when I start making adjustments on either one of them, after about a minute, I get Runtime error and a very polite message that the program has to terminate now.  I am on Win 10x64 and the CR2 files I tried to process are from the EOS-M.  The error occurs with both -  normal and Dual ISO CR2 files but does not occur when processing normal MLV clips from the same camera.

Could you please take a look and see if you can fix the runtime error?

I also have a question concerning the new "post export script for averaging a clip to a single frame (OSX only)".  How does it work?  If it averages an entire clip to a single frame, can it be used as a dark frame for noise reduction in high ISO clips?  What if there is motion in the clip?  Can this interesting feature be implemented in the Win versions too? 
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 02, 2020, 08:14:53 AM
Quote from: DeafEyeJedi on April 02, 2020, 12:00:20 AM
Thanks @masc for the much-needed updates especially with the better HL processing and the much-hyped copy/paste/import/export changes.
For this build, it again wasn't just me - Ilia, bouncyball, Danne, ... also did a lot for it. So thanks to all of them!

Quote from: IDA_ML on April 02, 2020, 04:21:41 AM
... but when I start making adjustments on either one of them, after about a minute, I get Runtime error and a very polite message that the program has to terminate now.
...
Could you please take a look and see if you can fix the runtime error?
Hm, this information comes a little late. The processing did not change for weeks. On the other side, I don't know what a "Runtime error" is, and such polite messages without information are brought by Microsoft :) . I did not get any crash since a very long time in all of my tests. So the only way to find such errors is to install Qt, open the project, and start it with the debugger, wait for the crash and have a look which line of code will be shown. That would help a lot, if you could try that. I don't see another way to fix such bugs. RAW2MLV is identical to the previous testing version.

Quote from: IDA_ML on April 02, 2020, 04:21:41 AM
I also have a question concerning the new "post export script for averaging a clip to a single frame (OSX only)".  How does it work?  If it averages an entire clip to a single frame, can it be used as a dark frame for noise reduction in high ISO clips?  What if there is motion in the clip?  Can this interesting feature be implemented in the Win versions too? 
All frames will be processed as if you export a movie. But then FFMPEG averages all frames to one single processed averaged frame. I would not use it as dark frame, because it is processed. But you can reduce noise in your photos because of this averaging. If there is motion you get a blurred picture. It is realized with an OSX script. If someone likes, you can also write Windows scripts. But this part is not platform independant.

Title: Re: MLV App 1.10 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yokashin on April 02, 2020, 08:48:11 AM
Quote from: masc on April 01, 2020, 09:41:56 PM
April 1st is not over yet... at least here in Europe. So here comes some new ML stuff: MLVApp v1.11:

Thank you all for the new version of the application.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on April 02, 2020, 12:21:27 PM
Quote from: masc on April 02, 2020, 08:14:53 AM
All frames will be processed as if you export a movie. But then FFMPEG averages all frames to one single processed averaged frame. I would not use it as dark frame, because it is processed. But you can reduce noise in your photos because of this averaging. If there is motion you get a blurred picture. It is realized with an OSX script. If someone likes, you can also write Windows scripts. But this part is not platform independant.

Thanks for this explanation, Masc.  I still do not understand the difference to the already existing TIFF export which gives you the option to create an averaged frame from a maximum of 128 frames.  Danne implemented two very nice presets on the EOS-M that create files appropriate for such type of averaging - ISO averaging and Frame burst:

https://www.magiclantern.fm/forum/index.php?topic=9741.msg222760#msg222760
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 02, 2020, 12:34:29 PM
The script averages the same as ffmpeg into one file only it does so with enfuse/hugin_align_image instead.

It is possible to use ffmpeg to create and use darkframes. Check page 50 here:
http://www.astro-electronic.de/FFmpeg_Book.pdf
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 02, 2020, 01:08:58 PM
For darkframes I would use "Averaged MLV" instead. Because this file can be subtracted before you start to edit.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on April 02, 2020, 02:06:56 PM
Quote from: Danne on April 02, 2020, 12:34:29 PM
The script averages the same as ffmpeg into one file only it does so with enfuse/hugin_align_image instead.

It is possible to use ffmpeg to create and use darkframes. Check page 50 here:
http://www.astro-electronic.de/FFmpeg_Book.pdf

Thanks for this clarification, Danne.  I understand now.  By the way, I love your two averaging presets - perfect for noise reduction in low-light photography.  I am trying to figure out which of all these options provide the best results for such type of photography and are most user friendly too:

1) Dark frame subtraction using an Averaged MLV, as Masc suggests;
2) ISO averaging (requires a tripod);
3) Frame burst (requires a tripod);
4) Silent picture using Dual ISO (typically 100/800 and 200/1600); 
5) Garry's hand held bracketing scrips.
6) Using "magic" ISO numbers to improve dynamic range (ISO research).

All these are remarkable ML options that can all be handled by MLVApp quite nicely.  Personally, I have been using option #4 a lot when traveling since it allows handheld shots with a stabilized lens at shutter speeds down to 1/4 s. with a very low count of misfocused shots. Taking multiple handheld shots with the intervalometer to select the sharpest one further reduces the chance that you end up with a missed shot.   ISO averaging seems a better option, though, since it allows working at closed apertures - better for wide-angle low-light landscape photography.

It would be nice if more of you share your experience on low-light photography using the above options.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Digital Corpus on April 02, 2020, 02:41:51 PM
Just wanted to extend my own thanks to this app. I come from shooting stills but have always been interested in some motion. ML has definitely had my attention since the first April first announcement introducing RAW video. Recently due to some abundance of time, I've been playing with it again and this app in conjunction with RawTherapee have been an interesting journey. Granted I've only used MLV App to export DNG files, but still, thank you for the work on it.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 743v04 on April 08, 2020, 12:19:48 AM
Hello everyone! First off thanks so much everyone involved for making MLV App it has been such a great tool. I have been having some problems with it crashing at 98-99% point of exports when using the AVFoundation ProRes export options though. It seems to only happen when using the 5K 1x3 preset modes for the EOSM, I am using the most recent build released. I've tried all variations of settings in MLV App and it will even crash when no changes are made to the file and it is exported immediately. It seems as though maybe it has something to do with the Transformation being applied? I have the crash message here: https://pastebin.com/PL1PyEcU. This one was taken from a custom built hackintosh however I have a normal 2015 Macbook Pro and this gives the same behavior. If there's any other info I can throw in let me know, thanks!!!

Edit: Uploaded sample MLV: https://we.tl/t-rC7vKZaTbp
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: QuickHitRecord on April 08, 2020, 09:39:45 AM
I haven't been using ML or MLV App lately, but in the wake of our recent quarantine, I decided to try them out once again. MLV App is a wonderful piece of software. I have one question though. When I set the profile preset to "Alexa Log-C" and then export to ProRes for grading later, I get some crazy banding in the resulting clips when a simple Log-C to Rec709 LUT is applied. Here is an example:

(https://i.postimg.cc/Z0yG712g/Working-00-00-48-11-Still001.png) (https://postimg.cc/Z0yG712g)

I seem to remember having problems with this in the past as well. Is there a way to export without this issue? In my case, I am using MLV App v1.11 and applying highlight reconstruction, making color temperature tweaks, and then exporting to 4K ProRes HQ. Then I'm bringing it into Premiere and applying the standard ALEXA_Default_LogC2Rec709 LUT in Lumetri. The camera is a 5D3 with 1.23 and a build from 2017.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 08, 2020, 10:58:14 AM
Quote from: 743v04 on April 08, 2020, 12:19:48 AM
If there's any other info I can throw in let me know, thanks!!!

Edit: Uploaded sample MLV: https://we.tl/t-rC7vKZaTbp
Downloaded and exported with av foundation, no problems.
You should specify your exact export settings. Preferrably upload the exact recipe for others to test.

Edit: tested with my own compiled build. Will test with an official build later.

EDIT: ALl is working with official download as well.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 08, 2020, 06:35:30 PM
Quote from: 743v04 on April 08, 2020, 12:19:48 AM
I have been having some problems with it crashing at 98-99% point of exports when using the AVFoundation ProRes export options though. It seems to only happen when using the 5K 1x3 preset modes for the EOSM, I am using the most recent build released. I've tried all variations of settings in MLV App and it will even crash when no changes are made to the file and it is exported immediately.
Thanks for your message and your report. I had a look to the crash report. It tells the crash happens after the export is ready, while doing the very last step: freeing the memory of the Apple AV Encoder library. So it should not care what clip or setting you export. I don't have a OSX 10.14 here for testing as you have. I just can say in 10.9, 10.11 and 10.13 it does not happen (tested several thousands of times). No idea what should be the problem telling the library freeing its memory which it definitively used. But it is not the freeing process, it is a thread in com.apple.VideoToolbox calling a function named VTPixelTransferSessionTransferImage :( (we don't call it...)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 08, 2020, 06:39:30 PM
Quote from: QuickHitRecord on April 08, 2020, 09:39:45 AM
When I set the profile preset to "Alexa Log-C" and then export to ProRes for grading later, I get some crazy banding in the resulting clips when a simple Log-C to Rec709 LUT is applied.
This is to be expected: Log saves your shadows and highlights at the cost of midtones (which get compressed by the log function). So it is better to grad 100% in MLVApp or 100% in another app. In MLVApp you could also apply .cube LUTs. This should look better and should not bring those artifacts, because processing is 16bit instead of 10bit if you apply it in Premiere on a ProRes file.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 743v04 on April 08, 2020, 07:19:21 PM
Hello Masc and Danne, thank you both for getting back to me so fast, as well as for creating these amazing tools for all of us to use. I just tested this same MLV from my MBP running High Sierra and am getting what seems like a similar crash. Here is the crash report from it: https://pastebin.com/8STnArw5

Edit: Here are screen captures of my export settings that both crash similarly: https://imgur.com/a/HMpVIEH
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 08, 2020, 07:32:54 PM
Quote from: 743v04 on April 08, 2020, 07:19:21 PM
Hello Masc and Danne, thank you both for getting back to me so fast, as well as for creating these amazing tools for all of us to use. I just tested this same MLV from my MBP running High Sierra and am getting what seems like a similar crash. Here is the crash report from it: https://pastebin.com/8STnArw5

Edit: Here are screen captures of my export settings that both crash similarly: https://imgur.com/a/HMpVIEH
The report tells exactly the same.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: QuickHitRecord on April 08, 2020, 09:04:21 PM
QuoteThis is to be expected: Log saves your shadows and highlights at the cost of midtones (which get compressed by the log function). So it is better to grad 100% in MLVApp or 100% in another app. In MLVApp you could also apply .cube LUTs. This should look better and should not bring those artifacts, because processing is 16bit instead of 10bit if you apply it in Premiere on a ProRes file.

Thank you. I am getting much cleaner results applying the LUT in MLV App.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 743v04 on April 08, 2020, 09:16:13 PM
Quote from: masc on April 08, 2020, 07:32:54 PM
The report tells exactly the same.
Yes, I just thought it was worth mentioning since you said there were no issues with 10.13, this MBP is running 10.13.6 that produced the second crash log. As opposed to the original one where it was taken from a 10.14 device. I guess I will try to see if there is any updates available for my 10.13.6 device though and go from there.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 08, 2020, 09:33:30 PM
Can you share your exact export recipe? Or a screen recording of what you are doing in mlv app.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 08, 2020, 09:35:45 PM
Quote from: Danne on April 08, 2020, 09:33:30 PM
Can you share your exact export recipe? Or a screen recording of what you are doing in mlv app.
743v04 wrote it also happens with default receipt. (I hope with MLVApps default receipt and not with a user defined one.)

Quote from: 743v04 on April 08, 2020, 09:16:13 PM
Yes, I just thought it was worth mentioning since you said there were no issues with 10.13, this MBP is running 10.13.6 that produced the second crash log. As opposed to the original one where it was taken from a 10.14 device. I guess I will try to see if there is any updates available for my 10.13.6 device though and go from there.
Hmmm...
(https://i.ibb.co/rkrdbDN/Bildschirmfoto-2020-04-08-um-21-31-11.jpg)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 08, 2020, 09:41:46 PM
Quote from: masc on April 08, 2020, 09:35:45 PM
743v04 wrote it also happens with default receipt.
I trust only screen recordings. But, could be a number of things.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 743v04 on April 08, 2020, 10:40:08 PM
Quote from: Danne on April 08, 2020, 09:41:46 PM
I trust only screen recordings. But, could be a number of things.
I have a screen recording of it, I will upload that in a few hours.

Edit: https://we.tl/t-NOWe73RkyK

https://imgur.com/a/qtVTV7K
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 09, 2020, 08:24:51 PM
I tried again and again and again. I now also tried to choose "Force AMaZE" and tried to "unselect" the clip in the session list before export, exactly as you did. Now I got exactly your crash, maybe one of 10..20 trys. With debugger enabled I had "no luck crashing the app" yet.

Edit: after another 20 times it happend also once with selected and "Receipt configuration" debayer in export settings. But it seems to come each time from Apple ProRes Encoder... whyever.

Edit2: @Ilia: The crash happens when the function freeAVEncoder calls a free (there are just 2). While this is called, the Apple ProRes Encoder seems still to work (I see 2 worker threads from Apple Encoder and one crashed the app). Is there a way to ask the Encoder for beeing ready?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 10, 2020, 01:09:43 AM
It only crashes with force amaze? But on freeAVEncoder call?

They aren't related though??
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 743v04 on April 10, 2020, 07:55:16 AM
No matter which debayer method I use, either with the force options in the export settings or using the receipt configuration, I always get this same crash. If there is a debugging tool that I could run on my end to find anything else out let me know. Thanks for taking the time to look into this.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 10, 2020, 09:02:14 AM
Did you test compiling yourself with mac compiler in first post? Run the OP menu option after dependencies are installed.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on April 10, 2020, 10:32:39 AM
Thank you for the wonderful MLV App!

I run Devuan Linux, and I just installed the the 1.11 appimage!

I also installed the focus pixel maps (fantastic feature!), but the MLV App Wiki is problematic in regards to its instructions on installing the focus pixel maps on a Linux system (https://github.com/ilia3101/MLV-App/wiki#fix-focus-dots).

One issue is that there are two mlvapp binaries in the appimage, but only one of them works (unfortunately, not the one referred to in the "Fix Focus Dots" instructions).  The two binaries are the same size, but I ran a checksum on both binaries, and got different results.

Another complication is that the appimage already includes a version of ffmpeg that works, so there might not be any need to copy the user's version of ffmpeg into the extracted appimage folders, as the wiki instructs.

Also, the focus pixel maps can merely be "copied" to a sub-directory of the extracted appimage.  It would likely be better to instruct Linux users to just copy the files (or at least mention that possibility), rather than only telling Linux users to "install" the focus pixle maps in the nice drag-&-drop manner suggested by the Wiki.  Some Linux users use simple window managers, rather than full-blown desktops, so the simple file manger that they use might not be capable of dragging/dropping files into other apps.

There is probably a way to make these instructions clearer, and I would be happy to contribute in that regard.

While I was exploring the extracted files, I noticed that there is a "plugin" folder.  It would be amazing if a version of the Cinelerra "Blue Banana" plug-in (https://www.youtube.com/watch?v=cNWCYVr2bYQ&t=9m12s) could be imported into MLV App.

One more thing, is there a way to import non-mlv and non-raw files?  I could probably convert a video to cinema DNGs or to jpegs, but it would be incredible if MLV App could manipulate mp4's, Quicktime files, mkv's, etc.  If it could do so, I would use it for everything!

Thanks!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 10, 2020, 07:11:32 PM
Quote from: ilia3101 on April 10, 2020, 01:09:43 AM
It only crashes with force amaze? But on freeAVEncoder call?

They aren't related though??
No, it happens with all debayer algorithms. It just popped up first time for me when I used this option. But it is not related.

Quote from: 743v04 on April 10, 2020, 07:55:16 AM
No matter which debayer method I use, either with the force options in the export settings or using the receipt configuration, I always get this same crash. If there is a debugging tool that I could run on my end to find anything else out let me know. Thanks for taking the time to look into this.
Sounds your computer is ideal for debugging this. If you like install the toolchain, compile the app as debug version and start it with debugger. The debugger tells you the line of code of the crash. This would be intersting. I got no crash at all with debugger...
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 743v04 on April 10, 2020, 07:22:33 PM
Quote from: masc on April 10, 2020, 07:11:32 PM
Sounds your computer is ideal for debugging this. If you like install the toolchain, compile the app as debug version and start it with debugger. The debugger tells you the line of code of the crash. This would be intersting. I got no crash at all with debugger...

I will give that a go over the weekend and report back. I am also trying Danne's recommendation in the meantime.

Edit: Self compiling did fix this for me, not sure if compiling the app as debug version is useful still, if so I'd be happy to do that. Sorry for the hassle and thanks for the help!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 10, 2020, 07:36:17 PM
Quote from: tupp on April 10, 2020, 10:32:39 AM
One issue is that there are two mlvapp binaries in the appimage, but only one of them works (unfortunately, not the one referred to in the "Fix Focus Dots" instructions).  The two binaries are the same size, but I ran a checksum on both binaries, and got different results.
Okaaay. Two binaries? I never tried to unpack the image. I just have compiled it and I was happy when the appimage process ended without error but with an appimage. :)

Quote from: tupp on April 10, 2020, 10:32:39 AM
Another complication is that the appimage already includes a version of ffmpeg that works, so there might not be any need to copy the user's version of ffmpeg into the extracted appimage folders, as the wiki instructs.
The included ffmpeg version should be used always!!! If you use another ffmpeg, nobody knows if it works for all features. It is just important, that ffmpeg is in the same folder as the mlvapp executable. Otherwise it should not work. Same for raw2mlv. It must be located in the same folder!

Quote from: tupp on April 10, 2020, 10:32:39 AM
Also, the focus pixel maps can merely be "copied" to a sub-directory of the extracted appimage.  It would likely be better to instruct Linux users to just copy the files (or at least mention that possibility), rather than only telling Linux users to "install" the focus pixle maps in the nice drag-&-drop manner suggested by the Wiki.  Some Linux users use simple window managers, rather than full-blown desktops, so the simple file manger that they use might not be capable of dragging/dropping files into other apps.
The reason why we write to use the drag and drop feature is, it always works. In the past it felt like 90% of the users failed with manual copy actions. And for some people even the drag and drop is hard to understand. But if copying the files works for, you can always do that!

Quote from: tupp on April 10, 2020, 10:32:39 AM
There is probably a way to make these instructions clearer, and I would be happy to contribute in that regard.
Feel free to contribute! That is very much welcome! Also if you find a way to create the appimage in a better way, you can help if you like. We implemented MLVApp mostly on OSX. On Windows I know how to get it to work. But on Linux I am just happy if it compiles and creates the appimage somehow, and it starts if I doubleclick the image. ;)

Quote from: tupp on April 10, 2020, 10:32:39 AM
While I was exploring the extracted files, I noticed that there is a "plugin" folder.  It would be amazing if a version of the Cinelerra "Blue Banana" plug-in (https://www.youtube.com/watch?v=cNWCYVr2bYQ&t=9m12s) could be imported into MLV App.
No idea what this plugin folder is and what it does. Should be something from the appimage. MLVApp has no plugin feature at the moment.

Quote from: tupp on April 10, 2020, 10:32:39 AM
One more thing, is there a way to import non-mlv and non-raw files?  I could probably convert a video to cinema DNGs or to jpegs, but it would be incredible if MLV App could manipulate mp4's, Quicktime files, mkv's, etc.  If it could do so, I would use it for everything!
There is a way to import non-mlv, yes, but there is no way to import non-raw files. DNG, CR2, ... can be transcoded to MLV via raw2mlv, which is included in the package. Use "Transcode and Import" from the menu. You'll find the menu action only, if raw2mlv is on the right place (same folder as MLVApp executable). MLVApp imports the created MLV when transcoding is ready.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 10, 2020, 07:37:31 PM
Quote from: 743v04 on April 10, 2020, 07:22:33 PM
Self compiling did fix this for me
Really? That is funny... :D Thanks for the feedback!

Quote from: 743v04 on April 10, 2020, 07:22:33 PM
not sure if compiling the app as debug version is useful still, if so I'd be happy to do that.
It would be useful, if you get it crashed with running debugger. This way we could maybe fix the bug. But for this we must have found it. But now you maybe see my problem: without this information I can't really help to find the bug...

Edit: does you version use all cores for the standard receipt? If not, it maybe compiled without openMP feature (this enables multithreading).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 10, 2020, 07:56:53 PM
Quote from: 743v04 on April 10, 2020, 07:22:33 PM
I will give that a go over the weekend and report back. I am also trying Danne's recommendation in the meantime.

Edit: Self compiling did fix this for me, not sure if compiling the app as debug version is useful still, if so I'd be happy to do that. Sorry for the hassle and thanks for the help!
You compiled with OP option? If so openmp is included.

Edit: also retry the official build. Maybe the compiler script iinstalls your faulty dependency.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 743v04 on April 10, 2020, 09:50:12 PM
Quote from: Danne on April 10, 2020, 07:56:53 PM
You compiled with OP option? If so openmp is included.

Edit: also retry the official build. Maybe the compiler script iinstalls your faulty dependency.

Yes I used the OP option and that fixed it. Also replaced it with the official build again and that kept it working too. This is all on my MBP with 10.13.6, haven't tested 10.14 yet but I feel like that device I am on my own with the hardware being used. Thanks again everyone, I will keep this in mind if I run into a similar problem in the future  :D
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on April 11, 2020, 12:44:59 AM
Quote from: masc on April 10, 2020, 07:36:17 PM
Okaaay. Two binaries? I never tried to unpack the image. I just have compiled it and I was happy when the appimage process ended without error but with an appimage. :)
Here is the directory/file tree of the unpacked AppImage:
squashfs-root
├── AppRun -> usr/bin/mlvapp
├── Makefile
├── mlvapp
├── mlvapp.desktop
├── MLVAPP.png
├── raw2mlv
└── usr
    ├── bin
    │   ├── ffmpeg
    │   ├── mlvapp
    │   ├── qt.conf
    │   └── raw2mlv
    ├── lib
    │   ├── libasyncns.so.0
    │   ├── libdbus-1.so.3
    │   ├── libEGL.so.1
    │   ├── libffi.so.6
    │   ├── libFLAC.so.8
    │   ├── libgbm.so.1
    │   ├── libgmodule-2.0.so.0
    │   ├── libgomp.so.1
    │   ├── libgstapp-1.0.so.0
    │   ├── libgstaudio-1.0.so.0
    │   ├── libgstbase-1.0.so.0
    │   ├── libgstpbutils-1.0.so.0
    │   ├── libgstreamer-1.0.so.0
    │   ├── libgsttag-1.0.so.0
    │   ├── libgstvideo-1.0.so.0
    │   ├── libgthread-2.0.so.0
    │   ├── libicudata.so.56
    │   ├── libicui18n.so.56
    │   ├── libicuuc.so.56
    │   ├── libjasper.so.1
    │   ├── libjpeg.so.8
    │   ├── libjson-c.so.2
    │   ├── libogg.so.0
    │   ├── liborc-0.4.so.0
    │   ├── libpcre.so.3
    │   ├── libpng12.so.0
    │   ├── libpulsecommon-4.0.so
    │   ├── libpulse-mainloop-glib.so.0
    │   ├── libpulse.so.0
    │   ├── libqgsttools_p.so.1
    │   ├── libQt5Core.so.5
    │   ├── libQt5DBus.so.5
    │   ├── libQt5Gui.so.5
    │   ├── libQt5Multimedia.so.5
    │   ├── libQt5MultimediaWidgets.so.5
    │   ├── libQt5Network.so.5
    │   ├── libQt5OpenGL.so.5
    │   ├── libQt5Widgets.so.5
    │   ├── libQt5XcbQpa.so.5
    │   ├── libsndfile.so.1
    │   ├── libvorbisenc.so.2
    │   ├── libvorbis.so.0
    │   ├── libwayland-client.so.0
    │   ├── libwayland-server.so.0
    │   ├── libwrap.so.0
    │   ├── libX11-xcb.so.1
    │   ├── libXau.so.6
    │   ├── libxcb-dri2.so.0
    │   ├── libxcb-dri3.so.0
    │   ├── libxcb-glx.so.0
    │   ├── libxcb-present.so.0
    │   ├── libxcb-sync.so.1
    │   ├── libxcb-xfixes.so.0
    │   ├── libXdamage.so.1
    │   ├── libXdmcp.so.6
    │   ├── libXext.so.6
    │   ├── libXfixes.so.3
    │   ├── libXi.so.6
    │   ├── libxshmfence.so.1
    │   └── libXxf86vm.so.1
    ├── plugins
    │   ├── audio
    │   │   ├── libqtaudio_alsa.so
    │   │   └── libqtmedia_pulse.so
    │   ├── bearer
    │   │   ├── libqconnmanbearer.so
    │   │   ├── libqgenericbearer.so
    │   │   └── libqnmbearer.so
    │   ├── imageformats
    │   │   ├── libqgif.so
    │   │   ├── libqicns.so
    │   │   ├── libqico.so
    │   │   ├── libqjp2.so
    │   │   ├── libqjpeg.so
    │   │   ├── libqtga.so
    │   │   ├── libqtiff.so
    │   │   ├── libqwbmp.so
    │   │   └── libqwebp.so
    │   ├── mediaservice
    │   │   ├── libgstaudiodecoder.so
    │   │   ├── libgstcamerabin.so
    │   │   ├── libgstmediacapture.so
    │   │   └── libgstmediaplayer.so
    │   ├── platforminputcontexts
    │   │   ├── libcomposeplatforminputcontextplugin.so
    │   │   └── libibusplatforminputcontextplugin.so
    │   ├── platforms
    │   │   └── libqxcb.so
    │   └── xcbglintegrations
    │       ├── libqxcb-egl-integration.so
    │       └── libqxcb-glx-integration.so
    ├── share
    │   ├── applications
    │   │   └── mlvapp.desktop
    │   ├── doc
    │   │   ├── libasyncns0
    │   │   │   └── copyright
    │   │   ├── libdbus-1-3
    │   │   │   └── copyright
    │   │   ├── libegl1-mesa-lts-xenial
    │   │   │   └── copyright
    │   │   ├── libffi6
    │   │   │   └── copyright
    │   │   ├── libflac8
    │   │   │   └── copyright
    │   │   ├── libglib2.0-0
    │   │   │   └── copyright
    │   │   ├── libgstreamer1.0-0
    │   │   │   └── copyright
    │   │   ├── libgstreamer-plugins-base1.0-0
    │   │   │   └── copyright
    │   │   ├── libjasper1
    │   │   │   └── copyright
    │   │   ├── libjpeg-turbo8
    │   │   │   └── copyright
    │   │   ├── libjson-c2
    │   │   │   └── copyright
    │   │   ├── libogg0
    │   │   │   └── copyright
    │   │   ├── liborc-0.4-0
    │   │   │   └── copyright
    │   │   ├── libpcre3
    │   │   │   └── copyright
    │   │   ├── libpng12-0
    │   │   │   └── copyright
    │   │   ├── libpulse0
    │   │   │   └── copyright
    │   │   ├── libpulse-mainloop-glib0
    │   │   │   └── copyright
    │   │   ├── libsndfile1
    │   │   │   └── copyright
    │   │   ├── libvorbis0a
    │   │   │   └── copyright
    │   │   ├── libvorbisenc2
    │   │   │   └── copyright
    │   │   ├── libwayland-client0
    │   │   │   └── copyright
    │   │   ├── libwayland-server0
    │   │   │   └── copyright
    │   │   ├── libwrap0
    │   │   │   └── copyright
    │   │   ├── libx11-xcb1
    │   │   │   └── copyright
    │   │   ├── libxau6
    │   │   │   └── copyright
    │   │   ├── libxcb-dri2-0-dev
    │   │   │   └── copyright
    │   │   ├── libxcb-dri3-0
    │   │   │   └── copyright
    │   │   ├── libxcb-glx0-dev
    │   │   │   └── copyright
    │   │   ├── libxcb-present0
    │   │   │   └── copyright
    │   │   ├── libxcb-sync1
    │   │   │   └── copyright
    │   │   ├── libxcb-xfixes0
    │   │   │   └── copyright
    │   │   ├── libxdamage1
    │   │   │   └── copyright
    │   │   ├── libxdmcp6
    │   │   │   └── copyright
    │   │   ├── libxext6
    │   │   │   └── copyright
    │   │   ├── libxfixes3
    │   │   │   └── copyright
    │   │   ├── libxi6
    │   │   │   └── copyright
    │   │   ├── libxshmfence1
    │   │   │   └── copyright
    │   │   └── libxxf86vm1
    │   │       └── copyright
    │   └── icons
    │       └── hicolor
    │           └── 512x512
    │               └── apps
    │                   └── MLVAPP.png
    └── translations
        ├── qt_bg.qm
        ├── qt_ca.qm
        ├── qt_cs.qm
        ├── qt_da.qm
        ├── qt_de.qm
        ├── qt_en.qm
        ├── qt_es.qm
        ├── qt_fi.qm
        ├── qt_fr.qm
        ├── qt_gd.qm
        ├── qt_he.qm
        ├── qt_hu.qm
        ├── qt_it.qm
        ├── qt_ja.qm
        ├── qt_ko.qm
        ├── qt_lv.qm
        ├── qt_pl.qm
        ├── qt_ru.qm
        ├── qt_sk.qm
        └── qt_uk.qm

57 directories, 153 files


As you can see, there are two "mlvapp" binaries, along with the "AppRun" link to the working mlvapp binary).

Also note the two "raw2mlv" binaries plus the single instance of "ffmpeg."

In addition, there are two "MLVAPP.png" images.


Quote from: masc on April 10, 2020, 07:36:17 PM
The included ffmpeg version should be used always!!! If you use another ffmpeg, nobody knows if it works for all features. It is just important, that ffmpeg is in the same folder as the mlvapp executable. Otherwise it should not work. Same for raw2mlv. It must be located in the same folder!
The MLV-App Wiki instructs Linux users to copy their system's version of ffmpeg into MLV-Apps extracted root directory.  This action is sort of futile, as the mlvapp binary in that root directory fails while seeking dependencies on the user's system (specifically, in "/usr/lib/").

However, if one runs the mlvapp binary found in the extracted "/squashfs-root/usr/bin/" directory, MLV-App and the included ffmpeg binary works.  By the way, I tried replacing that included version of ffmpeg with the one on my system and I didn't have any trouble exporting an MP4 file from MLV-App.


Quote from: masc on April 10, 2020, 07:36:17 PM
The reason why we write to use the drag and drop feature is, it always works. In the past it felt like 90% of the users failed with manual copy actions. And for some people even the drag and drop is hard to understand. But if copying the files works for, you can always do that!
After more than 40 years of the personal computing era, the preponderance of computer illiteracy is staggering.  It is amazing how many folks have trouble with something as fundamental as copying files from one directory to another.

Regardless, the instructions should mention the fact that the focus pixel maps are merely copied into a directory, and the instructions should also give the location and name of that directory ("/squashfs-root/usr/bin/" for the extracted Linux AppImage).


Quote from: masc on April 10, 2020, 07:36:17 PM
Feel free to contribute! That is very much welcome! Also if you find a way to create the appimage in a better way, you can help if you like. We implemented MLVApp mostly on OSX. On Windows I know how to get it to work. But on Linux I am just happy if it compiles and creates the appimage somehow, and it starts if I doubleclick the image. ;)
Okay!   Should I just DM the instructions to you?

In regards to creating an AppImage, my experience is limited mostly to running them and to the extraction that I had to perform to add the focus pixel maps.  I cannot speak for every Linux user, but I would prefer the additional option of having the files and directories of the app packed into a standard tar archive (or a compressed tar archive).  Although one can run an AppImage with only one command (or mouse click), the user must still unpack the MLV-App Appimage to use focus pixel maps.   It takes the same effort to unpack a tar archive and then run (click on) the binary.  Plus, there is no "compiling" a tar archive -- just create the archive (just like a zip file) and compress it, if you like.

I am happy to help in the creation of an MLV-App tar archive (and in cleaning-up the files/folders), but making a tar archive from folders and files is really "dumb-simple."


Quote from: masc on April 10, 2020, 07:36:17 PM
No idea what this plugin folder is and what it does. Should be something from the appimage. MLVApp has no plugin feature at the moment.
Judging from what's listed in the directory/file tree above, it appears that the "/squashfs-root/usr/plugins/" directory contains needed shared object libraries related to decoding/encoding audio and video formats.

If a version of the "Blue Banana" interface was an option in MLV-App, it could ease simple color grading (although it is very powerful in Cinelerra).


Quote from: masc on April 10, 2020, 07:36:17 PM
There is a way to import non-mlv, yes, but there is no way to import non-raw files. DNG, CR2, ... can be transcoded to MLV via raw2mlv, which is included in the package. Use "Transcode and Import" from the menu. You'll find the menu action only, if raw2mlv is on the right place (same folder as MLVApp executable). MLVApp imports the created MLV when transcoding is ready.
I thought I saw a way to import jpegs in the MLV-App menus. Even if one converted a video to a series of jpegs and there was an import function, image degradation would be a concern.  If importing jpegs is not possible, it might be a little unwieldy to convert video files to a compatible raw format, and then transcode with raw2mlv.

Some of us shoot ML H264 with boosted bit rate and/or all-I settings.  So, it would be great to be able to use MLV-App on those ML-generated files.

Thanks!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 11, 2020, 04:26:49 PM
Quote from: tupp on April 11, 2020, 12:44:59 AM
As you can see, there are two "mlvapp" binaries, along with the "AppRun" link to the working mlvapp binary).
Also note the two "raw2mlv" binaries plus the single instance of "ffmpeg."
In addition, there are two "MLVAPP.png" images.
Okay. I bet this should only be inside the structure, but not in the root folder. I hope the mlvapp executable inside bin is newer.

Quote from: tupp on April 11, 2020, 12:44:59 AM
The MLV-App Wiki instructs Linux users to copy their system's version of ffmpeg into MLV-Apps extracted root directory.  This action is sort of futile, as the mlvapp binary in that root directory fails while seeking dependencies on the user's system (specifically, in "/usr/lib/").
Where have you read this? I just see "copy "ffmpeg" and "raw2mlv" executable in this newly created directory". Nobody wrote (as I know) of a systems version of ffmpeg. Those hints came from another user who wanted to help us - maybe these days the archive was wrong the same way. I understood to copy ffmpeg from bin to archive root. But I would never ever use "any" ffmpeg.

Quote from: tupp on April 11, 2020, 12:44:59 AM
However, if one runs the mlvapp binary found in the extracted "/squashfs-root/usr/bin/" directory, MLV-App and the included ffmpeg binary works.  By the way, I tried replacing that included version of ffmpeg with the one on my system and I didn't have any trouble exporting an MP4 file from MLV-App.
Okay, but this is just one function you used from ffmpeg. There are many others like stabilizer and ...

Quote from: tupp on April 11, 2020, 12:44:59 AM
After more than 40 years of the personal computing era, the preponderance of computer illiteracy is staggering.  It is amazing how many folks have trouble with something as fundamental as copying files from one directory to another.
This might be the probem: today the guys grow with iPhone using "2-button-apps".

Quote from: tupp on April 11, 2020, 12:44:59 AM
Should I just DM the instructions to you?
You could also create an issue on github. Maybe others like to contribute as well with that. And with Linux I believe everything anybody tells me  ;D

Quote from: tupp on April 11, 2020, 12:44:59 AM
I thought I saw a way to import jpegs in the MLV-App menus. Even if one converted a video to a series of jpegs and there was an import function, image degradation would be a concern.  If importing jpegs is not possible, it might be a little unwieldy to convert video files to a compatible raw format, and then transcode with raw2mlv.

Some of us shoot ML H264 with boosted bit rate and/or all-I settings.  So, it would be great to be able to use MLV-App on those ML-generated files.
The main problem is, we need RAW data. For non-RAW pictures/videos you must somehow "undo calculate" unknown camera matrix, burned-in white balance and other things. I think this would never look good.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 11, 2020, 05:09:41 PM
Quote from: masc on April 11, 2020, 04:26:49 PM
The main problem is, we need RAW data. For non-RAW pictures/videos you must somehow "undo calculate" unknown camera matrix, burned-in white balance and other things. I think this would never look good.

Could just interpret it as sRGB, and figure out a basic curve to un-do it. But dynamic range would be bad.

This could be done very well with log I think. Log could be input in to a raw converter quite easily. Unfortunately this won't be happening with MLV App, it's tightly wrapped to MLV.

Quote from: QuickHitRecord on April 08, 2020, 09:39:45 AM
I haven't been using ML or MLV App lately, but in the wake of our recent quarantine, I decided to try them out once again. MLV App is a wonderful piece of software. I have one question though. When I set the profile preset to "Alexa Log-C" and then export to ProRes for grading later, I get some crazy banding in the resulting clips when a simple Log-C to Rec709 LUT is applied. Here is an example:

(https://i.postimg.cc/Z0yG712g/Working-00-00-48-11-Still001.png) (https://postimg.cc/Z0yG712g)

I seem to remember having problems with this in the past as well. Is there a way to export without this issue? In my case, I am using MLV App v1.11 and applying highlight reconstruction, making color temperature tweaks, and then exporting to 4K ProRes HQ. Then I'm bringing it into Premiere and applying the standard ALEXA_Default_LogC2Rec709 LUT in Lumetri. The camera is a 5D3 with 1.23 and a build from 2017.

Have you tried other export formats? Other versions of pro res? Which prores did you use?

Also... MLV App might do a better conversion to rec709 than a LUT someone else designed. Set tonemapping to reinhard 3/5 and gamma to 2.5, then tweak the dark/light sliders to your taste...

(https://i.postimg.cc/GRM2QW7z/M10-1710-frame-2.jpg)

After all, any log to rec709 lut will have smooth highlight roll-off and a subjective curve already built in.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on April 12, 2020, 09:46:42 AM
Quote from: masc on April 11, 2020, 04:26:49 PM
Okay. I bet this should only be inside the structure, but not in the root folder. I hope the mlvapp executable inside bin is newer.
The working mlvapp binary is located in the /squashfs-root/usr/bin/ directory.  The AppImage has a working symlink (AppRun -> usr/bin/mlvapp) that is integral to the AppImage structure.

Do you guys send the app (and its directories) around in "zip" files before creating the AppImage?  If so, zipping without an "allow symlinks" flag would probably explain the broken binary in the root directory.


Quote from: masc on April 11, 2020, 04:26:49 PM
Where have you read this? I just see "copy "ffmpeg" and "raw2mlv" executable in this newly created directory". Nobody wrote (as I know) of a systems version of ffmpeg. Those hints came from another user who wanted to help us - maybe these days the archive was wrong the same way. I understood to copy ffmpeg from bin to archive root. But I would never ever use "any" ffmpeg.
I was mistaken.  The Wiki doesn't specify where to get ffmpeg, so I just assumed that it meant one must provide it.  However, others might interpret those instructions similarly.

It shouldn't be too much trouble to make things clearer in the instructions.


Quote from: masc on April 11, 2020, 04:26:49 PM
Okay, but this is just one function you used from ffmpeg. There are many others like stabilizer and ...
I know.  I just tried my system's ffmpeg to see what would happen.


Quote from: masc on April 11, 2020, 04:26:49 PM
You could also create an issue on github. Maybe others like to contribute as well with that. And with Linux I believe everything anybody tells me  ;D
Ha, ha!

It would be great if I could send the instructions through this site.  I have no experience with github, but it's owned by Microsoft.  I would like to avoid signing-up with and giving details to Microsoft.


Quote from: masc on April 11, 2020, 04:26:49 PM
The main problem is, we need RAW data. For non-RAW pictures/videos you must somehow "undo calculate" unknown camera matrix, burned-in white balance and other things. I think this would never look good.
Quote from: ilia3101 on April 11, 2020, 05:09:41 PM
Could just interpret it as sRGB, and figure out a basic curve to un-do it. But dynamic range would be bad.  This could be done very well with log I think. Log could be input in to a raw converter quite easily. Unfortunately this won't be happening with MLV App, it's tightly wrapped to MLV.
Okay.  Just asking.  It's a shame that it can't be, though.

I have already made a compressed Linux tarball of MLV-App.  I cleaned out a lot of the compiling cruft, and I created a README file.  I also made a zip version (with the symlinks flag).  These archives are 60MB (smaller than the AppImage).

I don't see any way of attaching files to posts nor to direct messages here, so if anyone would like to have these files, we have to figure out how to make that happen.

Thanks!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Erkett on April 12, 2020, 07:49:09 PM
I'm feeling good with the 1.11 release with manual Bad Pixel Picker!
BEST THING EVER! :D
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 12, 2020, 08:36:03 PM
Quote from: Erkett on April 12, 2020, 07:49:09 PM
I'm feeling good with the 1.11 release with manual Bad Pixel Picker!
BEST THING EVER! :D
It is awesome. Thanks to masc and bouncyball.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on April 13, 2020, 03:26:36 AM
Quote from: tupp on April 12, 2020, 09:46:42 AM
I have already made a compressed Linux tarball of MLV-App.  I cleaned out a lot of the compiling cruft, and I created a README file.  I also made a zip version (with the symlinks flag).  These archives are 60MB (smaller than the AppImage).
Wouldn't it be better to just make an apt port (or use whatever package manager your distro has)? Same goes for Windows/OSX, actually. Everything could be installed through Chocolatey or Homebrew.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on April 13, 2020, 08:55:47 AM
Quote from: Luther on April 13, 2020, 03:26:36 AM
Wouldn't it be better to just make an apt port (or use whatever package manager your distro has)? Same goes for Windows/OSX, actually. Everything could be installed through Chocolatey or Homebrew.
Making distro-specific packages probably wouldn't be better from an "ease of maintenance and install" perspective.  Package managers such as apt, rpm, pacman, etc (and, perhaps, Chocolatey and Homebrew) fulfill dependencies from an OS's package repository (or "store").  So, it gets complex from the package developer's/maintainer's perspective, as every required dependency from every distro's repository has to work properly.

The developer could avoid those difficulties by maintaining versions of all dependencies for each distro in an independent, dedicated  repository, but, of course, that is a significant undertaking.  Such a scenario would additionally require that the user modify his/her repository list to include that independent repository (which can be somewhat daunting).

It's much easier for the developer of a special app to simply include all of the dependencies in an archive with the main binary.  It is just as easy for the user to to simply unpack the archive and run the binary, as it is for the user to update a repository list, install the app and run it normally.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on April 13, 2020, 12:37:18 PM
Quote from: tupp on April 13, 2020, 08:55:47 AM
It is just as easy for the user to to simply unpack the archive and run the binary, as it is for the user to update a repository list, install the app and run it normally.
Yeah, but normally easy is not the correct thing to do. If you distribute your software in a whole binary, your system will have different binaries for the same software. This will cause software to be out of date. Also, if you don't use a package manager, you'll need some kind of update checking code, which can be eliminated while using a package manager (MLVApp should even have network capable code in the first place). And from a security stand point a package manager is much better (protocol is encrypted, files signed and hash checked - some even have privilege separation).
Quote
So, it gets complex from the package developer's/maintainer's perspective
For a project with many dependencies, I agree. But MLVApp has only two dependencies and one of them is already well maintained on most systems (Qt).

Some useful links:
https://github.com/chocolatey/choco/wiki/CreatePackagesQuickStart
https://github.com/Homebrew/homebrew-cask/blob/master/doc/development/adding_a_cask.md
https://www.debian.org/doc/manuals/debmake-doc/ch05.en.html
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on April 13, 2020, 04:24:05 PM
Quote from: Luther on April 13, 2020, 12:37:18 PM
Yeah, but normally easy is not the correct thing to do.
Who's to say?  What is considered "easy" and what is considered "correct" are two independent and subjective notions.

Quote from: Luther on April 13, 2020, 12:37:18 PM
If you distribute your software in a whole binary, your system will have different binaries for the same software.
Most of the time, but not always.

In this case, we have two versions of ffmpeg -- the user's system version and, apparently, the version specially compiled for MLV-App, as suggested by @masc:
Quote from: masc on April 10, 2020, 07:36:17 PM
The included ffmpeg version should be used always!!! If you use another ffmpeg, nobody knows if it works for all features.

I would rather have two ffmpegs than bork some MLV-App features.


Quote from: Luther on April 13, 2020, 12:37:18 PM
This will cause software to be out of date. Also, if you don't use a package manager, you'll need some kind of update checking code, which can be eliminated while using a package manager (MLVApp should even have network capable code in the first place).
Huh?

Every time a new MLV-App version appears, one merely downloads the archive and upacks it in the same location as the previous version.

No problem.

By the way, MLV-App is likewise installed without a package manager with the AppImage and with the Mac (and probably Windows) package.


Quote from: Luther on April 13, 2020, 12:37:18 PM
And from a security stand point a package manager is much better (protocol is encrypted, files signed and hash checked - some even have privilege separation).
A package manager doesn't provide more security -- it basically just automates the install and reduces redundancy.

There is nothing preventing someone from encrypting, signing and check-summing a Linxux tarball, a Mac DMG nor an independent Windows program.

By the way, in Linux, MLV-App is usually installed somewhere in the user's home directory, so it only runs with that user's priveleges.


Quote from: Luther on April 13, 2020, 12:37:18 PM
For a project with many dependencies, I agree. But MLVApp has only two dependencies and one of them is already well maintained on most systems (Qt).
There seem to be lots of dependencies -- just look at the file/directory tree in this post (https://www.magiclantern.fm/forum/index.php?PHPSESSID=4hhr1eba1b6e0253olvec6irce9b21ro&topic=20025.msg225909#msg225909).

I tried to run the unintended mlvapp binary found in the root, " /squashfs-root/" directory of the extracted MLV-App, and it looked in my system's /usr/lib/ for all of the MLV-App libraries that were unpacked in /squashfs-root/usr/lib/.  Those libraries are not in my system's /usr/lib/ directory, so MLV-App stalled.

Hence, all of the libraries and shared objects packaged with MLV-App are dependencies.


Quote from: Luther on April 13, 2020, 12:37:18 PM
Some useful links:
https://github.com/chocolatey/choco/wiki/CreatePackagesQuickStart
https://github.com/Homebrew/homebrew-cask/blob/master/doc/development/adding_a_cask.md
https://www.debian.org/doc/manuals/debmake-doc/ch05.en.html
Thanks.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on April 14, 2020, 02:44:52 AM
Quote from: tupp on April 13, 2020, 04:24:05 PM
Who's to say?  What is considered "easy" and what is considered "correct" are two independent and subjective notions.
They are not subjective notions, we are not talking about philosophy we are talking about computing.
Quote
Most of the time, but not always.
Doesn't matter, many software will be redundant and out of date.
Quote
I would rather have two ffmpegs than bork some MLV-App features.
In the ffmpeg case, there would be no choice other than distribute the binary or give the package manager the order to compile the package itself.
Quote
one merely downloads the archive and upacks it in the same location as the previous version.
That's the point. This process can be easily automated.
Quote
A package manager doesn't provide more security -- it basically just automates the install and reduces redundancy.
That's just false. Most package managers require signing with PGP. The files are transported over encrypted connection (TLS1.2 or recently 1.3) and files have integrity check with SHA256/512. If you don't see the security benefits here, I don't know what to tell you.
Quote
There is nothing preventing someone from encrypting, signing and check-summing a Linxux tarball, a Mac DMG nor an independent Windows program.
Indeed, there's not. But these systems already have a unified solution, so why not use them?
Quote
There seem to be lots of dependencies -- just look at the file/directory tree in this post (https://www.magiclantern.fm/forum/index.php?PHPSESSID=4hhr1eba1b6e0253olvec6irce9b21ro&topic=20025.msg225909#msg225909).
Those doesn't seem to be dependencies, they are in the software itself.
Quote
Those libraries are not in my system's /usr/lib/ directory, so MLV-App stalled.
Of course not, that's the function of the package manager to put them there.
Quote
Hence, all of the libraries and shared objects packaged with MLV-App are dependencies.
Libs != dependencies
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Kharak on April 14, 2020, 12:09:20 PM
I noticed Slimraw lossless compressed dng's can not be transcoded to MLV.

Does Mlv App "expect" lossless compressed dng's from MLV_dump to be able to uncompress/transcode them back to MLV?

Slimraw does a better compression than mlv_dump, I'd say about 10-15% more compression or put it this way, you can compress the lossless output from Mlv_dump with slimraw by another 10-15% or so, lossless.

Would you consider looking in to supporting lossless dng from Slimraw?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 14, 2020, 08:36:06 PM
If it is just the appimage size: we also can zip it in future.
For me the good thing on a "All Inclusive Package" is: you get what we tested. In past we tried to keep the number of depencies low: now we use openMP and Qt, a ffmpeg version which we tested with MLVApp and a raw2mlv executable. The downside on Qt: there are many many versions out there. And some features change over time. So if a feature works with one Qt version, it might look different with another. That's why I don't like package managers. In our archives we can include the best working libraries we can find.
If you search a Debian package of MLVApp, you find it here:
http://phd-sid.ethz.ch/debian/mlv-app/
(1.10 is latest atm)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 14, 2020, 09:17:31 PM
Quote from: Kharak on April 14, 2020, 12:09:20 PM
I noticed Slimraw lossless compressed dng's can not be transcoded to MLV.

That means raw2mlv (meaning, LibRaw) does not support that specific format of DNG. LibRaw is supposed to support all raw formats, but there's a few it does not seem to work with. You could sumbit a issue on github: github.com/LibRaw/LibRaw (http://github.com/LibRaw/LibRaw) - send them a sample file
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on April 14, 2020, 10:16:41 PM
Quote from: Luther on April 14, 2020, 02:44:52 AM
They are not subjective notions, we are not talking about philosophy we are talking about computing.
Please pardon me.  I forgot that there are no subjective opinions concerning computing.


Quote from: Luther on April 14, 2020, 02:44:52 AM
Doesn't matter, many software will be redundant and out of date.
It matters.

As I said, in this case, we have two versions of ffmpeg -- the user's system version and, apparently, the version specially compiled for MLV-App, as suggested by @masc.  This is a special case and not "many software."

Furthermore, even with a package manager, the user usually still has to manually command an update -- auto-update mechanisms are commonly not the default.

In addition, "many" folks employ an "app"  directory in their home directory for just such special cases.  I have such a directory and it contains 13 apps, all up-to-date, except for the ones I specifically have not updated -- very easy. convenient and foolproof to do without a package manager and I never have to worry about a package manager inadvertently updating a package that I have intentionally downgraded.  One more thing, such a directory makes it very easy to run a downgraded version of an app , while also the "current" version of the app maintained by the package manager.  Additionally, one of the apps


Quote from: Luther on April 14, 2020, 02:44:52 AM
In the ffmpeg case, there would be no choice other than distribute the binary or give the package manager the order to compile the package itself.
Yes.  So, the first "choice" applies here -- the MLV-App binaries are distributed in their own self-contained packages :  Mac DMG,  'nix AppImage, Windows "whatever" (with it's own "installer?")  and, potentially, a Linux tarball.


Quote from: Luther on April 14, 2020, 02:44:52 AM
That's the point. This process can be easily automated.
No.  Not through a package manager.

Trying to keep differing versions of the same app and differing versions of the same libraries with a package manager is difficult to set-up as a maintainer (and one first has to recruit such a maintainer), and can often be complex to set-up as a user.

It is easy enough just to unpack a tarball and run the app from there.


Quote from: Luther on April 14, 2020, 02:44:52 AMThat's just false. Most package managers require signing with PGP. The files are transported over encrypted connection (TLS1.2 or recently 1.3) and files have integrity check with SHA256/512. If you don't see the security benefits here, I don't know what to tell you.
It's not false.

I said, "A package manager doesn't provide ***more*** security -- it basically just automates the install and reduces redundancy.  There is nothing preventing someone from encrypting, signing and check-summing a Linxux tarball, a Mac DMG nor an independent Windows program."

So, one can also use PGP signing and check-summing  with an independent tarball, AppImage or dmg (as I actually stated), just like a package manager might do.

Hence, a package manager doesn't provide ***more*** security than an AppImage, DMG, tarball, etc.


Quote from: Luther on April 14, 2020, 02:44:52 AMIndeed, there's not.
So, we agree that package managers don't provide more security, immediately after stating that assertion is false?


Quote from: Luther on April 14, 2020, 02:44:52 AMBut these systems already have a unified solution, so why not use them?
For the reasons that I have repeatedly stated.  Basically, it is often easier to distribute and run special apps (such as MLV-App) without using a package manager.


Quote from: Luther on April 14, 2020, 02:44:52 AM
Those doesn't seem to be dependencies, they are in the software itself.
No.  They aren't "in" the software.  They are separate, independent files, as shown in the directory/file tree.

Quote from: Luther on April 14, 2020, 02:44:52 AMOf course not, that's the function of the package manager to put them there.
So, ignoring the mud-slog of having to set-up such dependency functionality with each package manager, those libraries and shared objects are required by the main binary.

Thus, the binary depends on those files.

Quote from: Luther on April 14, 2020, 02:44:52 AM
Libs != dependencies
On the contrary, libraries are probably the most common software dependency.


This line of discussion has taken this thread off the rails, and I cannot keep repeating myself.  I merely tried to offer improved instructions for the MLV-App focus dot pixels and to provide a Linux tarball of the AppImage, but it seems to have devolved into qualitative opinions and semantics arguments regarding package managers vs. self-contained packages.

I have to move on.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on April 15, 2020, 02:01:15 AM
Quote from: tupp on April 14, 2020, 10:16:41 PM
It's not false.

I said, "A package manager doesn't provide ***more*** security -- it basically just automates the install and reduces redundancy.  There is nothing preventing someone from encrypting, signing and check-summing a Linxux tarball, a Mac DMG nor an independent Windows program."

So, one can also use PGP signing and check-summing  with an independent tarball, AppImage or dmg (as I actually stated), just like a package manager might do.

Hence, a package manager doesn't provide ***more*** security than an AppImage, DMG, tarball, etc.
Seriously dude? Call me when you wake up. This is the same as saying OMEMO doesn't offer more security, because you can just check fingerprints manually and encrypt your text with AES-256. That's just a dumb way of thinking. If the process is not automated, normal people just won't do it.
There's a reason why package managers exist for so long: they work.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Ottoga on April 15, 2020, 06:48:04 AM
@Luthor @Tupp

Let's remember that all the development work and distribution packaging is being done by people who aren't getting paid for it and doing it in their spare time. So how about we stop the pissing contest.

@Luthor If you feel that strongly that MLVAPP should be distributed via a packaging tool then: perhaps put your hand up and volunteer to take ownership of packaging and distributing the app for the developers unpaid in your spare time.

If not, then I think your suggestions have been heard load and clear. However at the end of the day it is up to the developers to decide on their distribution process.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 15, 2020, 06:50:11 AM
Quote from: Ottoga on April 15, 2020, 06:48:04 AM
@Luthor If you feel that strongly that MLVAPP should be distributed via a packaging tool then: perhaps put your hand up and volunteer to take ownership of packaging and distributing the app for the developers unpaid in your spare time.

If not, then I think your suggestions have been heard load and clear. However at the end of the day it is up to the developers to decide on their distribution process.
+1
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on April 17, 2020, 01:47:56 PM
+1 :D
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yokashin on April 17, 2020, 06:45:07 PM
 :)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: olofen on April 19, 2020, 12:00:11 PM
   Hi,
I am searching (in vain...?) for a way to postprocess my CinemaDNG files from MLV to ProRes 444 to be able to work in FCP X.
Someone mentioned somewhere that I could do it through Apple Compressor but I only meet greyed out files...
Why I want this is because I can adjust the CinemaDNG files in Photoshop in a good way as an intermediate process
Is it possible? Did I do something wrong?
    Please help me out!
         yours
      olof thiel
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 19, 2020, 01:11:20 PM
What do you mean?
Dng to prores can be achieved wkth mlv app resolve and acr för instance. What's the problem?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 19, 2020, 01:12:24 PM
You can do that with Quicktime or in Resolve. Or you don't use CinemaDNG and convert straight to ProRes.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: olofen on April 19, 2020, 07:20:31 PM
I want to be able to work with the CinemaDNG files in Photoshop before converting them to ProRes 444....
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 19, 2020, 08:22:28 PM
Closest thing is going through after effects, using adobe camera raw.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yourboylloyd on April 19, 2020, 09:23:18 PM
Quote from: olofen on April 19, 2020, 07:20:31 PM
I want to be able to work with the CinemaDNG files in Photoshop before converting them to ProRes 444....

Photoshopping hundereds of cDNG files is going to be rough. Like Danne said, use after effects (it's the same as photoshop because of Adobe Camera Raw). This is the fastest workflow if you want to stick with Adobe https://www.magiclantern.fm/forum/index.php?topic=13354.msg128954#msg128954 . It uses "Smart Import 2" and lets you adjust multiple DNG's at once that are in the folder.

But MLVapp can do all of that too and is much faster. Davinci Resolve is the fastest for editing cDNG files by an exponential amount though and it's free.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: olofen on April 19, 2020, 10:22:12 PM
You mean you can get ProRes out of After Effects...?
(Sorry about my ignorance but I never worked with After Effects but if it works I will get it)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 19, 2020, 10:37:18 PM
Quote from: olofen on April 19, 2020, 10:22:12 PM
You mean you can get ProRes out of After Effects...?
(Sorry about my ignorance but I never worked with After Effects but if it works I will get it)
Stop your "ignorance" by using search from now on. Even google will do the trick. Think you got enough hints already.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: olofen on April 20, 2020, 11:22:43 AM
I learn 👍
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 23, 2020, 01:00:04 PM
Quote from: olofen on April 19, 2020, 07:20:31 PM
I want to be able to work with the CinemaDNG files in Photoshop before converting them to ProRes 444....

This is how I would proceed: I would get IWLTBAP LUT Generator, generate an hald LUT put the hald ontop of a frame in Photoshop, "grade" everything, cut the hald part out of the image, save that as a PNG and generate a x64 cube LUT that I would import in MLVApp (or Resolve but you should test this by yourself). That woud serve as a base for a grade or a reference.
Look at their website for more in-depth explainations, that is a very useful tool (that I used to convert gmic's hald to cube).

If you are on Windows, MLVApp uses ffmpeg so your ProRes 444 would be 10 bits but on Mac it should be 12 bits  if i'm not mistaken.
With Resolve on Windows, you can export to DNxHR 444 12 bits and Prores should be available on Mac, I'm not sure.

From an esthetic point of view if the goal is to apply a film emulation preset to your shots keep in mind that they are meant for photography and might end up very strong in the context of videography (for the same reason I don't find trying to copy a look from a movie by grading a still particularly relevant, it might look good on one frame but usually really bad on a scene for many reasons that would need a deep dive into cinematography). I don't find grading from Photoshop very appealing overall because it is utterly slow and would lack consistency between scenes but hey, to each his own, there's nothing wrong about experimenting. Feel free to share your findings (preferably in a dedicated post in the Raw Video Postprocessing section instead of this one if it doesn't involve MLVApp).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 23, 2020, 03:55:04 PM
google's pixel 2 XL  RAW DNG files transcode and import is broken again in 1.1, it was fixed in the sourcecode for previous versions but looks like was not merged into new one.
But when i swap old raw2mlv then it says that cant find the MLV file, so more than that was changed.
I know its pretty vague but this hsould fix it, ill try to do it myself and compile raw2mlv again with this change
IT should be :
        "Pixel 2 XL-Google-google",
        {
         0.0127,  0.0727,  0.5789,
            -0.2806,  1.0683,  0.2451,
            1.2341, -0.6660,  0.0994
        },
        {
            -0.0558,  0.1620,  0.5206,
          -0.3982,  1.2675,  0.1412,
            1.0612, -0.4169, -0.1001
        }

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 23, 2020, 04:11:09 PM
@cmh: ProRes444 with ffmpeg is always 10bit, and with AVFoundation 12bit.

@2blackbar: don't see a change. Your code snippet is in the code of raw2mlv. raw2mlv says it can't find the MLV file? How that? As far as I know it generates MLV files and doesn't search for them. And what is version 1.1? Without a file we can't test...
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 23, 2020, 07:52:33 PM
I see it im matrices too, ill compile and test it, but it just doesnt work in new reelase, i compiled modified raw2mlv myself for previous releases, pixel 2xl matrices had swapped values  so i edited those to make them work and they worked until now, so i have to use old version of mlvapp cause when i simply copy old raw2mlv then it just give me issues with cant find mlv the file.
But in meanwhjile heres the file from pxel 2XL, can you convert it and see the image in newst mlvapp 1.1 ?
https://drive.google.com/open?id=1ZyWEty62iFkiSTmKAozqRQQ_wZCpjP2O
Ok , cant compile, structure has changed
My compiled raw2mlv that worked with pixel2xl dngs , but copying it to new mlvapp 1.1 folder wont make it work somehow
https://drive.google.com/open?id=1nPcOSacgGXDEsXLJ4MYVWqFItqpWUgT5

---
Ok now i copied old raw2mlv to new mlvapp1.1 folder but with all dlls from old mlvapp aswell, and it worked.
So all is good here, but that new raw2mlv is not working with pixel2xl files tho.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 23, 2020, 09:24:11 PM
Conversion works without any problems. Only problem I see so far: there is indeed a problem with the camera matrix values. You have to switch to "Don't use camera matrix", then you see an image. But colors are bad without calibration.
(https://i.ibb.co/ZXSbf8D/Bildschirmfoto-2020-04-23-um-21-21-40.png)
Any raw2mlv should work with any MLVApp version allowing to transcode. Reason: the interface never changed.
Edit: the colors are changed... :D
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 23, 2020, 09:35:12 PM
Quote from: 2blackbar on April 23, 2020, 07:52:33 PM
So all is good here, but that new raw2mlv is not working with pixel2xl files tho.

In what way doesn't it work? Program doesn't run?

@masc the colour problem is that blue and red channel get swapped, because pixel Raw photos start at Blue bayer pixel, while all MLV cameras start with Red pixel. MLV App never took this in to consideration, and the MLV format is quite stupid at how it indicates which pixel the bayer pattern starts at. The field cfa_pattern (https://github.com/ilia3101/LibMLV/blob/master/include/mlv_structs.h#L94) is supposed to tell us that, but all I know is that a value of 0x02010100 means red (very cool number right?). Who knows what value would represent blue.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 23, 2020, 09:38:12 PM
Quote from: ilia3101 on April 23, 2020, 09:35:12 PM
@masc the colour problem is that blue and red channel get swapped, because pixel Raw photos start at Blue bayer pixel, while all MLV cameras start with Red pixel.
Okay, thanks. That's what I thought too. ;)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 23, 2020, 11:30:30 PM
It PARtially works with that new raw2mlv but only when i choose to not use cam matrix and colors are swapped ,  i swapped them back into right place when compiling for myself but this new version of raw2mlv i cant compile.
In that version that i compiled you dont have to do "not use cam matrix" , it works right away with "use camera matrix".And all i did to it was editing matrices file, swapping values for channels in pixel2xl profile.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 23, 2020, 11:43:56 PM
As a temporary solution (until I sort out mlv format cfa_pattern) – I can make raw2mlv crop a few pixels on the left and right to make it always start at red (no more than 8 pixels of horizontal resolution will ever be lost). Would this be ok for you?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 24, 2020, 06:40:38 AM
Its not really that important cause old raw2mlv works fine and only i have that issue, but if its gomna help with other profiles then maybe its worth the hassle.
Ah, i also forgot i customised MLVApp medium compression ratio for h.264 so it has better quality, id have to recompile myself again.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 28, 2020, 09:57:46 PM
I used to raise cdng exposure to 1.26 in the raw tab to match prores in Resolve but I realized that MLVApp leave the BaselineExposure exif tag at 0 compared to various Ursa mini shots I got where it's always set to 3.09 (and 0.76 on a Digital Bolex D16 according to the internet).
A quick fix that overwrites the original files with a value of 1.26, it's a pretty quick operation:
exiftool -BaselineExposure=1.26 -overwrite_original *.dng
I tried few samples provided on the forum (7d 14 bits and 5d III 10 bits) and various gamut/color space: it's still 1.26, it seems consistent.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 28, 2020, 10:13:01 PM
Thanks for the post. When exporting cdng, MLVApp applies only RAW corrections and stretch factors - but nothing else. If you use a Mac, you could write a quick script and run it via post export script feature automatically. I don't know a way to write this value directly to the dng file without another tool. Maybe someone else knows a way... ?!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 28, 2020, 10:29:34 PM
MLVApp do create tags (related to black levels, camera and lens info for exemple) in dng.c and I can see some reference to BaselineExposure in dng_tag_codes.h.
I'm not qualified to say wether it's feasible in MLVApp or not but I think there's good hope.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 28, 2020, 10:44:50 PM
What is the tag set to when exporting a cr2 into dng with adobe dng converter?
It's read by acr but is it read in resolve?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 28, 2020, 10:51:10 PM
dng.c line 638 should be the line to change, if you mean BaselineExposure is the correct value.
{tcBaselineExposure,            ttSRational,RATIONAL_ENTRY(basline_exposure, header, &data_offset, 2)},
But what is the data type rational?! Our exposure value is of type "double".
#define RATIONAL_ENTRY(a,b,c,d) (d/2), add_array(a, b, c, d)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 09:07:43 AM
It's bouncyball code, maybe I should pm him later to see if he's around.

I see some other stuff line 579:

        /* Baseline exposure stuff */
        int32_t basline_exposure[2] = {mlv_data->RAWI.raw_info.exposure_bias[0],mlv_data->RAWI.raw_info.exposure_bias[1]};
        if(basline_exposure[1] == 0)
        {
            basline_exposure[0] = 0;
            basline_exposure[1] = 1;
        }


I need to reinstall qt and a dev environnement, that will take some time with my subpar internet.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 09:17:16 AM
It´s a simple exposure correction tag. Just change to the hardcoded one and compile. However before releasing any official changes make sure 1.26 is the correct number. No use adding this tag if it´s not properly checked. I think converting a CR2 to dng in adobe dng converter would reveal this. Anybody checked?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 09:25:03 AM
Not yet but you're right the 1.26 value is eyeballed by comparing prores and dng files on the vectorscope.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 09:47:16 AM
ACR converted files have a value of 0.25 (various iso tested).
edit: let me check what happened in Resolve...

Both the converted CR2 and the cdng needs a raise of exposure of 1.26 (approximately) to match untouched prores (rec709 tested for consistancy but whatever, it's the same for all of them).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 10:03:23 AM
Quote from: cmh on April 28, 2020, 09:57:46 PM
I used to raise cdng exposure to 1.26 in the raw tab to match prores in Resolve but I realized that MLVApp leave the BaselineExposure exif tag at 0 compared to various Ursa mini shots I got where it's always set to 3.09 (and 0.76 on a Digital Bolex D16 according to the internet).
A quick fix that overwrites the original files with a value of 1.26, it's a pretty quick operation:
exiftool -BaselineExposure=1.26 -overwrite_original *.dng
I tried few samples provided on the forum (7d 14 bits and 5d III 10 bits) and various gamut/color space: it's still 1.26, it seems consistent.

Are you matching prores from ffmpeg produced content here in Mlv App? Isn´t it a flaw in the prores setting then? It could be a number of things from rec709 curve, gamma etc. Think it will be difficult to achieve perfect raw/prores exposure etc out of the box.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 10:07:13 AM
Most definitly but it's not gamma and color space related, I've tested alexa cineon linear bmd they all need that exposure fix. Let me check other codecs real quick (but I think we would have noticed it before if dnxhr or h264 lowered the exposure by more than a stop).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 10:24:26 AM
How will a comparison between a cdng file produced from a MLV recording against a CR2 - dng produced in adobe dng converter look? Tested with exact same settings and on the same test scene.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 10:50:13 AM
I did those tests, I got prores and h264 files (both rec709 profiles but I already checked other profiles, +1.26 exposure is still needed).
While not perfect (due to framing missmatch, color temp shift and probably debayering differences) 1.26 seems consistent for MLVApp generated cdng files.
edit: let me do a screenshot real quick. Well a video then it will be easier.
https://youtu.be/YZAFH2MgE_k
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 29, 2020, 11:25:56 AM
I would not hardcode 1.26 to MLVApp. I would try to get the exposure slider value into the cdng. Then you can create your own default receipt with any value you like, import your MLVs and export them straight away with your preferred exposure value (e.g. 1.26) and get the right exposure in Resolve.

Danne is right: there are so many algorithms behind many parameters. And just because they are called the same and the numbers look similar the realization might (and will) be very very different. It can be anything, not just exposure. Who tells us e.g. Adobe or Resolve calculates profiles the same way?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 11:27:09 AM
If the adobe dng needs + 1 to match prores i'd say 0.26 is what to be added to to mlv cdng. Any other matching should be done manually.
Take this with a grain of salt. Still haven't seen any visual comparisons.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Kharak on April 29, 2020, 11:27:56 AM
I too recommend that you don't hardcode any exposure change to the DNG. But optional or a slider, that would be great and even other metadata.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 11:40:45 AM
It could be two explicit tickboxes at export or something, like "BaselineExposure 0.25" with an helper dialogue "match adobe dng converter exposure for canon cameras" and "add BaselineExposure + 1"  with the dialogue saying "match encoders exposure". Then I don't request anything just wanted to point out the discrepancies between various dng files in resolve.

The exact value has to be determined, 1.26 in resolve seems to match but I haven't checked other NLEs (baselight, vegas, adobe's products, apple's stuff, etc).

Edit:so far the tag matches various canon cameras but ofc it will be different depending of brands and models.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 11:46:07 AM
I don't agree. Follow adobe dng standard alternatively keep as is.
You will get different variations from any other nle.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 12:01:58 PM
Sorry I always edit my posts without realizing someone replied, but both separated values,+0,25 and +1 could be export options, one added on top of the other.
Also, you're right, not only different nle has to be checked but there's brands other than canon, thinking about raw2mlv stuff.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 12:08:58 PM
But isn't this for specific use with prorrs proxies? Anything above 0.26 will act as overexposure according to the original spec.
If you export prores from resolve they surely match.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 12:15:35 PM
I don't really understand your comment. Just to clarify the 1.26 exposure difference concerns all codecs not just proxies.
Quote from: Danne on April 29, 2020, 12:08:58 PM
Anything above 0.26 will act as overexposure according to the original spec.
Adobe's specs? Do you know where I can find some info on that?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 12:38:20 PM
I follow your tests. You converted a cr2 to dng and state it says 0.26 after conversion. This is the exposure calibration tag everything else should be derived from. If Mlv app prores comes out brighter that´s what to look into but really not necessary since it´s a small manual fix if to be used as proxy. If on other hand we start manipulate original 0.26 tag we will get wrong raw starting point. Never good.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 29, 2020, 01:13:45 PM
When trying with ACR, I would say the difference is smaller 1EV.
(https://i.ibb.co/LpcdM6z/Bildschirmfoto-2020-04-29-um-13-10-48.png)
(https://i.ibb.co/8rCZJZN/Bildschirmfoto-2020-04-29-um-13-10-52.png)
Sure, it isn't an issue or wrong setting in Resolve?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 03:15:57 PM
Sorry for the late response.
Quote from: Danne on April 29, 2020, 12:38:20 PM
I follow your tests. You converted a cr2 to dng and state it says 0.26 after conversion.
Right, I understand now.

Quote from: masc on April 29, 2020, 01:13:45 PM
Sure, it isn't an issue or wrong setting in Resolve?

I posted a quick video but there is no additional settings involved, it's not ACES, pretone curve isn't ticked (but I've tested, it doesn't change the exposure strictly speaking). The same exposure difference is for all dng files regardless of the profile applied given that you use the same cst/lut in resolve.

I don't have any other NLE installed but at one point I will probably upload a (boring long ass) pipeline comparison between MLVApp and Resolve on youtube, with various shot and go through these settings on screen so people can point out any mistakes.

If I find how to fix it I can put up a patch and fork the project real quick. Otherwise, my workflow will involve exiftool, no big deal it's extremly fast and more convenient than applying a receipt or use a dpx on Resolve.

edit:
Quote from: cmh on April 29, 2020, 10:50:13 AM
https://youtu.be/YZAFH2MgE_k
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 29, 2020, 04:45:41 PM
Quote from: Danne on April 29, 2020, 12:38:20 PM
Mlv app prores comes out brighter

Does anyone else have this kind issue? I'm having this issue for every kind of export (macOS 10.14)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 29, 2020, 05:04:19 PM
Quote from: ilia3101 on April 29, 2020, 04:45:41 PM
Does anyone else have this kind issue? I'm having this issue for every kind of export (macOS 10.14)
FFMPEG and/or AVFoundation?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 05:07:21 PM
I don't have this issue. At least never noticed.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 29, 2020, 05:48:31 PM
Quote from: masc on April 29, 2020, 05:04:19 PM
FFMPEG and/or AVFoundation?

Both, in all formats. Even with PNG frame export.

It seems like my combination of macOS version, Qt version and screen calibration is mixing badly for some reason.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 09:19:44 PM
I get the same as masc. Acr interprets preview window a little darker than mac quicktime preview or player. Resolve as usual has its own life but I get a fairly coherent preview. Gamma is a little different but brightness more or less the same.
Well. Everyone is being fairly lazy around this not posting images comparisons or digging deep so really hard to define a real issue yet ;).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 09:54:30 PM
I won't put that on laziness (maybe a lack of interest).
I don't know much about ACR but I do know that Resolve won't get the right exposure value for DNG produced without the proper exif tag.
Isn't ACR/Lightroom loading an embedded profile with lens data and color profile ? Then there's probably a way to strip that and compare to Resolve or UFRaw or RawTherapee.
Are those comparisons made with the same color space/gamut or just left with default reinhard on MLVApp for exemple (I did my video with rec709/rec709 in both MLVApp and Resolve for that reason)?
Are those previews an accurate representation of said DNG in the first place weither it's Resolve, Lightroom, MLVApp ?
At the end of the day if it revolve around more questions than answers, then I'll ask the real question? Is this even worth "fixing"?

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 10:07:21 PM
Quick and dirty:
resolve prores(mlv app exported)
(https://i.postimg.cc/KjBgjw33/Screenshot-2020-04-29-at-22-00-41-png-scaled.png)

resolve cinema dng
(https://i.postimg.cc/bw3SZQrg/Screenshot-2020-04-29-at-22-00-35-png-scaled.png)

Camera raw
(https://i.postimg.cc/0Q3pb7tF/Screenshot-2020-04-29-at-22-03-16-png-scaled.png)

Mlv app
(https://i.postimg.cc/7hfJ1j2L/Screenshot-2020-04-29-at-22-03-56-png-scaled.png)



EDIT:


Resolve prores master imported back into resolve timeline:
(https://i.postimg.cc/ZYpm748z/Screenshot-2020-04-29-at-22-10-03-png-scaled.png)

Resolve cinema dng
(https://i.postimg.cc/MZQ6Cy84/Screenshot-2020-04-29-at-22-10-09-png-scaled.png)


So yes. You got a valid point. Exposure is not matched correctly in brightness. But maybe other stuff too. I mean. Prores export from resolve matches cinema dng input beautifully.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 10:17:39 PM
Give me a sec I'll do the same with sRGB/rec709 everywhere (since I think this is how ACR will display it, well I think).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 10:27:22 PM
Adobe standard should be closest to rec709:

Mlv app preview
(https://i.postimg.cc/7hfJ1j2L/Screenshot-2020-04-29-at-22-03-56-png-scaled.png)

ACR adobe standard
(https://i.postimg.cc/pThCvKzG/Screenshot-2020-04-29-at-22-24-47-png-scaled.png)




EDIT:

By the way. Raise exposure in acr by 0.26:
ACR:
(https://i.postimg.cc/Hxb9hdQj/Screenshot-2020-04-29-at-22-29-07-png-scaled.png)

Mlv app preview
(https://i.postimg.cc/7hfJ1j2L/Screenshot-2020-04-29-at-22-03-56-png-scaled.png)




EDIT 2:
Exposure raised with 1 full step:
(https://i.postimg.cc/d0VfpW6G/Screenshot-2020-04-29-at-22-32-37-png-scaled.png)

Mlv app preview
(https://i.postimg.cc/7hfJ1j2L/Screenshot-2020-04-29-at-22-03-56-png-scaled.png)



Looks like 0.26 is close, maybe even 0.5 would work. That is matching acr. Resolve seems even darker as you said.

EDIT: Tested some more in resolve, all set to rec709. Seems more like 1.5 stop imcrease to match brightness.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 10:42:21 PM
Damn you are efficient and yeah I know, sRGB/rec709 and rec709/rec709 are really close (sRGB is just a bit higher) but I want to be as accurate as possible (I can see reinhard in your mlvapp screenshots tho and you extracted a frame you didn't export to cdng, just saying).

MLVApp
(https://i.postimg.cc/mZYRCgdq/MLVAPP.jpg)

Prores from MLVApp in Resolve
(https://i.postimg.cc/YC9w5fpK/prores.jpg)

cdng from MLVApp in Resolve
(https://i.postimg.cc/fTszr9tD/CDNG.jpg)

cdng from MLVApp in Lightroom
(https://i.postimg.cc/W1WszY91/Lightroom.jpg)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 10:50:27 PM
I'd say Resolve is closer to Lightroom in term of exposure (but with a wrong white balance, it has always rendered cdng like that and it needs like a -15 tint correction compared to prores) than MLVApp or prores.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 10:54:54 PM
Yes, Reinhardt is causing pushed brightness to prores file. If I select tangent(whatever that is) Exposure match pretty close with acr:
(https://i.postimg.cc/hG4bbsRw/Screenshot-2020-04-29-at-22-45-20-png-scaled.png)

(https://i.postimg.cc/MZn5F9fJ/Screenshot-2020-04-29-at-22-51-25-png-scaled.png)


Well, quick and dirty ;).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 10:56:28 PM
This is definitly NOT what we got on Windows, weither it's in ACR/Lightroom or Resolve... I'm starting to think that it's more of a Mac OS thing now.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 11:00:46 PM
hehe, what a mess  :-*
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 11:07:01 PM
Yeah Togg from the forum and I had a discussion about a dpx (power grades if you are not familiar) and we both had to raise our exposure by +2 with it, so I'm pretty sure he's on Windows and would have the same issue. Maybe some other Windows users are willing to confirm the issue. What about Linux ?

Here's the dng I used if anyone needed it:
https://mega.nz/file/9YYWRa4Z#qhnCofFnyY_AXlbS_5ciHaUflKXuNLyox-RS2EKVkNw

That said, I'll peace out for now.

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 11:11:45 PM
Tested some more. If I set to tangent and rec709 and then set white balance the same(6500, tint 0) in both apps it actually looks pretty much the same. Profile adobe color in acr.

Mlv app
(https://i.postimg.cc/brjv1zZR/Screenshot-2020-04-29-at-23-03-53-png-scaled.png)

Acr
(https://i.postimg.cc/yYjNSCsF/Screenshot-2020-04-29-at-23-04-26-png-scaled.png)



Fixing white balance:
Mlv app
(https://i.postimg.cc/7hhfHqWP/Screenshot-2020-04-29-at-23-09-11-png-scaled.png)

Acr
(https://i.postimg.cc/0N7SF5LL/Screenshot-2020-04-29-at-23-09-24-png-scaled.png)



Pretty impressed how alike this is now in both apps. Maybe only the 0.26 tag needs added to the dng now and it´s perfect?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 29, 2020, 11:19:03 PM
Real quick (sorry for the squeezed ratio).

MLVApp
(https://i.postimg.cc/mZYRCgdq/MLVAPP.jpg)

Rawtherapee (which is most definitely rendered as sRGB)
(https://i.postimg.cc/kD3xHVTR/Raw-Therapee.jpg)

Darktable
(https://i.postimg.cc/MK1Q3pVV/Dark-Table.jpg)

both really close to Resolve... so the BaselineExposure exif tag would be needed for Windows (maybe Linux) but not Mac OS for some reason. Very strange.

edit: added MLVapp
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 29, 2020, 11:28:47 PM
Could you include mlv app in your latest post?
But resolve is also darker on mac so exposure compensation needed. Will try and include resolve as well tomorrow.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 30, 2020, 02:16:34 AM
If you wanna inlcude MLV App in compatrisons, set profile to sRGB and creative adjustments set to OFF (or you can keep them on and set dark strength slider to 0)

Quote from: Danne on April 29, 2020, 11:11:45 PM
Fixing white balance:
Mlv app
(https://i.postimg.cc/7hhfHqWP/Screenshot-2020-04-29-at-23-09-11-png-scaled.png)

Acr
(https://i.postimg.cc/0N7SF5LL/Screenshot-2020-04-29-at-23-09-24-png-scaled.png)


Pretty impressed how alike this is now in both apps. Maybe only the 0.26 tag needs added to the dng now and it´s perfect?

I'd expect things to be similar, same matrices as Adobe.

And why is everyone so bothered by exposure? It's linear, so a compensation doesn't matter if you do it by hand, or if it's embedded in the file.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on April 30, 2020, 10:03:14 AM
Quote from: Danne on April 29, 2020, 11:11:45 PM
Fixing white balance:
Mlv app
(https://i.postimg.cc/7hhfHqWP/Screenshot-2020-04-29-at-23-09-11-png-scaled.png)

Acr
(https://i.postimg.cc/0N7SF5LL/Screenshot-2020-04-29-at-23-09-24-png-scaled.png)

I was always interested when the image is similar looking why the tint is so different (ACR vs MLVApp)?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 30, 2020, 10:22:08 AM
Quote from: Dmytro_ua on April 30, 2020, 10:03:14 AM
I was always interested when the image is similar looking why the tint is so different (ACR vs MLVApp)?
Well, calibrating against acr among all creative color spaces, slider and so on in mlv app is probably not a quick fix ;).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 30, 2020, 11:29:23 AM
Quote from: Danne on April 30, 2020, 10:22:08 AM
Well, calibrating against acr among all creative color spaces, slider and so on in mlv app is probably not a quick fix ;).
Right. And I don't know why this should be necessary. We just know what we calculate, but we don't know what (exactly) Adobe or Resolve calculates... who knows about their cheating factors behind the GUI? Why should we calibrate to it? 8) If someone finds something wrong in our code and math, it is no problem to fix it.
Thanks for your examples - so far I am impressed how close we are. Thanks especially to Ilia for that nice processing!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 30, 2020, 12:08:33 PM
Quote from: ilia3101 on April 30, 2020, 02:16:34 AM
And why is everyone so bothered by exposure? It's linear, so a compensation doesn't matter if you do it by hand, or if it's embedded in the file.

I'm not sure if you are asking how we came to talk about it or what are the technical reasons for those tests so I'll quickly glance over both so you don't have to search over the previous posts:

Context: Another ml user and I were sharing power grades involving cdng and bmdfilm and we both wondered why we had to raise the exposure by +2. He was afraid that it would increase noise. Doing some tests (checking highlight retentions with various MLVApp profiles) I realized that cdng exposure was always darker no matter the color space/gamut compared to encoded videos. Comparing ursa mini footage, the most obvious thing to pop up was an exif tag missing so I wanted to point this out.

Why it is relevant to me? If I mix Prores and cndg footage, I would only be able to correct cdng exposure. That's something to keep in mind before starting a grade.

That said, I don't care about ACR/Lightroom at all as it is not part of my workflow (I don't even understand why it matters but hey, if someone is asking for a test I'll gladly comply and it confirmed the missing tag). I found a discrepancy between prores and cdng. I don't care about a fix in MLVApp (exiftool does the job anyway) but I'm not the one qualified to say if it's a bug or a feature (that is up to you and your community to decide). Sometime those little bugs are the tree that hides the forest sometimes it's not worth fixing it for technical reason, I honestly have no idea. It's just an exif tag for cdng export.

edit: added MLVapp screenshot in a previous post as requested.
Also there's a lot of misconceptions around bmdfilm (in Resolve's raw tab, Gen1 is actually not a transform) but I won't go into there as this is not directly relevant to MLVApp (but if the option is present in MLVApp, people should be able to use it and expect a decent result).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Kharak on April 30, 2020, 01:26:11 PM
If you import dng's in to Resolve, it all depends on your color management.

What your input is set to, what output you have. Log-c output can rarely handle a +2 exposure without introducing a lot of noise and clipping, bmdfilm has always been a very dark log. That is why I think its not a good idea to universally set the exposure to +2. But manually setting an exposure, sure, the more options the better.

For compressed output like h264, prores etc, I can see it can be a problem.

I personally adjust the exposure individually on all clips in resolve.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 30, 2020, 01:38:21 PM
Well that's why I'm comparing apples to apples: MLVApp prores sRGB/rec709 compared to MLVApp cdng in Resolve with sRGB/rec709 in the Raw tab (but also other color spaces/gamma).
If you raise the exposure by +1.25 or 1.26 (or fix it in the tag with exiftool), you get pretty much the same picture (there's still -15 tint difference for some reasons, that's not the point tho).

I don't really want to talk about bmdfilm but it's more complicated than that (the raw tab is different between legit blackmagic files and other cdng).

Also I'll stop answering if a comment is ignoring the previous posts and just assume that I did something wrong. No offense.

edit: no adjustements made (other than + 1.25 exposure and wb in the raw tab), pretone curve disabled, default DaVinci YRGB.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 30, 2020, 02:53:39 PM
Quote from: cmh on April 30, 2020, 01:38:21 PM
Also I'll stop answering if a comment is ignoring the previous posts and just assume that I did something wrong.
Atm nobody can tell where the issue really is. Nodoby assumes, you did something wrong.
DNG was invented by Adobe. So if it looks more or less correct there, but not in other Apps like Resolve, it is even harder to say that something in the DNG is wrong.
Someone tried converting a CR2 to DNG with ACR (if there is a program doing it right, then ACR) and opened this in Resolve and Lightroom? Is there also a difference visible?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 30, 2020, 03:16:16 PM
Quote from: masc on April 30, 2020, 02:53:39 PM
Atm nobody can tell where the issue really is. Nodoby assumes, you did something wrong.
Care to elaborate? Can you suggest a way to accurately do a comparison between the two?
edit: nvm, it doesn't matter.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 30, 2020, 04:36:38 PM
I think it's more like narrow down the exact issue now. Build a case and add clear comparisons of what the issue really is. Resolve, mlv app, metadata? A quick "fix" with exiftool might at first glance seem to be legit but might not be best practice when working other apps for instance. Done properly it's probably a good learning experience involved here.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 30, 2020, 05:22:44 PM
Well it's like you said Danne, if adobe's DNG is the standard, then passing out the Baseline exposure (+0.26) to the cinemadng exported file gets you closer to said standard.
I totally understand that Blackmagic's Resolve cinemadng rendition isn't the standard, they have added extensions to cinemadng since the ursa mini late 2014 for exemple.
I don't mind the dismissive answers but some comparisons with the exact same settings with another NLE like Premiere instead of ACR are still lacking.
I'm probably not the only one having that issue:
https://forum.blackmagicdesign.com/viewtopic.php?t=45045

In the meantime, I'll be comparing the advantages between cdng in Resolve to tonemapped prores from MLVApp in terms of highlight retention.
I'm still wondering if there's an advantage to get blackmagic's extensions to work on MLVApp's cdng. Something I'll check later.

edit: those blackmagic's extensions, it's just the UniqueCameraModel tag that matters, change it to any blackmagic model and you'll get the full raw tab in Resolve as you would with one of their camera.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 30, 2020, 05:34:39 PM
All numbers and statements above are still assumptions(didn't check your link).
Dismissive or not. Clear facts and robust figures and comparisons would help things forward. Right now, it's a pretty mess ;).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 30, 2020, 10:04:58 PM
Quote from: Dmytro_ua on April 30, 2020, 10:03:14 AM
I was always interested when the image is similar looking why the tint is so different (ACR vs MLVApp)?

I think this may be because MLV App uses the blackbody curve, not daylight curve (my laziness). But it doesn't matter much. Temperature and tint are just a sorta stupid coordinate system, and if you can put them in the right place you will get the right result.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 30, 2020, 10:19:43 PM
Quote from: cmh on April 30, 2020, 05:22:44 PM
I'm probably not the only one having that issue:
https://forum.blackmagicdesign.com/viewtopic.php?t=45045
Checked your link. Pretty much verifies the issue lies within resolve.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 30, 2020, 10:41:42 PM
Definitely. Even if there's a slight difference between Adobe Camera RAW and MLVApp, let's say the quarter exposure thing, Resolve is still a stop below.
edit: but the fact that some people here doesn't find that result with Resolve is pretty intriguing nonetheless...
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 30, 2020, 10:47:55 PM
@cmh thanks for the explanation

Quote from: cmh on April 30, 2020, 12:08:33 PM
Also there's a lot of misconceptions around bmdfilm (in Resolve's raw tab, Gen1 is actually not a transform) but I won't go into there as this is not directly relevant to MLVApp

Is Gen1 what's used by the original pocket and 2.5k cinema camera? And what does "not a trasnsform" mean in this context?

Quote from: cmh on April 30, 2020, 12:08:33 PM
but if the option is present in MLVApp, people should be able to use it and expect a decent result.

I agree it is an awful option in MLV App, as there is no technical information about BMDFilm anywhere, like expressions for the log curve, or matrices for the gamut (which seems to be different on every camera that shoots it).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 30, 2020, 11:13:15 PM
You're welcome.
You'll understand this better than me:
https://forum.blackmagicdesign.com/viewtopic.php?f=2&t=87576

CaptainHook at Blackmagic Design talking about Gen 1
QuoteBlackmagic Film" for Gen 1 is actually not a transform but passes out sensor space, or sensor RGB. You can basically think of it as "no colour science applied". So you would need a transform from that particular sensors response to the gamut of your choice which you'd need to get from that manufacturer. I believe Digital Bolex for example offered LUTs to transform from their sensor RGB to common gamuts like 709 via a LUT to be used in this workflow with DNGs in Resolve.

Now to he talks about Gen 4 which is a different beast:
QuoteBlackmagic Design Wide Gamut Gen 4 is a common gamut with defined primaries that all our cameras can use (with raw files in Resolve you can choose Gen 4 for all our raw capable cameras). So that is why you can use "Blackmagic Design Broadcast Film" or "Blackmagic Design Pocket 4K Film" colour space/gamut interchangeably as John Paines points out since both of those cameras shipped with Gen 4 - but ideally these options will be consolidated to "Blackmagic Design Wide Gamut Gen 4" for colour space/gamut throughout Resolve.

A member who tried to import Sony shots, Jacob Fenn at the end of the convo
QuoteMy issue ended up most likely being that the DNG's weren't relaying the ISO data needed for Resolve to properly debayer to Blackmagic's log curve. Therefore, when I'd apply what I thought was a normalizing transform via a CST node, the result was off because that CST node expects ISO 800. Thanks CaptainHook for help figuring that out.

The ISO data he's refering to isn't what he's talking about really, nor the "debayer to Blackmagic's log curve" he's babbling about. We can totally change the UniqueCameraModel tag for a blackmagic camera and access those ISO settings in the raw tab (spoiler: it's pretty useless for exposure but you can access any blackmagic Gamut/Color Space like the Blackmagic Design Wide Gamut Gen 4 for exemple).

It is probably the BaselineExposure exif tag, I compared with Ursa mini cdng and it can only be this one, but I think I already made this clear.

Quote from: ilia3101 on April 30, 2020, 10:47:55 PM
I agree it is an awful option in MLV App, as there is no technical information about BMDFilm anywhere, like expressions for the log curve, or matrices for the gamut (which seems to be different on every camera that shoots it).

I don't really want to give an opinion but if you don't deem it accurate or reliable well...

CaptainHook talking about clipping, just to hammer the previous argument that using bmdfilm (or any other gammut/colorspace; appart from linear that I can conceive for streamlined SFX workflow) in the raw tab is useless; using rec709 and a CST to your fav log as a first node is as good.
QuoteYes, DNGs in the metadata provide the matrices and AsShotNeutral tags needed to convert from XYZ to SensorRGB (and back) as supplied by the camera manufacturer so Resolve will be converting from SensorRGB -> XYZ -> Rec709. As for getting an XYZ output option I'm not part of the Resolve team so you would have better luck requesting that direct to them, but you could use CST to go from Rec709 primaries to any other gamut as the output from the RAW decode should not be clipped.

Then maybe I misunderstood.
Also, sorry for the non MLVApp related stuff.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on April 30, 2020, 11:35:59 PM
Also keep in mind that the bmdfilm profile from MLVApp is totally fine, you can keep it but this is not what people do, they export to cdng and use bmdfilm in the raw tab which gives horrible colors and worst than that, they sometimes use Gen 3 or Gen 4 to rec709 as a final CST node and start grading (and this is the reason why I don't want to talk about this and made my comparisons only with rec709, without tonemapping in Resolve or MLVApp, it's complicated enough).
Let me take a screenshot real quick.
Left is cdng with bmdfilm in the raw tab and a CST to bmdfilm Gen1 to rec709. Right is prores with MLVApp's bmdfilm and the same CST to bmdfilm Gen1 to rec709

This is ungraded, just the +1.25 exposure thing and a +15 tint for the cdng clips (this is common even across other colorspace/gamma settings given the appropriate CST ofc, in a sense that if I take the same screenshot with cdng with rec709 in the raw tab +1.25 exposure +15 tint vs prores with the MLVApp's rec709 profile or let's say cdng with linear in the raw tab +1.25 exposure +15 tint with a CST node to rec709 vs prores with the MLVApp's linear profile with a CST node to rec709 in Resolve, you wouldn't be able to tell where's the line, is that clear, I'm not sure).

MLVApp's bmdfilm profile is not a problem, if I compare a rec709 footage from mlvapp (no tonemapping just the plain rec709 profile) and compare it to a prores with the bmdfilm profile and apply a CST from Gen 1 to rec 709 in Resolve, it's close-ish (a little more vibrant and a slight gamma difference but that's to be expected, I guess you got the matrices made for another NLE than Resolve so the right one, maybe people on acescentral can help, idk).

edit: On an another subject, I also tested AsShotNeutral values that I derived from a CR2 I took with my camera on a cdng, thinking that it might be the cause for the +15 tint and just ended up with totally wrong white balance value in Resolve's raw tab, so that's not that but you all probably knew.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: reddeercity on May 01, 2020, 02:10:43 AM
No problems here , on x64 win7pro ,
take this with a gain of salt , not knowing if you know about this.
Looking like a color space (gamma curve) problem
e.g. 1.8-2.6
https://www.eizo.be/en/knowledge/monitor-expertise/gamma-values-of-lcd-monitors/
Quote
Gamma characteristics are represented by the equation y = xγ.
At the ideal gamma value of 1.0, y = x; but since each monitor has its own unique gamma characteristics (gamma values), y generally doesn't equal x.
The above graph depicts a curve adjusted to the standard Windows gamma value of 2.2. The standard gamma value for the Mac OS is 1.8.
(https://i.ibb.co/ZcX10Sy/idealer-gamma-wert-vs-windows-standard-vs-macos-standard-66d.jpg) (https://imgbb.com/)
my 2cents  :D
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 01, 2020, 06:49:07 AM
Quote from: cmh on April 30, 2020, 11:35:59 PM
edit: On an another subject, I also tested AsShotNeutral values that I derived from a CR2 I took with my camera on a cdng, thinking that it might be the cause for the +15 tint and just ended up with totally wrong white balance value in Resolve's raw tab, so that's not that but you all probably knew.
AsShotNeutral as well as Baseline Exposure tag are simply information about white balance and exposure. Since it´s raw you can simply set them both in your nle. They will do no magic if changed with exiftool.


Another take on this "issue". Let´s compare a dng(raw) from all three nle.

First Davinci resolve(notice the lack of applied tone curve?) Actually a good thing letting the user decide manually or by setting a tab option:
(https://i.postimg.cc/x81cXsqw/Screenshot-2020-05-01-at-06-33-25-png-scaled.png)

Adobe camera raw. Exposure seems the same but tone curve added under the hood
(https://i.postimg.cc/BQtjswrD/Screenshot-2020-05-01-at-06-33-35-png-scaled.png)

Mlv App Tangent - rec709. Most similar look I could get exposure wise and tone curve wise. Wb will obviously differ slightly. It´s off anyway
(https://i.postimg.cc/26mqDjY8/Screenshot-2020-05-01-at-06-35-13-png-scaled.png)

Back to resolve. How about that tone curve. Well look. You can apply it here as well:
(https://i.postimg.cc/Dyj4VKm1/Screenshot-2020-05-01-at-06-46-21-png-500px.png)

Now check resolve output again. Almost identical to acr and mlv app. Actually resolve and mlv app match better in wb now.
(https://i.postimg.cc/Y0dLR5J2/Screenshot-2020-05-01-at-06-37-55-png-scaled.png)

Conclusion:
Use Tangent - rec709 in mlv app for proxies. In resolve apply the tone curve per above.


Edit: What is this "Tangent" Tonemapping Function anyway? Never heard of it but it seems spot on here. Checking code:
    { /* PROFILE_FILM */
        .allow_creative_adjustments = 1,
        .tonemap_function = TONEMAP_Tangent,
        .gamma_power = 3.465,
        .colour_gamut = GAMUT_Rec709
    },
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on May 01, 2020, 07:54:55 AM
Unfortunately I don't have any other monitor to test and it's a cheap 6 bit + frc ( probably like all of us who did those tests). There's no color profile used on windows.


@danne
For the tonemapping settings as I stated, I tested everything in rec709 for consistency.
Rec709 profile on MlVApp without creative adjustment, so no tonemapping.
Rec 709 in resolved raw tab with no Luma tonemapping of a CST, precurve tone disabled.

But yeah, apparently ACR is doing things under the hood.

Edit: my bad reddeercity you were talking about the gamma curve of the OS, yeah worth investigating. Sorry I literally just woke up.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 01, 2020, 08:01:10 AM
@cmh thanks again for all the interesting info. Confirms what I thought of the original BMPCC and BMCC, and why everyone seemed to get awful results with them.

Also good to know about Gen4 using same primaries on all cameras (still annoying they don't seem to tell use what they are, though I haven't checked onthis subject for a while).

I wonder what Gen2 and Gen3 are like...

Quote from: cmh on April 30, 2020, 11:13:15 PM
Also, sorry for the non MLVApp related stuff.

Absolutely fine, it is very related and useful I think, as we have "BMDFilm"


I can't read through everything you sent yet, will have a more detailed look in a few hours.



@Danne Tangent tonemap was just 2017 me realising that arctan(x)/(pi/2) worked for highlight roll off :)

(https://2.bp.blogspot.com/-4a53r5PBP3A/UKes73c-ClI/AAAAAAAAAGo/EflieeoYXw0/s1600/inverse+tan+function+.gif)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 01, 2020, 08:05:35 AM
Quote from: cmh on May 01, 2020, 07:54:55 AM
@danne
For the tonemapping settings as I stated, I tested everything in rec709 for consistency.
Rec709 profile on MlVApp without creative adjustment, so no tonemapping.
Rec 709 in resolved raw tab with no Luma tonemapping of a CST, precurve tone disabled.
It´s all rec709 in resolve as well. If you refer to mlv app you cannot expect coherent results without tweaking. There is nothing wrong with baseline exposure. The problem is related to interpretations coming from mlv app. The fix is not modifiying metadata. It´s to tweak and match input/output in mlv app.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on May 01, 2020, 08:08:25 AM
@danne I don't want to be a contrarian but if you don't change anything appart from using the rec709 profile on MLVApp and export to prores as is. You'll get an accurate rec709 conform footage to compare to (not esthetically pleasing sure, that's besides the point).
Edit : on phone: expect some typos.

Same goes for the srbg profile. super accurate, perfectly conform. Ilia should confirm my claims ofc.

Edit: just saying, the pretone curve thing in Resolve is there for historical reasons, that was used in old resolve by default but it will clip your footage like any pretone curve. There's also other mapping ofx in resolve, like in color space transform for example.

Fun fact (maybe) You can also download filmic aka tangent, Reinhard or Corona's tonemaping functions for Resolve's Fusion tab/og Fusion, but you better transform in linear before, same algorithm as MlVApp but tweakable.I should stop there, since it's irrelevant.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on May 01, 2020, 08:25:39 AM
I feel like if people would really put an effort into what I suggested in the first place, we might understand each others. MlVApp's prores footage with only the rec709 profile applied vs cdng (not an extracted frame) in resolve with rec709 color space/gamma in the raw tab. Every other comparisons are muddying the water. I didn't made any other claim, ACR was only useful to understand the dng tag. If we can all agree on this part then we could move on.

Edit: yes I understand Adobe created the dng format from Tiff, yadi yada, but it's a spec (like the headers, the legal exif tags etc) not the rendition. As controversial as it sounds, It really is a weird metric when it comes to how it should look in MLVApp (well with the inclusion of raw2mlv it makes more sense, I'll reckon). I'm eager to see what would be the result in Premiere.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 01, 2020, 08:40:56 AM
The mud in the water is modifying the dng starting out in resolve. You're in a domain fixing a problem starting much further down in the chain.
Well. Only interest to myself is that we don't modify mlv app adding unnecessary functions based on vague error seeking.
I'm out for now.
My latest tests are all done with a cdng frame by the way.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on May 01, 2020, 09:20:25 AM
Danne there's nothing to be upset about. If people would have find the same results (which is not the case because it seems really hard to reproduce.. I guess) and said well nice finding but we won't do anything about it... Then a-fucking-men, it is absolutely a reasonable answer. Nobody wants MLVApp to change, me included. At least we would have not lost our time on this. Then if my post have been perceived as rude or condescending it was not my intention. It's just a bug report that has to be confirmed type of thing.
Edit: I'll stick around just in case people want some clarifications. PM is also available btw.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 01, 2020, 11:24:47 AM
Hard to follow you now but I don't see any personal projections on my side. Quite the opposite from what you might think I would gladly welcome any refinements to Mlv app. I still don't see anything convincing in that direction so I would hope you'd take on the challenge and prove me wrong. So let's lift your tests to the next level or just leave subject alone. Agreed?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on May 01, 2020, 11:47:57 AM
Sure, what are you proposing ?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 01, 2020, 12:19:07 PM
Busy here but my thoughts. Mlv app rec709 without tonemap tweaks could be wrong. How to test this? Well. After effects can output prores. If you manage to export somewhat similar rec709 to what you do in mlv app you can compare these two prores files.
On a sidenote. What do you believe is the real issue here? Still in to baseline metadata?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on May 01, 2020, 12:36:32 PM
Haha. I'm sorry downloading after effects trial version requires me to enter my credit card number, nope.

The issue? We probably already found it partly because of you. There's a +0.25 exposure difference between ACR and MLVApp because the exif tag sn't there anymore but it's barely noticeable if you use tonemaping and the other +1 exposure that has to be added is a Resolve thing  (maybe only a Resolve on windows thing, maybe just a windows thing but none of you devs have Windows installed, which makes bug reports a bit complicated tbh). Maybe I need to dig in Blackmagic's forum a little harder.

I think all of us went in great length and have been charitable to each others. I'm totally fine with leaving this topic unless someone needs more explainations or someone else come up this same sort of issue (shoot me a PM if needed so I get mailed).

Edit: but comparing with after effects or premiere is a great idea. Baselight would probably be even better since it's the Hollywood colorists heavyweight software. Nuke, Avid (I might check on those later if a trial is available).

Edit again; did I ever told you guys that Windows is free of charge, the only downside if you don't register it is that you can't customize your desktop.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 01, 2020, 02:01:19 PM
Quote from: cmh on May 01, 2020, 12:36:32 PM
The issue? We probably already found it partly because of you. There's a +25 exposure difference between ACR and MLVApp because the exif tag sn't there anymore but it's barely noticeable if you use tonemaping and the other +1 exposure that has to be added is a Resolve thing  (maybe only a Resolve on windows thing, maybe just a windows thing but none of you devs have Windows installed, which makes bug reports a bit complicated tbh). Maybe I need to dig in Blackmagic's forum a little harder.
Too bad. Hopefully you reconsider finishing what you started and getting the pieces together. Until then. Nothing changes.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on May 01, 2020, 05:58:40 PM
Quote from: cmh on May 01, 2020, 12:36:32 PM
Edit again; did I ever told you guys that Windows is free of charge, the only downside if you don't register it is that you can't customize your desktop.
Yep. Direct download links here: https://tb.rg-adguard.net/public.php
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: levisfaustus on May 01, 2020, 10:19:34 PM
Future request, if possible: make auto Darkframe Subtraction from the last frames of the Clip (The easiest way to make black frames is to record a video with the lens cap on the camera on the end of clip). Because Darkframes are every time different - it will save a lot of time. Thank you very much for your work!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 03, 2020, 01:55:40 PM
Testing dualiso once more. 10bit on my eosm anamorphic(1x3 mode)

Test files(2 frames):
https://bitbucket.org/Dannephoto/magic-lantern/downloads/M03-1358dualisoflicker.MLV

Full MLV file here:
https://bitbucket.org/Dannephoto/magic-lantern/downloads/M03-1358.MLV

No matter what I do I get a slight variation to brightness. The change is subtle but when previewing this in a longer file It shows as flicker. I know the issue is not of high priority but maybe @bouncyball can tell what is going on with post processing? Is cr2hdr processing differently on each file? Depending on what? Borders, brightness?

One goal here would be to try and get both frames exactly matched. Probably should fix the issue?

EDIT: Testing the same file in mlvfs and brightness(white level) is completely wihtout flicker, hmm
EDIT 2: mlvfs also gives flickery ouput...

Edit: tested 12bit, already flicker free. Stay off 10bit on eosm while doing dualiso.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Levas on May 03, 2020, 03:11:54 PM
Downloaded your sample MLV.
And processed the dual-iso files with MLVapp to dng's.
I can see a exposure change from frame 20 to 21. Frame 0 to 20 is the same and frame 21 to 26 is slightly brighter.

But when I don't do dual-iso processing and just export to dng's, the exposure change is not there.
So the source/raw dual-iso files are ok  ???

could it be that it is caused by the light in the back coming from the light bulb.
Maybe test it again outside, without artificial light sources in the frame ?

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Levas on May 03, 2020, 03:16:24 PM
BTW I just did try the 10bit function in crop_rec on the 6D with dual iso and used MLVapp to process the dual-iso to dng's and I can't see any exposure/hue shifts between frames.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 03, 2020, 04:21:03 PM
Dual iso has always been somewhat problematic. Maybe you're on to something here. Why it flickers for me and not for you is a riddle.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: cmh on May 03, 2020, 07:43:57 PM
I def get the flickering on both cdng and prores 422 HQ.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 03, 2020, 08:05:16 PM
Yea, I tested three files but enabled 12bit and worked without flicker. Anamorphic mode and dualiso works so good so probably should do some more tests. Also gonna fix the line static issue due to irregular a-timer. At least for the anamorphic modes.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ngemu on May 12, 2020, 01:13:00 AM
I was wondering if a custom field could be entered so I can choose the video stretch instead of the preselects like 1.33x, 1.55x, etc.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 12, 2020, 04:47:30 AM
Sorry guys, almost surely this has been yet discussed before, but I can't find... My question is about Gamma in BMD Film preset.
I loaded my MLVs into MLV-App and I set BMD Film preset to obtain a really flat image. In that preset, default Gamma is 1.0 but it seems to me too dark. I tried 2.4 but it seems too high key. Perhaps 2.0 or maximum 2.2 seems a good middle.
I admit I have not a clear idea: which should be the Gamma value?
Thanks
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ZEEK on May 12, 2020, 06:31:53 AM
Try setting gamma to 3.15.
Bring down exposure a little, then increase dark strength to get the blacks back.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 12, 2020, 10:20:23 AM
Quote from: ZEEK on May 12, 2020, 06:31:53 AM
Try setting gamma to 3.15.
Bring down exposure a little, then increase dark strength to get the blacks back.
Thank you. Is there a sort of technical reason to maintain gamma so high, or it's just to push the histogram to the right?
I try to elaborate: my purpose is to obtain a flat image out of MLV App for working after in Davinci on exposure and blacks and others... So my purpose is NOT to obtain a "final" result directly out of MLV App.
In this particular case I'm doing a bunch of prores proxies from some MLV files, to work with in Davinci. I'll use these proxies for a preliminary editing in Davinci, then I'll replace them with the real c-DNGs instead.
Both proxies and c-DNGs will be produced by MLV App.

So my question is: should I set MLV App with BMD Film and gamma 3.15, for both prores proxies AND the future c-DNGs? Or it's important to set gamma only for prores proxies (since in Davinci it's also possible to set c-DNGs with BMD Film for obtaining flatting the image)?

And: If I convert in MLV App my MLVs to c-DNGs without changing anything, and then I set BMD Film in Davinci, I'll obtain a sort-of-flat image that is LOT LESS flat then the prores proxies produced by MLV App set with BMD Film and gamma 3.15. Is it because I HAVE to set MLV App to BMD Film gamma 3.15 ALSO for converting to c-DNGs?

Thanks
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ZEEK on May 12, 2020, 12:23:02 PM
No technical reason for this, pretty much depends on how you expose in-camera. Exposing to the right helps along with zebras.
Whatever you touch in MLV App will not affect the DNG Files as these come straight from the sensor, so no point editing in MLV App if exporting as DNG. Prores, on the other hand, would benefit from grading within MLV App and then doing the finishing touches in another editing system.
With the DNG Files in Davinci, you could possibly tweak the LOG Profiles in the "color management" section.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 13, 2020, 02:21:45 AM
Thank you so much zeek! So, if an high gamma value (in MLV App for Prores) is not "technical" but a "benefit", which is the limit? I can image that the limit is "just before cutting anything in the histogram to the right", is that right? So, the idea is to push the histogram as to-the-right as possible, in order to enlarge the room of color-grading possibilities (and reducing teh noise).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ZEEK on May 13, 2020, 04:43:06 AM
Yes pretty much. Use Exposure value with the waveform/histogram. Expose to the right should be about 0.1 EV but use zebras @100% as well just to confirm you're not clipping stuff in the corners of the frame as the exposure value seems to measure things in the center. EV 0.5-0.1 is a good range. 14 bit/lossless is a good selection.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on May 14, 2020, 07:29:10 PM
Quote from: ZEEK on May 12, 2020, 12:23:02 PM

Whatever you touch in MLV App will not affect the DNG Files as these come straight from the sensor, so no point editing in MLV App if exporting as DNG.


@ZEEK does the "RAW Correction" panel affect exported DNG's? No panels affect the DNGS at all?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 14, 2020, 07:39:41 PM
Quote from: Milk and Coffee on May 14, 2020, 07:29:10 PM
@ZEEK does the "RAW Correction" panel affect exported DNG's? No panels affect the DNGS at all?
Yes it does. The other panels don't.
https://github.com/ilia3101/MLV-App/wiki#export-settings
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on May 15, 2020, 06:07:51 AM
Good to know! Thanks Zeek!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Macke1 on May 16, 2020, 07:54:50 PM
i have tried to record a time-lapse today, 3 fps and mlv raw movie, when I import it to mlv app the movie is shifting from frame 1-2-1-3-1-4-1-5 and so on. I can't post movie in the forum to show you (don't know how)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Macke1 on May 16, 2020, 08:21:16 PM
https://youtu.be/2vdMywoZ9oY
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 16, 2020, 08:40:35 PM
Could you please upload a shortend version of this MLV for analysis? Maybe 10 frames or so? The frame counter counts the frames up, so I would think the MLV itself has a problem. Have you tried to export to DNG via mlv_dump or MLVFS?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Macke1 on May 16, 2020, 10:16:24 PM
how do I do that?' it works perfect without mlv raw
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 16, 2020, 10:24:11 PM
Set CutIn & CutOut to 1 and e.g. 10, export as MLV.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Macke1 on May 17, 2020, 12:05:06 PM
https://youtu.be/s6Z9QWf0tLc
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Macke1 on May 17, 2020, 01:05:55 PM
https://drive.google.com/open?id=17Cwk49UzOonwycr1rL9KVAFMAnEfbxAN
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 17, 2020, 01:51:47 PM
Ah this must be a magic lantern bug. I had this on my 5D2 a few years ago, I was also trying to shoot a timelapse at low fps in video mode. Why? I don't know. Much better to shoot timelapse with intervalometer.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on May 17, 2020, 06:51:06 PM
But in video mode you can use 360-degree shutter speed, and this will give you a very smooth and good-looking timelapse. With intervalometer, there is a time when the frame is being saved, and the camera basically waits, so it is not perfect.. at least I think so.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: heder on May 17, 2020, 07:12:58 PM
Hi
Question to the MLVApp@devs. Im working on mlv_lite for 40d, but in currently stuck. The frame order in my files are incorrect, this can happen to all cameras, but how is MLVApp Sorting the frames, by timestamp ?.i use mlv_ dump to covert the mlv so I can load the files into MLVApp, but no matter what i do, the frame order is incorrect so i suspect i bug in my source.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 17, 2020, 09:45:08 PM
@Macke1: thanks for the upload. I checked in MLVApp and in MLVFS (which uses mlv_dump):
both apps show the identical frames, so it is very sure there was something wrong when recording in camera. This could be a 5D2 ML bug, as Ilia also told.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 17, 2020, 09:52:14 PM
Quote from: heder on May 17, 2020, 07:12:58 PM
Hi
Question to the MLVApp@devs. Im working on mlv_lite for 40d, but in currently stuck. The frame order in my files are incorrect, this can happen to all cameras, but how is MLVApp Sorting the frames, by timestamp ?.i use mlv_ dump to covert the mlv so I can load the files into MLVApp, but no matter what i do, the frame order is incorrect so i suspect i bug in my source.
I'll try to answer and hope the info is correct... @bouncyball could correct me, because he implemented it to MLVApp.
I think MLVApp uses the variable timestamp in struct mlv_vers_hdr_t to sort the frames. See video_mlv.c line 1771 and following, and 1834.
BTW: great work @heder!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 24, 2020, 04:08:28 AM
Hi everybody and MANY congras to the author of this wonderful piece of software. MLV App is definitively in my workflow.
My question: I work on RAW files from 5D3, and I'm using MLV App to obtain Prores Proxy files to make a preliminary/sketchy grade in Davinci. I tried 3 Profiles: Alexa, Cineon and BMDfilm. My first impression is that with a bit of patience, you can achieve the same result with the 3 profiles. But since I'd convert a big bunch of RAWs with a single profile – for convenience – I'm try to understand which is the "good-enough-for-every-shot" profile that is possibly also a "less-nodes-for-a-good-grade" profile!
In short, my question is: which profile do you recommend (to be graded after in Davinci)?
I try to elaborate (forgive the non-technical terms):
A) Cineon seems to compress the histogram slightly pushing it towards the right (that should be good because it "saves" informations in a no-noise area);
B) Alexa does a similar thing but toward the left (theoretically not good because it's a noisy area, right?);
C) BMDfilm instead stretches the histogram with blacks starting on the very left.
It seems to me that BMD gives the fastest "couple-of-clics" good result (after Davinci grading) because of its contrasty histogram and "filmy" tone, BUT (for my taste) it's more difficult to obtain a less-contrasted look, and grass-greens seem to be flattened into a single unnatural color (even in Davinci...)
For my taste, Cineon and Alexa logs give the most pleasant results (always after Davinci grading): Alexa is faster for grading dark shots without great contrast (where Cineon adds always a bit of "halo"), whilst Cineon wins hands down in highly contrasted shots, also thanks to a creamy/screeny/gaussian rendition of lights when near to clipping.
For these first-and-rapid impressions, I'd decide go for Cineon for converting all my shots into proxies, but I'd like to know what you think about. Any advice?
Thanks a lot.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on May 24, 2020, 04:57:25 AM
I just use Reinhardt with AP1 matrix. Increase saturation and play with curves. This is the fastest way of processing.
I used to use Log-C, but skin midtones gets trashed for some reason.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 24, 2020, 05:21:48 AM
Quote from: Luther on May 24, 2020, 04:57:25 AM
I just use Reinhardt with AP1 matrix. Increase saturation and play with curves. This is the fastest way of processing.
I used to use Log-C, but skin midtones gets trashed for some reason.
Thanks a lot, Luther. But I understand that your advice refers to grading directly into MLV App, right? My bad: I didn't specify correctly my former question: actually my question is «Which profile do you recommend (to be graded after in Davinci)?» (Now I correct the question also in my former message.)
i.e. my idea is to find which log profile outputs the best "log-proxy-for-room-grading-in-davinci-with-few-nodes" file (so that once I'll finish grading in prores, I should be able to replace the proxies with the DNGs having the possibility of obtaining a very similar – or even the same – result.)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 24, 2020, 05:52:26 AM
One way of thinking is to closely match the rec709 starting point in resolve and the do all further grading in resolve. Hard to match logs and color spaces between these programs.
See Reply #4144
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on May 24, 2020, 06:15:40 AM
Quote from: adrjork on May 24, 2020, 05:21:48 AM
Which profile do you recommend (to be graded after in Davinci)?
You're better off just converting to CDNG and processing directly on Resolve using ACES.
If you don't want to do that, I'd go with Alexa Log-C.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 24, 2020, 07:19:26 AM
Thanks Danne and Luther!
Quote from: Luther on May 24, 2020, 06:15:40 AM
I'd go with Alexa Log-C.
Ah, that's interesting: is yours a genuine preference, or is there some reason to prefer Alexa Log over Cineon Log (with Alexa gamut)?

@Danne: Thanks again for your replay. Your advice is perfect, but actually I don't try to match the "proxy-grade" with the following "DNG-grade", I simply (and perhaps naively) try to have a "good-to-grade" proxy that gives me as room as possible to be graded in Davinci, and at the same time is as easy as possible to be graded. :) Rec.709 doesn't give to me the same room as a log profile. (Obviously, once I'll replace the proxies with the DNGs I'll have to remake all the grading... But I can image that DNGs will give me "at least" the same room as the proxies – naturally a much more large room.)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 24, 2020, 07:41:40 AM
I would grade the proxies directly in resolve. Rec709 - to whatever in resolve using nodes. In the end attach the full dng stream.
On a sidenote I don't see why you won't export proxies directly from resolve if you still gonna use dng files in the end. Mixing programs will be far from correct imo.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 24, 2020, 08:34:58 AM
Quote from: Danne on May 24, 2020, 07:41:40 AMI would grade the proxies directly in resolve. Rec709 - to whatever in resolve using nodes.
Thanks as always, Danne.
Quote from: Danne on May 24, 2020, 07:41:40 AMOn a sidenote I don't see why you won't export proxies directly from resolve if you still gonna use dng files in the end. Mixing programs will be far from correct imo.
You are right, Danne, it's not a strictly correct workflow. The reason is that MLVs are stored in an old external RAID that for "safety" reason I'd like to keep turned off during the long time of the proxy-editing (so, no MLVFS). If I had enought space I would have converted directly MLVs into DNGs, but I haven't (I'll have only the space to convert into DNGs those MLVs I'll verify – with the proxies – they will be actually used in the final editing). So the only thing I can do now is converting all the MLVs into small Prores Proxies, then trying an editing "hypothesis", then re-converting the fewer corresponding shots from MLVs to DNGs to remake both the editing and the grading.
For me, at the moment, it's important that the Prores Proxies give me simply an "idea" of the DNG-grading, not a strict method for replacing the proxies with the DNGs. :)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 24, 2020, 08:40:46 AM
Well, good luck solving your issues. Whatever proxy export chosen you need to match starting point as close as possible in resolve, color space, gamma etc.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 24, 2020, 05:44:51 PM
Quote from: Danne on May 24, 2020, 08:40:46 AM
Well, good luck solving your issues.
Psychiatrically speaking? :D Ahahah...
Quote from: Danne on May 24, 2020, 08:40:46 AMWhatever proxy export chosen you need to match starting point as close as possible in resolve, color space, gamma etc.
Perfect! I'll do so. Thanks a lot.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 25, 2020, 07:38:10 AM
Some limit in number of MLVs uploadable into MLV-App?
That's what happened to me: I tried to upload about 400 MLVs (about 3.3 TB) into a single MLV App. The App uploads correctly all the MLVs, then I select all them and clic the export button (prores code). The exporting bar appears saying something like "in preparation", and I can see the Cut in/out panel changing rapidly the "out" number (because the App is rapidly reading the MLVs durations, clip by clip, as expected). After passing about 200 MLVs, suddenly the App slows down dramatically (i.e. the Cut out numbers changes, but VERY slowly), the computer's processors seem not working anymore (iStat menus), instead the external RAID (with the MLVs) is still noisy but the App seems dead.
If I open another parallel instance of MLV-App, and I upload a single MLV to be converted (just for test), this parallel instance works without problems.
My question: is it possible that a single MLV-App has a limit of 200 uploadable MLVs?
Thanks.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 25, 2020, 08:16:55 AM
@adrjork: yes there is a limit, but it should be 2^31 or something, so much more than 200. Myself I have often projects with 500+ MLV files.
When you start to export, MLVApp has to open each MLV file to get the number of frames and sum them up, just to make ETR working. If you enable MAPP files, and created them before, this will be very fast, if not then it will be very slow. You could check "Create MAPP files" and trigger the acion "Create all MAPP files now" from the menu before exporting. Have you activated each file once before exporting (just to see all is fine)?
Anyway: the app should never stop working. You are on OSX?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 25, 2020, 08:53:35 AM
Hi masc, thanks for your kind reply.
I'm on OSX.
I have a total of 3400 mlvs (much less than 2^31). My initial idea was to open 10 instances of MLV-App, each one with 340 loaded mlvs, and let all the 10 instances working in parallel. Up to now, it works only if the total amount of the MLVs is 200 (i.e. 200 for a single running App, or a total of 200 distributed between the parallel running Apps).
Up to now I never used MAPP, but now I'll test it.
I've just tried to create MAPP files for all the mlvs uploaded: I uploaded 348 mlvs in a single App, then "Create all MAPP...": all went rapidly until 200th/250th mlv, then the App slowed down dramatically...
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 25, 2020, 09:26:32 AM
Happens the same, if you remove the first 200 from the project? Is it slow then also for the first mlvs in the session? Or also starting from ~200th mlv? I'll try to reproduce this evening.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 25, 2020, 09:53:03 AM
Quote from: masc on May 25, 2020, 09:26:32 AM
Happens the same, if you remove the first 200 from the project?
Yes.
Quote from: masc on May 25, 2020, 09:26:32 AM
Is it slow then also for the first mlvs in the session? Or also starting from ~200th mlv? I'll try to reproduce this evening.
Only from ~200th mlv, both in single App running and in parallel Apps scenarios: if I have 2 Apps running in parallel, and – let say – I have 200 mlvs in the first App, only the second App slows down (almost still).
Quote from: masc on May 25, 2020, 09:26:32 AM
I'll try to reproduce this evening.
Many many thanks, masc!

P.S. I tried to create MAPPs loading packs of 200 mlvs. This trick helped for the first 400/450 mlvs, after that – even quitting and restarting the App – the following packs of 200 mlvs slowed down a lot. Anyway, while doing the MAPPs, I noticed that CPUs work non-continuously: i.e. Activity Monitor says that at one moment the CPUs for MLVApp work at 200%, but the following moment the CPUs for MLVApp are at 4% (like if they have intervals of still).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 25, 2020, 03:03:12 PM
The time for parsing the information of a clip relates to the clip length, and the speed of your disk. CPU usage will partially be very low for that. After MAPP files are created, it should always be very fast.
Running apps in parallel is only recommended if you have many cores which are far away from beeing used 100% (all cores in sum, MLVApp+FFMPEG) (if used below 50% it makes sense). Otherwise you will only slow down the process because the apps fight against each other.

Tried an import of 352 files and had a half eye on it preparing the export. I could not recognize any difference between the first and the last clips. On my 2010 MBP (OSX 10.9.5) + external USB2.0 HDD each clip took around 1-2sec (without MAPP). MAPP creation also took around 1-2sec per clip (clip lengths 5-20sec, FHD).

Edit: tried also on a newer system (OSX 10.13 + USB3.0): more or less the same behaviour (only a very little bit faster).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on May 25, 2020, 05:25:27 PM
i know that there are voices in opposition to using card spanning, but for those of us who love using it, would you consider adding support to mlvapp so we can read directly from the two cards and not have to copy the files into a single directory?  this may not seem like much of an issue, but it really gets in the way of production!

please and thank you!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 25, 2020, 05:57:42 PM
That would be a helpful feature... shouldn't be too difficult to implement -  Just check the DCIM/*EOS*/ folder on every other external disk for any .M00 files with the same name

@masc Does Qt offer a cross platform way of doing this?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 25, 2020, 07:47:04 PM
I did not find a feature like this in Qt.
The code for spanning file search should be in the C part. So I would think to create a string variable for a "spanning file location" or something, which can be filled by the user from the edit dock (individually for each clip) or from a menu (global for all clips). What's the use case? Global?
If the existing code doesn't find a spanning file, it could search at this configured 2nd place.
But even here: does this work if we have 2 times the "same" drive, one with the MLV and one with the m00? How does the system remember which drive is which, if both have the same drive name (Unix)?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 25, 2020, 08:18:24 PM
Actually maybe you're right, could be done in C part!

I didn't even realise. Will see what I can do later.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 25, 2020, 08:45:14 PM
@70MM13
Are you using the spanning feature with sd_uhs module on?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 25, 2020, 09:02:53 PM
@Ilia: see static FILE **load_all_chunks(char *base_filename, int *entries) in video_mlv.c
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on May 25, 2020, 09:11:57 PM
@danne,
yes, i am!
it is wonderful to record at high resolutions for long durations!  it works beautifully here.

see my candlelight music video for a great example.  one continuous take at 3072 14 bits lossless.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 25, 2020, 09:16:11 PM
Eould you ssy it's reliable? Your sd card is still holding up?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on May 25, 2020, 09:45:19 PM
i am very pleased with it, and the only drawback i have experienced is the one i am asking for help with here...  i get lazy sometimes, especially with the zen episodes where i am more concerned with what i'm talking about versus visuals, and i wind up shooting at 1920 3*3 because it is so convenient.  but there's no question, using the card spanning and overclock is wonderful and rock solid.

i will be filming a new episode today/tomorrow using it.  due to my cellphone internet, i will be uploading it to youtube downsampled to 1080p, but it still looks much better than shooting at that resolution!

i'm using a sandisk extreme pro 170 MB/s sd card and KB 1066x CF

no problems with the cards after many sessions.  i'll share the link to the upcoming episode in the videos section once it's up...

it would be quite a treat to convert the mlvs to cdng straight from the 2 cards in mlvapp ;)

edit: i did just remember one "issue" i have with the overclock:  early on, i found that sometimes there were some issues with recording failures (immediate) if starting the camera with overclock ON.  it is now muscle memory for me to turn it off before shutting down the camera.  i don't know if it is camera-centric, but it may be a good idea to automagically turn it off in code at shutdown, or have it always OFF by default at startup (if it ever becomes an official function - which i vote for!)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 25, 2020, 10:31:06 PM
Quote from: masc on May 25, 2020, 03:03:12 PMRunning apps in parallel is only recommended if you have many cores which are far away from beeing used 100%
I'm using an hackintosh with an i7-extreme with 10-physical cores. I've tested multiple parallel Apps running and I've noticed the following:
1 App: T(ime);
4 Apps: T/2 (roughly);
8 Apps: T/2.66;
10 Apps: around T/2.88.
In a scenario with 33 TB to be converted, even the little difference of 2.88 over 2.66 is welcome (because means less hours).
Quote from: masc on May 25, 2020, 03:03:12 PMThe time for parsing the information of a clip relates to the clip length, and the speed of your disk.
I'd say that could be the real bottleneck, since all my mlvs are stored into an 8-HDDs 48TB RAID6 thunderb.2, that is only "relatively" fast, but surely not fast as even a single SSD. But in your test you are using a USB2 HDD that should be pretty slower than my RAID, so the mistery of my slowness remains unsolved...
Quote from: masc on May 25, 2020, 03:03:12 PMOn my 2010 MBP (OSX 10.9.5) + external USB2.0 HDD each clip took around 1-2sec (without MAPP). MAPP creation also took around 1-2sec per clip (clip lengths 5-20sec, FHD).
Perhaps the answer to the mistery is the clips' duration: my clips (around 3400 for this last single project) are from a minimum of 1 minute to a max. of 40 minutes per-clip.
I've noticed that if I drag up to 220 "unknown" clips into MLV-App it can take 1'45" to start seeing the clips added into the Session panel. Then, opening a single clip can take 10 seconds (with MAPP it's only slightly faster). Creating a MAPP can take from 1" to 20" (for every single clip) but creating MAPPs seems to be the ONLY solution for me: in fact, without MAPPs, I confirm that I can upload up to a max of 220 clips (also if distributed into various parallel instances of MLV-App running together), i.e. I "could" upload more clips, but once the conversion starts the App recaps all the clips before the conversion, then from the 221th clip the time of recap increases monstrously (the App "seems" crashed). Instead, WITH the MAPPs, I can upload many more clips without "recap stoppage" (of course, the recap time of 1-10 seconds per clip remains, but at least there isn't a stoppage anymore).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on May 26, 2020, 12:32:43 AM
@adrjork you have a shitton of data. MLVApp is not really suited for that kind of thing (CPU-only processing). I'd say it's time for you to invest in something like Transkoder (http://www.colorfront.com/?page=SOFTWARE&spage=Transkoder).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 26, 2020, 01:02:13 AM
How will that work with mlv files?
I agree on mlv structure and indexing not being suited for that kind of heavy batch work. Too bad indexing can't be skipped.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 26, 2020, 01:45:58 AM
Quote from: Luther on May 26, 2020, 12:32:43 AM
I'd say it's time for you to invest in something like Transkoder (http://www.colorfront.com/?page=SOFTWARE&spage=Transkoder).
Hi Luther, thanks for the reply. It seems that Transkoder doesn't handle MLV codec. I've seen an mlv-to-mov software for Windows that – they say – works on GPU (here (https://www.fastcompression.com/applications/mlv-converter.htm)), but I'm stupid (too stupid) because, ab illo tempore, I formatted my mlv-storage with HFS+ (if I had exFAT I could switch to Win if required), and also I've sold my Nvidia cards... Another option is slimRAW but it seems limited to MLV-to-cDNG (no MOV, no proxy).
So, up to now, the most realistic option for me remains MLV-App.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on May 26, 2020, 02:34:23 AM
QuoteHow will that work with mlv files?
QuoteIt seems that Transkoder doesn't handle MLV codec.
Same way people work with MLV on Resolve: transcoding to CDNG. Transkoder can take full advantage of GPU using CUDA. Might be expensive, but I would seriously consider it if I needed to process multiple terabytes of data.
QuoteI formatted my mlv-storage with HFS+
Consider using ZFS instead. This is what most guys processing large amounts of data use. Windows (https://openzfsonwindows.org/) and OSX (https://openzfsonosx.org/) has support to it (don't know how well these projects work, since ZFS was built for linux/bsd primarily).
QuoteI've sold my Nvidia cards
The older nvidia architectures are very cheap nowadays. I've brought my nvidia 1050 for about $120. I think that's a fair price for an era where people pay $400 for apple wheels...
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 26, 2020, 03:05:49 AM
Thanks Luther for your advices.
Quote from: Luther on May 26, 2020, 02:34:23 AMtranscoding to CDNG.
Unfortunately, I haven't enough free space to convert all the clips to DNGs. My idea is to convert the clips directly to a proxy code just to experiment various editing hypothesis, and only once I'll know which are the clips I actually need, I'll convert them few MLV-to-DNG. But now I need a MLV-to-MOV direct solution.
Quote from: Luther on May 26, 2020, 02:34:23 AMTranskoder can take full advantage of GPU using CUDA.
I said sadly goodbye to Nvidia one year ago (I sold 3 Titan X GPUs) because it seems that latest Davinci needs a recent OSX, but Mojave can't work well with Nvidia, right? So I went for a couple of Radeon VII GPUs.
Quote from: Luther on May 26, 2020, 02:34:23 AMConsider using ZFS instead.
That's interesting! But how can I re-format my external storage without deleting my mlvs inside??? Is it possible???
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on May 26, 2020, 03:46:28 AM
Quote from: adrjork on May 26, 2020, 03:05:49 AM
Unfortunately, I haven't enough free space to convert all the clips to DNGs.
See: https://www.magiclantern.fm/forum/index.php?topic=13152.0
Quoteonce I'll know which are the clips I actually need, I'll convert them few MLV-to-DNG.
MLVApp is great for previewing. Only exporting is painfully slow sometimes.
QuoteDavinci needs a recent OSX, but Mojave can't work well with Nvidia, right?
As far as I know, that's not true. But you could use some Linux distro like Debian. It has Nvidia drivers and Davinci works on it (faster than on Windows/OSX). Not surprising that Pixar uses Debian on their render farm...
QuoteSo I went for a couple of Radeon VII GPUs
I like AMD too. I have a AMD CPU. AMD is more cooperative with open source community than Nvidia/Intel. But unfortunately CUDA is way ahead of OpenCL, and that is a Nvidia specific feature. For heavy processing like you're doing, Nvidia is the only solution that is cost-effective.
QuoteHow can I re-format my external storage without deleting my mlvs inside??? Is it possible???
This is called "in-place filesystem conversion". I don't think it is possible to do that from HFS+ to OpenZFS though. You can read (not write) HFS+ on Windows using this tool (https://sourceforge.net/projects/jhfsplus/) (it seems... never tested). On Linux you can read and write on HFS+ filesystems.
Best solution would be to get new HDDs (highly suggest WesternDigital instead of Seagate), then copying and erasing the old HDDs. This way you ensure everything is in its right place, with a fresh filesystem. ZFS is great for large amounts of data. You can also consider doing RAID mirroring.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 26, 2020, 05:40:50 AM
Luther, your reply is hugely informative! Many thanks.
I understand your point. Thinking a migration to Debian is now a bit problematic for me (various things hold me on OSX, not only Davinci), but surely for a next project I'll think about it, seriously.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on May 26, 2020, 06:42:14 AM
Does MLVapp automatically set black & white points for the footage depending on its bit depth? Or should we be doing that manually?

Also should I always be doing something in the "RAW Correction" panel? if the stream looks good, then I can disable it yes?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: reddeercity on May 26, 2020, 08:08:13 AM
Quote from: adrjork on May 25, 2020, 10:31:06 PM
I'm using an hackintosh with an i7-extreme
......
8-HDDs 48TB RAID6 thunderb.2, that is only "relatively" fast, but surely not fast as even a single SSD.
Me the same as you "hackintosh" i7-3770K overclocked to 4.8GHz with a ATTO PICe Raid ExpressSAS card  (2TBx4=8TB) in a raid 5 6TB total with a spare drive
I tried raid 6 was too slowww , (around 350MB/s) changed it to Raid 5 (3 disk + 1 spare) and got around 800-1200MB's on a empty drive .
I keep the raid no more then 50% full after that is slows down too much to 600MB/s but above that I can maintain (30-40%full) 800MB/s
So if you can It would be really better to change to raid 5 from raid 6

I also use (Cross platform mac/pc) FreeNAS (home built) with 6drive Raid5 4TB confirmation in ZFS over 1Gb network connection (100-130Mb/s)
and I edit with FCPX , I leave the whole project on the NAS box proxies and all and don't notice any slow down .
Even use the NAS box raid 5 to mount MLV's with MLVFS and import to After Effect(CS6) or BM Resolve without issue

My 2 cent worth  :D
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 26, 2020, 06:29:47 PM
@adrjork: sounds like your computer is a tiny little bit faster than mine and your projects are also a tiny little bit bigger than mine.  ;D The projects I usually render are about 0.5TB with 300..500 clips in one session. Sry, but I can't reproduce anything in these (your) dimensions. Anyway, I don't see any reason why the app should slow down after 200 clips. It should need longer for bigger clips - for opening, for creating MAPPs and for exporting - that is expected. It doesn't care how many clips you load, because MLVApp always handles exactly one clip at the time. So if it is the only app, this one instance gets 100% of the ressources for one clip.
There are differences in loading and processing e.g. if you use lossless compression - it always slows down, because lossless decoding is always single threaded. If you use clarity, highlights & shadows, RBF * sliders ( -> if sliders are different from 0 ) - those functions are also single threaded. DualISO is single threaded. All other stuff is multithreaded. Thanks for your test how much difference in processing time you get with how much instances of the app. I don't have any 10 core system here, so I can't test with so much cores. Multiprocessing has always some overhead for creating and for collecting threads. Interesing how big this overhead really is.

Quote from: Milk and Coffee on May 26, 2020, 06:42:14 AM
Does MLVapp automatically set black & white points for the footage depending on its bit depth? Or should we be doing that manually?
No. The white and black point is set by ML in the cam. MLVApp reads this metadata and allows to adjust it in the case it wasn't correct.

Quote from: Milk and Coffee on May 26, 2020, 06:42:14 AM
Also should I always be doing something in the "RAW Correction" panel? if the stream looks good, then I can disable it yes?
You should do what is necessary. If all is fine without RAW Correction, you don't need it.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on May 26, 2020, 09:59:41 PM
Quote from: masc on May 26, 2020, 06:29:47 PM
No. The white and black point is set by ML in the cam. MLVApp reads this metadata and allows to adjust it in the case it wasn't correct.

In the ML menus, the black level is always set to "0" even if I change the bit depth. Is it still setting the correct value in the metadata then?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 27, 2020, 06:56:33 AM
Wow guys, really thank you both reddeercity and masc for your fantastic informations!

@reddeercity: Your system blows my mind: very smart! And FreeNAS is very interesting!!! Thanks also for the tip on raid5 vs raid6. Surely my current-project-RAID is slowed down by both the fact that it's full as an egg (48TB in raid6 is 36TB and I have more than 33TB of data inside...) and the configuration raid6 itself. I wanted raid6 because for this project I was terrified of losing data, and this indirectly is also one of the reasons I'm avoiding mlvfs: I want to do my proxy-edit (and the future DNG-edit) without the external-raid always turned on (for extending its life, and avoiding the noise of its fans. :) The proxies (now) and the definitive selected DNGs (future) will be placed onto an internal 8TB 4-NVMEs raid-0 (HPT with 4x EVO-2TB drives) that is my secret weapon ;) together with the two Radeon VII GPUs (I've tested grading uncompressed 14bit DNGs with a bunch of nodes, temporal denoise, effects... and the preview in Davinci goes always in real-time! Like a boss 8)

@masc: yes, I was surprised by the "limit" of about 220 long clips before the uploading slows-down. It's strange. Anyway, that's what I did to make the job:
1. I uploaded "packs" of 220 long clips in MLVApp (it took me around 2 minutes per-pack) and I simply created the MAPPs (more than 30 minutes per pack, so it has been a looong 12-hours work-day);
2. I opened 10 instances of MLVApp and I uploaded 334 long clips into each instance (I have a total of 3340 clips to be converted);
3. With all the instances standing, I ran the first just for letting it recap all the clips, and once it started the actual conversion I aborted;
4. I repeated point 3 with every other instance;
5. After all the recaps were done, I ran all the instances together (Activity Monitor says 'round 160% of CPU for each instance).
Now my sweet hackintosh is working... alone... in the darkness of its tiny bedroom, dreaming (perhaps) a magic lantern (https://youtu.be/3OlCzxFuV9c?t=82). We'll meet again in three days. Good night :)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 27, 2020, 08:49:53 AM
Quote from: Milk and Coffee on May 26, 2020, 09:59:41 PM
In the ML menus, the black level is always set to "0" even if I change the bit depth. Is it still setting the correct value in the metadata then?
Sry, no idea what your talking about. Where do you see or set the black level in ML menu? "0" will never be correct (with a Canon cam) and will lead to pink shadows.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on May 28, 2020, 02:14:46 AM
Quote from: masc on May 27, 2020, 08:49:53 AM
Sry, no idea what your talking about. Where do you see or set the black level in ML menu? "0" will never be correct (with a Canon cam) and will lead to pink shadows.
Its in "Movie">"Image Fine-Tuning." Whats the use of changing the black level in ML menus?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 28, 2020, 08:26:47 AM
Quote from: Milk and Coffee on May 28, 2020, 02:14:46 AM
Its in "Movie">"Image Fine-Tuning." Whats the use of changing the black level in ML menus?
This is an offset to the coded black level. You can adjust it, if you think you have a better value. The adjusted blacklevel is then automatically in all MLVs you record, and you mustn't adjust it in every single clip in post.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on May 29, 2020, 06:36:58 AM
I see! Thank you. I don't see an advantage for it. Is it probably best to leave it at "0"?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 29, 2020, 07:34:50 AM
Quote from: Milk and Coffee on May 29, 2020, 06:36:58 AM
I see! Thank you. I don't see an advantage for it. Is it probably best to leave it at "0"?
Only you can answer this question. Please record a MLV, open it and watch the darkest shadows. If they are black: leave it as is. If they are pink or green: adjust it.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 29, 2020, 08:58:39 AM
This setting represents black level offset, and I think it only affects normal video. It can be used to make your videos look awful, works great in combination with edge emphasis.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: motionSOUL on May 29, 2020, 11:30:45 AM
Do someone has succeeded in using Cinelog-C from MLV App?
This is my primary tool to get log files from After Effects but my workflow is a bit cumbersome:

Canon 5DMKIII -> MLV Files -> Switch.app -> DNG Files -> After Effects / Cinelog-C -> ProRes4444 Files -> Let's start working or go to sleep ;-)

Thanks,

S/.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on May 30, 2020, 02:08:27 AM
Hi everyone, my dual-iso clips have lines and flickering also after the conversion (MLV to DNG)... ???
When I upload the dual-iso clip, MLV-App's dual-iso panel is grey. The only button I can clic is "Force". So, I clic on Force and then on ON. I tested both Interpolation_Mean + Alias_Off and Interpolation_AMaZE + Alias_ON. The result is that after the onversion from MLV to DNG, lines are still visible together with flickering.
I tried also Swicth (all defaults, but 15 dualiso automation enabled) and the result is the same...
Any advice, please?
Thanks in advance.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on May 30, 2020, 03:20:49 AM
Quote from: motionSOUL on May 29, 2020, 11:30:45 AM
Do someone has succeeded in using Cinelog-C from MLV App?
Cinelog-C is proprietary. MLVApp can't legally put their DCP in there...

Quote from: adrjork on May 30, 2020, 02:08:27 AM
Hi everyone, my dual-iso clips have lines and flickering also after the conversion (MLV to DNG)... ???
Which camera and build are you using? Also, if possible, provide a MLV sample...
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on May 31, 2020, 12:18:56 PM
Cinelog C is a log colourspace with Cineon curve and Alexa RGB primaries right? MLV App can do the Alexa RGB gamut. Only it doesn't do the Cineon log curve, supposedly it's best for shadows, but all log curves look the same to me.

So I think you can get close enough. Only difference with using mlv app is that your using mlv app and not Adobe camera raw, which has better noise handling I think. But compare and decide for yourself.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on June 02, 2020, 12:34:20 AM
Quote from: Luther on May 30, 2020, 03:20:49 AMWhich camera and build are you using? Also, if possible, provide a MLV sample...
My cam is a 5D3, and build should be Nightly.2017Feb12.5D3123
HERE (https://drive.google.com/file/d/1czdKUAc5L4ua24b_qzruXuLWPM8yn3ku/view?usp=sharing) the link of the MLV-dualiso (it's a 6GB file I compressed in .7z with Keka). If you want, I can also upload some frames/dngs of the conversion. Anyway, converting into both dngs or mov give the same result: horizontal lines are reduced but still visible (mainly on the ancient stone columns in the image), and flickering is evident.
More or less, all my dual-iso shots have the same issue, and it seems not to be an MLV-App's specific issue because also Switch gives a very similar result (lines, flickering...)
Thanks a lot.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on June 02, 2020, 01:23:52 PM
Quote from: adrjork on June 02, 2020, 12:34:20 AM
My cam is a 5D3, and build should be Nightly.2017Feb12.5D3123
You're using a very old build. Try the lastest @Danne's build (https://bitbucket.org/Dannephoto/magic-lantern/downloads/crop_rec_4k_mlv_snd_isogain_1x3_presets_2020May29.5D3123.zip).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on June 02, 2020, 04:25:36 PM
Quote from: Luther on June 02, 2020, 01:23:52 PM
You're using a very old build.
Thanks Danne, I'll change the build. But what about my old dual-iso shots? Unusable?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on June 02, 2020, 05:51:05 PM
You're adressing Luther? But it's my build.
I havn't checked your file. Sorry. Left the dualiso movie wagon long time ago.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 02, 2020, 10:00:39 PM
Quote from: adrjork on June 02, 2020, 12:34:20 AM
My cam is a 5D3, and build should be Nightly.2017Feb12.5D3123
HERE (https://drive.google.com/file/d/1czdKUAc5L4ua24b_qzruXuLWPM8yn3ku/view?usp=sharing) the link of the MLV-dualiso (it's a 6GB file I compressed in .7z with Keka). If you want, I can also upload some frames/dngs of the conversion. Anyway, converting into both dngs or mov give the same result: horizontal lines are reduced but still visible (mainly on the ancient stone columns in the image), and flickering is evident.
More or less, all my dual-iso shots have the same issue, and it seems not to be an MLV-App's specific issue because also Switch gives a very similar result (lines, flickering...)
Thanks a lot.
I downloaded your clip and tried my luck. Something is really wrong with it, but I can't tell exactly what. Vertical Stripes Fix completely fails with it and dualiso as well. If you disable Vertical Stripes Fix and if you set dualiso to "Preview" it looks not too bad. For flickering you'll have to search another solution.
(https://i.ibb.co/58zZxqk/Bildschirmfoto-2020-06-02-um-21-54-23.png)
You should try a new build.

Quote from: adrjork on June 02, 2020, 04:25:36 PM
But what about my old dual-iso shots? Unusable?
You should always test your settings before you record important clips. Otherwise you might get into trouble and you'll have to search for very difficult solutions.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on June 03, 2020, 06:09:48 AM
Quote from: masc on June 02, 2020, 10:00:39 PM
I downloaded your clip and tried my luck. [...]
First of all, thanks really a lot for your help and your time. In the future I'll surely follow your advice of testing builds first. (For the flickering I have in mind a couple of solutions: perhaps Davinci deflicker could work, or perhaps a little workflow's detour towards LRTimelapse...)
Quote from: Danne on June 02, 2020, 05:51:05 PM
You're adressing Luther? But it's my build.
Actually, Luther very kindly advised me to change my old build for your newer build (that's what I'll surely do!)
Anyway, finally I've found out that my two problems (dual-ISO here in this topic, and the case of the different DNGs from the same MLV in Switch topic (https://www.magiclantern.fm/forum/index.php?topic=15108.msg227670#msg227670)) are actually one single issue: simply my dual-ISOs. I've posted a screen record HERE (https://youtu.be/5QffZCwMPjk), as you asked me.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: reddeercity on June 03, 2020, 07:41:59 AM
@adrjork check your clip you posted and I had no problem converting the Dual ISO file with MLVFS (https://www.magiclantern.fm/forum/index.php?topic=13152.msg127218#msg127218) on my win7 desktop , It's Cross platform (PC/Mac)
There no lines/stripes etc. .... 
That all I use when comes to Dual ISO .

Here the dng extracted with MLVFS
P3.borso-180911-1011zR.DI_000000.dng (https://bitbucket.org/reddeercity/magic-lantern_10-12bit/downloads/P3.borso-180911-1011zR.DI_000000.dng)

I ran it thought UFRaw (http://ufraw.sourceforge.net/) to do a quick adjustment , it uses dcraw in the backend , it's also cross platform .

(https://i.ibb.co/pwx0ZyH/P3-borso-180911-1011z-R-DI-000000-small.png) (https://imgbb.com/)

link to full res (1920x1080) png P3.borso-180911-1011zR.DI_000000.png (https://bitbucket.org/reddeercity/magic-lantern_10-12bit/downloads/P3.borso-180911-1011zR.DI_000000.png)
also here the P3.borso-180911-1011zR.DI_000000.ufraw (https://bitbucket.org/reddeercity/magic-lantern_10-12bit/downloads/P3.borso-180911-1011zR.DI_000000.ufraw) that UFRaw export with the save PNG .

One last thing , The flicker you have in the dual iso "could" have been fixed if you would has turn on the de-flicking in dual iso module .
edit: I'll keep the link up to the files for a 7 days 
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on June 03, 2020, 09:54:43 AM
Really thanks reddeercity for your help.
But... It sounded too good to be true in a "usable" way: after your post I tried immediately MLVFS and the result is: dual-ISO "Full" on-the-fly crashes/stops Davinci, only dual-ISO "Preview" works on-the-fly (on my machine at least). I tried also setting dual-ISO "Full", then copying the DNG-folder to save it as "offline", and then importing into Davinci (it works, but the result is apparently not SO different from Preview).
Anyway, the result is almost unusable: some frames are good, but the flickering is horrible, and the worst thing is that during the "flicks" you can clearly see the horizontal lines suddenly appear (it's like an old damaged CRT TV... it looks like young Chris Cunningham set my camera...)
I tried to use Davinci's deflicker to limit the problem, and it does something, but not too much...
This is the result:

I think that perhaps I could export deflickered DNGs from Davinci, and then trying to do a final adjustment in LRTimelapse, but even if it improves brightness stability, there are still the lines that appears time to time (the "flicks"). Any other idea is very welcome :)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 03, 2020, 12:02:51 PM
The dual iso processing algorithms between MLVFS and MLVApp are mostly identical, as far as I know.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Levas on June 03, 2020, 01:51:41 PM
Strange, the difference in results between MLVFS/MLVApp/Switch
Downloaded the big dualiso MLV file and loaded it with MLVFS on my mac...doesn't look as good as the frame reddeercity posted  ???
Still got the horizontal black lines...

Now I'm wondering, where does MLVFS get his cr2hdr source.
Can't find it in the contents folder, or is it baked in in the mlvfs file itself ? 

Further I'm wondering, could it be that reddeercity has somehow a different version of cr2hdr (baked in his version of mlvfs) then other people are using ?

EDIT and if so, I want that particular cr2hdr version reddeercity is using, but macOS ofcourse  ;D
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on June 03, 2020, 03:04:00 PM
i just tuned in to this discussion and i am wondering if this is the same issue i ran into when i shot some footage using dual iso in one of my ttt episodes last year...

if so, it is possible to "cherry pick" good frames where the problem is not visible.

could that be what's happening here?

if memory serves, i very slightly improved the problem in the footage by using cr2hdr with the command line and forcing some setting i cannot remember.  but it didn't fix the footage, it only slightly improved it.  i have never used dual iso since.  it might be useful for certain footage but the results are not great on detailed and important scenes, and it is not enjoyable to wonder if the footage will be good or not!

it's a sad thing because it has a lot of promise as a feature.

of course, YMMV...
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Levas on June 03, 2020, 05:07:43 PM
I've lately had the same problem as you describe, a few dual-iso's that are bad. But you could "cherry pick" some good frames out of it.
So some frames are good, most are really bad...

But that's not what is happening here, reddeercity posts frame P3.borso-180911-1011zR.DI_000000.dng, so the very first frame of the MLV file.
I have downloaded that same MLV file, opened it with MLVFS (on macOS) and I don't get the good results reddeercity is getting, while looking at the same frame (000000.dng)
I get the same shit adrjork posts  :P

So something weird is happening, reddeercity is able to get normal results out of a dual-iso MLV file, while most others here on the forum can't get any usable frames out of it ???
What is happening here ?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on June 03, 2020, 05:55:24 PM
Could we get a shortened file, maybe 20 frame mlv?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Levas on June 03, 2020, 06:34:42 PM
Converted with mlvdump to 20 frames MLV file (76Mb)
http://drive.google.com/file/d/1GCa_Y3dczpVH2zjoDkiQJnK4D1xH4XwG/view?usp=sharing (http://drive.google.com/file/d/1GCa_Y3dczpVH2zjoDkiQJnK4D1xH4XwG/view?usp=sharing)

EDIT, clicking on my own link, to check, and what...google shows a preview of the MLV file format  :o
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on June 03, 2020, 06:53:57 PM
Wtf! Google decodes MLV. Cool!
(https://i.postimg.cc/FHB16PZp/Screenshot-2020-06-03-at-18-52-35-png-500px.png)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Levas on June 03, 2020, 06:55:00 PM
As it seems for now, google didn't bother to add support for dual-iso mlv's  :P
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on June 03, 2020, 07:09:20 PM
Quote from: Levas on June 03, 2020, 06:55:00 PM
As it seems for now, google didn't bother to add support for dual-iso mlv's  :P
haha.

Tested the file both on mlvfs and cr2hdr and same result with stripes showning. I think it´s just one of those files that´s hard for the converter to detect correctly. A1ex probably knows how to fix that clip but is it worth it. Dualiso cr2 yes, but for movie files I think not.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Levas on June 03, 2020, 07:20:08 PM
It probably isn't worth the time to get a specific clip fixed.
But what amazes me is the fact that reddeercity has no problem converting the exact same file  ???

Could there be a bug in cr2hdr for macOS, or in different versions used ?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on June 03, 2020, 08:04:18 PM
Don't know about that. Will have to check his files. Did he share converted dng files? If working better maybe it's an early mlvfs version.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Levas on June 03, 2020, 08:23:58 PM
check this post of reddeercity:
http://www.magiclantern.fm/forum/index.php?topic=20025.msg227677#msg227677 (http://www.magiclantern.fm/forum/index.php?topic=20025.msg227677#msg227677)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on June 03, 2020, 08:45:55 PM
Did you examine the dng file? Full of cold pixels. Probably cold pixel fix added. Maybe some other setting. Probably some older version that makes this particular file work a little better but looking at the file so much noise. Better to just use it in anamorphic mode or x3crop and work with those files.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yourboylloyd on June 04, 2020, 12:15:37 AM
Hello all,

I'm still a noob at MLVApp. I usually just export DNG and edit in AFX. Is it possible to export to Prores RAW from MLVApp?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: reddeercity on June 04, 2020, 05:16:38 AM
@Levas as I said before this is Windows7 & I'm using 2 different MLVFS systems ,
the first one is the old Fuse/Dokan Quick Mount with mlvfs.dll in the root drive
so a simple right click on the .mlv file in windows explore .
The other one is the mlvfs.exe in Web browser that build a virtual disk drive and load them in that drive .

The one I use to extract the 5d3 dualiso dng was the quick mount mlvfs .
Her a screen shot of the .dll file proprieties

(https://i.ibb.co/J7RjFQ5/Untitled.png) (https://imgbb.com/)

been using this since 2015 for all my .mlv's normal & dual iso video on my 5D2
The file version 0.4.0.0 (bb0bad7)
Had a look in the source code to see what is set by default in dual iso processing
mlvfs/src/master/mlvfs/main.c#lines-918 (https://bitbucket.org/dmilligan/mlvfs/src/master/mlvfs/main.c#lines-918)
This look like it

            else if(mlvfs.dual_iso == 2)
            {
                is_dual_iso = cr2hdr20_convert_data(&frame_headers, image_buffer->data, mlvfs.hdr_interpolation_method, !mlvfs.hdr_no_fullres, !mlvfs.hdr_no_alias_map, mlvfs.chroma_smooth, mlvfs.fix_bad_pixels);
            }


So I would think if you compile the commit (bb0bad7) for mac you should have the same as me .
here link to the commit bb0bad7 (https://bitbucket.org/dmilligan/mlvfs/commits/bb0bad7e9ba5f5c4a59959ad7543b2bf6717b737)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on June 04, 2020, 05:49:07 AM
Quote from: reddeercity on June 04, 2020, 05:16:38 AMSo I would think if you compile the commit (bb0bad7) for mac you should have the same as me. here link to the commit bb0bad7 (https://bitbucket.org/dmilligan/mlvfs/commits/bb0bad7e9ba5f5c4a59959ad7543b2bf6717b737)
I'm not a coder, so I can only follow hoping someone compiles this for Mac.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on June 04, 2020, 07:13:39 AM
mlvfs from 2015. Check commits in cr2hdr ranch:
https://bitbucket.org/hudson/magic-lantern/commits/branch/cr2hdr

Best guess. Even if this particular clip will work with an older version, a lot of other files will get a much worse treatment. If anyone wants to compile a 2015 build, go ahead.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: reddeercity on June 04, 2020, 08:43:06 AM
Found the one I use on my older mac , build date from 11/30/2014 the only difference in this one is there no support for lossless compression (I think but I'm not sure) .
I didn't check any file with it as i'm not close to my MacPro 5.1 right now , but work with any files from my 5d2 .
MLVFS.dmg (https://bitbucket.org/reddeercity/magic-lantern_10-12bit/downloads/MLVFS.dmg)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on June 04, 2020, 09:02:02 AM
Quote from: reddeercity on June 04, 2020, 08:43:06 AM
Found the one I use on my older mac , build date from 11/30/2014 the only difference in this one is there no support for lossless compression (I think but I'm not sure). I didn't check any file with it as i'm not close to my MacPro 5.1 right now , but work with any files from my 5d2. MLVFS.dmg (https://bitbucket.org/reddeercity/magic-lantern_10-12bit/downloads/MLVFS.dmg)
Thank you so much reddeercity. Also, may I ask to you to kindly post a downloable link of your «old Fuse/Dokan Quick Mount with mlvfs.dll in the root drive». I'd appreciate it a lot :) (I'd like to test a thing on my machine...)

[EDIT: the old 2014 MLVFS gives the same results as current MLVFS... I'd like to try your old Windows quick mount version.]
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 04, 2020, 09:51:32 AM
Quote from: yourboylloyd on June 04, 2020, 12:15:37 AM
Is it possible to export to Prores RAW from MLVApp?
No, it isn't.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Levas on June 04, 2020, 11:09:48 AM
@adrjork
Found a workflow in MLVapp that somehow gives ok results(not perfect, because after this fix you can see you deal with the problem discussed in this post)
http://www.magiclantern.fm/forum/index.php?topic=7139.msg226389#msg226389 (http://www.magiclantern.fm/forum/index.php?topic=7139.msg226389#msg226389)

I did this in MLVapp1.11 on mac.
Open up the MLV file in in MLVapp.
Now on the right side of the window with options, at the top uncheck the box for "enable raw correction"
Once you unchecked this option, you will see that your MLV file has more natural colors.
Now export the file as DNG sequence (cinemaDNG lossless in the export option menu)
Now select in the top menu bar -> file -> Transcode and import
Select/open the folder where you export the dng's to and select a location for the new MLV file.
After that you will see your new MLV file appear in MLVapp.
Now on the right side of the window with options, use "auto" or "force" option for fixing bad pixels.
And use force on dual iso, and probably use preview option with dual iso (looks a little better I guess  ???)

Now the weird thing is, if you want to export this new mlv file to a dng sequence, it won't give you normal dual-iso results as you see in the preview...
But you can export to h.264 or Tiff/PNG sequence, Tiff/PNG sequence is als a good option for daVinci Resolve.

Problem however, you still have weird issues with frames that show reddish tint or green tint.
The clip is very stationary, so probably stack 4 layers of the clip on top of each other, with each 1 frame offset and blend in normal mode.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: byonik1 on June 05, 2020, 01:08:05 AM
Hello,
Is there anyone who, like me, has problems importing MLVs into the MLV App under Catalina (10.15.5)?
When I import via the App or click / drag, the App turns then crashes. A solution ?
A yes, I use the latest version of MLV App (QTv1.11)

Thanks
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: adrjork on June 05, 2020, 06:01:26 AM
Quote from: Levas on June 04, 2020, 11:09:48 AM@adrjork: Found a workflow in MLVapp that somehow gives ok results (not perfect, because after this fix you can see you deal with the problem discussed in this post (http://www.magiclantern.fm/forum/index.php?topic=7139.msg226389#msg226389))
Dear Levas, thanks for having shared your detailed workflow, I appreciated it, but the result I obtained is still unusable: it actually DOES improve things but doesn't fix them: flickering is better but still there (needs to be fixed with a deflicker), reddish and greenish frames are a problem, but the worse thing is... lines, lines, lines. It gets a little better if I put off Bad Pixels, and also using a temporal denoiser does something more, but the result remains pretty unusable.

Apparently nor the reddeercity method can help me...
Quote from: reddeercity on June 04, 2020, 05:16:38 AMI'm using 2 different MLVFS systems, the first one is the old Fuse/Dokan Quick Mount with mlvfs.dll in the root drive so a simple right click on the .mlv file in windows explore.
Today I downloaded mlvfs.dll (https://bitbucket.org/dmilligan/mlvfs/downloads/) (dated 2014) and PFMAP (https://pismotec.com/pfm/ap/), and I tried a test on Windows 10. The result is again a variant and synonym of "unusable". Main problem is again: lines, lines, lines (and a little flickering, and all the other stuff...)

That's it man... Game over, man :) :) :)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on June 05, 2020, 06:27:04 AM
Is there anyway to disable "RAW Correction" by default? It is enabled on all of my clips by default, and "Vertical Stripes" is always set to "Normal." Does MLV app alter the RAW data if the "Vertical Stripes" is always set to "Normal?" With that enabled, it's still exporting RAW right (if I export to cDNG?)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 05, 2020, 07:36:29 AM
save receipt
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 05, 2020, 08:25:16 AM
Quote from: Milk and Coffee on June 05, 2020, 06:27:04 AM
Is there anyway to disable "RAW Correction" by default? It is enabled on all of my clips by default, and "Vertical Stripes" is always set to "Normal." Does MLV app alter the RAW data if the "Vertical Stripes" is always set to "Normal?" With that enabled, it's still exporting RAW right (if I export to cDNG?)
It is enabled by default, because most cameras need these corrections. Appart from that, this needs nearly no time in processing. As the name says (RAW correction) the RAW data is corrected and the corrected RAW is saved into cDNG. After having exported the cDNG, there is no easy way to correct it afterwards.

You can open all your files in one session, uncheck it for one clip, CTRL+C, CTRL+A, CTRL+V.
OR
You can open one file, uncheck RAW corrections, save the receipt. Load this receipt as default receipt. https://github.com/ilia3101/MLV-App/wiki#22-edit
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on June 05, 2020, 11:48:52 AM
All raw corrections leave the data "raw", they are only for fixing defects. Please stop worrying about how raw your image is. DNG is always raw.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 05, 2020, 01:28:16 PM
I have a suspicion that 5D2 raw black level is wrong in mlvapp, its 1792, this makes the footage a bit green, when i dial it to 1782 then it looks more correct.
Is there a scientific way to check correctly black level ?
So before i post some screengrabs id like to make sure i checked properly.But i noticed it by comparing footage from canon M, it looks too green on 5d2, compared both with same white balance, same lens, same iso and shutter.
I noticed that there is color difference between cameras, red colors on M have ability to go towards purple which is correct and more true to real color i see with my eyes , while 5D2 has orange bias, i corrected 5d2 a bit to be similar to M.Also because M is more true to life, those 2 colours are more red than orange.
Overall from my tests it looks like M has more dynamic range than 5D2 even tho all the papers say its opposite.I could not get similar dynamic range from 5d2 that M gave me on ISO 100 which is native one.Shadows were too dark on 5d2 where restored highlight details were comparable on both cameras.
Id say M performed better because of newer sensor.
Color difference:
(https://funkyimg.com/i/35rAw.gif)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on June 05, 2020, 11:56:18 PM
What's that gif comparing? I want to see the shots processed with the same settings (caemera matrix on), except white balance (pick from the same point) and match exposure slider as close as possible. There should not be such a big color difference under light such as daylight or tungsten. If it's led light, then ok.

Also 1792/1791 black level is correct. Maybe the EOSM has more infrared sensitivity, causing the blacks to look more magenta and making the 5d2 look green in comparison.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: reddeercity on June 06, 2020, 06:01:24 AM
The 5d2 is in bt601 (full range 0-255) color space where the eosM/D5 cams are in rec709 (16-235) .
That's why the 5D2 looks flatter in color , more like film , the M & all D5 cam have more Video cam/HD look with hi-contrast level .
Plus the smaller sensor has small photodiode so it collect less light compared to full frame 
5D2 has 6.14µm pixel pitch size compared to the EOSM of 4.31µm (bigger is better  :D )

https://www.apotelyt.com/compare-camera/canon-5d-mark-ii-vs-canon-m
QuoteThis service determines an overall sensor rating, as well as sub-scores for
low-light sensitivity ("DXO Sports"),dynamic range ("DXO Landscape"), and color depth ("DXO Portrait").
Of the two cameras under review, the 5D Mark II provides substantially higher image quality than the Canon M, with an overall score that is 14 points higher.
This advantage is based on 1.6 bits higher color depth, 0.7 EV in additional dynamic range, and 1.1 stops in additional low light sensitivity.
(https://i.ibb.co/THVgV4V/5d2-Ver-eos-M.png) (https://imgbb.com/)

So it the 5D2 has 11.9 DR & the eosM has 11.2 DR , I guess that says it all  ;)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 06, 2020, 09:45:08 AM
mlv files and jpegs , same settings, matched exposure and white balance
That orange/hotrod color shift is definitely there on 5D2 also green shift is visible on foil, it sdefinitely not green when i look at it, M has more accurate colors.

Comparison with actual paint box
5D2
(https://funkyimg.com/i/35syf.jpg)

M
(https://funkyimg.com/i/35syq.jpg)

big scale jpgs:
5D2
https://funkyimg.com/i/35sxP.jpg
M
https://funkyimg.com/i/35sxE.jpg

MLV files 14 bit lossless on M and uncompressed on 5D2
https://drive.google.com/file/d/14JqFOIy9N8occlpHVuRh6OLACNBLaPaD/view?usp=sharing

https://drive.google.com/file/d/1rjyh2dvwaiaWmp-b7HkvNFDgqpbAh7G4/view?usp=sharing

Its worth noting that in order to get correct exposure on both i had to open up the lens on 5D2, which leads me to believe that ISO in canons doesnt follow any standards and isnt equal along their cameras or it just has less dynamic range.
Dave 5D2 in order to use 601 need to record mov file, this is raw pattern, and to both files tonemapped 709 is applied so its even.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 06, 2020, 10:04:21 AM
What are the used lenses? Comparing in LR makes it look nearly identically. M seems to have just a little more contrast because of less DR.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 06, 2020, 10:07:06 AM
Same helios 58 -44-2 on both cameras with that aperture ring that can be very precise.
Look at the colors of the paint below yellow one, compare M and 5D2.
I tried to be as similar as i possibly can but i noticed that green bias just recently, i also tested older ml builds and its the same.
Maybe there is more green photodiodes in 5D2 sensor thats causing this.Or there just isnt any standard that canon follows in their cameras so colors wont be accurate and they dont have to be ? Wheres color police ?  :P
I will take regular RAW photo on 5D and compare that instead of MLV.
--
Just did that, its the same, same colors as in MLV file.
Anyway you can "solve" that in hsl panel in MLVApp, if you want to match 5D2 colors with real life.I just wanted to point out that its happening.
I wish someone would do that comparison with all canons side by side.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on June 06, 2020, 10:50:56 AM
@2blackbar I've noticed this behavior in regular cr2 photos, when switched from 550d to 5d2. But for my taste, 5d2 photos looks more natural, and 550d have some magenta cast to them..
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on June 06, 2020, 12:23:01 PM
Thank you for the raw files, I will look. I remember in rawtherapee 5D2 raw photos always looked like absolute garbage, but other cameras were ok, so there is something different about this camera (or Adobe's matrix that everyone uses).

BTW, with old lenses there may be colour and contrast changes. I definitely know that the Helios 44 contrast increases massively between f2.0 and f2.8. The best way to match the shots in camera would be with shutter and iso.

And I really appreciate the test, if you could do it in other conditions like daylight that would be amazing ;) (I'd do it myself, but my 5D2 is broken for the millionth time)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on June 06, 2020, 01:04:53 PM
Quote from: 2blackbar on June 06, 2020, 09:45:08 AM
Its worth noting that in order to get correct exposure on both i had to open up the lens on 5D2, which leads me to believe that ISO in canons doesnt follow any standards and isnt equal along their cameras or it just has less dynamic range.

Dxomark says ISO 100 on the mark II is actually equal to 73, and 98 on the EOSM.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 06, 2020, 01:17:32 PM
it is daylight , sun  thru the window.
ithink coloors should be like real life and canon m is closer ,5d2 has color shift in raw, white balance wont help, needs hue shift
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on June 06, 2020, 04:14:53 PM
What are those paints? That difference is shocking and amazing... never seen that before. I want to see how other reds look.

I have heard before that the mark II has a strong infrared filter, so it is less sensitive to longer red wavelengths, and I guess those paints reflect mostly in the long reds. Could you see how the 5D reproduces some other red colours? (in comparison to eosm)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on June 06, 2020, 06:05:31 PM
Quote from: masc on June 06, 2020, 10:04:21 AM
What are the used lenses? Comparing in LR makes it look nearly identically. M seems to have just a little more contrast because of less DR.

Can you show how it looks in LR?

I knew adobe must be doing something in addition to the matrices.

Also how does the WB picker in mlv app work? How many pixels does it sample?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 06, 2020, 07:27:10 PM
These pics of actual acrylic paint box next to monitor with image from 5D2 show how different colors are, i dont mean contrast and brightness but hue of reds below yellow paint.
And that pic was taken with pixel 2 XL, it actually shows these reds quite accurate.I mean its how i see these colors in real life, they are definitely red , not orange like on 5D2.
(https://funkyimg.com/i/35tc4.jpg)

Or maybe my camera is faulty? It would be helpful if someone who has 5D2 would test this as well on some paints .The more colours the better.
Strange thing is i dont see that color shift mentioned in any of the reviews but most of the reviews are just ads.
One more with 3 of them:
(https://funkyimg.com/i/35tdh.jpg)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 06, 2020, 11:20:57 PM
Quote from: ilia3101 on June 06, 2020, 06:05:31 PM
Can you show how it looks in LR?

I knew adobe must be doing something in addition to the matrices.

Also how does the WB picker in mlv app work? How many pixels does it sample?
Here the LR5 results: (just WB corrected, all other sliders and options are default, no raw black level correction)

5D2:
(https://i.ibb.co/7gvvnLZ/5-D2-M06-0828-frame-1-l1.jpg)

M:
(https://i.ibb.co/26Ckknz/M-M06-0934-frame-1-l1.jpg)

The WB picker in MLVApp has a range of 20x20 pixels, which are averaged to find the correct WB.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on June 07, 2020, 12:30:28 AM
Fantastic comparisons @masc!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 07, 2020, 02:22:36 AM
great, how i can get these colors on 5d2 in mlvapp?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on June 07, 2020, 06:48:41 AM
The closest I can get is this in mlv app. Test this recipe https://bitbucket.org/Dannephoto/magic-lantern/downloads/5D2.marxml.

White balanced in acr:
(https://i.postimg.cc/fTS8nShd/Screenshot-2020-06-07-at-06-38-31-png-800px.png)

White balanced in Mlv App:
(https://i.postimg.cc/YCZGcjMv/Screenshot-2020-06-07-at-06-56-36-png-800px.png)

Basically I do following:
(https://i.postimg.cc/jjDHNGd7/Screenshot-2020-06-07-at-06-47-46-png-scaled.png)

(https://i.postimg.cc/MH6X0QbF/Screenshot-2020-06-07-at-06-58-57-png-scaled.png)

(https://i.postimg.cc/KzrRgNLT/Screenshot-2020-06-07-at-06-59-09-png-scaled.png)


I guess if we want to get closer we need to match the "adobe color" to the rec709. Maybe modifying rec709 itself could get us closer to adobe color? I also tested colors in MlRawViewer and they pretty much tells the same difference like with Mlv App.




Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on June 07, 2020, 07:23:22 AM
Quote from: masc on June 05, 2020, 08:25:16 AM
It is enabled by default, because most cameras need these corrections. Appart from that, this needs nearly no time in processing. As the name says (RAW correction) the RAW data is corrected and the corrected RAW is saved into cDNG. After having exported the cDNG, there is no easy way to correct it afterwards.

You can open all your files in one session, uncheck it for one clip, CTRL+C, CTRL+A, CTRL+V.
OR
You can open one file, uncheck RAW corrections, save the receipt. Load this receipt as default receipt. https://github.com/ilia3101/MLV-App/wiki#22-edit

Thanks all for the replies! Very very helpful!

So most cameras need this correction? Are they present, and I'm just not noticing them?

If the image looks good, does leaving "vertical  stripes" on, degrade an already good image?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: reddeercity on June 07, 2020, 07:56:11 AM
why is everyone so hang up this 5d2 color thing ?
You shouldn't have to adjust black & white level at all . Just select the "Don't use Camera Matrix" & select "Highlight Reconstruction" .
On the 5d2 & 50D "camera matrix" does not do a good job , messes with colors .
I can match frames in 10,12&14bit  from A.E. CS6 to MLV App or match frames from MLV App to A.E. CS6 with out any problems as long as I select the "Don't use Camera Matrix" on 5D2.

One last thing - Is you monitor calibrated correctly ?
No one else seems to have a problem with 5d2 (including me) , you need to look deeper , did you re-set you camera , is there any w/b hue adjust in the camera custom setting  ?
I seen this happen to other people before .
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on June 07, 2020, 08:18:52 AM
You need the camera matrices if you want coherency with sensor and color calibration according to adobe. Without them it is all a "generic matrix roulette". I do admit Ilia3101 did a good job on this no matrix starting point but still.

What makes things difficult is when rec709 is supposed to look like adobe color when comparing. Instead compare with for instance resolve rec709:

In resolve, Apply Pre Tone Cuve set in Project settings
(https://i.postimg.cc/W4FtpVXh/Screenshot-2020-06-07-at-08-07-49-png-500px.png)

Tangent to rec709 in Mlv App
(https://i.postimg.cc/8znjVcd2/Screenshot-2020-06-07-at-08-09-30-png-500px.png)

The provided clips from the 5D II do look greenish and colors differ from eos m as a starting point. When correcting white balance it do looks better. Not perfect but close when comparing in resolve. I didn´t touch white balance either.


EDIT:
Correcting white balance(Resolve)
(https://i.postimg.cc/gkKPh7n4/Screenshot-2020-06-07-at-08-34-51-png-500px.png)

Correcting white balance in Mlv App.
(https://i.postimg.cc/qMbHQ5dL/Screenshot-2020-06-07-at-08-51-39-png-500px.png)


By the way. Here is no matrix selected:
(https://i.postimg.cc/6qbbVFG4/Screenshot-2020-06-07-at-08-52-56-png-500px.png)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on June 07, 2020, 08:30:14 AM
Quote from: DanneMaybe modifying rec709 itself could get us closer to adobe color?
Using AP1 instead of Rec.709 seems to improve colors in my tests. AdobeRGB creates artifacts in blue hues.

Quote from: reddeercity on June 07, 2020, 07:56:11 AM
On the 5d2 & 50D "camera matrix" does not do a good job , messes with colors .
I disagree with that. At least for 50D, the skin tones improve a lot with camera matrix.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on June 07, 2020, 08:50:42 AM
Quote from: Luther on June 07, 2020, 08:30:14 AM
Using AP1 instead of Rec.709 seems to improve colors in my tests. AdobeRGB creates artifacts in blue hues.
As a stand alone workflow AP1 probably retains more color and keeps them from breaking. But how to use this streamlined matching resolve? I would look at AP1 as an approach of keeping more color to work with in post but precision/matching is not there the same as rec709? At least when I try and reproduce AP1 in resolve comparing with Mlv App. Please prove me wrong on this.

Edit:
Personally I think no matrix selected or Alexa wide gamut would be interesting to explore and use here
No matrix
(https://i.postimg.cc/6qbbVFG4/Screenshot-2020-06-07-at-08-52-56-png-500px.png)

Alexa wide gamut
(https://i.postimg.cc/cJd7HXrp/Screenshot-2020-06-07-at-08-55-54-png-500px.png)

AP1, looks kind of wonky, needs color correction luts
(https://i.postimg.cc/vmXr6fnc/Screenshot-2020-06-07-at-08-55-45-png-500px.png)


And back to rec709 for comparing. Vivid colors for a happy world ;)
(https://i.postimg.cc/d3crb6PN/Screenshot-2020-06-07-at-09-00-43-png-500px.png)

Looks like Ilia3101 no matrix color science has a little deeper color compared to even alexa wide gamut. Not bad at all.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: reddeercity on June 07, 2020, 09:33:12 AM
Quote from: Luther on June 07, 2020, 08:30:14 AM
I disagree with that. At least for 50D, the skin tones improve a lot with camera matrix.
No can't agree , instead of using rec709 or AP1 use Adobe standard space and correct your output color space to 16-235 level instead of full range (0-255)
FYI: I like my image to be flat (log like) as I don't final grade with mlv app.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 07, 2020, 09:45:00 AM
Quote from: reddeercity on June 07, 2020, 07:56:11 AM
No one else seems to have a problem with 5d2 (including me) , you need to look deeper , did you re-set you camera , is there any w/b hue adjust in the camera custom setting  ?
I seen this happen to other people before .
With my 5D2 I also never had a problem with that. I now tried to set w/b hue to a wrong setting (Canon menu), but the MLV clips look the same. Did you mean something else? Does this really affect RAW data saved to the card? Never heard about that before.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on June 07, 2020, 09:45:18 AM
Edit: answer to previous posts. Masc posted while writing.

Please back up statements with images to compare. Simply too many ways to utilize mlv app.
Also important to now what we are looking for here. On one hand seeking color accuracy between apps. On the other hand sort of personal creative uses where more or less anything that looks kind of good or log might work on individual basis.

Edit: hue cannot be changed following into a raw mlv. Come on. Only metadata and apps interpreting differently.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on June 07, 2020, 09:54:13 AM
Quote from: Danne on June 07, 2020, 08:50:42 AM
But how to use this streamlined matching resolve?
Yeah, not sure. An alternative solution would be to use Log-C with Wide Gamut RGB. Then apply ARRI LUT (https://www.arri.com/en/learn-help/learn-help-camera-system/tools/lut-generator) on Resolve.

Quote from: reddeercity on June 07, 2020, 09:33:12 AM
No can't agree , instead of using rec709 or AP1 use Adobe standard space and correct your output color space to 16-235 level instead of full range (0-255)
Why would you limit your range? Bt601 is not used anymore, there's no possible scenario (that I can think off) where your workflow would benefit from it.
QuoteFYI: I like my image to be flat (log like) as I don't final grade with mlv app.
If you don't grade in MLVApp and you don't need to do color match, then your goal should be to retain as much information as possible. Using Log-C with AP1 and exporting lossless would be the way to go. Or just convert to CDNG and work directly on Resolve, that would give much better/faster results.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on June 07, 2020, 10:05:16 AM
Quote from: Luther on June 07, 2020, 09:54:13 AM
Yeah, not sure. An alternative solution would be to use Log-C with Wide Gamut RGB. Then apply ARRI LUT (https://www.arri.com/en/learn-help/learn-help-camera-system/tools/lut-generator) on Resolve.
There's no general solution when it comes to color science. All needs testing. And then more testing. In theory, everything will work ;). Please prove above workflow working as expected. Would be nice.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 07, 2020, 02:26:19 PM
I pushed these colors below yellow towards red in HSL section and saved it as default receipt for 5D2.White balancing is not affecting their hue enough in mlvapp tonemapped preset.
If it would be blue colors then i wouldnt bother but reds are on our skin, they are quite important.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on June 07, 2020, 02:34:26 PM
Could you share example images?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: allemyr on June 07, 2020, 02:45:30 PM
Quote from: reddeercity on June 07, 2020, 09:33:12 AM
No can't agree , instead of using rec709 or AP1 use Adobe standard space and correct your output color space to 16-235 level instead of full range (0-255)

rec709 is 16-235, and hows that different from setting Adobe standard and 16-235 output?

My experience is that sRGB works best, when viewing videos from Youtube or Vimeo or other on displays. By works best i mean that it corresponds to what you see color like in your NLE and it a 100% match from NLE to online viewing. No color shifts after upload.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 07, 2020, 02:48:34 PM
Sure, its what i did, side by side to unchanged M and 5D2. corrected is last one with HSL settings:
(https://funkyimg.com/i/35u8y.jpg)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: reddeercity on June 08, 2020, 01:35:18 AM
Quote from: allemyr on June 07, 2020, 02:45:30 PM
rec709 is 16-235, and hows that different from setting Adobe standard and 16-235 output?
Adobe is full range (0-255) (photo color space) there more head room in the mids & highlights  compared to rec709 which is video color space .
Or to say Adobe Standard is very close to Rec2020 (4k video space) but in photo color space there more head room in general
but at the cost of always mind full of your output viewable color space .
Quote from: allemyr on June 07, 2020, 02:45:30 PM
My experience is that sRGB works best.
Agreed !
I use a 1080p per-calibrated 10bit sRGB (98% accurate) grading monitor , in After Effect CS6 , FCPX & my go to grading/FX app
Autodesk Smoke for Mac 2012  :D ,
I use Blackmagic UltraStudio SDI, USB 3.0 for FCPX & A.E.CS6 , for Autodesk Smoke for Mac i use my AJA Kona PICe card
to grade with so i work with either True Apple ProRes 4444XQ (full range) (FCPX), Tiff/DXP and some times prores in Smoke for mac
and last but not least good old Cdng in After Effect from mlv app .
I do wish MLV App. would have support of external monitor though devices like BM UltraStudio etc. ... to a calibrated monitor then i would use mlv app 100% of the time
as it is , i can only use it for low priority work that's not mission critical (i still have high hope for mlv app!)

In my opinion and from experience with Resolve , it does a big disservice to Magic Lantern Raw .
Being trying out Assimilate Scratch , I got a free 6 mouth licence and it way better then blackmagic resolve hands down !
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: allemyr on June 08, 2020, 04:04:31 PM
Quote from: reddeercity on June 08, 2020, 01:35:18 AM
In my opinion and from experience with Resolve , it does a big disservice to Magic Lantern Raw .
Being trying out Assimilate Scratch , I got a free 6 mouth licence and it way better then blackmagic resolve hands down !

Ok I understand, and I know Resolve is not that easy to setup to get good result, in terms of color and quality. Maybe it depends what camera you have for quality. I can imagine lower resolution then 1080p can get some slight worse result or maybe you record croprec at higher resolution. Good luck with Assimilate Scratch, it was a very expensive software when I last checked. But I can't understand how that gonna be different then Resolve. If you set Resolve up correctly you can get same result as ACR or MLVapp but you can easily cut and edit in it. You can check my latest grade video if you want. The colors is a 100% match to what I see in Resolve and the quality is good I think. Maybe I should get a screenrecording app for Windows and try making a tutorial for all the settings mostly and workflow. Now when I solved my workflow I don't look at buying any other camera then keeping my old Canon.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on June 08, 2020, 05:03:35 PM
Yes resolve has a huge amount of options, adobe works great by default. You can get good results with both.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ricardopt on June 09, 2020, 03:23:17 AM
Hi everyone, one of my main dificulties/weaknesses with magic lanterm is color grading the raw videos, mlvapp has received lots of attention in the color grading "section" but for some like me there's to many options, i know its sacrilege to say "to many options", i find that when i export mlv to cdnglossless or use mlvfs and import the dng sequences in Resolve and Premiere they have a more pleasing color to me, i find it easier to finish the colorgrading from that starting point, the problem is that editing cdng sequences brings my pc to a halt, i dont have any problems editing prores...my question is...is there a way to export to prores "using the color profiles" that are used when converting to cdng?

Thanks
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 09, 2020, 07:27:45 AM
@ricardopt: Leave all options as they are for standard. Default is fine. Just use whitebalance/tint and exposure. You should already get a pleasing picture. All other options are additional for special cases. CDNG has no color profile, as it is RAW. If MLVApp already has too many features, you should not use Resolve...  ;D
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ricardopt on June 09, 2020, 09:21:49 AM
Hi Masc, thanks for your help, Resolve/Premiere/hitfilm/kdenlive/shotcut are not complicated if you only use them to "lightly" edit the footage, for example: cut, stabilize,add title and small color edit, Resolve has indeed a lot of options in the color grading area but apart from that it looks and is used like any other regular NLE.

Will try your suggestions, thanks.

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ricardopt on June 09, 2020, 07:36:11 PM
Hi again, just figured out what was wrong with the colours...i recorded the videos on a sunny day and used 5600k as whitebalance but i was getting the wrong colour/cast in mlvapp, converting to cdng was giving better results but something was off, after so many tests i decided to play with the WB value in mlvapp and after some tests i found out that using 5600k was the problem, the colours were back to normal if i use 4600k, dont know what happened since i read here and on other forums that 5600k is good for sunny days.

Thanks everyone.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 09, 2020, 09:16:57 PM
Guys its me again with another quest  :P
I made some tiny customisation of MLVApp code about half year ago:
     if( m_codecOption == CODEC_H264_H_MOV || m_codecOption == CODEC_H264_H_MP4 || m_codecOption == CODEC_H264_H_MKV )
            quality = 13;
        else
            quality = 23;


And its the code responsible for compressing medium setting of h.264 export in MLVApp but what i would like to do is actually have third option in MLVApp for h264 and probably for h.265, and when i choose this option ( lets call it CUSTOM quality ) then i have a box where i can input my own quality value.
Where should i start ? Probably clone existing medium value and add a window to accept my own number with quality setting.
Its just i have no clue how to add this window that will accept my own values.
Does it need changes in several different places in MLVApp or just in export window code ?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 09, 2020, 09:27:34 PM
@2blackbar:
Small summary: you need to do many changes, in more than just the export window. You need to add a spinbox to the export dialog, then this values needs to be set when calling the dialog and needs to be read when closing it. If you have another setting than h.264 or h.265 (and other than ffmpeg), grey it out or hide it. The setting has to be integrated into preset saving/loading feature.
In MainWindow class, you need another member to hold this value. This value should be saved into registry when closing the app and needs to be read from registry when opening the app. In the end the simple part: integrate this member at the place where you customized already.

So... there is some work to do for this little change.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 09, 2020, 10:52:04 PM
I see, this kind of customized input would be very helpful, is there any other way to do it so i can give it my own quality values to h.264 and 265?
I have the project opened in qt creator.
how to fix the errors ?
(https://funkyimg.com/i/35yiS.jpg)

Ok its fixed itself i can compile, not sure what happened, and its wrong again, cant open mlv file, its crashing.
I dont know what is it, its compiling without issues, then i copy new mlvapp.exe to folder where older mlvapp exe is with all its required files, but it doesnt work, crashing when loading mlv or crashing when starting program.
Now it compiled properly and opens mlv properly.
I have not clue what the hell happened and wahts is going on.one time i get many errors, other time it compiles fine after i reopen qt creator.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 10, 2020, 08:59:58 AM
What you show are no errors, these are warnings. No problem. Warnings = yellow, Errors = red.

If you compile MLVApp yourself, you also have to deploy it yourself, or you go the same way the official binaries were build. This means your binary needs the correct libraries. And if the application crashs on startup, I am very sure you use the wrong libraries. The binary always needs the libraries of the same version it was build with. The official static MLVApp version includes the libraries in the .exe.
So best bet is to start your compiled binary from QtCreator, because it provides the correct libraries automatically.
In MLVApp menu there is an action called "About Qt" under Help: it shows the currently used libs. These libs MUST be identical to your compiler settings in Qt Creator.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 10, 2020, 10:26:47 AM
I cant see any libs mentioned in mlvapp help - about qt
Qt is a C++ toolkit for cross-platform application development.
Qt provides single-source portability across all major desktop operating systems. It is also available for embedded Linux and other embedded and mobile operating systems.
Qt is available under three different licensing options designed to accommodate the needs of our various users.
Qt licensed under our commercial license agreement is appropriate for development of proprietary/commercial software where you do not want to share any source code with third parties or otherwise cannot comply with the terms of the GNU LGPL version 3.
Qt licensed under the GNU LGPL version 3 is appropriate for the development of Qt applications provided you can comply with the terms and conditions of the GNU LGPL version 3.
Please see qt.io/licensing for an overview of Qt licensing.
Copyright (C) 2017 The Qt Company Ltd and other contributors.
Qt and the Qt logo are trademarks of The Qt Company Ltd.
Qt is The Qt Company Ltd product developed as an open source project. See qt.io for more information


How to make the exe to be 25MB , mine is only 6 MB , all i did was opening mlvapp.pro  file in qt creator and change to release on bottom then hit the hammer
that compiled with warnings but just 6mb, where in the source are these libs mentioned ( so i can look them up )that make up 25mb file mentioned? Id like the file to be 25MB and be self contained.
Currently master branch hangs on opening mlv file, i copied it to old folder with libs for 1.9 release ( i skipped 1.10 and 1.11 but they dont have any libs in zip, theyre self contained 25mb files )
Looks like the dlls files are version 5.13 , i have QT 5.14
Im downloading 5.13.1.0 , hope this will help but id prefere to learn to adapt to new qt versions.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 10, 2020, 10:40:00 AM
(https://i.ibb.co/mhyXK9x/Bildschirmfoto-2020-06-10-um-10-33-06.png)

This is how the dialog looks here. I have 5.11.2 here, you'll have a different one. Look just one line above your quote.

If you use a standard Qt version, then all is right you get. You should get around 6MB. The libs are mentioned in the .pro and Qt automatically knows what .dll to use. There is a deployment application (command line) in Qt to automate the copy process of all necessary dlls.
The 25MB version is static. You have to build/compile your own Qt framework for that. Bouncyball did that on Linux for crosscompiling the Win64 version. I failed when trying the same. In the end this was too much work for the same result for me. For the official releases it is nice to have.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 10, 2020, 10:50:36 AM
yeah i have 5.13.1 in about qt, but i have this issue only with master for 1.11 , i got 1,10 and 1.9 sources , they compile fine without errors on opening mlv files , they just dont have transocde that i need for dngs.
I have installed QT 5.14 and thats i compiled with qtcrator from that version, but im downloading 5.13 , i dont know if it will help.Strange that 1.10 works and 1.11 doesnt.
Ah from folders in qt i see its qt 5.12 , not 14 like it shows in qt creator.Anyway we will see if 5.13 will help.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 10, 2020, 07:30:47 PM
It didnt help, still crashing when opening MLV file in compiled 1.11 , something must be very different between 1.11 and 1.10 because compiled 1.10 works fine.
Wheres the list with required files  that are used with 1.11 ?
IT says that 1.11 is using QT version 5.9.1, its 6 hours of downloading for me, is it gonna make a difference ?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 10, 2020, 08:22:39 PM
I don't really understand what you do. You downloaded the tagged source code from 1.11, 1.10 and 1.9? Or the master?
Currently I would recommend to not try the master, because we started some new development and nobody tried it on Windows yet. The tagged sources of the official versions can be compiled and we know they work.
The Qt version you use don't really cares. As I already wrote, the toolchain version must be identical to the used libs next to the exe file. I know it works with 5.6, 5.7, 5.9, 5.10, 5.11 and 5.13, because I tried compiling and tested it without problems (5.10 and 5.11 bring some minor graphic problems). Do you start the application from QtCreator with the green triangle button?
If the application crashes at some point after showing the GUI: try to compile a "Debug" version and start with debugger (the green triangle with bug button). It is able to tell us the line of code of a crash.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 10, 2020, 11:47:07 PM
Yup, downloaded source of 1.11 from releases page, same thing after compilin 6mb file and copying it to folder where 1.10 and 1.9 is and works but that 1.11 exe is not working , hanging when opening mlv file.
There is definitely something very different in that 1.11 release. Without knowing what it is or what files are embedded into 25mb version im stuck.
Unless someone has dlls for 6mb version of 1.11 exe.
So.. i will do this, i know there was 1.9 version that had transcode and import which was remoevd for 1.10, i will compile that one, cause i compiled it before.Cant compile 1.11 succesfully for now.
This turned it off ?
    if( !QFileInfo( QString( "%1/raw2mlv.exe" ).arg( QCoreApplication::applicationDirPath() ) ).exists() )
        ui->actionTranscodeAndImport->setVisible( false );

What i wanted to have is most recent version with transcode and import but changing h264 quality so medium is at 20.But i have to settle for 1.9 or edit that code above myself for 1.10
Yeah that was it, i changed that line to true in 1.10 build.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on June 11, 2020, 03:37:14 AM
Master might be broken on Windows. I've tried multiple configs and still wasn't able to compile. Some notes for reference in the future:
- Fist error was not detecting clang. Just install using chocolatey (https://chocolatey.org/packages/llvm).
- You have to change the default compiler. Go to Tools > Options > Kits. Then click on the one you're using and choose the C and C++ compiler.
- Chocolatey doesn't seem to create PATH Env to clang binaries. You have to add manually.
- Second error: float.h is not up-to-date in MinGW binary release (it seems). I replaced it using this version (https://raw.githubusercontent.com/mirror/mingw-w64/82b169c5734a6198d3b4c51a48f82e7b7104f143/mingw-w64-headers/crt/float.h) and it worked. The path to the original is something like "C:\Qt\Tools\mingw730_64\x86_64-w64-mingw32\include"
- Third error: the debugger failed. Don't know if it was specific to my machine. I tried directly linking lldb instead on the 'Kit'. The path to it is "C:\Program Files\LLVM\bin\lldb.exe"
- Some people pointed to use the mkspec called "win32-clang-g++". Just update on the 'Kit'.
- After all that, still multiple errors while compiling. Before I got angry and gave up, I tried to read some of the debug messages. Tried to change from clang.exe to clang-cl.exe (which seems to have better compatibility for some reason). No success. The issues seemed to be related to the linker, because way too many libs were not recognized. So I tried to find to find a way to use LLVMs own linker (lld) (http://lld.llvm.org/), but I couldn't find a way to make qtcreator use it (or cmake, I dunno).


Windows is such a piece of shit for developing. QtCreator is bloated and buggy. Such a nightmare. I miss when software used to just be easy to compile as writing "sudo make".
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 11, 2020, 09:03:45 AM
Quote from: 2blackbar on June 10, 2020, 11:47:07 PM
Yup, downloaded source of 1.11 from releases page, same thing after compilin 6mb file and copying it to folder where 1.10 and 1.9 is and works but that 1.11 exe is not working , hanging when opening mlv file.
Maybe I did not write it clear enough: don't copy it anywhere for testing! Start the compiled application using QtCreator!!! And you did not write anything about the content in those folders. If just one library file in your folder is missing or has the wrong version it will crash the application!!! So: don't do it. Not for the beginning!

Quote from: 2blackbar on June 10, 2020, 11:47:07 PM
There is definitely something very different in that 1.11 release. Without knowing what it is or what files are embedded into 25mb version im stuck.
Unless someone has dlls for 6mb version of 1.11 exe.
I think I explained alredy: 6MB = dynamic version, 25MB = static version. You use a dynamic framework, so you can get only a 6MB version. The dynamic exe WON'T / CAN'T WORK in the folder of a static version!

Quote from: 2blackbar on June 10, 2020, 11:47:07 PM
This turned it off ?
    if( !QFileInfo( QString( "%1/raw2mlv.exe" ).arg( QCoreApplication::applicationDirPath() ) ).exists() )
        ui->actionTranscodeAndImport->setVisible( false );

What i wanted to have is most recent version with transcode and import but changing h264 quality so medium is at 20.But i have to settle for 1.9 or edit that code above myself for 1.10
Yeah that was it, i changed that line to true in 1.10 build.
These lines only switch an action invisible if the necessary file raw2mlv does not exist. If you delete the lines, the action will be shown but it can't work if raw2mlv isn't there. Changing to true makes no sense either.

Quote from: Luther on June 11, 2020, 03:37:14 AM
Master might be broken on Windows.
The latest changes were made for Unix only. Windows support comes later, if it doesn't work out of the box. Better play with official 1.11 for now. (Edit: master compiles and works without problem also on Windows 32bit, while 64 bit produces a crash on startup)

@Luther: if you just install Qt with mingw32 or mingw64 you don't have to change anything in settings for beeing able to compile MLVApp. MLVApp project is made for working with QtCreator standard settings on Windows.

Quote from: Luther on June 11, 2020, 03:37:14 AM
Windows is such a piece of shit for developing. QtCreator is bloated and buggy. Such a nightmare. I miss when software used to just be easy to compile as writing "sudo make".
Windows... yes, but that's nothing new. QtCreator is one of the best environments and works like a charme, as long you don't destroy the settings. Where is the problem to open a project and hit a compile button. Sorry. Even typing "make" is more difficult. And you can do that in command line instead using QtCreator, if you like, and you will come to the same result.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: reddeercity on June 11, 2020, 09:56:11 AM
Problem with mlv app 1.10 back to 1.8 on windows 7 , keeps crashing on export of dng's in fast pass or lossless .
I can render a  file to prores  or any compressed format etc. ... but for the last 2.5 hrs I've tried all version to  get any dng out .
It on 1x3 from my 50D , I import the file thought the menu in MLV App. adjust w/b & black level and then stops working on export
even lockup my desktop , had to reboot to get back to windows7 . It did export once the 1x3 50d file but exported as 1376x576
instead or 4128x1776 , the 1x3 file is 1376x1776 .

I have no problem exporting the 1x3 dng's with mlvfs quick mount , so  there's no problem with the file .
this has happen before with files from my 5D2 when i couldn't export dng's  in fast pass or Lossless
in either 3x3 ,  1x1 or 3x1 but that was when i was doing drop & drag on the mlv app. GUI window .
When I started to import thought the drop down menu that problem stop . Now on version 1.10->1.07
i'm finding this problem again on my 50D now , I just wanted to export the 10bit dng's with the 1x3 flag so i can work in A.E.
I can export with mlvfs , but the files get too bloated (10->16bit) or i can use mlv_dump to get the 10bit dng's but i
would like to get them out of mlv app because it's much easier .

Here 8 Crash Log's MLV_App_CrashDumps.rar (https://bitbucket.org/reddeercity/magic-lantern_10-12bit/downloads/MLV_App_CrashDumps.rar)
from different version from 1.70 to 1.10 on Windows 7Pro , AMD 8350 8 core , SSD OS , 8 GB Ram , 2x 580GTX video cards .
I tried off the USB 3.0 CF Card Reader also tried from a spare ssd work drive (500GB) Sata 6 and tried from SSD OS to Work SSD drive still no Joy .
 
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 11, 2020, 11:14:08 AM
Interesting details, Im kinda OK now as 1.10 works for what i want , raw2mlv and transcode in it works too.
masc 1.11 works when debugging, doesnt crash on opening mlv but where from now? How do i get proper dlls for 6mb version 1.11 thats deployed, i have these dlls but they work for 9 and 10, not for 11, even if all 3 are compiled bythe same QT in the same day .
I opened MLVApp 11 in dependency walker but well, is there a way to automate getting right dlls ?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 11, 2020, 12:33:01 PM
@reddeercity: I can't find any problem exporting DNGs here. Works without problem, also for 5D2 MLVs with the settings you mentioned. Could you please upload a small MLV which makes problems for you? Would be cool for analysis.

@2blackbar: You find the libs in the Qt intallation folder. But it is better to use windeployqt (a command line Qt tool which automatically deploys your project).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 11, 2020, 12:45:18 PM
Ill try this trick, copy all dlls, run mlvapp and then try to delete all dlls, it will leave the ones in use
https://wiki.qt.io/Deploy_an_Application_on_Windows
Also did windeployqt --dir E:/mlvap  E:/mlvap/MLVApp.exe
Then copied missing dlls manually like vcruntime from mlvapp 1.10
maybe that the issue? whre should i get vcruntime dlls  from, its c++ but how to find the right ones
--
didnt work.Ill pass for now.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 11, 2020, 04:47:34 PM
@2blackbar:

You can automize it with QtCreator. Build a custom process step like this:
(https://i.ibb.co/hfzBFw5/Bildschirmfoto.jpg)

All is deployed with that, when trying to start the app via Creator. Just one single lib is missing: libgomp-1.dll. You'll find it in C:\Qt\Tools\mingw730_64\bin
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 11, 2020, 07:16:38 PM
That worked ! Great , thanks for helping masc.
I noticed that files like QTCore d or QTGuid are much bigger in size than the ones for version 1.9 and 1.10.
IS that normal? Now MLVApp takes about 1gb.Their nam is also with "d" at the end, that means debug ?
I think yes, ill try it with release.
--
Yeah taht was it, now its 64MB with release.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 11, 2020, 09:53:06 PM
Yes, with d in the end is debug. It is way bigger and way slower, but it is able to track and log errors, when using the debugger. For normal use choose release. If you get any crash, try the same with the debug version inside QtCreator and it will you tell the line of code where the crash happens.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 11, 2020, 10:13:48 PM
masc can i make it do two pass encoding with hevc 265 ? im doing some testing in avidemux , if i will like them id like to use the settings in mlvapp for exporting 2 pass h265.It will make log file needed for 2nd pass tho and im not sure how to write it in one line in mlvapp, needs two separate passes.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on June 11, 2020, 11:13:12 PM
Quote from: masc on June 11, 2020, 09:03:45 AM
Edit: master compiles and works without problem also on Windows 32bit, while 64 bit produces a crash on startup)
So you were able to fully compile on 64-bit? What are your settings? I think the float commit was what made it stuck. It seems other people also had issues compiling tinyexpr on windows:
https://github.com/codeplea/tinyexpr/issues/44
https://github.com/codeplea/tinyexpr/pull/54
Quote
@Luther: if you just install Qt with mingw32 or mingw64 you don't have to change anything in settings for beeing able to compile MLVApp. MLVApp project is made for working with QtCreator standard settings on Windows.
That was the first thing I tried yesterday. Didn't work on master now (some months back it worked without problems). The debugger accuses of clang not being installed. I know QtCreator has it's own clang binary, but for some reason it didn't work. After manually installing and setting it to use the new binary, it worked. But then float.h was not up-to-date.
Quote
Where is the problem to open a project and hit a compile button. Sorry.
If only it was that simple. QtCreator was +50GB when I first downloaded it. All of that just for what was supposed to be just a GUI frontend for compilers.
Quote
Even typing "make" is more difficult.
Not really? I spent ~1h trying to figure out how to compile MLVApp master. While compiling st (http://st.suckless.org/) is as easy as doing "git clone https://git.suckless.org/st && cd st && sudo make".
Quote
And you can do that in command line instead using QtCreator, if you like, and you will come to the same result.
Yes, but now you need to chain 5+ binaries in a row to do the same task people have been doing since the 80s.
Anyway, don't want to be the obnoxious purist here, just think some of those modern solutions are too complex and create more problems than it solves.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on June 11, 2020, 11:46:44 PM
Tinyexpr won't compile on windows 64? Which parts are causing problems?

+ I always use command line to compile mlv app  ;)

qmake; make -j4
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 12, 2020, 07:09:46 AM
@2blackbar: two pass processing would mean to rewrite a bigger part of the ffmpeg export function. And it will need around the double processing time... (I think you know).

Quote from: Luther on June 11, 2020, 11:13:12 PM
So you were able to fully compile on 64-bit? What are your settings?
Yes, no problem. Works out of the box. Qt standard settings with minGW64, 5.13.1. Maybe you tried with VC compiler. The crash after starting the app is fixed now.

Quote from: Luther on June 11, 2020, 11:13:12 PM
I think the float commit was what made it stuck. It seems other people also had issues compiling tinyexpr on windows:
https://github.com/codeplea/tinyexpr/issues/44
https://github.com/codeplea/tinyexpr/pull/54
I did not see any problem with this lib.

Quote from: Luther on June 11, 2020, 11:13:12 PM
I spent ~1h trying to figure out how to compile MLVApp master.
Download, unzip, load .pro file, hit okay, hit compile, start application. https://github.com/ilia3101/MLV-App#qt-app-windows

Or via Qt command line:
go into MLVApp/platform/qt, qmake MLVApp.pro, make (or mingw32-make or how it's called) -j4 (number of threads)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on June 12, 2020, 11:28:35 PM
Quote from: ricardopt on June 09, 2020, 07:36:11 PM
Hi again, just figured out what was wrong with the colours...i recorded the videos on a sunny day and used 5600k as whitebalance but i was getting the wrong colour/cast in mlvapp, converting to cdng was giving better results but something was off, after so many tests i decided to play with the WB value in mlvapp and after some tests i found out that using 5600k was the problem, the colours were back to normal if i use 4600k, dont know what happened since i read here and on other forums that 5600k is good for sunny days.

Thanks everyone.

As a rule, always adjust white balance first. Always.

It is possible you have to use 4600k because your lens has a yellow tint (almost all lenses do). I find myself using between 4600k to 5200k for daylight mostly.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Luther on June 13, 2020, 05:16:58 AM
So I 'cleaned the room' (reinstalled lastest QtCreator, MinGW and cloned Master again) and it worked. Don't know what was the issue before, if you guys updated Qt and I was using a wrong version of it (it was working about 3 months ago) or if the new commit from @Ilia3101 (https://github.com/ilia3101/MLV-App/commit/674b292084e88a297baeae6e2d5889c6699482c7) fixed it...
Anyway, master is working great on Windows 10 64-bits now, that's good.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on June 17, 2020, 02:42:43 PM
A few fixes for Mlv_App_compiler.app in first post. Testing out a version for Catalina. To get openmp working we need both updated llvm and llvm@7 installed:
https://bitbucket.org/Dannephoto/mlv_app_compiler/commits/39cec5f9e58be00b2f7ff446045c8a850f406b5d

Download:
https://bitbucket.org/Dannephoto/mlv_app_compiler/downloads/mlv_app_compiler.dmg

If issues please try this in terminal then run the compiler again.
brew install llvm
brew upgrade llvm
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on June 24, 2020, 07:48:07 PM
A few questions here, forgive me! I tried to read as much of this thread as I could!

1. Is there a way to rename DNG sequences in MLV App? (Aside from the current structure?) I like to include the camera model in my file names.
1A. If I rename AFTER exporting to DNG, will this cause any issues? I know there is metadata inside cDNG's, so if the current filename doesn't match the filename it had when exporting, will that cause any issues?
2. What is the export setting "Cinema DNG Fast Pass"? How does it differ from "Cinema DNG Uncompressed?"

Thank you!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 24, 2020, 08:18:02 PM
Quote from: Milk and Coffee on June 24, 2020, 07:48:07 PM
1. Is there a way to rename DNG sequences in MLV App? (Aside from the current structure?) I like to include the camera model in my file names.
No, this is not possible.
Quote from: Milk and Coffee on June 24, 2020, 07:48:07 PM
1A. If I rename AFTER exporting to DNG, will this cause any issues? I know there is metadata inside cDNG's, so if the current filename doesn't match the filename it had when exporting, will that cause any issues?
It can lead to problems with proxy workflows: because the naming might be different, linking could fail.
Quote from: Milk and Coffee on June 24, 2020, 07:48:07 PM
2. What is the export setting "Cinema DNG Fast Pass"? How does it differ from "Cinema DNG Uncompressed?"
"Fast Pass" leaves picture data untouched, while "uncompressed" force exports to uncompressed cDNG where also RAW corrections are applied.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on June 24, 2020, 09:40:18 PM
Quote from: masc on June 24, 2020, 08:18:02 PM
No, this is not possible.It can lead to problems with proxy workflows: because the naming might be different, linking could fail."Fast Pass" leaves picture data untouched, while "uncompressed" force exports to uncompressed cDNG where also RAW corrections are applied.

Thanks masc!

1A. So If I don't use a proxy workflow, renaming cDNG sequences after exporting should work fine? There are no cDNG metadata issues with that?
2. To clarify, a "Fast Pass" cDNG export will not include ANY adjustments from the panels?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on July 02, 2020, 05:12:07 AM
Quote from: Danne on June 17, 2020, 02:42:43 PM
A few fixes for Mlv_App_compiler.app in first post. Testing out a version for Catalina. To get openmp working we need both updated llvm and llvm@7 installed:
https://bitbucket.org/Dannephoto/mlv_app_compiler/commits/39cec5f9e58be00b2f7ff446045c8a850f406b5d

Download:
https://bitbucket.org/Dannephoto/mlv_app_compiler/downloads/mlv_app_compiler.dmg

If issues please try this in terminal then run the compiler again.
brew install llvm
brew upgrade llvm


I've went ahead and did the two commands via Terminal per your request. Done. Thanks for this and how'd you managed this?  :o

Also downloaded this version of MLV_APP_compiler. Ran 'U' just to be sure all well. Then ran 'OP' and here we go...

A LEGEND!

(https://i.ibb.co/n6YW8sR/Screen-Shot-2020-07-01-at-12-42-10-PM.png) (https://ibb.co/jbQpZvH)

Thanks again for sticking your neck out, always!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: coffee_king on July 06, 2020, 04:52:45 PM
Is there no UNDO button with MLV Video? So if I don't like an adjustment I've done I can go back a step? I can't see it in the menu system and Cmd + Z doesnt do anything either.
Thanks in advance.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 06, 2020, 04:59:27 PM
Quote from: coffee_king on July 06, 2020, 04:52:45 PM
Is there no UNDO button with MLV Video? So if I don't like an adjustment I've done I can go back a step? I can't see it in the menu system and Cmd + Z doesnt do anything either.
Thanks in advance.
Nope. Does not exist, and would mean a rewrite of nearly the whole GUI.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: sebamax on July 06, 2020, 06:36:35 PM
Hi guys,
How to use MLV with card spanning?
Is it necessary to copy the contents of two cards in one folder?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on July 06, 2020, 06:50:27 PM
Yes. Didn't you try?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: sebamax on July 06, 2020, 07:50:07 PM
I tried coping the files into a new folder and it was ok, but I would like to know if it's possible to work connecting the cards without coping the files into the hard disk.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on July 06, 2020, 07:54:10 PM
Nope.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: sebamax on July 06, 2020, 08:01:20 PM
Thanks! Danne
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yourboylloyd on July 12, 2020, 10:12:43 PM
Feature Request: Is it possible to have a height transformation of 1.33x in MLVApp?  Right now there is only 1.67x and 3.0x. I mount my SLR magic lens sideways so I can get more vertical resolution. (I also turn my camera sideways too) But it would be awesome to preview and export it already in the proper aspect ratio.

(https://i.ibb.co/RSZ4645/mlvapp1.png) (https://ibb.co/wL3rQrv)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 12, 2020, 10:24:20 PM
Stretching preview is not as easy as one might think, because of many dependencies. But you can export in whatever resolution you like. See export settings, "resize".
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ZEEK on July 13, 2020, 09:54:28 AM
Quote from: masc on July 12, 2020, 10:24:20 PM
But you can export in whatever resolution you like. See export settings, "resize".
+1
I export Anamorphic to a specific Aspect Ration Resolution. E.g. for 1.33x, I export a 2.35:1 Aspect Ratio Resolution [4096x1679] and use this site as a guide for upscaling:
https://blog.chameleondg.com/post/111891072017/resolution-aspect-ratio-cheat-sheet

*Note, Some say the SLR Anamorphot 1.33x is not true 1.33x and feels like 1.25x, so if 2.35:1 looks a little tall, try other aspect ratios upon export, e.g. 2.39:1. And just to check it's a good fit, export 1 frame instead of the whole thing to save time ;)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: TKez on July 14, 2020, 06:03:27 AM
Any updates on the possibility of Cinelog?

Could we not allow a users who own Cinelog to copy the dcp files into a place where MLVApp can detect and use it?

Cinelog really is a great pairing for MLV Raw and remains AFAIK the only colourspace transform designed and calibrated specifically for it.

MLVApp + Cinelog workflow that would allow more or less one click dumping of a card full of MLVs into Cinelog Prores would be a very fast, powerful and space saving combination.

Working direct with cDNG in Davinci has it's benefits, but if you're working on real projects, it's hard to beat the blazing speed of FCPX with Prores.

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bakersdozen on July 16, 2020, 10:33:32 AM


Quote from: TequilaKez on July 14, 2020, 06:03:27 AM
Any updates on the possibility of Cinelog?

Could we not allow a users who own Cinelog to copy the dcp files into a place where MLVApp can detect and use it?


That would be super sweet if possible.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 16, 2020, 12:51:23 PM
Quote from: TequilaKez on July 14, 2020, 06:03:27 AM
Any updates on the possibility of Cinelog?
I haven't read about any update, so there probably won't be one. We are not working on that. MLVApp is open source, so feel free to integrate it for your personal use.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: clubsoda on July 24, 2020, 11:43:25 AM
Hello :)

Is there any plan to implement more debayer options in mlv app, also options for the user to tweak and finetune directly in the interface? For example Fast CinemaDNG Processor hast the MG Debayer 23x23 BBGR as default which tends to give some of my clips way better results with some weird artifacts disappering completely. Amaze is amazing but sometimes i wish that there would be more settings or more debayer options to tweak and test with. Some raw clips could be saved by changing the debayer already in a project of mine :)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 24, 2020, 12:52:24 PM
@clubsoda: if you have the source code of other nice depayer algorithms, we could try to add them to MLVApp. A while ago I tried with many other debayer algorithms: some were extremely slow, others were not good enough to add them to the release. I can't remember about MG - so if you have open source code for it, I'll try to add it.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on July 24, 2020, 01:12:15 PM
Hi guys... one question about sharpening.. As I understand, if I resize a video when exporting, MLVApp add sharpening before resizing? So it's better to sharpen later in premiere for example?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 24, 2020, 01:33:19 PM
Quote from: Skinny on July 24, 2020, 01:12:15 PM
Hi guys... one question about sharpening.. As I understand, if I resize a video when exporting, MLVApp add sharpening before resizing? So it's better to sharpen later in premiere for example?
Exactly.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: clubsoda on July 24, 2020, 01:34:24 PM
Quote from: masc on July 24, 2020, 12:52:24 PM
@clubsoda: if you have the source code of other nice depayer algorithms, we could try to add them to MLVApp. A while ago I tried with many other debayer algorithms: some were extremely slow, others were not good enough to add them to the release. I can't remember about MG - so if you have open source code for it, I'll try to add it.

I am no expert on this field by any means therefore i am a so called noob for everything "code" but i searched the web and "MG" is used by FastVideo. On this link it is listed right at the bottom: https://www.fastcompression.com/products/debayer-moire.htm

Maybe you can contact them (on the bottom there is a link) for any further information or if the sourcecode is somehow available. I found out about it in the software Fast CinemaDNG Processor (there are also other algorithms like DFPD and HQLI) which you can buy from them.

They have also a freeware available thats called Fast Debayer on CUDA which lists these algorithms too. Here is the download page: https://www.fastcompression.com/download/download.htm

Everything looks like this works with nvidia gpus only but as i said i am a par excellence noob :)

I will search further too if i find anything useful i will report back.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 24, 2020, 01:44:13 PM
If this algorithm was developed by fastompression.com, it is a commercial product and can't be added to MLVApp. If it is open source, the code should be easy to find somewhere in the internet. CUDA will not be added to MLVApp soon - I have no NVidia card and don't plan to buy one. The application would be very limited with that, same as all CUDA only applications.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: clubsoda on July 24, 2020, 01:56:30 PM
Ah! I understand! No probelm thanks for looking into my question :)

PS: There are also some other debayer algorithms available in raw therapee, for example DCB (looks like it trades details for better false color prevention). Was there any reason not to include them? https://rawpedia.rawtherapee.com/Demosaicing
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on July 24, 2020, 07:39:55 PM
When exporting .MLV using "CinemaDNG fastpass:" if the .MLV was recorded with lossless compression, does "CinemaDNG Fastpass" export CinemaDNG Lossless?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 25, 2020, 10:34:25 AM
Quote from: Milk and Coffee on July 24, 2020, 07:39:55 PM
When exporting .MLV using "CinemaDNG fastpass:" if the .MLV was recorded with lossless compression, does "CinemaDNG Fastpass" export CinemaDNG Lossless?
Trying out is the best you can do. Example: I tried with a 21MB MLV:
- DNG Fastpass: 21MB
- DNG Lossless: 21MB
- DNG Uncompressed: 34MB
So what could be "Fastpass", if the MLV was lossless?  8)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on July 25, 2020, 06:24:54 PM
That's pretty cool! Thanks masc!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Eugenia on August 08, 2020, 03:26:14 AM
I hope that some exporting optimization can happen on the MLV app. I tried on two computers, a PC and a Mac, they make for an unusable experience.

ffmpeg Prores or h.264 exports is abysmally slow on both (16 minutes for 28 seconds of 4k anamorphic footage), while when using Apple's Prores exporting libraries (instead of ffmpeg) on the mac, it's much faster (10 minutes), but still not fast enough. No filters or changes were done in the RAW tab (just a straight export). i know for a fact from FCP exports that Apple's prores libraries are not that slow.

What this tells me is that the FEEDING of the footage to the encoder that is the bottleneck, not the encoder. Please optimize the reading of the ML files. The way things are now, it makes ML not serious at all, not even for fun. In fact, it takes all the fun away.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on August 08, 2020, 08:11:03 AM
Quote from: Eugenia on August 08, 2020, 03:26:14 AM
The way things are now, it makes ML not serious at all, not even for fun. In fact, it takes all the fun away.

This is not true!  I use MLVApp all the time, also for serious work and it does a hell of a job for me.  If you have a lot of footage to process, you can run several copies of the software simultaneously.  In such cases, I typically run 4 copies in parallel, everyone for a different part of the footage and this cuts the overall processing time by a factor of 4.  This apples to a PC with a 4-core processor.  With more cores you can do even better than that.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 08, 2020, 08:33:19 AM
@Eugenia:
Do you have any idea what you're talking about? The encoding takes less than 25% of the time. The "reading" of an MLV is faster than real time (for 25fps), even on a 10 years old computer with HDD. MLV contains RAW data. You can try sending RAW data to the encoder and tell me what you see. Wait... I can also tell you: You don't see anything - maybe digital noise with a little luck.
RAW data must be processed! The comparison to FCP is misleading, because FCP can't process RAW data (reasonably or at all).
Quote from: Eugenia on August 08, 2020, 03:26:14 AM
The way things are now, it makes ML not serious at all, not even for fun. In fact, it takes all the fun away.
If RAW processing is too slow for you and takes away the fun, you shouldn't use it. You'll have to decide between quality and speed.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on August 08, 2020, 01:37:52 PM
@Eugenia:
Image processing is the beast, it takes most of the time to get usable 16bit RGB data to encoder.
Everything can be improved and this is not an exception and can be optmised. Project is open source so feel free to help us improve the speed :).

Quote from: masc on August 08, 2020, 08:33:19 AM
RAW data must be processed! The comparison to FCP is misleading, because FCP can't process RAW data (reasonably or at
Agree with FCP statement completely.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Eugenia on August 10, 2020, 01:18:13 AM
Do you have any idea what you're talking about?

Yes.

The "reading" of an MLV is faster than real time ...

That statement is NOT true here. I tried it BOTH on a Windows (fast Xeon CPUs), and a maxed out Macbook Pro (2016).

I shot 4k anamorphic MLV using an EOS M (non-stretched resolution is in the ~1400 pixels range, can't recall it exactly now as I write this as i don't have the files with me), in 10bit, 1:39 ratio. So I did not even shoot in 14bit, just 10bit. I DID NOT process the files in any way. Just a straight export to prores (using the default ffmpeg settings as provided by mlv app). It was *very slow* on BOTH my computers. So, yeah, explain that. Why is it so painfully slow here while you claim that is real time for you?!?

The mlv files don't playback realtime on the mlvapp either btw.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 10, 2020, 10:40:38 AM
Quote from: Eugenia on August 10, 2020, 01:18:13 AM
The "reading" of an MLV is faster than real time ...

That statement is NOT true here. I tried it BOTH on a Windows (fast Xeon CPUs), and a maxed out Macbook Pro (2016).

I shot 4k anamorphic MLV using an EOS M (non-stretched resolution is in the ~1400 pixels range, can't recall it exactly now as I write this as i don't have the files with me), in 10bit, 1:39 ratio. So I did not even shoot in 14bit, just 10bit. I DID NOT process the files in any way. Just a straight export to prores (using the default ffmpeg settings as provided by mlv app). It was *very slow* on BOTH my computers. So, yeah, explain that. Why is it so painfully slow here while you claim that is real time for you?!?

The mlv files don't playback realtime on the mlvapp either btw.
The statement is very true. See: just reading a MLV is for nothing. As soon as you see an image, it MUST BE PROCESSED! And this needs time. MLV data can't be viewed without processing, because it is RAW!
Download the code and disable processing in code just after reading, and you'll see that you'll get more than 25fps with that - even on a 10 years old computer. The problem is, nobody needs MLV reading without processing or transcoding, because you can't do anything with that.
What bitdepth you use don't cares at all. Processing is always done in 16bit.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Eugenia on August 10, 2020, 10:46:07 AM
I just told you that this is not what happens here. I open the file in MLV app and it's VERY slow. It does not playback real time, as you suggest.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 10, 2020, 10:49:48 AM
Quote from: Eugenia on August 10, 2020, 10:46:07 AM
I just told you that this is not what happens here. I open the file in MLV app and it's VERY slow. It does not playback real time, as you suggest.
Please read again my posts. Nobody is saying that MLVApp PROCESSES ( = playback ) MLV files in realtime. I think you should read a lot in the forum to learn what RAW footage is and how to handle it.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Eugenia on August 10, 2020, 11:50:25 PM
I've been shooting RAW for years with other cinema cameras without ANY such issues. BRAW from Blackmagic completely flies, for example. So is ARRIRAW.

Are you telling me that something special needs to be done inside the mlv app after loading the file, to make the raw file playback faster? If yes, then what is that special thing? Will that make the prores export faster? Because the way things are now, it's *dead slow*. And I've tried playing with the raw settings and change things around (e.g. removing AF points, getting back highlights etc), but the speed did NOT improve.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 12georgiadis on August 11, 2020, 03:13:17 AM
Quote from: Eugenia on August 10, 2020, 11:50:25 PM
I've been shooting RAW for years with other cinema cameras without ANY such issues. BRAW from Blackmagic completely flies, for example. So is ARRIRAW.

Are you telling me that something special needs to be done inside the mlv app after loading the file, to make the raw file playback faster? If yes, then what is that special thing? Will that make the prores export faster? Because the way things are now, it's *dead slow*. And I've tried playing with the raw settings and change things around (e.g. removing AF points, getting back highlights etc), but the speed did NOT improve.
If you want speed, just go with fastcinemadng. It reads MLV via CUDA and is faster. Here everything is processed by CPU. BRAW = CPU+GPU, that's why it's faster.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 11, 2020, 01:27:28 PM
Quote from: Eugenia on August 10, 2020, 11:50:25 PM
I've been shooting RAW for years with other cinema cameras without ANY such issues. BRAW from Blackmagic completely flies, for example. So is ARRIRAW.
And why don't you use these cameras if they work so fine? You really compare the most expensive professional solutions with open source free time projects? And then you cry because the professional solution is faster?

The only Blackmagic cameras you can really compare to ML record cDNG. This footage brings exactly the same speed using exactly the same applications (e.g. Resolve). BRAW is partially preprocessed and works differently.

But I'll stop now to answer and to explain, because it seems you still have nothing read I wrote, still have nothing understood I wrote, but you're still rumbling.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Eugenia on August 12, 2020, 12:44:13 AM
If you want speed, just go with fastcinemadng.

This won't fix the AF points or help me with other MLV-specific raw fixes though. It's not really a full solution. The only app with the proper raw controls is MLV app. That's where Cuda needs to be added (along other optimizations, let's not put all the blame to the lack of GPU support).

And why don't you use these cameras if they work so fine?

Because I also own an EOS M camera, so I'd like to use it too.

The only Blackmagic cameras you can really compare to ML record cDNG. This footage brings exactly the same speed using exactly the same applications (e.g. Resolve). BRAW is partially preprocessed and works differently.

I also own the original BMPCC, so I have worked with CDNG too. It's miles faster than MLV.

But I'll stop now to answer and to explain, because it seems you still have nothing read I wrote, still have nothing understood I wrote, but you're still rumbling.

No, I'm not. I have provided the information needed to get to the bottom of this. I simply reported that is slow to decode and export. I provided my setup. Instead, your replies have been "mlv is very fast, you're an idiot", only to change the tune later to "mlv is not as fast as in other raw pro cameras, you're rambling". You're the one who does not offer a lucid reply or solution. You're just angry that I badmouthed your beloved MLV App. That's all there is to it. Blind loyalism. Well, I'm not loyal to any app or camera.

And no, I don't accept replies to the type of "this is just open source". ML is an 8 year old project by now. Some form of software maturity should have been evident by now. Also: I've been using Linux since 1999. So I'm not some newbie who doesn't understand OSS. But I'm also --again-- not a loyalist to anyone. I'm a realist, and a very practical person. If something doesn't work adequately, I'm not going to give it props just for being open source. That's NOT a feature in my opinion. It's a political aspect of it, but not a software feature that makes work get done. I rather pay $50 and have it work better.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on August 12, 2020, 05:20:26 AM
@Eugenia - in case you're not aware, you're coming across as aggressive and rude.  It's fine to want things to be better, but your tone is making other people defensive.

There's no need to insult others here (including the people that made the software you use, and gave it to you for free!).  If you express what you want politely, you'll get better responses.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Volumetrik on August 12, 2020, 06:05:28 AM
Quote from: Eugenia on August 12, 2020, 12:44:13 AM
And no, I don't accept replies to the type of "this is just open source". ML is an 8 year old project by now. Some form of software maturity should have been evident by now. Also: I've been using Linux since 1999. So I'm not some newbie who doesn't understand OSS. But I'm also --again-- not a loyalist to anyone. I'm a realist, and a very practical person. If something doesn't work adequately, I'm not going to give it props just for being open source. That's NOT a feature in my opinion. It's a political aspect of it, but not a software feature that makes work get done. I rather pay $50 and have it work better.

You illustrated your own solution.

pay $50 and have it work better

No one forces you to use open source software created by a team of volunteers, on cameras which were not initially intended to have any of these features, on a forum where information is freely available to learn.

Your tone comes off like someone who did not receive what they paid for.

Did you pay for any of this ?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 12, 2020, 07:08:48 AM
Try work with ae and then post your complaints to adobe @Eugenia.
Mlv App is a high end batch tool. Do copies of the app if you want multiprocessing.
You also seem to think coding gpu based processing is trivial. Think again. Not even strong funded adobe nor resolve reads dng  streams close to realtime. Only one I see effectively fixing that is A. Baldwin(MlRawVewer). Another open source project.
Talking open source. The beauty here is that you can get all code and rework anything you want. You could  even pay someone to do it for you. A much better contribution for everybody.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: megapolis on August 12, 2020, 01:18:33 PM
Quote from: Eugenia on August 12, 2020, 12:44:13 AM
If you want speed, just go with fastcinemadng.

This won't fix the AF points or help me with other MLV-specific raw fixes though. It's not really a full solution. The only app with the proper raw controls is MLV app. That's where Cuda needs to be added (along other optimizations, let's not put all the blame to the lack of GPU support).

This is not correct. In the Fast CinemaDNG Processor software there is a module to suppress AF points. You just need to close current project and go to Option dialog, choose MLV tab and mark "Fix focus dots". If it doesn't work, please send us your MLV file for evaluation.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: fsr on August 16, 2020, 04:37:43 PM
Hi,

I have a Canon 600D, and every time i try to open a MLV File, MLV App crashes with the error "segmentation fault". The OS is MX Linux (it's Debian-based), so i'm running MLV App as an AppImage. Is there something i can make it work? Here some system info:


System:    Host: mx Kernel: 4.19.0-6-amd64 x86_64 bits: 64 Desktop: Xfce 4.14.2
           Distro: MX-19.2_x64 patito feo February 15  2020
Machine:   Type: Desktop Mobo: ASUSTeK model: M3A78-EM v: Rev X.0x serial: <root required> BIOS: American Megatrends
           v: 2701 date: 10/08/2010
CPU:       Topology: Quad Core model: AMD Phenom II X4 955 bits: 64 type: MCP L2 cache: 2048 KiB
           Speed: 800 MHz min/max: 800/3200 MHz Core speeds (MHz): 1: 800 2: 800 3: 800 4: 800
Graphics:  Device-1: Advanced Micro Devices [AMD/ATI] Redwood XT [Radeon HD 5670/5690/5730] driver: radeon v: kernel
           Display: x11 server: X.Org 1.20.4 driver: ati,radeon unloaded: fbdev,modesetting,vesa
           resolution: 1680x1050~60Hz
           OpenGL: renderer: AMD REDWOOD (DRM 2.50.0 / 4.19.0-6-amd64 LLVM 7.0.1) v: 3.3 Mesa 18.3.6
Audio:     Device-1: Advanced Micro Devices [AMD/ATI] Redwood HDMI Audio [Radeon HD 5000 Series]
           driver: snd_hda_intel
           Device-2: Creative Labs EMU10k1 [Sound Blaster Live! Series] driver: snd_emu10k1
           Sound Server: ALSA v: k4.19.0-6-amd64
Network:   Device-1: Realtek RTL8111/8168/8411 PCI Express Gigabit Ethernet driver: r8169
           IF: eth0 state: up speed: 1000 Mbps duplex: full
Drives:    Local Storage: total: 1.82 TiB used: 956.45 GiB (51.3%)
           ID-1: /dev/sda vendor: Western Digital model: WD10EZEX-21WN4A0 size: 931.51 GiB
           ID-2: /dev/sdb vendor: Western Digital model: WD10EZEX-21WN4A0 size: 931.51 GiB
Partition: ID-1: / size: 386.84 GiB used: 92.86 GiB (24.0%) fs: ext4 dev: /dev/sda4
           ID-2: swap-1 size: 7.63 GiB used: 4.5 MiB (0.1%) fs: swap dev: /dev/sda6
Sensors:   System Temperatures: cpu: 39.0 C mobo: N/A gpu: radeon temp: 27 C
           Fan Speeds (RPM): N/A gpu: radeon fan: 0
Info:      Processes: 209 Uptime: 2h 04m Memory: 7.79 GiB used: 3.05 GiB (39.2%) Shell: bash inxi: 3.0.36


I did a google search on this error, but didn't find much about it for this application.

The MLV video is 640x480 to keep the rate under what the camera can handle.

Regards
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on August 23, 2020, 02:33:01 PM
@fsr

Recently we, together with masc, fixed one old bug which caused crashes on MLV importing. It has to be the version you used (AppImage?) does not have that fix. If you can, try to compile latest mlvapp from repository. This should help resolve your issue.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on August 23, 2020, 05:24:10 PM
deleted
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: voglovas on August 24, 2020, 12:24:46 PM
Hello,
I'm linux (Fedora 32) user.
I have downloaded Appimage, and made permission for executing (chmod a+x...) but nothings happened when i tried to start application.
When I try over terminal i get this - ./MLV.App.v1.11.Linux.x86_64.AppImage: error while loading shared libraries: libnsl.so.1: cannot open shared object file: No such file or directory
I have installed libnsl, but nothing has changed

Any advise?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 25, 2020, 07:51:12 AM
Please don't double post. The question was already asked here: https://github.com/ilia3101/MLV-App/issues/211
It seems the dependencies in Fedora are different than in Ubuntu. You'll have to compile the App on your own, or use e.g. Ubuntu. I expect this a bug in linuxdeployqt, which should include all needed libraries. Maybe this helps: https://github.com/AppImage/pkg2appimage/issues/336
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on August 26, 2020, 08:18:07 AM
Quote from: voglovas on August 24, 2020, 12:24:46 PM
When I try over terminal i get this - ./MLV.App.v1.11.Linux.x86_64.AppImage: error while loading shared libraries: libnsl.so.1: cannot open shared object file: No such file or directory

The MLVapp appimage for Linux is sort of messy.  It contains two binaries that are different, and one of them commonly gives errors similar to the one you mentioned, although I suspect that the problem might also involve Fedora's removal of the library in question, to which @masc linked.

Try extracting the appimage (which creates the "squashfs-root/" directory containing all files), and then run the MLVapp binary that usually doesn't give the dependency errors:
$ ./MLV.App.v1.11.Linux.x86_64.AppImage --appimage-extract
$ ./squashfs-root/usr/bin/mlvapp

If you still get the same error on the missing library, try copying the library from where it resides on your Fedora install into the newly extracted lib directory:

$ cp -ivp /path/to/your/fedora/library squashfs-root/usr/lib/

Now, try running the MLVapp binary again:
$ ./squashfs-root/usr/bin/mlvapp


Quote from: voglovas on August 24, 2020, 12:24:46 PM
I have installed libnsl, but nothing has changed
If the above steps don't work, make sure that you have the specified version of the needed library(s).  If you are using another version of the library, install the needed version and repeat the above steps.


If none of these steps work, you could also try the same commands above with the usually problematic MLVapp binary and see what happens. To start that binary, do this:
$ ./squashfs-root/mlvapp

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jetrotal on September 12, 2020, 05:35:32 PM
Hey guys, any plans on improving the render workflow?

I've been testing DuMe, an opensource alternative to Adobe's Media Encoder.
It uses the same tools and framework as MLV App,
and includes tons of render settings and presets that could boost MLV App's rendering experience.

Here's a demo of it:


and Here's their Repo:
https://github.com/Rainbox-dev/DuME
https://rainboxlab.org/tools/dume/

It would be nice to have a way to queue MLVapp project files directly inside DuMe,
or to have part of DuMe's UI + Output Settings inside MLV App.

What do you think?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 12, 2020, 06:00:30 PM
Thanks for the links. But what do you mean with same tools and frameworks? Qt and FFMPEG won't speed up anything. MLVApp has a very unique processing engine. I don't think it will get much faster soon.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: jetrotal on September 12, 2020, 06:14:44 PM
My bad! I thought both were made using Qt and FFMPEG.

Maybe i'm just too attached to the typical UX from render and media encoder apps.

I feel like the overall render experience on MLV App is a little funky,
with the limited preset panels and render settings...

And feels a little bit unnatural the way MLV app freezes while rendering, leaving the user with a progress bar and a Terminal/CMD running in background.

These may be just nitpicking, but something closer to AME or DuMe, or a way to send the rendering file with the color corrections settings to DuMe would be nice.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 12, 2020, 06:25:56 PM
Quote from: jetrotal on September 12, 2020, 06:14:44 PM
My bad! I thought both were made using Qt and FFMPEG.
So far, so right, but this is not used for processing.
Quote from: jetrotal on September 12, 2020, 06:14:44 PM
I feel like the overall render experience on MLV App is a little funky,
with the limited preset panels and render settings...
What do you mean with funky? And what is limited? Other guys say there are way to much features... :D
Quote from: jetrotal on September 12, 2020, 06:14:44 PM
And feels a little bit unnatural the way MLV app freezes while rendering, leaving the user with a progress bar and a Terminal/CMD running in background.
If you get freezes, please install a debugger and tell us where it freezes. This could help to fix such behavior. Never got any freeze in the past year on all my computers.
For the terminal/CMD window you must tell your thanks to Microsoft - it is a Windows only feature. All other OS are able to run external apps without this ugly window (and tunnel data to them).
Quote from: jetrotal on September 12, 2020, 06:14:44 PM
These may be just nitpicking, but something closer to AME or DuMe, or a way to send the rendering file with the color corrections settings to DuMe would be nice.
As far as I can see in the demo, DuMe does no processing at all. It just configures FFMPEG to transcode into another codec. This is something very different.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 13, 2020, 12:01:12 PM
with danne's amazing new 3.5k mode, the need for constant use of card spanning is unavoidable now.  is there any chance of getting support for reading from both cards in mlv app?
copying all the source files into the same directory just to get started becomes a real problem in workflow.

thanks :)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 13, 2020, 12:45:27 PM
On mac this could be done fast with aliasing files. I´ll test some aorund mlv_dump on this theme.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 13, 2020, 12:59:34 PM
that is a great suggestion.  i'll test to see if this can work on windows using "libraries".
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 13, 2020, 01:16:41 PM
One idea is to Be able and drag the two cards straight onto Mlv App. This could itself activate a question if you want to enable card spanning routine or similar. Other way around enabling the function from withing Mlv App too would work. Question remains if this is worth the hassle or not.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 13, 2020, 01:47:30 PM
it's absolutely worth the hassle.  dealing with an extra pile of storage space and the time associated with the extra copying of all these large files is rather severe.

unfortunately, windows "libraries" does not support removable media.  i wonder if there is a third party alternative that can do this.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 13, 2020, 02:02:10 PM
Don't think you know what aliasing files are here?
Anyway. Think it's up to masc or ilia3101 what to do here.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 13, 2020, 02:14:59 PM
probably not!  i haven't used a mac since i had one as the front end for my hard disc recorder in the studio back in the 1990s :P

but it made me think of the "libraries" idea and hopefully i will find another workaround, so your inspiration is most appreciated ;)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on September 14, 2020, 12:10:03 AM
Quote from: Danne on September 13, 2020, 02:02:10 PM
Don't think you know what aliasing files are here?
Is "alias" a cute Apple name for what is merely a symbolic link?

@70MM13
In a single Windows folder/directory, you can create a batch of symbolic links to the files on both cards by
doing something like this (https://stackoverflow.com/questions/22322794/how-do-i-create-a-symbolic-link-using-a-batch-script-in-windows/22322934#22322934).

Of course, it would be ideal if MLV App simply had built-in functionality to load files from different directories/folders.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 14, 2020, 05:27:49 AM
unless my memory is incorrect, this option doesn't support exfat.

is there a way around that?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on September 14, 2020, 07:57:05 AM
I don't use Windows, but I think that you can link from non-exfat filesystems to target files/directories in an exfat filesystem.  It seems to be working for this poster (https://arstechnica.com/civis/viewtopic.php?t=1137559).

It's easy enough to try on a test file (with a test card).

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 14, 2020, 08:47:20 AM
Crude example of a dual card workflow using symlinks on mac:
https://bitbucket.org/Dannephoto/switch_mini-git/commits/db5140d40a1240a213a68a8a81dd2c6147cf8faf

Mainly this:
card1="$(cat ~/Library/Preferences/Dannephoto/folder_paths.txt | awk 'FNR == 1')"
card2="$(cat ~/Library/Preferences/Dannephoto/folder_paths.txt | awk 'FNR == 2')"
ln -s $(find "$card1" -iname '*.M*') /tmp/switchmini/cardspan
ln -s $(find "$card2" -iname '*.M*') /tmp/switchmini/cardspan

Throw all symlinks into a tmp folder and start working from there. Should be possible to handle this similarly in Mlv App.

The issue transcoding from cards is it´s not exactly fast and it doesn´t help that card spanning is mostly used with heavy resolution presets.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 14, 2020, 12:12:24 PM
i did the test some time back.  i tried again and even with links to links to links it still fails.  whether it is symlink commands alone, or "libraries" that use those symlinks, it says "local ntfs only"

:(
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on September 14, 2020, 06:37:00 PM
Quote from: 70MM13 on September 14, 2020, 12:12:24 PM
i tried again and even with links to links to links it still fails.
That sounds more complex than it needs to be.

The Windows mklink command is very simple.  If you can make it work with a single file on your exfat card, you are golden.

Just in case you haven't tried this, here is the command to test on the Windows command line (I think that you have to be root/administrator):
mklink  C:\link\on\ntfs\drive  E:\file\on\exfat\card

Of course, change the "E:" to whatever drive letter corresponds to your exfat card.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 14, 2020, 06:51:47 PM
Yeah. Could be done with an external script. Not even needed to touch Mlv App. Just run the symlinks in mlv app directly.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 15, 2020, 02:25:33 AM
i began with that simple version, but when it failed i tried more extravagant means, but nothing got me past the exfat brick wall...

edit: i've made a bit of progress.  the ntfs error message was totally misleading.  the issue is with trying to merge the directories.  after doing some research i found that windows doesn't support it at all:

https://en.wikipedia.org/wiki/Union_mount

but i did find this:

https://github.com/derbylock/MergeFS

does this look like it can be compiled?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on September 15, 2020, 04:12:26 AM
Quotethe issue is with trying to merge the directories.

Keep in mind, the idea is to link a single file -- not a directory.  In addition, merging directories is not necessary if you can link a single file.

Also, when you got the error, was the exfat card mounted and were you the administrator when you tried to link the file?


Quotebut i did find this:  https://github.com/derbylock/MergeFS  does this look like it can be compiled?
I don't know.  I would be careful running this.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 15, 2020, 04:30:16 AM
i'm a little lost... how would linking a single file get mlvapp to read from two cards?  i was linking directories, not files.  am i missing the goal?

the exfat cards are always mounted while i am testing, and i am running the command prompt as admin.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on September 15, 2020, 05:26:23 AM
If you can successfully link a single file (not a directory) from an exfat card using this command:
mklink  C:\link\on\ntfs\drive  E:\single-file\on\exfat\card

... then you can simply batch link into a single directory on your C:\ drive all of the files (not directories) from "Card A", along with all of the files (not directories) from "Card B".

So, all of the camera files on both cards will be individually linked within a single directory on your C:\ drive.

The batch command/script to use would be something like the commands/scripts suggested in this thread (https://stackoverflow.com/questions/22322794/how-do-i-create-a-symbolic-link-using-a-batch-script-in-windows/22322934#22322934).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 15, 2020, 04:58:21 PM
thanks for the help!  i got it working!

i wrote a very simple batch file for other windows users to use:  (input it as a text file and then save as filename.BAT)
right click on the icon and choose "run as administrator"

@echo on

SET SrcRoot1=L:\DCIM\100EOS5D
SET SrcRoot2=S:\DCIM\100EOS5D
SET TargetRoot=A:\MLVSDCF

FOR %%A IN ("%SrcRoot1%\*") DO (MKLINK "%TargetRoot%\%%~NXA" "%%~A")

FOR %%A IN ("%SrcRoot2%\*") DO (MKLINK "%TargetRoot%\%%~NXA" "%%~A")

PAUSE
EXIT


it's obviously set for my paths, so adjust to your specific settings.  make sure to create the destination directory before running the batch!

i'm using a ramdisk as drive A, which is a convenient place to stick random junk like a pile of shortcuts for a single use :)

tested with mlvapp and it worked!!

i hope it comes in handy for other magic lantern users as well :)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on September 16, 2020, 08:51:29 AM
Glad to hear that it worked!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on September 16, 2020, 06:37:08 PM
By the way, your script appears to be creating hard links (instead of symbolic links).

When you delete those hard links, do the target files (the camera files on your card) also get deleted?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 16, 2020, 07:20:30 PM
i specifically created hard links to ensure that mlvapp will recognize the files from both cards.

my initial test using "libraries" failed.  mlvapp didn't "see" the m00 files.
i took it to mean that soft links are insufficient for mlvapp, so i just went straight for hard links in the script.

but with your question, i went back and changed the script to soft links and it still works.

so i can't say why "libraries" don't work, and i suppose at this point i don't care ;)

thanks for the suggestion!

i will revise the code in the message to be soft links to avoid potential confusion by putting up a new version...

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on September 16, 2020, 08:05:28 PM
My concern was that if someone used the script with the hard link flag, that they would inadvertently/automatically delete the camera files on the cards when the hard links were deleted.  Symbolic links tend to avoid that problem.

By the way, what is the purpose of using the directory symbolic link flag ("/D") with the mlink command?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on September 17, 2020, 02:32:13 AM
the same... i was overcompensating for the failure of "libraries".
i just checked and it works without them, so another slim down!

thanks :)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Teamsleepkid on September 18, 2020, 02:12:10 AM
Haven't been keeping up with mlv app in a long time and there's absolutely tons of settings. What's everybody using? Amaze? Bilinear? Apple av foundation? Zeek probably has a recommendation I'm sure.. What seems to be fast export with good quality? Thanks
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 18, 2020, 08:05:39 AM
Always just use what you need to use, and what the footage makes looking like you want it. If you need good quality, it will mostly be slow. If it is fast, quality will mostly be bad.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on September 18, 2020, 09:10:06 AM
Quote from: masc on September 18, 2020, 08:05:39 AM
Always just use what you need to use, and what the footage makes looking like you want it. If you need good quality, it will mostly be slow. If it is fast, quality will mostly be bad.

I absolutely agree.  And never wait for MLVApp to finish its work.  Batch processing works perfectly on it.  Just apply your best settings, let it run and do something else in that time.  For lots of clips I usually let several copies (typically 3 or 4) work at the same time, each processing a different group of clips.  This makes rendering much faster and saves you a lot of time even on a laptop.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Teamsleepkid on September 18, 2020, 07:18:57 PM
I've been trying all the different options. I guess my problem is I have pink frames green frames trashed frames in 5k anamorphic mode. Doesn't seem to happen in the new 1:1 mode. Don't know if it's the 5k mode doing it? Or mlv app? Or maybe it's because I'm running dos dude patch on a 2011 Mac Pro and my little intel 3000 can't handle anything above 1080p raw. Anyone else have problems in 5k?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 18, 2020, 07:23:24 PM
5k what cam? Upload a mlv file. Your SETTINGS folder from cam? Guesswork otherwise.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Teamsleepkid on September 18, 2020, 11:45:13 PM
Never mind it must be some kind of computer problem. Really strange. I downloaded vlc and the garbage frames are gone. Seemed like it must have been QuickTimes fault. But strangely after I got vlc my QuickTime started working again. It's like something in the vlc package fixed QuickTime.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on September 24, 2020, 06:49:17 AM
Often Saving/Importing Receipt/Sessions fails, due to corrupted files.
MLVApp 1.11
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 24, 2020, 03:47:37 PM
Quote from: Quentin on September 24, 2020, 06:49:17 AM
Often Saving/Importing Receipt/Sessions fails, due to corrupted files.
MLVApp 1.11
From where do you get corrupted Receipt/Session files? What failes and how it failes?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on September 24, 2020, 08:16:35 PM
Quote from: masc on September 24, 2020, 03:47:37 PM
From where do you get corrupted Receipt/Session files? What failes and how it failes?

When saving sessions, I save twice with different names.
A couple of times, saving came out corrupted.
Recently I saved Receipt file and tried to Import it later.
It wasnt as responsive as I expected.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 24, 2020, 08:50:12 PM
What means corrupted? Do you have an example file?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on September 24, 2020, 11:36:17 PM
A few questions on exporting in MLV app.

Gear: 5D2 and reddeercity's latest Crop_rec build.

My goal is to get a file in a log gamma, as if it came straight out of camera that shoots log.

I have read the wiki here on export settings: https://github.com/ilia3101/MLV-App/wiki#export-settings

Heres the scenario,
-I import an MLV. I leave exposure alone, even if it was under/over exposed. I only adjust white balance if needed.
-Under "profiles" I select the "BMD Film" preset. (Does anyone have a suggestion of a "tonemapping" and "processing gamut" combination?)
-I leave "Allow Creative Adjustments" disabled.
-I leave "Gamma" set to "1.00"

Question 1: I kind of understand what the options under "Camera Matrix" do. But am still a little fuzzy. What are the benefits to "Use Camera Matrix" vs "Don't Use Camera Matrix"?
Question 2: Does leaving "Gamma" set to "1.00" basically mean MLV App won't make any adjustments? How is this different than using the exposure slider? What are the benefits to this adjustment?
Question 3: When selecting "Apple ProRes 4444," which "ffmpeg" selection should I select of the options? Options are "ffmpeg Kostya," "ffmpeg Anatolyi," and "Apple AVFoundation." What are the benefits?

Thanks all!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 25, 2020, 01:09:13 PM
Quote from: Milk and Coffee on September 24, 2020, 11:36:17 PM
Question 1: I kind of understand what the options under "Camera Matrix" do. But am still a little fuzzy. What are the benefits to "Use Camera Matrix" vs "Don't Use Camera Matrix"?
Question 2: Does leaving "Gamma" set to "1.00" basically mean MLV App won't make any adjustments? How is this different than using the exposure slider? What are the benefits to this adjustment?
Question 3: When selecting "Apple ProRes 4444," which "ffmpeg" selection should I select of the options? Options are "ffmpeg Kostya," "ffmpeg Anatolyi," and "Apple AVFoundation." What are the benefits?
1. Camera Matrix = Color calibration. Use = On, Don't use = Off. More info: https://github.com/ilia3101/MLV-App/wiki#camera-matrix
2. No. MLVApp always applies a curve to the RAW data, otherwise the result would look "strange". Gamma is one parameter of the math beeing done. Some more info: https://github.com/ilia3101/MLV-App/wiki#5-processing-pipeline
3. ProRes4444 is available in Kostya (ffmpeg) and AVFoundation (Apple). It are just two different implemenations. ffmpeg is 10bit, Apple is 12bit. ffmpeg is available for all OS, Apple version is for OSX only.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on September 25, 2020, 02:50:20 PM
Quote from: masc on September 24, 2020, 08:50:12 PM
What means corrupted? Do you have an example file?

Unfortunately not.
I consider the first time as an accident.
When it happened again it seemed serious.
As far as I remember, one of the cases was "Save on Exit" that generated a corrupted file.
I promise next time to keep the result in order to submit it to you.

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 25, 2020, 03:22:51 PM
@Quentin: yes, please send it to me, if it happens again. I never saw any corrupted session file, so I don't know what could be corrupted there. There is just one single save session function, so it don't cares from where it is called.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: clubsoda on September 28, 2020, 11:39:20 PM
i experience an awkward issue on my macbook pro late 2014. When i connect a monitor over hdmi the image of mlv app displays more red tones / colors change slightly from the result of the export. It happens only to mlvp app and can be reproduced by removing or connecting hdmi monitor. when the monitor is not connected the colors in the preview are the same as export (with prores for example). This change is only visable in mlv app so i thin it's a bug or i did something wrong. Color space on my mac is not the issue here i guess...

edit: the problem i found tends to have affect on the whole mlv app user interface for example color of the ui like the filname markings get more vibrant when hdmi connected

is this a known bug? don't work on colors (on main macbook monitor) with hdmi monitor connected
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 29, 2020, 01:52:54 PM
Sounds strange. But MLVApp does not care about monitors or screens or color profiles. This is 100% task of the operating system ( --> OSX ) or the monitor itself. OSX system preferences handles screen color calibration and color profiles.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: clubsoda on September 30, 2020, 10:19:51 AM
Quote from: masc on September 29, 2020, 01:52:54 PM
Sounds strange. But MLVApp does not care about monitors or screens or color profiles. This is 100% task of the operating system ( --> OSX ) or the monitor itself. OSX system preferences handles screen color calibration and color profiles.

Seems like it's OSX yes, i am still on latest Mojave build but i couldn't figure out the problem yet, display settings seems normal too. Will report back if i find anything further until then i need to disconnect my external monitor while looking at the colors. No problem as i still use the internal monitor for that anyway. Thanks for answering :)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: koopg on September 30, 2020, 04:48:22 PM
along time ago I've asked for "spydercheckr 24" presets file support for nailing color from within mlvapp
some dev asked for a file example.

this is the preset file content made for lightroom

s = {
id = "C77A6296-B58D-0B4D-94CC-2140587CC5BC",
internalName = "<NameOfPreset>",
title = "5D3Helius44_2_InSide_Day_Portrait",
type = "Develop",
value = {
settings = {
ConvertToGrayscale = false,
EnableColorAdjustments = true,
HueAdjustmentAqua = -17,
HueAdjustmentBlue = 10,
HueAdjustmentGreen = -20,
HueAdjustmentMagenta = 16,
HueAdjustmentOrange = 0,
HueAdjustmentPurple = 12,
HueAdjustmentRed = 2,
HueAdjustmentYellow = -2,
LuminanceAdjustmentAqua = 0,
LuminanceAdjustmentBlue = -15,
LuminanceAdjustmentGreen = -10,
LuminanceAdjustmentMagenta = -10,
LuminanceAdjustmentOrange = -4,
LuminanceAdjustmentPurple = -9,
LuminanceAdjustmentRed = -14,
LuminanceAdjustmentYellow = -6,
ParametricDarks = 0,
ParametricHighlightSplit = 75,
ParametricHighlights = 0,
ParametricLights = 0,
ParametricMidtoneSplit = 50,
ParametricShadowSplit = 25,
ParametricShadows = 0,
SaturationAdjustmentAqua = -17,
SaturationAdjustmentBlue = -10,
SaturationAdjustmentGreen = -7,
SaturationAdjustmentMagenta = 0,
SaturationAdjustmentOrange = -14,
SaturationAdjustmentPurple = -11,
SaturationAdjustmentRed = -4,
SaturationAdjustmentYellow = -7,
ToneCurve = {
0,
0,
32,
22,
64,
56,
128,
128,
192,
196,
255,
255,
},
ToneCurveName = "Medium Contrast",
},
uuid = "AFC5AB6B-ECC4-7648-AA9C-F37C5728F57C",
},
version = 0,
}

is this possible to add this possibility ?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on October 01, 2020, 09:14:47 AM
Quote from: masc on September 25, 2020, 01:09:13 PM

2. No. MLVApp always applies a curve to the RAW data, otherwise the result would look "strange".

So is it impossible to convert mlv to dng with MLVApp without a curve applying like raw2dng.exe?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 01, 2020, 09:17:57 AM
Quote from: vstrglv on October 01, 2020, 09:14:47 AM
So is it impossible to convert mlv to dng with MLVApp without a curve applying like raw2dng.exe?
What curve is applied with raw2dng you mean? Whatever information applied into the dng it´s only instruction information(metadata) which will or will not be active depending on nle.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on October 01, 2020, 09:25:56 AM
I mean that raw2dng does not apply any curve, but MLVApp does.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 01, 2020, 09:28:37 AM
Quote from: vstrglv on October 01, 2020, 09:25:56 AM
I mean that raw2dng does not apply any curve, but MLVApp does.
1 - Upload two unaltered dng files exported with both programs for others to examine.
2 - What program did you use checking your dng files?
3 - If possible upload images demoeing what you see.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 01, 2020, 09:49:44 AM
Quote from: vstrglv on October 01, 2020, 09:25:56 AM
I mean that raw2dng does not apply any curve, but MLVApp does.
Please read the entire post and the relating questsion. We were talking about ProRes export. MLVApp applies curves for non-RAW export only. RAW is and will be RAW. There is no curve applied on DNG.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on October 01, 2020, 11:34:55 AM
Thank you both! I understand now.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 01, 2020, 12:42:44 PM
Quote from: koopg on September 30, 2020, 04:48:22 PM
along time ago I've asked for "spydercheckr 24" presets file support for nailing color from within mlvapp
some dev asked for a file example.

this is the preset file content made for lightroom

s = {
id = "C77A6296-B58D-0B4D-94CC-2140587CC5BC",
internalName = "<NameOfPreset>",
title = "5D3Helius44_2_InSide_Day_Portrait",
type = "Develop",
value = {
settings = {
ConvertToGrayscale = false,
EnableColorAdjustments = true,
HueAdjustmentAqua = -17,
HueAdjustmentBlue = 10,
HueAdjustmentGreen = -20,
HueAdjustmentMagenta = 16,
HueAdjustmentOrange = 0,
HueAdjustmentPurple = 12,
HueAdjustmentRed = 2,
HueAdjustmentYellow = -2,
LuminanceAdjustmentAqua = 0,
LuminanceAdjustmentBlue = -15,
LuminanceAdjustmentGreen = -10,
LuminanceAdjustmentMagenta = -10,
LuminanceAdjustmentOrange = -4,
LuminanceAdjustmentPurple = -9,
LuminanceAdjustmentRed = -14,
LuminanceAdjustmentYellow = -6,
ParametricDarks = 0,
ParametricHighlightSplit = 75,
ParametricHighlights = 0,
ParametricLights = 0,
ParametricMidtoneSplit = 50,
ParametricShadowSplit = 25,
ParametricShadows = 0,
SaturationAdjustmentAqua = -17,
SaturationAdjustmentBlue = -10,
SaturationAdjustmentGreen = -7,
SaturationAdjustmentMagenta = 0,
SaturationAdjustmentOrange = -14,
SaturationAdjustmentPurple = -11,
SaturationAdjustmentRed = -4,
SaturationAdjustmentYellow = -7,
ToneCurve = {
0,
0,
32,
22,
64,
56,
128,
128,
192,
196,
255,
255,
},
ToneCurveName = "Medium Contrast",
},
uuid = "AFC5AB6B-ECC4-7648-AA9C-F37C5728F57C",
},
version = 0,
}

is this possible to add this possibility ?
Hm... sorry... I really don't know what to do with these numbers. There is no relation or equation or something. The question is who does what with these settings?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on October 02, 2020, 10:00:54 AM
Recently I had a serious problem.
I use Canon 5d mk3 with 1.1.3 firmware together with ML and MLVApp.
Suddenly all my shots were overexposed and low contrast.
I thought that it was ML fault and after uploading a file to the forums and read the response, I concluded that somehow my MLVApp settings were faulty.
It had to do with RAW Black Level and White Level.
Its impossible for an average user to know all the insights of the code and the parameters involved.
I erased MLVApp and reinstalled it, nothing changed. I though that maybe MLVApp stores some hidden settings somewhere.
I wish there was a Reset to Default option for all settings.
Or what are the default settings for RAW Black Level and RAW White Level ?

Thanks in advance for any guidance
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 02, 2020, 10:36:58 AM
There's a reset button.
99 times out of 100 problem is solved when users provide good feedback. Imo, a description of perceptual issues without providing a sample mlv is not a good starting point trying to solve or learn.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 02, 2020, 10:50:48 AM
If your settings are faulty, why don't you use the default settings? Only you are able to know about your settings. There are no hidden settings. Maybe uncheck "use default receipt" in Edit menu (if checked, you can default load any faulty custom settings if you do it the wrong way).
For the average and newbe users, there is also a help included in the app which explains all parameters. The same can be found on github wiki.
Reset to default = Ctrl+Alt+R. RAW Black and White level is different for all cams and all bitdepths - so the (mostly) correct value is included in the MLV files metadata.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: andy kh on October 02, 2020, 11:23:43 AM
Quote from: Quentin on October 02, 2020, 10:00:54 AM

I wish there was a Reset to Default option for all settings.
Or what are the default settings for RAW Black Level and RAW White Level ?

Thanks in advance for any guidance

In the very begining of this page, there is a video tutorial. Check it out if you have any problem on how to use this App
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on October 02, 2020, 11:37:56 AM
Thank you all for your help.
No intention to blame anybody.
We are all contributing to the same goal.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on October 04, 2020, 12:00:41 AM
Quote from: masc on September 25, 2020, 01:09:13 PM
1. Camera Matrix = Color calibration. Use = On, Don't use = Off. More info: https://github.com/ilia3101/MLV-App/wiki#camera-matrix
2. No. MLVApp always applies a curve to the RAW data, otherwise the result would look "strange". Gamma is one parameter of the math beeing done. Some more info: https://github.com/ilia3101/MLV-App/wiki#5-processing-pipeline
3. ProRes4444 is available in Kostya (ffmpeg) and AVFoundation (Apple). It are just two different implemenations. ffmpeg is 10bit, Apple is 12bit. ffmpeg is available for all OS, Apple version is for OSX only.

Thanks for the info! Isn't gamma 1.0 linear?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 04, 2020, 11:52:41 AM
Quote from: Milk and Coffee on October 04, 2020, 12:00:41 AM
Thanks for the info! Isn't gamma 1.0 linear?
Gamma is one variable in the profile equation.
If the MLVApp profile is "Standard", the equation is:
outColor = inColor ^ (1/gamma)
while here gamma is 3.15 by standard. Other profiles are a bit more complicated... And gamma has different values for different profiles (often it is 1.0 as default).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: koopg on October 04, 2020, 09:22:53 PM
Quote from: masc on October 01, 2020, 12:42:44 PM
Hm... sorry... I really don't know what to do with these numbers. There is no relation or equation or something. The question is who does what with these settings?
Thank you for replying.

I thought it would be strait forward
In most cases
Example:
HueAdjustmentAqua = -17,
HueAdjustmentBlue = 10

I will try to research more

Sent from my SM-N975F using Tapatalk

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 04, 2020, 09:56:51 PM
Quote from: koopg on October 04, 2020, 09:22:53 PM
In most cases
Example:
HueAdjustmentAqua = -17,
HueAdjustmentBlue = 10
Hm... But what's the unit, what's the relation, in what point this has to be done ... and so on.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on October 05, 2020, 11:38:30 AM
@masc got golden replies numbering here:

Reply 4444  (https://www.magiclantern.fm/forum/index.php?topic=20025.msg231627#msg231627)from masc
Reply 3333  (https://www.magiclantern.fm/forum/index.php?topic=20025.msg220456#msg220456)from masc
Reply 1111  (https://www.magiclantern.fm/forum/index.php?topic=20025.msg199679#msg199679)from masc
Reply 2222  (https://www.magiclantern.fm/forum/index.php?topic=20025.msg207573#msg207573)from . . . me :P

I have two suggestions:
-We don't need to add more focus maps: (at least for 700D)

When 1:1 and 1x3 revolution was happening on 700D with increased RAW resolution, and when a1ex made crop_rec with arbitrary resolutions and Binning mode, I (or dfort?) figure out we only need one Map for each Binning mode in this case for 1:1 and 1x3, one map covers the whole focus pixels in each mode,

Back then I provided one sample for 1x3 Mode @ 1736x3478 and another sample for 1:1 Mode @ 5208x3478 to @dfort, he made two focus maps, one for 1x3 and one for 1:1 and they covers all focus pixels . .

And that what I am using today! 3K 1:1 focus map is the same as 1440p 1:1 focus map and same as 1920x1280p 1:1 but with different buffer size in naming, we just need to change the naming of the pixel map buffer size (including the black borders) to match MLV buffer size for each resolution in 1:1, when changing RAW resolution from crop_rec, buffer size would change too, we just don't need more focus pixel to be added for 1:1 and 1x3.

Same thing, All presets in 1x3 share the same focus map but with different naming.

I asked for this back then (https://www.magiclantern.fm/forum/index.php?topic=16054.msg207177#msg207177), we should only use one focus map and calculate the offsets from each MLV directly, Not sure if this possible?

-Open Collective (https://www.magiclantern.fm/forum/index.php?topic=24548.msg230929#msg230929) for MLVApp
Why not? :)

Ilia3101, masc and bouncyball would be the admins, collecting some donations e.g: to enhance MLVApp or fixing the known problems by hiring freelancers, also for getting CUDA or OpenCV (what ever) on MLVApp for faster processing, or you can work on new paid features (up to you) . .

Fortunately, there are no legal issues you need to be aware about.

I'd like to see MLVApp getting faster, maybe all of MLVApp users want that! I'd like to hear your opinions
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: SoulState on October 07, 2020, 02:05:04 AM
Great app, my deep respect to the developer!
But i have some requests to make this app a bit more functional:
1. Please make "Sharpness" slider effect at least twice stronger - i shoot raw with noticeable defocus to avoid aliasing, and current maximum sharpness is not enought to restore image details.
2. Multi-threaded export of clips (every clip on dedicated processor core)
3. In MLV Producer there is cool effect called "analog contrast" that emulates film contrast, adjustments with this effect looking very cool and pleasing! But sadly that app don't have that AMAZING AMAZE debayer algo, so for me it useless(( The only thing that lacks MLV App is that great analog film contrast...

Oh! And just forgotten - i have a bug -  buttons stop working after some time using app (My system is Win7 x64)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 07, 2020, 09:27:43 AM
Quote from: theBilalFakhouri on October 05, 2020, 11:38:30 AM
@masc got golden replies numbering here:

Reply 4444  (https://www.magiclantern.fm/forum/index.php?topic=20025.msg231627#msg231627)from masc
Reply 3333  (https://www.magiclantern.fm/forum/index.php?topic=20025.msg220456#msg220456)from masc
Reply 1111  (https://www.magiclantern.fm/forum/index.php?topic=20025.msg199679#msg199679)from masc
Reply 2222  (https://www.magiclantern.fm/forum/index.php?topic=20025.msg207573#msg207573)from . . . me :P
Haha... nice finding :)

Quote from: theBilalFakhouri on October 05, 2020, 11:38:30 AM
I have two suggestions:
-We don't need to add more focus maps: (at least for 700D)

When 1:1 and 1x3 revolution was happening on 700D with increased RAW resolution, and when a1ex made crop_rec with arbitrary resolutions and Binning mode, I (or dfort?) figure out we only need one Map for each Binning mode in this case for 1:1 and 1x3, one map covers the whole focus pixels in each mode,

Back then I provided one sample for 1x3 Mode @ 1736x3478 and another sample for 1:1 Mode @ 5208x3478 to @dfort, he made two focus maps, one for 1x3 and one for 1:1 and they covers all focus pixels . .

And that what I am using today! 3K 1:1 focus map is the same as 1440p 1:1 focus map and same as 1920x1280p 1:1 but with different buffer size in naming, we just need to change the naming of the pixel map buffer size (including the black borders) to match MLV buffer size for each resolution in 1:1, when changing RAW resolution from crop_rec, buffer size would change too, we just don't need more focus pixel to be added for 1:1 and 1x3.

Same thing, All presets in 1x3 share the same focus map but with different naming.

I asked for this back then (https://www.magiclantern.fm/forum/index.php?topic=16054.msg207177#msg207177), we should only use one focus map and calculate the offsets from each MLV directly, Not sure if this possible?
That sounds interesting. But is this really possible? Do we have the needed metadata in the MLV? I thought we just have the offsets from the raw stream to the recorded area. And with this we already do a kind of what you suggest, but not for the entire sensor - only for the different streams. But here we would additionally need the offset from sensor to recorded area (or to raw stream).

Quote from: theBilalFakhouri on October 05, 2020, 11:38:30 AM
-Open Collective (https://www.magiclantern.fm/forum/index.php?topic=24548.msg230929#msg230929) for MLVApp
Why not? :)

Ilia3101, masc and bouncyball would be the admins, collecting some donations e.g: to enhance MLVApp or fixing the known problems by hiring freelancers, also for getting CUDA or OpenCV (what ever) on MLVApp for faster processing, or you can work on new paid features (up to you) . .

Fortunately, there are no legal issues you need to be aware about.

I'd like to see MLVApp getting faster, maybe all of MLVApp users want that! I'd like to hear your opinions
Faster would be nice, but for that you would have to implement the entire processing from scratch with another architecture, with another programming language, and so on. Especially CUDA would take away the perfect compatibility of MLVApp - see all the CUDA apps out there: none of them runs on a simple notebook. And the openCL apps aren't really faster on simple notebooks as well. I don't know if it makes any sense to put so much effort in accelerating this app using another architecture, as long it processes 500GB MLVs over night (what it does already).

Quote from: SoulState on October 07, 2020, 02:05:04 AM
1. Please make "Sharpness" slider effect at least twice stronger - i shoot raw with noticeable defocus to avoid aliasing, and current maximum sharpness is not enought to restore image details.
This will give very ugly edges and won't bring back the detail. For that you would need kind of KI. Why not using a moiree free mode?

Quote from: SoulState on October 07, 2020, 02:05:04 AM
2. Multi-threaded export of clips (every clip on dedicated processor core)
We can just have one multi threading architecture, and in past we all decided to multithread single clip based processing, what also accelerated playback a lot. At this time this was a almost 100% rewrite of the processing and export methods and I don't think it is soo bad. You can try very old releases which exported with different multithreading.

Quote from: SoulState on October 07, 2020, 02:05:04 AM
3. In MLV Producer there is cool effect called "analog contrast" that emulates film contrast, adjustments with this effect looking very cool and pleasing! But sadly that app don't have that AMAZING AMAZE debayer algo, so for me it useless(( The only thing that lacks MLV App is that great analog film contrast...
Why don't you use our film emulation? In filter section are 4 different analog film emulations and some other filters. These filters work with trained neural networks.

Quote from: SoulState on October 07, 2020, 02:05:04 AM
Oh! And just forgotten - i have a bug -  buttons stop working after some time using app (My system is Win7 x64)
Don't know about this one. But I need more information: which buttons, what conditions, what means "stop working",...?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on October 08, 2020, 01:32:45 PM
Quote from: masc on October 04, 2020, 11:52:41 AM
Gamma is one variable in the profile equation.
If the MLVApp profile is "Standard", the equation is:
outColor = inColor ^ (1/gamma)
while here gamma is 3.15 by standard. Other profiles are a bit more complicated... And gamma has different values for different profiles (often it is 1.0 as default).

I spent long time trying to conclude what I did wrong.
I compare Canon native video recording, what I see in monitor, and what MLVApp reads from RAW
Based on metadata, my RAW Black Level was 2047 and RAW White Level at 6000.

On Profile Tab, I use Reinhard Tonemapping and Rec.709 for Processing Gamut.
However MLVApp starts with Gamma 3.5. Unless I drop it down to 2, my shots look Overexposed.
In the past, I never had such a problem. I wonder how come and MLVApp starts with these setting.
Is there a Default Profile Preset setting stored somewhere, or Gamma.
I tried MLV App 1.08 to see whether there was something different. Same treatment as MLVApp 1.11

Thanks for any reply
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 08, 2020, 01:40:07 PM
Quote from: Quentin on October 08, 2020, 01:32:45 PM
On Profile Tab, I use Reinhard Tonemapping and Rec.709 for Processing Gamut.
However MLVApp starts with Gamma 3.5. Unless I drop it down to 2, my shots look Overexposed.
Since the feature exists, the parameters never changed. For Reinhard, Gamma is and was always 3.5.

Quote from: Quentin on October 08, 2020, 01:32:45 PM
I wonder how come and MLVApp starts with these setting.
It is and was the default.

Quote from: Quentin on October 08, 2020, 01:32:45 PM
Is there a Default Profile Preset setting stored somewhere, or Gamma.
You can create your own default with any receipt, which is auto loaded on all MLV imports.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on October 08, 2020, 02:14:05 PM
Quote from: masc on October 08, 2020, 01:40:07 PM
Since the feature exists, the parameters never changed. For Reinhard, Gamma is and was always 3.5.
It is and was the default.
You can create your own default with any receipt, which is auto loaded on all MLV imports.

Thank you
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on October 12, 2020, 03:08:30 AM
Quote from: masc on October 04, 2020, 11:52:41 AM
Gamma is one variable in the profile equation.
If the MLVApp profile is "Standard", the equation is:
outColor = inColor ^ (1/gamma)
while here gamma is 3.15 by standard. Other profiles are a bit more complicated... And gamma has different values for different profiles (often it is 1.0 as default).

Thanks for all the info MASC!

If I am getting shadow clipping with the standard "BMDFilm" Profile, should I adjust "Exposure" under the "Processing" menus, or adjust "Gamma" under the "Profiles" menus to avoid shadow clipping?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 12, 2020, 12:40:10 PM
Quote from: Milk and Coffee on October 12, 2020, 03:08:30 AM
If I am getting shadow clipping with the standard "BMDFilm" Profile, should I adjust "Exposure" under the "Processing" menus, or adjust "Gamma" under the "Profiles" menus to avoid shadow clipping?
I would use Exposure slider. This should fit better to any BMD LUTs. If it is just a starting point for manual correction, I would take whatever looks better.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Thomi on October 13, 2020, 11:14:46 AM
Hey I was wondering if you could implement something like a dual bayer function into MLVApp. There seems to be the option in programs like RAWTherapee because Amaze doesn't always provide the best values in all areas of a picture.
If you have the time and you would see the benefit in doing so I would really appreciate this!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 13, 2020, 09:11:18 PM
@Thomi: yes, I played around with these hybrid debayer options in RAWTherapee. But did you see any advantage? If AMaZE "failed" in my footage, those debayers weren't any better as well. How must the footage look, that this helps? I did not find out. That is, why I stopped getting this into MLVApp a longer time ago.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Thomi on October 13, 2020, 09:47:08 PM
@masc: I can get behind that, thanks for looking into it!

Another question: In Processing Gamut, should I always use ACES? I found it to give me more room to push Exposure without getting that much artifacts when compared to Rec.709, is that simply because ACES seems to need to be pushed more in relation to Exposure to get the same results as in Rec.709 or is there a real benefit of using ACES?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 13, 2020, 10:03:23 PM
You "should" always use, what fits best for you and your process.  8)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Thomi on October 13, 2020, 10:16:20 PM
Understandable, thank you! :)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on October 15, 2020, 05:34:00 PM
Quote from: masc on October 12, 2020, 12:40:10 PM
I would use Exposure slider. This should fit better to any BMD LUTs. If it is just a starting point for manual correction, I would take whatever looks better.

Thanks! I notice that the "exposure" slider gives me more contrast than the "gamma" slider. It seems that "gamma" doesn't alter contrast, but maybe raises the blacks?

If I want to keep processing as similar to what would be encoded out of an actual black magic camera, would the "gamma" slider keep multiple renders 'consistent'?

I noticed too, that the stock "cineon" profile preset, doesn't clip. Maybe I just use that from now on? Or should I use "LOG C"?

Why does the "BMD Film" preset want to clip so often?

Thanks again!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Thomi on October 16, 2020, 02:43:42 PM
Quote from: Thomi on October 13, 2020, 09:47:08 PM
@masc: I can get behind that, thanks for looking into it!

Another question: In Processing Gamut, should I always use ACES? I found it to give me more room to push Exposure without getting that much artifacts when compared to Rec.709, is that simply because ACES seems to need to be pushed more in relation to Exposure to get the same results as in Rec.709 or is there a real benefit of using ACES?

Omg I'm so sorry, I was talking about Exposure, but I did mean Saturation.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 17, 2020, 11:39:48 AM
Quote from: Milk and Coffee on October 15, 2020, 05:34:00 PM
Thanks! I notice that the "exposure" slider gives me more contrast than the "gamma" slider. It seems that "gamma" doesn't alter contrast, but maybe raises the blacks?
The math behind these sliders is very different, so the results are also different.

Quote from: Milk and Coffee on October 15, 2020, 05:34:00 PM
If I want to keep processing as similar to what would be encoded out of an actual black magic camera, would the "gamma" slider keep multiple renders 'consistent'?
I don't have a black magic camera, so no idea how good this is possible at all. What we did: we realized a way to make Canon MLV footage look very similar between Resolve and MLVApp processing. That does not mean, a black magic camera looks the same.

Quote from: Milk and Coffee on October 15, 2020, 05:34:00 PM
I noticed too, that the stock "cineon" profile preset, doesn't clip. Maybe I just use that from now on? Or should I use "LOG C"?

Why does the "BMD Film" preset want to clip so often?
No clipping here. No idea what you else do... Some profiles are more flat, some are more contrasty. But you can work with other sliders to prevent from clipping.

Quote from: Thomi on October 16, 2020, 02:43:42 PM
Omg I'm so sorry, I was talking about Exposure, but I did mean Saturation.
The range of ACES is larger than Rec.709. But ACES is displayed on your sRGB monitor as well without any transformation. That means it will look different (less saturated and more flat) with the same settings (apart from this profile). If you transform it back to Rec.709 with at LUT afterwards, it should look the same again. But while correcting, you worked with a larger color range...
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Thomi on October 25, 2020, 11:45:14 AM
Quote from: masc on October 17, 2020, 11:39:48 AMBut while correcting, you worked with a larger color range...

Thank you for pointing me into the right direction, the benefit of working in a larger color space is widely discussed all over the internet and I think I know now a bit more than before. The only thing I am unable to find is a conversion LUT from ACES AP0 to Rec.709, so the colors are not off in the end, but I'm sure a little bit more research will do the trick!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Thomi on October 26, 2020, 03:13:30 PM
Looking further into this topic I came across OpenColorIO, now I know that it was said in prospect of implementing OCIO here that almost none of the dependencies are needed. I personally know near to nothing about dependencies or programming, but something was said about them here in a presentation on OCIO v2:



Maybe that would make it easier to implement it, once again I don't know anything and I don't want to be pushy, I just want to provide information.
Also in terms of figuring out how OCIO works, there has been a revamp of the documentation in addition to v2, it can be found here:

https://opencolorio.readthedocs.io/en/latest/

I hope this is somewhat useful, have a nice day!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Thomi on October 27, 2020, 11:27:00 PM
Okay I get dependencies and I get why this is difficult to implement, so I won't bother anyone of you ever again with that stuff. But since I'm trying to get it working and produce some 3D LUTs as ODTs for example from AP0 or AP1 to Rec.709, sRGB or DCI-P3 I want to ask if I should post these LUTs in here just in case they are of use to other people who don't want to rely on other software than MLVApp.
Oh but when in the image processing are LUTs processed in MLVApp?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 28, 2020, 08:47:28 AM
OpenColorIO is very far away from how we do our processing, so we found no easy solution how to add it. But feel free to create pull requests, if you get a good soultion for it.
LUTs in MLV are processed near the end of the pipeline:
https://github.com/ilia3101/MLV-App/wiki#processing-a-frame
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on October 28, 2020, 01:19:11 PM
See https://www.magiclantern.fm/forum/index.php?topic=25440.msg232207;topicseen#msg232207 Gamma shift issues on Mac / NCLC tags

Is it possible for correct metadata colour tags to be added to ProRes output from MLVApp? In ProRes outputs the tags are missing.

Untagged files are at the mercy of being displayed un-colour managed by apps and OS.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 28, 2020, 01:28:30 PM
Quote from: timbytheriver on October 28, 2020, 01:19:11 PM
Is it possible for correct metadata colour tags to be added to ProRes output from MLVApp? In ProRes outputs the tags are missing.
Tags are included since a very long time in all ffmpeg created files. It made a huge difference, when we implemented it.
Example from MediaInfo (see last 3 lines):
Video
ID                                       : 1
Format                                   : ProRes
Format version                           : Version 0
Format profile                           : 4444
Codec ID                                 : ap4h
Duration                                 : 40 ms
Bit rate                                 : 273 Mb/s
Width                                    : 1 856 pixels
Height                                   : 1 044 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Constant
Frame rate                               : 25.000 FPS
Color space                              : YUV
Chroma subsampling                       : 4:4:4
Scan type                                : Progressive
Bits/(Pixel*Frame)                       : 5.625
Stream size                              : 1.30 MiB (99%)
Writing library                          : Lavc
Color primaries                          : BT.709
Transfer characteristics                 : BT.709
Matrix coefficients                      : BT.709
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on October 28, 2020, 02:02:08 PM
Ah! None of the following exports show these tags (Color primaries, Transfer characteristics, Matrix coefficients) on my Mac with Media Info app (or Finder > Get Info).  :o

422LT
422
422HQ
4444
H264_AppleAV

The only export so far that has tags (1-1-1) is H264_FFMpeg! How strange.

Here's 422 Anatolyi (MLVApp v1.11, OSX Mojave)

(https://i.ibb.co/yFBvC6Y/Screenshot-2020-10-28-at-13-19-33.png) (https://ibb.co/d4JCvPL)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 28, 2020, 02:41:06 PM
Ah okay... maybe there are some single encoders in ffmpeg not supporting the tags. I tried Kostya ProRes. Anatolyi is very limited. AppleAV is not ffmpeg, so here we have no access on any tags.

Edit: here the tags of Anatolyi 422 export (all 3 tags exist):

Video
ID                                       : 1
Format                                   : ProRes
Format version                           : Version 0
Format profile                           : 422
Codec ID                                 : apcn
Duration                                 : 40 ms
Bit rate                                 : 169 Mb/s
Width                                    : 1 856 pixels
Height                                   : 1 044 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Constant
Frame rate                               : 25.000 FPS
Color space                              : YUV
Chroma subsampling                       : 4:2:2
Scan type                                : Progressive
Bits/(Pixel*Frame)                       : 3.491
Stream size                              : 826 KiB (99%)
Writing library                          : fmpg
Color primaries                          : BT.709
Transfer characteristics                 : BT.709
Matrix coefficients                      : BT.709


And here Apple 422 (just one tag exists):

Video
ID                                       : 1
Format                                   : ProRes
Format version                           : Version 0
Format profile                           : 422
Codec ID                                 : apcn
Duration                                 : 67 ms
Bit rate                                 : 69.4 Mb/s
Width                                    : 1 856 pixels
Height                                   : 1 044 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Constant
Frame rate                               : 15.000 FPS
Color space                              : YUV
Chroma subsampling                       : 4:2:2
Scan type                                : Progressive
Bits/(Pixel*Frame)                       : 2.388
Stream size                              : 565 KiB (98%)
Title                                    : Core Media Video
Writing library                          : Apple
Matrix coefficients                      : BT.709


Edit2: in my latest revision I have an updated ffmpeg. This corrects the tags for Anatolyi.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on October 28, 2020, 02:54:27 PM
Updated ver1.11 shows me error for 'Transfer Function' dropdown:

(https://i.ibb.co/61SkLTz/Screenshot-2020-10-28-at-13-53-05.png) (https://ibb.co/s64ZzNn)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 28, 2020, 03:46:13 PM
What error do you mean? I don't see any...
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on October 28, 2020, 03:53:35 PM
The 'Transfer Function' is just raw text code. I can't select anything here. Shouldn't it be a dropdown selector?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 28, 2020, 04:03:11 PM
Nope. That changed since 1.11. Transfer function now can be defined as you like. With that you can have any transfer function, and not the few predefined ones. Use the preset combo to get the old predefined options as math expression.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on October 28, 2020, 04:07:04 PM
Oh. Not sure what you mean exactly. How do I restore the 'old' preset values dropdown? I can't write math expressions!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 28, 2020, 04:13:07 PM
Look on your screenshot. Select preset from the first combo. Then you'll get the expression for it. The old menu is gone.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on October 28, 2020, 04:23:09 PM
Ah, thanks! I see now. But if you don't know maths, there is no label to understand what has been selected.  ???

I see the tags now in ProRes export ffmpeg Anatolyi. But whatever preset/space/gamma is exported it just writes default 1-1-1 tags. Maybe this is mac only?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 28, 2020, 04:40:50 PM
Quote from: timbytheriver on October 28, 2020, 04:23:09 PM
Ah, thanks! I see now. But if you don't know maths, there is no label to understand what has been selected.  ???
There can't be any label, because this feature exists to tweak the formula. You can freely define your transfer function, instead of nearly all other applications - so there can't be a default name for all possibilities of functions - the list is endless.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: timbytheriver on October 28, 2020, 04:44:32 PM
Righto. Thanks. That's hardcore! I'd better learn me some functions math.  :P
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on October 31, 2020, 06:23:03 PM
What would be the proper way for me to rename long clips (multiple 4gb split .MLV's) BEFORE importing into MLV app? Do I just need to change the name of all files?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 31, 2020, 06:39:32 PM
How come you are not able to test it yourself? Something wrong with you computer?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on November 01, 2020, 04:29:06 AM
No, just thought maybe someone had a good insight from a previous experience. Thanks, really helpful though!
Title: MLV App compiled for Apple's new m1 soc
Post by: jdana on November 13, 2020, 08:41:22 AM
I know this is a long shot but I was wondering if anyone was thinking about this? Apple will soon (next few years) be moving to ARM for all of its computers.

Is a version of MLV App for arm in the works?

Thanks so much,

Jonathan
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: harkr on November 13, 2020, 06:39:04 PM
Hi there, I am new here and was wondering whether anybody might be able to help me troubleshoot an issue I'm having with MLV App / FCP XML.

Basically I used a 5Dm3/ML to shoot something, created ProRes proxies using the MLV App, locked my edit in Adobe Premiere, and am now trying to online to RAW for color correction.  My plan was to use the FCPXML Import Assistant in MLV App to link to the edit's corresponding MLV files and generate RAWs.  So I created an FCP XML file in Premiere from my locked sequence.  But when I try to use the FCP XML Import Assistant in MLV App, I'm unable to select my XML - I can navigate to it in the selection window of the Import Assistant, but it's grayed out and unclickable.

(https://i.imgur.com/AhuCf96.png) (https://i.imgur.com/AhuCf96.png)

I'm not sure where I went wrong, and would truly appreciate any help that anyone could provide, as I'm hoping to meet a tight deadline.  Apologies if this isn't the right place or way to post this query, and I very much appreciate any attention to this. Thank you!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 13, 2020, 07:54:11 PM
@harkr: as far as I know Premiere is not able to export "real" FCPXML files. And as you see, you did not export a .fcpxml, but a .xml. This is a difference, and that is why you can't import into MLVApp. I've never seen a .xml from Premiere, so I can't tell how it looks inside. If Premiere really exports a fcpxml (but with xml ending), you could try to rename the file ending. But no idea if MLVApp is able to read it.

@jdana: Apple just presented the new models with M1 processor. None of the devs owns a ARM Mac, and there is no Qt5 (the used development environment) for Mac ARM processors existing. Both is a must have to be able to support it. If Qt5 ever supports this architecture is not sure, because they will start rolling out Qt6. And if Qt6 is really compatible, I can't tell either. Time will tell... but for now it won't be compatible, if I understood right. So for now I recommend to not buy a ARM Mac if you want to edit MagicLantern files. Maybe it works with the use of Rosetta2, but who knows.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on November 24, 2020, 09:54:58 PM
masc is it possible to split grain slider so you can control how much grain is in highlights and how much in shadows separately ? Also size of it ? Currently theres tiny amount visible in highlights and a lot in shadows which looks more like noise, id like to reduce it in shadows and have more in highlights/midrange.
Id like to get something like this wtith visible grain in highlights  :
https://vimeo.com/230165379
Looks legit film like when theres grain in highlights as well and this guy has 0 grain in shadows.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 25, 2020, 08:20:43 PM
Quote from: 2blackbar on November 24, 2020, 09:54:58 PM
masc is it possible to split grain slider so you can control how much grain is in highlights and how much in shadows separately ?
Wow... there is really someone using my grain slider? Cool! B) Yes, I think that should be possible.

Quote from: 2blackbar on November 24, 2020, 09:54:58 PM
Also size of it ?
That is not really possible with current (very easy) solution, becaues generated grain size is exactly 1x1px now. I have no idea how to make it look good when e.g. using 2x2px or larger. Do you have ideas?

Quote from: 2blackbar on November 24, 2020, 09:54:58 PM
Currently theres tiny amount visible in highlights and a lot in shadows which looks more like noise, id like to reduce it in shadows and have more in highlights/midrange.
That might depend on the footage. The math is for all luminance values identical now.

Another question is: how to define shadow, mid and highlights? I could imagine an active diagram similar to HSL->Limunance vs. Saturation: bottom is 0 grain, top is 100 grain. Left is shadows, right is highlights. Sure: the image needs to be converted another time to LCbCr for this, and that needs additional time. What do you think?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 25, 2020, 09:20:09 PM
I found a quick solution for this: a checkbox for luma weighted grain. This brings a little more grain in highlights, but less to none grain in the shadows. Here the results:
(https://i.ibb.co/r7VQwZ0/Bildschirmfoto-2020-11-25-um-21-12-53.png)
(https://i.ibb.co/NWYVG4q/Bildschirmfoto-2020-11-25-um-21-12-57.png)
The code is commited to the repos. Try it if you like ;)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on November 25, 2020, 10:34:23 PM
Thats cool, ill try to compile , i was thinking about second slider that would remove grain starting from low luma values(darkest parts of the image) Kinda like You say - luminance vs saturation  curve but as a slider if its easier but of course curve would be better.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on November 26, 2020, 08:24:47 PM
I cant download the source, tried like 10 times and got disconnected after a couple MB's
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 26, 2020, 08:36:51 PM
Quote from: 2blackbar on November 26, 2020, 08:24:47 PM
I cant download the source, tried like 10 times and got disconnected after a couple MB's
That must be your connection. Works fine over here.

I liked your idea with another slider. What I did now: instead of a checkbox, there is another slider now. So you can finetune between the 2 modes from yesterday.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on November 26, 2020, 10:22:12 PM
Thats great, ill keep trying to download it
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on December 06, 2020, 08:40:08 PM
would it be possible to add the ability to remove jobs from the render list while rendering is underway?

when i am doing batch renders, splitting the jobs across multiple instances of mlvapp, invariably some finish earlier than others, and it would be nice to be able to have them take on clips from other instances without having the other one potentially redoing clips that were reassigned to other instances.

thanks!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 15, 2020, 10:18:06 AM
DarkFrame Substation seems to be very buggy.
It stops applying the darkframe after a certain amount of frames or clips rendered, without any warning or error message. very unpredictable.
Everytime the module stops working i have to close and reopen MLV App to get it working again. but everything else continues to work perfectly fine.
I tried a few older versions of MLV App, even the 32 bit ones. they all have the same exact issue for me.
Im on Windows 10 Pro x64.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 15, 2020, 10:29:42 AM
Quote from: 70MM13 on December 06, 2020, 08:40:08 PM
would it be possible to add the ability to remove jobs from the render list while rendering is underway?

when i am doing batch renders, splitting the jobs across multiple instances of mlvapp, invariably some finish earlier than others, and it would be nice to be able to have them take on clips from other instances without having the other one potentially redoing clips that were reassigned to other instances.
That's not possible in an easy way. There is currently no way to show/edit these internal data buffers, and they aren't made for this. So a huge change for a tiny feature.

Quote from: MotherSoraka on December 15, 2020, 10:18:06 AM
DarkFrame Substation seems to be very buggy.
It stops applying the darkframe after a certain amount of frames or clips rendered, without any warning or error message. very unpredictable.
Everytime the module stops working i have to close and reopen MLV App to get it working again. but everything else continues to work perfectly fine.
I tried a few older versions of MLV App, even the 32 bit ones. they all have the same exact issue for me.
Im on Windows 10 Pro x64.
Maybe you put in some information - "doesn't work" doesn't help at all. "they all have the same exact issue" because they all have exact the same feature and code. How to reproduce this? No such problem here, not on Windows, and not on macOS. What means "module stops working"?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 15, 2020, 11:01:06 AM
QuoteMaybe you put in some information - "doesn't work" doesn't help at all. "they all have the same exact issue" because they all have exact the same feature and code. How to reproduce this? No such problem here, not on Windows, and not on macOS. What means "module stops working"?

You can't really tell if the DarkFrame Subtraction module has stopped working (applying the Subtraction to the clip) until you play and examine your rendered output. (ofc if you know what to look for)
Sometimes the Subtraction only applies to the first few numbers of frames only and stops applying the DarkFrame to the rest of the frames.
The Longer your clip is, the higher the chances of the issue happening. Sometimes it renders all of the clip just fine, and sometimes it stops applying it from frame 1.
to reproduce it you should try to render a few long (preferably High ISO) clips in succession (without closing the App) or in batch, then play and check your output files till the last frame.
I've tried rendering in many different formats and codecs including RAW CinemaDNG, with all the different possible settings in "RAW Correction" module with no success.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 15, 2020, 11:08:24 AM
You dont even need to check the rendered file.when it stops working, your Darkframe will no longer have any effect on any of your clips until you restart the app.
There wont be any Crash or Error, only the Darkframe Subtraction function Silently stops working.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 15, 2020, 09:37:04 PM
After processing of around 30000 frames I really got the error once (that needed some time). Enabling debug messages and waiting another x * 10000 frames brought me the message "Could not open file darkframe.mlv" (video_mlv.c), and "DF: could not read frame: darkframe.mlv" (darkframe.c).
@bouncyball: do you have any idea why access to the file stops after such a long time? File is opened, data read, and closed again... I don't see any problem so far. MLVApp seems to be blocked to read any file after this.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 15, 2020, 10:39:33 PM
Almost all my videos are under 1 min long and the issue still happens to me very frequently even after processing only a dozen of frames. again, the occurrence of the issue seems to very random and unpredictable and possibly dependent on the content of the Darkframe or the clip being processed.

I just tried processing the same sets of MLV clips and Darkframes on the Linux version of MLVApp on a fresh installat of Ubuntu on VMWare; so far everything seems very stable and havent run into the issue yet.

Btw, How do i enable the debug messages?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on December 16, 2020, 12:53:30 AM
Possibly MLV App is leaking file handles?  That could explain the symptoms, especially it being blocked after the error occurs.  On Linux you should be able to check with some combination of lsof and ulimit -n.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 16, 2020, 08:10:30 AM
Quote from: MotherSoraka on December 15, 2020, 10:39:33 PM
Btw, How do i enable the debug messages?
Search for this in mlvapp.pro, comment and compile:
##############
# Silent Mode, deactivate for more debug info
##############
DEFINES += STDOUT_SILENT


Quote from: names_are_hard on December 16, 2020, 12:53:30 AM
Possibly MLV App is leaking file handles?  That could explain the symptoms, especially it being blocked after the error occurs.  On Linux you should be able to check with some combination of lsof and ulimit -n.
Yes, it could be the problem. But the architecture is very complex and it is very very hard to find such issues - if they exist at all. On my macOS "ulimit -n" brings 256, so not a high number of open files allowed for all users, for around 30000 times procesing with darkframe. Also RAM usage doesn't change at all over this time.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on December 16, 2020, 08:45:04 AM
There are tools for finding file handle leaks.  Valgrind can do this, if you use --track-fds=yes (valgrind will make the code run *very* slow though).

ulimit -n is a per process file handle limit.  You can increase this, e.g., ulimit -n 2048.  Mac does set the default very low.  Note that changes to ulimit only work for the process you run the command in, and its children.  That means you must start MLV App from the same terminal you ran ulimit in, or it will keep using the 256 default.

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 16, 2020, 06:56:55 PM
I tried to fix it. Here it works since hours now (macOS). Maybe someone else like to try it, also on other platforms. Download, compile, test.  8)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 16, 2020, 07:11:01 PM
Send the tester your version. Not many users work with the darkframe function.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 16, 2020, 07:13:32 PM
If I understood right he's on Windows. No Windows here.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 16, 2020, 07:29:44 PM
Oh crap. Good fixing though...
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 17, 2020, 06:49:39 PM
Hello guys!

I see some nasty hickups revealed in the darkframe code. Despite I wrote this part I use this feature very seldom myself so never noticed anything unusual.
Thanks for reporting it and thanks for the patch comited by @masc.

@masc: did that help with debug messages? (indeed handle leak)

regards
bb


Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 17, 2020, 07:02:58 PM
Hi bouncyball! Nice to have you here! Yes, the debug info gave me the initial idea.. after a long time of waiting for a bug  8) . Maybe you could have a look on my changes... you probably know better if that's a good fix or not.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 17, 2020, 07:16:33 PM
I already saw it. Patch looks OK! If this eliminates the issue - that's it! :D
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 17, 2020, 07:36:53 PM
I only made a theoretical analysis and called the unload before all possible returns in this function. No idea, if that problem could exist also on other places, and if all those places work correctly. I think it is nearly impossible to test all that.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 17, 2020, 10:55:18 PM
I tried installing qt5, but gave up in the middle of the installation.was taking years. maybe i'm doing something wrong. i don't have much experience in programing anyway
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 17, 2020, 11:00:23 PM
Quote from: masc on December 16, 2020, 06:56:55 PM
I tried to fix it. Here it works since hours now (macOS). Maybe someone else like to try it, also on other platforms. Download, compile, test.  8)
Wow, that was quick.
I totally underestimated you guys. Should've reported the issue mounts ago. i almost age up on MLV App.
Thank you masc.
I guess i'll just wait until someone complies the new version for windows.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 18, 2020, 11:30:15 AM
Quote from: MotherSoraka on December 17, 2020, 10:55:18 PM
I tried installing qt5, but gave up in the middle of the installation.was taking years. maybe i'm doing something wrong. i don't have much experience in programing anyway
Maybe you try the wrong packages. You just need these packages, and then you should hopefully be able to compile as described on github:
(https://i.ibb.co/Df8D3T0/Qt.png)

Quote from: MotherSoraka on December 17, 2020, 11:00:23 PM
Wow, that was quick.
I totally underestimated you guys. Should've reported the issue mounts ago. i almost age up on MLV App.
We just can fix the bugs we know ;)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 19, 2020, 10:57:00 AM
Quote from: masc on December 18, 2020, 11:30:15 AM
Maybe you try the wrong packages. You just need these packages, and then you should hopefully be able to compile as described on github:
This was very helpful!
Stupid me was trying to download all the packages.
Okay I successfully loaded the MLVApp.pro into QT Creator but wasn't quite sure how to compile it. I "Built" it as "Release" but got the "The Code Execution cannot proceed because QT5core.dll was not found..." message trying to run the generated exe file.
So i just ran it through QT itself and processed a few clips in batch with no issues.
Further help with the compiling process is welcomed. i think i should run some more tests.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on December 19, 2020, 12:08:07 PM
I encountered this problem with dark frames about a year ago, but completely forgot about it... It's great that this bug being fixed!

Ilia told me to register on github and report a bug, but I never did that... First, my laptop died, and I didn't shoot more stars then. But not because of a bug or anything, but because of a fact that stars don't look good in 3x3 mode - they disappear periodically. At that time I was experimenting with other things, another camera.. It was probably very unprofessional, for which I apologize.

Anyway, you guys are great, thank you for all the work you have done! Maybe more people will shoot stars now.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 19, 2020, 12:52:48 PM
Quote from: MotherSoraka on December 19, 2020, 10:57:00 AM
Stupid me was trying to download all the packages.
Okay I successfully loaded the MLVApp.pro into QT Creator but wasn't quite sure how to compile it. I "Built" it as "Release" but got the "The Code Execution cannot proceed because QT5core.dll was not found..." message trying to run the generated exe file.
So i just ran it through QT itself and processed a few clips in batch with no issues.
Yapp, you just need the package for your target, the compiler and QtCreator. If you are able to start from Creator, compilation was successful. What you need now to run from outside Creator is a "deployment". This collects all needed dlls and copies them to the release folder. But I also would have to search the Qt help to find out how this works on Windows...
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on December 19, 2020, 05:26:04 PM
Quote from: masc on December 15, 2020, 10:29:42 AM
Quote from: 70MM13 on December 06, 2020, 08:40:08 PM
would it be possible to add the ability to remove jobs from the render list while rendering is underway?

when i am doing batch renders, splitting the jobs across multiple instances of mlvapp, invariably some finish earlier than others, and it would be nice to be able to have them take on clips from other instances without having the other one potentially redoing clips that were reassigned to other instances.

That's not possible in an easy way. There is currently no way to show/edit these internal data buffers, and they aren't made for this. So a huge change for a tiny feature.
What @70MM13 requests doesn't sound like a "tiny feature" -- it sounds like fundamental functionality that would be exceedingly useful to anyone doing batch renders.

If one could merely call from the command line MLV App along with a specific mlv file and recipe, the problem could likely be solved with a script (and that script function could be later incorporated into MLV App).  Such a command might read:
$  mlvapp -i your_camera_file.mlv  -s your_recipe.marxml  -o rendered_file.mp4

I don't know the function of MLV App's "Export Settings" feature, but if MLV App does everything through ffmpeg, perhaps the ffmpeg command flags/settings could be exported, and one could just run an ffmpeg batch script using those flags/settings.

Also, what is the function of "Open with External Application?"  Perhaps that feature could be utilized in this endeavor.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 19, 2020, 07:01:08 PM
@tupp: for this you would need to write a new application which just uses the processing backend. The export command already now is very long and difficult - I doubt anybody would use this.

"Open with External Application" does how it is named: it opens the currently active clip in another external application, e.g. MlRawViewer, to be able to watch the clip unprocessed in realtime.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on December 19, 2020, 08:45:08 PM
@masc:  If the "Export Settings"  feature spits out all of the ffmpeg flags/variables, then it is easy enough to paste them into a command (or paste them into a file and then link the file).

Thanks for the explanation on the "Open with External Application" feature.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 19, 2020, 10:15:35 PM
Can we also get rid of this annoying warning message?
(https://i.ibb.co/bmCZMYS/2020-12-20-00-43-07-MLV-App-H-DCIM-100-EOS5-D-M13-1258-MLV.png)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 19, 2020, 10:54:47 PM
Quote from: MotherSoraka on December 19, 2020, 10:15:35 PM
Can we also get rid of this annoying warning message?
Sure. Just do what the message tells. Create an averaged MLV! See export settings. If you don't do it, MLVApp will just load the first frame. And one single frame of your original MLV won't help you at all... that's why the message exists.
https://github.com/ilia3101/MLV-App/wiki#darkframe-subtraction
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 19, 2020, 11:06:12 PM
Quote from: masc on December 19, 2020, 10:54:47 PM
Sure. Just do what the message tells. Create an averaged MLV! See export settings. If you don't do it, MLVApp will just load the first frame. And one single frame of your original MLV won't help you at all... that's why the message exists.
https://github.com/ilia3101/MLV-App/wiki#darkframe-subtraction
Thats exactly what im doing. I generated Averaged Single darkframes. they are only 1 Frame long.
but this annoying message keeps popping up for no reason.
(https://i.ibb.co/Ld9jVr9/2020-12-20-01-36-36-Clip-Information.jpg)

(https://i.postimg.cc/c1QnxBHd/2020-12-20-01-32-17-Da-Vinci-Resolve-Studio-Untitled-Project-9.png)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 19, 2020, 11:13:21 PM
I just commented this part of the code for now.
(https://i.ibb.co/0GpxdRj/2020-12-20-01-39-45-darkframe-c-X-MLV-App-master-2-MLV-App-master-src-mlv-llrawproc-MLVApp-Qt.jpg)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 19, 2020, 11:16:27 PM
Quote from: masc on December 19, 2020, 12:52:48 PM
Yapp, you just need the package for your target, the compiler and QtCreator. If you are able to start from Creator, compilation was successful. What you need now to run from outside Creator is a "deployment". This collects all needed dlls and copies them to the release folder. But I also would have to search the Qt help to find out how this works on Windows...
Done.
Manually copied all the required DLLs into the release folder and it worked.
(https://i.ibb.co/J7jnyDZ/2020-12-20-01-44-10-release.jpg)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 19, 2020, 11:16:41 PM
That's the right code. But have a look:

/* if MLV has more than one frame just show the warning */
    if( df_mlv.MLVI.videoFrameCount > 1 )
    {
        sprintf(err_msg, "For proper use as a dark frame all frames of this MLV have to be averaged first:\n\n%s", video->llrawproc->dark_frame_filename);

Whatever you load... it MUST have more than 1 frame. Maybe you select the wrong file. I tested here and I just get the message if the selected clip is longer 1 frame. So the code works and is correct.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 19, 2020, 11:34:05 PM
- deleted -
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 20, 2020, 12:02:36 AM
Quote from: masc on December 19, 2020, 11:16:41 PM
Whatever you load... it MUST have more than 1 frame. Maybe you select the wrong file. I tested here and I just get the message if the selected clip is longer 1 frame. So the code works and is correct.


The warning message also pops up everytime before starting and after finishing exporting.

The Darkframe file used for both clips:
https://gofile.io/d/5GMrDR
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 20, 2020, 06:20:59 AM
Good example how darkframe affects image by the way.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 20, 2020, 10:30:17 AM
Do you remember, how you created this darkframe? It is corrupted and this particular MLVApp line of code is correct. Your darkframe shows 139 frames in MLVI.videoFrameCount. This is not correct for a darkframe, so you get the message, which in the end seems not to be so stupid ;) . In the info dialog it shows 1, because image data analysis brought just a frame count of 1. That means the metadata in your darkframe is wrong. If I export this frame as "averaged MLV" again, the message is not shown and MLVI.videoFrameCount is 1.
(https://i.ibb.co/WcNJ7x5/Bildschirmfoto-2020-12-20-um-10-26-54.png)
(https://i.ibb.co/862vChG/Bildschirmfoto-2020-12-20-um-10-38-15.png)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 20, 2020, 11:24:28 AM
Is he even averaging the darkframe files at all prior to applying? Is it possible to apply an unavereged darkframe to the mlv? Shouldn´t be imo.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 20, 2020, 01:15:58 PM
Quote from: Danne on December 20, 2020, 11:24:28 AM
Is he even averaging the darkframe files at all prior to applying? Is it possible to apply an unavereged darkframe to the mlv? Shouldn´t be imo.
You can load also a standard MLV as darkframe - then you get this message. There is no metadata object if the MLV was averaged or not. We just can count the included frames.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 20, 2020, 01:25:18 PM
Maybe issues before comes from this? Running the workflow wrongly I mean.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 20, 2020, 01:37:11 PM
Yes... that's why I was asking: "Do you remember, how you created this darkframe?" Maybe this workflow includes a bug.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 21, 2020, 01:36:07 AM
Quote from: masc on December 20, 2020, 10:30:17 AM
Do you remember, how you created this darkframe? It is corrupted and this particular MLVApp line of code is correct. Your darkframe shows 139 frames in MLVI.videoFrameCount. This is not correct for a darkframe, so you get the message, which in the end seems not to be so stupid ;) . In the info dialog it shows 1, because image data analysis brought just a frame count of 1. That means the metadata in your darkframe is wrong. If I export this frame as "averaged MLV" again, the message is not shown and MLVI.videoFrameCount is 1.
Okay... that makes sense...
I used MLV_Dump to average my darkframes (before figuring out i could use the MLV App itself) using the following commend:
mlv_dump -a "input.mlv" -o "output.mlv"
Seems all my darkframes generated by MLV_Dump have the wrong framef count in metadata. My new MLVApp generated darkframes don't exhibit the same issue.
So... have I missed something while using MLV_dump?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 21, 2020, 01:48:03 AM
Quote from: Danne on December 20, 2020, 06:20:59 AM
Good example how darkframe affects image by the way.
This wasn't even a even good example of the necessity of using darkfames.
I can't believe only a very few here have been using this feature.

Darkframes make a night and day difference especially in low light or after heavy color grading, Denoising, sharpening and bringing up the shadows.
I'll post a before and after compression video later on.

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 21, 2020, 07:16:33 AM
I implemented fully automated darkframe routines both in Switch(mac) and batch_mlv(windows). I think I know how to use darkframes by now. And the effects.

To help you instead of fixing "issues" in Mlv App it's recommended you upload actual mlv files. This would have saved everyone involved a lot of time. Screen recordings of your full workflow and files is the way to go. Tons of vital information missing.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: MotherSoraka on December 23, 2020, 02:36:12 AM
Quick update, Ive been using the new version extensively lately and haven't faced the "leak" issue yet. its been working perfectly so far.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 23, 2020, 09:51:40 AM
@MotherSoraka: Thank you for testing and the feedback.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mevi on December 29, 2020, 02:12:01 AM
Hello! MLV newbie and my first post here.

I've been editing h264/265 8bit files for some years (DV if we're looking waaaay back). I edit while on the road and I'm trying hard not to fall back to using a laptop for much more than pre-processing audio and video.. I use Lumafusion on an iPad pro. My editing chops are pretty good after all these years, but 8bit breaks too easily for run and gun travel videos I make.

I'm not exactly rich, so ML on an older Canon seems an interesting option. I need to do some research before I pull the trigger on my eBay watch list.

Lumafusion has just added support for wide gamut 10bit h265, so I've spent some time with MLV App and some of the older utilities.

Is it possible to add a script for 10bit h265 in MLV App?

FFMpeg can encode to 10bit h265, but having a hard time getting it to process Zeek's sample MLVs.

Like I said, I'm new here. Perhaps I'm missing something?

Many thanks
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on December 29, 2020, 02:41:45 AM
On that noise in highlights , i just discovered that they used same techique in irishman - grain only in briught areas and shadows/darks are very clean, so it doesnt look like sensor noise.Its a bit strange that superhiglights -whiotes dont have grain as well so its abouyt 40%-80% brightness range that has it.
https://images.hdencode.com/upload/big/2020/12/12/5fd53aa7dcea8-hdencode_screenshot_3.png
I also realised that 35mm film detail rarely went to 4K if ever, i think it has about 3k maybe.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 29, 2020, 05:55:10 AM
It´s midtone grain. Not in highlights.
Interesting to see how strange grain appears when peeping a frozen image.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on December 29, 2020, 09:18:39 AM
Quote from: Mevi on December 29, 2020, 02:12:01 AM
I'm not exactly rich, so ML on an older Canon seems an interesting option. I need to do some research before I pull the trigger on my eBay watch list.

Is it possible to add a script for 10bit h265 in MLV App?

MLVApp has a H.265 codec built in and if you do all corrections to your RAW videos in MLVApp and export in that codec, results are fantastic.  Personally, I use it a lot since it provides very compact files that are fast and easy to edit in Resolve Lite, so you can create beautiful films while traveling.  You need pretty much patience with MLVApp though since render times are fairly long.  If you have a laptop whose video card supports the H.265 codec, Resolve 16 provides excellent render times in that codec.  Moreover, using MLVFS, you can do all the processing of your MLV files and video editing in Resolve directly - from import to rendering.  If the laptop does not support H.265 rendering, you can still render in H.264 in Resolve.  This is what I do if I need a fast result - I import all my MLVs in Resolve using MLVFS, do all the processing in the RAW module, as well as the video editing and then export in H.264.  This really goes fast, even on my 7 years old laptop (HP Z-Book 15 with 2GB of GPU RAM) that I take with me when traveling.  Here is a video that I filmed and completed in this way while traveling:

https://cloud.mail.ru/public/3Yw3/MbAHmSoSk

For smooth playback, please do not watch it online, download it with the "Скачать" button (bottom left) instead.

As far as camera options are concerned, if you are serious about RAW video, a 5D3 in a good condition is your best ML capable choice.  Cheaper cameras are the EOS-M and the 700D and they also do a hell of a job if you don't mind the short battery life.  So, if you decide to use one of these, please consider some sort of powering from external batteries.  Other models have not received updates for quite some time.

Good luck!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 29, 2020, 11:28:45 AM
Quote from: Mevi on December 29, 2020, 02:12:01 AM
Is it possible to add a script for 10bit h265 in MLV App?

FFMpeg can encode to 10bit h265

Thanks for pointing. I added H.265 10bit 4:2:2 and 12bit 4:4:4 to MLVApp. ffmpeg gets very slow with that and needs some RAM, but this is as it is. Support is now there ;)

@Danne: if you like to add it also to Switch, here are some nice hints, which made coding easy:
https://askubuntu.com/questions/922563/set-bit-depth-in-ffmpeg-encoding-for-hevc
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mevi on December 29, 2020, 01:13:42 PM
Quote from: IDA_ML on December 29, 2020, 09:18:39 AM
As far as camera options are concerned, if you are serious about RAW video, a 5D3 in a good condition is your best ML capable choice....
....Other models have not received updates for quite some time.

Good luck!

Hey, thanks. The video looks really great.  8)

I think I have settled on either a cheaper 5D2 or the 5D3 at twice that price (which I think has full sensor readout?), but might pick up an affordable EOSM just to try the workflow before fully committing. Whatever I choose, I don't think I will lose money if I decide to sell it on.  :D

Quote from: masc on December 29, 2020, 11:28:45 AM
Thanks for pointing. I added H.265 10bit 4:2:2 and 12bit 4:4:4 to MLVApp. ffmpeg gets very slow with that and needs some RAM, but this is as it is. Support is now there ;)

Hey thanks so much! I look forward to downloading that soon. Will that become available on MLV.app?

I expect to have long waits for the 265 encoding on my PC. I can set it running overnight  ;D
I imagine I will batch process the clips with minimal tweaks before editing on the iPad Pro.
I love using the touchscreen to edit - it kinda feels like I am sculpting a video. Impressively, with hardware support for the codec Lumafusion on the iPad Pro exports projects at 4K10bit 265 at around half real-time.
The new M1 Mac's hint at a bright future for editors. 8)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 29, 2020, 01:28:47 PM
What are your pix format settings for 10/12bit?

My tests givie me the same results with -pix_fmt yuv444p10le and -pix_fmt yuv444p10. When trying 12bit -pix_fmt yuv444p12le files comes out smaller in size. Indicates something´s wrong? Metadata and ffmpeg output tells me it´s 12bit but size is smaller than when specifying 10bit? Could you test on your end?

Also. I wonder if setting is the same if doing yuv420p10 instead of 444. File sizes much smaller.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mevi on December 29, 2020, 03:31:10 PM
I've been tinkering.
With minimal headaches, I can import CinemaDNG and it's associated WAV into Lumafusion (image sequence of 1 frame per image) and export wide gamut HDR from there!!

It'll import any still image sequence, but dng is fast to export in MLV App.

It is actually possible to grade the CinemaDNG in Lumafusion by copy/paste from one image to the whole sequence. The editing of an image sequence is super clunky, however.... There's also the matter of only having a 256GB iPad pro.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 29, 2020, 05:03:43 PM
Quote from: Mevi on December 29, 2020, 03:31:10 PM
It'll import any still image sequence, but dng is fast to export in MLV App.
DNG is no real export, it is just a copy of data into another structure and is still RAW - so it is mostly just a waste of time and diskspace. But MLVFS (on the fly conversion) is not compatible with an iPad I think... I don't know Lumafusion - what debayer does it use? Not all programs out there are able to process RAW in a nice way. But maybe you have luck and get good results.

Quote from: Danne on December 29, 2020, 01:28:47 PM
What are your pix format settings for 10/12bit?

My tests givie me the same results with -pix_fmt yuv444p10le and -pix_fmt yuv444p10. When trying 12bit -pix_fmt yuv444p12le files comes out smaller in size. Indicates something´s wrong? Metadata and ffmpeg output tells me it´s 12bit but size is smaller than when specifying 10bit? Could you test on your end?

Also. I wonder if setting is the same if doing yuv420p10 instead of 444. File sizes much smaller.
LOL. Yes, you're right. Here an example of 50 frames:
8bit 4:2:0 (yuv420p) - 2.025.062 Byte
Video
ID                                       : 1
Format                                   : HEVC
Format/Info                              : High Efficiency Video Coding
Format profile                           : Main@L4@Main
Codec ID                                 : hev1
Codec ID/Info                            : High Efficiency Video Coding
Duration                                 : 2 s 0 ms
Bit rate                                 : 7 950 kb/s
Width                                    : 1 856 pixels
Height                                   : 1 044 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Constant
Frame rate                               : 25.000 FPS
Color space                              : YUV
Chroma subsampling                       : 4:2:0
Bit depth                                : 8 bits
Scan type                                : Progressive
Bits/(Pixel*Frame)                       : 0.164
Stream size                              : 1.90 MiB (98%)
Writing library                          : x265 3.4+22-772b3229d157:[Mac OS X][clang 11.0.0][64 bit] 8bit+10bit+12bit

10bit 4:2:2 (yuv422p10le) - 2.015.250 Byte
Video
ID                                       : 1
Format                                   : HEVC
Format/Info                              : High Efficiency Video Coding
Format profile                           : Main 10@L4@Main
Codec ID                                 : hev1
Codec ID/Info                            : High Efficiency Video Coding
Duration                                 : 2 s 0 ms
Bit rate                                 : 7 910 kb/s
Width                                    : 1 856 pixels
Height                                   : 1 044 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Constant
Frame rate                               : 25.000 FPS
Color space                              : YUV
Chroma subsampling                       : 4:2:0
Bit depth                                : 10 bits
Scan type                                : Progressive
Bits/(Pixel*Frame)                       : 0.163
Stream size                              : 1.89 MiB (98%)
Writing library                          : x265 3.4+22-772b3229d157:[Mac OS X][clang 11.0.0][64 bit] 10bit

12bit 4:4:4 (yuv444p12le) - 1.981.483 Byte
Video
ID                                       : 1
Format                                   : HEVC
Format/Info                              : High Efficiency Video Coding
Format profile                           : @L4@Main
Codec ID                                 : hev1
Codec ID/Info                            : High Efficiency Video Coding
Duration                                 : 2 s 0 ms
Bit rate                                 : 7 775 kb/s
Width                                    : 1 856 pixels
Height                                   : 1 044 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Constant
Frame rate                               : 25.000 FPS
Color space                              : YUV
Chroma subsampling                       : 4:4:4
Bit depth                                : 12 bits
Scan type                                : Progressive
Bits/(Pixel*Frame)                       : 0.161
Stream size                              : 1.85 MiB (98%)
Writing library                          : x265 3.4+22-772b3229d157:[Mac OS X][clang 11.0.0][64 bit] 12bit

What's going on here? AND: 10bit is not 4:2:2 as the command told to ffmpeg - it is 4:2:0. Hmmmm. On the other side, 8bit is the only file I can playback on my old machine. For the other 2 files I just see the first frame and hear the sound. Reading the metadata with MediaInfo I exactly see what I setup, so I think it was correct.

Edit:

10bit 4:2:0 (yuv420p10le) - 2.015.250 Byte
Video
ID                                       : 1
Format                                   : HEVC
Format/Info                              : High Efficiency Video Coding
Format profile                           : Main 10@L4@Main
Codec ID                                 : hev1
Codec ID/Info                            : High Efficiency Video Coding
Duration                                 : 2 s 0 ms
Bit rate                                 : 7 910 kb/s
Width                                    : 1 856 pixels
Height                                   : 1 044 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Constant
Frame rate                               : 25.000 FPS
Color space                              : YUV
Chroma subsampling                       : 4:2:0
Bit depth                                : 10 bits
Scan type                                : Progressive
Bits/(Pixel*Frame)                       : 0.163
Stream size                              : 1.89 MiB (98%)
Writing library                          : x265 3.4+22-772b3229d157:[Mac OS X][clang 11.0.0][64 bit] 10bit
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on December 29, 2020, 05:15:54 PM
YEah encoding with h.265 takes a bit longer but its worth it, theres almost twice as much detail in h265 files for the same filesize vs h264 , its crazy.
I went into the source and changed i think both medium presets of h264 AND H265 to 14 to get good filesizes and detail , i dont remember now exact numbers i think they were on 18.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mevi on December 29, 2020, 07:33:20 PM
Quote from: masc on December 29, 2020, 05:03:43 PM
DNG is no real export, it is just a copy of data into another structure and is still RAW - so it is mostly just a waste of time and diskspace. But MLVFS (on the fly conversion) is not compatible with an iPad I think... I don't know Lumafusion - what debayer does it use? Not all programs out there are able to process RAW in a nice way. But maybe you have luck and get good results.

A quick Google for lumafusion's debayer came up blank. The iPad runs iOS, so it's VERY limited by hardware and the OS. If the file format isn't supported by the device, Lumafusion can't open it.

Whatever, Lumafusion won't remove the IR dots by itself. ;D

I should stick with MLVapp to do the heavy lifting and hopefully HDR 10bit H265 export can be implemented. I'm amazed and impressed to see the development team pick up this feature request so quickly. 8)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 29, 2020, 07:41:10 PM
Quote from: Mevi on December 29, 2020, 07:33:20 PM
I should stick with MLVapp to do the heavy lifting and hopefully HDR 10bit H265 export can be implemented. I'm amazed and impressed to see the development team pick up this feature request so quickly. 8)
HDR is what you do with the image data. You can't get more than what is included in RAW. So process it in a way to get out the most of it. With the latest commits you are already able to export 10bit H.265. You just need to compile it for now. Modification was easy and your tip was good, so the modification was fast ;)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mevi on December 29, 2020, 07:48:37 PM
This is what mediainfo says about the 10bit HLG D65 P3 H265 file I just exported from Lumafusion.

I can edit this file on a timeline.... I don't know if there are benefits to editing with this or whether this file type is intended to be for delivery only, like with Dolby vision.


*** General
Complete name                             :  /storage/1479-1B74/My project (2).mp4
Format                                    :  MPEG-4
Format profile                            :  Base Media / Version 2
Codec ID                                  :  mp42 (isom/mp41/mp42)
File size                                 :  47.0 MiB
Duration                                  :  3 s 542 ms
Overall bit rate                          :  111 Mb/s
Encoded date                              :  UTC 2020-12-29 18:36:52
Tagged date                               :  UTC 2020-12-29 18:36:59

*** Video
ID                                        :  1
Format                                    :  HEVC
Format/Info                               :  High Efficiency Video Coding
Format profile                            :  Main [email protected]@Main
Codec ID                                  :  hvc1
Codec ID/Info                             :  High Efficiency Video Coding
Duration                                  :  3 s 542 ms
Bit rate                                  :  111 Mb/s
Width                                     :  3 840 pixels
Height                                    :  2 160 pixels
Display aspect ratio                      :  16:9
Frame rate mode                           :  Constant
Frame rate                                :  24.000 FPS
Color space                               :  YUV
Chroma subsampling                        :  4:2:0
Bit depth                                 :  10 bits
Bits/(Pixel*Frame)                        :  0.558
Stream size                               :  46.9 MiB (100%)
Title                                     :  Core Media Video
Encoded date                              :  UTC 2020-12-29 18:36:52
Tagged date                               :  UTC 2020-12-29 18:36:59
Color range                               :  Limited
Color primaries                           :  Display P3
Transfer characteristics                  :  HLG
Matrix coefficients                       :  BT.709
Codec configuration box                   :  hvcC

*** Audio
ID                                        :  2
Format                                    :  AAC LC
Format/Info                               :  Advanced Audio Codec Low Complexity
Codec ID                                  :  mp4a-40-2
Duration                                  :  3 s 542 ms
Source duration                           :  3 s 605 ms
Bit rate mode                             :  Constant
Bit rate                                  :  128 kb/s
Channel(s)                                :  2 channels
Channel layout                            :  L R
Sampling rate                             :  48.0 kHz
Frame rate                                :  46.875 FPS (1024 SPF)
Compression mode                          :  Lossy
Stream size                               :  57.8 KiB (0%)
Source stream size                        :  58.5 KiB (0%)
Title                                     :  Core Media Audio
Encoded date                              :  UTC 2020-12-29 18:36:52
Tagged date                               :  UTC 2020-12-29 18:36:59




Running time
00:00.125
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 29, 2020, 09:10:14 PM
HLG seems to be some "HDR" format standard recently developed by bbc(starting in 2017). Looks like a kind of gamma approach based around hdr tv technology. Not sure if it reads metadata in file and apply the gamma straight in the tv or if it needs encoding in hlg or maybe both? Ben Turley has a few formats around HLG. Maybe it´s enough to apply a 1D lut here?
(https://i.postimg.cc/NFqSLsQ8/Ska-rmavbild-2020-12-29-kl-20-59-06-png-800px.png)

Here´s a pretty good explanation:
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 31, 2020, 04:08:03 PM
Quote from: MotherSoraka on December 21, 2020, 01:36:07 AM
Seems all my darkframes generated by MLV_Dump have the wrong framef count in metadata. My new MLVApp generated darkframes don't exhibit the same issue.
So... have I missed something while using MLV_dump?
Correct, mlvdump generated darkframe MLVs have wrong (original) frame count in the header. Unfortunately I did not correct this in mlvdump. Just put correct code into mlvapp.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on December 31, 2020, 04:18:49 PM
Hmm... that HLG stuff is interesting.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 31, 2020, 05:10:19 PM
Quote from: bouncyball on December 31, 2020, 04:08:03 PM
Correct, mlvdump generated darkframe MLVs have wrong (original) frame count in the header. Unfortunately I did not correct this in mlvdump. Just put correct code into mlvapp.
Seems steroid mlv_dump version has the corrected file count:
in mlv_dump.c:
                if(mlv_output)
                {
                    if(average_mode)
                    {
                        file_hdr.videoFrameCount = 1;
                    }

Averaged output in Mlv App:
(https://i.postimg.cc/MZBmWKSH/Ska-rmavbild-2020-12-31-kl-17-08-41-png-500px.png)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mevi on January 04, 2021, 04:41:15 PM
I've been wrestling with this problem for a few days and just can't find a solution. The conversion to a bt2020 colour space in FFMpeg always shifts contrast and the reds and/or saturation.

If I remove the colourspace conversion in the encoding, the footage looks fine, but I get banding if I push the grade - it's likely 8bit colourspace. The HDR is also broken as soon as SMPTE 2084 and BT2020 is taken out, so it's not an HDR10 file.


FOR CONTEXT: The H.265 hardware acceleration of the iPad pro makes this file format ideal for editing with smooth scrubbing and playback of 4K without dropped frames. The iPad Pro can edit Canon's new 8K files!
There's no ProRes support in iOS yet but I can import DNGs or other image sequences into the iPad and export them as HLG 150Mbs MP4 - that is currently my best workflow option and the output files are perfect. It's stupidly fast to render, but kinda clunky moving these image sequences around on the iPad. If I do end up working this way, I will concatenate all the clips of image sequences into a single video file.



but back to that colourspace conversion problem...

I've tried using uncompressed AVI and HuffYUV and even PNG sequence as the base format - DNG doesn't work at all in FFMpeg.

I've googled and googled and googled and find nothing that isn't related to HDR media playback. Obviously, I'm living life on the razors edge here.  :D

This is my .bat file for batch encoding AVI files. The "scale=out_color_matrix=bt2020" makes no difference at all BTW.

for %%a in ("*.avi") do ffmpeg -i "%%~na.avi" -pix_fmt yuv420p10le -vf scale=out_color_matrix=bt2020 -c:v libx265 -tune grain -profile:v main10-intra -x265-params level=6.2:hdr10-opt=1:hdr10=0:repeat-headers=1:no-strong-intra-smoothing=1:bframes=0:b-adapt=2:frame-threads=0:colorprim=bt2020:transfer=smpte2084:colormatrix=bt2020nc:master-display=G(8500,39850)B(6550,2300)R(35400,14600)WP(15635,16450)L(40000000,50):max-cll=1000,400:vbv-bufsize=800000:vbv-maxrate=800000:crf=14 -preset slow -brand mp42 -tag:v hvc1 -c:a aac -b:a 320k "%%~na.mp4"
pause
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Kharak on January 04, 2021, 06:57:41 PM
Can AVI contain the metadata for HDR/HLG?

I am surprised there is no support for prores on the Ipad, then again its a tablet, but I thought they unified the entire IOS, from phone to laptop?

Do you have a computer that you can test if the Prores or DNxHR work with the metadata?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mevi on January 04, 2021, 11:59:54 PM
The new Apple Silicon Macs can run iOS apps, but it doesn't work the other way. I can't see Apple merging separate revenue streams into a single product. They want me to buy a Mac to go with this iPad.  ::)

ProRes isn't supported on iOS and probably won't be. See the above paragraph.  :D My batch file does create all-intra files, which I guess makes that similar in concept. More expensive cameras have been recording h264 all-i for some years now.

I have a Windows PC. VLC might play ProRes. I can probably see the metadata too, but as an unsupported codec on iOS it's a dead end for me right now.

Your AVI colorspace metadata idea... that is something for me to investigate. The metadata of HuffYUV and uncompressed AVI output from MLVapp is just labeled "YUV".

Thanks Kharak
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mevi on January 05, 2021, 01:30:19 AM
Quote from: Mevi on January 04, 2021, 11:59:54 PM.
Your AVI colorspace metadata idea... that is something for me to investigate. The metadata of HuffYUV and uncompressed AVI output from MLVapp is just labeled "YUV".
Thanks Kharak

HLG/HDR10/rec2020/rec2100 really seems like it ought to be set up from acquisition. For me and most editors, it'll be taking that raw DNG sequence and putting it straight onto a HLG bt2020 timeline.

All of my talk of color space transfers was a rabbit hole of doom, but I'm much more informed now. I might not ever use a rec709 workflow ever again.

My poor old brain kinda hurts now, but switching to a totally bt2020 workflow will get the best out of our RAW footage. If we were to grade bt2020 colour space and render to HLG, we can upload that to YouTube to be played back in HDR on compatible devices.... You might even have one in your pocket.

Oh and my camera doesn't even arrive for another 2 days.  :D
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: BatchGordon on January 05, 2021, 01:35:03 AM
Lately, I am studying by myself the Bayer filter and some demosaicing algorithms.
I think those included in MlvApp are great and the results are generally stunning.
What I'm not sure about is the correctness of the common way to proceed with videos recorded using the 1x3 binning pattern.
In my opinion, demosaicing the video then doing a horizontal stretch (or a vertical shrink) is going to lose part of the information captured with the raw image.
Personally, I would first expand the raw image unbinning the pixels with an ad-hoc algorithm, then I would apply to the resulting raw one of the existing algorithms (e.g. Amaze).
I could be wrong, but if you look at the pixels that are binned... they are spatially in a slightly different position compared to a normal Bayer filter.
I have an idea about how to do the unbinning, but I would like to have some suggestions on where to make the changes to the code.
BTW, I am a software developer, so my problem is not in coding, but not all the project code is clear to me.
If someone can help proceed with the test, that would be great.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on January 05, 2021, 01:56:18 AM
@BatchGordon

The unbinning idea came two years ago, you may want to read from here:
https://www.magiclantern.fm/forum/index.php?topic=16516.msg210484#msg210484

A few posts later: the binned pixels can't be unbinned, the information of original unbinned pixels are lost forever.

It would be cool if someone find out how to process/stretch 1x3 data in a better way to enhance the quality.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: BatchGordon on January 05, 2021, 06:56:44 PM
@theBilalFakhouri

Yes, I already read that post. It helped me to understand how the binning is done in these cameras. And I have seen other people had almost my same idea.

What you say is absolutely true, we cannot restore the information that is lost with the binning.
But still I think an unbinning process is needed before doing the demosaicing: the value for the unbinned pixels won't be the original one, just an estimation from the nearest ones.

My opinion is not that we can restore what is lost during binning, but that applying a demosaicing algorithm made for unbinned pixels won't give best results on a binned image. In other words, I think we are losing even more detail than what the binning process itself implies.
It's absolutely just an opinion and I could be wrong, but I would like to test it.

P.S.: I have seen your contribute on many parts of the project and I really consider it impressive!
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on January 27, 2021, 07:58:43 PM
A couple of questions,

1) I'm getting the map of bad pixels out of track when copying it to other pictures. They still work fine but they look misaligned.

https://i.imgur.com/vBmTeFq.png

2) Is there a way to export the bad pixel map and use it in another projects?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 27, 2021, 08:16:57 PM
@togg:
1) how did you get this picture? What exactly does it show?
2) no need for this
--> you define the bad pixel map for any clip. This map is saved as .bpm in the MLVApp folder. As soon as you activate bad pixel map fix for any other clip using the same camera raw stream settings, the same .bpm will be used again. So ideally, you create this map once for your setting and use it forever for all future clips (in the same setting).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on January 27, 2021, 08:50:24 PM
It seems MLVApp doesn't skip black borders (OB Zones?) in MLV silent picture files, here is a sample from 700D:
https://drive.google.com/file/d/1lZ91OUQ9BQN5kyBtrXpUa0-YTiz92V6J/view?usp=sharing

It's showing the full 5280x3528 image, it should be 5208x3478 (Effective pixels on 700D) when skipping black borders in the top and left
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 27, 2021, 09:18:27 PM
Interesting. mlv_dump to dng shows the correct zones.

Exporting to dng from mlv app seems to work. Only preview that is problematic.
Exporting to prores keeps the black borders. Needs fixing.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 27, 2021, 10:03:44 PM
Thanks for reporting. But in what mlv object do I find the info how to crop? I would expect it in VIDF, but all is "0":
(https://i.ibb.co/CnmNbyC/Bildschirmfoto-2021-01-27-um-22-02-05.png)
RAWC the same... all "0".
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 28, 2021, 05:08:53 AM
Check default cropsize in a dng. Then check this place in mlv metadata:
Block: RAWI
  Offset: 0x00000034
  Number: 1
    Size: 180
    Time: 3.646000 ms
    Res:  5280x3528
    raw_info:
      api_version      0x00000001
      height           3528
      width            5280

      pitch            9240
      frame_size       0x01F16AC0
      bits_per_pixel   14
      black_level      2047
      white_level      15232
      active_area.y1   52
      active_area.x1   72

      active_area.y2   3528
      active_area.x2   5280
      exposure_bias    0, 0
      cfa_pattern      0x02010100
      calibration_ill  1

3528 - 52 = 3476
5280 - 72 = 5208

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 28, 2021, 09:15:39 PM
Hm... something seems to be missing...
(https://i.ibb.co/3dWKfpw/Bildschirmfoto-2021-01-28-um-21-14-21.png)
Can't find any 72 and 52 in the entire MLV structure.

Edit: here it is - very good hidden.
(https://i.ibb.co/pbvmbcj/Bildschirmfoto-2021-01-28-um-22-07-56.png)
But when searching for "active_area", there is no line in processing code using it. So it seems to be a bigger work to integrate - it isn't just a bug.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on January 28, 2021, 10:40:09 PM
You may want to compare it against mlv_lite @ 5208x3478 MLV which shows correctly in MLVApp without black borders, here is a sample:
https://drive.google.com/file/d/14Co4dvdnQ3w4WN8vlX0wd6ctF6YireWH/view?usp=sharing

@masc
How did show these information? I know it's possible with mlv_dump but which tool are you using?



Quote from: BatchGordon on January 05, 2021, 06:56:44 PM
My opinion is not that we can restore what is lost during binning, but that applying a demosaicing algorithm made for unbinned pixels won't give best results on a binned image. In other words, I think we are losing even more detail than what the binning process itself implies.
It's absolutely just an opinion and I could be wrong, but I would like to test it.

We all would appreciate if someone find a new way which enhance/maximize 1x3 quality files (I don't have an idea how it would be done), a1ex has done it before for Dual ISO files, he developed his algorithm over time, and we got fantastic results from Dual ISO images with less quality loss and less aliasing in processed Dual ISO files.

Quote from: BatchGordon on January 05, 2021, 06:56:44 PM
P.S.: I have seen your contribute on many parts of the project and I really consider it impressive!

Thank you very much! :)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 29, 2021, 05:55:43 PM
Quote from: theBilalFakhouri on January 28, 2021, 10:40:09 PM
You may want to compare it against mlv_lite @ 5208x3478 MLV which shows correctly in MLVApp without black borders, here is a sample:
https://drive.google.com/file/d/14Co4dvdnQ3w4WN8vlX0wd6ctF6YireWH/view?usp=sharing

@masc
How did show these information? I know it's possible with mlv_dump but which tool are you using?
Thank you! This file looks different in metadata. Here I see the correct size in RAWI: 5208x3478 (instead of 5280x3528 in your other file). No idea if that is the reason why it is showed correctly. Information in raw_info is slightly different: x1=72, x2=5280, y1=28, y2=3506.

You get this information, if you compile MLVApp in Debug mode, and start it with debugger. I set a breakpoint into MainWindow::drawFrame(). As soon as a frame is drawn, the debugger stops the app and I can see all internal variables. Here the complete screen:
(https://i.ibb.co/Zm8XWrZ/Bildschirmfoto-2021-01-29-um-17-51-17.png)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 29, 2021, 06:12:09 PM
Maybe better to change the silent dng/mlv code so it works the same as when recording with mlv_lite?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on January 30, 2021, 11:57:58 AM
Quote from: Danne on January 29, 2021, 06:12:09 PM
Maybe better to change the silent dng/mlv code so it works the same as when recording with mlv_lite?
Exactly!

Different recorder modules use different values. They need to be fixed same way.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 30, 2021, 12:10:07 PM
Care to look into it Bouncyball  8)? silent.c a good start I guess?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on January 30, 2021, 12:30:57 PM
QuoteMaybe better to change the silent dng/mlv code so it works the same as when recording with mlv_lite?

Please don't break the silent module for us humble photographers  :) ;)

If someone is going to look at the silent module, then maybe a chance to tweak a few things, eg get EXIF working and the ability to change image file name via Lua  ;)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 30, 2021, 12:53:59 PM
What would break? It's broken right now kind of.
I don't see photography and film features as two divided groups the way you describe it. Both approaches are fruitful to one another. And also please stick to recent discussed issue before presenting more personal wishes. Thanks
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: garry23 on January 30, 2021, 12:56:18 PM
I'll stop using  ;) :) in the future.

Over and out.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: a1ex on January 30, 2021, 01:09:19 PM
Silent pictures contain the complete image buffer delivered by Canon firmware (including black bars), while MLV frames contain a cropped section, not including black bars. Last time I've checked, mlv_dump was handling both types of files correctly (edit: tested two samples linked earlier, they both work fine with mlv_dump).

The tricky part is that raw_info structure is copied directly from current LiveView configuration - that is, it includes the active area offsets for a complete LiveView frame. As the MLV video frame (from mlv_rec/mlv_lite) is cropped, its active area offsets should be updated, and - since the black bars are not normally included in the recorded image - those offsets would be normally 0.

In mlv_dump, this is currently handled as a special case: if the frame size from the RAWI header (xRes x yRes) is smaller than the complete raw frame size (raw_info.width x height), that must be a cropped section of the entire frame. Since the black bars are not included in the recorded image, active_area is assumed to cover the entire recorded frame (that is, active_area offsets must be rewritten - "zeroed out" - by the MLV converter). If the frame size from RAWI matches the one from raw_info, that means the recorded image contains the complete raw frame, including black bars, so the active area declared in raw_info is considered valid (and should be used for conversion).

The offset fields from RAWC are supposed to show where the complete LiveView frame (possibly binned/cropped by crop_rec, x5 zoom, Canon's 1080p / 720p / crop mode etc) is placed, relative to a full-res image (FRSP or CR2), but these are not implemented yet.

The position of the cropped image (saved by mlv_rec/mlv_lite), relative to the complete LiveView frame, is given by VIDF cropPosX/Y (restrictions: we can only crop multiples of 8 pixels horizontally - because of 14-bit packing - and multiples of 2 pixels vertically, in order to keep the same Bayer layout). The "pan" offsets (panPosX/Y) were meant for smooth digital panning within a complete LiveView frame frame (not implemented yet (https://www.magiclantern.fm/forum/index.php?topic=21764.0)).

In any case, I don't see a good reason for changing the silent picture code - it works as expected, if you ask me. Changing the active_area offsets should have been done in mlv_rec/mlv_lite from the very beginning, rather than requiring MLV converters to rewrite these offsets - but now it's probably too late to make this change.

In other words, the active area metadata in a silent picture MLV is correct, while the one from a mlv_rec/lite MLV is invalid and must be "zeroed out" (recomputed from scratch) by the MLV converter. I don't see a good way out of this, other than using the above workaround (special case) in MLV converters.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: davvore33 on January 31, 2021, 05:31:27 PM
Hi everybody, got a news, I've created the package build for Archlinux for MLV.app, you can find it here https://aur.archlinux.org/packages/mlv.app/ (https://aur.archlinux.org/packages/mlv.app/)

if you want you can mention it on your website or something
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on January 31, 2021, 09:56:45 PM
Quote from: masc on January 27, 2021, 08:16:57 PM
@togg:
1) how did you get this picture? What exactly does it show?
2) no need for this
--> you define the bad pixel map for any clip. This map is saved as .bpm in the MLVApp folder. As soon as you activate bad pixel map fix for any other clip using the same camera raw stream settings, the same .bpm will be used again. So ideally, you create this map once for your setting and use it forever for all future clips (in the same setting).

1) it shows a set of hot pixel that I have selected in another picture on the same project that are displayed misaligned in other clips, but still work as intended. It's hard to explain ahah
.
2) mmm I'm not sure this is even working on my side. I don't have a .bpm file on the MLVApp folder and I'm almost sure than when I opened another project there was no past memory.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 31, 2021, 10:32:21 PM
@togg: the .bpm is auto generated as soon as you start telling MLVApp where the pixels are.
https://www.youtube.com/watch?v=Xwd2DFGjMx0


@davvore33: great news! Thank you! Yes, we'll add a link to the repo.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on February 01, 2021, 11:20:53 PM
I posted it before and recently i posted it in EOS M topic but i think it more belongs here. i get quite big difference in colours when importing 5D2 footage into mlvapp VS canon M footage, here are the same scenarios filmed with 5D2 and M.
DNG FRAMES :
Heres 5D2 frame:
https://drive.google.com/file/d/1RKpYa74qClOBkwEOspcC9jj3HnrG997T/view?usp=sharing
M frame:
https://drive.google.com/file/d/1OiF8FNmcuHAJs1kqnnuhw2NRrnaECH_5/view?usp=sharing

MLVAPP:
5D2:
(https://i114.fastpic.ru/big/2021/0202/b9/66762118fb6acccaf2a1d0d1e00fa0b9.jpg)
M:
(https://i114.fastpic.ru/big/2021/0202/4a/ee3ac8ca6bedb82d119a0f053e2aeb4a.jpg)
ADOBE LIGHTROOM ( looks very similar on both so theres no issue here)
5D2:
(https://i114.fastpic.ru/big/2021/0202/f6/112a6c7ce82373c3b0dc7c87c362b9f6.jpg)
M:
(https://i114.fastpic.ru/big/2021/0202/b8/c24e18642f11c0d6971d2bd60b32e9b8.jpg)

So there is something going on when debayering in mlvapp and it affects not only tonemapped conversion but logs too, im not sure what it is but its there i can see that 5D2 has weak reds, they look orangey, look at the reds above yellow paint VS M image from mlvapp which looks correct.Those paints above yellow are reddish not orangey like on 5D2 and no white balance can fix this, and if it does then everything else looks off.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 01, 2021, 11:25:49 PM
I think I have a déjà-vu. Didn't we already talk about exactly these images a while ago? If I remember right, the conclusion was: in MLVApp we use camera matrix values from the RAW metadata and Adobe seems to use own matrix values. But I am not sure if I remember right... should be "some" pages in this thread ago.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on February 01, 2021, 11:54:30 PM
It was but Id like im using tonemapped  and camera matrix most of the time, colors dont look that good without it. But i tried it , changing different methods like srgb and not using camera matrix and it really doesnt fix the colours whatever i do in mlvapp, i have to use HSL curves to bring back reds and squash the orange.
Theres just no red in that 5D2 image from mlvapp, its like orange and its strange.IT affects the sking and its the reason i dont film with 5D2 that much.
I brought it up cause maybe there is something thats causing this difference especially if in lightrooom both look the same.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on February 02, 2021, 02:55:41 AM
Quote from: masc on January 31, 2021, 10:32:21 PM
@togg: the .bpm is auto generated as soon as you start telling MLVApp where the pixels are.
https://www.youtube.com/watch?v=Xwd2DFGjMx0


OK I see it now! I mean I see it working. Even if I am unsure where the map is located, but all good! Great feature.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 02, 2021, 08:52:29 AM
@2blackbar: if our suggestion is right, you just need to find the correct matrix. We use the matrix coming from the camera. No problem to exchange it in the source code.

@togg: The maps can be found in the same path where MLVApp executable is located.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 02, 2021, 02:19:41 PM
@2blackbar the 5D2 has weaker red saturation compared to most cameras when using a 3x3 matrix, this is an issue in all raw converters that use these same matrices by Adobe. However Adobe's own profiles include some hue-based adjustments on top of the matrix, which we don't use, but that's how they correct the reds I believe.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on February 02, 2021, 02:56:04 PM
Ah i knew somethng was off, do you know where i can look up the hue adjustments to apply in mpvapp?
are there more cams affected by this besides 5d2?
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on February 02, 2021, 03:05:36 PM
I don't think you can directly translate the hue adjustments in Adobe profiles to MLV App's hue adjustments, as Adobe does hue adjustment in some way which we don't replicate exactly. What you do manually is probably no worse than what Adobe has in their profile. This stuff is just a bodge by Adobe to try and improve on 3x3 matrices imo.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 03, 2021, 08:45:12 AM
Quote from: davvore33 on January 31, 2021, 05:31:27 PM
Hi everybody, got a news, I've created the package build for Archlinux for MLV.app, you can find it here https://aur.archlinux.org/packages/mlv.app/ (https://aur.archlinux.org/packages/mlv.app/)
Yay!
Finally MLVApp is in AUR.
Thank you.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 03, 2021, 08:51:13 AM
Quote from: Danne on January 30, 2021, 12:10:07 PM
Care to look into it Bouncyball  8)? silent.c a good start I guess?
Haha! I changed my mind :P. I'll better stick with fixing mlvapp.

@a1ex: Thank you for comprehensive information (as always).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 03, 2021, 09:50:03 AM
Cool. It would be a great addition to have it working in mlvapp :).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 03, 2021, 10:42:56 AM
@theBilalFakhouri

I've tested 700D silent mlv shared by you and the story is:

MLVApp exports DNGs without black areas exactly as mlv_dump does, e.g. correctly.
It's just the mlvapp also happens to have :P image preview/export feature and uses whole buffer for this as it was expected.

Stay tuned... (never loaded silent pic mlv until now)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 03, 2021, 11:48:03 AM
Well, here is the next part of the story:

The image buffer of silent pics includes OB but Image buffer recorded by other mlv recorders does not, hence, as a1ex mentioned, active area metadata is wrong. When exporting DNGs, this situation handled by rewriting active area metadata by software (mlv_dump, mlvapp). But, the truth is that whole image buffer including OB area goes into DNGs (hence nothing is done to image buffer itself). Instead the DNG header active area appropriate fields filled with correct values. When DNG is opened in some processing software it reads only active area into buffer.

Mlvapp operates with whole image buffer from any mlv and uses it during debayer. So to correct this "misbehaving" it needs to read only active area which is not implemented. Do you really need this feature to be implemented in raw part guys? ;) or maybe crop OB area during postprocessing?

BR
BB
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 03, 2021, 12:55:19 PM
Yes, needed ;). Silent module is really cool, deserves the fix imo.
Will I use it personally. Maybe not a lot right now but who knows about the future.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 03, 2021, 06:32:56 PM
@bouncyball: 100% agree all of what you wrote. Correcting that means changing many many functions, in all parts of MLVApp.
Quote from: bouncyball on February 03, 2021, 11:48:03 AM
Do you really need this feature to be implemented in raw part guys? ;) or maybe crop OB area during postprocessing?
This is what I also thought about... we're talking about 3 clicks in a NLE vs. weeks of hard work correcting that few black pixels... surely a nice to have for the future.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 06, 2021, 10:10:19 AM
Quote from: Danne on February 03, 2021, 12:55:19 PM
Yes, needed ;)
Haha! Well, we'll think about it :)
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 06, 2021, 10:20:31 AM
@masc

Yes, it's really pointless to do this in the raw part of the mlvapp. Sadly we do not have crop functionality implemented in post processing either. FFMPEG crop option could be implemented during export but this would be just half of the job done.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 06, 2021, 10:27:23 AM
I think silent module is something to incorporate in Mlv app. That is, you find the the time and interest B. What's a week in code world really ;).

Why pointless @masc @bouncyball. One big reason I didn't continued using silent module was this uncropped output in mlv so I went and worked some lua scripts using movie mode and crop rec instead.

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 16, 2021, 11:25:33 AM
Quote from: Danne on February 06, 2021, 10:27:23 AM
Why pointless
Uh, I meant in the RAW processing part of MLV app (e.g. reading rawdata). But in RGB domain during image processing it makes sense.
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 16, 2021, 12:54:24 PM
Yes, seems really hard through raw pip  8).
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 08, 2021, 09:10:56 AM
Finally new version is out:

New in v1.12:
- Selection for copy / paste receipts reworked
- Added profile and gamma definition by math expression (still work in progress)
- Added auto focus pixel map download and update
- Fix for no audio in spanned clips
- Fix for darkframe subtraction
- Added Session table mode (shows all session clip metadata in one table)
- Added CineForm export 10bit (4:2:2) and 12bit (4:4:4)
- Added H.265 export 10bit (4:2:0) and 12bit (4:4:4)
- Added grain generator luma weight slider (apply grain in dependency to luma)
- Some bug fixes and some minor changes
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: wib on March 08, 2021, 12:29:46 PM
oooh what is that ?

"Fix for no audio in spanned clips"

is it the audio bug that occurs with card spanning recording ?

Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yokashin on March 08, 2021, 12:39:41 PM
Quote from: masc on March 08, 2021, 09:10:56 AM
Finally new version is out:

New in v1.12:

Thank you very much  :D
Title: Re: MLV App 1.11 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 08, 2021, 12:43:53 PM
Quote from: wib on March 08, 2021, 12:29:46 PM
oooh what is that ?

"Fix for no audio in spanned clips"

is it the audio bug that occurs with card spanning recording ?
Let me think about... the fix is nearly a year ago... :D Sometimes MLVApp did not show the audio part in clips, when card spanning was used (but audio was definitively inside). I still have a similar looking problem today, but here there is no audio in those clips.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Richard R on March 08, 2021, 04:27:44 PM
Hello,
I am completely new on this forum. So this question might have been asked before. Today I downloaded the new MLV app 1.12. Now everything seems okay, but if I choose BDM film preset the MLV footage becomes very dark and the highlights over exposed. If I just choose processing gamut: BDM film it looks better but not like the previous version of MLV app. Is this a bug or perhaps someone has an answer. By the way, I use a Mac.
Thank's a lot
Richard
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 08, 2021, 05:05:29 PM
If you like to use the BMDFilm preset, you must use an older version. Since 1.12 a preset must be defined as math eqaution. And there is no equation published for BMDFilm. In older versions we implemented a kind of LUT just for this single preset. The profile feature is still work in progress, but it seems BMDFilm will not longer be supported, because it is Blackmagics secret.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Richard R on March 08, 2021, 06:26:40 PM
Quote from: masc on March 08, 2021, 05:05:29 PM
If you like to use the BMDFilm preset, you must use an older version. Since 1.12 a preset must be defined as math eqaution. And there is no equation published for BMDFilm. In older versions we implemented a kind of LUT just for this single preset. The profile feature is still work in progress, but it seems BMDFilm will not longer be supported, because it is Blackmagics secret.
Thank you Masc for your reply. As usual a fast reply. Anyhow I use DNG, only sometimes I export as ProRes. But it is good to know.
We know each other from You tube.
A Warsteiner for you. Cheers.  ;D
Richard
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Kharak on March 16, 2021, 12:54:34 PM
What did you fix with Darkframe Averaging


Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 16, 2021, 02:42:46 PM
Quote from: Kharak on March 16, 2021, 12:54:34 PM
What did you fix with Darkframe Averaging
There was a bug, that darkframe files weren't unloaded after a frame was processed. And at some point (in playback or export) that crashed the app.
https://github.com/ilia3101/MLV-App/commit/046c603a86f343e8eb43049504369310f62149b0
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: canoneer on March 17, 2021, 02:48:31 PM
Hi all. Been advised to build a local test - and have follow Dannes simple route for Mac on 1st page.

Though being lost in Mac-details I managed to compile - but I do not know where to pick up the result from the compile nor what next step should be - a successful compile do not help much without getting next step done I guess (42 years since programming was my job for a short while).
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 17, 2021, 04:20:39 PM
Fine! Next step would be to test as much as you can (as much combinations of features possible) with your build and report problems. That build will mostly just work with your computer... dependencies should all be installed by the installation of Qt.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mr_gorilla_image on March 18, 2021, 11:49:20 PM
Hi team

I have an issue that I believe has already been encountered before and addressed so sorry if this is a repeat (I can find a reference or solution to it on here).

Installed MLV App today (on windows 10Pro) and was able to export all codec types with no issues..... Something has happened and now I can export to DNG only.

The export process appears to run as normal, but no files are actually exported.

Very 'green' to all this so not sure what info is needed to explain further (I just loaded ML onto my 5DmkIII today).

Thanks in advance for help 


Best

M
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on March 20, 2021, 01:49:08 PM
Quote from: Mr_gorilla_image on March 18, 2021, 11:49:20 PM
Installed MLV App today (on windows 10Pro) and was able to export all codec types with no issues..... Something has happened and now I can export to DNG only.

The export process appears to run as normal, but no files are actually exported.
Seems like, annoying ;), console window has been closed, or ffmpeg.exe is not reachable.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 02, 2021, 07:15:32 PM
Is it normal that it takes twice as long to exportvideo with grain enabled - 45mins vs wih disabled - 22 minutes?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 02, 2021, 07:21:03 PM
Quote from: 2blackbar on April 02, 2021, 07:15:32 PM
Is it normal that it takes twice as long to exportvideo with grain enabled - 45mins vs wih disabled - 22 minutes?
Definitively not. Here, adding noise makes nearly no difference in export time. Denoising would be slow.

Edit:
Quick test results of a test clip, just for the difference: default settings, AMaZE, H.264 export:
without noise: 2:15min
with noise: 2:43min
In preview it is closer. It seems the encoder needs more time. MLVApp processing is not too difficult for a processor.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 02, 2021, 09:11:42 PM
i also  add sharpness to 64 and upscale 1920 to 2500 then go h265, would  that make a difference?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 02, 2021, 09:43:05 PM
Sharpness and upscaling also doesn't change that, because grain is generated in source resolution, after sharpening. H.265 is very CPU hungry. This could be the reason.

Edit: difference is about the same as above. Difference default vs. grain+scaling+sharpness should be bigger.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on April 05, 2021, 01:59:48 PM
I've got some strange behavior. When exporting converted clips after export is done, the destination folder is empty. Tried different export formats/settings.
I'll try to find the problem as I assume, I'm doing smth wrong. Never happened before. Win10 64.
I'll report here later
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 05, 2021, 02:08:52 PM
Probably ffmpeg is missing in your MLVApp installation folder.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: yokashin on April 05, 2021, 02:10:40 PM
I used to describe a similar problem.

https://www.magiclantern.fm/forum/index.php?topic=20025.msg223632#msg223632


Quote from: Dmytro_ua on April 05, 2021, 01:59:48 PM
I've got some strange behavior. When exporting converted clips after export is done, the destination folder is empty. Tried different export formats/settings.
I'll try to find the problem as I assume, I'm doing smth wrong. Never happened before. Win10 64.
I'll report here later
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on April 05, 2021, 02:24:59 PM
Quote from: masc on April 05, 2021, 02:08:52 PM
Probably ffmpeg is missing in your MLVApp installation folder.

ffmpeg seems to be there
(https://i.ibb.co/7nGM4Gp/ffmpeg.jpg) (https://imgbb.com/)

The path does not contain any non Latin symbols.

G:\!!!!!DNG DAVINCI TEST\MLV APP\Rozetka\TPLink
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 05, 2021, 03:04:13 PM
Does it export to "an easy path" like C:\test.mov ?
Did you close the command line window on export?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on April 05, 2021, 03:27:38 PM
Quote from: masc on April 05, 2021, 03:04:13 PM
Does it export to "an easy path" like C:\test.mov ?

Yes, it does. Strange thing though I've used this path before.

I've also found that it couldn't export regular DNGs to that path giving me an error of corrupted frames (all of them).
(https://i.ibb.co/wZq2TH7/Screenshot-2021-04-05-161933.jpg)

Anyway, smth's wrong with my path:
G:\!!!!!DNG DAVINCI TEST\MLV APP\Rozetka\TPLink
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on April 05, 2021, 03:37:03 PM
If you want to live a happy life you should learn to keep your path names clean!
Avoid fancy things like spaces and !!!!!. Use _ instead to enhance readability.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on April 05, 2021, 03:43:31 PM
Quote from: Dmytro_ua on April 05, 2021, 03:27:38 PM
Yes, it does.

Oh, to fast conclusion. After export all frames are corrupted, only sound is fine.


(https://i.ibb.co/fXQc0Gf/Screenshot-2021-04-05-164134.jpg)
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 05, 2021, 04:09:45 PM
Are you surprised with that path name? I am surpries windows even allow expressions in a folder name. Seems allowed on mac too. Pretty ridicoulous imo.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on April 05, 2021, 04:21:48 PM
Hello guys! Is there an option to export to DNxHR with custom resolutions? Premiere or resolve can do it, it would be great if MLV App could too..

Currently I'm using prores, but on my laptop similar DNxHR files plays 4-5 times better/faster than prores for some reason...
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 05, 2021, 05:46:56 PM
Those DNxH_ codecs are extremely limited. No luck in using something else than the known formats in MLVApp. All the DNxH_ limitations are no fun and very hard to handle. I even have big problems in playing back those files at all, while prores runs in realtime on 4 tracks at the same time. Even Media-Info often can't tell about the data in these files. Better use a better codec...
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 05, 2021, 07:37:51 PM
Now it seems I have had some luck with those DNxH_ codecs and tried to rework them. That means I don't get error messages from ffmpeg anymore. Would be cool, if someone could download, compile and test if these codecs work as expected. Especially DNxHD can't be played at all on my computers. DNxHR works as slideshow here.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on April 08, 2021, 02:50:29 PM
Maybe I can download and compile it, but I have very little expirience in all this, so maybe later when I finish some things..

Quote from: masc on April 05, 2021, 07:37:51 PM
Especially DNxHD can't be played at all on my computers. DNxHR works as slideshow here.
This is very strange, but on my computer it is exactly the opposite :) I mean ProRes vs DNxHR
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 11, 2021, 04:35:47 PM
if youre on windows, compiling mlvapp isnt that hard , you open it in qtcreator
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: kidfob on April 13, 2021, 07:47:30 AM
I was curious about ways to possibly speed up export times.

It is possible that this application can be updated to be multi-threaded? When I look at my CPU usage, it is low and multiple cores/threads dont appear to be used.

Alternatively, I supposed one could open multiple instances of the app and process files in parallel.

Thanks for such a great program!
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 13, 2021, 08:16:33 AM
The app runs 100% multithreaded. If your CPU usage is very low, it must be a problem with your system.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on April 14, 2021, 12:24:16 PM
I am trying to compile MLVApp on Windows 10. qt-opensource-windows-x86-5.9.0 with MinGW32 compiler. It installed "Qt Creator 4.3.0"
MLV-App-master.zip from https://github.com/ilia3101/MLV-App/tree/master
Then unpackffmpe gWin32.zip in platform/qt/FFmpeg
then open platform/qt/MLVApp.pro in QtCreator
then Build and Run.
MLVApp opens and works. MLVApp.exe 7591KB compiled in BuildDir\release.
Also ffmpeg.exe was copied to BuildDir\release
But after closing MLVApp it is impossible to run MLVApp.exe. There is a message about missing dll.
What is wrong?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 14, 2021, 12:47:14 PM
You need to "deploy" the application. That brings all the needed dlls from the Qt folder to the MLVApp folder. Search for windeployqt. You can also search and copy the dlls manually. Until this, you can only run your application from QtCreator.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on April 14, 2021, 01:06:35 PM
Quote from: masc on April 14, 2021, 12:47:14 PM
You need to "deploy" the application.
Thank you very much! I'll try.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on April 14, 2021, 02:42:59 PM
So I have "Error while building/deploying project MLVApp (kit: Desktop Qt 5.9.0 MinGW 32bit)
When executing step "Run windeployqt""
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 14, 2021, 03:32:20 PM
Quote from: vstrglv on April 14, 2021, 02:42:59 PM
So I have "Error while building/deploying project MLVApp (kit: Desktop Qt 5.9.0 MinGW 32bit)
When executing step "Run windeployqt""
How do you try that? It is a commandline call... but I just can say the macos command, which is different from the windows version. The option in QtCreator menu never worked (at least on all my Qt workstations).
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on April 14, 2021, 04:22:10 PM
I have tried in Run Settings -  windeployqt with arguments- "--qmldir C:\Users\alvli\Downloads\MLV-App-master\MLV-App-master\platform\qt" in QtCreator menu
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 14, 2021, 06:11:32 PM
On macos my command is:
/Applications/Qt5.7.0/5.7/clang_64/bin/macdeployqt Documents/MLV_App/platform/build-MLVApp-Desktop_Qt_5_7_0_clangOMP_64bit-Release/MLV\ App.app/

So:
<path to Qt binaries>/macdeployqt <path to MLVApp build folder>/<MLVApp executable>
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on April 14, 2021, 08:36:20 PM
Quote from: masc on April 14, 2021, 12:47:14 PM
You can also search and copy the dlls manually.
I have to add 11 ddls. I works.

Quote from: masc on April 14, 2021, 06:11:32 PM
On macos my command is:
/Applications/Qt5.7.0/5.7/clang_64/bin/macdeployqt Documents/MLV_App/platform/build-MLVApp-Desktop_Qt_5_7_0_clangOMP_64bit-Release/MLV\ App.app/

So:
<path to Qt binaries>/macdeployqt <path to MLVApp build folder>/<MLVApp executable>
Thank you! But it is out of my skill. I have tried cmd in win10 with windeployqt.exe. Cmd works without errors but mlvApp needs dlls.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: kidfob on April 15, 2021, 08:57:03 AM
Quote from: masc on April 13, 2021, 08:16:33 AM
The app runs 100% multithreaded. If your CPU usage is very low, it must be a problem with your system.

Are you using Windows or Mac? If Windows, would you mind posting a screenshot of the Performance tab in Task Manager (Logical Processors Graph) while you're performing an export?

Regarding the multithreaded strategy, I think it'd be great to have a thread process a different MLV in the session. So if I load 10 MLVs into an export session, Maybe 10 CPU cores could process them all at once.

Thoughts?

Thanks
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 15, 2021, 09:12:49 AM
Platform doesn't matter - code is identical. Here a ProRes4444 export on Win10, on 4-Core, 8 threads, all at 100% load. On macOS this looks identical.
(https://i.ibb.co/B632rmT/Bildschirmfoto-2021-04-15-um-09-09-17.png)
You wish a clip-single-core-processing which would disable (near-to-)realtime preview.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: kidfob on April 16, 2021, 12:17:05 AM
Interesting. Can you show a screenshot exporting a dual iso clip to cinemadng?

I'm just trying to determine any potential bottlenecks on my end. Maybe its the type of clips and my export format...

Thanks again.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 16, 2021, 09:45:47 AM
That could be the problem: the main DualISO algorithm is the only part of the processing engine which has to run on a single core (preview mode is multithreaded, but quality is worse). So just for the little time of aligning, just one core will have 100% usage (before and after that, all cores are used).
Sry... DualISO is one of the features I barely use, so I forgot about its special realization.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 16, 2021, 10:56:34 AM
Think it is single threaded because of giving strange results. However the issues with dualiso from mlv app(mlvfs) are still present single threaded. Until issues are adressed i'd recommend disabling dual iso completely in mlv app.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 16, 2021, 11:26:56 PM
Do You guys know what kind of tonemapping its used here?
It looks so much better and brings up a lot of detail , from what i see at the end hes using 3 sliders, one for hightlights, one for mids and one for shadows to bring them back.
Its kinda like luma adjustment overlay for each of 3 sections thats blended on top of the footage.Luminance ciurve in mlvapp gives similar result but theres something more to it in their method.
would something like this be remotely possible in mlvapp ?


Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: kidfob on April 17, 2021, 12:33:21 AM
How about an option to disable preview and use multiple threads if a user's session is full of dual iso clips. Could that be a strong case for allowing a clip to be processed per core/thread?

Thanks for taking the time to answer all these questions. I'm really enjoying these new features!

It's like I have a new camera. Like a Red that fits in your palm.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on April 17, 2021, 04:32:17 AM
As I said. Dualso i mlv app is too unreliable. There's reliable code in cr2hdr which could be used but until that is implemented solution really is to remove dualiso completely from mlv app.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: kidfob on April 21, 2021, 10:41:09 PM
I thought of something:
What if MLV App could be used via command line similarly to cr2hdr?

It'd be great to spawn multiple sessions this way, passing in arguments such as file name, certain settings (dual iso, export settings, destination), and whether or not the processing should start immediately and close the app when complete, etc.

One could loop through all the MLVs in a folder, processing them with multiple instances of the App. Maybe one instance per CPU core or logical processor.

Would this be doable?

Thoughts?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 21, 2021, 10:57:22 PM
Feel free to implement. You can start from scratch, because not much could be used from what we have now.

Quote from: kidfob on April 21, 2021, 10:41:09 PM
One could loop through all the MLVs in a folder, processing them with multiple instances of the App. Maybe one instance per CPU core or logical processor.
MLVApp and ffmpeg are optimized in processing with ideal thread count for maximum performance. So why should we do this?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: kidfob on April 22, 2021, 08:10:02 PM
I'd do this since Dual ISO is a bottleneck and I currently have to manually open a new instance of MLVApp per each MLV. It'd be nice to be able to automate this via batch processes. Command line functionality could facilitate that.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 22, 2021, 08:19:50 PM
As Danne already told, DualISO in MLVApp is very unreliable and shouldn't be used as is. Use cr2hdr version instead - it is commandline based already.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 23, 2021, 10:31:52 AM
Markus is there some non complex way for me to change in the sourcecode when lut is applied in mlvapp pipeline ? I want it to be absolute last thing applied to footage.
I want it to be after chroma smoothing, after stabilisation and after adding toning, white balance change etc.
Most luts react differently when i give the footage blue tint and i use "toning" panel to do that but its affecting currently afterlut footage not pre-lut.
Or am i wrong and it is at the end ?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 23, 2021, 11:06:58 AM
Current order of these steps is: chroma smooth --> whitebalance --> toning --> lut --> stabilization (by ffmpeg on export).
(If you're interested, see raw_processing.c, apply_processing_object(...). This is the processing after RAW Corrections, debayering and whitebalance.)
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 23, 2021, 12:12:46 PM
thanks! This is responsible for grain size ?
double weight = sumL / 1.5 / 65535.0;
I see that in 1080 or 2800 pixels fooage grain size is different, relative to resolution, so id like to change the size for 2.8k
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 23, 2021, 12:51:04 PM
Grain size is always 1x1 pixel. Currently there is no way to adjust it.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 23, 2021, 05:17:59 PM
I find it very useful that you opened transfer function for processing and i could create more looks more freely using luts that just werent working with previous locked algorithms.
Is saturation algorithm able to be opened like that ?
What i really want to do is to make it behave identical to HUE vs saturation or luminance vs saturation algos because their algorithms are much cleaner, i find saturation slider below vibrance to be very noisy when moving up, introducing a lot of artifacts while adding saturation especially in reds, while hue vs saturation have almost none even when maxed out.
Or can i somehow swap algorithms in the sourcecode ?
Sometimes i cant use luma vs sat or hue vs sat because theyre already taken and used to correct for something else.
here are maxed out Hue vs sat, saturation slider (one below vibrance), original image.
saturation slider artifacts appear very soon when i bump it up.
(https://i114.fastpic.ru/big/2021/0423/cf/3782552983706cf04a984db701f25ccf.jpg)
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 23, 2021, 06:18:07 PM
Saturation is more than a single equation, so this can't be changed in the same way like profile. But tweaking the code is easy. Look at raw_processing.c line 1005.

if( processing->saturation > 1.01 || processing->saturation < 0.99 )
{
...
}

I also don't like the saturation slider. That's why I implemented the vibrance, which looks more natural.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on April 24, 2021, 02:51:02 PM
hi there..
I have tried this app and it does an amazingly good job, thanks to @ilia3101.

(https://i.ibb.co/ZhWN5Xq/image-2021-04-24-195222.png)

btw, Is MLVApp using CUDA?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 24, 2021, 03:02:31 PM
Quote from: ML700D on April 24, 2021, 02:51:02 PM
btw, Is MLVApp using CUDA?
No, just the CPU.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on April 24, 2021, 05:32:52 PM
Quote from: masc on April 24, 2021, 03:02:31 PM
No, just the CPU.

oh ok. thanks.  :D
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on April 25, 2021, 12:07:34 PM
Hi again,

I have a problem when using MLVApp with dual iso, if zoomed in the image look like this:
(https://i.ibb.co/NrqCZfy/image-2021-04-25-170443.png)

how to fix this? thanks.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on April 25, 2021, 01:00:20 PM
Reading and applying what was written in #4652?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: kidfob on April 26, 2021, 01:09:06 AM
Is there a way to set vertical stipes to Off by default?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: kidfob on April 26, 2021, 02:00:55 AM
Also noticed a potential bug in cr2hdr. Details here:
https://www.magiclantern.fm/forum/index.php?topic=26056.msg235329#msg235329
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on April 26, 2021, 04:16:01 AM
Quote from: Walter Schulz on April 25, 2021, 01:00:20 PM
Reading and applying what was written in #4652?

yes, but how? I'm noob here..  :D
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on April 26, 2021, 05:14:29 AM
https://www.magiclantern.fm/forum/index.php?topic=7139.0
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on April 26, 2021, 08:39:12 AM
ok. thanks.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 26, 2021, 11:21:05 AM
Quote from: kidfob on April 26, 2021, 01:09:06 AM
Is there a way to set vertical stipes to Off by default?
Yes: create your own default receipt and activate it via menu (Use Default Receipt).
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on April 26, 2021, 11:55:37 AM
hi there..

sometimes dual ISO work nice with MLVApp I don't know why..
(https://i.ibb.co/Zxpw5hv/Screenshot-2021-04-26-164052.png)

I think it's depend on the focus object itself, maybe it shouldn't be too bright or too dark. IMO
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 26, 2021, 12:08:45 PM
https://www.magiclantern.fm/forum/index.php?topic=20025.msg235208#msg235208
https://www.magiclantern.fm/forum/index.php?topic=20025.msg235214#msg235214
https://www.magiclantern.fm/forum/index.php?topic=20025.msg235249#msg235249
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on April 26, 2021, 12:39:15 PM
Quote from: masc on April 26, 2021, 12:08:45 PM
https://www.magiclantern.fm/forum/index.php?topic=20025.msg235208#msg235208
https://www.magiclantern.fm/forum/index.php?topic=20025.msg235214#msg235214
https://www.magiclantern.fm/forum/index.php?topic=20025.msg235249#msg235249

I see.. thanks.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on April 26, 2021, 05:55:32 PM
in this video, I tried to shoot some footages with Dual ISO 100/800 in close up and in MLV APP I used preset Alexa Log-c and left the other as default setting.
I think the result is pretty good, although there is a bit noticeable green pink noise when edited, maybe it can be eliminate by chroma smooth, perhaps?  :D



I understand what was talked here, but I think MLV App still can produce something good with dual ISO..

just sharing my opinion.. thanks!  ;D
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on April 27, 2021, 09:34:57 AM
my second test using crop mode UHD anamorphic 1x3 and Dual ISO 100/1600
in MLV App I set the chroma smooth and it looks better, I think.  :D
well, so far so good without or maybe unseen by me that naughty colors.  :D :D
I appreciate and thank ilia3101's work.


Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: avaneev on May 01, 2021, 08:41:04 PM
Hi! Have the MLV App authors tried to apply non-linear "saturation" image transformations in a higher resolution, with a later downsizing step? This is not a common technique, but from the DSP standpoint it should look much better. "Aliasing" is not the whole story like in image resizing, there's also "harmonic distortion", which is not as apparent with images as it is with audio. Maybe worth a try.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: avaneev on May 01, 2021, 08:46:49 PM
A follow-up: the same actually applies to "linearization" or sRGB->linear conversion. It's a non-conventional approach and is resource-heavy, but probably it will fix the feel of all these gamma corrections being "not right".
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on May 06, 2021, 02:39:49 PM
It is possible to use sinus in transfer function and create non linear curve but whats the exact formula for non linear film gamma ?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 06, 2021, 08:01:31 PM
Let's welcome @avaneev here in ML forum - the author of AVIR resizing algorithm. Nice to have you here and thank you again for your great work!

We already discussed the same questions a little bit here: https://github.com/avaneev/avir/issues/8#issuecomment-830816642
@Ilia: would be cool if you could join the discussion - you know best about the processing engine

@2blackbar: yes, all math functions are "poosible" but might look strange. For different profile functions you'll find the gamma variable at very different places.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on May 30, 2021, 02:03:32 PM
where in the source i can change quality of jpeg images exports to be higher? i can see some jpg2k code but cant find quality values
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 30, 2021, 05:09:00 PM
Quote from: 2blackbar on May 30, 2021, 02:03:32 PM
where in the source i can change quality of jpeg images exports to be higher? i can see some jpg2k code but cant find quality values

Single frame export:
Search for this line:
QImage( ( unsigned char *) imgBufferScaled8, getMlvWidth(m_pMlvObject) * stretchX, getMlvHeight(m_pMlvObject) * stretchY, QImage::Format_RGB888 ).save( fileName, "jpg", -1 );
The "-1" is the quality parameter, set to "default". This is the Qt library export function for jpg.

Video export:
For JPG2000 export we don't use any quality parameter, so we use ffmpeg default, too. If there is any quality parameter possible, you should find that in the ffmpeg documentation. https://ffmpeg.org/ffmpeg-codecs.html#jpeg2000
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on June 03, 2021, 04:34:58 PM
small "bug", if you mute/unmute during playback is on there's no effect. Not a big deal, more of an excuse to come say hi :)
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 03, 2021, 09:11:15 PM
Hi!  :)
Thanks for the feedback. Yes, I know about that issue and I also know why it is there... it exists because we just can sync audio to video when hitting the play button. So when enabling audio while playback, this function can't work. Maybe one day we have a better idea how to realize this...
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on June 05, 2021, 12:35:03 AM
Got it, fair enough.
The only thing really missing from the app for me is the fast playback that MlRawViewer has/had.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 05, 2021, 10:53:41 AM
Quote from: togg on June 05, 2021, 12:35:03 AM
The only thing really missing from the app for me is the fast playback that MlRawViewer has/had.
Even on a 10 years old quadcore CPU you can have "close-to-realtime" playback in MLVApp when using default settings. For 1080p I get 22fps on my iMac2011. The more fancy features you use, the slower the processing will be.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on June 13, 2021, 04:19:56 PM
Quote from: masc on June 05, 2021, 10:53:41 AM
Even on a 10 years old quadcore CPU you can have "close-to-realtime" playback in MLVApp when using default settings. For 1080p I get 22fps on my iMac2011. The more fancy features you use, the slower the processing will be.

Wait, how? I get 5fps if open in normal resolution, 10fps in low resolution. Everything disabled. My cpu is an i7 9th gen 2.6 ghz.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 13, 2021, 05:16:18 PM
Quote from: togg on June 13, 2021, 04:19:56 PM
Wait, how? I get 5fps if open in normal resolution, 10fps in low resolution. Everything disabled. My cpu is an i7 9th gen 2.6 ghz.
Open the clip with default settings and hit play. For fastest speed, use alexa preset, which disables a part of the processing. Are you on macOS or Linux? On Windows it will be a bit slower, because the OS is very hungry. (i7 Quadcore Desktop CPU on Windows will get a similar speed like a i5 DualCore Mobile CPU on macOS)
10fps on a i7? I get this on a Core2Duo for 1856x1044, 14bit.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: reddeercity on June 14, 2021, 04:19:45 AM
Just got my i7 10th Gen (10700K 16threads) up and running on Win10pro fresh load on the 21H1 update on a 1TB WD Black SN750 (MVMe SSD)
So I put the 2 file on my desktop (so the file where on my MVMe SSD) and run a quick test with the new MLV App 1.12 x64 , with default setting .
loaded up 2 files (crop_rec) 10 bit uncompressed 2600x1200 23.976fps no audio
and (3x3) 12bit uncompressed 1856x1044 23.976fps with audio 44.1KHz.
The crop_rec 2.6k playback run at 21-22 fps , the 3x3 payback with audio was real time , so 23.976 fps playback .
Being this CPU can be overclock , I left it at default clock speed (3.8 GHz) so I should get real time at 4k 10bit uncompressed when I overclock it .



Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on June 20, 2021, 02:32:43 AM
Maybe I get it, my files are compressed 14bit.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 20, 2021, 09:06:02 AM
Indeed, uncompressing lossless files is one of the MLVApp tasks to be done and that needs some time.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: EdwardLatour on June 26, 2021, 01:44:37 PM
Hi @masc, maybe this is useful information.

Nvidia has recently released their nvJPEG2000 framework/API for GPU-accelerated decoding of JPEG 2000 image compression


https://developer.nvidia.com/blog/accelerating-jpeg-2000-decoding-for-digital-pathology-and-satellite-images-using-the-nvjpeg2000-library/ (https://developer.nvidia.com/blog/accelerating-jpeg-2000-decoding-for-digital-pathology-and-satellite-images-using-the-nvjpeg2000-library/)

https://developer.nvidia.com/nvjpeg (https://developer.nvidia.com/nvjpeg)
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 28, 2021, 02:12:58 PM
MLVApp v1.13 is out:
- Debayer udpate for IGV and LMMSE from [librtprocess](https://github.com/CarVac/librtprocess)
- Added debayer RCD and DCB from [librtprocess](https://github.com/CarVac/librtprocess)
- Update to [AVIR](https://github.com/avaneev/avir) 2.9
- H.265 export playable on Apple devices
- Update for faster recursive bilinear filtering (Clarity, Shadows, Highlights, RBF Denoiser)
- Fix for SSL handshake problem on focus pixel map auto install
- DNxHR export with variable resolution
https://mlv.app
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: CommanderLake on July 07, 2021, 10:26:57 PM
Has anyone got this to build as a Visual Studio project?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 08, 2021, 08:01:44 AM
Quote from: CommanderLake on July 07, 2021, 10:26:57 PM
Has anyone got this to build as a Visual Studio project?
I had no luck to compile in Visiual Studio. The Microsoft compiler doesn't like some standard C++ libraries and can't compile so far. No such problems with MinGW on Windows. So better use this. If you get the project compiled in VS, feel free to add a pull request.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on July 08, 2021, 01:19:10 PM
Masc,

You did a great job with this v. 1.13! Thanks a lot!

I did not have time for a thorough test but it seems to be more stable than v. 1.12 and I generally like the results better.  It seems to handle better blown out highlights and high-contrast scenes.  It also seems to be faster in rendering clips with complex adjustments.  The automatic FPM update is fantastic too.  And finally, the eye dropper tool for skin tone correction on a single click is the best I have ever seen!

I do have a question.  Which "Profile preset" and "Processing gamuth" settings would you recommend for landscape high-resolution videography which may also include high-contrast scenes requiring complex adjustments to retain maximum image quality?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ChristianEOS on July 08, 2021, 03:37:18 PM
I would also like to say thank you. I would say the versions before worked for me also stable. I didn't test highlight fix. But already thank you very much.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 08, 2021, 07:13:43 PM
@IDA_ML:
Thank you. Good to hear it works fine.
I mostly use the preset "Film", or "Tonemapped" for very high contrast scenes (default). On top of that, adjust Dark Strength/Range and Light Strength/Range. With that you should get the maximum contrast and image information from RAW to something processed.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on July 09, 2021, 01:41:02 PM
Thank you again, Masc, for this useful information.  MLVApp keeps getting better and better and adds substantial value to our old ML-capable Canon cameras.  Just keep going!
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on July 09, 2021, 05:02:40 PM
+1 to the fact that the default values are perfect. It's one of the strenghts of the app. Here a video where I used the ProRes straight from the app (a few h264 shots are in) https://vimeo.com/519886116
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: wib on July 10, 2021, 03:00:51 AM
super reportage ! les gars sont passionnés !

so what was your set up ?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on July 10, 2021, 08:58:24 PM
Masc,

Is there going to be a 32 bit version of v.1.13?  I have an older PC that only works with the 32 bit version of 1.12.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ChristianEOS on July 11, 2021, 10:51:28 AM
MLV App also works for Linux.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 11, 2021, 11:06:43 AM
@IDA_ML: I don't have the 32bit toolchain anymore, so I can't build a 32bit version now.
@bouncyball: Do you still have a 32bit Windows Qt toolchain?
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on July 12, 2021, 01:19:37 AM
Quote from: wib on July 10, 2021, 03:00:51 AM
super reportage ! les gars sont passionnés !

so what was your set up ?

Merci!
I'm going with a simple smallrig cage, smallhd monitor, some CF cards from komputerbay and a big one from lexar. In the evening I copy the MLV files and backup. The day after I do some simple corrections in MLV App, export the ProRes 422 and then edit in FCPX.
(various lenses used, I have canon, tamron, vintage tokina with promist, vintage nikkor and then some)
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on July 14, 2021, 06:37:19 PM
Quote from: masc on July 11, 2021, 11:06:43 AM
@bouncyball: Do you still have a 32bit Windows Qt toolchain?
I don't. Btw, with higher QT versions application is 2x size :o.

I'll see what can I do.
Title: Re: MLV App 1.12 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 14, 2021, 09:08:48 PM
Quote from: bouncyball on July 14, 2021, 06:37:19 PM
I don't. Btw, with higher QT versions application is 2x size :o.

I'll see what can I do.
Take care... some of the newer QT version also have silly bugs, where e.g. the menu is completely wrong (if I remember right in 5.10 and 5.11). Older are very okay and smaller...
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on July 15, 2021, 07:24:16 PM
Win32 version uploaded.

After v1.13 we officially stop releasing win32 build. It can be compiled manually though.

regards
bb
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on July 26, 2021, 04:47:21 PM
wow.. nice
thank's for the update
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on August 01, 2021, 07:26:35 PM
Thank you so much, Bouncyball!

It's a pitty that the 32-bit version will no longer be available on future builds.  One of the major advantages of MLVApp is the fact that it can run on any computer including older models.  Many of them, including quite powerful Quad core ones will no longer work with MLVApp if there is no 32-bit version.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 01, 2021, 07:45:05 PM
Quote from: IDA_ML on August 01, 2021, 07:26:35 PM
It's a pitty that the 32-bit version will no longer be available on future builds.  One of the major advantages of MLVApp is the fact that it can run on any computer including older models.  Many of them, including quite powerful Quad core ones will no longer work with MLVApp if there is no 32-bit version.
->
Quote from: bouncyball on July 15, 2021, 07:24:16 PM
It can be compiled manually though.
As bouncyball told: you can compile it at any time yourself. The support is there... but having the 2GB+ toolchain installed 4x and doing all the release stuff 4x... no real fun. If you install an old Qt (e.g. 5.6) with mingw32, you can compile the latest commits at any time, and you don't have to wait for the releases. Same for macOS <=10.5 32bit and Linux 32bit.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on August 01, 2021, 08:45:49 PM
Quote from: masc on August 01, 2021, 07:45:05 PM
->As bouncyball told: you can compile it at any time yourself. The support is there... but having the 2GB+ toolchain installed 4x and doing all the release stuff 4x... no real fun. If you install an old Qt (e.g. 5.6) with mingw32, you can compile the latest commits at any time, and you don't have to wait for the releases. Same for macOS <=10.5 32bit and Linux 32bit.

Unfortunately, I am sorry to say that but I do not have any compiling skills whatsoever.  I don't understand what you are saying either.  If you are saying that this is quite a complicated process then there is no chance that people like me will be able to do it.  Anyway, that's not so important, we are not that many - 64 (32-bit) vs. 1613 (64-bit) users at the time of this writing.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 01, 2021, 08:58:54 PM
Quote from: IDA_ML on August 01, 2021, 08:45:49 PM
Unfortunately, I am sorry to say that but I do not have any compiling skills whatsoever.  I don't understand what you are saying either.  If you are saying that this is quite a complicated process then there is no chance that people like me will be able to do it.  Anyway, that's not so important, we are not that many - 64 (32-bit) vs. 1613 (64-bit) users at the time of this writing.
Really... no skills needed to compile. All you need is some diskspace and time. If you are able to start a PC, you'll be able to compile a ready application. Download and install a tool, download the archive, load a file, press a compile button. And you'll get the exe which runs on your computer. This video shows the already more difficult Debug compile for MLVApp (with multiple compilers installed, so configuration window can be ignored): https://www.youtube.com/watch?v=pmngCFQzFdo

While installing Qt you'll get this screen: choose mingw32 instead of mingw64.
(https://i.ibb.co/Df8D3T0/Qt.png)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on August 02, 2021, 12:33:17 AM
Thank you, Masc, I will have to give it a try.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on August 02, 2021, 12:37:49 AM
Hello. I noticed a strange distortion in the received video after exporting in the format h265 12 bit.
(https://i.ibb.co/dbtBmk3/M22-1526-mov-snapshot-00-03-462.jpg) (https://ibb.co/1sMZzRp)

(For visual purposes, see the video)
I haven't read the details of the latest program updates, and I may be making mistakes somewhere.
Attach the original video, preset the renderer settings and properties:

or
https://mega.nz/file/JrYhXYCY#A6dC9EwDqOVlpdnuWH19yR1uk0xLd9f5T_NLOHhfmME (https://mega.nz/file/JrYhXYCY#A6dC9EwDqOVlpdnuWH19yR1uk0xLd9f5T_NLOHhfmME)
Export:
(https://i.ibb.co/FBwtdqK/Screenshot-291.png) (https://imgbb.com/)

Settings:
https://mega.nz/file/wjZjSYQY#9ohzOys-1IsBLOhWXXX5dGlwAMqkaHkDEi87tWn7TBY (https://mega.nz/file/wjZjSYQY#9ohzOys-1IsBLOhWXXX5dGlwAMqkaHkDEi87tWn7TBY)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 02, 2021, 01:53:25 PM
@Icaab: What kind of distortion do you mean? Could you please give a hint? I just see some shaking, probably because you hit the record button.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on August 02, 2021, 02:12:25 PM
The box is moving. Wouldn't call it distortion, though.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on August 02, 2021, 02:41:02 PM
Quote from: masc on August 02, 2021, 01:53:25 PM
@Icaab: What kind of distortion do you mean? Could you please give a hint? I just see some shaking, probably because you hit the record button.
Yes, the box must move XD
On the corners of the video there are distortions in colors, and on the image of the camera(on the box) and the box there are large pixels.
(You can download the video to your computer using the mega link. This will show you better)
Before that, with minimal processing of the original video - this was not the case, and after adding sharpness and small changes (and rendering in full resolution that was received on the cameras, that is, in 4.3k) - discovered such oddities.

New
(https://i.ibb.co/nmqrzqY/Screenshot-306.png) (https://ibb.co/tKwB8wv)

Old
(https://i.ibb.co/D5GTSjh/Screenshot-305.png) (https://ibb.co/xJmdRrW)

I also attached processing parameters (.marxml). Can you look?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 02, 2021, 06:58:13 PM
You mean the bright pixels in the edges? Must have to do something with your MLV (which you did not upload?!), because with your receipt I can't reproduce on any of my clips.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on August 02, 2021, 09:09:41 PM
Quote from: masc on August 02, 2021, 06:58:13 PM
You mean the bright pixels in the edges? Must have to do something with your MLV (which you did not upload?!), because with your receipt I can't reproduce on any of my clips.

The original video mlv weighs a lot. I kept his piece in the same format, without applying any corrections:
https://mega.nz/file/Nu4W2DLL#KZoHbwou-b0tCYxNQuQ3snLQyCD2oXyyT8kTQQoJLaY (https://mega.nz/file/Nu4W2DLL#KZoHbwou-b0tCYxNQuQ3snLQyCD2oXyyT8kTQQoJLaY)
Strange: I can open .marxml settings through the import receipt . Then let me attach this screen:
(https://i.ibb.co/MCtK013/Screenshot-311.png) (https://ibb.co/jrQqXw1)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 02, 2021, 10:40:55 PM
No problem with the receipt, I can load it, but here all looks clean. Thanks for the MLV. Here I get this with the MLV and your receipt:
(https://i.ibb.co/0ZPHdwB/M22-1526-1-frame-1.jpg)
Is it the same you get? Do you find your "distortion" here too?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on August 03, 2021, 12:35:00 AM
Quote from: masc on August 02, 2021, 10:40:55 PM
No problem with the receipt, I can load it, but here all looks clean. Thanks for the MLV. Here I get this with the MLV and your receipt:
(https://i.ibb.co/0ZPHdwB/M22-1526-1-frame-1.jpg)
Is it the same you get? Do you find your "distortion" here too?
I can't say for sure right now, because you can see it better on video. However, in the photo only I see a red stripe at the bottom, which somehow appears at the bottom of the frame if the white surface, and comparing it to a previously attached photograph of the last renderer - problems have disappeared that have troubled me.
I don't know where I could be wrong. I didn't see that distortion in the playback.
Did you apply the same corrections I applied?
Can you send your receipt too?
What kind of debayer do you use to view the video?
Export settings are the same as mine?
(I used then h265 12bit,but now think it is better to use prores to speed up the renderer)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 03, 2021, 11:39:36 AM
Quote from: Icaab on August 03, 2021, 12:35:00 AM
I can't say for sure right now, because you can see it better on video. However, in the photo only I see a red stripe at the bottom, which somehow appears at the bottom of the frame if the white surface, and comparing it to a previously attached photograph of the last renderer - problems have disappeared that have troubled me.
I don't know where I could be wrong. I didn't see that distortion in the playback.
Did you apply the same corrections I applied?
Can you send your receipt too?
What kind of debayer do you use to view the video?
Export settings are the same as mine?
(I used then h265 12bit,but now think it is better to use prores to speed up the renderer)
The red stripe: comes from the camera preset. E.g. you can crop it in post.
I used your receipt with all your settings, nothing else.
I exported a single frame as JPG. The processing engine (for processed output of all codecs) is always the same.
I still see no problem and/or understand the problem.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on August 03, 2021, 12:28:49 PM
Quote from: masc on August 03, 2021, 11:39:36 AM
The red stripe: comes from the camera preset. E.g. you can crop it in post.
I used your receipt with all your settings, nothing else.
I exported a single frame as JPG. The processing engine (for processed output of all codecs) is always the same.
I still see no problem and/or understand the problem.
I understand. Thank you for your help. Perhaps the codec is a problem when exporting. I'll try others.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on August 04, 2021, 11:16:25 AM
Sometimes with ffmpeg h264/h265 codecs you can see top or bottom border line distortions, like blurred line, ribbon of pixels with changing color, etc. I guess it is related to vertical resolution not multiple of 8/16/32 etc. It's due to ffmpeg codecs and not the source image coming from mlvapp.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 04, 2021, 05:45:25 PM
I'm pretty sure height needs a simple pixel adjustment applied to the preset used to fix border pixelation in this case :).
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on August 08, 2021, 01:23:03 AM
Small bug: MLVApp is crashing while using "HDR blending" option when "Export audio" is ON, this crash affects 1.12 and 1.13 versions, 1.11 version works fine . . disabling audio export solves the crash issue in the affected versions of MLVApp.

Tested on Windows, Apple ProRes 422 HQ codec, both MLVApp 64-bit and 32-bit are affected.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 10, 2021, 01:02:11 PM
Thanks for reporting. Do you have a small MLV for reproducing that? No idea what's the difference between 1.11 and 1.12 - nothing changed for HDR blending. Just ffmpeg itself changed, but it always exports without audio anyway. Audio is added after video export. You could try 1.12/1.13 with the old ffmpeg.exe. (The latest codecs can't work this way.)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 10, 2021, 01:22:39 PM
Maybe something easy like spacing in the mlv file causing the issue? Anyway. More info needed.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on August 18, 2021, 09:02:55 AM
Hello. I came across a bug: No file appears when you export in any format. Export successfully ( Inscription - Export is ready), but I can't find the output file (latest version mlvapp).
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on August 18, 2021, 09:07:20 AM
http://www.catb.org/~esr/faqs/smart-questions.html#beprecise
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 18, 2021, 09:35:58 AM
Quote from: Icaab on August 18, 2021, 09:02:55 AM
Hello. I came across a bug: No file appears when you export in any format. Export successfully ( Inscription - Export is ready), but I can't find the output file (latest version mlvapp).
My bet: you deleted ffmpeg from MLVApp path. Otherwise more information needed.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on August 18, 2021, 10:37:06 AM
or... if on windows, you closed the terminal window before exporting finished.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on August 18, 2021, 12:45:17 PM
Quote from: masc on August 18, 2021, 09:35:58 AM
My bet: you deleted ffmpeg from MLVApp path. Otherwise more information needed.
I did not close anything at the time of export and ffmpeg is present.
(https://i.ibb.co/zfGMtQ4/Screenshot-372.png) (https://imgbb.com/)
Took again mlvapp v13 and replaced the following files: ffmpeg , libraw.dll , MLVApp , pixel_maps , raw2mlv .
To no avail.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on August 18, 2021, 06:04:54 PM
I suggest to download MLVApp 1.13 again, extract it in new empty folder, import your MLV clips and try exporting, does it work (do you have your exported clips)?

If not, what's your export settings? do you have a CMD running while exporting?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on August 19, 2021, 05:44:59 PM
Quote from: theBilalFakhouri on August 18, 2021, 06:04:54 PM
I suggest to download MLVApp 1.13 again, extract it in new empty folder, import your MLV clips and try exporting, does it work (do you have your exported clips)?

If not, what's your export settings? do you have a CMD running while exporting?
I apologize: it turns out in my path the folder with the program contained a cyrillic. After the renaming everything worked as if nothing had happened.
Thank you :)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on September 06, 2021, 03:02:51 PM
Hi,

I'm trying my first hand at Dual ISO MLV, and apparently the few short clips I took are not rendered correctly in MLV App.

I experience this weird behavior:
I'm shooting with Danne's latest build for 5DM3, using the 3.3K 1:1 x5 preset (@14 bit).

First question: is this a common behavior / bug / (most likely) common mistake on my side? Or am I alone in this?

Thanks a lot for the help.

Sergio
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 06, 2021, 04:28:54 PM
@vastunghia

Turn OFF "Vertical Stripes" from "RAW Correction" tab and you should be fine, I noticed the same problem here, "Vertical Stripes" doesn't work properly in Dual ISO clips and it's ON by default for 5D3 clips.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on September 06, 2021, 04:57:08 PM
Thank you @theBilalFakhouri you made my day, I would never sort it out by myself!

S
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Merlin ミーアキャット on September 07, 2021, 08:32:26 AM
Does that mean vertical stripes should be turned off? I thought in lower ISO situations it is better on?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on September 07, 2021, 02:35:32 PM
Does MLV App work natively with new Silicon M1 or with Rosetta 2?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 17, 2021, 07:38:23 PM
Quote from: Dmytro_ua on September 07, 2021, 02:35:32 PM
Does MLV App work natively with new Silicon M1 or with Rosetta 2?
Works with Rosetta2... but as I tested, very fast.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 17, 2021, 08:14:55 PM
Quote from: Merlin ミーアキャット on September 07, 2021, 08:32:26 AM
Does that mean vertical stripes should be turned off? I thought in lower ISO situations it is better on?

You should turn it off just when using Dual ISO otherwise Dual ISO clips won't be processed correctly, using vertical stripes in normal clips is fine.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: elenhil on September 21, 2021, 10:10:20 PM
Any ideas why trying to enable vid.stab invariably produces a 0-sized file? I do try to exit is as a H.264 ffmpeg, as per instructions.

P.S. I mistyped '265' the first time.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 21, 2021, 10:18:26 PM
Quote from: elenhil on September 21, 2021, 10:10:20 PM
Any ideas why trying to enable vid.stab invariably produces a 0-sized file? I do try to exit is as a H.265 ffmpeg, as per instructions.
The instructions and the vid.stab-enable-checkbox tell, vid.stab only works for H.264. So when choosing anything else you should get a non stibilized video, but never a 0-size file.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: dragonsfire1981 on September 22, 2021, 01:06:22 AM
I'm having this exact same problem with no files whatsoever appearing in my folders after exporting from MLV App to H264.

And before you ask, I have no folder in cyrillic or any other funny letters or symbols, and all the original installation files are present and correct in the MLV app folder, it just won't save the exported files at all. What's going on?

EDIT: I solved it after I figured out Avast antivirus was blocking the applications. I added exceptions to the MLV folder and all MLV .exe files. Woohoo!

Quote from: masc on August 18, 2021, 09:35:58 AM
My bet: you deleted ffmpeg from MLVApp path. Otherwise more information needed.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: elenhil on September 22, 2021, 09:32:20 AM
Quote from: masc on September 21, 2021, 10:18:26 PM
The instructions and the vid.stab-enable-checkbox tell, vid.stab only works for H.264. So when choosing anything else you should get a non stibilized video, but never a 0-size file.
Oops, a typo. I meant H.264, or course!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: elenhil on September 22, 2021, 09:41:10 AM
Quote from: dragonsfire1981 on September 22, 2021, 01:06:22 AM
I'm having this exact same problem with no files whatsoever appearing in my folders after exporting from MLV App to H264.

And before you ask, I have no folder in cyrillic or any other funny letters or symbols, and all the original installation files are present and correct in the MLV app folder, it just won't save the exported files at all. What's going on?

EDIT: I solved it after I figured out Avast antivirus was blocking the applications. I added exceptions to the MLV folder and all MLV .exe files. Woohoo!
My problem was 0-size files, not no files whatsoever (which I did use to get with cyrillic paths), so it's not the same problem. Plus, I disabled my AV and the problem didn't go away.

And, just so we're clear, regular encoding without enabling vid.stab works OK.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 22, 2021, 06:23:48 PM
@elenhil: More information needed. Can't reproduce here - all works as expected for me.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: elenhil on September 22, 2021, 06:32:49 PM
Quote from: masc on September 22, 2021, 06:23:48 PM
@elenhil: More information needed. Can't reproduce here - all works as expected for me.
OK, what do I do? Is there a debug option for a complete readout of all the info you need?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 22, 2021, 08:28:47 PM
Start describing your system (OS+version, app version,...), all your settings (cam+App(receipt and export)), maybe upload the MLV file.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: elenhil on September 23, 2021, 01:27:21 PM
Quote from: masc on September 22, 2021, 08:28:47 PM
Start describing your system (OS+version, app version,...), all your settings (cam+App(receipt and export)), maybe upload the MLV file.
- Windows 10 Pro v20H2
- MLV App v1.13
- Canon 70D running ML v1.12 (https://bitbucket.org/ArcziPL/downloads/downloads/magiclantern-Nightly.2021Apr04.70D112_crop_rec_4k_mlv_lite_lossless_fps_override_focus_stack_sduhs.zip)
- Zero receipt settings except ticking 'Enable FFmpeg vis.stab
- File export settings: H.264 (no mistake this time), ffmpeg MPEG-4 (*.mp4) Medium Quality, Debayer: Receipt configuration, Smooth aliasing Off, Export audio On, no other boxes ticked
- Source file at D:\RawVideo\, export to D:\, no special symbols whatsoever
- MLV App and ffmpeg.exe at C:\Program Files\MLV.App.v1.13.Win64.static\, likewise (anyways, exporting with vis.stab off works OK).

Source MLV file: https://disk.yandex.ru/d/LwpCY0i3jhLp0A
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 23, 2021, 06:34:17 PM
@elenhil: thank you. I tried exactly what you described. Result: I get the exported stabilized video file. Did you close the cmd window by accident? Or, do you forbid MLVApp to create files in the application folder? : ffmpeg creates a vector file when anaysing the footage and then uses this file to stabilize.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: elenhil on September 23, 2021, 06:43:51 PM
Quote from: masc on September 23, 2021, 06:34:17 PM
@elenhil: thank you. I tried exactly what you described. Result: I get the exported stabilized video file. Did you close the cmd window by accident? Or, do you forbid MLVApp to create files in the application folder? : ffmpeg creates a vector file when anaysing the footage and then uses this file to stabilize.
Brilliant! Access rights to app folder (more specifically, not running MLV App with admin privileges) was, indeed, the culprit! Thanks a ton!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 24, 2021, 08:12:36 PM
Have my new M1 for 48 hours now... result: MLVApp running natively on arm64! Speed is again a big jump from x86_64 on M1 via Rosetta. FullHD on 48fps runs in realtime! (with standard grading) ... I've never seen such framerate numbers in our tool...
Now we need a native ffmpeg... anyone has a static arm64 macos ffmpeg build?
(https://i.ibb.co/TYsLds0/Bildschirmfoto-2021-09-24-um-20-02-01.png)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 24, 2021, 11:30:55 PM
Cool!
Will this ffmpeg version work?
https://www.osxexperts.net/
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 25, 2021, 11:02:25 AM
Thank you Danne! Yeha... great! Works... and is indeed faster!

Now I just have big problems with Qt deployment: Just on my MacBook it runs really well (here and there some little crashes, but Qt5 on apple ARM64 is not officially supported), but when I try to include all needed libs into the app package, it stops working - MLVApp won't start anymore. :(

If someone else like to try what I did:
- install llvm@11 via brew as compiler (has Apple Silicon support)
- build Qt5 as described here: https://github.com/bobwolff68/fritzing-app/wiki/Building-Qt-5.15-for-Mac-M1#building-qt-515x-unreleasedopensource
- intall QtCreator via brew and setup llvm@11 as compiler and the self-build Qt5 as Qt engine
- modify .pro file with these lines:
mac{
    QMAKE_CC = /opt/homebrew/opt/llvm@11/bin/clang
    QMAKE_CXX = /opt/homebrew/opt/llvm@11/bin/clang++
    QMAKE_LINK = /opt/homebrew/opt/llvm@11/bin/clang++
    QMAKE_CFLAGS += -fopenmp -ftree-vectorize
    QMAKE_CXXFLAGS += -fopenmp -std=c++11 -ftree-vectorize
    INCLUDEPATH += -I/opt/homebrew/opt/llvm@11/include
    LIBS += -L/opt/homebrew/opt/llvm@11/lib -lomp
    QMAKE_APPLE_DEVICE_ARCHS = arm64
}

- compile and have fun

Edit: I tried some cheating, and now the package is running (at least on my machine). If someone would like to betatest:
https://www.dropbox.com/s/ej6ufca61ijeeyf/MLV.App.v1.13.macOS.arm64.zip?dl=0
If it doesn't work... no idea why. If it does work: same.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on September 26, 2021, 12:49:42 AM
Wow, so there is a chance for android port ? Id buy extra phones just for rendering
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 26, 2021, 08:38:08 AM
Android? Not more or less than before. This is about macOS on Apple Silicon. Android needs a very different UI.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on September 26, 2021, 05:17:02 PM
Quote from: masc on September 24, 2021, 08:12:36 PM
Have my new M1 for 48 hours now... FullHD on 48fps runs in realtime! (with standard grading) ... I've never seen such framerate numbers in our tool...

Wow! What model do you have?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 26, 2021, 07:10:50 PM
Quote from: Dmytro_ua on September 26, 2021, 05:17:02 PM
Wow! What model do you have?
I got the MBA 16GB, 8Core GPU, 1TB. Until now, I can absolutely recommend this machine. Speed is just wow - and battery life too.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 26, 2021, 08:01:12 PM
Nice. I want a 16 inch version so I am waiting for this beast to happen ;).
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on September 27, 2021, 01:34:15 PM
Quote from: masc on September 26, 2021, 07:10:50 PM
I got the MBA 16GB, 8Core GPU

Does 16GB is a must for video editing? Or 8Gb will do the job?
I was looking for the cheapest MBA M1
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 27, 2021, 04:33:33 PM
Quote from: Dmytro_ua on September 27, 2021, 01:34:15 PM
Does 16GB is a must for video editing? Or 8Gb will do the job?
I was looking for the cheapest MBA M1
It is no must. It absolutely depends on your needs. My thought was: a full RAM leads to swap files on SSD. Write cycles on SSD are limited. SSD is not removable. Broken SSD = broken Mac.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on September 28, 2021, 06:30:13 PM
@masc, Wow! Nice job man!!!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 30, 2021, 08:49:24 PM
@masc Amazing to see! Has anyone ever achieved such high MLV App performance on computers other than the M1?

I suspect the M1 might have a huge advantage for MLV App over anything else out there, due to GPU and CPU sharing the same, extremely fast, memory (MLV App is usually slowed down by CPU->GPU uploads I believe).
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 30, 2021, 09:03:09 PM
@Ilia: As long as MLVApp doesn't use the GPU, it can't be slowed down by CPU->GPU upload. Highest value I've seen before was ~23fps on a Intel quadcore processor.

I had the chance to test my Apple Silicon build on another new M1 computer: it was working there too. So have fun with the upload ... ;)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 30, 2021, 09:39:07 PM
Quote from: masc on September 30, 2021, 09:03:09 PM
@Ilia: As long as MLVApp doesn't use the GPU, it can't be slowed down by CPU->GPU upload.

It has to upload to the GPU to display the image though, I think that is quite slow (it was my main difficulty in the Cocoa GUI), I assume it must be happening in Qt behind the scenes?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 30, 2021, 09:49:11 PM
Ah okay... yes, probably...
For FHD on M1: Using Rosetta2+Intel-build, I get 20fps. Using arm64 build, I get up to 50fps.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on October 02, 2021, 04:57:52 PM
Quote from: ilia3101 on September 30, 2021, 09:39:07 PM
I assume it must be happening in Qt behind the scenes?
Seems so.

Quote from: masc on September 30, 2021, 09:49:11 PM
For FHD on M1: Using Rosetta2+Intel-build, I get 20fps. Using arm64 build, I get up to 50fps.
What a huge difference and this is for "lousy" MB Air M1? :P

Edit: I really need my Linux running on M1 ;)
Edit2: or maybe M2 or M3???
Edit3: there are rumors about Apple even dumping ARM in favor of open source RISC5 (none of licensing) in the future...
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: lil4ml on October 07, 2021, 01:51:29 PM
i see strange things in my old footage
after "fix focus dots on" interp.1 and all the other methods there still some dots left when i view the video in the viewer (MLV.App.v1.13.Win64.static)). results by method differ in some dots
the dots are mostly cyan, some red and some grey and a pattern can be kind of seen
"fix focus dots off" show red focus dots. back with "fix on" the strange mostly cyan dots are back again but are slightly off positioned to the red focus dots
you only see them on the edge of a object.
after export there are still present
export to cinenemaDNG lossless for ACR import

example
https://ibb.co/R2bYBXX (https://ibb.co/R2bYBXX)

am i doing something wrong?
newer noticed these dots before but after seeing them for the first time i notice them on lots of footage

chroma smooth 3x3 fix some of the dots but by far not all and leave some more greyish dots

shots are old and i think most or all were made with build crop_rec_4k.2018Jul22
footage Info
Camera: 650d
Lens: ef-s 18-135mm IS STM
Res.: 1600x900
bit: 11bits lossless

i can try and map these dots as "fix bad pixel" but this isnt that easy because they are everywhere but sadly not all present during one frame

can i somehow use a known pattern to quick solve this? or do i miss some function in mlvapp?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: lil4ml on October 07, 2021, 01:55:58 PM
just did a quick test on mlv.app.v1.11 and did not see the dots there
is something broken with v1.13?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on October 17, 2021, 11:03:17 PM
I know I said it before but I'm doing some export and I'm very happy about the look that MLV App gives as default, it's vibrant and balanced, for such old cameras it is a treat!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: whysodifficult on October 25, 2021, 03:31:54 AM
Hi!

Could someone please let me know:

1) How can i rotate mlv video in the app?
2) How to Undo
3) Is it okay that in Quick Time the video looks much more brighter than in the app when i edit it? In VLC it looks almost the same to the app.

MLVapp 1.13
MacOS 10.15.7
Quicktime Version 10.5 (1015.2.1)

Thank you!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 25, 2021, 09:02:52 AM
1) Transformation tab: Upside down = ON
2) Transformation tab: Upside down = OFF
3) Deactivate all effects in players and load system default monitor profiles in system preferences (and at all other places if you use special options). No such issues on 8 different macs with different OS' here.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: whysodifficult on October 27, 2021, 10:22:40 PM
masc,

Thank you for reply!

1) What i meant is rotating 90 degrees.
2) I meant undoing the actions like Cmmd+Z, but i found you replied here to someone that it cannot be implemented due to the way the current code is written.
3) I have just Quick Time and VLC players and no effects on, and i have default Color LCD profile in display settings.
Maybe it's because of difference in gammas that apps use. Quicktime uses brighter gamma (Apple's ColorSync) than MLVApp and VLC (which is not managed by ColorSync). People have this problem with Premier and Resolve as well, that use darker gammas than Apple. And there's no solution to this. But you say you don't have this problem. I will read more then. Thank you!
(Based on this info: https://dominey.blog/2021/01/24/why-are-videos-washed-out-on-the-mac-exploring-quicktime-gamma-shift/ )
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 28, 2021, 12:07:39 PM
1) You can do this with mostly every NLE. Atm MLVApp is not able to do this.
2) An undo for all actions is not implemented.
3) MLVApp writes the processed colors directly to the viewer frame. Here only the OS could change the resulting color via monitor profile. For other applications I can't tell for sure how it works. But here I got the same result for all applications on all macs around me. (Just know that Windows is more tricky here, where just Quicktime shows the correct color...)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on November 03, 2021, 01:34:53 PM
Im leaving settings for modifying mlvapp source here for myself but also for others whod like to change default stuff.
I did modificatioons cause default quality wasnt enought for me or was too high that resulted in very slow playback (h265 very high or very compressed quality, nothing inbetween)
I did that:

changed defaults in mainwindow.cpp:
        if( m_codecOption == CODEC_H265_H_MOV || m_codecOption == CODEC_H265_H_MP4 || m_codecOption == CODEC_H265_H_MKV )
            quality = 18;
        else
            quality = 20;

Second value is the medium setting ( high number - less quality and the lower numbers than defaults - the more data is put into compression) 20 is ok for me at this point in time for medium.
I really recommend to export in 265 10bit, it nicely retains a lot of colours from raw files.


Second thing i had to take care of was jpeg export for single frames, i put through mlvapp a lot of DNG files from camera and from my phone, so i needed much better compression so instead of default one , i changed it to 97 (100 is best ).

To do this i modified in singleframeexportdialog.cpp:

        QImage( ( unsigned char *) imgBufferScaled8, getMlvWidth(m_pMlvObject) * stretchX, getMlvHeight(m_pMlvObject) * stretchY, QImage::Format_RGB888 )
                .save( fileName, "jpg", 97 );


Thats about it, im leaving this here in case ill get back to new builds of mlvapp trying to apply these changes and i forget what i modified.
Also one thing i forgot but managed to remind myself today, i had already folder with all needed dlls and files for exe but i exported/compiled in x86 which failed to start with these dlls, i have to remember that its x64 build and change mingw to be x64 in qtcreator.

Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on November 07, 2021, 08:50:09 AM
I would like to report a bug which is not very important but quite annoying since you may loose your work if you have not saved it.  It occurs with the Windows x64 version 1.13 of MLVApp. 

When you click on a file which you would like to delete from your disk and select the "Delete from disk" option, MLVApp crashes.  I tested that on two different computers - one with Win 10 and another one with Win 7.

The "Remove" option works on both of them.  It removes the file from the session.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 07, 2021, 09:22:34 AM
Thanks for reporting. Did you try the latest commits on your own? There has been a fix, close to this topic. Would be nice to know if it is worse, better, or the same with it.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on November 08, 2021, 09:34:24 PM
Quote from: masc on November 07, 2021, 09:22:34 AM
Thanks for reporting. Did you try the latest commits on your own? There has been a fix, close to this topic. Would be nice to know if it is worse, better, or the same with it.

I am not sure what you mean by "latest commits".  Did you upload an updated version 1.13 linked in the 1-st post or you mean something else?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 08, 2021, 09:39:20 PM
Quote from: IDA_ML on November 08, 2021, 09:34:24 PM
I am not sure what you mean by "latest commits".  Did you upload an updated version 1.13 linked in the 1-st post or you mean something else?
https://github.com/ilia3101/MLV-App/commits/master
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: clubsoda on November 26, 2021, 10:14:42 PM
Thank you for adding the new debayer algorithms you are awesome! :)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on November 28, 2021, 06:57:50 PM
Hey masc , what should i add to encoding string to make x265 not use more than lets say 40Mb/s when encoding video ? i use this now but when the footage is noisy or theres lots of stuff in focus then i get about 90Mb/s and its slowing down playback , its nice for shots with blurred bgs but for deep focus it can bump up the bitrate depending on how noisy/detailed video is :
if( m_codecOption == CODEC_H265_H_MOV || m_codecOption == CODEC_H265_H_MP4 || m_codecOption == CODEC_H265_H_MKV )
            quality = 17;
        else
            quality = 19;

        program.append( QString( " -r %1 -y -f rawvideo -s %2 -pix_fmt rgb48 -i - -c:v libx265 -preset veryfast -tune fastdecode -crf %3 -tag:v hvc1 -pix_fmt %4 -color_primaries bt709 -color_trc bt709 -colorspace bt709 %5\"%6\"" )
                    .arg( fps )


This was default:
        if( m_codecOption == CODEC_H264_H_MOV || m_codecOption == CODEC_H264_H_MP4 || m_codecOption == CODEC_H264_H_MKV )
            quality = 14;
        else
            quality = 22;

        program.append( QString( " -r %1 -y -f rawvideo -s %2 -pix_fmt rgb48 -i - -c:v libx264 -preset medium -crf %3 -pix_fmt %4 -color_primaries bt709 -color_trc bt709 -colorspace bt709 %5\"%6\"" )
                    .arg( fps )

Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 28, 2021, 07:02:37 PM
Hi 2blackbar, not sure if you can set that. Did you read the ffmpeg documentation? You should find all possible options somewhere on there pages... I just know these "quality numbers", but as you wrote the bitrate could change in dependency to your footage.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 02, 2021, 09:18:38 AM
Tested on M1 pro 14 inch, 10 cores. Fast, very close or actual realtime previewing. Tested eos m clips. 2.8k 24fps, 1080p 48fps, 5k anamorphic.
Great app, great achievement @masc.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on December 05, 2021, 03:45:24 PM
Hello Masc and Danne,

I tried to film some Dual ISO video on my 5D3 using the latest April 1-st, 2021 experimental build by Danne but the file does not get processed properly in MLVApp.  The horizontal lines stay and I get very strange colors in the highlights and midtones.  Here is a sample shot at 12 bit lossless in 1392x2340 anamorphic resolution:

https://we.tl/t-hUeySxwwWO

I get the same results also in other modes.  It looks like the problem occurs with 5D3 Dual ISO files.  Such Dual ISO files from the EOS-M seem to process properly.  So do normal non Dual ISO files.

Could you please take a look?  Thanks.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 05, 2021, 04:04:04 PM
Dual iso know to not work corretly with mlvfs code, partially refined to "work" with 10bit and 12bit files. More recent code seems to fix issues but no one knows/have the time to update dualiso code in Mlv App. Dualiso code should be disabled/pauses in Mlv App.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on December 05, 2021, 04:49:06 PM
Quote from: IDA_ML on December 05, 2021, 03:45:24 PM
Could you please take a look?  Thanks.

Looks ok to me. Just make sure to set "Vertical Stripes" to "Off". Credit to theBilalFakhouri -- see below:

Quote from: theBilalFakhouri on September 06, 2021, 04:28:54 PM
Turn OFF "Vertical Stripes" from "RAW Correction" tab and you should be fine, I noticed the same problem here, "Vertical Stripes" doesn't work properly in Dual ISO clips and it's ON by default for 5D3 clips.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on December 05, 2021, 06:33:05 PM
Quote from: vastunghia on December 05, 2021, 04:49:06 PM
Looks ok to me. Just make sure to set "Vertical Stripes" to "Off". Credit to theBilalFakhouri -- see below:

Thank you so much, Vastunghia!  I was not aware of that.  It was an easy fix.  Dual ISO indeed provides a massive dynamc range improvement in 5D3 anamorphic footage and I am really glad, I got it working on my 5D3 footage again. 
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on December 06, 2021, 11:12:30 AM
Recent notes when compiling on Monterey(I think it´s 12.1).
Finally managed to compile Mlv App on my arm64 M1 pro, 10 core machine. Starting out with a lot of help from @masc and his post where he published this link about getting qt 5 working with arm64 M1.
https://github.com/bobwolff68/fritzing-app/wiki/Building-Qt-5.15-for-Mac-M1#building-qt-515x-unreleasedopensource

Compiling/configuring will eventually give an issue about missing header files. The fix is following:
https://github.com/Homebrew/homebrew-core/pull/88168#issuecomment-953466312
https://github.com/Homebrew/homebrew-core/pull/88168#issuecomment-953466312
inreplace "qtbase/src/plugins/platforms/cocoa/qiosurfacegraphicsbuffer.h",
              "#include <qpa/qplatformgraphicsbuffer.h>", "#include <CoreGraphics/CGColorSpace.h>\n#include


Commandline tools was a harder nut since it installs version 12.0 and upwards and not possible to go backwards. Luckily 11.3 is also included so a "monkey wrench" solution is possible by excluding 12.0 folder while compiling in the start and then attach 12.0 in the end of the compiling process. Not so nice to do this but relinking or changing files among versions is hard to nail. I noticed that usr/include folder and CoreServices, Frameworks folders are what we could replace with 11.3 versions if one wants to go down that route.

Finally fetching a missing lib and renaming it will fullfill dependencies but we also need to hack the code signing before the app can be opened with:
sudo codesign --force --deep --sign - ~/MLV-App-master/platform/Mlv_app_master/MLV\ App.app/Contents/MacOS/MLV\ App


In the compiler mainly this is happening when dependencies have been installed:
#temp workaround letting me compile Mlv App
sudo mv /Library/Developer/CommandLineTools/SDKs/MacOSX12.0.sdk /Library/Developer/CommandLineTools/SDKs/MacOSX12.0.sdktmp
sleep 5 && sudo mv /Library/Developer/CommandLineTools/SDKs/MacOSX12.0.sdktmp /Library/Developer/CommandLineTools/SDKs/MacOSX12.0.sdk &

~/qt5-5.15-macOS-release/qtbase/bin/qmake ~/MLV-App-master/platform/qt/MLVApp.pro \
QMAKE_CC=/opt/homebrew/opt/llvm@13/bin/clang \
QMAKE_CXX=/opt/homebrew/opt/llvm@13/bin/clang++ \
QMAKE_LINK=/opt/homebrew/opt/llvm@13/bin/clang++ \
QMAKE_CFLAGS+=-fopenmp \
QMAKE_CFLAGS+=-ftree-vectorize \
QMAKE_CXXFLAGS+=-fopenmp \
QMAKE_CXXFLAGS+=-std=c++11 \
QMAKE_CXXFLAGS+=-ftree-vectorize \
INCLUDEPATH+=-I/opt/homebrew/opt/llvm@13/include \
LIBS+=-L/opt/homebrew/opt/llvm@13/lib LIBS+=-lomp \
QMAKE_APPLE_DEVICE_ARCHS=arm64 \
sleep 2
/usr/bin/make -j 15 && ~/qt5-5.15-macOS-release/qtbase/bin/macdeployqt ~/MLV-App-master/platform/Mlv_app_master/MLV\ App.app && \
make clean

cp /opt/homebrew/Cellar/llvm/13.0.0_1/lib/libc++abi.1.0.dylib ~/MLV-App-master/platform/Mlv_app_master/MLV\ App.app/Contents/Frameworks/
mv ~/MLV-App-master/platform/Mlv_app_master/MLV\ App.app/Contents/Frameworks/libc++abi.1.0.dylib ~/MLV-App-master/platform/Mlv_app_master/MLV\ App.app/Contents/Frameworks/libc++abi.1.dylib
sleep 1
sudo codesign --force --deep --sign - ~/MLV-App-master/platform/Mlv_app_master/MLV\ App.app/Contents/MacOS/MLV\ App



Source code:
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/src/Monterey/

Downloadable compiler version:
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/mlv_app_compiler_Monterey.dmg

EDIT:
Note to self. xcode needed but command line tools as well and path absoluteluy needs to be set to:
sudo xcode-select -s /Library/Developer/CommandLineTools
https://stackoverflow.com/questions/9477860/xcode-select-switch-path-when-using-cli-toolkit
Title: MLV App’s Linear Profile
Post by: takoyaki on December 20, 2021, 02:31:50 PM
Hello. I have a question.

Why is the Linear Profile of the MLV App brighter than the output of dcraw or DaVinci Resolve?

MLV App's Linear looks brighter.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on December 30, 2021, 09:28:30 AM
Sorry for asking something potentially silly that may have already been answered before... but is there any reason why MLV App will produce such huge files, at least with H.265 10bit 4:2:0 via ffmpeg "high quality"?

Comparing same Raw footage (slightly upscaled to UHD) rendered in DaVinci Resolve (H.265 Master preset, with Main10 profile and automatic quality) and in MLV App, I get 16 Mbps with the former and a whopping 126 Mbps with the latter :o.

Now I understand that the question might be turned upside down, i.e. is there any reason why DVR produces a lower bit-rate video output? But the fact is, if I inspect carefully the two results, I am unable to see any difference in fine details.

Thank you
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 30, 2021, 03:12:29 PM
This question can't really be answered - "huge and small" is relative to a users definition. I can't tell what DVR does - but I can explain what MLVApp exports. If you're interested, you can read here - MLVApp uses ffmpeg for H.265 export.
https://trac.ffmpeg.org/wiki/Encode/H.265

The size and quality of the file is defined by using the CRF (Constant Rate Factor). 1=lossless, up to 51(very low quality). For MLVApp we played a lot when implementing and we've finally chosen 18 (high) and 24 (medium). So maybe the lower MLVApp setting could still be higher than the DVR "high" setting... who knows... We would be able to export the files much bigger, but also smaller when changing the CRF numbers.

If you like to play on your own with those numbers: try to compile MLVApp on your system and find the numbers in "MainWindow.cpp" line 2311.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 19, 2022, 04:53:05 PM
if mlvapp could implement existing plugin (third party?) like in premiere pro or other NLE it would be great I think.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on January 20, 2022, 06:03:37 PM
If I choose to export in DNxHD, a window-command prompt opens entering an infinite loop.
If I close the window, the exporting starts however the files generated are corrupted.

Please fix this :(
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 20, 2022, 06:55:59 PM
@ML700D: do you know any free and easy API? What kind of plugin?

@Quentin: the command promt is not in infinite loop. It is a Windows-only feature to tunnel data to ffmpeg. Wait until export is ready. If you close it, you'll get corrupted or no data. Can't see any bug here.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Quentin on January 20, 2022, 11:58:40 PM
What if it takes forever ?
In the past, when I used previous version of MLVApp I didnt take so long.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 21, 2022, 07:28:16 AM
Maybe you should tell more about your system, the MLV file, the receipt, the export settings, camera settings, ...
DNxHD works fine here (exports nearly in realtime), same for all other ffmpeg based codecs. So it must be something else on your side.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 21, 2022, 02:14:11 PM
Quote from: masc on January 20, 2022, 06:55:59 PM
@ML700D: do you know any free and easy API? What kind of plugin?

denoiser I think, I found this freeware but not try it yet. https://bit.ly/32jqXZG

or like this one https://github.com/NatronGitHub/openfx-misc (OFX plugin)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 21, 2022, 03:29:08 PM
OFX is extremely difficult - at least too difficult for me. If someone can help integrating that, please let me know. I tried that in past and gave up after a few weeks.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 22, 2022, 04:10:22 PM
Quote from: masc on January 21, 2022, 03:29:08 PM
OFX is extremely difficult - at least too difficult for me. If someone can help integrating that, please let me know. I tried that in past and gave up after a few weeks.

oh ic.. how about the first link I gave "batch_denoiser"? not ofx based I think, it use command like in mlvapp, here is a guy talked about it in this forum https://www.dpreview.com/forums/thread/4461481

about mvtools I google and found this links:
http://avisynth.nl/index.php/Main_Page
http://avisynth.org.ru/mvtools/mvtools2.html
https://github.com/pinterf/mvtools
and this one will useful too if it can be integrated with mlvapp https://www.svp-team.com/
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 22, 2022, 04:51:42 PM
Commandline based is better. But those apps are Windows only... did we have "post export scripts" in Windows? I know we have that on macOS. And remember: this works post export - that means you encode twice (and this will be at the cost of quality).

If another denoiser would be on your wishlist, you could do some research for ffmpeg denoisers. I know there are multiple different denoisers included in ffmpeg. If we know the exact commands and the meaning of all the parameters, we could try to integrate this (best with some presets, so the user just selects something like (hard/soft/...)). And here we encode just once. It could work for all ffmpeg export codecs. I know "Handbrake" offers these denoisers.
http://ffmpeg.org/ffmpeg-filters.html#vaguedenoiser
http://ffmpeg.org/ffmpeg-filters.html#nlmeans-1
http://ffmpeg.org/ffmpeg-filters.html#atadenoise
http://ffmpeg.org/ffmpeg-filters.html#hqdn3d-1
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 22, 2022, 05:01:03 PM
Quote from: masc on January 22, 2022, 04:51:42 PM
Commandline based is better. But those apps are Windows only... did we have "post export scripts" in Windows? I know we have that on macOS. And remember: this works post export - that means you encode twice (and this will be at the cost of quality).

If another denoiser would be on your wishlist, you could do some research for ffmpeg denoisers. I know there are multiple different denoisers included in ffmpeg. If we know the exact commands and the meaning of all the parameters, we could try to integrate this (best with some presets, so the user just selects something like (hard/soft/...)). And here we encode just once. It could work for all ffmpeg export codecs. I know "Handbrake" offers these denoisers.
http://ffmpeg.org/ffmpeg-filters.html#vaguedenoiser
http://ffmpeg.org/ffmpeg-filters.html#nlmeans-1
http://ffmpeg.org/ffmpeg-filters.html#atadenoise
http://ffmpeg.org/ffmpeg-filters.html#hqdn3d-1

that's great.. can it export to maybe prores 422 in mlvapp? 
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 22, 2022, 05:03:28 PM
is it possible to preserve sharpness while denoising?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 22, 2022, 05:23:51 PM
...no idea - I think yes. But that is what I mean: Someone should play with that and try out. ffmpeg is in MLVApp path. So just take any video clip and try to play with it in command line terminal.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 22, 2022, 05:34:50 PM
Quote from: masc on January 22, 2022, 05:23:51 PM
...no idea - I think yes. But that is what I mean: Someone should play with that and try out. ffmpeg is in MLVApp path. So just take any video clip and try to play with it in command line terminal.

thanks masc, I will try to find out. :)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 23, 2022, 05:37:18 AM
masc..
how dumb i am :o , I just realized that denoise feature in mlvapp is better now..

I found this link https://github.com/clausmichele/ViDeNN
what do you think?

btw I'm curious to ask, why stabilize feature only use h.264 not others format(e.g. prores)?

thanks a lot masc.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 23, 2022, 06:47:40 PM
Most times, the MLVApp RBF denoiser is good enough, at least for what I do. That does not mean, there are no better solutions out there.

Most source code for free denoisers use openCV or Python. But this is a problem for us, because this is very slow and this has new dependcies we don't really want to include. Best would be a clean C/C++ version.

The stabilize feature works only, because the author made it like that. I have no idea why, but unfortunately it is as it is. That's a shame, because I really like the results, just the codec isn't my favorit. ;) If there comes the day this (or a similar) feature comes for all codecs, I would be very interested to exchange.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 23, 2022, 07:12:18 PM
I see masc..

thanks a lot. 🍻
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: happyta5 on January 30, 2022, 12:25:14 AM
Hi all,

I gave up on ML with 5DIII years ago because workflow is so troublesome. With this MLV-app, I am happy to try it again. I have 5.7k video when convert to ProRes or H.264. I don't see ffmepg is using any GPU power. I have a nvidia GTX 1060 6G installed.


Thanks

Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 30, 2022, 09:07:09 AM
hi masc,

what do you think about prores RAW in MLVapp?

https://www.apple.com/final-cut-pro/docs/Apple_ProRes_RAW.pdf (https://www.apple.com/final-cut-pro/docs/Apple_ProRes_RAW.pdf)

thanks.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 30, 2022, 10:05:14 AM
Is there any API or lib already, which offers ProResRAW encoding? Same for BM-RAW. It could be another export type in MLVApp... not RAW, not processed, but something in between.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 30, 2022, 10:48:54 AM
Quote from: masc on January 30, 2022, 10:05:14 AM
Is there any API or lib already, which offers ProResRAW encoding? Same for BM-RAW. It could be another export type in MLVApp... not RAW, not processed, but something in between.

like this? https://support.apple.com/kb/dl2033?locale=en_US

BM raw is good too..
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 30, 2022, 11:19:42 AM
We need a programming interface - best: platform independant C/C++ source code.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 30, 2022, 12:14:48 PM
ok. masc..

I think it's too complicated for me.  😁

btw BM RAW has Developer SDK Fully documented publicly available.

https://www.blackmagicdesign.com/products/blackmagicraw

Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 30, 2022, 01:04:27 PM
Quote from: ML700D on January 30, 2022, 12:14:48 PM
btw BM RAW has Developer SDK Fully documented publicly available.

https://www.blackmagicdesign.com/products/blackmagicraw

"Using the SDK gives you access to GPU accelerated and CPU optimized algorithms for decoding Blackmagic RAW files."
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 30, 2022, 01:09:09 PM
oh.. I see,

thanks masc.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 06, 2022, 02:22:04 PM
Hello Masc,

I have a question for you.  Right now there are a variety of very powerful used workstations in very good condition that can be purchased for a very good price.  For example, this one:

https://www.kvantservice.com/product/dell-precision-7810-17265/

that has 2x Octa Core Xeon Processors at 3,2 GHz, 64 GB of RAM, 1 TB NVMe SSD and the M5000 GPU can be obtained for less than 1500 Euro.  In addition, it is extremely quiet, quite compact and very well built.  My question is:  Does it make sense to use a workhorse like this for running multiple instances of MLVApp simultaneously?  I tried running 2x MLVApp simultaneously on my i7 laptop with 32 GB of RAM.  However, this did not bring any significant improvement in overall render duration compared to a single MLVApp.  If the above workstation is used for running 4x MLVApp simultaneously, could we expect a significant improvement in render duration, especially when processing Dual ISO footage that takes forever on the laptop?

I am asking because MLVApp occupies a significant part of my workflow and I am looking for ways to improve its efficiency.  MacBook Air M1 is not an option since the workstation will also be used for other serious tasks.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on February 06, 2022, 04:11:45 PM
Hello.
Is there a method in the program to remove the flickering on a substandard light source?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 06, 2022, 05:41:45 PM
@IDA_ML: I can't answer this question, because I never do this. I just run one single instance which runs multithreaded and I almost never use DualISO. For DualISO I could imagine that it will run faster on multiple instances, because this algorithm runs single threaded and needs much CPU power.

@Icaab: nope - that doesn't exist in MLVApp. Best is to adjust shutter to the light frequency before recording. You could give "Smooth aliasing" in export dialog a try - but it will need much time and the chance is not very big, it becomes better.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 08, 2022, 07:19:18 PM
Thanks Masc!  How many cores (threads) does MLVApp support?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 08, 2022, 08:52:17 PM
@IDA_ML: MLVApp supports as many threads openMP supports - I did not hear about a limit yet.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 08, 2022, 09:18:59 PM
Sounds good to me, Masc.  Checking out one of these old workstations with tons of threads certainly makes sense.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: lil4ml on February 09, 2022, 12:47:49 PM
is there a file rename function that i dont see in mlvapp? if there isnt one, is it possible to add one?
i load all my footage to the session so i can see the content of the individual files only to change the ml standard filenames (Mxx-xxx.MLV) to filenames so i can directly identify the footage.
but for that i have to go to file explorer and before renaming close mlvapp because it locks the file or jump in the mlvapp instance to the next file. jumping files is sometimes confusing. ???
then i load mlvapp again with the renamed files and export the footage.

so a right click menu for file renaming in session view would be perfect solution 8)

or does someone have a workaround for me?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 09, 2022, 06:26:54 PM
@lil4ml: thanks for reporting. Yes, that was no usecase yet. And I can imagine that renaming opened files could be really hard. Will have a look into that...
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 09, 2022, 09:23:04 PM
Masc,

You say that the Dual ISO algorithm runs single threaded and needs much CPU power.  Isn't it possible to make it run multi threaded?  This would be a game changer for this fantastic feature.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 09, 2022, 10:20:13 PM
For that someone must completely understand this algotithm. I tried to multithread it just by analysing the code and failed several times very hard. It was fast then, but the result very wrong.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 10, 2022, 01:37:41 AM
@IDA_ML

Old versions of MLVApp used to support multithreaded Dual-ISO processing, however in later versions it was disabled due to some artifacts happening in some frames when the multi-threaded code is enabled.

e.g: MLVApp v1.1 has multithreaded Dual ISO processing, quick test on my machine:

A Dual ISO MLV clip which has 265 frames (1736x976 14-bit uncompressed, exported to C-DNG uncompressed) took:

-58 seconds to process using MLVApp v1.1
- and 2:22 minuets using MLVApp v1.13

That's because MLVApp v1.1 is utilizing more threads.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 10, 2022, 01:05:49 PM
Ha, that's very interesting, Bilal, thanks for the tip.  Haven't paid attention to that before since I haven't used Dual ISO much in the past.  But now that I have played around with Dual ISO quite a lot and am aware of the fact that it can greatly improve dynamic range and image quality in low-light high-contrast scenes in real life filming situations, I have to retry Dual ISO on one of the older versions of MLVApp.  Hopefully, I will not end up with some ugly artefacts.  One nice feature of v. 1.13 is that I am quite satisfied with the image quality of Dual ISO files, especially in the 1736x2928 full sensor width resolution that provides enough vertical resolution for Dual ISO.  Even occasional flickering does not seem to be that big of a problem.  In my experience, Dual ISO is a real life saver in many real world low-light scenarios, especially for cameras such as the EOS-M, 650D and 700D that do not shine with good low-light performance.

Masc,

It would be very interesting to compare image quality and render times of your Elgersburg workflow (high ISO, Darkframe subtraction, RBF noise reduction, etc.) to Dual ISO 200/1600 or 400/3200 or even 1600/6400.  If you have performed such comparative tests, could you please share a few thoughts on that?   
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 10, 2022, 04:34:39 PM
Quote from: lil4ml on February 09, 2022, 12:47:49 PM
is there a file rename function that i dont see in mlvapp? if there isnt one, is it possible to add one?
i load all my footage to the session so i can see the content of the individual files only to change the ml standard filenames (Mxx-xxx.MLV) to filenames so i can directly identify the footage.
but for that i have to go to file explorer and before renaming close mlvapp because it locks the file or jump in the mlvapp instance to the next file. jumping files is sometimes confusing. ???
then i load mlvapp again with the renamed files and export the footage.

so a right click menu for file renaming in session view would be perfect solution 8)

or does someone have a workaround for me?

I added this feature to MLVApp. Please test. On macOS it seems to work fine. On Windows I am not very sure about that... (have no Windows here).
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 10, 2022, 04:39:51 PM
Quote from: IDA_ML on February 10, 2022, 01:05:49 PM
Masc,

It would be very interesting to compare image quality and render times of your Elgersburg workflow (high ISO, Darkframe subtraction, RBF noise reduction, etc.) to Dual ISO 200/1600 or 400/3200 or even 1600/6400.  If you have performed such comparative tests, could you please share a few thoughts on that?
No, I did not do such tests. I almost never use dualiso. But I expect render times for dualiso to be much longer compared to darkframe+RBF.

Edit: Tested for you:
-> 6sec of 5.7K dualiso 400/3200 to ProRes4444 -> 5:10min
-> 6sec of 5.7K + Darkframe + RBF luma&chroma to ProRes4444 -> 1:33min
-> 6sec of 5.7K default settings to ProRes4444 -> 1:31min
M1 is warm now.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 10, 2022, 06:17:32 PM
Thanks a lot, Masc.  These are quite impressive render times, indeed.  If you have not deleted the test files yet, could you take a look at 100% magnification?  Is the image quality for Dual ISO much worse compared to the Elgersburg workflow?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 10, 2022, 06:34:53 PM
The Elgersburg clip (some frames of it - ISO1600) still exists. You can have a look yourself (my receipt included):
https://www.dropbox.com/s/p2j112gyph5ywzu/ElgersburgBHF.zip?dl=0

For a nice dualiso clip you might have better clips then I have.

Edit: There is a bug in the receipt: switch darkframe to "Int" manually after loading.
Edit2: Fixed.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 10, 2022, 07:22:17 PM
Thank you again, Masc.  I have downloaded your clip and will take a look.

Here is a Dual ISO clip that I have shot on the 700D:

https://we.tl/t-psETTga5hW

A sample .MLV is also enclosed.  I have downsized the clip to 2560x1440 resolution since the 5,2K file does not play smoothly on my PC.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 11, 2022, 03:28:30 AM
Quote from: IDA_ML on February 10, 2022, 07:22:17 PM
Thank you again, Masc.  I have downloaded your clip and will take a look.

Here is a Dual ISO clip that I have shot on the 700D:

https://we.tl/t-psETTga5hW

A sample .MLV is also enclosed.  I have downsized the clip to 2560x1440 resolution since the 5,2K file does not play smoothly on my PC.

nice.. I always get very dark image when using 100/800 with f/4 😊

(https://i.ibb.co/2vcV7Tv/Screenshot-2022-02-11-092137.png)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 11, 2022, 07:51:26 AM
Quote from: ML700D on February 11, 2022, 03:28:30 AM
nice.. I always get very dark image when using 100/800 with f/4

ML700D,

You need to learn how to expose to the right (ETTR) properly, also with Dual ISO!  In this particular shot I increased the exposure until zebras started appearing on the window of the store on the left.  Then I dialed it down by 1/3 of a stop and started recording.  I could have used F2.8 but in that case, zebras started showing up on the brightest areas, that is why I had to dial the aperture down to F4. 

If the light is not enough, you can try playing around with the Dual ISO numbers until the camera allows you to perform the above procedure.  Instead of 100/800, use 200/1600 or 100/1600 or even 400/3200, etc.   Just make sure you do not blow up the brightest areas since this really looks ugly.  Sometimes, the scene gets even too bright to look natural.  As I said, before asking questions, practice, practice, practice until you like what you see and after analyzing the results on your computer you will very quickly get the feeling for it.  Nobody else is going to do that for you!  MLVApp is such a wonderful tool in giving you all the metadata of your shots.  Why don't you just write down on a piece of paper the settings that work best for you and use them as a starting point in your future shots?  After some practice you will be able to tell if your exposure is right just by looking at the image on your camera screen.

And most importantly, just don't expect miracles!  They don't happen, even with the most expensive cameras.  But if you get things right you can produce some very beautiful high image quality shots even with such low-end cameras as the EOS-M or the 700D.  I always admire Zeek's work.  All his videos are technically close to perfection simply because he has learned how to squeeze the very last bit of image quality out of his EOS-M.  Just watch them all, you will have a lot of fun and learn a lot!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 11, 2022, 10:09:43 AM
I see, I just feel a bit jealous ha.ha. 😄


Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 13, 2022, 09:52:54 AM
using masc method still got good result in very low light condition I think, plus a bit detail in the shadow that I couldn't see in actual condition.

this video recorded only use ambient light that goes trough the window at iso 3200 f/1.8 50mm, crop_rec 1x3 4K.
Edited in MLVapp using Dark Frames + RBF Denoiser export to h.265 4:4:4 2560x1280

Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 13, 2022, 02:41:48 PM
masc,
in windows version there is no reinhard tonemapping function like yours

(https://i.ibb.co/d5WQgty/Screenshot-2022-02-13-203623.png)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 13, 2022, 03:07:42 PM
The profile section got a big update a year ago - the tutorial is older. But you can get identical results. Reinhard is auto selected in background if you choose preset "Tonemapped" now. And with "Film" you select 3/5 Reinhard. (my new favorit)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 13, 2022, 03:38:20 PM
oh.. I see, thanks.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: lil4ml on February 14, 2022, 12:27:16 PM
Quote from: masc on February 10, 2022, 04:34:39 PM
I added this feature to MLVApp. Please test. On macOS it seems to work fine. On Windows I am not very sure about that... (have no Windows here).
thanks masc
now need to learn how to compile with this ide  ::)
unless there is someone who could make a new version ;) 8)
op is not active anymore?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 14, 2022, 04:19:59 PM
@lil4ml: what OS do you use?
I could send macOS versions (M1 or Intel). On Windows I found out, that it doesn't work as expected... :( Here it becomes way more complicated (as usual). What do you mean with "op"?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 15, 2022, 04:33:12 AM
Reinhard Tonemapped Iso 100 f/4.0 50mm, crop_rec 1x3 4K
I think 50mm fix lens has limitation in certain situtation, better in close up.



Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: lil4ml on February 16, 2022, 07:32:34 AM
Quote from: masc on February 14, 2022, 04:19:59 PM
@lil4ml: what OS do you use?
I could send macOS versions (M1 or Intel). On Windows I found out, that it doesn't work as expected... :( Here it becomes way more complicated (as usual). What do you mean with "op"?
i use win10 64bit

by op i meant original poster and i assumed that ilia3101 did the last builds for all the os...but later i saw that the last builds were made by you masc. sorry for the confusion

bummer that windows behaves different with the renaming function. still doable?

going to try to set up the qt ide
is this still the way to go?
QuoteQt App Windows
install Qt5 (Win32: minimum 5.6, Win64: minimum 5.13.2) with MinGW32/64 compiler
unpack ffmpegWin.zip in platform/qt/FFmpeg (and copy it later into build directory)
open platform/qt/MLVApp.pro in QtCreator
Build and Start
my workstation is offline only. the last offline qt setup ver. is 5.13.2. so win64 compiling should be possible.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 16, 2022, 04:20:31 PM
@ lil4ml: Seems I got it working now also for windows. But would be cool, if you could test on your side. If you have a Qt 5.13.2 mingw64 installed, compiling is very easy. Just load the .pro into QtCreator, select "Release" and hit compile button.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 16, 2022, 06:17:19 PM
Hi guys!

I can confirm windows version works and linux version too.
Great job @masc! (as usual)

Here is latest static 64bit windows build (https://bouncyball.myweb.ge/mlvapp/?dir=&download=MLVApp.zip) if anyone needs it but can't compile. Just unpack and put the binary to mlvapp folder.

regards
bb
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: dream951 on February 16, 2022, 10:39:24 PM
Quote from: theBilalFakhouri on February 10, 2022, 01:37:41 AM
@IDA_ML

Old versions of MLVApp used to support multithreaded Dual-ISO processing, however in later versions it was disabled due to some artifacts happening in some frames when the multi-threaded code is enabled.

e.g: MLVApp v1.1 has multithreaded Dual ISO processing, quick test on my machine:

A Dual ISO MLV clip which has 265 frames (1736x976 14-bit uncompressed, exported to C-DNG uncompressed) took:

-58 seconds to process using MLVApp v1.1
- and 2:22 minuets using MLVApp v1.13

That's because MLVApp v1.1 is utilizing more threads.

It doesn't give any performance for me. Render time is the same
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: dream951 on February 16, 2022, 10:47:40 PM
Quote from: ML700D on February 13, 2022, 09:52:54 AM
using masc method still got good result in very low light condition I think, plus a bit detail in the shadow that I couldn't see in actual condition.

this video recorded only use ambient light that goes trough the window at iso 3200 f/1.8 50mm, crop_rec 1x3 4K.
Edited in MLVapp using Dark Frames + RBF Denoiser export to h.265 4:4:4 2560x1280



Hi
What's the masc method? Can you tell me in two words?
And what is the dark frames? Like in a astrophoto, denoising frames, right?
Just sorry for my english :)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 17, 2022, 03:09:02 AM
Quote from: dream951 on February 16, 2022, 10:47:40 PM
Hi
What's the masc method? Can you tell me in two words?
And what is the dark frames? Like in a astrophoto, denoising frames, right?
Just sorry for my english :)
RBF denoiser from MLVapp
yes, dark frames like denoising frames. you can read here from masc

Quote from: masc on February 10, 2022, 12:37:32 PM
MLVApp offers to reduce the static noise from your clips using dark frames. https://github.com/ilia3101/MLV-App/wiki#darkframe-subtraction

and YT compression if you upload to youtube

Quote from: Skinny on February 09, 2022, 07:09:45 AM
Have you tried uploading the same video to youtube but without denoiser? It will be interesting to compare. I found that youtube heavy compression algorithm acts like a denoiser to some extent :D
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 17, 2022, 04:46:25 PM
Quote from: bouncyball on February 16, 2022, 06:17:19 PM
I can confirm windows version works and linux version too.
I again found 2 bugs and fixed them on renaming function...
On Linux it was possible to rename clips so far?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: dream951 on February 17, 2022, 07:11:23 PM
Quote from: ML700D on February 17, 2022, 03:09:02 AM
RBF denoiser from MLVapp
yes, dark frames like denoising frames. you can read here from masc

and YT compression if you upload to youtube

Thanks a lot!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: dream951 on February 17, 2022, 07:37:08 PM
Guys, hello!
Please help with the correct video coloring process in 3dlut. I export mlv to a dng series, with corrections completely off in all settings, then open the first dng from the series in 3d lut creator, set input and output profiles to off. But the pictures are absolutely different, the histogram also confirms this. Various combinations of input and output profile also do not give me a picture (for example, the input is linear, and the output is rec709, which would be logical) that matches what is displayed in mlvapp. And any adjustments in 3dl in the future in mlvapp are displayed incorrectly. Tell me what I'm doing wrong and how can I make the frames and correction match. Thanks
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 17, 2022, 07:54:48 PM
In the end DNG is RAW. MLVApp won't change e.g. exposure. Did you record HDR video? Brightness changes in all frames here.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: dream951 on February 17, 2022, 07:58:17 PM
Quote from: masc on February 17, 2022, 07:54:48 PM
In the end DNG is RAW. MLVApp won't change e.g. exposure. Did you record HDR video? Brightness changes in all frames here.
No, simple test shot only
Sample screenshots there:
https://fex.net/ru/s/l3se7da
https://fex.net/ru/s/b8ynayt
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 17, 2022, 08:03:56 PM
Would be better if you upload the problematic frames as MLV. Can't help with processed frames...
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: dream951 on February 17, 2022, 08:12:59 PM
Quote from: masc on February 17, 2022, 08:03:56 PM
Would be better if you upload the problematic frames as MLV. Can't help with processed frames...
It is in a second link
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 17, 2022, 08:21:32 PM
One DNG? I can't compare anything with one single file. And DNG is the output - can't check for bugs or MLVApp behavior with that.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: dream951 on February 17, 2022, 08:28:44 PM
Quote from: masc on February 17, 2022, 08:21:32 PM
One DNG? I can't compare anything with one single file. And DNG is the output - can't check for bugs or MLVApp behavior with that.
Solved the problem by writing to the 3dlut developer. The solution is quite simple - export to TIFF and further processing in 3dlut, the results are the same! Thank you for your responsiveness, masc!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 18, 2022, 05:14:59 AM
Film (3/5 Reinhard) + Dark Frames + RBF Denoiser + Grain
with enable filter to Toy Camera reduced to 60
iso 800 f/2.8 crop_rec 1x3 4K
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 19, 2022, 07:11:13 AM
masc,
I get this problem with dualiso, I noticed it appeared around the small edge of the image at a certain distance. I once asked this in Bilal's thread post (https://www.magiclantern.fm/forum/index.php?topic=25784.msg237490#msg237490).
here is the file --> M19-1046.MLV (https://drive.google.com/file/d/1R86DeRfgjRjlK6QkImfggmtd7K04qpoS/view?usp=sharing)

(https://i.postimg.cc/FKTp1gw0/Screenshot-2022-02-19-113334.png)


Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 19, 2022, 03:35:27 PM
Looks like focus pixels. Currently there is no way to fix them in dualiso footage.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 20, 2022, 08:30:13 AM
I see, thanks masc.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on February 20, 2022, 11:37:43 AM
Quote from: masc on February 17, 2022, 04:46:25 PM
On Linux it was possible to rename clips so far?
Yup
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: lil4ml on February 23, 2022, 09:48:19 AM
Quote from: bouncyball on February 16, 2022, 06:17:19 PM
Hi guys!

I can confirm windows version works and linux version too.
Great job @masc! (as usual)

Here is latest static 64bit windows build (https://bouncyball.myweb.ge/mlvapp/?dir=&download=MLVApp.zip) if anyone needs it but can't compile. Just unpack and put the binary to mlvapp folder.

regards
bb
testet this linked build and can confirm that it is working for me too.
one minor thing. after renaming a file from session list that was not active(preview mode) the renamed file becomes active but the font highlight is still on the old file. does not bother me.


munch better workflow for me now.
BIG thanks masc
and thanks for compiling bouncyball
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 23, 2022, 09:51:58 AM
Those minor things should be fixed in latest commit already. But thanks for reporting!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on February 24, 2022, 06:04:05 PM
Can I ask about some feature request?

It would be really helpful if the interface of the program could be switched to light grey/white theme.
I like black interface but it is important to sometimes see how everything looks on a white background, because many consumer level monitors have some sorts of auto-contrast that can not be switched off, and the picture you see when working with dark interface is kind of different than you will see when upload everything on the internet, where sites usually have light backgrounds...

And not only monitors adjusts their brightness/contrast, our eyes too. So it is just helpful to switch the interface sometimes. For example, in photoshop you can click on a background and select custom color, usually I select almost pure white. And then the picture looks a lot more like it will be on the internet.

But this is just a suggestion, if it is too hard to implement or requires a lot of work then... I think everybody can live without it :) but if in some future version we will see such an option, it will be very nice.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 25, 2022, 06:22:01 PM
@Skinny:
Thanks for the request. I could offer realizing something similar to Lightroom - the theme is still dark, but the color of the viewer background could be changed. It would look like this:
(https://i.ibb.co/gJkhszN/Backgroundcolor.jpg)
Changing an entire theme is difficult - hundreds of line of code and no guaranty it looks good in the end...

Edit: feature commited to repos.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on February 26, 2022, 09:14:03 AM
@masc thank you! This is great, changing the background color is very helpful.

By the way, I am always surprised how much free software is better than commercial. When people ask for something, for example, from Adobe, they usually just ignore everything :D
And here we see a real community and a program that really develops and becomes more mature every day. You and all other guys who work on this program are just awesome! :)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IDA_ML on February 26, 2022, 10:38:01 AM
Changing background color would be another very welcome addition to this fantastic software.  Thanks a lot, Masc, for considering it!  I have been using MLVApp to process my still RAW files from the 5D3 for quite some time now and cannot be happier.  The processing flexibility and precision helps me get much better results compared to ACR, especially w.r.t. skin tones and noise reduction.  And I love the fact that it gets better and better. 

Congratulations to the developers for their amazing achievement!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: kob on March 02, 2022, 12:07:42 AM
Is there an audio adjustment in MLVapp ?

My (audio) recording settings (in Canon menu) are set as low as possible, and my videos are (overload) crackling in the audio.

Using EOSM, and there is no "quieter" microphone setting. Unless it's inside MLVapp or Magic Lantern. The audio is useless. 
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on March 02, 2022, 09:38:24 AM
Quote from: kob on March 02, 2022, 12:07:42 AM
Is there an audio adjustment in MLVapp ?
Nope.

Quote from: kob on March 02, 2022, 12:07:42 AM
My (audio) recording settings (in Canon menu) are set as low as possible, and my videos are (overload) crackling in the audio.
Using EOSM, and there is no "quieter" microphone setting. Unless it's inside MLVapp or Magic Lantern. The audio is useless.
If audio has clipped during acquisition you can't do anything about it in post, except just lower gain a bit and apply some smoothing filter to not hear that awful crackling. Anyway, information is gone and you're not gonna recover it.

My suggestion is to use external mic/preamp/recorder (built in mic sucks on every eos cam anyway) if eosm can't handle high decibels well (AGC is always on?). And sync it in post.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on March 02, 2022, 12:34:00 PM
Quote from: kob on March 02, 2022, 12:07:42 AM
My (audio) recording settings (in Canon menu) are set as low as possible, and my videos are (overload) crackling in the audio.

Using EOSM, and there is no "quieter" microphone setting. Unless it's inside MLVapp or Magic Lantern. The audio is useless.

Same thing happens for me,

On my 700D the audio settings from Canon menu is being ignored when recording RAW video (https://www.magiclantern.fm/forum/index.php?topic=25121.msg228273#msg228273), probably ML bug or maybe this feature isn't implemented for some models like 700D and EOS M.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on March 02, 2022, 02:59:42 PM
Quote from: bouncyball on March 02, 2022, 09:38:24 AM
If audio has clipped during acquisition you can't do anything about it in post, except just lower gain a bit and apply some smoothing filter to not hear that awful crackling. Anyway, information is gone and you're not gonna recover it.
there is also izotope RX de-clip, which can restore some digital clipping, but don't expect too much.. here you can hear an example: https://www.izotope.com/en/learn/using-the-de-clip-plug-in-to-fix-clipped-vocals.html
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on March 04, 2022, 08:49:06 AM
Btw this audio issue is the main reason why Magic Lantern project even exists...

Trammel was unhappy with audio recording levels on his 5d2 and used his RE and programming skills and chdk project as a basis to write his own ARM code to set the audio levels for his cam. So ML was born :D
Title: Re: MLV App’s Linear Profile
Post by: takoyaki on March 09, 2022, 05:07:41 PM
Hi. Does anyone know the answer to this post?

Quote from: takoyaki on December 20, 2021, 02:31:50 PM
Hello. I have a question.

Why is the Linear Profile of the MLV App brighter than the output of dcraw or DaVinci Resolve?

MLV App's Linear looks brighter.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 09, 2022, 09:57:23 PM
@takoyaki: no idea what other apps do and I never compared this. I just can tell that MLVApp linear funtion does this for linear tonemap: output=input.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on March 11, 2022, 12:49:19 PM
Hm... good question/answer. This means input already was brighter. So I guess the answer is in debayer part or right after debayer.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on March 17, 2022, 06:40:16 AM
masc,

avir ver. 3.0 has LANCIR 3.0.7 as part of the library and much faster he said here (https://github.com/avaneev/avir)


Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 17, 2022, 09:08:30 AM
"LANCIR offers up to three times faster image resizing in comparison to AVIR. The quality difference is, however, debatable. Note that while LANCIR can take 8- and 16-bit and float image buffers, its precision is limited to 8-bit resizing."

--> Yes, but it is just faster. We internally use 3x16bit color information, but this would finally limit the pipeline to 3x8bit, but consuming the time of the 16bit pipeline for all other algorithms. (256 colors of possible 65536 per channel as result)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on March 17, 2022, 10:31:26 AM
Quote from: masc on March 17, 2022, 09:08:30 AM
"LANCIR offers up to three times faster image resizing in comparison to AVIR. The quality difference is, however, debatable. Note that while LANCIR can take 8- and 16-bit and float image buffers, its precision is limited to 8-bit resizing."

--> Yes, but it is just faster. We internally use 3x16bit color information, but this would finally limit the pipeline to 3x8bit, but consuming the time of the 16bit pipeline for all other algorithms. (256 colors of possible 65536 per channel as result)

ooh I see..
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on March 20, 2022, 04:34:24 PM
Hi guys, I recently switched to a "new" (very old) computer and I can't run MLV App 1.13 on it for some reason. While 1.11 and 1.12 are working but only 32-bit versions (although I didn't check 1.11 x64).
But 1.13 just can not start, it doesn't show any error messages or anything, I can see it process in task manager for maybe a second, and then it just silently disappears.

I'm on fairly "fresh" installed windows so maybe I need to install something? like .NET or something else?
The config is (don't laugh!! :D) Intel Core 2 4400 2.0GHz so it's a dual core machine with 4gb of ram and ati radeon hd 4850 installed. Windows 10 x64 21H2 and by the way it runs ok, very smoothly. motherboard and cpu are from ~2007 so it's 15 years old :o but this is all I have for now..
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 20, 2022, 05:12:03 PM
Strange. Never tried such an old CPU. Normally a fresh Windows 10 is okay. No additional library is needed.
I know it working on:
- MacBook and MacBook Pro 2010: Core 2 Duo P8600 2.4GHz on macOS 10.9.5 and 10.13
- MacBook 2008: Core 2 Duo T8300 2.4GHz on macOS 10.6.8, but using Windows 32bit version via Wine, without anything else installed
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on March 21, 2022, 04:22:19 AM
@masc I'm using slightly cut down win 10 version (some unnecessary things disabled like store and so on). I had doubts the full version will work on that hardware.. So there is a chance something is missing, but I don't know tbh, all other programs seems to run ok.
Is there an option to diagnose what exactly happening, why MLV App quits? because it's doing it absolutely silently I can't even google the error and maybe see what could be done.

p.s. I'm gonna google what software can diagnose potential problems with running exe's, maybe I'll find something

It seems like I have all the necessary dependencies, and they are the same for 1.12 version
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on March 21, 2022, 09:56:03 AM
visual c++ redistributable maybe?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 21, 2022, 10:19:17 AM
Visual C++ libs are not needed, because it is not really compatilbe with many standard C/C++ libraries - we use mingw+Qt. All needed libraries are included in the package. 1.12 and 1.13 also should have the same dependencies. Maybe 1.13 was compiled with a newer Qt, which often has different system requirements than older versions. If you find a system where it works: in menu->help->about Qt, you can see which Qt library was used to build the release.

For getting more information on Windows systems, I think you'll have to install the entire Qt framework and debug with this. macOS brings a very detailed crash report and tells exactly the reason... unfortunately Windows doesn't do this.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on March 21, 2022, 11:05:28 AM
Quote from: Skinny on March 20, 2022, 04:34:24 PM
Hi guys, I recently switched to a "new" (very old) computer and I can't run MLV App 1.13 on it for some reason. While 1.11 and 1.12 are working but only 32-bit versions (although I didn't check 1.11 x64).
But 1.13 just can not start, it doesn't show any error messages or anything, I can see it process in task manager for maybe a second, and then it just silently disappears.

I just tried MLVApp 1.13 32-bit on old laptop, Pentium T2330 CPU with 1 GB RAM on Windows 7 32-bit and yeah it crashes silently. MLVApp 1.12 works (it launches).

So I confirm the crash, I can't help with de-bugging. You may want to follow masc instructions . .
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on March 21, 2022, 03:08:18 PM
Quote from: masc on March 21, 2022, 10:19:17 AM
Visual C++ libs are not needed, because it is not really compatilbe with many standard C/C++ libraries - we use mingw+Qt. All needed libraries are included in the package. 1.12 and 1.13 also should have the same dependencies. Maybe 1.13 was compiled with a newer Qt, which often has different system requirements than older versions. If you find a system where it works: in menu->help->about Qt, you can see which Qt library was used to build the release.

For getting more information on Windows systems, I think you'll have to install the entire Qt framework and debug with this. macOS brings a very detailed crash report and tells exactly the reason... unfortunately Windows doesn't do this.
I see..
thanks masc.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on March 21, 2022, 06:29:34 PM
wow. so this is not only on my computer..

Two years ago I messaged ilia3101 and he mentioned.... I will just quote him (well, I hope it is ok to quote a line from PM)
QuoteI used to use MLV App on a thinkpad X61 (laptop from 2006), and I had to fix a couple of bugs that only happened on the old cpu
And I don't know, maybe it is something like this. unfortunately.
I tried to use some programs that can show some info on exe files, dependencies and stuff, but didn't find anything different from v1.12.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on March 22, 2022, 02:30:44 PM
masc,
just a bit suggestion, in MLVapp sidebar I think it's better to put profile tab and lut tab above processing tab
so we don't have to scrolling up and down when choosing different profile or enable creative adjustment and lut.
this is more convenient I think.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on April 02, 2022, 02:49:05 PM
hi masc,
is there an easy way to compile mlvapp?
I couldn't compile using qt6 and got an error like no "make" or "qmake" something like that..

thanks.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 04, 2022, 08:52:32 PM
Quote from: ML700D on March 22, 2022, 02:30:44 PM
just a bit suggestion, in MLVapp sidebar I think it's better to put profile tab and lut tab above processing tab
so we don't have to scrolling up and down when choosing different profile or enable creative adjustment and lut.
this is more convenient I think.
That will be different for each user. But things like a LUT or a profile normally can be adjusted once for an entire project. Then Ctrl+C, Ctrl+A & Ctrl+V. ;)

Quote from: ML700D on April 02, 2022, 02:49:05 PM
is there an easy way to compile mlvapp?
I couldn't compile using qt6 and got an error like no "make" or "qmake" something like that..
It is very easy to compile MLVApp (if not on Apple Silicon). You must install Qt5 (e.g. 5.15.2) - not Qt6. MLVApp is not compatible to Qt6 and probably will never be. For further instructions, see:
https://github.com/ilia3101/MLV-App#compiling-collision

After Qt5 installation, on macOS the entire compile process looks like this (on other OS more or less the same appart from compiler name):
https://www.youtube.com/watch?v=sUry4Oc4wq8
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on April 05, 2022, 06:29:27 PM
thanks a lot masc! 🥳

I will try it later...
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: arrinkiiii on April 19, 2022, 10:42:00 PM
Hi MLV friends, long time...

I have some doubts about the the process with the MLV´s in MLV App. I search in the forum and ready a lot but didnt get out my doubts. Maybe some one can help me on this.

So, i recorded some footage in 10bits raw in my good and trust Canon 5D iii

     
    1- I Use the MLV App, that is amazing, to output to ProRes 4444. Then wend i open in premiere i saw banding in the footage. If
         it's in 10 bits and in ProRes 4444 shouldn't see any kind of banding in the footage, right? What im doing wrong?

    2- After this, I export the same footage in CinemaDNG Lossless, and the banding disappeared. Great, very happy. But... wend i import the CinemaDNG footage in Premiere the colores are one thing. Wend i import the CinemaDNG in after effects they are other thing.

        I see in premiere the colores are a little bit more washed and looks like the image are not so sharp. In after effects the colores are more saturated and looks like the footage are more sharp. 
   
Any advice one this? Any help would be good on this.

Thanks for all of the Magic Lantern  :)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on April 19, 2022, 11:34:12 PM
Quote from: arrinkiiii on April 19, 2022, 10:42:00 PM
So, i recorded some footage in 10bits raw in my good and trust Canon 5D iii
         1- I Use the MLV App, that is amazing, to output to ProRes 4444. Then wend i open in premiere i saw banding in the footage. If
         it's in 10 bits and in ProRes 4444 shouldn't see any kind of banding in the footage, right? What im doing wrong?
Banding occurs all the time in 10-bit footage, but it usually isn't perceptible.  Please post/link the banded 10-bit footage.

Quote from: arrinkiiii on April 19, 2022, 10:42:00 PM
    2- After this, I export the same footage in CinemaDNG Lossless, and the banding disappeared. Great, very happy. But... wend i import the CinemaDNG footage in Premiere the colores are one thing. Wend i import the CinemaDNG in after effects they are other thing.
        I see in premiere the colores are a little bit more washed and looks like the image are not so sharp. In after effects the colores are more saturated and looks like the footage are more sharp.
The difference in colors between Premiere and After Effects could be caused by a number of things, and they could probably be matched by changing settings in one or both of the programs.  The difference in sharpness could be sharpening and/or contrast settings.  The "washed" look means less contrast and, likely, less sharpness and less saturation. 

Perhaps After Effects is applying filtration/effects.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 20, 2022, 07:54:31 AM
10bit RAW is a complete different thing than 10bit ProRes. With 10bit RAW there are just a few tones in dark areas, so getting banding is very easy. Better use 12 or 14 bit RAW to avoid this.

Premiere has no real RAW engine - it just shows the DNG "somehow". While AfterEffects uses the Adobe ACR RAW engine. Use AE if you like Adobe colors with RAW footage!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on April 20, 2022, 09:05:53 AM
Quote from: arrinkiiii on April 19, 2022, 10:42:00 PM
I have some doubts about the the process with the MLV´s in MLV App.
All your issues are not related to MLV App processing at all.

Two previous posters are right.

If you intend to work with DNGs use appropriate software with good debayer, e.g. after effects, resolve, maybe lightroom (very slow workflow), etc...

Do not use 10bit raw! It sucks in comparison to 14 or even 12 bit. 5d3 can easily handle realtime 14bits.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: arrinkiiii on April 20, 2022, 09:20:41 PM
Hello my friends, thank you so much for the supporting. Now i can understand "everything", the meaning of life...

I just can say this, DAMN, i just recorded everything in 10bits raw. I thought that you didn't see a big difference between 10bits and 12/14 bits raw.

Indeed, ACR from Adobe is amazing for debayer CinemaDNG's that i pull off from MLV App. 



-Photo from 10bits raw, transcoded with MLV App to ProRes 4444. You can see the banding in the left side.

https://photos.app.goo.gl/83kN7hHCecCmR9Ky5



-Photo from 10bits raw, transcoded with MLV App to CinemaDNG and open/import directed to Premiere. Don't show up banding but soft, not so sharp.

https://photos.app.goo.gl/7T6ocdcChfHMTPEL9



-Photo from 10bits raw, transcoded with MLV App to CinemaDNG and open/import to After Effects and use ACR, very power raw engine. More crispy/sharp image.

https://photos.app.goo.gl/BA8gBrDjEVK2xGWB9



The company Autokroma have a plugin to open CinemaDNG from BlackMagic cameras, i tested with CinemaDNG from MLV App but only show up the slider of white Balance and Exposure. I tested against Lumetri and notice no difference.

Sooo... Next time i will shot 14bits raw and then convert to ProRes 4444 in MLV App and hope everything will be better  : ) By the way, anyone knows the comparison of the raw from MLV and other cameras? In the past a few cameras have this option like Arri or Red, nowadays almost all cameras can record a flavor of raw. 

Thank you one more time for the help. That Magic Lantern Lives For Ever  8)

Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on April 21, 2022, 10:26:40 AM
could you post samples from the same clip? because on last two you have background in focus, while on first it is not..
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Leszek Wysocki on April 21, 2022, 11:01:44 AM
Quote from: Danne on December 06, 2021, 11:12:30 AM
Recent notes when compiling on Monterey(I think it´s 12.1).
Finally managed to compile Mlv App on my arm64 M1 pro, 10 core machine. Starting out with a lot of help from @masc and his post where he published this link about getting qt 5 working with arm64 M1.

I am using the MLV App version for the arm64 M1 processors. On the basic macbook pro 16 m1, it is three times faster than the official version (the latest one is available on the website), unfortunately, after selecting the Apple ProRess 422 codec and avfoundation, the file is not created correctly (its size is zero). Perhaps this is an issue to tweak in the appropriate build, but I used this setting (Apple ProRess 422 and avfoundation) on the previous Intel Macbook 15 and didn't notice any performance improvement during compression so I don't know if the topic is worth paying attention to. I also noticed that on the same laptop with intel, the official version of MLV App works much faster under windows (bootcamp).
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on April 21, 2022, 11:02:33 AM
Quote from: Skinny on April 21, 2022, 10:26:40 AM
could you post samples from the same clip?
+1. Gonna be nice, cut original MLV with mlvapp.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: arrinkiiii on April 21, 2022, 12:30:03 PM
Hi,

They are from the same clip, the 3 photos, maybe not from the same frame. I can send the MLV if you guys want.


I just install the version that have 14bits lossless compression. Is this better that 10 or 12bits?

Many thanks
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Bender@arsch on May 04, 2022, 02:44:59 PM
There is maybe a problem with deleting cardspanning Raw files. In my Case MLVapp crashes and delete only one file (MLV file, not the second).

Tested on Windows.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 04, 2022, 09:29:24 PM
Cannot reproduce on my computers. Maybe you could debug this problem and tell us the line where the app crashes?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Bender@arsch on May 05, 2022, 02:26:29 PM
Sry, but I don't know how this works. But I'm mean "deleting from disk", maybe this will helps.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 05, 2022, 08:35:30 PM
Quote from: Bender@arsch on May 05, 2022, 02:26:29 PM
But I'm mean "deleting from disk", maybe this will helps.
I understood what you did... but if I do the same on my computers, there is no crash and the files to be deleted can be found in trash. Best is to debug on computers which show this error. Here I can't do anything, as long as I can't reproduce.

Quote from: Bender@arsch on May 05, 2022, 02:26:29 PM
Sry, but I don't know how this works.
That is quite easy. Installation procedure:
https://github.com/ilia3101/MLV-App#qt-app-windows

Compiling: This is on macOS. But on Windows it is 99% the same.
https://youtu.be/pmngCFQzFdo
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 17, 2022, 06:42:42 AM
I am optimizing my old desktop with a P8B75M socket 1155 MO.
The old i3 gave the performance of about 45 minutes per min UHD 1x3 mlv footage from 650D.
Changing the import and export folders from an internal SATA2 HDD to an internal SATA2 SSD does not have any improvement.
Changing the cpu from i3 to a Xeon E3-1270V2 improves about twice, now about 20 minutes per min UHD 1x3 mlv footage from 650D.
Will test if the NVME SSD on the PCIE 2.0 X4 improves the speed. Maybe not due to the experience from HDD vs SSD.

Update:
NVME M2 Samsung 970 1 TGB with an IO Crest adapter on PCIE 2.0 X4 does not improve the speed.

So cpu cores is the only critical factor for mlv app processing time. IO RW speed seems not the the bottleneck.
I checked in resource monitor that every cpu thread is 100% full even when one mlv app instance is running.
The only way to shorten the processing time is to have a latest advanced 16 core or 32 core AMD Ryzen workstation, which is expensive, or have a rendering farm comprised of several powerful and power consuming old dual cpu workstations.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 17, 2022, 09:51:03 PM
The calculation is easy: if your footage has maybe 50MB/s and MLVApp shows it realtime, your disk must have a minimum read speed of 50MB/s. That is not much. On CPU side you'll need a ~ QuadCore 2.5GHz on macOS and Linux and a faster machine with Windows for realtime processing. MLVApp processes 100% on CPU - so yes... it is all about the CPU if you want a fast processing. And about an OS which brings this power to the application.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 18, 2022, 03:56:24 AM
Quote from: masc on May 17, 2022, 09:51:03 PM
The calculation is easy: if your footage has maybe 50MB/s and MLVApp shows it realtime, your disk must have a minimum read speed of 50MB/s. That is not much. On CPU side you'll need a ~ QuadCore 2.5GHz on macOS and Linux and a faster machine with Windows for realtime processing. MLVApp processes 100% on CPU - so yes... it is all about the CPU if you want a fast processing. And about an OS which brings this power to the application.

Thanks for the explanation, MASC. This makes sense.

Intel® Xeon® Processor E3-1270 v2 is quad core cpu; Processor Base Frequency. 3.50 GHz ; Cache. 8 MB Intel® Smart Cache ; Bus Speed. 5 GT/s ; TDP. 69 W. If on linux this cpu can give a realtime processing, this means that on Windows 8.1 the processing time is 20 times slower by my experiments. I will definitely try to set up linux boxes for raw processing improvement.

I will build a render farm using my old servers. Probably will be 8 cpu 64 core xeon e5-2670 totally. All of the workstations will be linux based, except the master desktop is windows 8.1 based. The master is not a true cluster master, just copying files to other workstations manually. It will take some time to build up and test. Finally, I think the planned render farm will render 1 h per h of UHD 1X3 from 650d, or 5 h per h of 3.5k 1x1 dual iso from 5d3. It may take about 20 to 30 dollars electricity by my city's rate per h of 3.5 k 1x1 dual iso footage.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 18, 2022, 08:20:54 AM
20 times slower? So you get 1-2fps? With default settings? There must be something very wrong.
With "render" you mean export? Note: exporting is processing + ffmpeg encoding. Encoding might be again slow in dependency to used codec and codec settings. When testing just MLVApp processing, playback the clip. There is a FPS counter which shows how fast processing is. On a iMac 2011 I get around 23fps for 1856x1044 uncompressed. On 2020 MacBookAir M1 I get 50fps for a FullHD clip. On a Windows 10 Core i7 3.4GHz I get 13fps for FullHD.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 18, 2022, 03:36:59 PM
Quote from: masc on May 18, 2022, 08:20:54 AM
20 times slower? So you get 1-2fps? With default settings? There must be something very wrong.
With "render" you mean export? Note: exporting is processing + ffmpeg encoding. Encoding might be again slow in dependency to used codec and codec settings. When testing just MLVApp processing, playback the clip. There is a FPS counter which shows how fast processing is. On a iMac 2011 I get around 23fps for 1856x1044 uncompressed. On 2020 MacBookAir M1 I get 50fps for a FullHD clip. On a Windows 10 Core i7 3.4GHz I get 13fps for FullHD.

Hello, MASC. Thanks for your reply.
What I mean "rendering" is to export in h264 high quality (I suppose 8 bit) in mp4 format. Sorry for the misunderstanding.
I just tested quickly the mlv app appimage on one of my linux machines, which uses a low passmark amd athlon 5350 dual core apu. The export takes about 80 minutes per min of UHD 1x3 mlv footage. Considering this does not have hyperthreading like an i3, it is very possibly true that Linux exporting speed is similar to Windows, maybe a little bit faster, but not much.

Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 18, 2022, 03:46:14 PM
Quote from: masc on May 18, 2022, 08:20:54 AM
20 times slower? So you get 1-2fps? With default settings? There must be something very wrong.
With "render" you mean export? Note: exporting is processing + ffmpeg encoding. Encoding might be again slow in dependency to used codec and codec settings. When testing just MLVApp processing, playback the clip. There is a FPS counter which shows how fast processing is. On a iMac 2011 I get around 23fps for 1856x1044 uncompressed. On 2020 MacBookAir M1 I get 50fps for a FullHD clip. On a Windows 10 Core i7 3.4GHz I get 13fps for FullHD.

I just tested the playback counting. UHD 1X3 12 bit lossless AR 16-9 24 FPS from 650D with audio.
On my Windows 8.1 desktop, Intel Xeon E3-1270 V2 quad core 3.5 GHz, 32 GB DDR3, NVME 1TGB, the playback is about 3 fps, sometimes 2 fps.
On my Ubuntu desktop, AMD Athlon 5350 APU dual core, 16 GB DDR3, SATA2 SSD 256 GB, the playback is 1 fps.
I used all of the default settings, so it is neat processing.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 18, 2022, 03:49:14 PM
80min??? What the hell...
MacBookPro 2018 with i7 2.7GHz: 1min of 4K 1x3 footage to H.264 "high" takes 13:30min with MLVApp default settings. Playback is at 24fps (around 34fps with framerate override). And that is not fast, compared to the passively cooled M1. Do you export with default settings, or do you enable time consuming features in edit or export area? 1-3fps is very strange... even my MacBook from 2010 with Core2Duo is faster.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 18, 2022, 07:36:48 PM
Quote from: masc on May 18, 2022, 03:49:14 PM
80min??? What the hell...
MacBookPro 2018 with i7 2.7GHz: 1min of 4K 1x3 footage to H.264 "high" takes 13:30min with MLVApp default settings. Playback is at 24fps (around 34fps with framerate override). And that is not fast, compared to the passively cooled M1. Do you export with default settings, or do you enable time consuming features in edit or export area? 1-3fps is very strange... even my MacBook from 2010 with Core2Duo is faster.

Maybe UHD 1x3 playback is slow? I do not know. I use all default settings just now for playback checking to avoid the setting related issues.
Maybe I will try 1080P footage later to see if the results are better.

Or maybe because the video card?
I apply a 2g vram card on the windows desktop and the apu's gpu on the linux desktop. I know they are very basic.
I thought that mlv app does not use vram or high end video card cuda. If video card is the issue, I will buy better cards once the supply is normal.

Thanks very much for your help on trouble shooting, MASC.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 18, 2022, 08:05:31 PM
Quote from: masc on May 18, 2022, 03:49:14 PM
80min??? What the hell...
MacBookPro 2018 with i7 2.7GHz: 1min of 4K 1x3 footage to H.264 "high" takes 13:30min with MLVApp default settings. Playback is at 24fps (around 34fps with framerate override). And that is not fast, compared to the passively cooled M1. Do you export with default settings, or do you enable time consuming features in edit or export area? 1-3fps is very strange... even my MacBook from 2010 with Core2Duo is faster.

For exporting experiments, in addition to normal adjustment of exposure, contrast, saturation, vibrance, I also did some adjustment of HSL modules, maybe this caused some time. But from my previous experience, without any adjustment, the exporting time was 30 minutes per minute UHD 1X3 on the old i3 socket 1155. Assuming xeon e3-1270 v2 is twice faster, so it will be 15 minutes. Assuming the amd 5350 is twice slower, so it will be 60 minutes.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 19, 2022, 01:27:51 AM
Quote from: masc on May 18, 2022, 03:49:14 PM
80min??? What the hell...
MacBookPro 2018 with i7 2.7GHz: 1min of 4K 1x3 footage to H.264 "high" takes 13:30min with MLVApp default settings. Playback is at 24fps (around 34fps with framerate override). And that is not fast, compared to the passively cooled M1. Do you export with default settings, or do you enable time consuming features in edit or export area? 1-3fps is very strange... even my MacBook from 2010 with Core2Duo is faster.

I copied the same UHD 1X3 12 bit lossless footage to my MacBook Air 2020, M1, 8 GB. Downloaded MLV App 1.13 App Image. The playback is 13 fps most of the time, but unstable. Export setting is H264 HQ mp4, export time is about 20 minutes per min footage. All settings are default. Is it possible that the footage has details so delaying the processing? The performance is not as good as yours, maybe 50%?
I suspect that MLV App needs a good video card somehow even though it does not use CUDA. I have to wait for several months to buy some good video cards, because the Asian supply is compromised now.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 19, 2022, 09:41:59 AM
On M1 please use the Apple Silicon version of MLVApp. This one is much faster than Intel version on M1. Link for experimental version can be found some pages before in this thread.

MLVApp doesn't need any video card and runs on CPU only. That's the reason it works on nearly any computer of the past >10 years.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 19, 2022, 09:06:27 PM
Quote from: masc on May 19, 2022, 09:41:59 AM
On M1 please use the Apple Silicon version of MLVApp. This one is much faster than Intel version on M1. Link for experimental version can be found some pages before in this thread.

MLVApp doesn't need any video card and runs on CPU only. That's the reason it works on nearly any computer of the past >10 years.

Thanks a lot for the tip, MASC. I will try the Apple Silicon version. Best regards,
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 19, 2022, 09:54:45 PM
Quote from: masc on May 19, 2022, 09:41:59 AM
On M1 please use the Apple Silicon version of MLVApp. This one is much faster than Intel version on M1. Link for experimental version can be found some pages before in this thread.

MLVApp doesn't need any video card and runs on CPU only. That's the reason it works on nearly any computer of the past >10 years.

Hello, MASC. A quick question: Will MLV App Apple Silicon version have the same performance on Hackingtosh with DIY Intel Xeon workstation/server? 
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 19, 2022, 09:58:39 PM
MLVApp Apple Silicon version: was compiled for ARM64 and runs on Apple Silicon ONLY. It won't run on any other CPU architecture.
MLVApp official macOS version: was compiled for Intel and runs on both, Intel & Apple Silicon (via Rosetta, which consumes around 50% of CPU power).
Source code is identical for both versions. (appart from the commits done since last official release...)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 20, 2022, 12:29:45 AM
Quote from: masc on May 19, 2022, 09:58:39 PM
MLVApp Apple Silicon version: was compiled for ARM64 and runs on Apple Silicon ONLY. It won't run on any other CPU architecture.
MLVApp official macOS version: was compiled for Intel and runs on both, Intel & Apple Silicon (via Rosetta, which consumes around 50% of CPU power).
Source code is identical for both versions. (appart from the commits done since last official release...)

Thanks, MASC. If I set up my workstation as dual Xeon E5-2670 socket LGA2011, 128 GB RAM, which OS do you think is better, Ubuntu or Hackingtosh for MLV App macOS version?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 20, 2022, 03:43:47 AM
Computer: MO P8B75M, Socket 1155
CPU: E3-1270 V2, 4 core no hyperthreads
RAM: 32 GB DDR3
VRAM: 2GB
OS: Windows 8.1
App: MLV App 1.13
Setting: default
Export: mp 4 h264 hq


Footage from 5D3
1. Anomorphic 1x3, 1920x2340, 14 bit lossless, 24 fps, playback 5 fps, export time 25 min/min footage
2. 3.5k 1x1, AR 2.67, 14 bit lossless, 24 fps, playback 5 fps, export time 10 min/min footage
3. 3.2k 1x1, AR 16-9, 10 bit lossless, 24 fps, playback 4 fps, export time 10 min/min footage
4. 3k 1x1, 1920x1920 AR 1:1, 14 bit lossless, 24 fps, playback 6 fps, export time 7 min/min footage

Footage from 650D
5. UHD 1x3, AR 16-9, 12 bit lossless, 24 fps, playback 6 fps, export time 12 min/min footage
6. Movie crop mode, 1800X1000, AR 16-9, 14 bit lossless, 24 fps, playback 9 fps, export time 4 min/min footage (This is the closest to 2k 1x1 in my previous tests, used as a baseline here. My previous experience of 2k 1x1 was 10 minutes per min footage on an i3 cpu, very possibly 5 minutes on this quad core cpu.)

So, 5.7K 1x3 is about 5 times slower than the 2k 1X1, 3.5k 1x1 about 2 times slower. UHD 1X3 is almost the same as 3.5k 1x1, about 20% slower. 5.7K 1x3 is about 2 times slower than the UHD 1X3.

A render farm composed of 4 dual cpu Xeon E5-2670 workstations with 16 cores each using Ubuntu LTS may do 1 hour processing time per hour 5.7k 1x3 footage. Electricity bill may be 10 dollars per hour 5.7k 1x3 footage. This kind of render farm makes 5.7k 1x3 ml raw processing practical. An equivalent spec Mac Pro may be $15k to $20k, if DIY with AMD Ryzen CPUs, may still be $7k to $10k.

Hope the dual ISO processing be multithreading in the near future, this kind of render farm will make dual ISO footage routine too.


Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 20, 2022, 05:52:20 PM
1min RAW 1x3 5.7K (1920x2340) 24fps on M1 MacBookAir:
- playback 11fps
- export with ffmpeg to 5760x2340 H.264 high with MLVApp default: 14:20min
- export with AVFoundation to 5760x2340 H.264 with MLVApp default: 11:00min

1min RAW 1856x1044 25fps on M1 MacBookAir:
- playback 50fps
- export with AVFoundation to 1856x1044 H.264 with MLVApp default (AMaZE): 1:20min (edited: 1:00min was wrong here, measured again, so no realtime)
- export with AVFoundation to 1856x1044 H.264 with MLVApp default (bilinear): 0:30min (more than realtime, good enough as proxy)

1min RAW 1x3 1440x1836 24fps on M1 MacBookAir:
- playback 21fps (with alexa log-c preset 24fps)
- export with AVFoundation to 4320x1836 H.264 with MLVApp default: 5:20min
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 20, 2022, 06:34:40 PM
Quote from: masc on May 20, 2022, 05:52:20 PM
1min RAW 5.7K 24fps on M1 MacBookAir:
- playback 11fps
- export with ffmpeg to 5760x2340 H.264 high with MLVApp default: 14:20min
- export with AVFoundation to 5760x2340 H.264 with MLVApp default: 11:00min

1min RAW 1856x1044 25fps on M1 MacBookAir:
- playback 50fps
- export with AVFoundation to 1856x1044 H.264 with MLVApp default: 1:00min --> Realtime export

This is really good, considering the electricity bill is almost negligible.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 20, 2022, 09:22:28 PM
Hello, MASC. Just a quick thought.
Is it possible to add a new tab in MLV App for 1x3 processing. This way the workflow is optimized for 1x3 footage, the sharpening can be put anywhere it is proper.
Not sure if this is practical.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 20, 2022, 09:29:59 PM
What do you mean with "optimized"?! What should be different for 1x3? MLVApp is optimzied for all options we have - as good as we can ;)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 20, 2022, 10:45:30 PM
Quote from: masc on May 20, 2022, 09:29:59 PM
What do you mean with "optimized"?! What should be different for 1x3? MLVApp is optimzied for all options we have - as good as we can ;)

The sharpening right now is good for 1x1, not for 1x3?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 20, 2022, 10:58:23 PM
I recommend to sharpen 1x3 footage (if neccessary at all) in NLE after MLVApp export. For an improvement inside MLVApp we don't need a 1x3 optimization option - we would need a complete rewrite with a different conecpt.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 20, 2022, 11:42:03 PM
Quote from: masc on May 20, 2022, 10:58:23 PM
I recommend to sharpen 1x3 footage (if neccessary at all) in NLE after MLVApp export. For an improvement inside MLVApp we don't need a 1x3 optimization option - we would need a complete rewrite with a different conecpt.

OK. It is not as simple as I thought. Thanks for the explanation.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 21, 2022, 12:39:38 PM
Apple ARM M1 is an 8 core cpu with a typical tdp of 15w, passmark 15000, single thread 4000.
Intel Xeon E3-1270 V2 is a 4 core 8 thread cpu with a tdp of 70w, passmark 6000, single thread 2000.
The hardware does not explain the difference of 4 folds in full hd exporting speed, about 2 folds to 2.5 folds.
Maybe the mlv app is more optimized for the Apple hardware?


Intel i3-3240 is a 2 core 4 thread cpu with a tdp of 55w, passmark 2300, single thread 1800.
AMD Athlon 5370 is a 4 core 4 thread cpu with a tdp of 25w, passmark 2000, single thread 750.
Both has similar passmark and 4 threads, yet i3 3240 is about twice faster than athlon 5370. The single thread performance is 2.5 folds, is the single thread performance the key here? If so, it can not explain the two folds difference between E3-1270v2 and i3-3240.
Probably the low level C libraries are more tuned to the Intel structure than to the AMD's?

Probably the passmark is not a good criteria here?

Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 21, 2022, 12:52:29 PM
Rendering on macOS has always been faster than on Windows. When I compare some of my systems: a dualcore i5 2.4GHz with macOS has a similar performance like a quadcore i7 3.4GHz with Win10.
There is no optimization for certain systems in MLVApp. The code is identical (appart from AVFoundation export which is Apple only and post export scripts) for all OS. The only difference are the compilers and the operating system itself.
On Linux I saw very similar performance to macOS, but I don't use this really.
The code is open source and online. If you find optimized compilers for some CPU architecture: please try if you get more performance. Compiling is very easy.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 21, 2022, 12:55:57 PM
Quote from: masc on May 21, 2022, 12:52:29 PM
Rendering on macOS has always been faster than on Windows. When I compare some of my systems: a dualcore i5 2.4GHz with macOS has a similar performance like a quadcore i7 3.4GHz with Win10.
There is no optimization for certain systems in MLVApp. The code is identical (appart from AVFoundation export which is Apple only and post export scripts) for all OS. The only difference are the compilers and the operating system.
On Linux I saw very similar performance to macOS, but I don't use this really.

Maybe the MacOS and Linux kernels are more efficient. I remember that MacOS later versions use Linux kernel, not sure if it is still so on Arm M1 MBA.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 21, 2022, 01:01:38 PM
Quote from: mlrocks on May 21, 2022, 12:55:57 PM
Maybe the MacOS and Linux kernels are more efficient. I remember that MacOS later versions use Linux kernel, not sure if it is still so on Arm M1 MBA.
This is what I think. macOS is based on unix OS family.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 21, 2022, 01:09:28 PM
Better avoid AMD cpus and video cards. Something I was not aware before.

https://news.ycombinator.com/item?id=21628713
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on May 21, 2022, 05:16:01 PM
Quote
I remember that MacOS later versions use Linux kernel
MacOS has never had a Linux kernel.

Quote
Better avoid AMD cpus and video cards. Something I was not aware before.
Please don't give completely unfounded advice.  This is just untrue.  It's probably the *opposite* of true for MLVApp, which is heavily threaded; current Zen based AMD CPUs normally beat Intel (and Apple M1) based systems in multi-threaded workloads.

Don't guess.  Don't assume benchmarks *on a different piece of software* will be representative.  Benchmarking is notoriously complicated.  Benchmark using MLVApp on different systems; it's free and available on all OSes!  If somebody gives me an MLV file and instructions, I'll bench on my modern 8c/16t AMD Linux system.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 21, 2022, 08:08:32 PM
Quote from: names_are_hard on May 21, 2022, 05:16:01 PM
MacOS has never had a Linux kernel.
Please don't give completely unfounded advice.  This is just untrue.  It's probably the *opposite* of true for MLVApp, which is heavily threaded; current Zen based AMD CPUs normally beat Intel (and Apple M1) based systems in multi-threaded workloads.

Don't guess.  Don't assume benchmarks *on a different piece of software* will be representative.  Benchmarking is notoriously complicated.  Benchmark using MLVApp on different systems; it's free and available on all OSes!  If somebody gives me an MLV file and instructions, I'll bench on my modern 8c/16t AMD Linux system.

I agree with you that maybe passmark is not very suitable for the mlv app. Maybe using MLV App is a better way for benchmarking. I am converting almost of all of my home systems for MLV App now, so it makes sense to use it as the benchmarking criteria.

I DIYed my first video/gaming AMD desktop about 8 years ago, with Sabertooth 990FX tough mo, Athlon FX8350 overclocked, AMD R9 295X2 8GB video card, 32GB DDR3 RAM, SATA3 SSD. At the time it was extremely powerful. I enjoyed 2k gaming long before it becomes main stream. Rawtherapee raw photo editing was totally real time on this system. The set up will cost twice higher if using Intel ecosystem, 5 times higher if using Mac Pro. The system went dead after several years of intensive use. I think that it was my fault, not optimizing the air flow well enough, even there were a liquid cooling system for the cpu and a separated one for the video card.

Anyways, I like AMD's lower price. I am very happy that AMD is leading Intel now. But I recently realize that AMD upgrading path overhead room is not as much as Intel based mother board. Also, I just realize that AMD CPU and GPU is not well supported by low level compilers. As an end user, I really hope AMD can address these two main issues, so that I can build my new system Zen4 or Zen 5 based. Cheers,
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 21, 2022, 08:09:23 PM
Duplicated. Deleted.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on May 21, 2022, 08:40:09 PM
Quote
Also, I just realize that AMD CPU and GPU is not well supported by low level compilers

This is not true.  The article you linked to was about a specific *Intel* library that *Intel* deliberately made to be poorly optimised for AMD CPUs.  It has no relevance to "low level compilers".  Only one specific Intel library.  MLV App isn't even using that library!  Compilers optimise just fine on AMD.

Benchmarking is always quite tricky.  Since we can run MLVApp anywhere, when you're interested in MLVApp performance, it's the obvious best choice to use.  Ideally, script running MLVApp, always with the same input file, processing options etc.  That way you can get reproducible results, and you can share the script with other people so they can test on their systems.  It would be cool to see a set of results across a lot of different systems.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 21, 2022, 08:57:02 PM
Quote from: names_are_hard on May 21, 2022, 08:40:09 PM
This is not true.  The article you linked to was about a specific *Intel* library that *Intel* deliberately made to be poorly optimised for AMD CPUs.  It has no relevance to "low level compilers".  Only one specific Intel library.  MLV App isn't even using that library!  Compilers optimise just fine on AMD.

Benchmarking is always quite tricky.  Since we can run MLVApp anywhere, when you're interested in MLVApp performance, it's the obvious best choice to use.  Ideally, script running MLVApp, always with the same input file, processing options etc.  That way you can get reproducible results, and you can share the script with other people so they can test on their systems.  It would be cool to see a set of results across a lot of different systems.

For MLV App parameters, for benchmark testing, I set all for default, export to h264 mp4 high quality, which can be imported by Blender VSE.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on May 22, 2022, 07:27:53 AM
Quote from: names_are_hard on May 21, 2022, 08:40:09 PMIt would be cool to see a set of results across a lot of different systems.
I like this idea, we need to find some nice short MLV so anyone can benchmark and share the result.. And later it can be used to measure how certain processing algorithms behave on different systems.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on May 22, 2022, 05:39:28 PM
Quote from: Skinny on May 22, 2022, 07:27:53 AM
I like this idea, we need to find some nice short MLV so anyone can benchmark and share the result.. And later it can be used to measure how certain processing algorithms behave on different systems.

Blast from the past: https://www.magiclantern.fm/forum/index.php?topic=18999.0
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: dream951 on May 23, 2022, 08:16:13 AM
Quote from: masc on May 20, 2022, 05:52:20 PM
1min RAW 1x3 5.7K (1920x2340) 24fps on M1 MacBookAir:
- playback 11fps
- export with ffmpeg to 5760x2340 H.264 high with MLVApp default: 14:20min
- export with AVFoundation to 5760x2340 H.264 with MLVApp default: 11:00min

1min RAW 1856x1044 25fps on M1 MacBookAir:
- playback 50fps
- export with AVFoundation to 1856x1044 H.264 with MLVApp default (AMaZE): 1:20min (edited: 1:00min was wrong here, measured again, so no realtime)
- export with AVFoundation to 1856x1044 H.264 with MLVApp default (bilinear): 0:30min (more than realtime, good enough as proxy)

1min RAW 1x3 1440x1836 24fps on M1 MacBookAir:
- playback 21fps (with alexa log-c preset 24fps)
- export with AVFoundation to 4320x1836 H.264 with MLVApp default: 5:20min

Hello masc!
My laptop has an RTX2060, which supports export via ffmpeg to h265_nvenc, which gives a multiple increase in performance. I tested it in Fast CinemaDNG Processor - the result is very good. If you make the export settings in mlvapp also in h265_nvenc, will it give a performance boost or is it because fastcinema has a different mlv/cdng export algorithm?
Thanks!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 23, 2022, 09:01:10 AM
Quote from: dream951 on May 23, 2022, 08:16:13 AM
My laptop has an RTX2060, which supports export via ffmpeg to h265_nvenc, which gives a multiple increase in performance. I tested it in Fast CinemaDNG Processor - the result is very good. If you make the export settings in mlvapp also in h265_nvenc, will it give a performance boost or is it because fastcinema has a different mlv/cdng export algorithm?
Unfortunately I can't add this with any of my computers as I don't have any computer with NVidia graphic cards. So this won't work here - some as "Fast CinemaDNG Processor" which doesn't work on any of my computers. But the code is opensource and it isn't difficult to add this into a MLVApp experimental branch, if you like.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on May 23, 2022, 12:28:01 PM
Quote from: dream951 on May 23, 2022, 08:16:13 AM
If you make the export settings in mlvapp also in h265_nvenc, will it give a performance boost or is it because fastcinema has a different mlv/cdng export algorithm?
Thanks!
Maybe or maybe not with nvenc supported ffmpeg (encoding only). CDNG export will not be accelerated at all.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on May 23, 2022, 12:31:57 PM
Quote from: names_are_hard on May 21, 2022, 08:40:09 PM
It would be cool to see a set of results across a lot of different systems.
Absolutely agree.

Once in 2018 I benched mlvapp playback (no export) on 160core (4CPU) Xeon system and ... well have a look yourself:
Link (https://bouncyball.myweb.ge/mlvapp/?dir=&download=160thread_test-2018-12-07_19.33.57.mp4)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: dream951 on May 23, 2022, 08:47:54 PM
Quote from: bouncyball on May 23, 2022, 12:28:01 PM
Maybe or maybe not with nvenc supported ffmpeg (encoding only). CDNG export will not be accelerated at all.
I also thought that encoding from CDNG would be the bottleneck of this process.
Thanks!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: dream951 on May 23, 2022, 08:49:01 PM
Quote from: masc on May 23, 2022, 09:01:10 AM
Unfortunately I can't add this with any of my computers as I don't have any computer with NVidia graphic cards. So this won't work here - some as "Fast CinemaDNG Processor" which doesn't work on any of my computers. But the code is opensource and it isn't difficult to add this into a MLVApp experimental branch, if you like.
It's a pity that I'm not good at coding and I can't help you in any way:(
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 23, 2022, 10:51:35 PM
Quote from: bouncyball on May 23, 2022, 12:31:57 PM
Absolutely agree.

Once in 2018 I benched mlvapp playback (no export) on 160core (4CPU) Xeon system and ... well have a look yourself:
Link (https://bouncyball.myweb.ge/mlvapp/?dir=&download=160thread_test-2018-12-07_19.33.57.mp4)

160 threads xeon quad cpu server/workstation only gave 8 fps playback with default settings? What was the video card on this system?
it seems to me that playback is more video card dependent than cpu dependent. Exporting is for sure cpu dependent.
Otherwise, how can we explain 160 threads xeon machine only gave 8 fps, whereas mba m1 gives faster fps? I don't think m1 has so vastly improved on cpu speed, but on power saving.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on May 24, 2022, 12:41:43 AM
Quote from: names_are_hard on May 21, 2022, 08:40:09 PM
It would be cool to see a set of results across a lot of different systems.
Quote from: bouncyball on May 23, 2022, 12:31:57 PM
Absolutely agree.

I suggest someone to record few MLV clips in different resolutions/modes and upload them somewhere. To be used for benchmarking by users by exporting the clips in some compressed codecs like H2.64 and ProRes and *writing down processing time for each clip, then posting results in a dedicated thread in the forum (or maybe create a section in mlv.app domain for posting results in an organized way).

*Could we implement function in MLVApp that saves MLV info, used codec, system info and processing time for each MLV clip to a log file? that's could be useful too.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on May 24, 2022, 01:00:21 AM
Quote from: mlrocks on May 23, 2022, 10:51:35 PM
160 threads xeon quad cpu server/workstation only gave 8 fps playback with default settings? ..

Single thread performance seems much more important than multi threaded for playback. e.g. the lowest M1 Macbook destroys my Ryzen 3900x in terms of single thread performance (~30% faster) --> M1 has faster playback speed.
I can do some playback/exporting tests if there some unified MLV clips so other users can also make same tests with same clips on their systems.

@masc You have shot some amazing clips before using 5D3/EOS M, it would be cool if you shorten some of them and upload them somewhere (if you still have them and don't mind :) ).
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 24, 2022, 06:47:11 AM
Computer: MBA (entry model)
CPU: M1
RAM: 8GB
GPU: 7 core
OS: Latest
App: mlv app apple silicon version
https://www.dropbox.com/s/ej6ufca61ijeeyf/MLV.App.v1.13.macOS.arm64.zip?dl=0
All default settings
Export to H264 MP4 HQ

Footage: UHD 1X3 12 bit lossless from 650D
Scene: The same test scene

Performance
Playback: 18 fps most of the time, not stable
Export time: 15 minutes, calculating at the 50% of the timeline. The first several minutes the speed was not stable and time was changing. I always use the time at 50% and times 2 to get the total time.

This version is about 50% better than the MLV APP Image version.

Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 24, 2022, 07:11:05 AM
It is interesting to see that my MBA performs similarly to my Xeon E3-1270V2 desktop in exporting UHD 1X3 footage. Makes me feel good that my old desktop is not outdated yet. LOL.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on May 24, 2022, 07:13:17 AM
Quote from: mlrocks on May 23, 2022, 10:51:35 PM
I don't think m1 has so vastly improved on cpu speed, but on power saving.
Plenty to read about M1 cpu progression which explains why a "simple" iphone will outperform most(not all) intel processing units. Compiling mlv app with arm 64 makes all the difference in playback. Still mostly rosetta fallback when exporting with ffmpeg but apps are following. Resolve is already working quite nicely too on m1.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 24, 2022, 07:29:45 AM
Quote from: Danne on May 24, 2022, 07:13:17 AM
Plenty to read about M1 cpu progression which explains why a "simple" iphone will outperform most(not all) intel processing units. Compiling mlv app with arm 64 makes all the difference in playback. Still mostly rosetta fallback when exporting with ffmpeg but apps are following. Resolve is already working quite nicely too on m1.

Maybe this explains that why M1 has 3 times better playback but the same export speed.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 24, 2022, 11:24:16 AM
Just tried another workflow on MBA M1.
In MLV App Apple Silicon, export setting to cdng uncompressed, dvr file name format. Export 1 minute UHD footage is about 1 minute. The cdng folder can be opened in Davinci Resolve 17. This way DVR's CUDA capability can be utlized to shorten the process time significantly.
I know many people here already know this workflow long time ago. Just a learning experience for me.
The cdng files cannot be opened in Blender 3.1 VSE. So this workflow does not help Blender.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 24, 2022, 11:36:20 AM
DNG "export" is no real export, it is more a copy action of RAW data. You could also use MLVFS - this saves time and disk space.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on May 24, 2022, 11:49:28 AM
Also it is best to use EXR format if you want to load the files into blender...
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on May 24, 2022, 05:25:07 PM
Quote from: mlrocks on May 23, 2022, 10:51:35 PM
What was the video card on this system?
Some integrated intel GPU (don't remember Xeon model now) as every server hardware have.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on May 24, 2022, 05:33:26 PM
Quote from: theBilalFakhouri on May 24, 2022, 01:00:21 AM
Single thread performance seems much more important than multi threaded for playback.
Yup this 99% true. As I remember decoding and raw corrections of the frame happens in a separate thread but then debayering and color processing is done as multithreaded.

Quote from: theBilalFakhouri on May 24, 2022, 01:00:21 AM
@masc You have shot some amazing clips before using 5D3/EOS M, it would be cool if you shorten some of them and upload them somewhere (if you still have them and don't mind :) ).
Yeah!
@theBilalFakhouri: did you mean he was more creative while using his good, old 5d2? :D
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on May 24, 2022, 08:50:36 PM
Quote from: theBilalFakhouri on May 24, 2022, 12:41:43 AM
I suggest someone to record few MLV clips in different resolutions/modes and upload them somewhere.
And if we want to use one MLV file as "standard" for testing, it means it will be downloaded many times. And especially by the people who are new to ML, they just want to see how it looks, how it can be color graded and so on. So it's important to use something that will show ML RAW from the best side.. I think it should be:

1. Something really beautiful and not just test clips with some random stuff
2. It should look nice with default MLV App settings
3. Probably shot with 5D3 because it is the best ML raw camera for now
4. Shot using steadycam or tripod, no shaky footage obviously
5. 1920x1080 resolution because most people want at least true 1920 and at the same time file size won't be too big.
6. Filesize? ~2gb or more?

Just my thoughts.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 24, 2022, 09:02:33 PM
Computer: MBA (entry model)
CPU: M1
RAM: 8GB
GPU: 7 core
OS: Latest
App: mlv app apple silicon version
https://www.dropbox.com/s/ej6ufca61ijeeyf/MLV.App.v1.13.macOS.arm64.zip?dl=0
All default settings

Footage: UHD 1X3 12 bit lossless from 650D
Scene: The same test scene

Codec Optimization
Export to H264 MP4 HQ, ffmpeg, Export time: 15 minutes. Used as the baseline here.

Export to Prores 422 LT, ffmpeg, Export time: 12 minutes.
Export to Prores 422, ffmpeg, Export time: 8 minutes.
Export to Prores 422 HQ, ffmpeg, Export time: 10 minutes.
Export to Prores 4444, ffmpeg, Export time: 18 minutes.

All of the above codecs can be opened by the Blender VSE. If export to Prores 422, it is another two folds improvement. Maybe ProRes 422 is the most widely used and therefore the best optimized and the most mature one.


More:

AVID's codecs:
Export to DNxHD, 10 bit 1080p, frame rate override to 23.976, Export time: 6 minutes.
Export to DNxHR, 444 10 bit, Export time: 12 minutes.
Export to DNxHR, HQX 10 bit, Export time: 7 minutes.
Export to DNxHR, HQ 8 bit, Export time: 8 minutes.
Export to DNxHR, SQ 8 bit, Export time: 8 minutes.
Export to DNxHR, LB 8 bit, Export time: 7 minutes.

All of AVID's codecs can be imported in the Blender VSE.


Seems to me the best workflow for UHD 1x3 is to have camera frame rate override at 23.976 when recording, MLV App on Linux or Mac M1, Export to DNxHD 10 bit 1080p or DNxHR HQX 10 bit or LB 8 bit without even considering frame rate override to 23.976, edit in Blender VSE 3.1. For high resolution cinematic projects, DNxHR 444 10 bit encodes faster than H264 420 8 bit. AVID is the still the king of video editing.


In conclusion, using export codecs of AVID DNxHR HQX 10 bit, increases the encoding speed twice, and improves final image quality to 10 bit 422, comparing to the H264 codec. Apple's ProRes 422 is a good second choice, about 20% slower than the DNxHR HQX 10 bit. In general, AVID's codecs are efficient.



This is what Avid recommended the codecs were suitable for:

DNxHR LB - Low Bandwidth (8-bit 4:2:2) Offline Quality

DNxHR SQ - Standard Quality (8-bit 4:2:2) (suitable for delivery format)

DNxHR HQ - High Quality (8-bit 4:2:2)

DNxHR HQX - High Quality (12-bit 4:2:2) (UHD/4K Broadcast-quality delivery)

DNxHR 444 - Finishing Quality (12-bit 4:4:4) (Cinema-quality delivery)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on May 24, 2022, 10:44:43 PM
Quote from: bouncyball on May 24, 2022, 05:33:26 PM
Yup this 99% true. As I remember decoding and raw corrections of the frame happens in a separate thread but then debayering and color processing is done as multithreaded.

I don't know how MLVApp code works, never looked into it.
But in theory if we re-write the code somehow so it could utilize more threads for decoding and raw correction then we may have faster playback, would be that possible or *some parts of processing must be single threaded?

*Even if it's must be single threaded, I guess we can process multiple frames at the same time (multi processing), e.g. each frame uses one thread or two frames per thread:
First frame would be processed on CORE 0 while second frame is being processed on CORE 1 and so one for other cores, when CORE 0 finishes, it would load the next frame which we need to process.



I have ~16 FPS playback speed using MLVApp 1.13 (default settings, Bilinear debayer) on Ryzen 3900x, Clip used: UHD 1280x2160 10-bit lossless 23.976 FPS
CPU utilization: is only ~17%
Using Amaze debayer it's ~33% (~11 FPS)

I opened two copies of MLVApp, opened same clip, used default settings (Bilinear debayer), playback for each copy ~16 FPS, CPU utilization is ~35%, multi processing theory works, total ~32 FPS playback speed :D and there is 65% of CPU power left.

What I am saying in short:
There is a room for enhancement, even if this mean re-writing MLVApp from scratch. I bet someone from MLVApp team would do that :P (seems a lot of work).

That's why we should start dedicated Patreon account for MLVApp, if one (or two/all) of MLVApp team feels he can improve MLVApp but can't do it for free (fully understandable), funding is a solution for that. I think a lot of users would fund such thing beside there is no legal concerns. if MLVApp team don't want to work on MLVApp for whatever reason (again, it's fully understandable), the idea of creating Patreon account for MLVApp lives, but instead we may hire a freelancer.

Quote from: bouncyball on May 24, 2022, 05:33:26 PM
Yeah!
@theBilalFakhouri: did you mean he was more creative while using his good, old 5d2? :D

I did not mean that, just meant some beautiful MLV clips and used 5D3/EOSM as example (masc seems to have nice MLV clips, and looks good out of the box in MLVApp I guess), I forgot about masc owned 5D2 before :P, I don't think I have watched 5D2 clips from masc (or I just don't remember how it was). Of course clips from 5D2 would be ideal too, to be used for uncompressed MLV benchmarking :D
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 25, 2022, 12:43:20 AM
Quote from: theBilalFakhouri on May 24, 2022, 10:44:43 PM
I don't know how MLVApp code works, never looked into it.
But in theory if we re-write the code somehow so it could utilize more threads for decoding and raw correction then we may have faster playback, would be that possible or *some parts of processing must be single threaded?

*Even if it's must be single threaded, I guess we can process multiple frames at the same time (multi processing), e.g. each frame uses one thread or two frames per thread:
First frame would be processed on CORE 0 while second frame is being processed on CORE 1 and so one for other cores, when CORE 0 finishes, it would load the next frame which we need to process.



I have ~16 FPS playback speed using MLVApp 1.13 (default settings, Bilinear debayer) on Ryzen 3900x, Clip used: UHD 1280x2160 10-bit lossless 23.976 FPS
CPU utilization: is only ~17%
Using Amaze debayer it's ~33% (~11 FPS)

I opened two copies of MLVApp, opened same clip, used default settings (Bilinear debayer), playback for each copy ~16 FPS, CPU utilization is ~35%, multi processing theory works, total ~32 FPS playback speed :D and there is 65% of CPU power left.

What I am saying in short:
There is a room for enhancement, even if this mean re-writing MLVApp from scratch. I bet someone from MLVApp team would do that :P (seems a lot of work).

That's why we should start dedicated Patreon account for MLVApp, if one (or two/all) of MLVApp team feels he can improve MLVApp but can't do it for free (fully understandable), funding is a solution for that. I think a lot of users would fund such thing beside there is no legal concerns. if MLVApp team don't want to work on MLVApp for whatever reason (again, it's fully understandable), the idea of creating Patreon account for MLVApp lives, but instead we may hire a freelancer.

I did not mean that, just meant some beautiful MLV clips and used 5D3/EOSM as example (masc seems to have nice MLV clips, and looks good out of the box in MLVApp I guess), I forgot about masc owned 5D2 before :P, I don't think I have watched 5D2 clips from masc (or I just don't remember how it was). Of course clips from 5D2 would be ideal too, to be used for uncompressed MLV benchmarking :D

Blender adds render farm feature and multithreading and maybe 10 bit color depth editing in its latest VSE version. Blender has improved dramatically in the last five years, making it a serious option for video editing and VR creation. MLV App may consider adding render farm and improving multithreading in its future versions. ML coders and heros can set up your own render farm companies to create your own business for yourself and for the good of ML.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on May 25, 2022, 04:50:19 PM
Quote from: theBilalFakhouri on May 24, 2022, 10:44:43 PM
What I am saying in short:
There is a room for enhancement, even if this mean re-writing MLVApp from scratch. I bet someone from MLVApp team would do that :P (seems a lot of work).
Yes it surely is a lot of work. Let me explain.

Decoding/Playing engine of MLVApp is not using SDL or any other existing lib. It is written by Markus from scratch in QT with a few humble suggestions from me. This includes everything: video + audio, sync of frames with audio, frame dropping if power is insufficient etc. Just one framebuffer is filling always in the background in a separate thread.

Preparing framebuffer consists of:
* reading the raw frame from MLV according to index (easy task initially written by Ilia and optimized/enhanced by me),
* decode frame it if comressed using lib written by @Baldwin which is quite tricky to optimize further (needs deep understanding of lossless jpeg 92 compression which is used for DNG/cDNG standard),
* do raw correction if checked (darkframe subtract, stripes removal, bad/focus pixels removal, dual iso, smoothing, implemented by me, non multithreaded because it is mostly adaptation of all existing ML/MLVFS raw correction code)

Then multithreaded debayer of framebuffer is done to Camera RGB space and after converting it, for now, to rec709 color space we are ready for image processing which is also uses some multithreading.

The most time consuming parts are (fields for optimization):
* decompresion of the image (some overhead)
* raw correction (mostrly light except smoothing and dual iso, there was also pattern noise removal, disabled now)
* color processing (this is the bitch)

In theory dividing clip logically and processing each chunk in parallel should decrease exporting time but won't improve playing speed.

Writing from scratch is no option as well :P

regards
bb
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 25, 2022, 04:50:55 PM
@mlrocks: use AVFoundation instead of ffmpeg option and ProRes will be again faster (at better quality).

Quote from: theBilalFakhouri on May 24, 2022, 10:44:43 PM
I don't know how MLVApp code works, never looked into it.
But in theory if we re-write the code somehow so it could utilize more threads for decoding and raw correction then we may have faster playback, would be that possible or *some parts of processing must be single threaded?

Today MLVApp is nearly completely multithreaded. Last single threaded features:
-> RBF denoiser, highlights/shadows/clarity. All works with a recursive bilateral filter. This only works single threaded. You could exchange the recursive thing by multithreading. This makes the filter way slower, even on Octacore+.
-> DualISO. Here is much room for improvement. Anybody is invited to create a new algorithm which works faster at same or better quality. I gave up with it - I tried to multithread the current algorithm and it never worked.
-> lossless de-/compression. shouldn't be too hard to do this, but won't have much effect. Yes: uncompressed is faster than lossless footage in MLVApp - but only some single percents.

---> all other algorithms are already multithreaded. (or did I forget something?)

I don't understand why MLVApp doesn't use your Ryzen. My M1 runs always at 95-100% when exporting in MLVApp.

Quote from: theBilalFakhouri on May 24, 2022, 10:44:43 PM
*Even if it's must be single threaded, I guess we can process multiple frames at the same time (multi processing), e.g. each frame uses one thread or two frames per thread:
First frame would be processed on CORE 0 while second frame is being processed on CORE 1 and so one for other cores, when CORE 0 finishes, it would load the next frame which we need to process.
That's what we had in very first beta versions of MLVApp (process multiple frames single threaded) and it was very bad. You need 2 processing pipelines if you still like realtime preview: one for preview and one for export. Very hard to debug... and doesn't make much sense. We discussed it a lot - you should find this discussion very often here.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 25, 2022, 04:53:34 PM
Quote from: bouncyball on May 25, 2022, 04:50:19 PM
* do raw correction if checked (darkframe subtract, stripes removal, bad/focus pixels removal, dual iso, smoothing, implemented by me, non multithreaded because it is mostly adaptation of all existing ML/MLVFS raw correction code)
RAW corrections are already multithreaded... I did that as far I remember.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on May 25, 2022, 06:08:15 PM
Quote from: masc on May 25, 2022, 04:53:34 PM
RAW corrections are already multithreaded... I did that as far I remember.
Yeah, yeah, right. we used OpenMP and discussed and corrected some issues then. Not every loop can be OMP accelerated.
In short we OMPed every loop and disabled some after issues. 99% of the correction code (except dual iso) is multithreaded.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on May 25, 2022, 06:09:39 PM
But... as I said image processing is a real heavy bitch :D
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on May 25, 2022, 06:22:10 PM
MLVApp uses QT Creator I think?  It should be relatively easy for users to profile their usage and see where the pain is coming from.  I've never done this with QT Creator but I'm a big fan of profiling if you're trying to optimise.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 25, 2022, 09:45:36 PM
Just the UI uses QT. All the processing is standard C, some 3rd party algorithms are standard C++.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: devtone on May 27, 2022, 02:56:20 PM
Any option to use NVidia GPU NVenc in MLV-APP to speed up export? I cant find any way to change the ffmpeg parameters to use NVenc.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on May 28, 2022, 05:42:19 AM
Anyone has MLV App workstations built with AMD Threadripper CPUs, or EPYC CPUs? How do they perform comparing to Intel or ARM opponents?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: devtone on May 28, 2022, 12:13:14 PM
My i7 10875h 8Core (HT Disabled) is fully used. 4 cores 100% MLVapp and 4 cores 100% ffmpeg. Seems to be multithreaded. That should scale pretty nice on those AMD's.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 29, 2022, 10:59:28 AM
Quote from: devtone on May 27, 2022, 02:56:20 PM
Any option to use NVidia GPU NVenc in MLV-APP to speed up export? I cant find any way to change the ffmpeg parameters to use NVenc.
ffmpeg NVenc was for H.264? There is a way, but it isn't implemented, because I don't own any Nvidia graohics card. Without it, it can't work...
In MainWindow.cpp you'll find a function "startExportPipe". In this function you'll find
...else if( m_codecProfile == CODEC_H264 )...
In the following lines you could change the command parameters and try what happens.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on May 29, 2022, 12:17:50 PM
Thanks @bouncyball and @masc for the details.

Quote from: masc on May 25, 2022, 04:50:55 PM
I don't understand why MLVApp doesn't use your Ryzen. My M1 runs always at 95-100% when exporting in MLVApp.

Nah, MLVApp utilize my Ryzen 3900x up to ~80% during export, in reply #4961 (https://www.magiclantern.fm/forum/index.php?topic=20025.msg238975#msg238975) I was talking about CPU utilization during Playback . .
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 29, 2022, 12:34:23 PM
Quote from: theBilalFakhouri on May 29, 2022, 12:17:50 PM
Thanks @bouncyball and @masc for the details.

Nah, MLVApp utilize my Ryzen 3900x up to ~80% during export, in reply #4961 (https://www.magiclantern.fm/forum/index.php?topic=20025.msg238975#msg238975) I was talking about CPU utilization during Playback . .
Hm... on M1 I also (can) get 100% on playback. It is below 100%, if final framerate is reached with less CPU power. When using Shadows/Highlights/Clarity/DualISO("on" only) it is always below 100%, because these algorithms are single threaded.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on June 07, 2022, 08:24:00 PM
What a fun read that was... dating back from 2020 to now has been nothing short of remarkable. Love you guys and keep up with the fabulous work, as always!  8)

If you don't mind me asking, but is there any chance that we could have some sort of a checkbox to temporarily disable 'Graduation Curves' for viewing 'before/after' purposes?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 07, 2022, 08:38:26 PM
Quote from: DeafEyeJedi on June 07, 2022, 08:24:00 PM
What a fun read that was... dating back from 2020 to now has been nothing short of remarkable. Love you guys and keep up with the fabulous work, as always!  8)

If you don't mind me asking, but is there any chance that we could have some sort of a checkbox to temporarily disable 'Graduation Curves' for viewing 'before/after' purposes?
Thank you!
Hm... not exactly what you're asking, but:
- Ctrl+C
- reset curves
- Ctrl+V
will do the job.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DeafEyeJedi on June 08, 2022, 08:53:42 AM
Ah, ha. Thanks for the reminder on 'Receipt Mask Setup'.

This is actually much better. Brain fart on my part.

No wonder why no one complained.  :P
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 11, 2022, 05:42:47 PM
Hello!

Is it possible to have bad pixels map files same as focus pixel map?
e.g. let us pick bad pixels in MLVApp (using "Fix Bad Pixels" and "Map" option) then export our pixels selections to bad pixel map file, this way we can create bad pixel maps for different Binning modes (basically same as focus pixel maps).

Or at least let "Fix Bad Pixels" with "Map" option have multiple profiles which we can toggle between them when using "Map" option (also if profiles could be saved to external file), but personally I prefer a dedicated bad pixel maps files . .

Thanks
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 12, 2022, 11:25:24 AM
Hey theBilalFakhouri,
it is exactly the way it works. Focus and Bad Pixel maps are identical, just have another file ending. So rename from .fpm to .bpm and you can see the focus pixel map as bad pixel map. Do your editing, rename back, and you have a new focus pixel map.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 12, 2022, 12:15:03 PM
Okay, thanks for mentioning that!
Will make a try soon.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: BickyNutt on June 12, 2022, 04:46:06 PM
Hi.

I'm pretty new to MLV App and editing RAW video. But I'm having trouble with MLV App. Which I've searched on here for any answers and I can't find anything.

Firstly I'm on Windows and have MLV App v1.13. Win64.static

I'm not too sure if I have to install anything with MLV app. I just extracted what was in the .rar file and it launched when clicking the MLVApp.exe

I'm using a Canon EOS M

So the main problem.

I whenever I export a file as CinemaDNG Uncompressed. It comes up with this error.

Export File Error
Could not save: "blahblah.dng
How do you like to proceed?
(then asks me to pick an option)
Skip Frame - Abort Current Export - Abort Batch Extort.

---

Also When I try to export it any other way. It says it is exporting, it gets to 100%. Tells me "Export is Ready". And then nothing has actually been exported.

I'm wondering if anyone could help me. Is it the settings on my camera that aren't right for the actual MLV files. Or is it something I have to do on my PC.

I'm just pulling my hair out here.

Any help would be appreciated.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 15, 2022, 09:30:30 PM
ehm ehm,

MLVApp keep crashing when using "Darkframe Subtraction", the longer MLV clip is the high chance of MLVApp crash. I am on Windows 10, I am using 1.13 MLVApp x64 version.
How to debug the issue?

Thanks!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 15, 2022, 09:42:58 PM
Compile using QtCreator , Qt 5.x, Debug mode, MinGW64 compiler. Then start application with debugger from QtCreator and wait for crash. With some luck you'll see the line where it crashes.

For macOS it looks like this - on Windows it is similar.
https://youtu.be/pmngCFQzFdo
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 15, 2022, 11:16:10 PM
Okay, I have followed all the steps, compiled MLVApp, and ran MLVApp from Debug icon, and MLVApp did crash, where should I see the crash message?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 16, 2022, 06:45:03 AM
QtCreator shows it. Did you screenshot it? It automatically opens the source code file and marks the line. Plus you should see the call stack and all variable values.

How big are your files to reproduce this? If I can reproduce, I could try to help.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 16, 2022, 01:51:43 PM
Here is a screenshot:
(https://i.ibb.co/7Qm06XL/QT-Debug.png) (https://ibb.co/7Qm06XL)

MLVApp crashed (but still open in BG, frozen).

If I clicked on "Interrupt GDB for MLVApp", I can see these:

(https://i.ibb.co/9Zq7Pr6/GDB.png) (https://ibb.co/9Zq7Pr6)




-MLVApp settings and MLV clip info:

-1736x976 @ 23.976 14-bit lossless, 54 seconds.
-Exposure +3.0, Film profile, Dark-frame is generated by recording 5 seconds MLV (same camera settings as main MLV clip) with cap on lens, then imported to MLVApp and exported as MLV and "Averaged Frame", then loaded into MLVApp (just to check it), and then add it to main MLV clip via "Dark subtraction".

-Export settings: ProRess 444, up scale to 1920 (AR locked), export audio is on, force Amaze, ffmpeg Kostya.
-Few clips are loaded in MLVApp too, also other clips with "Dark subtraction" option, and same .MLV dark frame was re-used.

-Also the longer MLV clip with "Dark subtraction" (like 2 minutes or higher) the higher chance of crash will happen.

Above steps should re-produce the issue, this happens always to me.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 16, 2022, 02:41:43 PM
I forgot to mention that QtCreator didn't open anything or mark anything . .
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 16, 2022, 03:56:28 PM
I'll try to do the same when I am back to my EOSM.

What I see in your screenshots:
It seems MLVApp code is not the problem of your crash (otherwise you would see the line in code window and find the class/file in stack widget). The cxx and dll written in the application output are part of the Windows system (as far as I find via google). I do not know any feature in MLVApp using this. So it might be a Qt bug or a Windows bug. --> This will be very hard to fix, because we have no hint at all.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 16, 2022, 04:20:26 PM
Quote from: masc on June 16, 2022, 03:56:28 PM
... The cxx and dll written in the application output are part of the Windows system (as far as I find via google).

I think these "cxx and dll written in the application output" are being written when opening MLVApp and before the crash, so it's not related to the crash.

I will try to reproduce the issue on another PC.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 16, 2022, 10:11:43 PM
However... the debugger doesn't point on our code and doesn't list our classes in the stack. So this is difficult to fix. Looks like compiled library code.

I tried to reproducec exactly what ou described with my M, but only have my Macbook M1 here. I exported a 2:10min clip several times with darkframe as you described. No crash. Now searching for a Windows...
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 16, 2022, 11:32:43 PM
Thanks for testing.

I think I got the problem, the debugger should something and a line of code when I compiled MLVApp with MinGW_32bit, here is the messages:

(https://i.ibb.co/9hthXLd/1.png) (https://ibb.co/9hthXLd)

(https://i.ibb.co/gm0zb1M/2.png) (https://ibb.co/gm0zb1M)

AVIR thing?
I made two tests and the two tests showed the same error after the crash.

I did also the test with the same settings (same everything) but without "Darkframe Subtraction" and there is no crash.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 17, 2022, 08:14:57 AM
Interesting. Still strange: AVIR is 100% independant from Darkframe subtraction. And I really can't tell how to crash the pointed line... I mean float value = float value. How to fail here?! Hmmmmmm... Maybe the destination is invalid - but this also would happen without Darkframe.

Edit:
I could reproduce the problem (on Windows only) now. I get the same problem also without darkframe subtraction, without avir, and even with any other debayer - at least today, maybe after 30min of export... and I remember a similar bugsearch years ago.
What happens on crash:
The basic C function malloc/calloc (getting memory from the OS) doesn't work sometimes in Windows. This happens on any place in our app. I even can check if these functions succeeded: if the answer is "no" one time, it will be "no" until you restart the app. Microsoft: WTF?! I have GBs left in RAM and we free all memory we ask for! My taskmanager tells about 200-300MB RAM used for MLVApp. Are my free GBs of RAM so fragmeneted, so unusable?
So the only solution for now: use any other OS. It will work everywhere. This seems to be a Windows only bug. I've never seen this on any other OS.

If someone has a solution for that: please help. The question is how to get memory if your RAM is free and the OS says "no".

Example:
(https://i.ibb.co/BgwQ6JF/Bildschirmfoto-2022-06-17-um-11-28-22.png)
"debayerto" got memory, while red1d, green1d and blue1d did not get memory from OS. Before this crash, it worked some thousand times while running. Note: this can happen on any point using malloc/calloc - if it happens, I don't know any way to get memory again.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 17, 2022, 02:05:52 PM
Thanks for your efforts masc by narrowing down the issue, yeah it seems like only happens on Windows.
It would be nice if someone could help for finding a solution for it.

Funny thing, I downloaded linux version of MLVApp 1.13, and ran it using WSL2 on Windows 10, and it works fine with *native* processing speed :P
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 17, 2022, 05:03:00 PM
Do you free all memory as you go?  Any chance of memory leaks?

You really should check the return value from malloc / calloc in all cases, before using the memory.  You could do this by wrapping / redefining malloc, if you don't want to change every call site.  You can attempt to retry, but generally you are screwed if malloc fails (and some systems, e.g. default Linux, will have malloc never fail at point of allocation - the failure will occur only when you attempt to use the obtained pointer).  You can at least fail gracefully with more information (at least on platforms that have a malloc that will ever fail).

Because Linux has "optimistic" malloc behaviour, and you only see this behaviour on Windows, I wonder if you are sometimes allocating very large amounts, and not using them?  You could log the peak size allocated (some static global, wrap malloc with a logging call and output the peak value as you go).

You could try building with ASAN, that may give you more information (including memory leaks).  You could measure peak memory usage - Windows probably has some per process memory limit which you could be hitting even though the system has memory left.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 17, 2022, 08:48:44 PM
Is there any chance that MLVApp will get VP9 codec export ?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 18, 2022, 10:11:02 AM
Quote from: theBilalFakhouri on June 17, 2022, 02:05:52 PM
Funny thing, I downloaded linux version of MLVApp 1.13, and ran it using WSL2 on Windows 10, and it works fine with *native* processing speed :P
Cool! How does this work?

Quote from: names_are_hard on June 17, 2022, 05:03:00 PM
Do you free all memory as you go?  Any chance of memory leaks?
We do our very best to not have memory leaks. But there is always a very little chance... If there is a leak, it is very small, so you'll not see it e.g. using the task manager. I yesterday reviewed all mallocs/callocs and did not find a single call without beeing free() later.

Quote from: names_are_hard on June 17, 2022, 05:03:00 PM
You really should check the return value from malloc / calloc in all cases, before using the memory.  You could do this by wrapping / redefining malloc, if you don't want to change every call site.  You can attempt to retry, but generally you are screwed if malloc fails (and some systems, e.g. default Linux, will have malloc never fail at point of allocation - the failure will occur only when you attempt to use the obtained pointer).  You can at least fail gracefully with more information (at least on platforms that have a malloc that will ever fail).
This is more or less what I already tried in past. But if malloc/calloc fails once, it will fail until you restart the complete app. So all I could do is telling the user "no more processing now, the app will quit now", instead of crashing. The difference is not big: the user won't get a single additional frame beeing processed. This problem only exists on Windows.

If someone knows how to better search for memory leaks: feel free to search. Each bugfix is welcome!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 18, 2022, 10:29:19 AM
Quote from: 2blackbar on June 17, 2022, 08:48:44 PM
Is there any chance that MLVApp will get VP9 codec export ?
At least one pass should be doable.
https://trac.ffmpeg.org/wiki/Encode/VP9

What mode is required? Lossless? Or constant bitrate? Or...
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 18, 2022, 10:34:05 AM
Okay, probably not a leak using all your allowed process memory...  I'm not great at diagnosing real software on Windows, just the stupid stuff malware does.  I can try and look for problems in the Linux version, they might apply on both.  The behaviour of malloc failing being persistent seems odd to me unless all mem is exhausted.  Did you try an ASAN build?

Is this the right place to get current version?
https://github.com/ilia3101/MLV-App

Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 18, 2022, 12:12:19 PM
Quote from: names_are_hard on June 18, 2022, 10:34:05 AM
Okay, probably not a leak using all your allowed process memory... 
Who knows :)
No idea if there is a limit per application, or a limit per app per time. Because we malloc/calloc a lot (but also free a lot). In sum we're about 200-300MB, but it changes all the time.

Quote from: names_are_hard on June 18, 2022, 10:34:05 AM
I can try and look for problems in the Linux version, they might apply on both. 
Thank you!

Quote from: names_are_hard on June 18, 2022, 10:34:05 AM
Did you try an ASAN build?
Sry, never heard about this. I will do some research.

Quote from: names_are_hard on June 18, 2022, 10:34:05 AM
Is this the right place to get current version?
https://github.com/ilia3101/MLV-App
Yes, correct.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 18, 2022, 01:44:14 PM
Quote from: 2blackbar on June 17, 2022, 08:48:44 PM
Is there any chance that MLVApp will get VP9 codec export ?

Added VP9 lossless and CRF18. Please test.
https://github.com/ilia3101/MLV-App/commit/9a533b8a2e9c33d9cfb8c7d89b34b4858eb50b1f
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 18, 2022, 05:41:31 PM
Quote from: masc on June 18, 2022, 10:11:02 AM
Cool! How does this work?

I don't know how does WSL2 work, I am using it for ML compiling and QEMU stuff, followed g3gg0 tutorial (https://www.magiclantern.fm/forum/index.php?topic=20214.msg188142#msg188142), some notes for WSL2  (https://www.magiclantern.fm/forum/index.php?topic=20214.msg238825#msg238825)and DISPALY export (https://www.magiclantern.fm/forum/index.php?topic=20214.msg238826#msg238826), you will need X server also for MLVApp.

So WSL2 is some kind of VM designed by Microsoft, you can choose what Linux distribution you want to install when installing WSL2, it's Ubuntu by default (which I am using).



That was funny (https://www.magiclantern.fm/forum/index.php?topic=20025.msg239269#msg239269), but what is funnier:

Running MLVApp linux version using WSL2 on Windows 10 is faster compared to native MLVApp for Windows :D:

-Playback speed
-1360x1976 @ 23.976 FPS 14-bit lossless, default MLVApp 1.13 settings:
Windows MLVApp version on Windows 10: ~16 FPS
Linux MLVApp version via WSL2 on Windows 10: ~20 FPS

-1280x2160 @ 23.976 FPS 14-bit lossless, default MLVApp 1.13 settings:
Windows MLVApp version on Windows 10: ~15-16 FPS
Linux MLVApp version via WSL2 on Windows 10: ~18-19 FPS

-1736x2214 @ 23.976 FPS 11-bit lossless, default MLVApp 1.13 settings:
Windows MLVApp version on Windows 10: ~12 FPS
Linux MLVApp version via WSL2 on Windows 10: ~14-15 FPS

-Export
-1736x976 @ 23.976 FPS 14-bit lossless, default MLVApp 1.13 settings, ProRes 444:
Windows MLVApp version on Windows 10: 2:18 (2 minuets and 18 seconds)
Linux MLVApp version via WSL2 on Windows 10: 1:54 (1 minuets and 54 seconds)

-Same CPU utilization for both versions.
-More tests are probably needed.



Regarding MLVApp crash on Windows 10:
Yeah, I can have some random crashes especially when rendering time is long, probably same memory issue.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 18, 2022, 05:51:08 PM
Quote from: theBilalFakhouri on June 18, 2022, 05:41:31 PM
Running MLVApp linux version using WSL2 on Windows 10 is faster compared to native MLVApp for Windows :D
Haha... how funny is that.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 18, 2022, 09:00:05 PM
Masc - thanks for the reply.  It built nice and easily.  Had to fiddle around a bit with config (never used it before), am now trying to repro dark subtraction crash.

Only complaint so far: it expects ffmpeg binary to be in the same dir as mlvapp, and the error message isn't very good if it's missing "encoder ffmpeg missing".  I have ffmpeg in system path, but not next to mlvapp.  Had to use strace to realise it was opening with AT_FDCWD, and then copy the binary into my build location.  Is this deliberate?  Maybe people need to use custom ffmpeg versions sometimes?  Maybe it's fixed by a proper install (I just ran make and started mlvapp from there).  It would be nicer for me if when ffmpeg is not found, it tried to use the one in system path.  Maybe that would be a bad default for other people, I don't know.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 18, 2022, 09:05:06 PM
Top during dark frame subtraction export:


1395499 username       20   0 1710964 267988  22812 R 888.7   0.8  51:24.36 ffmpeg                                                                                 
1395388 username       20   0   18.0g  15.2g  53684 R 324.6  48.5  18:32.42 mlvapp


The amount of reserved mem steadily increases through the export.  Peaked at 20GB.  No crash here, this machine is fat.  It would surely crash if you had less ram + swap.  I would expect it's easy to observe memory going up during the export - should it be doing this?  Exported file is 7.7GB.  Maybe we're keeping a reference to each frame, something like that?  So they don't get garbage collected during the export?  Will dig a bit deeper.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 18, 2022, 09:23:59 PM
Quote from: names_are_hard on June 18, 2022, 09:05:06 PM
Peaked at 20GB.  No crash here, this machine is fat.  It would surely crash if you had less ram + swap.

My system has 64 GB of RAM, and sometime it can crash very early when dark-frame subtraction is on, like after hitting export by ~10 seconds.
Did you make your test on Windows? also what do you mean by "swap"?

If you want to me to run some analysis on my machine, please let me know.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 18, 2022, 09:32:31 PM
I don't have a Windows machine to test on.  Swap is disk space reserved to swap memory to if ram is exhausted.

Currently I am trying to run export under valgrind, but it might not be practical, it's so slow :)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 18, 2022, 10:44:44 PM
Valgrind has found one likely error so far, conceivably related to the dark subtraction issue, though I'd guess probably not.  It's an easy fix in code to test.

Here, in dng.c, we ROR32 over a pointer into a uint16 buffer.  This can read 2 bytes past the end of buffer (this *probably* won't crash on Windows, which typically has readable bytes after the allocated space on the heap.  I think if you exactly hit the end of a page boundary maybe it doesn't).  Probably we should check the buffer is 4 byte aligned earlier on?  Sometimes these type of errors are FPs by valgrind when it doesn't understand the asm for the function, but ROR32 over 16 bit buffer feels likely to be real to me.


703         uint32_t uncorrected_data = *((uint32_t *)&packed_bits[bits_address]);
704         uint32_t data = ROR32(uncorrected_data, rotate_value);


Valgrind dump so people unfamiliar can see how useful it is:

==1650919== Thread 35:
==1650919== Invalid read of size 4
==1650919==    at 0x1FC885: dng_unpack_image_bits._omp_fn.0 (dng.c:704)
==1650919==    by 0x4890DE5: ??? (in /usr/lib/x86_64-linux-gnu/libgomp.so.1.0.0)
==1650919==    by 0x5DEFEA6: start_thread (pthread_create.c:477)
==1650919==    by 0x6231DEE: clone (clone.S:95)
==1650919==  Address 0xc676e0e is 967,678 bytes inside a block of size 967,680 alloc'd
==1650919==    at 0x483AB65: calloc (vg_replace_malloc.c:760)
==1650919==    by 0x2114F1: df_load_ext (darkframe.c:102)
==1650919==    by 0x2119BC: df_validate (darkframe.c:256)
==1650919==    by 0x15A5E2: MainWindow::on_lineEditDarkFrameFile_textChanged(QString const&) (MainWindow.cpp:9728)
==1650919==    by 0x26D5C2: MainWindow::qt_metacall(QMetaObject::Call, int, void**) (moc_MainWindow.cpp:1764)


Shows you which buffer was used badly, including where it was allocated.  Learn to use valgrind if you're debugging C or C++! (works on anything but especially useful in these languages).
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 19, 2022, 01:28:50 AM
Probably a mem leak.  It took over two hours to run the test:


==1650919== HEAP SUMMARY:
==1650919==     in use at exit: 2,168,469,999 bytes in 10,637 blocks
==1650919==   total heap usage: 3,537,763 allocs, 3,527,126 frees, 62,845,029,066 bytes allocated
==1650919==
==1650919== LEAK SUMMARY:
==1650919==    definitely lost: 1,769,939,527 bytes in 4,387 blocks


Now I need to run it again with more logging, which will make it take longer.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 19, 2022, 02:52:26 AM
I made a much shorter clip, hoping it would still show the leak.  It did, and ran faster.


==1685697== 182,476,800 bytes in 55 blocks are definitely lost in loss record 511 of 511
==1685697==    at 0x483877F: malloc (vg_replace_malloc.c:307)
==1685697==    by 0x1DC83C: openMlvClip (video_mlv.c:1876)
==1685697==    by 0x2114A1: df_load_ext (darkframe.c:57)
==1685697==    by 0x1DFE3C: applyLLRawProcObject (llrawproc.c:172)
==1685697==    by 0x1D9C30: getMlvRawFrameFloat (video_mlv.c:308)
==1685697==    by 0x1D879A: get_mlv_raw_frame_debayered (frame_caching.c:305)
==1685697==    by 0x1DA0C5: getMlvRawFrameDebayered (video_mlv.c:439)
==1685697==    by 0x1DA190: getMlvProcessedFrame16 (video_mlv.c:465)
==1685697==    by 0x160B8F: MainWindow::startExportPipe(QString) (MainWindow.cpp:2572)
==1685697==    by 0x170093: MainWindow::exportHandler() (MainWindow.cpp:8128)
==1685697==    by 0x17D688: MainWindow::on_actionExport_triggered() (MainWindow.cpp:6596)
==1685697==    by 0x26D5C2: MainWindow::qt_metacall(QMetaObject::Call, int, void**) (moc_MainWindow.cpp:1764)


Valgrind thinks the allocation to rgb_raw_current_frame is not always being freed, and because "definitely" lost, we are getting to a state where there are no references to that block of mem.  That suggests we overwrite the pointer.

1874     /* For frame cache */
1875     video->rgb_raw_frames = (uint16_t **)malloc( sizeof(uint16_t *) * video->frames );
1876     video->rgb_raw_current_frame = (uint16_t *)malloc( getMlvWidth(video) * getMlvHeight(video) * 3 * sizeof(uint16_t) );
1877     video->cached_frames = (uint8_t *)calloc( sizeof(uint8_t), video->frames );


Hacked in some quick printf debugging around alloc free of rgb_raw_current_frame and got this:

initMlvObject hit
rgb_raw_current_frame alloc'd
freeMlvObject hit
rgb_raw_current_frame free'd
rgb_raw_current_frame alloc'd
rgb_raw_current_frame alloc'd
rgb_raw_current_frame alloc'd
rgb_raw_current_frame alloc'd
rgb_raw_current_frame alloc'd
rgb_raw_current_frame alloc'd
rgb_raw_current_frame alloc'd
rgb_raw_current_frame alloc'd
rgb_raw_current_frame alloc'd
rgb_raw_current_frame alloc'd
rgb_raw_current_frame alloc'd
rgb_raw_current_frame alloc'd
rgb_raw_current_frame alloc'd


That's truncated a lot.  Looks like it allocates to rgb_raw_current_frame every frame that's exported, and never frees them.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 19, 2022, 10:06:13 AM
Wow wow wow. Thank you so much @names_are_hard. I'll have a look for this variable. So linux "ps" or something already shows you 20GB of RAM usage? On Windows or macOS it is all the time about 200-300MB here and at least on macOS I could export over days without any swap.
Now I'll look for, what rgb_raw_current_frame does exactly...
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 19, 2022, 10:50:51 AM
@names_are_hard: your tests are done using a darkframe? I think I now know how what happens and will try to fix this. Thank you!
Did you also tested without a darkframe? Because last week here I also had a crash - whyever this did not happen before in endless tests.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 19, 2022, 11:07:44 AM
Find a small change in the latest commit.
Could you all test again please? Would be interesting if this runs stable on all the different platforms. macOS only here - I don't "feel" any change :D .
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 19, 2022, 11:13:41 AM
Quote from: names_are_hard on June 18, 2022, 09:00:05 PM
Only complaint so far: it expects ffmpeg binary to be in the same dir as mlvapp, and the error message isn't very good if it's missing "encoder ffmpeg missing". 
Hm... do you use latest commit? Since some time the message tells "Encoder ffmpeg missing in application path.". When compiling Qt should extract and copy the right ffmpeg version automatically into the application path. Just on Windows we have no alternative for this yet.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 19, 2022, 03:55:08 PM
Cool, glad if it seems helpful testing.  Bilal gave nice repro instructions so I was trying to do that for dark frame export, yes.  Haven't tried anything else yet.

Yes, high memory usage via "top".  Not very scientific.

Your change seems the right kind of thing to me, I tried a quick hack addition of freeing raw_rgb_current_frame as part of dl_free() but that seg faulted, so I didn't mention it.  I didn't know where cleanup should live :)  Testing now.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 19, 2022, 05:14:27 PM
Nice, much better:


==1745753== LEAK SUMMARY:
==1745753==    definitely lost: 7,140 bytes in 32 blocks
==1745753==    indirectly lost: 116,660 bytes in 156 blocks
==1745753==      possibly lost: 7,961,728 bytes in 30 blocks


There were several other leaks besides the big one I listed before, these are also fixed - makes sense, you free a bunch of related things in the latest change.

Most of the remaining leaks are a single block per size.  Often that means you created something once at the start and never free it.  That's fine if you want it to exist until the program exits.  It's nicer to explicitly free on exit, just so leak checkers don't FP on it.  Not important beyond that.

Bilal, does that change stop your crash?  This commit: https://github.com/ilia3101/MLV-App/commit/faddb3e1b5a1cec8c73b85252728fe031b6b23d3

Oh yeah, re ffmpeg, I am only doing make, not make install.  So perhaps it's not expected that ffmpeg gets copied for me?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 19, 2022, 07:22:56 PM
I made few tests (I am willing to do more later today with a lot of clips):

MLVApp compiled by MinGW_32:
I exported a clip five times with "Darkframe Subtraction" on and no crashes so far . .

MLVApp compiled by MinGW_64:
I exported a clip two times with "Darkframe Subtraction", first time no crash, but in the second try it crashed.

Tests made on Windows 10 x64 (no WSL2 used here :P).

Q:Does compiling with MinGW_32 makes MLVApp version x32 too? and same for MinGW_64, makes MLVApp x64?

Nice work @names_are_hard and @masc, many thanks for looking into it.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 19, 2022, 07:36:34 PM
I ran a non-dark frame export with a bunch of different options turned on and didn't get anything suspicious.  These tests take about 20 minutes to export a 2s clip, so I can't be bothered doing them if there's not a decent chance it will find something.  If you have something fairly reproducible and can share e.g. a session file so I can copy it, I'm quite happy to try it.

Since you're on Mac, Valgrind isn't well supported (it used to work okay, Apple broke it with Big Sur).  ASAN via clang does some of the same things, I strongly recommend you try it (introduce some buffer overflow bugs to test it in action).  According to Stack Overflow, Apple clang doesn't support leak checking via ASAN, so you'll want to get llvm from Brew or similar.  Then you need to change build options to include "-fsanitize=address", and when running, use "ASAN_OPTIONS=detect_leaks=1".  ASAN is faster than Valgrind, but not as thorough.

I've got two small fixes to current code that are unrelated to export, I'll PR them later.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 19, 2022, 07:42:47 PM
Quote from: theBilalFakhouri on June 19, 2022, 07:22:56 PM
Q:Does compiling with MinGW_32 makes MLVApp version x32 too? and same for MinGW_64, makes MLVApp x64?

Depends on build system.  Both compilers should be able to make 32 and 64 bit output files.  You can inspect the exe or the running process to find out what they've done.  Task Manager, should be a Platform column (maybe not visible by default?).  A 32 bit process will be limited to 2GB mem so this can be quite relevant.  Do you see the same crashes via WSL?

I saw the leaks from a 64 bit mlvapp (but on Linux).

Can you share a session file with me?  I can edit to use my MLV files.  If that doesn't repro then sharing your clips might help, hopefully not needed (exporting a 3 min clip takes several hours so I would like to avoid this!).
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 20, 2022, 01:50:58 PM
Quote from: names_are_hard on June 19, 2022, 07:42:47 PM
Depends on build system.  Both compilers should be able to make 32 and 64 bit output files.  You can inspect the exe or the running process to find out what they've done.  Task Manager, should be a Platform column (maybe not visible by default?).

Thanks for the answer, yeah I can see if a program is 64 bit or 32 bit in Windows task manager and it's visible by default.

Quote from: names_are_hard on June 19, 2022, 07:42:47 PM
Do you see the same crashes via WSL?

Well, could you provide a compiled MLVApp version (with the latest commit) on Linux?

Quote from: names_are_hard on June 19, 2022, 07:42:47 PM
Can you share a session file with me? ..

Sure, here is one (https://drive.google.com/file/d/1a1BbRuClEIg0LyMGWgKcnzgDhnGFRaDt/view?usp=sharing) which causes crashing issues, and was used in the following tests:

Tests:

-Two 1736x976 clips and one 1736x1160 clip, all loaded and "Darkframe Subtraction" on (same .MLV dark frame used for the 1736x976 clips), also .MLV dark frame are loaded in MLVApp.

64 bit:
-MLVApp 1.13 (official version):
Made three tests, and MLVApp crashes after few minutes, same thing in the three tests.

-MLVApp with latest commit  (https://github.com/ilia3101/MLV-App/commit/faddb3e1b5a1cec8c73b85252728fe031b6b23d3): (compiled with MinGW_64)
Made three tests, and MLVApp crashes after few seconds when it start exporting (same thing in the three tests).

32 bit:
-MLVApp 1.13 (official version):
Made three tests, and MLVApp crashes after few seconds, same thing in the three tests.

-MLVApp with latest commit  (https://github.com/ilia3101/MLV-App/commit/faddb3e1b5a1cec8c73b85252728fe031b6b23d3): (compiled with MinGW_32)
Made three tests, and MLVApp crashes after few minutes in two tests, third test it crashed in less than a minute.

Same exporting settings mentioned here (https://www.magiclantern.fm/forum/index.php?topic=20025.msg239245#msg239245). "Darkframe Subtraction" was on in all tests.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 20, 2022, 04:31:21 PM
Quote from: masc on June 18, 2022, 10:29:19 AM
At least one pass should be doable.
https://trac.ffmpeg.org/wiki/Encode/VP9

What mode is required? Lossless? Or constant bitrate? Or...
Well for me , id like to export VP9 encoded to resolutions like 8k cause ive got some 6k/8k from other blackmagic cams ( yeah braw works in mlvapp ) and settings that would allow them to work on youtube so 10 bit.Ideally id like adjustable bitrate so i could have own settings but i asked about it few years ago and you stated that its complex to add a box with customisable bitrate values so i have my own compiled versions when i bumped up quaity of x265 and h264.
Ideally - lossless, VBR,CBR and a box where we can set own values for VBR and CBR
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 20, 2022, 06:31:04 PM
Tested latest commit today on Win10 with Qt 5.13.2, MinGW_64 7.3.0, dynamic build; 1736x976, 14bit, >3200 frames clip, with darkframe subtraction. Exported this clip ~20x to ProRes4444 without any issue over the entire day, using the settings described by theBilalFakhouri.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 20, 2022, 06:42:16 PM
@masc

Could you provide the compiled version with latest commit for Windows?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on June 21, 2022, 05:01:50 PM
Quote from: masc on June 20, 2022, 06:31:04 PM
Tested latest commit today on Win10 with Qt 5.13.2, MinGW_64 7.3.0, dynamic build; 1736x976, 14bit, >3200 frames clip, with darkframe subtraction. Exported this clip ~20x to ProRes4444 without any issue over the entire day, using the settings described by theBilalFakhouri.

Very nice job guys! Thank you all!
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 22, 2022, 12:10:39 AM
Hey guys , i just found this raw to dng converter so we can use raw dng files from a lot of different camera brands in MLVApp, its quite fast , no gui juts command line
https://github.com/dnglab/dnglab
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 22, 2022, 06:44:28 AM
Quote from: theBilalFakhouri on June 20, 2022, 06:42:16 PM
@masc

Could you provide the compiled version with latest commit for Windows?
Yapp... finally:
https://www.dropbox.com/s/2t5o3uwxkfieyd8/MLV.App.v1.13.Win64.dynamic.zip?dl=0
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 22, 2022, 12:44:16 PM
Thanks masc,
It seems the problem is fixed with your compiled version, no longer crashes are happening with this test (https://www.magiclantern.fm/forum/index.php?topic=20025.msg239331#msg239331), I did three exporting tests, all of them didn't have crashes :D

Nice work, thanks @names_are_hard @masc!

I don't know why my compiled version was crashing (pretty sure I compiled with latest commit (https://github.com/ilia3101/MLV-App/commit/faddb3e1b5a1cec8c73b85252728fe031b6b23d3)), I was using Qt 5.14.1 and MinGW 7.3.0 (compiled with Release and Debug options, both had crashes).
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 22, 2022, 07:58:55 PM
Nice to hear it works for you. Whyever you get another result when compiling on your side. In past I tried many Qt versions starting from 5.6 to 5.15. There are sometimes some enoying GUI bugs, but crashes... not really. I think this must have another reason. Who knows ;)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on June 23, 2022, 09:52:03 AM
@theBilalFakhouri

Can you test those exports with this (https://bouncyball.myweb.ge/mlvapp/?dir=&download=MLVApp.zip) static build too?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on June 23, 2022, 02:34:32 PM
Quote from: bouncyball on June 23, 2022, 09:52:03 AM
Can you test those exports with this (https://bouncyball.myweb.ge/mlvapp/?dir=&download=MLVApp.zip) static build too?

Sure, I ran this test (https://www.magiclantern.fm/forum/index.php?topic=20025.msg239331#msg239331):
The first two tests it crashed for some reason, then I made six tests and it didn't crash.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 23, 2022, 03:33:44 PM
Quote from: bouncyball on June 23, 2022, 09:52:03 AM
Can you test those exports with this (https://bouncyball.myweb.ge/mlvapp/?dir=&download=MLVApp.zip) static build too?
3 trys, 3x success.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 24, 2022, 02:51:09 AM
Made this PR for a tiny fix: https://github.com/ilia3101/MLV-App/pull/243

Are you interested in fixes around compiler warnings?  E.g., this one:


MainWindow.cpp: In member function 'void MainWindow::startExportPipe(QString)':
../../src/mlv/macros.h:84:41: warning: macro expands to multiple statements [-Wmultistatement-macros]
   84 | #define setMlvDontAlwaysUseAmaze(video) (video)->use_amaze = 0; (video)->current_cached_frame_active = 0
      |                                         ^
MainWindow.cpp:1788:54: note: in expansion of macro 'setMlvDontAlwaysUseAmaze'
1788 |         if( !ui->actionAlwaysUseAMaZE->isChecked() ) setMlvDontAlwaysUseAmaze( m_pMlvObject );
      |                                                      ^~~~~~~~~~~~~~~~~~~~~~~~
MainWindow.cpp:1788:9: note: some parts of macro expansion are not guarded by this 'if' clause
1788 |         if( !ui->actionAlwaysUseAMaZE->isChecked() ) setMlvDontAlwaysUseAmaze( m_pMlvObject );


The macro will expand to look like this:

if( !ui->actionAlwaysUseAMaZE->isChecked() )
{
    m_pMlvObject->use_amaze = 0;
}
m_pMlvObject->current_cached_frame_active = 0;


This feels like a bug to me?  Presumably you want both statements to execute only if the condition is met? I would recommend converting the macro into a function.  It looks like a function, and performs the job of a function.  Just make it be a function.

I don't know if you have some normal process for checking and fixing compiler warnings so I haven't spent any time on this - but there are quite a few compiler warnings that looks like bugs.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 24, 2022, 08:58:09 PM
Thank you for reviewing our code. It is funny all different compilers will bring different warnings. And if you fix the warning of one compiler, it might not work anymore with the other one.
But yes, you're right with the macro you found. I made a very small fix for that (some additional {}). The frame caching is deactivated since some years and probably won't be active ever again - latest computers are able to playback in realtime even without caching.
Your PR is merged. Thanks a lot!
I watched all the warnings I get on macOS x86_64 again and tried to solve some... some I already removed again, because on other platforms it stopped working at all. Haha. In past we played already a lot avoiding those warnings. For libraries I stopped changing the code, because you change it with any update of the lib again.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 25, 2022, 09:50:53 AM
Yes, all compilers like to complain about different things!  And I agree it can be tricky to find fixes that make all of them happy.

I see you fixed the missing breaks in that big switch statement, that seemed a real problem :)
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 25, 2022, 01:48:19 PM
No idea why this switch ever worked... But it did. My Info dialog always showed the correct infos.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 25, 2022, 07:26:37 PM
Haha, yes, I was surprised by that one.  Maybe it was always called in the right order?  Then you'd set the later items wrong, but overwrite with correct values?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: swinxx on June 27, 2022, 09:04:19 PM
Hello my Friends! So to use some old videos, shot with mlv, i tried to convert to CinemaDNG, then i used the Blackmagic Name Scheme. But when i try to import the files to Davinci, i dont get a video file (like years ago) but single frame imports. has davinci stopped cinemadng support? or is there a workaround, to import those sequences?
if they stopped the format, what is the best codec to export the mlv files to work with davinci..?

best wishes. ren

Update. strange, but it works now. best wishes.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on June 29, 2022, 06:35:37 PM
Quote from: swinxx on June 27, 2022, 09:04:19 PM
if they stopped the format, what is the best codec to export the mlv files to work with davinci..?
Of course they did not drop the cinemadng support! :)

Also, If you wish, you can export the clip to prores or cineform with "Davinci Wide Gamut/Intermediate" profile and then import in resolve, works nicely. That color space added recently so you have to compile mlvapp from sources.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: wyup on June 30, 2022, 05:27:19 PM
Hello, thanks for long MLV work!

I'm a newbie here, can I substitute ffmpeg.exe file from MLV 11.13 win64 zip (n4.4-5-ge3fb0f0c88 version from 2021) to most recent BtbN gpl version (~121MB) expecting full functionality?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: swinxx on June 30, 2022, 05:30:17 PM
i found a bunch of old RAW Magic Files on my old HDD. so i wonder if it would it be possible to add the ability to import raw magic files into mlv app?
that would be awesome.

best wishes. Ren
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: swinxx on June 30, 2022, 05:32:08 PM
Quote from: bouncyball on June 29, 2022, 06:35:37 PM
Also, If you wish, you can export the clip to prores or cineform with "Davinci Wide Gamut/Intermediate" profile and then import in resolve, works nicely. That color space added recently so you have to compile mlvapp from sources.

ah very interesting. thank you for that info. is there a tutorial how to compile the app on a m1 mac? i have no idea how this works..

best wishes.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on June 30, 2022, 08:53:43 PM
Just compiled new version and theres VP9 export , Thanks !!!
I have a question, what should i change in the source so when i import folders with DNG files then i can mark 10 folders at once with shift or rect lasso ? Kinda how importing dng frames work( you can import multiple at once) but for folders.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 01, 2022, 06:56:03 PM
Major improvement (https://github.com/ilia3101/MLV-App/issues/245) to saturated colour handling coming in next release 8)

(You can all thank @troy_s on twitter for the idea, so simpe yet effective!)

(https://i.ibb.co/bPHjxVF/FWl4-Zdja-UAAi-M2-D.jpg)

Will help other subjects too, like sunsets and flowers. It's still not perfect, but now far better than most solutions out there.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on July 01, 2022, 08:48:19 PM
Are those samples available for download?
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 01, 2022, 08:55:16 PM
Would you like the original MLV, or just higher resolution?

Let me upload the MLV. Will be a few minutes.

Done. Here's the MLV: https://drive.google.com/file/d/1aGMz6JkatsWX9EGlValDahDheRcopj5E/view?usp=sharing (https://drive.google.com/file/d/1aGMz6JkatsWX9EGlValDahDheRcopj5E/view?usp=sharing)

And here it is in higher resolution, plus you get to see the whole rainbow:
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 01, 2022, 09:59:35 PM
Quote from: swinxx on June 30, 2022, 05:32:08 PM
ah very interesting. thank you for that info. is there a tutorial how to compile the app on a m1 mac? i have no idea how this works..
There is this: https://github.com/ilia3101/MLV-App#qt-app-macos-apple-silicon-based
Native Apple-Silicon support is very difficult to compile.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 01, 2022, 10:00:58 PM
Quote from: wyup on June 30, 2022, 05:27:19 PM
I'm a newbie here, can I substitute ffmpeg.exe file from MLV 11.13 win64 zip (n4.4-5-ge3fb0f0c88 version from 2021) to most recent BtbN gpl version (~121MB) expecting full functionality?
You can try to substitue with whatever version you like. But it is your task to test it then. There are so much features using ffmpeg...
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 01, 2022, 10:09:03 PM
Quote from: 2blackbar on June 30, 2022, 08:53:43 PM
I have a question, what should i change in the source so when i import folders with DNG files then i can mark 10 folders at once with shift or rect lasso ? Kinda how importing dng frames work( you can import multiple at once) but for folders.
You can just select one sequence at once.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on July 02, 2022, 07:14:52 AM
Quote from: ilia3101 on July 01, 2022, 06:56:03 PM
Major improvement (https://github.com/ilia3101/MLV-App/issues/245) to saturated colour handling coming in next release 8)

(You can all thank @troy_s on twitter for the idea, so simpe yet effective!)
wow, this looks great! I wonder how it will behave on skintones with saturated color lighting, because this problem exist even with standard cr2 files opened in photoshop sometimes..
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 02, 2022, 07:45:57 AM
Quote from: Skinny on July 02, 2022, 07:14:52 AM
wow, this looks great! I wonder how it will behave on skintones with saturated color lighting, because this problem exist even with standard cr2 files opened in photoshop sometimes..

I suspect it will be better than Adobe, except for highligh reconstruction. I'd love to see your results.

You can import your CR2 in to MLV App using File -> Transcode and import. It will convert any raw photos to an MLV.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on July 03, 2022, 05:34:59 PM
@ilia3101 Thanks, unfortunately I can't test it because builds after 1.12 (32-bit) don't work on my PC... it's from 2007. I can ask for cr2 if you want to check it out yourself and compare to Adobe or other software..
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 03, 2022, 06:12:52 PM
Ah that's annoying. Does it crash, or give any useful errors? Are you able to try compiling MLV App?

Also, maybe 1.14 will run. Perhaps 1.13 is just an unlucky coincidence.


And yes, I would love to see any difficult photos please.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 03, 2022, 08:00:46 PM
Quote from: Skinny on July 03, 2022, 05:34:59 PM
@ilia3101 Thanks, unfortunately I can't test it because builds after 1.12 (32-bit) don't work on my PC... it's from 2007. I can ask for cr2 if you want to check it out yourself and compare to Adobe or other software..
What OS do you use on this PC? And this OS is still 32bit? 2007 most PCs were already 64bit...
Maybe our used Qt library version was too new for your OS. Even Win7 isn't supported in latest Qt updates anymore.
Title: Re: MLV App 1.13 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 04, 2022, 06:37:03 PM
Finally, MLVApp v1.14 is out now. Thanks to all the contributors and testers.

New in v1.14:
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on July 05, 2022, 06:51:41 PM
Quote from: masc on July 04, 2022, 06:37:03 PM
Finally, MLVApp v1.14 is out now. Thanks to all the contributors and testers.
Great!

so, I'm using Windows 10 21H2 x64, and the processor is Intel(R) Core(TM)2 CPU 4400 @ 2.00GHz

Why 32 bit MLV App - because 1.12 32 bit is working here, but 64 is not. 1.13 doesn't work at all (as well as 1.14)

Quote from: ilia3101 on July 03, 2022, 06:12:52 PM
Are you able to try compiling MLV App?
I think I need to try it.. And maybe if I can use older QT version it will work?

Quote from: ilia3101 on July 03, 2022, 06:12:52 PM
And yes, I would love to see any difficult photos please.
ok, here are some files:
https://gofile.io/d/eh7zCN

In the archive you will find cr2 as well as processed jpeg files (just for reference). The problem is this purple light, which is a light source, so it should be brighter and not just dark purple color..
Photoshop camera raw profiles render it differently. Default Adobe profile is obviously worse, while "faithful" seems to be the most correct.. And not "neutral" as I was expecting.

But even then it still have some problems. For example if you look at 3384, in the center you will see a very saturated region on the hand/fingers which looks obviously kind of wrong..
As well as other problems, some photos looks better than the others. And sometimes it becomes very visible when photos are processed, for example if you add some contrast and change levels, gradients from these saturated regions become not as smooth as they should be, it can be really noticeable on the face for example. We can instantly tell if something wrong with person's face/skintones.

It's Rezeda's photos, and (fun fact) you subscribed to her youtube about a week ago...  :o :D I know she tried different things and at the end processed them with two different camera raw profiles, one for the overall look, and maybe "faithful" or "neutral" for the purple part of photos only. So obviously these saturated colors can be a little bit hard to work with..
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 05, 2022, 09:56:54 PM
Quote from: Skinny on July 05, 2022, 06:51:41 PM
so, I'm using Windows 10 21H2 x64, and the processor is Intel(R) Core(TM)2 CPU 4400 @ 2.00GHz

Why 32 bit MLV App - because 1.12 32 bit is working here, but 64 is not. 1.13 doesn't work at all (as well as 1.14)
I think I need to try it.. And maybe if I can use older QT version it will work?

On Win10 all Qt 5.x should work. For MLVApp 1.14 we used 3 different versions of Qt, the oldest was 5.9.9. Can't believe non is working for you. There is still no message or something? I think it doesn't matter what version you try. Maybe try latest 5.x - should be 5.15.2.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on July 06, 2022, 06:37:03 AM
no message or anything, but I found under windows event viewer two types of errors - with code 1000 and 1005.
both of them doesn't explain much.. but there is an exception code.

1000 - "Faulting application: MLVApp.exe, version: 1.14.0.0"
Exception code: 0xc000001d

1005 - "Windows cannot access the file for one of the following reasons: there is a problem with the network connection, the disk that the file is stored on, or the storage drivers installed on this computer; or the disk is missing."
There is no information about what file it is or anything.
Application name: "Processing and converting tool for MLV files"
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 06, 2022, 07:16:03 AM
Thanks for the photos! Very pink, wow. Even new MLV App is having trouble. Switching to Arri Wide gamut helps as usual. But that's some insane pink. Will take a deeper look later.

I can't find information about the exact CPU model name you specified. Only core 2 duo comes up. Is it a core 2 duo? (If so, it would be 64 bit). Also wikipedia for core 2 says all core 2 are 64 bit - https://en.wikipedia.org/wiki/Intel_Core_2

You could try dual booting 64 bit linux, and running the Linux build, might be easier than compiling it yourself for Windows 🤷

Those error codes might be helpful. Thanks for sharing.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on July 06, 2022, 07:23:34 AM
Some Core2Duo don't have SSE4.1 support, looks like MLV App builds with that.  0xc000001d is illegal instruction, so it's plausible as a cause.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 06, 2022, 08:03:28 AM
Thanks for pointing that out. Is that a compiler flag we're setting?

I think we should limit to SSE2, at least for the 32 bit builds.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on July 06, 2022, 08:24:18 AM
I don't know about 32 vs 64, but this is what I'm refering to, in platform/qt/MLVApp.pro:


QMAKE_CFLAGS += -O2 -fopenmp -msse4.1 -mssse3 -msse3 -msse2 -msse -D_FILE_OFFSET_BITS=64 -std=c99 -ftree-vectorize


I don't know Qt well at all, could be wrong.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on July 06, 2022, 10:13:45 AM
yes it's core 2 duo.

Quote from: ilia3101 on July 06, 2022, 07:16:03 AM
You could try dual booting 64 bit linux
do you know any protable linux version that I can just copy on the thumb drive and boot from it, instead of installing? for testing.

It could be SSE issue. What's interesting is that I haven't found any other program that won't run on this machine. Although I don't use a lot of applications.

Quote from: ilia3101 on July 06, 2022, 07:16:03 AM
Very pink, wow. Even new MLV App is having trouble.
By the way, it is not LED, it is just a standard white flash light with color filter on it. And it is not even that much as it can be sometimes.. for fashion photos it is normal to have very saturated colors sometimes. For example:
https://lindsayadlerphotography.com/fashion-i
https://lindsayadlerphotography.com/editorial-beauty
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 06, 2022, 10:29:35 AM
librtprocess uses SSE4.1, which is used since 1.13.

#ifdef __SSE4_1__

Maybe undef it in .pro and compile.

DEFINES -= __SSE4_1__

My oldest laptop also is a Core2Duo (P8600), but it runs well there. Maybe a bit newer. The 4400 indeed has no SSE4.1.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 06, 2022, 10:57:02 AM
Quote from: Skinny on July 06, 2022, 10:13:45 AM
do you know any protable linux version that I can just copy on the thumb drive and boot from it, instead of installing? for testing.


You can do this with normal ubuntu thumb dribe. But again, it may not run because of the SSE4.1 issue.

@masc What do you think about disabling SSE4.1 for 32 bit builds from now on? Or even on all builds, if the performance penalty isn't too great. It's a pretty weird instruction set that no one uses anyway.

Quote from: Skinny on July 06, 2022, 10:13:45 AM
By the way, it is not LED, it is just a standard white flash light with color filter on it.

That filter is likely producing a stronger pink than what's possible with typical RGB LEDs. I really appreciate having that photo to play with, so thanks again!

Quote from: Skinny on July 06, 2022, 10:13:45 AMfor fashion photos it is normal to have very saturated colors sometimes. For example:

Love bright colours. BTW, even in those examples, they aren't handled perfectly. I see digital skews/clipping in some of those photos.

My goal is to create digital image processing that handles bright colours smoothly. It's possible. Film does it. It's what I've been working towards for the past two years.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 06, 2022, 11:44:53 AM
Quote from: names_are_hard on July 06, 2022, 08:24:18 AM
I don't know about 32 vs 64, but this is what I'm refering to, in platform/qt/MLVApp.pro:


QMAKE_CFLAGS += -O2 -fopenmp -msse4.1 -mssse3 -msse3 -msse2 -msse -D_FILE_OFFSET_BITS=64 -std=c99 -ftree-vectorize


I don't know Qt well at all, could be wrong.
For Qt pro files "win32" and "win64" is the same.

Quote from: ilia3101 on July 06, 2022, 10:57:02 AM
@masc What do you think about disabling SSE4.1 for 32 bit builds from now on? Or even on all builds, if the performance penalty isn't too great. It's a pretty weird instruction set that no one uses anyway.
We have to disable it manually by changing the .pro file, before compiling this version. If someone knows about a "working" Win32/64 switch for .pro files, please let me know!


Could you please try this? Should be SSE4.1 free. Even before no feature used it in win32 version, just the compiler flag was enabled.
https://www.dropbox.com/s/ofqvc9vmmffarpl/MLVAppWin32Test.zip?dl=0
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: BatchGordon on July 06, 2022, 02:00:50 PM
Quote from: ilia3101 on July 06, 2022, 10:57:02 AM
My goal is to create digital image processing that handles bright colours smoothly. It's possible. Film does it. It's what I've been working towards for the past two years.

That's a great goal.
Color science (including color smoothness and highlight rolloff) can make more difference in the beauty of an image than the dynamic range and much-much-more difference than the resolution (personally I don't care too much of resolution unless it's less than 720p).

About this, are colors in MlvApp treated like in the color science of Arri Alexa (or Amira), with color saturation limited to a certain value like in watercolors?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on July 06, 2022, 02:36:11 PM
Quote from: masc on July 06, 2022, 11:44:53 AM
Could you please try this?
Thanks, it works! You guys are awesome!
I had to copy libgomp-1.dll from 1.14 Win32 version, because it is not included in the archive. And it opens up. I also copied ffmpeg and some other stuff, exported some MLV footage and everything seems to work perfectly :)

By the way I can instantly see benefits of AgX function - just opened some random mlv file, it was a test clip shot from my window (crappy and noisy) but it has red "Hotel" sign (LED) and it looks much better with AgX enabled.

Quote from: ilia3101 on July 06, 2022, 10:57:02 AM
Love bright colours. BTW, even in those examples, they aren't handled perfectly.
I know :D I can see it too now :)

QuoteMy goal is to create digital image processing that handles bright colours smoothly. It's possible. Film does it. It's what I've been working towards for the past two years.
I agree, this is really great. Keep us updated :) I think everyone wants to have "film-like" colors.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on July 06, 2022, 03:03:39 PM
Cool, probably SSE4.1 then.  I think 64 bit builds should work fine for you so long as they don't include that.  And 32 bit OS *can* use SSE4.1 (and all other SSE), just not your core2duo because it is super old ;)

Quote
Even before no feature used it in win32 version, just the compiler flag was enabled
The compiler will optimise using sse4.1 ops when it feels like it, can happen in any code.

The sophisticated fix would be something like: use CPUID to detect features at runtime, build multiple object files, some with sse4.1, some without, and swap function pointers / load different DLL or .so based on CPUID results.  Probably quite annoying work to do.

CPUs from about 2008 should have SSE4.1 and 4 is a big upgrade from prior versions, I expect you'll see noticeable perf drop with it disabled (have to test to be sure, of course).  How much do you want to support 15 year old hardware?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on July 07, 2022, 12:36:13 PM
Huston I've got a problem.

Hey guys I cant export fimage sequence (tiff, png, jp2) from mlvapp any more (Linux, v1.14). Craches/closes on fist frame every time with all MLVs.

The issue is not observed with v1.13. Tried 2 ffmpeg binaries with the same result.

Can you guys try this? No special steps needed for reproducing, just load mlv and export to TIFF sequence.

Valgrind does not give any sane information. Guess it is something with pipe but only for image sequences _not_for_video_ files.


Process terminating with default action of signal 13 (SIGPIPE)
==7341==    at 0x7113C5F: __libc_write (write.c:26)
==7341==    by 0x7113C5F: write (write.c:24)
==7341==    by 0x70960AC: _IO_file_write@@GLIBC_2.2.5 (fileops.c:1180)
==7341==    by 0x709544F: new_do_write (fileops.c:448)
==7341==    by 0x7097128: _IO_do_write@@GLIBC_2.2.5 (fileops.c:425)
==7341==    by 0x709676D: _IO_new_file_xsputn (fileops.c:1243)
==7341==    by 0x709676D: _IO_file_xsputn@@GLIBC_2.2.5 (fileops.c:1196)
==7341==    by 0x708B886: fwrite (iofwrite.c:39)
==7341==    by 0x15814D: MainWindow::startExportPipe(QString) (MainWindow.cpp:2619)
==7341==    by 0x186400: MainWindow::exportHandler() (MainWindow.cpp:8174)
==7341==    by 0x17C80F: MainWindow::on_actionExport_triggered() (MainWindow.cpp:6628)
==7341==    by 0x30D4DA: MainWindow::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (moc_MainWindow.cpp:1492)
==7341==    by 0x30EBC2: MainWindow::qt_metacall(QMetaObject::Call, int, void**) (moc_MainWindow.cpp:1769)
==7341==    by 0x68CA656: void doActivate<false>(QObject*, int, void**) (in /home/nic/Qt5.14.2/5.14.2/gcc_64/lib/libQt5Core.so.5.14.2)
==7341==
==7341== HEAP SUMMARY:
==7341==     in use at exit: 135,989,283 bytes in 98,200 blocks
==7341==   total heap usage: 1,221,836 allocs, 1,123,636 frees, 8,090,879,848 bytes allocated
==7341==
==7341== Searching for pointers to 98,200 not-freed blocks
==7341== Checked 474,945,176 bytes
==7341==
==7341== LEAK SUMMARY:
==7341==    definitely lost: 896 bytes in 7 blocks
==7341==    indirectly lost: 1,465 bytes in 45 blocks
==7341==      possibly lost: 6,673,015 bytes in 345 blocks
==7341==    still reachable: 129,313,907 bytes in 97,803 blocks
==7341==                       of which reachable via heuristic:
==7341==                         newarray           : 4,288 bytes in 2 blocks
==7341==                         multipleinheritance: 16,240 bytes in 22 blocks
==7341==         suppressed: 0 bytes in 0 blocks
==7341== Rerun with --leak-check=full to see details of leaked memory
==7341==
==7341== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on July 07, 2022, 12:45:11 PM
Debug bails out here:

MainWindow.cpp

-> 2619                fwrite(imgBuffer, sizeof( uint16_t ), frameSize, pPipe);
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on July 07, 2022, 01:51:34 PM
on Windows, exporting to tiff or png using 1.14 MLVApp, CMD shows for a less than second then closes very fast and MLVApp doesn't crash, progress bar is working but of course there is no exported frames.

Using 1.13 version, it works fine.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on July 07, 2022, 02:01:47 PM
if you launch mlvapp using a command prompt, you might see what is going wrong... maybe ;)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 07, 2022, 03:39:21 PM
ffmpeg output tells for TIFF "%7" is the problem in the used command. This is the colortag change we did - it seems nobody tested that. But I don't understand why argument no7 isn't inserted into the command string.

Edit: please try latest commit. I just sorted the arguments and now it is working here.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on July 08, 2022, 01:16:59 PM
That's it!

ffmpeg chokes on colortag option if sequence is chosen right?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on July 08, 2022, 01:19:31 PM
I guess we should release 1.14.1 :)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 08, 2022, 04:42:52 PM
Wait. A few more days and we could make it 1.15, I wanna make processing more float.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on July 08, 2022, 07:57:20 PM
Quote from: ilia3101 on July 08, 2022, 04:42:52 PM
I wanna make processing more float.
This sweetest sentence pleasing my eyes :D
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on July 08, 2022, 10:10:40 PM
Quote from: bouncyball on July 08, 2022, 07:57:20 PM
This sweetest sentence pleasing my eyes :D
Roflmao 😂
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on July 15, 2022, 09:45:30 PM
Hello :).
I work with the Dual ISO module. Shot the sunset on photos and videos. When I process photos in MLVApp, I get a dark picture when I turn on the Dual ISO program and increase the exposure, after which there is a lot of noise in the shadows.Sad outcome(
When I do this in the program CR2HDR - photos get perfect and there is no problem with noise. It is a pity not to process it accordingly mlv.
Maybe I'm doing something wrong in MLVApp? Is there some instruction? In MLVApp, the Dual ISO checkmark is just enabled, right?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 15, 2022, 10:28:21 PM
Sorry. DualISO is known not to work great in MLVApp and so is not supported. Use other tools for that.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on July 16, 2022, 11:23:39 AM
Is there a way to somehow export dng sequence and then use cr2hdr to process it, then import the sequence in MLV App back again?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on July 16, 2022, 01:57:55 PM
Quote from: masc on July 15, 2022, 10:28:21 PM
Sorry. DualISO is known not to work great in MLVApp and so is not supported. Use other tools for that.
It will work better in the next updates, right? ::)
And for MLV Dual ISO what other tools are there? I only know the good CR2HDR.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 16, 2022, 06:47:03 PM
Quote from: Icaab on July 16, 2022, 01:57:55 PM
It will work better in the next updates, right? ::)
Nope. Nobody is working on that and it is very complex. In the past months we were talking about completely removing it, because it is known to not work 100%.

Quote from: Icaab on July 16, 2022, 01:57:55 PM
And for MLV Dual ISO what other tools are there? I only know the good CR2HDR.
Exactly this.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on July 16, 2022, 08:38:14 PM
Wait, we're considering removing dual ISO? What are the reasons for that?

I believe I can fix highlight reconstruction, and the only other issue I know of is that it breaks with vertical stripes. Why remove it?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 16, 2022, 08:46:41 PM
The implementation in MLVApp is faulty. The one in CR2HDR (if I remember right) is correct. The code isn't changeable in an easy way. There were many issue reports about flickering etc. with MLVApp dualiso implementation.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on July 16, 2022, 09:45:11 PM
Quote from: Icaab on July 15, 2022, 09:45:30 PM
I work with the Dual ISO module. Shot the sunset on photos and videos. When I process photos in MLVApp, I get a dark picture when I turn on the Dual ISO program and increase the exposure, after which there is a lot of noise in the shadows.Sad outcome(
When I do this in the program CR2HDR - photos get perfect and there is no problem with noise. It is a pity not to process it accordingly mlv.

That's not an enough report, show examples, process the same picture in both MLVApp and CR2HDR, adjust the exposure so the two images match, then post the results.
Also, share the original not processed files.

Quote from: masc on July 16, 2022, 08:46:41 PM
The implementation in MLVApp is faulty. The one in CR2HDR (if I remember right) is correct.

MLVApp Dual ISO works fine here.
We will never know without examples and direct comparison which will show why MLVApp is *faulty* and why CR2HDR is *correct*.

Quote from: masc on July 16, 2022, 08:46:41 PM
There were many issue reports about flickering etc.

Dual ISO algorithm isn't designed for video processing in first place, I can have flickering issues also with CR2HDR.



During my experiments, there are many types of flickering issues, one of them is about white level output, I think a1ex did add a function in CR2HDR (you need to add a command for it to make it work) for making white level constant, and this fixes one of flickering issue. I think this one MLVApp doesn't have it.

I will make real tests and double check in future, and start a thread for Dual ISO flickering problems in general.
If someone can show (real examples) how cr2hdr performs better than MLVApp, go ahead :) .
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 16, 2022, 09:55:26 PM
Quote from: theBilalFakhouri on July 16, 2022, 09:45:11 PM
We will never know without examples and direct comparison which will show why MLVApp is *faulty* and why CR2HDR is *correct*.

All is here in this thread. The problem is just to find it in over 200 pages...
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on July 16, 2022, 09:58:14 PM
Quote from: theBilalFakhouri on July 16, 2022, 09:45:11 PM
That's not an enough report, show examples, process the same picture in both MLVApp and CR2HDR, adjust the exposure so the two images match, then post the results.
Also, share the original not processed files.

MLVApp Dual ISO works fine here.
We will never know without examples and direct comparison which will show why MLVApp is *faulty* and why CR2HDR is *correct*.

Dual ISO algorithm isn't designed for video processing in first place, I can have flickering issues also with CR2HDR.



During my experiments, there are many types of flickering issues, one of them is about white level output, I think a1ex did add a function in CR2HDR (you need to add a command for it to make it work) for making white level constant, and this fixes one of flickering issue. I think this one MLVApp doesn't have it.

I will make real tests and double check in future, and start a thread for Dual ISO flickering problems in general.
If someone can show (real examples) how cr2hdr performs better than MLVApp, go ahead :) .
I hear what you're saying.
Then in the next few days I'll send examples for comparison.
Personally, I believe that the competent work of Dual ISO in MLVApp depends on the model of the camera(I use 650d), otherwise for some reason, someone is working with quality, someone does not have)
By the way, what function did you say that takes the flicker out of the CR2HDR program ?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 16, 2022, 10:18:24 PM
The difference is not just a function. The versions are so different, that you can't easily take code from the one implementation to the other.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on July 16, 2022, 10:23:19 PM
Quote from: masc on July 16, 2022, 09:55:26 PM
All is here in this thread. The problem is just to find it in over 200 pages...

Okay, I will collect soon all replies here which talk about Dual ISO, and put in one place. I am interested in seeing some examples.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on July 18, 2022, 04:36:17 PM
Quote from: theBilalFakhouri on July 16, 2022, 09:45:11 PM
That's not an enough report, show examples, process the same picture in both MLVApp and CR2HDR, adjust the exposure so the two images match, then post the results.
Also, share the original not processed files.

MLVApp Dual ISO works fine here.
We will never know without examples and direct comparison which will show why MLVApp is *faulty* and why CR2HDR is *correct*.

Dual ISO algorithm isn't designed for video processing in first place, I can have flickering issues also with CR2HDR.



During my experiments, there are many types of flickering issues, one of them is about white level output, I think a1ex did add a function in CR2HDR (you need to add a command for it to make it work) for making white level constant, and this fixes one of flickering issue. I think this one MLVApp doesn't have it.

I will make real tests and double check in future, and start a thread for Dual ISO flickering problems in general.
If someone can show (real examples) how cr2hdr performs better than MLVApp, go ahead :) .
Sources at the bottom are included.
The same photo: DNG - CR2HDR, and dng - MLVApp, in which the photo was transcoded
in mlv, ticked in front of Dual ISO and saved due to the preset "CinemaDNG Uncompressed".
Photoshop only saw the difference that after CR2HDR the result is brighter, but the photos are more or less similar for comparison.
In the case of MLVApp - Camera RAW did not recognize on which camera and lens the photo was taken. The weight of the photos are almost the same.

(https://i.ibb.co/G097jpp/Screenshot-1275.png) (https://ibb.co/G097jpp)
(https://i.ibb.co/rwfwjfr/Screenshot-1276.png) (https://ibb.co/rwfwjfr)

For speed I better send pictures of my timelapse to CR2HDR.

But I cared about the video. After the inclusion of the Dual ISO video in MLVApp - everything becomes dark and I increase the exposure, after which a lot of colored noise comes out.

(https://i.ibb.co/F5fns3p/Screenshot-1279.png) (https://ibb.co/Vgh3H96)
(https://i.ibb.co/z2r1vBG/Screenshot-1277.png) (https://ibb.co/fN2bwy4)
(https://i.ibb.co/sVNThG0/Screenshot-1278.png) (https://ibb.co/BCQhmxX)

(I had a question: is it possible to shoot in Crop_Mode V2 - Preset "Centered x5 zoom" with fps override module? Received videos were not with x5 zoom.)

I decided to shoot more in different variations and getting a new result - made conclusions:
I think it is still right to include Dual ISO in MLVApp, and then export the video to DNG and continue processing in Lightroom or Photoshop (I thought it would be better to set up Clarity and Sharpen in MLVApp before exporting the video to the photos, but somehow the result with these manipulations is not saved and in Camera Raw I re-twist the corresponding settings).
As a result, my Camera Raw does not appear color noise on the same elevated levels of exposure as MLVApp, although the information CR2 photos have more and they weigh 30 with something megabyte, and the video saved in dng - 5 with something megabyte. Therefore, I believe that with CR2 photos more possibilities than with video for post-processing.
By the way for the source video I will attach my Cat, where there were bright rays of the sun and medium light corridor. I think the detail could have gone better, but I don't know how to achieve this result through MLVApp, and these shots themselves came out spontaneously :) (sharpness is more on noise than on the details of the picture itself).
https://vimeo.com/730993729
(password: dualiso)
If you have ideas - you can sit with the sources video: https://mega.nz/folder/j0QVlTgb#DI90sloYobh1R3oiQSF8ig (https://mega.nz/folder/j0QVlTgb#DI90sloYobh1R3oiQSF8ig)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on July 18, 2022, 07:35:51 PM
Quote from: Icaab on July 18, 2022, 04:36:17 PM
Sources at the bottom are included.
The same photo: DNG - CR2HDR, and dng - MLVApp, in which the photo was transcoded
in mlv, ticked in front of Dual ISO and saved due to the preset "CinemaDNG Uncompressed".
Photoshop only saw the difference that after CR2HDR the result is brighter, but the photos are more or less similar for comparison.

I downloaded the processed Dual ISO DNG frames from the included link, I imported them to MLVApp via "Transcode and import" and adjusted the exposure until they became identical, results:

-IMG_8014:
Processed with MLVApp Dual ISO algorithm:                                                                                            Processed with CR2HDR Dual ISO algorithm:
(https://i.ibb.co/7p3hD5L/MLVApp.jpg) (https://ibb.co/SmkSg8G) (https://i.ibb.co/b7mpMcQ/CR2HDR.jpg) (https://ibb.co/N7Cwdct)

-IMG_8016:
Processed with MLVApp Dual ISO algorithm:                                                                                  Processed with CR2HDR Dual ISO algorithm:
(https://i.ibb.co/KxT6Qfp/IMG-8016-MLVApp.jpg) (https://ibb.co/Df046vH) (https://i.ibb.co/KD1sKbH/IMG-8016-CR2-HDR.jpg) (https://ibb.co/gdnW4mC)

-Results:
Both CR2HDR and MLVApp Dual ISO algorithms produce identical noise level (overall identical image output), if the output was darker in MLVApp Dual ISO processing algorithm --> that's completely normal and it doesn't mean that you will get more noise, it won't affect noise in anyway, just increase the exposure until it looks normal and you will be fine.

Regarding the cat shots, you are clearly underexposing in first place, you will get same noise level if clip was processed in either CR2HDR or MLVApp, that's not MLVApp fault.
You are misusing Dual ISO (https://www.magiclantern.fm/forum/index.php?topic=25784.msg237228#msg237228), you need to expose to highlights and to the right, then if you had dark shadows and if there was usable ISO range left (like 100/800) --> at this moment you should consider to use Dual ISO.

In your case (cat shots), there is no need to use Dual-ISO (it won't make a difference), it's better to use single ISO like 800 or 1600.

-Example:

-ISO 100 (No Dual-ISO):                                                                                                                -Processed Dual-ISO 100/1600:
(https://i.ibb.co/jZ6nDq3/ISO-100.jpg) (https://ibb.co/gFjkJQt) (https://i.ibb.co/txVTZb5/Dual-ISO-100-1600.jpg) (https://ibb.co/gPkLvDC)

-ISO 100 (No Dual-ISO) Exposure +1, Shadows +50:                                                                       -Processed Dual-ISO 100/1600 Exposure +1, Shadows +50:
(https://i.ibb.co/dM9gCwV/ISO-100-Edited.jpg) (https://ibb.co/2h2NV1C) (https://i.ibb.co/qkGHxWG/Dual-ISO-100-1600-Edited.jpg) (https://ibb.co/QrBWXCB)

-Exposure +4:
https://youtu.be/m1IhE_a7Ez8

-Original MLV files: Download (https://drive.google.com/drive/folders/10OrhWdgIak9OwH8Is6NgiRZcn5lFMjBK?usp=sharing).

-Notes:
-In ISO 100 clip, I exposed the shot to highlights, if I increased the exposure more in camera I will start blowing highlights, at this case I can consider using Dual ISO:
  If my intention was to recover shadows in post, and get clean shadows.
  If there was still usable ISO range like 100/400, 100/800, 100/1600, 200/800, 200/1600. and not like 1600/6400.



-MLVApp and Dual-ISO:

The only downside here is flickering in some cases, and that's normal because the algorithm isn't designed for video in first place in both cr2hdr and MLVApp, but that doesn't mean it's not useable, cr2hdr can have flickering too in some cases. other than that MLVApp and Dual ISO works fine.

-MLVApp can handle 12/11/10/9/8-bit lossless Dual-ISO processing while cr2hdr can't do that currently.
-Beside MLVApp can also handle at least -to some point- focus pixels fix in Dual ISO clips while there is no other tool can do that iirc (didn't try MLVFS in this case).
-Also MLVApp can handle stretched Dual ISO DNGs (like when using 1x3 mode), cr2hdr gives error, you need to process squeezed 1x3 DNG files then apply the stretch.

cr2hdr has I think two tweaks for fixing flicker, one of them is this (https://foss.heptapod.net/magic-lantern/magic-lantern/-/commit/06fae84faeee81d6368091205d10868cf8d4cbe3), the other one here (https://www.magiclantern.fm/forum/index.php?topic=24216.msg232161#msg232161), But I am not sure if these only used in cr2hdr, they could be also there in MLVApp, we need to check.
If they are not there in MLVApp, we might want to check the possibility of implementing them.

-Lastly:

If there other issues with MLVApp and Dual-ISO other than flickering, feel free to make an argument which says cr2hdr is better :) (don't forget to mention the issue :P)
I am still looking for reported issues in this thread, will make a reply if I found one.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on July 18, 2022, 09:10:41 PM
This clip https://www.magiclantern.fm/forum/index.php?topic=20025.msg227661#msg227661 is one of several that will yield different output with mlvfs(mlv app) code vs a1ex cr2hdr and his latest code changes to cr2hdr, which was made very long ago must be said. Bouncyball added bit changes but the overall code is not working proper with output all the time. It could be subtle differences and it could also be very big issues. You never know really.
Personally I ditched this in favor of focusing on other stuff but the discussion comes back from time to time :).

I think you could reproduce the issue by simply recording some edge cases to try and produce an issue or try and find some old test file.

Edit: Seems the file is still downloadable :). Even a shortened test file:
https://drive.google.com/file/d/1GCa_Y3dczpVH2zjoDkiQJnK4D1xH4XwG/view

Regarding flicker it´s easily fixed with white level tag corrected with exiv2 or exiftool. But, if still flickers it indicates something else is not robust in code.

EDIT:
Here´s a unprocessed dng:
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/Short_000001.dng

If you can get looking like this from mlv app I would be very interested how you get that result:
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/cr2hdr_Short_000001.DNG
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on July 18, 2022, 11:26:03 PM
Quote from: theBilalFakhouri on July 18, 2022, 07:35:51 PM
I downloaded the processed Dual ISO DNG frames from the included link, I imported them to MLVApp via "Transcode and import" and adjusted the exposure until they became identical, results:

-IMG_8014:
Processed with MLVApp Dual ISO algorithm:                                                                                            Processed with CR2HDR Dual ISO algorithm:
(https://i.ibb.co/7p3hD5L/MLVApp.jpg) (https://ibb.co/SmkSg8G) (https://i.ibb.co/b7mpMcQ/CR2HDR.jpg) (https://ibb.co/N7Cwdct)

-IMG_8016:
Processed with MLVApp Dual ISO algorithm:                                                                                  Processed with CR2HDR Dual ISO algorithm:
(https://i.ibb.co/KxT6Qfp/IMG-8016-MLVApp.jpg) (https://ibb.co/Df046vH) (https://i.ibb.co/KD1sKbH/IMG-8016-CR2-HDR.jpg) (https://ibb.co/gdnW4mC)

-Results:
Both CR2HDR and MLVApp Dual ISO algorithms produce identical noise level (overall identical image output), if the output was darker in MLVApp Dual ISO processing algorithm --> that's completely normal and it doesn't mean that you will get more noise, it won't affect noise in anyway, just increase the exposure until it looks normal and you will be fine.

Regarding the cat shots, you are clearly underexposing in first place, you will get same noise level if clip was processed in either CR2HDR or MLVApp, that's not MLVApp fault.
You are misusing Dual ISO (https://www.magiclantern.fm/forum/index.php?topic=25784.msg237228#msg237228), you need to expose to highlights and to the right, then if you had dark shadows and if there was usable ISO range left (like 100/800) --> at this moment you should consider to use Dual ISO.

In your case (cat shots), there is no need to use Dual-ISO (it won't make a difference), it's better to use single ISO like 800 or 1600.

-Example:

-ISO 100 (No Dual-ISO):                                                                                                                -Processed Dual-ISO 100/1600:
(https://i.ibb.co/jZ6nDq3/ISO-100.jpg) (https://ibb.co/gFjkJQt) (https://i.ibb.co/txVTZb5/Dual-ISO-100-1600.jpg) (https://ibb.co/gPkLvDC)

-ISO 100 (No Dual-ISO) Exposure +1, Shadows +50:                                                                       -Processed Dual-ISO 100/1600 Exposure +1, Shadows +50:
(https://i.ibb.co/dM9gCwV/ISO-100-Edited.jpg) (https://ibb.co/2h2NV1C) (https://i.ibb.co/qkGHxWG/Dual-ISO-100-1600-Edited.jpg) (https://ibb.co/QrBWXCB)

-Exposure +4:
https://youtu.be/m1IhE_a7Ez8

-Original MLV files: Download (https://drive.google.com/drive/folders/10OrhWdgIak9OwH8Is6NgiRZcn5lFMjBK?usp=sharing).

-Notes:
-In ISO 100 clip, I exposed the shot to highlights, if I increased the exposure more in camera I will start blowing highlights, at this case I can consider using Dual ISO:
  If my intention was to recover shadows in post, and get clean shadows.
  If there was still usable ISO range like 100/400, 100/800, 100/1600, 200/800, 200/1600. and not like 1600/6400.



-MLVApp and Dual-ISO:

The only downside here is flickering in some cases, and that's normal because the algorithm isn't designed for video in first place in both cr2hdr and MLVApp, but that doesn't mean it's not useable, cr2hdr can have flickering too in some cases. other than that MLVApp and Dual ISO works fine.

-MLVApp can handle 12/11/10/9/8-bit lossless Dual-ISO processing while cr2hdr can't do that currently.
-Beside MLVApp can also handle at least -to some point- focus pixels fix in Dual ISO clips while there is no other tool can do that iirc (didn't try MLVFS in this case).
-Also MLVApp can handle stretched Dual ISO DNGs (like when using 1x3 mode), cr2hdr gives error, you need to process squeezed 1x3 DNG files then apply the stretch.

cr2hdr has I think two tweaks for fixing flicker, one of them is this (https://foss.heptapod.net/magic-lantern/magic-lantern/-/commit/06fae84faeee81d6368091205d10868cf8d4cbe3), the other one here (https://www.magiclantern.fm/forum/index.php?topic=24216.msg232161#msg232161), But I am not sure if these only used in cr2hdr, they could be also there in MLVApp, we need to check.
If they are not there in MLVApp, we might want to check the possibility of implementing them.

-Lastly:

If there other issues with MLVApp and Dual-ISO other than flickering, feel free to make an argument which says cr2hdr is better :) (don't forget to mention the issue :P)
I am still looking for reported issues in this thread, will make a reply if I found one.

In principle, the difference did not notice strong in the photos. May have a little in chromatic abbreviations and white balance, but these are trifles and are easily fixed in Photoshop or Lightroom.
Yes, the ETTR rule. I understood what you mean. If you stick to it, then the Dual ISO videos will contain less noise and more details. But when it's justified in use, unlike a dark cat photo.
I'm not afraid of flickering. I use one of the plugins in Premiere Pro, which turns them off and everything is fine :D.
I think I have no questions from the others. Only if this one:
Quote
(I had a question: is it possible to shoot in Crop_Mode V2 - Preset "Centered x5 zoom" with fps override module? Received videos were not with x5 zoom.)
The rest I figured out. Thank you!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on July 19, 2022, 08:35:33 AM
@Icaab

Please stop quoting the whole reply, there is no point to do that.

Quote from: Icaab on July 18, 2022, 04:36:17 PM
(I had a question: is it possible to shoot in Crop_Mode V2 - Preset "Centered x5 zoom" with fps override module? Received videos were not with x5 zoom.)

Off-topic here, please consider asking in this thread (https://www.magiclantern.fm/forum/index.php?topic=25784.0).
Anyway, x5 here refer to Canon preview, if you are looking for x5 crop factor for the RAW data, you need to reduce resolution from RAW video submenu, in your case to 1664x936 (while using 1:1 preset).

Crop mode V2 won't make any difference.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on July 19, 2022, 08:54:28 AM
Quote from: Danne on July 18, 2022, 09:10:41 PM
This clip https://www.magiclantern.fm/forum/index.php?topic=20025.msg227661#msg227661 is one of several that will yield different output with mlvfs(mlv app) code vs a1ex cr2hdr and his latest code changes to cr2hdr, which was made very long ago must be said. Bouncyball added bit changes but the overall code is not working proper with output all the time. It could be subtle differences and it could also be very big issues. You never know really.
...

Thanks Danne, finally there is a real issue (no I am not happy for that, I hate issues :P).
I never touched Dual ISO processing code, so we need to find the commit in cr2hdr which fixed the issue, and we need to try to implement it in proper way . .

It might be there other needed tweaks in some areas, who knows.

I will try digging into it, for now if someone encounter this issue, please use cr2hdr :D . . but that doesn't mean MLVApp Dual ISO processing is completely bad, it worked for me and never had the mentioned issue.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on July 19, 2022, 09:03:08 AM
For occasional dualiso sequences it works but I tried it a little more back then and issues came randomly. Too bad actually since crhdr is quite useful so refining it in Mlv app would be very nice. I looked at the code but hey, couldn't understand half of it.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on July 20, 2022, 07:31:28 AM
from my experience, dual iso in mlvapp is good for close object with no problem.. but for far object eg. trees or fence that has narrow structure will show red, green, blue pixels scattered around the edge.. sometimes it can be fixed by CA desaturate.

btw.. thanks for mlvapp new update.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 20, 2022, 08:47:23 PM
Quote from: ilia3101 on July 08, 2022, 04:42:52 PM
Wait. A few more days and we could make it 1.15, I wanna make processing more float.
Hej Ilia... that sounds so interesting. What about your progress?

@all: did someone test the latest commits? I would like to know it working for new releases...
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on July 20, 2022, 09:50:22 PM
Quote from: masc on July 20, 2022, 08:47:23 PM
@all: did someone test the latest commits? I would like to know it working for new releases...

Just tested PNG and TIFF exports with latest commits on Windows, both works fine and the issue seems fixed.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on July 21, 2022, 09:36:18 AM
Yeah dual iso is a PITA really.

Mlvfs code was not intended for 10-12bit RAW processing. I changed this and it now supports, "kinda", this RAW modes, but there was a lot of nuances with white and black level calculations/conversions and I have to say that aside of 14bit it is not reliable at all.

Also it is "super quick" as turtle :), because of complicated loops which can not be correctly multithreaded with openmp.

Adapting cr2hdr to mlvapp is also hard because @dmilligan did a great job to optimize and sometimes cut corners for speed's sake and those code parts are very different.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 21, 2022, 09:56:57 AM
Quote from: theBilalFakhouri on July 20, 2022, 09:50:22 PM
Just tested PNG and TIFF exports with latest commits on Windows, both works fine and the issue seems fixed.
Thanks a lot.

Also someone tested the update dialog? Github changed its webpage, so parsing for updates was completely broken. I reimplemented it in another way now, which hopefully is more future proof. For testing this, you'll have to change version number in .pro file to something smaller, then qmake, then clean, then build. If you want to see the 'update available' dialog on MLVApp startup, you have to delete MLVApp from registry (or equivalent on other platforms) or wait a day (or change system date).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ricardopt on August 01, 2022, 04:09:30 AM
Hi everyone.

Is there a way or does anyone know a lut that can "transform" any of the log formats to f-log? like sony slog to f-log? Or is that not possible?

Thanks
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: wib on August 01, 2022, 12:33:11 PM
I think you can try this : exporting with Alexa Log-C preset from MLV App, and then in Resolve Davinci, with the plugin CineMatch, you can easily convert the resulted Arri Log video to a F-Log curve.

(https://i.imgur.com/sEaAPc3.png)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on August 01, 2022, 02:59:20 PM
Hello.
Worked on the latest version of MLVApp. I put already familiar settings for me, but after watching the exported video - noticed a defect: the strings on the guitar are like floating (waves), which was not in the original.
I tweaked the other settings, but honestly I don't even know where this problem comes from.
I've never seen anything like it.
https://mega.nz/folder/WxYl0RSA#bF_IT0yBZtKtZl3lQ-4p7w (https://mega.nz/folder/WxYl0RSA#bF_IT0yBZtKtZl3lQ-4p7w)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 01, 2022, 03:55:12 PM
@Icaab: sharp vertical lines... one of the biggest disadvantages when recording with 1x3 (anamorphic) mode. This problem is also visible in your MLV. The movement of the partial vertical lines is exactly 1pixel in footage (so 3 on your sensor, and/or 3 desqueezed). This is just lack of image information - the compromize when using the 1x3 mode.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on August 01, 2022, 08:26:57 PM
Quote from: masc on August 01, 2022, 03:55:12 PM
@Icaab: sharp vertical lines... one of the biggest disadvantages when recording with 1x3 (anamorphic) mode. This problem is also visible in your MLV. The movement of the partial vertical lines is exactly 1pixel in footage (so 3 on your sensor, and/or 3 desqueezed). This is just lack of image information - the compromize when using the 1x3 mode.
In short, got bad source and rewrite everything? ))
Is it possible to record string instruments in any other way? I don't recall seeing musical instrument footages recorded at the expense of the Magic Lantern.
I've never seen 1x3 cause me this much trouble. I thought it was the best adapted
(Recently shot a video with similar settings MG and vertical lines I did not see. I do not understand anything. Would use preset x5 and 1x1 if space allowed)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 02, 2022, 05:35:49 AM
I think you oversharpened the footage. Or used some setting not working too good. I tried exporting with some minor changes. Looked good to me. Exported to 10bit h265:
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/M31-0100.mov
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/m31.marxml
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on August 02, 2022, 07:14:09 AM
Quote from: Danne on August 02, 2022, 05:35:49 AM
I think you oversharpened the footage. Or used some setting not working too good. I tried exporting with some minor changes. Looked good to me. Exported to 10bit h265:
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/M31-0100.mov
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/m31.marxml
Yes, the defects are now minimal. Thank you :), I'll keep that in mind. I'll sit down with your settings.
But in the future, If I shoot for example string instruments, is it better to do it in 1x1?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 02, 2022, 08:28:30 AM
Quote from: Icaab on August 02, 2022, 07:14:09 AM
But in the future, If I shoot for example string instruments, is it better to do it in 1x1?
You could also try fast lenses with much bokeh... here those lines are blurred and the effect is less or not visible.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on August 02, 2022, 09:33:13 AM
Quote from: masc on August 02, 2022, 08:28:30 AM
You could also try fast lenses with much bokeh... here those lines are blurred and the effect is less or not visible.
Interesting...the shooting was carried out with the Sigma 18-35 lens and the 2.2 aperture to capture the focus of the character and the instrument
Earlier, I ran tests with the same ML firmware settings, but with a lens Sigma of 16-50mm and an f/2.8 aperture, but I noticed more aliasing on strings than, as you put it, sharp vertical lines.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ricardopt on August 06, 2022, 04:50:25 PM
Quote from: wib on August 01, 2022, 12:33:11 PM
I think you can try this : exporting with Alexa Log-C preset from MLV App, and then in Resolve Davinci, with the plugin CineMatch, you can easily convert the resulted Arri Log video to a F-Log curve.

Thanks for your advice wib, will try the free trial as its expensive for me, have you tried it? 1GB download for a plugin?!

Hopefully one day mlvapp will support exporting to f-log.

Once again thanks for your advice
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 07, 2022, 12:04:17 AM
You can implement F log yourself. Select rec2020 primaries(F log uses them), then write the log curve formula forums as transfer function (you'll need to google it to find the formula).

Cinematch looks like the biggest rip off I've ever seen.

(unless it has really amazing gamut mapping algorithms or something).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 07, 2022, 07:18:48 AM
Also this page.
http://cameramanben.github.io/LUTCalc/
Tool building a conversion lut. F-log is represented.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 07, 2022, 03:01:49 PM
@Danne Perfect!

Cinematch is overkill (and possibly worse) for this use case.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ricardopt on August 07, 2022, 06:25:42 PM
Thanks for your feedback ilia3101 and Danne.

I dont have the technical know how to say if f-log is worth it or not, i've been playing with some xt3 and xt4 f-log and eterna video samples and it looks ok, just exploring some other "color sciences" instead of the usual ones.


Thanks for your advices and input.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 07, 2022, 11:47:45 PM
I can also recommend the latest MLV App for producing final/graded rec709 images, in my opinion the new AgX processing is better than most manufacturer's LUTs and "colour science".

It's tonally smooth and handles difficult saturated colours and highlights (like LEDs) with perfect smoothness. Combined with one of MLV App's film filters, I bet it will look way better than the Fujifilm system.

(https://i.ibb.co/GFXzrbg/Screenshot-2022-08-07-at-22-46-13.png)

The only area where MLV App is significantly lacking is highlight reconstruction. Davinci is better if you've clipped channels.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 09, 2022, 06:49:28 AM
It's easy to use the MLV App to export MLV files to CinemaDNG image sequences, but is it possible convert a CinemaDNG image sequences into MLV files?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 09, 2022, 07:47:40 AM
The closest I can get is using "Transcode and Import RAW2MLV" but it's missing audio and doesn't give me parameters to account for the 1:3 pixel ratio:

(https://i.ibb.co/yWWMCRK/Untitled-5-01.png)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 09, 2022, 08:48:02 AM
You found the function. The functionality is implemented in mlv2raw, not in MLVApp. MLVApp uses this little app for DNG import. Not all functions around DNG are supported, but normally there is no camera out there (as far as I know) recording 1x3 footage into DNG files. After import into MLVApp you can always stretch your footage manually from Transformation tab ("Height stretch = 0.33x").
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 10, 2022, 05:43:13 AM
Where can I get mlv2raw?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 10, 2022, 06:17:04 AM
Is this it? http://www.phreekz.de/wordpress/2014/04/magiclantern-raw2cdng-1-5-0/ (http://www.phreekz.de/wordpress/2014/04/magiclantern-raw2cdng-1-5-0/)

Backstory: Amazon Photos provides unlimited photo storage so I'm using it to backup my MLVs after extracting them to DNG sequences (fun fact: somehow Amazon Photos knows to display the DNGs in the correct aspect ratio). It would be nice if I could find a simple, quick, reliable method to get the DNG sequences back to their original state as MLVs with the audio synced up and the FPS the same as before (my 6D MK1 records at 24.01 FPS for some reason). The "Transcode and Import RAW2MLV" option in MLV App does not bring in the audio and doesn't give me the option to compile as 24.01 FPS, only 24.00 FPS. I'm on a mac so I don't think raw2cdng is an option for me.

Any suggestions would be greatly appreciated!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 10, 2022, 08:28:39 AM
Quote from: tdnelson2 on August 10, 2022, 05:43:13 AM
Where can I get mlv2raw?
https://github.com/ilia3101/LibMLV/tree/master/old/programs/raw2mlv

Quote from: tdnelson2 on August 10, 2022, 06:17:04 AM
(fun fact: somehow Amazon Photos knows to display the DNGs in the correct aspect ratio)
No fun fact. That's a MLVApp feature. All MLVApp exported DNG files have aspect ratio metadata included and nearly all applications out there read and handle it. The real fun fact: there is one app out there not reading it: Resolve.

Quote from: tdnelson2 on August 10, 2022, 06:17:04 AM
... so I'm using it to backup my MLVs after extracting them to DNG sequences
Why do you backup DNG sequences??? I would never do this. Always backup the MLV files! MLV files have much more metadata included - that is way more future proof, no matter what features we will develop and include in future, or what RAW corrections you would like to use in future. After exporting to DNG some RAW corrections are hard/impossible to do - over forever.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 10, 2022, 06:22:45 PM
Quote from: masc on August 10, 2022, 08:28:39 AMWhy do you backup DNG sequences??? I would never do this. Always backup the MLV files! MLV files have much more metadata included - that is way more future proof, no matter what features we will develop and include in future, or what RAW corrections you would like to use in future. After exporting to DNG some RAW corrections are hard/impossible to do - over forever.
Honestly, I assumed that MLV files are simply a container for a sequence of DNG images with audio and metadata included. Am I not right? Is there not a way to extract the RAW DNG sequences and metadata from the MLVs in a way that it could be restored to a MLV and be indistinguishable from the original MLV?

For me the whole point of this exercise is to enable me to take advantage of the Amazon Photos' limitless backup. I have my MLV files backed up to hard drives but cloud backup provides unbeatable assurance.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 10, 2022, 07:50:38 PM
Quote from: tdnelson2 on August 10, 2022, 06:22:45 PM
Honestly, I assumed that MLV files are simply a container for a sequence of DNG images with audio and metadata included. Am I not right?
No, not really. The included image data itself is the same, but organization is different. Same for metadata.

Quote from: tdnelson2 on August 10, 2022, 06:22:45 PM
Is there not a way to extract the RAW DNG sequences and metadata from the MLVs in a way that it could be restored to a MLV and be indistinguishable from the original MLV?
Should be hard, because in MLV there is metadata, which doesn't exist in DNG.

Again... better store MLV instead of DNGs. It is the original data.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 10, 2022, 08:09:56 PM
Thanks @masc. I'd like to understand the structure of the MLV a bit more. Can you point me in the right direction? I'd like to work this problem a bit
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 10, 2022, 08:53:21 PM
This is the MLV structure:
https://github.com/ilia3101/MLV-App/blob/master/src/mlv/mlv.h

And this is a handling struct from MLVApp:
https://github.com/ilia3101/MLV-App/blob/master/src/mlv/mlv_object.h

In the same folder you find MLV reading functions...
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 11, 2022, 05:30:56 AM
Just FYI, compiled versions of raw2mlv are referenced here: https://www.magiclantern.fm/forum/index.php?topic=24631.0 (https://www.magiclantern.fm/forum/index.php?topic=24631.0)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on August 11, 2022, 05:46:45 AM
Since your game plan is to abuse Amazon Photos to store video, and you already expect to do work after downloading the "photos" to reconstruct the videos *and* since Amazon Photos allows storing raw images with no alterations:

Chunk the video up into pieces and store each piece as b&w data in a series of raw images.  Perfect reproduction of any file.  Easy to automate.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 11, 2022, 01:05:09 PM
Quote from: tdnelson2 on August 11, 2022, 05:30:56 AM
Just FYI, compiled versions of raw2mlv are referenced here: https://www.magiclantern.fm/forum/index.php?topic=24631.0 (https://www.magiclantern.fm/forum/index.php?topic=24631.0)
raw2mlv.app is not raw2mlv. raw2mlv is part of raw2mlv.app (on macOS only).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on August 11, 2022, 01:40:13 PM
Quote from: masc on August 11, 2022, 01:05:09 PM
raw2mlv.app is not raw2mlv. raw2mlv is part of raw2mlv.app (on macOS only).
...also old, outdated.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 11, 2022, 09:56:03 PM
Quote from: names_are_hard on August 11, 2022, 05:46:45 AM
Since your game plan is to abuse Amazon Photos to store video
I wouldn't call it abuse. I'm sure Amazon uses these as raw data for their AI image generator project so really I'm doing them a favor  ;D

Quote from: names_are_hard on August 11, 2022, 05:46:45 AM
Chunk the video up into pieces and store each piece as b&w data in a series of raw images.  Perfect reproduction of any file.  Easy to automate.
Any tips on how I can get started on implementing this? This type of software development is pretty far out of my wheel house
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 11, 2022, 09:58:20 PM
Quote from: Danne on August 11, 2022, 01:40:13 PM
...also old, outdated.
Where I can I find an up-to-date implementation for mac?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 11, 2022, 10:03:30 PM
https://github.com/ilia3101/LibMLV/tree/master/old/programs/raw2mlv
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on August 11, 2022, 10:59:25 PM
Quote
Any tips on how I can get started on implementing this? This type of software development is pretty far out of my wheel house

Any file can be considered a long list of numbers.  The image data in a raw file is also a long list of numbers (the pixel data).  Chop up the file you care about into the correct sized pieces, and copy the numbers into the raw (in the correct place for it to be the "image data").  Repeat until you run out of source file.  Name each generated raw file sequentially or whatever.

Somebody always does something like this when there's an "unlimited" storage deal going, and the deal always gets shut down in a year or two (especially when somebody starts using it for storage of unsavory content).  Amazon Photos may last longer since it's not free.

EDIT: in case it's not clear - I am recommending you don't do this.  Just buy some cloud storage, it'll be much less hassle and won't get shut down in the future randomly.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on August 12, 2022, 02:29:24 AM
Suggestion:
"Fix Bad Pixels" with "Map" options should be turned on automatically when bad pixel map is presented.

@masc
Is this possible to do it?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 12, 2022, 07:56:14 AM
Quote from: theBilalFakhouri on August 12, 2022, 02:29:24 AM
Suggestion:
"Fix Bad Pixels" with "Map" options should be turned on automatically when bad pixel map is presented.

@masc
Is this possible to do it?
Working already: create your custom receipt and set it as default receipt in edit menu. So open any MLV, click on "Map", save receipt, and set as default. If no map exists, nothing will happen. If map exists, it will be used.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on August 12, 2022, 08:26:50 AM
Thanks @masc!
Yeah, that works. I didn't know that before.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 12, 2022, 06:16:39 PM
Quote from: tdnelson2 on August 11, 2022, 09:58:20 PM
Where I can I find an up-to-date implementation for mac?

Sorry there's no up to date implementation. It's on my infintely long to do list. I need to rewrite the whole tool (as well as LibMLV).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 12, 2022, 10:50:10 PM
Quote from: names_are_hard on August 11, 2022, 10:59:25 PM
Chop up the file you care about into the correct sized pieces, and copy the numbers into the raw (in the correct place for it to be the "image data").  Repeat until you run out of source file.
How do I find the delimiter between two raw images in a MLV? Is there a command line tool for doing this?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on August 12, 2022, 11:22:57 PM
You've misunderstood; you don't need to know anything about the internals of MLV for this approach.  Just slice it up so each piece is small enough to fit in the image data of a DNG (or any raw format Photos supports).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 13, 2022, 12:44:42 AM
Quote from: names_are_hard on August 12, 2022, 11:22:57 PMJust slice it up so each piece is small enough to fit in the image data of a DNG (or any raw format Photos supports).
Oh, yeah, that would definitely be abusing Amazon Photos. I'm not comfortable doing that
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on August 13, 2022, 02:40:42 AM
It's exactly what your current plan is: store the content of a filetype that's not covered, by splitting the data into multiple files that are covered.  You're only "storing images".  Both are equally against the spirit.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 13, 2022, 03:18:47 AM
Quote from: names_are_hard on August 13, 2022, 02:40:42 AMBoth are equally against the spirit.
I agree with you but it's a bit more egregious to try to pass non-image data off as image data (IOW data that has an image file extension but doesn't contain image data in the correct format for display). I mean, Amazon would definitely suspend my account
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on August 13, 2022, 03:37:13 AM
It would contain image data and would be displayed.  But I'm happy if you don't want to do this.  Just buy some cloud storage, really.  It'll be $10 a month or less and won't be randomly removed in the future like this Photos offer, and you can simply upload MLV without any of this fuss.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: orcslayer on August 14, 2022, 12:25:18 PM
Often I get app not responding error when exporting upscaled from MLV app. I dont remember this happening with previous versions. Any idea what might cause it?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 15, 2022, 08:00:56 PM
"Not responding" comes from Windows, as soon as MLVApp is waiting for ffmpeg to encode the current job - so nothing bad. Your export settings might cause this, if you e.g. use smooth aliasing.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ricardopt on August 16, 2022, 02:41:00 PM
Quote from: ilia3101 on August 07, 2022, 12:04:17 AM
You can implement F log yourself. Select rec2020 primaries(F log uses them), then write the log curve formula forums as transfer function (you'll need to google it to find the formula).

Hi ilia3101, ive looked/searched online but couldnt find any info about it. Do you know any specialized forum where i could find or ask for that info, almost all results point to logarithimic curves but thas nothing to do with video, the only result i could find was a pdf on the fujifilm website but cant make "head or tails" on how to write that formula, can you help?

https://dl.fujifilm-x.com/support/lut/F-Log_DataSheet_E_Ver.1.0.pdf

Thanks
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on August 16, 2022, 06:34:49 PM
That's the right document. I've seen it before, but thanks for digging it up.

I've translated the scene linear to F log curve in to MLV App's expression format. Here you go:

(x < 0.00089) ? (8.735631 * x + 0.092864) : (0.344676 * log10(0.555556 * x + 0.009468) + 0.790453)

It uses the ternary operator syntax, it's equivalent to an if statement. I guess that's a little confusing.

Just paste that in to the transfer function and select Rec2020 for Gamut. And you should uncheck 'allow creative adjustments'.

Should look like this:

(https://i.ibb.co/MfP4H1B/Screenshot-2022-08-16-at-17-33-55.png)

@masc Could we add this as one of the presets?


EDIT:

Also I recommend adjusting exposure *before* setting the log profile! It's impossible to judge exposure when viewing log (you're literally not meant to look at log encodings, they're encodings and not meant to be an image!!!).

Please export in 10 bit with this as well.


EDIT 2:

I still believe MLV App with AgX and one of the film filters is the best workflow out there for colour and tonality ;)

Big claim I will stand by.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 16, 2022, 08:16:11 PM
I started a repo to develop a 010 Editor Template for parsing MLV files. The trouble is I can't seem to get the fields to line up using the information provided in https://github.com/ilia3101/MLV-App/blob/master/src/mlv/mlv.h (https://github.com/ilia3101/MLV-App/blob/master/src/mlv/mlv.h) and https://github.com/ilia3101/MLV-App/blob/master/src/mlv/mlv_object.h (https://github.com/ilia3101/MLV-App/blob/master/src/mlv/mlv_object.h). If I comment out a bunch of fields and change the size of some of the fields I can get xRes and yRes to line up as expected, but obviously I'm doing something wrong if I have to comment out stuff.

Please see my repo and let me know if you have any thoughts: https://github.com/tdnelson2/MLV_010_Editor_Template (https://github.com/tdnelson2/MLV_010_Editor_Template)

Here's what it looks like when I run it on a MLV file in 010 Editor:
(https://i.ibb.co/YhGwP4T/010-mlv.jpg)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Bruno Italiano on August 16, 2022, 10:54:33 PM
Hope you will have good success.  8) :)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on August 17, 2022, 06:18:44 AM
Quote from: tdnelson2
I started a repo to develop a 010 Editor Template for parsing MLV files.

You have defined things as uint in the template when they are uint8_t in the struct def from the header.  Uint is probably size 4.  uint8_t is size 1.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 17, 2022, 06:37:41 PM
Quote from: names_are_hard on August 17, 2022, 06:18:44 AMUint is probably size 4.  uint8_t is size 1.
You are right! I'm looking again at the supported datatypes for 010 Editor and I see that I wrongly assumed uint was 8 bits long. Looks like they have it at 32 bits long: https://www.sweetscape.com/010editor/manual/DataTypes.htm (https://www.sweetscape.com/010editor/manual/DataTypes.htm).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ricardopt on August 17, 2022, 09:25:30 PM
Quote from: ilia3101 on August 16, 2022, 06:34:49 PM
That's the right document. I've seen it before, but thanks for digging it up.
I've translated the scene linear to F log curve in to MLV App's expression format. Here you go:
(x < 0.00089) ? (8.735631 * x + 0.092864) : (0.344676 * log10(0.555556 * x + 0.009468) + 0.790453)
......

thanks for yours and everyone's help, i done some tests and here's a video with side by side comparisons, all done in mlvapp, no color grading, just default values with exposure tweaking, only used an NLE for titling and "fx".

1 - mlavapp to f-log
2 - mlvapp with the f-log formula + AgX + fujifilm lut"
3 - mlvapp with tonemapped profile + AgX

Some videos look identical, others with f-log+lut look more "whitewashed" than the tonemapped ones, all a matter of personall preference i guess, look alike a good option for mlvapp.
Once again thanks.

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tdnelson2 on August 20, 2022, 10:20:22 PM
Quote from: tdnelson2 on August 16, 2022, 08:16:11 PMI started a repo to develop a 010 Editor Template for parsing MLV files.
OK. I've fully parsed a MLV file containing one frame. Am I right to assume the image data is located in "VIDF" blockTypes in the "frameData" field? Is this data in DNG format?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 21, 2022, 07:22:48 PM
Quote from: tdnelson2 on August 20, 2022, 10:20:22 PM
Am I right to assume the image data is located in "VIDF" blockTypes in the "frameData" field?
Yeaaa... see below...

Quote from: tdnelson2 on August 20, 2022, 10:20:22 PM
Is this data in DNG format?
No. But you could copy the imagedata of the VIDF block into a buffer and write this into a DNG - with correct metadata. No idea if any program could read the dng with incorrect metadata.

typedef struct {
    uint8_t     blockType[4];    /* this block contains one frame of video data */
    uint32_t    blockSize;    /* total frame size */
    uint64_t    timestamp;    /* hardware counter timestamp for this frame (relative to recording start) */
    uint32_t    frameNumber;    /* unique video frame number */
    uint16_t    cropPosX;    /* specifies from which sensor row/col the video frame was copied (8x2 blocks) */
    uint16_t    cropPosY;    /* (can be used to process dead/hot pixels) */
    uint16_t    panPosX;    /* specifies the panning offset which is cropPos, but with higher resolution (1x1 blocks) */
    uint16_t    panPosY;    /* (it's the frame area from sensor the user wants to see) */
    uint32_t    frameSpace;    /* size of dummy data before frameData starts, necessary for EDMAC alignment */
/* uint8_t     frameData[variable]; */
}  mlv_vidf_hdr_t;


See first variable in VIDF block.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on September 04, 2022, 05:47:13 PM
Observed some weird behavior, thought I'd report it here.

Using latest Danne's build for 5D3 113, shooting with 3.5K 1:1 centered x5 preset, and only happening with Dual ISO enabled:

- first frame is corrupted (upper pink noisy band, more often than not the case) => MLV App handles Dual ISO well, meaning that I just have to enable the "Dual ISO" switch in the Editor, and all is fine;
- when first frame is not corrupted => MLV App yields bluish output, and I have to force Vertical Stripes = OFF to fix this.

This is *not* a real problem of course -- just reporting it here as it seems to be a strong repeating pattern, so there must be a reason behind. Maybe will make ring a bell for some enlightened people buzzing around here?

Ciao

Sergio
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 05, 2022, 08:18:13 PM
Thanks for reporting. But it is known, you'll have to disable vertical stripes when using dualiso for 5D3 footage.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on September 05, 2022, 11:14:13 PM
Yup, that's what I knew.

What I'm reporting is that actually it turns out it is not always the case with the latest 5D3 builds: and more specifically, when the first frame is corrupted (often), then MLV App works fine even without disabling Vertical stripes.

Just a small curious thing (which would require more testing tbh). But I was surprised, so I thought I would report it.

Ciao

S
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 06, 2022, 08:26:08 AM
Quote from: vastunghia on September 05, 2022, 11:14:13 PM
... it turns out it is not always the case with the latest 5D3 builds: and more specifically, when the first frame is corrupted (often), ...
Ah okay... this is different then. Can't remember a corrupted frame in my 5D3 clips since a very long time. MLVApp gets some information reading the first frame and sets some settings with that - maybe this could be a reason for what you report.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on September 06, 2022, 07:00:43 PM
Nice. So for some reason when the first frame is corrupted MLV App reads it and sets something different, which leads Dual ISO debayering to work "out of the box" in the app.

S

PS: fyi slightly corrupted first frame (where 'slightly' refers to the fact that the frame can be read and exported successfully, even though it displays a small pink band in the first upper pixel rows) is the norm with the latest builds and all the 'one more hack' features by theBilalFakhouri enabled (check this thread: https://www.magiclantern.fm/forum/index.php?topic=26443.0 (https://www.magiclantern.fm/forum/index.php?topic=26443.0)). At least on 5D3.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 16, 2022, 05:51:34 PM
Little new feature in MLVApp, expecially for current SD UHS speed tests... MLVApp now shows data rate of clip!
(https://i.ibb.co/dLv681Y/datarate.png)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 16, 2022, 05:55:04 PM
Haha 👌👌👌
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on September 16, 2022, 05:56:27 PM
Nice one
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on September 17, 2022, 05:39:40 PM
Probably noob question, but.. what framerate should I set on export?
I read somewhere that most consumer devices can't play exactly 24 fps smoothly, they are made for 23,976.. and for example my monitor has 59.9hz instead of 60. It seems like clips with 23,976 fps (from camera standard .mov) play better, no tearing artefacts or stuck frames. While 24 fps exported from MLV App have such problems sometimes (on my computer at least).

Should I export to 23,976 to maximize compatibility?
And there is a problem, with standard .mov files from camera I can see framerate: 23.976024
If I export with MLV App I can only set 23,976 and it will be 23.976000

Is it not standard? will services like youtube transcode the file and change framerate to 23.976024? Maybe we need a preset for exporting 23.976024?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 17, 2022, 07:45:20 PM
If you want realtime playback, export without overriding the framerate. This option changes the playback speed! It exists for creating timelapse and slowmotion.

Quote from: Skinny on September 17, 2022, 05:39:40 PM
While 24 fps exported from MLV App have such problems sometimes (on my computer at least).
What problems one can get exporting?! Maybe you exported using a too high quality codec - so your PC can't playback?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on September 18, 2022, 12:54:00 PM
I often use 30 fps and export at 24 to create just a little slowmotion.

The problems are almost unnoticeable, sometimes I see frame tearing or slight stutter. You can barely notice it.
It is not only on my devices, for example https://www.avsforum.com/threads/fixed-apple-tv-4k-lacks-support-for-24-000-video.2961262/

So as far as I know, most consumer devices were made for 23,976 and not for true 24. Of course they can play 24 but it is not their native framerate. They usually have only one clock generator and it can't support both, so manufacturers choose 23,976 because it is more common. As well as 29,97 and 59,94 instead of 30 and 60...

Some info explained here https://github.com/mpv-player/mpv/wiki/Display-synchronization
They have to invent a lot of stuff to deal with this small difference between framerates..

And from what I see, it is just better to stick with 23,976 for the internet. But for now MLV App can only export at 23,976000 and not at 23,976024.
I don't really know if it should be exactly 23,976024. Or should it actually be 24 * 1000 / 1001 ?
I hope someone can clarify all this stuff..
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on September 18, 2022, 02:23:16 PM
Hard to see that 23.796000 should make any difference here. But since we are using ffmpeg you could specify exact fps output.
You can test exporting standard mov files to exact 23.976 and see if you can see any difference.
@masc. Should be possible to specify exact fps manually maybe?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 18, 2022, 03:08:36 PM
Can't believe that it is possible to see a difference. Example: between 24fps and 24000/1001, all 1000 frames there could be a jump of 1 single frame. 1000 frames happens after >41sec, and only if the scene is longer than that. For the difference between 23.976000 and 23.976024 it will need much longer. So I think a stutter because of this is impossible.
Yes, for ffmpeg you could write to the command 24000/1001 instead of 23.976, but entering into GUI is more complex and probably not really needed. For testing just change the code in export function.
You'll see a bad stutter if your monitor is force set to 60Hz and you playback ~24fps footage.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on September 20, 2022, 03:27:08 AM
hi masc,
just a question...
what is the different between mlvapp v1.14 static and dynamic?

thanks.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 20, 2022, 12:32:16 PM
Static: uses static Qt libraries compiled into the exe. Crosscompiled from bouncyballs linux OS
Dynamic: uses dynamic Qt libraries, dll files. Compiled from my windows OS

Qt version is different between both MLVApp versions. If one doesn't work for you, try the other.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on September 20, 2022, 01:04:22 PM
I have tried to compile MLV App on Windows but failed. Now I have installed macOSMojave10.14.6 through VirtualBox-6.1.38. I am on windows 11. I am trying to use "Compiler" app/script for macOS by Danne from first post. It seems to me a compiling goes good, but I can't  find MLV.App.xxx.zip file in MLV_App_Master folder. What is the problem?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 20, 2022, 02:41:19 PM
@vstrglv: can't help with compiler.app, but what was the problem on Windows? Which Qt version did you use? What compiler did you use?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on September 20, 2022, 03:51:26 PM
Quote from: masc on September 20, 2022, 12:32:16 PM
Static: uses static Qt libraries compiled into the exe. Crosscompiled from bouncyballs linux OS
Dynamic: uses dynamic Qt libraries, dll files. Compiled from my windows OS

Qt version is different between both MLVApp versions. If one doesn't work for you, try the other.
i see,
both work for me... thanks masc.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on September 24, 2022, 10:57:00 PM
Quote from: masc on September 20, 2022, 02:41:19 PM
@vstrglv: can't help with compiler.app, but what was the problem on Windows? Which Qt version did you use? What compiler did you use?
Sorry for delay. I have tried to compile MLVApp on Mac and Windows.
I have installed macOSMojave10.14.6 and Qt5.12.10  through VirtualBox-6.1.38. After several attempts i have gotten MLVApp.dmg.
Then i tried to compile on Windows 11. Also Qt5.12.10. Compiled MLVApp.exe requests some dlls. Windeployqt helps to add several dlls to MLVApp.exe folder, but not all requested. After adding manually dlls (the whole number is 9) plus "platforms"folder with  qwindows.dll MLVApp.exe works. I have tried to compile MLVApp.exe with dlls inside exe many times but failed. At last i've red your masc post:
Quote from: masc on September 20, 2022, 12:32:16 PM
Static: uses static Qt libraries compiled into the exe. Crosscompiled from bouncyballs linux OS
Dynamic: uses dynamic Qt libraries, dll files. Compiled from my windows OS
I downloaded  MLV.App.v1.14.Win64.dynamic.zip, opened it and saw that there were more files and folders than in my case. I deleted additional files and folder (which were missing in my compilation) but MLVApp.exe works.
What is the reason for this additional files and folders?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 28, 2022, 12:13:41 PM
Yay. Congrats @vstrglv! Fine.
If you got MLVApp.dmg, it means you also used macdeployqt? windeployqt is more or less the same for Windows.
Why the folders and files: _deployqt scanns the app and searches+provides all used libraries. For the GUI functionality, we did not reinvent the world, but we used the Qt development system. This is like a puzzle. And the parts of the puzzle are in the .dlls on Win or .dylibs on macOS. The app can't work without this. When using our .dlls, take care: the app will not be stable, if you used another Qt version. The compiled app must get the libraries from the Qt used for compiling. With some luck it might work here and there, but I would not guaranty. You should find all the files I used in your Qt and minGW folder - with those you should be fine.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vstrglv on September 28, 2022, 03:28:30 PM
Thank you masc! I have deleted MLVApp.dmg already, so don't remember about using windeployqt. But I guess I did not use it. I have tried Qt 5.13.2 and 5.14.2 also. It works. I added 9 DLLs plus "platforms"folder with  qwindows.dll manually. The only problem was to find libgomp-1.dll. It was absent in Qt 5.14.2 folder
Sorry found out. C:\Qt\Qt5.14.2\Tools\mingw730_64\x86_64-w64-mingw32\lib
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on September 29, 2022, 05:01:44 PM
I'm using MLVapp for a shooting this week and loving it as always. I was wondering is there a preset that doesn't apply the hidden +2 exposure that the software gives? Also is the transfer function only affecting the gamma part of the preset right? There are more hidden numbers about colours I guess. I'm not sure I get it right.

edit: a bug, the installed bad pixel map visually shifts place if you load it again, it fixes itself as soon as you place another correction. Also how can I export it?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 29, 2022, 06:59:49 PM
@togg: maybe Ilia can tell something about this. I remember, in the very old days there was this "cheat factor", if it still exists today - no idea. The transfer function includes the gamma and more maths.

Could you explain more about this bug? Sry, I really did not understand what you mean exactly. Could you please describe how to reproduce?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on September 30, 2022, 12:55:24 PM
Yeah I thought MLV App has an exposure factor of +1 or 2 by default. But I couldn't find it in the code just now, so I don't know anymore, could it be in the interface??

Why do you feel a need to undo this 'hidden exposure'? You could undo this gain by setting exposure to -1 or whatever, but... there's also white balance, which in itself increases blue and red by about +1, is that not hidden exposure?... do you want to undo that? What's your definition of 'no hidden exposure'? There's also highlight reconstruction, which (unpredictably) extends the dynamic range of your data by a couple of stops (above the cameras max white level), so... are those considered a part of the dynamic range? Should you decrease exposure to fit those in? I think it's useful sometimes, so maybe. Plus the camera matrix distorts values, and the resulting RGB values are often much higher than the camera's white level, or even negative 😱

Transfer function is a better word for gamma, yes. But there's nothing stoppping you from adding an exposure multiplier in to the expression.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on September 30, 2022, 03:27:21 PM
Well just to have a preset by default with a "clea" option, nothing fancy. I like the loo of the tone mapped preset though.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 30, 2022, 04:28:55 PM
Quote from: ilia3101 on September 30, 2022, 12:55:24 PM
Yeah I thought MLV App has an exposure factor of +1 or 2 by default. But I couldn't find it in the code just now, so I don't know anymore, could it be in the interface??
Yes, Ilia, you're right:
void MainWindow::on_horizontalSliderExposure_valueChanged(int position)
{
    double value = position / 100.0;
    processingSetExposureStops( m_pProcessingObject, value + 1.2 );
...
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 01, 2022, 01:52:24 PM
Thanks @masc.

So the exposure offset is 1.2

Quote
Well just to have a preset by default with a "clea" option, nothing fancy. I like the loo of the tone mapped preset though.

Then you could try setting the following:
- rec709 preset (it does nothing aesthetic, it simply encodes with the rec709 transfer function, which video players should decode with)
- exposure -1.2
- disable creative adjustments
- as a bonus: you can lock the white balance to 6504K to get the most absolute colorimetry

It would be:
- techincally the most 'colour accurate' output you can get (except where it clips), in a silly absolute way
- hideously ugly
- a very inefficient encoding in terms of preserving data (unlike log ;))
- you'd still lose data by clipping due to the following: 1. white balance 2. the limited rec709 primaries
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on October 01, 2022, 09:39:15 PM
I think that it is the right choice to have this boost of exposure and the tone mapping by default, but I do think that it woudl be better to have the exposure boost removes in the rec preset, at least to understand what's going on. The shadows clearly becomes noisy at +1.2, if you can get more light it's better to do so, the first result that MLV app provides and the difficulty to understand what's going on can be misleading.

Also I was wondering, could there be a way to fix the missing header error inside MLV App? I need to try to recover a few shoots that probly got corrupted because of a dying card and I will start looking for other tools.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 02, 2022, 01:19:34 PM
Quotebut I do think that it woudl be better to have the exposure boost removes in the rec preset, at least to understand what's going on

Disagree. Still cameras like our Canons usually leave 1 or 2 stops of highlight headroom, so 18% on the sensor is not meant to be 18% (middle grey) on the final image. That would leave no room for any kind of smooth roll-off curve.

This headroom also ends up being different on each channel, smallest on green, highest on red/blue, depending on the white balance, so which channel would you use as a reference point? They all get boosted/reduced during white balance, you can't really have no exposure... So why not just place middle grey sorta where the manufacturer intends!

Cine cameras like the Arri Alexa (and even the sigma FP at some ISO settings) leave 7+ stops of headroom above middle grey. That requires a masive amount of 'hidden exposure' during processing to match what the operator saw on the screen, or... to realise this isn't 'hidden exposure'. It's how the camera is engineered.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on October 02, 2022, 03:34:47 PM
Well you're describing how digital exposure is allocated. Of course you can bring it up in post, or log allocates it better. The thing is that in this case MLV app clearly gives out a noisier picture by default. Maybe because it doesn't do any kind of smoothing that the camera would automatically do on the jpeg, I don't know. I like it because I appreciate the cheated dinamic range boost, but it still feels very noisy. It's a hidden number that you cannot discover on the program, this of itself is an issue in my opinion.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 03, 2022, 05:13:56 PM
MLV is noisier than JPEG mainly because it's lower resolution with the same noise level. Signal to noise ratio ends up worse at viewing scale. And yeah, also the fact MLV App doesn't do chroma denoising by default.

Do you also want to know the values of the hidden camera matrix? It distorts all the hues if you think about it, and it means the camera's RGB channels do not correspond to the RGB channels that are output. But it's there for colour management. Without it you'd get pale colours and wrong hues.

I think of this 'hidden exposure' gain as another (admittedly less critical) form of camera calibration, just like the camera matrix.

And I still don't believe 'no exposure' is meaningful, as you must first make a choice about how you anchor the white balanced channels, which in itself, is an exposure choice. MLV App makes this choice by matching the luminance of before and after (which will produce some pink highlighs at 0 exposure, as the lowest clipping channel will end up below 1.0), but you could also make it such that the earliest clipping channel = 1.0 (this way they all clip at or above 1.0, so 0 exposure will not produce pink highlights, probably the best option for this), or you could make it so the highest clipping channel = 1 to preserve the most data, but then you'd get very visible pink highlights at 0 exposure.

Everything is relative. And there is no image in the raw file, it must be created.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on October 05, 2022, 07:45:52 AM
I was also comparing it with the dngs imported on photoshop camera raw, but then again I vastly appreciate the mlvapp default look.

Do someone knows where the bad pixel map is located?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 05, 2022, 11:34:14 AM
Adobe Camera RAW brings a very similar amount of noise and similar looking results, when I compared both. At least if you setup the chroma denoiser sliders to comparable values.

The bad pixel maps are in the same path as the mlvapp executable and focus pixel maps, after you created one. It has the .bpm ending.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on October 05, 2022, 12:00:49 PM
neat location, found it thanks :)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 05, 2022, 03:04:08 PM
QuoteI was also comparing it with the dngs imported on photoshop camera raw

Oh ok. I wouldn't even claim MLV App matches the exposure correctly. The 1.2 stops is just an absolute guess. Adobe camera raw probably knows better about this stuff (at least on CR2s)... although in the case of DNGs generated from MLV, the exposure offset metadata may be missing, so it's possible camera raw doesn't do the 'hidden exposure' with those. Just guessing.

If you have any interest in doing it, I'd love to see a comparison between:
1. CR2 photo through camera raw
2. MLV video through MLV App
3. A DNG created from that MLV, through camera raw

Where the MLV and the CR2 use the same aperture, ISO and shutter settings. ISO 100/200/400/800, not the inbetween steps. I'd do it myself if I had Adobe software.

My (likely wrong) prediction: 1 and 2 exposure will match, but 3 will be darker.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on October 06, 2022, 07:13:31 PM
I can surelly do this test. I will also had Resolve to the equation, since that is the main comparison.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on October 07, 2022, 03:24:14 PM
Hello,

I compiled the latest MLVApp build on OSX, and rendering clips now takes roughly 2X Longer compared to the Official Version 1.14 (I compared side by side)

Is it a compiling problem on my end, or because some Quality enhancement happened? (I tried Prores 422 and H264)

I have:

OSX 10.13.6
Qt 5.15.2
Qt Creator 5.0.2
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 07, 2022, 04:53:25 PM
Probably bot compiling with openmp.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on October 07, 2022, 06:20:19 PM
Quote from: Danne on October 07, 2022, 04:53:25 PM
Probably bot compiling with openmp.

Sorry, I am not familiar with the terminology. If you mean compile with the script you created here:

https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/mlv_app_compiler.dmg

, it says it needs osx 11 to work. Is that what you meant?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 07, 2022, 08:11:42 PM
Try googling the term.
When you compile. Do you see the word openmp in terminal?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on October 07, 2022, 09:02:57 PM
Quote from: Danne on October 07, 2022, 08:11:42 PM
Try googling the term.
When you compile. Do you see the word openmp in terminal?

As I am not a Coder, google Algo gives me unrelated responses. If you can send me one of your google query results, I'll be able to start from there.

Here is the terminal output of the compiling script (To the left) And the Qt GUI output (To the right)
The script doesn't give me an app, but I get an app with Qt (The App works, but export is slow)

(https://i.ibb.co/YpbycFj/Compilers-Output.png) (https://ibb.co/XSV37rJ)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 07, 2022, 11:51:47 PM
Maybe better you configure from scratch on your system.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on October 08, 2022, 02:07:36 PM
Quote from: ilia3101 on October 05, 2022, 03:04:08 PM
Oh ok. I wouldn't even claim MLV App matches the exposure correctly. The 1.2 stops is just an absolute guess. Adobe camera raw probably knows better about this stuff (at least on CR2s)... although in the case of DNGs generated from MLV, the exposure offset metadata may be missing, so it's possible camera raw doesn't do the 'hidden exposure' with those. Just guessing.

If you have any interest in doing it, I'd love to see a comparison between:
1. CR2 photo through camera raw
2. MLV video through MLV App
3. A DNG created from that MLV, through camera raw

Where the MLV and the CR2 use the same aperture, ISO and shutter settings. ISO 100/200/400/800, not the inbetween steps. I'd do it myself if I had Adobe software.

My (likely wrong) prediction: 1 and 2 exposure will match, but 3 will be darker.

Quote from: masc on October 05, 2022, 11:34:14 AM
Adobe Camera RAW brings a very similar amount of noise and similar looking results, when I compared both. At least if you setup the chroma denoiser sliders to comparable values.

Well I did the tests and it looks like you were indeed right :)

exposure on MLVapp match both CR2 on ACR and rec709 2.4 gamma on davinci raw panel.
MLV's dng in ACR don't match, need that 1.2 boost and higlight roll off.
dng treated as blackmagic color space + bmcc to recv2 in last node of Davinci don't match, same thing.

The last case is what I am more interested in and where I was trying to get bet results by default. That's where my mistake originated. I understand now that for a non-tandard dng you need to give that boost that is done as a gamma correction by default on native solutions. Sorry for the confusion!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 08, 2022, 03:31:29 PM
Quote from: gabriielangel on October 07, 2022, 09:02:57 PM
As I am not a Coder, google Algo gives me unrelated responses. If you can send me one of your google query results, I'll be able to start from there.

Here is the terminal output of the compiling script (To the left) And the Qt GUI output (To the right)
The script doesn't give me an app, but I get an app with Qt (The App works, but export is slow)

(https://i.ibb.co/YpbycFj/Compilers-Output.png) (https://ibb.co/XSV37rJ)
If you compile MLVApp with Apple standard Clang compiler, you get what you're talking about. All the app works, looks the same, all features available, BUT: it is slow, because OpenMP is not available with Apple's compiler. We use it a lot for accelerating some algorithms. Those algorithms work single threaded for you now. You can change that, but the workflow is a little complicated, when doing it manually. With Dannes compiler app, all this should be done automatically, if I remember right.
You must install llvm compiler via brew, because this one has OpenMP included. Then you configure a new toolchain in Qt settings, using this llvm compiler with the Qt version installed in one "kit". Then, on the top of the mlvapp.pro file, there are some compiler configuration lines commented out. Search for the section which describes your system and uncomment the lines. Then, add the new toolchain for your project, qmake, build.
For making the app working without Qt, you must use Qt "macdeployqt" - this copys all needed libraries into the .app and makes it running without Qt SDK.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 08, 2022, 05:03:51 PM
I think my app needs some rework  8). I messed around with it when getting it to compile on my Macbook pro m1 so I am not sure about status with it atm. Lots of good stuff in there though to get most of it done :).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on October 08, 2022, 11:38:58 PM
Thank you for the replies.

Keep in mind, it took me 8 hours to find the proper Qt version and download everything on my system. So all of this is beyond my current "Do-it-in-a-timely-manner" Capabilities.
I just needed the latest MB/s and filesize display, and the Histogram lines (Which are brillant additions by the way).

So I will use my compiled version for setup, and render in the official version, until the Official release.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 10, 2022, 01:04:34 PM
Could you test this version mac version?
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/MLV_App.zip
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 11, 2022, 09:58:06 PM
Quote from: Danne on October 10, 2022, 01:04:34 PM
Could you test this version mac version?
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/MLV_App.zip
No luck for me to start. Looks like macOS blocks the start, but all known terminal commands don't help here.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on October 11, 2022, 10:29:03 PM
Thanks. Compiled with an older compiler. Rework needed but will personally stick with the M1 version for now.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on October 14, 2022, 03:47:37 PM
Hello.
Canon 650d. Shooting in the morning with dual iso 100/400 fusion with the sun. After incorporating dual iso in mlvapp -  appears a strange spot in the sun:
(https://i.ibb.co/TWYR01D/M14-0716-000051.jpg) (https://ibb.co/FHmJYXk)
Photo with dual iso - in order
Sources:
https://mega.nz/folder/HlxkhZaa#xB_W3KI5mMn9mwOHuhiB8g (https://mega.nz/folder/HlxkhZaa#xB_W3KI5mMn9mwOHuhiB8g)
Is there any way to fix this? Such a problem on many source videos
(Highlight Reconstruction and White Level Change - do not help)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: elenhil on October 15, 2022, 08:18:37 AM
See the answer to a similar question here: https://www.magiclantern.fm/forum/index.php?topic=26593.msg239861#msg239861

Отправлено с моего SM-G965F через Tapatalk

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 15, 2022, 11:04:04 AM
For the high iso part of the dualiso image, the sun is very overexposed. I don't know about an easy fix for that. What I did in past: Use a small round object layer with the correct sun color and move it with tracking over the bad area.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 16, 2022, 10:18:55 PM
Just realised the black sun effect could be used as information to extend dynamic range in processing. Would need a fancy new algorithm tho.

Does anyone know how to increase likelihood of black sun effect without using dual ISO?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on October 16, 2022, 10:28:43 PM
AFAIK firmware will do black sun surpression on its own. No idea how to untweak the tweak.

On second thought: Silent pic may work.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: elenhil on October 17, 2022, 12:49:43 PM
Indeed. FRSPs all suffer from this effect.

Отправлено с моего SM-G965F через Tapatalk

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 17, 2022, 01:46:45 PM
Oh interesting. Thanks for the FRSP idea.

But what about simple MLV videos? It seems pretty uncommon there, at least on 5D3.


QuoteAFAIK firmware will do black sun surpression on its own.

😢😢
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Kharak on October 17, 2022, 05:34:37 PM
I cant speak for mlv app, but working with dng in resolve, any clip with log conversion applied with the sun directly in shot will most likely give you "black sun" (pink) artifact.

Color managed workflow:
Input: Linear
Output Color space: <C-log2, Log-c or <slog 2 etc
Output Timeline color space: <C-log2, Log-c or <slog 2 etc

Basically any log conversion that stretches the dynamic range beyond its input will show pink sun artifact.

I usually counter it by tracking a power window on the sun with Lens Blur and increasing green channel output until the magenta turns white(neutral).

Edit: those DNG's have already been darkframe subtracted, not sure if that is causing the black sun artifact.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: tupp on October 19, 2022, 12:12:38 AM
Quote from: Icaab on October 14, 2022, 03:47:37 PM
Is there any way to fix this? Such a problem on many source videos
(Highlight Reconstruction and White Level Change - do not help)
I am not familiar with the peculiarities of ML Dual ISO nor FRSP.

However, would the recently added Sobatka AgX trasnsform help in reducing this clipping/black-sun problem?

Troy Sobatka also made a "Filmic" Blender module, which has been adapted to Darktable, and which seems to deal well with clipping and tonal shifting in the highlights:

https://www.youtube.com/watch?v=bnfBgK3j1Bg&t=165s (https://www.youtube.com/watch?v=bnfBgK3j1Bg&t=165s)
https://www.youtube.com/watch?v=bnfBgK3j1Bg&t=165s


It would be great if MLV App featured a similarly versatile "filmic" module!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on October 20, 2022, 05:53:46 PM
Quote from: Kharak on October 17, 2022, 05:34:37 PM
I cant speak for mlv app, but working with dng in resolve, any clip with log conversion applied with the sun directly in shot will most likely give you "black sun" (pink) artifact.

Ah yes the "black sun" can show up as pink, I forgot! I see that all the time. Thanks for reminding me.


Quote from: tupp on October 19, 2022, 12:12:38 AM
However, would the recently added Sobatka AgX trasnsform help in reducing this clipping/black-sun problem?

It could help hide it, if it's pink, thanks to it's stronger film-ish highlight desaturation. But it won't truly fix it.

Black/pink sun needs to be handled at the raw correction stage.


Quote from: tupp on October 19, 2022, 12:12:38 AM
Troy Sobatka also made a "Filmic" Blender module, which has been adapted to Darktable, and which seems to deal well with clipping and tonal shifting in the highlights:

Yes, filmic was created a few years ago. AgX is basically Troy's replacement for filmic, it's better. It might get added to Blender soon as well.

And while darktable filmic is "inspired" by Troy's filmic, it works totally differently, and the aesthetic is different.


Quote from: tupp on October 19, 2022, 12:12:38 AM
It would be great if MLV App featured a similarly versatile "filmic" module!

It has so many parameters that don't make any meaningful change and just cause weird tonality distortions that don't look good whichever way you pull the slider. I don't love it.

I implemented AgX in MLV App because it was super convenient. The source code is a spaghetti house of cards and can't take much.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on December 05, 2022, 12:41:56 AM
Hello,
The Value Lines added in the Histogram/Waveform/Parade are really useful, especially when exporting to Alexa Log-C. It allows to set the proper brightness (Slightly brighter than normal) to get an accurate color rendition and contrast.

As Canon outputs certain colors very saturated (Especially when using agX), it would be a nice addition to have a graph similar to the Waveform Monitor, but displaying the Chroma (For example, a chroma value between 10-15/127 gives the best skin tones)

It would also be helpful if the value would display under the cursor when pointing on the graph, or have one user set value to add a reference line.

Those additions would make it possible to squeeze the most out of the Raw, before going to Log-C 422, and then use DaVinci tools only for minor tweaks/ power windows.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: dpjpandone on December 07, 2022, 02:16:33 PM
Can someone briefly explain the difference between vertical stripes and fixed pattern noise? I used to experience vertical stripes with the 7d and 5d, I don't seem to get them with the EOSM. It seems that either algorithm can be used to treat the vertical stripes, which one is superior? If you have firsthand experience with EOSM can you please share your raw processing settings? I would like to do the bare minimum raw processing in MLV app and treat the files for noise in Resolve.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on December 26, 2022, 08:27:17 PM
@dpjpandone

Vertical stripes are like a different ISO in each column (multiplicative), same pattern repeats every 8 columns.

Fixed pattern noise is an offset (additive) - specific to each pixel, not repetitive or preditable.

Algorithm for one will not really fix the other.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 07, 2023, 11:55:59 PM
Hi, I use Dual ISO a lot and I thought about trying to understand that part of the code in MLVApp and see if it can be optimized or at least divide it on parallel tasks to speed things up on Apple silicon.

I installed the latest Qt 6.4.0, the latest llvm 15, did some changes so the code will compile on the new Qt version and everything looked fine at first... I was getting a few more fps with less CPU usage while playing MLV (20fps vs 17fps on the current Apple silicon release), DNG export worked, but export to other video formats where video and audio are combined is failing.
When the progress gets to 100%, it stays at a 100%, the separate video "_tmp" and audio files are generated, but they are not joined and I have to abort the export.

Any idea where to start debugging? Wasn't MLVApp using ffmpeg for the compression process? Thanks a lot!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 08, 2023, 05:34:00 AM
Those fixes for latest llvm should be ported or included in first post maybe?
Try replacing ffmpeg with the apple silicon version here.
http://www.osxexperts.net/
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 08, 2023, 08:38:42 AM
Quote from: Danne on January 08, 2023, 05:34:00 AM
Those fixes for latest llvm should be ported or included in first post maybe?
Try replacing ffmpeg with the apple silicon version here.
http://www.osxexperts.net/
Thank you, I'll try this afternoon :)
I wanted to have everything working properly and replace as much deprecated code as I can before posting, but it was very straightforward,  just minor changes required
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 08, 2023, 11:52:40 AM
Quote from: iaburn on January 07, 2023, 11:55:59 PM
Hi, I use Dual ISO a lot and I thought about trying to understand that part of the code in MLVApp and see if it can be optimized or at least divide it on parallel tasks to speed things up on Apple silicon.
Cool!

Quote from: iaburn on January 07, 2023, 11:55:59 PM
I installed the latest Qt 6.4.0, the latest llvm 15, did some changes so the code will compile on the new Qt version and everything looked fine at first... I was getting a few more fps with less CPU usage while playing MLV (20fps vs 17fps on the current Apple silicon release), DNG export worked, but export to other video formats where video and audio are combined is failing.
You think this is possible? Qt 6.4.0 doesn't support QtMultimedia as Qt5 did - so some things (mostly audio based, and I think some of the graphics viewer features) don't work anymore. It was the reason why I stopped porting. Did you find a solution for this?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 08, 2023, 04:03:56 PM
Quote from: masc on January 08, 2023, 11:52:40 AM
Cool!
You think this is possible? Qt 6.4.0 doesn't support QtMultimedia as Qt5 did - so some things (mostly audio based, and I think some of the graphics viewer features) don't work anymore. It was the reason why I stopped porting. Did you find a solution for this?

Hi, regarding audio, yes, I had to replace a couple of things like QAudioOutput by QAudioSink, but the compiler was not complaining about any graphic function and seems to be working.
I would need to test a bit more, because there are some methods of QAudioFormat that are missing on the new version (setCodec, setByteOrder, setSampleType). I commented them out and audio was playing normally, but needs to be cheked.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 08, 2023, 04:56:58 PM
Wow. Interesting! Do you have a fork on github? I would be really interested how you did that!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 08, 2023, 05:30:45 PM
Really cool of this gets fixed iaburn. My roundtrip right now for apple silicon compiling includes way too much hacking. Updates most welcome.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 08, 2023, 06:08:08 PM
Hi,

I've updated a fork of the repository here: https://github.com/anibarro/MLV-App-Test (https://github.com/anibarro/MLV-App-Test)

For now I was just quickly changing a few things to get it compiled, so it's just for you guys to see that it's almost the same code and it works a bit faster with the updated tools, but don't trust the code because it's the first time I see "Qt" and I just got the Macbook Pro this Christmas :D

About the video export issue, I updated to the latest ffmpeg for Apple silicon and realised that the problem is just happening with "Apple AVFoundation", all the other ffmepg configs work fine.

Edit: Just noticed that the compiled MLV App is much smaller than the one available and it doesn't include the plugins folder, I guess it's loading them from the Qt installation
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 08, 2023, 06:39:57 PM
Cool! Will check within a few days.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 08, 2023, 07:10:00 PM
Quote from: iaburn on January 08, 2023, 06:08:08 PM
I've updated a fork of the repository here: https://github.com/anibarro/MLV-App-Test (https://github.com/anibarro/MLV-App-Test)
Thanks! I'll have a look soon!

Quote from: iaburn on January 08, 2023, 06:08:08 PM
About the video export issue, I updated to the latest ffmpeg for Apple silicon and realised that the problem is just happening with "Apple AVFoundation", all the other ffmepg configs work fine.
AV Foundation is not ffmpeg. It is original Apple encoder. Maybe you need to install the pro video codecs package from Apple.

Quote from: iaburn on January 08, 2023, 06:08:08 PM
Edit: Just noticed that the compiled MLV App is much smaller than the one available and it doesn't include the plugins folder, I guess it's loading them from the Qt installation
Finally you need to run macdeployqt. Then the libs, plugins and frameworks are included.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 08, 2023, 10:29:47 PM
Quote from: masc on January 08, 2023, 07:10:00 PM
Thanks! I'll have a look soon!
AV Foundation is not ffmpeg. It is original Apple encoder. Maybe you need to install the pro video codecs package from Apple.
Finally you need to run macdeployqt. Then the libs, plugins and frameworks are included.

Thanks for the macdeployqt tip :) It crashed at first but I saw somewhere that apps must be signed for M1 and it worked after signing it.
The AV Foundation export still fails for some reason.

I did a quick export test with a video including some effects and a LUT. Export to prores 422 with ffmpeg took 2:40 vs 3:00 on the current build
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 08, 2023, 11:10:10 PM
Could you share a test build?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 08, 2023, 11:49:56 PM
Quote from: Danne on January 08, 2023, 11:10:10 PM
Could you share a test build?

Sure, I've pushed everything, including the build here:
https://github.com/anibarro/MLV-App-Test/tree/master/platform/build-MLVApp-Qt_6_4_2_for_macOS-Release
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 08, 2023, 11:56:32 PM
Thanks. I'll have a deeper look tomorrow.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 09, 2023, 08:14:31 AM
Could we test a version working with MacOs Monterey? Allow for 12.0 versions too? Right now it´s 13 only. Sorry for not testing to compile myself but want to try backwards compatibilty.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 09, 2023, 10:20:41 AM
I've updated the compiled app with version 11 compatibility, but not sure if it will work.
I changed to version 13 only because I was getting these warnings:

ld: warning: dylib (/opt/homebrew/opt/llvm/lib/libomp.dylib) was built for newer macOS version (13.0) than being linked (11.0)
ld: warning: dylib (/opt/homebrew/opt/llvm/lib/libunwind.dylib) was built for newer macOS version (13.0) than being linked (11.0)
ld: warning: dylib (/opt/homebrew/opt/llvm/lib/libunwind.dylib) was built for newer macOS version (13.0) than being linked (11.0)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 09, 2023, 11:02:25 AM
Cool. Works for Monterey 12.2.1. Fast tested opening a MLV from my eos m.
Exporting with AV Foundation works over here.
More testing needed but good work I say.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 09, 2023, 06:34:44 PM
@iaburn:
Thank you for this great work, and for trying again. Now there is QtMultimedia again. This did not exist when I tried it last time. So now there is audio playback. Yay. Here my findings as far:
- Your compiled version runs on macOS 11.7.1 on M1
- It processes with identical speed as the latest revision with Qt 5.15.2, playback speed is also identical.
- Sound playback is working
- AVFoundation is working, at least without sound. When attaching the sound via ffmpeg onto the Apple encoded video, the app hangs. That is what you described. Without sound the video is fine.
- Darkthemes are broken. No idea why. I tried updating to the latest theme revision - same problem. The theme test application works fine. More work needed.
- Export settings preset saving is broken
- I was able to compile on IntelMac with BigSur

--> not bad for that try!!!  8)

Now another thing came into my mind: compatibility. For latest OS - Windows 11 and macOS13 - it would be awesome to use Qt libraries which are officially supported. There are some problems with both. On the other side Qt5 works from macOS 10.9.5 and from Win7 up to latest OSes, while Qt6.4 works from macOS 10.14 and Win10. Many users could not use MLVApp if we just offer a Qt6.4 version, including myself: all my Macs appart from my M1 Macbook could not run MLVApp. I'd like to make a suggestion: what about making the app beeing able to be compiled with both Qt versions? I started adding your code into our old code with some precompiler instructions. I already get it compiled with both Qts.

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 09, 2023, 07:41:49 PM
Quote from: masc on January 09, 2023, 06:34:44 PM
- It processes with identical speed as the latest revision with Qt 5.15.2, playback speed is also identical.

Could you please download this MLV and post your FPS while playing? https://we.tl/t-Zsfm6jvHNU
I get 14fps with the old build and 16fps with Qt 6.4 on a M1 Pro 10c CPU/16c GPU

I'm happy that I decide to try the new Qt version and that motivates you guys to update :)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 09, 2023, 10:42:15 PM
Downloaded your file and tested on my MacBookAir M1 8c CPU/ 8c GPU / 16GB RAM, BigSur 11.7.1, MLVApp default settings:

Latest commit on 5.15.2: 13fps
Your version: 14fps

Funny. With my testclips I got identical speed.

But another finding:
-focus pixel map installation fails.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 09, 2023, 10:49:59 PM
Focus map install worked when I put Mlv App on desktop. Maybe a path issue also in other builds? Didn't check
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 09, 2023, 11:08:53 PM
Quote from: masc on January 09, 2023, 10:42:15 PM
Funny. With my testclips I got identical speed.

But another finding:
-focus pixel map installation fails.

I noticed the biggest difference with 5K frtp recordings, like 16fps vs 20fps.

Quote from: Danne on January 09, 2023, 10:49:59 PM
Focus map install worked when I put Mlv App on desktop. Maybe a path issue also in other builds? Didn't check

Focus pixel maps downloading works for me also
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 10, 2023, 07:54:16 AM
I am compiling for M1 but with older quicktime. Testing against you build iaburn and getting identical speed on your test clip and 5kfrtp. 16fps and 25fps previewing speed on both arm64 compilations. I guess you are comparing non arm64 vs arm64 versions?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 10, 2023, 08:44:14 AM
Quote from: Danne on January 10, 2023, 07:54:16 AM
I am compiling for M1 but with older quicktime. Testing against you build iaburn and getting identical speed on your test clip and 5kfrtp. 16fps and 25fps previewing speed on both arm64 compilations. I guess you are comparing non arm64 vs arm64 versions?

I downloaded again the app just in case (https://github.com/ilia3101/MLV-App/releases/download/QTv1.14/MLV.App.v1.14.macOS-ARM64.dmg), tried with different videos and I get consistently faster play speed on the newer build.

For instance this clip: https://we.tl/t-jHdkVfhYzL (https://we.tl/t-jHdkVfhYzL) quickly fluctuates between 22 and 23fps on the new build and on the current one it plays between 18 and 19.

Not sure what could be the reason, but I mentioned a warning before about the openMP runtime library that seems to be dynamically linked and was compiled on my system for macosx 13, so I guess it's different than yours.
The newer version might be more optimized because the new build is playing faster while using less CPU resources on my system ( MacOS Ventura 13.1, M1 Pro 10c CPU/16c GPU, 32GB)  ::)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 10, 2023, 08:50:18 AM
Could you try my version?
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/MLV_App.zip

MacOS monterey 12.2.1

  Model Identifier:   MacBookPro18,3
  Chip:   Apple M1 Pro
  Total Number of Cores:   10 (8 performance and 2 efficiency)
  Memory:   16 GB


Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 10, 2023, 09:18:24 AM
Quote from: Danne on January 10, 2023, 08:50:18 AM
Could you try my version?
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/MLV_App.zip

With yours I get the same speed as with the "old" build, slower than the one I compiled.
Inspecting the package content I noticed that my package includes different plugins than yours and the official app build, that could be a reason also...
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 10, 2023, 05:01:42 PM
Could you please try to compile latest revision on MLVApp repos? If you like: test both, Qt5.15.2 AND Qt6.4. Is that working for you too? And is this still faster than the official build? I compile with llvm11. You compiled on llvm15? Maybe this one is more optimized.

If the difference is in anamorphic footage: this one uses AVIR scaling in MLVApp viewer. That is no Qt code. It is standard C++ code, even without openMP.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 10, 2023, 06:24:13 PM
Quote from: masc on January 10, 2023, 05:01:42 PM
Could you please try to compile latest revision on MLVApp repos? If you like: test both, Qt5.15.2 AND Qt6.4. Is that working for you too? And is this still faster than the official build? I compile with llvm11. You compiled on llvm15? Maybe this one is more optimized.

If the difference is in anamorphic footage: this one uses AVIR scaling in MLVApp viewer. That is no Qt code. It is standard C++ code, even without openMP.

I tried with Qt6.4 because for some reason the instructions to compile with Qt5 where not working for me...

I compiled with llvm15, yes. If you guys are compiling with an older version, that is most likely the reason.

I think the difference is more obvious on 5k anamorphic because it's close to 20fps, so same % increase translates into more fps gain.
Some modes play at very low fps so fps gain is also small, and some others like 1080 are already playing at full speed.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 10, 2023, 06:44:37 PM
So the latest additions on main MLVApp repository compile fine for you on Qt6.4? I added your changes combined with some precompiler #if instructions for supporting both, Qt5.6+ and Qt6.4+.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 10, 2023, 11:47:04 PM
Quote from: masc on January 10, 2023, 06:44:37 PM
So the latest additions on main MLVApp repository compile fine for you on Qt6.4? I added your changes combined with some precompiler #if instructions for supporting both, Qt5.6+ and Qt6.4+.

I tried your updated code stright away and it worked, but it was slower (13fps vs 16fps that I was getting on my test clip), but the AVFoundation export is working.
Then I tried to use my updated llvm compiler tools, version 15 I think, and got a pointer conversion error, which made me think that this code was breaking the export, and it was... I initially replaced the offending "return 1" by "return NULL" to get rid of the error, but now I properly replaced it by "((char*)(intptr_t)(1))" and the AVFoundation export worked again, together with the speed increase (16fps again).
So it looks like the compiler is the key for the performance gain in my case.
Title: Fix focus dots with Dual ISO on 5K mode
Post by: iaburn on January 11, 2023, 12:07:46 PM
Hello, I always notice that the Fix focus dots function with Dual ISO and 5K anamorphic clips is adding colored dots on places where there are no focus dots.
I understand the challenges of fixing focus dots on Dual ISO, but why would it affect parts of the image where no focus dots are present if it's using focus dots maps?

A couple of screenshoots attached to show what I mean. Thanks!
(https://i.ibb.co/TmqcRNf/focus-fixed.jpg) (https://ibb.co/TmqcRNf) (https://i.ibb.co/vqqH69N/no-fix.jpg) (https://ibb.co/vqqH69N)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 11, 2023, 01:42:16 PM
Quote from: iaburn on January 11, 2023, 12:07:46 PM
Hello, I always notice that the Fix focus dots function with Dual ISO and 5K anamorphic clips is adding colored dots on places where there are no focus dots.
I understand the challenges of fixing focus dots on Dual ISO, but why would it affect parts of the image where no focus dots are present if it's using focus dots maps?

A couple of screenshoots attached to show what I mean. Thanks!
(https://i.ibb.co/TmqcRNf/focus-fixed.jpg) (https://ibb.co/TmqcRNf) (https://i.ibb.co/vqqH69N/no-fix.jpg) (https://ibb.co/vqqH69N)

try using chroma smooth 3x3 in mlvapp usually solve the problem
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 11, 2023, 02:16:50 PM
Quote from: ML700D on January 11, 2023, 01:42:16 PM
try using chroma smooth 3x3 in mlvapp usually solve the problem
Thanks, it helps, l usually have to go all the way to 5x5, but still some color artifacts remain, specially the green dots.

I brought this topic because, not knowing how the fix works, it looks like it could be a bug that can be fixed
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 11, 2023, 02:20:24 PM
Dualiso is known for problems surrounding focus pixels
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 11, 2023, 04:49:25 PM
Quote from: Danne on January 11, 2023, 02:20:24 PM
Dualiso is known for problems surrounding focus pixels

I've been dealing with it for a while haha

On another topic, while searching for documentation, I found a thesis about a method to process dual ISO images that divides the dual ISO image on 2 halves, applies a deinterlace algorithm on both and then does a merge like if they where 2 frames from an HDR clip.
Is that the method used on MLV App? It seems possible to divide on multiple parallel tasks if that's the case.

Here the document (chapter 6 on page 101) : https://www.tdx.cat/handle/10803/664378?locale-attribute=en#page=1 (https://www.tdx.cat/handle/10803/664378?locale-attribute=en#page=1)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 11, 2023, 09:35:48 PM
Quote from: iaburn on January 10, 2023, 11:47:04 PM
... I initially replaced the offending "return 1" by "return NULL" to get rid of the error, but now I properly replaced it by "((char*)(intptr_t)(1))" and the AVFoundation export worked again, together with the speed increase (16fps again).
So it looks like the compiler is the key for the performance gain in my case.
Okaaaay. Where can I find this line? Is it in raw_processing.c?

I could fix the export preset feature for Qt6.4 version. For the broken theme - very strange - the app background reacts now on macOS dark/light theme, but not on the implemented background color. I don't find a Qt function to stop that.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 11, 2023, 10:22:36 PM
Quote from: masc on January 11, 2023, 09:35:48 PM
Okaaaay. Where can I find this line? Is it in raw_processing.c?
Yes, I got a "Incompatible integer to pointer conversion returning 'int' from a function with result type 'char *'" on the "return 1"

Quote from: masc on January 11, 2023, 09:35:48 PM
I could fix the export preset feature for Qt6.4 version. For the broken theme - very strange - the app background reacts now on macOS dark/light theme, but not on the implemented background color. I don't find a Qt function to stop that.
I never used that option, I can just choose between the normal and the modern dark themes, and looked very similar
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 12, 2023, 09:03:33 AM
Thanks for the hint. I'll change that also on the main repo!

This looks very wrong to me (macOS dark looks fine while this is in macOS light theme)
(https://i.ibb.co/3W5fvnG/Bildschirmfoto-2023-01-12-um-09-00-45.png)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 12, 2023, 10:14:43 AM
Quote from: iaburn on January 11, 2023, 02:16:50 PM
Thanks, it helps, l usually have to go all the way to 5x5, but still some color artifacts remain, specially the green dots.

I brought this topic because, not knowing how the fix works, it looks like it could be a bug that can be fixed

for the rest I use ca desaturated so far
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 12, 2023, 06:13:24 PM
Theme bug is fixed now. So now, all is working with Qt6.4, or do we have more bugs? Focus Pixel Fix works with my self-compiled version.

@iaburn: so now you could (if you like) work on algorithm speedup. There is also potential in lossless decompression - this works single threaded, same as dualIso. Processing uncompressed MLVs is by far faster.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 12, 2023, 06:27:44 PM
Quote from: masc on January 12, 2023, 06:13:24 PM
Theme bug is fixed now. So now, all is working with Qt6.4, or do we have more bugs? Focus Pixel Fix works with my self-compiled version.


is this time to update MLVapp, masc?  :D

thanks.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 12, 2023, 06:51:36 PM
Quote from: masc on January 12, 2023, 06:13:24 PM
Theme bug is fixed now. So now, all is working with Qt6.4, or do we have more bugs? Focus Pixel Fix works with my self-compiled version.
Awesome!

Quote from: masc on January 12, 2023, 06:13:24 PM
@iaburn: so now you could (if you like) work on algorithm speedup. There is also potential in lossless decompression - this works single threaded, same as dualIso. Processing uncompressed MLVs is by far faster.
Thanks, I put on the list, that would help to speed up all clips, also dual ISO  :)
I thought about trying to fix first the pink lines with dual ISO on overexposed areas, as this is something that I come across very often and it's very hard and time consuming to fix in post.
Then, if no one tried already, I wanted to see if I can implement the Dual ISO processing mentioned on the document I posted before and see how good it looks and how fast it is.
And then finally work on speed up Dual ISO processing, I have tasks for years hahaha
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 12, 2023, 07:40:31 PM
Quote from: ML700D on January 12, 2023, 06:27:44 PM
is this time to update MLVapp, masc?  :D
Not yet. Next I'll test if I can use llvm15 on my machine for speedup @iaburn reported. I hope to not crash my toolchain, which was setup manually.

@iaburn: sounds awesome. Let us know if you need help or information!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 12, 2023, 08:06:43 PM

Quote from: masc on January 12, 2023, 07:40:31 PM
Not yet. Next I'll test if I can use llvm15 on my machine for speedup @iaburn reported. I hope to not crash my toolchain, which was setup manually.

@iaburn: sounds awesome. Let us know if you need help or information!

I tried to compile the latest code in Windows and first it complained about c++ version, saying that v17 was mandatory:
  - QMAKE_CXXFLAGS += -fopenmp -std=c++11 -ftree-vectorize
  + QMAKE_CXXFLAGS += -fopenmp -std=c++17 -ftree-vectorize


and then it couldn't find a definition for "uint8_t", fixed by adding
#include "stdint.h"

The biggest problem so far is that there is no audio while playing the MLVs.
From what I've read, both Windows x64 and MacOS Arm64 are little endian, so that part should be ok.
QAudioFormat supports PCM audio formats only in Qt 6 multimedia, so it should work in Windows if it works in MacOS.
The new setSampleFormat already assumes signed ints, so no need for "setSampleType" replacement.

There has to be something breaking it, but no idea u_u Anyone that compiled the app in Windows with Qt 6.4 can confirm that sounds is missing?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 12, 2023, 08:33:35 PM
Yay. Got the compiler speedup! Can now reproduce @iaburns framerate increase, even with Qt5.15... 1856x1044 from 5D2 with 52fps playback on MacBookAir M1 (@43% CPU usage), disabling matrix and creative adjustments >60fps. Thank you @iaburn! It seems, c++15 makes the difference.

(https://i.ibb.co/DDFjF1s/Bildschirmfoto-2023-01-12-um-20-42-38.png)

If I find the time, I can test Qt6.4 on Windows tomorrow.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 12, 2023, 09:52:38 PM
Quote from: masc on January 12, 2023, 08:33:35 PM
Yay. Got the compiler speedup! Can now reproduce @iaburns framerate increase, even with Qt5.15... 1856x1044 from 5D2 with 52fps playback on MacBookAir M1 (@43% CPU usage), disabling matrix and creative adjustments >60fps. Thank you @iaburn! It seems, c++15 makes the difference.

(https://i.ibb.co/DDFjF1s/Bildschirmfoto-2023-01-12-um-20-42-38.png)

If I find the time, I can test Qt6.4 on Windows tomorrow.

Thank God, I started to think that I was crazy :o haha Thankss
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on January 12, 2023, 09:55:29 PM
Nice speed up! Thanks iaburn for this finding!

How can I test this on Windows? Do we have a compiled version already?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 12, 2023, 10:05:53 PM
Quote from: theBilalFakhouri on January 12, 2023, 09:55:29 PM
Nice speed up! Thanks iaburn for this finding!

How can I test this on Windows? Do we have a compiled version already?
Unfortunately I don't think anything changed for Windows version. This was a macOS compiler only change.

Edit: Qt6.4.2 on Windows: no sound. And no speedup compared to official versions. Even if I do the same compiler trick we did on macOS.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 13, 2023, 04:24:05 PM
Quote from: masc on January 12, 2023, 10:05:53 PM
Edit: Qt6.4.2 on Windows: no sound. And no speedup compared to official versions. Even if I do the same compiler trick we did on macOS.

I compiled the app using the Qt 6.5 beta and surprisingly the audio is working, so it probably doesn't worth trying to debug audio in 6.4  ::)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 13, 2023, 06:14:33 PM
Quote from: masc on January 12, 2023, 10:05:53 PM
This was a macOS compiler only change.

And Silicon only? Or Intel too?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 13, 2023, 06:34:38 PM
Quote from: vastunghia on January 13, 2023, 06:14:33 PM
And Silicon only? Or Intel too?
My test was on Apple Silicon. I updated Intel compiler instructions too (not yet commited to repo), but I did not compare the speed here.

More tests on Apple Silicon M1, with the 3K testclip from @iaburn:
Export with my FastProxy receipt, ProRes422 AVFoundation: 8sec
Export to DNG lossless: 14sec
:P

https://github.com/ilia3101/MLV-App/blob/master/receipts/FastProxy.marxml

Edit: Intel macOS compiler flags updated on repo
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 13, 2023, 06:38:32 PM
Very cool! Can't wait to test on Intel too.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 14, 2023, 04:58:59 AM
hi masc..
is it possible to implement this Video Restoration Transformer (https://awesomeopensource.com/project/JingyunLiang/VRT) in mlvapp?
I search google that pytorch can work with c++

https://pytorch.org/ (https://pytorch.org/)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 14, 2023, 11:46:53 AM
@ML700D:
That looks very interesting. Python in principle is compatible with C++ and Qt. But installation is a nightmare - for all users then. Just downloading the app and start processing will be impossible. And it looks as this is realized on CUDA. This means, MLVApp won't exist for most Apple machines and I can't help with it - I don't have any CUDA GPU. If something like this exists in C/C++, it would be awesome and we could add it for all users with all comfort.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 14, 2023, 01:11:32 PM
i see..
in their site pytorch.org I saw that you don't need cuda if you use libtorch for c++
but I don't know technically if it is applicable or not.

btw, I found this cuda for macOS (https://www.nvidia.com/en-us/drivers/cuda/mac-driver-archive/) maybe it's usefull.

ah sorry you don't have cuda GPU.. 😅
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 14, 2023, 01:24:12 PM
I think NVIDIA is not (officially) supported by Mac, even as an eGPU.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 14, 2023, 01:32:42 PM
Quote from: ML700D on January 14, 2023, 01:11:32 PM
in their site pytorch.org I saw that you don't need cuda if you use libtorch for c++
They don't say, CUDA is not needed. They say, CUDA is not supported. :) (on mac)
But on the VRT project page you can read the requirments needed: Python 3.8, PyTorch >= 1.9.1, CUDA 11.1  :-\
So I don't expect it to work here on my computers.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 14, 2023, 03:11:43 PM
pass.. 😂
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 15, 2023, 03:57:12 PM
About the pink horizontal lines on dual iso, I've been experimenting and it seems like the white level is set too high on the high ISO part of the image. If I set it to half of the value (white_bright *= 32 instead of 64 on dualiso.c - diso_get_full20bit), in most cases it fixes it completely or at least it gives a constant pink highlighted area, like on the example below.
I'll experiment a bit more, but maybe someone who actually understands the math behind all this can think of a reliable solution that works on all cases and it doesn't affect the general quality. Maybe a slider to adjust white balance individually for the bright and dark parts of the image when dual ISO is selected would help?

(https://i.ibb.co/CBqPRsn/dualiso-artifact.jpg) (https://ibb.co/CBqPRsn)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 15, 2023, 06:33:01 PM
my dual iso test..
I use iso 50 tweak -1 EV (canon iso 100)

no adjustment
(https://i.ibb.co/m69dgct/Screenshot-2023-01-16-001220.jpg)

after adjustment (w/o noise reduction), max detail I can get from my lens capability.
(https://i.ibb.co/PFY0cps/Screenshot-2023-01-15-234900.jpg)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 15, 2023, 06:47:06 PM
Quote from: iaburn on January 15, 2023, 03:57:12 PM
About the pink horizontal lines on dual iso, I've been experimenting and it seems like the white level is set too high on the high ISO part of the image. If I set it to half of the value (white_bright *= 32 instead of 64 on dualiso.c - diso_get_full20bit), in most cases it fixes it completely or at least it gives a constant pink highlighted area, like on the example below.
I'll experiment a bit more, but maybe someone who actually understands the math behind all this can think of a reliable solution that works on all cases and it doesn't affect the general quality. Maybe a slider to adjust white balance individually for the bright and dark parts of the image when dual ISO is selected would help?

(https://i.ibb.co/CBqPRsn/dualiso-artifact.jpg) (https://ibb.co/CBqPRsn)
for pink highlight I check the highlight reconstruction to make it back to white
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 15, 2023, 06:52:23 PM
Quote from: ML700D on January 15, 2023, 06:47:06 PM
for pink highlight I check the highlight reconstruction to make it back to white

Hi, what I described is a particular situation that you might have not experienced. Highlight reconstruction has no effect in this case.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 15, 2023, 07:09:37 PM
oh.. I see
maybe masc can figure it out.. 💡
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 15, 2023, 10:22:58 PM
After more experimentation, it looks like modifying the safety_margins on the white_detect function has the same effect. Top margin is set to 1500, but a value of around 4000 fixes the stripes (at the expense of a bit less DR, like it says on the comments)

int safety_margins[2] = {100, 1500}; /* use a higher safety margin for the higher ISO */

It should be possible to adjust this value automatically I suppose, but it could also be customizable from the Dual ISO section
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 15, 2023, 11:44:58 PM
As you dive into dualiso swamp you'll probably notice more edgecases causing issues, especially with mlvfs based fork used in mlv app. A few refinements were achieved by bouncyball but the more robust cr2hdr code from a1ex original code should be revisited against edgecases causing trouble otherwise.

Searching this very thread reveals some of the issues. Lucklily I think I keep later crhdr code in this branch. Now it "only" needs porting  8)
https://bitbucket.org/Dannephoto/magic-lantern_jip_hop_git/src/master/
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 16, 2023, 10:24:26 AM
Quote from: Danne on January 15, 2023, 11:44:58 PM
Lucklily I think I keep later crhdr code in this branch. Now it "only" needs porting  8)
https://bitbucket.org/Dannephoto/magic-lantern_jip_hop_git/src/master/

Thanks for the code! It looks very similar, I'll give it a try next weekend
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 16, 2023, 11:22:24 AM
That sounds fantastic.
As I have no access ro computer atm I am almost certain this code is the updated one. If possible you could check against this branch too, it's either one with latest cr2hdr code.
https://bitbucket.org/Dannephoto/magic-lantern_dannephoto_git/downloads/

If you find the problematic test files somewhere in this thread it should be good to check against that. Sorry I could not be of more assistance here but I am positive others could find this.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 16, 2023, 03:28:20 PM
Quote from: Danne on January 16, 2023, 11:22:24 AM
That sounds fantastic.
As I have no access ro computer atm I am almost certain this code is the updated one. If possible you could check against this branch too, it's either one with latest cr2hdr code.
https://bitbucket.org/Dannephoto/magic-lantern_dannephoto_git/downloads/

If you find the problematic test files somewhere in this thread it should be good to check against that. Sorry I could not be of more assistance here but I am positive others could find this.

That code already helps a lot, now I just need time to understand XD

I found this post with a problematic video:

Quote from: Icaab on October 14, 2022, 03:47:37 PM
Hello.
Canon 650d. Shooting in the morning with dual iso 100/400 fusion with the sun. After incorporating dual iso in mlvapp -  appears a strange spot in the sun:
(https://i.ibb.co/TWYR01D/M14-0716-000051.jpg) (https://ibb.co/FHmJYXk)
Photo with dual iso - in order
Sources:
https://mega.nz/folder/HlxkhZaa#xB_W3KI5mMn9mwOHuhiB8g (https://mega.nz/folder/HlxkhZaa#xB_W3KI5mMn9mwOHuhiB8g)
Is there any way to fix this? Such a problem on many source videos
(Highlight Reconstruction and White Level Change - do not help)

And it looks good after adjusting the tolerance:
https://mega.nz/file/8glgmZ6Q#2C1oQBeyokxAx-RVwt3oA5OEGMw5afdoyt6smdy8snY (https://mega.nz/file/8glgmZ6Q#2C1oQBeyokxAx-RVwt3oA5OEGMw5afdoyt6smdy8snY)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 16, 2023, 03:35:05 PM
Yes, those white level issues are easy to fix. There's a lot more to be found when running other scenarios.
Let's see what I can find.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 16, 2023, 03:43:50 PM
If you want you can start reading from post number #4235 and if possible download the test file. Long story short. Here's one file which will benefit from having code updated.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 16, 2023, 06:39:25 PM
Quote from: Danne on January 16, 2023, 03:43:50 PM
If you want you can start reading from post number #4235 and if possible download the test file. Long story short. Here's one file which will benefit from having code updated.

Now I see the problem... Fun fact, I never understood what the Preview button under Dual ISO was supposed to do, as the video looked all broken with pink/green tint, until now!
On that problematic video the preview looks quite good and it's super fast :D

Very interesting topic and quite complex for someone that just started reading about how sensors work, but it would be awesome as a final degree project for a student! I'll give it a try though :)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 17, 2023, 03:32:05 AM
btw the problem is in the camera or mlvapp actually?

nice finding.. so dual iso will be better next.. 😃
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 17, 2023, 09:22:11 AM
Quote from: ML700D on January 17, 2023, 03:32:05 AM
btw the problem is in the camera or mlvapp actually?
You forgot the user. If you setup low-iso/high-iso wrong, preview also doesn't work. But the problem can be one of the 3, or a mixture of all. DualIso is a difficult topic.

For the sun problem: it is not just a DualIso problem - google for "black sun": you'll find this problem with many RAW cameras, even ARRI and Blackmagic have (or had) this. If you like to implement and if have a nice idea: it would be a great new "RAW Correction".
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on January 17, 2023, 02:35:45 PM
Quote from: masc on January 17, 2023, 09:22:11 AM
You forgot the user. If you setup low-iso/high-iso wrong, preview also doesn't work. But the problem can be one of the 3, or a mixture of all. DualIso is a difficult topic.

For the sun problem: it is not just a DualIso problem - google for "black sun": you'll find this problem with many RAW cameras, even ARRI and Blackmagic have (or had) this. If you like to implement and if have a nice idea: it would be a great new "RAW Correction".

ah.. yes I forgot  :P

it means that MLV RAW is not alone in the world 😁
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 18, 2023, 08:47:42 PM
I fixed audio export on AVFoundation export with Qt6.4: it seems there are more bugs in Qt lib, because ffmpeg executable could not be found in app image (in Qt5 it works and file definitively was/is existing). I removed Qt calls and replaced with standard C call. Was this working (without my change) with Qt6.5beta?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 18, 2023, 09:55:05 PM
What are you downloading prior to compiling? Qt6.5beta from where? Llvm from where? I am trying a lazy homebrew install and I almost get it compiling but rpath issues and two macdeploy files are missing. Not sure homebrew is working 100%.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 19, 2023, 08:58:26 AM
I used Qt5.15 and Qt6.4 from official Qt-Online-Installer and llvm@15 from brew, on BigSur Intel.
On M1 I am still on Qt5.15 selfcompiled and llvm@15 from brew.

On the Intel machine I see the differences between Qt5 and Qt6: e.g. file access. But maybe it is a problem on this computer, or with Qt6.4, or... :)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 19, 2023, 10:54:40 AM
It seems to be issues with homebrew qt so will download and test macports. If not working I'll do it your way.
My qt5.15 is broken since your lates commits so I went ahead and downloaded ventura to get it working cleanly with latest os and so on. Will test some more this evening :). Very nice to see this progress.
Also nice to see somebody taking some serious steps to update dualiso code  @iaburn👍.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 19, 2023, 01:23:25 PM
Quote from: masc on January 19, 2023, 08:58:26 AM
I used Qt5.15 and Qt6.4 from official Qt-Online-Installer and llvm@15 from brew, on BigSur Intel.
On M1 I am still on Qt5.15 selfcompiled and llvm@15 from brew.

On the Intel machine I see the differences between Qt5 and Qt6: e.g. file access. But maybe it is a problem on this computer, or with Qt6.4, or... :)
Could you link to what you are using to install Qt6? A lot of alternatives and I bet all of them takes at least an hour to test..
https://www.qt.io/download

EDIT: Might have found something here:
https://www.qt.io/offline-installers

Also found this:
https://wiki.qt.io/Building_Qt_6_from_Git
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 19, 2023, 06:14:24 PM
Quote from: Danne on January 19, 2023, 01:23:25 PM
Could you link to what you are using to install Qt6? A lot of alternatives and I bet all of them takes at least an hour to test..
https://www.qt.io/download
Exactly this link. Then scroll to "Go opensource", Then "Download the Qt Online Installler". Then you'll need a free Qt account. Then install:
- Qt 6.4.2 macOS, with QtMultimedia
- QtCreator

I think, if you find an Offline Installer from official Qt page, it will do the same. (Years ago I used this - no idea if it changed.)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 19, 2023, 08:43:37 PM
Yes. Got a version going. Thanks for testing. Seemingly working but should also be tested on a vanilla M1. Anyway. Good jump into the future here.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 19, 2023, 10:34:45 PM
Quote from: iaburn on January 09, 2023, 07:41:49 PM
Could you please download this MLV and post your FPS while playing? https://we.tl/t-Zsfm6jvHNU

@iaburn, the link expired, could you possibly share another one pls? Just built latest commit of MLV App successfully with Qt 6.4.2, eager to give it a try.

Ps: must admit I got lost in this thread, are performance improvements expected only with Dual ISO? Only on Silicon Macs? Are they due to code optimization? Or just different compilers / newer Qt version? Is llvm the key? I brewed it on my Mac, but how do I make sure that it is actually used by Qt during build process? Many questions, much confusion :o But first things first: let's test this and see if I see some performance improvement at all ;D
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 19, 2023, 10:54:01 PM
Nice
What's the size of your compiled version? Could you test this version?
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/MLV_App_arm64.zip

If possible run an eos m mlv and see if it downloads pixel map files correctly.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 19, 2023, 11:18:32 PM
Quote from: Danne on January 19, 2023, 10:54:01 PM
What's the size of your compiled version?
If possible run an eos m mlv and see if it downloads pixel map files correctly.

172,499,896 bytes after running macdeployqt. Sorry I don't own an M :(
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 19, 2023, 11:25:37 PM
Aha, I see :).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 20, 2023, 08:56:43 AM
Quote from: vastunghia on January 19, 2023, 10:34:45 PM
Ps: must admit I got lost in this thread, are performance improvements expected only with Dual ISO? Only on Silicon Macs? Are they due to code optimization? Or just different compilers / newer Qt version? Is llvm the key? I brewed it on my Mac, but how do I make sure that it is actually used by Qt during build process? Many questions, much confusion :o But first things first: let's test this and see if I see some performance improvement at all ;D
The newer compiler and the c++15 flag seems to bring more speed for all operations. I don't know if you used QtCreator: here you select in Kit-Settings what compiler and Qt version to use. On cmd line: when running qmake, you'll have to run it from a Qt binary path. The one you select defines the Qt version to use. But then, I don't know what compiler you selected...
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 20, 2023, 09:42:44 AM
Thanks for taking the time to explain.

Ok, so clearly I must be doing something wrong. Here is an uncompressed cDNG export test starting from a 3.5K 1:1 lossless 14-bit Dual Iso clip (MLV data rate @148 MB/s):
Similarly for a standard (non-Dual Iso) clip (same scene as above, MLV data rate @129 MB/s):
Going in the wrong direction :D

Please find below my current kit settings in Qt Creator (I haven't touched them yet). Clearly, I must change something.

Could you advise? Where am I supposed to choose llvm from? Btw I think I didn't touch my PATH after brewing llvm, could this be an issue?

Thanks a lot

Sergio

(https://github.com/vastunghia/vastunghia.github.io/raw/main/QtKit.png)

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 20, 2023, 03:56:56 PM
Do you use the standard Apple compiler? This one offers no openMP (Open Multiprocessing). So many algorithms run single threaded. That is okay for debugging but slower than official version. Install llvm via brew, add the new compiler in "Compilers" in your screenshot frame, and then select in Kits the llvm compiler.
brew install llvm
(https://i.ibb.co/4dZB3TJ/Bildschirmfoto-2023-01-20-um-15-53-43.png)
(https://i.ibb.co/z7MrGgD/Bildschirmfoto-2023-01-20-um-15-58-59.png)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 20, 2023, 04:11:41 PM
Hi, just wanted to mention that the dimensions of the video on the screen while playing a video have a massive impact on playback speed.
I didn't noticed because I always have the window maximized and I'm used to have the same performance while playing videos regardless of the window size.
Is it so optimized that it actually process less pixels when the screen is smaller, or is the opposite and final scaling is not optimized?  ::)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 20, 2023, 04:56:47 PM
Cannot reproduce the window size issue. Same speed whatever I change it too, hmm. Testfile maybe?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on January 20, 2023, 05:18:31 PM
No idea if this related:
on Windows, playing 1280x2160 1x3 14-bit lossless 23.976 FPS MLV clip using MLVApp 1.14:

"Zoom: fit"       gives 15-16 FPS
"Zoom: 100%" gives   9-10 FPS

Tested 2560x1440 1:1 and 1736x976 3x3 clips, the problem isn't showing there.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 20, 2023, 07:12:13 PM
Quote from: iaburn on January 20, 2023, 04:11:41 PM
Hi, just wanted to mention that the dimensions of the video on the screen while playing a video have a massive impact on playback speed.
I didn't noticed because I always have the window maximized and I'm used to have the same performance while playing videos regardless of the window size.
Is it so optimized that it actually process less pixels when the screen is smaller, or is the opposite and final scaling is not optimized?  ::)
This is because of the Qt framework: the used pixels of the video on the screen matter how fast Qt shows the images. We always render the full picture. I wouldn't call it "optimized". So maximized (and maybe with hidden Edit, Session and Audio area (press E, S, A)) it is way slower than in a "small video box".
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 20, 2023, 07:22:25 PM
Quote from: masc on January 20, 2023, 07:12:13 PM
This is because of the Qt framework: the used pixels of the video on the screen matter how fast Qt shows the images. We always render the full picture. I wouldn't call it "optimized". So maximized (and maybe with hidden Edit, Session and Audio area (press E, S, A)) it is way slower than in a "small video box".

I see... still is not normal that a modern computer, a Macbook pro M1 en particular, is not able to keep the framerate when the window is bigger.

Quote from: Danne on January 20, 2023, 04:56:47 PM
Cannot reproduce the window size issue. Same speed whatever I change it too, hmm. Testfile maybe?

This is a screencast using the "official" 1.14 release showing what I described:
https://mega.nz/file/9llCXRDb#kBG3NLt32C4miBKe8j60VqwwGR2t5MgG6D1j0wH17bg (https://mega.nz/file/9llCXRDb#kBG3NLt32C4miBKe8j60VqwwGR2t5MgG6D1j0wH17bg)

I used one of this videos from youtube channel Zeek:
https://drive.google.com/drive/folders/1QG9zBzzaMffm25z7MSlxK7HruzF9rzfF (https://drive.google.com/drive/folders/1QG9zBzzaMffm25z7MSlxK7HruzF9rzfF)
video: https://www.youtube.com/watch?v=chtpBWMX1MY (https://www.youtube.com/watch?v=chtpBWMX1MY)

Something has to be wrong with my machine. I get now much slower playback speed than before, but no idea what could it be  ???
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 20, 2023, 07:44:51 PM
Quote from: iaburn on January 20, 2023, 07:22:25 PM
Something has to be wrong with my machine. I get now much slower playback speed than before, but no idea what could it be  ???
Do you compile with llvm compiler now? And also: did you uncomment  these lines in .pro file?
#Qt5 on Apple Silicon with openMP: install llvm via brew, build Qt5 from source
    {
        QMAKE_CC = /opt/homebrew/opt/llvm/bin/clang
        QMAKE_CXX = /opt/homebrew/opt/llvm/bin/clang++
        QMAKE_LINK = /opt/homebrew/opt/llvm/bin/clang++
        QMAKE_CFLAGS += -fopenmp -ftree-vectorize
        QMAKE_CXXFLAGS += -fopenmp -std=c++15 -ftree-vectorize
        INCLUDEPATH += -I/opt/homebrew/opt/llvm/include
        LIBS += -L/opt/homebrew/opt/llvm/lib -lomp -L/opt/homebrew/opt/openssl/lib -lssl
        QMAKE_APPLE_DEVICE_ARCHS = arm64
    }
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 20, 2023, 08:02:02 PM
Quote from: masc on January 20, 2023, 07:44:51 PM
Do you compile with llvm compiler now? And also: did you uncomment  these lines in .pro file?

I'm testing with the release on github (https://github.com/ilia3101/MLV-App/releases/download/QTv1.14/MLV.App.v1.14.macOS-ARM64.dmg (https://github.com/ilia3101/MLV-App/releases/download/QTv1.14/MLV.App.v1.14.macOS-ARM64.dmg)), I guess it's something on my laptop...
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 20, 2023, 08:03:27 PM
Interesting I get slow playback with the official MLV.App.v1.14.macOS-ARM64.dmg release. With my own compiled build I get 25fps 100% realtime. Not sure the official build is optimized with llvm@15.
I suspect Ventura OS and the old QT5.15 round trip isn´t working optimal now.

The build I sent you iaburn, is it also choppy/slow?
Are you testing your own compiled build?


If all dependecies are on your station you can run this in terminal. Well after translating to your own paths of course:
/Users/daniel/qt-everywhere-src-6.4.2/qtbase/bin/qmake ~/MLV-App-master/platform/qt/MLVApp.pro \
QMAKE_CC=/opt/homebrew/opt/llvm@15/bin/clang \
QMAKE_CXX=/opt/homebrew/opt/llvm@15/bin/clang++ \
QMAKE_LINK=/opt/homebrew/opt/llvm@15/bin/clang++ \
QMAKE_CFLAGS+=-fopenmp \
QMAKE_CFLAGS+=-ftree-vectorize \
QMAKE_CXXFLAGS+=-fopenmp \
QMAKE_CXXFLAGS+=-std=c++15 \
QMAKE_CXXFLAGS+=-ftree-vectorize \
INCLUDEPATH+=-I/opt/homebrew/opt/llvm@15/include \
LIBS+=-L/opt/homebrew/opt/llvm@15/lib LIBS+=-lomp \
QMAKE_APPLE_DEVICE_ARCHS=arm64
sleep 2
/usr/bin/make -j 15 && /Users/daniel/qt-everywhere-src-6.4.2/qtbase/bin/macdeployqt ~/MLV-App-master/platform/Mlv_app_master/MLV\ App.app && \
make clean
sudo codesign --force --deep --sign - ~/MLV-App-master/platform/Mlv_app_master/MLV\ App.app/Contents/MacOS/MLV\ App

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 20, 2023, 08:12:39 PM
Quote from: Danne on January 20, 2023, 08:03:27 PM
Interesting I get slow playback with the official MLV.App.v1.14.macOS-ARM64.dmg release. With my own compiled build I get 25fps 100% realtime. Not sure the official build is optimized with llvm@15.
I suspect Ventura OS and the old QT5.15 round trip isn´t working optimal now.

The build I sent you iaburn, is it also choppy/slow?
Are you testing your own compiled build?
The official MLV.App.v1.14.macOS-ARM64.dmg release was compiled with llvm@11. But 25fps is no problem. Latest revision compiled with llvm@15 is maybe up to 10% faster in playback.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 20, 2023, 08:18:32 PM
Strange I get around 10fps with that build on Ventura OS and 25fps wirh my local built version.
Edit: unfortunatdly I didn't test the official version on mac OS Monterey when I had that installed.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 20, 2023, 08:24:11 PM
Do you have a special test clip I could test? And which receipt - default?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 20, 2023, 08:37:10 PM
I grabbed the top one here provided by the link from iaburn. But it´s not the clips. Anyway. I run defaults:
https://drive.google.com/drive/folders/1QG9zBzzaMffm25z7MSlxK7HruzF9rzfF
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 20, 2023, 08:47:57 PM
Check difference:
Local build:
https://youtu.be/49JL3Tty7GA
Official build:
https://youtu.be/nRztPdJUeOw

Official build also very unresponsive and hangs when opening a lot. Ventura that is.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 20, 2023, 09:28:19 PM
I get 25fps with both, local latest revision and official build. On BigSur MBA2020 M1.
With fps-override to 60fps, I get 30fps with local latest revision, and 27fps with official build. The 10% more now...
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 20, 2023, 09:42:42 PM
Could you upload a version with llvm@15 for comparison? Definitely something fishy going on.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 21, 2023, 11:54:22 AM
Here comes my version: https://www.dropbox.com/s/iy9xr5sk5ljbdjp/MLV%20App%20llvm15.zip?dl=0
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 21, 2023, 12:25:14 PM
That version confirmed working effectiviely. I had to replace signature before getting it to be opened but after this it works:
sudo codesign --force --deep --sign - ~/MLV-App-master/platform/Mlv_app_master/MLV\ App.app/Contents/MacOS/MLV\ App
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 21, 2023, 12:58:03 PM
Thanks for that info. I never signed any app I compiled :-D
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 21, 2023, 02:12:04 PM
Quote from: masc on January 20, 2023, 03:56:56 PM
add the new compiler in "Compilers" in your screenshot frame, and then select in Kits the llvm compiler

Thanks a lot masc! So apparently I can confirm very slightly better performance during uncompressed cDNG export with Qt6 / llvm15 local build on Mac x86:
Frame rate during playback has a higher gain! From 4 to 7 fps for a 14-bit 3.5K 1:1 lossless-compressed single-ISO MLV file (avg MLV data rate @129 MB/s).

Not a game changer, but nice.

Sergio
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 21, 2023, 02:16:10 PM
A separate post for a feature request: Would it be hard to add an option to export the MLV files attribute table (as reported in the Session Area when in Table Mode) in a very simple and handy format, say csv maybe?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 21, 2023, 03:40:39 PM
Quote from: vastunghia on January 21, 2023, 02:12:04 PM
So apparently I can confirm very slightly better performance during uncompressed cDNG export with Qt6 / llvm15 local build on Mac x86:
cDNG export is not a major strength of MLVApp - more a side product for a longer feature list. Lossless de-/compression is single threaded. So don't expect much changes here. MLVFS is in advantage here (even if - i think - they use the same algorithm), if the NLE preloads more than one frame - then you get multithreading.

The table was/is already planned and should be doable. I just need the time to do this.
https://github.com/ilia3101/MLV-App/issues/212
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 21, 2023, 03:54:05 PM
I have reworked Mlv App compiler.app a lot today. It will atm only work with arm64 machines(M1,M2 etc) But might look into including intel processing as well if I find the time. By running the app you start by selecting:
(U)   install dependencies(run it once)
Which will download, configure and compile Qt 6 onto your system. All automated.
Also possible to erase dependencies if you want to start fresh:
(E)   Erase dependencies

Full menu:
(c)   compile MLV App with openmp(arm64)
(b)   check out branches
(D)   install dependencies(run it once)
(E)   erase dependencies
(m)  make clean


My focus has been to get something working which is not too complicated and automated.
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/

Feel free to let me know how it works if tested.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 21, 2023, 06:02:56 PM
Quote from: vastunghia on January 21, 2023, 02:16:10 PM
A separate post for a feature request: Would it be hard to add an option to export the MLV files attribute table (as reported in the Session Area when in Table Mode) in a very simple and handy format, say csv maybe?
Done. Please test.

@Danne: nice! FocusPixelMap auto downlod also works now?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 21, 2023, 07:36:27 PM
Quote from: masc on January 21, 2023, 06:02:56 PM
Done. Please test.

You are the best 8) Tested and given feedback here https://github.com/ilia3101/MLV-App/issues/212 (https://github.com/ilia3101/MLV-App/issues/212)

Ciao
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 21, 2023, 08:05:22 PM
Quote from: masc on January 21, 2023, 06:02:56 PM
@Danne: nice! FocusPixelMap auto downlod also works now?
Hm, that part always worked for me, and also when iaburn tested.
Uploaded a version here. https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/MLV_App_arm64.zip
Maybe works now? Or else we need to check some path issue.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 21, 2023, 08:35:52 PM
Hm, here it doesn't work with your version. Loading a clip which needs a map doesn't open the known messagebox. Pixels are visible. On my Intel Mac I've seen, Qt did not find libssl, but it downloaded the maps anyway. In Windows version it was needed for downloading. So in my latest commits I added openssl to the linked LIBs. I don't see libssl and libcrypto in your build yet. Could we try again?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 21, 2023, 09:04:13 PM
Added -lssl like follows:
QMAKE_CC=/opt/homebrew/opt/llvm@15/bin/clang \
QMAKE_CXX=/opt/homebrew/opt/llvm@15/bin/clang++ \
QMAKE_LINK=/opt/homebrew/opt/llvm@15/bin/clang++ \
QMAKE_CFLAGS+=-fopenmp \
QMAKE_CFLAGS+=-ftree-vectorize \
QMAKE_CXXFLAGS+=-fopenmp \
QMAKE_CXXFLAGS+=-std=c++15 \
QMAKE_CXXFLAGS+=-ftree-vectorize \
INCLUDEPATH+=-I/opt/homebrew/opt/llvm@15/include \
LIBS+=-L/opt/homebrew/opt/llvm@15/lib LIBS+=-lomp \
LIBS+=-L/opt/homebrew/opt/openssl/lib LIBS+=-lssl
QMAKE_APPLE_DEVICE_ARCHS=arm64


Mlv App increased a few mb in size so something seemed to happen. Could you test?
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/MLV_App_arm64.zip

Not sure where to add libcrypto. Part of openssl I noticed. Both libs are included now in Frameworks.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 21, 2023, 09:29:08 PM
Unfortunately no change. Maybe it is Qt6: AVFoundation sound export had an issue, where Qt6 file, path and call commands did not work at all. With standard C functions: no prob. Map download inherits many many of these Qt lib calls. E.g. a simple QFileInfo("filename").exists() always fails here with Qt6.4, same for QProcess::execute("application").
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 21, 2023, 10:12:46 PM
Is there a Qt 6.5?
Strange that it works on iaburns end, hmmm
I guess if pne compile locally ot could behave better.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 21, 2023, 10:34:27 PM
Qt6.5 is in beta state. You can load it from online installer. They plan to release end of march.
https://wiki.qt.io/Qt_6.5_Release
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 21, 2023, 11:37:50 PM
Just sharing MLV App installer (DMG) 'nightly build' (ref. commit 3330563) for OSX x86, built with Qt6 and llvm15:

https://www.icloud.com/iclouddrive/061ffs2OUqHzzwsMapMtkx6gQ#MLVApp.3330563.llvm15.OSX (https://www.icloud.com/iclouddrive/061ffs2OUqHzzwsMapMtkx6gQ#MLVApp.3330563.llvm15.OSX)

Sergio
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 21, 2023, 11:45:31 PM
Quote from: masc on January 21, 2023, 03:40:39 PM
MLVFS is in advantage here, if the NLE preloads more than one frame - then you get multithreading.

Understood. Too bad MLVFS is broken in Ventura. Or isn't it?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 22, 2023, 11:09:48 AM
Quote from: vastunghia on January 21, 2023, 11:37:50 PM
Just sharing MLV App installer (DMG) 'nightly build' (ref. commit 3330563) for OSX x86, built with Qt6 and llvm15:

https://www.icloud.com/iclouddrive/061ffs2OUqHzzwsMapMtkx6gQ#MLVApp.3330563.llvm15.OSX (https://www.icloud.com/iclouddrive/061ffs2OUqHzzwsMapMtkx6gQ#MLVApp.3330563.llvm15.OSX)

Sergio
Auto FocusPixelMap install is broken also with this version. Seems not to work on Qt6.4 yet. Many path related Qt6.4 functions fail (e.g. QFileInfo(<fileName>).exists() ). No idea why. No such problem on Qt5.15.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 22, 2023, 12:12:04 PM
Strange. Also not broken on all machines.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 22, 2023, 01:57:46 PM
Quote from: Danne on January 22, 2023, 12:12:04 PM
Strange. Also not broken on all machines.

It's funny that focus map download worked in your compilation but then it doesn't work when I was testing things and tried on one of my compilations O_O I'll try to find a reason...

Regarding the dual ISO update with the code that you posted from cr2hdr (I think I took the latest from the 2), I could put everything together and it's a total mess now, but it works and it gives much better results with the highlight stripes without having to tweak the tolerances like I was doing.

The problematic video from the 5D mark III looks much better (no horizontal stripes, no shadow noise) but it flickers like crazy. It's very likely that I messed something while trying to make the updated code work. I'll take a look next weekend while cleaning things and fixing all the processing settings that are not working now  :D
The video flicker issue: https://mega.nz/file/l9cgDYRC#S4FmCFDKsaZD9ZNgFiToBz5Dvjzw7Kmmpo56vsGeRRk (https://mega.nz/file/l9cgDYRC#S4FmCFDKsaZD9ZNgFiToBz5Dvjzw7Kmmpo56vsGeRRk)
Comparison from the old and the new code:
(https://i.ibb.co/N17SYS8/problematic5-DIII.jpg) (https://ibb.co/N17SYS8)

With my test clips, this is how it looks with no corrections at all (very zoomed in to see something...):
(https://i.ibb.co/k52RK4g/nocorrection.jpg) (https://ibb.co/k52RK4g)

A old vs new comparison (with a bit increased highlights) to illustrate the difference, same recipe on both:

(https://i.ibb.co/61cDznf/M06-1846-2-5k.jpg) (https://ibb.co/61cDznf)

(https://i.ibb.co/T1sQ1H5/M13-0935-5k.jpg) (https://ibb.co/T1sQ1H5)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 22, 2023, 02:11:38 PM
Wow. Impressive. Very close.
The flicker. What are whitelevel numbers if you export to dualiso processed dng files?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 22, 2023, 03:25:14 PM
Quote from: masc on January 22, 2023, 11:09:48 AM
Auto FocusPixelMap install is broken also with this version.

Mmh strange. I don't own an M, so I downloaded iaburn's test clips and checked. Opening them with my build, it automatically downloaded focus pixel maps and applied them correctly -- I can clearly see focus pixels re-appear if I disable the fix.

Also, I report a massive playback speed improvement with my local build for Mac x86 (Qt 6 + llvm15) vs official 1.14 build. With iaburn's test clip that Danne was referring to (M28-1445), I pass from 5-6 fps to 22.

Sergio
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 22, 2023, 03:34:04 PM
Quote from: Danne on January 22, 2023, 02:11:38 PM
Wow. Impressive. Very close.
The flicker. What are whitelevel numbers if you export to dualiso processed dng files?

Same on both (2 frames with different exposure): white level 64800, dark level 8188.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on January 22, 2023, 03:48:15 PM
@iaburn

Nice work on Dual ISO :) , finally we have new one who can deal with Dual ISO code :D
Could you fix multi-threading (https://github.com/ilia3101/MLV-App/commit/cb6c778dc712ab7951d1ae5db1f0b6c91a304226) issue too? :P

Dual ISO multi threaded vs single threaded (https://www.magiclantern.fm/forum/index.php?topic=20025.msg237885#msg237885)

Keep it up!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 22, 2023, 04:05:14 PM
Quote from: theBilalFakhouri on January 22, 2023, 03:48:15 PM
Could you fix multi-threading (https://github.com/ilia3101/MLV-App/commit/cb6c778dc712ab7951d1ae5db1f0b6c91a304226) issue too? :P

+1 :P

Your work looks so promising iaburn, thank you!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 22, 2023, 05:42:08 PM
Quote from: vastunghia on January 22, 2023, 03:25:14 PM
Mmh strange. I don't own an M, so I downloaded iaburn's test clips and checked. Opening them with my build, it automatically downloaded focus pixel maps and applied them correctly -- I can clearly see focus pixels re-appear if I disable the fix.

Also, I report a massive playback speed improvement with my local build for Mac x86 (Qt 6 + llvm15) vs official 1.14 build. With iaburn's test clip that Danne was referring to (M28-1445), I pass from 5-6 fps to 22.

Sergio
That's crazy. 22fps on intel processor.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 22, 2023, 05:46:01 PM
Quote from: Danne on January 22, 2023, 05:42:08 PM
That's crazy. 22fps on intel processor.

Well, I'm still stuck at 7 fps (up from 4) with 1:1 3.5K on 5D3.. ::)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on January 22, 2023, 08:44:00 PM
Quote from: Danne on January 22, 2023, 05:42:08 PM
That's crazy. 22fps on intel processor.

I get about 25fps on my linux desktop.  With gcc, qt5, 1.13.  AMD 3800.  I think we're learning that old Macs are slow, not new Macs are fast :)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 22, 2023, 09:47:02 PM
So it seems  8)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 22, 2023, 11:24:34 PM
Quote from: names_are_hard on January 22, 2023, 08:44:00 PM
I think we're learning that old Macs are slow, not new Macs are fast :)

Ahah, maybe, yes.

But actually the fact that by just switching to updated libs / different compiler we were able to achieve a 300% performance increase tells me that code optimization is far from perfect. And that could largely explain observed differences in performances on different machines.

Just my 2 cents.

EDIT: btw I tried MLV App official 1.14 release on my x86 Mac Windows partition and in terms of playback it sits just below latest local build with Qt6+llvm15 on MacOS (but still much higher than official 1.14 build on MacOS).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mattia on January 23, 2023, 12:18:51 PM
Could anyone share an updated build of Mlv app for Windows?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 23, 2023, 01:14:56 PM
Quote from: vastunghia on January 22, 2023, 11:24:34 PM
EDIT: btw I tried MLV App official 1.14 release on my x86 Mac Windows partition and in terms of playback it sits just below latest local build with Qt6+llvm15 on MacOS (but still much higher than official 1.14 build on MacOS).
Official x86 macOS build was compiled with the old llvm@6, for supporting all macOS since 10.9.5. It is possible, that this is slower.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 23, 2023, 01:48:20 PM
Aha, understood, thanks.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 70MM13 on January 25, 2023, 05:30:36 PM
are we getting close to a new mlv app official version?
i'd like to try it again comparing to resolve, and any extra speed for the windows version would be most welcomed!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 25, 2023, 09:37:40 PM
While cleaning and bringing back the custom parameters to the dual iso processing, I've noticed that activating "fullres reconstruction" is causing the pink stripes on the highlights, even on the updated code.
There is a comment from the programmer:

/* reconstruct a full-resolution image (discard interpolated fields whenever possible) */
/* this has full detail and lowest possible aliasing, but it has high shadow noise and color artifacts when high-iso starts clipping */


There is a hidden option on the current version of MLV App to toggle fullres reconstruction on and off, but it is disabled. I enabled the option and on the updated code it works as expected: turning that off fixes the artifacts, but on the "old" version the image is totally broken.
Not trying to find out why, I'm happy that it's broken, otherwise I updated the code for nothing xD

Activating "Fullres reconstruction" improves the resolution on the shadows but can break highlights, so I will try to add an option to do fullres reconstruction only on the shadows for these cases
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 25, 2023, 10:17:22 PM
Sometimes it is good, if we just hide features instead of deleting them, if not working... nice find!  8)

Quote from: 70MM13 on January 25, 2023, 05:30:36 PM
are we getting close to a new mlv app official version?
i'd like to try it again comparing to resolve, and any extra speed for the windows version would be most welcomed!
Quote from: Mattia on January 23, 2023, 12:18:51 PM
Could anyone share an updated build of Mlv app for Windows?
Each commit and dev work brings us closer... but there is still a way to go. iaburn just started porting dualiso and already did a great job. Thank you!

Don't expect the Windows version to get faster until now - this was a macOS compiler optimization. And Windows offers no hardware support for ProRes encoders.
As compiling MLVApp is really very easy, you could compile each commit you like, test and report.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: BatchGordon on January 26, 2023, 10:59:30 AM
Quote from: iaburn on January 25, 2023, 09:37:40 PM
Activating "Fullres reconstruction" improves the resolution on the shadows but can break highlights, so I will try to add an option to do fullres reconstruction only on the shadows for these cases

From the documentation of the a1ex dual-iso algorithm, full frame reconstruction should only be possible for midtone and impossible for both highlights and shadows.
This is because only the midtones fall into the "sensitive" part of both the low and high ISO lines.

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 26, 2023, 08:04:14 PM
Quote from: BatchGordon on January 26, 2023, 10:59:30 AM
From the documentation of the a1ex dual-iso algorithm, full frame reconstruction should only be possible for midtone and impossible for both highlights and shadows.
This is because only the midtones fall into the "sensitive" part of both the low and high ISO lines.

You are right, but I was talking one step before the final blending, when they build the non-interpolated fullres image out of the interpolated, exposure corrected, bright and dark images. For context:
Interpolated bright image example:
(https://i.ibb.co/CWpsXJ7/bright.png) (https://ibb.co/CWpsXJ7)

Interpolated dark image example:
(https://i.ibb.co/xJQ7QHq/dark.png) (https://ibb.co/xJQ7QHq)

Then they build an initial fullres image using pixels from the bright image if it's a bright row (and not overexposed in theory), or from the dark image if it's a dark row:

for (int y = 0; y < h; y ++)
{
    for (int x = 0; x < w; x ++)
    {
        if (BRIGHT_ROW)
        {
            uint32_t f = bright[x + y*w];
            /* if the brighter copy is overexposed, the guessed pixel for sure has higher brightness */
            fullres[x + y*w] = f < (uint32_t)white_darkened ? f : MAX(f, dark[x + y*w]);
        }
        else
        {
            fullres[x + y*w] = dark[x + y*w];
        }
    }
}



It looks like there are cases where pixels are so overexposed that doesn't look overexposed anymore, and the comparison is taking the pink rows from the bright image anyways.
This is what I would like to change to keep as much detail as possible, while avoiding the pink parts. I tried ignoring the comparison with white_darkened and taking always the MAX, like this:
fullres[x + y*w] = MAX(f, dark[x + y*w]);
And that gives visually a resolution between the halfres and the fullres with no pink artifacts. The problem is that I don't understand what the values of the pink areas means, I don't know how to figure out when a pink pixel is "too pink" and should be discarded. The comparison with "white_darkened" seems to work most of the time, but that's just too complex for me.
Maybe someone with more knowledge on the topic can help us...


Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 26, 2023, 09:29:10 PM
Hehe, call in @a1ex  8).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 27, 2023, 09:53:32 AM
I took a naive solution, thinking that dark and bright images with exposure correction should be similar, I'm comparing the absolute value of the difference between the dark and the bright row and if the result is greater than a threshold value, just assign MAX(f, dark[x + y*w]).
If it's smaller, keep the current f < (uint32_t)white_darkened ? f : MAX(f, dark[x + y*w])

That keeps all the detail if the threshold value is correctly selected, but the perfect value I guess will be different between clips, cameras, configurations...
I took 50000 and works fine for my clip tests
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 27, 2023, 10:42:29 AM
Cool, will be nice to test when ready. Are you considering adding back the openmp code? Would be cool if that was working as speed is totally needed for dualiso  :P.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: BatchGordon on January 27, 2023, 11:01:59 AM
Yes, the idea of comparing points between images and taking the one from the low iso image if the difference exceeds a threshold might be naive... but in my opinion it's also quite wise.  ;)

The choice of the threshold value can be critical and, as you said, it can be different depending on many things (especially the selected ISO values).
However, I still have the impression that the root of the problem may be exposure for video: ETTR should be applied for the high iso, not the low one.

Technically speaking, with dual ISO we gain more detail in the shadows, not in the highlights (I said technically because in post we can change exposure as we prefer).
That's why a1ex reduces the exposure of the high iso image before merging, instead of increasing the exposure of the low iso.

By the way, his blending algorithm is much more complex and sophisticated, but I suspect it's also too slow to be usable for video. That's why it has been simplified in the implementation.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 27, 2023, 11:34:36 AM
But if you ETTR for higher ISO on Dual ISO, the darks on the low ISO will be useless as they will probably be 0 or at least below the noise level.
ETTR to the low ISO causes trouble with the overexposed high ISO part, but it makes more sense because it keeps the highlights while also improving the shadow noise thanks to the high ISO part.
According to this chart, up to 2 stops of shadow improvement: https://photonstophotos.net/Charts/PDR_Shadow.htm#Canon%20EOS%20M
(https://photonstophotos.net/Charts/PDR_Shadow.htm#Canon%20EOS%20M)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 27, 2023, 11:54:30 AM
Quote from: Danne on January 27, 2023, 10:42:29 AM
Cool, will be nice to test when ready. Are you considering adding back the openmp code? Would be cool if that was working as speed is totally needed for dualiso  :P.

I saw a branch from many years ago willing to use OpenCL, it would be awesome if we could use the GPU, it's made for this! Imagine fully using the GPU and CPU... :o

Another important thing is that it looks like the code was not deeply reviewed for optimization, more like trying to keep it "easy" to understand.
So there is also room for improvement on the algorithms implementation, but for this you really need to understand what's going on :S

I personally export to DNG and edit in Resolve, so for me the easiest way to use multiple CPU cores would be assigning 1 frame per core. If we can also use the GPU for processing each frame, that would be a dream <3
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 27, 2023, 01:09:37 PM
Gpu, hehe, hard shit.
I was referring to theBilalfakhouri link before. It was an improvement when it was in there but a bit buggy. Well, let's see later on :)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 27, 2023, 01:59:35 PM
@iaburn: if you know how to use the GPU... I have absolutely no idea here. I just heard it is impossible with C/C++, because it has its own kernel language. So this means mostly rewriting everything.
Yes, in the past we tried to use the GPU for debayering. In the end we had success with it technically, but it was slower as with CPU, because the copy actions between graphic RAM and main RAM needed nearly the same time as if the CPU debayers. So GPU might be cool if you process all on it - single tasks are probably for nothing.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 27, 2023, 02:16:18 PM
Quote from: theBilalFakhouri on January 22, 2023, 03:48:15 PM
@iaburn

Nice work on Dual ISO :) , finally we have new one who can deal with Dual ISO code :D
Could you fix multi-threading (https://github.com/ilia3101/MLV-App/commit/cb6c778dc712ab7951d1ae5db1f0b6c91a304226) issue too? :P

Dual ISO multi threaded vs single threaded (https://www.magiclantern.fm/forum/index.php?topic=20025.msg237885#msg237885)

Keep it up!

I missed your post! I absolutely cannot deal with this code, let alone doing all the rewrite needed for safe multithread  :o

I was just trying to fix the pink stripes and see how hard would it be to speed up dual ISO processing, but the second part it's really hard... I have no experience in multithreading nor GPU programming sadly, I just have good intention and hope haha
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on January 27, 2023, 07:32:29 PM
Quote from: masc on January 27, 2023, 01:59:35 PM
@iaburn: if you know how to use the GPU... I have absolutely no idea here. I just heard it is impossible with C/C++, because it has its own kernel language. So this means mostly rewriting everything.
Yes, in the past we tried to use the GPU for debayering. In the end we had success with it technically, but it was slower as with CPU, because the copy actions between graphic RAM and main RAM needed nearly the same time as if the CPU debayers. So GPU might be cool if you process all on it - single tasks are probably for nothing.

I've only tinkered with GPU programming a little, so don't take my advice very seriously here.  You're right that GPU programming is a different way of thinking, but, if you work in CUDA, the language you use is very C-like:
https://cuda-tutorial.readthedocs.io/en/latest/tutorials/tutorial01/

Note that CUDA is Nvidia only.  But it's a good interface and is a large part of why Nvidia dominate GPGPU.

Yes, bandwidth to the GPU is often a bottleneck.  But, you only need to copy once for all GPU cores to see the data.  So, you want to divide the problem up, have each core debayer a portion of the image, then combine.  Copy in once, process in parallel,  copy out once.

Debayer should be an easy algorithm to split up like this, and indeed there are free libraries available to do GPU debayer, e.g.: https://github.com/avionic-design/cuda-debayer
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 27, 2023, 08:05:42 PM
I think CUDA is no option at all. In comparison there are just a few computers able to run this, while e.g. OpenCL works on nearly all computers out of the box. So if we would implement GPU features, I'd try again with OpenCL. And there is already a CUDA based MLV tool: fastcinemadng. I was never able to try it - no CUDA GPU in my near.

@iaburn: openmp is not difficult to understand. There are these #pragma lines, which will make 'for' loops multi threaded. There should be no dependency between the loop iterations - this can't work. (e.g. writing on same variable)

This would work:

#pragma ...
for(int i = 0; i < n; i++)
{
    c[i] = a[i] + b[i];
}
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 27, 2023, 08:11:23 PM
I've been watching an OpenMP tutorial and trying after on some expensive loops, and the results are encouraging :D
On the currently available windows version, it took 5 minutes 33 seconds to process 100 frames from a 2.5K Dual ISO clip, with amaze interpolation and alias map disabled.
With the same configuration and clip, it took just 2 minutes 22 seconds with the new compilation, and I could see on the CPU graph a constant "chainsaw" on all CPU cores, as opposed to the flat graph while exporting on the "old" version.
Edit: Forgot to say that this is on a Ryzen 3400G with 4 cores 8 threads

I also took the chance to compare the output and it was exactly the same, but with the pink strips fixed :)

It would be cool if someone can give it a try and share his results, but it definitely worth using openmp. Here my WIP changes: https://github.com/anibarro/MLV-App (https://github.com/anibarro/MLV-App)


Spoke too soon, I guess I made a mistake testing...

Quote from: masc on January 27, 2023, 08:05:42 PM
@iaburn: openmp is not difficult to understand. There are these #pragma lines, which will make 'for' loops multi threaded. There should be no dependency between the loop iterations - this can't work. (e.g. writing on same variable)

This would work:

#pragma ...
for(int i = 0; i < n; i++)
{
    c[i] = a[i] + b[i];
}


Just read your post, you are right, I thought it was going to be more complicated!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on January 27, 2023, 08:13:03 PM
Quote from: masc on January 27, 2023, 08:05:42 PM
I think CUDA is no option at all. In comparison there are just a few computers able to run this, while e.g. OpenCL works on nearly all computers out of the box. So if we would implement GPU features, I'd try again with OpenCL. And there is already a CUDA based MLV tool: fastcinemadng. I was never able to try it - no CUDA GPU in my near.

Right, if you did want to use it you'd certainly need it to detect at runtime and be optional.  Which is more complexity.  OpenMP is nice and general.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on January 27, 2023, 08:17:36 PM
Quote from: iaburn on January 27, 2023, 08:11:23 PM
It would be cool if someone can give it a try and share his results, but it definitely worth using openmp. Here my WIP changes: https://github.com/anibarro/MLV-App (https://github.com/anibarro/MLV-App)
Just read your post, you are right, I thought it was going to be more complicated!

I can run some comparisons, is there some CLI way to start MLVApp and run a task?  Would be nice for doing a reproducible test.  If not, please describe how to run a test (what options to enable, sample file to use, etc).  I guess I want to compare your 8e1b6d89 against 95d8d20a?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 27, 2023, 08:50:51 PM
Quote from: names_are_hard on January 27, 2023, 08:17:36 PM
I can run some comparisons, is there some CLI way to start MLVApp and run a task?  Would be nice for doing a reproducible test.  If not, please describe how to run a test (what options to enable, sample file to use, etc).  I guess I want to compare your 8e1b6d89 against 95d8d20a?

I think I spoke too soon, I tried more videos and now I cannot replicate the speed gain, it's just the same or worst... :(
I will try to find out why  ::)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 27, 2023, 09:20:39 PM
Thanks for sharing your build. I just compiled it on my mac. Do you have any nice test files maybe? EVen if code isn´t fullproof yet it´s still nice to test stuff :).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 27, 2023, 10:17:21 PM
I have just a couple of files for the pink stripes ("5K" and 2.5K) and the problematic clip that you pointed out:
https://mega.nz/folder/px0wEILA#Nw4286WtySSEeOBX0w4A9g (https://mega.nz/folder/px0wEILA#Nw4286WtySSEeOBX0w4A9g)

I had hundreds of dual ISO videos with problems, but delete the MLVs once I have the videos edited to save space u_u
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 27, 2023, 11:06:12 PM
Thanks. Those are enough. Will creates some files of my own eventually.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 27, 2023, 11:29:12 PM
Did some testing. For comparison. Here are mlv_dump_on_steroids and cr2hdr processing the dualiso file from the 5d3 camera:
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/downloads/dualiso_jip-hop_source.zip
Both binaries compiled from here:
https://bitbucket.org/Dannephoto/magic-lantern_jip_hop_git/src/master/
Branch:
crop_rec_4k_mlv_snd_raw_only

Unfortunately issues are still there from latest commits. Or can you get better results here?

Cropped examples from this file problematic_dualiso_5dIII.MLV:

Processed in program Switch(mlv_dump_on_steroids and cr2hdr)
(https://i.postimg.cc/y8HcFKKL/Screenshot-2023-01-27-at-23-14-58-png-500px.jpg)

Mlv App
(https://i.postimg.cc/2jg4SvKR/Screenshot-2023-01-27-at-23-22-00-png-500px.jpg)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 28, 2023, 12:35:15 AM
More or less the same for me. I have to disable "Alias map" to get rid of the weird shadow, but there are still stripes on the bright parts. The only way to get a clean image is to disable full reconstruction.
Fullres:
(https://i.ibb.co/dbNQJSw/full.jpg) (https://imgbb.com/)

Halfres:
(https://i.ibb.co/F8gtgCw/half.jpg) (https://imgbb.com/)

The only thing that I took from the existing Dual ISO code was the Amaze and Mean interpolation functions, because the ones on that code were producing weird colors and I thought they will be the same, but apparently not...
I'll check why the original functions were not working, maybe that will fix it  ???
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 28, 2023, 12:41:51 AM
Quote from: Danne on January 27, 2023, 11:29:12 PM
Both binaries compiled from here:
https://bitbucket.org/Dannephoto/magic-lantern_jip_hop_git/src/master/
Branch:
crop_rec_4k_mlv_snd_raw_only

I can only see the master branch there
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 28, 2023, 04:42:00 AM
Oh, had no idea about alias map and fullres blending. Should be turned off as starting point I´d say. Maybe dualios was working much better than I thought all along just because of these two mofos? Cr2hdr probably runs without fullres blending as a starting point?
EDIT: Seems it´s fullres blending that is the issue here. But what is alias mapping doing?

It´s already in crop_rec_4k_mlv_snd_raw_only in the master branch. I uploaded it to git but I have included hg in there but you can skip all that. Source files for cr2hdr and mlv_dump should be the very same you have worked with already.
You can open then source in Sourcetree app and navigate in that program. Should be easy to see where you are in there. Or I use this tool myself but might be a bit of overkill. https://bitbucket.org/Dannephoto/ml_compiler-git/src/master/

EDIT: hg roundtrip in Sourcetree will not work. Use Compiler.app if needed.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 28, 2023, 10:19:34 AM
Thanks! I'll take a look at all this.

Sadly, disabling the fullres reconstruction is giving much less detail. I think alias map is supposed to improve aliasing on dark and bright areas, but I don't notice much difference

By the way, how do you use mlv_dump_on_steroids and cr2hdr to process one frame of an MLV clip like you did?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 28, 2023, 01:31:11 PM
Actually I processed all frames and just took the first one out.
https://www.magiclantern.fm/forum/index.php?topic=15108.0

Drag folder with mlv file.
Select option (ms)
Deselect from next menu so that dualiso automation is enabled in (ms) menu.
Select (r) and enter.

But so the major change now is you have a better amaze code for dualiso in there? All else was supposedly working when fullres was off? Let's disable that per default. I had so many files broken due to this. I.mean, even with less resolution we get betterr dynamic range, clean files and not having to worry about failing processing.

By the way. I think there's vertical stripes code working good with dualiso. Some older raw2dng code. Think I had that in cr2hdr too. Well, so much to do here  8)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 28, 2023, 05:01:10 PM
I could finally could make the Switch app work, couldn't make it when I tried before. An now I understand why the DNGs are so small, it was using just Halfres with dual ISO.

Quote from: Danne on January 28, 2023, 01:31:11 PM
But so the major change now is you have a better amaze code for dualiso in there? All else was supposedly working when fullres was off? Let's disable that per default. I had so many files broken due to this. I.mean, even with less resolution we get betterr dynamic range, clean files and not having to worry about failing processing.

I think there was no difference at all between the code that was there and the one I tool from cr2hdr, so basically the only useful things after all the mess are: The Fullres blending ON/OFF switch (was not working before), the Horizontal stripes fix (still need to find a clip where it's useful) and the horizontal pink strips fix when Fullres is ON (this fix needs testing on much more videos).

When including the multi threaded loops I see a big improvement on my measured times within the code, but when I test it it runs slower than the current version... very strange

Quote from: Danne on January 28, 2023, 01:31:11 PM
By the way. I think there's vertical stripes code working good with dualiso. Some older raw2dng code. Think I had that in cr2hdr too. Well, so much to do here  8)

If you find this code please tell me, I can add it now that I know where things are on the App  :D
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 28, 2023, 07:38:24 PM
In lv_rec folder you find raw2dng.c. Search for apply_vertical_stripes_correction.
In mlv_dump.c it´s called like this:
                        /* call raw2dng code, replaces frame_info.vertical_stripes */
                        if (fix_vert_stripes)
                        {
                            fix_vertical_stripes();
                        }

There is also this note in mlv_dump.c:
//frame_info.vertical_stripes     = fix_vert_stripes; //Unreliable and buggy with dualiso

I believe I tested this with a user and got good results with dualiso even. Worth to be tested. It´s all in the same jip-hop branch.
Regarding openmp stuff I suggest you contact @bouncyball to review your stuff since he´s the one doing the major work on this before.

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 29, 2023, 02:02:56 PM
Thanks for the tip!
I've disabled the standard stripes fix when dual ISO is active and implemented the fix that you sent me, it's not breaking the image, but I cannot see differences either. I see that this part of the code is running, but no changes, maybe because I don't have any good MLV files to test  ::) Do you have any dual ISO files with the vertical stripes problem?

I'm testing now different configurations and videos with and without the openmp directives, trying to get consistent results to know what to do  ::)

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 29, 2023, 02:19:48 PM
Yes, that is very good work. I think it will show if the file is having issues. Hard to find a solid example right now but it was tested a year or two ago with a specific dualiso file and the result was striking.
Good work!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 29, 2023, 03:44:49 PM
Around here was the moment where we confirmed issues and that the older vertical stripes code were more robust. 2017, oh my, time flies.
https://www.magiclantern.fm/forum/index.php?topic=15108.msg183884#msg183884
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 29, 2023, 03:58:42 PM
Uff very hard to notice those vertical stripes, let's see if someone has an example that I can use.

In the meantime, I've done a lot of test and it seems that the new dual ISO code that I've added it's slower and the only benefit was that half-res was working, so I've fixed halfres on the old code and added the openmp directives there, and now I can get consistent results.

If someone with Windows have time to try, please use this version (https://mega.nz/file/ohMxxJqb#T2OKt8gRuRSauLakxVXfsoCLqC9M-lMVhfmcokkkMcc) to compare with the current release.
Edit: Same for MacOS arm64[/s]]Same for MacOS arm64 (http://[s)
I've noticed the biggest gains with this clip (https://mega.nz/file/0kVAyYyR#AU8nyOO2hkXck2Rv4IY7e70kfS9tdQlYgRqTIsoyrb0), from 6:25 on the current version, to 1:42 on this test version  :o
Edit: On my Mac M1, on the current version takes 2:16 and on the new one just 56 seconds.
Other clips doesn't have such big gains, but all my dual iso clips improved their speed (and the temporal fix for pink stripes is added as well)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 29, 2023, 04:04:46 PM
Cool.
With older vert stripes code at least user can disable stripes correction when processing dualiso but also enable it once stripes shows. Before it was totally useless for dualiso  8).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 29, 2023, 07:54:25 PM
Quote from: iaburn on January 29, 2023, 03:58:42 PM
Edit: Same for MacOS arm64 (https://mega.nz/file/14kjGLJA#TWN_RT3TJbJiZJOjtcoLB73TYaEVhCPCoVukPJyGXa8)
I've noticed the biggest gains with this clip (https://mega.nz/file/0kVAyYyR#AU8nyOO2hkXck2Rv4IY7e70kfS9tdQlYgRqTIsoyrb0), from 6:25 on the current version, to 1:42 on this test version  :o
Unfortunately it doesn't work here. Can't open the app and also can't sign it. Something seems to be wrong.

Edit: downloaded and compiled your version:
the stripes are gone with it. Speed is better: 1:24min the main branch, 1:16min with your branch. Both exported to ProRes422 on my MacBookAir M1.

Nice work!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 29, 2023, 08:30:55 PM
Quote from: masc on January 29, 2023, 07:54:25 PM
Unfortunately it doesn't work here. Can't open the app and also can't sign it. Something seems to be wrong.

Edit: downloaded and compiled your version:
the stripes are gone with it. Speed is better: 1:24min the main branch, 1:16min with your branch. Both exported to ProRes422 on my MacBookAir M1.

Nice work!

The version on git is not updated because I started again in another copy and I cannot have 2 forks from the same project :(
So the one that you tried is actually slower on many clips, that's why I started again from the master branch.
Please try again with this code, it should be faster https://mega.nz/file/p4dn0QYA#ySjr95pBiri-2EUKM1Dk6Qp6sO3CdTT7mb2VLlRNZJc
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 29, 2023, 08:58:20 PM
Tested your first fork which exports at 1:08(test clip) against regular mlv app source 1:33. Your provided test source says 3 minutes but halfway in Mlv app unexpectedly quits. I´d say your fork at github was fastest ;).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 29, 2023, 09:00:50 PM
The uploaded codes, compiled and tested ends in strange processing. Each try looks different, for one and the same frame...
(https://i.ibb.co/w46B0VL/Bildschirmfoto-2023-01-29-um-20-58-03.png)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 29, 2023, 09:09:48 PM
Quote from: masc on January 29, 2023, 09:00:50 PM
The uploaded codes, compiled and tested ends in strange processing. Each try looks different, for one and the same frame...
(https://i.ibb.co/w46B0VL/Bildschirmfoto-2023-01-29-um-20-58-03.png)
Quote from: Danne on January 29, 2023, 08:58:20 PM
Tested your first fork which exports at 1:08(test clip) against regular mlv app source 1:33. Your provided test source says 3 minutes but halfway in Mlv app unexpectedly quits. I´d say your fork at github was fastest ;).

Sorry you are both right, I uploaded the code that I was working on, with some extra untested "pragma paralels" and it's probably broken, but before I broke it, it was significantly faster than the code on Github. I'll debug the latest changes.
For comparison, a clip that takes 2:23 on the Github code, took 1:42 on my WIP.
Another clip goes from 1:48 to 54 seconds, but on the current release was 1:28, so faster than on my latest code on Github.

I forgot to mention that I always turn off "alias map"!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 29, 2023, 09:12:51 PM
Nice progress. Keep it up and we will keep testing stuff.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 29, 2023, 09:19:44 PM
I've updated the source in mega with the lines breaking it commented:
https://mega.nz/file/p4dn0QYA#ySjr95pBiri-2EUKM1Dk6Qp6sO3CdTT7mb2VLlRNZJc

This should work and be faster, but there are a lot more parts that can be optimized with time and patience
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 30, 2023, 12:32:56 AM
Nice. About 50s now  8).
What about vertical stripes correction? When added I get porsterization again? Is it always on when disabled or not working with older raw2dng code? Maybe not connected yet?
Also, why aren´t you pushing all stuff to your original fork :)? Or can you create sub-branches of your own fork?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 30, 2023, 02:05:27 PM
Tested some more wit dualiso. Very promising. Fast export, and files are as clean as a canon R5 in the shadows ;).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 30, 2023, 04:51:23 PM
Quote from: Danne on January 30, 2023, 12:32:56 AM
Nice. About 50s now  8).
What about vertical stripes correction? When added I get porsterization again? Is it always on when disabled or not working with older raw2dng code? Maybe not connected yet?
Also, why aren´t you pushing all stuff to your original fork :)? Or can you create sub-branches of your own fork?

I wanted to fix things like the chroma smooth not working, and add bad pixels and vertical stripes fixes from the other code.
Make sense a new branch there, I don't know why I didn't do it xD
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 30, 2023, 04:54:51 PM
I noticed bad pixels and focus pixels worked on my eos m with dual iso. Badass!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 30, 2023, 08:59:27 PM
I've just fixed the chroma smoothing that I broke, and in theory the vertical stripes fix is "working", we cannot test because we have no dual iso videos with the vertical stripes problem!
I've reverted back to the normal bad pixels fix, I think it works better than the dual ISO specific method that was in the code  ::)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on January 30, 2023, 09:04:46 PM
Nice. What branch can I suck the code from  8).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 30, 2023, 10:22:51 PM
Quote from: Danne on January 30, 2023, 09:04:46 PM
Nice. What branch can I suck the code from  8).
I'm trying to put the changes in dev/dual_iso_update and take the master back to the head of the original repository, but for now both the master and the branch have the same code Now just the dev/dual_iso_update is updated  ;D
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 01, 2023, 12:35:14 PM
I have updated the branch with mutithread enabled for the demosaic function on Dual ISO, and the speed on the M1 just doubles :O From 56 seconds before for a 100 frames, to just 26 (with alias map disabled on both cases)
I always test the speed improvements on playback, disabling drop frame mode and measuring the time it takes to go through a 100 frames. I feel this way raw ISO processing has more weight on the total time than exporting.

The only problem on my computer at least, is that the bigger the window, the slower the playback... A 1080p clip plays at over 25fps if I make the window small, but just about 12fps when I make it bigger.  It doesn't happen on my windows PC.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 01, 2023, 08:28:15 PM
Quote from: iaburn on February 01, 2023, 12:35:14 PM
The only problem on my computer at least, is that the bigger the window, the slower the playback... A 1080p clip plays at over 25fps if I make the window small, but just about 12fps when I make it bigger.  It doesn't happen on my windows PC.
That is because of QPainter / QGraphicsScene engine. I found no way to have it always fast. It seems it draws the pixels individually...  ::)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 01, 2023, 09:17:45 PM
Quote from: masc on February 01, 2023, 08:28:15 PM
That is because of QPainter / QGraphicsScene engine. I found no way to have it always fast. It seems it draws the pixels individually...  ::)

At least I'm not crazy, I thought I was the only one  :D

I've added now the openmp directives to almost all the loops I could on Dual ISO. I took these screenshots while playing the same dual ISO video on windows and mac, an image is worth a thousand words  :o

Mac current arm64 release:
(https://i.postimg.cc/tY9CQkk8/old-m1.jpg) (https://postimg.cc/tY9CQkk8)

Mac arm64 with multithread:
(https://i.postimg.cc/PCRtDjHk/openmp-m1.jpg) (https://postimg.cc/PCRtDjHk)

Win current x64 release:
(https://i.postimg.cc/yDd1WNwP/old-win.jpg) (https://postimg.cc/yDd1WNwP)

Mac x64 with multithread:
(https://i.postimg.cc/gn4cYhBj/openmp-win.jpg) (https://postimg.cc/gn4cYhBj)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on February 01, 2023, 09:36:13 PM
iaburn, I love you

Would be eager to test your code on Mac x86, not sure where I can get it. Did you fork ilia's master on GitHub?

PS: is it multi threading or multiprocessing, strictly speaking?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 01, 2023, 09:53:41 PM
Here is the fork, it will only be faster with Dual ISO! https://github.com/anibarro/MLV-App (https://github.com/anibarro/MLV-App)
By all means, please test it on Mac x86 if you have the chance and report back any issues. My x86 macbook pro is a dual core from 2012, too old to benefit much from this...

I guess it's multi threading and multiprocessing. Openmp is handling the threads and distributing loops among them.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 01, 2023, 10:08:21 PM
Cool stuff will test later. By the way. Uploaded a new eos m version build. With 2.8 it would not start recoridn dualiso until like the third frame but fixed now.

Another question. I believe dualiso was autodetected before? Seems the diso blcok is there but Mlv app isn´t following it anymore? @masc?
Block: DISO
  Offset: 0x000007f0
  Number: 17
    Size: 24
    Time: 7738.273000 ms
     Mode:        1
     ISO Value:   0

Mode: 1
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 01, 2023, 10:12:09 PM
Quote from: Danne on February 01, 2023, 10:08:21 PM
Cool stuff will test later. By the way. Uploaded a new eos m version build. With 2.8 it would not start recoridn dualiso until like the third frame but fixed now.

Another question. I believe dualiso was autodetected before? Seems the diso blcok is there but Mlv app isn´t following it anymore? @masc?
Block: DISO
  Offset: 0x000007f0
  Number: 17
    Size: 24
    Time: 7738.273000 ms
     Mode:        1
     ISO Value:   0

Mode: 1

Thanks for the heads-up, I'll update. And I've also noticed that it was not auto-detecting dual iso  ::)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 02, 2023, 08:10:54 AM
@iaburn: VERY IMPRESSIVE! WOW! Tested your dualiso clips on Intel i7 Quadcore Mac. In playback it feels like double speed now. In export to ProRes422 AVFoundation: 1:26 vs. 1:00 for your 100frames 2.5K clip. The cores now are used!

However I found a problematic clip, which now looks worse than before - even if it is processed also in double speed. See all the artifacts around the tree. Left: yours, right: official. Most of this can be removed with MLVApp CA Desaturate slider. But in e.g. Resolve, this doesn't exist.
(https://i.postimg.cc/TGTDqnJ9/Bildschirmfoto-2023-02-02-um-08-04-10.png)

https://www.dropbox.com/s/642u0t8kqy9od3e/5DII-DualIso.MLV?dl=0

Quote from: Danne on February 01, 2023, 10:08:21 PM
Cool stuff will test later. By the way. Uploaded a new eos m version build. With 2.8 it would not start recoridn dualiso until like the third frame but fixed now.

Another question. I believe dualiso was autodetected before? Seems the diso blcok is there but Mlv app isn´t following it anymore? @masc?
Block: DISO
  Offset: 0x000007f0
  Number: 17
    Size: 24
    Time: 7738.273000 ms
     Mode:        1
     ISO Value:   0

Mode: 1

Here it still works... in both versions, official and iaburns. (if "force" button is hidden, all is fine. In my screenshot, the clip is too old for this.)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on February 02, 2023, 08:56:59 AM
Quote from: iaburn on February 01, 2023, 09:53:41 PM
By all means, please test it on Mac x86 if you have the chance and report back any issues.

Ok so, tested uncompressed cDNG export for a lossless 14-bit 1x1 3584x1500 Dual ISO MLV clip (on i5-8500, 6-core) with 5x5 chroma smoothing. Here we go:
A nice 150% increase in export speed! 8)

Congrats iaburn and all.

Still have to check exported DNG quality, didn't have the time. Will update this post in 12h time.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mattia on February 02, 2023, 09:15:13 AM
Quote from: vastunghia on February 02, 2023, 08:56:59 AM
Ok so, tested uncompressed cDNG export for a lossless 14-bit 1x1 3584x1500 Dual ISO MLV clip (on i5-8500, 6-core) with 5x5 chroma smoothing. Here we go:

  • Official 1.14 release: 1.92 s / frame
  • ilia's 330563 commit with Qt6-llvm15: 1.79 s / frame
  • iaburn's 254ad90 commit with Qt6-llvm15: 0.75 s / frame (1.3 fps)
A nice 150% increase in export speed! 8)

Congrats iaburn and all.

Still have to check exported DNG quality, didn't have the time. Will update this post in 12h time.

Is this increase only on Mac? Any chance for the Windows version?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 02, 2023, 09:23:35 AM
Quote from: masc on February 02, 2023, 08:10:54 AM
However I found a problematic clip, which now looks worse than before - even if it is processed also in double speed. See all the artifacts around the tree. Left: yours, right: official. Most of this can be removed with MLVApp CA Desaturate slider. But in e.g. Resolve, this doesn't exist.

Thanks for testing! This artifacts on the tree are created by my "fix" for the pink lines on the fullres_reconstruction function  :-[
I will try to understand better what the values are to see if auto-adjusting the threshold will be possible and if that would be enough. I wish we could ask someone who really understand all this stuff... Maybe letting the user adjust the value using a slider could be a temporary solution at least

@vastunghia thanks a lot for sharing, I'm curious what the performance gain will be with different hardware :)

@Mattia I'm doing all the testing in Windows, every multicore processor should benefit from this (the more cores, the more benefit most likely)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on February 02, 2023, 09:52:20 AM
Quote from: iaburn on February 02, 2023, 09:23:35 AM
Maybe letting the user adjust the value using a slider could be a temporary solution at least

My 2 cents: that could be a final solution as well. Guess it could be nearly impossible to devise an algorithm that achieves optimal results automagically in all circumstances. A final word left to the user would be very healthy IMO.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 02, 2023, 01:07:44 PM
Quote from: Mattia on February 02, 2023, 09:15:13 AM
Is this increase only on Mac? Any chance for the Windows version?
The dualiso refactoring is for all OS. The compiler optimization is macOS only.

Quote from: iaburn on February 02, 2023, 09:23:35 AM
Maybe letting the user adjust the value using a slider could be a temporary solution at least
Let me know if you wish me to create another slider. I then need min/max value and number of steps.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mattia on February 02, 2023, 04:04:57 PM
Quote from: iaburn on February 02, 2023, 09:23:35 AM

@Mattia I'm doing all the testing in Windows, every multicore processor should benefit from this (the more cores, the more benefit most likely)

When will you release an updated version on the website? :)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 02, 2023, 04:16:41 PM
Quote from: masc on February 02, 2023, 01:07:44 PM
Let me know if you wish me to create another slider. I then need min/max value and number of steps.

In theory they are 20bit unsigned integers, so up to 1048512 with the granularity on the slider like 10000 should work, and it should default to 0.
But let's wait a bit to see if there is a better solution to fix the stripes. I'm not convinced of going for this solution because if you would have pink stripes in your clip, there might not be a value that removes the stripes and don't mess the tree branches ::)

Quote from: Mattia on February 02, 2023, 04:04:57 PM
When will you release an updated version on the website? :)
Still testing and it has problems, but you can try and report your issues with this windows version (if it works): https://mega.nz/file/Vh1xVJTY#B6RM7zaSbMyOVgR6IByvN8F6LeoQS-HL-h1ZdYbvjQE https://mega.nz/file/ohMxxJqb#T2OKt8gRuRSauLakxVXfsoCLqC9M-lMVhfmcokkkMcc
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 02, 2023, 04:49:26 PM
Quote from: Mattia on February 02, 2023, 04:04:57 PM
When will you release an updated version on the website? :)
Release comes when it is ready. Until that: feel free to compile as much commits you like. It is very easy.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 02, 2023, 05:19:59 PM
Quote from: iaburn on February 02, 2023, 04:16:41 PM
Still testing and it has problems, but you can try and report your issues with this windows version (if it works): https://mega.nz/file/Vh1xVJTY#B6RM7zaSbMyOVgR6IByvN8F6LeoQS-HL-h1ZdYbvjQE

This version re-introduced the artifacts which was the reason why openmp was disabled completely in the past, the artifacts happens randomly in MLV clip:

-This is the same frame, first photo with artifacts and second without it:

(https://i.ibb.co/FDS6jXN/Artifacts.png)

(https://i.ibb.co/6BM5HGV/No-Artifacts.png)

-These two images were proceeded with the same MLVApp version linked above.

This version doesn't have the artifacts:
Quote from: iaburn on January 29, 2023, 03:58:42 PM
If someone with Windows have time to try, please use this version (https://mega.nz/file/ol8UjJ7a#Xn1UqFrsWNGFMU9L_OuVC4RSCOScJ541uObOzXkUGSg) to compare with the current release.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 02, 2023, 05:33:47 PM
Quote from: theBilalFakhouri on February 02, 2023, 05:19:59 PM
This version re-introduced the artifacts which was the reason why openmp was disabled completely in the past, the artifacts happens randomly in MLV clip:

Hi, please note that Masc already reported an issue a few post above that's most likely the same, not related with openmp but with my faulty fix for pink stripes on higlights. I would like to find a solution that works in all cases, but still need to figure out how.

To make sure that was the issue, please clone the default branch on this repository (https://github.com/anibarro/MLV-App),set offset_threshold here (https://github.com/anibarro/MLV-App/blob/254ad90b5e49e3ccd2d3825258a8d5c32a18def3/src/mlv/llrawproc/dualiso.c#L1545) to 0 (edit: not to 0, the oposite! INT_MAX for example) and report back. Thanks!

PS: could you please share a few frames from that video for my tests?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 02, 2023, 05:36:36 PM
Quote from: theBilalFakhouri on February 02, 2023, 05:19:59 PM
This version re-introduced the artifacts which was the reason why openmp was disabled completely in the past, the artifacts happens randomly in MLV clip:

-This is the same frame, first photo with artifacts and second without it:

(https://i.ibb.co/FDS6jXN/Artifacts.png)

(https://i.ibb.co/6BM5HGV/No-Artifacts.png)

-These two images were proceeded with the same MLVApp version linked above.

This version doesn't have the artifacts:
Could you test that file with fullres blending to OFF bilal?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 02, 2023, 06:08:38 PM
I've removed the "fix" from the branch so people can focus on actual problems from openmp and don't get confused with this, and also updated the compiled version that I posted before.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 02, 2023, 06:32:48 PM
Quote from: iaburn on February 02, 2023, 05:33:47 PM
Hi, please note that Masc already reported an issue a few post above that's most likely the same, not related with openmp but with my faulty fix for pink stripes on higlights. I would like to find a solution that works in all cases, but still need to figure out how.

Just download the clip uploaded by masc (https://www.magiclantern.fm/forum/index.php?topic=20025.msg241955#msg241955), I can't see the same problem in masc's clip.

Here is the same frame but was processed in MLVApp 1.1:

-Artifacts:

(https://i.ibb.co/PmKprzg/Artifacts-MLVApp-1-1.png)

-No Artifacts:

(https://i.ibb.co/Y7q5CNH/No-Artifacts-MLVApp1-1.png)

It happens randomly, and the issue isn't new.
Probably some of the loops with openmp causes the issue, not all of them.

Quote from: iaburn on February 02, 2023, 05:33:47 PM
To make sure that was the issue, please clone the default branch on this repository (https://github.com/anibarro/MLV-App),set offset_threshold here (https://github.com/anibarro/MLV-App/blob/254ad90b5e49e3ccd2d3825258a8d5c32a18def3/src/mlv/llrawproc/dualiso.c#L1545) to 0 (edit: not to 0, the oposite! INT_MAX for example) and report back. Thanks!

Okay, I will do that soon.

Quote from: iaburn on February 02, 2023, 05:33:47 PM
PS: could you please share a few frames from that video for my tests?

Sure, here is a sample, few frames from the clip which show the issue:
https://drive.google.com/file/d/13dA8CqnvAwxwxF1qeXOMLTOk4mQmFHAU/view?usp=share_link




Quote from: Danne on February 02, 2023, 05:36:36 PM
Could you test that file with fullres blending to OFF bilal?

Yup, tested, same problem. MLV clip sample was provided too.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 02, 2023, 06:42:48 PM
Thanks for the clip! I tested now and you are right, it's a different issue, I'll take a look :)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 02, 2023, 06:55:07 PM
No problem, Good luck! :)

-Just a little reminder:

This version doesn't have the issue, and it probably using some openmp for some loops:
Quote from: iaburn on January 29, 2023, 03:58:42 PM
If someone with Windows have time to try, please use this version (https://mega.nz/file/ohMxxJqb#T2OKt8gRuRSauLakxVXfsoCLqC9M-lMVhfmcokkkMcc) to compare with the current

It's probably some of the recent loops cause the issue, how many loops? I don't know. It could be that one loop with openmp casues the problem.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 02, 2023, 08:11:27 PM
Quote from: theBilalFakhouri on February 02, 2023, 06:55:07 PM
No problem, Good luck! :)

-Just a little reminder:

This version doesn't have the issue, and it probably using some openmp for some loops:
It's probably some of the recent loops cause the issue, how many loops? I don't know. It could be that one loop with openmp casues the problem.

Actually that version was the same last version that you tried, I went to my older posts and replaced it  :P  It did have the issue as well, but as you mentioned, it was only showing up sometimes.
There are a few loops that I was not sure about, and one of them was the culprit. Your test sample looks good now, I played back and forth multiple times with no issue, so I've updated the Git branch (here a compiled version (https://mega.nz/file/Vs1w1Y4L#mRxvzOKnL8HZ-PUq-vSDazh6rtcE9R9VMymg4zD422Y) for Windows just in case)

I read that whenever you have an expression over a shared variable like "var++;", you need to use "atomic", and that makes sense, but in the case below I first thought it was not needed because the address on that 2-dimension vector will be different on each loop given that y and x are different, but it's not always... With the "atomic" directive should be fine :)

#pragma omp parallel for schedule(static) default(none) shared(raw_info, image_data, y0, h, w,hist) collapse(2)
    for (int y = y0; y < h/4*4; y++)
    {
        for (int x = 0; x < w; x++){
#pragma omp atomic
            hist[(y%2)*2 + (x%2)][raw_get_pixel16(x,y) & 16383]++;
        }
    }


Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 02, 2023, 09:06:56 PM
Quote from: iaburn on February 02, 2023, 08:11:27 PM
Actually that version was the same last version that you tried, I went to my older posts and replaced it  :P  It did have the issue as well, but as you mentioned, it was only showing up sometimes.

It seems I downloaded it before you replaced the link :) , I downloaded it 2 days ago, didn't check if the link was changed.
The version I am referring to is the one which was compiled in 29/1/2022, was named "MLVApp_openmp_test_1_0.zip", size of 67.5 MB.

Quote from: iaburn on February 02, 2023, 08:11:27 PM
.. (here a compiled version (https://mega.nz/file/Vs1w1Y4L#mRxvzOKnL8HZ-PUq-vSDazh6rtcE9R9VMymg4zD422Y) for Windows just in case)

Seems fixed with this version, great work! 8)
Edit: Nice you have narrowed it down and fixed it :)

Will do speed tests against official MLVApp, also will look for problems (if there are any).

Thanks!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 02, 2023, 09:13:40 PM
Thanks to you for testing! Let's see if more Dual ISO shooters feel like trying, I can only test with my EOS M
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 02, 2023, 10:04:17 PM
Yet another issue :( , it also happens randomaly:

-Good frame:
(https://i.ibb.co/W04dNSJ/Good-frame.jpg)

-Same frame, but bad:
(https://i.ibb.co/jgTWY5D/Not-good-frame.png)

-Same frame, but bad:
(https://i.ibb.co/G0GpL10/Not-good-frame-2.jpg)

-MLV sample:
https://drive.google.com/file/d/17N-Fobz5pEy5jdI_XI7LnwyK8k5Koxa8/view?usp=share_link

-All three frames were processed with "MLVApp_openmp_test_1_2.zip".
-"MLVApp_openmp_test_1_0.zip" doesn't have the issue, while "MLVApp_openmp_test_1_1.zip" and "MLVApp_openmp_test_1_2.zip" have it, probably another loop needs same as the recent fix (https://www.magiclantern.fm/forum/index.php?topic=20025.msg241985#msg241985)?
-Official MLVApp doesn't have the issue too.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 02, 2023, 11:20:55 PM
OMG... this one was totally broken, it's funny how a video can be destroyed and others look normal :O

It was again the exact same problem, I forgot that there were 2 for loops with this pattern... and fixed another similar one. I think that was the last one.

Git updated and another build: https://mega.nz/file/8kFUTBpC#f6ziyp06ds2E3b1NIgzQlLkDGae8LBDE8duL2zf0W5U (https://mega.nz/file/8kFUTBpC#f6ziyp06ds2E3b1NIgzQlLkDGae8LBDE8duL2zf0W5U)

Thanks again!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 02, 2023, 11:34:11 PM
Damn, your good. Nice to see this progress. Bravo.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on February 03, 2023, 12:03:16 PM
The issue has been fixed, thanks again iaburn, nice work!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 04, 2023, 08:49:09 AM
Testing dualiso from iaburn. Very reliable and fast. I bet one could run three copies of Mlv App in parallell to make the M1 sweat hard here.
Workflow for non flickery files.
Pull down E"xposure" to get good highlights. Pull shadows with "Lighten". Add color etc. That´s it. Didn´t test much further.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 04, 2023, 12:07:18 PM
Happy that we have no more issues so far  :D

@masc there are reports about focus pixels fixing being not that good for dual ISO. I tried moving the focus pixels fix after the dual iso processing and it seems to work very well (better than with the current flow) with the interpolation method 3 + chroma smooth 3x3.

The only problem is that, as soon as I switch Focus pixels fix OFF, I cannot turn it ON again. I have to turn OFF Dual iso, set focus pixels on, and then turn dual iso ON again.
I tried to follow the update process but it's quite hard, I couldn't find the reason why an innocent change in the order will do that  ::)

I've created a branch in case you would have time to check: https://github.com/anibarro/MLV-App/tree/dev/diso_focus_pixels
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 05, 2023, 12:16:42 AM
Quote from: iaburn on February 04, 2023, 10:22:05 AM
Thanks for the samples, very good tests for debugging the focus pixels issue :)
I tried moving the pixel fixing stuff after the Dual ISO processing and doing the fixing ignoring that it's a Dual ISO video works very well, looks almost identical to the non-dual ISO:
single:
(https://i.ibb.co/qgVpD7T/M03-2329-Single-ISO-frame-1.png) (https://ibb.co/T0dtwY9)

dual:
(https://i.ibb.co/Z2hhGSR/M03-2330-Dua-ISO-frame-1.png) (https://ibb.co/tLbbQzw)

I just need to find out why once I switch fix focus pixels OFF, cannot turn it ON again  ??? Let's discuss this on the MLVApp thread if you don't mind, it's not related to Danne's builds

Yep. looks good.
In my last post on Danne's thread, I included Dual ISO MLV files which show a dead pixel on the Sensor clearly, if you need to verify if "Fix Dead Pixels" work as expected.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 05, 2023, 09:47:23 AM
Quote from: gabriielangel on February 05, 2023, 12:16:42 AM
In my last post on Danne's thread, I included Dual ISO MLV files which show a dead pixel on the Sensor clearly, if you need to verify if "Fix Dead Pixels" work as expected.

Thanks for the samples, the chart clip helped me finding a mistake I did on the white detect function... Still more testing needed  :-\

The flicker on the highlights seems to be linked to how dual ISO works. On normal video the artifacts are always on the same spots, but when dual ISO is selected, the lines alternate, very clearly seen on your doll's arm on 1080HD.

Edit: I also play a bit with the dead pixel fix and it works better ignoring that it's a dual ISO clip... but we will need a lot more videos with dead pixels for testing
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Dmytro_ua on February 05, 2023, 11:10:32 AM
Hi
Just downloaded MLV.App.v1.14.macOS-ARM64.dmg for my M1 Pro (Monterey 12.6.1) but after installation I cannot run it. I've got an error that the program is corrupted and it should be deleted. On the other hand MLV.App.v1.14.macOS-Intel.dmg works fine.
What's wrong?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 05, 2023, 01:12:09 PM
Quote from: iaburn on February 05, 2023, 09:47:23 AM
The flicker on the highlights seems to be linked to how dual ISO works. On normal video the artifacts are always on the same spots
Turn off fullres blending? Also stick to lowering exposure and raise shadows with Lighten. Should yield flicker free files.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 05, 2023, 02:00:17 PM
Quote from: Danne on February 05, 2023, 01:12:09 PM
Turn off fullres blending? Also stick to lowering exposure and raise shadows with Lighten. Should yield flicker free files.
"Flicker" might be to wrong word for what gabriielangel was describing, it's something else, more related to the low resolution and artifacts of 1080HD mode... I never use dual ISO in this mode

@gabriielangel could you share also the 1080HD clip from the dolls with the highlights problem? Both the normal and dual ISO if possible. Thanks!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 05, 2023, 04:18:41 PM
Actually, one of the doll clips would give flicker because some of the files in the middle wouldn´t process correctly with fullres blending on.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 05, 2023, 04:41:03 PM
Quote from: iaburn on February 04, 2023, 12:07:18 PM
@masc there are reports about focus pixels fixing being not that good for dual ISO. I tried moving the focus pixels fix after the dual iso processing and it seems to work very well (better than with the current flow) with the interpolation method 3 + chroma smooth 3x3.

The only problem is that, as soon as I switch Focus pixels fix OFF, I cannot turn it ON again. I have to turn OFF Dual iso, set focus pixels on, and then turn dual iso ON again.
I tried to follow the update process but it's quite hard, I couldn't find the reason why an innocent change in the order will do that  ::)

I've created a branch in case you would have time to check: https://github.com/anibarro/MLV-App/tree/dev/diso_focus_pixels
I loaded this branch, compiled and loaded one of your sunset clips. Just chroma smoothing can kill (most of the) focus pixels. The behaviour you described... can't see it. Focus pixel buttons don't have any effect. Chroma smooth is working On/Off. Is it the correct branch?

Edit... as soon as I write it, I found it. Is @bouncyball still in the house? Did you implement some intermediate buffer for faster processing here? Unfortunately I am not very deep in llrawproc functions. I just build the GUI around it...

Edit2: what about things like that:

/* do chroma smoothing */
    if (video->llrawproc->chroma_smooth && video->llrawproc->dual_iso != 1) // do not smooth 20bit dualiso raw
    {
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 05, 2023, 05:51:22 PM
Hi, thanks for checking!
Chroma smooth is done inside the dual ISO processing function, so it's ok that it's not done outside.

I'll try to find the reason why focus pixels fix cannot be turned ON while Dual ISO is active if the function is moved after dual ISO...  ::)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 05, 2023, 05:52:21 PM
Quote from: Danne on February 05, 2023, 04:18:41 PM
Actually, one of the doll clips would give flicker because some of the files in the middle wouldn´t process correctly with fullres blending on.

Danne you mean some of the frames? I've updated the branch with some fixes
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 05, 2023, 06:16:04 PM
Test exporting the file M04-1236-BldFeb042023am.MLV with fullres blending.
EDIT: Seems fixed now :)! Great!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 05, 2023, 10:13:20 PM
Quote from: iaburn on February 05, 2023, 02:00:17 PM
"Flicker" might be to wrong word for what gabriielangel was describing, it's something else, more related to the low resolution and artifacts of 1080HD mode... I never use dual ISO in this mode

@gabriielangel could you share also the 1080HD clip from the dolls with the highlights problem? Both the normal and dual ISO if possible. Thanks!

Here: http://bit.ly/3Y44k3h

Keep in mind, there was the metadata issue, so single ISO says dual iso.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 05, 2023, 10:25:35 PM
Hello  MLV people, would it be possible to compile  the latest MLVApp version for older OSX (10.13 in my case)?

I managed to compile, but llvm is a no go on my machine. So I cannot render with it (20 minutes for a 3 second clip with full processing) Not possible for me to Upgrade to the latest OS, as I will lose my Adobe Creative suite (Adobe erased all the old downloads from their site to force  you to go the subscription route...)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 06, 2023, 07:53:12 AM
Quote from: iaburn on February 05, 2023, 02:00:17 PM
"Flicker" might be to wrong word for what gabriielangel was describing, it's something else, more related to the low resolution and artifacts of 1080HD mode... I never use dual ISO in this mode

@gabriielangel could you share also the 1080HD clip from the dolls with the highlights problem? Both the normal and dual ISO if possible. Thanks!

Here are more MLV files you can use to check the effects on hair, fur, colors and textures.
Some of the dirty pixels trapped in the thin strands of hair can be reduced by playing with CA Correction and CA Desaturate, but not all.

Please Download ASAP, I will remove tomorrow as my drive is very full :)

http://bit.ly/3jvWL6c (http://bit.ly/3jvWL6c)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 06, 2023, 08:10:27 AM
Quote from: gabriielangel on February 06, 2023, 07:53:12 AM
Here are more MLV files you can use to check the effects on hair, fur, colors and textures.
Some of the dirty pixels trapped in the thin strands of hair can be reduced by playing with CA Correction and CA Desaturate, but not all.

Please Download ASAP, I will remove tomorrow as my drive is very full :)

http://bit.ly/3jvWL6c (http://bit.ly/3jvWL6c)
to save space I think you just have to cut in out about few frames in mlvapp then export to mlv file again as a sample file..
but I don't know if it makes any different in quality.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 06, 2023, 08:53:29 AM
Quote from: ML700D on February 06, 2023, 08:10:27 AM
to save space I think you just have to cut in out about few frames in mlvapp then export to mlv file again as a sample file..
but I don't know if it makes any different in quality.

I cut each file to 2 seconds like you said (MLV Fast Pass), to give enough time to see flicker and aliasing artifacts, if any. Those files are just huge by file transfer standards :)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 06, 2023, 09:13:05 AM
All of the provided clips looks good when processed. If we get back to this clip:
M04-1236-BldFeb042023am.MLV it will give a subtle flicker. It´s 10bit though. Is it possible to record a similar clip at 14bit? Dual iso is strongest when 14bit. 10bit not so useful imo.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 06, 2023, 10:30:55 AM
Quote from: gabriielangel on February 06, 2023, 08:53:29 AM
I cut each file to 2 seconds like you said (MLV Fast Pass), to give enough time to see flicker and aliasing artifacts, if any. Those files are just huge by file transfer standards :)
I see..
I have downloaded your file I thought it's just one mlv clip 😅

for now I just having fun with xxx/800 and 1440p 1:1 preset from bilal's crop rec..
dual iso is great feature if there is no issue.
(https://i.ibb.co/BqTzC0v/Screenshot-2023-02-06-161403.jpg)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 06, 2023, 10:40:44 AM
Pushed a fix for eosm around dualiso and flicker. Should be fixed now.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 06, 2023, 11:12:47 AM
Quote from: Danne on February 06, 2023, 09:13:05 AM
All of the provided clips looks good when processed. If we get back to this clip:
M04-1236-BldFeb042023am.MLV it will give a subtle flicker. It´s 10bit though. Is it possible to record a similar clip at 14bit? Dual iso is strongest when 14bit. 10bit not so useful imo.

That particular preset (5k ana flv) won't do 14bits. It defaults to 10, and can usually record 1minute+ at 12.
I can do another clip, but I have to wait until everyone is done downloading the others. I'm out of space.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 06, 2023, 04:21:17 PM
I fixed fps in that mode so 10bit might still be valid :)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 06, 2023, 07:58:06 PM
I've updated a branch that applies twice the focus pixel fix for dual ISO, the second one after the dual ISO processing, like a non-dual ISO video, and the results are much better on my tests. More obvious on binning modes due to larger stretched pixels, but less artifacts in all modes.
A comparison, better download and switch from one to another:

No focus pixels fix:
(https://i.ibb.co/xCnw6xr/off.png) (https://ibb.co/h7GrV3T)

Normal fix, the current one:
(https://i.ibb.co/ZWRdt1b/normal.png) (https://ibb.co/Gcf7B3r)

Double fix:
(https://i.ibb.co/JR2Ppj4/double.png) (https://ibb.co/5WvVjhy)



Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 07, 2023, 01:53:49 AM
Quote from: Danne on February 06, 2023, 09:13:05 AM
All of the provided clips looks good when processed. If we get back to this clip:
M04-1236-BldFeb042023am.MLV it will give a subtle flicker. It´s 10bit though. Is it possible to record a similar clip at 14bit? Dual iso is strongest when 14bit. 10bit not so useful imo.

Here is another Batch of clips, mostly 14bits like you requested: http://bit.ly/3X7hATq (http://bit.ly/3X7hATq)

Clips were all recorded with Histogram showing 0.5.

Pay particular attention to M06-1306. I included a MLVApp receipt which will emphasize the point of interest.

One has to be careful with exposure, as when in dual Iso mode,  False colors and Histogram are not spot on (Those register a lot more headroom than what is actually available). 14bits is more forgiving, but I often clipped the snow outside when monitoring with those. I got good recordings when maximizing at both the base and recovering ISO individually, in single ISO mode and then enabled dualISO.


Recorded with 2023Feb06 Build.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 07, 2023, 02:06:03 AM
Quote from: gabriielangel on February 07, 2023, 01:53:49 AM
Here is another Batch of clips, mostly 14bits like you requested: http://bit.ly/3X7hATq (http://bit.ly/3X7hATq)

Clips were all recorded with Histogram showing 0.5.

Pay particular attention to M06-1306. I included a MLVApp receipt which will emphasize the point of interest.

One has to be careful with exposure, as when in dual Iso mode,  False colors and Histogram are not spot on (Those register a lot more headroom than what is actually available). 14bits is more forgiving, but I often clipped the snow outside when monitoring with those. I got good recordings when maximizing at both the base and recovering ISO individually, in single ISO mode and then enabled dualISO.

If you look at the waveform monitor in MlvApp, you can sometimes see that the absolute level is below clipping, but the shape of the drawing (Flat Top) suggests otherwise.


Recorded with 2023Feb06 Build.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 07, 2023, 04:53:29 AM
"Pay particular attention to M06-1306"
If you change fps to 20 fps, what do you expect to happen? Also height is altered?
My fix was about finetuning fps so your modification breaks the fix. It is very easy to see what happens by viewing the scanlines in dual iso output. In your example the lines are creeping around, if you look at the other clips output are showing calm, static lines.
If you intend to alter fps, at least find sweet spot and achieve static preview on your camera before recording.
In HD1080p dualiso won´t be flicker free as it runs native canon fps. Might fix this but dualiso with 3x3 looks like garbage mostly anyway.

Added 1736x2180 pixel map and uploaded an eosm build with the new resolution.

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 07, 2023, 05:33:08 AM
Quote from: Danne on February 07, 2023, 04:53:29 AM
"Pay particular attention to M06-1306"
If you change fps to 20 fps, what do you expect to happen? Also height is altered?
My fix was about finetuning fps so your modification breaks the fix. It is very easy to see what happens by viewing the scanlines in dual iso output. In your example the lines are creeping around, if you look at the other clips output are showing calm, static lines.
If you intend to alter fps, at least find sweet spot and achieve static preview on your camera before recording.
In HD1080p dualiso won´t be flicker free as it runs native canon fps. Might fix this but dualiso with 3x3 looks like garbage mostly anyway.

Added 1736x2180 pixel map and uploaded an eosm build with the new resolution.

Danne, maybe you should pay attention to your own stuff! Where did you get all that stuff you are talking about here? You asked me to send a similar clip at 14 bits, that's what I did!
Your preset defaults to 20 fps. Like I said, I used the build stock and only changed the ratio to 2.39:1...

Edit: I just double checked. All the 1736x2180 clips recorded in that batch recorded at the same  20.005 fps rate, and the 2520x1054 clips all recorded at 23.976 fps. So it's not a glitch.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 07, 2023, 06:02:36 AM
Ok, my bad. I thought your clip was from 5k anamorphic frtp and ratio set to off.

That particular preset I missed to fine tune.
In general I will focus mainly on the top presets in the tap display list. Bottom ones, not so much, used too little.
You can easily spot if output looks wrong now I guess.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 07, 2023, 08:50:49 AM
Quote from: iaburn on February 06, 2023, 07:58:06 PM
I've updated a branch that applies twice the focus pixel fix for dual ISO, the second one after the dual ISO processing, like a non-dual ISO video, and the results are much better on my tests. More obvious on binning modes due to larger stretched pixels, but less artifacts in all modes.
A comparison, better download and switch from one to another:

No focus pixels fix:
(https://i.ibb.co/xCnw6xr/off.png) (https://ibb.co/h7GrV3T)

Normal fix, the current one:
(https://i.ibb.co/ZWRdt1b/normal.png) (https://ibb.co/Gcf7B3r)

Double fix:
(https://i.ibb.co/JR2Ppj4/double.png) (https://ibb.co/5WvVjhy)

nice!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 07, 2023, 02:47:56 PM
Quote from: Danne on February 07, 2023, 06:02:36 AM
That particular preset I missed to fine tune.
In general I will focus mainly on the top presets in the tap display list. Bottom ones, not so much, used too little.
You can easily spot if output looks wrong now I guess.

Your 5k ANA Flv preset is quite useful. If you look at the Batch of files I sent yesterday (Dual_ISO_MLV-Hair-Fur-Glass.zip), it is the only preset where the fine strands of hair are completely stairstepping free.

Once you scale down to 2.8k or 2.5K, the gain in apparent resolution is substantial. When shooting a scene with deep DOF, it still shows details, like tree branches, where using 1080P would show a fuzzy mess. So I guess the 20fps limitation is ok when looking at the benefits. (And this may change, considering what Bilal is currently cooking... :) )
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 07, 2023, 03:23:55 PM
Meanwhile. It works with max res in flv and 1728x2180 already works with 24fps when 5k anamorphic ratio is turned OFF .
Flv preset could benefit from being recoded in X5 mode as it will work with higher framerates.
One could go on forever with magic lantern  8).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 19, 2023, 07:54:09 PM
I have a cam with a few bad pixels. Depending on the scene, enabling fix bad pixels may create some defects in the image.

Is there a way to put the cap on my camera, record (The bad pixels and hot pixels when using high ISO are then obvious), and then use the file in a way similar to darkframe subtraction (But to remove bad pixels instead)?

I tried averaging the recording and using dark frame subtraction, but it doesn't remove the pixels completely. It only fades those a little.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 19, 2023, 08:07:51 PM
You could create your own pixel map, which fixes the pixels you want to have fixed only. This map can be used for all your clips (in this camera setting) then.
https://www.youtube.com/watch?v=Xwd2DFGjMx0
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 19, 2023, 11:21:28 PM
I've done a small change on my fork (https://github.com/anibarro/MLV-App) and it seems to help with flickering in some clips (not all)!
The problematic video from this post (https://www.magiclantern.fm/forum/index.php?topic=20025.msg241808#msg241808) it's muuuch better now.
Before, this video was showing different issues when Alias Map or Fullres Blending were active, but now looks good when "horizontal stripes fix" is enabled (finally found a use for this fix  :D )

Did a windows build in case someone wants to try: https://mega.nz/file/A1tiTASK#OK46h1pPjzsJDILuHyoGQNbLWM6VVm0u7lUfm41CE1A

Edit: It seems to introduce horizontal lines where they were not present before... Using the "horizontal stripes fix" is an option but the result is not perfect, needs more work...
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 19, 2023, 11:23:53 PM
Thanks! This works very well. It works on Dual ISO clips too.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 19, 2023, 11:28:12 PM
Quote from: iaburn on February 19, 2023, 11:21:28 PM
I've done a small change on my fork (https://github.com/anibarro/MLV-App) and it seems to help with flickering in some clips (not all)!
The problematic video from this post (https://www.magiclantern.fm/forum/index.php?topic=20025.msg241808#msg241808) it's muuuch better now.
Before, this video was showing different issues when Alias Map or Fullres Blending were active, but now looks good when "horizontal stripes fix" is enabled (finally found a use for this fix  :D )

Did a windows build in case someone wants to try: https://mega.nz/file/A1tiTASK#OK46h1pPjzsJDILuHyoGQNbLWM6VVm0u7lUfm41CE1A
Thanks. Will try that.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 20, 2023, 09:32:27 AM
Quote from: iaburn on February 19, 2023, 11:21:28 PM
I've done a small change on my fork (https://github.com/anibarro/MLV-App) and it seems to help with flickering in some clips (not all)!
The problematic video from this post (https://www.magiclantern.fm/forum/index.php?topic=20025.msg241808#msg241808) it's muuuch better now.
Before, this video was showing different issues when Alias Map or Fullres Blending were active, but now looks good when "horizontal stripes fix" is enabled (finally found a use for this fix  :D )

Did a windows build in case someone wants to try: https://mega.nz/file/A1tiTASK#OK46h1pPjzsJDILuHyoGQNbLWM6VVm0u7lUfm41CE1A

Edit: It seems to introduce horizontal lines where they were not present before... Using the "horizontal stripes fix" is an option but the result is not perfect, needs more work...
nice..
dual iso flicker disappear but there is horizontal stripes flicker instead
(https://i.ibb.co/2ty91Zp/Untitled.jpg)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 20, 2023, 09:53:33 AM
Quote from: ML700D on February 20, 2023, 09:32:27 AM
nice..
dual iso flicker disappear but there is horizontal stripes flicker instead

True, I have to try more things... It's the problem when you don't know what you are doing, you can just experiment and see... XD
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mattia on February 23, 2023, 01:42:58 AM
I'm having a weird problem in MLVApp on some clips taken with my 5d3. The underexposed parts of the image are blue like if it was a false color view. Lifting the shadows solves the problem. In other apps, like MLV Producer, the problem doesn't show..
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 23, 2023, 02:28:48 AM
We need files and more info like print screens or similar. Very vague now.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mattia on February 23, 2023, 10:12:06 AM
Quote from: Danne on February 23, 2023, 02:28:48 AM
We need files and more info like print screens or similar. Very vague now.

You're right! Here are two clips (one 5.7k and the other 3.5k) opened in MLV App and in MLV Producer. As you can see the underexposed parts of the image in MLV App are shown like in a "false color" mode. In MLV Producer are shown correctly.

Here you can download the first clip: https://we.tl/t-dO0M2bTyrX

MLV App Clip 1
(https://i.imgur.com/NHc27ED.png)

MLV Producer Clip 1
(https://i.imgur.com/cQmqrVU.png)

MLV App Clip 2
(https://i.imgur.com/jYmggnn.png)

MLV Producer Clip 2
(https://i.imgur.com/XmH3mmD.png)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 23, 2023, 01:39:49 PM
It's no problem, it's a feature: you enabled Zebra function. Press Z to toggle it (or menu->view->show zebras). Blue is cut shadow, Red is cut highlight. You also see marker(s) in histogram.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mattia on February 23, 2023, 03:04:14 PM
Quote from: masc on February 23, 2023, 01:39:49 PM
It's no problem, it's a feature: you enabled Zebra function. Press Z to toggle it (or menu->view->show zebras). Blue is cut shadow, Red is cut highlight. You also see marker(s) in histogram.

Silly me!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: sc on February 25, 2023, 04:25:56 AM
Hi there;

I use Magic Lantern for visual effects work; my need is to convert mlv files to linear EXRs, ideally in ACES or ACEScg.

Historically I've done this via a hodgepodge of tools; RAWMagic (which seems to not get updated very often, and now seems to produce incorrect results), DCraw, and a handful of other utilities to get it into the EXR format.

Searching through the forums to see if a more modern approach exists, I came across MLV.app. It seems great; I tried downloading and installing the latest release to my Macbook M1, and it launches and seems to display footage fine, but I cannot get it to export any images in any format.

Is this a known issue? *should* I be able to do what I'm interested in doing with this app?

Thank you!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 25, 2023, 01:40:10 PM
Export to whatever you wish from MLVApp. EXR is not in format list. The app runs very well on M1 and there I can't remember an export issue - I exported a lot of footage on M1 systems. Maybe you need to allow disk access in macOS system preferences.
RAWMagic is banned here https://www.magiclantern.fm/forum/index.php?topic=13335.0
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: soundfan on February 27, 2023, 05:57:20 PM
Hi there,

attention: here may come the most silly question about MLV App ever!

I have searched the forum for about 5 hours now, read stickies, tutorials and beginner's guides, but didn't find the right workflow.

A few weeks ago I started with astro photography. Here you use several pictures of the same object(s) and stack them for noise reductions and more detailed pictures (probably a inaccurate description, sorry).

Anyway, for planetary pictures (also sun and moon) often video cameras are used to make hundreds of images to be stacked.

I managed to upgrade my 100D with ML (actually Bilals crop_rec_4k build) and create RAW videos. Now I want to separate the frames to single pictures in uncompressed and lossless format that can be processed by stacking software (usually tiff or png files). Now the only working thing I found in MLV App was exporting to CinemaDNG. This creates single frames indeed, but the DNG file format doesn't help me any further. I tried several times and settings for exporting into TIFF sequence, but it doesn't generate any files. Althought it takes about 6 minutes for a MLV file with 628 frames to export to TIFF sequence, no TIFF files are created.

I have no clue what I do wrong. Any help is greatly appreciated.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on February 27, 2023, 06:20:12 PM
Known bug in 1.14:

Quote from: masc on July 07, 2022, 03:39:21 PM
ffmpeg output tells for TIFF "%7" is the problem in the used command. This is the colortag change we did - it seems nobody tested that. But I don't understand why argument no7 isn't inserted into the command string.

Edit: please try latest commit. I just sorted the arguments and now it is working here.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: soundfan on February 27, 2023, 06:25:31 PM
Quote from: vastunghia on February 27, 2023, 06:20:12 PM
Known bug in 1.14:

Ahhhh! Honestly?

I just downloaded 1.13 and it works perfectly!

You are my hero!  8)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on February 27, 2023, 06:32:49 PM
Quote from: soundfan on February 27, 2023, 06:25:31 PM
Ahhhh! Honestly?

Yup. In fact somebody suggested:

Quote from: bouncyball on July 08, 2022, 01:19:31 PM
I guess we should release 1.14.1 :)

But then somebody else replied:

Quote from: ilia3101 on July 08, 2022, 04:42:52 PM
Wait. A few more days and we could make it 1.15, I wanna make processing more float.

And that was like 8 months ago ;D In the meanwhile, personally I learnt how to compile from source.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: soundfan on February 27, 2023, 07:03:49 PM
Quote from: vastunghia on February 27, 2023, 06:32:49 PM
And that was like 8 months ago ;D In the meanwhile, personally I learnt how to compile from source.

Now you cought my interest! Where do I find latest source code and how can I learn to compile? Is there some kind of dummy tutorial as well?  ;)
Title: MLV processed video
Post by: iaburn on February 27, 2023, 07:17:04 PM
A beautiful light this morning and the beauty of dual ISO. Processed with MLVApp of course  :D
Title: Re: MLV processed video
Post by: Mattia on February 27, 2023, 08:04:51 PM
Quote from: iaburn on February 27, 2023, 07:17:04 PM
A beautiful light this morning and the beauty of dual ISO. Processed with MLVApp of course  :D


Very beautiful!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on February 27, 2023, 08:47:32 PM
Quote from: soundfan on February 27, 2023, 07:03:49 PM
Where do I find latest source code and how can I learn to compile?

Start from post #1...
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 27, 2023, 10:16:49 PM
Quote from: vastunghia on February 27, 2023, 06:20:12 PM
Known bug in 1.14:

Quote from: masc on July 07, 2022, 03:39:21 PM
ffmpeg output tells for TIFF "%7" is the problem in the used command. This is the colortag change we did - it seems nobody tested that. But I don't understand why argument no7 isn't inserted into the command string.

Edit: please try latest commit. I just sorted the arguments and now it is working here.

Ups... haha... sry, that's too long ago.  :P

Quote from: soundfan on February 27, 2023, 07:03:49 PM
Now you cought my interest! Where do I find latest source code and how can I learn to compile? Is there some kind of dummy tutorial as well?  ;)

https://github.com/ilia3101/MLV-App

Start like shown here as first step. If performance is important further steps should be done...
https://www.youtube.com/watch?v=sUry4Oc4wq8
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 28, 2023, 03:07:38 AM
Quote from: soundfan on February 27, 2023, 05:57:20 PM
Hi there,

attention: here may come the most silly question about MLV App ever!

I have searched the forum for about 5 hours now, read stickies, tutorials and beginner's guides, but didn't find the right workflow.

A few weeks ago I started with astro photography. Here you use several pictures of the same object(s) and stack them for noise reductions and more detailed pictures (probably a inaccurate description, sorry).

Anyway, for planetary pictures (also sun and moon) often video cameras are used to make hundreds of images to be stacked.

I managed to upgrade my 100D with ML (actually Bilals crop_rec_4k build) and create RAW videos. Now I want to separate the frames to single pictures in uncompressed and lossless format that can be processed by stacking software (usually tiff or png files). Now the only working thing I found in MLV App was exporting to CinemaDNG. This creates single frames indeed, but the DNG file format doesn't help me any further. I tried several times and settings for exporting into TIFF sequence, but it doesn't generate any files. Althought it takes about 6 minutes for a MLV file with 628 frames to export to TIFF sequence, no TIFF files are created.

I have no clue what I do wrong. Any help is greatly appreciated.
There´s a really nice average stacker in Mlv App:
(https://i.postimg.cc/fTyhtpCc/Screenshot-2023-02-28-at-03-02-49.png)

Also an enfuse average script in the script section. Did not test that one lately though.
If compliing on mac M1 you could test this compiler.
https://bitbucket.org/Dannephoto/mlv_app_compiler-git/src/master/
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Mattia on March 09, 2023, 01:37:38 PM
Hi! I'm getting flickering highlights when exporting a dual iso mlv as an Apple ProRes video. I don't have this issue when exporting the video as a DNG sequence. Actually, it's not a "proper" flicker, it's more an alternate dual iso preview / dual iso correct output. I'll attach an image showing a problematic frame.

(https://i.imgur.com/GkIiVQV.jpg)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on March 09, 2023, 08:24:38 PM
Upload a Mlv file as well if possible.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on March 10, 2023, 02:43:08 AM
The pink stripes are because the High ISO lines are clipping.
MLV App maps extreme white values as pink, where a lot of DNG converters map those as pure white.

To get rid of the pink lines, try exposing the highlights with the High ISO value (The image will be underexposed).
Example, if you are using ISO 100/800, Use Single ISO 800 to expose the highlights without clipping, then switch to Dual ISO 100/800 to record.

You can then bring up the "Lighten" slider in MLV App to recover the shadows. This will reduce (or even eliminate in some cases) the flicker.

The remaining flicker is due to MLV App's processing.

Those interested can read a paper A1ex published: http://dhilung.com/vault/ml/dual_iso.pdf
Which could give ideas on how to improve the behavior.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on March 10, 2023, 10:03:42 AM
Quote from: gabriielangel on March 10, 2023, 02:43:08 AM
Example, if you are using ISO 100/800, Use Single ISO 800 to expose the highlights without clipping, then switch to Dual ISO 100/800 to record.
And what will be the point of using dual iso, if you expose so the highlights are not clipping with iso 800?

The shadows of the iso 800 will be cleaner than the shadows of 100 pushed +3 stops up.. you will probably get more noisy image by using dual iso in this scenario, because lines with 100 iso will be very underexposed
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Grognard on March 10, 2023, 01:13:34 PM
Quote from: Skinny on March 10, 2023, 10:03:42 AM
And what will be the point of using dual iso, if you expose so the highlights are not clipping with iso 800?

Iso 100 to expose the highlights I guess.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on March 10, 2023, 03:07:36 PM
right, if you ETTR for iso 100, then you will gain dynamic range. but if you ETTR for 800, then.. I don't see a point  (in using dual 100/800 and not just single iso 800)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on March 10, 2023, 03:16:55 PM
Quote from: Skinny on March 10, 2023, 10:03:42 AM
And what will be the point of using dual iso, if you expose so the highlights are not clipping with iso 800?

The shadows of the iso 800 will be cleaner than the shadows of 100 pushed +3 stops up.. you will probably get more noisy image by using dual iso in this scenario, because lines with 100 iso will be very underexposed

You're right.  This particular scene has both extremes.

But once you identify how far you can push it, you'll be able to compromise between the amount of aliasing you are willing to tolerate in the overexposed region and the amount of noise in the shadows.

As long as the portion you overexpose in the highlights is in the high white region, aliasing will be a lot less obvious. But the minute you begin overexposing a portion of the image where there are a lot of details, problems begin. (Until the Devs find a clever way to McGyver it  :) )

I posted a few examples here: https://www.magiclantern.fm/forum/index.php?topic=25781.msg242245#msg242245
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on March 10, 2023, 05:11:08 PM
Quote from: gabriielangel on March 10, 2023, 03:16:55 PM
But once you identify how far you can push it, you'll be able to compromise between the amount of aliasing you are willing to tolerate in the overexposed region and the amount of noise in the shadows.

Or, you export DNG, and you won't have to compromise.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: s1ntex on March 14, 2023, 05:40:44 PM
Hi guys. I have a couple of questions regarding the MLV App. Btw, phenomenal program, I salute the author.

Do you guys happen to know if there is an option to rotate the image when recording 1080x1920?

(https://i.imgur.com/wyawXAO.png)

Second question, more general, what is your way of editing an .mlv file if you use Premiere Pro, as I do?

Is there a better / equally good method, like: edit in MLV App -> export finished file in ProRes 4444 as .mov -> work on timeline in Premiere Pro?

E.g. exporting in some format to Premiere Pro and colouring directly there?

I read a lot of posts, however enough of them that it's hard to cover so much knowledge with my head. ;3

Best regards to you all.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on March 15, 2023, 07:36:01 PM
I don't think there is currently a way to rotate the image on MLV App, but if you are editing on Premier it's just a small inconvenience while preparing for export.

Most of the time I do my final editing on Davinci Resolve, exporting as DNG from MLV App. It is more convenient to do color correction and video cut on the same place, and also much faster to export.
MLV App is awesome on many aspects, but there are things like highlight recovery, noise reduction or local corrections that I miss from Resolve.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 16, 2023, 11:03:29 PM
Quote from: s1ntex on March 14, 2023, 05:40:44 PM
Do you guys happen to know if there is an option to rotate the image when recording 1080x1920?
Just 0° and 180° is available. Any other angle can be setup in your final NLE.

Quote from: s1ntex on March 14, 2023, 05:40:44 PM
Second question, more general, what is your way of editing an .mlv file if you use Premiere Pro, as I do?
Is there a better / equally good method, like: edit in MLV App -> export finished file in ProRes 4444 as .mov -> work on timeline in Premiere Pro?
E.g. exporting in some format to Premiere Pro and colouring directly there?
You can use Adobe ACR in After Effects. For me still the benchmark color wise.

Quote from: iaburn on March 15, 2023, 07:36:01 PM
Most of the time I do my final editing on Davinci Resolve, exporting as DNG from MLV App. It is more convenient to do color correction and video cut on the same place, and also much faster to export.
Not always true. ProRes export currently is faster than DNG in MLVApp. And Resolve also needs much time to render...

Quote from: iaburn on March 15, 2023, 07:36:01 PM
MLV App is awesome on many aspects, but there are things like highlight recovery, noise reduction or local corrections that I miss from Resolve.
Highlight recovery and noise reduction is available also in MLVApp - good enough for most cases.

Quote from: Mattia on March 09, 2023, 01:37:38 PM
Hi! I'm getting flickering highlights when exporting a dual iso mlv as an Apple ProRes video.
If you use official release: probably the known problem and the reason why we discussed to remove dualiso completely. Upload a MLV for analysis. Or try the latest versions from @iaburn - he did a great work getting a better version of dualiso processing into the app. This one should be flicker free.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on March 17, 2023, 06:44:37 AM
Quote from: masc
If you use official release: probably the known problem and the reason why we discussed to remove dualiso completely. Upload a MLV for analysis. Or try the latest versions from @iaburn - he did a great work getting a better version of dualiso processing into the app. This one should be flicker free.

I couldn't fix the flicker, but cedricp implemented a workaround that prevents flickering by applying the same correction values across all frames:
https://www.magiclantern.fm/forum/index.php?topic=25781.3675
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on March 17, 2023, 07:23:37 AM
So guys why don't you release 14.1 beta with these new dual iso corrections? It won't hurt anyone :) It's been a long time since the last release..
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 17, 2023, 09:46:23 PM
Quote from: Skinny on March 17, 2023, 07:23:37 AM
So guys why don't you release 14.1 beta with these new dual iso corrections? It won't hurt anyone :) It's been a long time since the last release..
The new version is not in the main branch. And I think some testing appart from iaburns work could be useful too. Releasing several times with all the deployment needed to make it work on as much computers as possible, probably with fixes, might not hurt, but is a lot of work which makes not too much fun.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: bouncyball on March 20, 2023, 04:44:29 PM
Hello guys! My old, good friends and newcomers.

I'm glad this great thread is still active and productive and newcomers providing great contributions!

I have missed you all :)

regards,
bb
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on March 20, 2023, 05:31:57 PM
Quote from: Skinny on March 17, 2023, 07:23:37 AM
So guys why don't you release 14.1 beta with these new dual iso corrections? It won't hurt anyone :) It's been a long time since the last release..
For Mac users I and also iaburn and probably a few others we could release a test build. For Windows users there must be someone out there...
Code is still worked upon so releasing official betas might.not be necessary.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on March 20, 2023, 06:23:56 PM
I've been also using the version compiled with the new Qt and dual ISO speed up on Windows and works fine.
I leave the decision of putting everything together and release a new version to Masc, as I think he is currently the main contributor to MLVApp.

It would also be cool to have a final version of cedricp's flickering fix, so we can put everything together when the time comes :)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on March 21, 2023, 03:41:58 PM
@iaburn, I tried the Windows version you posted and it really makes a difference on some clips.
So far, it works best when the whole scene is relatively well exposed without clipping and only the shadows needs lifting.
When there are a lot of highlights and mid exposures in a given area, we get the horizontal lines and resolution artifacts (Especially when not using a tripod).

I also saw that the "Transcode and import" option will not allow to import 10 second DNG sequences. On the official Mac version, it is possible to import around 260 frames before it gives an error.
This function is quite handy to match footage coming from motioncam, when the film emulation filter is used in MLV app.

Is this a Windows limitation?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on March 21, 2023, 04:13:04 PM
Quote from: gabriielangel on March 21, 2023, 03:41:58 PM
@iaburn, I tried the Windows version you posted and it really makes a difference on some clips.
So far, it works best when the whole scene is relatively well exposed without clipping and only the shadows needs lifting.
When there are a lot of highlights and mid exposures in a given area, we get the horizontal lines and resolution artifacts (Especially when not using a tripod).

Is this something specific on my fork or an issue in MLVApp in general? Could you please point out an example illustrating the issue?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on March 21, 2023, 04:46:10 PM
Your fork makes it less obvious, but this is an issue in general, as it also does it with the official build.
I will try to make a few examples in a controlled / repeatable manner over the weekend (I cleaned up my previous tests).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 21, 2023, 09:18:09 PM
Quote from: gabriielangel on March 21, 2023, 03:41:58 PM
I also saw that the "Transcode and import" option will not allow to import 10 second DNG sequences. On the official Mac version, it is possible to import around 260 frames before it gives an error.
This function is quite handy to match footage coming from motioncam, when the film emulation filter is used in MLV app.
Is this a Windows limitation?
Yes, Windows cmd line is limited. But only 260 frames on Mac? Currently I process GoPro RAW timelapse footage in MLV using DNG import and I also had 300+ frames... I've seen no error so far.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 21, 2023, 09:20:40 PM
Quote from: iaburn on March 20, 2023, 06:23:56 PM
I leave the decision of putting everything together and release a new version to Masc, as I think he is currently the main contributor to MLVApp.

It would also be cool to have a final version of cedricp's flickering fix, so we can put everything together when the time comes :)
I've seen there is a pull request ongoing. Nice to see all that contribution! For myself: I barely use dualiso, so I have to trust your input... also the reason why I was asking for more testing (also of other users) ;)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on March 22, 2023, 02:41:37 AM
Quote from: masc on March 21, 2023, 09:18:09 PM
Yes, Windows cmd line is limited. But only 260 frames on Mac? Currently I process GoPro RAW timelapse footage in MLV using DNG import and I also had 300+ frames... I've seen no error so far.

Sorry, the Official Mac 1.14 version can transcode and import 420+ frames (Don't know the exact upper limit)
Official 1.14 PC Version: 305 frames Max (Gives an error at 306)
Iaburn's openmp version: Cannot transcode and import
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 22, 2023, 03:49:42 PM
Quote from: gabriielangel on March 22, 2023, 02:41:37 AM
Official 1.14 PC Version: 305 frames Max (Gives an error at 306)
Iaburn's openmp version: Cannot transcode and import
If I remember right, Windows cmd is limited to 8196 characters. The number of frames possible to import, depends on the path name lengths.
You need raw2mlv executable in app image / path.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on March 22, 2023, 05:51:11 PM
Quote from: masc on March 21, 2023, 09:20:40 PM
I've seen there is a pull request ongoing. Nice to see all that contribution! For myself: I barely use dualiso, so I have to trust your input... also the reason why I was asking for more testing (also of other users) ;)

We have merged cedricp's changes with mines on my fork. I will try to compile the app for Windows and MacOS ARM, but I think I was having problems with focus pixel maps downloading not working...
Another thing that I forgot is that sounds doesn't work, at least when I build it with my Qt versions
After that, I'll post it here and maybe put a link to the post also on the Facebook group, trying to get more people to test and getting it ready for a pull request
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on March 23, 2023, 04:28:38 PM
Quote from: iaburn on March 21, 2023, 04:13:04 PM
Is this something specific on my fork or an issue in MLVApp in general? Could you please point out an example illustrating the issue?

Here are a few examples (2.5k and 5k frtp, with and without dual ISO 100/800): http://bit.ly/3K1Yfzx

In order to trigger artifacts in a clip easily, you must:

Move the camera vertically slowly;
Have areas where clipped and non-clipped detail-rich elements are next to one another (Like bare tree branches towards the sky);
Have horizontal elements moving through High and Low ISO scanlines;
Clip must be at least a few seconds long for you to see movement happening.

The exposure flickering is more visible in large, relatively flat areas (few details), where blending occurs.

If you use a tripod and avoid what is stated above, artifacts are sometimes imperceptible.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on March 23, 2023, 07:58:43 PM
Quote from: gabriielangel on March 23, 2023, 04:28:38 PM
Here are a few examples (2.5k and 5k frtp, with and without dual ISO 100/800): http://bit.ly/3K1Yfzx

In order to trigger artifacts in a clip easily, you must:

Move the camera vertically slowly;
Have areas where clipped and non-clipped detail-rich elements are next to one another (Like bare tree branches towards the sky);
Have horizontal elements moving through High and Low ISO scanlines;
Clip must be at least a few seconds long for you to see movement happening.

The exposure flickering is more visible in large, relatively flat areas (few details), where blending occurs.

If you use a tripod and avoid what is stated above, artifacts are sometimes imperceptible.

Thanks for the samples (nice images btw, lots of snow still!).

I see now what you mean, thin horizontal shapes with highlights are one of the worst cases for dual ISO. I tried to minimize the artifacts by adjusting settings but cannot get rid of them completely.
In one of the videos is very obvious on the tree branches and the railing next to the building. On this edge cases, I'm afraid there is not much you can do  :(
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: RhythmicEye on March 27, 2023, 11:09:54 AM
Quote from: iaburn on March 15, 2023, 07:36:01 PM
I don't think there is currently a way to rotate the image on MLV App, but if you are editing on Premier it's just a small inconvenience while preparing for export.

Most of the time I do my final editing on Davinci Resolve, exporting as DNG from MLV App. It is more convenient to do color correction and video cut on the same place, and also much faster to export.
MLV App is awesome on many aspects, but there are things like highlight recovery, noise reduction or local corrections that I miss from Resolve.

When importing footage / DNG images into Davinci Resolve what input color space settings are you using for images captured using ML? I know Zeek used to suggest using Arri Alexa but I'm wondering what the native color space is for ML. I would have assumed a Canon variety color space would have been optimal but I'm left wondering

Thanks RE.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on March 27, 2023, 12:03:30 PM
Quote from: RhythmicEye on March 27, 2023, 11:09:54 AM
When importing footage / DNG images into Davinci Resolve what input color space settings are you using for images captured using ML?

As long as you work with Raw DNG only, unless you are a professional colorist, my advice is to just trust DVR. Go for DaVinci YRGB Color Managed with Automatic color management. Then I suggest choosing HDR as Color processing mode, regardless of your Output color space (SDR should be the norm here). Also, in the Camera Raw settings, under CinemaDNG, I suggest you do *not* enable Apply Pre Tone Curve, leave Color Science = Camera Metadata, and pick Color Space = Blackmagic Design.

At least that's what I do after trying out more complex settings.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on March 27, 2023, 04:30:46 PM
I use cineon log in mlv app (color space use wide gamut like: adobe rgb, alexa wg, sony or davinci gamut) when edit using DR with default setting,  I think.. it gives better gamma and easier to grading when work in rec.709 environment.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on March 27, 2023, 04:36:02 PM
.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: RhythmicEye on March 28, 2023, 03:22:25 AM
Quote from: vastunghia on March 27, 2023, 12:03:30 PM
As long as you work with Raw DNG only, unless you are a professional colorist, my advice is to just trust DVR. Go for DaVinci YRGB Color Managed with Automatic color management. Then I suggest choosing HDR as Color processing mode, regardless of your Output color space (SDR should be the norm here). Also, in the Camera Raw settings, under CinemaDNG, I suggest you do *not* enable Apply Pre Tone Curve, leave Color Science = Camera Metadata, and pick Color Space = Blackmagic Design.

At least that's what I do after trying out more complex settings.

@vastunghia thank you for your excellent reply.

Yes all of the information you stated is correct but the most important information to make it all work correctly within DR is knowing your input color space first or the color space your camera records hard baked into your data. If you don't know this or get this right none of the other settings that you apply will be accurate because they relate to output color space / display color space. You must know the input color space first before you can get accurate results within DR for output to your monitor. Example: Canon C-Log (input CS) to REC 709 / Gamma 2.4 (output CS)

Even with color managed Davinci Wide Gamut Intermediate you still need to know your camera's or input (graphics etc) CS. If you don't know this info it's very difficult or even impossible to get accurate results when color grading. Especially if you are using footage from multiple, different camera manufacturers within the same project.

I'm assuming ML must use some form of Canon Log for the color space data.

Thanks again RE
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on March 28, 2023, 03:33:49 AM
Are you talking about raw images here?  Those don't really have a colour space.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: RhythmicEye on March 28, 2023, 05:06:33 AM
Ahhh yes RAW. My bad I meant some form of Canon RAW not log.

In DR there is an option for DNG Raw or Canon Raw. I'm assuming the Canon color science / algorithmic data from the sensor must remain in the DNG files.

Maybe not but that seems strange as all the sensors are Canon. I know this must seem pedantic but I think it's important to clarify.



Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on March 28, 2023, 05:41:44 AM
Raw files are straight from the sensor, no colour science has occured.  They don't have a colour space.  You can convert the raw data into any colour space you want.  I would guess DR has an option for Canon Raw because CR2 / CR3 is a different file format to DNG.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: RhythmicEye on March 28, 2023, 06:40:20 AM
All sensors use color science to record light hitting the sensor. It's the color science of the sensor we are talking about not the RAW DNG file. RAW files regardless of flavour still have color science which is determined by the sensor when recording light/color information.

Camera raw data is usually proprietary to each manufacturer. Which is why I'm asking about ML DNG files seeing as it's using a Canon sensor to capture the .MLV file.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on March 28, 2023, 07:22:58 AM
I'm not quite sure what you mean.  Different sensors will have different physical properties, including different sensitivities to different frequencies of light.  But they don't have a colour space.  I thought you meant colour space by "color science".

I was originally responding to you saying "I'm assuming ML must use some form of Canon Log for the color space data" - ML does not.  ML doesn't alter the colour space of JPG and raw doesn't have colour space.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on March 28, 2023, 07:36:06 AM
Quote from: names_are_hard on March 28, 2023, 03:33:49 AM
Are you talking about raw images here?  Those don't really have a colour space.

+1

That was the starting point of my answer above. There is no CST that needs to be handled by DVR as there is no image demosaic-ed already with some CS baked in. DVR needs to do the demosaic itself, so it can pick already the correct working CS.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: RhythmicEye on March 28, 2023, 08:30:16 AM
Quote from: vastunghia on March 28, 2023, 07:36:06 AM
+1

That was the starting point of my answer above. There is no CST that needs to be handled by DVR as there is no image demosaic-ed already with some CS baked in. DVR needs to do the demosaic itself, so it can pick already the correct working CS.

Just to be clear I'm not asking about color space nor CST in DR. I'm asking about how ML handles the sensor data from the Canon sensor when capturing the .MLV file.

ML is obviously not capturing a Canon RAW file but it's clearly using a Canon sensor that's capturing a CinemaDNG file. What is happening in that transformation? That is the nub of my question

There are 9 different varieties of Camera RAW in DR all based off the manufacturer's sensor data
1. ARRI Alexa 2. Blackmagic RAW 3. Canon RAW 4. CinemaDNG 5. Nikon RAW 6. Panasonic Varicam RAW 7. Phantom Cine 8. RED 9. Sony RAW

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on March 28, 2023, 08:48:06 AM
CinemaDNG isn't used at any point by ML, or by Canon, as far as I know.  Where are you seeing this?

ML takes the sensor data from camera memory and copies it unchanged into MLV files.  I would expect CR2 files to use the sensor data in the same way; by not changing it.  The file format of CR2 differs, the sensor data should be the same.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on March 28, 2023, 09:12:01 AM
+1, once again.

Raw data is just a collection of 14-bit values (think of them as numbers ranging from 0 to 2^14-1) each representing relative amount of light (think of this as a linear count of photons) collected by one of the photodiodes on the sensor.

These photodiodes are arranged in a RGGB (as proposed by Bayer first) square pattern, and each of them can collect light only in R, G or B channel.

Simplifying things a lot, if your sensor has N pixels, it means that it has 4*N photodiodes. Demosaic methods have the task of transforming this 4*N-long 1-dimensional array of data into an N-long 3-dimensional (R,G,B) array. Then, this resulting data is also tone mapped according to some sort of gamma(*), and color-coded according to some CS (still simplifying here). Finally, it can be saved as, say, JPEG (or, say, MPEG if we are talking video).

So if you are working with Raw data, demosaic has not yet been performed and you are presented with bare numbers representing amount of light collected on sensor (precisely "raw data", that is).

Only if you work with non-Raw data then you know that color information has already been elaborated and coded according to some predefined CS. Then you have to take this into account in NLE such as DVR in order to transform CS from input to working CS, all the way to output CS.

Don't be fooled by the fact that there are different formats of Raw files: these are just different formats of the container of the data. Raw data is raw data, it is always the same regardless of how it is stored, i.e. it has always the same meaning and once you crack open the container you are always presented with 14-bit series of photodiodes reads.

HTH

PS: may be worth playing with pure raw data to get acquaintance with it: found this (https://photo.stackexchange.com/questions/41373/whats-the-easiest-way-to-access-pure-raw-data-without-demosaicing), haven't tried, but seems to work. Personally I worked a bit on raw data in PixInSight, cfr for instance my report here (https://vastunghia.github.io/Wide-field-DSLR-astro-photography-post-processing-in-Pixinsight/index.html).

(*) Human perception is nonlinear (roughly logarithmic) and such that two perceived light *additive* gains are equivalent only if photon count is *multiplied* by the same amplifying coefficient — e.g. you need to pass from 2 to 4 photons in order to get the same gain that you obtained in passing from 1 to 2 photons.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: RhythmicEye on March 28, 2023, 10:31:53 AM
Quote from: names_are_hard on March 28, 2023, 08:48:06 AM
CinemaDNG isn't used at any point by ML, or by Canon, as far as I know.  Where are you seeing this?

ML takes the sensor data from camera memory and copies it unchanged into MLV files.  I would expect CR2 files to use the sensor data in the same way; by not changing it.  The file format of CR2 differs, the sensor data should be the same.

Again my bad, I meant DNG not CinemaDNG. An .MLV file is just a container for a sequence of DNG files. I use MLVFS to unpack them real time so I can grab still frames and short DNG image sequences easily. MLV App is a much better workflow though.

https://www.magiclantern.fm/forum/index.php?topic=13152.0

Anyhow you just answered my question which gives me the information I was looking for.

Thanks for your patience.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on March 28, 2023, 01:04:02 PM
I don't think MLV contains DNG files, these are different formats.  MLV is a container for raw sensor data, as is DNG.  I think MLFS converts MLV to DNG.  Could be wrong, haven't checked the code.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on March 28, 2023, 01:23:03 PM
If you want to know how to color correct mlv raw files to match other cameras, you may look at what photoshop does with it's camera profiles..
For example, if you convert mlv to dng and open it in photoshop, it will look almost the same (or the same) as usual cr2 file from the camera.

So it is obviously the same raw data. I don't know what adobe software does with color, but they have profiles for all cameras somewhere in folders, you can find there your canon camera profile. Maybe this profile can be converted to some LUT or something somehow...
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on March 28, 2023, 03:58:59 PM
Quote from: RhythmicEye on March 28, 2023, 10:31:53 AM
An .MLV file is just a container for a sequence of DNG files.
That's wrong. MLV and DNG are different formats, which hold the same RAW image data, but in a very different internal structure.
For color calibration MLVApp uses the camera matrices. No idea what DR does here.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: RhythmicEye on March 29, 2023, 12:13:38 PM
Quote from: masc on March 28, 2023, 03:58:59 PM
That's wrong. MLV and DNG are different formats, which hold the same RAW image data, but in a very different internal structure.
For color calibration MLVApp uses the camera matrices. No idea what DR does here.

Thanks for the explanation. MLVFS converts so quickly it seems to be more like a wrapper removal than a transcode.

Always happy to be wrong in the process of learning.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: RhythmicEye on March 29, 2023, 12:53:45 PM
Quote from: Skinny on March 28, 2023, 01:23:03 PM
If you want to know how to color correct mlv raw files to match other cameras, you may look at what photoshop does with it's camera profiles..
For example, if you convert mlv to dng and open it in photoshop, it will look almost the same (or the same) as usual cr2 file from the camera.

So it is obviously the same raw data. I don't know what adobe software does with color, but they have profiles for all cameras somewhere in folders, you can find there your canon camera profile. Maybe this profile can be converted to some LUT or something somehow...

Good suggestion but for Davinci Resolve I just needed to confirm the flavour is Canon RAW sensor data. That's what I assumed but was never 100% due the .MLV to DNG file conversion.

Now for some lighting and color chart testing to see just how accurate the color reproduction is for each of the various RAW flavours within DR.

Cheers RE
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on April 10, 2023, 11:03:33 AM
To get the same look in Resolve you can use rec709, no need to make it more complicated. It's just a curve that MLV app does, unless I am wrong. I played a bit with the raw panel contrast, gain, and a curve. Almost perfectly match.

(https://i.imgur.com/WlRoJom.png)
(https://i.imgur.com/Y0UZscH.png)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 12, 2023, 01:27:29 PM
I think you are wrong. All the detail comes out very different and shadows look just dead with this setting. It is way more than just a curve... If you look for the MLVApp look in another application, the closest should be ACR. Using Resolve for MLVApp look this is a really hard task.

(https://i.ibb.co/LpcdM6z/Bildschirmfoto-2020-04-29-um-13-10-48.png)
(https://i.ibb.co/8rCZJZN/Bildschirmfoto-2020-04-29-um-13-10-52.png)
(https://i.ibb.co/KND6sv5/Resolve.png)

Your setting without wheel and curve:
(https://i.ibb.co/CWSKYHy/Resolve2.png)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on April 12, 2023, 05:18:27 PM
You cannot think that one simple preset with some gain and contrast will be enough to match MLV App rendering with defaults settings in DVR for *any* scene.

That being said, of course, matching MLV App in DVR *is* possible, for any scene -- it just takes some time to tweak settings.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Skinny on April 13, 2023, 05:46:32 AM
Quote from: masc on April 12, 2023, 01:27:29 PM
(https://i.ibb.co/LpcdM6z/Bildschirmfoto-2020-04-29-um-13-10-48.png)
(https://i.ibb.co/8rCZJZN/Bildschirmfoto-2020-04-29-um-13-10-52.png)
By the way if you compare these two images you will notice that MLV App version has some kind of yellow tint over the image, at certain areas it is more visible.. While LR does not have this issue. It is always present in the mlv raw footage opened with MLV App. So I usually start tweaking white balance to add blue but that will break other colors and the whole balance.. I can fix it to some degree with LUTs but sometimes it is just so hard to do it, especially if you want warm image but without this unpleasant color..

So guys (and Ilia) if you will have some free time, could you look at MLV App color science and maybe tweak some things here and there? This is probably the number one issue I always have with MLV App, this yellow cast.. ::) :)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: elenhil on April 13, 2023, 08:34:01 AM
Guys, I've a question about highlight recovery and bit depth. I just reread https://www.magiclantern.fm/forum/index.php?topic=24933.0 and was mightily surprised by the findings, because in my 70D experience with MLVApp highlight recovery for 10-bit material is vastly inferior to 14-bit (to the point that I stopped shooting in anything other than 14-bit).

Is ACR's highlight recovery so much more advanced (or MLVApp's so much more... the other thing) that the latter can recover almost nothing from blown highlights in 10-bit (I just get pink areas), while the former can?

Отправлено с моего SM-G960F через Tapatalk

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 13, 2023, 11:06:00 AM
@elenhil: Blown out highlights means: absolutely no information on 2 (GG) of 4 (RGGB) pixels. And yes, ACR is very powerful here, creating information like magic. The algorithm is Adobe's secret. We can't just copy it (same for everything else from Adobe). On the other side, MLVApp is always able to fix the pink itself: adjust RAW white level as written in the manual/wiki. Bitdepth don't cares for that. If one likes the result is another question. Best bet is to not overexpose.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: elenhil on April 13, 2023, 11:13:17 AM
Thanks for the explanation, masc! I am a sucker for ETTR, so overexposed highlights is something of a job hazard.

I am curious about 11-bit vs 14-bit highlight recovery in MLVApp, though. Why is 14-bit material so much more accommodating in this regard (at least out of the box, without tweaking RAW white level first)?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 13, 2023, 03:24:10 PM
White level is hard coded, not measured. But real white level might vary. No idea how good the hard coded value is for all the possible settings and scenaries. If it is to high, highlight recovery (MLVApp) can't work. If it is to low, you lose dynamic range. For most cases, 2nd is not good.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Deadcode on April 14, 2023, 10:07:05 AM
Could you please improve multithreading support using some help from ChatGPT?

i just tried to do a benchmark with a 10 sec long dual ISO 1736x2214 clip from my 700D, and i have got interesing results

Converting to Lossless CDNG with Dual ISO turned ON, everything else is default:

M1 Macbook with the Arm64 version of MLVAPP: about 5 minutes render time
AMD Epyc based vitrual machine in tensorcore cloud computing service with 6 cores with Win64 Dynamic version of MLVAPP: about 16 minutes
AMD Epyc based vitrual machine in tensorcore cloud computing service with 44 cores with Win64 Dynamic version of MLVAPP: about 15 minutes

Converting to Lossless CDNG with Dual ISO turned OFF, everyting else is default:

Macbook M1: 30 sec
AMD Epyc 6 core: 40 sec
AMD Epyc 44 core: 40 sec
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: theBilalFakhouri on April 14, 2023, 10:42:47 AM
Quote from: Deadcode on April 14, 2023, 10:07:05 AM
Converting to Lossless CDNG with Dual ISO turned ON, everything else is default:

Currently Dual ISO code in official MLVApp reop doesn't support mutlithreading. There is a version made by @iaburn has multithreading support for Dual ISO, you find compiled Windows version here:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg241996#msg241996

Could you run the same test on AMD Epyc (at 6 and 44 cores) with this version and Dual ISO setting enabled?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on April 14, 2023, 10:51:01 AM
There is an improved version (fixed exposure consistency across frames) thanks to @cedricp, best is to download and compile directly: https://github.com/anibarro/MLV-App

I found issues with weird colors while exporting to cDNG, and also this version defaults to option 3 for focus pixels removal, which I realised is not always the best for non-dual ISO.
I was to lazy lately to take a look  :-[
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 14, 2023, 11:31:49 AM
Quote from: Deadcode on April 14, 2023, 10:07:05 AM
Could you please improve multithreading support using some help from ChatGPT?

...

Converting to Lossless CDNG with Dual ISO turned OFF, everyting else is default:

Macbook M1: 30 sec
AMD Epyc 6 core: 40 sec
AMD Epyc 44 core: 40 sec

If someone has a working multithreaded lj92 version for lossless encoding&decoding, please let me know. (As far as I know this is technically impossible, so runs always single threaded, for monochrome image data.)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Deadcode on April 14, 2023, 01:16:39 PM
Quote from: theBilalFakhouri on April 14, 2023, 10:42:47 AM
Currently Dual ISO code in official MLVApp reop doesn't support mutlithreading. There is a version made by @iaburn has multithreading support for Dual ISO, you find compiled Windows version here:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg241996#msg241996

Could you run the same test on AMD Epyc (at 6 and 44 cores) with this version and Dual ISO setting enabled?

I tried iaburn's 1.4 build with the same footage
4 threads: 5min31sec
32 threads: 5min04sec

masc: dumb question: it's not possible to force the threads to work on different image frames?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 14, 2023, 01:57:25 PM
Quote from: Deadcode on April 14, 2023, 01:16:39 PM
masc: dumb question: it's not possible to force the threads to work on different image frames?
With current concept: no. But you could use MLVFS for this.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on April 15, 2023, 01:30:55 AM
Quote from: masc on April 12, 2023, 01:27:29 PM
I think you are wrong. All the detail comes out very different and shadows look just dead with this setting. It is way more than just a curve... If you look for the MLVApp look in another application, the closest should be ACR. Using Resolve for MLVApp look this is a really hard task.


You are right. So what do you suggest to replicate MLVApp look in Resolve for every image? If the base settings are not enough a 3D LUT should cover it, no?
Maybe I forgot if there has been in the past a complete explanation of what MLVApp does to contrast and colours.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 15, 2023, 11:19:31 AM
Quote from: togg on April 15, 2023, 01:30:55 AM
You are right. So what do you suggest to replicate MLVApp look in Resolve for every image? If the base settings are not enough a 3D LUT should cover it, no?
Maybe I forgot if there has been in the past a complete explanation of what MLVApp does to contrast and colours.
Processing in MLVApp and importing this into Resolve? I don't understand the need of replicating, when you can use the original for free.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 15, 2023, 03:30:42 PM
MLVApp is not using GPU at all, i can render the same scene in resolve in minutes, and it takes hours in MLVApp.
Id love to replicate tonemapped look from MLVApp in resolve when i import DNGs, i have some presets but they arent that close
By the way, i successfully used bing chat to code and fix code recently, so what part of mlvapp code, what file do i need to feed into bing chat so it would take a look and try to add gpu rendering using ffmpeg in mlvapp ?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 15, 2023, 04:00:40 PM
Even with GPU processing, Resolve is slower for me, if it runs at all: 3h for 2min footage is normal here too. But I don't have a good GPU. Additionally 10x the time for making the footage look good plus all the artifacts it creates.  ;D :P
ffmpeg doesn't render anything. MLVApp does the rendering. You need to bring all the proessing.c, raw_processing.c, as well as all related files into openCL (for best compatibility). CUDA, Metal and friends is no solution IMO. Starting point is function "getMlvProcessedFrame16(..)"
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 15, 2023, 04:12:13 PM
Yeh im on 3090 and was on 1080, mlvapp is still very slow, resolve has nvidia cuda acceleration for 264 and 265, its a lot faster, minutes vs hours
so the pipeline is different from resolve and this suggestion wont work ?
(https://i.ibb.co/0KdCW6W/Clipboard07.jpg)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 15, 2023, 04:21:47 PM
ffmpeg on GPU would not bring much. And NVIDIA encoding doesn't work on any of my computers - probably the same for many if not most users. I also would not really recommend to render the clips to H264 or H265 if you want to edit. If you like HW encoding, try out the macOS version with AVFoundation - it brings more or less the same speed like preview without encoding (so I think Apple must do it in HW somehow). This can be faster than cDNG output. But encoding is the fastest part of creating the files. If you want to speed up MLVApp processing, you need to bring the entire RAW processing engine into GPU, not the encoding.

Quote from: masc on January 13, 2023, 06:34:38 PM
More tests on Apple Silicon M1, with the 3K testclip from @iaburn:
Export with my FastProxy receipt, ProRes422 AVFoundation: 8sec
Export to DNG lossless: 14sec
:P

https://github.com/ilia3101/MLV-App/blob/master/receipts/FastProxy.marxml
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: andy kh on April 15, 2023, 05:23:44 PM
Quote from: 2blackbar on April 15, 2023, 04:12:13 PM
Yeh im on 3090 and was on 1080, mlvapp is still very slow, resolve has nvidia cuda acceleration for 264 and 265, its a lot faster, minutes vs hours
(https://i.ibb.co/0KdCW6W/Clipboard07.jpg)

yeah its minutes vs hours. i am using a 10 year old laptop with nvidia cuda and its so fast rendering in resolve and premiere pro
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 15, 2023, 06:44:08 PM
For more modern laptops it seems it has changed.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 15, 2023, 07:47:21 PM
I found a small chance for easy GPU usage in MLVApp:
"openMP target" offloading.

As we already use openMP for CPU multiprocessing, this sounds good. But a first test program tells, my system has no device for offloading. Find the test program here:
https://enccs.github.io/openmp-gpu/target/

Output for MBA M1, same for Intel MBP:
"Number of available devices 0
Running on host"

openMP >=4 is needed. Latest LLVM versions (we use already) should support this.

Maybe someone finds how to use it.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: 2blackbar on April 15, 2023, 08:11:16 PM
Ill try to tinker with this when gpt will be able to accept long pieces of code, with the speed ai is learning it will become better programmer than i ever could be
I can do simple edits to the code but figuring out all the branching between files in sourcecode and what needs what to work, its a long journey
I dont want to ask someone to do it especially if its not going to be useful for that person , my another goal is to also add a code to raw2mlv which would support taking external audio file into mlv container
But all of that would be solved if i would have exact reinhard tonemapping formula available in resolve
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on April 16, 2023, 10:29:57 PM
Quote from: masc on April 15, 2023, 11:19:31 AM
Processing in MLVApp and importing this into Resolve? I don't understand the need of replicating, when you can use the original for free.

To have the option. It is a baked look after all, and it would be nicer to have a stronger grip on the first steps on the software where you plan to do your colour correction.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on April 17, 2023, 12:02:34 PM
Personally I love MLV App, but I typically use it just to preview clips and discard bad ones. Then I export cDNG to be imported in DVR.

Why? Simply because in my workflow first I cut / edit, and finally grade. I don't like grading before editing, as I still don't know exactly how / where I will be using each and every clip in the final sequence (some of them may end up unused as well, so grading them would result in a waste of time btw).

I'm fully aware that I'm losing many benefits of MLV App -- and more often than not I find myself struggling in DVR to get a decent look for my shots. But after some time I'm learning to do that, so that's a price I'm willing to pay.

Now, yesterday I filmed a few clips and decided that I wanted to try the other approach -- grade first in MLV App, and then edit in DVR. I thought that it was a very small video so it definitely made sense to try.

However, I'm encountering a problem: trying to export to ProRES 4444 using Apple AVFoundation, sometimes I get no output .mov file at the end of the process. I have to repeat rendering and export over and over again, until at some point (for no apparent reason) I finally get my rendered file.

In particular, I have 7 clips, of which
I reiterate that rendering is taking place (lot of time to fill the progress bar for each clip and CPU under heavy load).

Two questions:
Thanks a lot
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 17, 2023, 01:58:33 PM
@vastunghia: grading before edit makes no sense. Simple ProRes422 export is faster then cDNG export. Cut with this and grade the used clips later in MLVApp (use FCPXML import), then exchange the files. This makes sense not only for small videos. Especially for multiclip videos this is extremly powerful method: you can play and edit many clips in parallel in your NLE.
There were many fixes for AVFoundation export since last official version. Latest revision runs super fast and stable (my last >1TB without any issue). But this must be compiled first, there is no official release yet. Are you on Intel or Apple Silicon?

@togg: you could plan to do the color correction and grading in MLVApp - it is made for this.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on April 17, 2023, 02:49:12 PM
Quote from: masc on April 17, 2023, 01:58:33 PM
Simple ProRes422 export is faster than cDNG export. Cut with this and grade the used clips later in MLVApp (use FCPXML import), then exchange the files. This makes sense not only for small videos. Especially for multiclip videos this is extremly powerful method: you can play and edit many clips in parallel in your NLE.

Wait, wait, too fast for my poor brain power. Sounds cool anyway! So you are saying
Is that it? Not sure I understand if DVR can export FCPXML?

Quote from: masc on April 17, 2023, 01:58:33 PM
There were many fixes for AVFoundation export since last official version. Latest revision runs super fast and stable (my last >1TB without any issue). But this must be compiled first, there is no official release yet. Are you on Intel or Apple Silicon?

Intel. I'm using this self-compiled version here, with code as of Jan 21:

Quote from: vastunghia on January 21, 2023, 11:37:50 PM
Just sharing MLV App installer (DMG) 'nightly build' (ref. commit 3330563) for OSX x86, built with Qt6 and llvm15:

https://www.icloud.com/iclouddrive/061ffs2OUqHzzwsMapMtkx6gQ#MLVApp.3330563.llvm15.OSX (https://www.icloud.com/iclouddrive/061ffs2OUqHzzwsMapMtkx6gQ#MLVApp.3330563.llvm15.OSX)

Sergio

I see now that some newer commits had some fixes for AVFoundation. Will try to build an updated version when I find the time, thanks!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 17, 2023, 03:57:36 PM
My workflow for almost all videos I do:
1. Import all MLVs in MLVApp, set CutIn/CutOut to not render parts you'll never need, render as ProRes422 with AVFoundation. Use FastProxy.marxml for fastest export, or FastProxyRCD.marxml for better but fast debayer.
2. Import all .mov into your NLE
3. Cut/Edit in NLE
4. Export FCPXML from NLE
5. Import FCPXML in MLVApp
6. Color correction/grading in MLVApp, export as ProRes4444 with AVFoundation
7. Relink the graded clips in NLE
8. Export final from NLE

I use FCPX for this. But when I implemented the FCPXML feature into MLVApp, it worked also with Davinci. Since then I did not really use it anymore for such projects. To be tested with current versions...
Edit: works exactly this way also in Davinci Resolve, with nice performance.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on April 17, 2023, 09:36:06 PM
Very interesting, thank you masc. I'll need to take some time to try your workflow.

In the meanwhile, I'm trying to get compile environment up and running again (had to wipe all disk few weeks ago) to check if latest commits solved the problem I encountered today trying to export to ProRes 4444. Will report back asap.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: koopg on April 17, 2023, 10:46:00 PM
hello,

is this doable from mlvapp ?

thanks(https://uploads.tapatalk-cdn.com/20230417/cdd61ea4652f4ff700a3d3b14a852265.jpg)

Sent from my SM-N975F using Tapatalk
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 18, 2023, 07:44:38 AM
@koopg: "this" = what?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on April 19, 2023, 11:58:00 AM
Quote from: vastunghia on April 17, 2023, 09:36:06 PM
In the meanwhile, I'm trying to get compile environment up and running again (had to wipe all disk few weeks ago) to check if latest commits solved the problem I encountered today trying to export to ProRes 4444. Will report back asap.

Ok, compiled commit 09fd45f, I confirm now ProRes export via AVFoundation works like a charm, thank you masc!

Btw I used llvm16 just as this is the package that was brewed by default, and everything worked fine. Please find here (https://www.icloud.com/iclouddrive/064SQiu37z70UmYYx7ok3RzrA#MLVApp.09fd45f.llvm16.OSX) the MacOS installer, in case anybody is looking for a recent x86 build...

I'm getting ready to try your suggested workflow, and I started doing some tests on export times.

First of all, it took 50 minutes to render my 7 (graded) 30-second clips (~95 MB/s MLV files with Danne's anamorphic preset on 5D3) recorded @24/1.001 fps -- so rendering speed @1.71 fps overall for ProRes 4444 with AVFoundation.

Tried also ProRes 422 export with AVFoundation on the same (this time ungraded) clips and obtained these results:
(For the record, I also tried 422 Proxy with ffmpeg Kostya + FastProxy receipt and obtained 2.42 fps)

Of course, DNG export is way faster -- 15.1 fps.

So, my first take-away is that the workflow you are suggesting is much more time demanding than I thought -- we need to sum the proxy ProRes 422 export and then the master ProRes 4444 export: that's 1 / ( 1 / 3.69 + 1 / 1.71 ) = 1.17 fps (1.11 with RCD) to be compared with 15.1 fps for DNG. That means 13 times longer export overall :o Approximately, if we are talking about 1h of footage, this translates into ~21 hours of total processing time for exporting ProRes proxies + masters, versus the 1.5 hours necessary to export DNG. Of course on my x86 Mac...

(And I guess figures would be even worse if I considered 3.5K 1x1 footage, which is my favorite setting in most occasions.)

I'm still willing to try your workflow though, as I'm aware that grading in MLV App is so much more straightforward than in DVR. Will keep studying.

Thanks
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 19, 2023, 01:23:10 PM
Cool! A Qt6.5+llvm16 version. Nice. Audio works. FocusPixelMap download doesn't (was never working with 6.x for other computers than your own - whyever)

What Mac are you using? Your export is extremely slow! Is this dualiso or something?

Tested your version on my MBP2018 on Intel with a 1856x1044 clip:
- 20fps preview
- 17.3fps export speed into ProRes422 with FastProxy receipt
- 14.1fps for cDNG
(And this MBP2018 is known to be very slow for processing, because of heavy heat throttling.)

The final grade export needs its time in MLVApp, yes. But here Resolve is very slow too on all my machines (if it works at all). And your calculation is wrong, if you compare cDNG against final grade.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on April 19, 2023, 03:20:24 PM
Quote from: masc on April 19, 2023, 01:23:10 PM
What Mac are you using? Your export is extremely slow! Is this dualiso or something?

2019 iMac with 3.0 GHz Core i5 running macOS 13.3.1. Clips were plain vanilla anamorphic 1x3 1808x2268, 24/1.001 fps @14bit (~95 MB/s of MLV lossless compressed data). No Dual ISO. I get 3 fps real-time preview in MLV App with no / simple / bilinear demosaic, 2 with AMaZE ::)

Quote from: masc on April 19, 2023, 01:23:10 PM
Tested your version on my MBP2018 on Intel with a 1856x1044 clip[...]

My video is 2.1 times yours in terms of total pixels, I guess this may explain the different performance. Also, let's keep in mind that I'm exporting a stretched 5424x2268 video after all: so, from the point of view of AVFoundation, that's 6.3 times your video (once again in total pixel terms). Mind sharing your test clip? Would love to share mine, but it depicts my sons and I'm pretty strict on privacy matters :D Anyway, not so important of course.

Quote from: masc on April 19, 2023, 01:23:10 PM
The final grade export needs its time in MLVApp, yes. But here Resolve is very slow too on all my machines (if it works at all). And your calculation is wrong, if you compare cDNG against final grade.

Not sure I understand completely your point, sorry. Let me try and bring some order here, to check if I'm missing something at some point. So, schematically, here are the two workflows I'm trying to compare:
I underlined all rows that make a difference between the two workflows, at least in terms of time required for overall rendering.

If the reasoning is correct, I think that my calculations are correct too. The comparison must be taken between 15.1 fps on one hand, and 1 / ( 1 / 3.69 + 1 / 1.71 ) = 1.17 fps on the other. What am I missing?

Thanks
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 19, 2023, 03:33:24 PM
In 1. you still have RAW in the end, in 2. you have a nearly ready project.
--> You missed two very important underlined lines:
1.4 -> "5h" (Davinci does RAW processing and grading)
2.5 -> "5min" (Davinci just copies data)

The clip I used for M1 numbers was a 3K clip. Maybe try some non 1x3 clip, because 1x3 needs to be stretched. This needs additional time. But this time is worth it, because MLVApp uses AVIR which is by far superior to bicubic used by Resolve.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on April 19, 2023, 03:58:27 PM
Aha, very clear thanks, noted.

I voluntarily ignored points 1.4 and 2.5 as I thought they would turn out to be similar. However I see what you mean, and I'll try to clock these two steps as well.

Quote from: masc on April 19, 2023, 03:33:24 PM
Maybe try some non 1x3 clip, because 1x3 needs to be stretched. This needs additional time. But this time is worth it, because MLVApp uses AVIR which is by far superior to bicubic used by Resolve.

Since I want to compare the workflows for the cases I'm more likely to encounter, I'm trying to stick to the formats I personally use most, which are 1x3 5.4K and 1x1 3.5K. Nice to know of AVIR, another point in favor of workflow 2!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 19, 2023, 04:13:40 PM
Your points 1.4 and 2.4 might also vary a lot on what you setup in those applications. I bet this will be very hard to compare, if possible at all. Even for my own projects the export speed is different for each clip, because I use other features (but the same MLV setting on camera).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on April 19, 2023, 04:18:40 PM
Agreed. Like, NR in DVR without an eGPU totally destroys fps in any, so any difference would be evened out. I'm going to compare the two points in a very simple, plain-vanilla setting.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 19, 2023, 04:23:39 PM
In MLVApp using Clarity, Highlights and Shadows also will destroy any good fps - special algorithms behind ;)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on April 19, 2023, 04:43:08 PM
Aha, I see. Shadows and HL are a must, at least for me. Good to know that they had an impact on the fps when doing render of the graded clips, thanks.

EDIT: In fact, I realized that I get 3 fps of realtime playback with the graded version, but up to 9 fps with the ungraded one. I see that Shadows and HL are doing most of the harm here. But also (a bit unexpectedly at least for me) filters seem to have some minor impact.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 19, 2023, 05:19:32 PM
Quote from: vastunghia on April 19, 2023, 04:43:08 PM
Aha, I see. Shadows and HL are a must, at least for me.
Not really. Try to pull down exposure and then raise "lighten". Looks mostly better, is always faster.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on April 19, 2023, 05:46:10 PM
Quote from: masc on April 19, 2023, 05:19:32 PM
Not really. Try to pull down exposure and then raise "lighten". Looks mostly better, is always faster.

Nice one!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on April 19, 2023, 09:08:48 PM
One more question, not related to prior discussion: What's the difference between filters and LUTs? Had a look at film.h and they look like LUTs?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 20, 2023, 08:30:10 AM
Film is a look-simulation trained using neural networks. LUT uses 1D or 3D LUT files to change the look.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on April 20, 2023, 09:04:53 AM
Interesting, once again, thanks.

But what does this mean in terms of the transformation being applied to the RGB space? LUTs are easy to understand. But what do filters do? For instance, do they apply a continuous function instead of interpolating between discrete points defined in some RGB lattice? Do you have any documentation on this?

Sorry for bothering you, I like to understand things ;)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 20, 2023, 01:09:33 PM
I just can give you the code - everything else is magic for me ;)

https://github.com/ilia3101/MLV-App/blob/master/src/processing/filter/genann/genann.c
Title: MLV App 1.14 can't export
Post by: IBIRRU on April 20, 2023, 02:03:46 PM
I'm sorry but after digging 2 days into the forum I need to ask about a problem with MLV App v 1.14.

I use win 10 pro and win 11 pro

If I use v 1.13 all works without problem

using v1.14 (static or dynamic) when I export It run and finish without errors but the directory is always empty. Regardless of wich kind of conversion I define and select (TIFF, PNG etc)

I tried 3 different pc but always the same behaviour (v 1.13 works and v 1.14 don't). It puzzled me and It seems impossible because v.114 is 1 year old not and then well stable.

Anyone could help me to solve this issue?

Thank in advance and many many thanks to all people that contribute to develop such fantastic App.

And sorry for my bad english. :(


Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 20, 2023, 03:04:04 PM
@IBIRRU: hm... for PNG and TIFF there was a bug, which was fixed 7th july. But since then there was no new official release. When scrolling through the thread, I found this test build. Maybe try this for now:
https://www.magiclantern.fm/forum/index.php?topic=20025.msg242369#msg242369
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: IBIRRU on April 20, 2023, 04:03:10 PM
@masc
thanks a lot, it works ok
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ilia3101 on April 20, 2023, 04:22:22 PM
Quote from: vastunghia on April 20, 2023, 09:04:53 AM
But what does this mean in terms of the transformation being applied to the RGB space? LUTs are easy to understand. But what do filters do? For instance, do they apply a continuous function instead of interpolating between discrete points defined in some RGB lattice? Do you have any documentation on this?

Exactly this. They are a continous function (a tiny network trained on film convert before/afters), unlike LUTs... not that it makes any visual difference.

It's basically a LUT with extra steps. It was a silly experiment. But they are nice anyway.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on April 20, 2023, 06:50:44 PM
Thanks ilia, they are indeed! And I love the idea anyway.

Would love to know a little more about the training set used. And the specific neural network properties — though I guess these can be inferred directly from code inspection.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: togg on April 21, 2023, 11:14:20 PM
Quote from: masc on April 17, 2023, 01:58:33 PM
@togg: you could plan to do the color correction and grading in MLVApp - it is made for this.

I guess you are right. Like a primary grade on MLV App. It's just not a standard approach. But I do appreciate how well MLVapp works. I moved to another camera now but I still film from time to time with the 5D and it makes sense to export prores directly from here.

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on April 22, 2023, 05:32:52 AM
using crop mood on 650d, i can record single files with a size like 100 gbs. On 5d3 and old 5/25/2022ml 650d, big files are separated into 4gb series.
now importing 100 gb files into mlv app, they can be graded, but can not exported. small files have no problem.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 22, 2023, 03:29:52 PM
Quote from: mlrocks on April 22, 2023, 05:32:52 AM
now importing 100 gb files into mlv app, they can be graded, but can not exported.
How that? No problem here. Is there a message? File size is a don't care for MLVApp.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on April 22, 2023, 10:10:17 PM
Quote from: masc on April 22, 2023, 03:29:52 PM
How that? No problem here. Is there a message? File size is a don't care for MLVApp.

Thanks for your reply, MASC.
I just found out that I used dnxhr and dnxhd, they are not working. Also maybe due to that the hard drive is almost full.
When I use ProRes422 in export setting, seems working, either with short or long clips.
Prbobaly ffmpeg has issues with avid's codecs? 
Anyway, I am going to stick to prores 422 or prores 422hq or prores4444. Good enough for me. Speed wise, seems they are good enough comparing to avid's codecs.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on April 23, 2023, 07:05:47 PM
Unscientific observation: after upgrading Windows 8.1 to Windows 10, MLV App encoding speed (prores4444) seems to be 2-5 times slower than before. No rigorous test was done, just feeling so.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 23, 2023, 07:17:19 PM
If speed is important, do not use Windows. Using Unix you get much higher export speed on same hardware. Our algorithms are the same for all supported OS.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: koopg on April 23, 2023, 09:38:09 PM
Quote from: masc on April 18, 2023, 07:44:38 AM
@koopg: "this" = what?
adding tgis camera model like exiftool for addional functiinallity in davinci reaolve as suggested in the attached post

Sent from my SM-N975F using Tapatalk

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 23, 2023, 09:50:41 PM
Quote from: koopg on April 23, 2023, 09:38:09 PM
adding tgis camera model like exiftool for addional functiinallity in davinci reaolve as suggested in the attached post
No attached post available. No idea what you're talking about...
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on April 23, 2023, 10:33:04 PM
Quote from: masc on April 23, 2023, 07:17:19 PM
If speed is important, do not use Windows. Using Unix you get much higher export speed on same hardware. Our algorithms are the same for all supported OS.

Thanks a lot, Masc. Eventually I will build a linux video station to fasten the encoding.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on April 28, 2023, 09:44:29 AM
Hello. I was shooting a lot of stuff where I didn't have to change the firmware parameters, but I happened to have 14 bits on the second memory card(unlike the first, where 12 bits).
Is it possible to perform a grading video in mlvapp so that the difference between 12 and 14 bits is not visible? How to do this then? Or when exporting to Apple ProRes 4444 there will be no difference?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on April 28, 2023, 10:20:32 AM
@Icaab: what difference do you see? Processing engine is always the same, no matter which bitdepth was used. So the result should look the same. The lower the bitdepth, the more noise in dark tones. You like to decrease quality of the high bitdepth clips?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Icaab on April 28, 2023, 11:32:19 AM
Quote from: masc on April 28, 2023, 10:20:32 AM
@Icaab: what difference do you see? Processing engine is always the same, no matter which bitdepth was used. So the result should look the same. The lower the bitdepth, the more noise in dark tones. You like to decrease quality of the high bitdepth clips?
Okay, thanks for answering
I thought that such a small difference between bitness can differentiate the transmission of colors when the saturation of the video increases and the like
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on May 02, 2023, 10:27:12 PM
So I'm trying to experiment grading some clips in MLV App, and one thing I miss a lot is the ability to switch back and forth quickly between current and default receipt, possibly using some simple keyboard shortcut -- something like the "Cmd + D" or "Opt + D" shortcuts in DVR basically: my fingers keep reaching for the "D" key... but nothing happens. Very frustrating :P

Would it be possible to add this feature in the future?

Ps: an even more useful feature would be an Undo of course, just to review the impact of latest adjustments... but I guess this would be more complex to add.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on May 03, 2023, 01:32:24 PM
Do the following:
Ctrl+C (Copy), and then: Ctrl+Alt+R (Reset to default), Ctrl+V (Paste) as often you like.

Undo/Redo would mean a new start from scratch for the GUI.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on May 03, 2023, 07:14:55 PM
Quote from: masc on May 03, 2023, 01:32:24 PM
Do the following:
Ctrl+C (Copy), and then: Ctrl+Alt+R (Reset to default), Ctrl+V (Paste) as often you like.

Yup, thanks, I figured that but I'm lazy :D compare this sequence
with this:
Sooo much easier to do without even taking your eyes off the screen.

But I understand that this is not so vital ;) Would love to find the time and try playing with the code, all features are there basically, would need just to bind keyboard shortcut to a simple chain of already-implemented methods I guess.

Quote from: masc on May 03, 2023, 01:32:24 PM
Undo/Redo would mean a new start from scratch for the GUI.

Yes, clear, this was my guess.

Thanks!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Jonneh on May 21, 2023, 12:46:07 PM
I have a slight annoyance to report (essentially the only one in the otherwise very smooth MLV App experience), which is that error messages often pop up in an infinite loop, forcing me to Ctrl+Alt+Delete and kill the program and then wait for the hundreds of clips I typically have in the project to load again on restart.

This infinite loop most often happens when opening empty 2KB files sometimes generated by ML on my cameras (5D3 and 100D): I get an error message saying that the video file contains no frames, or something similar, and upon clicking OK, the message pops up again, I click OK, it pops up again, and so on ad infinitum. This is the most common initial cause for the error message in my case, but I've had the problem with different errors. I'm using v1.14.

Is there a workaround for this, beyond simply not importing the empty files in the first place (as I say, I've had the problem with other error causes too)?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Haco on June 10, 2023, 10:26:00 PM
Hi everyone I have a problem, recently bought a Canon EOS M and installed magic lantern, shot some raw .mlv files.

Downloaded MLV App 1.14 static x64 build but, when I start MLVAPP.exe nothing happens, netiher GUI opens, nor any error shown. Nothing. Am I missing anything?

I am using Win10 x64 running on AMD phenomII X4 955 CPU and Asus GTX 1050Ti GPU.

Any help will be appreciated, thank you..
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 14, 2023, 08:34:46 AM
@Haco: check your antivirus and system/path privileges.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: PaulHarwood856 on June 21, 2023, 06:36:58 PM
Hello ML,

    I'm fixing bad pixels using pixel maps on MLV App for 5.7K Canon 5D Mark III footage. However, I cannot figure out how to zoom really far to see individual pixels. I can only zoom 100%. I'm using Windows 10 on a PC. Any help on this would be greatly appreciated. Thank you.

- Paul

Revision: I figured it out. I zoomed to 100% and then used the scroll on my mouse. Sorry for the hassle.

- Paul
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Headless_Monkey on June 26, 2023, 03:24:09 PM
Quote from: vastunghia on May 03, 2023, 07:14:55 PM
Yup, thanks, I figured that but I'm lazy :D compare this sequence

  • Ctrl+C
  • close copy option dialog
  • Ctrl+Alt+R
  • Ctrl+V
with this:

  • Ctrl+D
  • Ctrl+D
Sooo much easier to do without even taking your eyes off the screen.

But I understand that this is not so vital ;) Would love to find the time and try playing with the code, all features are there basically, would need just to bind keyboard shortcut to a simple chain of already-implemented methods I guess.

Yes, clear, this was my guess.

Thanks!

Let me recommend the cheap hardware toy I could not live without - Contour Shuttle (or these days I upgraded to the ShuttlePRO v2). From the sound of things it might really suit your editing style. Starting at fifty bucks it is a fraction of the price of a consol.

Or for a software only tool, AutoHotkey. A weekend of hacking with macros and you can even have a second keyboard that does nothing but your dirty work when editing.

Cheers!

Ps. The Black Magic shuttle does make me drool, but exceeds my hobby's price rules. I would buy more cheap a** glass if I had luxury money.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on June 29, 2023, 02:52:45 PM
Quote from: masc on June 14, 2023, 08:34:46 AM
@Haco: check your antivirus and system/path privileges.

Hi masc how are you? :D
btw, I got this error when transcode dng file using folder transcode I don't know why.

(https://i.ibb.co/XX3HY0b/Screenshot-2023-06-29-194853.png)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 29, 2023, 04:32:07 PM
Does it work if you remove the spaces from the filename?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 29, 2023, 04:40:22 PM
You get this, when MLVApp can't read the file. The reason might be a corrupt file, or folder/file names which parts of the backend can't access.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on June 29, 2023, 05:09:08 PM
Quote from: names_are_hard on June 29, 2023, 04:32:07 PM
Does it work if you remove the spaces from the filename?
if I just using transcode file is working without removing the space from the file name.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on June 29, 2023, 05:10:46 PM
Quote from: masc on June 29, 2023, 04:40:22 PM
You get this, when MLVApp can't read the file. The reason might be a corrupt file, or folder/file names which parts of the backend can't access.
so how to fix it?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 29, 2023, 06:07:32 PM
Try to choose an easy small name. If your file is corrupted, there is no fix (with MLVApp).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on June 29, 2023, 07:01:48 PM
Quote from: masc on June 29, 2023, 06:07:32 PM
Try to choose an easy small name. If your file is corrupted, there is no fix (with MLVApp).
but why when I choose single file transcode is fine? and failed when I chose transcode folder?
if I use davinci there is no corrupted file..
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 29, 2023, 07:51:58 PM
If you won't run the tests we ask, we can't help you.  We're trying to work out why it isn't working, so that it can be fixed.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on June 29, 2023, 08:04:21 PM
Quote from: names_are_hard on June 29, 2023, 07:51:58 PM
If you won't run the tests we ask, we can't help you.  We're trying to work out why it isn't working, so that it can be fixed.
sorry I forgot to mention.. I just tested your instruction and masc but still the same..
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 29, 2023, 10:47:21 PM
Great - please show the new error with the changed name.

Can you confirm the file exists at the same location and is readable?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on June 30, 2023, 04:02:29 AM
Quote from: names_are_hard on June 29, 2023, 10:47:21 PM
Great - please show the new error with the changed name.

sure..

without space
(https://i.ibb.co/tpXnDHp/Screenshot-2023-06-30-084927.png)

with simple name
(https://i.ibb.co/dMyn2GW/Screenshot-2023-06-30-085053.png)

Quote from: names_are_hard on June 29, 2023, 10:47:21 PM
Can you confirm the file exists at the same location and is readable?
do you mean the dng file? yes.. I trandscode to the same location as the dng files
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: names_are_hard on June 30, 2023, 04:29:59 PM
Thanks, maybe masc can repro the problem now.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on June 30, 2023, 07:48:45 PM
Quote from: names_are_hard on June 30, 2023, 04:29:59 PM
Thanks, maybe masc can repro the problem now.
Sorry... nope. I just can say the file is very probably corrupted or unreadable, otherwise you wouldn't get this message.

Edit: wait. What exactly do you try to do? Not just opening a MLV. Do you try to transcode DNG to MLV? This is done by raw2mlv application. MLVApp just wraps a GUI around this cmd application. Looks like you are on Windows: this is the worst OS for this, because command line is veeeery limited on windows. The longer file/path names of your DNG files, the earlier the Windows CMD limit is reached. And this limit comes very soon - was it just 8191 characters for the entire command (262144 on macOS)? You can try this also with your CMD manually.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: wwoolf on July 12, 2023, 07:14:21 PM
Hi everyone. I have a workflow question - how can I make sure my bit depth is correct? I record MLV raw video on EOS M at 10 bit color depth. I have a workflow I've settled with, using the Alexa LogC profile to a ProRes 422 export. How can I be sure that the export from MLVApp preserves the 10bpc color information?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: DarkTrapStudio on July 13, 2023, 02:20:54 PM
You have to look at the codecs capability you want to use
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 13, 2023, 08:44:15 PM
@wwoolf: don't compare bitdepth of RAW with bitdepth of processed footage - that makes not much sense, because your tone values are completely changed from linear to log scale (plus much more math was done).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: whysodifficult on July 15, 2023, 04:29:57 AM
Hello, when i open in Lightroom cDNGs made by MLV App, they look really weird. I know there's an issue with AWB from different post here, and i did use AWB. But if that was just Kelvin, i could fix it it with just one knob in Lightroom. But i can't.

I understand MLV App and Lightroom can interpret RAW slightly differently. But it's way too different.

And how it's done by MLV App is very close to the reality, when cDNGs from MLV App opened in Lightroom look nothing like reality and it's not because the temperature is off.

I can make it look close to how it looks in MLV App, but in that case all my filters that i apply to photos look bad and nothing like they should look like. Which makes me think there's something wrong either with MLVApp or with magic lantern or with Lightroom. Or is it something else i'm missing?

In my understanding, i should be able to edit cDNGs like normal photos in Lightroom, and my filters should look the same as on photos. But they don't.

Anyone knows the issue? Maybe it was discussed somewhere? Thank you.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: elenhil on July 15, 2023, 06:46:54 AM
This is just guesswork on my part, but LR needs to have proper EXIF metadata to interpret the RAW file. Take, for example, camera model. If the tag is missing, erroneous, or somehow clashes with LR's built-in camera profiles (which can happen if an image is not, in fact, a straight out-of-the-camera photo, but rather something converted or generated by a 3rd party app), LR can 'display' the file in a different way. I have this issue with DNGs generated from DualISO files by cr2hdr (I need to manually change the camera model tag from my 70D to, for example, 60D to make the resulting DNGs have correct 'brightness' in LR). Perhaps there is a similar LR camera profiles bug with your model. Do try changing the camera model EXIF tag to some other, similar camera.

Отправлено с моего SM-G960F через Tapatalk

Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on July 15, 2023, 07:34:51 AM
Why speculate. Provide a cdng sample file to inspect.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 26, 2023, 08:05:11 PM
I tried updating our MLVApp AVFoundation export for Apple SDK, for macOS newer than 10.13. @Danne and other mac users, who are able to compile: could you please test that? If someone could test if the old options still work on older macOS, I also would be interested in test results. Thx!

The update brings ProRes Proxy, LT and HQ via Apple engine.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on July 26, 2023, 09:05:36 PM
My compiler for Mlv App is totally broken atm  :-[. Been messing too much with other compiling environments and all is a mess right now. Too bad.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on July 27, 2023, 12:44:03 AM
Quote from: masc on July 26, 2023, 08:05:11 PM
I tried updating our MLVApp AVFoundation export for Apple SDK, for macOS newer than 10.13. @Danne and other mac users, who are able to compile: could you please test that? If someone could test if the old options still work on older macOS, I also would be interested in test results. Thx!

The update brings ProRes Proxy, LT and HQ via Apple engine.

If someone can provide a compiled Macos 10.13+ version, I can test (when I compile myself, I get errors and the resulting version is too slow (No MP support).
AVFoundation is the option to choose to get an output file with the proper gamma and accurate color translation. So your update should be very interesting!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 27, 2023, 08:52:33 AM
Hm... my first question would have been: does it compile at all on other machines... can test on my M1 only atm.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on July 27, 2023, 01:01:02 PM
@masc, I should be able to compile on my 2019 Intel iMac running Ventura. Would this help? If so, will try that as soon as I can.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on July 30, 2023, 07:22:30 PM
All tests are welcome. So far I had luck with new AVFoundation on Apple Silicon and Intel Mac (both on BigSur). Old version seems to compile at least, but here I did no other test.
Title: Can MLV App apply lossless DNG compression?
Post by: Milk and Coffee on August 16, 2023, 08:40:50 PM
Can MLV App apply lossless compression to already exported cDNGs/Can I reopen a DNG sequence and apply lossless compression? Would this work for other camera models like the Sigma FP? Been looking into SlimRAW www.slimraw.com (http://www.slimraw.com), but realized maybe MLV App can already do this?

Thanks all!
Title: Re: Can MLV App apply lossless DNG compression?
Post by: masc on August 16, 2023, 08:55:17 PM
Quote from: Milk and Coffee on August 16, 2023, 08:40:50 PM
Can MLV App apply lossless compression to already exported cDNGs/Can I reopen a DNG sequence and apply lossless compression? Would this work for other camera models like the Sigma FP? Been looking into SlimRAW www.slimraw.com (http://www.slimraw.com), but realized maybe MLV App can already do this?

Thanks all!
Yes, that should all work. Note: just supported metadata will survive... (not many fields).
Title: Re: Can MLV App apply lossless DNG compression?
Post by: Milk and Coffee on August 18, 2023, 01:30:48 AM
Quote from: masc on August 16, 2023, 08:55:17 PM
Yes, that should all work. Note: just supported metadata will survive... (not many fields).

Great! Any tools/apps to view/edit metadata used on current DNG's? Adobe Bridge?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 18, 2023, 12:38:02 PM
Exiftool?!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on August 22, 2023, 12:02:57 AM
masc, where can I find a list of MLV App's supported metadata fields when exporting lossless cDNG?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 22, 2023, 03:28:50 PM
There is no list, but find kind of a list in this source function.
https://github.com/ilia3101/MLV-App/blob/master/src/dng/dng.c#L454

Line 606 and following should be interesting.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Milk and Coffee on August 23, 2023, 08:21:45 AM
Thank you! What's the process to re-run ding's through MLV App? I cannot seem to import them. 🙏
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on August 23, 2023, 09:31:35 AM
Quote from: Milk and Coffee on August 23, 2023, 08:21:45 AM
Thank you! What's the process to re-run ding's through MLV App? I cannot seem to import them. 🙏
"Import" is not done by MLVApp. raw2mlv converts DNG to MLV, while MLVApp gives a GUI over raw2mlv. Then MLVApp can reexport DNG from MLV.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: essbe on September 22, 2023, 01:05:03 PM
Having a problem right now with exporting cinema dng:s (uncompressed, lossless and fast pass) from the mlvapp. It only exports the first frame, then it stops with the message "Disk full." and then "Disk full. Export aborted.". I have 65gb free on my computer and 250gb on my external disk where the mlv files are. I can export frame by frame to dng ok. All other formats (tiff, h265 etc) are exporting as normal. Any idea what I may be doing wrong?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: essbe on September 22, 2023, 01:06:39 PM
I am using Ubuntu 22.04 by the way, latest version of the MLVapp.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 22, 2023, 07:49:12 PM
https://github.com/ilia3101/MLV-App/issues/256
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: essbe on September 23, 2023, 12:25:00 AM
Thanks!
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: essbe on September 25, 2023, 02:24:07 AM
The DNG-export works perfectly when building from source on Ubuntu 22.04, so my problem is solved by that really. The automatic import of focus pixel maps also works for all modes on the EOS M with that build, something that did not work for me at all for the "anamorphic" modes with the latest appimage. These things considered, would a new appimage for linux be possible?

For me, the 1x3 dng images are not stretched after export. Is that a known fact/problem?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on September 25, 2023, 07:51:53 AM
Nice to hear your build works.

Focus pixel map installation can't work for appImages, because those images are readonly. See in-app-help or wiki:
https://github.com/ilia3101/MLV-App/wiki#fix-focus-dots

Autostretching for exported DNG should work. I guess you tested with Davinci Resolve, which should be one of a few (or the one and only) application not reading the stretch factors from DNG files.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: essbe on September 26, 2023, 02:23:32 AM
Ok, good to know. I did try to install the focus pixel maps manually in the appimage build, but only got them to work with the 1x1 presets. Probably something I did wrong, but this build solves it anyhow. For the dng:s I did actually try a program called rawstudio (it is very fast, so processing a large quantity of dng:s for video is actually doable), but also rawtherapee just to see what it looked like, and neither one had the image stretched. But as they are photo editors, I guess not reading the stretch (if the mlvapp puts such information in the file) is what to expect.
Title: Lens correction via customized ffmpeg parameters?
Post by: scriptmonkey on October 02, 2023, 04:12:28 PM
MLVAPP does not have a correction of the barrel/pincushion distortion. But ffmpeg, used for export, does have high quality filters like v360 which do just that. Adding custom parameters to an export profile in MLVAPP seems to be all that is needed for this and a number of other corrections.

I wonder if it can be done? Directly in MLVAPP or by substituting the ffmpeg executable by a wrapper? I scale down by two when exporting from MLVAPP but evidently a geometric correction like that would be best done on the original, full resolution video.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 06, 2023, 05:14:26 PM
If you're on macOS (and maybe on Linux, not exactly sure here, as I almost never load it on Linux) you are able to create "post export scripts" which can be driven right after export. You could do a script which does this job.
In MLVApp code you can also change the ffmpeg command. That is a little complicated because there are hundreds of combined options. See function startExportPipe in MainWindow. I think it will be hard to use such a correction via ffmpeg, as you can't see what you'll get after exporting. The parameters change with zoom focal lengths, with crops, pans, etc. ... finding the correct parameters for each clip should be very very hard.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: scriptmonkey on October 07, 2023, 07:54:47 PM
Thanks! I changed the code to use FFMPEG's funlens with my lens' model like this:

resizeFilter = QString( "-vf lensfun=make=Canon:model=\"Canon EOS M\":lens_model=\"Samyang 16mm f/2.0 ED AS UMC CS\":focal_length=18:aperture=8,%1scale=in_color_matrix=bt601:out_color_matrix=bt709%2%3 " )
            .arg( moireeFilter )
            .arg( hdrString )
            .arg( vidstabString )

The problem is, I cannot probably put a pipe there, so this command does the rest (filter out noise, sharpen and resize)

ffmpeg -i input.mov -f yuv4mpegpipe -pix_fmt yuv420p - | yuvdenoise -m 4,4,4 -t 4,8,8 -M 3,3,3 | ffmpeg -f yuv4mpegpipe -vcodec rawvideo -i - -vf unsharp=luma_msize_x=5:luma_msize_y=5:luma_amount=4.5,scale=w=2088:h=1104 -c:v libx264 -preset ultrafast -qp 0 -y output.mp4

I did not use export's resize option, at it would downscale everything before the geometry and noise filters. So unnecessarily large files are still written to disk. I also did not use MLV app's own sharpen, as it would be before denoise.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 07, 2023, 08:14:30 PM
Interesting. But some questions for this:
- does Lensfun understand "EOS M" + a "16mm" lens at focal length 18?
- did you check the export if distortions are correct after export?
- you used a speedbooster? This adds additional distortion. The export is really correct?
- did you use a ML setting with full sensor? At least full sensor width? Is the vertically used area exactly centered? Otherwise this also should not work, I bet.

If you use the post export scripts, you could delete files after processing. So MLVApp pipes to a first intermediate export file. Then the script is started, does the additional stuff and deletes the first file. So the needed disk space should not be much.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: scriptmonkey on October 08, 2023, 01:16:07 PM
Quote from: masc on October 07, 2023, 08:14:30 PM
Interesting. But some questions for this:
- does Lensfun understand "EOS M" + a "16mm" lens at focal length 18?

It's my typo. Lensfun probably ignores the focal length for non-zooms entirely.

Quote from: masc on October 07, 2023, 08:14:30 PM
- did you check the export if distortions are correct after export?

Yes, it seemed visually perfect despite the barrel distortion in that lens being somewhat complex.

Quote from: masc on October 07, 2023, 08:14:30 PM
- you used a speedbooster? This adds additional distortion. The export is really correct?

I don't but the additional distortion can be handled separately. You can add to FFMPEG's -vf chain one more filter and that would add to funlens. There are a number of geometry correction filters in FFMPEG, but the subpixel quality varies.

Quote from: masc on October 07, 2023, 08:14:30 PM
- did you use a ML setting with full sensor? At least full sensor width? Is the vertically used area exactly centered? Otherwise this also should not work, I bet.

I used an almost 1.6-crop mode. Otherwise, lensfun has all that you asked for https://lensfun.github.io/manual/v0.3.2/el_lens.html but it seems, not all is accessible via ffmpeg. So some (likely easy) code would need to be contributed to ffmpeg.

Quote from: masc on October 07, 2023, 08:14:30 PM
If you use the post export scripts, you could delete files after processing. So MLVApp pipes to a first intermediate export file. Then the script is started, does the additional stuff and deletes the first file. So the needed disk space should not be much.

Yes, but I had already some problems with dying disks in the pasts ;)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: scriptmonkey on October 08, 2023, 01:16:23 PM
If only MLV app had a tab for lensfun parameters, a flow of arcane lens info would start to flow into their database. Mysteriously centered around the ef-m mount ;)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on October 10, 2023, 08:14:50 PM
If someone knows how lensfun library works in detail, I'd really like to add this directly to MLVApp. Until now the docs were too hard for me :P
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: scriptmonkey on October 11, 2023, 07:57:48 PM
I do not know, but maybe the respective code from ffmpeg would help: https://github.com/FFmpeg/FFmpeg/blob/f31d0f11417067a3fc9d53085c32f4ba82b252e4/libavfilter/vf_lensfun.c#L90
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on October 31, 2023, 09:36:36 PM
Finally found the time to compile an up-to-date version for Mac Intel.
Link here (https://www.icloud.com/iclouddrive/08bkSIeB7yzrT5KnKWilvO10g#MLVApp.620d7c8.2023.Aug.22.OSX.x86.QT6.6.0).

Ciao
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Teamsleepkid on November 06, 2023, 07:16:24 AM
Can you output to prores raw? Would be kinda cool..
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 06, 2023, 08:48:16 AM
Quote from: Teamsleepkid on November 06, 2023, 07:16:24 AM
Can you output to prores raw? Would be kinda cool..
No problem, if there is a library (best C/C++) which supports encoding. I did not hear about one yet.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on November 23, 2023, 09:56:36 PM
is mlvapp intrinsically 14bit? or 12 bit?
i read somewhere resolve free version is 8 bit.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 24, 2023, 06:20:07 AM
MLVApp is 16bit, DualISO 20bit.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: a.sintes on November 24, 2023, 07:57:30 AM
@mlrocks DaVinci Resolve engine (both free & studio version) works internally using 32bits float (single precision GPU float value).
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on November 24, 2023, 08:31:55 PM
Quote from: masc on November 24, 2023, 06:20:07 AM
MLVApp is 16bit, DualISO 20bit.

thank you, masc. probably this is why mlvapp has better color than resolve free version.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on November 24, 2023, 08:32:59 PM
Quote from: a.sintes on November 24, 2023, 07:57:30 AM
@mlrocks DaVinci Resolve engine (both free & studio version) works internally using 32bits float (single precision GPU float value).

why do someone say the free version is only 8 bit?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on November 24, 2023, 10:20:54 PM
Quote from: mlrocks on November 24, 2023, 08:31:55 PM
thank you, masc. probably this is why mlvapp has better color than resolve free version.
Good color has also other reasons than just a bitdepth. Low bitdepth might bring banding into the footage.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: a.sintes on November 25, 2023, 10:17:04 AM
Quote from: mlrocks on November 24, 2023, 08:32:59 PM
why do someone say the free version is only 8 bit?

People usually say a lot of shit on the Internet :)
Free & Studio version of Resolve relies over the same GPU engine, Studio just got more available advanced features.
As explained by @masc, an 8-bits engine will imply very visible banding issues.

Don't get how MLVApp would have "better color" than Resolve in the end, a 14-bits integer bit depth footage fit perfectly in 32-bits float without any loss, and we're talking here about one of the most renowned color-grading software with bullet-proof color science (DaVinci Wide Gamut & ACES colorspaces etc.), so eventually the only weak point may be the RAW (DNG) debayering algorithm (personally prefer the one used by Adobe in CameraRaw) but the differences are quite indistinguishable...
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on November 25, 2023, 04:31:56 PM
Quote from: a.sintes on November 25, 2023, 10:17:04 AM
People usually say a lot of shit on the Internet :)
Free & Studio version of Resolve relies over the same GPU engine, Studio just got more available advanced features.
As explained by @masc, an 8-bits engine will imply very visible banding issues.

Don't get how MLVApp would have "better color" than Resolve in the end, a 14-bits integer bit depth footage fit perfectly in 32-bits float without any loss, and we're talking here about one of the most renowned color-grading software with bullet-proof color science (DaVinci Wide Gamut & ACES colorspaces etc.), so eventually the only weak point may be the RAW (DNG) debayering algorithm (personally prefer the one used by Adobe in CameraRaw) but the differences are quite indistinguishable...

thanks for the good explanation.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: kob on December 10, 2023, 03:11:59 AM
Is there a volume control? A mute would be great.

I have tons of clips with wind.
Can't hit play without distorting my speakers when im working.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on December 10, 2023, 11:18:19 AM
@kob: Uncheck Audio Output from Playback menu.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on January 07, 2024, 05:52:39 PM
Sorry, I'm pretty sure this must have been discussed here at some point in time.

However, I compared MLV -> cDNG conversion with MLV App and MLVFS, and found out that
* which is the speed at which I could copy DNG files from the MLVFS mounted virtual drive to my physical drive.

NB: of course test export was performed starting from the same MLV file (3584 x 1500, 23.976 fps, 14 bit lossless, 119 MB/s), in both cases being exported on the same (ultra-fast NVMe) hard drive.

Thanks

S
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 25, 2024, 05:56:59 PM
Just an open question: On the transformation menu, there are options for width and height stretch.
A height stretch of 0.33x is used for the 1x3 modes, but instead of setting 1/3rd of the height, it is actually setting 3x the width. So height stretch is not actually stretching height, but width.

Shouldn't this be fixed so it's possible to set a 3x width stretch (currently missing, maxing out at 2x), but also a 0.33x height to leave the width alone and just benefit from the lower noise and reduced aliasing by adjusting the vertical resolution?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 25, 2024, 07:03:29 PM
It was an important design decission in the old days. And it was not easy to do this magic. We can change the labels if you like: first box is for anamorphic lenses, while second box is for digital ML stretch. If you were able to stretch width at 3.0x, you're forbidden to use anamorphic lenses at the same time, while 2nd box will probably never be used. There is also no 3.0x anamorphic lens (as far as I know), so this option doesn't exist. If we would downscale the height, you would never see the additional details in 1x3 footage over 3x3. If you however want to downscale for the export, use the export settings dialog. So I think there is nothing to fix - this is as it was intended to work.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on January 25, 2024, 07:46:39 PM
Quote from: masc on January 25, 2024, 07:03:29 PM
It was an important design decission in the old days. And it was not easy to do this magic. We can change the labels if you like: first box is for anamorphic lenses, while second box is for digital ML stretch. If you were able to stretch width at 3.0x, you're forbidden to use anamorphic lenses at the same time, while 2nd box will probably never be used. There is also no 3.0x anamorphic lens (as far as I know), so this option doesn't exist. If we would downscale the height, you would never see the additional details in 1x3 footage over 3x3. If you however want to downscale for the export, use the export settings dialog. So I think there is nothing to fix - this is as it was intended to work.

If it was intended, then I have nothing to say.

But regarding your comment about not seeing additional details over 3x3 by scaling down, if the scaling algorithm is good, you will get added detail (oversampling), reduced noise, and of course much less aliasing artifacts than on 3x3 mode.
The problem with downscaling on export is that you never get to see the final image at a 100% while editing (final meaning scaled down), and the frame buffer is larger, so playback and editing are also slower.
For these reasons I end up always exporting to CDNG and doing all the color corrections in resolve for 1x3 clips
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 25, 2024, 08:50:47 PM
Correct: you never saw the clip in the final size before export. (by standard.)
Wrong: the frame buffer is the same and the playback and editing is also the same speed. There is no reason making it faster. You must always process the entire picture first. The scaling is not that slow and viewer itself is by far faster than a video frame rate - at least on modern computers (you feel a big difference on Core2Duo). You can also drag the window to the "right size". Then you see the final size before export - if that is so important.
On encoding the entire sharpness changes anyways. Also with Davinci.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on January 29, 2024, 12:38:07 AM
i did some 5.2k 1x3 footage on 100d. i use mlvapp to export cdng, none of the options do stretching. is there a way to stretch in mlvapp and then export to cdng? if not, i am going to do prores444 as usual. thx.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 29, 2024, 06:50:56 AM
MLVApp also stretches cDNG (by metadata). Probably your used NLE/viewer/... is not able to read cDNG metadata completely.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on January 29, 2024, 04:09:40 PM
Quote from: masc on January 29, 2024, 06:50:56 AM
MLVApp also stretches cDNG (by metadata). Probably your used NLE/viewer/... is not able to read cDNG metadata completely.

I use resolve 18, and it cannot stretch. thx for the explanation. will try later.

I also notice that there are red focusing pixels on 100d footage. I use 5x5 chroma smoothing getting rid of these. maybe the map for 100d is not ready?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on January 30, 2024, 09:25:20 AM
Resolve is known to not read and use those cDNG metadata - whyever. Stretch manually.

I don't have a 100D. Please send a MLV clip with just a few frames and I can try to create the map.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: mlrocks on February 04, 2024, 12:18:42 PM
how to send the mlv file on this forum? thx for the help.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 04, 2024, 12:38:37 PM
Use any filehoster.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 19, 2024, 06:28:51 PM
Hello, I tested Danne's magiclantern-crop_mood.2024Feb18_Custom.EOSM202.zip and ran into the following issue:
MLVApp 1.14, official build.
OSX 10.13.6

If I load a clip I just recorded using the new 1920x1080p preset, without the focus pixel map installed, the clip opens fine (With the focus dots showing).

If I shutdown MLV APP, Install the new 80000331_1992x1109.fpm; when I launch the app and open any 1920x1080p clip, I get a beach ball and I need to force-quit (I'm on OSX).

If I launch the app again, but load a 2.8k clip this time, all is well.

If I shutdown MLVApp, remove the 80000331_1992x1109.fpm file, relaunch and load a 1920x1080p Clip, the clip opens fine again.

In any case, as long as I load any previously recorded clip at a resolution other 1920x1080p, it works without a problem.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Frank7D on February 19, 2024, 06:44:18 PM
How does one create a focus pixel map for a particular camera model and picture size? I'm asking because I need a 1920x1080 1x1 map for 650D.

Edit: Following a tip, I renamed 80000301_1992x1308.fpm to 80000301_1992x1109.fpm and installed it in MLV App and it seems to work.

Also, if anyone needs to make a focus pixel map, here's dfort's tutorial: https://www.magiclantern.fm/forum/index.php?topic=16054.msg227720#msg227720
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 19, 2024, 07:59:54 PM
Quote from: gabriielangel on February 19, 2024, 06:28:51 PM
Hello, I tested Danne's magiclantern-crop_mood.2024Feb18_Custom.EOSM202.zip and ran into the following issue:
MLVApp 1.14, official build.
OSX 10.13.6

If I load a clip I just recorded using the new 1920x1080p preset, without the focus pixel map installed, the clip opens fine (With the focus dots showing).

If I shutdown MLV APP, Install the new 80000331_1992x1109.fpm; when I launch the app and open any 1920x1080p clip, I get a beach ball and I need to force-quit (I'm on OSX).

If I launch the app again, but load a 2.8k clip this time, all is well.

If I shutdown MLVApp, remove the 80000331_1992x1109.fpm file, relaunch and load a 1920x1080p Clip, the clip opens fine again.

In any case, as long as I load any previously recorded clip at a resolution other 1920x1080p, it works without a problem.
Could you please upload this clip, or at least some frames of it? (In the "hope" this also happens for the shortend clip.)
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 19, 2024, 10:00:30 PM
Here is the complete file: https://bit.ly/3wk4LNU
Thanks.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: ML700D on February 20, 2024, 04:52:43 AM
Quote from: gabriielangel on February 19, 2024, 10:00:30 PM
Here is the complete file: https://bit.ly/3wk4LNU
Thanks.

it's fine, no issue on windows..
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 20, 2024, 06:51:19 AM
Quote from: gabriielangel on February 19, 2024, 10:00:30 PM
Here is the complete file: https://bit.ly/3wk4LNU
Thanks.
Here also: no problems. I can open, auto download the map. Afterwards the clips is shown immediately and the focus dots are removed. Clicking focus pixel fix to OFF makes the dots visible.
macOS BigSur, Apple M1.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 20, 2024, 07:46:45 AM
Check built in console while program is crashing for hints.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: gabriielangel on February 20, 2024, 03:28:05 PM
Quote from: Danne on February 20, 2024, 07:46:45 AM
Check built in console while program is crashing for hints.

WIll have to do more investigation on my end then.
How do I display the console?
Are you guys using the MLVApp version downloaded from the official site, or the runner on the GitHub page?(That one won't run on my machine, OS too old I think)
Could you try the pixel map I downloaded: https://bit.ly/4bKWy5C
(To make sure the error doesn't happen when downloading the file manually)

EDIT: It's because I downloaded the individual pixel map file manually. I just downloaded the whole MLVApp Code .zip file and got the pixel map from there. It works as expected now.
Maybe someone can have a look at the pixel file I downloaded individually (Linked above) to figure out what went wrong.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: masc on February 20, 2024, 08:19:20 PM
Haha... yes... found the problem! The file you downloaded is not a pixelmap - it has just the name of a pixelmap. You need to download using the "raw" button in github, else you get a webpage, maybe with the name of the file you wanted to load. In the end it looks MLVApp is kind of confused when trying to load this false pixel map.  :P :D If you open the files with any text editor, you'll see what I mean.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on February 23, 2024, 09:57:32 AM
Experiencing wired behavior with Vertical Stripes on 5D3 with Danne's anamorphic 1x3 preset (FWIW, running asintes' 2023Sep01 build for 1.23).

Low-light scene with ISO 1600, exporting to DNG and grading in DVR, I get


Re-tested with Dark Frame subtraction enabled => same results.

Just wondering if there is some known reason for this.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 23, 2024, 11:29:23 AM
Could you test exporting to dang also with this app?
https://bitbucket.org/Dannephoto/switch_mini-git/downloads/Switch_mini.dmg

There are a few different codebases out there with vertical stripes correction, not all is working perfect
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: vastunghia on February 23, 2024, 02:50:16 PM
Tested both with default settings and turning correction off, looks fine.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Walter Schulz on February 27, 2024, 08:04:36 AM
Any metrics/benchmarks for Dual-ISO footage in 2160x1080 (1x1) conversion to medium quality H.264? OP (on discord) got about 90 minutes for 10 minute footage.
SSD, AMD 7745HX and according to OP no thermal throtteling.
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 27, 2024, 11:30:45 AM
Quote from: Walter Schulz on February 27, 2024, 08:04:36 AMAny metrics/benchmarks for Dual-ISO footage in 2160x1080 (1x1) conversion to medium quality H.264? OP (on discord) got about 90 minutes for 10 minute footage.
SSD, AMD 7745HX and according to OP no thermal throtteling.

Could you/OP please try this build (https://mega.nz/file/I51jxYQB#oDmGLxasZ8Ry24E2XK_HqJMqGPgkcN_71XFe6nomRC0) and post your results?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 27, 2024, 02:03:24 PM
Would be nice to go over above build so it can get merged into master branch. What is needed?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 27, 2024, 03:31:31 PM
Quote from: Danne on February 27, 2024, 02:03:24 PMWould be nice to go over above build so it can get merged into master branch. What is needed?

cdric introduced a fix for the flickering in dual iso, but it was corrupting the exported video.
Tried to contact him but no answer.
I removed some bits of his code to get the export working, but ideally it should be fixed instead of partially removed, or removed completely.
We never merged the optimization because I got feedback asking for more testing, but didn't have much success when I look for testers  :-\
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 27, 2024, 03:56:25 PM
What kinds of tests and what fixes  8)? I remember It started out with some good results then it got a bit messy on the way? We need test files for sure. Then some way to test code in smaller steps.
How about yourself. Are you using dualiso a lot?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 27, 2024, 04:08:01 PM
Fix his code, that looked good while editing but not when exporting, and then test with all the supported cams and recording modes, focusing on Dual ISO clips.
I would narrow the test clips to those recorded with the latest versions of ML, otherwise it might be too much...
I have many old test clips that hopefully will cover old versions.

I'm using dual iso a lot when recording in 3x1 mode, but lately I lean more towards the 1620p 1x1 mode. Dual iso has too many artifacts in any other mode but 3x1 in my opinion
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: Danne on February 27, 2024, 07:21:00 PM
But you were working on this before right, or am I remembering incorrectly?
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: iaburn on February 27, 2024, 09:02:48 PM
Only on the multi core for dual ISO, but then cedricp added a fix for the flicker. I think masc made the interface changes, so it took some work and it's useful, I'll take a look and see if I find the problem
Title: Re: MLV App 1.14 - All in one MLV Video Post Processing App [Windows, Mac and Linux]
Post by: TKez on March 13, 2024, 11:44:52 AM
Just checking back here after many years. Do we have a way yet within MLV App to include our own DCP transform?

Personally I'm still a big fan of the Cinelog workflow.
On a mac, a Prores 4444 plays/srubs at lightning speed compared to DNG or compressed formats, and it effectively stores anything you could want from the 14 bits coming off the sensor in practice.
Not to mention the file size benefits.

Batch processing an sdcard full off MLVs into prores 4444 Cinelog with a few clicks would be a dream.